MAC address parsing

There was no MAC address parsing process from uri.
and checking a address validity neither.

Change-Id: I12476caf7a42c9d95a6613566ad50034ccb57d08
Signed-off-by: jaewook jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4013
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Optimization for EDR and LE adapter

In EDR and LE adapter, a request can't be differentiated as unicast or multicast.
Hence when a multicast request was received in EDR or LE adapter,
a error response was sent which could have been ignored.
Especially in Hetrogenous network, we received many responses with payload
NULL for a multicast request.  Hence as an optimization, we are blocking the
error response for EDR and LE adapters.

Change-Id: Ie3766115e8b89e21c760ec8232ebd74d73fc39c0
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4029
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

added to call unregisterReceiver for Android BT/BLE.

there was no method to call unregisterReceiver.

Change-Id: I7ceb5bc73d4a25a1e93cbbf6e3e167c0d9f5c98f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4047
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Modified preprocessor for headers of RI layer

Change-Id: I8639f3627f58ef8abd3200b3ac059807e6cbe55f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4273
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Set transport flag according to adapter type in CA Sample

transportflag is always set with CA_IPV4.
so I fixed CA Sample to set the flag according to transport adapter.

Change-Id: I1bc7a86a193355365b2602d88130405e8c7ab187
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4263
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[IOT-830] Added remove API for all credentials on |credresource|

added all credentials remove API for iotivity client with provisioning
feature. considering commercialization, iotivity client needs not only to
reset SVR data, e.g. doxm, acl and cred resources, but also to remove only
all credential data for its owned servers. for the former case legacy API(s)
could be supported but for the latter case additional API is needed.
the added API for this supports to remove all credentials and update
persistent storage in running iotivity client.
Jira-issue: https://jira.iotivity.org/browse/IOT-830

Change-Id: Icb41023f9acb6498c96e2b089a73daf4f39dd354
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4147
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[IOT-829] Updated |CT_FLAG_SECURE| support on |PMGenerateQuery| API

fixed |PMGenerateQuery| API in inputting |connType| with |CT_FLAG_SECURE|
Jira-issue: https://jira.iotivity.org/browse/IOT-829

Change-Id: Ib82e4a4ad10c84aef03de31ef81e5a25b9e1bc20
Signed-off-by: Kyungsun Cho <goodsun.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[ARDUINO][BLE] Enable Arduino BLE support in RI sample

Change-Id: Ie326dca25edbfea638e5fea718ad0802224e4c39
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3807
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Changed the logic to add option list in pdu.

resource uri has become null when CASendResponse API use
large payload. because we failed to add option in pdu.
so we fixed the code to add all option normally.

Change-Id: I9e25421793879020ccc0695b9c2642f18fd5e8d2
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3811
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[IOT-839] Ensure correct map size when serializing rep payload

type & interface map size was hardcoded as two, which broke representation
deserialization when only one of type or interface was present.

Change-Id: I8356fc4ae80f649163d093adbac3cae49cac1cff
Signed-off-by: Erkka Kääriä <erkka.kaaria@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

modified the wrong variable identifier in messagehandler.

gReceiveThread was deleted in messagehandler.
but in the case of 'ifndef SINGLE_HANDLE',
we use gReceiveThread still. so I modified the variable name.

Change-Id: I99cb0ae5b6edebc772adf94790f3c3ddde2d8c78
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3997
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Android: Removed CAInitialize() call from the CA initializer.

The early initialization call has prevented a proper propagation of the
configuration parameters into CA from ocstack.c. Therefore, IPv6 mode
was not available on Android.

Change-Id: Id90a1eb288ef80f08068113da2967e9ba0989483
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added message format error logic for EMPTY message.

According to CoAP spec(RFC 7252), Empty message has
the token length field set to Zero.
and bytes of data MUST NOT be present after the MessageID field.
If there are any bytes, they MUST be preocessed as a message
format error.

Change-Id: I1709143c9aa1851c428bbcce08d28c2d0534b89c
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3797
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

changed default transport type on android platform

if there is no trasport option from command line,
all transport should be enabled on android platform.

Change-Id: I78e7e3c0d7473f711db67a388d9ea0bbd5908587
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4135
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Temp. fix for the IOT-826

Change-Id: Iacd88a29e5705604b377a5bcf90ee5685dcef6c7
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4071
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

removed unnecessary log for Android BLE

since the log is occured continually,
there are some obstruction to analyze.
thru, it is better to remove it.

Change-Id: I211ad748f3689bdd855089cde4a388cc12f7fc82
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4027
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

things-manager: Updated doxygen comments for things-manager.

Updated and fixed some issues w.r.t doxygen comments in things-manager dir.

Change-Id: I3b872c2720f7723fd84c9f317c60f7785906806f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3841
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix for JIRA issue IOT-599.

- This patch include changes to install the public libraries in ${libdir} and all
public headers in ${includedir}.
- As of now, the iotivitiy.pc.in file refers to resource C and C++ SDK related libraries only.
- If required, the services related public libraries need to segregated into a different .pc.in
file.

Change-Id: Ie110db76900c29534f6bc36dc9e2424f71e9f71f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Multiple EDR connection in Tizen

To support multiple EDR connection, the multicast data will be
added to an arraylist and as on when a device is discovered,
the data will be sent.  Once the discovery is finished, the data
will be removed from the arraylist.
Also the current implementation does discovery during initialization alone,
with this commit discovery will be done everytime when a multicast data
is sent.

Change-Id: I6bedb72ab716b828244d79f6f54bdaa4c8005b2f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3625
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Coap over TCP support for Tizen

Tizen platform can be supported for coap over TCP

Change-Id: I8731181e3eac716b39ec40350df24d9c7fd03f74
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed issues reported by Prevent static analysis tool

Fix issues in CA and Routing manager reported by Prevent tool

Change-Id: I855181fa12e8e8b483f48c071fa6e12de9b94c2c
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3857
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Simplified OICGetCurrentTime() implementation.

Restructured the OICGetCurrentTime() implementation to remove two
unnecessary variables.  This allows us to drop a run-time conditional
in the _POSIX_MONOTONIC_CLOCK == 0 case, as well as fix an "unused
variable" compile-time warning.  Include directives were also cleaned
up to the minimum needed.

Change-Id: I8f478c08310a74ad642aad5b45f9fc3310b102de
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4249
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

To Enable empty token for CoAP

since token can be used 0~8 byte by spec.
to check null token should be removed.

Change-Id: I0e3b6a605e647206e9f886c9f7e406b6ea6e5288
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

[JIRA-IOT 722] Removed deprecated socket functions and updated inet_ntop() instead of snprintf()

Change-Id: I1efa2129728386728bcee0f3d0859c7343b4fd8f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3795
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

resource-container: add method to manually send a notification

When I am setting more than one attribute at a time I only want to send one
notification after all the attributes have been set. This change makes it
possible to send the notification at the end.

Change-Id: I8a4825edab97b92041a67a8cdf57f9a6fd832f3b
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4207
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung85@gmail.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Replaced hard-coded uri to discovered uri for GET/PUT in occlient.cpp

occlient.cpp always made GET PUT requests on /a/light as ocserver was
built with /a/light.
Changed this to make requests to discovered resources to enable easier
testing for test engineers.

Change-Id: I642b1d83e46f91d92270d414dda933b6cf97240e
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2721
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Resolved Tizen RI sample build error for SECURED=1 and enabled build in Jenkins

Change-Id: Ide348722046cb4dcf962f7652b6a5f19794d5b83
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3259
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed implicit declaration warning about OCSeedRandom() function.

Change-Id: I092496ed7dc0828cb4ec183426eedecb9c651458
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4247
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix payload logging related compile-time warnings.

Corrected format specifier for size_t typed value (%lld -> %zu).
Removed duplicate UUID_LENGTH definition.

Change-Id: Ia142247346cccbadea3a3c51d8e6f55af575c6ff
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Placed  OC random functionality at common place for RI and CA to use

Moved OC random implementation to c_common folder to make it available for CA as well. As Seed Random should be called at common place for RI and CA.

Change-Id: I0a7cd674b9c4212b3a1d1e382aa1f455bec1a6d2
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4101
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Expose PISetup() API in Plugin Interface.

This puts the onus on the application layer to perform discovery
operations for their radio(s).  This way the discovery operations can be
triggered via the appropriate actions for the application.

Change-Id: If5140b436159c74260dc30ac3d33401e62478b25
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3779
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Add message length validation check code in case of wrong key

[Patch #1] Intial upload
[Patch #2] Modify according to comments.
[Patch #3] Retrigger
[Patch #4] Retrigger again!

Change-Id: I90e38f950aa07dafd058cf88591ef8f5af5ca367
Signed-off-by: leechul <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4189
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[PLUGIN-INTERFACE] Delete resources when a request has failed.

This will allow for the Plugin-Interface module to delete resources which
are no longer properly mapped.

Change-Id: I7a3f0022b49aa6ebdae016b7f416df2ced0952d7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Thuyen Tran <thuyen.c.tran@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3791
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Collection resource support in SDK and Plug-in.

- Managing life cycle of collection resource.
- Supporting all types of attribute value in SimulatorResourceModel as supported in
  OCRepresentation.
- Updated unit test cases.

JIRA: https://jira.iotivity.org/browse/IOT-836

Change-Id: Iba01f46477155adad64e69dec9cda192405b09ee
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4209
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

resource-container: make registerResource() return status code

With this patch the calling application gets informed if the resource was
successfully actually registered.

Change-Id: I6f735379d7518d094c899444a6cedff18871b6f3
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4205
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[IOT-825] Explicit discovery to get secure port during provisioning

Issue : If provisiong candidate device doedn't have any secure resource,
        Provisioning Tool can't get secure port.
Solution : In order to get secure port, try explicit discovery
           with /oic/res?rt=oic.sec.doxm. instead of /oic/res
Related jira : https://jira.iotivity.org/browse/IOT-825

[Patch-2] : apply Sachin's comment

Change-Id: I6d6986f64af7ef24dd28ebada477613f30ee1e04
Signed-off-by: js126.lee <js126.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4131
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

remove a preprocessor for TCP_ADAPTER in RI.

since there is a preprocessor for TCP_ADAPTER in RI.
when user is using a interface file(octype.h)
user application have to add -DTCP_ADAPTER flag in their App.

since CA already check TCP_ADAPTER flag,
it is better to remove this preprocessor in RI.

Change-Id: I8dd2998831d9744e25e68c024b2b3e3fbbbc1633
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Added to call unregister for Android IP

Change-Id: I7e6ae3220955ae0314ce03807530f5cdbb912166
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4095
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fix for IOT-813

Change-Id: Ifd4692074430e45b935e0b9c6b6fa4b41a9951f0
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3901
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Add unittests for ConstructResourceTest for invalid port number

Added a test case for ConstructResourceTest to simulate the scenario
of Resource creation with missing port number.

Change-Id: I0e159df4c1441271bd2c414ed6b94605fc6ab3ac
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4105
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Enabled callback message for retransmission timeout.

if retransmission time is over,
ACK/EMPTY message should be sent into routing manager without token.

Change-Id: I1cffb4d3d9064c7b8b6772fcf515b922576951d2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4109
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Changed operator T enable_if to be more closely linked to the variant

The link between the variant and the enable_if needs to be strong!
Previously, there was no direct link, just one by 'coincidence'.  This
patch introduces a pair of type traits that bind the enable_if directly
to the variant.  Note that the type traits also work with ANY variadic
type!

Change-Id: Ie5f8fbc92b4f6800625c58fd73c08bedf147f122
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4021
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Correct a wrong memory free in construction of aggregate response

When an aggregate response is freed after sending it, only head response which
has a pointer of next response of the aggregate response is freed, not all
the linked responses, which might lead a wrong memory access after it.
For this reason, OCPayloadDestroy function is better to be used than
OICFree function in DeleteServerResponse function.
Additionally, I've often observed that ehResponse->payload is freed somewhere
, which the pointer becomes NULL. To overcome this exceptional situation, I
copies ehResponse->payload to a new payload data with OCRepPayloadClone
function and safely frees it when it has to be freed.

Change-Id: Ide42346b6ce4858b2587795db29b36027793a077
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add OCProvisioningManager.h into Doxyfile to generate C++ API doc.

Change-Id: Ide9bc08bb194b8909dfd2ff7407e6e09c3867b94
Signed-off-by: Woochul Shim <woochul.shim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3757
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Change occlient to cancel observe on every registration.

In the case when there are multiple servers, occlient sends out observer
requests to all of them. On reaching 15 notifications, only one of the
observation registrations were cancelled.
As the handle for cancellation was maintained in a global variable, none
of the others were cancelled and the client continued to get
notifications and this led to some failed tests.
Changed client behavior to cancel observe wit the handle present in the
response.

This can be cherry-picked to 1.0.0-dev

Change-Id: I51d28620b140dbb4f28baef7aa3be93276f6de5f
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3535
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

tinydtls: use types from inittype.h, fix musl libc

The SHA2 code currently uses u_int32_t and similar types without
defining them. This type is not defined by the POSIX standard, but many
libc implementations have it as a non standard extension. In the musl
libc it is not implemented and I am getting a compile error when using
u_int32_t, I should use uint32_t, which is done when
SHA2_USE_INTTYPES_H is set.

This fixes build with musl libs used in OpenWrt.

Change-Id: I485435ddb8b1a2359caedd335ab54f91ca5e3f3e
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3953
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Add ByteString support in CBOR wrapper in OIC stack

Currently byte strings in CBOR wrapper are achieved by using
int arrays. Drawbacks with this approach is in-efficient memory
consumption and 3rd Party tools cannot properly decode the CBOR
generated in this fashion.

Updated code in CBOR wrapper and also added unit tests.

Change-Id: I4ed1adc891be84e800c833df404914a335150ded
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2337
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Removing unwanted files

Removing unwanted files related to logging from resource dir

Change-Id: Ia550d754347f1dc45d00e43b9f95f2aa9f8cff1f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Fixed MAC key issue in AES-CBC cipher suite in tinyDTLS

There are couple of issues in current AES-CBC cipher-suite implementation.
1) Using the wrong data encryption/decryption key.
2) Using the wrong MAC Key for MAC calculation.
The reason for this is that the macros which point to the key location
in the key block were designed for AES-CCM cipher suites.

Change-Id: I410175302a2f23d1fa64f2b15b774c48d4ec19b3
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3441
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix format used in OIC_LOG_V

There was wrong format used for int64_t variable.

Change-Id: I52a1887600d0f004fcea2081058872f684572431
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3825
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add logs in android sample of resource encapsulation

Change-Id: I684601e36f6e55101e3385c4acfd0d1404a1fefa
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3933
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Fix issues of RCSResourceObject

Fix data race for handlers with shared_ptr which has guaranteed atomic operations for setting and loading.
LockGuard's destructor is now noexcept(false) and it will emit an exception if and only if the destruction is not caused by stack unwinding.
Some minor issues of the test are fixed.

Change-Id: I12ccb6adb4849642d266f7af5b1e28a2f6d35f83
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3929
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Fix warning and format

There is wrong format used for types in OIC_LOG_V. Also fixes for the unsed parameters

Change-Id: Ib99c196721877b30b7bc28b673e4734b7378c7b9
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3833
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Implemented OICGetCurrentTime.

Consolidated the functionality for getting current time in
milli or micro seconds as multiple implementation of the
functionality currently exist in the stack.

Change-Id: I79b786ace762012305e487f820bb25f3e1599706
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3239
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Refactoring resource-encapsulation linux examples

Duplicated settings in sconscript for each sample are removed.
And NestedAttributes samples are renamed.

Change-Id: Id0d675155cc85e737bd534c7922b80227a8ff6d6
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fixed bug IOT-798

IsRequestWithinValidTime in iotvticalendar.c was only checking for the
valid date when recurrence was NULL. Update the IsRequestWithinValidTime
function to check for both valid date and time.

Change-Id: Ifec7520f07958fd7ded36c017c0b08acd3053ff0
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3881
Reviewed-by: Mark Tung <mark.y.tung@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

fix many format errors

This fixes lots of format errors.
1. sometimes there were more arguments given when placeholders in the
   format string, sometimes it was the other way around
2. often size_t was not correctly printed
3. uint64_t and similar variables where often printed wrong

The #define __STDC_FORMAT_MACROS is needed to get the placeholders for
uint64_t and similar variables also in C++.

Change-Id: Ibf3724100fa9d62f7b0cb17201c79a44a30a7f72
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3383
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Refine toString method of RCSResourceAttributes

Nested values were not corretly encoded, they were just described with their type names.
Now it encodes every attribute value including nested olnes.

Change-Id: Ia228a34e6df05ac05c509012afd7f026c0f253e0
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3907
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fixed bug IOT-791

Fixed seg fault caused by error handling conditions in function
AmsMgrAclReqCallback while trying to access uninitialized
amsMgrContext field in PEContext.

Change-Id: I65d3d76fc476f848a82e606f5f7f2a2bb3540935
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3511
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

[IOT-803] Fix RD response

The RD response was not being generated due to missing changes in SConscript. Setting the flag, leads to compiling of relevant RD code.

Change-Id: Ic79f5dd316863a261bf6c2452c7fc14bf317a8e7
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3897
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for IOT-808
-Also updated things manager sample application for tizen.

Change-Id: I3d13e253831f480b2bab3831733469beae369a09
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3893
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fixed issues in resource encapsulation

Minor updates that results in compilation due to wrong type used in OIC_LOG_V.
Includes changing type in DataCache which compares unsigned int to int.

Change-Id: I20bb821c02510881251fefd6829fa71b233b863c
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3821
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Resource Client tizen sample applications UI updated.

Change-Id: I122d11e4f055432ff59f8c42f2689afeaa6ac8e5
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix compilation issue in security module

Fixed types used for OIC_LOG_V were not correct.
Fixed tmp variables used under the flag to be declared under the flag.

Change-Id: I78a38d7fa89d56b7c350b2144c9916e55dff9c10
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3819
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Removed unused static function for fixing compilation warning

Change-Id: I43d482790534b6b4903715cf93f902816355be1c
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3831
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix compilation issues in bt utils

There were parameters missing in OIC_LOG_V.

Change-Id: I175515eedaf54a097fce3a0277f082c542520915
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3823
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>

Fix coverity and compilation warning

Few variable unused and fix issues raised in coverity.

Change-Id: I345549de0132c8e3fe350365b2edce128fe3e18a
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3829
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Add exception handling logic in things configuration

When calling constructResourceObject, it probably throws an exception.
To avoid a sudden crash for it, we add exception handling to it.

Additionaly, in oicgroup file, there is a condition statement which
may lead wrong way from what we expect. Thus we remove it.

Change-Id: Ibc12cd261ca875738446ad3b10b199ae15497654
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3865
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for Update Frequency for both RECURRENT and NORMAL type of an resource is not working properly (IOT-801)

Change-Id: If802f56c76e24469d5ddfa0fe588d18f2d0d5c7d
Signed-off-by: spurthi.segu <spurthi.segu@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3859
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Resource Container - Global variable name changes to avoid crash in TIZEN.

Change-Id: I19075bd3a1dbea9cfbd81193cc26b6830e8ba669
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3851
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Markus Jung <markus.jung@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix warning due to mismatch in format

Arguments passed in OIC_LOG_V were not  matching the format used for printing.

Change-Id: I8dd5ffc35f0f0ad1e23d0a03ff118cc865005384
Signed-off-by: Habib Virji <habib.virji@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3827
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Code cleanup, Junit fixes and updated Junit test cases for Simulator.

Change-Id: I08587ff08fdc58dbe245f13298c514562722bef5
Signed-off-by: spurthi.segu <spurthi.segu@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3789
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[RE] [TIZEN] Fix for application crash when Back Button is pressed.

Change-Id: Ice60767d55099602df2bb9072a5a446f520fd8ca
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3813
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

modify resource type name used in server builder unittests

- modify resource type name used in server builder unittests into lower cases.

Change-Id: I812b1e67b649f133c861643748f4084c16bad9ec
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3759
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[Resource-Container] Updated README file of Android Sample App.

- Updated README file of RCSampleServerApp.

Change-Id: I48d1115e2348bbeed14d4145157d474ba6b99ca4
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Remove unnecessary files and codes from resource-container android.

RcsBundleInfo not needs native peer any more.
The dependency on rcs_common.so for building jni is removed.

Change-Id: I8e8af13a95f418eb9a3d2683eefd7f320ed6668d
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3777
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[TIZEN] Updated Resource Encapsulation Sample applicaitons.
- Added Light resource creation and discovery in the samples along with temperature resource.

Change-Id: Ic087000cd030ce2e7f9260adb0a2daf89c052e7e
Signed-off-by: arya.k <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3787
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

fixed Resource-encapsulation sampleApplication bug.

- when called 'getCachedAttribute' function, client can't get cached attribute because of mismatching key of 'attribute'.

Change-Id: I6248d2ff34d422fae4b8daf4df8b50804f4745b7
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3803
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Experimental disclaimer for resource container android support

The android platform support for the resource container is experimental

Change-Id: Ic9438e5b60dbf55f460e490518b14b75241facac
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3751
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[IOT-728] Remove Linux BLE build dir from include path.

The Linux BLE adapter build directory was originally added to the
preprocessor include path so that the generated GDBus "glue" headers
could be found by the preprocessor.  However, that caused conflicts in
cases where another directory contained a header with the same name as
one found on the Linux BLE adapter directory (e.g. utils.h).  Avoid
this conflict by removing the Linux BLE adapter build directory from
the preprocessor include path, and instead make the generated "glue"
header available to the preprocessor by copying it to the source
directory.  This change addresses the problem reported in bug
IOT-728.

This change can be cherry-picked for the 1.0.0-dev branch.

Change-Id: Ic7dbb570148458a30e05d4e6ac3cef78d606d4a4
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3003
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Fix ECDSA signature verification

[Patch #1] Fix signature verification.
[Patch #2] Fix compatibility.

Change-Id: Ib1b3769fc42143878d84f58830af1d3976409524
Signed-off-by: Dmitrii Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3647
Reviewed-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
(cherry picked from commit b5d9281374cd35e36e4bd348b4884d2f56d20ba8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/3755

easy-setup : mediator compilation warning and prevent fixes. Log TAG update

- Fixed some compilation warning fixes
- New prevent issue fixes
- Log TAG update

Change-Id: I8215d929af3a10791bd93a828e1a8ebad895a710
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3741
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix defect issues in things manager

Fixed issue CID: 82945, 82946, 82947, 82948, 82949

Change-Id: I7b4e8ac60751a5bb5c62aa1be05452aea16047ee
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3739
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Android: Enhancement for the IOT-764

It is OK now to do the following:

OcRepresentation rep = new OcRepresentation();
OcRepresentation repNull = null;
rep.setValue("key", repNull);

Change-Id: I10d554490190561e40cc97c8a1973f6ace0478cd
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3649
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

FindResource and CreateResource issue fix in Simulator.

Change-Id: I79b060680e52be77fb8779a12ca701e0d3eadbdf
Signed-off-by: spurthi.segu <spurthi.segu@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3729
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[Resource-Container] Java SDK and Sample applications

- Java SDK for Resource Container.
- Android Sample Applications for Resource Container.

Change-Id: I1138ea7c82a155b18b8951d2bcdd94b24f1bd579
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3641
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

intial creation for making JAVA API documetation
Running this shell results in  the "Java_API" folder
and "Java_API/index.html" explains Java APIs

Change-Id: I2302386d64d6f5df26286ecc931b65e2ab27d818
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3691
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[easy-setup] Modified JNI class name based on Android package change

- JNI class name has to be changed as Android easysetup package is modified

Change-Id: Ibfe4491788ecc3691d62d354f06a72b28cac0a0a
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3697
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[easy-setup] Fix for IOT-785

- Fix in Arduino build instructions

Change-Id: Iba558c43f118f6a449202f0d354a8fee0bf19174
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3603
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit d37d85cb0f850ed1d9169e62d43e38926de7a3ec)
Reviewed-on: https://gerrit.iotivity.org/gerrit/3689

[easy-setup] Android package name changed for sdk

- Changed package name for Easysetup setup Android sdk

Change-Id: Id80f23dc49bd5fdc8f1e04cc09d4292c43552d15
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3683
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[easy-setup] Updated Arduino Enrollee sample app for taking user input

- Modified Arduino sample and the corresponding code to accept input from sample user
- Added a new enum to provide the status of the enrollee along with the result
- Modified the callback handler to accept enrollee status

Change-Id: Ie0e8720c17315c0e022155727cc472f854308ead
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Junit fixes and review comment fixes for Simulator.

Change-Id: I215a83ef94b8b503018cf983bf36fc14bbe66c77
Signed-off-by: spurthi.segu <spurthi.segu@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Correct a typo in comments in Group Manager class

I modify Extrracting --> Extracting in getActionSetfromString function's comment

Change-Id: Ia6bd50c1abace62529c543acc8806739ab02c7f6
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3701
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Update the things manager code not to produce warning messages in compilation

It is shown that most of warning messages are produced by an existance
of unused parameters in a function. Not to produce the warning message, I
make the unused parameters being commented.
Additionally, fix potential defects in things manager with
CID 65806, 81664, 81560, 82257.

Change-Id: Ie460630d0dc3306087b87b2dd5bb314b1844bc1b
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3679
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

modified build option for CoAP/TCP

- There is no way to select ALL option without TCP
  in previous build option.
- CoAP/TCP should be also used WITH_TCP option like WITH_RA.
- and CoAP/TCP can be supported optionally more easy
  for Non-IP Transfer.

Change-Id: I39473e0c05c8f3950e9df78d118b9986dda42362
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3677
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Fix segmentation fault problem after discovery.

- PMDeviceDiscovery() add discovered devices in the list
  whenever callback is hit. If timeout happens the pointer to a list
  could be freed by the app but still there is a registered discovery callback.
  If the callback is hit after defined timeout period, callback try to
  add a discovered device to the invalid pointer (to freed memory).
  It will cause segmentation fault.

Fix: After defined timeout, PMDeviceDiscovery() explicitly
     remove registered callback using OCCancel.

Change-Id: Ic713cefb75c3495cfc9ad6688df44eb124d88f82
Signed-off-by: Woochul Shim <woochul.shim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3543
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Android: Removing old build instructions

Change-Id: Ib7ad6ea2a7ae5c29408054336f87655ee731ac2e
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3655
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

update comments for javadoc
changing comments to avoid errors while generating javadoc
such as </br>

Change-Id: I10c57894dcdc4642d600a11dc9fe224679c2aac9
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3645
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Junit testing fixes for Simulator APIs.

Change-Id: Id55390d0476be0349b2d2bbaa84adbbd36e4a8dd
Signed-off-by: spurthi.segu <spurthi.segu@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3629
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

[easy-setup] Added limit for Arduino Enrollee network reconnection attempts

- Added max 5 retry count for connecting to SoftAP nework
- Removed unused code in WiFiSoftAPManager

Change-Id: I9de157e9c69abb8301adf43a2404ac307681f286
Signed-off-by: lankamadan <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/3619
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>