Kevin Petit [Fri, 22 Mar 2019 12:10:04 +0000 (13:10 +0100)]
[Android] Fix old root page dispose when main page change (#4707) Fixes #4706 Fixes #4325
* Android - Fix old root page dispose when main page change.
* Revert dead code cleanup.
* Use direct cast for IApplicationController
Co-Authored-By: kvpt <kevin.petit@outlook.com>
* Use direct cast for IApplicationController (bis).
* Unsubscribe the event handler on the right application object.
* Prevent disruptive layout request from toolbar + Revert renderer clearing modification.
* If the page change, do nothing (dont dispose).
* Unsubscribe activity from application on destroy.
* Paused activity must not react to application changes
* Use nameof.
kicsiede [Fri, 22 Mar 2019 12:01:41 +0000 (13:01 +0100)]
Cellrenderer leak fixes + test (#5655) fixes #5604 fixes #5603
Brian Macomber [Thu, 21 Mar 2019 14:08:40 +0000 (09:08 -0500)]
[UWP]Fixes #3886, Master Detail, incorrect master height after window resize (#5338)
* Fix Issue 3386
* Update Xamarin.Forms.Platform.UAP/MasterDetailControl.cs
Co-Authored-By: bmacombe <brian@agspectrum.com>
Stephane Delcroix [Thu, 21 Mar 2019 13:38:37 +0000 (14:38 +0100)]
Merge branch '4.0.0'
Stephane Delcroix [Thu, 21 Mar 2019 13:37:08 +0000 (14:37 +0100)]
Merge branch '3.6.0' into 4.0.0
Stephane Delcroix [Thu, 21 Mar 2019 13:35:44 +0000 (14:35 +0100)]
Merge branch '3.5.0' into 3.6.0
Chris van de Steeg [Thu, 21 Mar 2019 13:24:31 +0000 (14:24 +0100)]
Fix BindableLayout's incorrect layout.children.add -> use insert (#5582)
* Fix incorrect layout.children.add -> use insert
* Modify unit test to match the problem with this issue
- fixes #5579
Shane Neuville [Thu, 21 Mar 2019 11:12:18 +0000 (05:12 -0600)]
Suppress warning for CharacterRangeForGlyphRange is obsolete (#5613) fixes #5246
* switch to GetCharacterRange for spans
* suppress obsolete message
Emil Alipiev [Thu, 21 Mar 2019 11:11:34 +0000 (04:11 -0700)]
DetectPlatform Fixed for UWP (#5182) fixes #4852
* detectplatform fixed using Windows.System.Profile.AnalyticsInfo.VersionInfo.DeviceFamily
UWP-Xbox sets TV...Surface tablets sets Desktop intead of Phone
* Update Xamarin.Forms.Platform.UAP/Forms.cs
Default was changed to be Unsupported Idiom
Co-Authored-By: EmilAlipiev <emil.alipiev@gmail.com>
* Update Xamarin.Forms.Platform.UAP/Forms.cs
Co-Authored-By: EmilAlipiev <emil.alipiev@gmail.com>
Pavel Yakovlev [Thu, 21 Mar 2019 10:03:50 +0000 (13:03 +0300)]
[shell] Fix show DisplayAlert (#5491) fixes #5504
* [shell, ios, tizen] fixes show alert
* - added helper extension
- fix navigation model
Shane Neuville [Thu, 21 Mar 2019 10:00:59 +0000 (04:00 -0600)]
fix abi breaks (#5620) fixes #5288
mtz [Thu, 21 Mar 2019 00:08:13 +0000 (01:08 +0100)]
[GTK] Fix NavigationBar check for Layout calc (#5506)
The loop was exiting before current was being set.
fixes #4713
Pavel Yakovlev [Wed, 20 Mar 2019 17:31:55 +0000 (20:31 +0300)]
[Android] fixes redraw element when changing renderer (#5233)
fixes #1760
Gabor Nemeth [Wed, 20 Mar 2019 17:31:00 +0000 (18:31 +0100)]
[macOS] enhance menu (#4718)
fixes #2618
Shane Neuville [Wed, 20 Mar 2019 17:11:16 +0000 (11:11 -0600)]
Centralize Theme Wrapper and fix sandbox to work with previewer (#5495)
* Centralize Theme Wrapper and fix sandbox to work with previewer
* simplify
* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Material.Android/MaterialContextThemeWrapper.cs
Pavel Yakovlev [Tue, 19 Mar 2019 20:05:38 +0000 (23:05 +0300)]
[Android] Fixes cancel Webview Navigation (#5458) fixes #4891 fixes #4919 closes #5460
* [Android] Fixes cancel Webview Navigation
* - added fix 4891
- refactoring
* Fix obsolete message
Co-authored-by: Ralph Brackert <brackert@baselineconnect.com>
Samantha Houts [Tue, 19 Mar 2019 20:01:21 +0000 (13:01 -0700)]
Merge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 19 Mar 2019 20:00:02 +0000 (20:00 +0000)]
[Controls] Fix build
Samantha Houts [Tue, 19 Mar 2019 18:58:17 +0000 (11:58 -0700)]
Merge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 19 Mar 2019 18:10:10 +0000 (18:10 +0000)]
[MacOS] Move ImageRenderer to use NSImageView (#5600)
* IMAGE https://github.com/xamarin/Xamarin.Forms/issues/5204
* Updated "no image source" behavior - return base value
* Added test case
* Updated test case number
* fixed file name
* [MacOS] Move ImageRenderer to use NSImageView
* [Macos,iOS] Fix sharing coding
Samantha Houts [Tue, 19 Mar 2019 18:08:56 +0000 (11:08 -0700)]
[UITest] Disable old 1461 test (#5605)
Pavel Yakovlev [Tue, 19 Mar 2019 15:26:43 +0000 (18:26 +0300)]
[mac] fix build (#5608)
Rui Marinho [Tue, 19 Mar 2019 09:48:11 +0000 (09:48 +0000)]
[MacOS] Fix rendering small text (#5443) fixes #2204
* [MacOS] Draft push test fix macOS test
* Refactor
* [Controls] Add repo test case #2204
* [Controls] Remove demo page
* [iOS,macOS] Refactor FontExtensions
* [iOS] Change visibility of shared method
* [Controls] Cleanup test #2204
Samantha Houts [Tue, 19 Mar 2019 01:26:21 +0000 (18:26 -0700)]
Merge branch '4.0.0'
Samantha Houts [Tue, 19 Mar 2019 01:25:50 +0000 (18:25 -0700)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Tue, 19 Mar 2019 01:22:34 +0000 (19:22 -0600)]
[Android] fall back to using native get identifier if reflection fails to retrieve drawable (#5585)
* - first try to use native get identifier before reflection
* add dummy types
* - try reflection first
* - add null check for resource requests
* fix fall through checks
* Update Xamarin.Forms.Platform.Android/ResourceManager.cs
Co-Authored-By: PureWeen <shane94@hotmail.com>
* - remove "smart" code for simpler code
* - fix replace
* - cleanup
* remove using
* - better if placement
* - hide LogInfoToPreviewer
* - hide LogInfoToPreviewer
Stephane Delcroix [Mon, 18 Mar 2019 23:43:59 +0000 (00:43 +0100)]
[X] intercepts FindByName exceptions (#5599)
for previewer
- fixes #5572
Stephane Delcroix [Mon, 18 Mar 2019 22:45:15 +0000 (23:45 +0100)]
[X] resilient to random text content (#5557)
- fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/817588
Stephane Delcroix [Mon, 18 Mar 2019 21:58:36 +0000 (22:58 +0100)]
[X] Allow empty property xaml-elements (#5550)
- fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/817710?src=WorkItemMention&src-action=artifact_link
- reverts #4582
David Ortinau [Mon, 18 Mar 2019 18:52:49 +0000 (13:52 -0500)]
[iOS,Shell] Fix tab bar style color alignment to match Android (#5075)
* Set the same TabBar color styles as Android
* unified on title color, made names consistent, and commented unused properties.
Pavel Yakovlev [Mon, 18 Mar 2019 14:48:21 +0000 (17:48 +0300)]
[mac] disregard the Dark mode (#5537) fixes #3777
E.Z. Hart [Mon, 18 Mar 2019 14:46:41 +0000 (08:46 -0600)]
Handle CollectionView multiple selection on Android and iOS (#5352)
* Handle multiple selection on Android and iOS
* Fire SelectionChanged events and commands when switching modes
* Do not fire the selection change if the mode change results in identical selection
* Fix rebase
* Temporarily patching EditorRenderer to get iOS tests running
* Fix bug where native selection is lost when items are off-screen
* [Core] Cleanup drop private o SelectionList
* [Android] Use local variable on foreach
Shane Neuville [Mon, 18 Mar 2019 11:47:23 +0000 (05:47 -0600)]
- Move renderer registration to Assembly Info (#5584)
Stephane Delcroix [Mon, 18 Mar 2019 10:25:47 +0000 (11:25 +0100)]
[X] recover from memberaccessEx
- fixes #5589
Shane Neuville [Mon, 18 Mar 2019 09:27:22 +0000 (03:27 -0600)]
remove maps.design (#5583)
Stephane Delcroix [Mon, 18 Mar 2019 08:40:38 +0000 (09:40 +0100)]
Merge branch '4.0.0'
Stephane Delcroix [Mon, 18 Mar 2019 08:40:11 +0000 (09:40 +0100)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Sat, 16 Mar 2019 01:19:53 +0000 (19:19 -0600)]
remove left over sealed on Material Entry Renderer (#5586)
Rui Marinho [Sat, 16 Mar 2019 01:13:14 +0000 (01:13 +0000)]
[Android] Fix issue when Message is null on Android API19 (#5562)
* [Android] Fix issue when Message is null on Android API19
* added kitkat check and moved check to extension method
* - remove awaken for kit kat and just catch all NPE
* - remove using
Akihiko Odaki [Fri, 15 Mar 2019 22:12:57 +0000 (07:12 +0900)]
[XamlC] Resolve complex property type (#5086)
Rui Marinho [Fri, 15 Mar 2019 21:45:17 +0000 (21:45 +0000)]
[Shell,Core] Add better exception messages for wrong or non existing content (#5566)
fixes #5081
Shane Neuville [Fri, 15 Mar 2019 21:43:04 +0000 (15:43 -0600)]
[Android] fix focus event on android and add UI Tests (#5528)
* fix focus event for material entry and add ui tests
* fix iOS
* - Focused
fixes #5509
E.Z. Hart [Fri, 15 Mar 2019 11:32:17 +0000 (05:32 -0600)]
[iOS] Fix crash when going from empty to having items (#5430)
* Fix crash on iOS when going from empty to having items
* Temporarily patching EditorRenderer so iOS tests can run
Stephane Delcroix [Fri, 15 Mar 2019 00:42:54 +0000 (01:42 +0100)]
[X] resilient to unyped x:Name (#5552)
Allow the previewer to recover from an x:Name attribute on a element
with unresolved type.
- fixes #5546
- closes #5547
Brandon Minnick [Fri, 15 Mar 2019 00:30:19 +0000 (17:30 -0700)]
Added AppLinks (#5568)
Rui Marinho [Thu, 14 Mar 2019 15:31:44 +0000 (15:31 +0000)]
[Controls] Only register AppCompact renderer if running in that context
Akihiko Odaki [Thu, 14 Mar 2019 12:39:29 +0000 (21:39 +0900)]
[XamlC] Correctly load addresses of values in compiled binding paths (#5082)
Andrei Nitescu [Thu, 14 Mar 2019 11:18:00 +0000 (13:18 +0200)]
iOS: Color of Editor Placeholder is different than Entry (#5259) fixes #5252
Seungkeun Lee [Thu, 14 Mar 2019 11:14:06 +0000 (20:14 +0900)]
[Tizen] Add CollectionView Tizen Renderer (#5364) fixes #3172
* [Tizen] Add CollectionView Tizen Renderer (#259)
* Tizen CollectionView implementation initial commit
- first working version
- only support LinearLayout(listview)
* Add more feature
* Implement INotifyCollectionChanged
* Implement EmptyView
* Implemnt SnapPoints, ScrollTo
* Fix MakeVisible option
* Add GridLayoutManager (#271)
* Fix GetScrollCanvasSize issue
* Enhance ItemAdaptor
- Measure Item size with data binding
Item size is determined with first item
- Extract ItemDefaultTemplateAdaptor from ItemTemplateAdaptor
* Remove debug message
* Implement SelectableItemsView
* Fix ghost view issue
* Fix TV profile button effect issue
* Clean up code space and refactoring ScrollTo method
* Fix collectionView emptyview (#277)
Stephane Delcroix [Thu, 14 Mar 2019 08:21:19 +0000 (09:21 +0100)]
[X] resilience on markup (#5532)
let the previewer intercepts and recover from misformatted markups
- fixes #5508
- closes #5527
Samantha Houts [Wed, 13 Mar 2019 22:41:12 +0000 (15:41 -0700)]
Merge branch '4.0.0'
Samantha Houts [Wed, 13 Mar 2019 22:40:27 +0000 (15:40 -0700)]
Merge branch '3.6.0' into 4.0.0
Samantha Houts [Wed, 13 Mar 2019 21:51:38 +0000 (14:51 -0700)]
[Housekeeping] Be more polite (#5539)
Andrei Nitescu [Wed, 13 Mar 2019 19:24:22 +0000 (21:24 +0200)]
Fix Map ItemsSource bp name (#5499)
Shane Neuville [Wed, 13 Mar 2019 16:03:32 +0000 (10:03 -0600)]
[Android] ensure scrollbar has been initialized (#5462)
* [Android] ensure scrollbar has been initialized
* fix comments
* Update Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs
spruceDevelopment [Wed, 13 Mar 2019 11:39:58 +0000 (12:39 +0100)]
Correct Grid Height When Aspect Fit Image Gets Shrinked (#4990)
- fixes #4933
* Grid size incorrect when using with Image #4990
* Unit Test for Grid size incorrect when using with Image #4933
* Grid size incorrect when using with Image #4933
* Unit Test for Grid size incorrect when using with Image #4933
Pavel Yakovlev [Tue, 12 Mar 2019 23:58:05 +0000 (02:58 +0300)]
[UWP] added Win2D.uwp dependency to nuget (#5475)
fixes #5188
Akihiko Odaki [Fri, 22 Feb 2019 00:56:42 +0000 (09:56 +0900)]
[XamlC] Identify generic instance types correctly when importing ctor (#5309)
The old implementation fails to identify generic instance types for typed
binding getter, whose type is:
System.Func`2<TSource, ValueTuple<TProperty, bool>>
This fixes the issue by taking generic arguments into account.
Tim Barham [Tue, 12 Mar 2019 21:36:12 +0000 (07:36 +1000)]
Fix NamedSize in Previewer (#5496)
In the previewer, ConvertTextAppearanceToSize() returns -0.5 for all values. Return default value if we get a size of 0 or less.
Shane Neuville [Mon, 11 Mar 2019 20:45:38 +0000 (14:45 -0600)]
Fix up Sandbox to work with previewer and add android material reference in (#5513)
* fix sandbox to work with previewer
* small page fixes
Stephane Delcroix [Mon, 11 Mar 2019 13:38:34 +0000 (14:38 +0100)]
[X] recover from missing markup type (#5485)
- fixes #5484
Akihiko Odaki [Mon, 11 Mar 2019 08:52:36 +0000 (17:52 +0900)]
[XamlC] Fix message for unresolved event handler reference in DataTemplate (#5502)
Stephane Delcroix [Mon, 11 Mar 2019 08:21:07 +0000 (09:21 +0100)]
Merge branch '4.0.0'
Stephane Delcroix [Mon, 11 Mar 2019 08:19:20 +0000 (09:19 +0100)]
Merge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 7 Mar 2019 22:44:10 +0000 (14:44 -0800)]
[Maps} move design dll to the design folder (#5481)
- fixes #5472
Seungkeun Lee [Thu, 7 Mar 2019 17:51:45 +0000 (02:51 +0900)]
[Tizen] Fix CarouselPage focus issue (#5483)
Samantha Houts [Thu, 7 Mar 2019 17:49:56 +0000 (09:49 -0800)]
Merge branch '4.0.0'
kingces95 [Thu, 7 Mar 2019 17:18:57 +0000 (07:18 -1000)]
ContextCompat.getColor if API < 23 (#5450)
Update Xamarin.Forms.Platform.Android/Forms.cs
Does this do all the suggestions?
Co-Authored-By: kingces95 <kingces95@users.noreply.github.com>
ContextCompat.getColor if API < 23
Shane Neuville [Thu, 7 Mar 2019 17:17:43 +0000 (10:17 -0700)]
[UWP] Roll back PR 3400 so the correct context is passed into Tapped (#5476)
* [UWP] pass the correct object to ItemView
* - remove object from source
Stephane Delcroix [Wed, 6 Mar 2019 08:39:12 +0000 (09:39 +0100)]
[XamlC] throw on invalid DataType (#5335)
Invalid x:DataType was ignored up to now. Change the behavior so it
throws a XPE.
- fixes #5330
Samantha Houts [Wed, 6 Mar 2019 00:54:49 +0000 (16:54 -0800)]
Merge branch '4.0.0'
Samantha Houts [Wed, 6 Mar 2019 00:54:26 +0000 (16:54 -0800)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Tue, 5 Mar 2019 18:07:57 +0000 (11:07 -0700)]
Uwp restart uitests on crash (#5420)
* [UWP] if a UI tests crashes the UWP window this will restart the window so all the rest of the tests can run
* simplify
E.Z. Hart [Tue, 5 Mar 2019 18:06:27 +0000 (11:06 -0700)]
[iOS] Check new element before creating placeholder label (#5432)
* Check new element before creating placeholder label
* additional checks
* create placeholder once
Shane Neuville [Mon, 4 Mar 2019 23:43:22 +0000 (16:43 -0700)]
[Android] remove android specific target (#5442)
* [Android] get rid of specific android targets
* change to AndroidApplication
* remove before/after targets
* MonoAndroid
Samantha Houts [Sat, 2 Mar 2019 03:17:26 +0000 (19:17 -0800)]
Merge branch '4.0.0'
Samantha Houts [Sat, 2 Mar 2019 03:16:42 +0000 (19:16 -0800)]
Merge branch '3.6.0' into 4.0.0
Shane Neuville [Sat, 2 Mar 2019 03:15:08 +0000 (20:15 -0700)]
fix changed apis (#5426)
* fix changed apis
* increment language version
* bring some back
* update font
* VisualElement fixes
fixes #4644
fixes #5170
Shane Neuville [Sat, 2 Mar 2019 01:10:02 +0000 (18:10 -0700)]
update readme to include vs for mac instructions (#5419)
Matthijs ter Woord [Fri, 1 Mar 2019 23:49:49 +0000 (00:49 +0100)]
Fix WPFResources, EntryCell (#5361)
Also bind Isenabled
fixes #5360
Gerald Versluis [Fri, 1 Mar 2019 23:47:31 +0000 (00:47 +0100)]
[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)
* Implemented Core and iOS
* Implemented Android
* Supressed platform specific obsolete warnings for now
* Implemented UWP
* Make selected page on UWP not rely on title
* Review feedback
* Removed references to (now) obsolete members
* Review feedback fixes
* Code review feedback
* Changed obsolete msg to reflect right XF version
* Apply suggestions from code review
Co-Authored-By: jfversluis <github@geraldversluis.nl>
fixes #3478
Samantha Houts [Fri, 1 Mar 2019 18:08:12 +0000 (10:08 -0800)]
Merge branch '4.0.0'
Samantha Houts [Fri, 1 Mar 2019 18:07:45 +0000 (10:07 -0800)]
Merge branch '3.6.0' into 4.0.0
Samantha Houts [Fri, 1 Mar 2019 18:06:34 +0000 (10:06 -0800)]
Merge branch '3.5.0' into 3.6.0
Andrei [Fri, 1 Mar 2019 18:06:08 +0000 (21:06 +0300)]
fixed crash (#5363)
Samantha Houts [Fri, 1 Mar 2019 17:59:21 +0000 (09:59 -0800)]
Reverts "[Xaml] require escaping curly braces (#4723)" and "[X] only require escaping if starts with '{' (#5169)" (#5424)
* Revert "[X] only require escaping if starts with '{' (#5169)"
This reverts commit
cd73391c3a2d7ff60a95449cac255c1425e81a43.
* Revert "[Xaml] require escaping curly braces (#4723)"
This reverts commit
6753ace40e68f8aa6d45eefa90117f5650984c6f.
* Make sure parsing doesn't fail when there *are* curly braces now
Pavel Yakovlev [Fri, 1 Mar 2019 17:22:18 +0000 (20:22 +0300)]
[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987
Samantha Houts [Fri, 1 Mar 2019 02:12:27 +0000 (18:12 -0800)]
Merge branch '3.6.0'
Samantha Houts [Fri, 1 Mar 2019 02:10:53 +0000 (18:10 -0800)]
Merge branch '3.5.0' into 3.6.0
Stephane Delcroix [Fri, 1 Mar 2019 00:17:13 +0000 (01:17 +0100)]
[X] bubble markup exception to previewer (#5411)
- fixes #5407
E.Z. Hart [Thu, 28 Feb 2019 20:02:49 +0000 (13:02 -0700)]
Fix iOS EmptyView crash; properly handle EmptyView swapping (#5353)
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)
* [X] allow previewer fallback on rootnode
- fixes #5410
* additional test case
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)
* [X] allow previewer fallback on rootnode
- fixes #5410
* additional test case
Shane Neuville [Thu, 28 Feb 2019 18:57:20 +0000 (11:57 -0700)]
[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible (#5398)
* return IVisualElementRenderer to previous state
* set to internal
kingces95 [Thu, 28 Feb 2019 02:32:57 +0000 (16:32 -1000)]
previewer; PageRenderer trap for missing bg image (#5342)
* previewer; PageRenderer trap for missing bg image
* previewer; PageRenderer trap for missing bg image
* fix macOS; remove ext for macOS
fixes #5300
Samantha Houts [Thu, 28 Feb 2019 02:22:37 +0000 (18:22 -0800)]
Merge branch '3.6.0'
Samantha Houts [Thu, 28 Feb 2019 02:21:59 +0000 (18:21 -0800)]
Merge branch '3.5.0' into 3.6.0
Samantha Houts [Thu, 28 Feb 2019 02:08:47 +0000 (18:08 -0800)]
[iOS, Android] Prevent NREs in ScrollViews (#5383)
* Add null checks on new code paths added in #4522
fixes #5161
* Fix cast...
Fixes #5247
E.Z. Hart [Thu, 28 Feb 2019 02:06:48 +0000 (19:06 -0700)]
Allow SelectableItemsViewRenderer/Adapted to deselect ViewHolders not in the RecyclerView's child collection (#5358)
Fixes #5078
Stephane Delcroix [Thu, 28 Feb 2019 01:58:58 +0000 (02:58 +0100)]
[X] more conv exception, bubble to previewer (#5400)
Catch more exception cases, make sure the previewer can recover from them
- fixes #5397