platform/upstream/dotnet/runtime.git
6 years agoFix Aes and Ssse3.Shuffle intrinsic APIs
Fei Peng [Tue, 26 Jun 2018 23:20:54 +0000 (16:20 -0700)]
Fix Aes and Ssse3.Shuffle intrinsic APIs

Commit migrated from https://github.com/dotnet/coreclr/commit/1aec8f9ff3c1aa575be0ecad9b2920d25436281c

6 years agoFix value numbering when selecting a constant (dotnet/coreclr#18627)
Jakob Botsch Nielsen [Tue, 26 Jun 2018 14:57:47 +0000 (16:57 +0200)]
Fix value numbering when selecting a constant (dotnet/coreclr#18627)

When applying selectors, constants were special-cased to not require any
type casts. However this is wrong if a narrowing needs to be performed.

Fix dotnet/coreclr#18235

Commit migrated from https://github.com/dotnet/coreclr/commit/4e237f058b12403f7ee69d62fd24053081d5fe13

6 years agoDelete slack link, standardize on gitter (dotnet/coreclr#18644)
Jan Kotas [Tue, 26 Jun 2018 05:56:03 +0000 (22:56 -0700)]
Delete slack link, standardize on gitter (dotnet/coreclr#18644)

Contributes to https://github.com/dotnet/coreclr/issues/18643

Commit migrated from https://github.com/dotnet/coreclr/commit/c17e34f4120f551c70be88fef835abc7640a2e00

6 years agoMerge pull request dotnet/coreclr#18585 from BruceForstall/FixArmOffsets
Bruce Forstall [Mon, 25 Jun 2018 21:55:27 +0000 (14:55 -0700)]
Merge pull request dotnet/coreclr#18585 from BruceForstall/FixArmOffsets

Clean up ARM reserved register handling

Commit migrated from https://github.com/dotnet/coreclr/commit/e910f324401e330bd586df8beb653c90616dd134

6 years agoRemove commentary on non-existent appx checks (dotnet/coreclr#18631)
Rafael Rivera [Mon, 25 Jun 2018 20:13:11 +0000 (13:13 -0700)]
Remove commentary on non-existent appx checks (dotnet/coreclr#18631)

Remove commentary on non-existent appx checks

Commit migrated from https://github.com/dotnet/coreclr/commit/19fd88befd6c142b3c1268703eda0e1f0fd2e7b8

6 years agoSimplify types in non-shared corelib (dotnet/corertdotnet/coreclr#6008)
Stephen Toub [Mon, 25 Jun 2018 03:21:25 +0000 (23:21 -0400)]
Simplify types in non-shared corelib (dotnet/corertdotnet/coreclr#6008)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/053e002e3299373ec85f5dc23f744337484d56ed

6 years agoCross-bitness regular and thread static fields offsets (dotnet/coreclr#18636)
Egor Chesakov [Mon, 25 Jun 2018 19:25:49 +0000 (12:25 -0700)]
Cross-bitness regular and thread static fields offsets (dotnet/coreclr#18636)

* Define OFFSETOF__DomainLocalModule__m_pDataBlob_ OFFSETOF__DomainLocalModule__NormalDynamicEntry__m_pDataBlob in src/vm/appdomain.hpp

* Define OFFSETOF__ThreadLocalModule__m_pDataBlob OFFSETOF__ThreadLocalModule__DynamicEntry__m_pDataBlob in src/vm/threadstatics.h

* Add assertions and offsets for dynamically allocated statics

* Compensate OffsetOfDataBlob difference

* Check target specific offsets in assertions in src/vm/methodtablebuilder.cpp

Commit migrated from https://github.com/dotnet/coreclr/commit/030a3ea9b8dbeae89c90d34441d4d9a1cf4a7de6

6 years agoDon't close the JIT func info file on shutdown (dotnet/coreclr#18060)
Koundinya Veluri [Mon, 25 Jun 2018 16:41:51 +0000 (09:41 -0700)]
Don't close the JIT func info file on shutdown (dotnet/coreclr#18060)

During shutdown there can be a race between closing/nulling `compJitFuncInfoFile` in `compShutdown` and a background thread trying to write to it after checking that it was not null.

Commit migrated from https://github.com/dotnet/coreclr/commit/df78ae72d5cf3f2c2dbe4ff972732d418497f9bc

6 years agoCross-bitness in instance fields placement and CORINFO structs (dotnet/coreclr#18366)
Egor Chesakov [Mon, 25 Jun 2018 16:17:00 +0000 (09:17 -0700)]
Cross-bitness in instance fields placement and CORINFO structs (dotnet/coreclr#18366)

* Replace sizeof(OBJECTREF*) with TARGET_POINTER_SIZE

* Define IN_TARGET_32BIT IN_TARGET_64BIT macros

* Replace IN_WIN32 IN_WIN64 with IN_TARGET_32BIT IN_TARGET_64BIT in src/vm/jitinterface.cpp src/vm/methodtablebuilder.cpp

* Define and use OFFSETOF__CORINFO_* constants in clrjit

* Define for all 64-bit targets

* Use unsigned __int32 to emphasize that this is 32-bit number

* Rename Array__u1Elems to Array__data

* Eliminate OFFSETOF__CORINFO_RefArray__length

* Rename OFFSETOF__CORINFO_RefAny__ to OFFSETOF__CORINFO_TypedReference__

* Fix OFFSETOF__CORINFO_TypedReference__dataPtr macro value

Commit migrated from https://github.com/dotnet/coreclr/commit/c77ef768fc969d6875426e76e51485f2d67ac51c

6 years agoFix nested-anon-types warnings (dotnet/coreclr#18591)
Adeel Mujahid [Mon, 25 Jun 2018 12:23:12 +0000 (15:23 +0300)]
Fix nested-anon-types warnings (dotnet/coreclr#18591)

Commit migrated from https://github.com/dotnet/coreclr/commit/86ca8b5e282ee0b42e27c69cb42c159dfc6e5a4b

6 years agoRemove test logs (dotnet/coreclr#18621)
Andon Andonov [Mon, 25 Jun 2018 05:45:27 +0000 (22:45 -0700)]
Remove test logs (dotnet/coreclr#18621)

Commit migrated from https://github.com/dotnet/coreclr/commit/556a5fa3e898bbaad3516b55875074a5c265327a

6 years agoRemoved dead strings used in debug-only code (dotnet/coreclr#18622)
hsharber [Mon, 25 Jun 2018 01:18:15 +0000 (21:18 -0400)]
Removed dead strings used in debug-only code (dotnet/coreclr#18622)

Removed strings used in debug-only code in ex.cpp

Fix dotnet/coreclr#18420

Commit migrated from https://github.com/dotnet/coreclr/commit/e24e66516f04f3de23bdedab9282ad7f334e64cf

6 years agoUpdate to latest released dotnet SDK (dotnet/coreclr#18626)
Jan Kotas [Sun, 24 Jun 2018 20:45:15 +0000 (13:45 -0700)]
Update to latest released dotnet SDK (dotnet/coreclr#18626)

Commit migrated from https://github.com/dotnet/coreclr/commit/798091f23f4c2eea653c78520117634960f366aa

6 years agonon shared changes and disabling tests
Anipik [Sun, 24 Jun 2018 04:29:23 +0000 (21:29 -0700)]
non shared changes and disabling tests

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/e32feb0120e74178ef03c5c65b06022666470177

6 years agoSimply type names in Corelib (dotnet/coreclr#18623)
Stephen Toub [Sun, 24 Jun 2018 12:22:35 +0000 (08:22 -0400)]
Simply type names in Corelib (dotnet/coreclr#18623)

Commit migrated from https://github.com/dotnet/coreclr/commit/0fbd855e38bc3ec269479b5f6bf561dcfd67cbb6

6 years agoUse correct basic block to check legality of PInvoke callsite for inlining (dotnet...
Jan Kotas [Sun, 24 Jun 2018 03:20:58 +0000 (20:20 -0700)]
Use correct basic block to check legality of PInvoke callsite for inlining (dotnet/coreclr#18620)

It is the same logic as used in other similar places

Commit migrated from https://github.com/dotnet/coreclr/commit/eb31c358b27182dae487406a3247dfe995beb40f

6 years agoClean up ARM reserved register computations
Bruce Forstall [Thu, 21 Jun 2018 02:06:27 +0000 (19:06 -0700)]
Clean up ARM reserved register computations

Tighten up and correct the math in compRsvdRegCheck.

Commit migrated from https://github.com/dotnet/coreclr/commit/c48506a1664fa12f5b72c40f57f52e7d3536a2ba

6 years agoMerge pull request dotnet/coreclr#18600 from BruceForstall/FixArmFPFrameAddressLimits
Bruce Forstall [Sat, 23 Jun 2018 16:38:05 +0000 (09:38 -0700)]
Merge pull request dotnet/coreclr#18600 from BruceForstall/FixArmFPFrameAddressLimits

Expand ARM local variable R11-based addressing

Commit migrated from https://github.com/dotnet/coreclr/commit/80fdb42107bad66b1710558cbeffb3fefe4f4463

6 years agoMerge pull request dotnet/coreclr#18615 from A-And/CIFXStaging
Bruce Forstall [Sat, 23 Jun 2018 16:36:45 +0000 (09:36 -0700)]
Merge pull request dotnet/coreclr#18615 from A-And/CIFXStaging

CoreFX CI - Correct testResults path

Commit migrated from https://github.com/dotnet/coreclr/commit/9bf3435fe6ad85a5d5021fd98ac323066fca75de

6 years agoChange string.Compare(...) == 0 occurrences to string.Equals(...) (dotnet/coreclr...
Stephen Toub [Sat, 23 Jun 2018 14:20:29 +0000 (10:20 -0400)]
Change string.Compare(...) == 0 occurrences to string.Equals(...) (dotnet/coreclr#18616)

Commit migrated from https://github.com/dotnet/coreclr/commit/e1a6bdb037e1a79ad7009fb81eecfd6bd1bbfe65

6 years agoMoved EventWaitHandle.cs to shared (dotnet/coreclr#18612)
Anirudh Agnihotry [Sat, 23 Jun 2018 04:12:42 +0000 (21:12 -0700)]
Moved EventWaitHandle.cs to shared (dotnet/coreclr#18612)

* Removed AccessControl Unused arguments

* moving common code to CreateEventCore and using constructor chaining

* Moving Functions to eventwaithandles.windows

* EventWaitHandle matched with corert

* eventwaithandle.windwos matched with corert

* Addding interop functions

* moved files to shared

* Minor changes

* fixing build for corert unix

* Removing Comment

Commit migrated from https://github.com/dotnet/coreclr/commit/2018d7875ccc01724a4a5c157b2a2bbe15e1a043

6 years agoPass RID to crossgen (dotnet/coreclr#18592)
Adeel Mujahid [Sat, 23 Jun 2018 02:51:03 +0000 (05:51 +0300)]
Pass RID to crossgen (dotnet/coreclr#18592)

Commit migrated from https://github.com/dotnet/coreclr/commit/328a2bdc754895bb2204f5daa4d8fa4529bc9dc4

6 years agoFix incorrect usage of ILCodeVersion::AsNode (issue dotnet/coreclr#18602) (dotnet...
Noah Falk [Sat, 23 Jun 2018 02:14:15 +0000 (19:14 -0700)]
Fix incorrect usage of ILCodeVersion::AsNode (issue dotnet/coreclr#18602) (dotnet/coreclr#18606)

When the debugger is querying the active rejit IL for an IL method that has not been rejitted it incorrectly creates a VMPTR_ILCodeVersionNode for a code version that shouldn't have one.

Commit migrated from https://github.com/dotnet/coreclr/commit/67af5834bf890632fe975fa27cae35c8404e726e

6 years agoCorrect testResults path
Andon Andonov [Sat, 23 Jun 2018 01:11:18 +0000 (18:11 -0700)]
Correct testResults path

Commit migrated from https://github.com/dotnet/coreclr/commit/ad694c15e8cd0df8d53a8d3359bc7678c754c3c0

6 years agoExpand ARM local variable R11-based addressing
Bruce Forstall [Thu, 21 Jun 2018 23:33:02 +0000 (16:33 -0700)]
Expand ARM local variable R11-based addressing

When addressing a local with negative offsets from R11 (if it can't
be reached from SP), allow the full range of negative offsets allowed
in the instructions. Floating-point load/store especially has a much
bigger range than what was previously allowed.

Commit migrated from https://github.com/dotnet/coreclr/commit/a8bccc94862a03ed1503b63cf8a38a7446353471

6 years agoFix incorrect script path (dotnet/coreclr#18613)
Andon Andonov [Fri, 22 Jun 2018 22:43:05 +0000 (15:43 -0700)]
Fix incorrect script path (dotnet/coreclr#18613)

Commit migrated from https://github.com/dotnet/coreclr/commit/a6369dfceb2106bcf0de3d834d9a9a4dbf1459d5

6 years agoNon Shared Changed And feedback
Anipik [Fri, 22 Jun 2018 18:32:13 +0000 (11:32 -0700)]
Non Shared Changed And feedback

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/db4248f0d615f6e86ed291a86adf395a59ec2e9c

6 years agoRemove trigger phrases and add testhost building (dotnet/coreclr#18608)
Andon Andonov [Fri, 22 Jun 2018 20:54:45 +0000 (13:54 -0700)]
Remove trigger phrases and add testhost building (dotnet/coreclr#18608)

Commit migrated from https://github.com/dotnet/coreclr/commit/57218f2de795f6a9141dc9853dbc83029815798e

6 years agoAdd public implementation MarshalerSupport (dotnet/coreclr#18530)
Luqun Lou [Fri, 22 Jun 2018 18:33:35 +0000 (11:33 -0700)]
Add public implementation MarshalerSupport (dotnet/coreclr#18530)

Commit migrated from https://github.com/dotnet/coreclr/commit/3fb4483277c7b12841b9ea7672bccdc6f23d3d52

6 years agoStart moving testing documentation into a single location (dotnet/coreclr#18598)
Aaron Robinson [Fri, 22 Jun 2018 18:24:22 +0000 (11:24 -0700)]
Start moving testing documentation into a single location (dotnet/coreclr#18598)

Start moving testing documentation into a single location
Update `test-configuration.md` with more details on creating a test and requirements

Commit migrated from https://github.com/dotnet/coreclr/commit/8aad994743a1332a21a56728799c293a21115050

6 years agoUpdate package version to 3.0.0
Russ Keldorph [Thu, 21 Jun 2018 20:49:04 +0000 (13:49 -0700)]
Update package version to 3.0.0

This doesn't make much practical difference since CoreCLR's packages aren't
intended for any consumers other than core-setup, but we might as well try
to be consistent with our peer repos in case it provides a useful hint when
something goes wrong.

Commit migrated from https://github.com/dotnet/coreclr/commit/75bd77f09d2221f8eae78e686ded8e510a569542

6 years agoMerge pull request dotnet/coreclr#18581 from CarolEidt/Reenable18295
Carol Eidt [Fri, 22 Jun 2018 16:11:16 +0000 (09:11 -0700)]
Merge pull request dotnet/coreclr#18581 from CarolEidt/Reenable18295

Re-enable tests after fixing 18295

Commit migrated from https://github.com/dotnet/coreclr/commit/cccc10972bfe7e92f7f32f6a96aa667b845c530f

6 years agoMerge pull request dotnet/coreclr#18595 from BruceForstall/FixArmEncoderLimits
Bruce Forstall [Fri, 22 Jun 2018 06:05:42 +0000 (23:05 -0700)]
Merge pull request dotnet/coreclr#18595 from BruceForstall/FixArmEncoderLimits

Fix ARM encoder limits

Commit migrated from https://github.com/dotnet/coreclr/commit/766418568816dfdaac15f7bc9929d5ffcf45b600

6 years agoMoved Semaphore.cs and Semaphore.Windows.cs to shared (dotnet/coreclr#18597)
Anirudh Agnihotry [Fri, 22 Jun 2018 01:39:23 +0000 (18:39 -0700)]
Moved Semaphore.cs and Semaphore.Windows.cs to shared (dotnet/coreclr#18597)

* TryOpenexistingworker and createsemaphore moved to semaphore.windows.cs

* Common code moved to verifyCounts and CreateMutexCore and then moved to semaphore.windows.cs

* CreateSemaphore merged with CreateSemaphore core

* Moving interop functions from win32Native to inteop.kernel32

* Moving the files to shared

* Minor Formating

Commit migrated from https://github.com/dotnet/coreclr/commit/84b6f1da3338df672347732a0ea5f7cf4a3e43cf

6 years agoUpdate behaviors of new TextWriter StringBuilder overloads (dotnet/coreclr#18578)
Stephen Toub [Fri, 22 Jun 2018 01:36:59 +0000 (21:36 -0400)]
Update behaviors of new TextWriter StringBuilder overloads (dotnet/coreclr#18578)

Two issues addressed:
- CancellationToken was being ignored; the overloads should check whether cancellation was requested.  This applies to the existing Write{Line}Async overloads that were added in 2.1.
- The other overloads support inputs (string, char[], etc.) being null, and just treat that the same as an empty string.  We should do the same for StringBuilder rather than throwing.

Commit migrated from https://github.com/dotnet/coreclr/commit/538a51e593964ad34147e3143153885135412837

6 years agoMerge pull request dotnet/coreclr#18570 from acmyu/bugs
Amy [Thu, 21 Jun 2018 23:19:05 +0000 (16:19 -0700)]
Merge pull request dotnet/coreclr#18570 from acmyu/bugs

R2RDump - Bug fixes

Commit migrated from https://github.com/dotnet/coreclr/commit/7196a7f62ba4047ddd51523cc4a253ba44201033

6 years agoWindows CoreFX CI Staging Commit (dotnet/coreclr#18388)
Andon Andonov [Thu, 21 Jun 2018 23:04:54 +0000 (16:04 -0700)]
Windows CoreFX CI Staging Commit (dotnet/coreclr#18388)

* Netci

* Add fake test switch

* Add branch PR trigger

* Add Checked corefx_innerloop jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/b5756070ace26b3f58b4bf495fe8e983431b5973

6 years agoFix unset ZapRelocationType for fixup (dotnet/coreclr#18589)
Gleb Balykov [Thu, 21 Jun 2018 22:16:58 +0000 (01:16 +0300)]
Fix unset ZapRelocationType for fixup (dotnet/coreclr#18589)

Commit migrated from https://github.com/dotnet/coreclr/commit/07bbd5f299fdc1ba4d00ab5331f2e2fc8c28291a

6 years agoFix ARM encoder limits
Bruce Forstall [Thu, 21 Jun 2018 20:11:13 +0000 (13:11 -0700)]
Fix ARM encoder limits

The ARM encoder was using slightly incorrect limits when deciding whether
a particular constant offset was allowed in an addressing mode.

Change the limits to match the instruction definitions.

Commit migrated from https://github.com/dotnet/coreclr/commit/1990fea59c19ccec643c3174b0cd5733296bb1c9

6 years agoMerge pull request dotnet/coreclr#18031 from kbaladurin/fix-hfa-tests
Bruce Forstall [Thu, 21 Jun 2018 15:57:44 +0000 (08:57 -0700)]
Merge pull request dotnet/coreclr#18031 from kbaladurin/fix-hfa-tests

[JIT/ARM] Fix Compiler::lvaFrameAddress

Commit migrated from https://github.com/dotnet/coreclr/commit/6b90c5676693e826a64d15b7c507795b8ed1d98f

6 years agoUpdate PgoData to master-20180621-0050 (dotnet/coreclr#18587)
dotnet-maestro-bot [Thu, 21 Jun 2018 12:34:29 +0000 (05:34 -0700)]
Update PgoData to master-20180621-0050 (dotnet/coreclr#18587)

Commit migrated from https://github.com/dotnet/coreclr/commit/572416a6e1faa1d76c9cdddec13f1e5b6741f5ed

6 years agoUndo accidental 2.0 -> 2.1 renames (dotnet/corertdotnet/coreclr#5981)
Jan Kotas [Thu, 21 Jun 2018 03:38:07 +0000 (20:38 -0700)]
Undo accidental 2.0 -> 2.1 renames (dotnet/corertdotnet/coreclr#5981)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/3e87306d8e8b909aaa26582fa11cb30e52e9431e

6 years agoRev netcoreapp2.0 to netcoreapp2.1 (dotnet/corertdotnet/coreclr#5974)
Adeel Mujahid [Thu, 21 Jun 2018 00:06:28 +0000 (03:06 +0300)]
Rev netcoreapp2.0 to netcoreapp2.1 (dotnet/corertdotnet/coreclr#5974)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/addb9956f1786bb8b6bcb0daf509a5d9c9b98347

6 years agoUpdate CoreClr, CoreFx to preview1-26621-01, preview1-26621-01, respectively (dotnet...
dotnet-maestro-bot [Thu, 21 Jun 2018 03:38:51 +0000 (20:38 -0700)]
Update CoreClr, CoreFx to preview1-26621-01, preview1-26621-01, respectively (dotnet/coreclr#18584)

Commit migrated from https://github.com/dotnet/coreclr/commit/88cd3828a5eee6f7a02935c7afcf240634dfa29a

6 years agoMerge pull request dotnet/coreclr#18552 from dotnet-maestro-bot/master-UpdateDependencies
Wes Haggard [Wed, 20 Jun 2018 23:59:20 +0000 (16:59 -0700)]
Merge pull request dotnet/coreclr#18552 from dotnet-maestro-bot/master-UpdateDependencies

Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02920-01, preview1-26620-04, preview1-26620-03, master-20180620-0039, respectively (master)

Commit migrated from https://github.com/dotnet/coreclr/commit/c58c7cf72fce548f74d73f1f0f53be7b81c53119

6 years agoFixed method name in comment (dotnet/coreclr#18571)
Alfred Myers [Wed, 20 Jun 2018 23:31:00 +0000 (20:31 -0300)]
Fixed method name in comment (dotnet/coreclr#18571)

Commit migrated from https://github.com/dotnet/coreclr/commit/da40cb1ca8779566ca53ed6bd2fa67a926b29b38

6 years agoMerge pull request dotnet/coreclr#18573 from CarolEidt/ExplicitLayoutTest
Carol Eidt [Wed, 20 Jun 2018 23:26:58 +0000 (16:26 -0700)]
Merge pull request dotnet/coreclr#18573 from CarolEidt/ExplicitLayoutTest

Add another test for dotnet/coreclr#17971

Commit migrated from https://github.com/dotnet/coreclr/commit/77bed31fc1a14fe7ef32a771cf53a3c5c496286b

6 years agoRe-enable tests after fixing 18295
Carol Eidt [Wed, 20 Jun 2018 22:43:19 +0000 (15:43 -0700)]
Re-enable tests after fixing 18295

Commit migrated from https://github.com/dotnet/coreclr/commit/95e80262b1bc2a1ca9ab76f034357466ce9b1338

6 years agoUpdate BuildTools, CoreClr, CoreFx, PgoData to preview1-02920-01, preview1-26620...
dotnet-maestro-bot [Wed, 20 Jun 2018 22:03:51 +0000 (15:03 -0700)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02920-01, preview1-26620-04, preview1-26620-03, master-20180620-0039, respectively

Commit migrated from https://github.com/dotnet/coreclr/commit/7fc59ab9fcfd4e9c8693ed3c42cb0b87c29ace9a

6 years agoAn UnusedValue still requires a target reg (dotnet/coreclr#18561)
Carol Eidt [Wed, 20 Jun 2018 21:55:12 +0000 (14:55 -0700)]
An UnusedValue still requires a target reg (dotnet/coreclr#18561)

* An UnusedValue still requires a target reg

The BuildSimple method wasn't creating a def for an unused value. Although (in this case) the code is dead, the code generator must still be able to generate code for it.

* Add test case for dotnet/coreclr#18295 to arm/arm64 tests.lst

Commit migrated from https://github.com/dotnet/coreclr/commit/0c95349ef5ee360dc92a51632e7a4210cb4053da

6 years agoadded concurrent access detection to Remove() (dotnet/coreclr#18524)
Marco Rossignoli [Wed, 20 Jun 2018 19:19:06 +0000 (21:19 +0200)]
added concurrent access detection to Remove() (dotnet/coreclr#18524)

Commit migrated from https://github.com/dotnet/coreclr/commit/1c0c5ac3af04bc198784a82e5985dd510a4f02b5

6 years agoAdd another test for dotnet/coreclr#17971
Carol Eidt [Wed, 20 Jun 2018 18:02:27 +0000 (11:02 -0700)]
Add another test for dotnet/coreclr#17971

Commit migrated from https://github.com/dotnet/coreclr/commit/7f3c57cf30e80a694376e5c112cbb24b9a68886f

6 years agoRemove MaskLoad tests from arm and arm64 lst files (dotnet/coreclr#18569)
Jarret Shook [Wed, 20 Jun 2018 17:39:04 +0000 (10:39 -0700)]
Remove MaskLoad tests from arm and arm64 lst files (dotnet/coreclr#18569)

This will disable the test from being run with smart in our windows arm
testing. This corresponds to the tests being deleted in dotnet/coreclr#17637.

Commit migrated from https://github.com/dotnet/coreclr/commit/b55d2b85d6829974dddf3b69e7c03bcddac95ae4

6 years agoMake sections optional, throw more descriptive error when rva can't be converted...
Amy Yu [Wed, 20 Jun 2018 17:12:39 +0000 (10:12 -0700)]
Make sections optional, throw more descriptive error when rva can't be converted to offset

Commit migrated from https://github.com/dotnet/coreclr/commit/7aff2b734c82422c23a6a19208998abca7ddddb8

6 years agoAvoid extra allocation in IDNA (dotnet/coreclr#18551)
Tarek Mahmoud Sayed [Wed, 20 Jun 2018 01:50:38 +0000 (18:50 -0700)]
Avoid extra allocation in IDNA (dotnet/coreclr#18551)

* Avoid extra allocation in IDNA

* cache the indexd value in StringBuilder

Commit migrated from https://github.com/dotnet/coreclr/commit/5d34cc6642c3f8d406f0c4bdf74b7be26b1aa0df

6 years agoFix instruction groups offset on the border between cold/hot code. (dotnet/coreclr...
Sergey Andreenko [Wed, 20 Jun 2018 01:02:11 +0000 (18:02 -0700)]
Fix instruction groups offset on the border between cold/hot code. (dotnet/coreclr#17775)

* add an additional debug printing.

* add additional checks

* Clean-up checks a bit.

* fill unused allocated chunks

* clean up checks

* fix EMITTER_STATS

* optimize padding filling

call to emitCurCodeOffs(cp) is not free.

Commit migrated from https://github.com/dotnet/coreclr/commit/d10950e4bb40643f72e97e8c0a03390694b2d2a2

6 years agoFix Complus_JitMinOpts for the first method (dotnet/coreclr#18555)
Sergey Andreenko [Wed, 20 Jun 2018 01:01:36 +0000 (18:01 -0700)]
Fix Complus_JitMinOpts for the first method (dotnet/coreclr#18555)

Commit migrated from https://github.com/dotnet/coreclr/commit/1731c34ffbffbe3157ebd1368ab5420483efe1fc

6 years agoRemove StringBuilderCache usage from System.Text.RegularExpressions (dotnet/coreclr...
Viktor Hofer [Tue, 19 Jun 2018 21:34:37 +0000 (23:34 +0200)]
Remove StringBuilderCache usage from System.Text.RegularExpressions (dotnet/coreclr#30474)

* Remove StringBuilderCache usage

* fixed buffer size, manual reverse copying & local textinfo

* Fast path for not to encode string

* avoid one span slice

* code formatting & bounds check opt

* Avoid string allocation in char class

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/d429e0291cefdba83248b3d158926df05a76528e

6 years agoFix bugs
Amy Yu [Sat, 16 Jun 2018 00:10:21 +0000 (17:10 -0700)]
Fix bugs

Commit migrated from https://github.com/dotnet/coreclr/commit/3397b0a8a1fb126bb512e35b204d9ad4ea62d813

6 years agoMerge pull request dotnet/coreclr#18357 from acmyu/sections
Amy [Tue, 19 Jun 2018 23:34:29 +0000 (16:34 -0700)]
Merge pull request dotnet/coreclr#18357 from acmyu/sections

R2RDump - Dump CompilerIdentifier and ImportSection contents

Commit migrated from https://github.com/dotnet/coreclr/commit/65f88a816b818e132dc4d5a3a0d786a961a18583

6 years agoParse entries of import section
Amy Yu [Tue, 19 Jun 2018 21:42:05 +0000 (14:42 -0700)]
Parse entries of import section

Commit migrated from https://github.com/dotnet/coreclr/commit/1c98c6e234989f20f21782670d53046ff4550b7c

6 years agoAvoid two unnecessary string.Substring calls in PunycodeDecode (dotnet/coreclr#18546)
Stephen Toub [Tue, 19 Jun 2018 21:28:32 +0000 (17:28 -0400)]
Avoid two unnecessary string.Substring calls in PunycodeDecode (dotnet/coreclr#18546)

Commit migrated from https://github.com/dotnet/coreclr/commit/90850134cb27a499a2bf8e6a545f58ae057ded41

6 years agofixes for sos on FreeBSD (dotnet/coreclr#18479)
Tomas Weinfurt [Tue, 19 Jun 2018 20:54:41 +0000 (13:54 -0700)]
fixes for  sos on FreeBSD (dotnet/coreclr#18479)

* fixes for  sos on FreeBSD

* refactore unwind detection to common block for BSD and Linux

* missing newline

* do not do libunwind detection for OSX

Commit migrated from https://github.com/dotnet/coreclr/commit/4c51b2dbbdd9bdf23552a9d26ad08a78ce1523cc

6 years agoFix struct promotion check for SIMD field (dotnet/coreclr#18548)
Carol Eidt [Tue, 19 Jun 2018 20:35:02 +0000 (13:35 -0700)]
Fix struct promotion check for SIMD field (dotnet/coreclr#18548)

A struct can have `lvIsRegArg` true but have multiple SIMD fields if it is passed by reference.

Commit migrated from https://github.com/dotnet/coreclr/commit/d3905518d08ca174ae631aebfe16314b885aa61a

6 years agoTypo (dotnet/coreclr#18550)
John Doe [Tue, 19 Jun 2018 20:26:30 +0000 (13:26 -0700)]
Typo (dotnet/coreclr#18550)

* accesible -> accessible

* acheive -> achieve

* addtional -> additional

* affars -> affairs

* approch -> approach

* archtecture -> architecture

* aritmetic -> arithmetic

* arquired -> acquired

* assigments -> assignments

* assmblies -> assemblies

Commit migrated from https://github.com/dotnet/coreclr/commit/d92a3cf483b06a7103a80e4ed8c8ee8a519a688e

6 years agoDump bytes with offset instead of rva
Amy Yu [Fri, 8 Jun 2018 23:16:23 +0000 (16:16 -0700)]
Dump bytes with offset instead of rva

Commit migrated from https://github.com/dotnet/coreclr/commit/b85874d6ac7c82e03434aee01ef9b32da64a3096

6 years agoParse and dump compiler identifier and import sections, move dump section contents...
Amy Yu [Thu, 7 Jun 2018 22:01:23 +0000 (15:01 -0700)]
Parse and dump compiler identifier and import sections, move dump section contents to own function

Commit migrated from https://github.com/dotnet/coreclr/commit/dc8c0b9c388225e19e95aaa74fcef1026331d586

6 years agoDump contents of NativeArray and NativeHashtable
Amy Yu [Thu, 7 Jun 2018 20:40:37 +0000 (13:40 -0700)]
Dump contents of NativeArray and NativeHashtable

Commit migrated from https://github.com/dotnet/coreclr/commit/10cfcbabc62b95a67d3ace771600ee20889333bd

6 years agoUse GetEntryPointIdFromOffset to get EntryPointId of generic methods
Amy Yu [Thu, 7 Jun 2018 18:53:18 +0000 (11:53 -0700)]
Use GetEntryPointIdFromOffset to get EntryPointId of generic methods

Commit migrated from https://github.com/dotnet/coreclr/commit/2cf151572ab9df6b40faad4fdcecd30d7b8d6f7c

6 years agoOutput formatting changes for unwindInfo and section contents
Amy Yu [Thu, 7 Jun 2018 01:00:58 +0000 (18:00 -0700)]
Output formatting changes for unwindInfo and section contents

Commit migrated from https://github.com/dotnet/coreclr/commit/957c4db6eb24cdbe87fcd02a658ab99b50f8d304

6 years agoMerge pull request dotnet/coreclr#18500 from acmyu/liveness
Amy [Tue, 19 Jun 2018 20:23:18 +0000 (13:23 -0700)]
Merge pull request dotnet/coreclr#18500 from acmyu/liveness

R2RDump - Output GcSlot liveness interweaved with disasm instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/3643c064f7b41558e08ef16337d8c0379d238138

6 years agoSave name of dll in constant, use tab instead of spaces
Amy Yu [Tue, 19 Jun 2018 18:22:03 +0000 (11:22 -0700)]
Save name of dll in constant, use tab instead of spaces

Commit migrated from https://github.com/dotnet/coreclr/commit/a5c843564c4dd8301b0c424f6041fada2921b1ab

6 years agoUpdate CoreClr to preview1-26619-04 (dotnet/coreclr#18540)
dotnet-maestro-bot [Tue, 19 Jun 2018 15:39:01 +0000 (08:39 -0700)]
Update CoreClr to preview1-26619-04 (dotnet/coreclr#18540)

Commit migrated from https://github.com/dotnet/coreclr/commit/473d9b09c7e000480f41021c94fbffeae27cb179

6 years agoPInvoke calli support for CoreRT (dotnet/coreclr#18534)
Jan Kotas [Tue, 19 Jun 2018 12:58:44 +0000 (05:58 -0700)]
PInvoke calli support for CoreRT (dotnet/coreclr#18534)

* Ifdef out NGen-specific PInvoke calli inlining limitation for CoreCLR

This limitation seems to be a left-over from effort to eliminate JITing with fragile NGen.

* Delete dead partial-trust related code

* Allow PInvoke stub inlining

* Add convertCalliToCall JIT/EE interface method

* Update superpmi

Commit migrated from https://github.com/dotnet/coreclr/commit/10111af6ba5e18f4a9b9c6eb80d49ed545604cfa

6 years agoUpdate BuildTools, CoreClr, CoreFx, PgoData to preview1-02918-02, preview1-26619...
dotnet-maestro-bot [Tue, 19 Jun 2018 11:31:55 +0000 (04:31 -0700)]
Update BuildTools, CoreClr, CoreFx, PgoData to preview1-02918-02, preview1-26619-01, preview1-26617-01, master-20180619-0054, respectively (dotnet/coreclr#18518)

Commit migrated from https://github.com/dotnet/coreclr/commit/57375e5cd91b3554e0e9690bba56d7fc341f8ce7

6 years agoRemoved dead strings from corerror.xml
Henry Sharber [Tue, 19 Jun 2018 01:41:02 +0000 (21:41 -0400)]
Removed dead strings from corerror.xml

Commit migrated from https://github.com/dotnet/coreclr/commit/cc5dcbe6d1f5a799deab8064081b4e760e0df38e

6 years agoRemove dead strings mscorrc.rc
Henry Sharber [Mon, 18 Jun 2018 02:31:46 +0000 (22:31 -0400)]
Remove dead strings mscorrc.rc

Commit migrated from https://github.com/dotnet/coreclr/commit/ccf2c3eba2d833743a127be7ad3d2143bfe04091

6 years agogenPutArgStk needs to check for FIELD_LIST first (dotnet/coreclr#18499)
Carol Eidt [Tue, 19 Jun 2018 00:11:56 +0000 (17:11 -0700)]
genPutArgStk needs to check for FIELD_LIST first (dotnet/coreclr#18499)

When a struct is passed on the stack using `FIELD_LIST`, the type of the `FIELD_LIST` is the type of its first field. If that type was a struct type (i.e. a SIMD type), `genPutArgStk` would assume that it was the non-`FIELD_LIST` case.

Fix dotnet/coreclr#18497

Commit migrated from https://github.com/dotnet/coreclr/commit/e9946c0de3bcab0d09ce5f10a039b37d6497d4cb

6 years agoDelete PinnableBufferCache (dotnet/corertdotnet/coreclr#5950)
Jan Kotas [Mon, 18 Jun 2018 19:00:33 +0000 (12:00 -0700)]
Delete PinnableBufferCache (dotnet/corertdotnet/coreclr#5950)

Port https://github.com/dotnet/coreclr/pull/18360 to CoreRT

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/108ead41ca9243d4c6e1c6f3866fe986c44e31a1

6 years agoCorrectly return early if the test fails (dotnet/coreclr#18529)
Jarret Shook [Mon, 18 Jun 2018 21:07:39 +0000 (14:07 -0700)]
Correctly return early if the test fails (dotnet/coreclr#18529)

Commit migrated from https://github.com/dotnet/coreclr/commit/a74bbaf2d0cc1f9a9bb9104d204c45dd0c0eb2dc

6 years agoAdd public implementation WindowsRuntime ExceptionSupport (dotnet/coreclr#18494)
Luqun Lou [Mon, 18 Jun 2018 20:24:48 +0000 (13:24 -0700)]
Add public implementation WindowsRuntime ExceptionSupport (dotnet/coreclr#18494)

Commit migrated from https://github.com/dotnet/coreclr/commit/d4bbfb39572a2e1cb0708c7c94d0c05aee69d813

6 years agoImprove Intel hardware intrinsic APIs (dotnet/coreclr#17637)
Fei Peng [Mon, 18 Jun 2018 20:17:41 +0000 (13:17 -0700)]
Improve Intel hardware intrinsic APIs (dotnet/coreclr#17637)

* Improve Intel hardware intrinsic APIs

* Simplify Avx.Extract non-const fallback

Commit migrated from https://github.com/dotnet/coreclr/commit/ea58e86b476c7a596b43b12f31b5bccfdbbeca67

6 years agotemporarily disable pthread based named mutexes on FreeBSD (dotnet/coreclr#18480)
Tomas Weinfurt [Mon, 18 Jun 2018 19:54:23 +0000 (12:54 -0700)]
temporarily disable pthread based named mutexes on FreeBSD (dotnet/coreclr#18480)

Commit migrated from https://github.com/dotnet/coreclr/commit/ddca735a59327dedc681900e7d484491b769b7d6

6 years agoDocument span lifetime issue in CreateSpan (dotnet/corefxdotnet/coreclr#30490) (dotne...
dotnet bot [Mon, 18 Jun 2018 17:45:42 +0000 (10:45 -0700)]
Document span lifetime issue in CreateSpan (dotnet/corefxdotnet/coreclr#30490) (dotnet/coreclr#18528)

The language rules around span safety that C# and F# adhere to assume
there is no way to create a `Span<T>` wrapper over a `ref` local /
parameter. This means `ref` inputs into a method are not considered when
calculating the allowed lifetime of a returned `Span<T>`. Hence both
CreateSpan and CreateReadOnlySpan will be assumed to have heap lifetime
even when provided stack based inputs. Example:

``` c#
Span<int> Example() {
  int i = 42;
  Span<int> span = MemoryMarshal.CreateSpan(ref i, length: 1);
  return span; // C# and F# will allow this
}
```

In this case the actual lifetime of `span` is that of `i`. Yet the
compiler doesn't consider the `ref i` input and hence believes this must
be heap based and hence safe to return out of the method.

This is okay as these methods are unsafe. But want to explicitly
document that fact.

More information on the safety rules can be found in the [span safety
proposal](https://github.com/dotnet/csharplang/blob/master/proposals/csharp-7.2/span-safety.md)

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/ac637552982717e72e473df03d0994e65c2dccd8

6 years agoTypo (dotnet/coreclr#18520)
John Doe [Mon, 18 Jun 2018 17:45:13 +0000 (10:45 -0700)]
Typo (dotnet/coreclr#18520)

* Acutal -> Actual

* addtional -> additional

* agressive -> aggressive

* agument -> argument

* Alignement -> Alignment

* alredy -> already

* MAnaged -> Managed

* analagous -> analogous

* aquire -> acquire

* arbitary -> arbitrary

Commit migrated from https://github.com/dotnet/coreclr/commit/22bfefbc787629d9d5637cd37fc92701b95dcea0

6 years agoRe-Enable StructABI test for xplat (dotnet/coreclr#18496)
Jarret Shook [Mon, 18 Jun 2018 17:32:53 +0000 (10:32 -0700)]
Re-Enable StructABI test for xplat (dotnet/coreclr#18496)

Commit migrated from https://github.com/dotnet/coreclr/commit/6a35855005898b243191c17496fa137d09926201

6 years agomach_absolute_time as the primary clock source on macOS (corefxdotnet/coreclr#30391...
Andrey Akinshin [Mon, 18 Jun 2018 17:11:32 +0000 (13:11 -0400)]
mach_absolute_time as the primary clock source on macOS (corefxdotnet/coreclr#30391) (dotnet/coreclr#18505)

macOS 10.12+ supports clock_gettime (HAVE_CLOCK_MONOTONIC is defined)
However, mach_absolute_time has better resolution and should be used
as the primary clock source.

Commit migrated from https://github.com/dotnet/coreclr/commit/a88923778b841a51d9656f714f171115baf7ca80

6 years ago[JIT/ARM] Fix Compiler::lvaFrameAddress
Konstantin Baladurin [Mon, 18 Jun 2018 12:49:40 +0000 (15:49 +0300)]
[JIT/ARM] Fix Compiler::lvaFrameAddress

Use sp-based offset only if r10 reserved or offset is lower than
encoding limit.

Commit migrated from https://github.com/dotnet/coreclr/commit/d513e316e1a5f5e8e482193c736e90d51aba1f88

6 years agoUpdate CoreClr, CoreFx to preview1-26616-03, preview1-26616-02, respectively (dotnet...
dotnet-maestro-bot [Sat, 16 Jun 2018 18:54:59 +0000 (11:54 -0700)]
Update CoreClr, CoreFx to preview1-26616-03, preview1-26616-02, respectively (dotnet/coreclr#18503)

Commit migrated from https://github.com/dotnet/coreclr/commit/71f4199f7dd043c4901a187b9bd88ab40e2b87e2

6 years agoUpdate BuildTools, CoreClr to preview1-02915-01, preview1-26616-01, respectively...
dotnet-maestro-bot [Sat, 16 Jun 2018 05:36:31 +0000 (22:36 -0700)]
Update BuildTools, CoreClr to preview1-02915-01, preview1-26616-01, respectively (dotnet/coreclr#18495)

Commit migrated from https://github.com/dotnet/coreclr/commit/45da72ca0f1493f793e30f39a7da0e59acb8bdbc

6 years agoAdd missing registers enum
Amy Yu [Sat, 16 Jun 2018 00:37:10 +0000 (17:37 -0700)]
Add missing registers enum

Commit migrated from https://github.com/dotnet/coreclr/commit/377718dffb619796c4abb2751b934c03e4ab7db8

6 years agoInterweave gcslot liveness with disasm
Amy Yu [Sat, 16 Jun 2018 00:07:41 +0000 (17:07 -0700)]
Interweave gcslot liveness with disasm

Commit migrated from https://github.com/dotnet/coreclr/commit/c77c97e4d08ad8cafdae00128496b214dc2a2098

6 years agoUse DumpInstruction instead of code block
Amy Yu [Fri, 15 Jun 2018 18:46:49 +0000 (11:46 -0700)]
Use DumpInstruction instead of code block

Commit migrated from https://github.com/dotnet/coreclr/commit/1df3d7978e69166fa366c5788d114acf1c743d70

6 years agoMerge pull request dotnet/coreclr#18474 from acmyu/gc
Amy [Fri, 15 Jun 2018 23:36:40 +0000 (16:36 -0700)]
Merge pull request dotnet/coreclr#18474 from acmyu/gc

R2RDump - Get GC slot liveness code offset

Commit migrated from https://github.com/dotnet/coreclr/commit/30a7daa5d0fd4102ef053d1291775140be610495

6 years agoMerge pull request dotnet/coreclr#18379 from acmyu/disasm
Amy [Fri, 15 Jun 2018 23:36:18 +0000 (16:36 -0700)]
Merge pull request dotnet/coreclr#18379 from acmyu/disasm

R2RDump - Print disassembly to text buffer

Commit migrated from https://github.com/dotnet/coreclr/commit/d77fd94014bd4fc67df03a731498f9b8fd1e0e42

6 years agoDelete bitrotten appdomain agility checks (dotnet/coreclr#18489)
Jan Kotas [Fri, 15 Jun 2018 22:44:36 +0000 (15:44 -0700)]
Delete bitrotten appdomain agility checks (dotnet/coreclr#18489)

Fixes dotnet/coreclr#18484

Commit migrated from https://github.com/dotnet/coreclr/commit/6bb3f84d42b9756c5fa18158db8f724d57796296

6 years agoUse correct field offset in genPutArgStkFieldList (dotnet/coreclr#18483)
Carol Eidt [Fri, 15 Jun 2018 21:46:19 +0000 (14:46 -0700)]
Use correct field offset in genPutArgStkFieldList (dotnet/coreclr#18483)

* Use correct field offset in genPutArgStkFieldList

Fix dotnet/coreclr#18482

* formatting

* Add the new test to the arm and arm64 test lists

Commit migrated from https://github.com/dotnet/coreclr/commit/13954f2b3072866be61c273d17f7b4fd2d1e6099

6 years agoAvoid some virtual dispatch in Encodings (dotnet/coreclr#18487)
Stephen Toub [Fri, 15 Jun 2018 21:45:44 +0000 (17:45 -0400)]
Avoid some virtual dispatch in Encodings (dotnet/coreclr#18487)

- Seal some internal overrides
- In the more common encodings, add overrides of GetBytes/GetByteCount/GetChars/GetCharCount to avoid another layer of virtuals from the base class (they can call to an internal non-virtual).

Commit migrated from https://github.com/dotnet/coreclr/commit/acd35fd3ce18ebaf7b0edbd933ed2d4f17b8db78

6 years agoUse IntPtr instead of long for pointers
Amy Yu [Fri, 15 Jun 2018 21:17:06 +0000 (14:17 -0700)]
Use IntPtr instead of long for pointers

Commit migrated from https://github.com/dotnet/coreclr/commit/5a0278defa155de8c0d1f2b6f1d51841006f97cd

6 years agoFix bugs from trying to get transitions for untracked slots when it's not supposed to
Amy Yu [Fri, 15 Jun 2018 20:00:15 +0000 (13:00 -0700)]
Fix bugs from trying to get transitions for untracked slots when it's not supposed to

Commit migrated from https://github.com/dotnet/coreclr/commit/40f0203513823cb52daa352ae0f444cbc2b6daea