commit-bot@chromium.org [Mon, 12 May 2014 20:42:21 +0000 (20:42 +0000)]
re-land hide get/setLocalMatrix
This reverts commit
b1d702a43b07934f5b001b1b09db2c57ede909a1.
TBR=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
279903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14702
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 20:40:29 +0000 (20:40 +0000)]
rename rebaseline_server JSON constants to be more consistent
(no behavioral change, no change to JSON file format)
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
287473002
git-svn-id: http://skia.googlecode.com/svn/trunk@14701
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 20:23:34 +0000 (20:23 +0000)]
bench rebase after
261d015
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
280683002
git-svn-id: http://skia.googlecode.com/svn/trunk@14700
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 12 May 2014 18:12:24 +0000 (18:12 +0000)]
apply localmatrix in pre-order, to match other shaders
BUG=skia:
Review URL: https://codereview.chromium.org/
280293002
git-svn-id: http://skia.googlecode.com/svn/trunk@14699
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 12 May 2014 17:18:45 +0000 (17:18 +0000)]
add new perlin noise gm to test localmatrix
BUG=skia:
Review URL: https://codereview.chromium.org/
283533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14698
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 15:48:38 +0000 (15:48 +0000)]
Clean up global gSkSuppressFontCachePurgeSpew.
No one is using it except to flick it to true to shut up the spew,
but the spew is already guarded by #ifdef SPEW_PURGE_STATUS. Let's
leave it to SPEW_PURGE_STATUS.
Noticed this specificially when TSAN complained about FontScalerBench
modifying it in a thread-unsafe way.
BUG=skia:1792
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
264333008
git-svn-id: http://skia.googlecode.com/svn/trunk@14697
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 15:38:00 +0000 (15:38 +0000)]
Make gMask_00FF00FF a constant
This is to optimize SkAlphaMulQ() in PIC mode. With the visibility=default
symbol the constant is not known at compile time (and is not a constant), but
instead is fetched through a double indirection through GOT. The function is
quite hot on one of the chromium benchmarks:
rasterize_and_record_micro.key_silk_cases.
This change replaces the symbol with a compile-time constant. As a bonus the
variable is not exported from the dynamic library, i. e. a cleaner library
interface.
See specific performance improvements on Android here:
http://goo.gl/iMuTDt
R=skyostil@chromium.org, tomhudson@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com
Author: pasko@chromium.org
Review URL: https://codereview.chromium.org/
270473003
git-svn-id: http://skia.googlecode.com/svn/trunk@14696
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 15:37:20 +0000 (15:37 +0000)]
add --readJsonSummaryPath to render_pictures
BUG=skia:1942
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
273783004
git-svn-id: http://skia.googlecode.com/svn/trunk@14695
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 14:36:43 +0000 (14:36 +0000)]
Adds the ability to filter bench expectations in builder/config level.
BUG=skia:2539
NOTRY=true
R=rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
277163002
git-svn-id: http://skia.googlecode.com/svn/trunk@14694
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 14:16:19 +0000 (14:16 +0000)]
Improved x86 SSE build and run-time checks.
Replaces the current build/run-time checks for SSE level in
opts_check_x86.cpp with a simpler and more future-proof version.
Also adds SSE versions 4.1 and 4.2 to the config file.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14644
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
272503006
git-svn-id: http://skia.googlecode.com/svn/trunk@14693
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 14:12:38 +0000 (14:12 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
BUG=skia:2187
Committed: http://code.google.com/p/skia/source/detail?r=14651
R=reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
265973002
git-svn-id: http://skia.googlecode.com/svn/trunk@14692
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 12 May 2014 13:35:55 +0000 (13:35 +0000)]
remove unused Kernel33MaskFilter
R=robertphillips@google.com
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
280233002
git-svn-id: http://skia.googlecode.com/svn/trunk@14691
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 10 May 2014 12:57:48 +0000 (12:57 +0000)]
bench rebase after
108eddb
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
275353002
git-svn-id: http://skia.googlecode.com/svn/trunk@14690
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 10 May 2014 03:04:40 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14689
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 9 May 2014 20:52:23 +0000 (20:52 +0000)]
add localmatrix param to asNewEffect
BUG=skia:
Review URL: https://codereview.chromium.org/
278983002
git-svn-id: http://skia.googlecode.com/svn/trunk@14688
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 20:46:48 +0000 (20:46 +0000)]
Factor GrTexture into public GrTexture and private GrTextureImpl.
Committed: http://code.google.com/p/skia/source/detail?r=14680
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14687
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 20:28:11 +0000 (20:28 +0000)]
add localmatrix parameter to shader's asNewEffect
BUG=skia:
R=bsalomon@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
278963002
git-svn-id: http://skia.googlecode.com/svn/trunk@14686
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 9 May 2014 20:06:57 +0000 (20:06 +0000)]
Revert "remove SK_SUPPORT_LEGACY_BUILDMIPMAP"
This reverts commit
9acd04797101990af23f5c374b7dfcbaac12fd2b.
git-svn-id: http://skia.googlecode.com/svn/trunk@14685
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 19:54:42 +0000 (19:54 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP
TBR=djsollen@google.com
NOTRY=True
Author: reed@google.com
Review URL: https://codereview.chromium.org/
271253002
git-svn-id: http://skia.googlecode.com/svn/trunk@14684
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 19:25:43 +0000 (19:25 +0000)]
Un-swap underline position and thickness calcualtions in DirectWrite.
The change at r13635 got these backwards.
git-svn-id: http://skia.googlecode.com/svn/trunk@14683
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Fri, 9 May 2014 18:08:24 +0000 (18:08 +0000)]
Flatten resources directory
On android trybots, the files in a subdirectory weren't being
loaded onto the device. Consequently, the ImageDecoderOptions
test was not testing anything. I had to relax that unit test
to reflect the existing behavior of our libjpeg decoder on
Android.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
264583007
git-svn-id: http://skia.googlecode.com/svn/trunk@14682
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 18:02:51 +0000 (18:02 +0000)]
Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. (https://codereview.chromium.org/
275903002/)
Reason for revert:
Breaks chrome build.
Original issue's description:
> Factor GrTexture into public GrTexture and private GrTextureImpl.
>
> Committed: http://code.google.com/p/skia/source/detail?r=14680
R=jvanverth@google.com, robertphillips@google.com
TBR=jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
278073002
git-svn-id: http://skia.googlecode.com/svn/trunk@14681
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 17:37:55 +0000 (17:37 +0000)]
Factor GrTexture into public GrTexture and private GrTextureImpl.
R=jvanverth@google.com, robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14680
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 9 May 2014 17:24:31 +0000 (17:24 +0000)]
Revert "Flatten resources directory"
Review URL: https://codereview.chromium.org/
278033002
git-svn-id: http://skia.googlecode.com/svn/trunk@14679
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 16:24:06 +0000 (16:24 +0000)]
Flatten resources directory
On android trybots, the files in a subdirectory weren't being
loaded onto the device. Consequently, the ImageDecoderOptions
test was not testing anything. I had to relax that unit test
to reflect the existing behavior of our libjpeg decoder on
Android.
R=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
264583007
git-svn-id: http://skia.googlecode.com/svn/trunk@14678
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 15:42:07 +0000 (15:42 +0000)]
Revert of hide get/setLocalMatrix (https://codereview.chromium.org/
279563002/)
Reason for revert:
broke gms
Original issue's description:
> hide get/setLocalMatrix
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14675
R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org
TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@google.com
Review URL: https://codereview.chromium.org/
278903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14677
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 15:22:41 +0000 (15:22 +0000)]
Allow for no pdf rasterizers in gm.
Our poppler does not build properly with VS2013, but using
gyp_skia -Dskia_enable_poppler_enabled=0
also does not build due to kPDFRasterizers being statically empty.
This adds a do nothing, not run by default 'pdf rasterizer'.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
270263009
git-svn-id: http://skia.googlecode.com/svn/trunk@14676
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 15:19:48 +0000 (15:19 +0000)]
hide get/setLocalMatrix
BUG=skia:
R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
279563002
git-svn-id: http://skia.googlecode.com/svn/trunk@14675
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 15:04:18 +0000 (15:04 +0000)]
Add a dry-run option to gyp_skia.
There are times when I want to do some low-level fiddling with the gyp
command. It's nice to start with whatever the 'default' is, and it's also
nice to peek behind the curtain to see what's going on. To this end,
a '--dry-run' in the argument list will spit out the command to run,
rather than running the command.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
278893002
git-svn-id: http://skia.googlecode.com/svn/trunk@14674
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 15:00:10 +0000 (15:00 +0000)]
Use a tilegrid for bench_playback.
Using --tile wasn't a fair comparison: SkPicture didn't get to optimize its
playback, but SkRecord did. Numbers here are starting to agree with what I saw
in telemetry: SkRecord with culling is on average at 0.8-0.9 of the speed of
SkPicture (10-30% slower) than SkPicture SkPicture with a tile grid, but some
in some cases it's down at 0.3, taking almost 4x as long to draw a 256x256 tile.
0.4x tabl_mercurynews.skp 0.109889 0.252483
0.5x tabl_cnet.skp 0.250367 0.527789
1.0x desk_mapsvg.skp 1.48698 1.49939
1.2x desk_yahoogames.skp 0.07745 0.065343
0.9x tabl_mlb.skp 0.294509 0.312505
0.8x tabl_hsfi.skp 0.250678 0.316337
0.6x tabl_worldjournal.skp 0.510204 0.828798
0.7x desk_facebook.skp 0.318981 0.483744
0.9x desk_googlehome.skp 0.06983 0.078964
0.9x desk_tigersvg.skp 0.019232 0.022611
1.0x desk_youtubetvvideo.skp 0.401614 0.401862
1.1x desk_amazon.skp 0.415552 0.362111
0.7x desk_yahooanswers.skp 0.237995 0.358659
0.7x desk_twitter.skp 0.323466 0.439772
1.2x desk_fontwipe.skp 0.121577 0.097845
1.1x desk_css3gradients.skp 0.395335 0.362087
0.9x desk_googlespreadsheet.skp 0.362056 0.406688
1.0x tabl_frantzen.skp 15.2475 14.8521
0.6x desk_forecastio.skp 0.154236 0.276881
0.7x desk_pinterest.skp 0.077433 0.11324
0.5x tabl_cuteoverload.skp 0.173014 0.361815
0.5x tabl_androidpolice.skp 0.225903 0.465608
0.6x tabl_vnexpress.skp 0.151075 0.241104
0.6x tabl_nytimes.skp 0.06515 0.117229
0.8x desk_ebay.skp 0.353437 0.422586
0.8x tabl_deviantart.skp 0.223103 0.295496
1.1x tabl_culturalsolutions.skp 0.551348 0.506104
0.9x mobi_wikipedia.skp 0.302603 0.337292
0.6x desk_linkedin.skp 0.165102 0.276149
0.6x tabl_digg.skp 0.159074 0.281529
1.2x desk_oldinboxapp.skp 0.019815 0.017146
1.0x tabl_nofolo.skp 5.18914 5.42784
0.6x desk_jsfiddlehumperclip.skp 0.076869 0.133665
1.0x desk_blogger.skp 0.206702 0.19688
0.8x desk_espn.skp 0.346386 0.451871
1.0x desk_samoasvg.skp 3.60037 3.43147
0.8x desk_booking.skp 0.338818 0.438267
1.3x desk_yahoosports.skp 0.603811 0.470052
0.6x tabl_engadget.skp 0.248995 0.404372
0.7x desk_wowwiki.skp 0.325801 0.479559
0.8x tabl_ukwsj.skp 0.326985 0.405971
0.9x tabl_gmail.skp 0.2604 0.276744
0.9x desk_googleplus.skp 8.08874 8.71105
1.1x tabl_slashdot.skp 0.559332 0.524313
0.9x desk_gmailthread.skp 0.671569 0.74134
0.8x desk_weather.skp 0.194162 0.247681
1.3x desk_rectangletransition.skp 0.218372 0.173685
0.6x tabl_gamedeksiam.skp 0.243374 0.4134
0.9x desk_jsfiddlebigcar.skp 0.162282 0.186035
0.3x desk_pokemonwiki.skp 0.202878 0.778934
0.7x tabl_googleblog.skp 0.141203 0.209971
0.8x desk_sfgate.skp 0.229078 0.275248
1.0x desk_chalkboard.skp 2.28916 2.20101
0.9x tabl_googlecalendar.skp 0.687155 0.75413
1.1x tabl_gspro.skp 0.186399 0.169522
0.5x desk_googlespreadsheetdashed.skp 0.512622 1.02815
0.6x desk_mobilenews.skp 0.183506 0.293929
0.8x tabl_techmeme.skp 0.193074 0.229106
1.2x desk_carsvg.skp 5.33047 4.34058
0.5x desk_youtube.skp 0.132663 0.248236
0.7x tabl_pravda.skp 0.21644 0.308788
1.1x desk_gws.skp 0.698107 0.625371
0.5x tabl_mozilla.skp 0.189638 0.386801
1.0x desk_baidu.skp 0.353438 0.355965
1.1x tabl_sahadan.skp 0.476226 0.416737
summary: ≥0.3x (A 0.9x, G 0.8x) ≤1.3x
Whole SKP playback speed is fine of course.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
277653002
git-svn-id: http://skia.googlecode.com/svn/trunk@14673
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 14:59:29 +0000 (14:59 +0000)]
Add timing to dump_record.
Prints microsecond timing for each command in the left-hand column:
optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp
4.0 1 Save
2075.0 2 DrawRect
104.0 3 BoundedDrawPosTextH
135.4 4 DrawRect
9.4 5 DrawRect
5.6 6 DrawRect
8.2 7 DrawRect
6.8 8 DrawRect
...
(I'm sure Rietveld will just mangle the crap out of that. It's helpfully right-aligned.)
To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw,
and time it command-by-command.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
272723007
git-svn-id: http://skia.googlecode.com/svn/trunk@14672
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 14:39:26 +0000 (14:39 +0000)]
update canvas-layer-state (which should be deleted soon)
R=reed@android.com
TBR=reed
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
274133002
git-svn-id: http://skia.googlecode.com/svn/trunk@14671
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 14:33:55 +0000 (14:33 +0000)]
QuadTree: don't leak deferred inserts past clear()
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
277713003
git-svn-id: http://skia.googlecode.com/svn/trunk@14670
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 14:29:32 +0000 (14:29 +0000)]
cleanup GrContext resource cache api
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275563005
git-svn-id: http://skia.googlecode.com/svn/trunk@14669
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 14:16:11 +0000 (14:16 +0000)]
commit GM actuals as expectations for all tests, marking them as unreviewed
BUG=skia:1578
NOTRY=True
R=caryclark@google.com
TBR=caryclark
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
279773003
git-svn-id: http://skia.googlecode.com/svn/trunk@14668
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 14:11:19 +0000 (14:11 +0000)]
Fix typo in SkFontHost_win.cpp in comment.
We want the 'size', not the 'side'.
git-svn-id: http://skia.googlecode.com/svn/trunk@14667
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 9 May 2014 14:08:28 +0000 (14:08 +0000)]
Add missing sfnt header files to gyp.
This makes finding these files easier in IDEs.
git-svn-id: http://skia.googlecode.com/svn/trunk@14666
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 13:53:38 +0000 (13:53 +0000)]
Disable filtering in draw Bitmap operation when pixels are aligned
The check is now performed in the callers of internalDrawBitmap() to
avoid retrieve the texture with wrong filter mode when the pixels were
aligned.
This bug was spotted in Chrome for Android: Chrome for Androids's
Canvas drawImage loses fidelity in canvases larger than 64k pixels.
BUG=chromium:231916
R=bsalomon@google.com, robertphillips@google.com
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Author: siglesias@igalia.com
Review URL: https://codereview.chromium.org/
264303008
git-svn-id: http://skia.googlecode.com/svn/trunk@14665
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 12:00:19 +0000 (12:00 +0000)]
update Test-Linux-Bare-NoGPU-Arm8_64-Debug expectations
R=djsollen@google.com
TBR=djsollen
NOTRY=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
276893002
git-svn-id: http://skia.googlecode.com/svn/trunk@14664
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Fri, 9 May 2014 04:30:09 +0000 (04:30 +0000)]
Point to skiadocs in our README.
This seems to be the canonical location for all skia documentation
nowadays.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
276483008
git-svn-id: http://skia.googlecode.com/svn/trunk@14663
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 03:18:41 +0000 (03:18 +0000)]
reland "extract some common code from PictureRenderer"
re-lands https://codereview.chromium.org/
273703006/
NOTRY=True
R=bungeman@google.com, djsollen@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
278633002
git-svn-id: http://skia.googlecode.com/svn/trunk@14662
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 9 May 2014 03:05:30 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14661
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 9 May 2014 00:05:52 +0000 (00:05 +0000)]
Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. (https://codereview.chromium.org/
265973002/)
Reason for revert:
This is breaking compilation of cc_unittests in Chrome
Original issue's description:
> Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
>
> Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
>
> BUG=skia:2187
>
> Committed: http://code.google.com/p/skia/source/detail?r=14651
R=reed@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2187
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
275713002
git-svn-id: http://skia.googlecode.com/svn/trunk@14660
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 23:24:05 +0000 (23:24 +0000)]
Fix rendering artifacts in pull-saveLayers-forward mode
This CL fixes 2 bugs in the pre-rendering of saveLayers:
1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed
2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state
It also reduces the number of layers that are pre-rendered when a BBH is not in use.
Committed: http://code.google.com/p/skia/source/detail?r=14650
R=bsalomon@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
267293007
git-svn-id: http://skia.googlecode.com/svn/trunk@14659
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 21:15:20 +0000 (21:15 +0000)]
rebaseline_server JSON: pass category values as values, not keys
BUG=skia:1758
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
270413002
git-svn-id: http://skia.googlecode.com/svn/trunk@14658
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 8 May 2014 19:41:48 +0000 (19:41 +0000)]
Remove non-existent header file from Android opts.
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
274793004
git-svn-id: http://skia.googlecode.com/svn/trunk@14657
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 19:22:52 +0000 (19:22 +0000)]
return null if subshader fails
TBR=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
279573002
git-svn-id: http://skia.googlecode.com/svn/trunk@14656
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:58:32 +0000 (18:58 +0000)]
Split Star into Star (stores nothing) and List (stores matches).
Just noticed that the cull noop pattern (PushCull, Star<NoOp>, PopCull)
would trigger the Star that stores matches. We certainly don't need
those matches here, so instead of magically determining which Star you
need, we'll make you tell us which one you want.
No one but List's unit test needs List. I'll leave it for now, but we
might find it's not useful.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com, bungeman@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
275623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14655
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 8 May 2014 18:45:20 +0000 (18:45 +0000)]
Revert r14650 (Fix rendering artifacts in pull-saveLayers-forward mode - https://codereview.chromium.org/
267293007) due to unit test failures
git-svn-id: http://skia.googlecode.com/svn/trunk@14654
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:17:51 +0000 (18:17 +0000)]
Noop away PushCull/PopCull pairs with nothing between them.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
277613002
git-svn-id: http://skia.googlecode.com/svn/trunk@14653
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:13:23 +0000 (18:13 +0000)]
store map ptr in GrGeometryBuffer base class
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
272503009
git-svn-id: http://skia.googlecode.com/svn/trunk@14652
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:13:15 +0000 (18:13 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
BUG=skia:2187
R=reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
265973002
git-svn-id: http://skia.googlecode.com/svn/trunk@14651
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:13:07 +0000 (18:13 +0000)]
Fix rendering artifacts in pull-saveLayers-forward mode
This CL fixes 2 bugs in the pre-rendering of saveLayers:
1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed
2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state
It also reduces the number of layers that are pre-rendered when a BBH is not in use.
R=bsalomon@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
267293007
git-svn-id: http://skia.googlecode.com/svn/trunk@14650
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 16:23:56 +0000 (16:23 +0000)]
Revert of extract some common code from PictureRenderer (https://codereview.chromium.org/
273703006/)
Reason for revert:
breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue.
Original issue's description:
> extract some common code from PictureRenderer
>
> Committed: http://code.google.com/p/skia/source/detail?r=14638
R=borenet@google.com, epoger@google.com
TBR=borenet@google.com, epoger@google.com
NOTREECHECKS=true
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
274463004
git-svn-id: http://skia.googlecode.com/svn/trunk@14649
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:40:06 +0000 (15:40 +0000)]
rebaseline_server: add link to other result sets from main UI
BUG=skia:2529
NOTREECHECKS=True
NOTRY=True
(SkipBuildbotRuns)
R=caryclark@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
267363010
git-svn-id: http://skia.googlecode.com/svn/trunk@14648
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:29:57 +0000 (15:29 +0000)]
Fix Moz2D build
BUG=skia:2221
R=george@mozilla.com, reed@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
277593003
git-svn-id: http://skia.googlecode.com/svn/trunk@14647
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:27:52 +0000 (15:27 +0000)]
Revert of Improved x86 SSE build and run-time checks. (https://codereview.chromium.org/
272503006/)
Reason for revert:
Windows builders breaking. :(
Original issue's description:
> Improved x86 SSE build and run-time checks.
>
> Replaces the current build/run-time checks for SSE level in
> opts_check_x86.cpp with a simpler and more future-proof version.
> Also adds SSE versions 4.1 and 4.2 to the config file.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14644
R=reed@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com
TBR=djsollen@google.com, henrik.smiding@intel.com, joakim.landberg@intel.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
277593004
git-svn-id: http://skia.googlecode.com/svn/trunk@14646
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:27:02 +0000 (15:27 +0000)]
Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2816
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
275593002
git-svn-id: http://skia.googlecode.com/svn/trunk@14645
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:17:50 +0000 (15:17 +0000)]
Improved x86 SSE build and run-time checks.
Replaces the current build/run-time checks for SSE level in
opts_check_x86.cpp with a simpler and more future-proof version.
Also adds SSE versions 4.1 and 4.2 to the config file.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
272503006
git-svn-id: http://skia.googlecode.com/svn/trunk@14644
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:14:57 +0000 (15:14 +0000)]
Greenify bench bot Perf-Android-Nexus4-Adreno320-Arm7-Release at build 1643
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
279533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14643
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 8 May 2014 15:13:52 +0000 (15:13 +0000)]
Fix some references to Makefiles in gyp_skia.
BUG=None
TEST=None, no functional changes. Just updating documentation.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
263083006
git-svn-id: http://skia.googlecode.com/svn/trunk@14642
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:12:43 +0000 (15:12 +0000)]
Remove global SkRandoms from ChartBench.
TSAN picked them up while running DM.
BUG=skia:1792
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
278523005
git-svn-id: http://skia.googlecode.com/svn/trunk@14641
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:00:24 +0000 (15:00 +0000)]
Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2818
R=bsalomon@google.com, bensong@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
273593009
git-svn-id: http://skia.googlecode.com/svn/trunk@14640
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 14:57:58 +0000 (14:57 +0000)]
Greenify bench bot Perf-Android-Nexus4-Adreno320-Arm7-Release at build 1644
R=bsalomon@google.com, bensong@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
277563005
git-svn-id: http://skia.googlecode.com/svn/trunk@14639
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 14:48:44 +0000 (14:48 +0000)]
extract some common code from PictureRenderer
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
273703006
git-svn-id: http://skia.googlecode.com/svn/trunk@14638
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 04:57:58 +0000 (04:57 +0000)]
Greenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2207
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
276593004
git-svn-id: http://skia.googlecode.com/svn/trunk@14637
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 8 May 2014 03:05:29 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14636
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 02:25:44 +0000 (02:25 +0000)]
bench rebase after
37f6e62
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
270593005
git-svn-id: http://skia.googlecode.com/svn/trunk@14635
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 22:59:38 +0000 (22:59 +0000)]
Move paints to the front of draw structs.
The order of arguments in these structs is arbitrary, so we might as well arrange them to optimize something. Putting the paints at the front means the logic to find the paint is a lot more concise: it's usually just ptr+0, or *(ptr+0) when the SkPaint is optional.
This considerably reduces the size of the jump table in IsDraw::operator().
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
272673002
git-svn-id: http://skia.googlecode.com/svn/trunk@14634
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 22:26:37 +0000 (22:26 +0000)]
add localmatrix-shader
BUG=skia:
R=scroggo@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
272593002
git-svn-id: http://skia.googlecode.com/svn/trunk@14633
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 7 May 2014 21:31:09 +0000 (21:31 +0000)]
First pass at pre-rendering saveLayers for GPU
https://codereview.chromium.org/
261663003/
git-svn-id: http://skia.googlecode.com/svn/trunk@14632
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 21:16:09 +0000 (21:16 +0000)]
Convert all SkRecordPattern matchers into SkRecord mutators.
- Allow any return type from SkRecord mutators and visitors;
- update existing calls to mutate and visit;
- convert match to operator() in SkRecordPattern;
- tidy up a few inelegant bits of old code in tests.
The net result is that the generated code is much clearer. All the mutate() calls
inline as you'd hope, and you can now actually follow along with the disassembly.
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
273643007
git-svn-id: http://skia.googlecode.com/svn/trunk@14631
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 7 May 2014 20:56:08 +0000 (20:56 +0000)]
Some small cleanups for image filter code.
Use the 2-param flavour of mapVector instead of the 3-param, where possible.
Add an SkMatrixImageFilter test case to the tiling unit test.
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
277543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14630
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 7 May 2014 20:54:58 +0000 (20:54 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
git-svn-id: http://skia.googlecode.com/svn/trunk@14629
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 20:51:05 +0000 (20:51 +0000)]
Rename from "(un)lock" to "(un)map" for geometry buffers.
This better reflects OpenGL terminology and is less overloaded ("lock" is used w.r.t. the resource cache).
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275493004
git-svn-id: http://skia.googlecode.com/svn/trunk@14628
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 7 May 2014 20:00:04 +0000 (20:00 +0000)]
Fix for SkDisplacementMap::onFilterBounds().
Two problems: we were not applying the CTM to the scale parameter when
modifying clip bounds, and the recursion for onFilterBounds() must be done
in the reverse order.
BUG=370914
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
272643003
git-svn-id: http://skia.googlecode.com/svn/trunk@14627
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:56:27 +0000 (19:56 +0000)]
Statically initialize those zero-size singletons.
This way GCC/Clang don't generate the magic static code to call the
pointless T::T() once in a threadsafe way. = {} is plenty initialized.
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14623
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270353003
git-svn-id: http://skia.googlecode.com/svn/trunk@14626
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:33:41 +0000 (19:33 +0000)]
Revert of Statically initialize those zero-size singletons. (https://codereview.chromium.org/
270353003/)
Reason for revert:
breaks windows bots
Original issue's description:
> Statically initialize those zero-size singletons.
>
> This way GCC/Clang don't generate the magic static code to call the
> pointless T::T() once in a threadsafe way. = {} is plenty initialized.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14623
R=bungeman@google.com, mtklein@chromium.org
TBR=bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
270363005
git-svn-id: http://skia.googlecode.com/svn/trunk@14625
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:29:03 +0000 (19:29 +0000)]
make compare_rendered_pictures_test.py run end-to-end test
1. generate test SKPs using skpmaker
2. render those SKPs using render_pictures
3. compare results using compare_rendered_pictures.py
BUG=skia:1942,skia:2230
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
274623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14624
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:15:01 +0000 (19:15 +0000)]
Statically initialize those zero-size singletons.
This way GCC/Clang don't generate the magic static code to call the
pointless T::T() once in a threadsafe way. = {} is plenty initialized.
BUG=skia:2378
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270353003
git-svn-id: http://skia.googlecode.com/svn/trunk@14623
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 18:01:57 +0000 (18:01 +0000)]
Partially restore small-T optimization for very small (empty) T.
This is particularly helpful for SkRecord::replace<NoOp>, which now doesn't go
off and allocate a pointless byte.
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
269543025
git-svn-id: http://skia.googlecode.com/svn/trunk@14622
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:50:03 +0000 (17:50 +0000)]
New GM for testing circle blur optimization
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
276453002
git-svn-id: http://skia.googlecode.com/svn/trunk@14621
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:35:05 +0000 (17:35 +0000)]
Fix Dash Effect readback calc for fPhase from old skps
BUG=skia:
R=reed@google.com, bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
270223003
git-svn-id: http://skia.googlecode.com/svn/trunk@14620
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 7 May 2014 17:22:36 +0000 (17:22 +0000)]
Disable broken GMs on Nexus 4.
BUG=skia:2528
R=humper@google.com
Review URL: https://codereview.chromium.org/
272633002
git-svn-id: http://skia.googlecode.com/svn/trunk@14619
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:17:48 +0000 (17:17 +0000)]
save-draw*-restore -> noop-draw*-noop
save-drawA-drawB-drawC-restore always means drawA-drawB-drawC,
no matter what flags we use for save().
This one triggers all over the silk SKPs and in several of the bot SKPs, typically as save-drawBitmap-restore.
BUG=skia:2378
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
267793006
git-svn-id: http://skia.googlecode.com/svn/trunk@14618
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:12:55 +0000 (17:12 +0000)]
GameBench: curCell doesn't need to be extra state.
We're using a static curCell to loop around the atlas. We can just use i.
Noticed this when TSAN complained about it. Parallel invocations of the
game bench were stomping on each other's curCell.
BUG=skia:1792
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270273006
git-svn-id: http://skia.googlecode.com/svn/trunk@14617
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 16:17:26 +0000 (16:17 +0000)]
if SK_DEBUG -> ifdef SK_DEBUG
Should unbreak Chrome canary bots.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
272623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14616
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:46:56 +0000 (15:46 +0000)]
Fix warning
BUG=skia:2526
R=caryclark@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
270253006
git-svn-id: http://skia.googlecode.com/svn/trunk@14615
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:31:40 +0000 (15:31 +0000)]
When solving the cubic line intersection directly fails, use binary search as a fallback.
The cubic line intersection math empirically works 99.99% of the time (fails 3100 out of 1B random tests) but when it fails, an intersection may be missed altogether.
The binary search is may not find a solution if the cubic line failed to find any solutions at all, but so far that case hasn't arisen.
BUG=skia:2504
TBR=reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
266063003
git-svn-id: http://skia.googlecode.com/svn/trunk@14614
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:27:10 +0000 (15:27 +0000)]
4x allocation in PipeController is probably overkill.
When verylargebitmap GM runs in cross-process pipe mode, we're
requestBlock()ing ~200M to carry the bitmaps. The current
implementation ends up allocating ~800M, which is a bit wasteful.
SkGPipeWrite already rounds up to 16K, so just rely on that.
This change exposed several bugs in pipe:
- we don't reserve enough space in drawVertices
- we don't reserve enough space for factory names in cross-process mode
- we don't quite have the right check in needOpBytes to see if we needed to send off the current block and allocate a new one
SETUP_NOTIFY and generally calling doNotify() more often than necessary made things hard to debug and understand. Now the pipe always waits to send off its current block until it needs more space than that block can provide, or it's the final block. We can put these back if we need the proactive flushing, but it seems not necessary?
Removed an assert in DeferredCanvasTest, which is somtimes 2 (Debug), sometimes 3 (Release). It seemed like the other asserts were more essential, and this one was more of a white-box assertion. Still sound if we remove it?
BUG=skia:2478
R=scroggo@google.com, mtklein@google.com, reed@google.com, junov@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
267863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14613
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:08:48 +0000 (15:08 +0000)]
Disallow Android from calling getTotalClip.
Remove the define that lets the function live on.
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
268333002
git-svn-id: http://skia.googlecode.com/svn/trunk@14612
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:05:34 +0000 (15:05 +0000)]
remove dead mipmap code from SkBitmap
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
271693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14611
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 14:47:44 +0000 (14:47 +0000)]
Add SaveLayer-Draw-Restore optimization.
This is like SkPictureRecord's remove_save_layer1 but works with all draw calls.
Interesting patterns removed:
SaveLayer-DrawRect-Restore: Silk SKPs, desk_weather
SaveLayer-DrawPath-Restore: desk_carsvg, desk_wowwiki, tabl_androidpolice
SaveLayer-DrawPosTextH-Restore: tabl_android_police
There may be others, but I stopped looking.
BUG=skia:2378
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
269813010
git-svn-id: http://skia.googlecode.com/svn/trunk@14610
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 7 May 2014 14:46:35 +0000 (14:46 +0000)]
Remove the old Makefile.
Building through this hand-made Makefile is not really supported
anymore and this file is also not maintained by the core team.
BUG=None
TEST=None
R=epoger@google.com
Review URL: https://codereview.chromium.org/
267353002
git-svn-id: http://skia.googlecode.com/svn/trunk@14609
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 14:33:57 +0000 (14:33 +0000)]
Split CPU and GPU DeferredCanvas tests
Nothing important, just happened to notice this and figured it was good hygiene.
DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14603
R=junov@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
271483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14608
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 12:33:02 +0000 (12:33 +0000)]
Revert of Split CPU and GPU DeferredCanvas tests (https://codereview.chromium.org/
271483002/)
Reason for revert:
breaking the run tests steps on ChromeOS. See http://108.170.220.120:10117/builders/Test-ChromeOS-Alex-GMA3150-x86-Debug/builds/1669
Original issue's description:
> Split CPU and GPU DeferredCanvas tests
>
> Nothing important, just happened to notice this and figured it was good hygiene.
> DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14603
R=junov@chromium.org, mtklein@google.com, mtklein@chromium.org
TBR=junov@chromium.org, mtklein@chromium.org, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
270283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14607
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 03:57:56 +0000 (03:57 +0000)]
Revert "remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE"
This reverts commit
95b03ce59986ecee5e4188da630a563efca3afe8.
NOTRY=True
TBR=fmalita@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
274513002
git-svn-id: http://skia.googlecode.com/svn/trunk@14606
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 7 May 2014 03:04:15 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14605
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 6 May 2014 22:52:55 +0000 (22:52 +0000)]
Fix for empty saveLayer() with a filter which affects transparent black.
If an saveLayer()/restore() is recorded, tilegrid/rtree will cull them
out and not draw anything. This is correct for most cases, but if the
paint in the saveLayer() is one that affects transparent black (e.g.,
it contains a color filter or image filter which affects transparent
black), this is incorrect: the filter should be applied.
Fixed by adding a no-op between the saveLayer() and restore(), and
adding a bbox node pointing at that node with the saveLayer()'s bounds.
This exposed a bug in SkPictureRecord.cpp's match(), where it would
assert if the NOOP was the last op seen. Fixed with an early-out before
calling peek_op_and_size().
BUG=skia:2254
Review URL: https://codereview.chromium.org/
262363007
git-svn-id: http://skia.googlecode.com/svn/trunk@14604
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 21:43:37 +0000 (21:43 +0000)]
Split CPU and GPU DeferredCanvas tests
Nothing important, just happened to notice this and figured it was good hygiene.
DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially.
BUG=skia:
R=junov@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
271483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14603
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log