William Godbe [Thu, 7 Jul 2016 22:32:04 +0000 (15:32 -0700)]
Merge pull request #6170 from wtgodbe/signarm
Revert sign.builds so that arm64 bins can be signed
Kyungwoo Lee [Thu, 7 Jul 2016 22:20:20 +0000 (15:20 -0700)]
Merge pull request #6173 from kyulee1/gc03
ARM64: Enable Daily Job for GcStress0x3
Kyungwoo Lee [Thu, 7 Jul 2016 21:45:02 +0000 (14:45 -0700)]
ARM64: Enable Daily Job for GcStress0x3
Kyungwoo Lee [Thu, 7 Jul 2016 21:41:34 +0000 (14:41 -0700)]
Merge pull request #6090 from kyulee1/gctest3
ARM64: Test Update for GcStress0x3
Justin Van Patten [Thu, 7 Jul 2016 21:18:47 +0000 (14:18 -0700)]
Avoid box allocation in Encoding.EncodingName (#6142)
`Encoding.EncodingName` concatenates a `string` with an `int` via
`string.Concat(object, object)`, which results in the `int` being
boxed.
This change avoids the box by calling `int.ToString()`,
allowing `string.Concat(string, string)` to be used.
wtgodbe [Thu, 7 Jul 2016 20:38:49 +0000 (13:38 -0700)]
Revert sign.builds so that arm64 bins can be signed
Tarek Mahmoud Sayed [Thu, 7 Jul 2016 18:35:03 +0000 (11:35 -0700)]
Merge pull request #6114 from jamesqo/encodingforwarder
Consolidate much of the duplicated code across Encoding implementations
Carol Eidt [Thu, 7 Jul 2016 15:55:28 +0000 (08:55 -0700)]
Merge pull request #6152 from mikedn/x86-addsub-lo
[WIP] Introduce GT_ADD_LO and GT_SUB_LO
Kyungwoo Lee [Wed, 6 Jul 2016 16:16:02 +0000 (09:16 -0700)]
ARM64: Test Update for GcStress0x3
Gaurav Khanna [Thu, 7 Jul 2016 13:43:17 +0000 (06:43 -0700)]
Merge pull request #6161 from dotnet-bot/UpdateDependencies20160707062011
Updating External dependencies to beta-24307-00
James Ko [Thu, 7 Jul 2016 10:41:09 +0000 (06:41 -0400)]
Avoid heap allocating in char.ConvertFromUtf32 (#6141)
dotnet-bot [Thu, 7 Jul 2016 06:20:11 +0000 (06:20 +0000)]
Updating External dependencies to beta-24307-00
James Ko [Thu, 7 Jul 2016 06:03:59 +0000 (02:03 -0400)]
Convert SymbolType.m_format to be a string (#6133)
Justin Van Patten [Thu, 7 Jul 2016 05:39:34 +0000 (22:39 -0700)]
Avoid box allocation in DateTimeFormat.FormatCustomized (#6147)
The current implementation calls `string.Concat(object, object)`, which
results in an `int` box allocation.
Avoid the box allocation by calling `int.ToString()`, allowing
`string.Concat(string, string)` to be used.
Justin Van Patten [Thu, 7 Jul 2016 05:37:53 +0000 (22:37 -0700)]
Avoid box allocation in TypeBuilder.DefineDataHelper (#6148)
The current implementation calls `string.Concat(object, object)`, which
results in a box allocation.
Avoid the box allocation by calling `int.ToString()`, allowing
`string.Concat(string, string)` to be used.
Justin Van Patten [Thu, 7 Jul 2016 05:37:02 +0000 (22:37 -0700)]
Avoid box allocation in ActivityTracker (#6149)
The current implementation calls
`string.Concat(object, object, object)`, which results in a box
allocation.
Avoid the box allocation by calling `long.ToString()`, allowing
`string.Concat(string, string, string)` to be used.
Adam Sitnik [Thu, 7 Jul 2016 05:35:34 +0000 (07:35 +0200)]
make all public properties of DebuggableAttribute visible outside mscorlib (#6153)
Rahul Kumar [Thu, 7 Jul 2016 01:39:02 +0000 (18:39 -0700)]
Merge pull request #6157 from rahku/crossgen
Do not clean tests folder when skiptests option is used along with clean
Aditya Mandaleeka [Wed, 6 Jul 2016 21:41:57 +0000 (14:41 -0700)]
Merge pull request #6151 from mikedn/runbench-coreclr
Fix incorrect RunBenchmarks help text
Rahul Kumar [Wed, 6 Jul 2016 21:39:21 +0000 (14:39 -0700)]
Do not clean tests folder when skiptests option is used along with clean
Rahul Kumar [Wed, 6 Jul 2016 21:00:04 +0000 (14:00 -0700)]
Merge pull request #6130 from rahku/crossgen
ARM64: Fix incremental build problem for cross-components
Rahul Kumar [Tue, 5 Jul 2016 22:04:59 +0000 (15:04 -0700)]
Fix incremental build problem for cross-components
Aditya Mandaleeka [Wed, 6 Jul 2016 19:32:47 +0000 (12:32 -0700)]
Merge pull request #6139 from mkborg/fix_lldb_search_order
Fix LLDB search order
Matt Ellis [Wed, 6 Jul 2016 18:38:36 +0000 (11:38 -0700)]
Merge pull request #6146 from ellismg/fix-sign-targets-syntax-error
Fix syntax error in sign.builds
Mike Danes [Wed, 6 Jul 2016 18:29:06 +0000 (21:29 +0300)]
Fix incorrect RunBenchmarks help text
RunBenchmark's help text claims that there's a -coreclr option when in fact the option is -runner.
Mike Danes [Wed, 6 Jul 2016 17:23:42 +0000 (20:23 +0300)]
Introduce GT_ADD_LO and GT_SUB_LO
Matt Ellis [Wed, 6 Jul 2016 16:55:23 +0000 (09:55 -0700)]
Fix syntax error in sign.builds
Koundinya Veluri [Wed, 6 Jul 2016 16:50:12 +0000 (09:50 -0700)]
Merge pull request #6015 from kouvel/NamedMutexMoreFlockCases
Named mutex: Use flock instead of pthread process-shared mutex in som…
Gaurav Khanna [Wed, 6 Jul 2016 14:19:00 +0000 (07:19 -0700)]
Merge pull request #6135 from dotnet-bot/UpdateDependencies20160706051943
Updating External dependencies to beta-24306-00
Mikhail I. Krivtsov [Wed, 6 Jul 2016 11:37:39 +0000 (14:37 +0300)]
Fix LLDB search order
By default 'find_library' without 'NO_DEFAULT_PATH' keyword searches
first in default locations specified by '${CMAKE_SYSTEM_PREFIX_PATH}'
and only then in locations specified via 'PATHS' keyword
('${WITH_LLDB_LIBS}' in our case). As result it always picks-up default
LLDB ignoring the one explicitly specified via '${WITH_LLDB_LIBS}'.
This change modifies search order giving priority to '${WITH_LLDB_LIBS}'
and '${WITH_LLDB_INCLUDES}' over default locations.
dotnet-bot [Wed, 6 Jul 2016 05:19:43 +0000 (05:19 +0000)]
Updating External dependencies to beta-24306-00
Koundinya Veluri [Mon, 27 Jun 2016 17:53:28 +0000 (10:53 -0700)]
Named mutex: Use flock instead of pthread process-shared mutex in some more cases
Workaround for #5456:
- Sometimes, a timed wait operation is not getting released, causing a hang
- Due to the hang, it is not possible to detect this issue with code
- Temporarily disabled the use of pthread process-shared mutexes on ARM/ARM64. File locks will be used instead.
Workaround for #5872:
- On Alpine Linux, a pthread process-shared robust mutex is detecting the case where a process abandons the mutex when it exits while holding the lock, but is putting the mutex into an unrecoverable state (ENOTRECOVERABLE) instead of assigning lock ownership to the next thread that is released from a wait for a lock and notifying of abandonment (EOWNERDEAD).
- Added a test case to detect this issue, to have it use file locks instead
Close #5456
Carol Eidt [Tue, 5 Jul 2016 22:55:48 +0000 (15:55 -0700)]
Merge pull request #6098 from CarolEidt/BlkNodeRefactors
More Blk Op Refactoring
Brian Sullivan [Tue, 5 Jul 2016 22:48:14 +0000 (15:48 -0700)]
Merge pull request #6102 from briansull/inliner-dump
Improve the dump for inline return expressions
Bruce Forstall [Tue, 5 Jul 2016 21:58:31 +0000 (14:58 -0700)]
Merge pull request #6101 from BruceForstall/RyuJITx86EH
RyuJIT/x86: add support for EH
Sivarv [Tue, 5 Jul 2016 21:47:48 +0000 (14:47 -0700)]
Merge pull request #6094 from mikedn/x86-uncontained-long
Allow uncontained GT_LONG nodes
Bruce Forstall [Tue, 5 Jul 2016 20:33:28 +0000 (13:33 -0700)]
Merge pull request #6124 from dotnet-bot/from-tfs
Merge changes from TFS
Bruce Forstall [Tue, 5 Jul 2016 20:29:59 +0000 (13:29 -0700)]
Merge pull request #6100 from BruceForstall/BotrX86EHUpdate
Add information on x86 EH to CLR ABI
Rahul Kumar [Tue, 5 Jul 2016 18:49:29 +0000 (11:49 -0700)]
Merge pull request #6093 from rahku/arm64retbuf
Revert Pinvoke ILStub calli signature for desktop clr
Maoni Stephens [Tue, 5 Jul 2016 18:47:29 +0000 (11:47 -0700)]
only use config on coreclr
[tfs-changeset: 1616092]
James Ko [Tue, 5 Jul 2016 16:45:15 +0000 (12:45 -0400)]
Remove TODO on throwing exception
Bruce Forstall [Tue, 5 Jul 2016 16:31:21 +0000 (09:31 -0700)]
Merge pull request #6106 from mikedn/modopt-feedback
Address div/mod CR feedback
Carol Eidt [Sat, 2 Jul 2016 00:03:52 +0000 (17:03 -0700)]
More Blk Op Refactoring
Code refactoring in preparation for 1st Class Structs:
Factor out the legacy code generation for CpObj.
Abstract some functionality to member methods.
Move some block-related method definitions.
Make fgOrderBlockOps legacy-only (it is unused in RyuJIT).
Factor out the code to create a block init value.
Add a new IsLocalExpr() method.
Change some variable names to distinguish between objects and their addresses.
James Ko [Tue, 5 Jul 2016 14:58:26 +0000 (10:58 -0400)]
Move the SecuritySafeCritical attributes to EncodingForwarder
Stephen Toub [Tue, 5 Jul 2016 11:59:03 +0000 (07:59 -0400)]
Merge pull request #6120 from dotnet-bot/UpdateDependencies20160705051942
Updating External dependencies to beta-24305-00
James Ko [Tue, 5 Jul 2016 09:50:52 +0000 (05:50 -0400)]
Better performance for MulticastDelegate.Equals (#6113)
Better performance for MulticastDelegate.Equals
Viacheslav Nikolaev [Tue, 5 Jul 2016 06:33:46 +0000 (09:33 +0300)]
One of the flags MAP_SHARED or MAP_PRIVATE has to be specified. MAP_PRIVATE seems to fit here. (#6089)
dotnet-bot [Tue, 5 Jul 2016 05:19:42 +0000 (05:19 +0000)]
Updating External dependencies to beta-24305-00
James Ko [Tue, 5 Jul 2016 00:20:43 +0000 (20:20 -0400)]
Add note on UTF8Encoding.GetByteCount to EncodingForwarder
James Ko [Tue, 5 Jul 2016 00:16:44 +0000 (20:16 -0400)]
Fix CoreFX test failures
James Ko [Mon, 4 Jul 2016 19:53:34 +0000 (15:53 -0400)]
[UTF8Encoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:52:00 +0000 (15:52 -0400)]
[UTF7Encoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:49:54 +0000 (15:49 -0400)]
[UTF32Encoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:48:20 +0000 (15:48 -0400)]
[UnicodeEncoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:45:19 +0000 (15:45 -0400)]
[EncodingNLS] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:41:17 +0000 (15:41 -0400)]
[ASCIIEncoding] Remove unncessary comments
James Ko [Mon, 4 Jul 2016 19:17:25 +0000 (15:17 -0400)]
Use EncodingForwarder for GetString(byte[], int, int)
James Ko [Mon, 4 Jul 2016 19:04:43 +0000 (15:04 -0400)]
Use EncodingForwarder for GetChars(byte*, int, char*, int)
James Ko [Mon, 4 Jul 2016 18:55:39 +0000 (14:55 -0400)]
Use EncodingForwarder for GetChars(byte[], int, int, char[], int)
James Ko [Mon, 4 Jul 2016 17:08:37 +0000 (13:08 -0400)]
Use EncodingForwarder for GetCharCount(byte*, int)
James Ko [Mon, 4 Jul 2016 16:55:41 +0000 (12:55 -0400)]
Use EncodingForwarder for GetCharCount(byte[], int, int)
James Ko [Mon, 4 Jul 2016 16:45:52 +0000 (12:45 -0400)]
Use EncodingForwarder for GetBytes(char*, int, byte*, int)
James Ko [Mon, 4 Jul 2016 16:39:03 +0000 (12:39 -0400)]
Use EncodingForwarder for GetBytes(char[], int, int, byte[], int)
James Ko [Mon, 4 Jul 2016 16:25:21 +0000 (12:25 -0400)]
Use EncodingForwarder for GetBytes(string, int, int, byte[], int)
James Ko [Mon, 4 Jul 2016 16:05:22 +0000 (12:05 -0400)]
Use EncodingForwarder for GetByteCount(char*, int)
James Ko [Mon, 4 Jul 2016 15:58:44 +0000 (11:58 -0400)]
Rename the chars parameter in a comment
James Ko [Mon, 4 Jul 2016 15:57:58 +0000 (11:57 -0400)]
Use EncodingForwarder for GetByteCount(string)
James Ko [Mon, 4 Jul 2016 15:44:55 +0000 (11:44 -0400)]
Use EncodingForwarder for GetByteCount(char[], int, int)
Stephen Toub [Mon, 4 Jul 2016 10:09:55 +0000 (06:09 -0400)]
Merge pull request #6109 from dotnet-bot/UpdateDependencies20160704051959
Updating External dependencies to beta-24304-00
James Ko [Mon, 4 Jul 2016 05:39:12 +0000 (01:39 -0400)]
Short-circuit on the count, not the array length, in common Encoding methods (#6108)
* Short-circuit using count instead of array.Length
* Use Array.Empty in default Reset implementation
dotnet-bot [Mon, 4 Jul 2016 05:19:58 +0000 (05:19 +0000)]
Updating External dependencies to beta-24304-00
Maoni Stephens [Sun, 3 Jul 2016 20:06:03 +0000 (13:06 -0700)]
Merge pull request #6104 from Maoni0/config
Added 2 configs for Server GC
Mike Danes [Sun, 3 Jul 2016 16:46:15 +0000 (19:46 +0300)]
Address div/mod CR feedback
Maoni0 [Sun, 3 Jul 2016 04:07:23 +0000 (21:07 -0700)]
Added 2 configs for Server GC
complus var GCNoAffinitize or project.json System.GC.NoAffinitize - specify 1/true to disable hard affinity of Server GC threads to CPUs
complus var GCHeapCount or project.json System.GC.HeapCount - specify the # of Server GC threads/heaps, must be smaller than the # of logical CPUs the process is allowed to run on, ie, if you don't specifically affinitize your process it means the # of total logical CPUs on the machine; otherwise this is the # of logical CPUs you affinitized your process to.
Aditya Mandaleeka [Sun, 3 Jul 2016 01:11:31 +0000 (18:11 -0700)]
Merge pull request #6099 from adityamandaleeka/remove_virtual_owned
Remove VIRTUALOwnedRegion
Gaurav Khanna [Sat, 2 Jul 2016 16:12:54 +0000 (09:12 -0700)]
Merge pull request #6086 from dotnet-bot/UpdateDependencies20160701051708
Updating External dependencies to beta-24301-00
Sivarv [Sat, 2 Jul 2016 13:06:44 +0000 (06:06 -0700)]
Merge pull request #6092 from sivarv/lsrawork
Lower, LSRA and Codegen support for reg optional operands
Mike Danes [Fri, 1 Jul 2016 19:54:04 +0000 (22:54 +0300)]
Allow uncontained GT_LONG nodes
When the result of a TYP_LONG operation is not used the GT_LONG node inserted during decomposition remains in the tree and unlike other GT_LONG nodes is not contained and needs special handling.
This usually happens with arithmetic operations that require overflow checks, the result of the operation may be ignored but the operation itself cannot be eliminated because it has a side-effect.
Brian Sullivan [Sat, 2 Jul 2016 01:31:16 +0000 (18:31 -0700)]
Improve the dump for inline return expressions
Also don't do a deep copy of the inline return expression
Bruce Forstall [Sat, 2 Jul 2016 00:57:57 +0000 (17:57 -0700)]
Add information on x86 EH to CLR ABI
Aditya Mandaleeka [Sat, 2 Jul 2016 00:09:47 +0000 (17:09 -0700)]
Remove VIRTUALOwnedRegion.
sivarv [Fri, 1 Jul 2016 18:41:02 +0000 (11:41 -0700)]
Consider spilled lcl var as contained memory operands for codegen purpose.
Bruce Forstall [Fri, 1 Jul 2016 23:55:01 +0000 (16:55 -0700)]
RyuJIT/x86: add support for EH
This change implements the necessary x86 support in RyuJIT for exception handling.
It removes the EH-related NYI. The number of NYI fallbacks in an x86 test run drops
by about 13000. There are 10 new asserts which are now suppressed: 6 appear to be
new and 4 are new instances of existing known asserts.
The various changes are:
1. Implement code generation for BBJ_CALLFINALLY/BBJ_ALWAYS blocks for invoking a finally.
This requires appropriately modifying the ShadowSP slot structure before the call.
2. Implement BBJ_EHFINALLYRET/BBJ_EHFILTERRET control transfer. The related GT_RETFILT
code was already implemented.
3. Implement GT_END_LFIN for handling return-from-finally cleanup, namely, clearing the
appropriate slot in the ShadowSP structure.
Bruce Forstall [Fri, 1 Jul 2016 23:47:51 +0000 (16:47 -0700)]
Merge pull request #6096 from dotnet-bot/from-tfs
Merge changes from TFS
Maoni Stephens [Fri, 1 Jul 2016 21:47:30 +0000 (14:47 -0700)]
Fixed build breaks related to perf counter code on desktop. perf counters are only enabled on desktop.
[tfs-changeset: 1615834]
Rahul Kumar [Fri, 1 Jul 2016 19:20:39 +0000 (12:20 -0700)]
Revert Pinvoke ILStub calli signature for desktop clr
Aditya Mandaleeka [Fri, 1 Jul 2016 20:11:10 +0000 (13:11 -0700)]
Merge pull request #6083 from adityamandaleeka/upload_ci_dumps
Start using dumpling service to upload dumps from CI runs
Pat Gavlin [Fri, 1 Jul 2016 19:33:16 +0000 (12:33 -0700)]
Merge pull request #6031 from mikedn/x86-float-unspill
Remove misplaced call to genUnspillRegIfNeeded
Maoni Stephens [Fri, 1 Jul 2016 17:49:06 +0000 (10:49 -0700)]
Merge pull request #6084 from Maoni0/gc_etw
GC ETW fixes
William Godbe [Fri, 1 Jul 2016 17:22:44 +0000 (10:22 -0700)]
Merge pull request #6091 from wtgodbe/buildfix
do all coreclr copying BEFORE building
wtgodbe [Fri, 1 Jul 2016 17:15:06 +0000 (10:15 -0700)]
do all coreclr copying BEFORE building
chunseoklee [Fri, 1 Jul 2016 08:41:20 +0000 (17:41 +0900)]
FIX #6074 : cannot find exception handler on arm (#6088)
dotnet-bot [Fri, 1 Jul 2016 05:17:08 +0000 (05:17 +0000)]
Updating External dependencies to beta-24301-00
Kyungwoo Lee [Fri, 1 Jul 2016 01:49:05 +0000 (18:49 -0700)]
Merge pull request #6082 from kyulee1/gc3
ARM64: Enable GCStress0x3 Private Job
Andy Ayers [Fri, 1 Jul 2016 00:47:24 +0000 (17:47 -0700)]
Merge pull request #6078 from AndyAyersMS/ModelPolicyAvailability
Inliner: make ModelPolicy available in release builds
Maoni0 [Fri, 24 Jun 2016 22:45:51 +0000 (15:45 -0700)]
GC ETW fixes. The code for getting data for ETW and perf counter was written by different
folks and was very intertwined. For full CLR we always have both defined but for coreclr
perf counters are not enabled so some things for ETW were just 0. Need to make sure when one
is not defined the rest are still getting the data they need.
Pat Gavlin [Thu, 30 Jun 2016 23:36:19 +0000 (16:36 -0700)]
Merge pull request #6077 from pgavlin/RemoveGtfDead
Remove GTF_DEAD.
Mike McLaughlin [Thu, 30 Jun 2016 22:49:46 +0000 (15:49 -0700)]
Fix the hang in the debugger tests repo on OS X. (#6079)
The transport pipe closes during shudown where blocked/deadlocked with the pending read on the transport thread.
Aditya Mandaleeka [Thu, 30 Jun 2016 22:20:22 +0000 (15:20 -0700)]
Upload CI dumps to dumpling.
Kyungwoo Lee [Thu, 30 Jun 2016 22:00:07 +0000 (15:00 -0700)]
ARM64: Enable GCStress0x3 Private Job