Martin Fleisz [Tue, 5 Dec 2017 10:19:59 +0000 (11:19 +0100)]
Merge pull request #4294 from akallabeth/shadow_fix
Shadow server crash fixes
Martin Fleisz [Tue, 5 Dec 2017 09:56:14 +0000 (10:56 +0100)]
Merge pull request #4288 from hardening/disp_channel
Disp channel changes and improvements
Bernhard Miklautz [Sat, 2 Dec 2017 15:09:43 +0000 (16:09 +0100)]
Merge pull request #4298 from myfreeweb/libressl-fix-fips
Fix LibreSSL build
Greg V [Fri, 1 Dec 2017 15:34:48 +0000 (18:34 +0300)]
Fix LibreSSL build
LibreSSL does not support FIPS mode.
David Fort [Tue, 28 Nov 2017 14:32:15 +0000 (15:32 +0100)]
drdynvc: fix invalid check
There were a copy'n paste error in the check of a malloc.
David Fort [Fri, 24 Nov 2017 13:53:39 +0000 (14:53 +0100)]
display control channel: add a callback called when we receive capabilities
We need a signal to know when the channel is ready and it's safe to send the
monitor layouts.
akallabeth [Fri, 1 Dec 2017 10:24:50 +0000 (11:24 +0100)]
Merge pull request #4275 from ondrejholy/big-endian-fixes
Big endian fixes
David Fort [Wed, 29 Nov 2017 14:28:37 +0000 (15:28 +0100)]
Merge pull request #4292 from daixj-shterm/master
Fix #4291: xfreerdp segfault when connecting freerdp-shadow-cli
Armin Novak [Wed, 29 Nov 2017 13:17:27 +0000 (14:17 +0100)]
Reset errno in X11 monitor enumeration
XOpenDisplay may succeed but set errno,
reset at the end of the function.
Armin Novak [Wed, 29 Nov 2017 13:13:50 +0000 (14:13 +0100)]
Fixed /monitors argument checks.
daixj [Wed, 29 Nov 2017 10:12:40 +0000 (05:12 -0500)]
Fix #4291: xfreerdp segfault when connecting freerdp-shadow-cli
David Fort [Fri, 24 Nov 2017 13:06:35 +0000 (14:06 +0100)]
xfreerdp: when available use xrandr to get display infos
akallabeth [Tue, 28 Nov 2017 15:36:32 +0000 (16:36 +0100)]
Merge pull request #4287 from bmiklautz/dev2
2.0.0-dev2 - start rc2 development cycle
Bernhard Miklautz [Tue, 28 Nov 2017 14:33:03 +0000 (15:33 +0100)]
client/android: increase version
Bernhard Miklautz [Tue, 28 Nov 2017 14:29:17 +0000 (15:29 +0100)]
2.0.0-dev2 - start rc2 development cycle
akallabeth [Tue, 28 Nov 2017 14:26:30 +0000 (15:26 +0100)]
Merge pull request #4286 from bmiklautz/rc1
Version 2.0.0-rc1
Bernhard Miklautz [Tue, 28 Nov 2017 14:03:09 +0000 (15:03 +0100)]
Version 2.0.0-rc1
David Fort [Tue, 28 Nov 2017 09:48:53 +0000 (10:48 +0100)]
Merge pull request #4282 from akallabeth/force_ipv6
Fix #4281: Added option to prefer IPv6 over IPv4
Bernhard Miklautz [Tue, 28 Nov 2017 09:47:27 +0000 (10:47 +0100)]
Merge pull request #4284 from akallabeth/channel_count_fix_v2
Fixed channel count exceed checks
Armin Novak [Tue, 28 Nov 2017 08:40:04 +0000 (09:40 +0100)]
Fixed channel count exceed checks
The check aborted on CHANNEL_MAX_COUNT - 1 instead
of correctly at CHANNEL_MAX_COUNT
akallabeth [Tue, 28 Nov 2017 08:19:58 +0000 (09:19 +0100)]
Merge pull request #4283 from bmiklautz/kfreebsd
fix build: GNU/kFreeBSD
David Fort [Mon, 27 Nov 2017 21:46:23 +0000 (22:46 +0100)]
Merge pull request #4272 from akallabeth/static_channel_checks
Fix #3378: 31 static channels are supported.
Bernhard Miklautz [Mon, 23 Oct 2017 08:32:51 +0000 (10:32 +0200)]
fix/build: handle GNU/kFreeBSD like other BSDs
Based on a patch for Debian from
Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Mike Gabriel [Mon, 23 Oct 2017 08:31:55 +0000 (10:31 +0200)]
fix/build: GNU/kFreeBSD is not FreeBSD
Bernhard Miklautz [Mon, 27 Nov 2017 10:49:46 +0000 (11:49 +0100)]
Merge pull request #3991 from akallabeth/stream_string_helper
Stream convenience functions to read/write strings.
Bernhard Miklautz [Mon, 27 Nov 2017 10:46:54 +0000 (11:46 +0100)]
Merge pull request #4261 from akallabeth/doc_ssl_store
Fix #3890: Point to OpenSSL doc for private CA
Armin Novak [Mon, 27 Nov 2017 09:54:49 +0000 (10:54 +0100)]
Fix #4281: Added option to prefer IPv6 over IPv4
Bernhard Miklautz [Mon, 27 Nov 2017 09:57:26 +0000 (10:57 +0100)]
Merge pull request #4220 from akallabeth/version_from_file_or_tag
Extract build version from file or git tag.
Bernhard Miklautz [Mon, 27 Nov 2017 09:41:06 +0000 (10:41 +0100)]
Merge pull request #4273 from akallabeth/issue_template
Added issue template.
Bernhard Miklautz [Mon, 27 Nov 2017 09:40:44 +0000 (10:40 +0100)]
Merge pull request #4270 from akallabeth/mac_clipboard_fix
Fixed #1536: Clipboard data size.
Bernhard Miklautz [Mon, 27 Nov 2017 09:06:30 +0000 (10:06 +0100)]
Merge pull request #4280 from akallabeth/snd_parser_fix
Fix #4278: Fix nasty range check bug
Armin Novak [Mon, 27 Nov 2017 09:03:49 +0000 (10:03 +0100)]
Added mailing list address.
Armin Novak [Mon, 27 Nov 2017 08:06:31 +0000 (09:06 +0100)]
Added reminder to delete template before submit
Armin Novak [Thu, 23 Nov 2017 15:44:00 +0000 (16:44 +0100)]
Added pull request template.
Armin Novak [Thu, 23 Nov 2017 15:34:17 +0000 (16:34 +0100)]
Added issue template.
Armin Novak [Sun, 26 Nov 2017 13:59:37 +0000 (14:59 +0100)]
Fix #4278: Fix nasty range check bug
David Fort [Fri, 24 Nov 2017 14:51:46 +0000 (15:51 +0100)]
Merge pull request #4229 from akallabeth/from_stdin_args
Option to force password prompt before connection
Bernhard Miklautz [Fri, 24 Nov 2017 14:44:15 +0000 (15:44 +0100)]
Merge pull request #4268 from akallabeth/big_endian_fixes
Fix ZGfx decoder on big endian
David Fort [Fri, 24 Nov 2017 10:14:17 +0000 (11:14 +0100)]
Merge pull request #4271 from akallabeth/surface_c
Fixed return value check for callbacks.
akallabeth [Fri, 24 Nov 2017 09:43:53 +0000 (10:43 +0100)]
Merge pull request #4274 from hardening/clipboard_checks
clipboard: add some checks for the message
Ondrej Holy [Fri, 24 Nov 2017 09:24:47 +0000 (10:24 +0100)]
client/common: Fix two memory leaks in RDP file processing
FALSE is returned immediately in case of parsing error and thus buffer
copy is leaked. Let's release the memory properly.
Ondrej Holy [Thu, 23 Nov 2017 18:51:57 +0000 (19:51 +0100)]
winpr/nt: Fix wide char string on big endian
Wide char strings are always little endian encoded and thus
Data_Write_UINT16 has to be used in _RtlAnsiStringToUnicodeString.
It fixes TestIoDevice on big endian machines among others.
https://github.com/FreeRDP/FreeRDP/issues/4231
Ondrej Holy [Thu, 23 Nov 2017 17:22:48 +0000 (18:22 +0100)]
client/common: Fix RDP file processing on big endian
TestClientRdpFile fails on big endian machines due to some bug in
unicode processing. Let's drop all the unicode functions and convert
unicode input into ascii as soon as possible. This significantly
simplify RDP file processing and also fixes TestClientRdpFile on
big endian machines.
https://github.com/FreeRDP/FreeRDP/issues/4231
David Fort [Thu, 23 Nov 2017 16:37:55 +0000 (17:37 +0100)]
clipboard: add some checks for the message
Armin Novak [Thu, 23 Nov 2017 15:18:44 +0000 (16:18 +0100)]
Fix #3378: 31 static channels are supported.
David Fort [Thu, 23 Nov 2017 14:35:52 +0000 (15:35 +0100)]
Merge pull request #4255 from akallabeth/rfx_fix
Fix #4253: Rfx decode tile width.
Armin Novak [Thu, 23 Nov 2017 14:10:42 +0000 (15:10 +0100)]
Fixed return value check for callbacks.
Armin Novak [Thu, 23 Nov 2017 11:53:39 +0000 (12:53 +0100)]
Fixed #1536: Clipboard data size.
akallabeth [Thu, 23 Nov 2017 09:49:15 +0000 (10:49 +0100)]
Merge pull request #4267 from ondrejholy/autofips
Enable FIPS mode automatically
Ondrej Holy [Wed, 22 Nov 2017 18:41:35 +0000 (19:41 +0100)]
Remove unused variable
Unused variable was added together with FIPS mode support, let's remove it.
Ondrej Holy [Wed, 22 Nov 2017 18:25:32 +0000 (19:25 +0100)]
Enable FIPS mode automatically
FreeRDP aborts if OpenSSL operates in FIPS mode and +fipsmode is not
manually specified. Let's prevent the abortion and enable the necessary
options in that case automatically.
Armin Novak [Tue, 21 Nov 2017 16:32:54 +0000 (17:32 +0100)]
Fixed endianess issues of zgfx decoder.
David Fort [Thu, 23 Nov 2017 08:22:02 +0000 (09:22 +0100)]
Merge pull request #4251 from akallabeth/openssl_warn_fixes
Fix #4247: warnings introduced with #3904
Martin Fleisz [Wed, 22 Nov 2017 11:23:04 +0000 (12:23 +0100)]
Merge pull request #4244 from akallabeth/drivestoredirect
Fix parsing of drivestoredirect (#3267)
Martin Fleisz [Wed, 22 Nov 2017 11:06:55 +0000 (12:06 +0100)]
Merge pull request #4258 from akallabeth/kbd_parse_fix
Fix #4257: Proper error checks for /kbd argument
Armin Novak [Wed, 8 Nov 2017 13:22:38 +0000 (14:22 +0100)]
Extract version from file or git tag.
Armin Novak [Tue, 21 Nov 2017 07:46:29 +0000 (08:46 +0100)]
Fix #4257: Proper error checks for /kbd argument
Martin Fleisz [Wed, 22 Nov 2017 08:24:16 +0000 (09:24 +0100)]
Merge pull request #4263 from akallabeth/rdp_parser_mem_corruption_fix
Fixed #4249: Corruption due to recursive parser
akallabeth [Tue, 21 Nov 2017 18:10:28 +0000 (19:10 +0100)]
Testing argument to end with file extension.
Martin Fleisz [Tue, 21 Nov 2017 16:25:25 +0000 (17:25 +0100)]
Merge pull request #4264 from cedrozor/upstream-master
Fixed NLA for Negotiate and NTLM authentication
cedrozor [Tue, 21 Nov 2017 15:36:47 +0000 (16:36 +0100)]
Fixed NLA for Negotiate and NTLM authentication (regression due to the recent addition of kerberos support)
Armin Novak [Tue, 21 Nov 2017 12:47:28 +0000 (13:47 +0100)]
Fixed #4249: Corruption due to recursive parser
Armin Novak [Tue, 21 Nov 2017 10:47:33 +0000 (11:47 +0100)]
Fix #3890: Point to OpenSSL doc for private CA
Armin Novak [Tue, 21 Nov 2017 10:37:42 +0000 (11:37 +0100)]
Disabled ceritficate signature check.
Armin Novak [Mon, 20 Nov 2017 13:02:41 +0000 (14:02 +0100)]
Fixed X11 stride on screen update.
Armin Novak [Mon, 20 Nov 2017 12:42:40 +0000 (13:42 +0100)]
Fix #4101: Rfx decode tile width.
Martin Fleisz [Tue, 21 Nov 2017 10:02:25 +0000 (11:02 +0100)]
Merge pull request #4252 from akallabeth/mac_kbd_sync
Mac kbd sync
Martin Fleisz [Tue, 21 Nov 2017 09:55:18 +0000 (10:55 +0100)]
Merge pull request #4256 from akallabeth/15bpp_fix
Fix #4111: 15bpp color handling for brush.
Armin Novak [Fri, 17 Nov 2017 13:03:57 +0000 (14:03 +0100)]
Fix parsing of drivestoredirect (#3267)
Bernhard Miklautz [Mon, 20 Nov 2017 15:30:54 +0000 (16:30 +0100)]
Merge pull request #4254 from akallabeth/doc_update
Fix #3509: Added Ctrl+Alt+Enter description
Armin Novak [Mon, 20 Nov 2017 14:00:09 +0000 (15:00 +0100)]
Fix #4111: 15bpp color handling for brush.
Bernhard Miklautz [Mon, 20 Nov 2017 13:11:15 +0000 (14:11 +0100)]
Merge pull request #4253 from akallabeth/win_return
Win return code
Armin Novak [Mon, 20 Nov 2017 12:21:50 +0000 (13:21 +0100)]
Fix #3509: Added Ctrl+Alt+Enter description
Armin Novak [Mon, 20 Nov 2017 12:16:49 +0000 (13:16 +0100)]
Fix #3211: Return freerdp error from main.
Armin Novak [Mon, 20 Nov 2017 10:46:32 +0000 (11:46 +0100)]
Fixed keyboard state sync.
Armin Novak [Mon, 20 Nov 2017 10:46:09 +0000 (11:46 +0100)]
Removed linux specific include.
Armin Novak [Mon, 20 Nov 2017 09:11:35 +0000 (10:11 +0100)]
Fix #4247: warnings introduced with #3904
David Fort [Fri, 17 Nov 2017 14:23:24 +0000 (15:23 +0100)]
Merge pull request #4243 from akallabeth/man_fix
Better description for drive redirection (Fix #3513)
Armin Novak [Fri, 17 Nov 2017 12:44:56 +0000 (13:44 +0100)]
Better description for drive redirection (Fix #3513)
akallabeth [Fri, 17 Nov 2017 12:31:43 +0000 (13:31 +0100)]
Merge pull request #3904 from bjcollins/master
FIPS Mode support for xfreerdp
Martin Fleisz [Fri, 17 Nov 2017 12:02:46 +0000 (13:02 +0100)]
Merge pull request #4236 from akallabeth/scan_fix_remastered
Scanbuild warning fixes
Armin Novak [Fri, 17 Nov 2017 11:41:18 +0000 (12:41 +0100)]
Fixed formatting.
Brent Collins [Wed, 12 Apr 2017 19:03:20 +0000 (14:03 -0500)]
Make the new winpr_Digest*MD5_Allow_FIPS functions more generic to no longer be MD5 specific in design. This way the FIPS override
could easily be extended to more digests in the future. For now, an attempt to use these functions with anything other than MD5 will
not work.
Brent Collins [Tue, 11 Apr 2017 17:04:25 +0000 (12:04 -0500)]
Initialize SSL directly in the sample server, instead of relying on the SSL initialize logic
in the tls code as it was removed in a previous patch due to its redundancy.
Brent Collins [Tue, 11 Apr 2017 17:02:17 +0000 (12:02 -0500)]
Fix checks for openssl version numbers around fips changes, they were using an incorrect version matching 1.1.0 and not 1.0.1
Simplify the logic to enable openssl fips mode
Brent Collins [Tue, 11 Apr 2017 16:57:39 +0000 (11:57 -0500)]
Do not initialize SSL in freerdp_context_new, it is too early to detect the fips enabled flag
and is redundant since it is initialized later before actually using SSL.
Brent Collins [Mon, 10 Apr 2017 19:20:50 +0000 (14:20 -0500)]
Fix the return values of the winpr_Digest_Init functions which were accidentally removed
during rework in previous checkin.
Brent Collins [Mon, 10 Apr 2017 19:19:43 +0000 (14:19 -0500)]
Move the disabling nla and setting the fips encryption mode based on fips
mode to happen after argument parsing to ensure it always enforced.
Brent Collins [Mon, 10 Apr 2017 19:03:39 +0000 (14:03 -0500)]
Fix logic error in reworked MD5 call for establishing keys, and fix some minor whitespace issues.
Brent Collins [Mon, 10 Apr 2017 18:33:37 +0000 (13:33 -0500)]
Fix variable definition placement to adhere to older C standard.
Brent Collins [Mon, 10 Apr 2017 18:19:59 +0000 (13:19 -0500)]
FIPS_mode() and FIPS_mode_set() does not exist in OpenSSL versions before 1.0.1
Brent Collins [Mon, 10 Apr 2017 18:06:04 +0000 (13:06 -0500)]
Change initialization of EVP_CIPHER_CTX to use API function instead of trying to calloc().
Fix some warnings noted from build output.
Brent Collins [Mon, 10 Apr 2017 16:08:40 +0000 (11:08 -0500)]
Workaround for missing EVP_CIPH_FLAG_FIPS_NON_ALLOW flag in openssl 1.0.0.
Brent Collins [Fri, 7 Apr 2017 21:54:08 +0000 (16:54 -0500)]
Add new command-line option to force xfreerdp into a fips compliant mode.
This option will ensure that NLA is disabled(since NTLM uses weak crypto algorithms), FIPS
encryption is enabled, and ensure fips mode is enabled for openssl.
Selectively override specific uses of MD5/RC4 with new API calls specifically tailored to override FIPS.
Add comments on why overriding the use of these algorithms under FIPS is acceptable for the locations where overrides happen.
Remove check of server proprietary certificate which was already being ignore to avoid use of MD5.
Initialize winpr openssl earlier to ensure fips mode is set before starting using any crypto algorithms.
David Fort [Fri, 17 Nov 2017 08:36:50 +0000 (09:36 +0100)]
Merge pull request #4242 from ccpp/afreerdp_versioncode_11
Increase APK versionCode for aFreeRDP 2.0-rc1
Christian Plattner [Fri, 17 Nov 2017 07:58:07 +0000 (08:58 +0100)]
Increase versionCode for aFreeRDP 2.0-rc1
David Fort [Thu, 16 Nov 2017 14:26:03 +0000 (15:26 +0100)]
Merge pull request #4186 from RangeeGmbH/multimonitor_primary_fix
FreeRDP multimonitor: Use first command line element, then primary, …
David Fort [Thu, 16 Nov 2017 12:26:01 +0000 (13:26 +0100)]
Merge pull request #4000 from akallabeth/ign_keyword_fix
Command line ignore empty if flag set
akallabeth [Thu, 16 Nov 2017 11:07:07 +0000 (12:07 +0100)]
Merge pull request #4034 from blino/wayland-keymap
Reuse evdev/X11 keymap for wayland
Armin Novak [Fri, 10 Nov 2017 10:52:23 +0000 (11:52 +0100)]
Option to force password prompt before connection
The idea is based on #3257.
If a non NLA connection is requested the password callbacks are not executed
and there is currently no way to read from stdin.
This extension of /from-stdin allows reading the passwords
before the connection is established.