platform/core/csapi/xsf.git
5 years agoCherry pick Tizen project changes to 4.0.0 and modify SLN changes VS makes (#6396)
Shane Neuville [Tue, 4 Jun 2019 23:48:29 +0000 (17:48 -0600)]
Cherry pick Tizen project changes to 4.0.0 and modify SLN changes VS makes (#6396)

* [Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)

* sln changes that vs wants to apply

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 1 Jun 2019 01:50:16 +0000 (18:50 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agoRoll back assembly version to 2.0.0.0 (#6379)
Samantha Houts [Sat, 1 Jun 2019 01:36:34 +0000 (18:36 -0700)]
Roll back assembly version to 2.0.0.0 (#6379)

fixes #6375

5 years ago[Android] Remove call to update Image on button during measure (#6274)
Shane Neuville [Wed, 29 May 2019 01:40:39 +0000 (19:40 -0600)]
[Android] Remove call to update Image on button during measure (#6274)

* remove update call before measure

* apply to material as well
fixes #6260

5 years agoroll back IButtonLayoutRenderer to its former 3.6 glory (#6290)
Shane Neuville [Wed, 29 May 2019 00:27:26 +0000 (18:27 -0600)]
roll back IButtonLayoutRenderer to its former 3.6 glory (#6290)

5 years agoCheck for correct API version (#6306)
E.Z. Hart [Tue, 28 May 2019 19:48:17 +0000 (13:48 -0600)]
Check for correct API version (#6306)

fixes #5693

5 years ago[Android] propagate elevation after initial elevation changes android (#6271)
Shane Neuville [Tue, 28 May 2019 18:56:40 +0000 (12:56 -0600)]
[Android] propagate elevation after initial elevation changes android (#6271)

fixes #6262

5 years ago[Shell, Android] Fixes crash on api 22 or less (#6198)
Pavel Yakovlev [Tue, 28 May 2019 17:56:31 +0000 (10:56 -0700)]
[Shell, Android] Fixes crash on api 22 or less (#6198)

fixes #6197

5 years ago[Build] This actually doesn't fix the issue
Rui Marinho [Tue, 28 May 2019 11:01:09 +0000 (12:01 +0100)]
[Build] This actually doesn't fix the issue

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Sat, 25 May 2019 00:33:08 +0000 (01:33 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix env variable for release nuget (#6311)
Rui Marinho [Sat, 25 May 2019 00:30:00 +0000 (01:30 +0100)]
[Build]  Fix env variable for release nuget (#6311)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Fri, 24 May 2019 23:18:10 +0000 (00:18 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix release variable name
Rui Marinho [Fri, 24 May 2019 23:02:44 +0000 (00:02 +0100)]
[Build] Fix release variable name

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Fri, 24 May 2019 21:10:57 +0000 (22:10 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoFix packageversion (#6288)
Rui Marinho [Fri, 24 May 2019 21:08:24 +0000 (22:08 +0100)]
Fix packageversion (#6288)

* [Build] Simplify package version

* [Build] Update the semver package version

* [Build] Remove prepare and set tags

* [Build] Update win build

* [Build] Fix tags

* Update Version.targets

* Update azure-pipelines.yml

* Update Version.targets

* [Build] Fix sign

* Update azure-pipelines.yml

5 years ago[Build] Add a global.json to specify what netcore sdk to use (#6279)
Rui Marinho [Thu, 23 May 2019 15:09:08 +0000 (16:09 +0100)]
[Build] Add a global.json to specify what netcore sdk to use (#6279)

5 years agoProperly guard against statusbar usage (#5999)
Morten Nielsen [Thu, 23 May 2019 00:44:22 +0000 (17:44 -0700)]
Properly guard against statusbar usage (#5999)

If you add the `Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer` nuget package, you'll find the analyzer points out these locations as not correctly guarded against usage.

5 years agoAllow third party libs to display animated images correctly in view recycling scenari...
Daniel Luberda [Thu, 23 May 2019 00:31:01 +0000 (02:31 +0200)]
Allow third party libs to display animated images correctly in view recycling scenarios (#6153)

* VisualElementRenderer and ElevationHelper should be public

* ElevationHelper.SetElevation should be public

* remove comment

* Allows to display animated images on iOS in recycled views (CollectionView, ListView)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 23 May 2019 00:06:47 +0000 (01:06 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Update version target (#6270)
Rui Marinho [Thu, 23 May 2019 00:04:53 +0000 (01:04 +0100)]
[Build] Update version target (#6270)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 22 May 2019 21:21:31 +0000 (22:21 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build]Yaml consolidate nuget (#6266)
Rui Marinho [Wed, 22 May 2019 18:33:27 +0000 (19:33 +0100)]
[Build]Yaml consolidate nuget (#6266)

* [Build] Consolidate nuget version

* [Build] Allow to continue to other steps if package fails to push on internal feed

* [Build] Fix script

5 years ago[Build] Clean Xamarin.Forms.Build
Rui Marinho [Wed, 22 May 2019 16:37:20 +0000 (17:37 +0100)]
[Build] Clean Xamarin.Forms.Build

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 22 May 2019 15:23:05 +0000 (16:23 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix Version for branches with dashes
Rui Marinho [Wed, 22 May 2019 03:04:10 +0000 (04:04 +0100)]
[Build] Fix Version for branches with dashes

5 years ago[Build] Also build tags on yaml
Rui Marinho [Wed, 22 May 2019 01:45:17 +0000 (02:45 +0100)]
[Build] Also build tags on yaml

5 years ago[Build] Update yaml builds (#6230)
Rui Marinho [Wed, 22 May 2019 01:16:26 +0000 (02:16 +0100)]
[Build] Update yaml builds (#6230)

* [Build] Update build yaml

* [MacOS]Fix warning

* [Build] Enable binlog

* [Build] Run tests after build, update nuget version

* [Build] Don't build PagesGallery and Embedding

5 years ago[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo (#6068)
Rui Marinho [Wed, 22 May 2019 00:06:59 +0000 (01:06 +0100)]
[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo (#6068)

* [Build] Remove submodule

* [Build] Use GitInfo to set Assembly metadata

* [Build] Remove extra prop

* [Build] Update version

* [Build] Update versions to be consistent with existing Build.Tasks

* [Build] Update build number

* [Build] make sure build tasks gets info

* [Build] Add assembly info unit test

* [Test] Refactor test for gitinfo on vsts

5 years agoHeight -> Width; fixes #6168 (#6213)
E.Z. Hart [Fri, 17 May 2019 00:21:16 +0000 (17:21 -0700)]
Height -> Width; fixes #6168 (#6213)

5 years agoInvalidateLayout after reload to avoid iOS 10 crash (#6190)
E.Z. Hart [Tue, 14 May 2019 19:20:29 +0000 (12:20 -0700)]
InvalidateLayout after reload to avoid iOS 10 crash (#6190)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 11 May 2019 19:12:26 +0000 (12:12 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agoitem template attached, fix icon propagations (#6173)
Shane Neuville [Sat, 11 May 2019 19:09:10 +0000 (12:09 -0700)]
item template attached, fix icon propagations (#6173)

* item template attached, fix icon propagations

* tabs

5 years ago[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)
Samantha Houts [Sat, 11 May 2019 19:08:21 +0000 (12:08 -0700)]
[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)

* Add repro for #5888

Co-Authored-By: melimion <melimion@users.noreply.github.com>
* [iOS] Fix HasUnevenRows for iOS11+

Co-Authored-By: melimion <melimion@users.noreply.github.com>
fixes #5888

5 years agoremove safe area from inset (#6169)
Shane Neuville [Sat, 11 May 2019 19:07:49 +0000 (12:07 -0700)]
remove safe area from inset (#6169)

5 years ago[iOS] Fix NRE when looking for internal buttons (#6170)
Rui Marinho [Sat, 11 May 2019 01:33:50 +0000 (18:33 -0700)]
[iOS] Fix NRE when looking for internal buttons (#6170)

5 years ago[iOS] Shell _headerView can apparently be null (#6164)
Samantha Houts [Fri, 10 May 2019 20:57:55 +0000 (13:57 -0700)]
[iOS] Shell _headerView can apparently be null (#6164)

5 years ago[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties...
Samantha Houts [Fri, 10 May 2019 20:38:39 +0000 (13:38 -0700)]
[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText... (#6165)

* [Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText

But more concerning is that the `shellIconTextDescription` isn't used at all. Is it leftover code, or is this a mistake?

* [Android] Remove dead code from shellIconTextDescripion

5 years agostack the elevation of elements (#6108)
Shane Neuville [Fri, 10 May 2019 04:08:14 +0000 (21:08 -0700)]
stack the elevation of elements (#6108)

* stack the elevation of elements

* only layer implicit elevations

* check elevation of incoming elemelements

* fix api 19
fixes #2989
fixes #3543

5 years agofix up shell menu items, fix templates, fix bindings (#6117)
Shane Neuville [Fri, 10 May 2019 03:58:04 +0000 (20:58 -0700)]
fix up shell menu items, fix templates, fix bindings (#6117)

* fix up shell menu items, fix templates, fix bindings

* propagate bindingcontext changed on menu items

* address feedback
fixes #4399
fixes #5707

5 years agoRemove experimental flag for shell and change a few apis (#6086) fixes #2415
Shane Neuville [Thu, 9 May 2019 21:18:04 +0000 (14:18 -0700)]
Remove experimental flag for shell and change a few apis (#6086) fixes #2415

* api changes for shell official

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellSection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItem.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix compile errors

* fix ui test

* fix ui test

* removed some more properties

* remove a couple more

5 years ago[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956
Shane Neuville [Thu, 9 May 2019 21:17:30 +0000 (14:17 -0700)]
[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956

* create an actual logical child structure for page to use for propagation

* JustTheLogicalChildren

* only iterate over ActuallyLogicalChildren

* fix naming

* reuse ChildrenNotDrawnByThisElement

* testing

* fix unit test

5 years ago[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109...
Shane Neuville [Thu, 9 May 2019 21:16:52 +0000 (14:16 -0700)]
[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109) fixes #3875

* fix the flyout header to size based on content opposed to a fixed height

* update storeshell

* added height slider into storeshell

* resize header if underlying measure changes

* unsubscribe

5 years ago[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)
Samantha Houts [Thu, 9 May 2019 18:00:14 +0000 (11:00 -0700)]
[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)

* Add tests for #6132 and #6130

* [Android] Fix EnableZoomControl BP name and fix helper methods

fixes #6132
fixes #6130

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

5 years ago[Android] VisualElementRenderer and ElevationHelper should be public (#6131)
Daniel Luberda [Thu, 9 May 2019 17:57:59 +0000 (19:57 +0200)]
[Android] VisualElementRenderer and ElevationHelper should be public (#6131)

* VisualElementRenderer and ElevationHelper should be public

* ElevationHelper.SetElevation should be public

* remove comment

5 years ago[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchH...
Rui Marinho [Thu, 9 May 2019 17:42:19 +0000 (10:42 -0700)]
[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchHandler (#5810)

* [Shell,iOS] Add Colors, Font , HorizontalAlignment and keyboard support to SearchHandler

* {Android]Allow set colors and customize text on Shell SearchHandler

* [Android] Update icons color on SearchView

* [Android] Update Placeholdericon color from one place

* [iOS] Update shell cancel button colours

* [iOS,Android] Update IconPlaceholder color

* [Core] Fix missing region

* [Controls] Add shell SearchHandlerPage

* [iOS] Fix alignment changes on SearchHandlerAppearanceTraccker

* [Shell,Core] Add focus to SearchHandler

* [Android] Add SearchHandler focus

* [iOS] Add SearchHandler focus

* [Controls] Reuse dynamic gallery for SearchHandler

* [Controls] Fixes to gallery

* [Android] Remove cancel button code

* [Android] Add extension point for SearchHandlerAppearanceTracker

* [Android] Fix spelling

* fix bad merge

fixes #3125
fixes #5768

5 years ago[Android] Fix Frame size (#6115) fixes #5766
Pavel Yakovlev [Thu, 9 May 2019 16:20:37 +0000 (19:20 +0300)]
[Android] Fix Frame size (#6115) fixes #5766

5 years ago4.0 ABI Fixes (#6133) fixes #6123
Shane Neuville [Thu, 9 May 2019 16:17:59 +0000 (10:17 -0600)]
4.0 ABI Fixes (#6133) fixes #6123

* fix background image type

* additional abi fixes

* updated 4915 to test nav icon

* uwp fixes

* Update Xamarin.Forms.Platform.UAP/TabbedPageStyle.xaml

5 years ago[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items...
Rui Marinho [Thu, 9 May 2019 16:14:25 +0000 (09:14 -0700)]
[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items (#5758) fixes #5132

* [Controls,Shell] Add automation properties to FlyoutIcon

* [iOS] Set accessibility properties from flyout icon on ShellPageRenderer

* [Android] Add accessibility features to Shell flyout icon

* [Android] Add accessibility to shell toolbar and button items

* [Controls] Add uitest for issue #5132

* [Controls] Fix uitest android

* [Controls] Use new types

* [UItests] Only run on iOS and Android

Co-Authored-By: rmarinho <me@ruimarinho.net>
* [Controls] Add scrollview to test page

* [Android] Set icon AutomationId using NavigationContentDescription

* [Android] Restore code on AutomationPropertiesProvider

* [Android] Set help text or AutomationID for toolbar navigation content description

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

5 years ago[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)
Shane Neuville [Thu, 9 May 2019 07:05:57 +0000 (01:05 -0600)]
[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)

* add DesignerFlyoutRenderer

* private and hack comment

* internal

5 years agoremove route params from shell (#6081)
Shane Neuville [Wed, 8 May 2019 23:15:43 +0000 (17:15 -0600)]
remove route params from shell (#6081)

* remove route params from shell

* Update Xamarin.Forms.Core.UnitTests/ShellTests.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix unit test

5 years ago[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)
Shane Neuville [Wed, 8 May 2019 23:15:18 +0000 (17:15 -0600)]
[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)

* add tab bar and promote implicit tabs to same tabbar

* - remove parent

* remove tab bar from flyout

* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
5 years agoMake Android CollectionView smarter about recycling elements/renderers (#5980)
E.Z. Hart [Wed, 8 May 2019 23:14:18 +0000 (17:14 -0600)]
Make Android CollectionView smarter about recycling elements/renderers (#5980)

5 years ago[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089...
E.Z. Hart [Wed, 8 May 2019 16:02:14 +0000 (10:02 -0600)]
[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089) fixes #5793

* Add missing call to ReloadData on INCC Reset; fixes #5793

* Automated test for INCC Reset

5 years agoApply round corners shape based on radius (#6099)
Shane Neuville [Tue, 7 May 2019 16:52:53 +0000 (10:52 -0600)]
Apply round corners shape based on radius (#6099)

* Apply round corners shape based on radius

* update gallery

* apply to SmallComponentShape

* add color scheme back

* basic fixes

* - make corner radius default the same
- reapply theme on ios so corner is changeable
- force set ios border width to size

* fix border width for default and remove extra call to bgcolor

5 years agoreturn from designer earlier (#6102)
Shane Neuville [Tue, 7 May 2019 01:44:00 +0000 (19:44 -0600)]
return from designer earlier (#6102)

* return from designer earlier

* - initialize fake coordinator layout for designer

* change to a non appcompat compatible layout

5 years agoUpdate screen size info after orientation change on Android/iOS (#5975)
E.Z. Hart [Mon, 6 May 2019 22:27:43 +0000 (16:27 -0600)]
Update screen size info after orientation change on Android/iOS (#5975)

* Update Android screen size info in Device when changing orientation;
Fixes #4992

* Add test instructions

* Update iOS screen size on orientation change

* Fix build error in UI Test projects

* Fix errors with #if directives in iOS/macOS projects

* Update Xamarin.Forms.Platform.MacOS/MacDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.Android/Forms.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.iOS/IOSDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
5 years agorename SearchBoxVisibility (#6103)
Shane Neuville [Mon, 6 May 2019 20:31:06 +0000 (14:31 -0600)]
rename SearchBoxVisibility (#6103)

5 years agoHopefully fix the mdoc issues with the localization typo (#6105)
E.Z. Hart [Mon, 6 May 2019 20:29:27 +0000 (14:29 -0600)]
Hopefully fix the mdoc issues with the localization typo (#6105)

5 years ago[Android] Image load fixes (#6062)
Shane Neuville [Mon, 6 May 2019 17:13:36 +0000 (11:13 -0600)]
[Android] Image load fixes (#6062)

* fix loading for lollipop

* cache

* fix some loading behavior

* requested changes

* cache fixes

* API 19 fix

* fix sizeof and use lazy

* add better management over requests to same key

* add caching validity checks

* remove remove and fire and forget put

* synchronous put

* add disposed check for bitmap data

* max memory

5 years agochanges transition to enter mask (#6066)
Shane Neuville [Fri, 3 May 2019 18:38:46 +0000 (12:38 -0600)]
changes transition to enter mask (#6066)

fixes #5216

5 years ago[Android] Fix previewer exceptions with shell (#5955)
Shane Neuville [Thu, 2 May 2019 10:26:42 +0000 (04:26 -0600)]
[Android] Fix previewer exceptions with shell (#5955)

* shell preivewer

* nonappcompat hack

* - moove up null check

* internal IsDesignerContext

5 years agoretain local variable of page so not collected (#6054)
Shane Neuville [Wed, 1 May 2019 16:12:41 +0000 (10:12 -0600)]
retain local variable of page so not collected (#6054)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Mon, 29 Apr 2019 23:42:15 +0000 (16:42 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agofix global routes to push onto stack correctly (#6025)
Shane Neuville [Mon, 29 Apr 2019 23:40:12 +0000 (17:40 -0600)]
fix global routes to push onto stack correctly (#6025)

fixes #6016

5 years agoadditional proguard rules for shell (#6032)
Shane Neuville [Sat, 27 Apr 2019 19:21:30 +0000 (13:21 -0600)]
additional proguard rules for shell (#6032)

* additional proguard rules for shell

* add property to disable file

fixes #5799

5 years agoadd check for null track drawable (#6029)
Shane Neuville [Sat, 27 Apr 2019 19:18:33 +0000 (13:18 -0600)]
add check for null track drawable (#6029)

fixes #5970

5 years ago[Android] set dialog to null when dismissed (#6031)
Shane Neuville [Sat, 27 Apr 2019 19:18:08 +0000 (13:18 -0600)]
[Android] set dialog to null when dismissed (#6031)

fixes #5945

5 years ago[Android] Use Fast Renderers by Default (#5926)
Samantha Houts [Sat, 27 Apr 2019 19:15:39 +0000 (12:15 -0700)]
[Android] Use Fast Renderers by Default (#5926)

* [Android] Unseal FastRenderers

* [Android] Flip experimental flag to legacy flag

* Flip flag for testing both renderers & set up custom renderers for testing

* Undo build arg change

This reverts commit 8447fec03b4dff16d8ca96544ec83159670b80d7.

* Fix whitespace

* restore workaround for #2520

* Only use workaround for fast renderers (crashes legacy)

fixes #5724

5 years agofix tizen obsolete errors (#6030)
Shane Neuville [Sat, 27 Apr 2019 17:48:26 +0000 (11:48 -0600)]
fix tizen obsolete errors (#6030)

5 years ago[iOS] remove SetPaddingInsets api and just have it pad content and flyout by default...
Shane Neuville [Sat, 27 Apr 2019 03:29:42 +0000 (21:29 -0600)]
[iOS] remove SetPaddingInsets api and just have it pad content and flyout by default (#5990)

* remove content setting api and just set by default

* - address comments and centralize window insets check

* add check if height < 0

5 years ago[WIP] Unify the image handling (#4915)
Matthew Leibowitz [Fri, 26 Apr 2019 20:46:13 +0000 (00:46 +0400)]
[WIP] Unify the image handling (#4915)

* Initial code to get unifiied image handling
 - not yet tested
 - still using FileImageSource in some areas

* Updated the button renderers and added tests for Android

* Updated a few more of the Android renderers
 - also added an `IsEmpty` property to the ImageSource to indicate if this source actually contains data that can be used to try and load an image
 - added a few more "tests"
 - includes the changes for #4916

* A few more changes

* Keep the default page for the sample app

* Changing everything to ImageSource and going from there
 - Android, iOS, UWP and WPF are compiling
 - GTK, Mac and Tizen are not yet finished
 - Added a new interface for UWP to return an IconElement in addition to ImageSource (for app bar buttons)
 - not tested yet, nor are there any tests

* Renamed the property to be more useful

* All of Android is now async
 - still only minimal tests
 - also removed the bits that are in https://github.com/xamarin/Xamarin.Forms/pull/4948

* Update Xamarin.Forms.Platform.cs

* A few fixes to whitespace and nameof()

* Updated iOS and UWP wirth async image sources

* A few fixes and WPF support

* A few fixes for Android after the big merge

* Updated a few more loaders:
 - ios
 - macos
 - tizen
 - gtk

* Fix a few things after the merge

* - cast type to FileImageSource

* fix setting of title content if icon doesn't load

* fix IButtonLayoutManager to return correct control

* remove cast and add pack api

* - fix timing issues with layout/invalidation

* - remove aggresive element invalidations for now

* first set of api changes

* obsolete old apis and create new ones for ImageSource

* obsolete messages and static ordering fix

* add tests

* switch default on windows to show images on tabs

* - XStatic obsolete fix

* fix NPC test and bring back alert check on uwp

Fixes #3207
Fixes #4689

5 years agoAdd null check in iOS ShadowEffect OnDetached (#5952)
Matt Soucoup [Fri, 26 Apr 2019 16:15:04 +0000 (18:15 +0200)]
Add null check in iOS ShadowEffect OnDetached (#5952)

Added a null check in iOS ShadowEffect OnDetached
fixes #5951

5 years ago[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)
Kangho Hur [Mon, 15 Apr 2019 16:55:56 +0000 (01:55 +0900)]
[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)

* [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual

* Update Tizen.NET.MaterialComponent for applying color scheme

* Don't build XF.Material.Tzien on iPhone and iPhoneSimulator

* Fix MCanvas build issue

* Update build-windows.yml for XF.Material.Tizen

5 years agoAdd the ShellRenderer for Tizen (#5818)
yourina [Mon, 8 Apr 2019 16:54:41 +0000 (01:54 +0900)]
Add the ShellRenderer for Tizen (#5818)

5 years agoShell hamburger (#5961)
Shane Neuville [Thu, 25 Apr 2019 00:36:19 +0000 (18:36 -0600)]
Shell hamburger (#5961)

* Draw the hamburger if the user hasn't supplied an icon

* move variable

* remove excess code

* remove public

5 years agofix infinite loops and remove public apis (#5954)
Shane Neuville [Wed, 24 Apr 2019 22:25:12 +0000 (16:25 -0600)]
fix infinite loops and remove public apis (#5954)

* fix infinite loops and remove public apis

* - remove comments, fix location to not have implicit

* force uri to be relative on ios when no scheme specified

* address PR comments

* add error message

* reformat absolute uris

* additional suggestions

* Update Xamarin.Forms.Core/Shell/ShellNavigationState.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
5 years agoAllow CollectionView items to resize with their content (#5905)
E.Z. Hart [Wed, 24 Apr 2019 18:30:02 +0000 (12:30 -0600)]
Allow CollectionView items to resize with their content (#5905)

* Add gallery for reproing expanding DataTemplate content;
Allow ItemContentView on Android to expand with content;
Allow ItemContentView on iOS to expand with content;
Fixes #5647

* Improve instructions
Fixes #5721
Fixes #5521

* Apply suggestions from code review

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Clear binding contexts before recycling cells/viewholders.

5 years ago[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)
Pavel Yakovlev [Wed, 24 Apr 2019 02:33:09 +0000 (05:33 +0300)]
[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)

* [Shell, Android] added tab order on Shell flyout menu items

* [iOS mac] fix build

* support iOS

5 years agoAdd unit tests for TabIndexExtensions (#5722)
Samantha Houts [Wed, 24 Apr 2019 00:09:20 +0000 (17:09 -0700)]
Add unit tests for TabIndexExtensions (#5722)

* Add check to FindNextElement

* Add unit tests for TabIndexExtensions

5 years agoAvoid LINQ exception (#5933)
Morten Nielsen [Tue, 23 Apr 2019 17:18:19 +0000 (10:18 -0700)]
Avoid LINQ exception (#5933)

* Avoid LINQ exception

If the back button in UWP is pressed, but there's nothing in the backstack, the `Last()` LINQ query will throw `System.InvalidOperationException: 'Sequence contains no elements`
This change avoids that, and just returns false that Forms didn't handle the event.

* Change to use LastOrDefault

5 years agoadd delay to 2951 (#5972)
Shane Neuville [Tue, 23 Apr 2019 17:13:20 +0000 (11:13 -0600)]
add delay to 2951 (#5972)

5 years ago[Android] move runtime registration of renderers to its own method (#5946)
Shane Neuville [Thu, 18 Apr 2019 15:25:58 +0000 (09:25 -0600)]
[Android] move runtime registration of renderers to its own method (#5946)

* move renderer registration to its own method

* - move to static

5 years ago[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934)...
Shane Neuville [Thu, 18 Apr 2019 15:25:31 +0000 (09:25 -0600)]
[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501

* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 18 Apr 2019 15:15:48 +0000 (16:15 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fixes to yaml public build (#5948)
Rui Marinho [Thu, 18 Apr 2019 15:14:47 +0000 (16:14 +0100)]
[Build] Fixes to yaml public build (#5948)

* [Build] Don't sign on public builds

* [Build] Use vmImages

* [Build] Fix pool specification

* [Build] Revert back to pool name

* [Build] add osx demands

* [Build] Fix indentation

* [Build] Add more demands

* [Build] Try using certs

* [Build] Try use name

* cert password

* [Build] Add endpoint back

* [Build] Add VSTS feed as variable

* [Build] Add signing stuff

* Fix

* [Build] Try simplify Windows build

* [Build] Publish android apps

* [Build] Add signVmImage

5 years agoMove IElementConfiguration to an internal structure on Cell (#5850)
Shane Neuville [Wed, 17 Apr 2019 17:59:16 +0000 (11:59 -0600)]
Move IElementConfiguration to an internal structure on Cell (#5850)

* Move IElementConfiguration to an internal structure on Cell

* set custom ElementConfiguration to private

* fix comments

5 years agoRemove need for PressEnter on test 5535 because it crashes iOS 12 tests
E.Z. Hart [Wed, 17 Apr 2019 16:13:10 +0000 (10:13 -0600)]
Remove need for PressEnter on test 5535 because it crashes iOS 12 tests

5 years agos/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)
Larry O'Brien [Tue, 16 Apr 2019 22:04:55 +0000 (12:04 -1000)]
s/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)

* s/SearchBoxVisiblty/SearchBoxVisibility/

Fix typo in type name.

* s/Collapsable/Collapsible/

* Changed capitalization in comment

5 years agoremove used Group Header Template (#5906)
Shane Neuville [Tue, 16 Apr 2019 16:38:17 +0000 (10:38 -0600)]
remove used Group Header Template (#5906)

5 years ago[iOS] Fix usage of iOS11 api (#5893)
Rui Marinho [Mon, 15 Apr 2019 21:24:50 +0000 (22:24 +0100)]
[iOS] Fix usage of iOS11 api (#5893)

* [iOS] Fix usage of iOS11 api

* [iOS] Fix remaining calls to HomeIndicatorHidden feature

5 years ago[Shell] Hide Shell types from being browsable (#5915)
Shane Neuville [Mon, 15 Apr 2019 16:22:47 +0000 (10:22 -0600)]
[Shell] Hide Shell types from being browsable (#5915)

* set shell things to EditorBrowsable false

* - EditorBrowsable always

* delete tab content

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 13 Apr 2019 01:28:49 +0000 (18:28 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago- add explicit references back into nuspec (#5902)
Shane Neuville [Fri, 12 Apr 2019 23:25:54 +0000 (17:25 -0600)]
- add explicit references back into nuspec (#5902)

5 years ago[Android, shell] fixes visibility of tabs after their changes (#5896)
Pavel Yakovlev [Fri, 12 Apr 2019 16:33:33 +0000 (19:33 +0300)]
[Android, shell] fixes visibility of tabs after their changes (#5896)

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 11 Apr 2019 04:59:38 +0000 (21:59 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)
piotrkonowalski [Thu, 11 Apr 2019 04:58:34 +0000 (06:58 +0200)]
[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)

fixes #5310

5 years ago[Shell] refactor of processing uris (#5852)
Shane Neuville [Thu, 11 Apr 2019 04:54:50 +0000 (22:54 -0600)]
[Shell] refactor of processing uris (#5852)

fixes #5790

5 years ago[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)
Samantha Houts [Thu, 11 Apr 2019 04:53:37 +0000 (21:53 -0700)]
[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)

fixes #2789

5 years agoPorting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (...
E.Z. Hart [Thu, 11 Apr 2019 04:28:11 +0000 (22:28 -0600)]
Porting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (#5863)

fixes #4790

5 years ago[Android] Null check on Switch TrackDrawable (#5851)
Samantha Houts [Thu, 11 Apr 2019 00:25:45 +0000 (17:25 -0700)]
[Android] Null check on Switch TrackDrawable (#5851)

* [Android] Null check on Switch TrackDrawable

fixes #5553

* Add a few more checks, dispose Drawable, fix copy/paste error

* Couple more for safety's sake