platform/upstream/llvm.git
6 years ago[MS Demangler] Properly handle backreferencing of special names.
Zachary Turner [Wed, 8 Aug 2018 00:43:31 +0000 (00:43 +0000)]
[MS Demangler] Properly handle backreferencing of special names.

Function template names are not stored in the backref table,
but non-template function names are.  The general pattern seems
to be that when you are demangling a symbol name, if the name
starts with '?' it does not go into the backreference table,
otherwise it does.  Note that this even handles the general case
of operator names (template or otherwise) not going into the
back-reference table, anonymous namespaces not going into the
backreference table, etc.

It's important that we apply this check *only* for the
unqualified portion of a name, and only for symbol names.
For example, this does not apply to type names (such as class
templates) and we need to make sure that these still do go
into the backref table.

Differential Revision: https://reviews.llvm.org/D50394

llvm-svn: 339211

6 years agoPR38286: Don't crash when attempting to define a constructor for an
Richard Smith [Wed, 8 Aug 2018 00:42:42 +0000 (00:42 +0000)]
PR38286: Don't crash when attempting to define a constructor for an
incomplete class template.

llvm-svn: 339210

6 years ago[libcxx] [test] Add missing <stdexcept> in several tests.
Billy Robert O'Neal III [Wed, 8 Aug 2018 00:40:32 +0000 (00:40 +0000)]
[libcxx] [test] Add missing <stdexcept> in several tests.

Reviewed as https://reviews.llvm.org/D50420

llvm-svn: 339209

6 years ago[tablegen] Improve performance of -gen-register-info by replacing barely-necessary...
Daniel Sanders [Wed, 8 Aug 2018 00:19:59 +0000 (00:19 +0000)]
[tablegen] Improve performance of -gen-register-info by replacing barely-necessary std::map with a sorted vector

Summary:
This particular map is hardly ever queried and has a phased usage pattern (insert,
iterate, query, insert, iterate) so it's a good candidate for a sorted vector and
std::lower_bound.

This significantly reduces the run time of runTargetDesc() in some circumstances.
One llvm-tblgen invocation in my build improves the time spent in runTargetDesc()
from 9.86s down to 0.80s (~92%) without changing the output. The same invocation
also has 2GB less allocation churn.

Reviewers: bogner, rtereshin, aditya_nandakumar, volkan

Reviewed By: rtereshin

Subscribers: mgrang, dexonsmith, llvm-commits

Differential Revision: https://reviews.llvm.org/D50272

llvm-svn: 339208

6 years ago[CodeGen] IncompleteArray Support
Balaji V. Iyer [Wed, 8 Aug 2018 00:01:21 +0000 (00:01 +0000)]
[CodeGen] IncompleteArray Support

Added code to support ArrayType that is not ConstantArray.

https://reviews.llvm.org/D49952
rdar://42476155

llvm-svn: 339207

6 years agoDelete a dead Function constructor (NFC)
Vedant Kumar [Tue, 7 Aug 2018 23:48:40 +0000 (23:48 +0000)]
Delete a dead Function constructor (NFC)

llvm-svn: 339206

6 years ago[StackFrame] Add more clarifying comments to StackFrameList (NFC)
Vedant Kumar [Tue, 7 Aug 2018 23:48:25 +0000 (23:48 +0000)]
[StackFrame] Add more clarifying comments to StackFrameList (NFC)

llvm-svn: 339205

6 years agoRemoved doxygen comment that doesn't fit to function signature
Raphael Isemann [Tue, 7 Aug 2018 23:47:05 +0000 (23:47 +0000)]
Removed doxygen comment that doesn't fit to function signature

llvm-svn: 339204

6 years ago[InstCombine] add tests for fneg fold including FMF; NFC
Sanjay Patel [Tue, 7 Aug 2018 23:24:25 +0000 (23:24 +0000)]
[InstCombine] add tests for fneg fold including FMF; NFC

llvm-svn: 339203

6 years agoRemoved duplicated commented-out code [NFC]
Raphael Isemann [Tue, 7 Aug 2018 23:24:24 +0000 (23:24 +0000)]
Removed duplicated commented-out code [NFC]

llvm-svn: 339202

6 years ago[analyzer] Avoid querying this-pointers for static-methods.
Matt Davis [Tue, 7 Aug 2018 23:13:28 +0000 (23:13 +0000)]
[analyzer] Avoid querying this-pointers for static-methods.

Summary:
The loop-widening code processes c++ methods looking for `this` pointers.  In
the case of static methods (which do not have `this` pointers), an assertion
was triggering.   This patch avoids trying to process `this` pointers for
static methods, and thus avoids triggering the assertion .

Reviewers: dcoughlin, george.karpenkov, NoQ

Reviewed By: NoQ

Subscribers: NoQ, xazax.hun, szepet, a.sidorin, mikhail.ramalho, cfe-commits

Differential Revision: https://reviews.llvm.org/D50408

llvm-svn: 339201

6 years ago[InstCombine] fix FP constant in test; NFC
Sanjay Patel [Tue, 7 Aug 2018 23:03:29 +0000 (23:03 +0000)]
[InstCombine] fix FP constant in test; NFC
Too many digits...

llvm-svn: 339200

6 years ago[VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.
Volodymyr Sapsai [Tue, 7 Aug 2018 23:00:40 +0000 (23:00 +0000)]
[VFS] Unify iteration code for VFSFromYamlDirIterImpl, NFC intended.

First and subsequent iteration steps are similar, capture this similarity.

Reviewers: bruno, benlangmuir

Reviewed By: bruno

Subscribers: dexonsmith, cfe-commits

Differential Revision: https://reviews.llvm.org/D50118

llvm-svn: 339199

6 years ago[Sema] Ensure an auto non-type template parameter is dependent
Erik Pilkington [Tue, 7 Aug 2018 22:59:02 +0000 (22:59 +0000)]
[Sema] Ensure an auto non-type template parameter is dependent

The dependent auto was getting stripped away while rebuilding the template
parameter type, so substitute it in.

rdar://41852459

Differential revision: https://reviews.llvm.org/D50088

llvm-svn: 339198

6 years ago[NFC] adding tests for Y - (X + Y) --> -X
Michael Berg [Tue, 7 Aug 2018 22:52:57 +0000 (22:52 +0000)]
[NFC] adding tests for Y - (X + Y) --> -X

llvm-svn: 339197

6 years ago[NFC] Improve auto-var-init alignment check
JF Bastien [Tue, 7 Aug 2018 22:43:44 +0000 (22:43 +0000)]
[NFC] Improve auto-var-init alignment check

We're not actually testing for alignment, we just want to know that whatever incoming alignment got propagated. Do that by capturing the alignment and checking that it's actually what's passed later, instead of hard-coding an alignment value.

llvm-svn: 339196

6 years ago[InstCombine] add tests for fneg of fmul/fdiv with constant; NFC
Sanjay Patel [Tue, 7 Aug 2018 22:30:43 +0000 (22:30 +0000)]
[InstCombine] add tests for fneg of fmul/fdiv with constant; NFC

llvm-svn: 339195

6 years ago[Coverage] Ignore 'unused' functions with non-zero execution counts
Vedant Kumar [Tue, 7 Aug 2018 22:25:36 +0000 (22:25 +0000)]
[Coverage] Ignore 'unused' functions with non-zero execution counts

Frontends emit 'unused' coverage mapping records for functions which are
provably unused in a TU. These unused records contain a single counter
with CounterKind::Zero. However, a function may be unused in one TU and
used in another. When this happens, prefer the records with a full set
of counters instead of arbitrarily picking the first loaded record.

There is no impact on the single-TU case. In the multiple-TU case, this
resolves issues causing a function to appear unused when it's not.

Testing: check-{llvm,clang,compiler-rt}

rdar://42981322

llvm-svn: 339194

6 years ago[Coverage] Delete getCounterMismatches, it's dead code (NFC)
Vedant Kumar [Tue, 7 Aug 2018 22:25:22 +0000 (22:25 +0000)]
[Coverage] Delete getCounterMismatches, it's dead code (NFC)

Exactly one counted region is inserted into a function record for every
region in a coverage mapping.

llvm-svn: 339193

6 years agoRefactor FileCheck to make it usable as an API
Aditya Nandakumar [Tue, 7 Aug 2018 21:58:49 +0000 (21:58 +0000)]
Refactor FileCheck to make it usable as an API

https://reviews.llvm.org/D50283
reviewed by bogner

This patch refactors FileCheck's implementation into support so it can
be used from C++ in other places (Unit tests).

llvm-svn: 339192

6 years ago[NFC] CGDecl factor out constant emission
JF Bastien [Tue, 7 Aug 2018 21:55:13 +0000 (21:55 +0000)]
[NFC] CGDecl factor out constant emission

The code is cleaner this way, and with some changes I'm playing with it makes sense to split it out so we can reuse it.

llvm-svn: 339191

6 years agoAMDGPU: Remove broken i16 ternary patterns
Jan Vesely [Tue, 7 Aug 2018 21:54:37 +0000 (21:54 +0000)]
AMDGPU: Remove broken i16 ternary patterns

Fixup test to check for GCN prefix
These patterns always zero extend the result even though it might need sign extension.
This has been broken since the addition of i16 support.
It has popped up in mad_sat(char) test since min(max()) combination is turned into v_med3, resulting in the following (incorrect) sequence:
        v_mad_i16 v2, v10, v9, v11
        v_med3_i32 v2, v2, v8, v7

Fixes mad_sat(char) piglit on VI.

Differential Revision: https://reviews.llvm.org/D49836

llvm-svn: 339190

6 years agoAdd documentation for SBTarget::AppendImageSearchPath
Alexander Polyakov [Tue, 7 Aug 2018 21:41:59 +0000 (21:41 +0000)]
Add documentation for SBTarget::AppendImageSearchPath

llvm-svn: 339189

6 years agoFix one hard coded value I missed in r339185.
Douglas Yung [Tue, 7 Aug 2018 21:37:14 +0000 (21:37 +0000)]
Fix one hard coded value I missed in r339185.

llvm-svn: 339188

6 years agoClean up and simplify RequireCompleteType.
Richard Smith [Tue, 7 Aug 2018 21:35:41 +0000 (21:35 +0000)]
Clean up and simplify RequireCompleteType.

No functional change intended, except that we will now produce more
"declared here" notes.

llvm-svn: 339187

6 years ago[WebAssembly] Update SIMD binary arithmetic
Derek Schuff [Tue, 7 Aug 2018 21:24:01 +0000 (21:24 +0000)]
[WebAssembly] Update SIMD binary arithmetic

Add missing SIMD types (v2f64) and binary ops. Also adds
tablegen support for automatically prepending prefix byte to SIMD
opcodes.

Differential Revision: https://reviews.llvm.org/D50292

Patch by Thomas Lively

llvm-svn: 339186

6 years agoMake test more robust by not checking hard coded debug info values, but instead check...
Douglas Yung [Tue, 7 Aug 2018 21:22:49 +0000 (21:22 +0000)]
Make test more robust by not checking hard coded debug info values, but instead check the relationships between them.

llvm-svn: 339185

6 years ago[lit] Disable shtest-timeout on Windows
Stella Stamenova [Tue, 7 Aug 2018 21:21:30 +0000 (21:21 +0000)]
[lit] Disable shtest-timeout on Windows

This test passes on Windows when using Python 3 but fails when using Python 2, so it needs more investigation before it can be enabled as the bots use Python 2.

llvm-svn: 339184

6 years ago[analyzer] [tests] Do not be verbose by default when updating reference results.
George Karpenkov [Tue, 7 Aug 2018 21:14:35 +0000 (21:14 +0000)]
[analyzer] [tests] Do not be verbose by default when updating reference results.

llvm-svn: 339183

6 years agoIf a function starts with line number 0, don't try to check if a breakpoint crossed...
Jim Ingham [Tue, 7 Aug 2018 21:09:55 +0000 (21:09 +0000)]
If a function starts with line number 0, don't try to check if a breakpoint crossed function boundaries.

clang doesn't use line number 0 (to mean artifically generated code) very often, but swift does it
quite often.  We were rejecting all by line breakpoints in functions that started at line 0.  But that's
a special marker so we can just not do this test in that case.

llvm-svn: 339182

6 years agoFix the Xcode project for the Core -> Utility moves.
Jim Ingham [Tue, 7 Aug 2018 21:05:34 +0000 (21:05 +0000)]
Fix the Xcode project for the Core -> Utility moves.

Scalar.{h,cpp}, RegisterValue.{h,cpp}, State.{h,cpp} were moved.

llvm-svn: 339181

6 years ago[lit, python] Change the order of the quotes in the lit cfg file
Stella Stamenova [Tue, 7 Aug 2018 20:58:02 +0000 (20:58 +0000)]
[lit, python] Change the order of the quotes in the lit cfg file
Double quotes are always correct in paths on windows while single quotes only work sometimes. By swapping the order of the quotes in the subsitution we guarantee that the quotes will be correct on Windows. Both sets work correctly on Linux in the test environment.

llvm-svn: 339180

6 years ago[lit, python3] Update lit error logging to work correctly in python3 and other test...
Stella Stamenova [Tue, 7 Aug 2018 20:54:38 +0000 (20:54 +0000)]
[lit, python3] Update lit error logging to work correctly in python3 and other test fixes

Summary:
In Python2 'unicode' is a distinct type from 'str', but in Python3 'unicode' does not exist and instead all 'str' objects are Unicode string. This change updates the logic in the test logging for lit to correctly process each of the types, and more importantly, to not just fail in Python3.

This change also reverses the use of quotes in several of the cfg files. By using '""' we are guaranteeing that the resulting path will work correctly on Windows while "''" only works correctly sometimes. This also fixes one of the failing tests.

Reviewers: asmith, zturner

Subscribers: stella.stamenova, delcypher, llvm-commits

Differential Revision: https://reviews.llvm.org/D50397

llvm-svn: 339179

6 years ago[lldb-mi] Re-implement target-select command
Alexander Polyakov [Tue, 7 Aug 2018 20:45:46 +0000 (20:45 +0000)]
[lldb-mi] Re-implement target-select command

Now target-select uses SB API instead of HandleCommand.

This patch has been reviewed along with the r339175.

Differential Revision: https://reviews.llvm.org/D49739

llvm-svn: 339178

6 years ago[Hexagon] Allow use of gather intrinsics even with no-packets
Krzysztof Parzyszek [Tue, 7 Aug 2018 20:33:47 +0000 (20:33 +0000)]
[Hexagon] Allow use of gather intrinsics even with no-packets

Vgather requires must be in a packet with a store, which contradicts
the no-packets feature. As a consequence, gather/scatter could not be
used with no-packets. Relax this, and allow gather packets as exceptions
to the no-packets requirements.

llvm-svn: 339177

6 years ago[InstSimplify] fold fsub+fadd with common operand
Sanjay Patel [Tue, 7 Aug 2018 20:32:55 +0000 (20:32 +0000)]
[InstSimplify] fold fsub+fadd with common operand

llvm-svn: 339176

6 years agoAdd new API to SBTarget class
Alexander Polyakov [Tue, 7 Aug 2018 20:23:57 +0000 (20:23 +0000)]
Add new API to SBTarget class

Summary:
The new API appends an image search path to the
target's path mapping list.

Reviewers: aprantl, clayborg, labath

Reviewed By: aprantl

Subscribers: ki.stfu, lldb-commits

Differential Revision: https://reviews.llvm.org/D49739

llvm-svn: 339175

6 years ago[InstSimplify] fold fadd+fsub with common operand
Sanjay Patel [Tue, 7 Aug 2018 20:23:49 +0000 (20:23 +0000)]
[InstSimplify] fold fadd+fsub with common operand

llvm-svn: 339174

6 years ago[Local] Add dbg location on unreachable inst in changeToUnreachable
Anastasis Grammenos [Tue, 7 Aug 2018 20:21:56 +0000 (20:21 +0000)]
[Local] Add dbg location on unreachable inst in changeToUnreachable

As show in https://bugs.llvm.org/show_bug.cgi?id=37960
it would be desirable to have debug location in the unreachable
instruction.

Also adds a unti test for this function.

Differential Revision: https://reviews.llvm.org/D50340

llvm-svn: 339173

6 years ago[WebAssembly] CFG sort support for exception handling
Heejin Ahn [Tue, 7 Aug 2018 20:19:23 +0000 (20:19 +0000)]
[WebAssembly] CFG sort support for exception handling

Summary:
This patch extends CFGSort pass to support exception handling. Once it
places a loop header, it does not place blocks that are not dominated by
the loop header until all the loop blocks are sorted. This patch extends
the same algorithm to exception 'catch' part, using the information
calculated by WebAssemblyExceptionInfo class.

Reviewers: dschuff, sunfish

Subscribers: sbc100, jgravelle-google, llvm-commits

Differential Revision: https://reviews.llvm.org/D46500

llvm-svn: 339172

6 years ago[InstSimplify] fold fsub+fsub with common operand
Sanjay Patel [Tue, 7 Aug 2018 20:14:27 +0000 (20:14 +0000)]
[InstSimplify] fold fsub+fsub with common operand

llvm-svn: 339171

6 years ago[Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64
Martin Storsjo [Tue, 7 Aug 2018 20:02:40 +0000 (20:02 +0000)]
[Headers] Expand _Unwind_Exception for SEH on MinGW/x86_64

This matches how GCC defines this struct.

Differential Revision: https://reviews.llvm.org/D50380

llvm-svn: 339170

6 years agoUpdate msbuild integration warnings: Don't warn on /Zi and /X
Nico Weber [Tue, 7 Aug 2018 19:55:12 +0000 (19:55 +0000)]
Update msbuild integration warnings: Don't warn on /Zi and /X

We do need to map /Zi to /Z7 explicitly for msbuild as explained in this file,
but since /Zi is passed by default and since things transparently work fine
with it mapped to /Z7, we shouldn't produce effectively inactionable noise for
it.

Also don't warn on /X since clang-cl supports that (since r326357; the risk of
duplicating a bunch of clang-cl driver logic here).

https://reviews.llvm.org/D50398

llvm-svn: 339169

6 years ago[InstSimplify] add tests for fadd/fsub; NFC
Sanjay Patel [Tue, 7 Aug 2018 19:49:13 +0000 (19:49 +0000)]
[InstSimplify] add tests for fadd/fsub; NFC

Instcombine gets some, but not all, of these cases via
it's internal reassociation transforms. It fails in
all cases with vector types.

llvm-svn: 339168

6 years ago[Sema] Fix for crash on conditional operation with address_space pointer
Leonard Chan [Tue, 7 Aug 2018 19:43:53 +0000 (19:43 +0000)]
[Sema] Fix for crash on conditional operation with address_space pointer

Compiling the following causes clang to crash

```
char *cmp(__attribute__((address_space(1))) char *x, __attribute__((address_space(2))) char *y) {
  return x < y ? x : y;
}
```

with the message: "wrong cast for pointers in different address
spaces(must be an address space cast)!"

This is because during IR emission, the source and dest type for a
bitcast should not have differing address spaces.

This fix prints an error since the code shouldn't compile in the first place.

Differential Revision: https://reviews.llvm.org/D50278

llvm-svn: 339167

6 years ago[SLP] Fix insert point for reused extract instructions.
Alexey Bataev [Tue, 7 Aug 2018 19:21:05 +0000 (19:21 +0000)]
[SLP] Fix insert point for reused extract instructions.

Summary:
Reworked the previously committed patch to insert shuffles for reused
extract element instructions in the correct position. Previous logic was
incorrect, and might lead to the crash with PHIs and EH instructions.

Reviewers: efriedma, javed.absar

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D50143

llvm-svn: 339166

6 years agolld-link: Take /SUBSYSTEM into account for automatic /ENTRY detection.
Nico Weber [Tue, 7 Aug 2018 19:10:28 +0000 (19:10 +0000)]
lld-link: Take /SUBSYSTEM into account for automatic /ENTRY detection.

If /subsystem:windows is passed, link.exe only looks for WinMain and wWinMain,
and if /subsystem:console is passed it only looks for main and wmain. lld-link
used to look for all 4 in both cases. This patch makes lld-link match
link.exe's behavior.

This requires that the subsystem is known by the time findDefaultEntry() gets
called. findDefaultEntry() is called before the main link loop, so that the
loop can mark the entry point as undefined. That means inferSubsystem() has to
be called above the main loop as well. This in turn means /subsystem: from
.drectve sections only has an effect on entry point inference for obj files
passed to lld-link directly (and not in obj files found later in .lib files).
link.exe seems to ignore /subsystem: for obj files from lib files completely
(while in lld it's ignored only for entry point detection but it still
overrides /subsystem: flags passed on the command line for the value that gets
written in the output file).

Also, if the subsytem isn't needed (e.g. when only writing a /def: lib file and
not writing a coff file), link.exe doesn't complain if the subsystem isn't
known, so both subsystem and entry point handling should be below the early
return lld has for that case.

Fixes PR36523.
https://reviews.llvm.org/D50316

llvm-svn: 339165

6 years ago[VFS] Emit an error when entry at root level uses a relative path.
Volodymyr Sapsai [Tue, 7 Aug 2018 19:05:41 +0000 (19:05 +0000)]
[VFS] Emit an error when entry at root level uses a relative path.

Entries with only a filename prevent us from building a file system tree and
cause the assertion

> Assertion failed: (NewParentE && "Parent entry must exist"), function uniqueOverlayTree, file clang/lib/Basic/VirtualFileSystem.cpp, line 1303.

Entries with a relative path are simply not discoverable during header search.

rdar://problem/28990865

Reviewers: bruno, benlangmuir

Reviewed By: bruno

Subscribers: dexonsmith, cfe-commits

Differential Revision: https://reviews.llvm.org/D49518

llvm-svn: 339164

6 years ago[WebAssembly] Remove use of lld -flavor flag
Sam Clegg [Tue, 7 Aug 2018 18:55:41 +0000 (18:55 +0000)]
[WebAssembly] Remove use of lld -flavor flag

This flag is deprecated. The preferred way to select the lld
flavor is by calling it by one of its aliases.

Differential Revision: https://reviews.llvm.org/D50395

llvm-svn: 339163

6 years ago[SampleFDO] Fix a bug in getOrCompHotCountThreshold/getOrCompColdCountThreshold
Wei Mi [Tue, 7 Aug 2018 18:13:10 +0000 (18:13 +0000)]
[SampleFDO] Fix a bug in getOrCompHotCountThreshold/getOrCompColdCountThreshold

getOrCompHotCountThreshold/getOrCompColdCountThreshold introduced in
https://reviews.llvm.org/D45377 contain a bad mistake and will only return 1 or 0
instead of the true hot/cold cutoff value. The patch fixes the mistake. But the
mistake seems not causing big performance difference according to internal server
benchmarks testing.

Differential Revision: https://reviews.llvm.org/D50370

llvm-svn: 339162

6 years agoMisc module/dwarf logging improvements
Leonard Mosescu [Tue, 7 Aug 2018 18:00:30 +0000 (18:00 +0000)]
Misc module/dwarf logging improvements

This change improves the logging for the lldb.module category to note a few interesting cases:

1. Local object file found, but specs not matching
2. Local object file not found, using a placeholder module

The handling and logging for the cases wehre we fail to load compressed dwarf
symbols is also improved.

Differential Revision: https://reviews.llvm.org/D50274

llvm-svn: 339161

6 years ago[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.
Alexander Polyakov [Tue, 7 Aug 2018 17:55:26 +0000 (17:55 +0000)]
[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

Summary: Now this function uses SB API instead of HandleCommand.

Reviewers: aprantl, clayborg, labath

Reviewed By: aprantl

Subscribers: ki.stfu, lldb-commits

Differential Revision: https://reviews.llvm.org/D49632

llvm-svn: 339160

6 years ago[LICM] Strengthen assume hoisting tests [NFC]
Philip Reames [Tue, 7 Aug 2018 17:54:36 +0000 (17:54 +0000)]
[LICM] Strengthen assume hoisting tests [NFC]

As requested in review of https://reviews.llvm.org/D50364

llvm-svn: 339159

6 years ago[WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)
David Greene [Tue, 7 Aug 2018 17:44:43 +0000 (17:44 +0000)]
[WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

lld is the only supported linker that works for WebAssembly, so ensure
clang is using it for this test. This gets the tests passing when
configuring clang to use a different linker by default.

Differential Revision: https://reviews.llvm.org/D49897

llvm-svn: 339158

6 years ago[SelectionDAG] When splitting scatter nodes during DAGCombine, create a serial chain...
Craig Topper [Tue, 7 Aug 2018 17:35:02 +0000 (17:35 +0000)]
[SelectionDAG] When splitting scatter nodes during DAGCombine, create a serial chain dependency.

Scatter could have multiple identical indices. We need to maintain sequential order. We get this right in LegalizeVectorTypes, but not in this code.

Differential Revision: https://reviews.llvm.org/D50374

llvm-svn: 339157

6 years ago[SelectionDAG][X86][SystemZ] Add a generic nonvolatile_store/nonvolatile_load pattern...
Craig Topper [Tue, 7 Aug 2018 17:34:59 +0000 (17:34 +0000)]
[SelectionDAG][X86][SystemZ] Add a generic nonvolatile_store/nonvolatile_load pattern fragment in TargetSelectionDAG.td

Differential Revision: https://reviews.llvm.org/D50358

llvm-svn: 339156

6 years agoAdd instructions for building LLDB on Mac OS X with CMake
Alex Langford [Tue, 7 Aug 2018 17:34:13 +0000 (17:34 +0000)]
Add instructions for building LLDB on Mac OS X with CMake

Summary:
There were previously no instructions for building LLDB on Mac OS X
with CMake. It's sufficiently close to building on Linux/FreeBSD/NetBSD that a
well-motivated developer could figure out the steps themselves. However, having
an explicit guide is better and can provide Mac OS X specific configurations
(e.g. LLDB_BUILD_FRAMEWORK).

Reviewers: labath, clayborg

Subscribers: emaste, krytarowski

Differential Revision: https://reviews.llvm.org/D50362

llvm-svn: 339155

6 years agoCheck result after setting PC value.
Tatyana Krasnukha [Tue, 7 Aug 2018 16:46:11 +0000 (16:46 +0000)]
Check result after setting PC value.

llvm-svn: 339153

6 years ago[OPENMP] Mark variables captured in declare target region as implicitly
Alexey Bataev [Tue, 7 Aug 2018 16:14:36 +0000 (16:14 +0000)]
[OPENMP] Mark variables captured in declare target region as implicitly
declare target.

According to OpenMP 5.0, variables captured in lambdas in declare target
regions must be considered as implicitly declare target.

llvm-svn: 339152

6 years ago[RFC] Build LLVM-C.dll on MSVC that exports only the C API
David Bolvansky [Tue, 7 Aug 2018 15:54:50 +0000 (15:54 +0000)]
[RFC] Build LLVM-C.dll on MSVC that exports only the C API

Summary:
Hello!

This commit adds a LLVM-C target that is always built on MSVC. A big fat warning, this is my first cmake code ever so there is a fair bit of I-have-no-idea-what-I'm-doing going on here. Which is also why I placed it outside of llvm-shlib as I was afraid of breaking things of other people. Secondly llvm-shlib builds a LLVM.so which exports all symbols and then does a thin library that points to it, but on Windows we do not build a LLVM.dll so that would have complicated the code more.

The patch includes a python script that calls dumpbin.exe to get all of the symbols from the built libraries. It then grabs all the symbols starting with LLVM and generates the export file from those. The export file is then used to create the library just like the LLVM-C that is built on darwin.

Improvements that I need help with, to follow up this review.
  - Get cmake to make sure that dumpbin.exe is on the path and wire the full path to the script.
  - Use LLVM-C.dll when building llvm-c-test so we can verify that the symbols are exported.
  - Bundle the LLVM-C.dll with the windows installer.

Why do this?  I'm building a language frontend which is self-hosting, and on windows because of various tooling issues we have a problem of consuming the LLVM*.lib directly on windows. Me and the users of my projects using LLVM would be greatly helped by having LLVM-C.dll built and shipped by the Windows installer. Not only does LLVM takes forever to build, you have to run a extra python script in order to get the final DLL.

Any comments, thoughts or help is greatly appreciated.

Cheers, Jakob.

Patch by: Wallbraker (Jakob Bornecrantz)

Reviewers: compnerd, beanz, hans, smeenai

Reviewed By: beanz

Subscribers: xbolva00, bhelyer, Memnarch, rnk, fedor.sergeev, chapuni, smeenai, john.brawn, deadalnix, llvm-commits, mgorny

Differential Revision: https://reviews.llvm.org/D35077

llvm-svn: 339151

6 years ago[OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return
Scott Linder [Tue, 7 Aug 2018 15:52:49 +0000 (15:52 +0000)]
[OpenCL] Restore r338899 (reverted in r338904), fixing stack-use-after-return

Always emit alloca in entry block for enqueue_kernel builtin.

Ensures the statically sized alloca is not converted to DYNAMIC_STACKALLOC
later because it is not in the entry block.

llvm-svn: 339150

6 years ago[GVN,NewGVN] Keep nonnull if K does not move.
Florian Hahn [Tue, 7 Aug 2018 15:36:11 +0000 (15:36 +0000)]
[GVN,NewGVN] Keep nonnull if K does not move.

In combineMetadata, we should be able to preserve K's nonnull metadata,
if K does not move. This condition should hold for all replacements by
NewGVN/GVN, but I added a bunch of assertions to verify that.

Fixes PR35038.

There probably are additional kinds of metadata that could be preserved
using similar reasoning. This is follow-up work.

Reviewers: dberlin, davide, efriedma, nlopes

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D47339

llvm-svn: 339149

6 years ago[ARM] FP16: codegen support for VACGT
Sjoerd Meijer [Tue, 7 Aug 2018 15:11:47 +0000 (15:11 +0000)]
[ARM] FP16: codegen support for VACGT

Differential Revision: https://reviews.llvm.org/D50236

llvm-svn: 339148

6 years ago[DAG] Allow non-uniform constant vectors to call BuildSDIV
Simon Pilgrim [Tue, 7 Aug 2018 14:50:39 +0000 (14:50 +0000)]
[DAG] Allow non-uniform constant vectors to call BuildSDIV

This was missed in D50185.

NFC until we add actual non-uniform support to BuildSDIV (similar BuildUDIV support in D49248) - for now it just early outs.

llvm-svn: 339147

6 years ago[TargetLowering] Use pre-computed Shift value type in BuildUDIV (NFCI)
Simon Pilgrim [Tue, 7 Aug 2018 14:40:21 +0000 (14:40 +0000)]
[TargetLowering] Use pre-computed Shift value type in BuildUDIV (NFCI)

This was missed in D49248

llvm-svn: 339146

6 years ago[X86] MCA tests for XCHG*, XADD* and CMPXCHG* instructions
Andrew V. Tischenko [Tue, 7 Aug 2018 14:36:43 +0000 (14:36 +0000)]
[X86] MCA tests for XCHG*, XADD* and CMPXCHG* instructions
Differential Revision: https://reviews.llvm.org/D49912

llvm-svn: 339145

6 years ago[InstSimplify] move minnum/maxnum with common op fold from instcombine
Sanjay Patel [Tue, 7 Aug 2018 14:36:27 +0000 (14:36 +0000)]
[InstSimplify] move minnum/maxnum with common op fold from instcombine

llvm-svn: 339144

6 years ago[libFuzzer] Disable print_unstable_stats.test for aarch64.
Max Moroz [Tue, 7 Aug 2018 14:22:00 +0000 (14:22 +0000)]
[libFuzzer] Disable print_unstable_stats.test for aarch64.

Summary:
Follow-up for https://reviews.llvm.org/D50264. Reported by testbots:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/5592

Reviewers: morehouse, kevinwkt, metzman, javed.absar, Dor1s

Reviewed By: Dor1s

Subscribers: kristof.beyls, delcypher, #sanitizers, llvm-commits, kcc

Differential Revision: https://reviews.llvm.org/D50386

llvm-svn: 339143

6 years ago[InstSimplify] add tests for minnum/maxnum with shared op; NFC
Sanjay Patel [Tue, 7 Aug 2018 14:13:40 +0000 (14:13 +0000)]
[InstSimplify] add tests for minnum/maxnum with shared op; NFC

llvm-svn: 339142

6 years ago[InstSimplify] move misplaced minnum/maxnum tests; NFC
Sanjay Patel [Tue, 7 Aug 2018 14:12:08 +0000 (14:12 +0000)]
[InstSimplify] move misplaced minnum/maxnum tests; NFC

llvm-svn: 339141

6 years ago[SystemZ] Comment update.
Jonas Paulsson [Tue, 7 Aug 2018 13:48:09 +0000 (13:48 +0000)]
[SystemZ]  Comment update.

Update the comment in nextGroup since the ProcResourceCounters are not anymore
always decremented with '1'.

llvm-svn: 339140

6 years ago[SystemZ] NFC: Remove redundant check in SystemZHazardRecognizer.
Jonas Paulsson [Tue, 7 Aug 2018 13:44:11 +0000 (13:44 +0000)]
[SystemZ]  NFC: Remove redundant check in SystemZHazardRecognizer.

Remove the redundant check against zero when updating ProcResourceCounters in
nextGroup(), as pointed out in https://reviews.llvm.org/D50187.

Review: Ulrich Weigand.
llvm-svn: 339139

6 years ago[GVN,NewGVN] Move patchReplacementInstruction to Utils/Local.h
Florian Hahn [Tue, 7 Aug 2018 13:27:33 +0000 (13:27 +0000)]
[GVN,NewGVN] Move patchReplacementInstruction to Utils/Local.h

This function is shared between both implementations. I am not sure if
Utils/Local.h is the best place though.

Reviewers: davide, dberlin, efriedma, xbolva00

Reviewed By: efriedma, xbolva00

Differential Revision: https://reviews.llvm.org/D47337

llvm-svn: 339138

6 years ago[LLD][ELF] - Add test cases for ScriptParser::readDynamicList(). NFCI.
George Rimar [Tue, 7 Aug 2018 13:13:19 +0000 (13:13 +0000)]
[LLD][ELF] - Add test cases for ScriptParser::readDynamicList(). NFCI.

This 2 test cases covers the following code:
https://github.com/llvm-mirror/lld/blob/master/ELF/ScriptParser.cpp#L185
https://github.com/llvm-mirror/lld/blob/master/ELF/ScriptParser.cpp#L189

llvm-svn: 339137

6 years agoMove ScalarTest to follow the class being tested
Pavel Labath [Tue, 7 Aug 2018 13:10:16 +0000 (13:10 +0000)]
Move ScalarTest to follow the class being tested

This should have been a part of r339127, but I missed it somehow.

llvm-svn: 339136

6 years ago[analyzer][UninitializedObjectChecker] New flag to turn off dereferencing
Kristof Umann [Tue, 7 Aug 2018 12:55:26 +0000 (12:55 +0000)]
[analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Even for a checker being in alpha, some reports about pointees held so little
value to the user that it's safer to disable pointer/reference chasing for now.
It can be enabled with a new flag, in which case checker should function as it
has always been. This can be set with `CheckPointeeInitialization`.

Differential Revision: https://reviews.llvm.org/D49438

llvm-svn: 339135

6 years ago[AST][NFC] Use unsigned in the bit-fields of IdentifierInfo
Bruno Ricci [Tue, 7 Aug 2018 12:40:41 +0000 (12:40 +0000)]
[AST][NFC] Use unsigned in the bit-fields of IdentifierInfo

Avoid mixing bool and unsigned in the bit-fields of IdentifierInfo
since MSVC packs this poorly. Also clang-format the changes.

llvm-svn: 339134

6 years ago[AST][NFC] Use unsigned in the bit-fields of PrintingPolicy
Bruno Ricci [Tue, 7 Aug 2018 12:23:41 +0000 (12:23 +0000)]
[AST][NFC] Use unsigned in the bit-fields of PrintingPolicy

Avoid the mix between bools and unsigned since MSVC pack
this poorly.

llvm-svn: 339132

6 years agoFix a couple of extended-offsetof warnings that had slipped through
Pavel Labath [Tue, 7 Aug 2018 12:16:49 +0000 (12:16 +0000)]
Fix a couple of extended-offsetof warnings that had slipped through

llvm-svn: 339130

6 years agoFix inconsistency with/without debug information (-g)
Jonas Devlieghere [Tue, 7 Aug 2018 12:14:01 +0000 (12:14 +0000)]
Fix inconsistency with/without debug information (-g)

This fixes an inconsistency in code generation when compiling with or
without debug information (-g). When debug information is available in
an empty block, the original test would fail, resulting in possibly
different code.

Patch by: Jeroen Dobbelaere

Differential revision: https://reviews.llvm.org/D49467

llvm-svn: 339129

6 years ago[objc-gnustep] Don't emit .guess ivar offset vars.
David Chisnall [Tue, 7 Aug 2018 12:02:46 +0000 (12:02 +0000)]
[objc-gnustep] Don't emit .guess ivar offset vars.

These were intended to allow non-fragile and fragile ABI code to be
mixed, as long as the fragile classes were higher up the hierarchy than
the non-fragile ones.  Unfortunately:

 - No one actually wants to do this.
 - Recent versions of Linux's run-time linker break it.

llvm-svn: 339128

6 years agoMove RegisterValue,Scalar,State from Core to Utility
Pavel Labath [Tue, 7 Aug 2018 11:07:21 +0000 (11:07 +0000)]
Move RegisterValue,Scalar,State from Core to Utility

These three classes have no external dependencies, but they are used
from various low-level APIs. Moving them down to Utility improves
overall code layering (although it still does not break any particular
dependency completely).

The XCode project will need to be updated after this change.

Differential Revision: https://reviews.llvm.org/D49740

llvm-svn: 339127

6 years ago[mips] Handle branch expansion corner cases
Aleksandar Beserminji [Tue, 7 Aug 2018 10:45:45 +0000 (10:45 +0000)]
[mips] Handle branch expansion corner cases

When potential jump instruction and target are in the same segment, use
jump instruction with immediate field.

In cases where offset does not fit immediate value of a bc/j instructions,
offset is stored into register, and then jump register instruction is used.

Differential Revision: https://reviews.llvm.org/D48019

llvm-svn: 339126

6 years ago[Tablegen] In TargetSchedule.td: Remove unused argument `pfmCounters` from ProcResour...
Andrea Di Biagio [Tue, 7 Aug 2018 10:33:46 +0000 (10:33 +0000)]
[Tablegen] In TargetSchedule.td: Remove unused argument `pfmCounters` from ProcResourceUnits.

PFM counters don't need to be passed in input to the definition of
ProcResourceUnits. class PfmIssueCounter (see r329675) is used to map resources
to PFM counter(s).

Differential Revision: https://reviews.llvm.org/D50333

llvm-svn: 339125

6 years ago[LLD][ELF] - Added test case for non-nullterminated wide strings.
George Rimar [Tue, 7 Aug 2018 10:29:35 +0000 (10:29 +0000)]
[LLD][ELF] - Added test case for non-nullterminated wide strings.

This covers the following line:
https://github.com/llvm-mirror/lld/blob/master/ELF/InputSection.cpp#L1032

llvm-svn: 339124

6 years ago[clang-format] comment reflow: add last line's penalty when ending broken
Krasimir Georgiev [Tue, 7 Aug 2018 10:23:24 +0000 (10:23 +0000)]
[clang-format] comment reflow: add last line's penalty when ending broken

Summary:
This fixes a bug in clang-format where the last line's penalty is not
taken into account when its ending is broken. Usually the last line's penalty
is handled by addNextStateToQueue, but in cases where the trailing `*/` is put
on a newline, the contents of the last line have to be considered for penalizing.

Reviewers: mprobst

Reviewed By: mprobst

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D50378

llvm-svn: 339123

6 years ago[DebugInfo] Reduce debug_str_offsets section size
Pavel Labath [Tue, 7 Aug 2018 09:54:52 +0000 (09:54 +0000)]
[DebugInfo] Reduce debug_str_offsets section size

Summary:
The accelerator tables use the debug_str section to store their strings.
However, they do not support the indirect method of access that is
available for the debug_info section (DW_FORM_strx et al.).

Currently our code is assuming that all strings can/will be referenced
indirectly, and puts all of them into the debug_str_offsets section.
This is generally true for regular (unsplit) dwarf, but in the DWO case,
most of the strings in the debug_str section will only be used from the
accelerator tables. Therefore the contents of the debug_str_offsets
section will be largely unused and bloating the main executable.

This patch rectifies this by teaching the DwarfStringPool to
differentiate between strings accessed directly and indirectly. When a
user inserts a string into the pool it has to declare whether that
string will be referenced directly or not. If at least one user requsts
indirect access, that string will be assigned an index ID and put into
debug_str_offsets table. Otherwise, the offset table is skipped.

This approach reduces the overall binary size (when compiled with
-gdwarf-5 -gsplit-dwarf) in my tests by about 2% (debug_str_offsets is
shrunk by 99%).

Reviewers: probinson, dblaikie, JDevlieghere

Subscribers: aprantl, mgrang, llvm-commits

Differential Revision: https://reviews.llvm.org/D49493

llvm-svn: 339122

6 years ago[TargetLowering] Add support for non-uniform vectors to BuildUDIV
Simon Pilgrim [Tue, 7 Aug 2018 09:51:34 +0000 (09:51 +0000)]
[TargetLowering] Add support for non-uniform vectors to BuildUDIV

This patch refactors the existing TargetLowering::BuildUDIV base implementation to support non-uniform constant vector denominators.

It also includes a fold for MULHU by pow2 constants to SRL which can now more readily occur from BuildUDIV.

Differential Revision: https://reviews.llvm.org/D49248

llvm-svn: 339121

6 years ago[X86][SSE] Add more non-uniform exact sdiv vector tests covering all/none ashr paths
Simon Pilgrim [Tue, 7 Aug 2018 09:31:22 +0000 (09:31 +0000)]
[X86][SSE] Add more non-uniform exact sdiv vector tests covering all/none ashr paths

llvm-svn: 339120

6 years agovs integration: bump version number
Hans Wennborg [Tue, 7 Aug 2018 09:27:05 +0000 (09:27 +0000)]
vs integration: bump version number

llvm-svn: 339119

6 years agovs integration: update the publisher name
Hans Wennborg [Tue, 7 Aug 2018 09:15:16 +0000 (09:15 +0000)]
vs integration: update the publisher name

llvm-svn: 339118

6 years agovs integration: fix default path to clang-cl
Hans Wennborg [Tue, 7 Aug 2018 09:02:06 +0000 (09:02 +0000)]
vs integration: fix default path to clang-cl

Differential Revision: https://reviews.llvm.org/D50335

llvm-svn: 339117

6 years ago[clangd] Share getSymbolID implementation.
Haojian Wu [Tue, 7 Aug 2018 08:57:52 +0000 (08:57 +0000)]
[clangd] Share getSymbolID implementation.

Summary: And remove all duplicated implementation.

Reviewers: ioeric

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits

Differential Revision: https://reviews.llvm.org/D50375

llvm-svn: 339116

6 years ago[LLD][ELF] - Add a test case for code in Archive::fetch(). NFCI.
George Rimar [Tue, 7 Aug 2018 08:41:37 +0000 (08:41 +0000)]
[LLD][ELF] - Add a test case for code in Archive::fetch(). NFCI.

This covers the following piece with a test.
https://github.com/llvm-mirror/lld/blob/master/ELF/InputFiles.cpp#L830

Thanks to Peter Collingbourne for providing the reproducer sample!

llvm-svn: 339114

6 years ago[yaml2obj] - Add a support for changing EntSize.
George Rimar [Tue, 7 Aug 2018 08:11:38 +0000 (08:11 +0000)]
[yaml2obj] - Add a support for changing EntSize.

I was trying to add a test case for LLD and found that it
is impossible to set sh_entsize via yaml.
The patch implements the missing part.

Differential revision: https://reviews.llvm.org/D50235

llvm-svn: 339113

6 years agoFix clash of gcc toolchains in driver regression tests
Karl-Johan Karlsson [Tue, 7 Aug 2018 08:10:33 +0000 (08:10 +0000)]
Fix clash of gcc toolchains in driver regression tests

For some regression tests the path to the right toolchain is specified
using the -sysroot switch. However, if clang was configured with a
custom gcc toolchain (either by using GCC_INSTALL_PREFIX in cmake or the
equivalent configure command), the path to the custom gcc toolchain path
takes precedence to the one specified by sysroot. This causes several
regression tests to fail as they will be using an unexpected path. This
patch fixes this issue by adding --gcc-toolchain='' to all tests that
rely on that. The empty string causes the driver to pick the path from
sysroot instead.

This patch contain the same kind of fixes as done in rC225182

llvm-svn: 339112

6 years ago[ARM][NFC] Replaced tab characters in test file vfcmp.ll.
Sjoerd Meijer [Tue, 7 Aug 2018 08:05:15 +0000 (08:05 +0000)]
[ARM][NFC] Replaced tab characters in test file vfcmp.ll.

llvm-svn: 339111

6 years agoAMDGPU: Add builtin for s_dcache_wb
Matt Arsenault [Tue, 7 Aug 2018 07:49:13 +0000 (07:49 +0000)]
AMDGPU: Add builtin for s_dcache_wb

llvm-svn: 339110

6 years agoAMDGPU: Add builtin for s_dcache_inv_vol
Matt Arsenault [Tue, 7 Aug 2018 07:49:04 +0000 (07:49 +0000)]
AMDGPU: Add builtin for s_dcache_inv_vol

llvm-svn: 339109

6 years agoAMDGPU: Add feature vi-insts
Matt Arsenault [Tue, 7 Aug 2018 07:28:46 +0000 (07:28 +0000)]
AMDGPU: Add feature vi-insts

This is necessary to add a VI specific builtin,
__builtin_amdgcn_s_dcache_wb. We already have an
overly specific feature for one of these builtins,
for s_memrealtime. I'm not sure whether it's better
to add more of those, or to get rid of that and merge
it with vi-insts.

Alternatively, maybe this logically goes with scalar-stores?

llvm-svn: 339104