profile/ivi/webkit-efl.git
13 years ago2011-05-29 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 29 May 2011 21:56:53 +0000 (21:56 +0000)]
2011-05-29  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Some heap refactoring
        https://bugs.webkit.org/show_bug.cgi?id=61704

        SunSpider says no change.

        * JavaScriptCore.exp: Export!

        * heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.

        (JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.

        (JSC::Heap::allocate): Changed inline allocation code to only select the
        size class, since this can be optimized out at compile time -- everything
        else is now inlined into this out-of-line function.

        No need to duplicate ASSERTs made in our caller.

        * heap/Heap.h:
        (JSC::Heap::heap):
        (JSC::Heap::isMarked):
        (JSC::Heap::testAndSetMarked):
        (JSC::Heap::testAndClearMarked):
        (JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding
        a layer of indirection through MarkedSpace.

        (JSC::Heap::allocate): See above.

        * heap/MarkedBlock.cpp:
        (JSC::MarkedBlock::create):
        (JSC::MarkedBlock::MarkedBlock):
        * heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.

        * heap/MarkedSpace.cpp:
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::allocateBlock):
        * heap/MarkedSpace.h:
        (JSC::MarkedSpace::allocate): Updated to match changes above.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sun, 29 May 2011 21:28:24 +0000 (21:28 +0000)]
2011-05-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION (r86924): webkitRequestFullScreen does not work properly (black screen, can’t interact)
        https://bugs.webkit.org/show_bug.cgi?id=61710

        When taking the documentElement full screen, we don't create a RenderFullScreen
        object and thus never enter accelerated compositing mode for the animation. Tell
        the WKFullScreenWindowController to enter accelerated compositing mode anyway
        (with an empty layer context) so as to fulfill its expectations and cause the
        full screen animation to complete.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added a
            comment explaining when we expect the animation to complete.
        (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):
            Remove an ASSERT which is no longer valid.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Tell the UIProcess
            to enter then exit full-screen mode.
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 29 May 2011 20:45:10 +0000 (20:45 +0000)]
2011-05-29  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Element: Micro-cleanup of scroll methods.
        https://bugs.webkit.org/show_bug.cgi?id=61705

        Do an early return without calculating element boundaries when asked
        to scroll an element without a renderer().

        * dom/Element.cpp:
        (WebCore::Element::scrollIntoView):
        (WebCore::Element::scrollIntoViewIfNeeded):
        (WebCore::Element::scrollByUnits):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 May 2011 20:12:27 +0000 (20:12 +0000)]
2011-05-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Race condition in full screen controller, which leads to problem when web process crashes
        https://bugs.webkit.org/show_bug.cgi?id=61707

        Saw this while debugging a crash. We don't have a way to make regression tests for this
        kind of issue at this time.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Retain the controller
        here since we are keeping a pointer to it.
        (exitCompositedModeRepaintCompleted): Release the controller here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 May 2011 20:12:01 +0000 (20:12 +0000)]
2011-05-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Fix assertion seen when entering full screen mode for standalone video
        https://bugs.webkit.org/show_bug.cgi?id=61708

        We don't currently have a way to make a regression test for this.

        * dom/Document.cpp:
        (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc,
        because scheduleStyleRecalc is intended to only be called when the style
        system itself detects recalc is needed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 29 May 2011 20:06:10 +0000 (20:06 +0000)]
2011-05-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (87637): Entering WebKit Full Screen mode causes an assertion in DrawingAreaImpl::layerHostDidFlushLayers
        https://bugs.webkit.org/show_bug.cgi?id=61706
        <rdar://problem/9521970>

        If we've already let the UI process know that we're in compositing mode, we just need to force a repaint.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::forceRepaint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 29 May 2011 19:38:46 +0000 (19:38 +0000)]
2011-05-29  Daniel Bates  <dbates@rim.com>

        Reviewed by David Kilzer.

        REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
        https://bugs.webkit.org/show_bug.cgi?id=61162

        Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
        that omits a line count. In particular, the chunk range regular expression does
        not match a chunk range line that omits a line count. GNU diff(1) will omit the
        line count in the chunk range if the line count is exactly 1. For example, appending
        a new line to the end of an existing file F that contains exactly one line of text will
        be represented in a diff with a chunk range line that omits the line count for F.

        * Scripts/VCSUtils.pm:
          (parseChunkRange): Added.
        * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
          - Added unit test "Git: Append new line to the end of an existing file".

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 29 May 2011 19:13:46 +0000 (19:13 +0000)]
2011-05-27  Andreas Kling  <kling@webkit.org>

        Reviewed by James Robinson.

        [Qt] Add area check to ImageBufferData::getImageData()
        https://bugs.webkit.org/show_bug.cgi?id=61375

        No change in behavior, just a sanity check.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agohttps://bugs.webkit.org/show_bug.cgi?id=61700
darin@apple.com [Sun, 29 May 2011 19:00:11 +0000 (19:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

Patch by Beth Dakin <bdakin@apple.com> on 2011-05-29
Reviewed by Darin Adler.

New member variable on RenderArena keeps track of the current amount of memory
allocated in the arena. The new client function sends this piece of data to
WebKit.
* page/ChromeClient.h:
(WebCore::ChromeClient::setRenderTreeSize):
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
* rendering/RenderArena.cpp:
(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):
* rendering/RenderArena.h:
(WebCore::RenderArena::totalRenderArenaSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Beth Dakin <bdakin@apple.com>
darin@apple.com [Sun, 29 May 2011 18:13:14 +0000 (18:13 +0000)]
2011-05-29  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=61700
        Need WebKit2 API to get the size of the render tree
        -and corresponding-
        <rdar://problem/9512733>

        * UIProcess/API/C/WKPage.cpp:
        (WKPageGetRenderTreeSize):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::renderTreeSize):
        (WebKit::WebPageProxy::setRenderTreeSize):
        * UIProcess/WebPageProxy.messages.in:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::setRenderTreeSize):
        * WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/9519453>
darin@apple.com [Sun, 29 May 2011 18:03:30 +0000 (18:03 +0000)]
<rdar://problem/9519453>
When calling ForceRepaint on a page with accelerated compositing, we can get
a race condition where the UI process paints the old content, resulting in showing
the previous page. That happens because forceRepaint's callback waits for the next
repaint to happen, but nothing notifies UI process that the page is in accelerated
compositing mode.

Reviewed by Anders Carlsson and Simon Fraser.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint): Call layerHostDidFlushLayers instead of
just calling forceRepaint on the layer tree host.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Sun, 29 May 2011 09:49:03 +0000 (09:49 +0000)]
2011-05-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Data directory is webkitgtk-x.y not webkit-x.y
        https://bugs.webkit.org/show_bug.cgi?id=61642

        * GNUmakefile.am: updated data directory.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 29 May 2011 08:30:35 +0000 (08:30 +0000)]
2011-05-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87566.
        http://trac.webkit.org/changeset/87566
        https://bugs.webkit.org/show_bug.cgi?id=61702

        It made all tests assert on Qt in debug mode (Requested by
        Ossy_weekend on #webkit).

        * WebCore.exp.in:
        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::suggestedMIMEType):
        (WebCore::Document::lastModified):
        (WebCore::Document::initSecurityContext):
        (WebCore::Document::updateURLForPushOrReplaceState):
        * dom/Document.h:
        (WebCore::Document::setDocumentLoader):
        (WebCore::Document::loader):
        * html/MediaDocument.cpp:
        (WebCore::MediaDocument::replaceMediaElementTimerFired):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::createDocumentStructure):
        * platform/mac/HTMLConverter.mm:
        (fileWrapperForElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Sun, 29 May 2011 07:04:13 +0000 (07:04 +0000)]
2011-05-28  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Dan Bernstein.

        Don't add sub-frames to global history when navigating via back/forward
        https://bugs.webkit.org/show_bug.cgi?id=61701
        <rdar://problem/9521222>

        Instead of just checking whether the load is the first in the frame, we also need to
        check to make sure we're loading in the main frame.

        Not testable due to lack of global history infrastructure in DRT.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::transitionToCommitted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Suggested by Simon Fraser.
ap@apple.com [Sun, 29 May 2011 04:42:18 +0000 (04:42 +0000)]
    Suggested by Simon Fraser.

        REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
        https://bugs.webkit.org/show_bug.cgi?id=61692
        <rdar://problem/9488628>

        * loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use
        ASSERT_UNUSED here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@apple.com [Sun, 29 May 2011 01:37:59 +0000 (01:37 +0000)]
    Reviewed by Geoff Garen.

        REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
        https://bugs.webkit.org/show_bug.cgi?id=61692
        <rdar://problem/9488628>

        Test: fast/dom/gc-image-element-2.html

        Manually verified that tests from bug 59604 and from bug 40926 still pass.

        The problem here was that HTMLImageElement::hasPendingActivity() could return false when
        a load (or error) event was still expected to fire.

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::setRequest):
        * loader/cache/CachedResource.h:
        (WebCore::CachedResource::wasCanceled):
        (WebCore::CachedResource::errorOccurred):
        Track whether the load was canceled. We want to always notify clients of load outcome,
        as that's the only way they could make intelligent decisions.

        * dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now
        get a notifyFinished call on cancellation. Handle this case, where we don't need the
        execute the script, but also don't need to fire an error event.

        * html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single
        function call now.

        * html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large
        window between when CachedResource::isLoading() becomes false and events are queued.
        ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting
        an event to fire.

        * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do
        anything on cancellation.

        * loader/ImageLoader.cpp:
        (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to
        give an accurate result while looping over the list of events to dispatch.
        (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to
        switch to a broken image icon, or to dispatch events.
        (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching
        list, as the event is no longer pending when it's being dispatched.

        * loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one
        is already pending, we only care if one is expected at some time in the future, and
        !haveFiredLoadEvent() is our best idea of that.

        * dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to
        handle cancellation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 28 May 2011 23:45:17 +0000 (23:45 +0000)]
2011-05-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Maciej Stachowiak.

        Denying access to your keychain on login crashes WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=61695
        <rdar://problem/9520570>

        Fix two sources of crashes if you hit the Deny button when WebKit2 is
        doing HTTP authentication.

        First, SecKeychainItemRequestData::attributeList() failed to initialize the
        length and data members of SecKeychainAttributes in the list if there was no data.
        This caused invalid memory reads later.

        Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
        would cause a later crash in a system framework, which is not set up to handle
        errors. Instead, we always return noErr, and allow the authentication to fail.

        Finally, paranoically initialize the SecKeychainItemContext in two places
        to avoid uninitialized data members, and initialize length and outData
        to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
        fails to set them on error.

        * Shared/mac/SecKeychainItemRequestData.cpp:
        (WebKit::SecKeychainItemRequestData::attributeList):
        * UIProcess/mac/WebProcessProxyMac.mm:
        (WebKit::WebProcessProxy::secKeychainItemCopyContent):
        * WebProcess/mac/KeychainItemShimMethods.mm:
        (WebKit::webSecKeychainItemCopyContent):
        (WebKit::webSecKeychainItemCreateFromContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 May 2011 22:26:15 +0000 (22:26 +0000)]
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        EWS builds patches that fail to build twice, which seems useless and slows down the bots
        https://bugs.webkit.org/show_bug.cgi?id=55585

        This patch switches all the early warning system bots over to the new
        PatchAnalysisTask-based infrastructure.  This patch makes these bots
        more efficient (in the case where patches fail to build) and paves the
        way for running tests on these bots!

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 28 May 2011 21:45:43 +0000 (21:45 +0000)]
2011-05-28  Martin Robinson  <mrobinson@igalia.com>

        Skip a failing test and better classify some existing skipped tests.

        * platform/gtk/Skipped: Update the skipped list.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 28 May 2011 20:39:23 +0000 (20:39 +0000)]
2011-05-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r86578): Flash content missing from mercurynews.com
        https://bugs.webkit.org/show_bug.cgi?id=61691
        <rdar://problem/9519893>

        If the plug-in doesn't have access to the toplevel URL, make sure to
        return *something* to the plug-in.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 May 2011 19:59:16 +0000 (19:59 +0000)]
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::updateGlobalHistory):
        (WebCore::FrameLoaderClientQt::cancelledError):
        (WebCore::FrameLoaderClientQt::blockedError):
        (WebCore::FrameLoaderClientQt::objectContentType):
        (WebCore::FrameLoaderClientQt::createPlugin):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
        (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
        (WebCore::FrameLoaderClientEfl::download):
        (WebCore::FrameLoaderClientEfl::cancelledError):
        (WebCore::FrameLoaderClientEfl::blockedError):
        * ewk/ewk_frame.cpp:
        (ewk_frame_hit_test_new):
        (ewk_frame_uri_changed):
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (ewk_view_frame_create):
        (ewk_view_plugin_create):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        As far as I can tell, all the callers of this API are confused.  There
        seems to be a cargo cult of using the "pretty" version of a URL, but in
        reality folks just want the URL itself.  The only case I'm unsure about
        is location.href, which could have some compatibility constraints.
        I've renamed prettyURL to deprecatedString to discourage folks from
        further cargo-culting.

        * WebCore.exp.in:
        * page/Location.cpp:
        (WebCore::Location::href):
        (WebCore::Location::toString):
        * platform/KURL.cpp:
        (WebCore::KURL::deprecatedString):
        * platform/KURL.h:
        * platform/KURLGoogle.cpp:
        (WebCore::KURL::deprecatedString):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::prepareForURL):
        * workers/WorkerLocation.cpp:
        (WebCore::WorkerLocation::href):
        (WebCore::WorkerLocation::toString):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createPlugin):
        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
        (WebKit::cancelledError):
        (WebKit::blockedError):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 28 May 2011 19:41:14 +0000 (19:41 +0000)]
2011-05-28  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Mouse clicks propagate outside full-screen media controls.
        https://bugs.webkit.org/show_bug.cgi?id=61689

        Mouse click events are propagating out of the media controls, so mouse click
        listeners registered on the video element are getting fired when the user
        clicks on media controller buttons.  By default, block propagation of click
        events from MediaControlElements by overriding preDispatchEventHandler, and
        convert all instances of defaultEventHandler -> preDispatchEventHandler.  Change
        all calls of event->setDefaultHandled() to event->stopPropagation().

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlElement::preDispatchEventHandler): Added.  Block
            propagation of all mouse click events.
        (WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):
            Renamed from setDefaultHandled.
        (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
        * html/shadow/MediaControlElements.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Gavin Peters <gavinp@chromium.org>
commit-queue@webkit.org [Sat, 28 May 2011 18:18:49 +0000 (18:18 +0000)]
2011-05-28  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-28  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Sat, 28 May 2011 17:55:16 +0000 (17:55 +0000)]
2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: there is a problem with computed style properties with wrong values
        https://bugs.webkit.org/show_bug.cgi?id=60535

        Adding cases that test invalid properties.

        * inspector/styles/styles-computed-trace-expected.txt:
        * inspector/styles/styles-computed-trace.html:
2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: there is a problem with computed style properties with wrong values
        https://bugs.webkit.org/show_bug.cgi?id=60535

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
        (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-26 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Sat, 28 May 2011 17:02:18 +0000 (17:02 +0000)]
2011-05-26  Antonio Gomes  <agomes@rim.com>

        Reviewed by Andreas Kling.

        Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial      lyAligned
        https://bugs.webkit.org/show_bug.cgi?id=61606

        Removed duplicated statement within if condition.

        No new tests. Obvious clean up patch.

        * page/SpatialNavigation.cpp:
        (WebCore::areRectsPartiallyAligned):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Unreviewed, clean up GPU tests expectations
mnaganov@chromium.org [Sat, 28 May 2011 16:16:12 +0000 (16:16 +0000)]
[Chromium] Unreviewed, clean up GPU tests expectations

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBUILD FIX when building only the interpreter
ddkilzer@apple.com [Sat, 28 May 2011 15:43:38 +0000 (15:43 +0000)]
BUILD FIX when building only the interpreter

Fixes the following compiler warning:

    JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]
     void releaseExecutableMemory(JSGlobalData& globalData)
          ^

* jit/ExecutableAllocator.h: Moved declaration of
JSC::releaseExecutableMemory().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing...
mnaganov@chromium.org [Sat, 28 May 2011 15:27:31 +0000 (15:27 +0000)]
[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)
ddkilzer@apple.com [Sat, 28 May 2011 15:24:46 +0000 (15:24 +0000)]
BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode): Added missing argument.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 28 May 2011 12:15:26 +0000 (12:15 +0000)]
2011-05-28  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
        https://bugs.webkit.org/show_bug.cgi?id=60311

        If there is no editable text Qt interprets backspace as a navigation
        command, regardless of platform.

        * platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashin...
mnaganov@chromium.org [Sat, 28 May 2011 12:06:36 +0000 (12:06 +0000)]
[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashin...
mnaganov@chromium.org [Sat, 28 May 2011 10:32:45 +0000 (10:32 +0000)]
[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Sat, 28 May 2011 08:50:44 +0000 (08:50 +0000)]
2011-05-28  Mikhail Naganov  <mnaganov@chromium.org>

        [Chromium] Unreviewed. Test expectations update after r87605

        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Kenichi Ishibashi <bashi@chromium.org>
bashi@chromium.org [Sat, 28 May 2011 08:27:43 +0000 (08:27 +0000)]
2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        Add bashi as a committer.

        https://bugs.webkit.org/show_bug.cgi?id=61685

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-28 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Sat, 28 May 2011 07:17:58 +0000 (07:17 +0000)]
2011-05-28  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        editing/style/non-inheritable-styles should be dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=61681

        Converts the test to dump-as-markup and cleans up the HTML a bit.

        * editing/style/non-inheritable-styles-expected.txt: Added.
        * editing/style/non-inheritable-styles.html:
        * platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
        * platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
        * platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
        * platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 28 May 2011 06:52:04 +0000 (06:52 +0000)]
2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed, this just adds a new test.

        WebKit fails WICD SVG background image tests
        https://bugs.webkit.org/show_bug.cgi?id=16481

        Add two WICD SVG background image tests, which pass just fine.

        * svg/wicd/resources/test-scalable-background-image1.css: Added.
        (html):
        (body):
        (p):
        * svg/wicd/resources/test-scalable-background-image1.svg: Added.
        * svg/wicd/resources/test-scalable-background-image2.css: Added.
        (html):
        * svg/wicd/resources/test-scalable-background-image2.svg: Added.
        * svg/wicd/test-scalable-background-image1.xhtml: Added.
        * svg/wicd/test-scalable-background-image2.xhtml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Sat, 28 May 2011 06:19:39 +0000 (06:19 +0000)]
2011-05-27  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        editing/inserting/insert-3907422 should be dumpAsText test
        https://bugs.webkit.org/show_bug.cgi?id=61680

        Converted to dumpAsMarkup and cleaned up markup.

        * editing/inserting/insert-3907422-fix-expected.txt: Added.
        * editing/inserting/insert-3907422-fix.html:
        * platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
        * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Removed.
        * platform/mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/mac/editing/inserting/insert-3907422-fix-expected.txt: Removed.
        * platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 May 2011 04:48:28 +0000 (04:48 +0000)]
2011-05-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        When checking whether the tree is red, the EWS posts a link to the wrong log
        https://bugs.webkit.org/show_bug.cgi?id=61072

        We need to cache the original script error because that contains the
        failure log we want to upload.  If we don't cache that script error,
        self._script_error will get overwritten when we sanity check the clean
        tree (and it also has test failures).

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
            - This testing approach is slightly goofy.  We'd like to use
              assertRaisesRegexp, but that's not available until Python 2.7.
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRoll out r87544 since it is bogus.
mrowe@apple.com [Sat, 28 May 2011 04:39:34 +0000 (04:39 +0000)]
Roll out r87544 since it is bogus.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 28 May 2011 04:18:44 +0000 (04:18 +0000)]
2011-05-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CG BitmapImage needs to check for valid CGImage in a couple of places
        https://bugs.webkit.org/show_bug.cgi?id=61684
        <rdar://problem/9519348>

        BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
        returns null, which it may do if the image is corrupted or still
        loading. Protect against that here and in getFirstCGImageRefOfSize().

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::getFirstCGImageRefOfSize):
        (WebCore::BitmapImage::getCGImageArray):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Sat, 28 May 2011 03:27:16 +0000 (03:27 +0000)]
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Check access policy on all storage operations
        https://bugs.webkit.org/show_bug.cgi?id=61581

        * platform/chromium/permissionclient/storage-permission-expected.txt: Added.
        * platform/chromium/permissionclient/storage-permission.html: Added.
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Add Frame parameter to all StorageArea methods. The chromium
        embedder uses the Frame as context to decide whether or not
        to allow usage of the storage API.
        https://bugs.webkit.org/show_bug.cgi?id=61581

        Test: platform/chromium/permissionclient/storage-permission.html

        * storage/Storage.cpp:
        (WebCore::Storage::length):
        (WebCore::Storage::key):
        (WebCore::Storage::getItem):
        (WebCore::Storage::contains):
        * storage/StorageArea.h:
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::length):
        (WebCore::StorageAreaImpl::key):
        (WebCore::StorageAreaImpl::getItem):
        (WebCore::StorageAreaImpl::contains):
        * storage/StorageAreaImpl.h:
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Check access policy on all storage operations
        https://bugs.webkit.org/show_bug.cgi?id=61581

        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::length):
        (WebCore::StorageAreaProxy::key):
        (WebCore::StorageAreaProxy::getItem):
        (WebCore::StorageAreaProxy::setItem):
        (WebCore::StorageAreaProxy::removeItem):
        (WebCore::StorageAreaProxy::clear):
        (WebCore::StorageAreaProxy::contains):
        (WebCore::StorageAreaProxy::canAccessStorage):
        * src/StorageAreaProxy.h:
        * src/WebStorageAreaImpl.cpp:
        (WebKit::WebStorageAreaImpl::length):
        (WebKit::WebStorageAreaImpl::key):
        (WebKit::WebStorageAreaImpl::getItem):
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Add layoutTestController.setStorageAllowed() to control whether access
        to the localStorage API is enabled via the WebPermissionClient
        https://bugs.webkit.org/show_bug.cgi?id=61581

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setStorageAllowed):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::createNewWindow):
        * DumpRenderTree/chromium/TestShell.h:
        * DumpRenderTree/chromium/WebPermissions.h: Added.
        (WebPermissions::WebPermissions):
        (WebPermissions::allowStorage):
        (WebPermissions::setStorageAllowed):
        (WebPermissions::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 02:28:00 +0000 (02:28 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
        https://bugs.webkit.org/show_bug.cgi?id=60326

        This patch removes a lot of the complexity from the
        metered_stream implementation that was unnecessary since there
        was only one caller and the logic could be coordinated better.

        There should be no functional changes in this patch, just code
        getting deleted and cleaned up.

        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Sat, 28 May 2011 02:24:20 +0000 (02:24 +0000)]
2011-05-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Jian Li.

        Keep a reference to BlobResourceHandle before calling doNotifyFinish()
        asynchronously to ensure it's still safe in the main thread.

        https://bugs.webkit.org/show_bug.cgi?id=61669

        I triggered this crash in fast/files/file-reader-abort.html during a
        refactor that changed timings slightly.

        * platform/network/BlobResourceHandle.cpp:
        (WebCore::doNotifyFinish):
        (WebCore::BlobResourceHandle::notifyFinish):
        * platform/network/BlobResourceHandle.h:
        (WebCore::BlobResourceHandle::aborted):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 02:16:16 +0000 (02:16 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        NRWT: minor cleanup in printing module
        https://bugs.webkit.org/show_bug.cgi?id=60329

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 02:11:00 +0000 (02:11 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        NRWT: remove --print detailed-progress
        https://bugs.webkit.org/show_bug.cgi?id=60324

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Steve Lacey <sjl@chromium.org>
sjl@chromium.org [Sat, 28 May 2011 02:00:13 +0000 (02:00 +0000)]
2011-05-27  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Add sjl@chromium.org as a committer.

        https://bugs.webkit.org/show_bug.cgi?id=61672

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 01:56:23 +0000 (01:56 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        NRWT: debug messages from the workers are being logged twice
        https://bugs.webkit.org/show_bug.cgi?id=60428

        It looks like when the workers are run in separate processes
        we end up getting two copies of every log message they print.
        This has to do with the multiprocessing module on UNIX cloning
        the log configuration in a way I wasn't expecting, and so two
        log handlers end up getting registered.

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Sat, 28 May 2011 01:24:21 +0000 (01:24 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. Hopefully last rebaseline from r87526.

        * platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed test expectations update: Vista flakiness.
adamk@chromium.org [Sat, 28 May 2011 00:30:18 +0000 (00:30 +0000)]
Unreviewed test expectations update: Vista flakiness.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 28 May 2011 00:28:56 +0000 (00:28 +0000)]
2011-05-27  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        JS API is too aggressive about throwing exceptions for NULL get or set operations
        https://bugs.webkit.org/show_bug.cgi?id=61678

        * API/JSCallbackObject.h: Changed our staticValueGetter to a regular
        function that returns a JSValue, so it can fail and still forward to
        normal property lookup.

        * API/JSCallbackObjectFunctions.h:
        (JSC::::getOwnPropertySlot): Don't throw an exception when failing to
        access a static property -- just forward the access. This allows objects
        to observe get/set operations but still let the JS object manage lifetime.

        (JSC::::put): Ditto.

        (JSC::::getStaticValue): Same as JSCallbackObject.h.

        * API/tests/testapi.c:
        (MyObject_set_nullGetForwardSet):
        * API/tests/testapi.js: Updated tests to reflect slightly less strict
        behavior, which matches headerdoc claims.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Sat, 28 May 2011 00:26:19 +0000 (00:26 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. Even more rebaselines after r87526.

        * platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
        * platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 27 May 2011 23:53:36 +0000 (23:53 +0000)]
2011-05-27  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Property caching is too aggressive for API objects
        https://bugs.webkit.org/show_bug.cgi?id=61677

        * API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our
        callback APIs allow the client to change its mind about our propertis at
        any time.

        * API/tests/testapi.c:
        (PropertyCatchalls_getProperty):
        (PropertyCatchalls_setProperty):
        (PropertyCatchalls_getPropertyNames):
        (PropertyCatchalls_class):
        (main):
        * API/tests/testapi.js: Some tests for dynamic API objects.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::tryCachePutByID):
        (JSC::Interpreter::tryCacheGetByID):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCachePutByID):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client
        requires it.

        * runtime/JSTypeInfo.h:
        (JSC::TypeInfo::TypeInfo):
        (JSC::TypeInfo::isFinal):
        (JSC::TypeInfo::prohibitsPropertyCaching):
        (JSC::TypeInfo::flags): Added a flag to track opting out of property
        caching. Fixed an "&&" vs "&" typo that was previously harmless, but
        is now harmful since m_flags2 can have more than one bit set.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed test expectations update: widen flakiness to include Linux.
adamk@chromium.org [Fri, 27 May 2011 23:21:33 +0000 (23:21 +0000)]
Unreviewed test expectations update: widen flakiness to include Linux.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Steve Lacey <sjl@chromium.org>
sjl@chromium.org [Fri, 27 May 2011 23:18:07 +0000 (23:18 +0000)]
2011-05-27  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        The behaviour of controls-after-reload was causing
        layoutTestController in DumpRenderTree to misbehave causing a reported
        failure in the test run after it (controls-css-overload).

        Effectively, notifyDone() ended up getting called again after the test
        was being torn down.

        This change removes the unneeded seek at the end of the test (as we
        should have already seeked to 0.

        https://bugs.webkit.org/show_bug.cgi?id=60132

        * media/controls-after-reload.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
slewis@apple.com [Fri, 27 May 2011 22:57:53 +0000 (22:57 +0000)]
Unreviewed.

Fix a typo in the order_file flag.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Fri, 27 May 2011 22:32:01 +0000 (22:32 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. More rebaselines after r87526.

        * platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
        * platform/chromium-linux/svg/in-html/by-reference-expected.txt:
        * platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
        * platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 May 2011 22:14:13 +0000 (22:14 +0000)]
2011-05-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Always use the default localization strategy
        https://bugs.webkit.org/show_bug.cgi?id=61670
        <rdar://problem/9516130>

        Always use the default localization strategy when there's no platform strategy.

        * platform/DefaultLocalizationStrategy.cpp:
        (WebCore::DefaultLocalizationStrategy::shared):
        * platform/DefaultLocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        (WebCore::inputElementAltText):
        (WebCore::resetButtonDefaultLabel):
        (WebCore::searchableIndexIntroduction):
        (WebCore::submitButtonDefaultLabel):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (WebCore::defaultDetailsSummaryText):
        (WebCore::copyImageUnknownFileLabel):
        (WebCore::contextMenuItemTagOpenLinkInNewWindow):
        (WebCore::contextMenuItemTagDownloadLinkToDisk):
        (WebCore::contextMenuItemTagCopyLinkToClipboard):
        (WebCore::contextMenuItemTagOpenImageInNewWindow):
        (WebCore::contextMenuItemTagDownloadImageToDisk):
        (WebCore::contextMenuItemTagCopyImageToClipboard):
        (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
        (WebCore::contextMenuItemTagOpenFrameInNewWindow):
        (WebCore::contextMenuItemTagCopy):
        (WebCore::contextMenuItemTagGoBack):
        (WebCore::contextMenuItemTagGoForward):
        (WebCore::contextMenuItemTagStop):
        (WebCore::contextMenuItemTagReload):
        (WebCore::contextMenuItemTagCut):
        (WebCore::contextMenuItemTagPaste):
        (WebCore::contextMenuItemTagSelectAll):
        (WebCore::contextMenuItemTagNoGuessesFound):
        (WebCore::contextMenuItemTagIgnoreSpelling):
        (WebCore::contextMenuItemTagLearnSpelling):
        (WebCore::contextMenuItemTagSearchInSpotlight):
        (WebCore::contextMenuItemTagSearchWeb):
        (WebCore::contextMenuItemTagLookUpInDictionary):
        (WebCore::contextMenuItemTagOpenLink):
        (WebCore::contextMenuItemTagIgnoreGrammar):
        (WebCore::contextMenuItemTagSpellingMenu):
        (WebCore::contextMenuItemTagShowSpellingPanel):
        (WebCore::contextMenuItemTagCheckSpelling):
        (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
        (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
        (WebCore::contextMenuItemTagFontMenu):
        (WebCore::contextMenuItemTagShowFonts):
        (WebCore::contextMenuItemTagBold):
        (WebCore::contextMenuItemTagItalic):
        (WebCore::contextMenuItemTagUnderline):
        (WebCore::contextMenuItemTagOutline):
        (WebCore::contextMenuItemTagStyles):
        (WebCore::contextMenuItemTagShowColors):
        (WebCore::contextMenuItemTagSpeechMenu):
        (WebCore::contextMenuItemTagStartSpeaking):
        (WebCore::contextMenuItemTagStopSpeaking):
        (WebCore::contextMenuItemTagWritingDirectionMenu):
        (WebCore::contextMenuItemTagTextDirectionMenu):
        (WebCore::contextMenuItemTagDefaultDirection):
        (WebCore::contextMenuItemTagLeftToRight):
        (WebCore::contextMenuItemTagRightToLeft):
        (WebCore::contextMenuItemTagCorrectSpellingAutomatically):
        (WebCore::contextMenuItemTagSubstitutionsMenu):
        (WebCore::contextMenuItemTagShowSubstitutions):
        (WebCore::contextMenuItemTagSmartCopyPaste):
        (WebCore::contextMenuItemTagSmartQuotes):
        (WebCore::contextMenuItemTagSmartDashes):
        (WebCore::contextMenuItemTagSmartLinks):
        (WebCore::contextMenuItemTagTextReplacement):
        (WebCore::contextMenuItemTagTransformationsMenu):
        (WebCore::contextMenuItemTagMakeUpperCase):
        (WebCore::contextMenuItemTagMakeLowerCase):
        (WebCore::contextMenuItemTagCapitalize):
        (WebCore::contextMenuItemTagChangeBack):
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagInspectElement):
        (WebCore::searchMenuNoRecentSearchesText):
        (WebCore::searchMenuRecentSearchesText):
        (WebCore::searchMenuClearRecentSearchesText):
        (WebCore::AXWebAreaText):
        (WebCore::AXLinkText):
        (WebCore::AXListMarkerText):
        (WebCore::AXImageMapText):
        (WebCore::AXHeadingText):
        (WebCore::AXDefinitionListTermText):
        (WebCore::AXDefinitionListDefinitionText):
        (WebCore::AXARIAContentGroupText):
        (WebCore::AXButtonActionVerb):
        (WebCore::AXRadioButtonActionVerb):
        (WebCore::AXTextFieldActionVerb):
        (WebCore::AXCheckedCheckBoxActionVerb):
        (WebCore::AXUncheckedCheckBoxActionVerb):
        (WebCore::AXLinkActionVerb):
        (WebCore::AXMenuListPopupActionVerb):
        (WebCore::AXMenuListActionVerb):
        (WebCore::missingPluginText):
        (WebCore::crashedPluginText):
        (WebCore::multipleFileUploadText):
        (WebCore::unknownFileSizeText):
        (WebCore::uploadFileText):
        (WebCore::allFilesText):
        (WebCore::keygenMenuItem512):
        (WebCore::keygenMenuItem1024):
        (WebCore::keygenMenuItem2048):
        (WebCore::keygenKeychainItemName):
        (WebCore::imageTitle):
        (WebCore::mediaElementLoadingStateText):
        (WebCore::mediaElementLiveBroadcastStateText):
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):
        (WebCore::validationMessageValueMissingText):
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        (WebCore::validationMessageTypeMismatchText):
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessagePatternMismatchText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Unreviewed test expectations update.
adamk@chromium.org [Fri, 27 May 2011 21:36:05 +0000 (21:36 +0000)]
[Chromium] Unreviewed test expectations update.

Flip svg/html/by-reference.html to its new failed state after r87526.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFirst swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bu...
beidson@apple.com [Fri, 27 May 2011 21:15:46 +0000 (21:15 +0000)]
First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Make the Document be intelligent about returning its DocumentLoader, including the possibility that
the DocumentLoader will be null.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):
* dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* platform/mac/HTMLConverter.mm:
(fileWrapperForElement):

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 27 May 2011 21:05:00 +0000 (21:05 +0000)]
2011-05-27  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed. Adjust baselines for debug-only failing scrollbar test.
        https://bugs.webkit.org/show_bug.cgi?id=61652

        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Fri, 27 May 2011 20:56:13 +0000 (20:56 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. Rebaselines and test expectations updates after r87526.

        * platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
        * platform/chromium-linux-x86/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-no-size-attributes-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-explicit-height-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/object-sizing-no-width-height-expected.txt: Added.
        * platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.txt: Added.
        * platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/test-rightsizing-a-expected.txt: Added.
        * platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.txt: Added.
        * platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/chromium-linux-x86/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
        * platform/chromium-linux-x86/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
        * platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
        * platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-no-size-attributes-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-explicit-height-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-explicit-width-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
        * platform/chromium-linux/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.png: Added.
        * platform/chromium-linux/svg/custom/object-sizing-no-width-height-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-linux/svg/wicd/rightsizing-grid-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.png: Added.
        * platform/chromium-linux/svg/wicd/test-rightsizing-a-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.txt: Added.
        * platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
        * platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
        * platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
        * platform/chromium-win-vista/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-no-size-attributes-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-explicit-height-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/object-sizing-no-width-height-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/test-rightsizing-a-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/test-rightsizing-b-expected.txt: Added.
        * platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
        * platform/chromium-win-vista/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
        * platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
        * platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 27 May 2011 20:53:43 +0000 (20:53 +0000)]
2011-05-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        30 second rewind button obscured in fullscreen controller
        https://bugs.webkit.org/show_bug.cgi?id=61663

        If reset() is called while in full-screen mode, make sure to show and hide
        the correct controls for that mode.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 27 May 2011 20:39:28 +0000 (20:39 +0000)]
2011-05-27  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Build fix for !ENABLE(ASSEMBLER) after r87527.

        * runtime/JSGlobalData.cpp:
        (JSGlobalData::JSGlobalData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 27 May 2011 20:29:12 +0000 (20:29 +0000)]
2011-05-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
        https://bugs.webkit.org/show_bug.cgi?id=61590

        * compositing/iframes/resizer-expected.txt: Added.
        * compositing/iframes/resizer.html: Added.
2011-05-27  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
        https://bugs.webkit.org/show_bug.cgi?id=61590

        Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
        backing is parented.  This ensures that the scroll corner layer for an iframe without a clipping layer ends up
        in the final layer tree.  We don't currently render resizers for iframes, but we will soon and this keeps the
        graphics layer tree consistent.

        Test: compositing/iframes/resizer.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 27 May 2011 20:25:27 +0000 (20:25 +0000)]
2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        embedded SVG object doesn't scale right
        https://bugs.webkit.org/show_bug.cgi?id=10526

        Fix last failing win/svg test, put result in correct directory.

        * platform/win/svg/custom/object-sizing-explicit-width-height-expected.txt: Copied from platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt.
        * platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/9513401>
jeffm@apple.com [Fri, 27 May 2011 20:22:46 +0000 (20:22 +0000)]
<rdar://problem/9513401>
Add "allow file-issue-extension*" to the sandbox profile to let the user style sheet be added as an exception and subsequently loaded.
This patch is actually by Timothy Hatcher, I'm just landing it for him.

Rubber-stamped by Steve Falkenburg.

* WebProcess/com.apple.WebProcess.sb: Added (allow file-issue-extension*).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed the change log entry from the last commit. The feature is tracked by the bug...
rniwa@webkit.org [Fri, 27 May 2011 20:21:20 +0000 (20:21 +0000)]
Fixed the change log entry from the last commit. The feature is tracked by the bug 61661 not by the bug 61630.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 27 May 2011 20:18:39 +0000 (20:18 +0000)]
2011-05-27  Ryosuke Niwa  <rniwa@webkit.org>

        Skip smart-paste-001.html through smart-paste-005.html because GTK doesn't support smart replace.
        The feature is tracked by the bug 61630.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 27 May 2011 19:53:45 +0000 (19:53 +0000)]
2011-05-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLVideoElement::currentSrc() should return a KURL
        https://bugs.webkit.org/show_bug.cgi?id=61578

        I suspect we got into this mess because the author of this code didn't
        know about the URL attribute in WebKit IDL, which is super useful!

        Bad news: The line of code in question seems to have another bug, which
        I've documented in a FIXME.  Let the yak shaving continue!

        * html/HTMLMediaElement.cpp:
        (WebCore::urlForLogging):
        (WebCore::HTMLMediaElement::loadResource):
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
        (WebCore::HTMLMediaElement::selectNextSourceChild):
        (WebCore::HTMLMediaElement::getPluginProxyParams):
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::currentSrc):
        (WebCore::HTMLMediaElement::currentURL):
        * html/canvas/CanvasRenderingContext.cpp:
        (WebCore::CanvasRenderingContext::checkOrigin):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteMediaURL):
            - This complete URL call was unnecessary because currentSrc is
              already absolute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 27 May 2011 19:52:26 +0000 (19:52 +0000)]
2011-05-27  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add support for showing URL of DOMWindow in heap profiles.
        https://bugs.webkit.org/show_bug.cgi?id=61177

        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotNode.prototype.get className):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAlways decode tester names from location.hash
aroben@apple.com [Fri, 27 May 2011 19:50:35 +0000 (19:50 +0000)]
Always decode tester names from location.hash

When navigating directly to a tester-specific URL (e.g.,
<http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
with a URL-encoded tester name in the page, and then the encoded name could make its way
into Bugzilla bugs. Bad!

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
decodeURIComponent before trying to use it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 27 May 2011 19:48:25 +0000 (19:48 +0000)]
2011-05-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Add a few validity assertions to JSCallbackObject
        https://bugs.webkit.org/show_bug.cgi?id=61659

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObject::visitChildren):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 27 May 2011 19:44:09 +0000 (19:44 +0000)]
2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        embedded SVG object doesn't scale right
        https://bugs.webkit.org/show_bug.cgi?id=10526

        Rebaseline some qt/win/leopard results.

        * platform/mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
        * platform/mac-leopard/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
        * platform/qt/svg/in-html/by-reference-expected.txt:
        * platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
        * platform/win/svg/zoom/page/object-sizing-explicit-width-height-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 27 May 2011 19:32:57 +0000 (19:32 +0000)]
2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Rob Buis.

        embedded SVG object doesn't scale right
        https://bugs.webkit.org/show_bug.cgi?id=10526

        Fixes crash in svg/custom/immutable-properties.html, seen on the bots.

        * svg/SVGLength.cpp:
        (WebCore::SVGLength::determineViewport): Oops forgot to merge-in a null check before landing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nat Duca <nduca@chromium.org>
enne@google.com [Fri, 27 May 2011 19:32:50 +0000 (19:32 +0000)]
2011-05-27  Nat Duca  <nduca@chromium.org>

        Unreviewed, landed by enne@google.com.

        [chromium] Add suppression for media/video-zoom due to 64/32 scrollbar issue
        https://bugs.webkit.org/show_bug.cgi?id=61652

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgot...
rniwa@webkit.org [Fri, 27 May 2011 18:56:21 +0000 (18:56 +0000)]
Add paste-pre-001-expected.txt and paste-pre-002-expected.txt for chromium-win forgotten in the previous commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 27 May 2011 18:52:59 +0000 (18:52 +0000)]
2011-05-27  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Convert editing/pasteboard/paste-pre-001.html and paste-pre-002.html to dump-as-markup tests
        https://bugs.webkit.org/show_bug.cgi?id=61610

        Converted paste-pre-001.html and paste-pre-002.html to dump-as-markup tests.

        * editing/pasteboard/paste-pre-001-expected.txt: Added.
        * editing/pasteboard/paste-pre-001.html:
        * editing/pasteboard/paste-pre-002-expected.txt: Added.
        * editing/pasteboard/paste-pre-002.html:
        * platform/chromium-linux/editing/pasteboard/paste-pre-001-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/paste-pre-002-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-pre-001-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-pre-001-expected.txt:
        * platform/chromium-win/editing/pasteboard/paste-pre-002-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-pre-002-expected.txt:
        * platform/gtk/editing/pasteboard/paste-pre-001-expected.png: Removed.
        * platform/gtk/editing/pasteboard/paste-pre-001-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-pre-002-expected.png: Removed.
        * platform/gtk/editing/pasteboard/paste-pre-002-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-pre-002-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-pre-001-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-pre-001-expected.txt: Removed.
        * platform/mac/editing/pasteboard/paste-pre-002-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-pre-002-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-pre-001-expected.png: Removed.
        * platform/qt/editing/pasteboard/paste-pre-001-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-pre-002-expected.png: Removed.
        * platform/qt/editing/pasteboard/paste-pre-002-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove testing code that snuck into r87528
aroben@apple.com [Fri, 27 May 2011 18:49:13 +0000 (18:49 +0000)]
Remove testing code that snuck into r87528

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix
oliver@apple.com [Fri, 27 May 2011 18:47:34 +0000 (18:47 +0000)]
Build fix

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd links to TestFailures to easily file bugs about failing tests
aroben@apple.com [Fri, 27 May 2011 18:41:56 +0000 (18:41 +0000)]
Add links to TestFailures to easily file bugs about failing tests

Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
links to file bugs for failing tests

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
for a particular build.
(Builder.prototype._getFailingTests): Use resultsPageURL.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._displayBuilder): Add links to file bugs about each set of
failures.
(ViewController.prototype._domForBuildName): Use resultsPageURL.
(ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
new bug link. The bug has a title, description, and URL already filled in for you!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 27 May 2011 18:30:08 +0000 (18:30 +0000)]
2011-05-27  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Try to release unused executable memory when the FixedVMPool allocator is under pressure
        https://bugs.webkit.org/show_bug.cgi?id=61651

        Rather than crashing when full the FixedVMPool allocator now returns a null
        allocation.  We replace the code that used to CRASH() on null allocations
        with logic that asks the provided globalData to release any executable memory
        that it can.  Currently this just means throwing away all regexp code, but
        in future we'll try to be more aggressive.

        * assembler/ARMAssembler.cpp:
        (JSC::ARMAssembler::executableCopy):
        * assembler/ARMAssembler.h:
        * assembler/AssemblerBuffer.h:
        (JSC::AssemblerBuffer::executableCopy):
        * assembler/AssemblerBufferWithConstantPool.h:
        * assembler/LinkBuffer.h:
        (JSC::LinkBuffer::LinkBuffer):
        (JSC::LinkBuffer::linkCode):
        * assembler/MIPSAssembler.h:
        (JSC::MIPSAssembler::executableCopy):
        * assembler/SH4Assembler.h:
        (JSC::SH4Assembler::executableCopy):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::executableCopy):
        (JSC::X86Assembler::X86InstructionFormatter::executableCopy):
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::compileFunction):
        * jit/ExecutableAllocator.h:
        (JSC::ExecutablePool::create):
        (JSC::ExecutablePool::alloc):
        (JSC::ExecutableAllocator::ExecutableAllocator):
        (JSC::ExecutableAllocator::poolForSize):
        (JSC::ExecutablePool::ExecutablePool):
        (JSC::ExecutablePool::poolAllocate):
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::alloc):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::privateCompileCTINativeCall):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::stringGetByValStubGenerator):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::finalize):
        * jit/ThunkGenerators.cpp:
        (JSC::charCodeAtThunkGenerator):
        (JSC::charAtThunkGenerator):
        (JSC::fromCharCodeThunkGenerator):
        (JSC::sqrtThunkGenerator):
        (JSC::powThunkGenerator):
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData):
        (JSC::JSGlobalData::releaseExecutableMemory):
        (JSC::releaseExecutableMemory):
        * runtime/JSGlobalData.h:
        * runtime/RegExpCache.cpp:
        (JSC::RegExpCache::invalidateCode):
        * runtime/RegExpCache.h:
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::compile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 27 May 2011 18:27:50 +0000 (18:27 +0000)]
2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        embedded SVG object doesn't scale right
        https://bugs.webkit.org/show_bug.cgi?id=10526

        <object> tags should treat width/height on a referenced SVG as intrinsic width/height
        https://bugs.webkit.org/show_bug.cgi?id=11976

        Incorrect handling of percentage values for width/height on embedded elements
        https://bugs.webkit.org/show_bug.cgi?id=14793

        WebKit fails some WICD 1.0 core test cases
        https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

        CSS 2.1: Support replaced elements with relative intrinsic sizes
        https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

        SVG embedded as <object> doesn't respect width/height attributes
        https://bugs.webkit.org/show_bug.cgi?id=34972

        Explicit size of object tag ignored
        https://bugs.webkit.org/show_bug.cgi?id=37086

        * http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml: Added.
        * http/tests/misc/resources/embedded.svg: Added.
        * http/tests/misc/resources/svg-slow.pl: Added.
        * platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
        * platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
        * platform/mac/svg/custom/object-no-size-attributes-expected.png: Added.
        * platform/mac/svg/custom/object-no-size-attributes-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-explicit-height-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-explicit-height-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-explicit-width-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-explicit-width-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-no-width-height-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-no-width-height-expected.txt: Added.
        * platform/mac/svg/hixie/text/003-expected.png:
        * platform/mac/svg/hixie/text/003-expected.txt:
        * platform/mac/svg/in-html/by-reference-expected.txt:
        * platform/mac/svg/wicd: Added.
        * platform/mac/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/mac/svg/wicd/rightsizing-grid-expected.txt: Added.
        * platform/mac/svg/wicd/test-rightsizing-a-expected.png: Added.
        * platform/mac/svg/wicd/test-rightsizing-a-expected.txt: Added.
        * platform/mac/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/mac/svg/wicd/test-rightsizing-b-expected.txt: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-no-width-height-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
        * svg/custom/object-no-size-attributes.xhtml: Added.
        * svg/custom/object-sizing-explicit-height.xhtml: Added.
        * svg/custom/object-sizing-explicit-width-height.xhtml: Added.
        * svg/custom/object-sizing-explicit-width.xhtml: Added.
        * svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml: Added.
        * svg/custom/object-sizing-no-width-height.xhtml: Added.
        * svg/custom/object-sizing.xhtml: Added.
        * svg/custom/resources/embedded.svg: Added.
        * svg/custom/resources/red-circle.svg: Added.
        * svg/in-html/by-reference-expected.png:
        * svg/wicd: Added.
        * svg/wicd/resources: Added.
        * svg/wicd/resources/a.svg: Added.
        * svg/wicd/resources/bcde.svg: Added.
        * svg/wicd/resources/empty1.svg: Added.
        * svg/wicd/resources/empty2.svg: Added.
        * svg/wicd/resources/empty3.svg: Added.
        * svg/wicd/resources/f.svg: Added.
        * svg/wicd/resources/g.svg: Added.
        * svg/wicd/resources/h.svg: Added.
        * svg/wicd/resources/i.svg: Added.
        * svg/wicd/resources/j.svg: Added.
        * svg/wicd/resources/k.svg: Added.
        * svg/wicd/resources/l.svg: Added.
        * svg/wicd/resources/main.css: Added.
        (body,html):
        (body):
        (.buttons):
        (h1):
        (h2):
        (h4):
        (p):
        (table):
        (th):
        (td,th):
        (td a):
        (a):
        (a:hover):
        (a:focus):
        (a:visited):
        (a.index):
        (a.index:hover):
        (a.index:focus):
        (a.index:visited):
        (ul):
        (ol):
        (.red):
        (.navi):
        (.navi a):
        (.navi a:hover):
        (.navi a:visited):
        * svg/wicd/resources/mnop.svg: Added.
        * svg/wicd/resources/q.svg: Added.
        * svg/wicd/resources/r.svg: Added.
        * svg/wicd/resources/s.svg: Added.
        * svg/wicd/resources/t.svg: Added.
        * svg/wicd/resources/test-rightsizing-a.css: Added.
        (html,body):
        (div.all):
        (object.w100):
        (object.h100):
        * svg/wicd/resources/test-rightsizing-b.css: Added.
        (html,body):
        (object):
        * svg/wicd/resources/test-svg-child-object-rightsizing.gif: Added.
        * svg/wicd/resources/test-svg-child-object-rightsizing.png: Added.
        * svg/wicd/resources/test-svg-child-object-rightsizing.svg: Added.
        * svg/wicd/resources/test-svg-child-object-rightsizing1.svg: Added.
        * svg/wicd/rightsizing-grid.xhtml: Added.
        * svg/wicd/test-rightsizing-a.xhtml: Added.
        * svg/wicd/test-rightsizing-b.xhtml: Added.
        * svg/zoom/page/resources: Added.
        * svg/zoom/page/resources/absolute-sized-svg.png: Added.
        * svg/zoom/page/resources/absolute-sized-svg.svg: Added.
        * svg/zoom/page/resources/huge-rect.svg: Added.
        * svg/zoom/page/resources/percentage-sized-svg.png: Added.
        * svg/zoom/page/resources/percentage-sized-svg.svg: Added.
        * svg/zoom/page/resources/text.svg: Added.
        * svg/zoom/page/resources/tux.svg: Added.
        * svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml: Added.
        * svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml: Added.
        * svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml: Added.
        * svg/zoom/page/zoom-svg-through-object-with-override-size.html: Added.
        * svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml: Added.
        * svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Added.

2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        embedded SVG object doesn't scale right
        https://bugs.webkit.org/show_bug.cgi?id=10526

        <object> tags should treat width/height on a referenced SVG as intrinsic width/height
        https://bugs.webkit.org/show_bug.cgi?id=11976

        Incorrect handling of percentage values for width/height on embedded elements
        https://bugs.webkit.org/show_bug.cgi?id=14793

        WebKit fails some WICD 1.0 core test cases
        https://bugs.webkit.org/show_bug.cgi?id=15836 (partially fixed, all 'rightsizing' tests are fixed)

        CSS 2.1: Support replaced elements with relative intrinsic sizes
        https://bugs.webkit.org/show_bug.cgai?id=15849 (partially fixed)

        SVG embedded as <object> doesn't respect width/height attributes
        https://bugs.webkit.org/show_bug.cgi?id=34972

        Explicit size of object tag ignored
        https://bugs.webkit.org/show_bug.cgi?id=37086

        Add partial support of CSS 2.1 replaced elements with intrinsic size. The feature itself is complete but has only
        been implemented for RenderPart, to support SVG content document size negotiation. It serves as starting point for a generalization, in future.
        The changes in RenderPart are a 1:1 transliteration of the spec (http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-width/height, see code).

        SVG 1.1 says:
        The 'width' attribute on the outermost svg element establishes the viewport's width, unless the following conditions are met:
        ...
        and there are CSS-compatible positioning properties ([CSS2], section 9.3) specified on the referencing element (e.g., the 'object' element)
        or on the containing document's outermost svg element that are sufficient to establish the width of the viewport. Under these conditions,
        the positioning properties establish the viewport's width.

        If an <object> carries width/height attributes, these specify the viewport size of the embedded SVG, instead of its own
        width/height or viewBox properties. If an <object> has no width/height information, its intrinsic size needs to be calculated depending
        on the intrinsic ratio (viewBox width divided by height ratio) and the width/height properties on the outermost referenced <svg> element.
        This requires a negotiation between the host document and the embedded document.
        (There are several more factors that need to be considered, the CSS spec covers this and the RenderPart::computeReplaced* code covers this.)

        Fixes dozens of long-standing bug reports. The number one integration issue when using SVG through <object> is resolved: "right sizing".

        Tests: http/tests/misc/object-embedding-svg-delayed-size-negotiation.xhtml
               svg/custom/object-no-size-attributes.xhtml (bug 11976, from Eric Seidel)
               svg/custom/object-sizing-explicit-height.xhtml (bug 10526, from Ryan Cannon)
               svg/custom/object-sizing-explicit-width-height.xhtml
               svg/custom/object-sizing-explicit-width.xhtml (bug 14793, from Oliver Hunt)
               svg/custom/object-sizing-no-width-height-change-content-box-size.xhtml
               svg/custom/object-sizing-no-width-height.xhtml
               svg/custom/object-sizing.xhtml (bug 37086, from Jeff Schiller)
               svg/wicd/rightsizing-grid.xhtml (bug 15836, WICD rightsizing test now works)
               svg/wicd/test-rightsizing-a.xhtml (ditto)
               svg/wicd/test-rightsizing-b.xhtml (ditto)
               svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml
               svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml
               svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml
               svg/zoom/page/zoom-svg-through-object-with-override-size.html (bug 34972, from Andreas Kling)
               svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml
               svg/zoom/page/zoom-svg-through-object-with-text.xhtml

        * platform/Length.h:
        (WebCore::Length::isSpecified):
        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::embeddedSVGContentRenderer):
        (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
        (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
        (WebCore::RenderPart::computeReplacedLogicalWidth):
        (WebCore::RenderPart::computeReplacedLogicalHeight):
        (WebCore::RenderPart::layout):
        * rendering/RenderPart.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeReplacedLogicalWidth):
        (WebCore::RenderReplaced::computeReplacedLogicalHeight):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::RenderSVGRoot):
        (WebCore::RenderSVGRoot::computeIntrinsicRatio):
        (WebCore::RenderSVGRoot::computeIntrinsicWidth):
        (WebCore::RenderSVGRoot::computeIntrinsicHeight):
        (WebCore::RenderSVGRoot::negotiateSizeWithHostDocumentIfNeeded):
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
        (WebCore::RenderSVGRoot::layout):
        * rendering/svg/RenderSVGRoot.h:
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::determineViewport):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::currentScale):
        (WebCore::SVGSVGElement::setCurrentScale):
        (WebCore::SVGSVGElement::currentViewBoxRect):
        (WebCore::SVGSVGElement::viewBoxToViewTransform):
        * svg/SVGSVGElement.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Fri, 27 May 2011 18:11:28 +0000 (18:11 +0000)]
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] drop unused WebFrame parameter to WebStorageArea::setItem
        https://bugs.webkit.org/show_bug.cgi?id=61583

        * public/WebStorageArea.h:
        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::setItem):
        * src/WebStorageAreaImpl.cpp:
        (WebKit::WebStorageAreaImpl::setItem):
        * src/WebStorageAreaImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 27 May 2011 17:52:05 +0000 (17:52 +0000)]
2011-05-27  Michael Saboff  <msaboff@apple.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=61646
        Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font

        Change the platformIsEqual to just compare the m_font members if
        either is not null.

        No tests added - functionality unchanged, fixing memory abandonment.

        * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
        (WebCore::FontPlatformData::platformIsEqual):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 27 May 2011 17:39:53 +0000 (17:39 +0000)]
2011-05-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [GTK][Cairo] Twitter rendering breaks
        https://bugs.webkit.org/show_bug.cgi?id=60917

        Added a GTK+ specific test that verifies that zero pixel sized
        fonts do not corrupt the Cairo context.

        * platform/gtk/fonts/zero-pixel-sized-fonts-expected.png: Added.
        * platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt: Added.
        * platform/gtk/fonts/zero-pixel-sized-fonts.html: Added.
2011-05-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Dirk Schulze.

        [GTK][Cairo] Twitter rendering breaks
        https://bugs.webkit.org/show_bug.cgi?id=60917

        When instantiating a cairo_scaled_font_t font would put the font in an error state,
        leave the m_scaledFont member of platform data as null. Rendering with scaled fonts
        in the error state can later lead to corrupted rendering.

        Due to this change, we must always null check cairo_scaled_font_t and the platform
        data now carries the cairo_font_face_t object with it, so that it can be accessed later
        if there is no cairo_scaled_font_t.

        Test: platform/gtk/fonts/zero-pixel-sized-fonts.html

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs): If the scaled font is null, do not render.
        * platform/graphics/freetype/FontPlatformData.h: Now include the cairo_font_face_t.
        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Initialize the new member.
        (WebCore::FontPlatformData::operator=): Carry over the new member.
        (WebCore::FontPlatformData::operator==): Check equality with the new member.
        (WebCore::FontPlatformData::initializeWithFontFace): If the initialization of m_scaledFont
        put the font into an error state, then just free it and return.
        (WebCore::FontPlatformData::hasCompatibleCharmap): The font always has a compatible charmap
        when the scaled font is null, because rendering is always a no-op and the font data never
        needs to be read.
        * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
        (WebCore::GlyphPage::fill): Don't read font data when the scaled font is null.
        * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
        (WebCore::SimpleFontData::platformInit): Return early when there's no scaled font.
        (WebCore::SimpleFontData::scaledFontData): Use the new m_font member.
        (WebCore::SimpleFontData::containsCharacters): Return early when there's no scaled font.
        (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-26 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 27 May 2011 17:39:35 +0000 (17:39 +0000)]
2011-05-26  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Optimized ConservativeSet to avoid double-visiting objects
        https://bugs.webkit.org/show_bug.cgi?id=61592

        SunSpider thinks this might be a 1% speedup

        * heap/ConservativeRoots.h:
        (JSC::ConservativeRoots::add): Use testAndClearMarked to avoid double-visiting
        an object.

        * heap/Heap.h:
        (JSC::Heap::isMarked):
        (JSC::Heap::testAndSetMarked):
        (JSC::Heap::testAndClearMarked):
        (JSC::Heap::setMarked): Added testAndClearMarked. Changed argument type
        to void*, since clients want to ask questions about arbitrary pointers
        into the heap, even when they aren't known to be JSCells.

        * heap/MarkedBlock.h:
        (JSC::MarkedBlock::testAndClearMarked):
        * heap/MarkedSpace.h:
        (JSC::MarkedSpace::isMarked):
        (JSC::MarkedSpace::testAndSetMarked):
        (JSC::MarkedSpace::testAndClearMarked):
        (JSC::MarkedSpace::setMarked):
        (JSC::MarkedSpace::contains): Ditto.

        * wtf/Bitmap.h:
        (WTF::::testAndClear): New function for ConservativeRoots's inverted
        marking pass.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoNeed a callback for when the preferred rendered size may have changed.
levin@chromium.org [Fri, 27 May 2011 17:25:06 +0000 (17:25 +0000)]
Need a callback for when the preferred rendered size may have changed.
https://bugs.webkit.org/show_bug.cgi?id=61309

Reviewed by Darin Fisher.

Source/WebCore:

No new tests needed since no new functionality is exposed.

* page/Chrome.cpp:
(WebCore::Chrome::layoutUpdated): Plumbed through the call.
* page/Chrome.h: Added the new method.
* page/ChromeClient.h:
(WebCore::ChromeClient::layoutUpdated): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Added a callback for whem a layout has finished.

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didUpdateLayout): Added stub.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::layoutUpdated): Plumbed through the call to WebFrameClient::didUpdateLayout.
* src/ChromeClientImpl.h: Added declaration.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRubber Stamped by Adam Roben.
slewis@apple.com [Fri, 27 May 2011 16:59:08 +0000 (16:59 +0000)]
Rubber Stamped by Adam Roben.

Source/JavaScriptCore:

Update Order Files.  Use -order_file flag since it can order more of the binary.

* Configurations/Base.xcconfig:
* JavaScriptCore.order:

Source/WebCore:

Update Order Files.  Use -order_file flag since it can order more of the binary.

* Configurations/Base.xcconfig:
* WebCore.order:

Source/WebKit/mac:

Update Order Files.  Use -order_file flag since it can order more of the binary.

* Configurations/Base.xcconfig:
* WebKit.order:

Source/WebKit2:

Add Order File.  Use -order_file flag since it can order more of the binary.

* Configurations/Base.xcconfig:
* mac/WebKit2.order: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 27 May 2011 16:34:10 +0000 (16:34 +0000)]
2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87464.
        http://trac.webkit.org/changeset/87464
        https://bugs.webkit.org/show_bug.cgi?id=61643

        client-close/server-close tests are flaky on Chromium Mac and
        Windows (Requested by aklein on #webkit).

        * http/tests/websocket/tests/client-close-expected.txt: Removed.
        * http/tests/websocket/tests/client-close.html: Removed.
        * http/tests/websocket/tests/client-close_wsh.py: Removed.
        * http/tests/websocket/tests/close-before-open-expected.txt:
        * http/tests/websocket/tests/close-event-expected.txt:
        * http/tests/websocket/tests/close-event.html:
        * http/tests/websocket/tests/close-unref-websocket-expected.txt:
        * http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
        * http/tests/websocket/tests/server-close-expected.txt: Removed.
        * http/tests/websocket/tests/server-close.html: Removed.
        * http/tests/websocket/tests/server-close_wsh.py: Removed.
        * http/tests/websocket/tests/websocket-event-target-expected.txt:
2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87464.
        http://trac.webkit.org/changeset/87464
        https://bugs.webkit.org/show_bug.cgi?id=61643

        client-close/server-close tests are flaky on Chromium Mac and
        Windows (Requested by aklein on #webkit).

        * platform/network/SocketStreamHandleBase.cpp:
        (WebCore::SocketStreamHandleBase::send):
        (WebCore::SocketStreamHandleBase::close):
        (WebCore::SocketStreamHandleBase::sendPendingData):
        * platform/network/SocketStreamHandleBase.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::send):
        (WebCore::WebSocket::close):
        (WebCore::WebSocket::bufferedAmount):
        (WebCore::WebSocket::didConnect):
        (WebCore::WebSocket::didReceiveMessage):
        (WebCore::WebSocket::didReceiveMessageError):
        (WebCore::WebSocket::didClose):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::close):
        (WebCore::WebSocketChannel::disconnect):
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::didReceiveData):
        (WebCore::WebSocketChannel::didFail):
        (WebCore::WebSocketChannel::processBuffer):
        * websockets/WebSocketChannel.h:
        * websockets/WebSocketChannelClient.h:
        (WebCore::WebSocketChannelClient::didClose):
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
        (WebCore::workerContextDidClose):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
        * websockets/WorkerThreadableWebSocketChannel.h:
2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87464.
        http://trac.webkit.org/changeset/87464
        https://bugs.webkit.org/show_bug.cgi?id=61643

        client-close/server-close tests are flaky on Chromium Mac and
        Windows (Requested by aklein on #webkit).

        * Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 27 May 2011 16:19:53 +0000 (16:19 +0000)]
2011-05-27  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=19995
        hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

        Remove 003-broken.xml and replace it with a 003.xml that is text-only.

        * platform/mac/svg/hixie/links/003-broken-expected.png: Removed.
        * platform/mac/svg/hixie/links/003-broken-expected.txt: Removed.
        * svg/hixie/links/003-broken.xml: Removed.
        * svg/hixie/links/003-expected.txt: Added.
        * svg/hixie/links/003.xml: Added.
2011-05-27  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=19995
        hixie.ch : anchor Link fails with fragment identifiers inside SVG fragments.

        Only allow links to animation elements within the document.

        Test: svg/hixie/links/003.xml

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 27 May 2011 16:14:39 +0000 (16:14 +0000)]
2011-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [CAIRO] Don't copy the surface before drawing it into the context in ShareableBitmap::paint()
        https://bugs.webkit.org/show_bug.cgi?id=60757

        cairo_image_surface_create_for_data() is already a shallow copy of
        the image, so we don't need to copy it again.

        * Shared/cairo/ShareableBitmapCairo.cpp:
        (WebKit::ShareableBitmap::paint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago[Chromium] Unreviewed test expectations update: remove details expectations accidenta...
adamk@chromium.org [Fri, 27 May 2011 16:10:00 +0000 (16:10 +0000)]
[Chromium] Unreviewed test expectations update: remove details expectations accidentally re-added in a merge.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added Douglas Davidson to contributors list for easier CC'ing.
ap@apple.com [Fri, 27 May 2011 15:41:20 +0000 (15:41 +0000)]
    Added Douglas Davidson to contributors list for easier CC'ing.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Fri, 27 May 2011 15:34:17 +0000 (15:34 +0000)]
2011-05-27  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Csaba Osztrogonác.

        [Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
        https://bugs.webkit.org/show_bug.cgi?id=61044

        Make sure to set the active window on the application too.

        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::setPalette):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
yael.aharon@nokia.com [Fri, 27 May 2011 15:19:03 +0000 (15:19 +0000)]
Unreviewed.

WebKit2 does not support eventSender.

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 27 May 2011 15:03:50 +0000 (15:03 +0000)]
2011-05-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        Update RGBA color serialization to match HTML5.
        https://bugs.webkit.org/show_bug.cgi?id=61449

        HTML5 now specifies that fully transparent colors should have their alpha value
        serialized to "0" rather than "0.0" (followed by any number of extra zeroes.)

        The number of decimals for alpha values between 0 and 1 is not specified,
        so match Gecko and Presto by returning the lowest number of decimals needed
        to represent the number. (No more trailing zeroes.)

        * platform/graphics/Color.cpp:
        (WebCore::Color::serialized):
2011-05-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        Update RGBA color serialization to match HTML5.
        https://bugs.webkit.org/show_bug.cgi?id=61449

        Update tests to reflect the new behavior.

        * canvas/philip/tests/2d.fillStyle.get.transparent.html:
        * canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html:
        * canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html:
        * editing/style/inline-style-container-expected.txt
        * editing/style/script-tests/inline-style-container.js:
        * fast/canvas/canvas-color-clamping-expected.txt:
        * fast/canvas/canvas-color-serialization-expected.txt:
        * fast/canvas/canvas-currentColor-expected.txt:
        * fast/canvas/script-tests/canvas-color-clamping.js:
        * fast/canvas/script-tests/canvas-color-serialization.js:
        * fast/canvas/script-tests/canvas-currentColor.js:
        * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt:
        * fast/dom/canvasContext2d-element-attribute-js-null.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
yael.aharon@nokia.com [Fri, 27 May 2011 14:35:51 +0000 (14:35 +0000)]
Unreviewed.

Skip a test that requires eventSender.beginDragWithFiles.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUnreviewed.
yael.aharon@nokia.com [Fri, 27 May 2011 14:23:37 +0000 (14:23 +0000)]
Unreviewed.

Skip a test that is failing until investigated.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-26 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Fri, 27 May 2011 14:19:07 +0000 (14:19 +0000)]
2011-05-26  Jeff Miller  <jeffm@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add a key handling logging channel for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=61588

        Added a new LogKeyHandling channel, and logged some key events in WebPageProxy.
        I also fixed a misspelling of coalescing in a comment in WebPageProxy.cpp.

        * Platform/Logging.cpp:
        (WebKit::initializeLogChannelsIfNecessary): Initialize LogKeyHandling channel.
        * Platform/Logging.h: Added LogKeyHandling channel.

        * UIProcess/WebPageProxy.cpp: Fixed misspelling of coalescing in a comment.
        (WebKit::webKeyboardEventTypeString): Added to support logging.
        (WebKit::WebPageProxy::handleKeyboardEvent): Log the keyboard event.
        (WebKit::WebPageProxy::didReceiveEvent): Log the keyboard event.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2011-05-27 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Fri, 27 May 2011 14:02:26 +0000 (14:02 +0000)]
2011-05-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Tony Gentilcore.

        IndexedDB: Support mutating cursors on top of LevelDB
        https://bugs.webkit.org/show_bug.cgi?id=61615

        New test for adding new entries to an objecet store while running a
        cursor over it.

        * storage/indexeddb/mutating-cursor-expected.txt: Added.
        * storage/indexeddb/mutating-cursor.html: Added.
2011-05-27  Hans Wennborg  <hans@chromium.org>

        Reviewed by Tony Gentilcore.

        IndexedDB: Support mutating cursors on top of LevelDB
        https://bugs.webkit.org/show_bug.cgi?id=61615

        We need to support the case where a new node is added to the tree in a
        transaction after the TreeIterator has covered the whole tree.

        Since this is done lazily, i.e. we set a flag that the tree might have
        changed, and act upon it later, some members need to be mutable,
        because we might need to re-seek the tree iterator in a const function.

        Test: storage/indexeddb/mutating-cursor.html
              storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html (existing)

        * platform/leveldb/LevelDBTransaction.cpp:
        (WebCore::LevelDBTransaction::set):
        (WebCore::LevelDBTransaction::TreeIterator::reset):
        (WebCore::LevelDBTransaction::TreeIterator::~TreeIterator):
        (WebCore::LevelDBTransaction::TreeIterator::TreeIterator):
        (WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator):
        (WebCore::LevelDBTransaction::TransactionIterator::~TransactionIterator):
        (WebCore::LevelDBTransaction::TransactionIterator::next):
        (WebCore::LevelDBTransaction::TransactionIterator::prev):
        (WebCore::LevelDBTransaction::TransactionIterator::key):
        (WebCore::LevelDBTransaction::TransactionIterator::value):
        (WebCore::LevelDBTransaction::TransactionIterator::treeChanged):
        (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
        (WebCore::LevelDBTransaction::registerIterator):
        (WebCore::LevelDBTransaction::unregisterIterator):
        (WebCore::LevelDBTransaction::notifyIteratorsOfTreeChange):
        * platform/leveldb/LevelDBTransaction.h:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::open):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87508 268f45cc-cd09-0410-ab3c-d52691b4dbfc