Aaron Robinson [Thu, 7 Mar 2019 20:19:53 +0000 (12:19 -0800)]
Update error message for when a parent is marked as COMVisible(false) (dotnet/coreclr#23092)
* Update message to include type and parent type marked as COMVisible(false)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8b3c55c36531689c337df37f15eb5a40530fa42f
Andy Ayers [Thu, 7 Mar 2019 18:52:19 +0000 (10:52 -0800)]
JIT: fix filter liveness computation (dotnet/coreclr#23044)
When a filter is finished executing, control can logically pass to the
associated handler, any enclosing handler or filter, or any finally or fault
handler nested within the associated try. This is a consequence of two-pass EH.
The jit was not propagating liveness from the nested handlers, which lead to a
live object being collected inadvertently.
This change updates `fgGetHandlerLiveVars` to find the nested handlers and
merge their live-in into the filter block live sets.
Because these implicit EH flow edges can create cycles in the liveness dataflow
equations, the jit will also now always iterate liveness when it sees there is
exception flow, to ensure livness reaches the appropriate fixed point.
Added test case.
Closes dotnet/coreclr#22820.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f6cc0134fa4bb0d2f329ebc18c4eb662a5a5d973
Juan Hoyos [Thu, 7 Mar 2019 18:35:25 +0000 (10:35 -0800)]
Fix control C trap hang in the debugger (dotnet/coreclr#23090)
Commit migrated from https://github.com/dotnet/coreclr/commit/
637900c4d1792d41b0c195904c079277cd80caf9
Bruce Forstall [Thu, 7 Mar 2019 17:25:17 +0000 (09:25 -0800)]
Clean up some arm64 prolog/epilog code (dotnet/coreclr#23080)
* Clean up some arm64 prolog/epilog code
1. For frame types which establish a frame pointer before the final
SP adjustment, there is no need to report the SP adjustment in unwind
data, as it is unused.
2. Added some comments, esp. related to frameType 1, explaining the
totalFrameSize limit.
3. Fixed frameType 3 #outsz check to > 504 versus >= 504; 504 is a legal
offset for STP/LDP.
4. Fix frameType 3 epilogs to always restore SP from FP. Should give more
prolog/epilog unwind code matching, and simplifies the code.
Closes dotnet/coreclr#22056, dotnet/coreclr#22058, dotnet/coreclr#22057, dotnet/coreclr#22476, dotnet/coreclr#22478.
* Formatting
* Update comment
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5935b38947fe1c6beea1a9191e58b3048355b67
Bruce Forstall [Thu, 7 Mar 2019 16:34:29 +0000 (08:34 -0800)]
Merge pull request dotnet/coreclr#23085 from BruceForstall/FixAsmDiffScratchRoot
Fix PMI asm diffs
Commit migrated from https://github.com/dotnet/coreclr/commit/
781211ecdf96d3d9293e7623dc9e5990dd857e57
Jan Kotas [Thu, 7 Mar 2019 15:37:04 +0000 (07:37 -0800)]
Cleanup unused hosting interfaces (dotnet/coreclr#23091)
Commit migrated from https://github.com/dotnet/coreclr/commit/
70300c711b9e507d251f9a31d5c4be9653dd4c8a
Hugh Bellamy [Thu, 7 Mar 2019 14:39:23 +0000 (14:39 +0000)]
Cleanup Globalization info code (dotnet/coreclr#22591)
Commit migrated from https://github.com/dotnet/coreclr/commit/
724112354c74b67629d58d1f6b9c0007f5a13fc9
Sergey Andreenko [Thu, 7 Mar 2019 07:09:11 +0000 (23:09 -0800)]
Ignore warning in another build script. (dotnet/coreclr#23082)
Commit migrated from https://github.com/dotnet/coreclr/commit/
8e39d114c9f9733f3337dc678cd2344631dd4742
Next Turn [Thu, 7 Mar 2019 02:26:51 +0000 (10:26 +0800)]
Fix comment (dotnet/coreclr#23058)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a8e9f22240cbd0ac75f119a05d92ccfb19342940
Mike McLaughlin [Thu, 7 Mar 2019 01:57:13 +0000 (17:57 -0800)]
Fix missing includes in coreclr/src/debug/createdump/ (dotnet/coreclr#23075)
See issue 19722.
Commit migrated from https://github.com/dotnet/coreclr/commit/
898d3f4b8f7dd9ab6bd87548e2f11a5d1618f59a
Michal Strehovský [Thu, 7 Mar 2019 00:52:36 +0000 (01:52 +0100)]
Remove legacy behavior around non-virtual interface calls (dotnet/coreclr#23032)
* Throw BadImageFormat for direct calls to abstract methods
* Remove legacy behavior around non-virtual interface calls
* Try fixing failing tests
The test we inherited from the default interface method prototype branch is doing exactly the thing it shouldn't do (rely on the bad behavior) for unexplained reasons.
Commit migrated from https://github.com/dotnet/coreclr/commit/
502de2a97b9fd26082ee8e3de46734724b2b535c
Sven Boemer [Thu, 7 Mar 2019 00:26:17 +0000 (16:26 -0800)]
Use Microsoft Container Registry for docker images (dotnet/coreclr#23061)
* Use Microsoft Container Registry for docker images
https://github.com/dotnet/dotnet-buildtools-prereqs-docker has been updated to publish docker images to the Microsoft Container Registry.
* Also update netci.groovy
Commit migrated from https://github.com/dotnet/coreclr/commit/
18542014bba5c33a776fa12c46a001fbe55dc5d1
Michal Strehovský [Mon, 4 Mar 2019 17:41:36 +0000 (18:41 +0100)]
Fix ProjectN build breaks (dotnet/corertdotnet/coreclr#7115)
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
28342adceb2995f9074a289c0b82b580f5fb1fe9
Honza Rameš [Wed, 6 Mar 2019 15:51:17 +0000 (16:51 +0100)]
Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/coreclr#35810)
* Fix ValueStringBuilder.EnsureCapacity to call Grow correctly (dotnet/coreclr#35746)
Call to EnsureCapacity may result in invalid buffer size being
allocated.
* Update ValueStringBuilder.Grow to prevent misuse (dotnet/coreclr#35746)
Updated name of the argument to make it clearer on the call-site also
added summary co clearly state the behavior of Grow.
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
042e1790a50e79cc99d63125c6281bd2f1e1d387
dotnet-maestro[bot] [Tue, 5 Mar 2019 19:17:12 +0000 (19:17 +0000)]
Update dependencies from dotnet/core-setup (dotnet/corefxdotnet/coreclr#35713)
* Update dependencies from https://github.com/dotnet/core-setup build
20190301.13
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27501-13
* Remove workaround for System.Runtime.CompilerServices.Unsafe
* Update dependencies from https://github.com/dotnet/core-setup build
20190302.8
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27502-8
* Update dependencies from https://github.com/dotnet/core-setup build
20190303.9
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27503-9
* Update dependencies from https://github.com/dotnet/core-setup build
20190304.10
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27504-10
* Don't include EventRegistrationToken on Unix
This type was accidentally duplicated between CoreLib and contracts.
Suppress that for now since we're detecting the duplication in the shared framework.
Make a fix in the shared items to restore the condition on this type.
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
afcb5e3de5cf3df6d865c284168e82c5f6c73038
Viktor Hofer [Sun, 3 Mar 2019 17:55:25 +0000 (18:55 +0100)]
Project msbuild syntax cleanup (dotnet/corefxdotnet/coreclr#35686)
* Remove license header from non-shipping files
* Remove obsolete Project attributes
* Remove xml header and remove DefaultTargets
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
864a9cc1af452d72e72b0e9db8c84a0c19f498d3
Michelle McDaniel [Thu, 7 Mar 2019 00:19:16 +0000 (16:19 -0800)]
Change IBC data path to match Arcade standard (dotnet/coreclr#23063)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a270c17c931f3bbc9f2f1cad8baa29ace5e36c14
Bruce Forstall [Wed, 6 Mar 2019 23:55:11 +0000 (15:55 -0800)]
Fix PMI asm diffs
Fix scratch_root validation
Commit migrated from https://github.com/dotnet/coreclr/commit/
2062dc2339bd05886d7230df995d84e14231727e
Jarret Shook [Wed, 6 Mar 2019 23:00:37 +0000 (15:00 -0800)]
Do not conflict publish name based on scenario (dotnet/coreclr#23041)
* Do not conflict publish name based on scenario
* Fix syntax error
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f1e36058d44e458e4d76ef633463ff45db17e07
Koundinya Veluri [Wed, 6 Mar 2019 19:17:18 +0000 (11:17 -0800)]
Temporarily disable some WaitAny tests that have been failing periodically in the CI (dotnet/coreclr#22997)
Issues:
- https://github.com/dotnet/coreclr/issues/19515
- https://github.com/dotnet/coreclr/issues/19406
- https://github.com/dotnet/coreclr/issues/14249
Commit migrated from https://github.com/dotnet/coreclr/commit/
1c39a226041de19909a964889d77c0cfc908bf45
Michal Strehovský [Wed, 6 Mar 2019 18:23:44 +0000 (19:23 +0100)]
Improve resiliency of LoadIBCMethodHelper (dotnet/coreclr#23057)
The encoded slot could be bogus and we would end up asserting for this.
Commit migrated from https://github.com/dotnet/coreclr/commit/
326b25a658e87a122708d5ce1f4d997c1c1730f5
Andy Ayers [Wed, 6 Mar 2019 18:14:40 +0000 (10:14 -0800)]
JIT: fix issue with assertion prop on isinst helpers (dotnet/coreclr#23056)
For calls to isinst helpers, morph may rearrange the order of args on the late
arg list, so examine the operands to ensure the right ones are passed into the
assertion creation code.
Added simplified test case.
Closes dotnet/coreclr#23039.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5ce4140ca10cdda9af170d5215ff9de295c58a30
Carol Eidt [Wed, 6 Mar 2019 18:07:07 +0000 (10:07 -0800)]
Merge pull request dotnet/coreclr#22912 from fiigii/fixBroadcast
Fix BroadcastScalarToVector128/256 codegen
Commit migrated from https://github.com/dotnet/coreclr/commit/
b7922721dc7298094da3f4c2bcf31b43fde9476b
Tanner Gooding [Wed, 6 Mar 2019 12:27:57 +0000 (04:27 -0800)]
Fixing the float/double parsing logic to handle exponents that are too large/small (dotnet/coreclr#23043)
* Fixing the float/double parsing logic to handle exponents that are too large/small
* Fixing the debug assert to use >= and <=
* Fixing the max exponents to be +1 to match what scale uses.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5a2650959268bf0a760965a2bd8cca34301cd1a1
Fei Peng [Wed, 6 Mar 2019 08:30:14 +0000 (00:30 -0800)]
fix BroadcastScalarToVector128/256 and simplify MoveMask
Commit migrated from https://github.com/dotnet/coreclr/commit/
c5da1c4c42f1f1bc3f8254bc9c50bcd431f10001
Steve MacLean [Wed, 6 Mar 2019 07:40:50 +0000 (02:40 -0500)]
Cleanup old code (dotnet/coreclr#23053)
Remove IsContinuableException declaration & fix comment
Clean up ThreadBaseRedirectingFilter
Clean up comment
Cleanup dead code
Commit migrated from https://github.com/dotnet/coreclr/commit/
cb87aaebb321edd9ed74786305953314acfefda3
Andy Ayers [Wed, 6 Mar 2019 06:49:49 +0000 (22:49 -0800)]
Reduce running time of GitHub_19361 test case (dotnet/coreclr#23048)
This is a regression test and the original issue indicated that the test
would fail reliably under GC stress. So cut down the size of the lists
being processed and remove the various exclusions.
This reduces execution time on arm64 debug from ~30 mins to 2 seconds.
Closes dotnet/coreclr#20232.
Commit migrated from https://github.com/dotnet/coreclr/commit/
76abdef2f4e1d91c97581e0d5ec63d6edf3248c0
Jeremy Koritzinsky [Wed, 6 Mar 2019 04:54:49 +0000 (20:54 -0800)]
Move HasLayoutMetadata to methodtablebuilder.cpp (dotnet/coreclr#23015)
* Move HasLayoutMetadata to methodtablebuilder.cpp
* Collapse auto case into unicode case.
* Remove ancient workaround for Managed C++ compiler bug.
Commit migrated from https://github.com/dotnet/coreclr/commit/
400b472f3333fd2a5371fcab7c34c2892b6324c6
Stephen Toub [Wed, 6 Mar 2019 03:37:33 +0000 (19:37 -0800)]
Clean up some string.Format usage (dotnet/coreclr#23025)
* Clean up some string.Format usage
Mainly changes some string.Format usage to be SR.Format when working with resource strings. Also cleans up a few asserts that were using string.Format.
* Address PR feedback and clean up src
* Address more feedback
* Update src/System.Private.CoreLib/shared/System/Type.Enum.cs
Thanks.
Co-Authored-By: stephentoub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
3662d02bb222728ebed70d6d73f89a63c9910ffb
Andrew Au [Tue, 5 Mar 2019 21:48:50 +0000 (13:48 -0800)]
Fix issue 23040
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffcdabd7735d6860dec361d1efde20be4cf89b8f
Andrew Au [Tue, 5 Mar 2019 20:01:15 +0000 (12:01 -0800)]
Fix issue 23037
Commit migrated from https://github.com/dotnet/coreclr/commit/
a20e3d04343d47326e3c0789802890bc3f0c522c
John Salem [Tue, 5 Mar 2019 21:20:55 +0000 (13:20 -0800)]
Update delegate signature for GetSourceLineInfo and change reflection logic to find correct overload on CoreFX side (dotnet/coreclr#22960)
Commit migrated from https://github.com/dotnet/coreclr/commit/
98cd595b35ced3adb6efe0c667f5160f21067e0b
Aaron Robinson [Tue, 5 Mar 2019 20:08:01 +0000 (12:08 -0800)]
Re-enable RCW license tests (dotnet/coreclr#23023)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2add95d3f3dc6e0b54946f88ba2215560f5002a3
Maryam Ariyan [Tue, 5 Mar 2019 19:36:02 +0000 (11:36 -0800)]
Add Type Forward (dotnet/coreclr#23036)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c004dff82def0f92ca837b81fd93445ae767fd62
Marek Safar [Tue, 5 Mar 2019 19:07:15 +0000 (20:07 +0100)]
Move more Assembly methods to shared partition (dotnet/coreclr#22817)
Commit migrated from https://github.com/dotnet/coreclr/commit/
2a295e0232aa28dd9b98a0f8bd9bd6ed12b6a4bd
Juan Hoyos [Tue, 5 Mar 2019 18:41:22 +0000 (10:41 -0800)]
Merge pull request dotnet/coreclr#23002 from optimization
[master] Update dependencies from 1 repositories
Commit migrated from https://github.com/dotnet/coreclr/commit/
4834806fa2268b73ffe23ef6ccf40e93946bc7d6
Jarret Shook [Tue, 5 Mar 2019 17:10:07 +0000 (09:10 -0800)]
Disable test correctly. Missed casing (dotnet/coreclr#23035)
Commit migrated from https://github.com/dotnet/coreclr/commit/
75cc2a038d8608501d6788c1423965e3a7280dae
Russ Keldorph [Sun, 3 Mar 2019 05:00:34 +0000 (21:00 -0800)]
Fix JIT/Directed/pinvoke/tail
Remove dependency on Windows user32 library and enable test for all platforms.
Fixes dotnet/coreclr#13048
Commit migrated from https://github.com/dotnet/coreclr/commit/
5739414d9757164ccf54cf92fd556f7ae6a16402
Andrew Au [Mon, 4 Mar 2019 23:39:41 +0000 (15:39 -0800)]
Fix issue 23009
Commit migrated from https://github.com/dotnet/coreclr/commit/
119cfe86d996aec5f81a2dae491e9c8c7f445bb5
Steve MacLean [Tue, 5 Mar 2019 11:29:18 +0000 (06:29 -0500)]
Remove dead AppDomain unload code (dotnet/coreclr#23026)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc11162e1c36624d3cabb6e0bf6583a94ab2e30c
Sung Yoon Whang [Tue, 5 Mar 2019 11:06:40 +0000 (03:06 -0800)]
Update eventcounter spec (dotnet/coreclr#23019)
* Update EventCounter spec
* some wording fix
* some wording fix
* fix payload example
* Add DisplayRateTimeScale
Commit migrated from https://github.com/dotnet/coreclr/commit/
b54752c8869f55c82cc24b49fbb1b48a87090943
Andy Ayers [Tue, 5 Mar 2019 07:30:48 +0000 (23:30 -0800)]
JIT: remove unneeded ref count updating traversal from optimizer (dotnet/coreclr#22954)
The ref count update traversal in the optimizer is not doing anything,
so remove it. This was overlooked when we changed away from incremental
updates in dotnet/coreclr#19345.
Also: fix up comments and documentation to reflect the current approach
to local var ref counts.
Commit migrated from https://github.com/dotnet/coreclr/commit/
04fed62162092da2a824e425aa65b8fcfc70ce14
Steve MacLean [Tue, 5 Mar 2019 06:54:24 +0000 (01:54 -0500)]
Remove dead ContainToAppDomain (dotnet/coreclr#23021)
* Remove dead ContainToAppDomain
* Respond to feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
7d54e6130f0db16b2eaa80272076ae3bd725cf69
Sergey Andreenko [Tue, 5 Mar 2019 05:46:19 +0000 (21:46 -0800)]
Do not treat warnings as errors during corefx build in docker. (dotnet/coreclr#23014)
* Do not treat warnings as errors during corefx build in docker.
* Add a comment.
Commit migrated from https://github.com/dotnet/coreclr/commit/
14caedf474161891c09e740448f07e541e7a95b5
Aaron Robinson [Tue, 5 Mar 2019 02:58:56 +0000 (18:58 -0800)]
Remove loose dependency in runtime on System.ComponentModel. (dotnet/coreclr#23010)
Remove loose dependency in runtime on System.ComponentModel.
Disable test to sync with CoreFX
Commit migrated from https://github.com/dotnet/coreclr/commit/
88ada237f7765b7edd39967adab8ea2ba25ea16c
Steve MacLean [Tue, 5 Mar 2019 01:29:11 +0000 (20:29 -0500)]
Remove BEGIN/END_EXCEPTION_GLUE from botr
Commit migrated from https://github.com/dotnet/coreclr/commit/
77fcaf6b738941a0c5dc3c00b70b49c7d9f63b69
Egor Chesakov [Tue, 5 Mar 2019 00:42:40 +0000 (16:42 -0800)]
Pass -priority= argument directly to build-test.cmd (dotnet/coreclr#23007)
Commit migrated from https://github.com/dotnet/coreclr/commit/
a217ea2902e26182e7f8f3f66afce1fffa1fc175
Egor Chesakov [Mon, 4 Mar 2019 23:22:56 +0000 (15:22 -0800)]
Publish logs as pipeline artifacts for build-job.yml and test-job.yml (dotnet/coreclr#22926)
Commit migrated from https://github.com/dotnet/coreclr/commit/
857567c1b7f35986bc72d7d417e8db64f4df9f72
Jarret Shook [Mon, 4 Mar 2019 22:22:44 +0000 (14:22 -0800)]
Disable tests for open issues (dotnet/coreclr#22976)
* Disable tests for open issues
* Clean pri1 run
Commit migrated from https://github.com/dotnet/coreclr/commit/
d17b66c8bbc21fc8be18d901e691ed7e9bc8d7ce
Jarret Shook [Mon, 4 Mar 2019 22:19:14 +0000 (14:19 -0800)]
Fix rid choice setup stress (dotnet/coreclr#23004)
* Correct rid choice for setting up coredistools
* Force ubuntu.14.04 as the rid choice for ubuntu
* Add better comment
* Fix typo
Commit migrated from https://github.com/dotnet/coreclr/commit/
36cf483227b1fdc3d6554ab6694cb0215b0eed26
Jeremy Koritzinsky [Mon, 4 Mar 2019 21:15:28 +0000 (13:15 -0800)]
Move EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing to class.cpp (dotnet/coreclr#22932)
Move `EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing` to class.cpp and out of fieldmarshaler.cpp.
This change co-locates `EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing` with the rest of the implementation of `EEClassLayoutInfo`. Additionally, this PR separates out the field blittability check into a separate function instead of burying it in `CollectLayoutFieldMetadataThrowing`.
Finally, it adds a small optimization in the field marshaler implementations where if a field's native size is statically known, the code returns that value instead of calling into one of the FieldMarshaler "virtual" calls.
Originally part of dotnet/coreclr#21415, but extracted out to make that PR smaller.
Commit migrated from https://github.com/dotnet/coreclr/commit/
1278da1f480e664b5afd1b62f2be74424dbefbb8
Carol Eidt [Mon, 4 Mar 2019 16:54:19 +0000 (08:54 -0800)]
Merge pull request dotnet/coreclr#22791 from CarolEidt/Fix19256
Fix condition for calling EvalArgsToTemps
Commit migrated from https://github.com/dotnet/coreclr/commit/
fd3afcaf0dc0ace3f84d0412c128f4e64c419105
Sinan Kaya [Mon, 4 Mar 2019 06:55:22 +0000 (01:55 -0500)]
Cleanup more GCC warnings (dotnet/coreclr#22872)
* Add parenthesis
src/vm/sha1.cpp: In function ‘void SHA1_block(SHA1_CTX*)’:
src/vm/sha1.cpp:93:29: warning: suggest parentheses around arithmetic in operand of ‘|’ [-Wparentheses]
#define ROUND3(B, C, D) ((C & (B | D) | (B & D)) + sha1_round3)
^
src/vm/sha1.cpp:139:32: note: in expansion of macro ‘ROUND3’
e += ROTATE32L(a, 5) + ROUND3(b, c, d) + msg80[i];
* Move declaration into same file as one was defined Extern the other one was static
* Remove hr=hr undefined assignment
* Fix mutli-line comment warning
* Convert multi-character literal
* Remove null check for stack local variables
rc/vm/invokeutil.cpp: In static member function ‘static void InvokeUtil::SetValidField(CorElementType, TypeHandle, FieldDesc*, OBJECTREF*, OBJECTREF*, TypeHandle, CLR_BOOL*)’:
src/vm/invokeutil.cpp:978:29: warning: the address of ‘Throwable’ will never be NULL [-Waddress]
EX_CATCH_THROWABLE(&Throwable);
^
src/inc/ex.h:1087:21: note: in definition of macro ‘EX_CATCH_THROWABLE’
if (NULL != ppThrowable)
^
Commit migrated from https://github.com/dotnet/coreclr/commit/
9d3f264b9ef8b4715017ec615dcb6f9d57e607cc
Dotnet-GitSync-Bot [Mon, 4 Mar 2019 05:07:25 +0000 (21:07 -0800)]
Mirror changes from dotnet/corert (dotnet/coreclr#22985)
* Move fully managed TimerQueue implementation to shared partition (dotnet/coreclr#7111)
* Update CoreCLR for changes in shared partition
Commit migrated from https://github.com/dotnet/coreclr/commit/
7da0883d9ceba31bccf36cc8cbbbf2fe77a4f3e0
Stephen Toub [Sun, 3 Mar 2019 21:33:39 +0000 (16:33 -0500)]
Merge pull request dotnet/coreclr#22981 from dotnet/darc-master-
95952865-131b-47b2-99d0-
f60a630db1b3
[master] Update dependencies from dotnet/corefx
Commit migrated from https://github.com/dotnet/coreclr/commit/
fef5785dbb0012da8ff2b53007b2684df23a729e
Jan Kotas [Sun, 3 Mar 2019 15:08:54 +0000 (07:08 -0800)]
Disable outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
758823876700728fee63f7726791f35ef391d377
Jan Kotas [Sun, 3 Mar 2019 06:25:25 +0000 (22:25 -0800)]
Fix CoreCLR build break
Commit migrated from https://github.com/dotnet/coreclr/commit/
d36c51023ef0bd58301e2f0e441f4c1901981263
Jan Kotas [Sun, 3 Mar 2019 03:21:19 +0000 (19:21 -0800)]
Update CoreRT for changes in shared partition
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
f22edcb508780dc3d6442b8233c49d60ad695225
Fawad Halim [Sun, 3 Mar 2019 03:21:39 +0000 (03:21 +0000)]
Corrected some misspellings (dotnet/coreclr#22978)
Commit migrated from https://github.com/dotnet/coreclr/commit/
3e9f456f81e215ddcd6b1fb1443fa551725a3eb1
Marek Safar [Sat, 2 Mar 2019 22:22:55 +0000 (23:22 +0100)]
Move Activator to shared partition (dotnet/coreclr#22894)
Commit migrated from https://github.com/dotnet/coreclr/commit/
7ddd038a33977b152e856448443425cbc6b591c6
Grant [Sat, 2 Mar 2019 21:55:07 +0000 (13:55 -0800)]
Use BitOperations in more callsites (CoreCLR) (dotnet/coreclr#22630)
* Missed perf improvement in EventProvider
* Add missing methods to StubEnvironment
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c0f075864df149fd477cbf07f0c606239798fc6
dotnet-maestro[bot] [Sat, 2 Mar 2019 18:55:15 +0000 (10:55 -0800)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#22968)
* Update dependencies from https://github.com/dotnet/corefx build
20190302.1
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19152.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19152.1
* Disable outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
fcfc3baa491b0ac7eb6a9cb73e3b2d46cb5929a0
Jarret Shook [Sat, 2 Mar 2019 18:54:48 +0000 (10:54 -0800)]
Revert "Revert "Improve coreclrhost.h header" (dotnet/coreclr#22955)" (dotnet/coreclr#22973)
This reverts commit dotnet/coreclr@
831cb13f1432aac09e66a8543831d3ed55b4bddf.
Commit migrated from https://github.com/dotnet/coreclr/commit/
441f049754803a0f1b40bb2cacb977df8a1425fa
Jarret Shook [Sat, 2 Mar 2019 18:51:40 +0000 (10:51 -0800)]
Revert "Improve coreclrhost.h header" (dotnet/coreclr#22955)
Commit migrated from https://github.com/dotnet/coreclr/commit/
831cb13f1432aac09e66a8543831d3ed55b4bddf
Jan Kotas [Sat, 2 Mar 2019 16:49:52 +0000 (08:49 -0800)]
Disable DOTNET_MULTILEVEL_LOOKUP in the build scripts (dotnet/coreclr#22972)
Fixes dotnet/coreclr#22971
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff53a99fb9e4c6e479a60c09a7014bfb72af4936
Marek Safar [Sat, 2 Mar 2019 13:46:27 +0000 (14:46 +0100)]
Move more Thread logic to shared partition (dotnet/coreclr#22935)
* Move more Thread logic to shared partition
* Keep the fields in runtime part for reliable layout structure
Commit migrated from https://github.com/dotnet/coreclr/commit/
ef0fde985732148eea136e90aece4ccd3d0370b5
Jan Kotas [Sat, 2 Mar 2019 04:15:28 +0000 (20:15 -0800)]
Fix CoreFX build break
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
d3e8eced36393f6c8b7e03b30acbcd33f2c284b9
Jan Kotas [Fri, 1 Mar 2019 21:59:19 +0000 (13:59 -0800)]
Fix netfx build break
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc6bba9d005edf2cc5df77795591fb2ef660055f
Aaron Robinson [Sat, 2 Mar 2019 06:53:42 +0000 (22:53 -0800)]
Support IClassFactory2 - LicenseManager use in COM activation (dotnet/coreclr#22846)
* Implement IClassFactory2
* Add test support for IClassFactory2
* Add support for testing RCW activation via IClassFactory2
Commit migrated from https://github.com/dotnet/coreclr/commit/
9e66e140f09b32694b32b98c34d8948bdf3608a3
Steve MacLean [Sat, 2 Mar 2019 04:07:35 +0000 (23:07 -0500)]
Use arcade's version of dotnet to build (dotnet/coreclr#22755)
* Use arcade dotnet
* Add cmake_msbuild.cmd
Move msbuild.cmd to cmake_msbuild.bat
Document intent that this file is only used to resolve
Windows cmake dependency on desktop msbuild.exe
Remove one instance of msbuild.cmd
* Fix inittools.cmd
* Remove spurious setup_vs_tools.cmd calls
Commit migrated from https://github.com/dotnet/coreclr/commit/
42bc2de2c63fe0c95a582e642ff97b2fe0d4bb7e
Varun Venkatesan [Sat, 2 Mar 2019 00:41:09 +0000 (16:41 -0800)]
Revert heapcount and enable CPU Groups to fix Ubuntu FPE (dotnet/coreclr#22861)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c1801e85024add717f518feb6a9caed60d54500f
Jan Kotas [Fri, 1 Mar 2019 18:08:59 +0000 (10:08 -0800)]
Fix CoreRT build breaks
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
5c911a4f16668a07ac53c4e29d8128afae6ff0f0
Juan Hoyos [Fri, 1 Mar 2019 22:00:15 +0000 (14:00 -0800)]
[master] Update dependencies from dotnet/arcade (dotnet/coreclr#22818)
* Update dependencies from https://github.com/dotnet/arcade build
20190228.3
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19128.3
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19128.3
Commit migrated from https://github.com/dotnet/coreclr/commit/
2410bfc989768a705293027db13512a2a4dd2474
dotnet-maestro[bot] [Fri, 1 Mar 2019 21:49:15 +0000 (13:49 -0800)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#22953)
* Update dependencies from https://github.com/dotnet/corefx build
20190301.4
This change updates the following dependencies
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19151.4
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19151.4
* Disable outdated tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
c3811b37b4f1633bd880a762e3759778237e7ad0
Marek Safar [Fri, 1 Mar 2019 21:16:56 +0000 (22:16 +0100)]
Remove unused code from EventSource (dotnet/coreclr#22853)
FallbackActivityId is theoretically references in CoreFX but it's under never defined FEATURE_ACTIVITYSAMPLING
and the implementation should live in CoreFX part anyway
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f4a95b3a4bc8c3a2b928eb59b7a88c5de84b4e9
Foxtrek_64 [Fri, 1 Mar 2019 21:15:23 +0000 (15:15 -0600)]
Label implements IEquatable<Label> (dotnet/coreclr#22938)
Commit migrated from https://github.com/dotnet/coreclr/commit/
919a19ce1d000049e9dd7e886760b8f03d861af9
Andy Ayers [Fri, 1 Mar 2019 21:00:52 +0000 (13:00 -0800)]
JIT: revise comment about struct-of-struct-of-field promotion (dotnet/coreclr#22952)
Fixes an oversight in dotnet/coreclr#22867.
Commit migrated from https://github.com/dotnet/coreclr/commit/
bd3a20d3c047fafbaf77a2cd56f32662b08a24dd
José Rivero [Fri, 1 Mar 2019 19:23:49 +0000 (11:23 -0800)]
Fixes: Audit missing entries in ClrEtwAll.man dotnet/coreclr#22790 (dotnet/coreclr#22795)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b290578abfe5e5526c5ed0502527942fd381945d
Andrew Au [Fri, 1 Mar 2019 01:39:08 +0000 (17:39 -0800)]
Fix issue dotnet/coreclr#22337
Commit migrated from https://github.com/dotnet/coreclr/commit/
4d7a99fb5b4a6345153ae0c80a17fd0f0cf20cd0
Vance Morrison [Fri, 1 Mar 2019 17:07:16 +0000 (09:07 -0800)]
Merge pull request dotnet/coreclr#22905 from vancem/RundownFix
Rundown profiler fix
Commit migrated from https://github.com/dotnet/coreclr/commit/
00e757cc51bc341386de95c6e9ab1b9b27574e64
Jeremy Koritzinsky [Fri, 1 Mar 2019 16:48:49 +0000 (08:48 -0800)]
Turn on IBC and enforce PGO in official and release builds. (dotnet/coreclr#22843)
* Enable pgocheck to run on python 3.
* Enable IBC optimizations in official builds and enforce PGO in release builds on platforms where pgocheck.py works.
* Only enable IBC on Windows x64/x86.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d778ad50511f5511ef799afa7fdef86ab5756e95
Morgan Brown [Fri, 1 Mar 2019 16:46:22 +0000 (08:46 -0800)]
Implement Serialization Guard
Add Serialization Guard API and consume it in CoreLib targets
Commit migrated from https://github.com/dotnet/coreclr/commit/
3c0d755886d2130e1b0db01524c140cb6c6b6fe6
Jan Vorlicek [Fri, 1 Mar 2019 16:40:55 +0000 (17:40 +0100)]
Merge pull request dotnet/coreclr#22801 from janvorli/improve-coreclrhost-header
Improve coreclrhost.h header
Commit migrated from https://github.com/dotnet/coreclr/commit/
051ec3753e416cb7fab3cf36b4f3112c7a924f1e
Jan Vorlicek [Fri, 1 Mar 2019 16:38:44 +0000 (17:38 +0100)]
Merge pull request dotnet/coreclr#22821 from am11/fix/signed-compare-and-narrowing
Fix comparison and narrowing errors reported by GCC
Commit migrated from https://github.com/dotnet/coreclr/commit/
fd448f7d0c9d5ed3beee3b0ef078f29d97f3eefa
jashook [Thu, 28 Feb 2019 22:44:15 +0000 (14:44 -0800)]
Disable tests for a clean official build
Commit migrated from https://github.com/dotnet/coreclr/commit/
a37cb15b812961e00cd1824bdeb1ec7d41d11ddf
Jan Vorlicek [Fri, 1 Mar 2019 11:10:49 +0000 (12:10 +0100)]
Fix resource stream for collectible assemblies (dotnet/coreclr#22925)
* Fix resource stream for collectible assemblies
The GetManifestResourceStream was returning a stream that didn't keep
the underlying assembly alive. For collectible assemblies, that means
that an assembly could be collected and the stream still kept,
potentially reading garbage.
The fix is to create a new stream type that stores a reference to the
underlying assembly, thus ensuring the proper lifetime management.
* Make the new stream class sealed
Commit migrated from https://github.com/dotnet/coreclr/commit/
452c40d2338bcf3f9298d316b49fbd1389a70cd5
Stephen Toub [Fri, 1 Mar 2019 09:35:45 +0000 (04:35 -0500)]
Another small tweak to fix Thread behavioral difference (dotnet/coreclr#22943)
To match existing behavior: https://github.com/dotnet/corefx/blob/dotnet/coreclr@
5dc8132370532804a5381b90e2ce87d6c52b61f6/src/Common/src/CoreLib/System/Threading/Thread.Unix.cs#L13
Commit migrated from https://github.com/dotnet/coreclr/commit/
a26aabef798c3a0c42b38c75e0a14a0cb253594f
Sung Yoon Whang [Fri, 1 Mar 2019 05:50:14 +0000 (21:50 -0800)]
Fix keyword for PinPlugAtGCTime event (dotnet/coreclr#22806)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dacab04a17e0cd4ed2b321be936f233cf75bb7e8
Levi Broderick [Fri, 1 Mar 2019 05:48:01 +0000 (21:48 -0800)]
Add Rune.DecodeUtf16 / DecodeUtf8 and friends (dotnet/coreclr#22725)
Commit migrated from https://github.com/dotnet/coreclr/commit/
484466c6344b1d7997a6ed00ce6fc7230b84a7d0
Aaron Robinson [Fri, 1 Mar 2019 03:17:13 +0000 (19:17 -0800)]
Move COM related attributes to the shared source location of Object class. (dotnet/coreclr#22942)
Commit migrated from https://github.com/dotnet/coreclr/commit/
80eece76a5d3e9c4a731633334cce37f6050b9e7
Juan Hoyos [Fri, 1 Mar 2019 02:55:34 +0000 (18:55 -0800)]
Consume optimization packages using new dependency flow system (dotnet/coreclr#22915)
* Consume optimization packages using new dependency flow system.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c659d285baed0b083fd0c25658a1a8e24a550425
Sergey Andreenko [Fri, 1 Mar 2019 02:31:44 +0000 (18:31 -0800)]
Fix CoreFX build scripts2. (dotnet/coreclr#22931)
Commit migrated from https://github.com/dotnet/coreclr/commit/
557eac638356ff47af7b92c9f349931eed5e0891
Vance Morrison [Fri, 1 Mar 2019 00:42:26 +0000 (16:42 -0800)]
change to kick off CI
Commit migrated from https://github.com/dotnet/coreclr/commit/
0fe6be13fdc45f3d2432db943a741e2e397e49d6
Tanner Gooding [Fri, 1 Mar 2019 00:28:14 +0000 (16:28 -0800)]
Removing the ExtractVector128 and InsertVector128 APIs that take an address. (dotnet/coreclr#22886)
* Removing the InsertVector128 and ExtractVector128 overloads that take an address from S.P.Corelib
* Removing the ExtractStore and InsertLoad tests.
* Fixing the PacketTracer test to use the appropriate Extract/InsertVector128 overloads
* Removing the JIT support for the Extract/InsertVector128 overloads that take an address.
Commit migrated from https://github.com/dotnet/coreclr/commit/
d06becc2658b2130c152d0f6c34a358441dd0f8e
Jan Kotas [Thu, 28 Feb 2019 23:45:26 +0000 (15:45 -0800)]
Revert "Update added types and methoddefs on ApplyMetadata (dotnet/coreclr#22617)" (dotnet/coreclr#22923)
This reverts commit dotnet/coreclr@
ee755e322dabc2fc280e2561b0fbaf6e90aedf54.
Commit migrated from https://github.com/dotnet/coreclr/commit/
f9c10f995fe65c0e7c30aa1734f7bb22c519983d
Aaron Robinson [Thu, 28 Feb 2019 23:25:17 +0000 (15:25 -0800)]
Set the MarshalByRefObject to be ComVisible and (dotnet/coreclr#22930)
a IDispatch class interface. this is being done
to ensure WinForms consumers can interact with
COM based controls.
Commit migrated from https://github.com/dotnet/coreclr/commit/
780bdacf375f031f12d7d64295521cddcca4478b
Jarret Shook [Thu, 28 Feb 2019 22:30:03 +0000 (14:30 -0800)]
Set flag in comp info to signal that a caller has >8 byte struct args (dotnet/coreclr#22775)
* Set flag in comp info to signal that a caller has >8 byte struct args
This will be used by fgCanFastTailCall to correctly determine whether an arm64
or x64 linux caller/callee can fastTailCall.
It is also a workaround to dotnet/coreclr#12468 to catch early any slot shuffling that would happen in LowerFastTailCall. Which currently assumes all parameters are one slot size.
* Address feedback
* Apply format patch
* Add comment
* apply new format patch
Commit migrated from https://github.com/dotnet/coreclr/commit/
0a29aaf5e40d36cdd23f59b2dee487cf8b926391
Swaroop Sridhar [Thu, 28 Feb 2019 22:10:46 +0000 (14:10 -0800)]
NativeLibraryTests: Platform restriction on some tests (dotnet/coreclr#22732)
NativeLibraryTests: Platform restriction on some tests
This change adds platform restrictions on two API tests:
* Change the System32 dll loading test from `msi.dll` to `uri.dll`
* Restrict the System32 dll loading test to platforms where `uri.dll` actually exists in the System32 directory.
* Disable double-free tests on Linux, because the OS call doesn't reliably fail.
Use the public version of CoreLib, since the NativeLibrary APIs are
now available.
Fixes dotnet/coreclr#22726
Commit migrated from https://github.com/dotnet/coreclr/commit/
c395a8a8e7a987000455d65efac371973d96a3c8
Stephen Toub [Thu, 28 Feb 2019 21:44:26 +0000 (16:44 -0500)]
Fix DumpAsync to understand ContinuationWrapper (dotnet/coreclr#22913)
Continuations created while the debugger is attached or certain EventSource events are enabled end up getting wrapped in an extra ContinuationWrapper object that carries some additional information. DumpAsync currently isn't unwrapping these but should. This just teaches it to look for a known field name so that it can "see through" these wrappers while following async "stacks".
Commit migrated from https://github.com/dotnet/coreclr/commit/
3a0367c75a9b5cebbcc2f2c9609aa05536ed921b
Stephen Toub [Thu, 28 Feb 2019 21:42:27 +0000 (16:42 -0500)]
Fix GetApartmentState value on Unix to be Unknown (dotnet/coreclr#22928)
* Fix GetApartmentState value on Unix to be Unknown
The code in corefx is returning ApartmentState.Unknown on Unix. This new coreclr implementation should do the same.
* Fix visibility on TrySetApartmentStateUnchecked
Commit migrated from https://github.com/dotnet/coreclr/commit/
0a93b5136621040b93b9f805e26e7d27d11dc955