Table cell's anonymous wrappers are left in the tree, impacting our layout
https://bugs.webkit.org/show_bug.cgi?id=7180

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/table-switch-cell-position-bad-layout-expected.html
       fast/table/table-switch-cell-position-bad-layout.html

This patch implements cell's anonymous wrapper removal at detach time.

Trimming the render tree when we remove objects from it would be more complex
to generalize as several objects override the behavior to do their own clean-ups.
This would also open more potential for programming errors.

This change is limited to table cells' as a simple step towards fixing bug 52123
and more generally eliminate some anonymous wrappers from the tree at detach time.

* dom/Node.cpp:
(WebCore::Node::detach):
Patched detach to call destroyAndCleanupAnonymousWrappers. The Document does not need
to clean up any anonymous wrappers on detach.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
Added this method to wrap destroy() call and trim the render tree. To avoid slowing down
detach in some cases, added a fast path.

* rendering/RenderObject.h: Added destroyAndCleanupAnonymousWrappers.

LayoutTests:

* fast/table/table-switch-cell-position-bad-layout-expected.html: Added.
* fast/table/table-switch-cell-position-bad-layout.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ASSERT (and crash) with dynamically moved <font-face>
https://bugs.webkit.org/show_bug.cgi?id=64839

Reviewed by Antti Koivisto.

Source/WebCore:

Reset the style declaration when rmeoving the font-face element from the document.

Test: svg/custom/font-face-move.svg

* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::removedFromDocument):

LayoutTests:

* svg/custom/font-face-move-expected.txt: Added.
* svg/custom/font-face-move.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix some warnings encountered during the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=78911

Reviewed by Xan Lopez.

Source/WebCore:

No new tests. These are just fixes for warnings.

* page/GestureTapHighlighter.cpp: Avoid using potentially signed operations on
a size_t type. Use size_t for iterating over members of a vector.
* platform/graphics/texmap/TextureMapperBackingStore.cpp: Use size_t where necessary.
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded): Ditto.
* platform/graphics/texmap/TextureMapperLayer.cpp: Ditto.
(WebCore::TextureMapperLayer::computeTransformsRecursive): Ditto.
(WebCore::TextureMapperLayer::paintSelfAndChildren): Ditto.
(WebCore::TextureMapperLayer::intermediateSurfaceRect): Ditto.

Source/WebKit2:

* UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView): Initialize a new member of the loader client struct.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

perf-o-matic needs model unit tests
https://bugs.webkit.org/show_bug.cgi?id=78885

Reviewed by Adam Barth.

Added unit tests for models.py.

Also renamed modelFromNumericId to model_from_numeric_id and moved set_persitent_cache and get_persistent_cache
from controller to PersistentCache.set_cache and PersistentCahce.set_cache respectively.

* Websites/webkit-perf.appspot.com/controller.py:
(cache_manifest):
(CachedManifestHandler.get):
(cache_dashboard):
(CachedDashboardHandler.get):
(cache_runs):
(CachedRunsHandler.get):
* Websites/webkit-perf.appspot.com/create_handler.py:
(CreateHandler._create_builder):
(CreateHandler._create_builder.execute):
* Websites/webkit-perf.appspot.com/models.py:
(create_in_transaction_with_numeric_id_holder):
(model_from_numeric_id):
(Builder):
(Builder.create):
(Builder.update_password):
(Builder._hashed_password):
(TestResult.key_name):
(ReportLog.get_value):
(ReportLog._integer_in_payload):
(ReportLog):
(ReportLog.timestamp):
(PersistentCache):
(PersistentCache.set_cache):
(PersistentCache.set_cache.execute):
(PersistentCache.get_cache):
* Websites/webkit-perf.appspot.com/models_unittest.py: Added.
(HelperTests):
(HelperTests.setUp):
(HelperTests.tearDown):
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_model_from_numeric_id):
(HelperTests.test_model_from_numeric_id.execute):
(BuilderTests):
(BuilderTests.setUp):
(BuilderTests.tearDown):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(ReportLog):
(ReportLog.setUp):
(ReportLog.tearDown):
(ReportLog._create_log_with_payload):
(ReportLog.test_parsed_payload):
(ReportLog.test_get_value):
(ReportLog.test_results):
(ReportLog.test_builder):
(ReportLog.test_build_number):
(ReportLog.test_webkit_revision):
(ReportLog.chromium_revision):
(PersistentCacheTests):
(PersistentCacheTests.setUp):
(PersistentCacheTests.tearDown):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.post):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Refactor video drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76720

Patch by Tim Dresser <tdresser@chromium.org> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

CCVideoLayerImpl no longer handles drawing itself, but produces a list of CCVideoDrawQuads.
These quads are then drawn by LayerRendererChromium.

CCLayerImpl::willDraw(LayerRendererChromium*) is called directly before appendQuads.
CCLayerImpl::didDraw() is called directly after all drawing has been completed.
CCLayerImpl::draw has been removed.

willDraw and didDraw are used to handle interaction with the VideoFrameProvider
in CCVideoLayerImpl. willDraw gets a frame from the VideoFrameProvider, and
didDraw returns it.

A unit test has been added: CCLayerTreeHostImplTest.didDrawCalledOnAllLayers.
This test ensures that CCLayerImpl::didDraw() is called on all layers,
including layers on different render surfaces.

As this was a refactor, no other tests were added.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore):
(WebCore::LayerRendererChromium::drawSingleTextureVideoQuad):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture):
(WebCore::LayerRendererChromium::copyFrameToTextures):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::didDraw):
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::drawLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::textures):
(WebCore::CCVideoDrawQuad::frame):
(WebCore::CCVideoDrawQuad::format):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::providerMutex):
(WebCore::CCVideoLayerImpl::provider):
(Texture):

Source/WebKit/chromium:

CCLayerTreeHostImplTest.didDrawCalledOnAllLayers ensures that
CCLayerImpl::didDraw() is called on all layers, including layers
on different render surfaces.

* tests/CCLayerTreeHostImplTest.cpp:
(DidDrawCheckLayer):
(WebKit::DidDrawCheckLayer::create):
(WebKit::DidDrawCheckLayer::didDraw):
(WebKit::DidDrawCheckLayer::didDrawCalled):
(WebKit::DidDrawCheckLayer::DidDrawCheckLayer):
(WebKit):
(WebKit::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Allow printing scaled pages in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78823

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable scale option in print
dialog.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
manual scale to 1.
(WebKit::WebPrintOperationGtk::rotatePageIfNeeded): Renamed and
moved the needs rotate check here as an early return.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Scale the
page according to the manual scale factor.
(WebKit::WebPrintOperationGtk::renderPage): Move rotatePage to
prepareContextToDraw.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Include TestShellLinux.cpp in the build for Android
https://bugs.webkit.org/show_bug.cgi?id=78865

Reviewed by Eric Seidel.

Android will be re-using the TestShellLinux.cpp file. I already
added this r104033, but it seems to have gotten lost in the
recent refactorings.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Allow printing multiple copies in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78805

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable multiple copies and
collate options in print dialog.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Initialize number of
collated and uncolated copies done and total.
(WebKit::PrintPagesData::collatedCopiesLeft): Helper function that
returns the number of collated copies left to do.
(WebKit::PrintPagesData::uncollatedCopiesLeft): Helper function
that returns the number of uncollated copies left to do.
(WebKit::PrintPagesData::copiesLeft): Helper function
that returns the number of collated or uncollated copies left to
do.
(WebKit::PrintPagesData::incrementPageSequence): Do not finish the
print if there are uncollated copies left, and do not increment
sheet number if there are collated copies left.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualCopies to 1 and m_manualCollateCopies to false.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed Chromium rebaseline after r107971.

* platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.txt: Added.
* platform/chromium-win-vista/tables/mozilla/bugs: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Unreviewed, update chromium pixel baselines for r108079

* fast/borders/border-mixed-alpha-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-mixed-alpha-expected.txt.
* fast/borders/only-one-border-with-width-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/only-one-border-with-width-expected.txt.
* platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png:
* platform/chromium-mac-snowleopard/fast/borders/only-one-border-with-width-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/color-leakage-expected.png: Added.
* platform/chromium-win/fast/borders/border-mixed-alpha-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
* platform/chromium-win/fast/borders/only-one-border-with-width-expected.png: Copied from LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png.
* platform/chromium-win/fast/css/color-leakage-expected.png:
* platform/mac/fast/borders/border-mixed-alpha-expected.txt: Removed.
* platform/mac/fast/borders/only-one-border-with-width-expected.txt: Removed.
* platform/qt/fast/borders/border-mixed-alpha-expected.txt: Removed.
* platform/qt/fast/borders/only-one-border-with-width-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Allow printing pages in reverse order in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78799

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable printing in reverse
order option in print dialog.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and lastPagePosition depending on whether printing is in reverse
order or not.
(WebKit::PrintPagesData::incrementPageSequence): Use a negative
increment step when printing in reverse order. Fix page
incrementing when printing only odd/even pages broken in previous
commit due to merge conflicts.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
reverse printing to false.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Allow printing only odd/even pages in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78793

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable print odd/even pages
option in print dialog.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Add lastPagePosition and
initialize it depending on the page set.
(WebKit::PrintPagesData::incrementPageSequence): Use 2 step
increment when printing only odd/even pages.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
m_manualPageSet to GTK_PAGE_SET_ALL.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Crash at WebCore::SVGUseElement::expandSymbolElementsInShadowTree
https://bugs.webkit.org/show_bug.cgi?id=77639

Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Fix a SVG crash in Release builds, although it still crashes in Debug builds.
The crash occurred when an SVG use element attempted to reference a style element while the file
contained an error causing the error banner to display. The fix is to prevent SVGUseElement
from recalculating style during tree building and return immediately when style is recalculated and
the tree is building.

Test: svg/custom/use-referencing-style-crash.svg

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::willRecalcStyle): Return false if the tree is being built.
(WebCore::SVGUseElement::didRecalcStyle): Check and return if the tree
is being built and we are not yet ready for style update.

LayoutTests:

Fix a SVG crash in Release builds, although it still crashes in Debug builds.
This test is to verify no crash in Release builds, while expectations/Skipped
are added for Debug builds. Bug 77764 tracks the Debug fix.

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* svg/custom/use-referencing-style-crash-expected.txt: Added.
* svg/custom/use-referencing-style-crash.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r108077.
http://trac.webkit.org/changeset/108077
https://bugs.webkit.org/show_bug.cgi?id=78390

it broke compilation.

* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

chrome.dll!WebCore::SVGTRefElement::updateReferencedText ReadAV@NULL (e85cb8e140071fa7790cad215b0109dc)
https://bugs.webkit.org/show_bug.cgi?id=74858

Patch by Florin Malita <fmalita@google.com> on 2012-02-17
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Tests: svg/custom/tref-remove-target-crash-expected.svg
       svg/custom/tref-remove-target-crash.svg

Add a DOMNodeRemovedFromDocumentEvent listener to detect when the target element is removed. Upon removal,
cleanup all listeners and re-activate the pending resource to attach if the referenced ID is added
at a later time programmatically. Also move the DOMSubtreeModifiedEvent listener from the parent to
the target element to simplify the implementation and reduce the scope.

* svg/SVGTRefElement.cpp:
(WebCore::TargetListener::create):
(WebCore::TargetListener::cast):
(WebCore::TargetListener::clear):
(WebCore::TargetListener::TargetListener):
(WebCore::TargetListener::operator==):
(WebCore::TargetListener::handleEvent):
(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):
* svg/SVGTRefElement.h:

LayoutTests:

* svg/custom/tref-remove-target-crash-expected.svg: Added.
* svg/custom/tref-remove-target-crash.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the build after r108077.

* inspector/CodeGeneratorInspector.py:
(RawTypes.Any.generate_validate_method):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Allow printing multiple pages per sheet in WebKit2 for printers that don't support it
https://bugs.webkit.org/show_bug.cgi?id=78715

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialogUnix): Enable multiple pages per
sheet options in print dialog.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Initialize sheetNumber
and numberOfSheets. Move pagePosition to WebPrintOperationGtk.
(WebKit::PrintPagesData::incrementPageSequence): Increment current
sheet and page position.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk):
(WebKit::WebPrintOperationGtk::currentPageIsFirstPageOfSheet):
Helper function to check whether current pages is the first one of
the current sheet.
(WebKit::WebPrintOperationGtk::currentPageIsLastPageOfSheet):
Helper function to check whether current pages is the last one of
the current sheet.
(WebKit::WebPrintOperationGtk::getRowsAndColumnsOfPagesPerSheet):
Returns the number of rows and columns of pages per sheet.
(WebKit::WebPrintOperationGtk::getPositionOfPageInSheet): Returns
the row and column number of the current page in the current sheet.
(WebKit::WebPrintOperationGtk::prepareContextToDraw): Translate,
scale and rotate accordingly to render every page in the right
place of the sheet.
(WebKit::WebPrintOperationGtk::renderPage): Call
prepareContextToDraw() before drawing the page.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
(WebKit::WebPrintOperationGtk::setNumberOfPagesToPrint):
(WebKit::WebPrintOperationGtk::pagePosition):
(WebKit::WebPrintOperationGtk::setPagePosition):
(WebKit::WebPrintOperationGtk::numberUp):
(WebKit::WebPrintOperationGtk::numberUpLayout):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Avoid using a transparency layer for rgba() border drawing when possible
https://bugs.webkit.org/show_bug.cgi?id=63176

Reviewed by Dan Bernstein.

The non-radiused border drawing code would use a transparency layer
when drawing any one or more borders with alpha colors. However,
we only need to use a transparency layer when there is a corner
join between the borders being rendered with any one color,
so add a utility function includesAdjacentEdges() that can tell us
that, and use it to avoid making extraneous transparency layers.

Optimization only, no new tests.

* rendering/RenderBoxModelObject.cpp:
(WebCore::includesAdjacentEdges):
(WebCore):
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2012-02-17  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: Qt minimal build fix.

        * inspector/InjectedScript.h:
        (WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-17
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: hide color picker on selected node update.
https://bugs.webkit.org/show_bug.cgi?id=78896

Reviewed by Vsevolod Vlasov.

* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.get visible):
(WebInspector.Spectrum.prototype.toggle):
(WebInspector.Spectrum.prototype.show):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: check undo-redo boundaries based on current action index, not history size.
https://bugs.webkit.org/show_bug.cgi?id=78895

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Tests: inspector/elements/perform-undo-undo.html
       inspector/styles/perform-undo-perform-of-mergable-action.html

* inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::perform):

LayoutTests:

* inspector/elements/perform-undo-undo-expected.txt: Added.
* inspector/elements/perform-undo-undo.html: Added.
* inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Added.
* inspector/styles/perform-undo-perform-of-mergable-action.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, rolling out r108071.
http://trac.webkit.org/changeset/108071
https://bugs.webkit.org/show_bug.cgi?id=77155

chromium-mac compilation failed

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

* public/platform/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
* src/Extensions3DChromium.cpp:
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
* src/GraphicsContext3DPrivate.h:
(WebCore):
* tests/FakeWebGraphicsContext3D.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, skipping 2 new test failures on GTK.

* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspecter: Unreviewed. Adjust expectation for script-formatter-console.html

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] GL_CHROMIUM_gpu_memory_manager extension
https://bugs.webkit.org/show_bug.cgi?id=77155

Patch by Michal Mocny <mmocny@google.com> on 2012-02-17
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
(GpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore::Extensions3DChromium::GpuMemoryAllocationChangedCallbackCHROMIUM::~GpuMemoryAllocationChangedCallbackCHROMIUM):
(Extensions3DChromium):

Source/WebKit/chromium:

* public/platform/WebGraphicsContext3D.h:
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebKit::WebGraphicsContext3D::WebGraphicsMemoryAllocationChangedCallbackCHROMIUM::~WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
(WebCore):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
(WebCore):
(WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
* src/GraphicsContext3DPrivate.h:
(WebCore):
* tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::setMemoryAllocationChangedCallbackCHROMIUM):
(FakeWebGraphicsContext3D):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[EFL] Unreviewed, adapt to the changes introduced in r107973.

SVN r107973 moved some libsoup feature initialization code to
WebCore, but only changed the GTK+ bits in WebKit.

* ewk/ewk_main.cpp:
(_ewk_init_body): Do not initialize the content sniffer and the
decoder here, the initialization is now done in WebCore.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78893

Reviewed by Gustavo Noronha Silva.

And it's not emitted anynmore when the print dialog has been
cancelled. Since it's not possible to know whether the print
dialog was cancelled or not, the enum WebKitPrintOperationResponse
has been added, with Print and Cancel values, and it's used as
return value of webkit_print_operation_run_dialog().

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init): Rename done as finished.
(webkitPrintOperationRunDialogUnix): Return a
WebKitPrintOperationResponse instead of bool.
(webkitPrintOperationRunDialogWin32): Ditto.
(drawPagesForPrintingCompleted): Emit finished instead of done.
(webkitPrintOperationRunDialogForFrame): Do not emit finished if
the dialog was cancelled and return a WebKitPrintOperationResponse.
(webkit_print_operation_run_dialog): Return
WebKitPrintOperationResponse.
* UIProcess/API/gtk/WebKitPrintOperation.h: Add
WebKitPrintOperationResponse enum.
* UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Check whether the dialog has been
cancelled or not and connect to finish when the print operation is
in progress to release the print operation object when printing
finishes.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
WebKitPrintOperationResponse symbol.
* UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrintFinished): Use finished instead of done.
(testPrintOperationPrint): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Add webkit_print_operation_print() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76536

Reviewed by Gustavo Noronha Silva.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationPrintPagesForFrame): Helper function to call
WebPageProxy::drawPagesForPrinting using the given
GtkPrintSettings and GtkPageSetup.
(webkitPrintOperationRunDialogForFrame): Use
webkitPrintOperationPrintPagesForFrame().
(webkit_print_operation_print): Print directly using current
GtkPrintSettings and GtkPageSetup without showing the print
dialog.
* UIProcess/API/gtk/WebKitPrintOperation.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrintLoadChanged):
(testPrintOperationPrintDone):
(testPrintOperationPrintPrinter):
(testPrintOperationPrint):
(beforeAll):
(afterAll):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[CMake, EFL] Unreviewed, fix the build when building with
SHARED_CORE=ON after r107820.

RunLoopEfl.cpp has not been upstreamed yet, and building only
RunLoop.cpp created an .so with some missing, unimplemented
symbols. The BlackBerry port seems to be in the same situation.

The best solution for now is to build RunLoop.cpp only on the
WinCE port.

* CMakeLists.txt: Remove RunLoop.cpp from the list of files to build.
* PlatformWinCE.cmake: Add RunLoop.cpp to the list of files to build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, fix the build with ENABLE(DEVICE_ORIENTATION) after
r107518. The EFL EWS bot doesn't enable that flag, so the breakage
was not spotted earlier.

* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: a bit of color picker polish
https://bugs.webkit.org/show_bug.cgi?id=78892

- Fixed computed style swatch
- Removed color: caption
- Rendered value as source code, user-selectable
- Removed scroller gap

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):
* inspector/front-end/Spectrum.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype._resetMouseDownElement):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
* inspector/front-end/elementsPanel.css:
(.spectrum-container):
(.spectrum-display-value):
(.spectrum-range-container):
* inspector/front-end/popover.css:
(.popover .content.fixed-height):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Chromium DEPS roll

* DEPS: from 122122 to 122498

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, disable video build on EFL until it can be
supported by EFL build bot.

* Scripts/build-webkit:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: color picker does not allow changing the color.
https://bugs.webkit.org/show_bug.cgi?id=78886

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype.setCanShrink):
(WebInspector.Popover.prototype._positionElement):
* inspector/front-end/Settings.js:
* inspector/front-end/Spectrum.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: new image preview has poorly positioned popover arrow.
https://bugs.webkit.org/show_bug.cgi?id=78884

Reviewed by Vsevolod Vlasov.

* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._positionElement):
* inspector/front-end/utilities.js:
(Element.prototype.boxInWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #34 of N.  Restore/move following tests back in BUGCR9950
group with a WIN exception for an IMAGE failure.

WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE
WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: enable "Single click CSS editing" experiment by default.
https://bugs.webkit.org/show_bug.cgi?id=78881

Reviewed by Vsevolod Vlasov.

* inspector/front-end/elementsPanel.css:
(.styles-section .properties .enabled-button):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: split innerUpdate into rebuildUpdate and refreshUpdate, make computed styles load lazily.
https://bugs.webkit.org/show_bug.cgi?id=78827

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._validateNode):
(WebInspector.StylesSidebarPane.prototype._styleSheetOrMediaQueryResultChanged):
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylesSidebarPane.prototype._attributesRemoved):
(WebInspector.StylesSidebarPane.prototype._styleInvalidated):
(WebInspector.StylesSidebarPane.prototype._innerRefreshUpdate):
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._nodeStylesUpdatedForTest):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):
(WebInspector.ComputedStyleSidebarPane.prototype.expand):
(WebInspector.StylePropertyTreeElement.prototype):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.waitForStyles):
* inspector/styles/undo-add-property.html:
* inspector/styles/undo-change-property.html:
* inspector/styles/updates-during-dom-traversal.html:
* inspector/styles/updates-throttled.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #32 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

* platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
* platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
* platform/chromium-win/tables/mozilla/core/row_span-expected.png:
* platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Implement zoom in/out in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75253

Reviewed by Gustavo Noronha Silva.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowUpdateZoomActions):
(webViewZoomLevelChanged):
(zoomInCallback):
(zoomOutCallback):
(browser_window_init):
(browserWindowConstructed):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt][WK2] Allow partial updates
https://bugs.webkit.org/show_bug.cgi?id=78824

Source/WebCore:

BitmapTextureGL should not zero-fill the textures when resetting.
This was needed in the previous buffer management system, where texture were not completely
filled by the backing store.

Reviewed by Simon Hausmann.

No new behavior.

* platform/graphics/opengl/TextureMapperGL.cpp:
(BitmapTextureGL):
(WebCore::texSubImage2DResourceSafe):
(WebCore):
(WebCore::BitmapTextureGL::reset):

Source/WebKit2:

Instead of using UpdateInfo to fill the entire tile's texture, we use it as a patch that
contains only the dirty rectangle of the current paint. This requires a lot less memory
for small updates, for example when typing a text in an input field.
This shows a significant reduction in overhead when testing on Mac with Instruments.

Reviewed by Simon Hausmann.

* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit):
(WebKit::LayerBackingStore::updateTile):
* UIProcess/qt/LayerBackingStore.h:
(LayerBackingStoreTile):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::updateTileForLayer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Adam Roben.

Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
Size the web view before running the test, not when dumping.
All platforms handle this correctly now.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
(sizeWebViewForCurrentTest):
(runTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Fix GTK+ build after r108003.

* Source/autotools/symbols.filter: Add missing symbol.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #33 of N. See also bug 78219.

* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Forms] Integrate InputType::dispatchChangeEventInResponseToSetValue into InputType::setValue
https://bugs.webkit.org/show_bug.cgi?id=78873

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-17
Reviewed by Kent Tamura.

This patch moves event dispatch logic to InputType and TextFieldInputType from HTMLInputElement
and merge dispatchChangeEventInResponseToSetValue to setValue.

No new tests. No change in behavior.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Move dispatch logic to InputType and TextFieldInput.
* html/InputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
* html/InputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.
(WebCore::InputType::setValue): Move code from dispatchChangeEventInResponseToSetValue.
* html/TextFieldInputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
* html/TextFieldInputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.
(WebCore::TextFieldInputType::setValue): Move code from dispatchChangeEventInResponseToSetValue. Stop dispatching event in InputType::setValue.
* html/HTMLTextFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent to public from protected for accessing from InputType class.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2012-02-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mac build fix after r108047.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Removing the last presentation attribute should result in a null attributeStyle().
<http://webkit.org/b/78812>

Reviewed by Antti Koivisto.

If the collectStyleForAttribute() pass in updateAttributeStyle() doesn't encounter any
respected presentation attributes, set a null attributeStyle() instead of an empty one.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #31 of N. Any reasons for the MAC exception have been lost
in time, like tears in rain. Remove the MAC exception, update all pixel results.

* platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: use static counters for estimation of allocated Documents, Nodes and JS EventListeners
https://bugs.webkit.org/show_bug.cgi?id=78825

Introduced static counters of allocated Documents, Nodes and JS EventListeners.
Their values are displayed on the Timeline panel.

Reviewed by Pavel Feldman.

* CMakeLists.txt:
* English.lproj/localizedStrings.js:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorCounters.cpp: Added.
(WebCore):
(WebCore::InspectorCounters::counterValue):
* inspector/InspectorCounters.h: Added.
(WebCore):
(InspectorCounters):
(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getDocumentCount):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed, GTK rebaseline after r108034.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #30 of N.  Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

* platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-linux/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
* platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-win/tables/mozilla/core/misc-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rollout r107952 removed fast/events/related-target-focusevent.html so
lint complains about it in test_expectations.txt, remove it's expectation line.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Correct a misleading comment regarding string delimiters in CSS parsing.
https://bugs.webkit.org/show_bug.cgi?id=78521

Reviewed by Zoltan Herczeg.

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. r107980 rolled-out, fast/js/stack-trace.html was removed so lint
complains about it in test_expectations.txt, remove it's expectation line.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

* GNUmakefile.list.am: Add missing files to the build and change spaces to tabs.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Make sure print operation object is alive until printing finishes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78829

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Adopt the WebKitPrintOperation
reference so that it's released when the callback finishes.
(webkitPrintOperationRunDialogForFrame): Pass a reference of
WebKitPrintOperation to the printing callback.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[GTK] Make install is broken when building without --enable-gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=78828

Reviewed by Martin Robinson.

* gtk/generate-gtkdoc:
(rebase_installed_docs): Check documentation has been generated
before trying to rebase it.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode

The instance variable HTMLStyleElement::m_isRegisteredWithScopingNode is only
referenced from within ENABLE(STYLE_SCOPED)-guarded code. We should add this
guard around its declaration.

* html/HTMLStyleElement.h:
(HTMLStyleElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add JSC code profiling support on Linux x86
https://bugs.webkit.org/show_bug.cgi?id=78871

Reviewed by Gavin Barraclough.

We don't unwind the stack for now as we cannot guarantee all the
libraries are compiled without -fomit-frame-pointer.

* tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
* tools/CodeProfiling.cpp:
(JSC):
(JSC::profilingTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rolling out r107980, because it broke 32 bit platforms.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):

LayoutTests:

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Removed.
* fast/js/stack-trace-expected.txt: Removed.
* fast/js/stack-trace.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
https://bugs.webkit.org/show_bug.cgi?id=78875

Reviewed by Kentaro Hara.

Source/WebCore:

Since v8 does not assume that we do 'new WebkitShadowRoot(host)', a wrapper object for new WebKitShadowRoot(host)
was saved in DOMObject storage instead of DOMNode storage.

CodeGenerator should handle with DOMNode correctly to solve the problem.

Test: fast/dom/shadow/shadow-root-new.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):

LayoutTests:

Skip non-chromium ports since SHADOW_DOM flag is not enabled in their ports.

* fast/dom/shadow/shadow-root-new.html: Added.
* fast/dom/shadow/shadow-root-new-expected.txt: Added.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(WebCore):
(BlurEventDispatchMediator):
* dom/EventFactory.in:
* dom/FocusEvent.cpp: Removed.
* dom/FocusEvent.h: Removed.
* dom/FocusEvent.idl: Removed.
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
* dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/UIEvent.h:
(FocusInEventDispatchMediator):
(WebCore):
(FocusOutEventDispatchMediator):
* page/DOMWindow.idl:

LayoutTests: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html:
* fast/events/related-target-focusevent-expected.txt: Removed.
* fast/events/related-target-focusevent.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #29 of N.  Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.

* platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
* platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Another fix for viewport tests

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): When we don't parse a number, we could either be
trying to parse junk, which returns NaN, or we could get an empty string,
which returns 0, so we need to account for that in the assert.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Bundle page scale factor and limits in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78762

Setting page scale factor and its limits in separate methods
may cause clamping bugs if one of them makes it to the
impl thread before the other.  Change the API to bundle them together,
which matches the existing impl-side interface.

Patch by Alexandre Elias <aelias@google.com> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

No new tests (API change will disallow this type of bug).

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScaleFactorAndLimits):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #26 of N. Color profiles are not supported in chrome win/linux.
Retain the FAIL MISSING expectation, update the failing win/linux pixel result.

* platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #28 of N.  Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.

* platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
* platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
* platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png: Added.
* platform/chromium-win/fast/repaint/clipped-relative-expected.png:
* platform/chromium-win/fast/repaint/selected-replaced-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Add method to WebViewImpl to extract zoom/scroll params for gesture events on touch devices
https://bugs.webkit.org/show_bug.cgi?id=72909

Patch by Varun Jain <varunjain@google.com> on 2012-02-16
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(std):
(WebKit):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::widenRectWithinPageBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebFrameTest.cpp:
(WebKit):
(WebKit::TEST_F):
* tests/data/get_scale_for_auto_zoom_into_div_test.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #25 of N.  Chrome MAC rendering was previously incorrect, and
still is incorrect/weird: update test_expectations.txt with IMAGE failure.

* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-mac-leopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] LayerChromium::setNeedsDisplay does not apply contents scale correctly
https://bugs.webkit.org/show_bug.cgi?id=77464

Source/WebCore:

Use bounds() instead of contentBounds() to calculate the region to mark
as needing painting in LayerChromium::setNeedsDisplay(). contentBounds()
includes contents scale, while bounds() does not.

Since this change also means that TiledLayerChromium::setNeedsDisplayRect() is
given an unscaled rectangle, modify that function to scale the rectangle before
using it to invalidate the underlying tiles.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Tests: New tests added to LayerChromium and TiledLayerChromium unit tests.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setNeedsDisplay):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setNeedsDisplayRect):

Source/WebKit/chromium:

Added a new unit test for TiledLayerChromium to verify its invalidation behavior when
the contents scale changes. Also enhance and existing unit test for LayerChromium to
verify the paint rectangle dimensions instead just checking that it is not empty.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.

* tests/LayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::setNeedsDisplayRect):
(FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::lastNeedsDisplayRect):
(WTF::TEST):
(WTF):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #27 of N.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=78065
[Chromium] Should eliminate WebTextCheckingResult legacy APIs

Reviewed by Kent Tamura.

Removed unused legacy members.

* public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):
* src/AssertMatchingEnums.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Lazy init for DefaultAudioDestinationNode and OfflineAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=76509

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-16
Reviewed by Eric Seidel.

No new tests required.

* webaudio/AudioDestinationNode.h:
* webaudio/AudioNode.h:
(WebCore::AudioNode::sampleRate):
* webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
* webaudio/DefaultAudioDestinationNode.h:
* webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
* webaudio/OfflineAudioDestinationNode.h:
(WebCore::OfflineAudioDestinationNode::sampleRate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Refactoring] Remove location from NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=78796

Reviewed by Hajime Morita.

This is a simple refactoring to remove m_location from NodeRenderingContext.
TreeLocation is merged into AttachPhase like the following.
    LocationUndertermined -> Calculating
    LocationNotInTree -> AttachingNotInTree
    LocationLightChild -> AttachingStraight / AttachingNotDistributed / AttachingDistributed
    LocationShadowChild -> AttachingStraight / AttachingShadowChild / AttachingFallback

We have renamed the enum items of AttachPhase, because not only <content> but also
<shadow> will use the phases. Basically these words are taken from Shadow DOM spec.
'Calculating' means NodeRenderingContext is used not for attaching but for calculating RenderObject.

No new tests, no change in behavior.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ENABLE_INTERPRETER should be ENABLE_CLASSIC_INTERPRETER
https://bugs.webkit.org/show_bug.cgi?id=78791

Rubber stamped by Oliver Hunt.

Just a renaming, nothing more. Also renamed COMPUTED_GOTO_INTERPRETER to
COMPUTED_GOTO_CLASSIC_INTERPRETER.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/AbstractPC.h:
(AbstractPC):
* interpreter/CallFrame.h:
(ExecState):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(Interpreter):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(NativeExecutable):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSGlobalData):
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Run sort-Xcode-project-file.

* WebCore.xcodeproj/project.pbxproj: Sorted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Another build fix for viewport tests

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): We now return NaN instead of 0 when we fail to
parse a number using charactersToFloatIgnoringJunk, so we need to assert that
we have NaN rather than 0.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] pull third_party/gold to fix linux build
https://bugs.webkit.org/show_bug.cgi?id=78842

Reviewed by Tony Chang.

The Chrome build now depends on third_party/gold also being checked out.

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #24 of N.  Differences in rendered image extents on chrome
LINUX, WIN compared to chrome MAC.  Retain that fact in test_expectations.txt.

* platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: [chromium] Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=78841

WebDatabase now delegates this function entirely to DatabaseTracker,
a new closeDatabasesImmediately() has been added for that purpose. That
method posts tasks to the appropiate context thread for each database
instance that should be closed immediately.

The DatabaseTracker getAllOpenDatabases() method has been removed from
the chromium impl because it's unsafe, refs cannot be safely taken on
AbstractDatabase instances in the tracker's collection of open databases.

Add a message to the console log when a database is forcibly closed.

Transactions initiated on a database instance that has been forcibly
closed complete with a transaction error callback.

This is part of resolving http://crbug.com/98939

Reviewed by David Levin.

No new layout tests, there is no common code way to closeImmediately.
We have coverage for this in py automation tests.

* platform/sql/SQLiteDatabase.cpp:
The closeImmediately code path can result in the underlying sqlite3 handle being
closed earlier than usual and trip some assertions. Updated the assertions to no
longer trigger in this early close case.
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::setMaximumSize):
* platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::sqlite3Handle):

* storage/Database.cpp:
(WebCore::Database::closeImmediately): Modified to only be called on the context thread and to log a console message.
(WebCore::Database::changeVersion): Use the private runTransaction helper method.
(WebCore::Database::transaction): Pass a new param required by the runTransaction helper.
(WebCore::Database::readTransaction): Ditto.
(WebCore::callTransactionErrorCallback): Used to defer invocation of the error callback.
(WebCore::Database::runTransaction): Modified to detect when the database has been closed, and
to invoke the error callback in that case. This also avoids creating a reference cycle between
a newly created transaction and the database that previously existed due to a transction being
added and never removed from the Q while in this state.
* storage/Database.h:
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::closeImmediately): Modified to only be called on the context thread and to log a console message.
* storage/DatabaseTracker.h:

* storage/chromium/DatabaseTrackerChromium.cpp:
Posts tasks to the appropiate context thread for execution without bumping AbstractDatabase refcounts.
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::performTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeDatabasesImmediately):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):

Source/WebKit/chromium: Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=78841

WebDatabase now delegates this function entirely to DatabaseTracker.
This is part of resolving http://crbug.com/98939

Reviewed by David Levin.

* src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #23 of N.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Chromium] Occlusion tracking with CSS filters
https://bugs.webkit.org/show_bug.cgi?id=77498

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

The new CSS filter support within the compositor changes how
occlusion tracking needs to function. A filter can change the
alpha value of pixels, making an otherwise opaque pixel no
longer so. Secondly, a filter may move color values around
on a surface, which can cause otherwise occluded areas to
become visible and require painting.

New unit tests: CCLayerTreeHostTest.cpp

Tests: compositing/culling/filter-occlusion-alpha-large.html
       compositing/culling/filter-occlusion-alpha.html
       compositing/culling/filter-occlusion-blur-large.html
       compositing/culling/filter-occlusion-blur.html

* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setFilters):
(WebCore::RenderSurfaceChromium::filters):
(WebCore::RenderSurfaceChromium::setNearestAncestorThatMovesPixels):
(WebCore::RenderSurfaceChromium::nearestAncestorThatMovesPixels):
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::enterTargetRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setNearestAncestorThatMovesPixels):
(WebCore::CCRenderSurface::nearestAncestorThatMovesPixels):
(CCRenderSurface):
* platform/graphics/filters/FilterOperation.h:
(FilterOperation):
(WebCore::FilterOperation::affectsOpacity):
(WebCore::FilterOperation::movesPixels):
(WebCore::ReferenceFilterOperation::affectsOpacity):
(WebCore::ReferenceFilterOperation::movesPixels):
(ReferenceFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::affectsOpacity):
(BasicComponentTransferFilterOperation):
(WebCore::BlurFilterOperation::affectsOpacity):
(WebCore::BlurFilterOperation::movesPixels):
(BlurFilterOperation):
(WebCore::DropShadowFilterOperation::affectsOpacity):
(DropShadowFilterOperation):
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::hasFilterThatAffectsOpacity):
(WebCore):
(WebCore::FilterOperations::hasFilterThatMovesPixels):
* platform/graphics/filters/FilterOperations.h:
(WebCore::FilterOperations::isEmpty):
(FilterOperations):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::afterTest):
(WTF):

LayoutTests:

* compositing/culling/filter-occlusion-alpha-expected.png: Added.
* compositing/culling/filter-occlusion-alpha-expected.txt: Added.
* compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
* compositing/culling/filter-occlusion-alpha-large-expected.txt: Added.
* compositing/culling/filter-occlusion-alpha-large.html: Added.
* compositing/culling/filter-occlusion-alpha.html: Added.
* compositing/culling/filter-occlusion-blur-expected.txt: Added.
* compositing/culling/filter-occlusion-blur-large-expected.txt: Added.
* compositing/culling/filter-occlusion-blur-large.html: Added.
* compositing/culling/filter-occlusion-blur.html: Added.
* platform/chromium/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/chromium/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #22 of N.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[BlackBerry] Adapt to the removal of WebStringIml.h
https://bugs.webkit.org/show_bug.cgi?id=78784

Reviewed by Antonio Gomes.

Source/WebCore:

WebKit/blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.

No functionalities changed, no new tests.

* platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::operator WebString):

Source/WebKit:

blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.

* blackberry/Api/WebString.cpp:
(BlackBerry::WebKit::WebString::WebString):
(BlackBerry::WebKit::WebString::equalIgnoringCase):
* blackberry/Api/WebString.h:
(WTF):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Made Weak<T> single-owner, adding PassWeak<T>
https://bugs.webkit.org/show_bug.cgi?id=78740

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This works basically the same way as OwnPtr<T> and PassOwnPtr<T>.

This clarifies the semantics of finalizers: It's ambiguous and probably
a bug to copy a finalizer (i.e., it's a bug to run a C++ destructor
twice), so I've made Weak<T> non-copyable. Anywhere we used to copy a
Weak<T>, we now use PassWeak<T>.

This also makes Weak<T> HashMaps more efficient.

* API/JSClassRef.cpp:
(OpaqueJSClass::prototype): Use PassWeak<T> instead of set(), since
set() is gone now.

* JavaScriptCore.xcodeproj/project.pbxproj: Export!

* heap/PassWeak.h: Added.
(JSC):
(PassWeak):
(JSC::PassWeak::PassWeak):
(JSC::PassWeak::~PassWeak):
(JSC::PassWeak::get):
(JSC::::leakHandle):
(JSC::adoptWeak):
(JSC::operator==):
(JSC::operator!=): This is the Weak<T> version of PassOwnPtr<T>.

* heap/Weak.h:
(Weak):
(JSC::Weak::Weak):
(JSC::Weak::release):
(JSC::Weak::hashTableDeletedValue):
(JSC::=):
(JSC): Changed to be non-copyable, removing a lot of copying-related
APIs. Added hash traits so hash maps still work.

* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate): Use PassWeak<T>, as required by
our new hash map API.

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringSlowCase): Use PassWeak<T>, as required by our new
hash map API.

* bindings/js/JSDOMBinding.h:
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper): Use PassWeak<T> and raw pointer, as required by
our new hash map API.

* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper):
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::addRuntimeObject): Use PassWeak<T>, as
required by our new hash map and Weak<T> APIs.

Source/WebKit2:

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject): Use raw pointer and
PassWeak<T>, as required by our new hash map API.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Crash in visiblePositionForIndex
https://bugs.webkit.org/show_bug.cgi?id=77683

Reviewed by Eric Seidel.

Source/WebCore:

Fixed the crash.

Test: editing/execCommand/applyblockelement-visiblepositionforindex-crash.html

* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
* editing/htmlediting.h:
(WebCore):

LayoutTests:

Add a regression test. It crashes Webkit with very high frequency.

* editing/execCommand/applyblockelement-visiblepositionforindex-crash-expected.txt: Added.
* editing/execCommand/applyblockelement-visiblepositionforindex-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
https://bugs.webkit.org/show_bug.cgi?id=78765

Reviewed by Simon Fraser.

No new tests due to the flaky nature of reproducing the issue.

* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::getScratchBuffer): Make sure to call clearScratchBuffer()
when we create a new ImageBuffer in order to invalidate cached values.
(WebCore::ScratchBuffer::setCachedShadowValues): Roll together matching and setting
of cached values into one method to enforce them being the same.
(WebCore::ScratchBuffer::setCachedInsetShadowValues): Ditto.

Restructure to use new method described above.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::beginShadowLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Empty divs not transforming overflow correctly
https://bugs.webkit.org/show_bug.cgi?id=78850

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/overflow/transform-in-empty-container.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setSize):

LayoutTests:

* compositing/overflow/transform-in-empty-container-expected.png: Added.
* compositing/overflow/transform-in-empty-container-expected.txt: Added.
* compositing/overflow/transform-in-empty-container.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix use of long long in FractionalLayoutUnit::setRawValue
https://bugs.webkit.org/show_bug.cgi?id=78835

Reviewed by Eric Seidel.

Change setRawValue(long long) to compare against int min and max instead
of using abs as not all platforms we support implement a long long
version of abs or llabs.

No new tests.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::setRawValue):
Compare against int min/max instead of just max with abs.

(WebCore::FractionalLayoutUnit::isInBounds):
Fix type mismatch warning.

(WebCore::operator==):
Fix typo.

(WebCore::operator*):
Use long long version of setRawValue.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

nrwt: simplify worker interface
https://bugs.webkit.org/show_bug.cgi?id=78181

Reviewed by Tony Chang.

This change moves code in name(), is_done(), run(), and cancel()
from Worker to AbstractWorker, since the logic is pretty much
boilerplate code that any implementation would want to use.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get.should):
(AbstractWorker.__init__):
(AbstractWorker):
(AbstractWorker.name):
(AbstractWorker.stop_handling_messages):
(AbstractWorker.run):
(AbstractWorker.is_done):
(AbstractWorker.cancel):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.run):
(Worker.handle_stop):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html

* platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: Add an internal flag to accept multiple shadow roots for the purpose of tests.
https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

This patch introduces a flag to enable multiple shadow subtrees.
This flag is intended to be used for testing purpose for a while.
We will remove it later.

No new tests, no change in behavior.

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::multipleShadowSubtreesEnabled):
(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::pushShadowRoot):
* testing/Internals.cpp:
(WebCore::Internals::setMultipleShadowSubtreesEnabled):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests: Needs an internal flag to accept multiple shadow roots for the purpose of tests
https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

* fast/dom/shadow/shadow-root-js-api.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Improve usability of coding-style.html
https://bugs.webkit.org/show_bug.cgi?id=78470

Reviewed by Eric Seidel.

* coding/coding-style.html:
- Do not add a title attribute to each of LI elements
- Do not add a click handler to each of them
- Add a SPAN element in order to show [id-name] and provide smaller clickable area.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the broken viewport tests
https://bugs.webkit.org/show_bug.cgi?id=78774

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.cpp:
(WTF):
(WTF::toDoubleType): Template-ized to allow other functions to specify whether they
want to allow trailing junk or not when calling strtod.
(WTF::charactersToDouble):
(WTF::charactersToFloat):
(WTF::charactersToFloatIgnoringJunk): Created new version of charactersToFloat that allows
trailing junk.
* wtf/text/WTFString.h:
(WTF):

Source/WebCore:

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Changed to use the new charactersToFloatWithJunk function(s).

LayoutTests:

* platform/gtk/Skipped: Undoing tests skipped due to earlier breakage.
* platform/qt/Skipped: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[chromium] Disable mock scrollbars for rubber-banding tests
https://bugs.webkit.org/show_bug.cgi?id=78370

Turning on mock scrollbars caused rubber-banding tests to fail
because the overhang is painted by the ScrollbarTheme, which
was replaced by the mock theme. Disable mock scrollbars for
these tests.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-16
Reviewed by James Robinson.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Very large strings could cause the new quoted string to wrap.
https://bugs.webkit.org/show_bug.cgi?id=78387

Reviewed by Eric Seidel.

* css/CSSParser.cpp:
(WebCore::quoteCSSString):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add a themeChromiumAndroid.css file for android-specific default styles
https://bugs.webkit.org/show_bug.cgi?id=78547

Reviewed by Adam Barth.

This includes the themeChromiumAndroid.css file from the Chromium-Android port
as well as some addidtional changes they had to html.css.  I believe those
changes were made before themeChromiumAndroid was created, but it's now the better place for this CSS.

* WebCore.gyp/WebCore.gyp:
* css/themeChromiumAndroid.css: Added.
(select[size][multiple]):
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
(WebCore):
* rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::delegatesMenuListRendering):
(WebCore::RenderThemeChromiumAndroid::platformTapHighlightColor):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ENH: Add ability to run subset of JavaScript layout tests with JSC
https://bugs.webkit.org/show_bug.cgi?id=78764

Reviewed by Gavin Barraclough.

Tools:

New simple test drive shell script that runs a defined
list of javascript tests using jsc and the standalone-{pre,post}.js
wrappers.

* Scripts/run-fast-jsc: Added.

LayoutTests:

* fast/js/jsc-test-list: Added. List of tests that can be run
using jsc.  Used by new Tools/Scripts/run-fast-jsc script.
* fast/js/resources/standalone-post.js: ~pdated to match changes
in js-test-post.js
* fast/js/resources/standalone-pre.js: Updated to match changes
in js-test-pre.js

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107997 268f45cc-cd09-0410-ab3c-d52691b4dbfc