Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:31:47 +0000 (11:31 -0500)]
core/execute.c: check asprintf return value in the usual fashion
This is unlikely to fail, but we cannot rely on asprintf return value
on failure, so let's just be correct here.
CID #1368227.
Zbigniew Jędrzejewski-Szmek [Tue, 31 Jan 2017 16:23:10 +0000 (11:23 -0500)]
core/execute: reformat exec_context_named_iofds() for legibility
Zbigniew Jędrzejewski-Szmek [Sun, 29 Jan 2017 02:09:08 +0000 (21:09 -0500)]
pid1: rewrite check in ignore_proc() to not check condition twice
It's harmless, but it seems nicer to evaluate a condition just a single time.
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jan 2017 04:06:57 +0000 (23:06 -0500)]
boot: fix two typos
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jan 2017 02:50:06 +0000 (21:50 -0500)]
logind: trivial simplification
free_and_strdup() handles NULL arg, so make use of that.
Yi EungJun [Mon, 30 Jan 2017 15:24:06 +0000 (00:24 +0900)]
journal-gatewayd: return -EINVAL if ARG_TRUST and HAVE_GNUTLS (#5181)
This bug was introduced by 1aa1e59.
Ivan Shapovalov [Sun, 29 Jan 2017 19:33:37 +0000 (23:33 +0400)]
journal-gatewayd: actually recognize -D as a synonym for --directory (#5180)
llua [Fri, 27 Jan 2017 12:50:40 +0000 (07:50 -0500)]
zsh-completion: _journalctl fixes (#5165)
allow _journalctl to work when the rcquotes option is set, broken in
ba89f80620d619867b4838973785d529c5a959f6.
allow the completion of --file multiple times, which
ba89f80620d619867b4838973785d529c5a959f6 claims is true.
Fixes #4842
Dan Streetman [Thu, 26 Jan 2017 01:24:52 +0000 (20:24 -0500)]
tests: add tests for SYMLINK containing whitespace in variable (#5158)
add udev-test.pl tests for whitespace in a substituted variable,
to verify the variable whitespace is replaced with underscores.
Tests for the change made by commit
0a10235ed453 ("udev-rules:
perform whitespace replacement for symlink subst values")
clearyf [Thu, 26 Jan 2017 01:20:17 +0000 (02:20 +0100)]
hwdb: add Razer DeathAdder Black Edition (#5157)
Evgeny Vereshchagin [Wed, 25 Jan 2017 13:31:11 +0000 (16:31 +0300)]
Merge pull request #5152 from keszybz/strv-free
Use strv_free where appropriate
Jan Synacek [Wed, 25 Jan 2017 12:44:04 +0000 (13:44 +0100)]
bash-completion: add support for --now (#5155)
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jan 2017 03:27:21 +0000 (22:27 -0500)]
resolve: fix strv memleak
sd_bus_message_read_strv() returns a normal strv...
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jan 2017 03:24:07 +0000 (22:24 -0500)]
core/execute: fix strv memleak
compile_read_write_paths() returns a normal strv from strv_copy(), and
setup_namespace() uses it read-only, so we should use strv_free to deallocate.
Zbigniew Jędrzejewski-Szmek [Wed, 25 Jan 2017 03:21:16 +0000 (22:21 -0500)]
core/dbus: fix two strv memleaks
job_dbus_path and unit_dbus_path both allocate new strings, so we should use
strv_free.
Evgeny Vereshchagin [Wed, 25 Jan 2017 02:53:50 +0000 (05:53 +0300)]
core: fix memleak in bus_exec_context_set_transient_property (#5143)
Fixes:
```sh
systemd-run --property EnvironmentFile=/some/environment/file /bin/sleep 30
```
```
23 bytes in 1 blocks are definitely lost in loss record 1 of 7
at 0x4C2DB9D: malloc (vg_replace_malloc.c:299)
by 0x4E85488: malloc_multiply (alloc-util.h:70)
by 0x4E85F19: strjoin_real (string-util.c:252)
by 0x1AF741: bus_exec_context_set_transient_property (dbus-execute.c:1418)
by 0x1A907C: bus_service_set_property (dbus-service.c:330)
by 0x1A66DD: bus_unit_set_properties (dbus-unit.c:1456)
by 0x19CF93: transient_unit_from_message (dbus-manager.c:892)
by 0x19D388: method_start_transient_unit (dbus-manager.c:980)
by 0x4F60544: method_callbacks_run (bus-objects.c:418)
by 0x4F62D9D: object_find_and_run (bus-objects.c:1255)
by 0x4F633CE: bus_process_object (bus-objects.c:1371)
by 0x4F2CE1D: process_message (sd-bus.c:2563)
```
Closes: #5142
Jakub Wilk [Wed, 25 Jan 2017 02:45:58 +0000 (03:45 +0100)]
po: Fix invalid date in Croatian translation (#5147)
Stefan Schweter [Wed, 25 Jan 2017 02:45:30 +0000 (03:45 +0100)]
tree-wide: remove consecutive duplicate words in comments (#5148)
Stefan Schweter [Wed, 25 Jan 2017 02:44:59 +0000 (03:44 +0100)]
virt: update url to hypervisor top-level functional specification (#5149)
Stefan Schweter [Wed, 25 Jan 2017 02:44:19 +0000 (03:44 +0100)]
catalog: make support URL to show in shipped catalog entries configurable (#5150)
Franck Bui [Tue, 24 Jan 2017 13:29:57 +0000 (14:29 +0100)]
core: don't load dropin data multiple times for the same unit (#5139)
When an alias is loaded, we resolve this alias to its final unit first to load
the dropin data.
However if the final unit was already loaded, there's no point in reloading the
dropin data a second time.
This patch optimizes this case.
Also this allows the dropin loading code to assume that only units not yet
loaded are passed down. This assumption is not yet used but might be in the
future.
[zj: invert the condition in the if]
peoronoob [Tue, 24 Jan 2017 03:26:41 +0000 (04:26 +0100)]
network: accept colons in network interface names, normally used for alias interfaces (#5117)
Jan Synacek [Tue, 24 Jan 2017 03:06:05 +0000 (04:06 +0100)]
core: improve error message when RefuseManualStart(Stop) is hit (#5132)
Michal Sekletar [Tue, 24 Jan 2017 02:18:40 +0000 (03:18 +0100)]
load-fragment: fix comment to reflect changes made in 43eb109 (#5138)
Lucas Werkmeister [Tue, 24 Jan 2017 02:18:07 +0000 (03:18 +0100)]
README: document CONFIG_USER_NS requirement for PrivateUsers (#5140)
Evgeny Vereshchagin [Tue, 24 Jan 2017 02:12:58 +0000 (05:12 +0300)]
sd-network: fix memleak in dhcp6_lease_set_domains (#5113)
The simplest way to reproduce:
```diff
diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c
index bd289fa..4e14d8f 100644
--- a/src/libsystemd-network/test-dhcp6-client.c
+++ b/src/libsystemd-network/test-dhcp6-client.c
@@ -286,6 +286,8 @@ static int test_advertise_option(sd_event *e) {
assert_se(optlen == 11);
assert_se(dhcp6_lease_set_domains(lease, optval,
optlen) >= 0);
+ assert_se(dhcp6_lease_set_domains(lease, optval,
+ optlen) >= 0);
break;
case SD_DHCP6_OPTION_SNTP_SERVERS:
```
Fixes:
```
==27369==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 10 byte(s) in 1 object(s) allocated from:
#0 0x7f90e7d21160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7f90e7467f69 in strv_extend src/basic/strv.c:552
#2 0x5612fcc19379 in dhcp6_option_parse_domainname src/libsystemd-network/dhcp6-option.c:399
#3 0x5612fcc1acdf in dhcp6_lease_set_domains src/libsystemd-network/sd-dhcp6-lease.c:225
#4 0x5612fcc06b95 in test_advertise_option src/libsystemd-network/test-dhcp6-client.c:287
#5 0x5612fcc0a987 in main src/libsystemd-network/test-dhcp6-client.c:761
#6 0x7f90e6d46400 in __libc_start_main (/lib64/libc.so.6+0x20400)
SUMMARY: AddressSanitizer: 10 byte(s) leaked in 1 allocation(s).
```
Evgeny Vereshchagin [Tue, 24 Jan 2017 02:11:59 +0000 (05:11 +0300)]
sd-network: fix memleak in dhcp6_option_parse_domainname (#5114)
The simplest way to reproduce:
```diff
diff --git a/src/libsystemd-network/test-dhcp6-client.c b/src/libsystemd-network/test-dhcp6-client.c
index bd289fa..7b0a5ef 100644
--- a/src/libsystemd-network/test-dhcp6-client.c
+++ b/src/libsystemd-network/test-dhcp6-client.c
@@ -168,7 +168,7 @@ static uint8_t msg_advertise[198] = {
0x00, 0x17, 0x00, 0x10, 0x20, 0x01, 0x0d, 0xb8,
0xde, 0xad, 0xbe, 0xef, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x01, 0x00, 0x18, 0x00, 0x0b,
- 0x03, 0x6c, 0x61, 0x62, 0x05, 0x69, 0x6e, 0x74,
+ 0x01, 0x6c, 0x01, 0x62, 0x00, 0x0a, 0x6e, 0x74,
0x72, 0x61, 0x00, 0x00, 0x1f, 0x00, 0x10, 0x20,
0x01, 0x0d, 0xb8, 0xde, 0xad, 0xbe, 0xef, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00,
@@ -338,9 +338,7 @@ static int test_advertise_option(sd_event *e) {
assert_se(!memcmp(addrs, &msg_advertise[124], r * 16));
r = sd_dhcp6_lease_get_domains(lease, &domains);
- assert_se(r == 1);
- assert_se(!strcmp("lab.intra", domains[0]));
- assert_se(domains[1] == NULL);
+ assert_se(r == -ENOENT);
r = sd_dhcp6_lease_get_ntp_addrs(lease, &addrs);
assert_se(r == 1);
```
Fixes:
```
=================================================================
==15043==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 4 byte(s) in 1 object(s) allocated from:
#0 0x7f13c8564160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7f13c7caaf69 in strv_extend src/basic/strv.c:552
#2 0x55f775787230 in dhcp6_option_parse_domainname src/libsystemd-network/dhcp6-option.c:399
#3 0x55f775788b96 in dhcp6_lease_set_domains src/libsystemd-network/sd-dhcp6-lease.c:225
#4 0x55f775774b95 in test_advertise_option src/libsystemd-network/test-dhcp6-client.c:287
#5 0x55f77577883e in main src/libsystemd-network/test-dhcp6-client.c:759
#6 0x7f13c7589400 in __libc_start_main (/lib64/libc.so.6+0x20400)
Direct leak of 4 byte(s) in 1 object(s) allocated from:
#0 0x7f13c8564160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7f13c7caaf69 in strv_extend src/basic/strv.c:552
#2 0x55f775787230 in dhcp6_option_parse_domainname src/libsystemd-network/dhcp6-option.c:399
#3 0x55f775788b96 in dhcp6_lease_set_domains src/libsystemd-network/sd-dhcp6-lease.c:225
#4 0x55f775781348 in client_parse_message src/libsystemd-network/sd-dhcp6-client.c:807
#5 0x55f775781ba2 in client_receive_advertise src/libsystemd-network/sd-dhcp6-client.c:895
#6 0x55f775782453 in client_receive_message src/libsystemd-network/sd-dhcp6-client.c:994
#7 0x7f13c7e447f4 in source_dispatch src/libsystemd/sd-event/sd-event.c:2268
#8 0x7f13c7e471b0 in sd_event_dispatch src/libsystemd/sd-event/sd-event.c:2627
#9 0x7f13c7e47ab3 in sd_event_run src/libsystemd/sd-event/sd-event.c:2686
#10 0x7f13c7e47c21 in sd_event_loop src/libsystemd/sd-event/sd-event.c:2706
#11 0x55f77577863c in test_client_solicit src/libsystemd-network/test-dhcp6-client.c:737
#12 0x55f77577884b in main src/libsystemd-network/test-dhcp6-client.c:760
#13 0x7f13c7589400 in __libc_start_main (/lib64/libc.so.6+0x20400)
SUMMARY: AddressSanitizer: 8 byte(s) leaked in 2 allocation(s).
```
Peter Hutterer [Tue, 24 Jan 2017 02:10:33 +0000 (12:10 +1000)]
hwdb: mark Wacom touchpads as external (#5115)
Wacom doesn't have any internal touchpads.
Zbigniew Jędrzejewski-Szmek [Tue, 24 Jan 2017 01:20:13 +0000 (20:20 -0500)]
Merge pull request #5112 from yuwata/fix-5105
core: add missing unit_add_to_load_queue() to mount_setup_new_unit()
Yu Watanabe [Fri, 20 Jan 2017 00:46:47 +0000 (09:46 +0900)]
core: add missing unit_add_to_load_queue() to mount_setup_new_unit()
unit_add_to_load_queue was present in the code before
03b8cfede9ff3441b1ec8ff5cdf6876294846aa4,
and was inadvertently dropped.
Fixes #5105
Yu Watanabe [Fri, 20 Jan 2017 00:45:58 +0000 (09:45 +0900)]
core: minor error handling fix in mount_setup_new_unit()
The function mount_setup_new_unit() should return -ENOMEM
if at least one of `strdup` calls are failed.
Александр Тихонов [Sat, 21 Jan 2017 19:53:09 +0000 (23:53 +0400)]
Fixi caching in zsh completion (#5122)
I found several issues with zsh completion code:
1. typo in cache filename: "SYS_ALL_PROPRTIES", so cache just not loading from this file
2. cache stored in one file, despite user or system mode. So it can be loaded later in wrong mode
3. most serious problem: broken logic - it retrieves cache when _cache_invalid is true
How to reproduce: type "systemctl --user status <TAB>" and you will see user units. Then press
control+C and type "systemctl --system status <TAB>" in same session and you'll see user units again
Zbigniew Jędrzejewski-Szmek [Sat, 21 Jan 2017 17:48:27 +0000 (12:48 -0500)]
Merge pull request #5126 from namhyung/journalctl-completion
bash_completion: Small update for journalctl completion.
Namhyung Kim [Sat, 21 Jan 2017 07:38:23 +0000 (16:38 +0900)]
bash_completion: journalctl: Complete -t option values
The -t or --identifier requires a syslog identifier.
Namhyung Kim [Sat, 21 Jan 2017 07:36:20 +0000 (16:36 +0900)]
bash_completion: journalctl: add missing options
The --no-hostname and --vacuum-files were missing, add them.
Rike-Benjamin Schuppner [Fri, 20 Jan 2017 00:10:30 +0000 (01:10 +0100)]
man: fix flag in systemd-run (#5107)
Jakub Wilk [Thu, 19 Jan 2017 15:54:22 +0000 (16:54 +0100)]
man: fix typos (#5109)
Djalal Harouni [Wed, 18 Jan 2017 13:36:07 +0000 (14:36 +0100)]
Merge pull request #5098 from evverx/fix-nspawn-notifications
nspawn: change owner/group of /run/systemd/nspawn/notify to userns-root
Zbigniew Jędrzejewski-Szmek [Wed, 18 Jan 2017 04:10:46 +0000 (23:10 -0500)]
Merge pull request #4991 from poettering/seccomp-fix
Zbigniew Jędrzejewski-Szmek [Wed, 18 Jan 2017 03:38:55 +0000 (22:38 -0500)]
pid1: provide a more detailed error message when execution fails (#5074)
Fixes #5000.
Lennart Poettering [Tue, 27 Dec 2016 15:50:02 +0000 (16:50 +0100)]
seccomp: minor simplifications for is_seccomp_available()
Lennart Poettering [Tue, 27 Dec 2016 14:28:25 +0000 (15:28 +0100)]
seccomp: rework seccomp code, to improve compat with some archs
This substantially reworks the seccomp code, to ensure better
compatibility with some architectures, including i386.
So far we relied on libseccomp's internal handling of the multiple
syscall ABIs supported on Linux. This is problematic however, as it does
not define clear semantics if an ABI is not able to support specific
seccomp rules we install.
This rework hence changes a couple of things:
- We no longer use seccomp_rule_add(), but only
seccomp_rule_add_exact(), and fail the installation of a filter if the
architecture doesn't support it.
- We no longer rely on adding multiple syscall architectures to a single filter,
but instead install a separate filter for each syscall architecture
supported. This way, we can install a strict filter for x86-64, while
permitting a less strict filter for i386.
- All high-level filter additions are now moved from execute.c to
seccomp-util.c, so that we can test them independently of the service
execution logic.
- Tests have been added for all types of our seccomp filters.
- SystemCallFilters= and SystemCallArchitectures= are now implemented in
independent filters and installation logic, as they semantically are
very much independent of each other.
Fixes: #4575
AsciiWolf [Tue, 17 Jan 2017 11:09:38 +0000 (12:09 +0100)]
man: fix typo (#5093)
Evgeny Vereshchagin [Tue, 17 Jan 2017 01:37:05 +0000 (01:37 +0000)]
tests: check that we can write to /run/systemd/nspawn/notify
See https://github.com/systemd/systemd/issues/4944
Evgeny Vereshchagin [Tue, 17 Jan 2017 01:19:34 +0000 (01:19 +0000)]
nspawn: change owner/group of /run/systemd/nspawn/notify to userns-root
Fixes #4944
Franck Bui [Mon, 16 Jan 2017 20:19:13 +0000 (21:19 +0100)]
core: make sure to init mount params before calling mount_is_extrinsic() (#5087)
When a new entry appears in /proc/self/mountinfo, mount_setup_unit()
allocated a new mount unit for it and starts initializing it.
mount_setup_unit() is also used to update a mount unit when a change happens in
/proc/self/mountinfo, for example a mountpoint can be remounted with additional
mount options.
This patch introduces 2 separate functions to deal with those 2 cases instead
of mount_setup_unit() dealing with both of them. The common code is small and
doing the split makes the code easier to read and less error prone if extended
later.
It also makes sure to initialize in both functions the mount parameters of the
mount unit before calling mount_is_extrinsic() since this function relies on
them.
Fixes: #4902
Cédric Schieli [Mon, 16 Jan 2017 17:23:26 +0000 (18:23 +0100)]
ndisc: honor IPv6AcceptRA.UseDNS when parsing RA options (#5071)
RDNSS and DNSLL options received in RA are always used, possibly breaking the resolution of private domains hosted on a local DNS server. When setting UseDNS=no in a [IPv6AcceptRA] section of a .network file, both RDNSS and DNSLL options in received RA should be ignored.
Fixes: #5040
Björn [Mon, 16 Jan 2017 17:19:04 +0000 (18:19 +0100)]
hwdb: add axis range corrections for Lenovo X1 Carbon 4th gen. / X1 Yoga (#5089)
The parameters were calculated on my X1 Yoga using touchpad-edge-detector; As as the device name indicates, the Touchpad is exactly the same as the X1 Carbon 4th gen.
Martin Pitt [Mon, 16 Jan 2017 06:56:53 +0000 (07:56 +0100)]
Merge pull request #5085 from keszybz/variables
Fixes for gcc and coverity warnings
Earnestly [Mon, 16 Jan 2017 01:41:59 +0000 (01:41 +0000)]
hwdb: Include X220 for pointingstick sensitivity (#5083)
Without this the trackpoint is very difficult to manoeuvre until
manually correcting the sysfs serio1/sensitivity entry.
kilian-k [Sun, 15 Jan 2017 22:21:33 +0000 (23:21 +0100)]
hwdb: add Logitech TrackMan Wheel (#5084)
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 21:57:57 +0000 (16:57 -0500)]
nspawn: fix memleak
CID #1368262: fn is allocated with new, so it should be freed.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 18:42:53 +0000 (13:42 -0500)]
shared/install-printf: fix memleak
instance might be "", and that string would be leaked.
CID #1368264.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 18:38:43 +0000 (13:38 -0500)]
systemctl: fix alignment with units in not-found state
A fixed value (6 and later 5) was added back in
4deb3b93911, and
not updated when load_len was added later on.
Also the other 5 with 1 + 1 + 1 + 1 + 1 to make it easier to see
that this is about the column separators.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 18:27:37 +0000 (13:27 -0500)]
systemctl: uninitalized variable
CID #1368270.
Easily reproduced with COLUMNS=50 ./systemctl --no-pager.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 17:41:34 +0000 (12:41 -0500)]
process-util: rename char *r to ans and add comment
Add a comment about the return value and rename r to ans. r is
nowadays reserved for the integer return value, and char *r is confusing.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 16:55:46 +0000 (11:55 -0500)]
journalctl: fix memleak
This is harmless, it would only happen if --verify-key is used multiple times.
But let's fix it for correctness.
CID ##1368415.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 16:51:48 +0000 (11:51 -0500)]
cryptsetup: fix unitialized variable
CID #1368416.
Coverity web interface is back, yay!
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 03:00:48 +0000 (22:00 -0500)]
udev: fix variable assignment
gcc doesn't like &, even though &sbuf and buf are the same things afaiu.
Follow-up for
e20a917105b.
Lucas Werkmeister [Sun, 15 Jan 2017 04:03:00 +0000 (05:03 +0100)]
journalctl: expunge verification key from argv (#5081)
After parsing the --verify-key argument, overwrite it with null bytes.
This minimizes (but does not completely eliminate) the time frame within
which another process on the system can extract the verification key
from the journalctl command line.
Zbigniew Jędrzejewski-Szmek [Sun, 15 Jan 2017 00:48:04 +0000 (19:48 -0500)]
Merge pull request #4879 from poettering/systemd
Mark Stosberg [Wed, 21 Dec 2016 19:55:04 +0000 (14:55 -0500)]
man: provide a basic guide to the `systemctl status` output (#4950)
- Show example of all `systemctl status` output and documents what possible
"Loaded:", "Active" and "Enabled" values mean.
- Documents what different colors of the dot mean.
- Documents "gotcha" with load-on-demand behavior which will report units as
"loaded" even if they are only loaded to show their status.
(From @poettering: https://github.com/systemd/systemd/issues/5063#issuecomment-
272115024 )
Lennart Poettering [Thu, 12 Jan 2017 09:19:30 +0000 (10:19 +0100)]
Merge pull request #5069 from keszybz/fixlets
Small fixes and enhancements to docs and code
Harald Hoyer [Thu, 12 Jan 2017 09:19:07 +0000 (10:19 +0100)]
Merge pull request #5068 from keszybz/kernel-install-process-sub
kernel-install: avoid process substitution
Zbigniew Jędrzejewski-Szmek [Thu, 12 Jan 2017 09:16:20 +0000 (04:16 -0500)]
rpm triggers: do nothing if systemd is not running (#5065)
If we are running in a chroot/container/..., we would print a useless warning about
not being able to communicate with systemd. Trying to do daemon-reload is pointless
in those cases, so let's just skip all actions in that case.
The check uses /run/system/system, as recommended by sd_booted(3).
https://bugzilla.redhat.com/show_bug.cgi?id=1411299
Franck Bui [Thu, 12 Jan 2017 02:37:15 +0000 (03:37 +0100)]
systemctl: remove duplicate entries showed by list-dependencies (#5049)
When a unit is part of several dependency constraints of another
unit, list-dependencies repeats the name of the dependency for each
dep constraint the unit is encountered.
For example:
$ systemctl cat test-main.target
# /etc/systemd/system/test-main.target
[Unit]
Description=Main Target
$ systemctl cat test.target
[Unit]
Description=Sub target
PartOf=test-main.target
[Install]
WantedBy=test-main.target
$ systemctl enable test.target
Created symlink from /etc/systemd/system/test-main.target.wants/test.target to /etc/systemd/system/test.target.
$ systemctl show test-main.target | grep test.target
Wants=test.target
ConsistsOf=test.target
[...]
$ systemctl list-dependencies test-main.target
test-main.target
● ├─test.target
● └─test.target
With this patch applied, dependencies are shown only once.
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 21:40:04 +0000 (16:40 -0500)]
Merge pull request #4837 from ddstreet/master
Replace spaces in expanded fields in SYMLINK properties by default.
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 20:48:15 +0000 (15:48 -0500)]
man: link to sd-j-{remote,upload} from journalctl(1)
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 19:45:19 +0000 (14:45 -0500)]
shell-completion: redirect all errors from systemctl to /dev/null
Completion scripts should not generate errors, ever.
https://bugzilla.redhat.com/show_bug.cgi?id=1409649
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 19:09:47 +0000 (14:09 -0500)]
socket-util: drop _pure_ from a function with an output parameter
If it writes to memory, it's not pure, by definition.
Fixup for
882ac6e769c5c.
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 18:48:16 +0000 (13:48 -0500)]
core: add missing "=" in message
For consistency. Also drop "e.g." because it's somewhat redundant with the
ellipsis and the message is pretty long already.
Follow-up for
4d1fe20a585ca.
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 18:40:10 +0000 (13:40 -0500)]
networkd: reorder gperf fields
In
eb64b435ebb2a7cb1274d5 ActiveSlave/PrimarySlave were inserted in between
IPv6AcceptRA and IPv6AcceptRouterAdvertisements and the comment then didn't
make sense. It turns out that gperf does not understand C-style comments, and
that there's no comment syntax in the keywords section. The following was
generated:
{"/* legacy alias for the above */"},
{"Network.IPv6AcceptRA", config_parse_tristate, 0, offsetof(Network, ipv6_accept_ra)},
In practice this wouldn't lead to problems because this fake pattern would be
hard to match, but it seems better to remove the comments altogether.
Readers of the .gperf file will have to look for the repeated output field to
notice legacy options. To make this easier, let's always keep the legacy option
second.
Michal Schmidt [Fri, 16 Dec 2016 17:14:47 +0000 (18:14 +0100)]
kernel-install: avoid process substitution
bash implements process substitution using /dev/fd/N (this is documented
in man bash). We'd like kernel-install to work in chrooted RPM
scriptlets without /dev.
We can use here-strings instead. bash uses temporary files to implement
those.
Zbigniew Jędrzejewski-Szmek [Wed, 11 Jan 2017 20:23:00 +0000 (15:23 -0500)]
Merge pull request #5009 from ian-kelling/ian-mnt-namespace-doc
micah [Wed, 11 Jan 2017 20:07:35 +0000 (15:07 -0500)]
Document how restart actions work (#5052)
When a user is trying to understand what is going on with a restart action, it is useful to explicitly describe how the action is run. It may seem obvious, but it is helpful to be explicit so one knows there isn't a special ExecRestart= or similar option that they could be looking at.
sammynx [Wed, 11 Jan 2017 20:01:55 +0000 (21:01 +0100)]
hwdb: add correct metrics for Lenovo Thinkpad T430 (#5050)
Zbigniew Jędrzejewski-Szmek [Mon, 9 Jan 2017 18:51:06 +0000 (13:51 -0500)]
man: add more links to systemd-ask-password and systemd-tty-ask-password-agent
Loosely inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1411134.
nikolaof [Wed, 11 Jan 2017 13:35:20 +0000 (15:35 +0200)]
hwdb: update micmute YCODE on device node at DELL LATITUDE laptops for mic mute button. (#5012)
Lennart Poettering [Wed, 11 Jan 2017 09:53:59 +0000 (10:53 +0100)]
Merge pull request #5046 from stefanha/vsock
Add AF_VSOCK socket activation support
Robert Kreuzer [Wed, 11 Jan 2017 09:50:58 +0000 (10:50 +0100)]
journal-gatewayd: align closing braces (#5060)
Lubomir Rintel [Wed, 11 Jan 2017 09:50:25 +0000 (10:50 +0100)]
sparse: avoid clash with __bitwise and __force from 4.10 linux/types.h (#5061)
It also used __bitwise and __force. It seems easier to rename
our versions since they are local to this one single header.
Also, undefine them afteerwards, so that we don't pollute the
preprocessor macro namespace.
Stefan Hajnoczi [Wed, 21 Dec 2016 17:02:08 +0000 (17:02 +0000)]
core: add AF_VSOCK support to socket units
Accept AF_VSOCK listen addresses in socket unit files. Both guest and
host can now take advantage of socket activation.
The QEMU guest agent has recently been modified to support socket
activation and can run over AF_VSOCK with this patch.
Stefan Hajnoczi [Tue, 20 Dec 2016 14:24:27 +0000 (14:24 +0000)]
socket-util: add AF_VSOCK address family
The AF_VSOCK address family facilitates guest<->host communication on
VMware and KVM (virtio-vsock). Adding support to systemd allows guest
agents to be launched through .socket unit files. Today guest agents
are stand-alone daemons running inside guests that do not take advantage
of systemd socket activation.
Stefan Hajnoczi [Tue, 20 Dec 2016 14:10:54 +0000 (14:10 +0000)]
socket-util: introduce port argument in sockaddr_port()
sockaddr_port() either returns a >= 0 port number or a negative errno.
This works for AF_INET and AF_INET6 because port ranges are only 16-bit.
In AF_VSOCK ports are 32-bit so an int cannot represent all port number
and negative errnos. Separate the port and the return code.
Stefan Hajnoczi [Tue, 10 Jan 2017 13:35:18 +0000 (13:35 +0000)]
missing.h: add AF_VSOCK bits
Ubuntu 14.04 (Trusty) kernel header packages ship without
<linux/vm_sockets.h>. Only struct sockaddr_vm and VMADDR_CID_ANY will
be needed by systemd and they are simple enough to go in missing.h.
CentOS 7 <sys/socket.h> does not define AF_VSOCK. Define it so the code
can compile although actual socket(2) calls may fail at runtime if the
address family isn't available.
Franck Bui [Tue, 10 Jan 2017 08:11:34 +0000 (09:11 +0100)]
core: make sure to not call device_is_bound_by_mounts() when dev is null (#5033)
device_setup_unit() might be called (when an event happened in
/proc/self/mountinfo for example) with a null 'dev' parameter. This
indicates that the device has been unplugged but the corresponding
mountpoint is still visible in /proc/self/mountinfo.
This patch makes sure we don't call device_is_bound_by_mounts() in
this case.
Fixes: #5025
Susant Sahani [Tue, 10 Jan 2017 07:58:04 +0000 (13:28 +0530)]
networkd: RouteMetric for IPv6 Stateless Autoconfiguration (#5045)
Add support to set route metric for IPv6
Fixes: #5002
(GalaxyMaster) [Tue, 10 Jan 2017 07:55:50 +0000 (18:55 +1100)]
socket-proxyd: fix --connections-max help message and docs (#5044)
Peter Hutterer [Tue, 10 Jan 2017 07:41:50 +0000 (17:41 +1000)]
hwdb: add hwdb override for Asus S550CB (#5053)
Widen the match for the current X550CC rule, they probably all have the same
touchpad.
https://bugs.freedesktop.org/show_bug.cgi?id=99306
Martin Pitt [Tue, 10 Jan 2017 07:41:14 +0000 (08:41 +0100)]
Merge pull request #5054 from evverx/fix-double-free-in-link
shared: fix double free in link
Mike Gilbert [Tue, 10 Jan 2017 07:39:05 +0000 (02:39 -0500)]
build-sys: add check for gperf lookup function signature (#5055)
gperf-3.1 generates lookup functions that take a size_t length
parameter instead of unsigned int. Test for this at configure time.
Fixes: https://github.com/systemd/systemd/issues/5039
Peter Hutterer [Tue, 10 Jan 2017 07:36:46 +0000 (17:36 +1000)]
udev: add ID_INPUT_SWITCH for devices with switch capability (#5057)
Evgeny Vereshchagin [Mon, 9 Jan 2017 22:45:41 +0000 (22:45 +0000)]
shared: check strdup != NULL
This is a follow-up for
dc7dd61de610e9330
Evgeny Vereshchagin [Mon, 9 Jan 2017 04:46:11 +0000 (04:46 +0000)]
shared: fix double free in link
Fixes:
```
touch hola.service
systemctl link $(pwd)/hola.service $(pwd)/hola.service
```
```
==1==ERROR: AddressSanitizer: attempting double-free on 0x60300002c560 in thread T0 (systemd):
#0 0x7fc8c961cb00 in free (/lib64/libasan.so.3+0xc6b00)
#1 0x7fc8c90ebd3b in strv_clear src/basic/strv.c:83
#2 0x7fc8c90ebdb6 in strv_free src/basic/strv.c:89
#3 0x55637c758c77 in strv_freep src/basic/strv.h:37
#4 0x55637c763ba9 in method_enable_unit_files_generic src/core/dbus-manager.c:1960
#5 0x55637c763d16 in method_link_unit_files src/core/dbus-manager.c:2001
#6 0x7fc8c92537ec in method_callbacks_run src/libsystemd/sd-bus/bus-objects.c:418
#7 0x7fc8c9258830 in object_find_and_run src/libsystemd/sd-bus/bus-objects.c:1255
#8 0x7fc8c92594d7 in bus_process_object src/libsystemd/sd-bus/bus-objects.c:1371
#9 0x7fc8c91e7553 in process_message src/libsystemd/sd-bus/sd-bus.c:2563
#10 0x7fc8c91e78ce in process_running src/libsystemd/sd-bus/sd-bus.c:2605
#11 0x7fc8c91e8f61 in bus_process_internal src/libsystemd/sd-bus/sd-bus.c:2837
#12 0x7fc8c91e90d2 in sd_bus_process src/libsystemd/sd-bus/sd-bus.c:2856
#13 0x7fc8c91ea8f9 in io_callback src/libsystemd/sd-bus/sd-bus.c:3126
#14 0x7fc8c928333b in source_dispatch src/libsystemd/sd-event/sd-event.c:2268
#15 0x7fc8c9285cf7 in sd_event_dispatch src/libsystemd/sd-event/sd-event.c:2627
#16 0x7fc8c92865fa in sd_event_run src/libsystemd/sd-event/sd-event.c:2686
#17 0x55637c6b5257 in manager_loop src/core/manager.c:2274
#18 0x55637c6a2194 in main src/core/main.c:1920
#19 0x7fc8c7ac7400 in __libc_start_main (/lib64/libc.so.6+0x20400)
#20 0x55637c697339 in _start (/usr/lib/systemd/systemd+0xcd339)
0x60300002c560 is located 0 bytes inside of 19-byte region [0x60300002c560,0x60300002c573)
freed by thread T0 (systemd) here:
#0 0x7fc8c961cb00 in free (/lib64/libasan.so.3+0xc6b00)
#1 0x7fc8c90ee320 in strv_remove src/basic/strv.c:630
#2 0x7fc8c90ee190 in strv_uniq src/basic/strv.c:602
#3 0x7fc8c9180533 in unit_file_link src/shared/install.c:1996
#4 0x55637c763b25 in method_enable_unit_files_generic src/core/dbus-manager.c:1985
#5 0x55637c763d16 in method_link_unit_files src/core/dbus-manager.c:2001
#6 0x7fc8c92537ec in method_callbacks_run src/libsystemd/sd-bus/bus-objects.c:418
#7 0x7fc8c9258830 in object_find_and_run src/libsystemd/sd-bus/bus-objects.c:1255
#8 0x7fc8c92594d7 in bus_process_object src/libsystemd/sd-bus/bus-objects.c:1371
#9 0x7fc8c91e7553 in process_message src/libsystemd/sd-bus/sd-bus.c:2563
#10 0x7fc8c91e78ce in process_running src/libsystemd/sd-bus/sd-bus.c:2605
#11 0x7fc8c91e8f61 in bus_process_internal src/libsystemd/sd-bus/sd-bus.c:2837
#12 0x7fc8c91e90d2 in sd_bus_process src/libsystemd/sd-bus/sd-bus.c:2856
#13 0x7fc8c91ea8f9 in io_callback src/libsystemd/sd-bus/sd-bus.c:3126
#14 0x7fc8c928333b in source_dispatch src/libsystemd/sd-event/sd-event.c:2268
#15 0x7fc8c9285cf7 in sd_event_dispatch src/libsystemd/sd-event/sd-event.c:2627
#16 0x7fc8c92865fa in sd_event_run src/libsystemd/sd-event/sd-event.c:2686
#17 0x55637c6b5257 in manager_loop src/core/manager.c:2274
#18 0x55637c6a2194 in main src/core/main.c:1920
#19 0x7fc8c7ac7400 in __libc_start_main (/lib64/libc.so.6+0x20400)
previously allocated by thread T0 (systemd) here:
#0 0x7fc8c95b0160 in strdup (/lib64/libasan.so.3+0x5a160)
#1 0x7fc8c90edf32 in strv_extend src/basic/strv.c:552
#2 0x7fc8c923ae41 in bus_message_read_strv_extend src/libsystemd/sd-bus/bus-message.c:5578
#3 0x7fc8c923b0de in sd_bus_message_read_strv src/libsystemd/sd-bus/bus-message.c:5600
#4 0x55637c7639d1 in method_enable_unit_files_generic src/core/dbus-manager.c:1969
#5 0x55637c763d16 in method_link_unit_files src/core/dbus-manager.c:2001
#6 0x7fc8c92537ec in method_callbacks_run src/libsystemd/sd-bus/bus-objects.c:418
#7 0x7fc8c9258830 in object_find_and_run src/libsystemd/sd-bus/bus-objects.c:1255
#8 0x7fc8c92594d7 in bus_process_object src/libsystemd/sd-bus/bus-objects.c:1371
#9 0x7fc8c91e7553 in process_message src/libsystemd/sd-bus/sd-bus.c:2563
#10 0x7fc8c91e78ce in process_running src/libsystemd/sd-bus/sd-bus.c:2605
#11 0x7fc8c91e8f61 in bus_process_internal src/libsystemd/sd-bus/sd-bus.c:2837
#12 0x7fc8c91e90d2 in sd_bus_process src/libsystemd/sd-bus/sd-bus.c:2856
#13 0x7fc8c91ea8f9 in io_callback src/libsystemd/sd-bus/sd-bus.c:3126
#14 0x7fc8c928333b in source_dispatch src/libsystemd/sd-event/sd-event.c:2268
#15 0x7fc8c9285cf7 in sd_event_dispatch src/libsystemd/sd-event/sd-event.c:2627
#16 0x7fc8c92865fa in sd_event_run src/libsystemd/sd-event/sd-event.c:2686
#17 0x55637c6b5257 in manager_loop src/core/manager.c:2274
#18 0x55637c6a2194 in main src/core/main.c:1920
#19 0x7fc8c7ac7400 in __libc_start_main (/lib64/libc.so.6+0x20400)
SUMMARY: AddressSanitizer: double-free (/lib64/libasan.so.3+0xc6b00) in free
==1==ABORTING
```
Closes #5015
Peter Hutterer [Fri, 6 Jan 2017 09:29:17 +0000 (19:29 +1000)]
hwdb: add axis range overrides for Lenovo B590 (#5031)
https://bugs.freedesktop.org/show_bug.cgi?id=96315
Michal Sekletar [Fri, 6 Jan 2017 09:27:35 +0000 (10:27 +0100)]
tests: fix failure of test-execute if /dev/mem is not available (#5028)
/dev/mem isn't necessarily available. Recently, I've encountered arm64
systems that didn't provide raw memory access via /dev/mem. Instead,
let's use /dev/kmsg since we don't support systems w/o it anyway.
Peter Hutterer [Thu, 5 Jan 2017 09:32:14 +0000 (19:32 +1000)]
hwdb: add axis range corrections for Dell Latitude E6320 (#5022)
From https://bugs.freedesktop.org/show_bug.cgi?id=99239
Peter Hutterer [Thu, 5 Jan 2017 09:31:51 +0000 (19:31 +1000)]
hwdb: add MOUSE_WHEEL_TILT_VERTICAL/HORIZONTAL to the mouse db (#5023)
Plenty of single scroll-wheel mice have the ability to tilt the wheel to
generate horizontal wheel events. They use the same evdev axis as a real
horizontal wheel (REL_HWHEEL) and are indistinguishable to userspace from the
real thing. libinput promises physical degrees for wheel events but that's not
accurate for those tilting wheels, hence mark them as tilting wheels so we can
treat them like the special snowflakes they think they are.
Peter Hutterer [Wed, 4 Jan 2017 03:41:13 +0000 (13:41 +1000)]
Merge pull request #5001 from tsmock/g502
hwdb/70-mouse.hwdb: Add Logitech Wired Mouse (G502)
Dan Streetman [Tue, 3 Jan 2017 19:39:50 +0000 (14:39 -0500)]
udev-rules: perform whitespace replacement for symlink subst values
If the string_escape option is either unset or 'replace' (i.e. if it is
not 'none'), then enable whitespace replacement in SYMLINK variable
substitution values, as added in the last patch.
This will keep any whitespace that is directly contained in a SYMLINK
value, but will replace any whitespace that is added to the SYMLINK
value as a result of variable substitution (except $result/%c).
This fixes bug 4833.