Karol Herbst [Sat, 3 Jun 2023 12:59:41 +0000 (14:59 +0200)]
rusticl: add proc macro module for generating API stubs
Most of the API stubs are very very trivial to generate as the sole
purpose of those are to deconstruct the returned `Result` object.
Sadly we can't use external crates yet, so "syn" and "qoute" can't be used
for this :'(
The code is kinda hacky, but we also don't expose this to other people, so
we can keep this as a big hack until we can use external crates.
I wish there was a better solution here.
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23413>
Lucas Stach [Thu, 8 Jun 2023 20:03:41 +0000 (22:03 +0200)]
etnaviv: rs: unconditionally flush color and depth cache before using RS
When the RS uses the pixel pipes it seems to destroy/invalidate any
content sitting in the color and depth caches from a previous draw.
Always flush the color and depth cache before using the RS to make
sure that any cache content written by the PE is properly flushed
to memory.
Fixes spec@!opengl 1.0@gl-1.0-drawpixels-depth-test and probably a
few others that are suffering from corruption of PE writes.
CC: mesa-stable
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23530>
Lucas Stach [Thu, 8 Jun 2023 19:58:19 +0000 (21:58 +0200)]
etnaviv: rs: flush TS cache before making configuration changes
Move the TS cache flush into the same conditional block where
the TS setup is changed. TS cache always needs to be flushed
before making any changes to the TS setup.
CC: mesa-stable
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23530>
Hyunjun Ko [Thu, 8 Jun 2023 07:48:54 +0000 (09:48 +0200)]
anv/video: move video requirements to outarray.
Signed-off-by: Hyunjun Ko <zzoon@igalia.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23519>
Martin Roukala (né Peres) [Thu, 1 Jun 2023 10:25:33 +0000 (13:25 +0300)]
ci/b2c: update to mesa-trigger:2023-03-08.1
This should speed up job submission by 3 to 30 seconds depending on
the farm the machine is hosted in, and how busy it is.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23361>
Gert Wollny [Wed, 14 Dec 2022 09:12:49 +0000 (10:12 +0100)]
rusticl: compile r600 driver
To really use the driver it still needs to be enabled with
export RUSTICL_ENABLE=r600
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20252>
Gert Wollny [Wed, 14 Dec 2022 09:59:47 +0000 (10:59 +0100)]
r600/sfn: Handle load_global in 64 to vec2 lowering
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20252>
Gert Wollny [Wed, 14 Dec 2022 09:59:04 +0000 (10:59 +0100)]
r600/sfn: Handle store_global when lowering 64 bit ops to vec2
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20252>
Gert Wollny [Fri, 9 Dec 2022 16:02:37 +0000 (17:02 +0100)]
r600/sfn: Add experimental support for load/store_global
This is needed for rusticl, but the results may be unexpected.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20252>
Lionel Landwerlin [Thu, 17 Nov 2022 21:32:21 +0000 (23:32 +0200)]
intel/nir: switch ray query state tracking to local variables uint16_t
We should be able to use uint8_t but there appears to be a backend
bug.
Q2RTX shader compute shader improvement with ray queries :
Totals:
Instrs: 102221 -> 101499 (-0.71%); split: -0.82%, +0.12%
Cycles: 4451260 -> 4396025 (-1.24%)
Send messages: 3587 -> 3585 (-0.06%)
Spill count: 717 -> 658 (-8.23%)
Fill count: 1248 -> 1214 (-2.72%); split: -3.21%, +0.48%
Scratch Memory Size: 21504 -> 16384 (-23.81%)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ivan Briano <ivan.briano@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19982>
Dave Airlie [Fri, 9 Jun 2023 02:55:11 +0000 (12:55 +1000)]
radv/video: fix hevc scaling list order.
pps takes priority.
Fixes:
da54b57888cf ("radv/video: fix hevc scaling lists.")
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23537>
Dave Airlie [Thu, 8 Jun 2023 03:07:09 +0000 (13:07 +1000)]
radv/video: report bad profile operation if h264 profile isn't supported.
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23537>
Qiang Yu [Mon, 5 Jun 2023 09:31:23 +0000 (17:31 +0800)]
radeonsi: enable aco support for gs copy shader
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Thu, 1 Jun 2023 06:45:18 +0000 (14:45 +0800)]
radeonsi: enable aco for standalone gs
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Fri, 2 Jun 2023 08:25:47 +0000 (16:25 +0800)]
ac/llvm,radeonsi: lower nir_load_ring_gsvs_amd in abi
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Thu, 1 Jun 2023 07:12:50 +0000 (15:12 +0800)]
radeonsi: add scratch_offset arg for aco gs
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 07:45:20 +0000 (15:45 +0800)]
radeonsi: enable aco support for standalone tes
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 09:40:02 +0000 (17:40 +0800)]
radeonsi: update lds size for tes
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 08:25:58 +0000 (16:25 +0800)]
radeonsi: init tes aco shader info fields
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 07:44:01 +0000 (15:44 +0800)]
radeonsi: add scratch_offset arg for aco tes
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 07:10:10 +0000 (15:10 +0800)]
radeonsi: enable aco support for mono standalone tcs
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 06:58:37 +0000 (14:58 +0800)]
ac/llvm,radeonsi: lower nir_load_ring_tess_offchip_amd in abi
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 05:50:22 +0000 (13:50 +0800)]
radeonsi: lower nir_load_tess_rel_patch_id_amd in abi for aco
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Tue, 23 May 2023 03:10:18 +0000 (11:10 +0800)]
radeonsi: add scratch_offset arg for aco tcs
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23433>
Qiang Yu [Wed, 31 May 2023 08:33:34 +0000 (16:33 +0800)]
ac/nir,radv: add 1 dword to ES/GS item size
This reduce LDS bank conflict and align with radeonsi,
so we don't assume LDS access 16 byte aligned for both
driver.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23314>
Qiang Yu [Tue, 30 May 2023 07:47:20 +0000 (15:47 +0800)]
ac/nir,radv: add 1 dword to LS/HS vertex stride
This reduce LDS bank conflict and align with radeonsi,
so we don't assume LDS access 16 byte aligned for both
driver.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23314>
Christian Gmeiner [Wed, 7 Jun 2023 07:48:26 +0000 (09:48 +0200)]
ci/etnaviv: add asan run
Has more a PoC state that it works and needs some time get stable.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23493>
Christian Gmeiner [Wed, 7 Jun 2023 07:42:24 +0000 (09:42 +0200)]
ci: add debian-arm32-asan
I want to have the possibility to use asan in for etnaviv ci. As lot
devices in the my CI farm are arm32 based lets do some prep work.
I had to skip the mesa:util suite as there are some asan problems
on 32bit platform with the hash_map. Once they got sorted out we can
enable the suite again.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23493>
Caio Oliveira [Tue, 6 Jun 2023 06:31:17 +0000 (23:31 -0700)]
intel/compiler: Refactor dump_instruction(s)
Delete unnecessary virtual functions, we need just two. Refactor code
so the 'default behavior' logic (stderr and/or creating file) is not
duplicated.
Rename the virtuals so overrides don't hide the common convenience
functions. Finally, provide a variant of dump_instructions() with
a `FILE *` parameter.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23457>
Caio Oliveira [Wed, 7 Jun 2023 18:08:36 +0000 (11:08 -0700)]
spirv: Use vtn_translate_scope for OpReadClockKHR
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23508>
Caio Oliveira [Wed, 7 Jun 2023 18:01:09 +0000 (11:01 -0700)]
spirv: Refactor and rename scope translation helper
This will make the change from nir_scope to mesa_scope
later less noisy.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23508>
Juston Li [Wed, 7 Jun 2023 17:59:10 +0000 (10:59 -0700)]
docs: venus: update extension support
Advertise support for the follow extensions:
- VK_EXT_non_seamless_cube_map
- VK_EXT_dynamic_rendering_unused_attachments
- VK_KHR_shader_clock
- VK_EXT_border_color_swizzle
- VK_EXT_fragment_shader_interlock
- VK_EXT_shader_subgroup_ballot
- VK_EXT_color_write_enable
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 23:05:18 +0000 (16:05 -0700)]
venus: enable VK_EXT_color_write_enable
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 22:46:20 +0000 (15:46 -0700)]
venus: enable VK_EXT_shader_subgroup_ballot
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 22:33:33 +0000 (15:33 -0700)]
venus: enable VK_EXT_fragment_shader_interlock
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 22:22:24 +0000 (15:22 -0700)]
venus: enable VK_EXT_border_color_swizzle
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 21:49:39 +0000 (14:49 -0700)]
venus: enable VK_KHR_shader_clock
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 21:32:12 +0000 (14:32 -0700)]
venus: enable VK_EXT_dynamic_rendering_unused_attachments
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 17:56:55 +0000 (10:56 -0700)]
venus: enable VK_EXT_non_seamless_cube_map
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 17:56:17 +0000 (10:56 -0700)]
venus: sync protocol for multiple extensions for zink
- VK_EXT_non_seamless_cube_map
- VK_EXT_dynamic_rendering_unused_attachments
- VK_KHR_shader_clock
- VK_EXT_border_color_swizzle
- VK_EXT_fragment_shader_interlock
- VK_EXT_shader_subgroup_ballot
- VK_EXT_color_write_enable
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Juston Li [Wed, 7 Jun 2023 20:54:25 +0000 (13:54 -0700)]
venus: sync to latest protocol header from v1.3.252
Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23510>
Rhys Perry [Wed, 7 Jun 2023 11:13:22 +0000 (12:13 +0100)]
util/tests: add gc_alloc_size alignment tests
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23501>
Rhys Perry [Wed, 7 Jun 2023 11:04:49 +0000 (12:04 +0100)]
util: fix gc_alloc_size alignment
This was only aligning the gc_block_header. The returned pointer could be
incorrectly aligned.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Fixes:
69a9b343e8d ("util: add freelist allocator with mark/sweep")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9166
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23501>
Karol Herbst [Wed, 7 Jun 2023 21:14:18 +0000 (23:14 +0200)]
clc: relax spec constant validation
Multiple values can have multiple spec constants assigned and vtn handles
this just fine. So just drop that assert as we need it to run SyCL
kernels.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9037
Fixes:
a699844ffba ("microsoft/clc: Parse SPIR-V specialization consts into metadata")
Signed-off-by: Karol Herbst <git@karolherbst.de>
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23512>
Karol Herbst [Thu, 8 Jun 2023 12:42:00 +0000 (14:42 +0200)]
rusticl: fix clippy errors on image_slice_pitch change to usize
That field got changed from `unsigned` to `uintptr_t` on the C side, so
now we can drop a bit of code dealing with conversions to `usize`.
Fixes:
68735f4e860 ("treewide: use uint64_t / (u)intptr_t in image address calculations")
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23522>
Karol Herbst [Thu, 8 Jun 2023 11:40:03 +0000 (13:40 +0200)]
ci: add and use clippy for rusticl
Acked-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23522>
Eric Engestrom [Thu, 8 Jun 2023 14:18:58 +0000 (16:18 +0200)]
docs: update calendar for 23.1.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23525>
Eric Engestrom [Thu, 8 Jun 2023 14:17:27 +0000 (16:17 +0200)]
docs/relnotes: add sha256sum for 23.1.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23525>
Eric Engestrom [Thu, 8 Jun 2023 10:57:01 +0000 (12:57 +0200)]
docs: add release notes for 23.1.2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23525>
Marek Olšák [Wed, 31 May 2023 15:09:03 +0000 (11:09 -0400)]
mesa: fix glBitmap in display lists when width <= 0 || height <= 0
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8904
Fixes:
bb860f63 - mesa: create glBitmap textures while creating display lists
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23335>
Timur Kristóf [Mon, 17 Apr 2023 23:56:51 +0000 (01:56 +0200)]
radv: Clarify gang submit terminology.
This is done to better match the terminology used by the kernel
and also because the follower may not always be ACE in the future.
- Gang: a group of command streams that are submitted to
more than one HW queue at the same time.
- Leader: the main command stream of a command buffer that works
on the queue type of the command buffer.
- Follower: a command stream on a different HW queue that doesn't
have a separate command buffer state and is submitted together
with its leader.
During submission, a follower must always precede the leader in
the submitted command streams array.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23462>
Mike Blumenkrantz [Thu, 8 Jun 2023 13:27:13 +0000 (09:27 -0400)]
zink: update some radv qbo fails
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23511>
Mike Blumenkrantz [Thu, 11 May 2023 14:29:00 +0000 (10:29 -0400)]
zink: stop swizzling conditional render during batch flush
conditional render is only supposed to be enabled during renderpasses,
and this ends up doing mismatched start/stop in and out of renderpasses
affects:
GTF-GL46.gtf30.GL3Tests.conditional_render*
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23511>
Mike Blumenkrantz [Fri, 2 Jun 2023 12:44:23 +0000 (08:44 -0400)]
zink: remove assert for dt in zink_kopper_update
this is a valid (harmless) path that can be hit by in some cases
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23511>
Mike Blumenkrantz [Wed, 7 Jun 2023 12:48:19 +0000 (08:48 -0400)]
zink: check for cached mem correctly when mapping buffer
bo placement is the mem index, not the mem flags
Fixes:
52f27cda05b ("zink: allow direct memory mapping for any COHERENT+CACHED buffer")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23511>
Mike Blumenkrantz [Wed, 31 May 2023 19:27:30 +0000 (15:27 -0400)]
zink: don't check prog->shaders when creating gfx pipeline
these objects don't technically belong to the pipeline, and checking
them may lead to inconsistent results in some corner cases
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23511>
Mike Blumenkrantz [Thu, 25 May 2023 18:14:23 +0000 (14:14 -0400)]
zink: combine some rast state draw conditionals
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23511>
norablackcat [Thu, 8 Jun 2023 10:17:02 +0000 (04:17 -0600)]
docs/features update opencl extensions add rusticl
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23055>
norablackcat [Thu, 8 Jun 2023 10:16:50 +0000 (04:16 -0600)]
rusticl: add cl_khr_create_command_queue
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23055>
Eric Engestrom [Thu, 8 Jun 2023 11:09:00 +0000 (13:09 +0200)]
docs/relnotes/23.1.1: clear "new features"
I should've done this after 23.1.0/before 23.1.1, but I forgot :]
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23521>
Rhys Perry [Tue, 6 Jun 2023 11:02:02 +0000 (12:02 +0100)]
aco/tests: test that s_bfe bits is masked
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23464>
Rhys Perry [Tue, 6 Jun 2023 09:55:16 +0000 (10:55 +0100)]
aco: mask bits source of s_bfe
The s_bfe instructions use 7 bits, not 5 like the NIR opcode requires.
No fossil-db changes (navi21).
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9162
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23464>
Matt Coster [Fri, 24 Feb 2023 14:06:39 +0000 (14:06 +0000)]
pvr: Add support for sampler border colors
Currently only the six vulkan 1.0 pre-defined formats are supported,
but some basic infrastructure that will be useful for implementing
VK_EXT_custom_border_color (and vulkan 1.1) is included.
Only formats currently listed in the pvr_format_table in pvr_formats.c
are currently supported. Unlike most (all?) other drivers, the PowerVR
hardware requires each entry in the border color table to be encoded
for every hardware format (of which there are 128 available, plus 128
for compressed formats).
Also in this commit:
- Two new constants in rogue_texstate.xml:
- IMAGE_WORD0_TEXFORMAT_MAX_SIZE, and
- SAMPLER_BORDERCOLOR_INDEX_MAX_SIZE; and
- A new device feature (tpu_border_colour_enhanced)
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21555>
Matt Coster [Thu, 8 Jun 2023 09:32:15 +0000 (10:32 +0100)]
pvr: Declare dependency on idep_mesautil
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21555>
Christian Gmeiner [Wed, 7 Jun 2023 09:16:43 +0000 (11:16 +0200)]
etnaviv: make wider use of DBG_ENABLED(..)
Make the source code more consistent.
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23495>
Andres Gomez [Wed, 7 Jun 2023 10:32:53 +0000 (12:32 +0200)]
.mailmap: add an alias for Christian Gmeiner
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23498>
Karmjit Mahil [Fri, 13 May 2022 10:53:53 +0000 (11:53 +0100)]
pvr: HWRT creation simplifications.
Signed-off-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Reviewed-by: Matt Coster <matt.coster@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20092>
Gert Wollny [Wed, 31 May 2023 15:45:03 +0000 (17:45 +0200)]
r600/sfn: Don't rewrite TESS_EVAL inner tess level outputs
Fixes:
5cd3e3950 (r600/sfn: Make sure all components are usable when lowering TF inputs)
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23518>
Gert Wollny [Wed, 31 May 2023 15:44:16 +0000 (17:44 +0200)]
r600/sfn: add read instruction for unused but required LDS op results
DS_XCHG_RET and LDS_CMP_XCHG_RET don't have a version that doesn't return
a value in the LDS red queue. so we have to read the value from the queue
and discard it.
Fixes:
79ca456b (r600/sfn: rewrite NIR backend)
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23518>
Luigi Santivetti [Tue, 16 May 2023 13:36:24 +0000 (14:36 +0100)]
pvr: fixup assert in pvr_cmd_buffer_alloc_mem
Stop explicitly passing PVR_BO_ALLOC_FLAG_CPU_MAPPED to
pvr_cmd_buffer_alloc_mem(). This is redundant for sub-allocations,
as they are always unconditionally mapped to the CPU.
Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23463>
SoroushIMG [Tue, 16 May 2023 13:22:15 +0000 (14:22 +0100)]
pvr: fix infinite recursion in pvr_cmd_buffer_{start,end}_sub_cmd
Reported-by: James Glanville <james.glanville@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23463>
Gert Wollny [Mon, 27 Feb 2023 08:56:41 +0000 (09:56 +0100)]
util/driconf: pin minImageCount to three for "Path of Exile"
"Path of Exile" will fail with an error "unsupported backbuffer image count"
when vkGetPhysicalDeviceSurfaceCapabilitiesKHR reports more than 3 as
minImageCount.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21547>
Caio Oliveira [Wed, 7 Jun 2023 20:13:53 +0000 (13:13 -0700)]
r600/sfn: Fix warning about overloads hiding virtual functions
Fixes multiple warnings when building with g++ 13.1.1 that look like
```
./src/gallium/drivers/r600/sfn/sfn_scheduler.cpp:1111:9: warning: ‘virtual void r600::CheckArrayAccessVisitor::visit(const r600::InlineConstant&)’ was hidden [-Woverloaded-virtual=]
1111 | void visit(const InlineConstant& value) override {(void)value;}
| ^~~~~
../src/gallium/drivers/r600/sfn/sfn_scheduler.cpp:1125:9: note: by ‘virtual void r600::UpdateArrayWrite::visit(const r600::LocalArrayValue&)’
1125 | void visit(const LocalArrayValue& value) override {
| ^~~~~
(...)
```
What's going on here is when mixing overloading and virtual functions,
compiler will warn when one of the variants is not overriden. So tell
it to also use the base class definitions.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23509>
Yonggang Luo [Sun, 4 Jun 2023 06:59:45 +0000 (14:59 +0800)]
compiler: use align instead glsl_align and remove glsl_align
#include "util/u_math.h" when necessary to call align function
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23421>
Yonggang Luo [Sun, 4 Jun 2023 06:59:01 +0000 (14:59 +0800)]
util: Do not use align as variable name
Because align is also a function in u_math.h
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23421>
Yonggang Luo [Sun, 4 Jun 2023 06:42:51 +0000 (14:42 +0800)]
util: use uint32_t as the parameter of align function
align on negative value doesn't make sense
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23421>
Yonggang Luo [Mon, 5 Jun 2023 17:00:03 +0000 (01:00 +0800)]
util: Remove redundant type cast in function align64
Fixes:
0a06cf75231 ("util: migrate alignment functions and macros to use ALIGN_POT")
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23421>
Konstantin Seurer [Fri, 5 May 2023 19:34:16 +0000 (21:34 +0200)]
gallivm: Zero initialize param structs
Zero all param structs using {0} because it's shorter than a memset and
there were some instances where the structs weren't zero initialized.
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Sun, 28 May 2023 09:36:13 +0000 (11:36 +0200)]
gallivm: Handle invalid image format/op combinations
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Fri, 28 Apr 2023 09:27:52 +0000 (11:27 +0200)]
gallivm: Add lp_img_op_from_intrinsic
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Tue, 25 Apr 2023 15:32:51 +0000 (17:32 +0200)]
gallivm: Add lp_build_nir_sample_key
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Fri, 21 Apr 2023 09:43:53 +0000 (11:43 +0200)]
llvmpipe: Add lp_storage_render_image_format_supported
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Wed, 19 Apr 2023 21:00:40 +0000 (23:00 +0200)]
llvmpipe: Add lp_storage_image_format_supported
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Thu, 8 Jun 2023 03:16:49 +0000 (13:16 +1000)]
llvmpipe: refactor out the pipe->lp_jit structure fillers.
These are useful later for descriptor indexing, but refactor them
out now.
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Wed, 7 Jun 2023 20:23:52 +0000 (22:23 +0200)]
gallivm: Cast read_first_invocation source to an int
cc: mesa-stable
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Konstantin Seurer [Mon, 1 May 2023 17:35:55 +0000 (19:35 +0200)]
gallivm: Fix anisotropic sampling with num_mips=1
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23515>
Dave Airlie [Wed, 7 Jun 2023 02:05:44 +0000 (12:05 +1000)]
lavapipe: ignore another yuv format.
Since these were added to generic translation, lavapipe has
been annoyed.
Cc: mesa-stable
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23486>
Dave Airlie [Tue, 6 Jun 2023 07:30:02 +0000 (17:30 +1000)]
radv/video: fix hevc scaling lists.
These need some zscan conversion, that I've taken from vaapi.
v2: move to common code for it_ptr updates, add defines
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23476>
Dave Airlie [Wed, 31 May 2023 02:54:53 +0000 (12:54 +1000)]
radv/video: fix hevc st rps programming
These needs to be programmed to fix some video glitches.
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23476>
Dave Airlie [Wed, 31 May 2023 01:47:27 +0000 (11:47 +1000)]
radv/video: rework h265 reference frame bindings.
This reworks the ref frame bindings and allows dropping the tier_2 workaround.
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23476>
Dave Airlie [Tue, 30 May 2023 05:06:11 +0000 (15:06 +1000)]
radv/video: don't supply an 8-bit format for a 10-bit dpb.
The firmware can write an 8-bit output buffer, but still needs
a 10-bit dpb allocation.
This also puts the 8-bit format after the 10-bit format though
apps should be smart enough to pick the correct one.
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23476>
Dave Airlie [Tue, 30 May 2023 04:45:48 +0000 (14:45 +1000)]
radv/video: convert session memory requirements to outarray.
These are just standard outarray so use the common code.
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23476>
Dave Airlie [Tue, 30 May 2023 04:43:23 +0000 (14:43 +1000)]
radv/video: convert video format properties to an outarray
These are just standard outarray so use the common code.
Reviewed-by: Lynne <dev@lynne.ee>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23476>
Chia-I Wu [Wed, 7 Jun 2023 01:14:54 +0000 (18:14 -0700)]
radv: fix non-square compressed image copy on gfx9
There is a typo in fixup_gfx9_cs_copy.
Fixed dEQP-VK.api.copy_and_blit.*.image_to_buffer.2d_images.mip_copies_bc*_64x192_* in deqp 1.3.6.0.
Fixes:
35f053ba8cd ("radv: Fix corrupted mipmap copies on GFX9+")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23483>
Karol Herbst [Sat, 20 May 2023 20:29:10 +0000 (22:29 +0200)]
rusticl/event: flush queues from dependencies
We have to flush all event dependencies inside clWaitForEvents and
clFinish implicitly otherwise applications might wait forever.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9052
Fixes:
ebfffa1daec ("rusticl/event: wrong but non crashing impl of clWaitForEvents")
Cc: mesa-stable
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23110>
Karol Herbst [Wed, 24 May 2023 15:31:12 +0000 (17:31 +0200)]
rusticl: bump rust req to 1.60
We need this rustc bugfix:
https://github.com/rust-lang/rust/commit/
6466f89fc5df36b4c841fca9d10e27c50dd744b5
Cc: mesa-stable
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23110>
Karol Herbst [Wed, 24 May 2023 15:02:48 +0000 (17:02 +0200)]
doc/rusticl: add Rust Update Policy
Signed-off-by: Karol Herbst <git@karolherbst.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23110>
Matt Turner [Wed, 7 Jun 2023 00:53:41 +0000 (20:53 -0400)]
u_format: Use memcpy to avoid unaligned accesses
These functions are used by gl[Get]TexImage, which imposes no
alignment restructions on the void *pixels parameter.
This fixes an unaligned access in GTK's "gtk:gdk / memorytexture" unit
test on SPARC, which causes the test to fail.
Fixes:
45ae4434b5b ("util: Use bitshift arithmetic to unpack pixels.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23482>
Pierre-Eric Pelloux-Prayer [Wed, 7 Jun 2023 08:28:23 +0000 (10:28 +0200)]
Revert "gallium/u_threaded: buffer sharedness tracking"
This reverts commit
8f159a8576efbb7bb3755d215a54b87c4c99a0d2.
This commit is correct but it exposes an existing bug: DISCARD_RANGE doesn't
work well with shared buffers.
So for now revert this commit as it's causing hangs on some APUs (see
https://gitlab.freedesktop.org/drm/amd/-/issues/2447) and flickering in
Metro Last Light Redux.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9108
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23492>
Lionel Landwerlin [Fri, 2 Jun 2023 07:02:29 +0000 (10:02 +0300)]
anv: allow binding tables allocations on compute only queues
COMPUTE_WALKER is using binding tables.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes:
eb2b309328 ("anv: defer binding table block allocation to when necessary")
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23506>