platform/upstream/libSkiaSharp.git
11 years agorefactor duplication (shouldSkip and skip_name) into a utility function
sglez@google.com [Wed, 24 Jul 2013 17:24:23 +0000 (17:24 +0000)]
refactor duplication (shouldSkip and skip_name) into a utility function

R=caryclark@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10280

Review URL: https://codereview.chromium.org/19807005

git-svn-id: http://skia.googlecode.com/svn/trunk@10317 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix warning of implicit cast to float
reed@google.com [Wed, 24 Jul 2013 17:10:05 +0000 (17:10 +0000)]
fix warning of implicit cast to float

git-svn-id: http://skia.googlecode.com/svn/trunk@10316 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoall in the gyp
mtklein@google.com [Wed, 24 Jul 2013 16:20:05 +0000 (16:20 +0000)]
all in the gyp

BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/19726012

git-svn-id: http://skia.googlecode.com/svn/trunk@10315 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove dependency on picture_utils. add utility function to render SkStrea...
edisonn@google.com [Wed, 24 Jul 2013 15:56:19 +0000 (15:56 +0000)]
pdfviewer: remove dependency on picture_utils. add utility function to render SkStream into bitmap.

Review URL: https://codereview.chromium.org/20087003

git-svn-id: http://skia.googlecode.com/svn/trunk@10314 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRollback Nexus10, ANGLE, and Win7 expectations after r10251 revert.
fmalita@google.com [Wed, 24 Jul 2013 15:48:25 +0000 (15:48 +0000)]
Rollback Nexus10, ANGLE, and Win7 expectations after r10251 revert.

This is a revert of r10252.

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/20064006

git-svn-id: http://skia.googlecode.com/svn/trunk@10313 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpose shaders
reed@google.com [Wed, 24 Jul 2013 15:47:52 +0000 (15:47 +0000)]
expose shaders

git-svn-id: http://skia.googlecode.com/svn/trunk@10312 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline.py: set text mimetype for all .json files, so text diffs work
epoger@google.com [Wed, 24 Jul 2013 15:38:39 +0000 (15:38 +0000)]
rebaseline.py: set text mimetype for all .json files, so text diffs work
BUG=https://code.google.com/p/skia/issues/detail?id=1442
R=fmalita@google.com

Review URL: https://codereview.chromium.org/20017009

git-svn-id: http://skia.googlecode.com/svn/trunk@10311 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet all gm expected-results.json files to text mimetype
epoger@google.com [Wed, 24 Jul 2013 15:38:29 +0000 (15:38 +0000)]
Set all gm expected-results.json files to text mimetype
BUG=https://code.google.com/p/skia/issues/detail?id=1442
R=fmalita@google.com

Review URL: https://codereview.chromium.org/19577017

git-svn-id: http://skia.googlecode.com/svn/trunk@10310 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SK_DECLARE_STATIC_MUTEX
reed@google.com [Wed, 24 Jul 2013 15:06:34 +0000 (15:06 +0000)]
use SK_DECLARE_STATIC_MUTEX

git-svn-id: http://skia.googlecode.com/svn/trunk@10309 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse sk_bzero to init level, since I got the number of 0s wrong using { }
reed@google.com [Wed, 24 Jul 2013 14:55:00 +0000 (14:55 +0000)]
use sk_bzero to init level, since I got the number of 0s wrong using { }

git-svn-id: http://skia.googlecode.com/svn/trunk@10308 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline Android after update to freetype 2.5.0
fmalita@google.com [Wed, 24 Jul 2013 14:32:04 +0000 (14:32 +0000)]
rebaseline Android after update to freetype 2.5.0

R=epoger@google.com

Review URL: https://codereview.chromium.org/19550010

git-svn-id: http://skia.googlecode.com/svn/trunk@10306 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd mipmaps to scaledimagecache
reed@google.com [Wed, 24 Jul 2013 14:31:33 +0000 (14:31 +0000)]
add mipmaps to scaledimagecache

BUG=

Review URL: https://codereview.chromium.org/19789016

git-svn-id: http://skia.googlecode.com/svn/trunk@10305 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10251 (Implement crop rect for SkImageFilter) due to Chromium-side unit...
robertphillips@google.com [Wed, 24 Jul 2013 13:18:06 +0000 (13:18 +0000)]
Reverting r10251 (Implement crop rect for SkImageFilter) due to Chromium-side unit test failures

git-svn-id: http://skia.googlecode.com/svn/trunk@10304 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 24 Jul 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10299 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDeterministic SkTSet and PDF Output
commit-bot@chromium.org [Wed, 24 Jul 2013 01:51:08 +0000 (01:51 +0000)]
Deterministic SkTSet and PDF Output

Addresses this issue: https://code.google.com/p/skia/issues/detail?id=1277

R=edisonn@google.com, vandebo@chromium.org

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19283005

git-svn-id: http://skia.googlecode.com/svn/trunk@10298 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplemented transparent gradients
commit-bot@chromium.org [Tue, 23 Jul 2013 23:16:03 +0000 (23:16 +0000)]
Implemented transparent gradients

R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18585002

git-svn-id: http://skia.googlecode.com/svn/trunk@10297 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove dead defines from SkUserConfig.h
reed@google.com [Tue, 23 Jul 2013 22:03:26 +0000 (22:03 +0000)]
remove dead defines from SkUserConfig.h

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/19599011

git-svn-id: http://skia.googlecode.com/svn/trunk@10296 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Clang build on SkPDFResourceDict (CL 18977002)
commit-bot@chromium.org [Tue, 23 Jul 2013 21:49:29 +0000 (21:49 +0000)]
Fix Clang build on SkPDFResourceDict (CL 18977002)

R=edisonn@google.com, vandebo@chromium.org

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19954011

git-svn-id: http://skia.googlecode.com/svn/trunk@10295 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: more simple fixed to prevent crashes
edisonn@google.com [Tue, 23 Jul 2013 21:05:49 +0000 (21:05 +0000)]
pdfviewer: more simple fixed to prevent crashes

Review URL: https://codereview.chromium.org/19625008

git-svn-id: http://skia.googlecode.com/svn/trunk@10294 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: don't crash if the xref is corrupted.
edisonn@google.com [Tue, 23 Jul 2013 20:47:05 +0000 (20:47 +0000)]
pdfviewer: don't crash if the xref is corrupted.

Review URL: https://codereview.chromium.org/20004007

git-svn-id: http://skia.googlecode.com/svn/trunk@10293 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkChecksum::Murmur3.
commit-bot@chromium.org [Tue, 23 Jul 2013 20:25:34 +0000 (20:25 +0000)]
Add SkChecksum::Murmur3.
BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/19500020

git-svn-id: http://skia.googlecode.com/svn/trunk@10292 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoskpdiff: remove default value for output. Diifs can be very big, and fill a hard...
edisonn@google.com [Tue, 23 Jul 2013 20:15:08 +0000 (20:15 +0000)]
skpdiff: remove default value for output. Diifs can be very big, and fill a hard drive, no sense to generate them if not needed.

R=zachr@google.com

Review URL: https://codereview.chromium.org/20054003

git-svn-id: http://skia.googlecode.com/svn/trunk@10291 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf we fail to contruct the Pdf Image Shader, mark the object as busted, and dn't...
edisonn@google.com [Tue, 23 Jul 2013 19:45:38 +0000 (19:45 +0000)]
If we fail to contruct the Pdf Image Shader, mark the object as busted, and dn't try to remove it from shaders list. Also, when we delete invalid shaders, remove the lock, otherwise we freeze (see CanonicalShadersMutex usage).

R=vandebo@chromium.org

Review URL: https://codereview.chromium.org/19509005

git-svn-id: http://skia.googlecode.com/svn/trunk@10290 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: fix type3 font, make SkPdfObject::get parameter const
edisonn@google.com [Tue, 23 Jul 2013 19:43:48 +0000 (19:43 +0000)]
pdfviewer: fix type3 font, make SkPdfObject::get parameter const

Review URL: https://codereview.chromium.org/19670019

git-svn-id: http://skia.googlecode.com/svn/trunk@10289 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove gm-expected to trunk/expectations/gm , and modify scripts that use it.
epoger@google.com [Tue, 23 Jul 2013 19:37:03 +0000 (19:37 +0000)]
Move gm-expected to trunk/expectations/gm , and modify scripts that use it.
Left dummy content in the old gm-expected dir to keep Update step happy,
to avoid the breakages caused by r10281.

R=borenet@google.com

Review URL: https://codereview.chromium.org/19668009

git-svn-id: http://skia.googlecode.com/svn/trunk@10288 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix signed/unsigned warning
reed@google.com [Tue, 23 Jul 2013 19:27:48 +0000 (19:27 +0000)]
fix signed/unsigned warning

git-svn-id: http://skia.googlecode.com/svn/trunk@10287 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd scaledimagecache
reed@google.com [Tue, 23 Jul 2013 19:13:54 +0000 (19:13 +0000)]
add scaledimagecache

BUG=

Review URL: https://codereview.chromium.org/20005003

git-svn-id: http://skia.googlecode.com/svn/trunk@10286 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10281 -- it broke the Update step on Test builders
epoger@google.com [Tue, 23 Jul 2013 18:32:55 +0000 (18:32 +0000)]
Revert r10281 -- it broke the Update step on Test builders

git-svn-id: http://skia.googlecode.com/svn/trunk@10285 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10280, which caused https://code.google.com/p/skia/issues/detail?id=1441
epoger@google.com [Tue, 23 Jul 2013 17:56:20 +0000 (17:56 +0000)]
Revert r10280, which caused https://code.google.com/p/skia/issues/detail?id=1441

Review URL: https://codereview.chromium.org/19537005

git-svn-id: http://skia.googlecode.com/svn/trunk@10284 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: improve memory usage, improve parse time (by 30-50%) and don't allocate...
edisonn@google.com [Tue, 23 Jul 2013 17:43:18 +0000 (17:43 +0000)]
pdfviewer: improve memory usage, improve parse time (by 30-50%) and don't allocate extra buffers (more to do, but low priority now), and put the page specific memory in an allocator.

Review URL: https://codereview.chromium.org/19793011

git-svn-id: http://skia.googlecode.com/svn/trunk@10282 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove gm-expected to trunk/expectations/gm , and modify scripts that use it.
epoger@google.com [Tue, 23 Jul 2013 17:35:43 +0000 (17:35 +0000)]
Move gm-expected to trunk/expectations/gm , and modify scripts that use it.

R=borenet@google.com

Review URL: https://codereview.chromium.org/19697017

git-svn-id: http://skia.googlecode.com/svn/trunk@10281 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorefactor duplication (shouldSkip and skip_name) into a utility function
sglez@google.com [Tue, 23 Jul 2013 17:26:34 +0000 (17:26 +0000)]
refactor duplication (shouldSkip and skip_name) into a utility function

R=caryclark@google.com, reed@google.com

Review URL: https://codereview.chromium.org/19807005

git-svn-id: http://skia.googlecode.com/svn/trunk@10280 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove dead SampleDecode.cpp
reed@google.com [Tue, 23 Jul 2013 16:20:28 +0000 (16:20 +0000)]
remove dead SampleDecode.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@10275 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkImage->draw() call with src and dst rects.
commit-bot@chromium.org [Tue, 23 Jul 2013 15:52:16 +0000 (15:52 +0000)]
Add SkImage->draw() call with src and dst rects.

Committed: http://code.google.com/p/skia/source/detail?r=10237

R=junov@chromium.org, senorblanco@chromium.org, reed@google.com

Author: arbesfeld@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19729007

git-svn-id: http://skia.googlecode.com/svn/trunk@10274 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate freetype to version 2.5.0.1 when building it from source.
djsollen@google.com [Tue, 23 Jul 2013 15:51:12 +0000 (15:51 +0000)]
Update freetype to version 2.5.0.1 when building it from source.

R=bungeman@google.com

Review URL: https://codereview.chromium.org/19625006

git-svn-id: http://skia.googlecode.com/svn/trunk@10273 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SKIA_OUT variable in make.py
borenet@google.com [Tue, 23 Jul 2013 15:45:50 +0000 (15:45 +0000)]
Use SKIA_OUT variable in make.py

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19743005

git-svn-id: http://skia.googlecode.com/svn/trunk@10272 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoturn off debugging printfs
caryclark@google.com [Tue, 23 Jul 2013 15:27:41 +0000 (15:27 +0000)]
turn off debugging printfs

fix pathops issues 1417, 1418

be more rigorous about pulling intersections of lines to end points
rewrite cubic/line and quad/line intersections to share style

BUG=

Review URL: https://codereview.chromium.org/19543005

git-svn-id: http://skia.googlecode.com/svn/trunk@10270 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate gyp DEPS
borenet@google.com [Tue, 23 Jul 2013 14:46:58 +0000 (14:46 +0000)]
Update gyp DEPS

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19996003

git-svn-id: http://skia.googlecode.com/svn/trunk@10266 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRoll freetype back to 2.4.9 until Android/NaCL errors are resolved.
djsollen@google.com [Tue, 23 Jul 2013 13:54:58 +0000 (13:54 +0000)]
Roll freetype back to 2.4.9 until Android/NaCL errors are resolved.

R=borenet@google.com, fmalita@google.com

Review URL: https://codereview.chromium.org/19956003

git-svn-id: http://skia.googlecode.com/svn/trunk@10264 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoput max on outputted poi in skpdiff
zachr@google.com [Tue, 23 Jul 2013 12:57:52 +0000 (12:57 +0000)]
put max on outputted poi in skpdiff

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19601006

git-svn-id: http://skia.googlecode.com/svn/trunk@10262 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate freetype DEPS to version 2.5 with PNG encoded color bitmap glyphs
djsollen@google.com [Tue, 23 Jul 2013 12:22:11 +0000 (12:22 +0000)]
Update freetype DEPS to version 2.5 with PNG encoded color bitmap glyphs

R=bungeman@google.com

Review URL: https://codereview.chromium.org/19931003

git-svn-id: http://skia.googlecode.com/svn/trunk@10259 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAccidentally skipped buildbot runs on r10257
borenet@google.com [Tue, 23 Jul 2013 12:20:28 +0000 (12:20 +0000)]
Accidentally skipped buildbot runs on r10257

Review URL: https://codereview.chromium.org/19598005

git-svn-id: http://skia.googlecode.com/svn/trunk@10258 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoI don't want these changes as part of the "allow bleeding" CL.
commit-bot@chromium.org [Tue, 23 Jul 2013 11:28:45 +0000 (11:28 +0000)]
I don't want these changes as part of the "allow bleeding" CL.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/19842002

git-svn-id: http://skia.googlecode.com/svn/trunk@10256 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn on -Wall -Wextra on Mac, and fix all the warnings that crop up for /usr/bin...
commit-bot@chromium.org [Tue, 23 Jul 2013 11:13:56 +0000 (11:13 +0000)]
Turn on -Wall -Wextra on Mac, and fix all the warnings that crop up for /usr/bin/g++ and Clang 3.3.
BUG=
R=bungeman@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/19569012

git-svn-id: http://skia.googlecode.com/svn/trunk@10255 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 23 Jul 2013 07:01:05 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10254 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis patch implements a crop rect for SkImageFilter. It has been implemented for...
senorblanco@chromium.org [Mon, 22 Jul 2013 20:03:22 +0000 (20:03 +0000)]
This patch implements a crop rect for SkImageFilter. It has been implemented for SkColorFilterImageFilter and SkBlurImageFilter as examples.

In order to preserve the immutability of SkImageFilters, the crop rect is passed as a constructor parameter. If NULL (the default), the bounds of the input image are used, as before.

This also tightens up the boundary handling for SkImageBlurFilter on the GPU backend. Where we were previously using clamping semantics, we now respect decal semantics (so we don't oversaturate the edges). This brings the GPU and raster backends into closer alignment, but will require some new baselines for the GPU tests.

At a minimum, the following tests will need new baselines: imageblur, imagefiltersbase, imagefilterscropped, spritebitmap.

R=reed@google.com

Review URL: https://codereview.chromium.org/19775006

git-svn-id: http://skia.googlecode.com/svn/trunk@10251 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLast friday I changed this file to un-break the build.
commit-bot@chromium.org [Mon, 22 Jul 2013 19:28:40 +0000 (19:28 +0000)]
Last friday I changed this file to un-break the build.
I introduced a bug in my tool that is fixed by this CL.

R=caryclark@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19780004

git-svn-id: http://skia.googlecode.com/svn/trunk@10250 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove skpdiff into tools
zachr@google.com [Mon, 22 Jul 2013 18:46:45 +0000 (18:46 +0000)]
move skpdiff into tools

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19608005

git-svn-id: http://skia.googlecode.com/svn/trunk@10249 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Adds SkPDFResourceDict class, refactor existing code to use it."
vandebo@chromium.org [Mon, 22 Jul 2013 18:31:24 +0000 (18:31 +0000)]
Revert "Adds SkPDFResourceDict class, refactor existing code to use it."

This reverts commit r10245

Review URL: https://codereview.chromium.org/19523007

git-svn-id: http://skia.googlecode.com/svn/trunk@10247 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdds SkPDFResourceDict class, refactor existing code to use it.
commit-bot@chromium.org [Mon, 22 Jul 2013 18:20:52 +0000 (18:20 +0000)]
Adds SkPDFResourceDict class, refactor existing code to use it.

Committed: http://code.google.com/p/skia/source/detail?r=10202

R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18977002

git-svn-id: http://skia.googlecode.com/svn/trunk@10245 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoinclude SkPaint.h
reed@google.com [Mon, 22 Jul 2013 17:44:54 +0000 (17:44 +0000)]
include SkPaint.h

git-svn-id: http://skia.googlecode.com/svn/trunk@10244 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocopy/paste error. don't use s.
reed@google.com [Mon, 22 Jul 2013 17:33:43 +0000 (17:33 +0000)]
copy/paste error. don't use s.

git-svn-id: http://skia.googlecode.com/svn/trunk@10243 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: SkTDict, does accept to pass the length of the key also. We will use it...
edisonn@google.com [Mon, 22 Jul 2013 17:29:43 +0000 (17:29 +0000)]
pdfviewer: SkTDict, does accept to pass the length of the key also. We will use it, as this is a prerequirment for optimizing memory usage for pdf parser.

Review URL: https://codereview.chromium.org/19964003

git-svn-id: http://skia.googlecode.com/svn/trunk@10242 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorename fFilterQuality to fFilterLevel
reed@google.com [Mon, 22 Jul 2013 17:26:19 +0000 (17:26 +0000)]
rename fFilterQuality to fFilterLevel

git-svn-id: http://skia.googlecode.com/svn/trunk@10241 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agostop using bitmap-filter flags outside of paint itself, as a step towards really...
reed@google.com [Mon, 22 Jul 2013 17:18:18 +0000 (17:18 +0000)]
stop using bitmap-filter flags outside of paint itself, as a step towards really changing them into an enum

BUG=

Review URL: https://codereview.chromium.org/19825002

git-svn-id: http://skia.googlecode.com/svn/trunk@10240 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoports for mac, ios, android, linux, windows
zachr@google.com [Mon, 22 Jul 2013 17:05:24 +0000 (17:05 +0000)]
ports for mac, ios, android, linux, windows

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19787006

git-svn-id: http://skia.googlecode.com/svn/trunk@10239 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add SkImage->draw() call with src and dst rects."
fmalita@google.com [Mon, 22 Jul 2013 17:01:37 +0000 (17:01 +0000)]
Revert "Add SkImage->draw() call with src and dst rects."

This reverts commit 9c730e27e0bb550dc228ad496cadeed8787b2244.

git-svn-id: http://skia.googlecode.com/svn/trunk@10238 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkImage->draw() call with src and dst rects.
commit-bot@chromium.org [Mon, 22 Jul 2013 16:16:37 +0000 (16:16 +0000)]
Add SkImage->draw() call with src and dst rects.

R=junov@chromium.org, senorblanco@chromium.org, reed@google.com

Author: arbesfeld@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19729007

git-svn-id: http://skia.googlecode.com/svn/trunk@10237 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: All NulCanvas (does not draw operations), TrackDevice (trackes what pixels...
edisonn@google.com [Mon, 22 Jul 2013 15:36:39 +0000 (15:36 +0000)]
pdfviewer: All NulCanvas (does not draw operations), TrackDevice (trackes what pixels have been changed)

Review URL: https://codereview.chromium.org/19793006

git-svn-id: http://skia.googlecode.com/svn/trunk@10236 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: fix typo (false != NULL)
edisonn@google.com [Mon, 22 Jul 2013 15:29:55 +0000 (15:29 +0000)]
pdfviewer: fix typo (false != NULL)

Review URL: https://codereview.chromium.org/19543016

git-svn-id: http://skia.googlecode.com/svn/trunk@10235 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd --csv parameter to skpdiff to dump all scores in a csv file. We can run it with...
edisonn@google.com [Mon, 22 Jul 2013 15:24:26 +0000 (15:24 +0000)]
Add --csv parameter to skpdiff to dump all scores in a csv file. We can run it with all skps, and have scores available to look at worst offenders progarmatically.

R=djsollen@google.com, zachr@google.com

Review URL: https://codereview.chromium.org/19826002

git-svn-id: http://skia.googlecode.com/svn/trunk@10234 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClean up a few warnings on Windows x64.
bungeman@google.com [Mon, 22 Jul 2013 15:21:23 +0000 (15:21 +0000)]
Clean up a few warnings on Windows x64.

git-svn-id: http://skia.googlecode.com/svn/trunk@10233 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate obvious deps.
bungeman@google.com [Mon, 22 Jul 2013 14:39:45 +0000 (14:39 +0000)]
Update obvious deps.

This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root, then everything
in skia_lib pointing toward core as best possible, then everything
outside skia_lib depending on skia_lib for things in skia_lib. This
prevents double definitions where a symbol is provided by both the
skia_lib shared object and and a statically linked component of skia_lib.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19823003

git-svn-id: http://skia.googlecode.com/svn/trunk@10231 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate android_make to use arrays instead of space delimited strings
djsollen@google.com [Mon, 22 Jul 2013 14:18:08 +0000 (14:18 +0000)]
Update android_make to use arrays instead of space delimited strings

R=borenet@google.com

Review URL: https://codereview.chromium.org/19796008

git-svn-id: http://skia.googlecode.com/svn/trunk@10230 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorefactor gyp to isolate freetype usage
djsollen@google.com [Mon, 22 Jul 2013 14:12:56 +0000 (14:12 +0000)]
refactor gyp to isolate freetype usage

R=bungeman@google.com

Review URL: https://codereview.chromium.org/19835002

git-svn-id: http://skia.googlecode.com/svn/trunk@10229 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake the copy of fontconfig font names before freeing their memory.
bungeman@google.com [Mon, 22 Jul 2013 14:10:08 +0000 (14:10 +0000)]
Make the copy of fontconfig font names before freeing their memory.

R=reed@google.com

Review URL: https://codereview.chromium.org/19466004

git-svn-id: http://skia.googlecode.com/svn/trunk@10228 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "migrate skpdiff to tools"
zachr@google.com [Mon, 22 Jul 2013 13:29:20 +0000 (13:29 +0000)]
Revert "migrate skpdiff to tools"

This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.

git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomigrate skpdiff to tools
zachr@google.com [Mon, 22 Jul 2013 13:14:04 +0000 (13:14 +0000)]
migrate skpdiff to tools

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkNWayCanvas comment API overrides.
commit-bot@chromium.org [Sat, 20 Jul 2013 15:03:26 +0000 (15:03 +0000)]
Add SkNWayCanvas comment API overrides.

SkNWayCanvas should also dispatch beginCommentGroup(), addComment() & endCommentGroup.

R=robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19723012

git-svn-id: http://skia.googlecode.com/svn/trunk@10224 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 20 Jul 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10223 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert deps changes in r10220 and r10217.
bungeman@google.com [Sat, 20 Jul 2013 00:24:35 +0000 (00:24 +0000)]
Revert deps changes in r10220 and r10217.

Need to avoid linking in .a things which are already provided by .so things.

git-svn-id: http://skia.googlecode.com/svn/trunk@10222 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a 'unique' method to SkRefCnt, document the usage, and add support.
bungeman@google.com [Fri, 19 Jul 2013 23:18:52 +0000 (23:18 +0000)]
Add a 'unique' method to SkRefCnt, document the usage, and add support.

std::shared_ptr has a method called 'unique' which captures the concept that
a reference count of 1 is special, and can be used to optimize copy on write.
It also has some undocumented need for memory barriers in certain situations
and those needs are documented here.

The motivation for looking into this is crbug.com/258499 . The use of the
reference count in this manner is a benign race with both ref() and unref().
By introducing sk_atomic_unprotected_read, it is possible for Chromium to
annotate this read to tell ThreadSanitizer that this is known.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18770007

git-svn-id: http://skia.googlecode.com/svn/trunk@10221 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLie about views_animated dependencies until Android situation is resolved.
bungeman@google.com [Fri, 19 Jul 2013 23:10:37 +0000 (23:10 +0000)]
Lie about views_animated dependencies until Android situation is resolved.

git-svn-id: http://skia.googlecode.com/svn/trunk@10220 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix latent warning as error in Android specific code.
bungeman@google.com [Fri, 19 Jul 2013 22:43:15 +0000 (22:43 +0000)]
Fix latent warning as error in Android specific code.

git-svn-id: http://skia.googlecode.com/svn/trunk@10219 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a detachAsStream to SkDynamicMemoryWStream.
bungeman@google.com [Fri, 19 Jul 2013 22:32:11 +0000 (22:32 +0000)]
Add a detachAsStream to SkDynamicMemoryWStream.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10171

Committed: https://code.google.com/p/skia/source/detail?r=10178

Review URL: https://codereview.chromium.org/19677002

git-svn-id: http://skia.googlecode.com/svn/trunk@10218 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate obvious deps.
bungeman@google.com [Fri, 19 Jul 2013 22:31:23 +0000 (22:31 +0000)]
Update obvious deps.

This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root,
then opts, ports, and utils depending on core, then everything else.
We will need some other change to resolve the fact that
core, opts, ports, and utils depend on each other and other targets which
depend on them. Outside of these targets, things look ok.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19823003

git-svn-id: http://skia.googlecode.com/svn/trunk@10217 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix some noisy warnings on Windows x64.
bungeman@google.com [Fri, 19 Jul 2013 22:30:11 +0000 (22:30 +0000)]
Fix some noisy warnings on Windows x64.

On Windows x64, sizeof(long) < sizeof(size_t).

Review URL: https://codereview.chromium.org/19786010

git-svn-id: http://skia.googlecode.com/svn/trunk@10216 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Slipping in a small bug fix for my previous patch"
reed@google.com [Fri, 19 Jul 2013 21:45:10 +0000 (21:45 +0000)]
Revert "Slipping in a small bug fix for my previous patch"

This reverts commit 1908ef0441e37c98b00ffe6c0a89d247393aeead.

git-svn-id: http://skia.googlecode.com/svn/trunk@10215 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobad line in gyp fie snuck into last commit, continuing the ARM breakage
humper@google.com [Fri, 19 Jul 2013 21:26:15 +0000 (21:26 +0000)]
bad line in gyp fie snuck into last commit, continuing the ARM breakage

git-svn-id: http://skia.googlecode.com/svn/trunk@10214 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSlipping in a small bug fix for my previous patch
sglez@google.com [Fri, 19 Jul 2013 21:19:11 +0000 (21:19 +0000)]
Slipping in a small bug fix for my previous patch

Review URL: https://codereview.chromium.org/19858002

git-svn-id: http://skia.googlecode.com/svn/trunk@10213 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SK_ScalarPI, and fix ARM build
humper@google.com [Fri, 19 Jul 2013 21:12:08 +0000 (21:12 +0000)]
use SK_ScalarPI, and fix ARM build

git-svn-id: http://skia.googlecode.com/svn/trunk@10212 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agostruct and class forward declarations incompatible on some compilers
humper@google.com [Fri, 19 Jul 2013 20:52:12 +0000 (20:52 +0000)]
struct and class forward declarations incompatible on some compilers

git-svn-id: http://skia.googlecode.com/svn/trunk@10211 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoscale --> convolution typo
humper@google.com [Fri, 19 Jul 2013 20:46:20 +0000 (20:46 +0000)]
scale --> convolution typo

git-svn-id: http://skia.googlecode.com/svn/trunk@10210 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomissing M_PI include needed on Windows
humper@google.com [Fri, 19 Jul 2013 20:33:36 +0000 (20:33 +0000)]
missing M_PI include needed on Windows

git-svn-id: http://skia.googlecode.com/svn/trunk@10209 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove unused function
humper@google.com [Fri, 19 Jul 2013 20:30:44 +0000 (20:30 +0000)]
remove unused function

git-svn-id: http://skia.googlecode.com/svn/trunk@10208 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix mac
sglez@google.com [Fri, 19 Jul 2013 20:21:05 +0000 (20:21 +0000)]
fix mac

BUG=

Review URL: https://codereview.chromium.org/19845003

git-svn-id: http://skia.googlecode.com/svn/trunk@10207 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe image resampling code has been transplanted from Chrome; it's incredibly fast.
humper@google.com [Fri, 19 Jul 2013 20:20:04 +0000 (20:20 +0000)]
The image resampling code has been transplanted from Chrome; it's incredibly fast.

We've tested this CL plumbed into Chrome and done benchmarking with excellent results.

This CL can land independent of any Chrome changes; it's completely internal to skia.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/19335002

git-svn-id: http://skia.googlecode.com/svn/trunk@10206 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Adds SkPDFResourceDict class to manage resource dicts. Refactors existing...
vandebo@chromium.org [Fri, 19 Jul 2013 20:13:44 +0000 (20:13 +0000)]
Revert "Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class."

This reverts commit r10202

Review URL: https://codereview.chromium.org/19790007

git-svn-id: http://skia.googlecode.com/svn/trunk@10205 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoplease fix the build, please
sglez@google.com [Fri, 19 Jul 2013 20:03:57 +0000 (20:03 +0000)]
please fix the build, please
BUG=

Review URL: https://codereview.chromium.org/19693012

git-svn-id: http://skia.googlecode.com/svn/trunk@10204 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd include to fix build
sglez@google.com [Fri, 19 Jul 2013 19:50:00 +0000 (19:50 +0000)]
Add include to fix build

BUG=

Review URL: https://codereview.chromium.org/19516006

git-svn-id: http://skia.googlecode.com/svn/trunk@10203 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdds SkPDFResourceDict class to manage resource dicts. Refactors existing code to...
commit-bot@chromium.org [Fri, 19 Jul 2013 18:58:34 +0000 (18:58 +0000)]
Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class.

BUG=
R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18977002

git-svn-id: http://skia.googlecode.com/svn/trunk@10202 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build problem with reverted issue 16948011
commit-bot@chromium.org [Fri, 19 Jul 2013 18:54:04 +0000 (18:54 +0000)]
Fix build problem with reverted issue 16948011

BUG=
R=caryclark@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19541009

git-svn-id: http://skia.googlecode.com/svn/trunk@10201 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unneeded mention of SkThread_pthread.cpp in ports.gyp.
bungeman@google.com [Fri, 19 Jul 2013 18:51:10 +0000 (18:51 +0000)]
Remove unneeded mention of SkThread_pthread.cpp in ports.gyp.

This was overlooked in r10105.

git-svn-id: http://skia.googlecode.com/svn/trunk@10200 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBench performance trigger rebaselines
robertphillips@google.com [Fri, 19 Jul 2013 18:20:26 +0000 (18:20 +0000)]
Bench performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10198 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix texture allocation in SWMaskHelper
robertphillips@google.com [Fri, 19 Jul 2013 18:13:02 +0000 (18:13 +0000)]
Fix texture allocation in SWMaskHelper

https://codereview.chromium.org/19789006/

git-svn-id: http://skia.googlecode.com/svn/trunk@10197 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert unreviewed 10194, will send to review
edisonn@google.com [Fri, 19 Jul 2013 17:47:39 +0000 (17:47 +0000)]
revert unreviewed 10194, will send to review

Review URL: https://codereview.chromium.org/19693010

git-svn-id: http://skia.googlecode.com/svn/trunk@10196 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkAlpha constant defs
commit-bot@chromium.org [Fri, 19 Jul 2013 17:43:27 +0000 (17:43 +0000)]
SkAlpha constant defs

R=edisonn@google.com, vandebo@chromium.org, reed@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19592014

git-svn-id: http://skia.googlecode.com/svn/trunk@10195 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoskpdiff: add ability to write the diff scores in a csv file (one line per pair of...
edisonn@google.com [Fri, 19 Jul 2013 17:19:47 +0000 (17:19 +0000)]
skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with the result of each diff engine)

Review URL: https://codereview.chromium.org/19786004

git-svn-id: http://skia.googlecode.com/svn/trunk@10194 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAlter resource cache and GrContext to (optionally) never reuse a scratch texture
robertphillips@google.com [Fri, 19 Jul 2013 16:51:46 +0000 (16:51 +0000)]
Alter resource cache and GrContext to (optionally) never reuse a scratch texture

https://codereview.chromium.org/19482004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10193 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd reformat-json.py script
epoger@google.com [Fri, 19 Jul 2013 15:45:22 +0000 (15:45 +0000)]
add reformat-json.py script

R=borenet@google.com

Review URL: https://codereview.chromium.org/19289011

git-svn-id: http://skia.googlecode.com/svn/trunk@10192 2bbb7eff-a529-9590-31e7-b0007b416f81