platform/upstream/libSkiaSharp.git
11 years agogm: add self-test to confirm that ignore-failure field is respected
epoger@google.com [Fri, 30 Aug 2013 20:19:25 +0000 (20:19 +0000)]
gm: add self-test to confirm that ignore-failure field is respected
BUG=skia:1578
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23799004

git-svn-id: http://skia.googlecode.com/svn/trunk@11047 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIsolate VertexBuilder from GrGLShaderBuilder
commit-bot@chromium.org [Fri, 30 Aug 2013 20:17:31 +0000 (20:17 +0000)]
Isolate VertexBuilder from GrGLShaderBuilder

Adds a nested class to GrGLShaderBuilder called VertexBuilder. Now
GrGLShaderBuilder can only modify the fragment shader directly. In
order to modify the vertex shader, the client code needs to call
getVertexShader, which will return null for vertex-less shaders.

R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/23754003

git-svn-id: http://skia.googlecode.com/svn/trunk@11046 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRename ShaderType enum to ShaderVisibility
commit-bot@chromium.org [Fri, 30 Aug 2013 19:43:59 +0000 (19:43 +0000)]
Rename ShaderType enum to ShaderVisibility

Renames ShaderType in GrGLShaderBuilder to ShaderVisibility. It is now
used solely as a bitfield. Methods that previously accepted a single
ShaderType value are split into separate calls:

 - getShader -> vsGetShader, gsGetShader, fsGetShader
 - emiitFunction -> fsEmitFunction
 - appendTextureLookup -> fsAppendTextureLookup

No change in functionality. This is a refactoring to allow us to
separate the vertex/geometry and fragment parts of GrGLShaderBuilder.

R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/23826002

git-svn-id: http://skia.googlecode.com/svn/trunk@11044 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd bit to GrGLCaps for fixed function support
commit-bot@chromium.org [Fri, 30 Aug 2013 19:43:47 +0000 (19:43 +0000)]
Add bit to GrGLCaps for fixed function support

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23587014

git-svn-id: http://skia.googlecode.com/svn/trunk@11043 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing .outs
sglez@google.com [Fri, 30 Aug 2013 18:54:54 +0000 (18:54 +0000)]
Add missing .outs

Review URL: https://codereview.chromium.org/23567005

git-svn-id: http://skia.googlecode.com/svn/trunk@11042 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix rtree bench
sglez@google.com [Fri, 30 Aug 2013 18:38:53 +0000 (18:38 +0000)]
Fix rtree bench

R=caryclark@google.com

Review URL: https://codereview.chromium.org/23609009

git-svn-id: http://skia.googlecode.com/svn/trunk@11041 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix invalid enum error when checking for core profile in GrGLInterface::validate()
bsalomon@google.com [Fri, 30 Aug 2013 18:25:21 +0000 (18:25 +0000)]
Fix invalid enum error when checking for core profile in GrGLInterface::validate()

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23691022

git-svn-id: http://skia.googlecode.com/svn/trunk@11040 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 4 image rebaselines for r11021
robertphillips@google.com [Fri, 30 Aug 2013 17:44:13 +0000 (17:44 +0000)]
Nexus 4 image rebaselines for r11021

git-svn-id: http://skia.googlecode.com/svn/trunk@11039 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix rtree tests build error
sglez@google.com [Fri, 30 Aug 2013 17:43:31 +0000 (17:43 +0000)]
Fix rtree tests build error

Review URL: https://codereview.chromium.org/23531019

git-svn-id: http://skia.googlecode.com/svn/trunk@11038 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoR-Tree -- Don't sort draw commands unless specified.
sglez@google.com [Fri, 30 Aug 2013 17:27:47 +0000 (17:27 +0000)]
R-Tree -- Don't sort draw commands unless specified.
We expect Webkit and Bink to give us draw commands in a reasonable x,y order.
We can maintain correctness and get a 17% recording speedup for the R-Tree by
not sorting in x and y when bulk-loading.

R=caryclark@google.com, reed@google.com

Review URL: https://codereview.chromium.org/23480002

git-svn-id: http://skia.googlecode.com/svn/trunk@11037 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for r11021
robertphillips@google.com [Fri, 30 Aug 2013 17:26:16 +0000 (17:26 +0000)]
Image rebaselines for r11021

git-svn-id: http://skia.googlecode.com/svn/trunk@11036 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix stroked oval and rrect rendering on Ubuntu-x86-Release.
commit-bot@chromium.org [Fri, 30 Aug 2013 16:34:52 +0000 (16:34 +0000)]
Fix stroked oval and rrect rendering on Ubuntu-x86-Release.

The Ubuntu-x86 compiler was optimizing out a case where I was
reseting the isStroked boolean based on the new inner radii.
This changes it to check the radii at the time the effect is
created, which tricks the compiler into doing the right thing.

R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/23592021

git-svn-id: http://skia.googlecode.com/svn/trunk@11035 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd ShouldSkip variant that can read a --match flag directly.
commit-bot@chromium.org [Fri, 30 Aug 2013 15:52:46 +0000 (15:52 +0000)]
Add ShouldSkip variant that can read a --match flag directly.

Just seemed like we were going through lots of hoops for this common case.

BUG=
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/23708009

git-svn-id: http://skia.googlecode.com/svn/trunk@11034 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModify GLSL version declaration to allow access to compat. features
commit-bot@chromium.org [Fri, 30 Aug 2013 15:52:36 +0000 (15:52 +0000)]
Modify GLSL version declaration to allow access to compat. features

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23526008

git-svn-id: http://skia.googlecode.com/svn/trunk@11033 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd glTexGen funcs to interface
commit-bot@chromium.org [Fri, 30 Aug 2013 15:52:12 +0000 (15:52 +0000)]
Add glTexGen funcs to interface

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23513006

git-svn-id: http://skia.googlecode.com/svn/trunk@11032 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for r11021
robertphillips@google.com [Fri, 30 Aug 2013 15:02:48 +0000 (15:02 +0000)]
Image rebaselines for r11021

git-svn-id: http://skia.googlecode.com/svn/trunk@11030 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for r11021
robertphillips@google.com [Fri, 30 Aug 2013 14:36:44 +0000 (14:36 +0000)]
Image rebaselines for r11021

git-svn-id: http://skia.googlecode.com/svn/trunk@11029 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for r11021
robertphillips@google.com [Fri, 30 Aug 2013 13:56:08 +0000 (13:56 +0000)]
Image rebaselines for r11021

git-svn-id: http://skia.googlecode.com/svn/trunk@11026 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for r11021
robertphillips@google.com [Fri, 30 Aug 2013 13:31:06 +0000 (13:31 +0000)]
Image rebaselines for r11021

git-svn-id: http://skia.googlecode.com/svn/trunk@11025 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoStop running bench_pictures with msaa4 on Galaxy Nexus
borenet@google.com [Fri, 30 Aug 2013 13:19:18 +0000 (13:19 +0000)]
Stop running bench_pictures with msaa4 on Galaxy Nexus

Hopefully this works around https://code.google.com/p/skia/issues/detail?id=1560

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23449017

git-svn-id: http://skia.googlecode.com/svn/trunk@11023 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove SkBitmapDevice functions to their own file
robertphillips@google.com [Fri, 30 Aug 2013 13:12:10 +0000 (13:12 +0000)]
Move SkBitmapDevice functions to their own file

https://codereview.chromium.org/23553006/

git-svn-id: http://skia.googlecode.com/svn/trunk@11022 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove blur from text labels in tilemodes* GMs
robertphillips@google.com [Fri, 30 Aug 2013 12:41:42 +0000 (12:41 +0000)]
Remove blur from text labels in tilemodes* GMs

https://codereview.chromium.org/23617003/

git-svn-id: http://skia.googlecode.com/svn/trunk@11021 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 30 Aug 2013 07:01:34 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@11017 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace SkTScopedPtr with SkAutoTDelete in Skia.
commit-bot@chromium.org [Thu, 29 Aug 2013 22:14:04 +0000 (22:14 +0000)]
Replace SkTScopedPtr with SkAutoTDelete in Skia.

BUG=
R=djsollen@google.com, reed@google.com, vandebo@chromium.org

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/23621005

git-svn-id: http://skia.googlecode.com/svn/trunk@11016 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix windows test error for CanvasStateTest.cpp
djsollen@google.com [Thu, 29 Aug 2013 20:36:22 +0000 (20:36 +0000)]
fix windows test error for CanvasStateTest.cpp

Review URL: https://codereview.chromium.org/23539005

git-svn-id: http://skia.googlecode.com/svn/trunk@11015 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Fix image references.
commit-bot@chromium.org [Thu, 29 Aug 2013 20:26:41 +0000 (20:26 +0000)]
[PDF] Fix image references.

Chrome doesn't seem to honor the reference to the pixel ref. A copy is necessary for unpremultiplication anyway, so pull that part in now.

BUG=chromium:279640
R=reed@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23730003

git-svn-id: http://skia.googlecode.com/svn/trunk@11014 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate a semi-stable API for capturing the state of an SkCanvas and reconstructing...
djsollen@google.com [Thu, 29 Aug 2013 20:20:40 +0000 (20:20 +0000)]
Create a semi-stable API for capturing the state of an SkCanvas and reconstructing that state across different versions of Skia.

R=joth@chromium.org, mtklein@google.com, reed@google.com, scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11010

Review URL: https://codereview.chromium.org/23545017

git-svn-id: http://skia.googlecode.com/svn/trunk@11013 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodump out sizeof(void*) in header
reed@google.com [Thu, 29 Aug 2013 20:20:39 +0000 (20:20 +0000)]
dump out sizeof(void*) in header

BUG=
R=rmistry@google.com

Review URL: https://codereview.chromium.org/23773003

git-svn-id: http://skia.googlecode.com/svn/trunk@11012 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Create a semi-stable API for capturing the state of an SkCanvas and reconstru...
djsollen@google.com [Thu, 29 Aug 2013 19:41:56 +0000 (19:41 +0000)]
Revert "Create a semi-stable API for capturing the state of an SkCanvas and reconstructing that state across different versions of Skia."

This reverts r11010.

Review URL: https://codereview.chromium.org/23757008

git-svn-id: http://skia.googlecode.com/svn/trunk@11011 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate a semi-stable API for capturing the state of an SkCanvas and reconstructing...
djsollen@google.com [Thu, 29 Aug 2013 19:29:09 +0000 (19:29 +0000)]
Create a semi-stable API for capturing the state of an SkCanvas and reconstructing that state across different versions of Skia.

R=joth@chromium.org, mtklein@google.com, reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/23545017

git-svn-id: http://skia.googlecode.com/svn/trunk@11010 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGalaxy Nexus image rebaselines for r10936 (Blur refactoring)
robertphillips@google.com [Thu, 29 Aug 2013 18:20:53 +0000 (18:20 +0000)]
Galaxy Nexus image rebaselines for r10936 (Blur refactoring)

git-svn-id: http://skia.googlecode.com/svn/trunk@11009 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline.py self-test: validate that unknown fields are maintained
epoger@google.com [Thu, 29 Aug 2013 18:04:20 +0000 (18:04 +0000)]
rebaseline.py self-test: validate that unknown fields are maintained
BUG=skia:1569
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23702006

git-svn-id: http://skia.googlecode.com/svn/trunk@11008 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMoving out of order call to TexParameteri in GrGpuGL::onCreateTexture
junov@chromium.org [Thu, 29 Aug 2013 16:22:09 +0000 (16:22 +0000)]
Moving out of order call to TexParameteri in GrGpuGL::onCreateTexture

BUG=crbug.com/278940
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23514014

git-svn-id: http://skia.googlecode.com/svn/trunk@11007 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert determinant-based ScaleTranslate inverse.
commit-bot@chromium.org [Thu, 29 Aug 2013 15:34:50 +0000 (15:34 +0000)]
Revert determinant-based ScaleTranslate inverse.
The current code fails the unit tests on Ubuntu32 Release.
This will pass the tests, and also removes sk_bzero().

R=reed@google.com, robertphillips@google.com, shawnsingh@chromium.org

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/23477020

git-svn-id: http://skia.googlecode.com/svn/trunk@11006 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGet debugger compiling in NoGPU config
robertphillips@google.com [Thu, 29 Aug 2013 13:22:28 +0000 (13:22 +0000)]
Get debugger compiling in NoGPU config

git-svn-id: http://skia.googlecode.com/svn/trunk@11001 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoYet another patch for 10995
robertphillips@google.com [Thu, 29 Aug 2013 12:53:23 +0000 (12:53 +0000)]
Yet another patch for 10995

git-svn-id: http://skia.googlecode.com/svn/trunk@10998 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch for 10995
robertphillips@google.com [Thu, 29 Aug 2013 12:40:26 +0000 (12:40 +0000)]
Patch for 10995

git-svn-id: http://skia.googlecode.com/svn/trunk@10997 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch for r10995
robertphillips@google.com [Thu, 29 Aug 2013 12:10:20 +0000 (12:10 +0000)]
Patch for r10995

git-svn-id: http://skia.googlecode.com/svn/trunk@10996 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSplit SkDevice into SkBaseDevice and SkBitmapDevice
robertphillips@google.com [Thu, 29 Aug 2013 11:54:56 +0000 (11:54 +0000)]
Split SkDevice into SkBaseDevice and SkBitmapDevice

https://codereview.chromium.org/22978012/

git-svn-id: http://skia.googlecode.com/svn/trunk@10995 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland 'Update expectations for skimage.'
scroggo@google.com [Thu, 29 Aug 2013 10:24:44 +0000 (10:24 +0000)]
Reland 'Update expectations for skimage.'

Now that expectations have moved to use the builder_name rather than
the gm_subdir (see https://code.google.com/p/skia/source/detail?r=10923),
check in a new set which uses the proper name.

Committed: https://code.google.com/p/skia/source/detail?r=10969

Reverted in https://code.google.com/p/skia/source/detail?r=10970
due to failures on builders without an attached device. Can
resubmit once https://codereview.chromium.org/23495007/ is
submitted.

Review URL: https://codereview.chromium.org/23600004

git-svn-id: http://skia.googlecode.com/svn/trunk@10993 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 29 Aug 2013 07:01:20 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10992 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexport SkFontMgr_New_... experimental functions for testing in chrome
reed@google.com [Wed, 28 Aug 2013 20:31:58 +0000 (20:31 +0000)]
export SkFontMgr_New_... experimental functions for testing in chrome

BUG=
R=eae@chromium.org

Review URL: https://codereview.chromium.org/23555004

git-svn-id: http://skia.googlecode.com/svn/trunk@10991 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't require getLength on Mac.
scroggo@google.com [Wed, 28 Aug 2013 19:13:13 +0000 (19:13 +0000)]
Don't require getLength on Mac.

For consistency with our other image decoders, do not depend on getLength
in Mac specific decoder.

BUG=skia:1570
R=djsollen@google.com

Review URL: https://codereview.chromium.org/23004008

git-svn-id: http://skia.googlecode.com/svn/trunk@10990 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove temporary workaround TODOs from tools/tests/run.sh
epoger@google.com [Wed, 28 Aug 2013 19:04:05 +0000 (19:04 +0000)]
Remove temporary workaround TODOs from tools/tests/run.sh

R=rmistry@google.com

Review URL: https://codereview.chromium.org/23490009

git-svn-id: http://skia.googlecode.com/svn/trunk@10989 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove sk_bzero usage from SkMatrix44 for improved performance.
shawnsingh@chromium.org [Wed, 28 Aug 2013 18:55:25 +0000 (18:55 +0000)]
Remove sk_bzero usage from SkMatrix44 for improved performance.

sk_bzero is not efficient for initializing small chunks of memory. Instead,
directly initializing matrix values when needed results in substantial
performance improvements.

BUG=skia:1558
R=reed@google.com

Review URL: https://codereview.chromium.org/23090008

git-svn-id: http://skia.googlecode.com/svn/trunk@10988 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDelete empty subdirs under tools/tests/rebaseline
epoger@google.com [Wed, 28 Aug 2013 18:47:49 +0000 (18:47 +0000)]
Delete empty subdirs under tools/tests/rebaseline

git-svn-id: http://skia.googlecode.com/svn/trunk@10987 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTest decoders when hasLength returns false.
scroggo@google.com [Wed, 28 Aug 2013 18:33:31 +0000 (18:33 +0000)]
Test decoders when hasLength returns false.

Compare the result of a decode of a stream without a length to the
result of the same stream with a length. Ensures that our decoders
work regardless of whether hasLength returns true (since the decode
potentially follows two paths).

R=epoger@google.com

Review URL: https://codereview.chromium.org/23598004

git-svn-id: http://skia.googlecode.com/svn/trunk@10984 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobbh_shootout: Move bitmap rendering out of the timing codepath.
commit-bot@chromium.org [Wed, 28 Aug 2013 16:02:47 +0000 (16:02 +0000)]
bbh_shootout: Move bitmap rendering out of the timing codepath.

R=reed@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/23639003

git-svn-id: http://skia.googlecode.com/svn/trunk@10983 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name.
commit-bot@chromium.org [Wed, 28 Aug 2013 15:59:13 +0000 (15:59 +0000)]
Fix case where GrGLEffectMatrix gives back a dangling ptr for the coords var name.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23706003

git-svn-id: http://skia.googlecode.com/svn/trunk@10982 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix state machine so we know simple only loops once, but we can call maprect in debug...
reed@google.com [Wed, 28 Aug 2013 15:23:19 +0000 (15:23 +0000)]
fix state machine so we know simple only loops once, but we can call maprect in debug mode

Revert "Revert of r10943."

This reverts commit 9e83074cce521d3cc3b8b3a9b819a612a07d800a.

BUG=
R=tomhudson@google.com

Review URL: https://codereview.chromium.org/23618005

git-svn-id: http://skia.googlecode.com/svn/trunk@10981 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARM Skia NEON patches - 15 - Preparation work for Blitmask optims
commit-bot@chromium.org [Wed, 28 Aug 2013 15:07:58 +0000 (15:07 +0000)]
ARM Skia NEON patches - 15 - Preparation work for Blitmask optims

Blitmask: copy empty factory functions to a new file

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/21120007

git-svn-id: http://skia.googlecode.com/svn/trunk@10980 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace uses of GR_DEBUG by SK_DEBUG.
commit-bot@chromium.org [Wed, 28 Aug 2013 14:17:03 +0000 (14:17 +0000)]
Replace uses of GR_DEBUG by SK_DEBUG.

BUG=None
R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23137022

git-svn-id: http://skia.googlecode.com/svn/trunk@10978 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHandle SkStream::rewind properly.
scroggo@google.com [Wed, 28 Aug 2013 13:08:54 +0000 (13:08 +0000)]
Handle SkStream::rewind properly.

include/core/SkStream.h:
Update documentation to state that rewinding a stream at the beginning
should return true. This is important because our decoders fail if
rewind returns false, assuming that the stream is not at the beginning.

src/images/SkImageDecoder_libpng.cpp:
If rewind fails, call png_error.

src/images/SkImageDecoder_libwebp.cpp:
If rewind fails, report an error and return false.

src/images/SkImageRef.cpp:
If rewind fails report an error and return false.
FIXME: Need to handle flattening properly. Should I perhaps move
writeStream into SkOrderedWriteBuffer?

src/images/SkJpegUtility.cpp:
Report a jpeg error on failure to rewind.

BUG=https://b.corp.google.com/issue?id=8432093
R=bungeman@google.com, djsollen@google.com, reed@google.com

Review URL: https://codereview.chromium.org/22861028

git-svn-id: http://skia.googlecode.com/svn/trunk@10977 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMissed a Nexus4 image rebaseline
robertphillips@google.com [Wed, 28 Aug 2013 12:50:16 +0000 (12:50 +0000)]
Missed a Nexus4 image rebaseline

git-svn-id: http://skia.googlecode.com/svn/trunk@10976 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerformance trigger rebaselines of theverge on Nexus7 for r10936 (Blur refactoring)
robertphillips@google.com [Wed, 28 Aug 2013 12:37:31 +0000 (12:37 +0000)]
Performance trigger rebaselines of theverge on Nexus7 for r10936 (Blur refactoring)

git-svn-id: http://skia.googlecode.com/svn/trunk@10975 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test the Commit Queue.
commit-bot@chromium.org [Wed, 28 Aug 2013 12:36:22 +0000 (12:36 +0000)]
Whitespace change to test the Commit Queue.

(SkipBuildbotRuns)

R=borenet@google.com

Author: rmistry@google.com

Review URL: https://chromiumcodereview.appspot.com/23448008

git-svn-id: http://skia.googlecode.com/svn/trunk@10974 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove less then useful configs from bench_pictures runs
robertphillips@google.com [Wed, 28 Aug 2013 12:31:49 +0000 (12:31 +0000)]
Remove less then useful configs from bench_pictures runs

https://codereview.chromium.org/23618004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10973 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix issue on devices running an OS prior to 4.2 when the fallback font file was poten...
djsollen@google.com [Wed, 28 Aug 2013 12:29:45 +0000 (12:29 +0000)]
fix issue on devices running an OS prior to 4.2 when the fallback font file was potential stored in a different location on device.

BUG=chromium:183830
R=scroggo@google.com

Review URL: https://codereview.chromium.org/23621002

git-svn-id: http://skia.googlecode.com/svn/trunk@10972 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Update expectations for skimage."
scroggo@google.com [Wed, 28 Aug 2013 10:50:37 +0000 (10:50 +0000)]
Revert "Update expectations for skimage."

This reverts commit c154d36bd319baa1472189ecb212805e08f3c00b.

Reverting due to build failure in prerender.

git-svn-id: http://skia.googlecode.com/svn/trunk@10970 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate expectations for skimage.
scroggo@google.com [Wed, 28 Aug 2013 10:26:01 +0000 (10:26 +0000)]
Update expectations for skimage.

Now that expectations have moved to use the builder_name rather than
the gm_subdir (see https://code.google.com/p/skia/source/detail?r=10923),
check in a new set which uses the proper name.

Review URL: https://codereview.chromium.org/23600004

git-svn-id: http://skia.googlecode.com/svn/trunk@10969 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 28 Aug 2013 07:01:18 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10968 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd performance benchmark before landing perf improvements that remove sk_bezero...
shawnsingh@chromium.org [Wed, 28 Aug 2013 05:07:26 +0000 (05:07 +0000)]
Add performance benchmark before landing perf improvements that remove sk_bezero in SkMatrix44

BUG=skia:1558
R=jvanverth@google.com

Review URL: https://codereview.chromium.org/22872015

git-svn-id: http://skia.googlecode.com/svn/trunk@10967 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for 10963: Use mx instead of my where mx is wanted.
bungeman@google.com [Wed, 28 Aug 2013 03:16:02 +0000 (03:16 +0000)]
Fix for 10963: Use mx instead of my where mx is wanted.

git-svn-id: http://skia.googlecode.com/svn/trunk@10966 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSome missed tilemodes image rebaselines
robertphillips@google.com [Tue, 27 Aug 2013 22:25:53 +0000 (22:25 +0000)]
Some missed tilemodes image rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@10965 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Win7 x86 Debug/Nexus4 Release/Ubuntu x86 Debug and Release
robertphillips@google.com [Tue, 27 Aug 2013 22:21:11 +0000 (22:21 +0000)]
Image rebaselines for Win7 x86 Debug/Nexus4 Release/Ubuntu x86 Debug and Release

git-svn-id: http://skia.googlecode.com/svn/trunk@10964 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClear unknown DirectWrite font metrics.
bungeman@google.com [Tue, 27 Aug 2013 21:51:37 +0000 (21:51 +0000)]
Clear unknown DirectWrite font metrics.

git-svn-id: http://skia.googlecode.com/svn/trunk@10963 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn image filters, apply the CTM and offset to the crop rect. This is necessary to...
senorblanco@chromium.org [Tue, 27 Aug 2013 21:37:01 +0000 (21:37 +0000)]
In image filters, apply the CTM and offset to the crop rect. This is necessary to compensate for both clipping applied by the compositor (communicated via the CTM) and for cropping applied in upstream image filters (communicated via the offset). This requires a few ugly conversions, since the crop rect is an SkIRect, and the ctm is an SkMatrix.

I also had to offset the matrix passed to filter evaluation by drawSprite() and internalDrawBitmap() by the primitive position. This is the same offset that is applied when drawing the primitive, to compensate for the internal saveLayer().

Also apply the total matrix to the filter params in asNewEffect(), so that (for example) lighting params are offset by both the compositor clipping and upstream crop rects.

R=reed@google.com

Review URL: https://codereview.chromium.org/23295017

git-svn-id: http://skia.googlecode.com/svn/trunk@10961 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Ubuntu NoGPU x86_64
robertphillips@google.com [Tue, 27 Aug 2013 21:34:37 +0000 (21:34 +0000)]
Image rebaselines for Ubuntu NoGPU x86_64

git-svn-id: http://skia.googlecode.com/svn/trunk@10960 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Nexus7 Release/Debug
robertphillips@google.com [Tue, 27 Aug 2013 21:31:22 +0000 (21:31 +0000)]
Image rebaselines for Nexus7 Release/Debug

git-svn-id: http://skia.googlecode.com/svn/trunk@10959 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage baselines for Nexus 10 Debug/Release
robertphillips@google.com [Tue, 27 Aug 2013 21:18:50 +0000 (21:18 +0000)]
Image baselines for Nexus 10 Debug/Release

git-svn-id: http://skia.googlecode.com/svn/trunk@10958 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Nexus S Debug/Release
robertphillips@google.com [Tue, 27 Aug 2013 21:13:15 +0000 (21:13 +0000)]
Image rebaselines for Nexus S Debug/Release

git-svn-id: http://skia.googlecode.com/svn/trunk@10957 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Mac 10.7 x86/x86_64 Debug/Release
robertphillips@google.com [Tue, 27 Aug 2013 21:03:01 +0000 (21:03 +0000)]
Image rebaselines for Mac 10.7 x86/x86_64 Debug/Release

git-svn-id: http://skia.googlecode.com/svn/trunk@10956 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Mac10.6 x86/x86_64 Debug/Release
robertphillips@google.com [Tue, 27 Aug 2013 20:43:50 +0000 (20:43 +0000)]
Image rebaselines for Mac10.6 x86/x86_64 Debug/Release

git-svn-id: http://skia.googlecode.com/svn/trunk@10955 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly destroy huffman if build succeeded.
scroggo@google.com [Tue, 27 Aug 2013 20:42:22 +0000 (20:42 +0000)]
Only destroy huffman if build succeeded.

The earlier code assumed that if jpeg_create_huffman_index
succeeded but jpeg_build_huffman_index failed that the
index would still need to be destroyed. This is not the
case. Only call jpeg_destroy_huffman_index if both
succeeded.

BUG=http://b.corp.google.com/issue?id=10263847

Review URL: https://codereview.chromium.org/22859042

git-svn-id: http://skia.googlecode.com/svn/trunk@10954 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Ubuntu12 x86 Debug & Release & x86_64 Debug
robertphillips@google.com [Tue, 27 Aug 2013 20:29:57 +0000 (20:29 +0000)]
Image rebaselines for Ubuntu12 x86 Debug & Release & x86_64 Debug

git-svn-id: http://skia.googlecode.com/svn/trunk@10952 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Win7 x86 Release
robertphillips@google.com [Tue, 27 Aug 2013 20:06:15 +0000 (20:06 +0000)]
Image rebaselines for Win7 x86 Release

git-svn-id: http://skia.googlecode.com/svn/trunk@10951 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage rebaselines for Win7 x86_64 Release & Debug
robertphillips@google.com [Tue, 27 Aug 2013 20:02:18 +0000 (20:02 +0000)]
Image rebaselines for Win7 x86_64 Release & Debug

git-svn-id: http://skia.googlecode.com/svn/trunk@10950 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImage baselines for Win7 x86 Release ANGLE & DirectWrite
robertphillips@google.com [Tue, 27 Aug 2013 19:44:06 +0000 (19:44 +0000)]
Image baselines for Win7 x86 Release ANGLE & DirectWrite

git-svn-id: http://skia.googlecode.com/svn/trunk@10949 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWin7 x86 Debug DirectWrite rebaselines for 10936
robertphillips@google.com [Tue, 27 Aug 2013 19:39:03 +0000 (19:39 +0000)]
Win7 x86 Debug DirectWrite rebaselines for 10936

git-svn-id: http://skia.googlecode.com/svn/trunk@10948 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselines for Win7 x86 Debug ANGLE
robertphillips@google.com [Tue, 27 Aug 2013 19:31:04 +0000 (19:31 +0000)]
Rebaselines for Win7 x86 Debug ANGLE

git-svn-id: http://skia.googlecode.com/svn/trunk@10946 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix _GDI::generateCharToGlyph to properly handle missing glyphs.
bungeman@google.com [Tue, 27 Aug 2013 19:05:32 +0000 (19:05 +0000)]
Fix _GDI::generateCharToGlyph to properly handle missing glyphs.

git-svn-id: http://skia.googlecode.com/svn/trunk@10945 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert of r10943.
rmistry@google.com [Tue, 27 Aug 2013 18:53:41 +0000 (18:53 +0000)]
Revert of r10943.

Review URL: https://codereview.chromium.org/23626002

git-svn-id: http://skia.googlecode.com/svn/trunk@10944 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkDeviceLooper to handle larger-than-fixedpoint
reed@google.com [Tue, 27 Aug 2013 17:53:52 +0000 (17:53 +0000)]
add SkDeviceLooper to handle larger-than-fixedpoint

BUG=

Review URL: https://codereview.chromium.org/23392006

git-svn-id: http://skia.googlecode.com/svn/trunk@10943 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix issue when the family name is reused among multiple families.
djsollen@google.com [Tue, 27 Aug 2013 17:40:03 +0000 (17:40 +0000)]
Fix issue when the family name is reused among multiple families.

BUG=chromium:274117
R=reed@google.com

Review URL: https://codereview.chromium.org/23592002

git-svn-id: http://skia.googlecode.com/svn/trunk@10942 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove experimental/json-expectations , no longer needed.
epoger@google.com [Tue, 27 Aug 2013 16:48:04 +0000 (16:48 +0000)]
Remove experimental/json-expectations , no longer needed.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/23498007

git-svn-id: http://skia.googlecode.com/svn/trunk@10941 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compiler warning/error in r10936
robertphillips@google.com [Tue, 27 Aug 2013 16:31:31 +0000 (16:31 +0000)]
Fix compiler warning/error in r10936

git-svn-id: http://skia.googlecode.com/svn/trunk@10938 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew warning -> new pattern for fingers to learn for asserting failure.
mtklein@google.com [Tue, 27 Aug 2013 16:15:37 +0000 (16:15 +0000)]
New warning -> new pattern for fingers to learn for asserting failure.

The Ubuntu Clang compile bot has a warning enabled now that yells about !"foo"
before it breaks Chrome's build where the same warning is -Werror.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23586002

git-svn-id: http://skia.googlecode.com/svn/trunk@10937 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBlur refactoring
robertphillips@google.com [Tue, 27 Aug 2013 16:14:03 +0000 (16:14 +0000)]
Blur refactoring

https://codereview.chromium.org/21835004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10936 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofactory can draw now too
mtklein@google.com [Tue, 27 Aug 2013 16:07:48 +0000 (16:07 +0000)]
factory can draw now too

BUG=skia:1564
R=epoger@google.com

Review URL: https://codereview.chromium.org/23607002

git-svn-id: http://skia.googlecode.com/svn/trunk@10935 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix clip expansion in SkPictureRecord::recordRestoreOffsetPlaceholder()
fmalita@google.com [Tue, 27 Aug 2013 15:50:19 +0000 (15:50 +0000)]
Fix clip expansion in SkPictureRecord::recordRestoreOffsetPlaceholder()

For operations which can expand the region, zeroing previous clip ops' restore offsets is not enough: we need to also break the chain - otherwise the next restore() will simply traverse back and reset the skip offsets.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22987003

git-svn-id: http://skia.googlecode.com/svn/trunk@10934 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding SkLumaXfermode GM results.
fmalita@google.com [Tue, 27 Aug 2013 13:54:36 +0000 (13:54 +0000)]
Adding SkLumaXfermode GM results.

Review URL: https://codereview.chromium.org/23596004

git-svn-id: http://skia.googlecode.com/svn/trunk@10933 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFour cmykjpeg GMs that weren't done yet yesterday.
mtklein@google.com [Tue, 27 Aug 2013 13:03:03 +0000 (13:03 +0000)]
Four cmykjpeg GMs that weren't done yet yesterday.
This does not fix the other failures yet.

BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23591002

git-svn-id: http://skia.googlecode.com/svn/trunk@10932 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 27 Aug 2013 07:02:54 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10929 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().
vandebo@chromium.org [Mon, 26 Aug 2013 22:52:09 +0000 (22:52 +0000)]
[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().

An apparently recently change started putting web fonts into SkStream objects that don't support getMemoryBase().  This change uses writeStream to avoid needing to call getMemoryBase().

BUG=chromium:274440
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23437004

git-svn-id: http://skia.googlecode.com/svn/trunk@10928 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate SkLumaMaskXfermode partial coverage handling.
fmalita@google.com [Mon, 26 Aug 2013 21:46:34 +0000 (21:46 +0000)]
Update SkLumaMaskXfermode partial coverage handling.

Use lerp-to-dst instead of straight coverage scaling to align the behavior with
the other transfer modes.

R=reed@google.com

Review URL: https://codereview.chromium.org/23453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10927 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotest drawing large-coord aa rects
reed@google.com [Mon, 26 Aug 2013 21:27:03 +0000 (21:27 +0000)]
test drawing large-coord aa rects

git-svn-id: http://skia.googlecode.com/svn/trunk@10926 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove mismatched delete.
scroggo@google.com [Mon, 26 Aug 2013 21:20:04 +0000 (21:20 +0000)]
Remove mismatched delete.

Use SkAutoTArray to create an array and delete it safely.

BUG=https://code.google.com/p/skia/issues/detail?id=1547
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23068033

git-svn-id: http://skia.googlecode.com/svn/trunk@10925 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline most cmykjpeg from blank to an image
mtklein@google.com [Mon, 26 Aug 2013 20:40:35 +0000 (20:40 +0000)]
rebaseline most cmykjpeg from blank to an image

BUG=
R=borenet@google.com

Review URL: https://codereview.chromium.org/23447002

git-svn-id: http://skia.googlecode.com/svn/trunk@10924 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "[PDF] Fix printing crashes caused by font streams that don't support getMemor...
vandebo@chromium.org [Mon, 26 Aug 2013 18:28:55 +0000 (18:28 +0000)]
Revert "[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase()."

This reverts commit r10918

Review URL: https://codereview.chromium.org/23351007

git-svn-id: http://skia.googlecode.com/svn/trunk@10920 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().
vandebo@chromium.org [Mon, 26 Aug 2013 18:02:00 +0000 (18:02 +0000)]
[PDF] Fix printing crashes caused by font streams that don't support getMemoryBase().

An apparently recently change started putting web fonts into SkStream objects that don't support getMemoryBase().  This change uses writeStream to avoid needing to call getMemoryBase().

BUG=chromium:274440
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23414007

git-svn-id: http://skia.googlecode.com/svn/trunk@10918 2bbb7eff-a529-9590-31e7-b0007b416f81