David Zeuthen [Thu, 16 Sep 2010 17:43:55 +0000 (13:43 -0400)]
Run 'udisks dump' in the pager if stdin/stdout are TTYs
This is like e.g. git-diff(1).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Sep 2010 16:25:07 +0000 (12:25 -0400)]
If both stdin/stdout are TTYs, provide colorful output
See http://people.freedesktop.org/~david/udisks-command-in-living-color.png
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 22:04:41 +0000 (18:04 -0400)]
Also show interfaces+properties when an object is added
$ udisks monitor
Monitoring the udisks daemon. Press Ctrl+C to exit.
18:04:29.489: The udisks-daemon is running (name-owner :1.267).
18:04:30.845: Added /org/freedesktop/UDisks/devices/mmcblk0
org.freedesktop.UDisks.BlockDevice:
Device: /dev/mmcblk0
Major: 179
Minor: 0
Size:
1015808000
Symlinks: /dev/block/179:0
/dev/disk/by-id/mmc-SD01G_0x50882907
/dev/disk/by-path/pci-0000:05:00.2
org.freedesktop.UDisks.LinuxSysfsDevice:
Subsystem: block
SysfsPath: /sys/devices/pci0000:00/0000:00:1e.0/0000:05:00.2/mmc_host/mmc0/mmc0:9ffc/block/mmcblk0
18:04:30.912: Added /org/freedesktop/UDisks/devices/mmcblk0p1
org.freedesktop.UDisks.BlockDevice:
Device: /dev/mmcblk0p1
Major: 179
Minor: 1
Size:
499998720
Symlinks: /dev/block/179:1
/dev/disk/by-id/mmc-SD01G_0x50882907-part1
/dev/disk/by-path/pci-0000:05:00.2-part1
org.freedesktop.UDisks.LinuxSysfsDevice:
Subsystem: block
SysfsPath: /sys/devices/pci0000:00/0000:00:1e.0/0000:05:00.2/mmc_host/mmc0/mmc0:9ffc/block/mmcblk0/mmcblk0p1
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 21:58:58 +0000 (17:58 -0400)]
Show interface properties when adding an interface
Again, when doing mkfs then wiping a block device, this is the output
we get:
$ udisks monitor
Monitoring the udisks daemon. Press Ctrl+C to exit.
17:56:39.132: The udisks-daemon is running (name-owner :1.267).
17:56:43.189: /org/freedesktop/UDisks/devices/mmcblk0p1: Received signal org.freedesktop.UDisks.LinuxSysfsDevice::UEvent (b'change',)
17:56:43.192: /org/freedesktop/UDisks/devices/mmcblk0p1: Added interface org.freedesktop.UDisks.BlockDevice.Probed
Label: foo
Type: vfat
UUID: 11AC-D2FD
Usage: filesystem
Version: FAT16
17:56:43.194: /org/freedesktop/UDisks/devices/mmcblk0p1: Added interface org.freedesktop.UDisks.Filesystem
MountPoint:
17:56:43.197: /org/freedesktop/UDisks/devices/mmcblk0p1: org.freedesktop.UDisks.BlockDevice: Properties Changed
Symlinks: /dev/block/179:1
/dev/disk/by-id/mmc-SD01G_0x50882907-part1
/dev/disk/by-path/pci-0000:05:00.2-part1
/dev/disk/by-uuid/11AC-D2FD
/dev/disk/by-label/foo
17:56:50.956: /org/freedesktop/UDisks/devices/mmcblk0p1: Received signal org.freedesktop.UDisks.LinuxSysfsDevice::UEvent (b'change',)
17:56:50.957: /org/freedesktop/UDisks/devices/mmcblk0p1: Removed interface org.freedesktop.UDisks.BlockDevice.Probed
17:56:50.958: /org/freedesktop/UDisks/devices/mmcblk0p1: Removed interface org.freedesktop.UDisks.Filesystem
17:56:50.958: /org/freedesktop/UDisks/devices/mmcblk0p1: org.freedesktop.UDisks.BlockDevice: Properties Changed
Symlinks: /dev/block/179:1
/dev/disk/by-id/mmc-SD01G_0x50882907-part1
/dev/disk/by-path/pci-0000:05:00.2-part1
^C
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 21:48:16 +0000 (17:48 -0400)]
Add a 'monitor' verb to the udisks command
If we run these commands
# mkfs.vfat -n "foo" /dev/mmcblk0p1
mkfs.vfat 3.0.9 (31 Jan 2010)
# mount /dev/mmcblk0p1 /media/Foo5/
# umount /media/Foo5
# dd if=/dev/zero of=/dev/mmcblk0p1 bs=512 count=100
100+0 records in
100+0 records out
51200 bytes (51 kB) copied, 0.0327893 s, 1.6 MB/s
then we get this output
$ udisks monitor
Monitoring the udisks daemon. Press Ctrl+C to exit.
17:44:08.566: The udisks-daemon is running (name-owner :1.267).
17:44:15.418: /org/freedesktop/UDisks/devices/mmcblk0p1: Received signal org.freedesktop.UDisks.LinuxSysfsDevice::UEvent (b'change',)
17:44:15.419: /org/freedesktop/UDisks/devices/mmcblk0p1: Added interface org.freedesktop.UDisks.BlockDevice.Probed
17:44:15.420: /org/freedesktop/UDisks/devices/mmcblk0p1: Added interface org.freedesktop.UDisks.Filesystem
17:44:15.421: /org/freedesktop/UDisks/devices/mmcblk0p1: org.freedesktop.UDisks.BlockDevice: Properties Changed
Symlinks: /dev/block/179:1
/dev/disk/by-id/mmc-SD01G_0x50882907-part1
/dev/disk/by-path/pci-0000:05:00.2-part1
/dev/disk/by-uuid/E2F3-2C42
/dev/disk/by-label/foo
17:44:24.466: /org/freedesktop/UDisks/devices/mmcblk0p1: org.freedesktop.UDisks.Filesystem: Properties Changed
MountPoint: /media/Foo5
17:44:29.582: /org/freedesktop/UDisks/devices/mmcblk0p1: org.freedesktop.UDisks.Filesystem: Properties Changed
MountPoint:
17:44:34.586: /org/freedesktop/UDisks/devices/mmcblk0p1: Received signal org.freedesktop.UDisks.LinuxSysfsDevice::UEvent (b'change',)
17:44:34.589: /org/freedesktop/UDisks/devices/mmcblk0p1: Removed interface org.freedesktop.UDisks.BlockDevice.Probed
17:44:34.589: /org/freedesktop/UDisks/devices/mmcblk0p1: Removed interface org.freedesktop.UDisks.Filesystem
17:44:34.589: /org/freedesktop/UDisks/devices/mmcblk0p1: org.freedesktop.UDisks.BlockDevice: Properties Changed
Symlinks: /dev/block/179:1
/dev/disk/by-id/mmc-SD01G_0x50882907-part1
/dev/disk/by-path/pci-0000:05:00.2-part1
which is actually very nice.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 21:31:05 +0000 (17:31 -0400)]
Actually remove the object on "remove" event
Duh!
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 21:25:15 +0000 (17:25 -0400)]
Fixup finalization order to avoid warnings when disconnecting signals
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 19:46:58 +0000 (15:46 -0400)]
Make udisks(1) actually show some information
Looks like this
$ udisks info --device /dev/sda1
/org/freedesktop/UDisks/devices/sda1:
org.freedesktop.UDisks.BlockDevice:
Device: /dev/sda1
Major: 8
Minor: 1
Size:
80025223168
Symlinks: /dev/block/8:1
/dev/disk/by-id/ata-INTEL_SSDSA2MH080G1GC_CVEM842101HD080DGN-part1
/dev/disk/by-id/scsi-SATA_INTEL_SSDSA2MH0CVEM842101HD080DGN-part1
/dev/disk/by-path/pci-0000:00:1f.2-scsi-0:0:0:0-part1
/dev/disk/by-uuid/
4e057fd9-bae5-4a12-83b5-
2f654d42edb1
/dev/disk/by-label/Fedora-13-x86_64
/dev/disk/by-id/wwn-0x5001517387d61905-part1
org.freedesktop.UDisks.BlockDevice.Probed:
Label: Fedora-13-x86_64
Type: ext4
UUID:
4e057fd9-bae5-4a12-83b5-
2f654d42edb1
Usage: filesystem
Version: 1.0
org.freedesktop.UDisks.Filesystem:
MountPoint: /
org.freedesktop.UDisks.LinuxSysfsDevice:
Subsystem: block
SysfsPath: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1
Also add a dump verb to dump everything.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Sep 2010 16:27:45 +0000 (12:27 -0400)]
Use bytestring for strings that are not guaranteed to be UTF-8
This requires gdbus-codegen(1) master.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 13 Sep 2010 17:39:16 +0000 (13:39 -0400)]
Dynamically update the UDisksFilesystem:MountPoint property
In other words.. use the UDisksMountMonitor machinery added in the
previous commits.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 13 Sep 2010 17:38:35 +0000 (13:38 -0400)]
Remove debug spew
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 13 Sep 2010 17:19:36 +0000 (13:19 -0400)]
Add UDisksMountMonitor and UDisksMount
This is basically a port from the old sources. Now to use it.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 10 Sep 2010 20:44:23 +0000 (16:44 -0400)]
Fixup doc indenting
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 10 Sep 2010 16:19:05 +0000 (12:19 -0400)]
Handle the org.fd.UDisks.Job.Cancel() method in the base job class
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 9 Sep 2010 21:16:07 +0000 (17:16 -0400)]
Factor common job features into a base class
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 9 Sep 2010 20:38:54 +0000 (16:38 -0400)]
Add UDisksThreadedJob class
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 21:58:06 +0000 (17:58 -0400)]
Add UDisksError to the docs
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 21:51:07 +0000 (17:51 -0400)]
Build fixes / cleanups
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 21:39:22 +0000 (17:39 -0400)]
Fix build
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 21:25:28 +0000 (17:25 -0400)]
Add UDisksError error domain and use it
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 20:09:39 +0000 (16:09 -0400)]
Fix reference count SNAFU
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 19:26:22 +0000 (15:26 -0400)]
Make it possible to pass a string to the helper via stdin
This is needed for e.g. passing a pass-phrase to cryptsetup(8).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 18:51:27 +0000 (14:51 -0400)]
Don't mix up stdout and stderr
Repeated runs of the test suite, like this
$ while `/bin/true` ; do ./udisks-test || break ; done
actually triggered this error.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 18:36:53 +0000 (14:36 -0400)]
UDisksSpawnedJob: Add test case for binary output
Also try to use this facility from UDisksFilesystemImpl:
$ gdbus call --system --dest org.freedesktop.UDisks --object-path /org/freedesktop/UDisks/devices/mmcblk1p1 --method org.freedesktop.UDisks.Filesystem.Mount "" "[]"
('/foobar',)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 15:17:07 +0000 (11:17 -0400)]
Add some more spawn tests
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 14:15:46 +0000 (10:15 -0400)]
Break test suite into separate cases
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 8 Sep 2010 14:03:54 +0000 (10:03 -0400)]
Add a test suite
These are unit-tests that check each class/type - it is not the same
as Martin Pitt's test suite which is more like integration testing
that pokes the daemon's D-Bus interface. We need both.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 7 Sep 2010 21:47:51 +0000 (17:47 -0400)]
Work on UDisksSpawnedJob implementation of UDisksJob
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 7 Sep 2010 17:18:58 +0000 (13:18 -0400)]
Add docs for UDisksJobImpl
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 6 Sep 2010 18:55:55 +0000 (14:55 -0400)]
Rearrange docs
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 6 Sep 2010 18:35:08 +0000 (14:35 -0400)]
Use new gtk-doc features available in latest gdbus-codegen(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 4 Sep 2010 07:59:31 +0000 (03:59 -0400)]
Use new _GET_ and _PEEK_ macros in latest gdbus-codegen(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 4 Sep 2010 02:51:30 +0000 (22:51 -0400)]
Start rewriting udisks(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 20:23:57 +0000 (16:23 -0400)]
Rework some of the code
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 17:30:15 +0000 (13:30 -0400)]
Introduce the UDisksDaemon class
This will be used for bookkeeping, job management and so on.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 16:46:43 +0000 (12:46 -0400)]
Nuke random device being created in main.c
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 16:20:54 +0000 (12:20 -0400)]
Use D-Bus property name Type instead of Kind
We used the name :Kind only because of a gdbus-codegen(1) bug that I
just fixed. See
http://cgit.freedesktop.org/~david/gdbus-binding-tool/commit/?id=
840c466a45ae310990c040eb5e6f5b1336c0297f
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 16:19:35 +0000 (12:19 -0400)]
Add a UDisksJob interface and implementation
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 15:27:52 +0000 (11:27 -0400)]
Add skeleton for UDisksFilesystem implementation and use it
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 00:39:19 +0000 (20:39 -0400)]
Emit UEvent signal on the LinuxSysfsDevice interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 3 Sep 2010 00:12:18 +0000 (20:12 -0400)]
Split out check/update interface functions
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 22:26:42 +0000 (18:26 -0400)]
Add org.freedesktop.UDisks.Filesystem interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 21:54:47 +0000 (17:54 -0400)]
Rename ProbedBlockDevice to BlockDevice.Probed
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 21:51:47 +0000 (17:51 -0400)]
Add the org.freedesktop.UDisks.ProbedBlockDevice interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 21:08:19 +0000 (17:08 -0400)]
Export a couple of more BlockDevice properties
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 20:51:42 +0000 (16:51 -0400)]
Don't leak the GDBusInterface objects
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 20:44:52 +0000 (16:44 -0400)]
Updates
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 19:55:31 +0000 (15:55 -0400)]
Add support for Linux Block devices
Well, it's more like the skeleton.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 19:28:43 +0000 (15:28 -0400)]
More cleanups
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 2 Sep 2010 19:01:16 +0000 (15:01 -0400)]
Cleanup
Lots of this will be added back shortly...
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 27 Aug 2010 22:50:12 +0000 (18:50 -0400)]
Catch up with latest gdbus-codegen(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 26 Aug 2010 19:09:11 +0000 (15:09 -0400)]
Use new ::g-properties-changed-emitted signal in gdbus-codegen(1)
This allows us to also emit changes on the manager object.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 26 Aug 2010 19:08:04 +0000 (15:08 -0400)]
Free the GUdevDevice before the GUdevClient objects
Otherwise valgrind complains.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 26 Aug 2010 19:05:26 +0000 (15:05 -0400)]
Update gitignore
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 25 Aug 2010 20:08:12 +0000 (16:08 -0400)]
Update to latest gdbus-codegen(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Jun 2010 20:39:55 +0000 (16:39 -0400)]
Catch up with latest gdbus and gdbus-codegen(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 8 Jun 2010 22:21:36 +0000 (18:21 -0400)]
Do proper shutdown upon receiving SIGINT
This helps with finding/detecting memory leaks.
David Zeuthen [Tue, 8 Jun 2010 20:08:48 +0000 (16:08 -0400)]
Don't leak the object path
David Zeuthen [Tue, 8 Jun 2010 19:59:06 +0000 (15:59 -0400)]
Update for latest gdbus-binding-tool
This bug was fixed
http://cgit.freedesktop.org/~david/gdbus-binding-tool/commit/?id=
a78aca02de934cbec27bae2ef04127745a7fbc55
David Zeuthen [Tue, 8 Jun 2010 19:46:33 +0000 (15:46 -0400)]
Updates
David Zeuthen [Mon, 7 Jun 2010 20:57:25 +0000 (16:57 -0400)]
Updates
David Zeuthen [Mon, 7 Jun 2010 15:57:29 +0000 (11:57 -0400)]
Require GIO 2.25.7 or later
We need this for the gdbus bits.
Martin Pitt [Thu, 3 Jun 2010 10:09:29 +0000 (12:09 +0200)]
Bug 28075 — Do not have files executable on NTFS
Set fmask on NTFS devices to avoid having files being executable. This provides
a better default for almost all NTFS use cases under Linux, and avoids
confusing "show or execute?" questions in nautilus.
This is similar to what commit 7e7ec1 did for vfat, except that NTFS does not
have this handy "showexec" option.
Martin Pitt [Wed, 2 Jun 2010 13:56:07 +0000 (15:56 +0200)]
Fix long hangs on probing nonexistant floppy drives
A lot of modern machines do not have a floppy drive any more, but still have a
floppy controller somewhere (or at least the BIOS pretends to). Trying to
open(/dev/fd0) on these machines causes long hangs, which lead to long desktop
startup times.
To fix this, avoid probing floppies for media in update_info().
https://launchpad.net/bugs/539515
David Zeuthen [Tue, 1 Jun 2010 21:22:38 +0000 (17:22 -0400)]
Avoid using entities in introspection XML
Unfortunately GMarkup doesn't understand entities so
gdbus-binding-tool will not work with these XML files without this
patch.
David Zeuthen [Tue, 25 May 2010 14:59:01 +0000 (10:59 -0400)]
Don't probe non-data discs for partition tables
Suggested by Kay Sievers. This is related to
https://bugzilla.kernel.org/show_bug.cgi?id=15757
Signed-off-by: David Zeuthen <davidz@redhat.com>
Martin Pitt [Thu, 20 May 2010 20:12:44 +0000 (22:12 +0200)]
testsuite: mkfs() code cleanup
Replace the long if ladder for mkfs special cases with option dictionaries.
This makes it easier to extend in the future and the code easier to read.
Martin Pitt [Wed, 12 May 2010 12:00:18 +0000 (14:00 +0200)]
Bug 28075 — Do not have all files executable on vfat
Enable the "showexec" vfat mount option, to avoid data files being executable
(which causes confusing question dialogs in nautilus which only have one
sensible answer).
See http://www.kernel.org/doc/Documentation/filesystems/vfat.txt (search for
"showexec") for the details of this option.
David Zeuthen [Wed, 19 May 2010 17:01:31 +0000 (13:01 -0400)]
Update to latest LVM2 API
See
http://lists.freedesktop.org/archives/devkit-devel/2010-April/000783.html
Martin Pitt [Wed, 12 May 2010 11:00:16 +0000 (13:00 +0200)]
testsuite: Check file permissions
Add a check to the filesystem test cases for sane permissions of data files and
executables. In particular, this ensures that the executable bit is set where
it makes sense (directories and programs), but not on mere data files.
We currently ignore known-broken file systems like vfat and ntfs.
This is the groundwork to fix this behaviour at least on vfat. Its current
behaviour is quite unnerving, since trying to open a file on them in e. g.
GNOME will always ask for "do you want to open or run this file".
David Zeuthen [Fri, 9 Apr 2010 15:56:27 +0000 (11:56 -0400)]
Post-release version bump to 1.0.2
David Zeuthen [Fri, 9 Apr 2010 15:45:44 +0000 (11:45 -0400)]
Update NEWS for release
Martin Pitt [Fri, 9 Apr 2010 11:19:44 +0000 (13:19 +0200)]
add information about CVE-2010-1149 to NEWS
Martin Pitt [Wed, 7 Apr 2010 07:50:19 +0000 (09:50 +0200)]
Hide Sony E-Book launcher partition
It only contains Windows software and is read-only, and thus useless.
https://launchpad.net/bugs/546924
Martin Pitt [Wed, 7 Apr 2010 07:27:18 +0000 (09:27 +0200)]
job-drive-benchmark.c: Fix data types in error messages
We previously used wrongly sized data types in the error messages, which causes
crashes on platforms where they do not coincidentally match in size.
https://launchpad.net/bugs/527202
Martin Pitt [Wed, 7 Apr 2010 06:56:05 +0000 (08:56 +0200)]
part-id: Fix DM partition table detection
If DM_NAME does not end in 'pN' (i. e. is not a partition), do not treat it as
malformed, but just go ahead probing it. This fixes partition table detection
for kpartx'ed DM devices.
Re-enable the test case which originally uncovered this bug.
Martin Pitt [Wed, 7 Apr 2010 06:36:42 +0000 (08:36 +0200)]
testsuite: Check presence and properties of loop devices
Martin Pitt [Wed, 7 Apr 2010 06:12:42 +0000 (08:12 +0200)]
Bug 27494 — publicly exports dm key information
Change udisks-dm-export to only export UDISKS_DM_TARGETS_PARAMS for "linear"
types. It is the only one we care about for now and know how to interpret.
"crypto" types have information about the encryption key in the target
parameters, which we must not leak.
Also add appropriate comments to the two places which currently evaluate
UDISKS_DM_TARGETS_PARAMS.
Martin Pitt [Tue, 6 Apr 2010 21:01:38 +0000 (23:01 +0200)]
testsuite: Test detection of kpartx LVM partitions
Add a new LVM test case where we create two partitions of the LV and check
their udisks properties.
This is primarily meant to test the rather involved logic of udisks-part-id to
determine which device that partition is a slave of (it involves parsing
UDISKS_DM_TARGETS_PARAMS and various DM_* properties).
This also apparently uncovered a bug: the partition table does not have correct
properties in udisks. Comment out the two checks for now, to be investigated
later.
Martin Pitt [Tue, 6 Apr 2010 18:34:36 +0000 (20:34 +0200)]
testsuite: Check that our udev probers do not leak key information
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=27494
Martin Pitt [Fri, 19 Mar 2010 09:09:59 +0000 (10:09 +0100)]
Fix exit code of umount.udisks
Exit with return code 0 if the unmount succeeded.
https://launchpad.net/bugs/541740
Martin Pitt [Thu, 18 Mar 2010 13:42:24 +0000 (14:42 +0100)]
Allow other rules to set a more specific presentation icon
If previous rules already set UDISKS_PRESENTATION_ICON_NAME (like in a future
media-player-info, to attach more specific icons to particular devices), do not
overwrite it with our generic icons; just set them if we do not have an icon at
all yet.
Also put the icon rules into their own visual section now, they were previously
in the middle of the "card reader type" rules.
Martin Pitt [Wed, 17 Mar 2010 14:46:03 +0000 (15:46 +0100)]
Set multimedia-player-ipod icon for iPod media players
Part of https://launchpad.net/bugs/540235
David Zeuthen [Mon, 15 Mar 2010 23:42:29 +0000 (19:42 -0400)]
Update NEWS for release
Ooops, should have done this before 1.0.0 - this will have to do.
David Zeuthen [Mon, 15 Mar 2010 23:38:42 +0000 (19:38 -0400)]
Post-release version bump to 1.0.1
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 15 Mar 2010 22:37:21 +0000 (18:37 -0400)]
Add TODO item about UTF-8 and D-Bus properties
David Zeuthen [Mon, 15 Mar 2010 22:31:58 +0000 (18:31 -0400)]
Guarantee that DeviceFilePresentation always contain something meaningful
This makes life easier for UI tools - they can always just display
:DeviceFilePresentation instead of having to check whether it's blank
and if so use :DeviceFile.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 15 Mar 2010 22:22:48 +0000 (18:22 -0400)]
Make it possible to disable LVM2 and dm-multipath support
Evidently, the device-mapper and LVM2 side of this needs some more
work so certain enterprise distros may want to disable this for now.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 15 Mar 2010 19:38:53 +0000 (15:38 -0400)]
Update TODO
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 15 Mar 2010 18:04:59 +0000 (14:04 -0400)]
Fix partition table probing during coldplug
Commit
8aa58f68ae3b53f6ba6d8c51b4f66bc8135b4123 introduced a subtle
assumption that the device file given on the command line for
udisks-part-id is the same as what udev_device_get_devnode() returns
for the udev_device object. This is actually not true when handling an
event as the node passed is a temporary one.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Martin Pitt [Mon, 15 Mar 2010 07:41:32 +0000 (08:41 +0100)]
udisks-part-id: Simplify code
In 8aa58f we changed part-id to keep one singe udev_device around. Simplify
get_part_table_device_file() to not get the syspath from our device, just to
get a new udev device from that syspath again (which is exactly the same as the
device that we already have).
This also fixes a double udev_device_unref(), although this seems to have been
harmless.
Martin Pitt [Sun, 14 Mar 2010 19:58:28 +0000 (20:58 +0100)]
Bug 27072 — does not force-unmount for drives in fstab
force_removal() previously only checked for entries in our own mtab.
This caused forced unmounts for drives in /etc/fstab not to work.
Now check for drives in /etc/fstab as well.
Martin Pitt [Fri, 12 Mar 2010 19:07:24 +0000 (20:07 +0100)]
TODO update for property update race conditions
Martin Pitt [Fri, 12 Mar 2010 18:56:34 +0000 (19:56 +0100)]
testsuite: Add option to disable workarounds for race conditions
Some D-BUS API methods cause properties to not be up to date yet when a method
call finishes, thus we do an udevadm settle as a workaround in the test suite.
Those bugs should eventually get fixed properly, but it's unnerving to have the
tests fail on them when you are working on something else.
Split the udevadm settles into the existing .sync() for legitimate syncs, and a
new sync_workaround() for race condition workarounds.
Add --no-workarounds CLI option to disable those workaround syncs, so that
these race conditions can be detected and fixed.
Martin Pitt [Fri, 12 Mar 2010 18:14:24 +0000 (19:14 +0100)]
testsuite: Use loop devices instead of ram disks
On many platforms, the default size of RAM disks is too small for some file
systems or LVM devices. Rewrite using temporary loop devices.
Martin Pitt [Fri, 12 Mar 2010 17:30:23 +0000 (18:30 +0100)]
udisks-part-id: Check ID_FS_TYPE from environment first
We need to do that for the initial udev run where blkid and udisks-part-id are
called in the same round; the database is not updated at that time yet.
Martin Pitt [Fri, 12 Mar 2010 16:42:25 +0000 (17:42 +0100)]
Bug 26996 — wrongly detects partition on unpartitioned VFAT device
A standard VFAT header matches the signature of an MBR, so we detected VFAT
file systems on raw unpartitioned devices as both VFAT and MBR partition table.
This confuses gnome-disk-utility/gvfs, and causes them to be ignored in GNOME.
The standard approach in the kernel/blkid is to only detect an MBR if it does
not have a valid VFAT signature. Since blkid already does that for us, do not
output PARTITION_TABLE properties in udisks-part-id if we already know that we
have a valid ID_FS_TYPE.
Martin Pitt [Fri, 12 Mar 2010 16:27:03 +0000 (17:27 +0100)]
udisks-part-id: Shuffle code to keep udev_device in main()
Reorder the code to get and keep an udev_device struct in main() and pass it
down to get_part_table_device_file(), instead of temporarily creating them in
that function and get_syspath(). This avoids duplicate lookups and also
allows us to do further queries on the udev_device later on (which we need to
fix bz#26996)
Martin Pitt [Fri, 12 Mar 2010 15:15:52 +0000 (16:15 +0100)]
testsuite: Check partitions with filesystems
So far we only checked handling of partitions without file systems, which did
not detect the regression from commit cfc6698. Now test both combinations.
Note that we have to jump through some hoops here, since
Partition{Create,Modify} internally writes the new partition type/flags/etc,
and thus does not care about a broken part-id. Thus we trigger a change event
on block devices to actually check what the udev probers do.
Michael Biebl [Tue, 17 Nov 2009 03:18:14 +0000 (21:18 -0600)]
Bug 25424 — Update to stable API of udev/gudev/dbus
Remove G_UDEV_API_IS_SUBJECT_TO_CHANGE and
LIBUDEV_I_KNOW_THE_API_IS_SUBJECT_TO_CHANGE.
Bump the build dependency on libudev to >= 143 and gudev-1.0 to >= 147
when those APIs were declared stable.
We also depend on dbus >= 1.0, so remove DBUS_API_SUBJECT_TO_CHANGE as
well.
Signed-off-by: David Zeuthen <davidz@redhat.com>
projects / platform / upstream / udisks2.git / log