review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

egdaniel [Wed, 4 Jun 2014 15:15:53 +0000 (08:15 -0700)]

Move Dashing filterPath to a dashing utils file

From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.

BUG=skia:
R=bsalomon@google.com, reed@google.com, rmistry@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/314623004

commit | commitdiff | tree

egdaniel [Wed, 4 Jun 2014 15:15:31 +0000 (08:15 -0700)]

Add bench to measure drawing a dashed grid

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/310083005

commit | commitdiff | tree

robertphillips [Wed, 4 Jun 2014 12:40:44 +0000 (05:40 -0700)]

Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613004

commit | commitdiff | tree

Ravi Mistry [Wed, 4 Jun 2014 11:04:29 +0000 (07:04 -0400)]

Whitespace change to test bugdroid

(SkipBuildbotRuns)

BUG=skia:2139,chromium:380617

commit | commitdiff | tree

borenet [Wed, 4 Jun 2014 06:13:07 +0000 (23:13 -0700)]

Update SKP version to 17

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/312043004

commit | commitdiff | tree

reed [Tue, 3 Jun 2014 23:51:10 +0000 (16:51 -0700)]

readd SK_SUPPORT_LEGACY_SETCONFIG_INFO -- missed a place in a blink test

R=jvanverth@google.com
TBR=jvanverth
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/316753002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 22:59:23 +0000 (15:59 -0700)]

Disable PDF in dm for tonight. It's crashy.

BUG=skia:2598
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/317533003

commit | commitdiff | tree

kelvinly [Tue, 3 Jun 2014 22:43:34 +0000 (15:43 -0700)]

Added grid data to logging output

BUG=skia:
R=bensong@google.com, jcgregorio@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/318433003

commit | commitdiff | tree

reed [Tue, 3 Jun 2014 22:39:06 +0000 (15:39 -0700)]

remove unneeded flags SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_DEVICE_CONFIG

TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/315733002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 22:38:18 +0000 (15:38 -0700)]

Android: remove -lcutils dependency

I believe we no longer depend on this after we ported our atomics to __sync.

Tested by running android_ninja.

BUG=skia:
R=scroggo@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/318493002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 20:57:14 +0000 (13:57 -0700)]

DM: add pdf

BUG=skia:2598
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312873002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 20:56:54 +0000 (13:56 -0700)]

DM: go back to memcmp for BitmapsEqual

Even when autovectorized, using MaxComponentDifference is slower than memcmp.
And debug builds (most runs of DM) will never even be autovectorized.

DM::MaxComponentDifference is the top function on DM profile, and memcmp moves
to ~20th.

BUG=skia:
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/315743002

commit | commitdiff | tree

Ravi Mistry [Tue, 3 Jun 2014 20:39:21 +0000 (16:39 -0400)]

Whitespace change to test the new cron.chrome bugdroid.

(SkipBuildbotRuns)
BUG=skia:2139

Review URL: https://codereview.chromium.org/309333003

commit | commitdiff | tree

robertphillips [Tue, 3 Jun 2014 20:34:06 +0000 (13:34 -0700)]

Fix neglected cleanup of SkTileGridPicture.h

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/312803003

commit | commitdiff | tree

scroggo [Tue, 3 Jun 2014 20:12:51 +0000 (13:12 -0700)]

Return NULL when building empty LayerRasterizer.

In SkLayerRasterizer::snapshotRasterizer() and ::detachRasterizer(),
if no layers have been added, do not attempt to create an
SkLayerRasterizer. Instead, return NULL.

This fixes an error when running tests on Android.

Update dox to state that NULL may be returned.

Add tests.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/313653006

commit | commitdiff | tree

krajcevski [Tue, 3 Jun 2014 20:04:35 +0000 (13:04 -0700)]

Initial KTX file decoder

R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302333002

commit | commitdiff | tree

robertphillips [Tue, 3 Jun 2014 19:31:09 +0000 (12:31 -0700)]

Add LICENSE & README.google files to third_party/etc1

R=djsollen@google.com, krajcevski@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309343004

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 19:07:31 +0000 (12:07 -0700)]

SK_CPU_ARM --> SK_CPU_ARM32

That's what it means. It keeps confusing us as named today.

BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/314643004

commit | commitdiff | tree

jvanverth [Tue, 3 Jun 2014 18:46:30 +0000 (11:46 -0700)]

manual bench rebase after 55ada06

R=robertphillips@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/315683004

commit | commitdiff | tree

reed [Tue, 3 Jun 2014 17:53:59 +0000 (10:53 -0700)]

remove SkBounder -- unused and unloved

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/312553006

commit | commitdiff | tree

epoger [Tue, 3 Jun 2014 17:35:28 +0000 (10:35 -0700)]

download_actuals.py: download JSON files from Google Storage instead of skia-autogen

uses google-api-python-client instead of gsutil binary to interact with Google Storage

BUG=skia:553
R=rmistry@google.com, bensong@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/309653005

commit | commitdiff | tree

humper [Tue, 3 Jun 2014 17:20:49 +0000 (10:20 -0700)]

a few rebaseline stragglers from image scaling change

BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth

Author: humper@google.com

Review URL: https://codereview.chromium.org/311853004

commit | commitdiff | tree

kevin.petit [Tue, 3 Jun 2014 17:08:07 +0000 (10:08 -0700)]

ARM Skia NEON patches - 38 - arm64 8888 blitters

Enable NEON on arm64 for most 8888 blitters

This patch enables NEON optimisation for the Color32, S32_Blend,
S32A_Opaque blitters on arm64.

Here are the perf improvements vs the existing code:

Color32:
========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -2.39% |     23.78% |
+-------+------------+------------+
|     2 |     -5.46% |      8.88% |
+-------+------------+------------+
|     4 |     -4.74% |      4.89% |
+-------+------------+------------+
|     8 |     67.74% |    107.12% |
+-------+------------+------------+
|    16 |     40.03% |    101.20% |
+-------+------------+------------+
|    64 |     11.09% |     98.40% |
+-------+------------+------------+
|   256 |     -2.20% |     74.81% |
+-------+------------+------------+
|  1024 |     -4.28% |     78.90% |
+-------+------------+------------+

S32_Blend:
==========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |      7.84% |     -6.75% |
+-------+------------+------------+
|     2 |     28.95% |     39.77% |
+-------+------------+------------+
|     4 |      5.80% |      8.26% |
+-------+------------+------------+
|     8 |      1.35% |     33.80% |
+-------+------------+------------+
|    16 |     -2.13% |     41.13% |
+-------+------------+------------+
|    64 |     -4.91% |     42.84% |
+-------+------------+------------+
|   256 |     -6.53% |     48.72% |
+-------+------------+------------+
|  1024 |     -6.65% |     46.66% |
+-------+------------+------------+

S32A_Opaque:
============

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -7.51% |    -19.06% |
+-------+------------+------------+
|     2 |     -5.02% |    -27.70% |
+-------+------------+------------+
|     4 |     15.38% |    -21.66% |
+-------+------------+------------+
|     8 |     -0.98% |      1.05% |
+-------+------------+------------+
|    16 |     -7.35% |      3.34% |
+-------+------------+------------+
|    64 |     50.53% |     94.63% |
+-------+------------+------------+
|   256 |     71.17% |    164.10% |
+-------+------------+------------+
|  1024 |     79.58% |    197.60% |
+-------+------------+------------+

Signed-off-by: Kevin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/302283003

commit | commitdiff | tree

robertphillips [Tue, 3 Jun 2014 17:04:47 +0000 (10:04 -0700)]

Remove legacy picture recording

This is unblocked now that Android no longer uses the old interface.

This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio.

R=bsalomon@google.com, reed@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613002

commit | commitdiff | tree

borenet [Tue, 3 Jun 2014 16:38:11 +0000 (09:38 -0700)]

Update SKP version to 16

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/313593002

commit | commitdiff | tree

jcgregorio [Tue, 3 Jun 2014 16:04:44 +0000 (09:04 -0700)]

Fix etc1 support for SkFiddle.

Also update design doc to fix MySQL notation for auto incrementing columns.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/315643002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 16:04:33 +0000 (09:04 -0700)]

Fix memory leak in etc1bitmap GM.

We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.

BUG=skia:2635
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/310793003

commit | commitdiff | tree

scroggo [Tue, 3 Jun 2014 14:57:51 +0000 (07:57 -0700)]

Allow chrome to use old version of installPixels.

R=jvanverth@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/312703003

commit | commitdiff | tree

jcgregorio [Tue, 3 Jun 2014 14:38:35 +0000 (07:38 -0700)]

Update link to Doxygen.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/302543007

commit | commitdiff | tree

Brian Salomon [Tue, 3 Jun 2014 14:01:47 +0000 (10:01 -0400)]

Rebase a few GMs and remove some tests from ignored-tests.txt

Review URL: https://codereview.chromium.org/311813003

commit | commitdiff | tree

scroggo [Tue, 3 Jun 2014 13:50:26 +0000 (06:50 -0700)]

Remove brackets from gm names.

BUG=skia:2634
R=epoger@google.com, borenet@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/307373003

commit | commitdiff | tree

bsalomon [Tue, 3 Jun 2014 13:34:58 +0000 (06:34 -0700)]

Fall back to using clip effect for outer rect in drawdrrect

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/310483010

commit | commitdiff | tree

rmistry [Tue, 3 Jun 2014 13:30:09 +0000 (06:30 -0700)]

Whitespace change to test multiple master support in CQ

TBR=
BUG=skia:2624

(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/315633002

commit | commitdiff | tree

reed [Tue, 3 Jun 2014 12:31:00 +0000 (05:31 -0700)]

remove unneeded flags

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/316463002

commit | commitdiff | tree

rmistry [Tue, 3 Jun 2014 11:31:55 +0000 (04:31 -0700)]

Whitespace change to test new CQ trybot

TBR=
BUG=skia:2203
(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/311813002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 02:34:19 +0000 (19:34 -0700)]

Revert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromium.org/309823004/)

Reason for revert:
the bot's clang doesn't know -fsanitize-blacklist

Original issue's description:
> Try TSAN blacklist for SkGLContextHelper::init.
>
> Submitting to test this; this particular problem only happens on the bot.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/314543002

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 02:11:06 +0000 (19:11 -0700)]

Try TSAN blacklist for SkGLContextHelper::init.

Submitting to test this; this particular problem only happens on the bot.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309823004

commit | commitdiff | tree

mtklein [Tue, 3 Jun 2014 01:22:12 +0000 (18:22 -0700)]

Clean up another silly race in benches when run concurrently.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309193003

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 23:40:06 +0000 (16:40 -0700)]

Tweak TSAN suppressions.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312613002

commit | commitdiff | tree

reed [Mon, 2 Jun 2014 21:41:24 +0000 (14:41 -0700)]

remove unneeded inval

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/307993012

commit | commitdiff | tree

reed [Mon, 2 Jun 2014 21:38:28 +0000 (14:38 -0700)]

add makeOffset and makeInset to SkRect

TBR=bsalomon

precursor for https://codereview.chromium.org/306013010

Author: reed@google.com

Review URL: https://codereview.chromium.org/306893012

commit | commitdiff | tree

epoger [Mon, 2 Jun 2014 21:26:18 +0000 (14:26 -0700)]

use most innocuous characters possible within skimage output filenames

BUG=skia:2634
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302323003

commit | commitdiff | tree

krajcevski [Mon, 2 Jun 2014 20:51:34 +0000 (13:51 -0700)]

Change #def to be opt-out

R=jvanverth@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/308143008

commit | commitdiff | tree

epoger [Mon, 2 Jun 2014 20:46:21 +0000 (13:46 -0700)]

Revert of stop using brackets within skimage output filenames (https://codereview.chromium.org/303263012/)

Reason for revert:
Broke http://108.170.220.120:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Release/builds/2806/steps/UploadSKImageResults/logs/stdio :

[13:38:43.401942] /bin/sh: 1: Syntax error: "(" unexpected
[13:38:43.902632] Command /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/scripts/slave/../../third_party/gsutil/gsutil cp -a private /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Link-HD4000-x86_64-Release/build/skia/out/Release/skimage_out/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png gs://chromium-skia-gm/skimage/output/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png failed with retcode 2, try 1.

Original issue's description:
> stop using brackets within skimage output filenames
>
> BUG=skia:2634
>
> Committed: https://skia.googlesource.com/skia/+/f07892413cd2359549dc187f1d10bc48d7d263ba

R=scroggo@google.com
TBR=scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2634

Author: epoger@google.com

Review URL: https://codereview.chromium.org/314443002

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 20:46:17 +0000 (13:46 -0700)]

Update TSAN suppressions.

TSAN suppressions need to be on their own line, even free of comments.

Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load.
Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN
has an atomic load that makes the annotation moot.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/be7de4fc4229b70b0954f3ea5e3b053dae4c1a9d

R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308073013

commit | commitdiff | tree

epoger [Mon, 2 Jun 2014 20:35:22 +0000 (13:35 -0700)]

stop using brackets within skimage output filenames

BUG=skia:2634
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/303263012

commit | commitdiff | tree

scroggo [Mon, 2 Jun 2014 20:34:08 +0000 (13:34 -0700)]

Update expectations to fix self tests.

R=epoger@google.com
TBR=epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/306313004

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 20:23:49 +0000 (13:23 -0700)]

Update TSAN suppressions.

TSAN suppressions need to be on their own line, even free of comments.

Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load.
Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN
has an atomic load that makes the annotation moot.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308073013

commit | commitdiff | tree

reed [Mon, 2 Jun 2014 20:07:26 +0000 (13:07 -0700)]

use colortype instead of config

clone of https://codereview.chromium.org/305133006/

TBR=

BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/301233011

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 19:41:07 +0000 (12:41 -0700)]

TSAN caught us racing in ScalarBench.cpp

http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14992

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305033002

commit | commitdiff | tree

jvanverth [Mon, 2 Jun 2014 19:27:25 +0000 (12:27 -0700)]

Allow access to device config for Moz2d.

BUG=skia:2633
R=robertphillips@google.com, borenet@google.com, george@mozilla.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/304273009

commit | commitdiff | tree

borenet [Mon, 2 Jun 2014 19:19:29 +0000 (12:19 -0700)]

Revert of Update SKP version to 13 (https://codereview.chromium.org/309753004/)

Reason for revert:
Did not include perf baselines.

Original issue's description:
> Update SKP version to 13
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/7574153e9cc52b1b560ded02a2b219cda4b1816c

R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/309813003

commit | commitdiff | tree

Robert Phillips [Mon, 2 Jun 2014 19:18:27 +0000 (15:18 -0400)]

Adding resource files

The ktx file is to test the new ktx reader
The pkm shrinks the size of the pkm test file

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/312563002

commit | commitdiff | tree

borenet [Mon, 2 Jun 2014 19:15:31 +0000 (12:15 -0700)]

Update SKP version to 13

R=rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/309753004

commit | commitdiff | tree

robertphillips [Mon, 2 Jun 2014 19:09:29 +0000 (12:09 -0700)]

Remove legacy Picture-recording flags from Android build

R=scroggo@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/304333002

commit | commitdiff | tree

scroggo [Mon, 2 Jun 2014 18:32:56 +0000 (11:32 -0700)]

Remove unitmappers header.

This file contained a bunch of unitmappers. Luckily noone includes
it, since it wouldn't compile (the unitmapper class was removed in
https://codereview.chromium.org/288313009).

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/295383013

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 18:26:59 +0000 (11:26 -0700)]

Clean up SkOnce:

  1 Remove atExit feature: clients can do it just as well as SkOnce can.
  2 Remove support for functors: no one but the unit test did that.
  3 Remove support for unused non-static SkOnceFlag (no SK_ONCE_INIT).
  4 Add SkOnce variants for no-arg functions so we're not forced to pass dummy values all the time.
  5 Merge SkSpinlock and SkOnceFlag, making all members private.
  6 More notes about memory barriers, adding an acquire load after acquiring the spinlock.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/302083003

commit | commitdiff | tree

humper [Mon, 2 Jun 2014 18:09:12 +0000 (11:09 -0700)]

invert comparison sense for reason return

BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/313433003

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 17:59:35 +0000 (10:59 -0700)]

Compile-time initialize special SkMatrices.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303263011

commit | commitdiff | tree

robertphillips [Mon, 2 Jun 2014 17:20:14 +0000 (10:20 -0700)]

Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h)

R=bsalomon@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309683002

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 15:44:27 +0000 (08:44 -0700)]

Port most uses of SkOnce to SkLazyPtr.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=15006

Committed: http://code.google.com/p/skia/source/detail?r=15014

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

commit | commitdiff | tree

krajcevski [Mon, 2 Jun 2014 15:02:45 +0000 (08:02 -0700)]

Fix bracket outside of ifdef

R=jvanverth@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/305333003

commit | commitdiff | tree

mtklein [Mon, 2 Jun 2014 14:53:01 +0000 (07:53 -0700)]

Clean up SkLazyPtrs only in SK_DEVELOPER mode.

Checking only SK_DEBUG may make SkLazyPtr too anal about leaks for
clients. Still working through strange leak problems inside Skia
tests, so it's probably premature to turn it on in Chrome tests.

BUG=379570
R=reed@google.com, mtklein@google.com, bungeman@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308003014

commit | commitdiff | tree

krajcevski [Mon, 2 Jun 2014 14:38:14 +0000 (07:38 -0700)]

Initial work to get ETC1 data up to the GPU

Committed: http://code.google.com/p/skia/source/detail?r=15001

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302783002

commit | commitdiff | tree

scroggo [Mon, 2 Jun 2014 14:19:13 +0000 (07:19 -0700)]

Update comments about debugging on master.

Update the makefile to reference the correct location of
config.mk.

R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/308703009

commit | commitdiff | tree

robertphillips [Mon, 2 Jun 2014 14:15:18 +0000 (07:15 -0700)]

Add Sample slide for Rectanizers

R=jvanverth@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/303263005

commit | commitdiff | tree

reed [Mon, 2 Jun 2014 12:45:31 +0000 (05:45 -0700)]

hide SkDevice::config()

TBR=robertphilips

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/302253002

commit | commitdiff | tree

rmistry [Mon, 2 Jun 2014 12:29:08 +0000 (05:29 -0700)]

Whitespace change to test the Git Skia CQ

NOTREECHECKS=true
BUG=skia:2613
TBR=

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/311603002

commit | commitdiff | tree

rmistry [Mon, 2 Jun 2014 12:20:32 +0000 (05:20 -0700)]

Use googlesource VIEW_VC in codereview.settings

BUG=skia:2613
NOTREECHECKS=true
NOTRY=true
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/309643005

commit | commitdiff | tree

rmistry [Mon, 2 Jun 2014 12:12:27 +0000 (05:12 -0700)]

Whitespace change to test the Git Skia CQ

NOTREECHECKS=true
TBR=
BUG=skia:
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/308703008

commit | commitdiff | tree

Eric Boren [Mon, 2 Jun 2014 12:03:43 +0000 (08:03 -0400)]

Whitespace

BUG=skia:

Review URL: https://codereview.chromium.org/304233004

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 31 May 2014 21:47:03 +0000 (21:47 +0000)]

remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE

R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/308953002

git-svn-id: http://skia.googlecode.com/svn/trunk@15016 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 31 May 2014 00:15:22 +0000 (00:15 +0000)]

Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/)

Reason for revert:
linux x86-64 release segfault in src/ports/SkFontHost_fontconfig.cpp:107

http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/builds/905/steps/RunTests/logs/stdio

Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006
>
> Committed: http://code.google.com/p/skia/source/detail?r=15014

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/306063004

git-svn-id: http://skia.googlecode.com/svn/trunk@15015 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 23:59:12 +0000 (23:59 +0000)]

Port most uses of SkOnce to SkLazyPtr.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=15006

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

git-svn-id: http://skia.googlecode.com/svn/trunk@15014 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 21:53:01 +0000 (21:53 +0000)]

New file for simpler updating of Android defines.

When building Skia for the Android framework, we will now read a
file which only includes defines. This will make it easier for
people deprecating APIs to add the guard to Android.

R=reed@google.com, djsollen@google.com, bungeman@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/305193002

git-svn-id: http://skia.googlecode.com/svn/trunk@15013 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 21:52:52 +0000 (21:52 +0000)]

Add a way for the gpu veto to report back the reason why it said no

BUG=2334
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/301423002

git-svn-id: http://skia.googlecode.com/svn/trunk@15012 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 21:07:05 +0000 (21:07 +0000)]

fix casting issue with or operator

R=reed@google.com, epoger@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/305253002

git-svn-id: http://skia.googlecode.com/svn/trunk@15011 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 21:03:38 +0000 (21:03 +0000)]

Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS (https://codereview.chromium.org/308083010/)

Reason for revert:
broke skia/ext/bitmap_platform_device_cairo.cc:44:56: error: no matching function for call to ‘SkBitmap::installPixels

Original issue's description:
> remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
>
> TBR=
> NOTRY=
>
> Committed: http://code.google.com/p/skia/source/detail?r=15007

TBR=
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/301353006

git-svn-id: http://skia.googlecode.com/svn/trunk@15010 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 21:00:52 +0000 (21:00 +0000)]

Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/)

Reason for revert:
Leaking refs on SkTypeface on Macs.

Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/304283007

git-svn-id: http://skia.googlecode.com/svn/trunk@15009 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 30 May 2014 20:50:56 +0000 (20:50 +0000)]

Allow SkPictureImageFilter to be serialized when not run cross-process.

Picture serialization is not yet hardened, but it turns out we do need
serialization of SkPictureImageFilter for deferred SVG-on-SVG filters,
since the SkPaints (and thus the SkImageFilters) are serialized by
SkPictureRecord. However, deferred filters are always drawn in the
same process, so we can safely serialize them in this case. We do this
by turning the compile-time check for
SK_ALLOW_PICTUREIMAGEFILTER_SERIALIZATION to a runtime check for
isCrossProcess().

The image filter fuzzer sample was also modified to enable fuzzing
of basic picture image filters (the code had rotted a bit, being behind
an #ifdef that no one sets).

BUG=375162
R=sugoi@google.com

Review URL: https://codereview.chromium.org/311443003

git-svn-id: http://skia.googlecode.com/svn/trunk@15008 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 20:47:13 +0000 (20:47 +0000)]

remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS

TBR=
NOTRY=

Author: reed@google.com

Review URL: https://codereview.chromium.org/308083010

git-svn-id: http://skia.googlecode.com/svn/trunk@15007 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 20:42:00 +0000 (20:42 +0000)]

Port most uses of SkOnce to SkLazyPtr.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

git-svn-id: http://skia.googlecode.com/svn/trunk@15006 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 20:41:20 +0000 (20:41 +0000)]

Add an OR operator overload for SaveFlags to avoid extra static casts.

R=reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/303373003

git-svn-id: http://skia.googlecode.com/svn/trunk@15005 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 20:36:21 +0000 (20:36 +0000)]

Revert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium.org/302783002/)

Reason for revert:
ETC1 linking problems with chrome.

Original issue's description:
> Initial work to get ETC1 data up to the GPU
>
> Committed: http://code.google.com/p/skia/source/detail?r=15001

R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/303273008

git-svn-id: http://skia.googlecode.com/svn/trunk@15004 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 30 May 2014 20:36:15 +0000 (20:36 +0000)]

Implement SkPictureImageFilter bounds computation.

SkPictureImageFilter::onFilterBounds() was unimplemented, causing
incorrect results for SVG filters and impl-side painting (see Chrome
bug https://code.google.com/p/chromium/issues/detail?id=375162).

BUG=skia:
R=reed@google.com

Review URL: https://codereview.chromium.org/306733003

git-svn-id: http://skia.googlecode.com/svn/trunk@15003 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 18:55:03 +0000 (18:55 +0000)]

Use GrGLShaderBuilder::GenProgramOutput in GrGLProgram.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/305203002

git-svn-id: http://skia.googlecode.com/svn/trunk@15002 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 18:41:39 +0000 (18:41 +0000)]

Initial work to get ETC1 data up to the GPU

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302783002

git-svn-id: http://skia.googlecode.com/svn/trunk@15001 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 17:32:50 +0000 (17:32 +0000)]

Fixing clusterfuzz issue

When reading an SkSSE2ProcCoeffXfermode object, fProcSIMD should never be NULL. The reason for this is that it's not possible to create such an object through SkPlatformXfermodeFactory_impl_SSE2(), which is the only function used to create these objects, so if we're reading one, it's clearly invalid.

BUG=379181
R=reed@google.com, mtklein@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/306183002

git-svn-id: http://skia.googlecode.com/svn/trunk@15000 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 17:23:31 +0000 (17:23 +0000)]

add --dryRun flag to dm

BUG=2294
R=mtklein@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/305963007

git-svn-id: http://skia.googlecode.com/svn/trunk@14999 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 30 May 2014 17:15:23 +0000 (17:15 +0000)]

check for null typeface from paint

git-svn-id: http://skia.googlecode.com/svn/trunk@14998 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 16:46:10 +0000 (16:46 +0000)]

Test font created from paint

This is meant to allow clients to migrate over to a SkFont api on canvas (e.g. drawText(text, font, paint)) while still permitting the current setters in paint (e.g. setTextSize, setFlags).

R=bungeman@google.com, eae@chromium.org, fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/245953003

git-svn-id: http://skia.googlecode.com/svn/trunk@14997 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 15:14:56 +0000 (15:14 +0000)]

move all code generation under genProgram() in GrGLShaderBuilder.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/306063002

git-svn-id: http://skia.googlecode.com/svn/trunk@14996 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 15:11:28 +0000 (15:11 +0000)]

more rebaselines for filterbitmap and downsamplebitmap.

BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/304353007

git-svn-id: http://skia.googlecode.com/svn/trunk@14995 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 15:09:44 +0000 (15:09 +0000)]

Revert of TSAN caught us racing in ScalarBench.cpp (https://codereview.chromium.org/305033002/)

Reason for revert:
windows doesn't like it

Original issue's description:
> TSAN caught us racing in ScalarBench.cpp
>
> http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14992

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/308883003

git-svn-id: http://skia.googlecode.com/svn/trunk@14994 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 15:06:24 +0000 (15:06 +0000)]

using real tiles when simulating tiling

BUG=skia:
R=mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/303403003

git-svn-id: http://skia.googlecode.com/svn/trunk@14993 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 14:56:58 +0000 (14:56 +0000)]

TSAN caught us racing in ScalarBench.cpp

http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305033002

git-svn-id: http://skia.googlecode.com/svn/trunk@14992 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 13:55:58 +0000 (13:55 +0000)]

Move the LATC and ETC1 enum values to GrPixelConfig. I also tried to put in checks in a few places to make sure that we weren't using these pixel configurations in places that we shouldn't be.

LATC is a DXT-esque alpha compression format that goes by a few other names (RGTC, 3DC). It might be useful to investigate using it to compress the alpha masks that we get from software rasterization. This patch set adds enums for that and recognition whether or not the device can support it.

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/304743004

git-svn-id: http://skia.googlecode.com/svn/trunk@14991 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 30 May 2014 13:45:36 +0000 (13:45 +0000)]

fix int->scalar warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@14990 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 13:26:10 +0000 (13:26 +0000)]

Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"

This reverts commit eecaea4148805834f223681f70b6488ceba12d09.

R=robertphillips@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/301283003

git-svn-id: http://skia.googlecode.com/svn/trunk@14989 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 30 May 2014 12:12:41 +0000 (12:12 +0000)]

Whitespace change to test CQ throttling

(SkipBuildbotRuns)
TBR=
NOTREECHECKS=True
NOTRY=True

BUG=skia:2472

Committed: http://code.google.com/p/skia/source/detail?r=14986

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/307993004

git-svn-id: http://skia.googlecode.com/svn/trunk@14988 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;