Will Thompson [Fri, 24 Dec 2010 14:40:49 +0000 (14:40 +0000)]
connection: correct HAVE_DECL_MSG_NOSIGNAL guard
Helpfully, AC_CHECK_DECLS (which configure.in uses to define
HAVE_DECL_MSG_NOSIGNAL) behaves differently to every similar AC_CHECK_*
macro and, rather than producing #undef HAVE_DECL_MSG_NOSIGNAL if the
given symbol is not found, instead produces #define
HAVE_DECL_MSG_NOSIGNAL 0.
Mike McQuaid's patch fixes the uses of this constant in sysdeps-unix;
with this patch, all code is guarded consistently and correctly.
Christian Dywan [Tue, 4 Jan 2011 19:36:43 +0000 (19:36 +0000)]
Fix error condition in _dbus_pipe_close
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32264
Reviewed-by: Colin Walters <walters@verbum.org>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Christian Dywan [Tue, 4 Jan 2011 19:23:47 +0000 (19:23 +0000)]
Make _dbus_system_logv actually exit with DBUS_SYSTEM_LOG_FATAL
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32262
Bug-NB: NB#180486
Reviewed-by: Thiago Macieira <thiago@kde.org>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Pau Garcia i Quiles [Fri, 31 Dec 2010 15:10:42 +0000 (16:10 +0100)]
Windows fix: MSVC 2010 has errno.h.
Marcus Brinkmann [Wed, 22 Dec 2010 16:02:33 +0000 (17:02 +0100)]
Avoid live lock in Windows (CE) under some situations due to unfair condition variables.
Ralf Habacker [Wed, 29 Dec 2010 11:31:42 +0000 (12:31 +0100)]
Use absolute session service dir path in bus-test on windows.
Ralf Habacker [Wed, 29 Dec 2010 13:41:41 +0000 (14:41 +0100)]
Keep in sync with autotools.
Mike McQuaid [Fri, 24 Dec 2010 13:30:22 +0000 (13:30 +0000)]
sysdeps-unix: use #if for HAVE_DECL_MSG_NOSIGNAL
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk>
Will Thompson [Tue, 21 Dec 2010 15:56:34 +0000 (15:56 +0000)]
Mention maintainer-upload-docs in the release process
Will Thompson [Tue, 21 Dec 2010 15:45:03 +0000 (15:45 +0000)]
Bump development version to 1.4.3.
The last release should have been 1.4.2; sorry.
Ralf Habacker [Tue, 21 Dec 2010 07:46:52 +0000 (08:46 +0100)]
Fix configure doc: libxml may be named libxml2 on some systems.
Ralf Habacker [Tue, 21 Dec 2010 07:24:00 +0000 (08:24 +0100)]
Keep in sync with automake.
Ralf Habacker [Tue, 21 Dec 2010 07:23:27 +0000 (08:23 +0100)]
Dist additional README's too.
Will Thompson [Mon, 20 Dec 2010 21:24:24 +0000 (21:24 +0000)]
Post-release version bump to 1.4.2
Will Thompson [Mon, 20 Dec 2010 21:18:17 +0000 (21:18 +0000)]
Bump LT_REVISION for this new release.
Will Thompson [Mon, 20 Dec 2010 21:18:10 +0000 (21:18 +0000)]
NEWS for 1.4.1
Havoc Pennington [Mon, 13 Dec 2010 02:08:43 +0000 (21:08 -0500)]
CVE 2010-4352: Reject deeply nested variants
Add DBUS_INVALID_NESTED_TOO_DEEPLY validity problem and a test that
should generate it.
Previously, we rejected deep nesting in the signature, but
variants allow dynamic message nesting, conditional only
on the depth of the message body.
The nesting limit is 64, which was also the limit in static
signatures. Empirically, dynamic nesting depth observed on my
Fedora 14 system doesn't exceed 2; 64 is really a huge limit.
https://bugs.freedesktop.org/show_bug.cgi?id=32321
Signed-Off-By: Colin Walters <walters@verbum.org>
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk>
Will Thompson [Fri, 17 Dec 2010 18:42:13 +0000 (18:42 +0000)]
policy tests: Use bin rather than nogroup, wheel, or root
This group seems to exist on all of Debian, Fedora and Mac OS X. (I
mistakenly believed that nogroup exists on Fedora.)
Will Thompson [Thu, 16 Dec 2010 13:56:04 +0000 (13:56 +0000)]
sysdeps-unix: check for HAVE_DECL_MSG_NOSIGNAL
MSG_NOSIGNAL could theoretically be an enum member or something rather
than an #define, so it's better to check for the flag defined by the
configure check (as is done in dbus-connection.c already).
Reviewed-by: Colin Walters <walters@verbum.org>
Reviewed-by: Scott James Remnant <scott@netsplit.com>
Scott James Remnant [Thu, 16 Dec 2010 11:11:44 +0000 (11:11 +0000)]
sysdeps-unix: use MSG_NOSIGNAL when sending creds
Since SIGPIPE is no longer touched by default when MSG_NOSIGNAL is
available, it's extra-critical that all socket writes actually pass
that flag.
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk>
Will Thompson [Mon, 13 Dec 2010 17:54:57 +0000 (17:54 +0000)]
Revert "test-autolaunch is only known to work in launchd environments."
This reverts commit
4626b405609900812125a407ef5fdd31c7b89868.
test-autolaunch works fine in non-launchd environments (and non-X11
environments, based on a quick test passing enable_x11=no to configure).
On the contrary: this commit *broke* the build on non-launchd
environments, because test/name-test/run-test.sh still tried to run this
test even if it hadn't been built.
Will Thompson [Mon, 13 Dec 2010 17:52:40 +0000 (17:52 +0000)]
Ignore generated bus/org.freedesktop.dbus-session.plist
Will Thompson [Mon, 13 Dec 2010 17:22:00 +0000 (17:22 +0000)]
policy tests: Use 'nogroup' rather than 'wheel' or 'root'
The excellently-titled commit 197bef8 “Fix test failures on OSX.” broke
the tests on Linux, since there's no wheel group on this side of the
tracks. So here's a group everyone should enjoy.
(If anyone comes along and tells me that DragonflyBSD doesn't have
'nogroup' …)
Ralf Habacker [Tue, 14 Dec 2010 07:12:59 +0000 (08:12 +0100)]
Handle case when autolaunched daemon address is already pulished on windows.
Ralf Habacker [Mon, 13 Dec 2010 21:17:12 +0000 (22:17 +0100)]
Windows fix: In install path scope case add hashed install path to mutex/shm name.
Will Thompson [Mon, 13 Dec 2010 15:35:16 +0000 (15:35 +0000)]
Fix malformed specification XML.
bf532d6 and 28a2d08 each introduced errors in the specification XML that
left it malformed and unbuildable.
Ralf Habacker [Tue, 7 Dec 2010 01:32:36 +0000 (02:32 +0100)]
Be more verbose when publishing or requesting session bus address on Windows.
Ralf Habacker [Tue, 7 Dec 2010 01:23:39 +0000 (02:23 +0100)]
Add documentation for autolaunch meta transport on Windows.
Reviewed-by: Romain Pokrzywka
Mike McQuaid [Wed, 8 Dec 2010 22:49:30 +0000 (22:49 +0000)]
Add launchd section to specification.
Ralf Habacker [Tue, 7 Dec 2010 01:16:14 +0000 (02:16 +0100)]
Implements user limited session bus on Windows.
This feature is enabled by using the session bus address
"autolaunch:scope=*user" for the client and the server.
Reviewed-by: Romain Pokrzywka
Ralf Habacker [Tue, 7 Dec 2010 00:34:38 +0000 (01:34 +0100)]
Fixed bug not freeing mutex handle on Windows.
Reviewed-by: Romain Pokrzywka
Ralf Habacker [Tue, 7 Dec 2010 00:07:05 +0000 (01:07 +0100)]
Variables and functions name cleanup on Windows.
Reviewed-by: Romain Pokrzywka
Mike McQuaid [Wed, 8 Dec 2010 22:58:32 +0000 (22:58 +0000)]
10.4 is old so set more sensible launchd defaults.
Ralf Habacker [Sun, 11 Apr 2010 09:46:04 +0000 (11:46 +0200)]
Fix bus-test failure with cmake on unix.
SHA1 connection tests needs an non debug-pipe transport for the activation bus.
Benjamin Reed [Sun, 19 Jul 2009 15:45:34 +0000 (11:45 -0400)]
Enable launchd.
This patch enables support for Mac OS X's launch daemon
for startup as well as sharing of the DBus session bus
environment. It includes a LaunchAgent plist for automatic
start of the session bus.
Benjamin Reed [Tue, 21 Jul 2009 14:33:32 +0000 (10:33 -0400)]
Look up DISPLAY from launchd if not initialized.
Benjamin Reed [Sun, 19 Jul 2009 15:44:50 +0000 (11:44 -0400)]
Add launchd implementation.
Ralf Habacker [Mon, 6 Dec 2010 20:31:14 +0000 (21:31 +0100)]
Fixed wrong libtoolize presence check.
Mike McQuaid [Tue, 5 Oct 2010 19:52:54 +0000 (20:52 +0100)]
libtoolize is called glibtoolize on OSX so check for it too.
Mike McQuaid [Tue, 5 Oct 2010 21:31:40 +0000 (22:31 +0100)]
Fix test failures on OSX.
Mike McQuaid [Sat, 4 Dec 2010 22:47:35 +0000 (23:47 +0100)]
test-autolaunch is only known to work in launchd environments.
Ralf Habacker [Sat, 4 Dec 2010 00:07:07 +0000 (01:07 +0100)]
Keep in sync with automake.
Colin Walters [Wed, 11 Jun 2008 22:01:16 +0000 (18:01 -0400)]
Added a test-autolaunch.
* test/name-test/test-autolaunch.c: New file,
unsets DBUS_SESSION_BUS_ADDRESS so we should
fall back to autolaunch:.
* test/name-test/run-test.sh: Run it.
* test/name-test/Makefile.am: Build it.
Mike McQuaid [Mon, 19 Apr 2010 18:04:28 +0000 (20:04 +0200)]
Fix PROFILE_TIMED_FORMAT printf warning on OSX.
Ralf Habacker [Wed, 3 Nov 2010 14:15:24 +0000 (15:15 +0100)]
Added revision history.
Thiago Macieira [Wed, 3 Nov 2010 13:59:26 +0000 (14:59 +0100)]
Documentated autolaunch implementation for X Windowing system.
Ralf Habacker [Fri, 29 Oct 2010 09:46:33 +0000 (11:46 +0200)]
Service dir related bug fix on windows.
The code for accessing services requires absolute pathes, which are based
on DBUS_DATADIR. DBUS_DATADIR on windows is defined relative. This patch
makes sure that those pathes are absolute.
Romain Pokrzywka [Mon, 4 Oct 2010 10:33:36 +0000 (12:33 +0200)]
Restore the close_on_exec flag on windows.
Will Thompson [Tue, 26 Oct 2010 16:11:10 +0000 (17:11 +0100)]
Merge branch 'documentation-build-system'
Andre Heinecke [Tue, 12 Oct 2010 13:36:56 +0000 (15:36 +0200)]
Dist Readme.win instead of Readme.windbus
Ralf Habacker [Tue, 12 Oct 2010 12:45:12 +0000 (14:45 +0200)]
Cleaned up windows related README's.
Ralf Habacker [Tue, 12 Oct 2010 11:50:10 +0000 (13:50 +0200)]
Fixed reference to cmake configure options.
Ralf Habacker [Mon, 11 Oct 2010 22:20:21 +0000 (00:20 +0200)]
keep version in sync with automake
Ralf Habacker [Fri, 8 Oct 2010 19:09:01 +0000 (21:09 +0200)]
Merge branch 'master' of ssh://git.freedesktop.org/git/dbus/dbus
Ralf Habacker [Fri, 8 Oct 2010 12:56:57 +0000 (14:56 +0200)]
Revert "Added documentation for autolaunch transport."
This reverts commit
2e61875728deca49a96e2db52275f3a5e24bb59b.
Romain Pokrzywka [Sun, 3 Oct 2010 23:46:42 +0000 (01:46 +0200)]
Tentative workaround for the random hangs on windows.
The problem seems to be a race condition with winsock's
internal threads for the non-blocking mode of the sockets,
but I haven't had time to try a standalone test case yet
to confirm it. Anyway, I found a workaround that fixes it
in all cases, so it's good enough for now.
Romain Pokrzywka [Sun, 3 Oct 2010 23:46:42 +0000 (01:46 +0200)]
tentative workaround for the random hangs on windows
Christian Dywan [Tue, 20 Jul 2010 13:23:31 +0000 (15:23 +0200)]
Only use signature directly inside _dbus_verbose
Christian Dywan [Tue, 20 Jul 2010 13:01:03 +0000 (15:01 +0200)]
Don't pretend to free lock if it was never allocated
Christian Dywan [Tue, 21 Sep 2010 12:43:39 +0000 (14:43 +0200)]
Always get current time in _dbus_connection_block_pending_call
Christian Dywan [Tue, 20 Jul 2010 09:53:15 +0000 (11:53 +0200)]
Take care to free windows_sid in cache_peer_loginfo_string
Christian Dywan [Tue, 20 Jul 2010 10:50:23 +0000 (12:50 +0200)]
Free envvar and args in pass_info in the oom case
Will Thompson [Thu, 9 Sep 2010 12:15:57 +0000 (13:15 +0100)]
Move uploading docs into build system.
This uploads a doc tarball, and its contents, to the appropriate
location on dbus.freedesktop.org. It also uploads the DTDs to the
appropriate location on specifications.freedesktop.org.
I believe this uploads the same files as the old update-dbus-docs.sh
script did.
Will Thompson [Wed, 8 Sep 2010 21:38:22 +0000 (22:38 +0100)]
Integrate building HTML-ified manpages with the build system
Will Thompson [Wed, 8 Sep 2010 21:12:00 +0000 (22:12 +0100)]
Report correct result of doxygen/xml doc checks
Previously the configure output always said these were enabled during
the 'Checking for...' stage, even if they weren't. The summary at the
end of configure was correct, though.
Will Thompson [Wed, 8 Sep 2010 21:10:47 +0000 (22:10 +0100)]
Move manpages to doc/
This will make integrating the building of HTML versions of these
manpages into the build system way easier, at the cost of keeping
manpages in a different directory to the source for the program they
describe. I think this is an acceptable trade-off.
Will Thompson [Wed, 8 Sep 2010 19:58:05 +0000 (20:58 +0100)]
Build Doxygen documentation for `make all`.
This depends on GNU Make for the wildcard dependency on all the source
files in dbus/. If anyone objects very strongly to this, I'd welcome
suggestions of a more portable way to do this.
Will Thompson [Wed, 8 Sep 2010 21:19:28 +0000 (22:19 +0100)]
Update a load of .gitignores
Will Thompson [Wed, 8 Sep 2010 18:42:19 +0000 (19:42 +0100)]
Silence silent build a bit more.
Will Thompson [Wed, 8 Sep 2010 18:25:40 +0000 (19:25 +0100)]
Squash warnings and spurious output from autogen.sh
Will Thompson [Wed, 8 Sep 2010 18:20:18 +0000 (19:20 +0100)]
Use Automake 1.11, if available, for silent rules
Automake 1.11 adds support for silent rules, which are conditionally
enabled in configure.in if available.
Also, previously it was impossible to override the version chosen by
this script; this patch makes that possible.
Ralf Habacker [Tue, 28 Sep 2010 06:17:38 +0000 (08:17 +0200)]
When launching dbus-daemon be more verbose in error case.
Ralf Habacker [Mon, 27 Sep 2010 20:21:29 +0000 (22:21 +0200)]
Keep unix autolaunch functions in sync.
Ralf Habacker [Sun, 26 Sep 2010 18:05:11 +0000 (20:05 +0200)]
Added documentation for autolaunch transport.
Ralf Habacker [Fri, 27 Aug 2010 15:03:16 +0000 (17:03 +0200)]
Fixed case when no scope attribute is used.
Ralf Habacker [Fri, 27 Aug 2010 14:51:44 +0000 (16:51 +0200)]
Extended autolaunch protocol with scope attribute.
Christian Dywan [Thu, 23 Sep 2010 12:38:15 +0000 (14:38 +0200)]
Add return_if_fail watch != NULL in public DBusWatch API
Reviewed-by: Havoc Pennington <hp@pobox.com>
Signed-off-by: Will Thompson <will.thompson@collabora.co.uk>
Ralf Habacker [Fri, 10 Sep 2010 07:14:06 +0000 (09:14 +0200)]
Include cmake subdirectory in source distribution.
Marcus Brinkmann [Thu, 9 Sep 2010 12:15:45 +0000 (14:15 +0200)]
Fix typo in creating temp file.
Marcus Brinkmann [Mon, 6 Sep 2010 13:50:16 +0000 (15:50 +0200)]
Fix use of _dbus_make_file_world_readable.
Will Thompson [Wed, 8 Sep 2010 11:11:50 +0000 (12:11 +0100)]
Explicitly require the daemon to respect destination=''
Ralf Habacker [Wed, 8 Sep 2010 07:13:42 +0000 (09:13 +0200)]
Unix compile fix.
Lennart Poettering [Tue, 7 Sep 2010 00:57:54 +0000 (02:57 +0200)]
post release version bump
Havoc Pennington [Tue, 31 Aug 2010 16:00:26 +0000 (12:00 -0400)]
fix some "unused result" warnings in dbus-launch and dbus-spawn
Needed to avoid -Werror
Havoc Pennington [Tue, 31 Aug 2010 15:59:09 +0000 (11:59 -0400)]
Change failure of setsockopt SO_REUSEADDR to be a warning, not set an error
It was previously setting an error but then continuing, which is
not allowed since errors can't be "piled up"
Lennart Poettering [Mon, 6 Sep 2010 12:52:05 +0000 (14:52 +0200)]
build-sys: bump version number for the 1.4.0 release
Kay Sievers [Fri, 3 Sep 2010 13:12:19 +0000 (15:12 +0200)]
systemd: enable the dbus service unconditionally
Since D-Bus is a core part of the OS don't make this service optional.
Lennart Poettering [Sun, 5 Sep 2010 21:43:24 +0000 (23:43 +0200)]
autoconf: update lt version info in preparation for 0.4.2
Lennart Poettering [Sun, 5 Sep 2010 21:37:25 +0000 (23:37 +0200)]
NEWS: update for 1.4.0
Lennart Poettering [Sun, 5 Sep 2010 21:30:47 +0000 (23:30 +0200)]
systemd: update sd-daemon.[ch] from upstream systemd
Colin Walters [Fri, 3 Sep 2010 18:46:53 +0000 (14:46 -0400)]
Merge branch 'dbus-1.2'
Conflicts:
dbus/dbus-sysdeps-unix.c
Colin Walters [Fri, 3 Sep 2010 14:18:25 +0000 (10:18 -0400)]
Make dbus-uuidgen atomic
A Red Hat QA engineer hit in practice a race condition in dbus-uuidgen
where it could leave an empty file.
dbus-uuidgen (_dbus_create_uuid_file_exclusively) formerly created an
empty file in the path to the uuid, then filled it in. At some point,
the internal libdbus _dbus_string_save_to_file became atomic on Unix
at least (doing the save to temp file, fsync(), rename() dance).
So _dbus_create_uuid_file_exclusively doesn't need to create the file
beforehand anymore. However, it *does* need the file to be
world-readable, unlike all other consumers of
_dbus_string_save_to_file. So add a "world_readable" argument.
Lennart Poettering [Sat, 7 Aug 2010 19:04:59 +0000 (21:04 +0200)]
sd-daemon: update from upstream
This updates the sd-daemon.[ch] copy from upstream, which makes sure
thet the code compiles even if SOCK_CLOEXEC is not supported.
Romain Pokrzywka [Wed, 11 Aug 2010 12:05:31 +0000 (14:05 +0200)]
Cleanup: removed unused code; fixed Winsock error handling; fixed code indentation.
Ralf Habacker [Tue, 10 Aug 2010 09:26:42 +0000 (11:26 +0200)]
Fixed wince build problem reported by aheinecke at intevation dot de.
Ralf Habacker [Tue, 10 Aug 2010 07:17:33 +0000 (09:17 +0200)]
Fixed bug not creating bus/messagebus-config.
Yaakov Selkowitz [Mon, 9 Aug 2010 07:01:52 +0000 (09:01 +0200)]
Delete stale pid file on cygwin.
Yaakov Selkowitz [Mon, 9 Aug 2010 06:50:33 +0000 (08:50 +0200)]
Avoid -Werror problems on cygwin.
Yaakov Selkowitz [Mon, 9 Aug 2010 06:32:04 +0000 (08:32 +0200)]
Applied patches from cygwin port.
Romain Pokrzywka [Sun, 8 Aug 2010 21:54:35 +0000 (23:54 +0200)]
fix socket descriptor leak in _dbus_connect_tcp_socket_with_nonce