Shinichiro Hamaji [Fri, 20 Oct 2017 07:11:31 +0000 (16:11 +0900)]
Style fixes for consistency
Shinichiro Hamaji [Fri, 20 Oct 2017 07:09:28 +0000 (16:09 +0900)]
Merge pull request #245 from DariuszOstolski/issue211
Fix username lookup in case of missing USER environment variable
Shinichiro Hamaji [Fri, 20 Oct 2017 06:48:21 +0000 (15:48 +0900)]
Merge pull request #254 from DariuszOstolski/issue253
#253: Use MS preprocessor idiom to disable warning
Dariusz Ostolski [Wed, 18 Oct 2017 18:56:49 +0000 (20:56 +0200)]
#253: Use MS preprocessor idiom to disable warning
Shinichiro Hamaji [Wed, 11 Oct 2017 15:25:02 +0000 (00:25 +0900)]
Merge pull request #226 from sergiud/zero-allocation-log-failure
Zero allocation fix
Sergiu Deitsch [Thu, 6 Jul 2017 09:05:58 +0000 (11:05 +0200)]
fixed gcc logging failure
Dariusz Ostolski [Wed, 20 Sep 2017 16:41:07 +0000 (18:41 +0200)]
Added HAVE_PWD_H to cmake build
Dariusz Ostolski [Tue, 19 Sep 2017 20:23:53 +0000 (22:23 +0200)]
Fix username lookup in case of missing USER environment variable
Shinichiro Hamaji [Wed, 9 Aug 2017 15:06:08 +0000 (00:06 +0900)]
Merge pull request #228 from sergiud/dll-export-fix
Fix for missing exports (fixes #227)
Sergiu Deitsch [Wed, 9 Aug 2017 13:21:32 +0000 (15:21 +0200)]
added missing exports (fixes #227)
Shinichiro Hamaji [Wed, 9 Aug 2017 07:35:05 +0000 (16:35 +0900)]
Merge pull request #225 from jray272/remove-log-every-n-assert
Fix LOG_EVERY_N with clang -Wunused-local-typedef
Jim Ray [Wed, 9 Aug 2017 07:09:14 +0000 (00:09 -0700)]
Remove GOOGLE_GLOG_COMPILE_ASSERT
This compile time assert is no longer used anywhere in glog. Remove
it.
Shinichiro Hamaji [Wed, 9 Aug 2017 06:04:26 +0000 (15:04 +0900)]
Merge pull request #224 from jray272/run-windows-script
Run src/windows/preprocess.sh to pick up latest logging.h.in changes
Jim Ray [Mon, 31 Jul 2017 05:30:33 +0000 (22:30 -0700)]
Fix LOG_EVERY_N with clang -Wunused-local-typedef
Glog uses a pre-C++11 compile time assert to verify the validity of
the severity parameter for LOG_EVERY_N. Unfortunately, some compilers
will complain about the usage of LOG_EVERY_N with
"-Wunused-local-typedef" due to the way the compile time assert is
constructed. This makes it impossible to use LOG_EVERY_N with this
warning treated as an error.
The fix simply removes the assert entirely. This is safe to do since
you can't put anything invalid into the severity parameters without
generating a compile error elsewhere. This has been safe to do ever
since the GLOG_ prefixes were added as part of
6febec361e.
Fixes #223
Jim Ray [Mon, 31 Jul 2017 05:25:36 +0000 (22:25 -0700)]
Update Windows logging.h based on
2df0ca34aa
Commit changes to src/windows/glog/logging.h that were missed in
2df0ca34aa. Because a change to src/glog/logging.h.in was made,
src/windows/preprocess.sh needed to be run.
Jim Ray [Mon, 31 Jul 2017 04:38:38 +0000 (21:38 -0700)]
Add Jim Ray to CONTRIBUTORS
Shinichiro Hamaji [Tue, 1 Aug 2017 05:41:47 +0000 (14:41 +0900)]
Merge pull request #218 from andschwa/remove-sln
Update Windows docs
Andrew Schwartzmeyer [Wed, 26 Jul 2017 18:35:04 +0000 (11:35 -0700)]
Update Windows readme for CMake
Andrew Schwartzmeyer [Wed, 26 Jul 2017 18:34:52 +0000 (11:34 -0700)]
Update gitignore for CMake and Visual Studio
Andrew Schwartzmeyer [Wed, 26 Jul 2017 18:34:40 +0000 (11:34 -0700)]
Delete ancient Visual Studio Solution file.
Shinichiro Hamaji [Wed, 26 Jul 2017 08:46:57 +0000 (17:46 +0900)]
Merge pull request #216 from google/revert-120-master
Revert "configure.ac: Allow user to disable gflags"
Shinichiro Hamaji [Wed, 26 Jul 2017 08:44:25 +0000 (17:44 +0900)]
Revert "configure.ac: Allow user to disable gflags"
Shinichiro Hamaji [Wed, 19 Jul 2017 14:51:20 +0000 (23:51 +0900)]
Merge pull request #120 from ribalda/master
configure.ac: Allow user to disable gflags
Shinichiro Hamaji [Sun, 9 Jul 2017 16:53:19 +0000 (01:53 +0900)]
Merge pull request #209 from sergiud/cmake-icc-fix
cmake: fixed gflags namespace detection (fixes #193)
Sergiu Deitsch [Sun, 9 Jul 2017 00:04:17 +0000 (02:04 +0200)]
cmake: fixed gflags namespace detection (fixes #193)
This commit fixes gflags namespace detection using Intel compiler and ensures
the generated try_compile command line does not produce malformed paths.
Shinichiro Hamaji [Thu, 6 Jul 2017 06:01:10 +0000 (15:01 +0900)]
Merge pull request #153 from sergiud/cmake-gnu-install-dirs
cmake: do not hardcode relative install directories
Shinichiro Hamaji [Thu, 6 Jul 2017 06:00:37 +0000 (15:00 +0900)]
Merge pull request #152 from sergiud/cmake-project-name
cmake: changed project name from google-glog to glog
Shinichiro Hamaji [Thu, 6 Jul 2017 06:00:06 +0000 (15:00 +0900)]
Merge pull request #157 from sergiud/cygwin-support
Cygwin support
Shinichiro Hamaji [Thu, 6 Jul 2017 05:58:37 +0000 (14:58 +0900)]
Merge pull request #158 from sergiud/zero-allocation
[RFC] reduce heap memory allocations to zero
Shinichiro Hamaji [Thu, 6 Jul 2017 05:52:13 +0000 (14:52 +0900)]
Merge pull request #145 from pixelb/rate-limit-posix-fadvise
rate limit calls to posix_fadvise()
Hans-Andreas Engel [Fri, 8 Apr 2016 08:51:40 +0000 (10:51 +0200)]
reduce memory allocations to zero
Shinichiro Hamaji [Thu, 29 Jun 2017 03:36:25 +0000 (12:36 +0900)]
Merge pull request #199 from v1bri/brian-fix-gflags-link
Use gflags ALIAS instead of ${gflags_XXX} vars
Shinichiro Hamaji [Wed, 28 Jun 2017 03:31:40 +0000 (12:31 +0900)]
Merge pull request #168 from andschwa/windows-stacktrace
Port stack tracing to Windows
Andrew Schwartzmeyer [Tue, 27 Jun 2017 00:13:21 +0000 (17:13 -0700)]
Support signal handler on Windows
Andrew Schwartzmeyer [Fri, 23 Jun 2017 19:39:49 +0000 (12:39 -0700)]
Link to DbgHelp using pre-processor directive
This method ensure that all users of glog get automatically linked to
the DbgHelp library without needing to set compiler flags.
Andrew Schwartzmeyer [Thu, 25 May 2017 20:43:39 +0000 (13:43 -0700)]
Export GetStackTrace
Necessary when building with BUILD_SHARED_LIBS=1.
Andrew Schwartzmeyer [Sat, 4 Mar 2017 00:50:08 +0000 (16:50 -0800)]
Support symbolizer and demangler on Windows
Andrew Schwartzmeyer [Wed, 21 Dec 2016 21:48:58 +0000 (13:48 -0800)]
Support stacktrace on Windows
Andrew Schwartzmeyer [Tue, 20 Dec 2016 23:24:50 +0000 (15:24 -0800)]
Copy stacktrace_generic-inl.h for Windows
Andrew Schwartzmeyer [Fri, 23 Jun 2017 17:00:12 +0000 (10:00 -0700)]
Add Andrew Schwartzmeyer to authors and contributors
Brian Orr [Thu, 22 Jun 2017 18:24:58 +0000 (11:24 -0700)]
Specify gflags version in CMakeLists.txt
Brian Orr [Thu, 22 Jun 2017 07:25:13 +0000 (00:25 -0700)]
Use gflags ALIAS instead of ${gflags_XXX} vars
The gflags project updated their CMake config last year with a
`gflags` ALIAS target. This can be used instead of the legacy
`${gflags_LIBRARIES}` and `${gflags_INCLUDE_DIRS}` variables. It also
looks cleaner.
Fixes #198
Fumitoshi Ukai [Fri, 12 May 2017 05:57:09 +0000 (14:57 +0900)]
Merge pull request #188 from shinh/remove-configure
Remove files generated by autotools
closes #165
Shinichiro Hamaji [Fri, 12 May 2017 05:52:54 +0000 (14:52 +0900)]
Remove files generated by autotools
for #165. I think not many projects have them in their repo.
Shinichiro Hamaji [Wed, 10 May 2017 11:42:57 +0000 (20:42 +0900)]
Update the version in CMakeLists.txt to 0.3.5
Fumitoshi Ukai [Wed, 10 May 2017 03:51:39 +0000 (12:51 +0900)]
Merge pull request #186 from shinh/backport
Backport internal changes
Shinichiro Hamaji [Tue, 9 May 2017 08:35:18 +0000 (17:35 +0900)]
Add a hack for naive include scanners
Shinichiro Hamaji [Tue, 9 May 2017 08:22:38 +0000 (17:22 +0900)]
Define OS_LINUX only if it's not defined yet
Shinichiro Hamaji [Tue, 9 May 2017 08:21:16 +0000 (17:21 +0900)]
symbolize: Allow 4kB stack consumption on PPC64
Shinichiro Hamaji [Tue, 9 May 2017 08:11:51 +0000 (17:11 +0900)]
x86 stacktrace: Use __builtin_frame_address if possible
Shinichiro Hamaji [Tue, 9 May 2017 08:05:55 +0000 (17:05 +0900)]
Relax test for symbolize
Don't rely on an internal-linkage extern "C" function having an
unmangled name. This isn't required by the ABI, and in fact is not
valid for a conforming compiler(!). Instead, allow symbolization to
produce either a mangled or an unmangled name here.
Shinichiro Hamaji [Tue, 9 May 2017 08:01:07 +0000 (17:01 +0900)]
Use LOG(FATAL) instead of CHECK(false)
Shinichiro Hamaji [Tue, 9 May 2017 07:41:58 +0000 (16:41 +0900)]
Run src/windows/preprocess.sh
Shinichiro Hamaji [Tue, 9 May 2017 07:24:50 +0000 (16:24 +0900)]
glog: release 0.3.5
Fumitoshi Ukai [Fri, 21 Apr 2017 00:54:53 +0000 (09:54 +0900)]
Merge pull request #179 from renning22/master
CHECK_NOTNULL works with smart pointers when compiled in C++11.
Ning Ren [Thu, 20 Apr 2017 22:30:42 +0000 (15:30 -0700)]
CHECK_NOTNULL works with smart pointers when compiled in C++11.
Fumitoshi Ukai [Tue, 7 Mar 2017 03:44:37 +0000 (12:44 +0900)]
Merge pull request #169 from mayah/windows-no-return
Add __declspec(noreturn) on Win
mayah [Tue, 7 Mar 2017 02:22:24 +0000 (11:22 +0900)]
Add __declspec(noreturn) on Win
Currently cl.exe doesn't know LOG(FATAL) exits the program. Set
__declspec(noreturn).
Fumitoshi Ukai [Thu, 9 Feb 2017 02:04:00 +0000 (11:04 +0900)]
Merge pull request #164 from yoshisatoyanagisawa/dcheck_always_on
DCHECK_ALWAYS_ON to make D* enabled under NDEBUG
Yoshisato Yanagisawa [Tue, 7 Feb 2017 06:47:51 +0000 (15:47 +0900)]
DCHECK_ALWAYS_ON to make D* enabled under NDEBUG
The macro NDEBUG could be automatically defined for release build on
some build environments (e.g. MSVC). If we use NDEBUG as a key to
distinguish using DCHECK as CHECK (I call this DCHECK is enabled) or
not, we cannot make DCHECK enabled for release build on such
environments.
Considering people use a program with glog for presubmit testing or
dogfooding, they should need to do release build with DCHECK enabled.
Sergiu Deitsch [Tue, 17 Jan 2017 11:47:11 +0000 (12:47 +0100)]
fixed cygwin compilation errors
Sergiu Deitsch [Tue, 10 Jan 2017 10:34:42 +0000 (11:34 +0100)]
cmake: do not hardcode relative install directories
Sergiu Deitsch [Tue, 10 Jan 2017 10:15:18 +0000 (11:15 +0100)]
cmake: changed project name from google-glog to glog
This fixes the default install location on Windows. Specifically,
find_package works now out-of-the box with the default
CMAKE_INSTALL_PREFIX.
Pádraig Brady [Fri, 9 Dec 2016 19:45:34 +0000 (19:45 +0000)]
rate limit calls to posix_fadvise()
There can be a large kernel overhead involved in POSIX_FADV_DONTNEED.
There is no point in calling this per item logged, so rate limit
to at most once per 2MiB written.
With a simple test program that logs 100K items at WARNING level:
Before:
$ time strace -c -e fadvise64 log.test \
-log_dir=/dev/shm -logtofiles=true -logtostderr=false
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
100.00 12.522509 125 99957 fadvise64
------ ----------- ----------- --------- --------- ----------------
real 0m52.671s
user 0m2.194s
sys 0m44.022s
After:
$ time strace -c -e fadvise64 log.test \
-log_dir=/dev/shm -logtofiles=true -logtostderr=false
% time seconds usecs/call calls errors syscall
------ ----------- ----------- --------- --------- ----------------
100.00 0.000759 152 5 fadvise64
------ ----------- ----------- --------- --------- ----------------
real 0m4.206s
user 0m1.436s
sys 0m3.153s
Fixes issue #84
Ricardo Ribalda Delgado [Thu, 11 Aug 2016 09:49:36 +0000 (11:49 +0200)]
configure.ac: Allow user to disable gflags
Under some circumstances like cross-compilation, the user might not want
to enable support for gflags.
This patch allows support for --without-gflags
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Fumitoshi Ukai [Thu, 20 Oct 2016 06:52:27 +0000 (15:52 +0900)]
Update github.com/sergiud in AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 07:40:55 +0000 (16:40 +0900)]
Merge pull request #132 from sergiud/cmake-disable-unittests
cmake: allow to disable building unit tests
Sergiu Deitsch [Wed, 19 Oct 2016 07:28:19 +0000 (09:28 +0200)]
cmake: allow to disable building unit tests
This commit introduces a CMake `BUILD_TESTING` boolean option that
allows to disable unit tests. This is especially useful in superbuilds
where typically only the main library is built. By default, this option
is enabled.
Fumitoshi Ukai [Wed, 19 Oct 2016 07:29:34 +0000 (16:29 +0900)]
Merge pull request #127 from MinGW-caffe/master
try to avoid the error "conflicting declaration 'typedef DWORD pthread_t'" etc. in MinGW
Fumitoshi Ukai [Wed, 19 Oct 2016 07:28:53 +0000 (16:28 +0900)]
Add MiniLight to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 07:10:39 +0000 (16:10 +0900)]
Merge pull request #123 from yying/master
Set sinks_ to NULL after deletion in LogDestination::DeleteLogDestinations
Fumitoshi Ukai [Wed, 19 Oct 2016 07:09:41 +0000 (16:09 +0900)]
Add Andy Ying to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 07:06:38 +0000 (16:06 +0900)]
Merge pull request #116 from pcc/fix2
Fix autotools build.
Fumitoshi Ukai [Wed, 19 Oct 2016 07:02:49 +0000 (16:02 +0900)]
Merge pull request #98 from willyd/relocatable
Added $<BUILD_INTERFACE> to gflags include directory
Fumitoshi Ukai [Wed, 19 Oct 2016 06:59:24 +0000 (15:59 +0900)]
Add Guillaume Dumont to AUTHORS/CONTRIBUTORS
Fumitoshi Ukai [Wed, 19 Oct 2016 06:52:32 +0000 (15:52 +0900)]
Merge pull request #129 from sergiud/cmake-PIC
cmake: enable position independent code (PIC)
Fumitoshi Ukai [Wed, 19 Oct 2016 06:51:45 +0000 (15:51 +0900)]
Merge pull request #130 from sergiud/cmake-warning-fix
cmake: fixed clang warning propagation to gcc
Sergiu Deitsch [Fri, 7 Oct 2016 09:03:19 +0000 (11:03 +0200)]
cmake: fixed clang warning propagation to gcc
Sergiu Deitsch [Fri, 7 Oct 2016 08:54:14 +0000 (10:54 +0200)]
cmake: enable position independent code (PIC)
MiniLight [Sun, 2 Oct 2016 16:38:15 +0000 (00:38 +0800)]
try to avoid the error "conflicting declaration 'typedef DWORD
pthread_t'" etc.
Andy Ying [Sun, 11 Sep 2016 05:16:32 +0000 (01:16 -0400)]
NULL sinks_ after deletion to prevent dangling pointer
Fumitoshi Ukai [Thu, 14 Jul 2016 01:47:13 +0000 (10:47 +0900)]
Add Peter Collingbourne <pcc@google.com> to CONTRIBUTORS
Fumitoshi Ukai [Thu, 14 Jul 2016 01:44:18 +0000 (10:44 +0900)]
Merge pull request #115 from pcc/fix1
symbolize: Calculate a module's zero VA using program headers.
Peter Collingbourne [Thu, 23 Jun 2016 01:34:48 +0000 (18:34 -0700)]
Fix autotools build.
It looks like commit 3c49b93 modified the auto-generated file src/config.h.in
to add a definition of macro GOOGLE_GLOG_DLL_DECL. One of the autotools
reverts this change upon running "make", causing the build to fail when a
source file includes demangle.h.
To fix the problem, revert the change to src/config.h.in and include
glog/logging.h from demangle.h which provides a definition of that macro.
Peter Collingbourne [Thu, 23 Jun 2016 01:18:06 +0000 (18:18 -0700)]
symbolize: Calculate a module's zero VA using program headers.
Previously we were using a module's "start address", i.e. the
address at which the module's executable region was mapped, as the
zero virtual address, i.e. the address from which the DSO's virtual
addresses are calculated. This works fine for DSOs created by the
bfd and gold linkers, which will emit a PT_LOAD directive into the
program header which loads the executable region at virtual address
(p_vaddr) and file offset (p_offset) 0.
However, the lld linker may place a read-only region before the
executable region, meaning that both p_vaddr and p_offset for the
executable region are non-zero. This means that any symbols resolved
by the symbolizer are resolved to an incorrect virtual address. To
correctly calculate the address corresponding to virtual address zero,
we need to take into account p_vaddr and p_offset.
Specifically, the calculation starts with the "base address", i.e. the
start address minus the file offset. To get from the base address to
virtual address zero, we first add p_offset. This gives us the mapped
address of the start of the segment, or in other words the mapped
address corresponding to the virtual address of the segment. (Note
that this is distinct from the start address, as p_offset is not
guaranteed to be page aligned.) We then subtract p_vaddr, which takes
us to virtual address zero.
Fumitoshi Ukai [Fri, 15 Apr 2016 08:05:30 +0000 (17:05 +0900)]
Merge pull request #101 from yasushi-saito/master
Allow permission line in /proc/self/map to be "rwx", not just "r-x".
Fumitoshi Ukai [Wed, 13 Apr 2016 05:00:49 +0000 (14:00 +0900)]
Merge pull request #91 from abdasgupta/master
Added support for PowerPC.
Fumitoshi Ukai [Wed, 13 Apr 2016 04:59:08 +0000 (13:59 +0900)]
Merge pull request #82 from sergiud/cmake-imported-target
Better support and documentation for CMake projects that consume glog
Yaz Saito on W541 [Mon, 11 Apr 2016 21:35:42 +0000 (14:35 -0700)]
Allow permission line in /proc/self/map to be "rwx", not just "r-x". At
least in Ubuntu14, a binary file that's writable by the process owner
has permission "rwx", not "r-x".
Guillaume Dumont [Tue, 5 Apr 2016 18:02:42 +0000 (14:02 -0400)]
Added $<BUILD_INTERFACE> to gflags include to avoid including the gflags include dir in the glog-targets.cmake
Fumitoshi Ukai [Thu, 31 Mar 2016 08:50:09 +0000 (17:50 +0900)]
Merge pull request #96 from mayah/update-windows
Update src/windows/glog/logging.h to ToT
mayah [Thu, 31 Mar 2016 08:29:36 +0000 (17:29 +0900)]
Run src/windows/preprocess.sh
src/windows/glog/logging.h is not generated by the current source.
Let me run src/windows/preprocess.sh and update the source.
Abhishek Dasgupta [Wed, 16 Mar 2016 09:28:18 +0000 (05:28 -0400)]
Added support for PowerPC.
Sergiu Dotenco [Fri, 8 Jan 2016 14:21:24 +0000 (15:21 +0100)]
added CMake usage instructions
Sergiu Dotenco [Fri, 8 Jan 2016 13:55:58 +0000 (14:55 +0100)]
cmake: allow to refer to imported glog target as glog::glog
Fumitoshi Ukai [Thu, 17 Dec 2015 07:31:55 +0000 (16:31 +0900)]
use namespace GFLAGS_NAMESPACE instead namespace gflags
only signalhandler_unittest.cc uses "using namespace gflags".
others use "using namespace GFLAGS_NAMESPACE", so
signalhandler_unittest.cc does the same way.
fixes #62
Fumitoshi Ukai [Thu, 17 Dec 2015 06:40:25 +0000 (15:40 +0900)]
win: use _fdopen instead of fdopen
The POSIX function fdopen is deprecated.
Use the ISO C++ conformant _fdopen instead.
https://msdn.microsoft.com/library/ms235351.aspx
fixes #73
Fumitoshi Ukai [Thu, 17 Dec 2015 06:36:40 +0000 (15:36 +0900)]
win: FAILED macro can't be used with HANDLE.
FAILED macro is for HRESULT, not for HANDLE.
FindFirstFile returns INVALID_HANDLE_VALUE when error or not found.
https://msdn.microsoft.com/library/windows/desktop/
aa364418(v=vs.85).aspx
fixes #79
Fumitoshi Ukai [Thu, 17 Dec 2015 06:26:15 +0000 (15:26 +0900)]
avoid calling new/malloc in signalhandler.
FlushLogFilesUnsafe would be called in FailureSignalHandler,
so should avoid calling new/malloc, which are not signal safe.
fixes #78
Fumitoshi Ukai [Fri, 27 Nov 2015 04:18:55 +0000 (13:18 +0900)]
Merge pull request #74 from yoshisatoyanagisawa/fix_sigabrt_action
Reset SIGABRT action only if FailureSignalHandler is installed.