Vitor Sousa [Fri, 12 Jul 2019 20:09:41 +0000 (17:09 -0300)]
csharp: fix some unit tests that rely on garbage collection
Summary:
Fix unit tests `TestEoInherit.inherited_collected` and
`TestFunctionPointers.set_callback_inherited_called_from_c`.
Iterate through garbage collection and EFL main loop more times to ensure that
allocated objects are really collected.
Also expand the test utility method `CollectAndIterate` to receive the number of
times to call the whole cleaning iteration process (not only the garbage
collection).
Test Plan: `meson test`
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9271
Cedric BAIL [Fri, 14 Jun 2019 23:46:17 +0000 (16:46 -0700)]
evas: add a test for loading Android 9patch file.
Example data come from https://github.com/vindolin/ninepatch/tree/master/ninepatch/data
under MIT license.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9105
Cedric BAIL [Fri, 14 Jun 2019 23:43:23 +0000 (16:43 -0700)]
ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas.
This allow evas test to work with an Ecore_Evas directly. It prevent leaking of memory
in the case of half destroying Ecore_Evas.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9104
Cedric BAIL [Thu, 13 Jun 2019 22:35:48 +0000 (15:35 -0700)]
evas: add support for .9.png file to PNG loader.
This support Android 9 patch file format. Only black is a recognized color for both
the stretch area and the content area. All other color are associated with being
"white".
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9103
Cedric BAIL [Thu, 13 Jun 2019 22:34:09 +0000 (15:34 -0700)]
evas: add infrastructure to feed 9 patch information from file loader to image object.
This is just the plumbing that feed data provided along android 9 patch image for example
into Evas object image new stretch and content region infrastructure for rendering them
properly.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9102
Cedric BAIL [Fri, 31 May 2019 18:57:53 +0000 (11:57 -0700)]
evas: break Image_Loader API to allow for getting property from the data field of an image.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9101
Cedric BAIL [Fri, 31 May 2019 17:43:32 +0000 (10:43 -0700)]
evas: break Evas_Loader API and introduce a version numbering for Image_Loader.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9099
Cedric BAIL [Fri, 31 May 2019 00:43:20 +0000 (17:43 -0700)]
evas: improve test to evaluate stretch region effect on content region.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9098
Cedric BAIL [Fri, 31 May 2019 00:42:58 +0000 (17:42 -0700)]
evas: take stretch region into account when content region is requested.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9097
Cedric BAIL [Thu, 9 May 2019 00:54:55 +0000 (17:54 -0700)]
evas: add support for stretchable region.
This is the first step into introducing support for Android 9 patch
format (extension: .9.png). The principle is to expose a new property
on image object that define a complete behavior incompatible with other
border and fill logic. The reason is that 9 patch allow for any number
of stretchable area inside an image, not just for each corner. The way
to define this is by giving a pointer to an array of the proper type
that define stretchable region relative to each other.
The logic being slightly more complex than the border and fill logic,
it is slightly slower. If you are just defining corner on your image
for something like a button, you would still get better performance
using border. I will try to make edje_cc detect those case and fallback
to border when possible.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9096
Cedric BAIL [Thu, 30 May 2019 18:25:39 +0000 (11:25 -0700)]
evas: add test for the new efl_gfx_image_content_region_get API.
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9095
Cedric BAIL [Thu, 30 May 2019 18:22:42 +0000 (11:22 -0700)]
evas: add an API to know where inside an object content can be layout over.
The first step with this API is to use the information provided when setting
the border on an image to define the content area inside it. Improvement will
be to use more flexible stretch region area to make it more customizable and
finally read the information from a 9patch file (.9.png).
Reviewed-by: Hermet Park <hermetpark@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9093
Subodh Kumar [Fri, 12 Jul 2019 15:58:35 +0000 (11:58 -0400)]
edje: Add support for map zoom to use other part center.
Summary:
Current:
In edc, zoom is supposed to happen from object center, there is no way to
change the center of the zoom.
Changes:
Adding support to change the center of zooming just like map rotation by using
other part's center.
@feature
Reviewers: cedric, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9115
Mike Blumenkrantz [Thu, 11 Jul 2019 18:17:30 +0000 (14:17 -0400)]
elm_test: fix some range api misuse in spotlight test
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9286
Marcel Hollerbach [Fri, 12 Jul 2019 13:01:43 +0000 (15:01 +0200)]
efl_ui_spec_suite: this is not python2
i don't know why it was added like this.
Vitor Sousa [Fri, 12 Jul 2019 13:07:27 +0000 (09:07 -0400)]
cxx: remove compilation warnings in C++ code, from both gcc and clang
Summary:
Remove almost all the compilation warnings from C++ code. Only explicit
warnings using the `#warning` preprocessor directive remain.
Some warnings had to be suppressed with `#pragma` directives because the
behavior they were warning about is intended in some specific places.
Code comments were added in such situations.
Added a generator that creates `#pragma` directives in order to suppress
warnings in all generated C++ headers.
Currently `-Wignored-qualifiers` is the only warning category being suppressed.
The innocuous const qualifiers that it points are inoffensive and have
no effect in compilation at all.
They are also hard to track in generation since they can emerge from different
types in many places.
To ease the generation of the warning suppressors an utility constructor was
added to `efl::eolian::grammar::attributes::unused_type`.
Add constructors to `eolian_mono::class_context` to default initialize its
internal string and avoid field initialization warnings.
Test Plan: `meson test`
Reviewers: lauromoura, felipealmeida, zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl_language_bindings
Differential Revision: https://phab.enlightenment.org/D9275
Godly T.Alias [Fri, 12 Jul 2019 12:45:18 +0000 (08:45 -0400)]
Evas Events: Decrement grab count on freeze state
Summary:
Decrement grab count of mouse event when mouse up happen during a freeze state.
Currently as grab count is not reduced in this scenario, further touches gets ignored.
Signed-off-by: Godly T.Alias <godlytalias@yahoo.co.in>
Test Plan: (on scenario where proxy exists) mouse down -> freeze events -> mouse up -> unfreeze events
Reviewers: cedric, raster, zmike, Hermet
Reviewed By: zmike
Subscribers: zmike, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9214
Vincent Torri [Fri, 12 Jul 2019 11:19:19 +0000 (12:19 +0100)]
draw static lib: use sse3 instructions set even on Windows
Summary:
sse3 instructions set exists since 2003/2004. One can consider that computers with Windows have it, these days
Note also that ector and evas also use sse3 instructions without the test disabling the Windows platform
Test Plan: compilation
Reviewers: zmike, raster, cedric, bu5hm4n
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9284
Hosang Kim [Fri, 12 Jul 2019 08:22:16 +0000 (10:22 +0200)]
Rename orientation -> image_orientation.
Summary:
Efl.Gfx.Image_Orientable and Efl.Ui.Layout_Orientable have same property name.
So when class extends both interfaces, it makes conflict.
Relates to T7924
Reviewers: woohyun, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9299
Hermet Park [Thu, 11 Jul 2019 11:10:17 +0000 (20:10 +0900)]
vector lottie: register node name as it's designed.
Caller could find/access a specific node with the name.
Mike Blumenkrantz [Thu, 11 Jul 2019 18:17:54 +0000 (14:17 -0400)]
evas/render: clear smart render cache when re-adding smart parent in post-render
given the following scenario:
* object is added to smartobj
* smartobj is otherwise unchanged
* render occurs
object will never render due to smartobj's render cache not including object
by clearing this cache when reinserting smartobj into the render tree for a
followup render, the object chain will be correctly processed on the next pass
fix T7990
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9287
Lauro Moura [Thu, 11 Jul 2019 16:36:25 +0000 (13:36 -0300)]
csharp: Enable conversion of container Eina.Values
Summary:
When creating a new Value with any IEnumerable of a supported type, the IEnumerable
will be copied into an Eina.Value of type EINA_VALUE_ARRAY_TYPE.
Similarly, `Unwrap()` on a Eina.Value container will create a new
System.Collections.List<T> and return it.
Depends on D9272
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl, #expertise_solutions
Differential Revision: https://phab.enlightenment.org/D9273
Lauro Moura [Thu, 11 Jul 2019 18:52:52 +0000 (15:52 -0300)]
csharp: Add helpers to get/set Values from Objects
Summary:
The user can construct an `Eina.Value` from a plain C# `object`, using
reflection to get the correct type of object and construct the correct
underlying C value.
Also added the `Unwrap()` method to return a C# object representing the
wrapped value.
Both operations are useful when using `Eina.Value` to
Get/Set values from `PropertyInfo` targets as in
```
var v = new Eina.Value(propInfo.GetValue(sourceObj));
...
propInfo.SetValue(targetObj, v.Unwrap());
```
Currently, containers are not supported. It will be added in a following
commit.
Depends on D9270
Reviewers: felipealmeida, vitor.sousa, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9272
Lauro Moura [Thu, 11 Jul 2019 18:50:33 +0000 (15:50 -0300)]
csharp: Tag exported API items.
Summary:
Attributes to be used by the API export tool. For end users, no changes
in the public API (except for a new attribute in generated classes).
Also simplifies constructor forwarding by not needing to pass the type
of the first "generated" class to compare.
Currently only automatically generated items are tagged.
Depends: D9259
Reviewers: vitor.sousa, felipealmeida
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9270
Shinwoo Kim [Thu, 11 Jul 2019 12:02:27 +0000 (12:02 +0000)]
test: add Efl.Ui.Format related test
This patch is including negative test as well.
See https://phab.enlightenment.org/D9276. This could make @bu5hm4n very happy.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9281
Mike Blumenkrantz [Wed, 10 Jul 2019 19:15:19 +0000 (15:15 -0400)]
tests/elm: create abstract function for clicking swallowed part objects
this handles all the part object getting and signal processing and geometry
calculating so you can get to clickin those parts faster
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9269
Mike Blumenkrantz [Wed, 10 Jul 2019 19:06:08 +0000 (15:06 -0400)]
tests/elm: break out click helper function for reuse
also fixes lifetime issue with spin parts
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9268
Marcel Hollerbach [Wed, 10 Jul 2019 15:25:15 +0000 (17:25 +0200)]
declare a few classes stable
this is the first wave of stablization declarations
fixes T7562
fixes T7846
fixes T7848
fixes T7859
fixes T7860
fixes T7861
fixes T7863
fixes T7878
fixes T7899
fixes T7918
fixes T7919
fixes T7963
fixes T7964
fixes T7965
fixes T7967
fixes T7969
fixes T7970
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9264
Marcel Hollerbach [Thu, 11 Jul 2019 14:07:11 +0000 (16:07 +0200)]
efl_ui_list: fix warnings
Summary: nothing to see here, move on!
Reviewers: zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9283
Lauro Moura [Thu, 11 Jul 2019 14:06:17 +0000 (16:06 +0200)]
csharp: Skip beta interfaces from the list of interfaces.
Summary:
Interfaces were declaring Beta parent interfaces instead of skipping
them.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9282
WooHyun Jung [Thu, 11 Jul 2019 10:18:50 +0000 (10:18 +0000)]
efl_ui_text: avoid infinite loop when long pressing
Long pressing on efl_ui_text gave inifinte loop. So, I removed
event_call in the event callback function.
I think long press functionality is almost broken after applying
clickable_util. There is no way to remove long press timer based
on the action on efl_ui_text.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9274
Marcel Hollerbach [Wed, 10 Jul 2019 14:57:57 +0000 (16:57 +0200)]
efl_ui_item: remove internal pointer to select_mode
there was this internal pointer to select_mode for getting the selection
mode of the container. However, we now have API for checking this, so
there is exactly 0 reason for doing this like this. Additionally, with
the old way of doing, bildings like C# or lua are just lost, they cannot
use this class at all in there implementations, as they cannot access
the privat data.
ref T905
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9263
Marcel Hollerbach [Wed, 10 Jul 2019 14:30:04 +0000 (16:30 +0200)]
efl_ui_item: rework parent relation
this commit ensures that there is a public way of setting the container
to a item. This was also like this before, just with the difference that
it was set and unset in all privacy, however, we want to have this class
also ready for bindings, so we should stop making things privat like
this.
Note: the removed fields from grid and list have not been used.
ref T7905
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9262
Alastair Poole [Thu, 11 Jul 2019 10:36:31 +0000 (10:36 +0000)]
ELM_CODE: Fix for theming of widget.
Change inhertitence for object so we can use
themes with elm_code.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9279
Shinwoo Kim [Thu, 11 Jul 2019 10:33:55 +0000 (10:33 +0000)]
Efl.Ui.Format: fix regressions
(1) Following commit did not care of efl_ui_format_string_get(set) of
elm_slider_part_indicator_eo.c
e776f5f Efl.Ui.Format revamp
Even though you call elm_slider_indicator_format_set with "%1.0f",
elm_slider_indicator_format_get returns NULL.
(2) The commit does not initialize format variables
- elm_slider_indicator_format_get
- elm_slider_unit_format_get
- elm_progressbar_unit_format_get
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9276
Lauro Moura [Thu, 11 Jul 2019 08:19:53 +0000 (10:19 +0200)]
csharp: Respect beta for implementable functions
Summary:
Build fix (remove warnings)
Instead of returning the beta functions in the vector and relying on
function generators to skip them, filter them out when filling the
implementable methods vector.
This will make the code return the actual number of implementable
function, skipping some unused fields in places like the NativeMethods
implementations.
Depends on D9258
Reviewers: vitor.sousa, felipealmeida, segfaultxavi
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl, #expertise_solutions
Differential Revision: https://phab.enlightenment.org/D9259
Lauro Moura [Thu, 11 Jul 2019 08:19:52 +0000 (10:19 +0200)]
csharp: Fix build and doc generation re beta stuff
Summary:
When skipping beta items, make sure generated documentation does not try
to refer to beta stuff using `see` tags. Doing so would lead to warnings
when generating the xml doc file and as we now treat warnings as errors,
compilation would fail.
Instead of `see` tags, use a simple `span` with a suffix text explaining
said item is beta.
Reviewers: vitor.sousa, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl, #expertise_solutions
Differential Revision: https://phab.enlightenment.org/D9258
Hermet Park [Thu, 11 Jul 2019 08:08:20 +0000 (17:08 +0900)]
vector json: replace the data type properly.
Shinwoo Kim [Thu, 11 Jul 2019 03:35:58 +0000 (03:35 +0000)]
efl_ui_*: fix regressions on legacy side
elm_progressbar_value_set with value bigger than max (or less than min) set to
max value instead of the bigger value. Following commit broke this behavior.
5efb4b3 efl_ui_*: get range users onto the same semantics
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9277
Cedric BAIL [Wed, 10 Jul 2019 21:09:15 +0000 (14:09 -0700)]
ecore: phab didn't get this bit from D8570.
Mike Blumenkrantz [Wed, 10 Jul 2019 19:02:56 +0000 (15:02 -0400)]
edje: check for user_defined hash existence before removing members
Differential Revision: https://phab.enlightenment.org/D9267
Cedric BAIL [Wed, 10 Jul 2019 18:39:44 +0000 (11:39 -0700)]
efl: use eina_streq for all property operation in model to avoid crash on NULL property name.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9266
Cedric BAIL [Wed, 3 Apr 2019 21:23:50 +0000 (14:23 -0700)]
ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8570
Mike Blumenkrantz [Wed, 10 Jul 2019 18:24:55 +0000 (14:24 -0400)]
edje: fix some small leaks when failing to reapply user-defined data
Summary:
this only occurs when the same text parts don't exist in the new layout,
which is an extremely unlikely scenario
Depends on D9210
Reviewers: cedric, bu5hm4n
Reviewed By: cedric, bu5hm4n
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9211
Mike Blumenkrantz [Wed, 10 Jul 2019 18:24:53 +0000 (14:24 -0400)]
edje: improve user-defined data caching to handle data before file is set
Summary:
this adds explicit handling for things like:
efl_add(SOMECLASS, parent,
efl_text_set(efl_added, "my text")
);
on edje-inheriting objects.
note that it's still impossible to do something like
efl_add(SOMECLASS, parent,
efl_text_set(efl_part(efl_added, "somepart"), "my text")
);
also add a unit test to verify common behaviors
@feature
Depends on D9209
Reviewers: cedric
Reviewed By: cedric
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9210
Mike Blumenkrantz [Wed, 10 Jul 2019 18:24:51 +0000 (14:24 -0400)]
edje: fix reapplying markup text on file/group change
Summary:
this was being stored as regular text when it was actually markup
@fix
Depends on D9208
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9209
Mike Blumenkrantz [Wed, 10 Jul 2019 18:24:48 +0000 (14:24 -0400)]
edje: change 'user_defined' member of Edje struct to be a hash
Summary:
this is where all user-added data (e.g., swallowed objects, table/box packs,
text strings) are stored. with this patch, it is now a hash by part name,
storing a list of user-defined data for that part
this simplifies a bit of code by deconstructing some list walks, and
should end up being slightly faster for large edje objects with lots of
user-defined data
ideally no functional changes
Depends on D9206
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9208
Mike Blumenkrantz [Wed, 10 Jul 2019 18:24:46 +0000 (14:24 -0400)]
eina/hash: add direct variants of list append/prepend functions
Summary:
this simplifies the process of manipulating lists inside hashes with a
non-copied key
@feature
Depends on D9205
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9206
Mike Blumenkrantz [Wed, 10 Jul 2019 18:24:43 +0000 (14:24 -0400)]
edje: remove _edje_user_definition_fetch()
Summary: this is an internal function which is never used
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9205
Mike Blumenkrantz [Wed, 10 Jul 2019 18:06:47 +0000 (14:06 -0400)]
efl/selection_manager: remove correct conditional
ref
ac26c0a69d0b4fc4b8e3517e23fe6b5c3b77a555
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9265
Mike Blumenkrantz [Wed, 10 Jul 2019 17:57:40 +0000 (13:57 -0400)]
tests/elm: fail tests if unexpected warnings or errors occur
Summary:
warnings and errors should never occur in unit tests unless they are
intentionally triggered. this will help catch regressions
Depends on D9256
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9257
Mike Blumenkrantz [Wed, 10 Jul 2019 17:57:35 +0000 (13:57 -0400)]
events: don't check for zeroed event types before registering them
Summary:
this handles the case of reinitializing a component, but it's totally
broken in the case of doing a full ecore restart
Depends on D9253
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9254
Mike Blumenkrantz [Wed, 10 Jul 2019 17:57:33 +0000 (13:57 -0400)]
efl/selection_manager: only create wl event handlers if using wl connection
Summary:
this codepath is broken if the wl server connection does not exist
Depends on D9252
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9253
Mike Blumenkrantz [Wed, 10 Jul 2019 17:57:30 +0000 (13:57 -0400)]
elm/player: remove slider range setting from constructor
Summary:
this was setting an invalid 0<->0 range, which is a misuse of api
Depends on D9251
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9252
Mike Blumenkrantz [Wed, 10 Jul 2019 17:57:28 +0000 (13:57 -0400)]
tests/elm: use helper functions for managing naviframe unit test abort-on-error
Summary: also bump up to abort on warnings
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9251
Hermet Park [Wed, 10 Jul 2019 11:38:54 +0000 (20:38 +0900)]
canvas event: remove unnecessary condition check.
This condition is duplicated in the function,
it's unnecessary.
Hermet Park [Wed, 10 Jul 2019 05:33:29 +0000 (14:33 +0900)]
efl_ui_textpath: adjust angle only for circle text.
Hermet Park [Wed, 10 Jul 2019 03:40:53 +0000 (12:40 +0900)]
efl_ui_textpath: code refactoring.
less symbol calls, no logic changes.
Hermet Park [Wed, 10 Jul 2019 03:34:04 +0000 (12:34 +0900)]
efl_ui_textpath: remove unnecessary set.
Textpath positioning is completed manually,
this is duplicated request, remove it.
Shinwoo Kim [Tue, 16 Jul 2019 05:27:50 +0000 (14:27 +0900)]
elm_progressbar: set elm.text.status to NULL (UX)
We have following tizen only commit.
- bfe7365 progressbar: remove wrong unit format for Tizen UX.
And upstream has following recently added commits
- 8ab2a74 Efl.Ui.Progressbar: Add explicit display control of progress label
As a result, Tizen progressbar shows elm.text.status by default.
But Tizen UX does not show elm.text.status by default.
@tizen_only
Change-Id: I7eb09b5b4e61d053d5b75a8354306843fdb1af33
InHong Han [Tue, 16 Jul 2019 05:47:37 +0000 (14:47 +0900)]
elm_entry : Modified to prevent sending wrong input hint
Change-Id: I96e82713d33b12281d85cc6b73a2dae097dbc469
Jihoon Kim [Wed, 10 Jul 2019 11:01:47 +0000 (20:01 +0900)]
ecore_imf: deprecate ambigous or unused APIs
ecore_imf_context_show
ecore_imf_context_hide
ecore_imf_context_control_panel_show
ecore_imf_context_control_panel_hide
ecore_imf_context_preedit_start_event_add
ecore_imf_context_preedit_end_event_add
ecore_imf_context_preedit_changed_event_add
ecore_imf_context_commit_event_add
ecore_imf_context_delete_surrounding_event_add
Change-Id: Ibdf98e4b40b0fa402abeb428fac6c295f74a73cb
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Godly T.Alias [Mon, 8 Jul 2019 14:23:26 +0000 (19:53 +0530)]
[Evas] Fix on object looping
Change-Id: Ifab2231e71f55e7b03631fb2e44272c32133dcff
Signed-off-by: Godly T.Alias <godlytalias@yahoo.co.in>
maxerba [Tue, 9 Jul 2019 17:41:01 +0000 (19:41 +0200)]
Updating spanish translation
Ali Alzyod [Tue, 9 Jul 2019 17:31:44 +0000 (19:31 +0200)]
evas_object_textblock: update documentation, setting color part
Summary: Now Textblock has the ability to parse color names same as hex value strings.
Reviewers: segfaultxavi, woohyun, bowonryu
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9250
Xavi Artigas [Tue, 9 Jul 2019 17:22:10 +0000 (19:22 +0200)]
docs: Update Efl.Ui.Box documentation
It has had a big uppercase FIXME text for 2 years.
Marcel Hollerbach [Tue, 9 Jul 2019 15:37:05 +0000 (17:37 +0200)]
efl_ui_pan: emit the viewport change when the position changes
otherwise the viewport changes are not propagated correctly. This is
needed in order to have the new item_container bug free.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9249
Carsten Haitzler (Rasterman) [Tue, 9 Jul 2019 15:02:40 +0000 (16:02 +0100)]
edje - double make sure edje messages are zero'd due to a segv i saw
i saw a segv on freeing em->msg as it was a junk ptr... i dont know
for sure it msg was properly initted but as em is recycled from trash
be sure and zero it when digging out of trash because em->msg was not
a valid ptr (and i wasnt using valgrind at the time to know for sure
and cant find this with valgrind now).
@fix
Mike Blumenkrantz [Tue, 9 Jul 2019 13:11:36 +0000 (09:11 -0400)]
tests/efl_ui: add event test for slider
this verifies event emission for slider like in legacy tests
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9246
Mike Blumenkrantz [Tue, 9 Jul 2019 12:52:07 +0000 (08:52 -0400)]
tests/evas: add file for evas event unit tests, add frozen mouse-up test
this adds an explicit test verifying that if an object is frozen before
a mouse-up event is passed through it, the callback for mouse-up will
not be called for that object
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9239
Marcel Hollerbach [Tue, 9 Jul 2019 12:49:12 +0000 (08:49 -0400)]
Introduce efl_ui_scroll_util files.
Summary:
this brings API that connects the theme to the object. This reduces the
amount of code that you need to write in order to develop a widget that
can be scrollable.
For now efl_ui_grid and efl_ui_scroller are replaced with it.
efl_ui_list / efl_ui_list_view are not handeled with this, as they will
be replaced with newer widgets.
Right now this is only avaiable in the C API. However, wrapping this
into a mixin should be easy.
Reviewers: zmike, segfaultxavi
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9245
Carsten Haitzler (Rasterman) [Tue, 9 Jul 2019 12:03:31 +0000 (13:03 +0100)]
elm - cursor - clear cursor job late to avoid crash
during cursor free a move cb seems to add another job again after it
wss already deleted during the free process, so just clear the job
really late instead. valgrind found this one
@fix
Xavi Artigas [Mon, 8 Jul 2019 14:59:19 +0000 (16:59 +0200)]
efl-mono: Treat Warnings as Errors
Now that there are 0 documentation warnings, let's make sure we stay this way.
Jaehyun Cho [Fri, 28 Jun 2019 10:35:19 +0000 (10:35 +0000)]
efl_ui_clickable: fix not to be clicked if pointer is processed
If pointer is processed by a container in its POINTER_MOVE event
callback, then clickable calls efl_ui_clickable_button_state_reset not
to be clicked by efl_ui_clickable_unpress.
e.g. Efl.Ui.Active_View.View_Manager_Scroll sets pointer processed in
POINTER_MOVE event callback not to click button during scrolling.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9204
Vitor Sousa [Tue, 9 Jul 2019 08:13:27 +0000 (10:13 +0200)]
cxx: fix some compilation warnings in C++ examples
Summary:
Fix some warnings in the C++ examples for elementary. These examples are build
by default in the normal meson compilation.
Only accidental warnings were fixed, explicit warnings using the `#warning`
preprocessor directive were maintained.
Test Plan: Compile with C++ binding.
Reviewers: lauromoura, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9244
Vitor Sousa [Tue, 9 Jul 2019 08:05:23 +0000 (10:05 +0200)]
csharp: update and disable tests that use deprecated eolian type notations
Summary:
Avoid the usage of deprecated Eolian type notations like `ptr()` in C# unit
tests.
In places where an alternative type could be used, tests were changed to use
a valid type, e.g. containers that stored `ptr(int)` were changed to store
`string`.
Tests for types that require a pointer notation were commented out and
disabled. They can be re-enabled when a new notation to the type is defined.
Depends on D9238
Test Plan: `meson test`
Reviewers: lauromoura, felipealmeida, q66, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, bu5hm4n, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9247
Vitor Sousa [Tue, 9 Jul 2019 08:00:06 +0000 (10:00 +0200)]
eolian_mono: fix non-beta build and support for slice/rw_slice keywords
Summary:
Add support for `slice` and `rw_slice` keywords in eolian_mono.
Now it generates the proper manual binding type for these native types.
Make unit tests use these keywords instead of native names.
Remove some unnecessary `@beta` tags from eolian types in unit tests so now
tests correctly compile without the `mono-beta` compilation flag.
Also make tests that use `Eina.Binbuf` "beta only".
In a future update, the external type `Eina.Binbuf` will be marked as beta, so
we shield the binding in anticipation.
Test Plan: `meson -Dbindings=mono -Dmono-beta=true` and `meson -Dbindings=mono -Dmono-beta=false`
Reviewers: lauromoura, felipealmeida, q66, segfaultxavi, bu5hm4n
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9238
Vitor Sousa [Mon, 8 Jul 2019 15:53:41 +0000 (17:53 +0200)]
csharp: fix build warning related with an unused field in an unit test
Test Plan: `meson test`
Reviewers: lauromoura, felipealmeida, segfaultxavi
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9240
JunsuChoi [Tue, 9 Jul 2019 06:46:41 +0000 (15:46 +0900)]
Ector.Renderer: Prevent too many unref.
Summary:
pd-> surface will try efl_xref whenever surface_set is called.
desturctor is called from a subclass, ref and unref do not match.
So, Add this condition temporarily.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9235
maxerba [Mon, 8 Jul 2019 19:17:06 +0000 (21:17 +0200)]
Updating french translation
Marcel Hollerbach [Sun, 7 Jul 2019 16:14:13 +0000 (18:14 +0200)]
efl_ui_spin_button: add test suite
this adds a testsuite to emulate and check the usage of buttons in the
spin button widget. This also verifies that the correct events are
emitted. (For now, the testcases from spin are also copied over, since
they inherit from each other)
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9232
Marcel Hollerbach [Sun, 7 Jul 2019 14:58:01 +0000 (16:58 +0200)]
efl_ui_spin_button: fix event calling in spin_button
before the spin event for changing the value was called twice if you
changed the value by the entry. Additionally, the changed,delay event is
not emitted when the value was changed via the arrow buttons.
This corrects this, additionally, this enables the delay timer when
focus is gone, this is expected and should be supported by the API.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9231
Marcel Hollerbach [Fri, 5 Jul 2019 17:09:43 +0000 (19:09 +0200)]
efl_ui_spin_button: make theme consistent
this reduces the amount of code needed in the widget itself,
additionally, the theme now follows a scheme.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9230
Marcel Hollerbach [Fri, 5 Jul 2019 16:18:33 +0000 (18:18 +0200)]
efl_ui_spin_button: cleanup internal data
there is no reason to store those two times in the internal data, as
they do not change at all. Additionally, saving the direction in the
internal data has also no reason, since it is *always* used in the call
after the setting, so this makes this a parameter.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9229
Marcel Hollerbach [Fri, 5 Jul 2019 16:08:02 +0000 (18:08 +0200)]
efl_ui_spin_button: this can also be done with the focus callback
this makes the code more readable, and reduces the amount of events we
are subscribing to.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9227
Marcel Hollerbach [Fri, 5 Jul 2019 15:44:36 +0000 (17:44 +0200)]
efl_ui_spin_button: change entry to button before changing value
doing this in pressed is kind of weird, if you are on a touchscreen,
missclick, and move the finger away, the entry is already transformed,
which is weird, this fixes that.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9226
Marcel Hollerbach [Fri, 5 Jul 2019 15:38:07 +0000 (17:38 +0200)]
efl_ui_spin_button: this function is 1:1 like this in efl_ui_spin
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9225
Marcel Hollerbach [Fri, 5 Jul 2019 15:35:06 +0000 (17:35 +0200)]
efl_ui_spin_button: replace timers with autorepeat of button
this was just reimplementing existing behaviour. This can be done more
easily
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9224
Marcel Hollerbach [Mon, 8 Jul 2019 14:18:57 +0000 (16:18 +0200)]
efl_ui_spec_suite: introduce two new test suites
this checks that the expected errors are in place, and the state does
not get changed when there is an errornous call.
ref T7895
ref T7894
Marcel Hollerbach [Mon, 8 Jul 2019 14:17:38 +0000 (16:17 +0200)]
efl_ui_*: get range users onto the same semantics
this commits introduces unified behaviour for the users of the range
interfaces. This includes:
- The same errors for limit_set errors
- The same errors for value setting outside the range
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9241
Marcel Hollerbach [Fri, 5 Jul 2019 12:11:23 +0000 (14:11 +0200)]
efl_ui_spin: add tests for basic spin features
this tests for the correct event emission. And checks the wheel
interaction.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9221
Xavi Artigas [Mon, 8 Jul 2019 14:56:49 +0000 (16:56 +0200)]
docs: Fill last missing docs from EO files
Some docs have been filled with placeholder text ("TBD") or with preliminary
text (marked with //TODO).
Having 0 doc warning we can now enable Warnings as Errors in mono, and in Eolian later on.
Vitor Sousa [Mon, 8 Jul 2019 15:46:25 +0000 (12:46 -0300)]
Revert "efl: prevent usage of some Eina.* stub types in stable APIs"
C# does not support `slice` and `rw_slice` yet.
Reverting until proper support lands.
This reverts commit
ec7bc0eddd7abc77d28605b0a6f0aea2e246a0ee.
Vitor Sousa [Mon, 8 Jul 2019 15:18:47 +0000 (17:18 +0200)]
csharp: fix some build warnings related with incorrect and missing documentation
Summary:
Some parameter names, tag names and cref identifiers in the documentation were
incorrect and causing warnings during compilation.
There were also warnings related with missing documentation in publicly
visible elements in the manual binding.
This commit fixes these incorrections and adds documentation to the manual
binding in order to solve these compilation warnings.
Warnings related with missing documentation in `.eo` files are still present.
Test Plan: Just compile with mono binding.
Reviewers: lauromoura, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9243
Daniel Kolesa [Mon, 8 Jul 2019 15:01:40 +0000 (17:01 +0200)]
efl: prevent usage of some Eina.* stub types in stable APIs
Mike Blumenkrantz [Mon, 8 Jul 2019 14:17:58 +0000 (16:17 +0200)]
eolian: fix leak in eolian_state_file_path_parse
Summary:
this fixes a trivial leak where a string is leaked at the end of the function.
it is not significant, but it still appears in leak detections.
Reviewers: q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9124
Vitor Sousa [Mon, 8 Jul 2019 14:16:07 +0000 (16:16 +0200)]
eolian_cxx: update eolian_cxx to recognize slice and rw_slice
Summary:
Update eolian_cxx to recognize the new keywords `slice` and `rw_slice`, so it
can generate the corresponding types `Eina_Slice` and `Eina_Rw_Slice`.
Reviewers: lauromoura, felipealmeida, q66
Reviewed By: q66
Subscribers: cedric, bu5hm4n, #reviewers, segfaultxavi, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9237
Vitor Sousa [Mon, 8 Jul 2019 14:15:41 +0000 (16:15 +0200)]
eolian_cxx: update tests to no longer use forbidden eolian notations
Summary:
Update eolian_cxx tests in order to remove forbidden eolian notations.
For tests with containers that support non-pointer types,
change `ptr(int)` to `int`.
For tests with containers that only support pointer types,
change `ptr(int)` to `string`.
Remove tests for features that are no longer meaningful with eolian new
restrictions.
Add a FIXME note to eina::range_array when used with eina::string_view.
Reviewers: lauromoura, felipealmeida, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers, bu5hm4n, segfaultxavi
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9236
Daniel Kolesa [Wed, 3 Jul 2019 15:52:04 +0000 (17:52 +0200)]
eolian: remove API to get freefunc of type
This is not supported anymore. For now, the syntax is kept
around because of broken C++ tests, but afterwards it will
also be removed.
Daniel Kolesa [Wed, 3 Jul 2019 13:03:59 +0000 (15:03 +0200)]
eolian: remove builtin freefuncs
For now this does not alter API behavior, so freefuncs are still
transitive to aliases etc., this will get removed later.