Bruno da Silva Belo [Thu, 7 Nov 2019 18:52:31 +0000 (19:52 +0100)]
csharp: Removing a never used class.
Summary: ref T8417
Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8417
Differential Revision: https://phab.enlightenment.org/D10611
Taehyub Kim [Thu, 7 Nov 2019 04:38:47 +0000 (13:38 +0900)]
efl_ui_alert_popup: add title part in parts block
Summary: add title part in parts block
Reviewers: Jaehyun_Cho, woohyun, zmike, segfaultxavi
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10596
Lauro Moura [Thu, 7 Nov 2019 02:47:50 +0000 (23:47 -0300)]
csharp: Fix test build dependency
Summary: Make dotnet target also depend on the manual test files.
Test Plan: Modify one of the manual files and run the tests again. The test target should be rebuilt.
Reviewers: bu5hm4n, segfaultxavi, brunobelo, felipealmeida
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10609
Lauro Moura [Thu, 7 Nov 2019 02:47:39 +0000 (23:47 -0300)]
efl: Make stable single-valued getters consistent.
Summary:
Instead of a getter with an explicit return type, change it to be a
single-valued property.
The eolian C generator takes care of making this single value the actual
return value of the C function.
This also makes these properties able to be reflected on.
The stack properties returns just a pointer and not a new ref, so no
@move needed.
Beta properties will be handled in a future commit.
Depends on D10601
Reviewers: segfaultxavi, bu5hm4n, q66, cedric
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers, brunobelo, felipealmeida
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10602
Bruno da Silva Belo [Thu, 7 Nov 2019 02:34:18 +0000 (23:34 -0300)]
csharp:comma have whitespace after and none before
Reviewers: felipealmeida, lauromoura, YOhoho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10575
Woochanlee [Wed, 6 Nov 2019 07:13:03 +0000 (07:13 +0000)]
edje_calc: UNLIKELY changed to LIKELY.
It should takes true almost all times when it checks.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10606
Cedric BAIL [Fri, 1 Nov 2019 15:03:00 +0000 (08:03 -0700)]
elementary: fix end of fast scroll not showing up during Efl.Ui.CollectionView scroll.
efl_ui_position_manager_entity_entities_ready is expecting the end offset and not the
length of how many items have been updated. Sending the correct number fixes the problem.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D10590
Xavi Artigas [Tue, 5 Nov 2019 19:26:14 +0000 (20:26 +0100)]
Efl.Interpolator*: More sensible API names and docs
Summary:
OK, so, ALL interpolator parameters were called "factor" and the docs
literally said "First factor, Second factor, ..."
After diving into the actual implementation, proper names (and types) for the
parameters were found and proper docs written.
I am afraid I could not make any sense of the Divisor interpolator code. Those
docs still need writing.
Test Plan: Everything still builds and passes tests. No functional changes.
Reviewers: zmike, cedric, bu5hm4n, Jaehyun_Cho
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10603
Lauro Moura [Tue, 5 Nov 2019 20:59:01 +0000 (17:59 -0300)]
csharp: Revamp dotnet support
Summary:
Instead of building with a patched meson version, make use of custom
targets and generated csproj files so we can used upstream meson
normally.
This avoids digging into "non official" dotnet stuff like calling
the CSC.dll directly that the patched meson tried to do.
To enable, run meson with `-Ddotnet=true`.
Regarding source file dependencies, Meson has a limitation[1]
about generated artifacts being placed in subdirectories.
In order to correctly track these generated artifacts for dotnet, we
generated them in the same folder as the csproj file through
`dotnet build -o`.
Instead of installing the dll like we do for mono, a nupkg is generated
and installed in the same folder as the dll would be
(<prefix>/lib/x86_64-linux-gnu/efl-mono-1)
To avoid messing around with Nupkg caches, we reference the source
project for the library directly instead of the nupkg when building the
test suite.
[1] https://github.com/mesonbuild/meson/issues/2320
Fixes T8168
Reviewers: bu5hm4n, woohyun, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, brunobelo, felipealmeida, segfaultxavi
Tags: #efl, #do_not_merge
Maniphest Tasks: T8168
Differential Revision: https://phab.enlightenment.org/D9717
Xavi Artigas [Wed, 30 Oct 2019 17:47:07 +0000 (18:47 +0100)]
docs: Add caveat details to Efl.Canvas.Animation
Summary:
Regarding object properties not matching actual rendered values when animations
are running.
Depends on D10560
Reviewers: bu5hm4n, cedric, zmike, Jaehyun_Cho
Reviewed By: bu5hm4n
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10566
Lauro Moura [Tue, 5 Nov 2019 14:59:46 +0000 (11:59 -0300)]
eolian: Imply @no_unused if @move in return.
Summary:
This makes sure the user is warned if it ignores a return value that
could potentially be a memory leak.
This also makes possible to use `value {}` blocks with `@move` instead
of value-less properties with `@no_unused`.
Also removed the `@move` from canvas_text_async_layout as it is ignored
in the only place it is used.
Reviewers: q66
Reviewed By: q66
Subscribers: #reviewers, #committers, bu5hm4n, felipealmeida, cedric, segfaultxavi
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10601
Xavi Artigas [Tue, 5 Nov 2019 10:48:40 +0000 (11:48 +0100)]
docs: Efl.Gfx.View
Stefan Schmidt [Tue, 5 Nov 2019 14:53:24 +0000 (15:53 +0100)]
travis: update Ubuntu image to the 19.10 release
We keep the 18.04 LTS until a new LTS comes along.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10600
Stefan Schmidt [Tue, 5 Nov 2019 14:26:36 +0000 (15:26 +0100)]
ci: work around ccache segafult during setup
This is the same fix we applied for the macOS. Somehow ccache segfaults
during the init. This only shows on the Ubuntu 19.10 update.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10599
Stefan Schmidt [Wed, 30 Oct 2019 08:40:46 +0000 (09:40 +0100)]
travis/ci: update Fedora CI images to 31
Also disable the gstreamer 0.10 module since this version is no longer
shipped with Fedora 31.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10597
Stefan Schmidt [Mon, 4 Nov 2019 14:52:29 +0000 (15:52 +0100)]
tests/spec: allow for a longer timeout of the spec suite for dist build
During our ninja dist builds on the CI we run into timeouts for the spec
test suite taking longer than the default 30s. We can't pass any
multiplier into the ninja dist command as we are doing on the other unit
test runs.
Allow th default value for this suite to also cover the CI case. It does
no harm on sutuations where it finishes faster.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10593
Christopher Michael [Tue, 5 Nov 2019 14:44:53 +0000 (09:44 -0500)]
tests/ecore-wl2: Remove surface test
This test is not necessary anymore as the ecore_wl2_surface function
it was testing is now an internal function
ref T8016
Christopher Michael [Tue, 5 Nov 2019 14:30:48 +0000 (09:30 -0500)]
evas-wayland-common: Move boolean fields to bottom of structure
Christopher Michael [Tue, 5 Nov 2019 14:29:06 +0000 (09:29 -0500)]
evas-wayland-common: Fix variable type
The 'resizing' variable here does not need to be an 'int' as it's
either true or false, so change to be Eina_Bool.
Christopher Michael [Tue, 5 Nov 2019 14:26:49 +0000 (09:26 -0500)]
evas-wayland-common: Add include for ecore_wl2 internal functions
Christopher Michael [Tue, 5 Nov 2019 14:22:43 +0000 (09:22 -0500)]
ecore-wl2: Move ecore_wl2_surface_alpha_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:22:21 +0000 (09:22 -0500)]
ecore-wl2: Move ecore_wl2_surface_window_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:22:01 +0000 (09:22 -0500)]
ecore-wl2: Move ecore_wl2_surface_manager_del function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:21:29 +0000 (09:21 -0500)]
ecore-wl2: Move ecore_wl2_surface_manager_add function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:21:06 +0000 (09:21 -0500)]
ecore-wl2: Move ecore_wl2_surface_buffer_create function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:20:42 +0000 (09:20 -0500)]
ecore-wl2: Move ecore_wl2_window_surface_flush function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:20:22 +0000 (09:20 -0500)]
ecore-wl2: Move ecore_wl2_surface_flush function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:20:02 +0000 (09:20 -0500)]
ecore-wl2: Move ecore_wl2_surface_post function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:19:41 +0000 (09:19 -0500)]
ecore-wl2: Move ecore_wl2_surface_assign function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:19:21 +0000 (09:19 -0500)]
ecore-wl2: Move ecore_wl2_surface_data_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:19:00 +0000 (09:19 -0500)]
ecore-wl2: Move ecore_wl2_surface_reconfigure function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:18:26 +0000 (09:18 -0500)]
ecore-wl2: Move ecore_wl2_surface_destroy function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:17:40 +0000 (09:17 -0500)]
ecore-wl2: Move ecore_wl2_surface_create function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:17:02 +0000 (09:17 -0500)]
ecore-wl2: Move ecore_wl2_buffer_age_inc function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:16:31 +0000 (09:16 -0500)]
ecore-wl2: Move ecore_wl2_buffer_age_set function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:16:11 +0000 (09:16 -0500)]
ecore-wl2: Move ecore_wl2_buffer_age_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:15:48 +0000 (09:15 -0500)]
ecore-wl2: Move ecore_wl2_buffer_busy_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:15:28 +0000 (09:15 -0500)]
ecore-wl2: Move ecore_wl2_buffer_busy_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:15:08 +0000 (09:15 -0500)]
ecore-wl2: Move ecore_wl2_buffer_destroy function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:14:48 +0000 (09:14 -0500)]
ecore-wl2: Move ecore_wl2_buffer_unlock function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:14:16 +0000 (09:14 -0500)]
ecore-wl2: Move ecore_wl2_buffer_lock function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:13:46 +0000 (09:13 -0500)]
ecore-wl2: Move ecore_wl2_buffer_discard function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:13:06 +0000 (09:13 -0500)]
ecore-wl2: Move ecore_wl2_buffer_unmap function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:12:43 +0000 (09:12 -0500)]
ecore-wl2: Move ecore_wl2_buffer_map function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:12:21 +0000 (09:12 -0500)]
ecore-wl2: Move ecore_wl2_buffer_wl_buffer_get function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:11:56 +0000 (09:11 -0500)]
ecore-wl2: Move ecore_wl2_buffer_destroy function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:11:35 +0000 (09:11 -0500)]
ecore-wl2: Move ecore_wl2_buffer_create function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:10:48 +0000 (09:10 -0500)]
ecore-wl2: Move ecore_wl2_buffer_init function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:09:14 +0000 (09:09 -0500)]
ecore-wl2: Move ecore_wl2_window_damage function to be internal
As this function is only used in 1 place and will likely never be used
outside of the modular dmabuf engine, we can move it to be internal
only.
ref T8013
Christopher Michael [Tue, 5 Nov 2019 14:08:23 +0000 (09:08 -0500)]
ecore-wl2-dmabuf: Add include for internal functions
Christopher Michael [Tue, 5 Nov 2019 13:53:29 +0000 (08:53 -0500)]
ecore-wl2: Move variables to be above functions
NB: No functional changes
Xavi Artigas [Tue, 5 Nov 2019 10:31:29 +0000 (11:31 +0100)]
docs: Efl.Ui.Table_Static
The need for this class is still being discussed in
https://phab.enlightenment.org/T8206
but at least it is a bit more clear what its purpose is.
Shinwoo Kim [Tue, 5 Nov 2019 01:44:58 +0000 (10:44 +0900)]
evas filter: Implement inverse color filter
Summary: This is the first version of inverse color filter both GL and SW.
Test Plan:
1. Create filter_example with following .
efl_gfx_filter_program_set(image, "inverse_color ()", "inverse color");
2. Run.
./filter_example (Use ELM_ACCEL=gl for GL engine)
Reviewers: Hermet, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10335
Hosang Kim [Thu, 7 Nov 2019 08:05:21 +0000 (17:05 +0900)]
build: add ecore_input_device
@tizen_only
Change-Id: I961f38268cfdae293342efc2c32b345285c6320e
Hosang Kim [Thu, 7 Nov 2019 07:09:42 +0000 (16:09 +0900)]
build: fix build error
Change-Id: Ie4581daaeb1ceb68fc918b9b744758fc3717923f
Bruno da Silva Belo [Mon, 4 Nov 2019 17:40:18 +0000 (14:40 -0300)]
csharp: Changing visibility of nested class/struct
Reviewers: felipealmeida, lauromoura, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8393
Differential Revision: https://phab.enlightenment.org/D10588
Xavi Artigas [Wed, 30 Oct 2019 14:26:08 +0000 (15:26 +0100)]
docs: Polish Efl.Canvas.Animation_Group and sons
Summary: These docs were almost empty.
Reviewers: bu5hm4n, zmike, cedric, Jaehyun_Cho
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10564
Marcel Hollerbach [Mon, 4 Nov 2019 12:44:29 +0000 (13:44 +0100)]
efl_canvas_animation: improve generally
Summary:
to be taken over by doccop
Depends on D10559
Reviewers: Jaehyun_Cho, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10560
Xavi Artigas [Mon, 4 Nov 2019 12:06:41 +0000 (13:06 +0100)]
docs: Polish Efl.Canvas.Animation_*
Summary:
These docs were lacking a lot of detail.
Depends on D10562
Reviewers: bu5hm4n, cedric, zmike, Jaehyun_Cho
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10565
Marcel Hollerbach [Wed, 30 Oct 2019 14:30:20 +0000 (15:30 +0100)]
efl_canvas_animation_translate: move from x&y to container types
Summary:
this now uses Eina.Position2D so its easier to pass arround other
positions.
ref T8288
Depends on D10559
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8288
Differential Revision: https://phab.enlightenment.org/D10562
Marcel Hollerbach [Wed, 30 Oct 2019 14:30:18 +0000 (15:30 +0100)]
efl_canvas_animation_scale: move from 2 doubles to vectors
Summary:
with this the passing of positions is getting more easy. Additionally,
Reading the API call gets easier, as parameters are semantically
grouped.
Depends on D10558
Reviewers: segfaultxavi, Jaehyun_Cho
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8288
Differential Revision: https://phab.enlightenment.org/D10559
Marcel Hollerbach [Wed, 30 Oct 2019 14:30:09 +0000 (15:30 +0100)]
efl_canvas_animation: be more explicit with errors
Summary:
with this commit invalid values are not accepted silently anymore. But
rather a error will be raised.
Depends on D10350
Reviewers: segfaultxavi, Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8288
Differential Revision: https://phab.enlightenment.org/D10558
Marcel Hollerbach [Wed, 30 Oct 2019 14:29:59 +0000 (15:29 +0100)]
efl_canvas_animation_rotate: adjust API
Summary:
in task T8288 we concluded that a few APIs need to be adjusted in order
to stabelize animation classes at some point. This also adds a new macro
to eina in order to create EINA_VECTOR2 values more easily.
ref T8288
Reviewers: Jaehyun_Cho, segfaultxavi, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8288
Differential Revision: https://phab.enlightenment.org/D10350
Yeongjong Lee [Fri, 1 Nov 2019 20:13:57 +0000 (17:13 -0300)]
eo_mono: make Efl.EventDescription, Efl.Event, Efl.EventCb internal
Summary:
Hide struct and delegate related to `IntPtr`.
Depends on D10585
Depends on D10586
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10587
Yeongjong Lee [Fri, 1 Nov 2019 20:03:56 +0000 (17:03 -0300)]
mono: blacklist efl_thread
Summary:
C# developers are already familar with C# Thread`System.Threading.Thread`, We
don't need to provide Wrapped `Efl.Thread` class.
Also, we can't ensure compatibility between C# Thread and EFL Thread.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10586
Yeongjong Lee [Fri, 1 Nov 2019 19:01:49 +0000 (16:01 -0300)]
mono: blacklist functions related to native event
Summary:
`efl_event_callback_forwarder_priority_del`
=> It can be replaced with `obj.XXXEvent -= callback;`.
Furthermore, `efl_event_callback_forwarder_priority_add` is already in blacklist.
`efl_ui_widget_input_event_handler`
=> It can be replaced with `obj.DownEvent`, `obj.UpEvent` and `obj.PointerWhellEvent`.
`efl_access_object_event_handler_add`
`efl_access_object_event_handler_del`
`efl_access_object_event_emit`
=> They are functions to handle global event related to access(E.g. `elm_atspi_bridge`).
It should be generated to `static event` in C#.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10585
Lauro Moura [Fri, 1 Nov 2019 13:04:04 +0000 (10:04 -0300)]
csharp: Refactor MarshalOwn
Summary:
Instead of using the empty interface as tag, split MarshalOwn into two
marshalers that can be used directly.
Fixes T8395 (CA1040)
Test Plan: no new functionality. Use existing tests
Reviewers: felipealmeida, brunobelo, segfaultxavi, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8395
Differential Revision: https://phab.enlightenment.org/D10457
Carsten Haitzler (Rasterman) [Fri, 1 Nov 2019 10:12:30 +0000 (10:12 +0000)]
Revert "elm/genlist: don't process entire item queue on each item add"
First - the big problem. This breaks enlightenment's bluez5 popup. it
does a sortyed inert using the item data and the item data for one of
the itmes to compare in _cb_insert_cmp() in e_mod_popup.c when it
calls elm_object_item_data_get(0 returns a junk ptr for the item data
after this patch. i haven't managed to figure out exactly why in my
last 30 mins of looking.
But a closer look... this disables immediate processing of:
1. the first block of items (32items) which was intended so for
short/small lists you have some content by the time you go to the
first frame, and at least the first block of itso you seem to have
visual contnt and not a blank list until idlers can process further
content. so the patch being reverted would have gotten rid of this
logic that gets you content as opposed to blank:
while ((sd->queue) && ((!sd->blocks) || (!sd->blocks->next)))
2. if it's a homogenous list, all items have the same size so we do
have to realize the first item of each class type but ONLY that one.
further items should not need realizing as we can ASSUME the height to
be the same as the first item... that's the point of homogenous +
compress lists - all items of the same class have the same height and
width thus shortcutting further need to calculate nd realize. if we
are reizing everything in a homogenous list then the issue lies with
something going wrong with this above logic. we shokuld be able to
handle such lists super fastif this logic was working.
that's the 2nd while:
while ((sd->queue) && (sd->blocks) &&
(sd->homogeneous) && (sd->mode == ELM_LIST_COMPRESS))
so overall, this should not have been realizing every item. either
just the first block of 32, OR just the first item of any class and
thus assume all further items are the same size without realizing
being needed. if these broke then the solution is not commenting this
out but finding out why this logic is breaking :)
and not to mention... this commenting out also caused segfaults in
existing applications which are doing the right thing. perhaps the
sorting logic also needed updating as well if this above is commented out...
but i didn't have time to chase it more than this.
---
This reverts commit
0777b74f07857c86408bc0929e3391ced0e098e4.
JunsuChoi [Fri, 1 Nov 2019 03:46:24 +0000 (12:46 +0900)]
ecore_event: Remove unused goto define
Summary:
For remove -Wunused-label warning
Test Plan: N/A
Reviewers: Hermet, kimcinoo, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10584
Yeongjong Lee [Thu, 31 Oct 2019 21:30:23 +0000 (18:30 -0300)]
mono: blacklist elm_general.eot
Summary:
Prevent generating legacy eot.cs
Depends on D10580
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10581
Yeongjong Lee [Thu, 31 Oct 2019 21:25:32 +0000 (18:25 -0300)]
mono: blacklist efl_ui_text_context_menu_item_add
Summary: Blacklist a method which has `IntPtr` parameters.
Reviewers: woohyun, segfaultxavi, YOhoho, felipealmeida
Reviewed By: felipealmeida
Subscribers: segfaultxavi, zmike, q66, bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10579
Yeongjong Lee [Thu, 31 Oct 2019 21:21:42 +0000 (18:21 -0300)]
mono: remove duplicated EinaFreeCb delegate
Summary: Use Eina.Claabacks.EinaFreeCb instead.
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10577
Cedric BAIL [Thu, 31 Oct 2019 19:43:16 +0000 (15:43 -0400)]
efl: fix include due to stale files.
Reviewers: zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10583
Yeongjong Lee [Thu, 31 Oct 2019 17:38:08 +0000 (13:38 -0400)]
efl_ui_text: remove elm_general.eot
Summary: remove legacy dependency in eo file.
Test Plan: ninja
Reviewers: woohyun, Jaehyun_Cho, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10580
Cedric Bail [Thu, 31 Oct 2019 17:20:52 +0000 (13:20 -0400)]
evas: move watching over destruction of device to custom logic due to high use.
Summary:
This specific EFL_EVENT_DEL handler was registered thousand of time alone on
an Evas device. Potential solution are to improve handling of this kind of large
scale callback logic or just not take that path. I find it easier to have a custom
code in this case to handle the destruction of Evas device and avoid this
thousand of callback.
Depends on D10492
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10493
Cedric Bail [Thu, 31 Oct 2019 17:20:45 +0000 (13:20 -0400)]
evas: deprecate evas_device_parent_set.
Summary:
It is unlikely that the code was working before and it was a bad idea
anyway. There is no user of this API in EFL.
Depends on D10490
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10491
Cedric Bail [Thu, 31 Oct 2019 17:20:39 +0000 (13:20 -0400)]
evas: move exposed internal structure of Efl_Input_Device to be private.
Summary: Depends on D10489
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10490
Cedric Bail [Thu, 31 Oct 2019 17:20:33 +0000 (13:20 -0400)]
evas: move efl_input_device into evas/Efl_Canvas.h
Summary:
The internal and the API we would like is mostly a canvas API. A lot of the code
in evas is working around the fact that efl_input_device is not defined inside Evas.
This patch is the first step to try to clean this up.
Depends on D10487
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10488
Mike Blumenkrantz [Wed, 9 Oct 2019 17:20:43 +0000 (13:20 -0400)]
tests/eina: use #ifdef guard for block which can only occur inside ifdef
this value is set in the corresponding #ifdef block above, so use the same
guard here to make code more readable
CID 1400948
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10321
Marcel Hollerbach [Thu, 31 Oct 2019 16:48:27 +0000 (12:48 -0400)]
eo_base_class: move shift init to the first call
Summary:
this cannot be evalulated in compile time, so this must be evalulated in
runtime, at the first call.
This should fix OSX build.
Co-authored-by: Cedric Bail <cedric.bail@free.fr>
Reviewers: zmike, cedric, raster
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10582
Cedric Bail [Fri, 18 Oct 2019 16:24:47 +0000 (09:24 -0700)]
eo: add debug ability to detect long chain of event handler.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10484
Cedric Bail [Thu, 17 Oct 2019 19:09:14 +0000 (12:09 -0700)]
eo: reduce memory use to track event registration and callback call.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10482
Cedric Bail [Wed, 16 Oct 2019 23:47:47 +0000 (16:47 -0700)]
ecore: remove custom code for generating Eina_Future_Schedule attached on Efl.Loop.
This leverage the new infrastructure from Eo that provide a scheduler for any event
attached to any object.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10481
Cedric Bail [Wed, 16 Oct 2019 23:47:10 +0000 (16:47 -0700)]
eo: add infrastructure to attach an Eina_Future_Scheduler to any source of event.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10480
Cedric Bail [Wed, 16 Oct 2019 23:45:50 +0000 (16:45 -0700)]
eina: only the type need to be NULL to assume EINA_VALUE_EMPTY.
This avoid comparison with potentially uninitialized byte.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10479
Cedric Bail [Wed, 16 Oct 2019 19:14:20 +0000 (12:14 -0700)]
ecore: remove unecessary code for Eina_Future scheduler.
As we do not rely on legacy Ecore Event directly anymore, we do not
need to mind the shutting down of EFL.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10477
Cedric Bail [Wed, 16 Oct 2019 17:04:29 +0000 (10:04 -0700)]
ecore: remove unecessary field in data structure.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10476
Cedric Bail [Wed, 16 Oct 2019 00:04:32 +0000 (17:04 -0700)]
eo: prevent unecessary callback call walk.
This patch introduce a small hash (64 or 32bits) that cache all existing
Efl_Event_Description callback handler registered on an object. It slightly
reduce the time needed to do an unecessary call and cost just a few bytes
per object.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10475
Cedric Bail [Thu, 31 Oct 2019 13:17:53 +0000 (09:17 -0400)]
elementary: handle case when XFIXES is not available.
Summary:
ECORE_X_EVENT_FIXES_SELECTION_NOTIFY is only initialized when XFIXES
is available. If ecore_event_handler_add is called with type == 0, it
will trigger an abort and elementary would not initialize properly.
Depends on D10491
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10492
Cedric Bail [Thu, 31 Oct 2019 13:17:46 +0000 (09:17 -0400)]
edje: load edje seat callback only when necessary.
Summary:
This reduce in elementary_test the number of callback registered on the
canvas from hundreds to around 10.
Depends on D10486
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10487
Cedric Bail [Thu, 31 Oct 2019 13:17:40 +0000 (09:17 -0400)]
edje: improve callback count on Evas canvas.
Summary:
This reduce by 3 the amount of callback registered on the canvas. Another
potential improvement would be to only register those callback if someone
is listening for a 'seat,*' event or if the edje file define seat filters.
Depends on D10484
Reviewers: zmike, raster, bu5hm4n, Hermet
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8321
Differential Revision: https://phab.enlightenment.org/D10486
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:56 +0000 (09:02 -0400)]
tests/spec: pre-create a ton of widgets during test init
Summary:
similar to existing mechanics for elm/efl_ui tests, this pre-creates
all the widgets used as test contents for all the test cases so they
can be forked and reused without needing to spend time in every single
test creating the same test contents
Depends on D10573
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10574
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:54 +0000 (09:02 -0400)]
tests/elm: add utils for detecting buffer engine and setting fork init cb
Summary:
this allows use of the global win object prior to actually being inside a
test for the purpose of doing additional setup
Depends on D10572
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10573
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:52 +0000 (09:02 -0400)]
tests/spec: use wrefs to automatically unset global pointers
Summary:
these may end up being reused in the future, so unset them only on
object destruction
Depends on D10571
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10572
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:51 +0000 (09:02 -0400)]
tests/spec: assert success of content_set during setup
Summary: Depends on D10570
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10571
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:49 +0000 (09:02 -0400)]
tests/spec: store test class and reuse globally to avoid needing efl_isa
Summary: Depends on D10569
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10570
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:47 +0000 (09:02 -0400)]
tests/elm: add util function for detecting whether current test is forked
Summary:
this is useful for determining whether we can use extra hacks because nobody's
supervising our pointer (ab)use
Depends on D10568
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10569
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:45 +0000 (09:02 -0400)]
tests/spec: reduce looping of pack content tests
Summary:
this was hugely over-testing before; simply verifying one item outside
the limit is sufficient here
Depends on D10567
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10568
Mike Blumenkrantz [Thu, 31 Oct 2019 13:02:44 +0000 (09:02 -0400)]
tests/spec: merge some loops in linear pack tests
Summary:
these are small loops, but iterating small loops hundreds of times leads to
big slowdowns
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10567
Carsten Haitzler (Rasterman) [Thu, 31 Oct 2019 12:21:59 +0000 (12:21 +0000)]
evas - revert evas variation sequence support - out of bound accesses
This code is filled with out of bounds accesses now after the reverted
patch. All those base_char+1, itr+1 etc. in
evas_common_font_query_run_font_end_get() are accessing BEYOND
the end of the run. textgrid shows this instantly to fall over as it
uses single unicode codepoint chars with no nul terminator. As this
api takes an explicit run_len we should never access beyond the end of
the run_len.
Please revisit this code and keep in mind proper memory/bounds
accessing. If there was ano run_len and it assumed strings were
regular strings that had to be nul terminated... then it might be ok,
but not here.
of course if i put in guards for these +1's then it ends up in
infintie loops, so enough debugging and send it back for a rethink. :)
....
Revert "evas_object_textblock: add support for variation sequences"
This reverts commit
46f2d8acdcda3f374c9e393ecb734ff9d00fef7d.