commit-queue@webkit.org [Sat, 14 Apr 2012 21:05:00 +0000 (21:05 +0000)]
CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
https://bugs.webkit.org/show_bug.cgi?id=80736
Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.
Added support for fetching the value of 'border-radius' CSS property which was missing.
Source/WebCore:
Test: fast/css/border-radius-property-value.html
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
* fast/css/border-radius-property-value-expected.txt: Added.
* fast/css/border-radius-property-value.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 18:29:17 +0000 (18:29 +0000)]
[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
https://bugs.webkit.org/show_bug.cgi?id=81945
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.
Tools:
WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 14 Apr 2012 18:15:47 +0000 (18:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=83826
Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.
Reviewed by Dan Bernstein.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
* rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Sat, 14 Apr 2012 09:34:27 +0000 (09:34 +0000)]
[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=83569
Reviewed by Eric Seidel.
No new tests. Covered by exiting fast/canvas/*toDataURL* tests.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 06:02:08 +0000 (06:02 +0000)]
[Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
https://bugs.webkit.org/show_bug.cgi?id=83804
Patch by David Reveman <reveman@chromium.org> on 2012-04-13
Reviewed by James Robinson.
Source/WebCore:
Cleanup code that determines if we need to use a buffered update and
avoid buffering of tiles that are not in use by the impl thread.
Tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
TiledLayerChromiumTest.partialUpdates
* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::bufferedUpdates):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
Source/WebKit/chromium:
* tests/CCLayerTreeHostTest.cpp:
(WTF::setLayerPropertiesForTesting):
(WTF):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Sat, 14 Apr 2012 03:32:40 +0000 (03:32 +0000)]
[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
https://bugs.webkit.org/show_bug.cgi?id=83899
Reviewed by Adrienne Walker.
When a LTH becomes invisible, the texture eviction is spread out across
two different functions and is not entirely clear. We move all the logic
together into a single place in didBecomeInvisibleOnImplThread() and
make the consequences of the current code more clear.
Covered by existing tests.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Sat, 14 Apr 2012 03:07:21 +0000 (03:07 +0000)]
[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it.
https://bugs.webkit.org/show_bug.cgi?id=83920
Reviewed by James Robinson.
Found by clang:
third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion]
EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f)));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
* tests/LayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 03:06:50 +0000 (03:06 +0000)]
Unreviewed, rolling out r114036.
http://trac.webkit.org/changeset/114036
https://bugs.webkit.org/show_bug.cgi?id=83969
Breaks gmail.com causing it to never finish loading (Requested
by danakj on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebCore:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* dom/NodeList.idl:
LayoutTests:
* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
* fast/dom/NodeList/node-list-array-class.html: Removed.
* fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
* fast/dom/everything-to-string-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/js/recursion-limit-equal-expected.txt:
* inspector/console/command-line-api-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* jquery/traversing-expected.txt:
* platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
* platform/chromium/fast/dom/everything-to-string-expected.txt: Removed.
* platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/jquery/traversing-expected.txt: Removed.
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 03:02:00 +0000 (03:02 +0000)]
[chromium] Add null pointer check to animatePageScale
https://bugs.webkit.org/show_bug.cgi?id=83940
Patch by Alexandre Elias <aelias@google.com> on 2012-04-13
Reviewed by James Robinson.
Add null pointer check to startPageScaleAnimation.
If the root scroll layer goes away in the middle of a page scale
animation, there can be a null pointer access here.
No new tests.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animatePageScale):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Sat, 14 Apr 2012 02:33:09 +0000 (02:33 +0000)]
Two lineboxcontain tests are failing
https://bugs.webkit.org/show_bug.cgi?id=82742
Reviewed by Ojan Vafai.
* platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
* platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
Rebaselined.
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
Unskip some tests that are either rebaselined or now passing due to
r112582 re-adding some of the RenderLayers removed by r110072.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Sat, 14 Apr 2012 01:58:23 +0000 (01:58 +0000)]
[chromium] Replicas should be included in the computed occlusion
https://bugs.webkit.org/show_bug.cgi?id=82262
Reviewed by Adrienne Walker.
Source/WebCore:
When merging a surface's occlusion up to its target, make a copy of it
where the replica will be as well, and make sure that occlusion from a
RenderSurface does not leave its clipRect.
Unit test: CCOcclusionTrackerTestReplicaDoesOcclude
CCOcclusionTrackerTestReplicaWithClipping
CCOcclusionTrackerTestSurfaceChildOfSurface
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::hasReplica):
(WebCore):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
Source/WebKit/chromium:
* tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestReplicaDoesOcclude):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaWithClipping):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:30:36 +0000 (01:30 +0000)]
Add layout test case for JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=83747
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.
* webaudio/javascriptaudionode-expected.txt: Added.
* webaudio/javascriptaudionode.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:29:00 +0000 (01:29 +0000)]
Unreviewed, rolling out r114185.
http://trac.webkit.org/changeset/114185
https://bugs.webkit.org/show_bug.cgi?id=83967
Broke a bunch of JavaScript related tests (Requested by
andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
* runtime/CommonIdentifiers.h:
* tests/mozilla/ecma/Array/15.4.4.2.js:
(getTestCases):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:27:13 +0000 (01:27 +0000)]
convolution-mono-mono test passes now
https://bugs.webkit.org/show_bug.cgi?id=83793
Patch by Raymond Toy <rtoy@google.com> on 2012-04-13
Reviewed by Eric Seidel.
* platform/chromium/test_expectations.txt: Delete entry.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:25:30 +0000 (01:25 +0000)]
AudioContext createChannelMerger() method should have optional argument for number of inputs.
https://bugs.webkit.org/show_bug.cgi?id=83759
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.
Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.
Source/WebCore:
Test: webaudio/audiochannelmerger-basic.html
* Modules/webaudio/AudioChannelMerger.cpp:
(WebCore):
(WebCore::AudioChannelMerger::create):
(WebCore::AudioChannelMerger::AudioChannelMerger):
* Modules/webaudio/AudioChannelMerger.h:
(AudioChannelMerger):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelMerger):
(WebCore):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioContext.idl:
LayoutTests:
* webaudio/audiochannelmerger-basic-expected.txt: Added.
* webaudio/audiochannelmerger-basic.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 14 Apr 2012 01:20:33 +0000 (01:20 +0000)]
Don't rely on fixed offsets to patch calls
https://bugs.webkit.org/show_bug.cgi?id=83966
Rubber stamped by Oliver Hunt.
These aren't being used anywhere!
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Sat, 14 Apr 2012 00:42:00 +0000 (00:42 +0000)]
[chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316
Reviewed by Adrienne Walker.
We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.
We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.
Covered by existing tests.
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 00:38:25 +0000 (00:38 +0000)]
Optimize tracking of intruding floats being removed from RenderBlock during layout
https://bugs.webkit.org/show_bug.cgi?id=82928
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-13
Reviewed by David Hyatt.
Performance tweaks in RenderBlock layout as a follow up to r112935.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Sat, 14 Apr 2012 00:36:10 +0000 (00:36 +0000)]
[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134
Reviewed by David Hyatt.
Source/WebCore:
The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.
The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).
Test: fast/regions/webkit-named-flow-content-nodes.html
* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::detach):
* dom/Node.h:
(WebCore::Node::inNamedFlow):
(WebCore::Node::setInNamedFlow):
(WebCore::Node::clearInNamedFlow):
(Node):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
* rendering/FlowThreadController.h:
(FlowThreadController):
* rendering/RenderNamedFlowThread.cpp:
(WebCore):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
* rendering/RenderNamedFlowThread.h:
(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::hasContentNode):
LayoutTests:
* fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
* fast/regions/webkit-named-flow-content-nodes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 14 Apr 2012 00:34:19 +0000 (00:34 +0000)]
Remove the calls to CRASH() from ResourceLoader.cpp.
https://bugs.webkit.org/show_bug.cgi?id=83962
Reviewed by Alexey Proskuryakov.
They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Sat, 14 Apr 2012 00:33:09 +0000 (00:33 +0000)]
REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
when using certain fonts
https://bugs.webkit.org/show_bug.cgi?id=83523
Reviewed by Kent Tamura.
Revert r102190.
Convert characters being treatAsSpace to white space.
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::fillRuns):
(WebCore::UniscribeHelper::adjustSpaceAdvances):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 00:27:34 +0000 (00:27 +0000)]
[chromium] Remove fallback code for "Missing plug-in" string.
https://bugs.webkit.org/show_bug.cgi?id=81907
Patch by Bernhard Bauer <bauerb@google.com> on 2012-04-13
Reviewed by Adam Barth.
* src/LocalizedStrings.cpp:
(WebCore::missingPluginText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 00:26:25 +0000 (00:26 +0000)]
Array.prototype.toString and Array.prototype.toLocaleString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588
Patch by Hojong Han <hojong.han@samsung.com> on 2012-04-13
Reviewed by Gavin Barraclough.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
* runtime/CommonIdentifiers.h:
* tests/mozilla/ecma/Array/15.4.4.2.js:
(getTestCases.array.item.new.TestCase):
(getTestCases):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 14 Apr 2012 00:11:16 +0000 (00:11 +0000)]
Change how the Web Insector is installed on Mac builds.
<rdar://problem/
10857918>
Reviewed by Mark Rowe.
* WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources
and Streamline Inspector Source build phases.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 13 Apr 2012 23:44:25 +0000 (23:44 +0000)]
Don't rely on fixed offsets to patch method checks
https://bugs.webkit.org/show_bug.cgi?id=83958
Reviewed by Oliver Hunt.
* bytecode/StructureStubInfo.h:
- Add fields for the method check info.
* jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- Store the offsets on the stub info, instead of asserting.
* jit/JIT.h:
- Delete all the method check related offsets.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- Use the offset from the stubInfo.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Pass the stubInfo to patchMethodCallProto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Apr 2012 23:44:05 +0000 (23:44 +0000)]
Rebaseline some compositing tests. Some were affected by the colorspace of
the sample image changing.
* compositing/images/direct-pdf-image-expected.png:
* compositing/repaint/newly-composited-repaint-rect-expected.png:
* compositing/visibility/visibility-image-layers-expected.png:
* compositing/visibility/visibility-simple-video-layer-expected.png:
* platform/mac/compositing/reflections/reflection-in-composited-expected.png:
* platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 23:43:01 +0000 (23:43 +0000)]
fast/dom/Window/window-property-descriptors.html is too much work to maintain
https://bugs.webkit.org/show_bug.cgi?id=83915
Reviewed by Alexey Proskuryakov.
The goal of this test is to remind us whenever we add something to the
global scope. In practice, however, this test is a lot of work to
maintain because every port has different features enabled, which means
every port has a different list of things in the global scope. It's
very difficult to make changes without causing this test to go red on a
number of bots.
Rather than use this test to monitor the global scope, we're better off
paying attention to the IDL files. If folks are interested in changes
to what is exposed to JavaScript, they can subscribe to IDL changes
using a watchlist. (That's what I do, and it works pretty well.)
* fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
* fast/dom/Window/window-property-descriptors.html: Removed.
* platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 13 Apr 2012 23:31:00 +0000 (23:31 +0000)]
Video at apple.com gets standard controls in addition to custom controls after returning from full screen
https://bugs.webkit.org/show_bug.cgi?id=83939
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; DRT and WKTR don't have the infrastructure to test full-screen animation related bugs.
Instead of asking the media element whether it is in full screen or not, rely on when the media root element
was told that it enteredFullscreen() or exitedFullscreen(), which may occur at a different time than the
media element due to animations.
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::playbackStarted):
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):
(WebCore::MediaControlRootElement::defaultEventHandler):
(WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
(WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):
* html/shadow/MediaControlRootElement.h:
(MediaControlRootElement): Added m_isFullscreen;
Source/WebKit2:
So that the media controls don't show up momentarily during full screen animations, call setAnimatingFullScreen(true)
before calling will{Enter,Exit}FullScreen(), so that the CSS rule for full screen animation will be in effect
immediately.
Similarly, call setAnimatingFullScreen(false) after calling did{Enter,Exit}FullScreen, so that the full screen media
controls don't momentarily appear at the end of an animation.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 13 Apr 2012 23:27:38 +0000 (23:27 +0000)]
fullscreen/video-controls-drag.html failing on Mac
https://bugs.webkit.org/show_bug.cgi?id=81176
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Fixes fullscreen/video-controls-drag.html.
Regressed in r110409. When the -webkit-media-controls-panel were changed
from position:absolute to position:relative, this broke dragging of the
controls in fullscreen, which relies on the panel being absolutely positioned
to do its drag positioning. Change the way drag positioning is calculated to
accommodate position:relative.
* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel): Instead of bottom:50px,
use margin-bottom:50px to push panel up from the bottom of the screen.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag): Do not ask for the current renderer location.
(WebCore::MediaControlPanelElement::continueDrag): Use the delta between the event locations
only to calculate the new panel position.
* html/shadow/MediaControlElements.h:
LayoutTests:
Removed expected failing results from platform/mac.
* platform/mac/fullscreen/video-controls-drag-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Apr 2012 23:25:34 +0000 (23:25 +0000)]
Fix two compositing animation tests to not have flakey pixel results
https://bugs.webkit.org/show_bug.cgi?id=83957
Reviewed by Dean Jackson.
Fix these tests to use the pause animation API by providing an animation
name in the expected data. There's no need to start the animations by hand.
* compositing/reflections/animation-inside-reflection.html:
* compositing/reflections/nested-reflection-animated.html:
* platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 13 Apr 2012 23:16:39 +0000 (23:16 +0000)]
Rebaseline this since svg/custom/resources/green-checker.png changed.
* svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Apr 2012 22:51:35 +0000 (22:51 +0000)]
Avoid use of ::webkit-scrollbar to hide scrollbars, since it doesn't work in WK1
https://bugs.webkit.org/show_bug.cgi?id=83950
Reviewed by James Robinson.
Remove use of ::webkit-scrollbar from compositing tests, since this doesn't
affect WebKit1 scrollbars.
* compositing/geometry/fixed-position-composited-page-scale-down.html:
* compositing/geometry/fixed-position-composited-page-scale.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
* compositing/geometry/fixed-position-iframe-composited-page-scale.html:
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
* compositing/geometry/fixed-position-transform-composited-page-scale.html:
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Apr 2012 22:26:47 +0000 (22:26 +0000)]
Compositing layers not updated after scroll in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=83945
Source/WebCore:
Reviewed by James Robinson.
Fix the WebKit1 code path to correctly update compositing layers
after a scroll, by calling updateFixedElementsAfterScrolling() from
scrollPositionChangedViaPlatformWidget().
Covered by existing tests.
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
LayoutTests:
Reviewed by James Robinson.
Replace an incorrect Mac baseline with the correct result which was
already in place for WebKit2.
Remove a passing test from test-expectations.
* compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
* platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
* platform/mac/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 13 Apr 2012 22:09:06 +0000 (22:09 +0000)]
Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 13 Apr 2012 22:05:16 +0000 (22:05 +0000)]
Fix skipped list.
* Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 13 Apr 2012 22:02:02 +0000 (22:02 +0000)]
Don't process filters if the input region is exceptionally large.
https://bugs.webkit.org/show_bug.cgi?id=83317
Reviewed by Simon Fraser.
Source/WebCore:
An extremely large element causes problems with filters, either by
taking too long to compute the output or using too much memory. The
filter engine already has some constants for maximum expected size.
Make sure the render tree checks them before deciding to apply
effects.
Tests: css3/filters/huge-region-composited.html
css3/filters/huge-region.html
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
* rendering/FilterEffectRenderer.cpp:
(WebCore):
(WebCore::isFilterSizeValid):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::updateBackingStore):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
* rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
LayoutTests:
* css3/filters/huge-region-composited-expected.txt: Added.
* css3/filters/huge-region-composited.html: Added.
* css3/filters/huge-region-expected.txt: Added.
* css3/filters/huge-region.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Fri, 13 Apr 2012 21:45:59 +0000 (21:45 +0000)]
Queue the cuechange event on HTMLTrackElement for proper sorting.
https://bugs.webkit.org/show_bug.cgi?id=83858
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. Updates to media/track/track-cues-cuechange.html and
media/track/track-mode.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
Add HTMLTrackElement's cuechange event to the event queue rather than
firing it synchronously.
* html/track/LoadableTextTrack.cpp:
Remove fireCueChangeEvent() as it is no longer used.
* html/track/LoadableTextTrack.h:
Ditto.
* html/track/TextTrack.h:
(TextTrack):
Ditto.
LayoutTests:
* media/track/captions-webvtt/captions-fast.vtt:
Captions were a wee bit too fast: they need to be at least 250ms apart
for accurate testing as timeupdate events are only fired every 250ms.
* media/track/track-cues-cuechange-expected.txt:
Changes the order that cuechange events are fired.
* media/track/track-cues-cuechange.html:
Ditto.
* media/track/track-mode-expected.txt:
cuechange events are now fired at the proper times.
Test now checks for all cuechange events (both enter and exit of cues).
* media/track/track-mode.html:
Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Fri, 13 Apr 2012 21:32:53 +0000 (21:32 +0000)]
Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map
https://bugs.webkit.org/show_bug.cgi?id=79611
Reviewed by James Robinson.
Patch by Antonio Gomes <agomes@rim.com>
Source/WebCore:
As of today, any FrameView attached to the Widget-tree or any
RenderLayer whose corresponding RenderBox's style has a 'overflow'
property set to 'auto' is cached in its containing scrollable areas set.
We could be more restrictive about what we in fact want to
cache as scrollable areas, by checking if the element as an overflow
(i.e. more content than its viewport).
* page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
Whenever the viewport changes, check if we have an scrollable/overflowed
content, and update the cache accordingly.
(WebCore::FrameView::setContentsSize):
Whenever the contents size changes, check if we have a scrollable/overflowed
content, and update the cache accordingly.
(WebCore::FrameView::calculateScrollbarModesForLayout):
Introduces a way to query for the scrollbars by only
taking into account the "rules" set by the web author.
For that, a new enum was added called SrollbarModesCalculationStrategy,
which allows callers to discard for example client-side scrollbar policies
in order to verify if a given frameview is scrollable or not.
(WebCore::FrameView::updateScrollableAreaSet):
Take into account various factors before considering a FrameView as
scrollable. If in the end it is, it gets added to its parent FrameView
scrollable areas map, otherwise removed.
(WebCore):
(WebCore::FrameView::addScrollableArea):
Became unneeded, thus removed.
(WebCore::FrameView::removeScrollableArea):
Whenever a FrameView is removed from the Widget-tree,
remove it from the cache.
* page/FrameView.h:
(FrameView):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Update scrollable area set after layout.
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Update scrollable area set after style changes.
(WebCore::RenderLayer::styleChanged):
Removed the scrollable areas logic detection from it.
(WebCore::RenderLayer::updateScrollableAreaSet):
Updates the containing FrameView scrollable areas cache
only when needed (i.e. an overflow exists).
(WebCore):
* rendering/RenderLayer.h:
(RenderLayer):
* testing/Internals.cpp:
(WebCore::Internals::numberOfScrollableAreas):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Tests: fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-overflow-hidden.html
fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html
fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-scrolling-no.html
fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html
fast/scrolling/scrollable-area-frame-scrolling-yes.html
fast/scrolling/scrollable-area-frame-visibility-hidden-child.html
fast/scrolling/scrollable-area-frame-zero-size-and-border.html
fast/scrolling/scrollable-area-frame.html
fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-display-none.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html
fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html
fast/scrolling/scrollable-area-overflow-auto-visibility-override.html
fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html
fast/scrolling/scrollable-area-overflow-auto.html
fast/scrolling/scrollable-area-overflow-not-set.html
fast/scrolling/scrollable-area-overflow-visible.html
LayoutTests:
Reviewed by NOBODY (OOPS!).
Added scrollable area set count tests to many situations observed
in real world sites.
* fast/scrolling/resources/generic-scrollable-content.html: Added.
* fast/scrolling/resources/hidden-generic-scrollable-content.html: Added.
* fast/scrolling/resources/scrollable-area.js: Added.
(runTest):
(end):
* fast/scrolling/resources/scrollable-style.css: Added.
(.inner):
(.offscreen):
* fast/scrolling/scrollable-area-frame-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-inherited-visibility-hidden-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html: Added.
* fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-overflow-hidden.html: Added.
* fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html: Added.
* fast/scrolling/scrollable-area-frame-scrolling-no-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html: Added.
* fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html: Added.
* fast/scrolling/scrollable-area-frame-scrolling-no.html: Added.
* fast/scrolling/scrollable-area-frame-scrolling-yes-display-none-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html: Added.
* fast/scrolling/scrollable-area-frame-scrolling-yes-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-scrolling-yes.html: Added.
* fast/scrolling/scrollable-area-frame-visibility-hidden-child-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-visibility-hidden-child.html: Added.
* fast/scrolling/scrollable-area-frame-zero-size-and-border-expected.txt: Added.
* fast/scrolling/scrollable-area-frame-zero-size-and-border.html: Added.
* fast/scrolling/scrollable-area-frame.html: Added.
* fast/scrolling/scrollable-area-overflow-auto-display-none-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html: Added.
* fast/scrolling/scrollable-area-overflow-auto-display-none.html: Added.
* fast/scrolling/scrollable-area-overflow-auto-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-override-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-override.html: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-visible-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html: Added.
* fast/scrolling/scrollable-area-overflow-auto.html: Added.
* fast/scrolling/scrollable-area-overflow-not-set-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-not-set.html: Added.
* fast/scrolling/scrollable-area-overflow-visible-expected.txt: Added.
* fast/scrolling/scrollable-area-overflow-visible.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 13 Apr 2012 21:29:54 +0000 (21:29 +0000)]
Make sure that we're using the right compiler for generating derived sources.
Rubber-stamped by Dan Bernstein.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 13 Apr 2012 21:23:13 +0000 (21:23 +0000)]
Track rem unit usage in StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=83923
Reviewed by Andreas Kling.
Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to
the stylesheet instead so parser does not need to know about the document. This also
avoids setting the flag unnecessarily when the stylesheet is not used.
* css/CSSGrammar.y:
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
* css/CSSStyleSheet.h:
(WebCore::StyleSheetInternal::parserSetUsesRemUnits):
(WebCore::StyleSheetInternal::usesRemUnits):
(StyleSheetInternal):
* dom/Document.cpp:
(WebCore):
(WebCore::checkUsesRemUnits):
(WebCore::Document::updateActiveStylesheets):
* dom/Document.h:
(WebCore::Document::usesRemUnits):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 13 Apr 2012 21:19:12 +0000 (21:19 +0000)]
Chromium test_expectations TIMOUT mask for fast/canvas/2d.imageDataHD.html
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 13 Apr 2012 21:01:06 +0000 (21:01 +0000)]
[chromium] Remove unused compositeToTexture / compositeOffscreen setting
https://bugs.webkit.org/show_bug.cgi?id=83733
Reviewed by Adrienne Walker.
Source/Platform:
Remove compositeOffscreen setting. This was an experiment that is no longer needed.
* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore:
Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::setScissorToRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
Source/WebKit/chromium:
Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
* public/WebSettings.h:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Tools:
Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Apr 2012 20:57:10 +0000 (20:57 +0000)]
REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached
https://bugs.webkit.org/show_bug.cgi?id=83925
<rdar://problem/
11231790>
Reviewed by Antti Koivisto.
Added subtests to http/tests/cache/subresource-expiration-2.html.
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::parseCacheControlDirectives): Honor first max-age
instead of the last. New behavior matches both Firefox and IE.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 13 Apr 2012 20:43:24 +0000 (20:43 +0000)]
[chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API
https://bugs.webkit.org/show_bug.cgi?id=83851
Reviewed by Adam Barth.
Source/Platform:
Move WebVideoFrame API into Platform.
* Platform.gypi:
* chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.
(WebKit):
(WebVideoFrame):
(WebKit::WebVideoFrame::~WebVideoFrame):
(WebKit::WebVideoFrame::format):
(WebKit::WebVideoFrame::width):
(WebKit::WebVideoFrame::height):
(WebKit::WebVideoFrame::planes):
(WebKit::WebVideoFrame::stride):
(WebKit::WebVideoFrame::data):
(WebKit::WebVideoFrame::textureId):
(WebKit::WebVideoFrame::textureTarget):
* chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.
(WebKit):
Source/WebCore:
Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).
Covered by existing media/ and compositing/ layout tests.
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::copyFrameToTextures):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/VideoFrameProvider.h:
(VideoFrameProvider):
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h:
(WebKit):
(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::frame):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore):
(WebCore::convertVFCFormatToGC3DFormat):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::videoFrameDimension):
(WebCore::hasPaddingBytes):
(WebCore::CCVideoLayerImpl::computeVisibleSize):
(WebCore::CCVideoLayerImpl::reserveTextures):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(WebKit):
Source/WebKit/chromium:
Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
implementation.
* WebKit.gyp:
* public/WebVideoFrame.h:
* src/AssertMatchingEnums.cpp:
* src/VideoFrameChromiumImpl.cpp: Removed.
* src/VideoFrameChromiumImpl.h: Removed.
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 13 Apr 2012 19:43:58 +0000 (19:43 +0000)]
Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859
Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/css/image-set-parsing.html
* WebCore.gypi:
Source/WebKit/chromium:
* features.gypi:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Fri, 13 Apr 2012 19:39:33 +0000 (19:39 +0000)]
Integrate IETC CSS : grid layout tests
https://bugs.webkit.org/show_bug.cgi?id=83830
Patch by Dave Tharp < dtharp@codeaurora.org> on 2012-04-13
Reviewed by Adam Barth
* ietestcenter/css3/grid/display-grid-001.htm: Added.
* ietestcenter/css3/grid/display-grid-002.htm: Added.
* ietestcenter/css3/grid/grid-column-001.htm: Added.
* ietestcenter/css3/grid/grid-column-002.htm: Added.
* ietestcenter/css3/grid/grid-column-003.htm: Added.
* ietestcenter/css3/grid/grid-columns-001.htm: Added.
* ietestcenter/css3/grid/grid-items-001.htm: Added.
* ietestcenter/css3/grid/grid-items-002.htm: Added.
* ietestcenter/css3/grid/grid-items-003.htm: Added.
* ietestcenter/css3/grid/grid-items-004.htm: Added.
* ietestcenter/css3/grid/grid-items-005.htm: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
michaeln@google.com [Fri, 13 Apr 2012 19:33:55 +0000 (19:33 +0000)]
[chromium] Now that the chromium port is using a different dom_storage backend
library in its main browser process, there are a handful of files that should no
longer be included in the build, and a few files than should be deleted
outright, and the webkit api should be modified to reflect the new (and smaller)
contract between the embedder and webkit/webcore.
https://bugs.webkit.org/show_bug.cgi?id=83807
Reviewed by Adam Barth.
Source/WebCore:
No new tests, existing tests apply.
* WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
* storage/StorageEventDispatcher.h: Delete a stale comment.
Source/WebKit/chromium:
* WebKit.gyp: Delete a few files.
* public/WebStorageNamespace.h: Remove some unused data members and methods, and annotate close() as deprecated.
* public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
* src/StorageAreaProxy.cpp: Remove the include of a deleted file.
* src/StorageEventDispatcherChromium.cpp: Removed.
* src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
* src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
* src/StorageNamespaceProxy.h: Moved some blank lines around.
* src/WebStorageAreaImpl.cpp: Removed.
* src/WebStorageAreaImpl.h: Removed.
* src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
* src/WebStorageNamespaceImpl.cpp: Removed.
* src/WebStorageNamespaceImpl.h: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Fri, 13 Apr 2012 19:32:52 +0000 (19:32 +0000)]
Unreviewed, rebaselining after r114150.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 13 Apr 2012 19:26:16 +0000 (19:26 +0000)]
webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
and also rebaseline the test results since we ignore the first run now.
* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPageLoadingPerfTest.test_run):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 13 Apr 2012 19:24:14 +0000 (19:24 +0000)]
Don't rely on fixed offsets to patch get_by_id/put_by_id
https://bugs.webkit.org/show_bug.cgi?id=83924
Reviewed by Oliver Hunt.
Store offsets in the structure stub info, as we do for the DFG JIT.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::differenceBetween):
- this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)
* bytecode/StructureStubInfo.h:
- added new fields for baseline JIT offsets.
* jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- moved out from JIT::privateCompile.
(JSC::JIT::privateCompile):
- moved out code to PropertyStubCompilationInfo::copyToStubInfo.
* jit/JIT.h:
(PropertyStubCompilationInfo):
- added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
- removed many offsets.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
- changed code generation to use new interface to store info on PropertyStubCompilationInfo.
- changed repatch functions to read offsets from the structure stub info.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_method_check):
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::patchGetByIdSelf):
(JSC::JIT::patchPutByIdReplace):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
- changed code generation to use new interface to store info on PropertyStubCompilationInfo.
- changed repatch functions to read offsets from the structure stub info.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 13 Apr 2012 19:19:00 +0000 (19:19 +0000)]
More rebaselining.
* platform/mac/fast/dom/Window/window-properties-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Fri, 13 Apr 2012 19:02:53 +0000 (19:02 +0000)]
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Antonio Gomes.
Fix signed/unsigned comparison warning.
* parser/Lexer.cpp:
(JSC::::record16):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 13 Apr 2012 18:49:39 +0000 (18:49 +0000)]
Include the error if we fail to initialize the web process sandbox
https://bugs.webkit.org/show_bug.cgi?id=83927
Reviewed by Alexey Proskuryakov.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 13 Apr 2012 18:26:46 +0000 (18:26 +0000)]
Unreviewed, rolling out r114140.
http://trac.webkit.org/changeset/114140
https://bugs.webkit.org/show_bug.cgi?id=83921
Fails fast/css/image-set-parsing.html test it attempts to
introduce. (Requested by scheib on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebCore:
* WebCore.gypi:
Source/WebKit/chromium:
* features.gypi:
LayoutTests:
* platform/chromium/fast/css/image-set-parsing-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 13 Apr 2012 18:20:25 +0000 (18:20 +0000)]
<rdar://problem/
10912680> Pixel access canvas APIs do not operate at backing store resolution
https://bugs.webkit.org/show_bug.cgi?id=83836
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/canvas/2d.imageDataHD.html
Added getImageDataHD and putImageDataHD functions to CanvasRenderingContext2D, as proposed in
<http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The functions
are prefixed with “webkit” for now.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData): Added this cover function that calls
through to getImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Added. Calls through to
getImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::getImageData): Added a CoordinateSystem parameter to this
now-private function. It is passed through to ImageBuffer::getUnmultipliedImageData().
(WebCore::CanvasRenderingContext2D::putImageData): Added this cover function that calls
through to putImageData with LogicalCoordinateSystem.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Added. Calls through to
putImageData with BackingStoreCoordinateSystem.
(WebCore::CanvasRenderingContext2D::putImageData): Added a CoordinateSystem parameter to this
function. It is passed through to ImageBuffer::putByteArray, and used to compute the rect to
invalidate after the drawing operation.
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl: Added webkitPutImageDataHD() and
webkitGetImageDataHD().
* platform/graphics/ImageBuffer.h: Added a CoordinateSystem enum with the values
LogicalCoordinateSystem and BackingStoreCoordinateSystem. Added a CoordinateSystem parameter,
which defaults to LogicalCoordinateSystem, to getUnmultipliedImageData,
getPremultipliedImageData, and putByteArray.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData): Now uses the CoordinateSystem parameter to
decide whether to ask ImageBufferDaya::getData() to apply the resolution scale or not.
(WebCore::ImageBuffer::getPremultipliedImageData): Ditto.
(WebCore::ImageBuffer::putByteArray): Now uses the CoordinateSystem parameter to decide
whether to maintain the resolution scale while drawing or not.
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
LayoutTests:
* fast/canvas/2d.imageDataHD-expected.txt: Added.
* fast/canvas/2d.imageDataHD.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 13 Apr 2012 18:16:26 +0000 (18:16 +0000)]
Enable SVG page loading performance tests
https://bugs.webkit.org/show_bug.cgi?id=83861
Reviewed by Adam Barth.
PerformanceTests:
Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
and the ones that take too long to load (more than 20s).
* Skipped:
Tools:
Add support for page loading tests. These are tests without any test running harnesses, and we use
DriverOutput's test_timeout to measure the loading time.
Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.run):
(PerfTest):
(PerfTest.run_failed):
(PerfTest.parse_output):
(PerfTest.output_statistics):
(ChromiumStylePerfTest.parse_output):
(PageLoadingPerfTest): Added.
(PageLoadingPerfTest.__init__):
(PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
* Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
(MockPrinter):
(MockPrinter.__init__):
(MockPrinter.write):
(MainTest):
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest):
(TestPageLoadingPerfTest.assertWritten):
(TestPageLoadingPerfTest.MockDriver):
(TestPageLoadingPerfTest.MockDriver.__init__):
(TestPageLoadingPerfTest.MockDriver.run_test):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_page_load_svg):
(test_collect_tests_with_page_load_svg.add_file):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 13 Apr 2012 18:15:43 +0000 (18:15 +0000)]
Rebaseline a test.
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Fri, 13 Apr 2012 18:06:50 +0000 (18:06 +0000)]
[chromium] Support CCHeadsUpDisplay in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=67499
Reviewed by James Robinson.
No new tests because this code is debugging code itself.
The last item that was needed to make the CCHeadsUpDisplay work in
threaded compositing mode was to remove the font rendering code
used on the impl-side thread. To solve this, this patch adds a
CCFontAtlas that is initialized on the main thread (where the font
rendering takes place). Then, when the HUD draws text on the impl
thread, it uses the font atlas directly.
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCFontAtlas.cpp: Added.
(WebCore):
(WebCore::CCFontAtlas::CCFontAtlas):
(WebCore::wrapPositionIfNeeded):
(WebCore::CCFontAtlas::generateAtlasForFont):
(WebCore::CCFontAtlas::initialize):
(WebCore::CCFontAtlas::drawText):
(WebCore::CCFontAtlas::drawOneLineOfTextInternal):
(WebCore::CCFontAtlas::drawDebugAtlas):
* platform/graphics/chromium/cc/CCFontAtlas.h: Added.
(WebCore):
(CCFontAtlas):
(WebCore::CCFontAtlas::create):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
(WebCore::CCHeadsUpDisplay::drawPlatformLayerTree):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
(WebCore::CCLayerTreeHost::headsUpDisplayFontAtlas):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Fri, 13 Apr 2012 18:06:15 +0000 (18:06 +0000)]
Unreviewed - remove duplicate entries for two failing sputnik tests
from the test_expectations.txt file.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Fri, 13 Apr 2012 17:47:00 +0000 (17:47 +0000)]
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303
Unreviewed Chromium test_expectations clean up.
Previous clean up in r114137 dropped a WIN IMAGE failure suppression.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 13 Apr 2012 17:46:05 +0000 (17:46 +0000)]
<rdar://problem/
11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache
Source/WebKit2:
- Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified
of back/forward navigations (and deny them if it chooses)
- Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.
Reviewed by Darin Adler.
Add the new WKBundleBackForwardListItem API:
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
(WKBundleBackForwardListItemIsInPageCache):
* WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
* WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
(WebKit::InjectedBundleBackForwardListItem::isInPageCache):
Update the UI page loader client to allow for a user data object to be passed from the bundle:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
(WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willGoToBackForwardListItem):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Add the new callback to the bundle loader client:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
Call the bundle client before doing anything else, possibly canceling the navigation:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.
Tools:
Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
Reviewed by Darin Adler.
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::willGoToBackForwardListItem):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
(ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::shouldGoToBackForwardListItemCallback):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
(TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 17:40:42 +0000 (17:40 +0000)]
Update baselines to make this test run again.
* platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Replaced.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 17:20:24 +0000 (17:20 +0000)]
Chromium: Should enable -webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=81859
Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/css/image-set-parsing.html
* WebCore.gypi:
Source/WebKit/chromium:
* features.gypi:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 16:16:10 +0000 (16:16 +0000)]
Mark test as even flakier: it can timeout.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 16:05:03 +0000 (16:05 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Flag fast/regions
again. Only parts of it were passing, sigh.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Fri, 13 Apr 2012 15:49:11 +0000 (15:49 +0000)]
[Chromium] LayoutTest failures/flaky for svg/as-background-image
https://bugs.webkit.org/show_bug.cgi?id=83303
Unreviewed Chromium test_expectations clean up.
Consolidating common-cause flaky tests.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Apr 2012 15:41:38 +0000 (15:41 +0000)]
Web Inspector: do not attempt to load content from resource until request finished loading.
https://bugs.webkit.org/show_bug.cgi?id=83896
Reviewed by Yury Semikhatsky.
Source/WebCore:
When we stop in the inline script on reload, we should only show concatenated script content.
When we resume, we should replace UI source code with the actual HTML content. We should not attempt to
fetch resource content until request finished loading. I regressed it in the Request extraction
and now am bringing it back.
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
LayoutTests:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 15:40:20 +0000 (15:40 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Unskip fast/regions and
svg/hixie/perf that seem to pass fine on GTK bots.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Apr 2012 14:33:22 +0000 (14:33 +0000)]
Web Inspector: follow up to r114116 - fixing QT test
https://bugs.webkit.org/show_bug.cgi?id=83892
Reviewed by Yury Semikhatsky.
Source/WebCore:
Requesting content for the scripts exclusively via the page agent now.
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.requestContent):
LayoutTests:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 14:30:16 +0000 (14:30 +0000)]
Group EFL bots into a category on the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=82712
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-13
Reviewed by Adam Roben.
Creating a new category definition on the buildbot frontend.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig): Determine category for EFL bots
* BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yi.4.shen@nokia.com [Fri, 13 Apr 2012 14:28:45 +0000 (14:28 +0000)]
InsertHTML fails to insert h6 if the insertion point is before some text.
https://bugs.webkit.org/show_bug.cgi?id=82689
Reviewed by Ryosuke Niwa.
Added the missing h6 tag for the isHeaderElement.
Source/WebCore:
No new tests: updated existing test (editing/execCommand/4128080-1.html)
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isHeaderElement):
LayoutTests:
* editing/execCommand/4128080-1-expected.txt:
* editing/execCommand/4128080-1.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 13 Apr 2012 14:25:42 +0000 (14:25 +0000)]
2012-04-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Build fix after r114126.
* WebKit.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 14:23:08 +0000 (14:23 +0000)]
[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
https://bugs.webkit.org/show_bug.cgi?id=82483
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-04-13
Reviewed by Noam Rosenthal.
This fixes API tests broken by r113715.
* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 14:18:54 +0000 (14:18 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Marking some css2.1 tests flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 14:16:55 +0000 (14:16 +0000)]
Mark test as flaky.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 13 Apr 2012 13:50:43 +0000 (13:50 +0000)]
Web Inspector: exception in heap profiler when expanding a class in summary view
https://bugs.webkit.org/show_bug.cgi?id=83883
Moved all DOM-specific inspector utilities into DOMExtension.js
Merged BinarySearch.js and PartialQuickSort.js into utilities.js, HeapSnapshotWorker.js now
imports utilities.js which contains all required routines.
Reviewed by Pavel Feldman.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/BinarySearch.js: Removed.
* inspector/front-end/DOMExtension.js: Copied from Source/WebCore/inspector/front-end/utilities.js.
(Node.prototype.rangeOfWord):
(Node.prototype.traverseNextTextNode):
(Node.prototype.rangeBoundaryForOffset):
(Element.prototype.removeStyleClass):
(Element.prototype.removeMatchingStyleClasses):
(Element.prototype.addStyleClass):
(Element.prototype.hasStyleClass):
(Element.prototype.positionAt):
(Element.prototype.pruneEmptyTextNodes):
(Element.prototype.isScrolledToBottom):
(Node.prototype.enclosingNodeOrSelfWithNodeNameInArray):
(Node.prototype.enclosingNodeOrSelfWithNodeName):
(Node.prototype.enclosingNodeOrSelfWithClass):
(Node.prototype.enclosingNodeWithClass):
(Element.prototype.query):
(Element.prototype.removeChildren):
(Element.prototype.isInsertionCaretInside):
(Element.prototype.createChild):
(Element.prototype.totalOffsetLeft):
(Element.prototype.totalOffsetTop):
(Element.prototype.totalOffset):
(Element.prototype.scrollOffset):
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):
(Element.prototype.boxInWindow):
(Element.prototype.setTextAndTitle):
(Event.prototype.consume):
(Text.prototype.select):
(Element.prototype.selectionLeftOffset):
(Node.prototype.isAncestor):
(Node.prototype.isDescendant):
(Node.prototype.isSelfOrAncestor):
(Node.prototype.isSelfOrDescendant):
(Node.prototype.traverseNextNode):
(Node.prototype.traversePreviousNode):
(HTMLTextAreaElement.prototype.moveCursorToEnd):
(isEnterKey):
(consumeEvent):
(highlightSearchResult):
(highlightSearchResults):
(highlightRangesWithStyleClass):
(applyDomChanges):
(revertDomChanges):
* inspector/front-end/HeapSnapshot.js: Fixed a couple of js compiler warnings
by describing structure of heap snapshot header in the protocol.
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
* inspector/front-end/HeapSnapshotWorker.js:
* inspector/front-end/PartialQuickSort.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/utilities.js:
(.):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 13:45:15 +0000 (13:45 +0000)]
Mark test as flaky.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 13:26:44 +0000 (13:26 +0000)]
Unreviewed, rolling out r113714.
http://trac.webkit.org/changeset/113714
https://bugs.webkit.org/show_bug.cgi?id=83887
It is behaving strange on the bots and needs more
investigation. (Requested by jeez_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebKit2:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::isViewWindowActive):
Tools:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 13:16:58 +0000 (13:16 +0000)]
Unreviewed, rolling out r114103.
http://trac.webkit.org/changeset/114103
https://bugs.webkit.org/show_bug.cgi?id=83884
New breakpoint UI looks bad / needs polish. (Requested by
pfeldman_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 13:14:08 +0000 (13:14 +0000)]
[BlackBerry] Sign in cookie for ESPN.com does not retain login account (for fantasy sports).
https://bugs.webkit.org/show_bug.cgi?id=83760
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-13
Reviewed by George Staikos.
.:
* ManualTests/blackberry/http-cookie-database-set.php: Added.
* ManualTests/blackberry/http-cookie-database-update.php: Added.
Source/WebCore:
When we update cookies' database, protocol shouldn't be checked since it is not a cookie's key.
ESPN.com's https cookies should replace old http cookies if they have the same keys(name, path, domain).
We must restart the browser to test, so have to write a manual test case.
Test: ManualTests/blackberry/http-cookie-database-set.php
* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::invokeOpen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 13:06:19 +0000 (13:06 +0000)]
Mark test as flaky.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Fri, 13 Apr 2012 13:01:51 +0000 (13:01 +0000)]
webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
https://bugs.webkit.org/show_bug.cgi?id=83690
Reviewed by Tor Arne Vestbø.
Typing part of an email and pressing <TAB> will bash-complete it using the list in
Tools/Scripts/webkitpy/common/config/committers.py
* Scripts/webkit-tools-completion.sh:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 13 Apr 2012 12:57:53 +0000 (12:57 +0000)]
[Qt] Gardening: rebaseline 2 tests and add 5 tests to skiplist.
Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-04-13
Reviewed by Csaba Osztrogonác.
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/Skipped:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Fri, 13 Apr 2012 12:56:08 +0000 (12:56 +0000)]
[Qt] Use QQuickFlickable::setPixelAligned instead of doing pixel-alignment when rendering.
https://bugs.webkit.org/show_bug.cgi?id=83770
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Revert the previous way of dealing with things. The problem is that different layers
would end up rounding in different directions, and would cause jittering between
layers or with the QQuickWebPage's background.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexture):
Source/WebKit2:
- Do the alignment on the highest level as possible: the QQuickFlickable content item
position. It already supports this with setPixelAligned which rounds the content item's position.
- Also move the setClip(true) to the common constructor as this constructor is currently only used by WTR.
- Remove setFlags(QQuickItem::ItemClipsChildrenToShape) as it is redundant with setClip(true).
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::QQuickWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Apr 2012 12:25:25 +0000 (12:25 +0000)]
Web Inspector: introduce ParsedURL type, clean up url and displayName mess in Resource and NetworkRequest.
https://bugs.webkit.org/show_bug.cgi?id=83871
Reviewed by Yury Semikhatsky.
Source/WebCore:
There is a number of random properties created on Resource and NetworkRequest that represent various url
fragments. Display name is being based on them and sometimes requires fake Resource instance to be created.
This change (officially) introduces WebInspector.ParsedURL as a type that encapsulates this complexity.
This change also moves documentURL property into the Resource and NetworkRequest constructors and brushes up
factory methods used to create the objects.
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.get displayDomain):
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.FrameEvaluationContext.prototype.get displayName):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.set url):
(WebInspector.NetworkRequest.prototype.get documentURL):
(WebInspector.NetworkRequest.prototype.get parsedURL):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
* inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshUrlFragment):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get parsedURL):
(WebInspector.Resource.prototype.get frameId):
(WebInspector.Resource.prototype.get loaderId):
(WebInspector.Resource.prototype.get displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype._createResourceFromFramePayload):
(WebInspector.ResourceTreeFrame.prototype._addRequest):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
(WebInspector.ParsedURL.prototype.get displayName):
(String.prototype.asParsedURL):
(WebInspector.displayDomain):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
* inspector/front-end/utilities.js:
LayoutTests:
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Apr 2012 12:15:05 +0000 (12:15 +0000)]
Web Inspector: extracting NetworkRequest from Resource (step 3)
https://bugs.webkit.org/show_bug.cgi?id=83802
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change extracts NetworkRequest from the Resource. It is now clear that these two
should have super class that would be responsible for parsing URL and would define the
requestContent signature. Corresponding patch will follow.
* inspector/front-end/NetworkManager.js:
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest):
(WebInspector.NetworkRequest.prototype.get requestId):
(WebInspector.NetworkRequest.prototype.set requestId):
(WebInspector.NetworkRequest.prototype.get url):
(WebInspector.NetworkRequest.prototype.get frameId):
(WebInspector.NetworkRequest.prototype.get loaderId):
(WebInspector.NetworkRequest.prototype.get startTime):
(WebInspector.NetworkRequest.prototype.set startTime):
(WebInspector.NetworkRequest.prototype.get responseReceivedTime):
(WebInspector.NetworkRequest.prototype.set responseReceivedTime):
(WebInspector.NetworkRequest.prototype.get endTime):
(WebInspector.NetworkRequest.prototype.set endTime):
(WebInspector.NetworkRequest.prototype.get duration):
(WebInspector.NetworkRequest.prototype.get latency):
(WebInspector.NetworkRequest.prototype.get receiveDuration):
(WebInspector.NetworkRequest.prototype.get resourceSize):
(WebInspector.NetworkRequest.prototype.set resourceSize):
(WebInspector.NetworkRequest.prototype.get transferSize):
(WebInspector.NetworkRequest.prototype.increaseTransferSize):
(WebInspector.NetworkRequest.prototype.get finished):
(WebInspector.NetworkRequest.prototype.set finished):
(WebInspector.NetworkRequest.prototype.get failed):
(WebInspector.NetworkRequest.prototype.set failed):
(WebInspector.NetworkRequest.prototype.get canceled):
(WebInspector.NetworkRequest.prototype.set canceled):
(WebInspector.NetworkRequest.prototype.get cached):
(WebInspector.NetworkRequest.prototype.set cached):
(WebInspector.NetworkRequest.prototype.get timing):
(WebInspector.NetworkRequest.prototype.set timing):
(WebInspector.NetworkRequest.prototype.get mimeType):
(WebInspector.NetworkRequest.prototype.set mimeType):
(WebInspector.NetworkRequest.prototype.get displayName):
(WebInspector.NetworkRequest.prototype.get folder):
(WebInspector.NetworkRequest.prototype.get displayDomain):
(WebInspector.NetworkRequest.prototype.get type):
(WebInspector.NetworkRequest.prototype.set type):
(WebInspector.NetworkRequest.prototype.get redirectSource):
(WebInspector.NetworkRequest.prototype.set redirectSource):
(WebInspector.NetworkRequest.prototype.get requestHeaders):
(WebInspector.NetworkRequest.prototype.set requestHeaders):
(WebInspector.NetworkRequest.prototype.get requestHeadersText):
(WebInspector.NetworkRequest.prototype.set requestHeadersText):
(WebInspector.NetworkRequest.prototype.get requestHeadersSize):
(WebInspector.NetworkRequest.prototype.requestHeaderValue):
(WebInspector.NetworkRequest.prototype.get requestCookies):
(WebInspector.NetworkRequest.prototype.get requestFormData):
(WebInspector.NetworkRequest.prototype.set requestFormData):
(WebInspector.NetworkRequest.prototype.get requestHttpVersion):
(WebInspector.NetworkRequest.prototype.get responseHeaders):
(WebInspector.NetworkRequest.prototype.set responseHeaders):
(WebInspector.NetworkRequest.prototype.get responseHeadersText):
(WebInspector.NetworkRequest.prototype.set responseHeadersText):
(WebInspector.NetworkRequest.prototype.get responseHeadersSize):
(WebInspector.NetworkRequest.prototype.responseHeaderValue):
(WebInspector.NetworkRequest.prototype.get responseCookies):
(WebInspector.NetworkRequest.prototype.get queryParameters):
(WebInspector.NetworkRequest.prototype.get formParameters):
(WebInspector.NetworkRequest.prototype.get responseHttpVersion):
(WebInspector.NetworkRequest.prototype._parseParameters):
(WebInspector.NetworkRequest.prototype._headerValue):
(WebInspector.NetworkRequest.prototype.get content):
(WebInspector.NetworkRequest.prototype.get contentEncoded):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.isHttpFamily):
(WebInspector.NetworkRequest.prototype.requestContentType):
(WebInspector.NetworkRequest.prototype.isPingRequest):
(WebInspector.NetworkRequest.prototype.hasErrorStatusCode):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._contentURL):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
(WebInspector.NetworkRequest.prototype.setResource):
(WebInspector.NetworkRequest.prototype.resource):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._resourceAdded):
(WebInspector.RawSourceCode.prototype.forceUpdateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set url):
(WebInspector.Resource.prototype.get type):
(WebInspector.Resource.prototype.get mimeType):
(WebInspector.Resource.prototype.set mimeType):
(WebInspector.Resource.prototype.get content):
(WebInspector.Resource.prototype.get contentEncoded):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
LayoutTests:
* http/tests/inspector/network/network-request-revision-content.html:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/set-breakpoint.html:
* inspector/debugger/source-frame.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Fri, 13 Apr 2012 12:12:30 +0000 (12:12 +0000)]
use getClipDeviceBounds, rather than (deprecated) getTotalClip
https://bugs.webkit.org/show_bug.cgi?id=83808
Reviewed by Stephen White.
Equivalent functionality, existing tests apply.
* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDraw):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 12:02:05 +0000 (12:02 +0000)]
Mark test as flaky.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 11:44:22 +0000 (11:44 +0000)]
[EFL] Add API for color chooser
https://bugs.webkit.org/show_bug.cgi?id=83692
.:
Enables INPUT_TYPE_COLOR by default on the EFL port.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:
Source/WebCore:
Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
* PlatformEfl.cmake:
* platform/efl/ColorChooserEfl.cpp: Added.
(WebCore):
(WebCore::ColorChooserEfl::ColorChooserEfl):
(WebCore::ColorChooserEfl::~ColorChooserEfl):
(WebCore::ColorChooserEfl::setSelectedColor):
(WebCore::ColorChooserEfl::endChooser):
* platform/efl/ColorChooserEfl.h: Added.
(WebCore):
(ColorChooserEfl):
Source/WebKit/efl:
Added new API to enable browsers to display a custom color picker
when an input field of type "color" is activated.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore):
(WebCore::ChromeClientEfl::createColorChooser):
(WebCore::ChromeClientEfl::removeColorChooser):
(WebCore::ChromeClientEfl::updateColorChooser):
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* ewk/ewk_private.h:
(WebCore):
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_color_chooser_new):
(ewk_view_color_chooser_destroy):
(ewk_view_color_chooser_color_set):
(ewk_view_color_chooser_changed):
* ewk/ewk_view.h:
Tools:
Enables INPUT_TYPE_COLOR by default on the EFL port.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
* Scripts/build-webkit:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 11:25:31 +0000 (11:25 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 11:19:54 +0000 (11:19 +0000)]
Linux rebaselines.
Unreviewed.
* platform/chromium-linux/platform/chromium/compositing/filters: Added.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Apr 2012 11:16:34 +0000 (11:16 +0000)]
[Qt] Build fix with QT_NO_BEARERMANAGEMENT
Reviewed by Jocelyn Turcotte.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 11:11:59 +0000 (11:11 +0000)]
Enabling/disabling delegates scrolling when page has no composited content asserts on WK1.
https://bugs.webkit.org/show_bug.cgi?id=83860
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-13
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
WK2 has compositing mode on all the time, while Wk1 turns it on only when
the page has composited content. This patch ensures that, when delegates scrolling behavior
is changed, backing stores are cleared only when there's an actual composition,
similarly to what CachedFrame does.
Test: fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html
* page/FrameView.cpp:
(WebCore::FrameView::delegatesScrollingDidChange):
LayoutTests:
* fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts-expected.txt: Added.
* fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 13 Apr 2012 11:09:29 +0000 (11:09 +0000)]
[chromium] Add WebKit API to access <datalist> options
https://bugs.webkit.org/show_bug.cgi?id=83762
Introduce WebInputElement::dataListOptions so we can implement a UI for datalist.
Reviewed by Kent Tamura.
* public/WebInputElement.h:
(WebKit):
(WebInputElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::dataListOptions): Added. Returns a WebNodeCollection containing WebOptionElements.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 10:39:29 +0000 (10:39 +0000)]
Unreviewed, GTK baselines for tests now being runned since the
migration to test_expectations.
* platform/gtk/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/gtk/editing/pasteboard/smart-drag-drop-expected.txt: Added.
* platform/gtk/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/gtk/fast/dom/gc-10-expected.txt: Added.
* platform/gtk/fast/forms/date/date-appearance-expected.txt: Added.
* platform/gtk/fast/images/exif-orientation-css-expected.txt: Added.
* platform/gtk/fast/images/exif-orientation-expected.txt: Added.
* platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Added.
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
* platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
* platform/gtk/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Added.
* platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Added.
* platform/gtk/fast/regions/region-style-image-background-color-expected.txt: Added.
* platform/gtk/fast/regions/region-style-inline-background-color-expected.txt: Added.
* platform/gtk/fast/regions/render-region-custom-style-mark-expected.txt: Added.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-character-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-first-word-expected.txt: Added.
* platform/gtk/fast/text/hyphenate-locale-expected.txt: Added.
* platform/gtk/fast/text/hyphens-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-126-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-127-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-65-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-82-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-84-expected.txt: Added.
* platform/gtk/fast/viewport/viewport-87-expected.txt: Added.
* platform/gtk/mathml/presentation/mo-stretch-expected.txt: Added.
* platform/gtk/mathml/presentation/msub-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msub-sub-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-sub-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msubsup-sup-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msup-base-changed-expected.txt: Added.
* platform/gtk/mathml/presentation/msup-sup-changed-expected.txt: Added.
* platform/gtk/plugins/plugin-initiate-popup-window-expected.txt: Added.
* platform/gtk/test_expectations.txt: Mark a media/track test flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Apr 2012 10:37:51 +0000 (10:37 +0000)]
[Qt] Fix build on OS X
We were manually including the directories needed from WTF, instead of
using the WEBKIT qmake variable to add dependencies, which also adds
other tricks from WTF.pri, such as the right include paths for ICU.
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 10:23:18 +0000 (10:23 +0000)]
New suppression.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 13 Apr 2012 10:11:10 +0000 (10:11 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Skip two media tests trigger flakiness.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 13 Apr 2012 10:10:41 +0000 (10:10 +0000)]
Web Inspector: Line number is not displayed while debugging javascript
https://bugs.webkit.org/show_bug.cgi?id=83786
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-13
Reviewed by Pavel Feldman.
Changed the textViewer.css to start displaying the line number with
appropriate color property. Added outline property for enhanced view
No additional test cases required for the above fix.
* inspector/front-end/Images/breakpointConditionalCounterBorder.png:
* inspector/front-end/Images/breakpointCounterBorder.png:
* inspector/front-end/Images/programCounterBorder.png:
* inspector/front-end/textViewer.css:
(.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint.webkit-execution-line .webkit-line-number-outer):
(.webkit-breakpoint-conditional.webkit-execution-line .webkit-line-number-outer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Fri, 13 Apr 2012 09:37:09 +0000 (09:37 +0000)]
Now test sometimes crashes in Debug on XP too.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc