Shane Neuville [Fri, 6 Dec 2019 19:00:35 +0000 (12:00 -0700)]
Put SwipeView behind experimental flag (#8786)
* Put SwipeView behind experimental flag
* Update Xamarin.Forms.ControlGallery.Android/FormsAppCompatActivity.cs
Samantha Houts [Fri, 6 Dec 2019 04:21:20 +0000 (20:21 -0800)]
Merge branch '4.3.0' into 4.4.0
Javier Suárez Ruiz [Fri, 6 Dec 2019 04:08:09 +0000 (05:08 +0100)]
[Android] Center elements in CarouselView (#8733)
* Added repro sample and fix on Android
* Added changes to centered all the items from the CarouselView on Android
* Fixed build error in the added Issue8525
* Renamed issue file
* Fixed build error
* Renamed Issue8525 to Issue8636
* Fixed issues centering carousel items using PeekAreaInsets on Android
fixes #8225
fixes #8638
Stephane Delcroix [Fri, 6 Dec 2019 04:04:49 +0000 (05:04 +0100)]
[X] send tree changed events on parenting (#8760)
so thye will be triggered in all cases
Shane Neuville [Thu, 5 Dec 2019 22:07:26 +0000 (15:07 -0700)]
Sdk Extras netcore 2 fix (#8771)
Shane Neuville [Thu, 5 Dec 2019 20:37:01 +0000 (13:37 -0700)]
Merge branch '4.3.0' into 4.4.0
# Conflicts:
# Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
Shane Neuville [Thu, 5 Dec 2019 20:35:13 +0000 (13:35 -0700)]
Revert back to VS 2017 (#8770)
Javier Suárez Ruiz [Thu, 5 Dec 2019 20:32:43 +0000 (21:32 +0100)]
Rebase from 4.3.0 branch
Shane Neuville [Thu, 5 Dec 2019 12:00:14 +0000 (05:00 -0700)]
Fix dynamic heights for iOS Flyout Item Templates (#8531) fixes #8290
* Fix dynamic heights for iOS Flyout
* - fix default height used
* Apply suggestions from code review
Shane Neuville [Wed, 4 Dec 2019 17:39:53 +0000 (10:39 -0700)]
Uwp thread to task fixes (#8639)
* Convert usages of thread in gallery to Task
* - swap thread for task
* - couple more thread to task fixes
* - remove call to start
Tomáš Ondřej [Wed, 4 Dec 2019 16:56:23 +0000 (17:56 +0100)]
Prevent UWP NullReferenceException when calling SavePropertiesAsync method off the main thread (#8696)
* Fix Issue 8682
* Rename UI test method
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* Return FallbackDispatcher with null-coalescing
Ken Nguyen [Wed, 4 Dec 2019 16:52:52 +0000 (23:52 +0700)]
fix #5518 | Frame Tap Gesture not working when using Visual="Material" in iOS (#7988)
* fix #5518
* - small changes to ui tests
* - fix automationid and ui test
* - fix null ref
Mario van Zeist [Wed, 4 Dec 2019 12:52:43 +0000 (13:52 +0100)]
[iOS] Fixes crash in CollectionViews when using DataTemplateSelector as a DataTemplate when used in GroupHeaders and or GroupFooters (#8674)
- fixes #8647
* Added repro and partial fix
* Removed some code in Templated cell to prevent an extension method being called twice.
Modified ItemsViewController to call different bind function. (Removed older one)
Added checks for Header/Footer in groupableItemsViewController.
Some code cleanup
* Removed unittest as I could not get it to run Due to missing Provisioningprofile
* Revert unintended change
* Cleanup some code
Javier Suárez Ruiz [Wed, 4 Dec 2019 12:44:09 +0000 (13:44 +0100)]
Fix crash on iOS adding items (ObservableCollection) (#7711) fixes #7678
Shane Neuville [Tue, 3 Dec 2019 21:18:03 +0000 (14:18 -0700)]
Reverse the order of assigning the Current Items on Shell (#8630)
* Failing Unit test for #8624
* - Set Current Item from the bottom up
Seungkeun Lee [Tue, 3 Dec 2019 10:37:39 +0000 (19:37 +0900)]
[Tizen] Enhancement EntryRenderer (#8686)
* Enhancement EntryRenderer on Tizen
- Support ClearButtonVisibility
- Support ReturnType.Next
- Limitation No support clearButtonVisibility on TV
* Update ClearButton color
* Remove redundant line
* Remove init value on IsTextBlockFoused
Seungkeun Lee [Tue, 3 Dec 2019 10:37:19 +0000 (19:37 +0900)]
[Tizen] Add RefreshView for Tizen (#8697)
* Add RefreshViewRenderer in Tizen
* RefreshView support ListView
* Support RefreshView on WebView
* Review updated
* Fix async method naming
* Update to handle ItemsViewRenderer
* Fix Reload window
Samantha Houts [Tue, 3 Dec 2019 02:17:59 +0000 (18:17 -0800)]
Merge branch '4.3.0' into 4.4.0
Gerald Versluis [Tue, 19 Nov 2019 11:05:18 +0000 (12:05 +0100)]
Update MacDeviceInfo.cs (#8561) fixes #8559
Rui Marinho [Mon, 2 Dec 2019 19:58:50 +0000 (19:58 +0000)]
Merge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 2 Dec 2019 19:20:47 +0000 (19:20 +0000)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Mon, 2 Dec 2019 19:17:09 +0000 (19:17 +0000)]
Update nuget release number (#8726)
Felipe Baltazar [Mon, 2 Dec 2019 17:35:11 +0000 (14:35 -0300)]
Fix issue 6878 | [Bug] ShellItem.Items.Clear() crashes when the ShellItem has bottom tabs (#8215)
* Fix issue 6878
* Code review ♻
Javier Suárez Ruiz [Mon, 2 Dec 2019 16:20:03 +0000 (17:20 +0100)]
[Android] Fix crash adding items to the CollectionView (#7670)
* Fixed 7510 - Crash adding items to the CollectionView on Android
* Removed code used for testing
Stephane Delcroix [Mon, 2 Dec 2019 10:24:02 +0000 (11:24 +0100)]
Merge branch '4.3.0' into 4.4.0
Stephane Delcroix [Mon, 2 Dec 2019 10:22:59 +0000 (11:22 +0100)]
Merge branch '4.2.0' into 4.3.0
Gerald Versluis [Thu, 28 Nov 2019 10:15:00 +0000 (11:15 +0100)]
Added defensive code (#8666)
Brayan Khosravian [Thu, 28 Nov 2019 08:12:23 +0000 (09:12 +0100)]
Fix-7167-UWP-ListViewRenderer-ScrollToTop-when-NotifyCollectionChangedAction.Reset (#7279)
* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.
* - changed controlgalery.projitems manually after cherrypick
* - made testcase uitestable
* - fixed uitesting exception
* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)
* - created test view in control gallery for issue 7167
- wrote view, vm, and "ImprovedObservableCollection" for testing purpose
- reproduced the bug without using any external nugets like "System.Reactive"
- added onitemselected of listview to test itemselections
- fixed by changing the implementation of Xamarin.Forms.Platform.UWP.ListViewRenderer.ReloadData
- single commit which is useful for cherry picks
- if itemsource and collectionviewsource.source (_collection) are the same the collectionviewsource is not being reinstantioated again
- wrote ui test.
* - changed controlgalery.projitems manually after cherrypick
* - made testcase uitestable
* - fixed uitesting exception
* - made view, vm ui-testable
- (TODO) modified uitest. (assert is missing)
* - wrote uitest, formetted
* - updated comments
* - uitest are only being executed for UWP
* - removed comments (PR feedback)
Rui Marinho [Wed, 27 Nov 2019 17:52:46 +0000 (17:52 +0000)]
[Core,iOS,Android] Remove NumberOfSideItems (#8614)
* [Core,iOS,Android] Remove number of side items
* [Controls] Fix IndicadorCodeGallery
Kangho Hur [Wed, 27 Nov 2019 16:54:42 +0000 (08:54 -0800)]
[Tizen] Use pre-created window at initailzation time (#8685)
Seungkeun Lee [Wed, 27 Nov 2019 15:04:13 +0000 (00:04 +0900)]
[Tizen] Add SwipeViewRenderer on Tizen (#8542)
* Add SwipeViewRenderer on Tizen
* Update SwipeItemWidth and Height to PX
* Rebase to 4.4.0
- Fix build error
- Fix async method naming
* Update StaticRegistrar
Shane Neuville [Tue, 26 Nov 2019 19:27:50 +0000 (12:27 -0700)]
Change build type on Android CG (#7909)
Rui Marinho [Tue, 26 Nov 2019 18:29:04 +0000 (18:29 +0000)]
[Tizen]Update StaticRegistrar (#8676)
Kangho Hur [Tue, 26 Nov 2019 16:21:04 +0000 (08:21 -0800)]
[Tizen] Provides Static Registrar (#8642)
* [Tizen] Provides Static Registrar
* Adds Lookup handler instead of fallback mechanism
sung-su.kim [Tue, 26 Nov 2019 15:54:42 +0000 (00:54 +0900)]
[Tizen] Add CarouselViewRenderer (#8081)
* [Tizen] Add CarouselViewRenderer
* [Tizen] Fix item size
* Move ItemSizingStrategy property to StructuredItemsView
Shane Neuville [Tue, 26 Nov 2019 15:26:39 +0000 (08:26 -0700)]
fix generating nugets (#8660)
Javier Suárez Ruiz [Tue, 26 Nov 2019 09:13:21 +0000 (10:13 +0100)]
Implement CollectionView Scrolled event on UWP (#8549)
fixes #8508
Stephane Delcroix [Tue, 26 Nov 2019 00:29:40 +0000 (01:29 +0100)]
[X] RegisterSourceInfo for XamlC (#8579)
When compiling in DEBUG, Register sourceInfo even for compiled code
shane [Sat, 23 Nov 2019 04:05:36 +0000 (21:05 -0700)]
Merge branch '4.3.0' into 4.4.0
# Conflicts:
# Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootHeader.cs
Andrei [Sat, 23 Nov 2019 01:09:32 +0000 (04:09 +0300)]
Added IndicatorsView (#7465)
* Added IndicatorsView
* removed static ctor
* refused plural in naming
* opened ItemsSource property
* followed code convention
* renamed IndicatorView (removed plural)
* made Color.Default as initial value
* updated IndicatorSize initial value
* Added IndicatorViewExtensions
* naming changes
* fix build
* small cleanup
* refactored control to templatedView
* added UIPageControl renderer for iOS
* moved extensions class to separate file
* removed useless private methods
* local vars name refactoring
* tapGesture naming update
* avoided linq
* code styling
* fixed default indicator colors for iOS
* added experimental flag
* [Core]Update api naming for IndicatorView
* Update IndicatorView.cs
* [Core] Add forms visual
* Revert "[Core] Add forms visual"
This reverts commit
380f36684ebf1d90ce8df074c13f70f8549ba8db.
* Revert "Revert "[Core] Add forms visual""
This reverts commit
6619e9e758970de3c11672ed2fb181dc37fe6ad0.
* [Gallery]Revert changes to gallery
* [Android] Export default renderer for FormsVisual
* [iOS] Handle FormsVisual for IndicatorView
* [iOS] Update Position from native renderer
* [iOS] IndicatorVIewRendederer updates and dispose
* [Controls] Fix merge
* Added IndicatorView Core Gallery sample
* Add IndicatorSample
* Update Xamarin.Forms.Controls.csproj
* [Core] Fix FormsVisual check
* [iOS] Fix FormsVisual check
* [Controls] Fix Indicator Gallery sample
* [Core] Cleanup IndicatorView
* [Core]Fix toogle between template and shapes on FormsVisual
* [Controls] Fix indicators samples
* [Controls] Fix IndicatorTemplate
* [Core] Add ItemsSourceBy xaml option
* [iOS,Android,Core] Add IndicatorStacklayout
* [Android] Remove extra renderer for FormsVisual
* [Controls] Remove Visual from Indicator sample
* [Core, iOS, Android] Fix bug on IndcatorView
* - remove forms visual
* - remove extra shared
* - remove forms visual
* - remove disposable
* - remove renderer from tizen
Javier Suárez Ruiz [Sat, 23 Nov 2019 00:47:01 +0000 (01:47 +0100)]
SwipeView (#7603)
* Implemented SwipeView Spec
* Fixed close SwipeView when scrolling ScrollView in iOS
* Removed unnecessary SwipeItemInvokedEventArgs
* Separate ISwipeItem in a new file
* Changed BaseSwipeEventArgs to be abstract
* Changed SwipeView SwipeItems properties to use OneWay BindingMode
* SwipeDirectionHelpers is now no EditorBrowsable
* Removed unnecessary ContextItem
* Changed SwipeItems base type from BO to Element
* Added defaultValueCreator for SwipeItems (and new sample)
* Changes in UWP SwipeViewRenderer to change some SwipeItems validations
* Renamed CustomSwipeItem to SwipeItemView
Added Close method
Added new SwipeView sample in Core Gallery
Propagate BindingContext from SwipeView to SwipeItems
Fixed bug in Android where occasionally was not rendering the SwipeItem (BindableLayout)
* Moved command execution from the renderers to the abstraction
* Implemented Close method on UWP
Fixed issue to notify SwipeItems changes (add/remove) on UWP
Implemented Uri IconSource (fix SwipeItem using an Url on UWP)
* Updated CustomSwipeItem samples
* Fixed issue on Android (not rendering SwipeItem occasionally)
* Avoid use MessagingCenter to close the SwipeView when scrolling
* Added new Core Gallery sample using custom size SwipeItems
Fixed icon position on Android with big SwipeItems
Fixed custom SwipeItem size issue
* Fixed vertical swipe threshold calc
* Created ISwipeViewController
Moved SwipeItemView to a new class
Moved SwipeEventArgs to a new class
Changes in touch events in Android to have the same behavior as in Android
* Unsubscribe CollectionChanged from the OldElement on UWP renderer
* Allow open the swipeView if the width of the SwipeItems exceeds the width of the SwipeView
Fixed Android SwipeItem icon position calc issue
* Updated SwipeItems to use ISwipeViewController
* Fixed typo
* Fixed typo
* - remove EditorBrowsable
* Changed SwipeTransitionMode enum values
* - fix samsung fussiness
* - fix compile error for UAP
Shane Neuville [Fri, 22 Nov 2019 21:06:14 +0000 (14:06 -0700)]
fix threadpool when compiling for 14393 (#8628)
Jiarui Guo [Fri, 22 Nov 2019 16:57:21 +0000 (08:57 -0800)]
#3533 Bring back uap10.0/netstandard1.4 support (#7079) fixes #3533
* target netstandard 1.4 for supporting rs2
* multi targeting
* initial tests
* - set a couple libraries to NS1.0
* - ns1.4
* - fix gallery project
* - fix min targets
* - fix target
* - remove sdk
* - buildControlsPath
* - nuget restore
* - controls path
* - uwp version
* - add generic
* - fix xbf
* - add tuple nuget
* - set max target to 16299
* - proj fixes
Gerald Versluis [Fri, 22 Nov 2019 14:51:22 +0000 (15:51 +0100)]
Update LabelRenderer.cs (#8571) fixes #7019
Gerald Versluis [Fri, 22 Nov 2019 03:04:10 +0000 (04:04 +0100)]
[UWP] Fix MDP Button "Padding" issue (#8610)
* Update MasterDetailControlStyle.xaml
* Added comments
* Update MasterDetailControlStyle.xaml
Stephane Delcroix [Fri, 22 Nov 2019 00:25:32 +0000 (01:25 +0100)]
[C] avoid calling ChangeVisualState twice (#8381)
Peter Moore [Fri, 22 Nov 2019 00:21:33 +0000 (18:21 -0600)]
RelativeSource Binding Bug Fixes (Gh8450) (#8541)
* RelativeSource Binding Bug FIxes
(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes;
(2) fix incorrect interpretation of AncestorLevel;
(3) much more robust unit tests for RelativeSource ancestor-type binding (#4)
* Update Xamarin.Forms.Core.UnitTests/RelativeSourceBindingTests.cs
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Fixes #8450
Brian Runck [Thu, 21 Nov 2019 23:49:05 +0000 (18:49 -0500)]
[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)
* iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command property binding on non-Xamarin.Forms.Command ICommand implementations
* Changes after code review
* - add ui test to android
E.Z. Hart [Thu, 21 Nov 2019 15:53:39 +0000 (08:53 -0700)]
Remove ItemSizingStrategy from CarouselView (#8588)
* Move ItemSizingStrategy
* Fix tests
* Fix Android
* Fix Tizen
* Fix iOS
Shane Neuville [Thu, 21 Nov 2019 15:33:05 +0000 (08:33 -0700)]
[iOS] Fix top tab highlighting (#8599)
* Let UICollectionViewCell handle state itself (#7884)
Fixes #7416
* [iOS] Fix top tab highlighting
melimion [Thu, 21 Nov 2019 15:22:40 +0000 (18:22 +0300)]
Fix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility=WhenEditing (#8429)
* repro
* fix
* set _clearBtn to null in Dispose
* comment removed
Shane Neuville [Thu, 21 Nov 2019 06:02:30 +0000 (23:02 -0700)]
slow down gesture scroll for ui test and let it retry (#8591)
Shane Neuville [Thu, 21 Nov 2019 05:52:52 +0000 (22:52 -0700)]
Gif Animation Support (#7330)
* Add image animation API.
* Add animated image tests.
* Add animated image UWP implementation.
* Add animated image IOS implementation.
* Add animated image Android implementation.
Also include GIF image parser base class + android parser sub class.
* Add animation finished playing event to Android/IOS for image.
* Add fallback when loading none GIF as animation image.
* Adding a couple of additional tests for animated images.
* Adjusting image animation support based on PR feedback.
* Add support to reload as animated image on StartAnimation call.
* Add UITest and activity indicator when loading from source for Issue1704.
* Reduce number of temporary bitmaps when scaling.
* Implemented review feedback.
* Animation problems related to Android API level 19 and earlier
due to a couple of bugs and changed behavior in AnimationDrawable class.
Implemented a couple of fixes and workaround related to these bugs, fixing
the animation issues on devices before Android Lollipop.
* Moved a couple of methods implemented in FormsAnimationDrawable into an
interface that is used to hide implementation details. Enables possibility
to factor different implementations of animation support going forward.
* Fixed review feedback and comments.
* Notify IOS to redraw control when changing animation layer.
* - android rebase fixes
* - first set of iOS changes for gifs
* - uwp Gif changes
* - clean up android gif code and enable gif for ImageButtons
* - cleanup iOS gif implementation
* - fix imagebutton and other sources
* - add imagebutton to tests
* - getting rid of start/stop and just using IsAnimationPlaying
* - image button
* - adding animation handler for android
* - replace gifs
* - fix rebase issues
* Added gif samples in Core Gallery
* Updated gif Core Gallery sample
* Fixed UWP gif samples path
* - remove auto play
- fix uwp so it plays correctly on load
* Added support to Url gifs on Android
* - fix rebase
* - fix NRE and iOS repeat
* - fix android loop counter
* - fix animation stopped on ios
* - fix removed ImageHandler interface Android
* - add top margin so ui tests can click button
Shane Neuville [Wed, 20 Nov 2019 11:51:30 +0000 (04:51 -0700)]
Shell Navigation Bar Has Shadow property (#8408)
* add shadow api for shell nav bar
* - ios fixes
* - ios fixes
* - name fix android and simplify types on ios
* - change to listener
* - cleanup
* - remove toolbar
* - fix ios to propagate nav bar on page push
* - fix android crash
E.Z. Hart [Tue, 19 Nov 2019 19:19:14 +0000 (12:19 -0700)]
Fix NRE on iOS 10 when navigating away from a page with a grouped CollectionView (#8496)
Shane Neuville [Tue, 19 Nov 2019 14:19:57 +0000 (07:19 -0700)]
Expose top tab creation methods (#8441) fixes #7808 fixes #8428
Gerald Versluis [Tue, 19 Nov 2019 11:05:18 +0000 (12:05 +0100)]
Update MacDeviceInfo.cs (#8561) fixes #8559
Javier Suárez Ruiz [Tue, 19 Nov 2019 10:24:53 +0000 (11:24 +0100)]
Fix crash using the CarouselView and EmptyView (#8430)
Felipe Baltazar [Tue, 19 Nov 2019 10:09:16 +0000 (07:09 -0300)]
Fix Bug 7823 - Frame corner radius (#8032)
* Fix Bug 7823
* Code review
Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Code review ♻
* Code review ♻
* revert
7f93346a3d1d3261d05843084d1934d5201b0c75
* Revert
d9ad8f31507e8373a2db1f4b9eb737b256dcf6ad
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* Update Xamarin.Forms.Controls.Issues.Shared.projitems
* rebase 4.4.0 fixes
* fix rebase 4.4.0
* fix rebase 4.4.0
* Fix test 7823
* Fixes api 19 test
Shane Neuville [Tue, 19 Nov 2019 01:31:25 +0000 (18:31 -0700)]
Merge branch '4.3.0' into 4.4.0
# Conflicts:
# Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
# build.cake
Shane Neuville [Tue, 19 Nov 2019 00:58:28 +0000 (17:58 -0700)]
Merge branch '4.2.0' into 4.3.0
# Conflicts:
# azure-pipelines.yml
Shane Neuville [Tue, 19 Nov 2019 00:54:56 +0000 (17:54 -0700)]
Add export method for transform string on UI Tests (#8532)
* export transform string
* - add missing renderers to performance tracker
* Update Xamarin.Forms.ControlGallery.iOS/PerformanceTrackerRenderer.cs
Shane Neuville [Mon, 18 Nov 2019 17:10:14 +0000 (10:10 -0700)]
Implement FormsStack and FormsQueue internally for VS 2017 Compatibility (#8403)
* FormsStack and FormsQueue for VS 2017 Compat
* - sync stable vs mac versions
* - mono version
* - gtk
* - fix mono provision
* Update Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
* - remove uwp changes
* - add 2019 back in
* Update azure-pipelines.yml
Glenn Versweyveld [Mon, 18 Nov 2019 14:38:35 +0000 (15:38 +0100)]
Keep tab image collapsed if no datasource is available (#8050) fixes #6757
Stephane Delcroix [Mon, 18 Nov 2019 10:39:51 +0000 (11:39 +0100)]
Merge branch '4.3.0' into 4.4.0
Stephane Delcroix [Mon, 18 Nov 2019 10:38:36 +0000 (11:38 +0100)]
Merge branch '4.2.0' into 4.3.0
E.Z. Hart [Mon, 18 Nov 2019 09:19:50 +0000 (02:19 -0700)]
Disable packager for CollectionView on UWP (#8404)
* Reproduce issue 8366
* Clean up old comments
* Turn off packaging for the CollectionView on UWP
Fixes #8366
Jon Robinson Levy [Fri, 15 Nov 2019 13:54:35 +0000 (14:54 +0100)]
Fix 7361 - [UWP] Stepper buttons not becoming enabled again, when disabled more than once. (#8191)
* Adding test class Issue7361
* Adding checks to prevent PseudoDisable from being called once _plus- or _minusStateCache is set.
* Improving Instructions in Issue7361 test page.
Rui Marinho [Wed, 13 Nov 2019 23:44:47 +0000 (23:44 +0000)]
[Build] Update version numbers to ship from yaml (#8437)
* Update version numbers
* Update Version.targets
* Fix variables
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
Stephane Delcroix [Wed, 13 Nov 2019 15:09:43 +0000 (16:09 +0100)]
[X] FontSizeConverter on FontImageExtension (#8375)
fixes https://github.com/xamarin/Xamarin.Forms/pull/7887#issuecomment-
549437276
Kangho Hur [Tue, 12 Nov 2019 11:04:43 +0000 (03:04 -0800)]
[Tizen] Enables SwipeGestureHandler (#8456)
Philippe Leybaert [Mon, 11 Nov 2019 18:50:53 +0000 (12:50 -0600)]
Reset transformation properly on UWP (#7385) (#7386)
Shane Neuville [Fri, 8 Nov 2019 20:33:32 +0000 (13:33 -0700)]
Merge branch '4.3.0' into 4.4.0
E.Z. Hart [Fri, 8 Nov 2019 19:44:08 +0000 (12:44 -0700)]
Make character spacing work for UWP Picker without breaking ItemsSource (#8356)
* Make character spacing work for UWP Picker without breaking ItemsSource
Fixes #8177
* Add test instructions
Shane Neuville [Wed, 6 Nov 2019 10:28:01 +0000 (03:28 -0700)]
Ensure that ParentSet fires before OnAppearing (#8242)
Rui Marinho [Wed, 6 Nov 2019 10:12:42 +0000 (10:12 +0000)]
[Android] Fix API usage on Android19 (#8378)
* [Android] Check api usage for set color on image drawable
* [Android] Add missing brackets
Javier Suárez Ruiz [Tue, 5 Nov 2019 14:56:17 +0000 (15:56 +0100)]
[Android] Fix Switch Thumb wrong color (#7777) fixes #7249
Gerald Versluis [Tue, 5 Nov 2019 09:53:34 +0000 (10:53 +0100)]
Added defensive code (#8324)
E.Z. Hart [Mon, 4 Nov 2019 21:21:59 +0000 (14:21 -0700)]
Add missing null check on ItemsSource when IsGrouped is true; fixes #8269 (#8273)
Gerald Versluis [Mon, 4 Nov 2019 20:37:28 +0000 (21:37 +0100)]
Fix UWP Toolbar icons (#8147)
* Added demo and fix
* Update Issue7505.cs
* Update Platform.cs
* Fixed AsyncValue
Javier Suárez Ruiz [Mon, 4 Nov 2019 20:08:43 +0000 (21:08 +0100)]
Fix crash using an object that implements IEnumerable and INotifyCollectionChanged (#8283) fixes #8200
Rui Marinho [Mon, 4 Nov 2019 13:26:25 +0000 (13:26 +0000)]
Merge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 4 Nov 2019 13:10:00 +0000 (13:10 +0000)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Fri, 1 Nov 2019 20:58:47 +0000 (20:58 +0000)]
[Android] Fix API21 usage on shell (#8335)
* [Android] Fix API21 usage
* [Android] Remove extra usings
E.Z. Hart [Fri, 1 Nov 2019 20:20:32 +0000 (14:20 -0600)]
Prevent UWP error/crash when updating binding off the main thread; fixes #8167 (#8311)
Konrad Müller [Fri, 1 Nov 2019 18:50:32 +0000 (19:50 +0100)]
[iOS] Fix scroll to does not scroll to end (#8241)
* Fix scroll to does not scroll to end
* Remove private modifier
Rui Marinho [Thu, 31 Oct 2019 17:06:42 +0000 (17:06 +0000)]
[Build] Clean repos, update vs image (#8339)
Samantha Houts [Thu, 31 Oct 2019 00:31:13 +0000 (17:31 -0700)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#8096)
adrianknight89 [Wed, 30 Oct 2019 21:15:20 +0000 (16:15 -0500)]
change accessibility modifiers (#8264)
Jon Robinson Levy [Wed, 30 Oct 2019 15:49:37 +0000 (16:49 +0100)]
Fix 8222 - [UWP] Make text in Editor control top aligned (#8280)
* Adding test case page for Issue 8222.
* Adding top alignment to text by setting VerticalContentAlignment = Verticalalignment.Top in the internal FormsTextBox. Fixes Issue 8222.
* Removing version file added by mistake
* Removing version file added by mistake
* Removing version file added by mistake
* Removing version file added by mistake
Konrad Müller [Wed, 30 Oct 2019 12:00:42 +0000 (13:00 +0100)]
implement placeholder text alignment (#8292)
Gerald Versluis [Wed, 30 Oct 2019 10:50:09 +0000 (11:50 +0100)]
Implement fix (#8281)
Rui Marinho [Tue, 29 Oct 2019 23:50:57 +0000 (23:50 +0000)]
Merge branch '4.3.0' into 4.4.0
Rui Marinho [Tue, 29 Oct 2019 13:08:11 +0000 (13:08 +0000)]
[Android] Make sure we use the right Context (#8196)
Samantha Houts [Tue, 29 Oct 2019 11:18:34 +0000 (04:18 -0700)]
[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145
* Add test case for issue 8145
* [Android] Don't double dispose the more sheet
fixes #8145
Shane Neuville [Tue, 29 Oct 2019 00:42:11 +0000 (18:42 -0600)]
Better detect IsCollapsed state/changes on master (#8181)
Shane Neuville [Tue, 29 Oct 2019 00:41:14 +0000 (18:41 -0600)]
[UWP] Delay RequestRefresh until Loaded (#8190)
fixes #8186
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)
Stephane Delcroix [Mon, 28 Oct 2019 18:25:35 +0000 (19:25 +0100)]
[X] resolve indexers on generic types (#8226)
The lovely #7837 is trying to be smarter at identifying which indexer to invoke,
by checking the parametertype. Of course, it wasn't tested on generic types...
So this is definitely a regression, I apologize for it.
- fixes #8221
Shane Neuville [Mon, 28 Oct 2019 17:26:55 +0000 (11:26 -0600)]
Fix Flyout behavior so it propagates from templated Content Page once it's created (#8135) fixes #7985
* Centralize SendAppearanceChanged call
* - Appearance Change UI tests
* - remove extra button and add better messaging
* - make sure there is space to swipe
* - fix rebase
* - only call appearance change if display page changes
* - process appearance changes before page has fully popped