Tom Gundersen [Thu, 3 Jul 2014 07:43:31 +0000 (09:43 +0200)]
networkd: netdev - take ref immediately after calling out
Keeping the refcounting next to the sd_bus_call_async() makes it easier to check.
Tom Gundersen [Thu, 3 Jul 2014 07:38:33 +0000 (09:38 +0200)]
networkd: split out vlan and macvlan handling
Lennart Poettering [Wed, 2 Jul 2014 23:19:26 +0000 (01:19 +0200)]
sd-login: use the same code for verfiying machine names everywhere
Lennart Poettering [Wed, 2 Jul 2014 23:19:21 +0000 (01:19 +0200)]
bus: close a bus that failed to connect
Lennart Poettering [Wed, 2 Jul 2014 23:17:26 +0000 (01:17 +0200)]
sd-bus: support connecting to remote hosts, directly into containers
systemctl -H root@foobar:waldi
will now show a list of services running on container "waldi" on host
"foobar", using "root" for authenticating at "foobar".
Since entereing a container requires priviliges, this will only work
correctly for root logins.
Lennart Poettering [Wed, 2 Jul 2014 23:10:01 +0000 (01:10 +0200)]
man: /usr/bin may contain binaries in any compatible arch, not just the primary one
Lennart Poettering [Wed, 2 Jul 2014 23:09:35 +0000 (01:09 +0200)]
man: fix links to systemd-efi-boot-generator(8)
Lennart Poettering [Wed, 2 Jul 2014 15:36:47 +0000 (17:36 +0200)]
sd-bus: when an event loop terminates, explicitly close the bus
This makes sure we actually release the bus and all the messages it
references.
Lennart Poettering [Wed, 2 Jul 2014 15:29:09 +0000 (17:29 +0200)]
bus: drop bus/message GC logic
When a caller drops all references to a bus and its messages while the
messages where still queue, this causes the bus to reference the
messages, and the messages to reference the bus, without anybody else
keeping a reference, which is something we so far considered a leak, and
tried to fix with a GC logic that would recognize cases like this, and
drop the reference.
This GC logic has been broken sofar, and remained unfixed. This commit
removes it altogther, replacing it with nothing. The rationale is that
simply because all refs to the bus have been dropped its queued messages
should *still* be written to the bus, even if the caller doesn't retain
any reference to either bus nor message. This means it was actually
wrong to attempt to clean up the bus in this case.
The proper way how applications should handle this is by explicitly
invoking sd_bus_close(), when they want busses to go away. This is
probably want they want to do anyway to avoid getting spurious
callbacks after they stopped using a bus.
Lennart Poettering [Wed, 2 Jul 2014 15:12:24 +0000 (17:12 +0200)]
bus-proxy: restore operation in non-kdbus mode
bus-proxyd is not only the bridge between legacy dbus clients and kdbus
but is also used to access remote dbus servers via ssh. Let's make sure
it actually works for that.
Michal Sekletar [Fri, 30 May 2014 16:20:16 +0000 (18:20 +0200)]
localed: consider an unset model as a wildcard
Tom Gundersen [Wed, 2 Jul 2014 13:53:41 +0000 (15:53 +0200)]
sd-dhcp6-client: initialize variable
Lennart Poettering [Wed, 2 Jul 2014 13:13:29 +0000 (15:13 +0200)]
udev: net_setup_link builtin should print the reason why something fails
Let's tell users what is going wrong.
Lennart Poettering [Wed, 2 Jul 2014 11:42:25 +0000 (13:42 +0200)]
util: when unescaping strings, don't allow smuggling in of additional NUL bytes
Better safe than sorry.
Lennart Poettering [Wed, 2 Jul 2014 11:41:31 +0000 (13:41 +0200)]
util: generalize is_localhost() and use it everywhere where applicable
Lennart Poettering [Wed, 2 Jul 2014 10:23:36 +0000 (12:23 +0200)]
path: add new "systemd-path" utility for querying paths described in file-hierarchy(7)
This new tool is based on "sd-path", a new (so far unexported) API for
libsystemd, that can hopefully grow into a workable API covering /opt
and more one day.
Thomas Hindoe Paaboel Andersen [Tue, 1 Jul 2014 21:11:47 +0000 (23:11 +0200)]
coredump: vacuum - fix calculation of 10% of fs size for MaxUse
Thomas Hindoe Paaboel Andersen [Tue, 1 Jul 2014 20:56:31 +0000 (22:56 +0200)]
sd-dhcp6-client: check return value
Checking the return values seems to have been forgotten in
ed6ee21953dac9c78383da00bc4514ece6b75ab5
Filipe Brandenburger [Tue, 1 Jul 2014 20:42:59 +0000 (13:42 -0700)]
networkd: fix alignment of gperf source
Tom Gundersen [Tue, 1 Jul 2014 17:45:37 +0000 (19:45 +0200)]
networkd: netdev - add dummy support
Eugene Yakubovich [Tue, 1 Jul 2014 18:58:49 +0000 (11:58 -0700)]
networkd: send hostname to dhcp server
Send hostname (option 12) in DISCOVER and REQUEST messages so the
DHCP server could use it to register with dynamic DNS and such.
To opt-out of this behaviour set SendHostname to false in [DHCP]
section of .network file
[tomegun: rebased, made sure a failing set_hostname is a noop and moved
config from DHCPv4 to DHCP]
Tom Gundersen [Tue, 1 Jul 2014 19:49:28 +0000 (21:49 +0200)]
man: bring systemd.network(5) up-to-date
Based on diff by 'poma'.
Tom Gundersen [Tue, 1 Jul 2014 19:38:08 +0000 (21:38 +0200)]
man: bring systemd.netdev(5) up-to-date
Based on a diff by the mysterious 'poma'.
Thomas Hindoe Paaboel Andersen [Tue, 1 Jul 2014 19:11:35 +0000 (21:11 +0200)]
typo fixes
Tom Gundersen [Tue, 1 Jul 2014 17:41:45 +0000 (19:41 +0200)]
networkd: netdev - take ref when creating netdevs
We were doing this correctly for when the callback takes the Link object, but
must also do it for the cases it takes the NetDev object.
Kay Sievers [Tue, 1 Jul 2014 15:45:44 +0000 (17:45 +0200)]
man: file-hierarchy - emphasize /usr/lib/$arch-id instead of $libdir
Christian Hesse [Tue, 1 Jul 2014 08:22:51 +0000 (10:22 +0200)]
man/sd_journal_get_data: fix variable naming in example
Christian Hesse [Tue, 1 Jul 2014 08:22:50 +0000 (10:22 +0200)]
man/sd_journal_next: fix argument in example
The example does not compile, it fails with:
error: passing argument 3 of ‘sd_journal_get_data’ from incompatible
pointer type
Cast to (const void **) to avoid this.
Lennart Poettering [Tue, 1 Jul 2014 14:37:38 +0000 (16:37 +0200)]
update TODO
Kay Sievers [Tue, 1 Jul 2014 14:00:05 +0000 (16:00 +0200)]
parse_uid: return -ENXIO for -1 uids
Thadeu Lima de Souza Cascardo [Tue, 1 Jul 2014 13:11:50 +0000 (10:11 -0300)]
Use dev_port for the ID of a network device.
For network devices on the same PCI function, dev_id should not be used,
since its purpose is for IPv6 support on interfaces with the same MAC
address.
The new dev_port sysfs attribute should be used instead of dev_id.
Lennart Poettering [Tue, 1 Jul 2014 11:51:26 +0000 (13:51 +0200)]
update TODO
Lennart Poettering [Tue, 1 Jul 2014 11:50:19 +0000 (13:50 +0200)]
man: document directories in $HOME, too, in file-hierarchy(7)
Tom Gundersen [Tue, 1 Jul 2014 11:30:23 +0000 (13:30 +0200)]
networkd: link - don't fail if master netdev already exists
This allows restarts to work gracefully.
Tom Gundersen [Tue, 1 Jul 2014 10:51:08 +0000 (12:51 +0200)]
networkd: tunnel - ensure that enslave callback is always invoked
The Link statemachine relies on this, as it would otherwise wait forever. Hook up the tunnels in the
same way as the other NetDev's.
Tom Gundersen [Tue, 1 Jul 2014 09:27:24 +0000 (11:27 +0200)]
networkd: link - ignore missing MAC address
Currently DHCP/IPv4LL only works on ethernet devices, but no reason not to otherwise
manage them.
Kay Sievers [Tue, 1 Jul 2014 10:25:38 +0000 (12:25 +0200)]
base-filesystem: avoid all searching if the link already exists
Kay Sievers [Tue, 1 Jul 2014 10:12:40 +0000 (12:12 +0200)]
base-filesystem: explicitely check existence of the platform's ABI dynamic loader
Kay Sievers [Tue, 1 Jul 2014 09:42:58 +0000 (11:42 +0200)]
base-filesystem: create /lib64 symlink to libdir /usr directory
Susant Sahani [Mon, 30 Jun 2014 05:05:48 +0000 (10:35 +0530)]
networkd: address_acquire use cleanup macro
use cleanup macro for Address na
[tomegun: dropped unneccessary braces]
Susant Sahani [Mon, 30 Jun 2014 05:05:49 +0000 (10:35 +0530)]
networkd: netdev add one separate line
Tom Gundersen [Tue, 1 Jul 2014 08:28:36 +0000 (10:28 +0200)]
networkd: link - drop assert from _free()
_free() should always succeed, even if object is not fully allocated.
Tom Gundersen [Tue, 1 Jul 2014 08:16:42 +0000 (10:16 +0200)]
sd-dhcp6-client: fix free before use
Tom Gundersen [Tue, 1 Jul 2014 08:09:52 +0000 (10:09 +0200)]
networkd: link - improve refcounting
We failed to take a ref when waiting for udev synchronization. Fix that and also
make unreffing in callbacks simpler throughout by using _cleanup_ macros.
Fixes <https://bugs.freedesktop.org/show_bug.cgi?id=80556>.
Lennart Poettering [Tue, 1 Jul 2014 00:39:08 +0000 (02:39 +0200)]
update TODO
Lennart Poettering [Tue, 1 Jul 2014 00:38:41 +0000 (02:38 +0200)]
TODO: start documenting changes for 215
Lennart Poettering [Mon, 30 Jun 2014 23:33:56 +0000 (01:33 +0200)]
man: document ConditionNeedsUpdate=
Lennart Poettering [Mon, 30 Jun 2014 23:14:11 +0000 (01:14 +0200)]
man: extend a bit what to expect from the various places apps can store data
Lennart Poettering [Mon, 30 Jun 2014 23:13:50 +0000 (01:13 +0200)]
man: add sections about file node types and write access to file-hierarchy(7)
Zbigniew Jędrzejewski-Szmek [Mon, 30 Jun 2014 13:41:01 +0000 (09:41 -0400)]
man: mention x-initrd.mount option in fstab options list
Zbigniew Jędrzejewski-Szmek [Mon, 30 Jun 2014 13:27:16 +0000 (09:27 -0400)]
man: mention that x-systemd.device-timeout is only for fstab
Reformat fstab options description. Now they are easier to read and
show up in systemd.directives(7).
Use a single sublist for both /etc/fstab and /etc/crypttab options.
Many of them can be used in both places. crypttab(5) is updated to use
the same docbook elements, so formatting is uniform.
Zbigniew Jędrzejewski-Szmek [Sat, 28 Jun 2014 17:21:01 +0000 (13:21 -0400)]
man: beef up systemd-fsck description
Zbigniew Jędrzejewski-Szmek [Mon, 30 Jun 2014 22:41:17 +0000 (18:41 -0400)]
cryptsetup: allow x-systemd.device-timeout
https://bugs.freedesktop.org/show_bug.cgi?id=54210
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jun 2014 19:03:05 +0000 (15:03 -0400)]
fstab-generator: allow x-systemd.device-timeout for swap units
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jun 2014 16:12:07 +0000 (12:12 -0400)]
Move x-systemd-device.timeout handling from core to fstab-generator
Instead of adjusting job timeouts in the core, let fstab-generator
write out a dropin snippet with the appropriate JobTimeout.
x-systemd-device.timeout option is removed from Options= line
in the generated unit.
The functions to write dropins are moved from core/unit.c to
shared/dropin.c, to make them available outside of core.
generator.c is moved to libsystemd-label, because it now uses
functions defined in dropin.c, which are in libsystemd-label.
Lennart Poettering [Mon, 30 Jun 2014 22:28:54 +0000 (00:28 +0200)]
man: reference $TMPDIR, not $TMP in file-hierarchy(7)
This what environ(7) and POSIX define, so that's what we should
reference.
Lennart Poettering [Mon, 30 Jun 2014 22:16:37 +0000 (00:16 +0200)]
update TODO
Lennart Poettering [Mon, 30 Jun 2014 22:16:17 +0000 (00:16 +0200)]
man: document systemd-update-done.service
Tom Gundersen [Mon, 30 Jun 2014 22:05:03 +0000 (00:05 +0200)]
man: file-hierarchy - minor fixes
Leave non-specified top-level dirs out of the spec, and minor cleanups.
Lennart Poettering [Mon, 30 Jun 2014 21:30:00 +0000 (23:30 +0200)]
man: document how to query $libdir for the primary architecture using pkg-config
Lennart Poettering [Mon, 30 Jun 2014 21:10:11 +0000 (23:10 +0200)]
pc: no longer expose exec_prefix in .pc file
There's little reason to export this, so let's drop it to minimize the
file a bit.
Lennart Poettering [Mon, 30 Jun 2014 21:09:42 +0000 (23:09 +0200)]
pc: expose more drop-in dirs in the .pc file
Lennart Poettering [Mon, 30 Jun 2014 21:04:26 +0000 (23:04 +0200)]
pc: export $libdir in the .pc file
This is useful for code that tries to figure out the primary arch's
$libdir on the local system, given that is different on the various
Linuxes.
Thomas Hindoe Paaboel Andersen [Mon, 30 Jun 2014 20:54:21 +0000 (22:54 +0200)]
man: file-hierarchy - typo fixes
Lennart Poettering [Mon, 30 Jun 2014 20:48:06 +0000 (22:48 +0200)]
man: deemphesize Fedora-specific "lib64", only mention the more generic $libdir
Lennart Poettering [Mon, 30 Jun 2014 19:44:49 +0000 (21:44 +0200)]
update TODO
Lennart Poettering [Mon, 30 Jun 2014 19:44:05 +0000 (21:44 +0200)]
units: skip mounting /tmp if it is a symlink
We shouldn't get confused if people have symlinked /tmp somewhere, so
let's simply skip the mount then.
Thomas Hindoe Paaboel Andersen [Mon, 30 Jun 2014 20:38:17 +0000 (22:38 +0200)]
man: daemon - typo fix
Lennart Poettering [Mon, 30 Jun 2014 17:53:10 +0000 (19:53 +0200)]
tmpfiles: explicitly set mode for /run/log
Lennart Poettering [Mon, 30 Jun 2014 17:52:44 +0000 (19:52 +0200)]
man: a couple of additions to file-hierarchy(7)
Lennart Poettering [Mon, 30 Jun 2014 17:06:18 +0000 (19:06 +0200)]
tmpfiles: don't do automatic cleanup in $XDG_RUNTIME_DIR
Now that logind will clean up all IPC resources of a user we should
really consider $XDG_RUNTIME_DIR as just another kind of IPC with the
same life-cycle logic as the other IPC resources. This should be safe
now to do since every user gets his own $XDG_RUNTIME_DIR tmpfs instance
with a fixed size limit, so that flooding of it will more effectively be
averted.
Lennart Poettering [Mon, 30 Jun 2014 17:06:11 +0000 (19:06 +0200)]
man: drop references to manual StandardError=syslog from daemon(7), we do this implicitly since ages
Lennart Poettering [Mon, 30 Jun 2014 17:05:17 +0000 (19:05 +0200)]
man: add a minimized, modernized description of the file system hierarchy systemd suggests
Lennart Poettering [Mon, 30 Jun 2014 14:22:12 +0000 (16:22 +0200)]
nspawn: block open_by_handle_at() and others via seccomp
Let's protect ourselves against the recently reported docker security
issue. Our man page makes clear that we do not make any security
promises anyway, but well, this one is easy to mitigate, so let's do it.
While we are at it block a couple of more syscalls that are no good in
containers, too.
Lennart Poettering [Mon, 30 Jun 2014 13:20:59 +0000 (15:20 +0200)]
nspawn: let's avoid using goto to wildly for non-cleanup purposes
Lennart Poettering [Mon, 30 Jun 2014 13:19:00 +0000 (15:19 +0200)]
nspawn: simplify exit condition check
Luke Shumaker [Mon, 30 Jun 2014 00:18:03 +0000 (20:18 -0400)]
nspawn: log a warning on failure from wait_for_terminate()
This is at the suggestion of Djalal Harouni on the mailing list, and
reflects the behavior of shared/util.c:wait_for_terminate_and_warn().
Luke Shumaker [Mon, 30 Jun 2014 00:18:02 +0000 (20:18 -0400)]
nspawn: Fix regression with exit status
Commit 113cea8 introduced a bug that caused the exit code of systemd-nspawn
to not reflect the exit code of the program executed in the container.
Luke Shumaker [Mon, 30 Jun 2014 00:18:01 +0000 (20:18 -0400)]
shared/util.c:wait_for_terminate_and_warn(): Add a comment on the return values
Tom Gundersen [Sun, 29 Jun 2014 21:58:18 +0000 (23:58 +0200)]
units: networkd - don't order wait-online.service before network.target
Reported by Michael Olbrich.
Tom Gundersen [Sun, 29 Jun 2014 21:47:13 +0000 (23:47 +0200)]
networkd: dhcp - use same metric for all DHCP-related routes
Lennart Poettering [Mon, 30 Jun 2014 10:41:26 +0000 (12:41 +0200)]
util: fix comment
Ronny Chevalier [Wed, 11 Jun 2014 19:20:52 +0000 (21:20 +0200)]
tests: add missing XDG_RUNTIME_DIR env variable
Otherwise the test fails because specifier_runtime() returns -ENOTSUP
when XDG_RUNTIME_DIR is not set.
Lennart Poettering [Sun, 29 Jun 2014 20:26:19 +0000 (22:26 +0200)]
sysusers: split up default sysusers snippet
This ways, distributions have an easier way to replace the OS specific
generic groups/users while keeping systemd's own.
Lennart Poettering [Sun, 29 Jun 2014 20:15:33 +0000 (22:15 +0200)]
util: refuse considering UID 0xFFFF and 0xFFFFFFFF valid
Lennart Poettering [Sun, 29 Jun 2014 20:15:01 +0000 (22:15 +0200)]
man: document the sysusers tool
Tom Gundersen [Sun, 29 Jun 2014 20:26:06 +0000 (22:26 +0200)]
network-internal: initialize _cleanup_ variable
Susant Sahani [Sun, 29 Jun 2014 19:39:08 +0000 (01:09 +0530)]
netowrkd:deserialize_dhcp_routes verify strndup ret
strndup need to be chcked
Tom Gundersen [Sun, 29 Jun 2014 14:59:33 +0000 (16:59 +0200)]
networkd: dhcp - update the lifetime of an existing address
The logic otherwise is that we leave anything preconfigured alone, but in the case of DHCP
we actually need to update it whenever the lease is renewed.
Tom Gundersen [Sun, 29 Jun 2014 14:42:43 +0000 (16:42 +0200)]
sd-dhcp-client: don't fail hard if UDP socket can not be bound
Even if we cannot renew the lease at T1, we will likely succeed at T2, so warn and ignore the failure.
This could happen if for whatever reason the received address is not yet configured, or it has
been lost.
Tom Gundersen [Sun, 29 Jun 2014 14:34:43 +0000 (16:34 +0200)]
networkd: improve DHCP error logging
Tom Gundersen [Sun, 29 Jun 2014 14:20:33 +0000 (16:20 +0200)]
units: local-fs.target - don't pull in default dependencies
Reported by Gerardo Exequiel Pozzi:
Looks like [commit
a4a878d0] also changes a unrelated file
(units/local-fs.target) [partially]reverting the commit
40f862e3 (filesystem targets: disable default dependencies)
The side effect, at least in my case is that the "nofail" option in both
"crypttab" and "fstab" has partial effect does the default timeout
instead of continue normal boot without timeout.
Tom Gundersen [Sat, 28 Jun 2014 14:21:58 +0000 (16:21 +0200)]
networkd: set static addresses immediately
Don't wait for IPv4LL nor DHCP to finish before setting statically configured addresses.
Eugene Yakubovich [Fri, 27 Jun 2014 22:00:06 +0000 (15:00 -0700)]
Add support for DHCP static route options
This adds support for DHCP options 33 and 121: Static Route and
Classless Static Route. To enable this feature, set UseRoutes=true
in .network file. Returned routes are added to the routing table.
Tom Gundersen [Sat, 28 Jun 2014 14:00:49 +0000 (16:00 +0200)]
networkd: merge DHCPv4 and DHCPv6 config
If there are v4 or v6 specific options we can keep those in separate sections,
but for the common options, we will use only one.
Moreovere only use DHCP=[yes/both|no/none|v4|v6] to enable or disable the clients.
Patrik Flykt [Thu, 26 Jun 2014 13:18:43 +0000 (16:18 +0300)]
sd-dhcp-client/networkd: set lifetimes for IPv4 addresses
Note that /proc/sys/net/ipv4/ip_dynaddr needs to be non-zero.
[tomegun: hook up DHCP renew events to increase the lifetime when necessary]
Tom Gundersen [Sun, 29 Jun 2014 11:11:44 +0000 (13:11 +0200)]
networkd/sd-dhcp-server: only start dhcp server when necessary
Jan Engelhardt [Fri, 27 Jun 2014 22:50:28 +0000 (00:50 +0200)]
doc: use expanded forms for written style
Jan Engelhardt [Fri, 27 Jun 2014 22:49:12 +0000 (00:49 +0200)]
doc: typographical improvements and choice of words
Jan Engelhardt [Fri, 27 Jun 2014 22:48:28 +0000 (00:48 +0200)]
doc: grammatical corrections