Tomas Weinfurt [Thu, 12 Sep 2019 18:48:41 +0000 (11:48 -0700)]
make sure BindDuringTcpWait_Succeeds does not run with other tests (dotnet/corefx#40958)
* make sure BindDuringTcpWait_Succeeds does not run with other tests
* add partial to NoParallelTests class
* add empty class to CollectionDefinition
Commit migrated from https://github.com/dotnet/corefx/commit/
b384d34bcd4674bc0df08a333a4973de8e2ac7ae
Omair Majid [Thu, 12 Sep 2019 17:57:14 +0000 (13:57 -0400)]
Add Runtime IDs for Fedora 32
Commit migrated from https://github.com/dotnet/corefx/commit/
86fc9e751c424278a9c4e163e0a71a9d7e30c8e7
Carlos Sanchez Lopez [Wed, 11 Sep 2019 20:38:29 +0000 (13:38 -0700)]
Add example of strong API proposal (dotnet/corefx#41042)
Commit migrated from https://github.com/dotnet/corefx/commit/
452c93e38097b53f19516486fda4f3b1f16334cf
Adam Sitnik [Wed, 11 Sep 2019 20:34:27 +0000 (22:34 +0200)]
add links to the new Profiling docs (dotnet/corefx#41018)
Commit migrated from https://github.com/dotnet/corefx/commit/
dc71f95667cabd5ad0f7a051c974e0d312b243e8
Adam Sitnik [Wed, 11 Sep 2019 19:57:23 +0000 (21:57 +0200)]
add few StartsWith edge case test cases (dotnet/corefx#41016)
* add Hungarian edge case for IsPrefix
* add InvariantCulture.CompareInfo.IsPrefix("o\u0308", "o") edge case
Commit migrated from https://github.com/dotnet/corefx/commit/
e32d9a2664a59eccbcbe5a4044cffbdd96538b5b
Adam Sitnik [Wed, 11 Sep 2019 19:56:55 +0000 (21:56 +0200)]
add IsPrefix test cases for Platforms differences (dotnet/corefx#41017)
Commit migrated from https://github.com/dotnet/corefx/commit/
728aceca7464e964719fc99ef585e63cbb95f44d
Tomas Weinfurt [Wed, 11 Sep 2019 19:16:01 +0000 (12:16 -0700)]
improve two http2 tests (dotnet/corefx#40797)
Commit migrated from https://github.com/dotnet/corefx/commit/
9eed67227c2d0766c1b7fe40fa8a1a97097e3beb
Krzysztof Wicher [Wed, 11 Sep 2019 18:34:57 +0000 (11:34 -0700)]
Fix SerialStream.Flush on Unix (dotnet/corefx#40896)
* Fix SerialStream.Flush
* Only wait for write queue to drain on Flush
* add test case with reproted scenario
Commit migrated from https://github.com/dotnet/corefx/commit/
45dba6ea7a49a9945a5ad497cfc3de2ec1246683
Katarzyna Bułat [Wed, 11 Sep 2019 18:23:17 +0000 (11:23 -0700)]
JsonDocument documenation fix (dotnet/corefx#40994)
* JsonDocument documenation fix
* comma added
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
0354194175bb8d609000b463f402942db7235f0a
Mandar Sahasrabuddhe [Wed, 11 Sep 2019 04:29:44 +0000 (09:59 +0530)]
Given examples and made points explicit (dotnet/corefx#41012)
Made certain points explicit by giving examples or specifying acronyms in brackets where the words they stand for, appear for first time.
Commit migrated from https://github.com/dotnet/corefx/commit/
76f566a281bbe979e80cbbb3a48ddf522cdcb4e1
Ahson Khan [Wed, 11 Sep 2019 00:49:22 +0000 (17:49 -0700)]
Avoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while escaping in Utf8JsonWriter. (dotnet/corefx#40996)
* Avoid MemoryMarshal.Cast when transcoding from UTF-16 to UTF-8 while
escaping in Utf8JsonWriter.
* Fix white space typo in the test expected string.
* Guard against empty spans where an implementation of JavascriptEncoder
might not handle null ptrs correctly.
* Cleanup tests to avoid some duplication.
* Some more test clean up.
Commit migrated from https://github.com/dotnet/corefx/commit/
ee9995f31b684a0c6e5488eceb2500bf0057da89
Charles Stoner [Wed, 11 Sep 2019 00:31:41 +0000 (17:31 -0700)]
Use slow path for CallInstruction returning enum value (dotnet/corefx#40976)
* Use slow path for CallInstruction returning enum value
* Fix assert
Commit migrated from https://github.com/dotnet/corefx/commit/
f2daf45473553c19cc7b3dd4bb3f2033080a254c
Jan Kotas [Tue, 10 Sep 2019 22:10:25 +0000 (15:10 -0700)]
Delete unused ItemGroup (dotnet/corefx#40983)
Moved to CoreLib
Commit migrated from https://github.com/dotnet/corefx/commit/
0ebca43a4db8d5ddaf2e9fd0df359a262b61c0ce
Viktor Hofer [Tue, 10 Sep 2019 18:23:02 +0000 (20:23 +0200)]
Re-enable macOS 10.13 (dotnet/corefx#40980)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b0e8cc8d66275de148f7310a7116de00d814cd0
Stephen Toub [Tue, 10 Sep 2019 15:36:35 +0000 (11:36 -0400)]
Fix namespace typo in Tasks test (dotnet/corefx#40974)
Commit migrated from https://github.com/dotnet/corefx/commit/
02bebd69dcac53a7b903d605ce43fd28cd5ee0e9
Santiago Fernandez Madero [Tue, 10 Sep 2019 13:37:09 +0000 (06:37 -0700)]
Add test for IComponent typeconverter register in TypeDescriptor (dotnet/corefx#40959)
Commit migrated from https://github.com/dotnet/corefx/commit/
d1eeba90af85dd203aa27adbb30a28e45b54e23d
Hugh Bellamy [Mon, 9 Sep 2019 23:30:51 +0000 (00:30 +0100)]
Add CodeDom.CodeValidator tests and fix some bugs (dotnet/corefx#39585)
* Add CodeDom.CodeValidator tests and fix some bugs
* Fix netfx tests
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
50e8db3cabbfb6ad0fc0702b3db25491a95c72a5
Steve Harter [Mon, 9 Sep 2019 21:55:47 +0000 (16:55 -0500)]
Minor deserialization perf improvements for collections (dotnet/corefx#40889)
Commit migrated from https://github.com/dotnet/corefx/commit/
27ddbe99ccc32122141b81045ac670c3a0d1a45a
Katarzyna Bułat [Mon, 9 Sep 2019 21:53:38 +0000 (14:53 -0700)]
Writable JSON API changes (dotnet/corefx#40673)
* implicit operators moved to JsonNode
* JsonNull introduced
* JsonObject rewritten to use JsonObjectProperty
* JsonElement.ObjectEnumerator changed to use _current instead of _enumerator
* iterative DeepCopy implemented
* code reorganized
* parse implemented
* JsonDocumentOptions added to JsonNode.Parse
* WriteTo and ToJsonString added
* specification adjusted
* string comparison added
* JsosReadonlyDomWriteTests reused
* code coverage improved
* minor other fixes
* review comments included
Commit migrated from https://github.com/dotnet/corefx/commit/
37b37395481b635c15eaa3454e52b72ab91de4ef
Stephen Toub [Mon, 9 Sep 2019 21:47:36 +0000 (17:47 -0400)]
Allow more of ConsolePal to be linked away (dotnet/corefx#40944)
If an app just uses Console.Write*, it's currently still pulling in support for stdin and stderr, because of the GetUseFileAPIs choke point.
Commit migrated from https://github.com/dotnet/corefx/commit/
d733b29ce6fccd7e64bc351e97cce68a9b91bb17
Ahson Khan [Mon, 9 Sep 2019 21:26:54 +0000 (14:26 -0700)]
Use ThrowHelper in Utf8JsonReader.GetGuid so that the deserializer can catch the exception and re-throw JsonException. (dotnet/corefx#40938)
* Use ThrowHelper in Utf8JsonReader.GetGuid so that the deserializer can
catch the exception and re-throw JsonException.
* Fix the typo in the enum used and added more test cases.
Commit migrated from https://github.com/dotnet/corefx/commit/
5bec8c841ec0ab366a99361bc9d4540022e7fa02
Stephen Toub [Mon, 9 Sep 2019 20:44:56 +0000 (16:44 -0400)]
Replace HashHelpers.Combine with HashCode.Combine in netcoreapp projects (dotnet/corefx#40935)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c221ca346b64e1e80ab4bde240b0f479bd203fc
Jan Kotas [Mon, 9 Sep 2019 18:21:50 +0000 (11:21 -0700)]
Mark System.Data.SqlClient as archived component (dotnet/corefx#40946)
Commit migrated from https://github.com/dotnet/corefx/commit/
f5574287ee7e9ef785ee6849bad7916871bebd81
Viktor Hofer [Mon, 9 Sep 2019 16:21:25 +0000 (18:21 +0200)]
Remove ProjectGUIDs from project files and Project and Name attributes from P2Ps (dotnet/corefx#40926)
* Remove ProjectGUIDs from P2Ps
* Remove ProjectGUIDs from project files
Commit migrated from https://github.com/dotnet/corefx/commit/
c22714d65151968a17c3b232748880d5e7961dee
itrofimow [Mon, 9 Sep 2019 14:27:44 +0000 (17:27 +0300)]
fix of a minor typo in System.Threading.Channels.ChannelReader docs (dotnet/corefx#40943)
Commit migrated from https://github.com/dotnet/corefx/commit/
061d05b8df6295a9253d2bae423d89538a3b9132
Hugh Bellamy [Mon, 9 Sep 2019 02:54:57 +0000 (03:54 +0100)]
Add tests relating to TypeDescriptor (dotnet/corefx#38938)
Commit migrated from https://github.com/dotnet/corefx/commit/
cc51975a897cb803f1ad76b6b93b2ebd4581bca4
Hugh Bellamy [Mon, 9 Sep 2019 02:18:22 +0000 (03:18 +0100)]
Cleanup drawing primitives (dotnet/corefx#40019)
Commit migrated from https://github.com/dotnet/corefx/commit/
5bc243aa2040a1dbf63df1dd099124ade64ed5ce
Hugh Bellamy [Mon, 9 Sep 2019 00:40:26 +0000 (01:40 +0100)]
Add more TypeConverter tests (dotnet/corefx#38945)
* Add more TypeConverter tests
* Add more ReferenceConverter tests and fix bugs
Commit migrated from https://github.com/dotnet/corefx/commit/
ae987068bb07d7b8af458874d74714083a84618c
Viktor Hofer [Sun, 8 Sep 2019 12:52:08 +0000 (14:52 +0200)]
Disable OSX.1013.Amd64.Open in CI (dotnet/corefx#40927)
Commit migrated from https://github.com/dotnet/corefx/commit/
f0d5faf69b832646240b1b30797587ab35ffd03b
Viktor Hofer [Sun, 8 Sep 2019 11:24:35 +0000 (13:24 +0200)]
Increase helix timeout on Windows clients (dotnet/corefx#40913)
* Increase helix timeout on Windows clients
Depending on the ARM64 windows queue utilization, clients sometimes take longer than the current timeout. Increasing temporarily until the queue has more machines.
* Update windows.yml
* Update windows.yml
Commit migrated from https://github.com/dotnet/corefx/commit/
ba5b90b95269548f8011e36e13b7f58acb62b4b8
Santiago Fernandez Madero [Sat, 7 Sep 2019 14:54:58 +0000 (07:54 -0700)]
Add missing dummy primitive to ReadOnlySequence<T>.Enumerator (dotnet/corefx#40910)
Commit migrated from https://github.com/dotnet/corefx/commit/
59c6b1ab96aa2e99ed6ecb33a8bcf9283ce1ea27
Anirudh Agnihotry [Sat, 7 Sep 2019 01:50:05 +0000 (18:50 -0700)]
Remove Redundant dependency of microsoft.netcoreapp.platforms (dotnet/corefx#40907)
* remove extra dependency
* removing microsoft.netcore.targets
Commit migrated from https://github.com/dotnet/corefx/commit/
9e8d47c6e548dcacd71cb83133bbf49f74be90ac
Santiago Fernandez Madero [Fri, 6 Sep 2019 21:56:56 +0000 (14:56 -0700)]
Disable ToolboxBitmatAttribute test in netfx (dotnet/corefx#40901)
Commit migrated from https://github.com/dotnet/corefx/commit/
937e7d6d7eb6f1413aa48d14961d8f0c8a061e0e
Stephen Toub [Fri, 6 Sep 2019 19:45:09 +0000 (15:45 -0400)]
Fix Select.Count bug that iterates twice (dotnet/corefx#40718)
* Add System.Linq tests to validate enumerator lifecycle
* Fix bug with Select(...).Count() on an IPartition
It currently ends up potentially enumerating the source twice.
* Remove unnecessary source inputs in lifecycle tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8455fd2d9bd46fc8b97fe86f907d2a8ae748443f
Viktor Hofer [Fri, 6 Sep 2019 19:06:28 +0000 (21:06 +0200)]
Remove misleading test condition variable for registry (dotnet/corefx#40887)
Commit migrated from https://github.com/dotnet/corefx/commit/
d88152f91a5b08534873868afe93ddc3c840f76f
Viktor Hofer [Fri, 6 Sep 2019 19:04:52 +0000 (21:04 +0200)]
Disable two flaky EventLog tests (dotnet/corefx#40876)
Commit migrated from https://github.com/dotnet/corefx/commit/
9d5b200c6088d9dc038c64ec051596170731dbab
Stephen Toub [Fri, 6 Sep 2019 19:04:17 +0000 (15:04 -0400)]
Make "remote" more CultureInfo.CurrentCulture setting tests (dotnet/corefx#40891)
Commit migrated from https://github.com/dotnet/corefx/commit/
002d62b53343ae9b24310681c349913b97d30202
Viktor Hofer [Fri, 6 Sep 2019 16:42:03 +0000 (18:42 +0200)]
Disable two networking tests on UAP (dotnet/corefx#40875)
* Disable timeout sensitive networking test on UAP
Disabling GetAsync_CancelPendingRequests_DoesntCancelReadAsyncOnResponseStream on UAP
* Update HttpClientHandlerTest.Cancellation.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
9161098ade5075a8c126b2d7eb98abbeadff2961
Stephen Toub [Fri, 6 Sep 2019 16:19:02 +0000 (12:19 -0400)]
Fix some low-hanging fruit boxing in JsonSerializer (dotnet/corefx#40867)
It's boxing lots of dictionary enumerators and KeyValuePairs. Stop doing that.
Commit migrated from https://github.com/dotnet/corefx/commit/
447f76f251d72a6d5e9bc102523937d05f929095
Michal Strehovský [Fri, 6 Sep 2019 15:51:56 +0000 (17:51 +0200)]
Add license header to S.R.CS.Unsafe (dotnet/corefx#40886)
Commit migrated from https://github.com/dotnet/corefx/commit/
b42c65ee76c35a63124a6b8e887bbd25c0d263df
Tomas Weinfurt [Fri, 6 Sep 2019 04:27:05 +0000 (21:27 -0700)]
use type for Http2LoopbackServer.CreateServer (dotnet/corefx#40863)
Commit migrated from https://github.com/dotnet/corefx/commit/
b46ebcb9a2408f9826c103ce6b340b419d948512
Tomas Weinfurt [Thu, 5 Sep 2019 23:49:16 +0000 (16:49 -0700)]
update SendAsync_ConcurentSendReceive_Ok to use DuplexContent (dotnet/corefx#40858)
Commit migrated from https://github.com/dotnet/corefx/commit/
88017f967529d30272ad75028e5538f35087e451
Steve Harter [Thu, 5 Sep 2019 22:45:41 +0000 (17:45 -0500)]
Address a couple non-functional nits (dotnet/corefx#40854)
Commit migrated from https://github.com/dotnet/corefx/commit/
4390a665c2fe082007f6bd25be0e055307ee5573
Stephen Toub [Thu, 5 Sep 2019 20:51:34 +0000 (16:51 -0400)]
Allow NetworkStream.WriteAsync calls to be canceled asynchronously (dotnet/corefx#40839)
In 3.0 we added the necessary support for this, and for Socket.WriteAsync calls we're appropriately passing the CancellationToken through, but we missed doing so for NetworkStream.WriteAsync, which takes a slightly different code path through AwaitableSocketAsyncEventArgs.
Commit migrated from https://github.com/dotnet/corefx/commit/
0a5b9286854c8bbb10677d730b0fe25425da562c
Jose Perez Rodriguez [Thu, 5 Sep 2019 18:57:18 +0000 (11:57 -0700)]
Update Stable Version info on package index (dotnet/corefx#40780)
* Upate Stable Version info on package index
* Re-adding back package version which was unlisted
Commit migrated from https://github.com/dotnet/corefx/commit/
95c10ccf3f17e35339070a5ecacdc44366585643
Hugh Bellamy [Thu, 5 Sep 2019 18:21:59 +0000 (19:21 +0100)]
Fix TypeConverter for IComponent (dotnet/corefx#40837)
Commit migrated from https://github.com/dotnet/corefx/commit/
3cc18081e24acdcfe7db737400a2dc702e314395
Adeel Mujahid [Thu, 5 Sep 2019 14:45:49 +0000 (17:45 +0300)]
Raise JsonException when PolicyProperty is null (dotnet/corefx#40501)
Commit migrated from https://github.com/dotnet/corefx/commit/
5dbbdfa0f924f02754a464d492a2116ad9f5752b
Steve Harter [Thu, 5 Sep 2019 14:41:47 +0000 (09:41 -0500)]
Use options.Encoder when serializing dictionary keys and property names (dotnet/corefx#40787)
Commit migrated from https://github.com/dotnet/corefx/commit/
7829d4acc8303a42e222415c7eb829fc3f8264cc
Carlos Sanchez Lopez [Thu, 5 Sep 2019 12:49:13 +0000 (05:49 -0700)]
Match src param name of BrotliEncoder.GetMaxCompressedLength to ref param name (dotnet/corefx#40822)
* Make the name of the parameter in the BrotliEncoder.GetMaxCompressedLength src match the name of the parameter in the ref.
* Update unit test validating parameter name.
Commit migrated from https://github.com/dotnet/corefx/commit/
c668e96cb0886d13a051d8021a3c3147e7daa15c
Cory Nelson [Thu, 5 Sep 2019 09:11:47 +0000 (02:11 -0700)]
Support PAC scripts that return multiple proxies (dotnet/corefx#40082)
* Support PAC scripts that return multiple proxies.
Resolves dotnet/corefx#39370
Commit migrated from https://github.com/dotnet/corefx/commit/
5e97c2b50ac2b18909606ce3ea14c3e7e61db7e8
Stephen Toub [Thu, 5 Sep 2019 01:03:34 +0000 (21:03 -0400)]
Reduce number of PFX loads in System.Net tests (dotnet/corefx#40821)
* Reduce number of PFX loads in System.Net tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
838832e2ecac9f81b5a5649bfac2fc835db76c1e
Wraith2 [Wed, 4 Sep 2019 23:52:07 +0000 (00:52 +0100)]
Fix | SqlClient fix for managed encryption connection failure (dotnet/corefx#40732)
Commit migrated from https://github.com/dotnet/corefx/commit/
30decee8aa72ce93eec0394e94f05a86cec7ab9d
Tomas Weinfurt [Wed, 4 Sep 2019 23:48:34 +0000 (16:48 -0700)]
fix more tests to work with http2 (dotnet/corefx#39019)
* fix cancelation tests to work with http2
* fix more tests and feedback from review
* feedback from review
* fix issues with missing connection: close
* update body check
* feedback from review
* fix resolve
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
5108d9245b891deeb36a164f434f4fb6975c8baf
Ahson Khan [Wed, 4 Sep 2019 23:01:41 +0000 (16:01 -0700)]
Add round-trip test to JsonSerializer with overflow that needs to be escaped. (dotnet/corefx#40793)
* Add round-trip test to JsonSerializer with overflow that needs to be
escaped.
* Used escaped property names and add a test for serializer/writer
interop.
Commit migrated from https://github.com/dotnet/corefx/commit/
76031d2f8ed714b54e0e7bbd7020f111b6c9c023
Stephen Toub [Wed, 4 Sep 2019 21:46:09 +0000 (17:46 -0400)]
Remove `readonly` from two `GCHandle` fields (dotnet/corefx#40807)
Due to the `readonly`, the mutations performed by `Free` will be done on a copy rather than on the data stored in the field.
Commit migrated from https://github.com/dotnet/corefx/commit/
437ce88edeb835e1dbe94c6d418b6169b69745fb
Stephen Toub [Wed, 4 Sep 2019 17:56:14 +0000 (13:56 -0400)]
Delete Box.cs from System.Threading.Tasks.Parallel (dotnet/corefx#40808)
We can just use `StrongBox<T>`.
Commit migrated from https://github.com/dotnet/corefx/commit/
0b572f1a7ec2f691a424d0c6dd403e11191ca8c5
Stephen Toub [Wed, 4 Sep 2019 16:24:03 +0000 (12:24 -0400)]
Remove reflection from ThreadPoolHelpers test class (dotnet/corefx#40810)
Commit migrated from https://github.com/dotnet/corefx/commit/
c9a124635dbfc0ec3958f06093cd5196b00b47b1
Stephen Toub [Wed, 4 Sep 2019 14:33:35 +0000 (10:33 -0400)]
Disable FileSystemWatcher_File_Create_ForceLoopRestart test (dotnet/corefx#40804)
Commit migrated from https://github.com/dotnet/corefx/commit/
aea8a56edf54228029b0f9ddf369e4d4f82f4446
Stephen Toub [Wed, 4 Sep 2019 14:33:13 +0000 (10:33 -0400)]
Move wildcard bind in Socket.ConnectAsync to be Windows-only (dotnet/corefx#40767)
* Move wildcard bind in Socket.ConnectAsync to be Windows-only
It's necessary to use ConnectEx; it's not necessary on Unix.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8a1fc9d6b3c9b85a881e220a9f9193b72c0e801b
Ahson Khan [Wed, 4 Sep 2019 05:24:28 +0000 (22:24 -0700)]
Fix the max token size threshold to correctly compute to 125MB for Base64 bytes. (dotnet/corefx#40792)
* Fix the max token size threshold to correctly compute to 125MB for
Base64 bytes.
* Rename constant to fix transpose error: Base46 -> Base64
* Enable the outerloop tests for windows and osx only and update to use
platform specific new line.
Commit migrated from https://github.com/dotnet/corefx/commit/
1511f723f7adfe82cef72460df45dc4422d303c6
Stephen Toub [Wed, 4 Sep 2019 04:04:25 +0000 (00:04 -0400)]
Disable XML crypto test failing on Windows 10 (dotnet/corefx#40775)
Commit migrated from https://github.com/dotnet/corefx/commit/
70b4d01e18236c925c2d44d49fff7cbb4919dc43
Stephen Toub [Wed, 4 Sep 2019 03:51:50 +0000 (23:51 -0400)]
Fix several recently added StyleCop tuple rules (dotnet/corefx#40794)
Commit migrated from https://github.com/dotnet/corefx/commit/
06007cdedee9cfb096d884016a99e3a64bdccb45
Liudmila Molkova [Wed, 4 Sep 2019 03:26:05 +0000 (20:26 -0700)]
DiagnosticSource Stop event was not reported in W3C mode by HttpHandlerDiagnosticListener on netfx (dotnet/corefx#40777)
Commit migrated from https://github.com/dotnet/corefx/commit/
687a84008e6c532584199305a75ec53e4e1f1c74
Tomas Weinfurt [Wed, 4 Sep 2019 02:34:24 +0000 (19:34 -0700)]
replace CRLF with Environment.NewLine where appropriate (dotnet/corefx#40723)
* replace CRLF with Environment.NewLine where appropriate
* use sb.AppendLine
* fix more unit tests
Commit migrated from https://github.com/dotnet/corefx/commit/
a6e7ffd72db078a46612afa9d085bd27ef8e2fed
Tomas Weinfurt [Wed, 4 Sep 2019 02:11:43 +0000 (19:11 -0700)]
surface _abortException (dotnet/corefx#40785)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc7e561e28839c56f7465f3382d5f60716a34bab
Ryan Lucia [Wed, 4 Sep 2019 02:05:17 +0000 (22:05 -0400)]
Add case-sensitive type lookup test to ActivatorTests (dotnet/corefx#40788)
Commit migrated from https://github.com/dotnet/corefx/commit/
ffe957980a1c33217d2fca68bb473029f37568e4
Jeremy Barton [Tue, 3 Sep 2019 22:59:24 +0000 (15:59 -0700)]
Fix JsonElement.WriteTo handling of escaped property names (dotnet/corefx#40784)
This removes the duplicate switch statement from writing properties,
as the usage of the new WritePropertyName API on the writer simplifies the logic here.
Commit migrated from https://github.com/dotnet/corefx/commit/
2d2abb32db879c877e14310c892faeeef756e27d
Cory Nelson [Tue, 3 Sep 2019 22:23:36 +0000 (15:23 -0700)]
Revert "set _requestQueueBoundHandle to null after disposing" (dotnet/corefx#40783)
* Revert "set _requestQueueBoundHandle to null after disposing (dotnet/corefx#40466)", but keep tests around (disabled re: 39552)
This reverts commit dotnet/corefx@
40949c48e1a24a735452248294c983609c77a26c.
Commit migrated from https://github.com/dotnet/corefx/commit/
7a668f4f13b962a20a4585fffadbf537d5ebf570
Stephen Toub [Tue, 3 Sep 2019 22:07:33 +0000 (18:07 -0400)]
Update analyzer versions (dotnet/corefx#40778)
In particular to pick up StyleCop fixes related to C# 8 and nullability.
Commit migrated from https://github.com/dotnet/corefx/commit/
1bf90840626cd2e7b19377bd6a16b17de0e6e672
Brian Robbins [Fri, 30 Aug 2019 23:31:37 +0000 (16:31 -0700)]
Add the DebuggableAttribute to System.Runtime.CompilerServices.Unsafe.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9c848d6ad5415c1fa844f5403ea8ef78c408f9a
Stephen Toub [Tue, 3 Sep 2019 19:24:08 +0000 (15:24 -0400)]
Pass a CancellationToken in a few more places (dotnet/corefx#40715)
Most of these to WaitAsync shouldn't actually matter, as the semaphores being used are there for corner cases or to protect erroneous usage, but if there's no contention, passing a token won't hurt, and if there is contention, passing the token makes it more robust.
Commit migrated from https://github.com/dotnet/corefx/commit/
14a7adb23569363b94d575d64b7cb1f38cda3e4a
Tom Deseyn [Tue, 3 Sep 2019 19:12:23 +0000 (21:12 +0200)]
Fix regression in TCPClient behavior when Disposed/Client set to null (dotnet/corefx#40769)
Commit migrated from https://github.com/dotnet/corefx/commit/
e0a6f2b7b11afc2be10a535477910524d9fee834
Stephen Toub [Tue, 3 Sep 2019 15:21:35 +0000 (11:21 -0400)]
Disable a couple S.S.Cryptography.Algorithms tests deterministically failing locally
Commit migrated from https://github.com/dotnet/corefx/commit/
a533a0fad2c101881945824570dc21845783366a
Stephen Toub [Tue, 3 Sep 2019 09:39:43 +0000 (05:39 -0400)]
Disable RsaDecryptPkcs1LeadingZero test failing on some Windows (dotnet/corefx#40760)
Commit migrated from https://github.com/dotnet/corefx/commit/
5b2c6b7d286265d3bdaddb8445c1bbf3d9141461
Stephen Toub [Tue, 3 Sep 2019 01:59:05 +0000 (21:59 -0400)]
Consolidate / cleanup disposal checks in System.Net.Sockets (dotnet/corefx#40757)
Commit migrated from https://github.com/dotnet/corefx/commit/
b2412774416fc177cf5daa025bb4644a0a91c2df
Viktor Hofer [Tue, 3 Sep 2019 01:56:31 +0000 (03:56 +0200)]
Disable flaky PrintPage test (dotnet/corefx#40754)
Commit migrated from https://github.com/dotnet/corefx/commit/
b059630fc9139d0c940b2f0f249ff702a7b6250f
Viktor Hofer [Mon, 2 Sep 2019 20:48:05 +0000 (22:48 +0200)]
Retry eventlog deletion in tests on all platforms (dotnet/corefx#40743)
* Retry deleting eventlog on all platforms
* Remove OS differentiation
Commit migrated from https://github.com/dotnet/corefx/commit/
8c041484dda3059bd4adebebda939a15ee4a087d
Stephen Toub [Mon, 2 Sep 2019 15:05:50 +0000 (11:05 -0400)]
Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
74708406b04b3d0946d53259ddbc93159ac90a24
Stephen Toub [Mon, 2 Sep 2019 14:22:58 +0000 (10:22 -0400)]
Delete duplicate line after LINQ nullable changes (dotnet/corefx#40746)
This line was moved into the ctor and should have been deleted from here, too. Addresses post-merge PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
71c669e918a5f4e48f09a697e9dd147f7dc31480
Viktor Hofer [Mon, 2 Sep 2019 11:58:38 +0000 (13:58 +0200)]
Disable TimerElapsedSignaled (dotnet/corefx#40742)
https://github.com/dotnet/corefx/issues/29166
Commit migrated from https://github.com/dotnet/corefx/commit/
a44c40809c43d29ab3d42d5e6a7d8ad1b65a4fe6
Viktor Hofer [Mon, 2 Sep 2019 07:55:24 +0000 (09:55 +0200)]
Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
1d994feb73fcf57161e5bded92119c0d1b147616
Viktor Hofer [Mon, 2 Sep 2019 07:51:00 +0000 (09:51 +0200)]
Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
49e2b4955ff83acc4b19b503709bd1e56f409871
Viktor Hofer [Sun, 1 Sep 2019 18:47:16 +0000 (20:47 +0200)]
Create pull-request-policy.md (dotnet/corefx#40701)
* Create pull-request-validation.md
* Update pull-request-validation.md
* Update pull-request-validation.md
* Update pull-request-validation.md
* Update pull-request-validation.md
* Rename pull-request-validation.md to pull-request-policy.md
* Update pull-request-policy.md
Commit migrated from https://github.com/dotnet/corefx/commit/
e2a3e98ee0ae608783906c3a352be27bf7e437b6
Next Turn [Sun, 1 Sep 2019 14:59:18 +0000 (22:59 +0800)]
Simplify BitArray enumerator (dotnet/corefx#40735)
Commit migrated from https://github.com/dotnet/corefx/commit/
130d8582e4973bbdb55ae737b942d214ad3c6570
Eric Erhardt [Sat, 31 Aug 2019 14:19:10 +0000 (09:19 -0500)]
Add tests for round trip serializing TimeZoneInfos. (dotnet/corefx#40637)
Fix dotnet/corefx#40578
Commit migrated from https://github.com/dotnet/corefx/commit/
75a591d4e5606c49f00e187ea2f5ba694d712523
Jose Perez Rodriguez [Sat, 31 Aug 2019 07:08:36 +0000 (00:08 -0700)]
Add harvest validation logic to the all configurations tests (dotnet/corefx#40717)
Commit migrated from https://github.com/dotnet/corefx/commit/
2c974d484209ab46815ec9abd35936ca66f2444e
Charles Stoner [Sat, 31 Aug 2019 01:38:32 +0000 (18:38 -0700)]
Skip tests on Arm (dotnet/corefx#40716)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1974096f6e02099a7e4d030ce0dd903574dd24e
Stephen Toub [Fri, 30 Aug 2019 22:10:37 +0000 (18:10 -0400)]
Annotate System.Threading.Channels for nullable reference types (dotnet/corefx#40653)
Commit migrated from https://github.com/dotnet/corefx/commit/
60e5e452977d0c51bd8c20e6c390f47333ad85b9
Tarek Mahmoud Sayed [Fri, 30 Aug 2019 21:56:24 +0000 (14:56 -0700)]
Tests for abbdrivated genitive month names parsing (dotnet/corefx#40595)
Commit migrated from https://github.com/dotnet/corefx/commit/
e62f9b61785a340a4a73182c2e228d6ef409dec4
Viktor Hofer [Fri, 30 Aug 2019 21:37:04 +0000 (23:37 +0200)]
Disable TestZeroTimeout hanging test (dotnet/corefx#40713)
In response to https://github.com/dotnet/corefx/issues/40711
Commit migrated from https://github.com/dotnet/corefx/commit/
5fef8a05c2ba51b614dbc2d5350fc3cc0e8541b4
Eirik Tsarpalis [Fri, 30 Aug 2019 21:14:49 +0000 (23:14 +0200)]
Httpstress: Add more checksum validations & expose Kestrel Http2 limits configuration (dotnet/corefx#40708)
Httpstress: Add more checksum validations & expose Kestrel Http2 limits configuration
Commit migrated from https://github.com/dotnet/corefx/commit/
a64e40535283d6470c2909c8f08b178454a8718b
Stephen Toub [Fri, 30 Aug 2019 20:49:29 +0000 (16:49 -0400)]
Annotate System.Linq for nullable reference types (dotnet/corefx#40651)
Commit migrated from https://github.com/dotnet/corefx/commit/
fe969a5893b845c0ba4550d828894c49745f456f
Benjamin Bartels [Fri, 30 Aug 2019 20:48:45 +0000 (21:48 +0100)]
Fixed missing Dispose call on Union on empty enumerable (dotnet/corefx#40384)
Commit migrated from https://github.com/dotnet/corefx/commit/
e78caf82ce13b6e1d1359cc239bf0535943cc386
Stephen Toub [Fri, 30 Aug 2019 19:23:38 +0000 (15:23 -0400)]
Annotate Microsoft.Win32.Primitives for nullable reference types (dotnet/corefx#40652)
Commit migrated from https://github.com/dotnet/corefx/commit/
70d2b62dcfd328228f8ea6754faae0ed3b69ff37
Stephen Toub [Fri, 30 Aug 2019 18:44:22 +0000 (14:44 -0400)]
Test for ArrayPool.Create allocating cleared arrays (dotnet/corefx#40592)
Commit migrated from https://github.com/dotnet/corefx/commit/
eeca0c2c0876919a9029cfdc371070bba84da02b
Jan Kotas [Fri, 30 Aug 2019 15:36:01 +0000 (08:36 -0700)]
Tests for Read_CharArrayTest reading more than necessary (dotnet/corefx#40521)
* Tests for Read_CharArrayTest reading more than necessary
* Update src/System.IO/tests/BinaryReader/BinaryReaderTests.cs
Co-Authored-By: Stephen Toub <stoub@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/
a192823a84145546be747cc520625062fe6cb5a8
Viktor Hofer [Fri, 30 Aug 2019 14:55:22 +0000 (16:55 +0200)]
Limit precision checks in arm/64 (dotnet/corefx#40696)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e01a780a8a5bc61332c8d743e8516c15bbbb293
Ben Adams [Fri, 30 Aug 2019 13:32:32 +0000 (14:32 +0100)]
Net.Http Use span.SequenceEqual rather than custom EqualsOrdinal (dotnet/corefx#40694)
* Net.Http Use span.SequenceEqual rather than custom EqualsOrdinal
* Fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
d3cd1d05357d3c5f756a89d9800af6ef91dd8efe
Viktor Hofer [Fri, 30 Aug 2019 13:31:38 +0000 (15:31 +0200)]
Ignore casing in servicename tests on nano server (dotnet/corefx#40699)
Commit migrated from https://github.com/dotnet/corefx/commit/
0c650b2765f64186f2fe84e332d8a74108866db2
Viktor Hofer [Fri, 30 Aug 2019 08:34:54 +0000 (10:34 +0200)]
Update pullrequest-builds.md
Commit migrated from https://github.com/dotnet/corefx/commit/
261b2cdc260bc94967a8af6666831739d91ceb96