platform/upstream/efl.git
4 years agoefl/arrangement: mark content_padding beta
Mike Blumenkrantz [Wed, 25 Sep 2019 11:22:34 +0000 (13:22 +0200)]
efl/arrangement: mark content_padding beta

Summary:
this still potentially needs some work and changing the implementations
now would be too invasive

ref T7864

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7864

Differential Revision: https://phab.enlightenment.org/D10149

4 years agoevas_callbacks: check if obj is NULL before using it
Shinwoo Kim [Wed, 25 Sep 2019 10:53:53 +0000 (06:53 -0400)]
evas_callbacks: check if obj is NULL before using it

Summary:
evas_object_callbacks_finalized could take NULL obj because
_efl_canvas_object_efl_object_finalize could call it with NULL obj.

Reviewers: bu5hm4n, jsuya, Hermet

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10141

4 years agoefl_ui_spin_button: mark "direct_text_input" property @beta
WooHyun Jung [Wed, 25 Sep 2019 10:53:51 +0000 (06:53 -0400)]
efl_ui_spin_button: mark "direct_text_input" property @beta

Summary:
After making efl_ui_text interface be stabilized, this property
can be considered again about its opening.

ref T8097

Reviewers: zmike, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8097

Differential Revision: https://phab.enlightenment.org/D10140

4 years agoefl_ui_layout: fix null pointer dereferences
Yeongjong Lee [Wed, 25 Sep 2019 10:44:56 +0000 (06:44 -0400)]
efl_ui_layout: fix null pointer dereferences

Summary: If theme doesn't have version data, `version` can be NULL.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10146

4 years agodocs: formatting nitpick in Efl.Player.eo
Xavi Artigas [Wed, 25 Sep 2019 10:33:24 +0000 (12:33 +0200)]
docs: formatting nitpick in Efl.Player.eo

4 years agorelease: Update NEWS and bump version for 1.23.0-beta3 release
Stefan Schmidt [Wed, 25 Sep 2019 09:13:32 +0000 (11:13 +0200)]
release: Update NEWS and bump version for 1.23.0-beta3 release

4 years agoefl/image: remove load_controller events
Mike Blumenkrantz [Tue, 24 Sep 2019 20:38:04 +0000 (16:38 -0400)]
efl/image: remove load_controller events

these aren't implemented by anything and duplicate the functionality provided
by efl.gfx.image::image,preload_state,changed

ref T7876

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10128

4 years agoefl_ui : put beta on range select/unselect as parameter unstable
SangHyeon Jade Lee [Wed, 25 Sep 2019 07:50:06 +0000 (07:50 +0000)]
efl_ui : put beta on range select/unselect as parameter unstable

there are more discussion need on this range selection.
we could extend this parameter with range structure(aka Eina.Range)
so that extendable object to object, int to int, Range to Range.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10145

4 years agoefl_ui_win: default window type change should not be applied to legacy one
WooHyun Jung [Wed, 25 Sep 2019 05:18:04 +0000 (05:18 +0000)]
efl_ui_win: default window type change should not be applied to legacy one

If my understanding is correct, below referenced commit needs to be applied to
efl_ui_win only.

@ref D10049

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10143

4 years agoefl_ui : reverse the select method name to be ended verb on the last.
SangHyeon Jade Lee [Wed, 25 Sep 2019 07:39:30 +0000 (16:39 +0900)]
efl_ui : reverse the select method name to be ended verb on the last.

Summary:
our new method naming rule only allow verb at the last position,
so change name to fallow rule.

Reviewers: bu5hm4n, cedric, segfaultxavi

Reviewed By: bu5hm4n, segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10144

4 years agoapi: mark Efl.Player stable
Mike Blumenkrantz [Tue, 24 Sep 2019 20:53:49 +0000 (16:53 -0400)]
api: mark Efl.Player stable

fix T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10127

4 years agoefl_ui/image: implement efl.player::playback_speed methods
Mike Blumenkrantz [Tue, 24 Sep 2019 19:43:00 +0000 (15:43 -0400)]
efl_ui/image: implement efl.player::playback_speed methods

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10121

4 years agoefl_ui/image: implement efl.player::playback_progress method
Mike Blumenkrantz [Tue, 24 Sep 2019 19:30:11 +0000 (15:30 -0400)]
efl_ui/image: implement efl.player::playback_progress method

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10120

4 years agoefl_ui/image: implement required efl.player::playback_position methods
Mike Blumenkrantz [Tue, 24 Sep 2019 19:27:24 +0000 (15:27 -0400)]
efl_ui/image: implement required efl.player::playback_position methods

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10119

4 years agoefl/player: improve docs
Mike Blumenkrantz [Tue, 24 Sep 2019 18:21:29 +0000 (14:21 -0400)]
efl/player: improve docs

some doc improvements

ref T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10117

4 years agoefl/player: progress -> playback_progress
Mike Blumenkrantz [Tue, 24 Sep 2019 18:21:04 +0000 (14:21 -0400)]
efl/player: progress -> playback_progress

no functional changes

ref T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10116

4 years agoefl/player: play_speed -> playback_speed
Mike Blumenkrantz [Tue, 24 Sep 2019 18:16:13 +0000 (14:16 -0400)]
efl/player: play_speed -> playback_speed

no functional changes

ref T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10115

4 years agoefl/player: rename 'play' property to 'pause'
Mike Blumenkrantz [Tue, 24 Sep 2019 15:18:57 +0000 (11:18 -0400)]
efl/player: rename 'play' property to 'pause'

this is a bit of an overhaul wherein the existing 'play' mechanics are
all inverted. 'pause' is a state which stops playback but does not affect
the playback_position property.

this patch also includes implementations of Efl.Player::playing for
a couple classes which (now) only implement pause, as this is a requirement
for the objects to actually activate their animations

test cases:
* unit tests
* all elm_test animation cases
* elm_test video
* rage

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10114

4 years agoefl/player: merge start+stop methods into 'playing' property
Mike Blumenkrantz [Tue, 24 Sep 2019 14:11:26 +0000 (10:11 -0400)]
efl/player: merge start+stop methods into 'playing' property

this has some overlap with the existing 'play' property which will
soon be renamed. the intent here is that there is a property for
controlling the 'playing' state and then another property for managing
'pausing' the play state

ref T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10113

4 years agoefl/player: pos -> playback_position
Mike Blumenkrantz [Tue, 24 Sep 2019 14:02:54 +0000 (10:02 -0400)]
efl/player: pos -> playback_position

ref T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10112

4 years agoefl/player: prune properties duplicated in efl.playable
Mike Blumenkrantz [Tue, 24 Sep 2019 13:39:21 +0000 (09:39 -0400)]
efl/player: prune properties duplicated in efl.playable

efl.playable implements a number of properties which are also present
in efl.player. playable was intended to be separate, so enforce this
split in all classes which use player

ref T7877

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10109

4 years agoelm_object: revert deferred sizing_eval to keep backward compatibility 75/214675/2
Yeongjong Lee [Wed, 25 Sep 2019 06:59:23 +0000 (15:59 +0900)]
elm_object: revert deferred sizing_eval to keep backward compatibility

If legacy widget that override `efl_canvas_group_calculate` call
`elm_layout_sizing_eval`, the overridden function
`_xxx_efl_canvas_group_group_calculate` is called.

This reverts commit 29270c6861f999fae438b650e009dd9c706b4015.
This reverts commit 29270c6861f999fae438b650e009dd9c706b4015.

@tizen_fix

Change-Id: Ib3efae3ad057ac166309414aff8dc3ba44247b49

4 years agoslider: delete unnecessary tizen only code 68/214668/1
Hosang Kim [Wed, 25 Sep 2019 06:21:07 +0000 (15:21 +0900)]
slider: delete unnecessary tizen only code

Change-Id: If34391956a8b81a2b7d2b57fa0759919b7a4ab59

4 years agoRevert "efl_canvas_object: set default value to false for not breaking compatibility" 24/214624/1
WooHyun Jung [Tue, 24 Sep 2019 22:14:29 +0000 (07:14 +0900)]
Revert "efl_canvas_object: set default value to false for not breaking compatibility"

This reverts commit 5d4c3446016a97622aae0c03c9a4d423c1f1e41d.

This was commit only for Tizen and it was fixed by upstream properly.
So, reverting this commit is right process.

Change-Id: I1fd2631e06ae76050e9b124d64f9d049124800d5

4 years agoefl_ui/spin_button: fix signal namespacing submit/tizen/20190924.220547
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:58 +0000 (17:02 -0400)]
efl_ui/spin_button: fix signal namespacing

Summary:
efl,anim,activate is the signal used by buttons, which is what this is

ref T8231

Depends on D10099

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10100

4 years agoefl_ui/timepicker: rename and namespace visibility signals
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:52 +0000 (17:02 -0400)]
efl_ui/timepicker: rename and namespace visibility signals

Summary:
this is consistent with efl api 'visible' property

ref T8231

Depends on D10098

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10099

4 years agoefl_ui/scroller: remove unused "looping" signals
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:46 +0000 (17:02 -0400)]
efl_ui/scroller: remove unused "looping" signals

Summary:
this feature is not implemented

revert this patch to restore signal handling when the corresponding
features are implemented by widgets

ref T8231

Depends on D10097

Reviewers: cedric

Reviewed By: cedric

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10098

4 years agoefl_ui/focus: rename focus visibility signals
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:40 +0000 (17:02 -0400)]
efl_ui/focus: rename focus visibility signals

Summary:
this is consistent with efl api 'visible' property

ref T8231

Depends on D10096

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10097

4 years agoefl_ui/scroller: rename bar visibility signals
Mike Blumenkrantz [Tue, 24 Sep 2019 21:02:34 +0000 (17:02 -0400)]
efl_ui/scroller: rename bar visibility signals

Summary:
this is consistent with efl api 'visible' property

ref T8231

Depends on D10095

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10096

4 years agoefl_ui/alert_popup: rename show/hide signals to visible,on/off
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:56 +0000 (16:59 -0400)]
efl_ui/alert_popup: rename show/hide signals to visible,on/off

Summary:
this is consistent with the efl api

ref T8231
Depends on D10081

Reviewers: segfaultxavi, cedric

Reviewed By: cedric

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10095

4 years agotheme: add 'required' to efl/border parts
Xavi Artigas [Tue, 24 Sep 2019 20:59:50 +0000 (16:59 -0400)]
theme: add 'required' to efl/border parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10094

4 years agoelm: rename _use_build_config variable -> _running_in_tree
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:49 +0000 (16:59 -0400)]
elm: rename _use_build_config variable -> _running_in_tree

Summary:
this makes the meaning of the variable more clear

no functional changes
Depends on D10092

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10093

4 years agoefl_ui/alert_popup: use normal C-based part aliasing and remove theme alias
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:44 +0000 (16:59 -0400)]
efl_ui/alert_popup: use normal C-based part aliasing and remove theme alias

Summary:
part aliasing should be done at the layout level, not using bespoke string
comparisons. also this removes the "title" part of the alert_popup theme
which was previously considered api

Depends on D10091

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10092

4 years agoefl_ui/layout: validate theme api version in theme_apply
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:39 +0000 (16:59 -0400)]
efl_ui/layout: validate theme api version in theme_apply

Summary:
this throws error and warning messages if the theme api version does
not match the current efl version, and it will cause unit tests to fail
when the theme version is not updated

ref T8231

Depends on D10093

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10081

4 years agotheme: manually specify version info for all eo-based widget themes
Mike Blumenkrantz [Tue, 24 Sep 2019 20:59:33 +0000 (16:59 -0400)]
theme: manually specify version info for all eo-based widget themes

Summary:
this needs to be provided to verify that the theme corresponds to the
current version of the widget

ref T8231
Depends on D10079

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl_widgets

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10080

4 years agoeolian: fixing switch case.
Bruno da Silva Belo [Tue, 24 Sep 2019 19:50:49 +0000 (16:50 -0300)]
eolian: fixing switch case.

Summary: Scope of the switch breaks compilation.

Reviewers: felipealmeida, segfaultxavi, brunobelo

Reviewed By: brunobelo

Subscribers: segfaultxavi, cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10118

4 years agocsharp: Fix wrapping of private classes
Lauro Moura [Tue, 24 Sep 2019 14:36:34 +0000 (11:36 -0300)]
csharp: Fix wrapping of private classes

Summary:
Sometimes, valid Eo objects of private classes can be returned from
methods. Currently we try to wrap in a minimal `Efl.Object` instance,
but as it is an abstract class, we can't instantiate directly.

This commits adds a dummy `Efl.ObjectRealized` to be instantiated when
wrapping such classes alongside a test case.

Fixes: T8258

Reviewers: felipealmeida, brunobelo, segfaultxavi, Jaehyun_Cho

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10101

4 years agoefl_ui_selection_manager: fix potential out of bounce access
Stefan Schmidt [Tue, 24 Sep 2019 20:56:48 +0000 (16:56 -0400)]
efl_ui_selection_manager: fix potential out of bounce access

Summary:
We have been casting the selection to unsigned char * for the address of
sel and not for the value. Coverity pointed this out:
Overrunning buffer pointed to by (unsigned char *)&sel of 8 bytes by
passing it to a function which accesses it at byte offset 167 using argument 168

It seems this has been working by memory layout and luck if I understand
it all correctly.

Coverity ID: 1402666

Reviewers: thiepha, raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10107

4 years agoefl_ui/layout: fix part aliasing for non-legacy widgets
Mike Blumenkrantz [Mon, 23 Sep 2019 19:20:07 +0000 (15:20 -0400)]
efl_ui/layout: fix part aliasing for non-legacy widgets

if a non-null value is passed here, this needs to actually evaluate
all the part aliases

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10091

4 years agoelm: rename layout part aliasing functions/macros
Mike Blumenkrantz [Mon, 23 Sep 2019 17:24:51 +0000 (13:24 -0400)]
elm: rename layout part aliasing functions/macros

these are internal apis for managing part aliasing on the C side,
but they apply to efl_ui_layout and not elm_layout

no functional changes

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10090

4 years agoevas: fix error return of evas_object_propagate_events_get()
Mike Blumenkrantz [Tue, 24 Sep 2019 20:11:33 +0000 (16:11 -0400)]
evas: fix error return of evas_object_propagate_events_get()

ref T8259

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10123

4 years agocsharp: Fix factory instantiation
Lauro Moura [Tue, 24 Sep 2019 20:06:29 +0000 (20:06 +0000)]
csharp: Fix factory instantiation

After 892c26f906d23595b709b834dde6b032bdd6d89d, widget factories require
a widget to be their parents.

This commit updates C# tests and adds a warning message to elementary if the user does
not provide one.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10122

4 years agoefl/audio_control: remove player
Mike Blumenkrantz [Tue, 24 Sep 2019 18:51:04 +0000 (14:51 -0400)]
efl/audio_control: remove player

Summary: this does not require any other interfaces

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10110

4 years agodocs: Update Efl.Ui.Scrollbar docs
Xavi Artigas [Tue, 24 Sep 2019 18:51:01 +0000 (14:51 -0400)]
docs: Update Efl.Ui.Scrollbar docs

Summary: Ref T7884

Reviewers: zmike, eagleeye

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7884

Differential Revision: https://phab.enlightenment.org/D10041

4 years agoelementary: another forgotten file that need removal.
Cedric Bail [Tue, 24 Sep 2019 18:54:20 +0000 (11:54 -0700)]
elementary: another forgotten file that need removal.

4 years agoefl_player: split off audio related properties
Marcel Hollerbach [Tue, 24 Sep 2019 18:22:11 +0000 (14:22 -0400)]
efl_player: split off audio related properties

Summary:
this commit moves the audio related properties from Efl.Player to
Efl.Player_Audio.

Reviewers: zmike, Jaehyun_Cho

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7877

Differential Revision: https://phab.enlightenment.org/D10106

4 years agoelementary: fix up left over header that got removed.
Cedric Bail [Tue, 24 Sep 2019 18:30:22 +0000 (11:30 -0700)]
elementary: fix up left over header that got removed.

4 years agoefl_ui_position_manager_list: emit events correctly
Marcel Hollerbach [Mon, 16 Sep 2019 12:11:56 +0000 (14:11 +0200)]
efl_ui_position_manager_list: emit events correctly

it does not matter if pmin_size is > 0 or not. The important thing is
that it is different to what is now, but thats it.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9970

4 years agoefl_ui_collection_view: support focus
Marcel Hollerbach [Mon, 16 Sep 2019 11:50:12 +0000 (13:50 +0200)]
efl_ui_collection_view: support focus

with this commit you can more or less use focus. The only uncaught case
for now is that if the object is not available, no focus can be set.
Navigating with focus on the screen however should be possible.

Differential Revision: https://phab.enlightenment.org/D9969

4 years agoelementary: add a basic test for MVVM infrastructure.
Cedric Bail [Fri, 20 Sep 2019 22:01:49 +0000 (15:01 -0700)]
elementary: add a basic test for MVVM infrastructure.

Differential Revision: https://phab.enlightenment.org/D10063

4 years agoelementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager...
Cedric Bail [Mon, 16 Sep 2019 06:18:50 +0000 (23:18 -0700)]
elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure.

Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9960

4 years agoelementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View.
Cedric Bail [Thu, 19 Sep 2019 18:19:56 +0000 (11:19 -0700)]
elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View.

Differential Revision: https://phab.enlightenment.org/D10035

4 years agoelementary: introduce Efl.Ui.CollectionView a generic listing View.
Cedric BAIL [Fri, 5 Jul 2019 21:03:13 +0000 (14:03 -0700)]
elementary: introduce Efl.Ui.CollectionView a generic listing View.

The idea of this widget is to provide to MVVM what Efl.Ui.Collection provide and
leverage the same shared logic for layout.

Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9958

4 years agoelementary: fix children removal in Efl.Ui.Select_Model by not remembering index...
Cedric Bail [Thu, 19 Sep 2019 02:39:44 +0000 (19:39 -0700)]
elementary: fix children removal in Efl.Ui.Select_Model by not remembering index and relying on underlayer infrastructure to do it for us.

Differential Revision: https://phab.enlightenment.org/D10034

4 years agoelementary: add an interface for asynchronous multi selection.
Cedric Bail [Sun, 15 Sep 2019 19:50:27 +0000 (12:50 -0700)]
elementary: add an interface for asynchronous multi selection.

This interface is currently focusing on being use by widget like
Efl.Ui.Collection_View or Efl.Ui.Select_Model. I have decided that
it should not be available along with Efl.Ui.Multi_Selectable.

Differential Revision: https://phab.enlightenment.org/D9957

4 years agoelementary: factorize all events emitted by a Efl.Ui.Collection into their own interface.
Cedric Bail [Sun, 15 Sep 2019 21:38:03 +0000 (14:38 -0700)]
elementary: factorize all events emitted by a Efl.Ui.Collection into their own interface.

For most event it is actually meaningful to share them with Efl.Ui.Collection_View so let's do it.

Differential Revision: https://phab.enlightenment.org/D9956

4 years agoelm: fix Efl.Ui errors not being registered
Daniel Kolesa [Tue, 24 Sep 2019 17:17:28 +0000 (19:17 +0200)]
elm: fix Efl.Ui errors not being registered

The implementation is necessary, but it wasn't being generated
and included by mistake.

4 years agoeolian: remove support for globals
Daniel Kolesa [Tue, 24 Sep 2019 15:06:24 +0000 (17:06 +0200)]
eolian: remove support for globals

This was meant to happen but did not previously happen. It is not
ideal to do it now but better do it while we still can.

In short, this removes one half of the variables API (keeps
constants as they are) and repurposes the API to be only for
constants. This is also better for consistency to match errors.

4 years agoefl: remove remaining instances of .eo global variables
Daniel Kolesa [Tue, 24 Sep 2019 15:46:56 +0000 (17:46 +0200)]
efl: remove remaining instances of .eo global variables

4 years agoeolian: always allow implementation for eot files
Daniel Kolesa [Tue, 24 Sep 2019 16:17:59 +0000 (18:17 +0200)]
eolian: always allow implementation for eot files

This is so the build system can unconditionally generate .eot.c
without worrying whether there's something to generate.

4 years agoEfl.Ui.Layout_Pack: fix obvious uninitialized variable
Xavi Artigas [Tue, 24 Sep 2019 15:57:00 +0000 (17:57 +0200)]
Efl.Ui.Layout_Pack: fix obvious uninitialized variable

Why did this ever work?

4 years agodoc: update ecore_filter_model description
Wonki Kim [Tue, 24 Sep 2019 15:20:43 +0000 (17:20 +0200)]
doc: update ecore_filter_model description

Summary: this patch updates single line description of ecore_filter_model.(T7717)

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10103

4 years agoeolian: remove global vars from tests
Daniel Kolesa [Tue, 24 Sep 2019 14:17:11 +0000 (16:17 +0200)]
eolian: remove global vars from tests

4 years agoefl: use new eolian error functionality instead of globals
Daniel Kolesa [Tue, 24 Sep 2019 13:52:34 +0000 (15:52 +0200)]
efl: use new eolian error functionality instead of globals

Also enable referencing errors in docs.

4 years agodeclare first round of classes stable
Marcel Hollerbach [Mon, 9 Sep 2019 09:23:04 +0000 (11:23 +0200)]
declare first round of classes stable

this stabelizes the "stableized" column of the efl: api workboard.

fixes T8208,
fixes T8158,
fixes T8156,
fixes T8025,
fixes T8024,
fixes T7976,
fixes T7946,
fixes T7928,
fixes T7923,
fixes T7905,
fixes T7902,
fixes T7901,
fixes T7900,
fixes T7898,
fixes T7897,
fixes T7895,
fixes T7894,
fixes T7893,
fixes T7891,
fixes T7880,
fixes T7873,
fixes T7869,
fixes T7867,
fixes T7865,
fixes T7862,
fixes T7854,
fixes T7847,
fixes T7881,
fixes T7870,
fixes T9086

Differential Revision: https://phab.enlightenment.org/D10008

4 years agoefl_ui_collection: this interface is not event used
Marcel Hollerbach [Tue, 24 Sep 2019 13:16:45 +0000 (15:16 +0200)]
efl_ui_collection: this interface is not event used

Differential Revision: https://phab.enlightenment.org/D10108

4 years agoefl_ui_win: default the window type to basic
Marcel Hollerbach [Fri, 20 Sep 2019 12:57:09 +0000 (14:57 +0200)]
efl_ui_win: default the window type to basic

normally when you create a window, you just want to have it beeing a
basic window. If not you still can set the window type.

ref T8229

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10049

4 years agoefl: make Efl.Ui.Factory.release work in batches.
Cedric Bail [Mon, 16 Sep 2019 05:39:05 +0000 (22:39 -0700)]
efl: make Efl.Ui.Factory.release work in batches.

This will enable better strategy in scheduling removal of object from the cache
instead of doing the throttling in the View as there is a better understanding
of the different layer the items are going to go through and where they will
consume time.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9955

4 years agoelementary: rework Efl.Ui.Factory to have another additional stage during releasing...
Cedric Bail [Mon, 16 Sep 2019 03:52:50 +0000 (20:52 -0700)]
elementary: rework Efl.Ui.Factory to have another additional stage during releasing of items.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9954

4 years agoefl: simplify logic for widget created by factory.
Cedric Bail [Mon, 16 Sep 2019 03:50:05 +0000 (20:50 -0700)]
efl: simplify logic for widget created by factory.

In an attempt to make things more complex than they should have been,
I tried to change the inheritance tree on the fly and assume widget would
rely on autodeleting its children. This is way more complex of a solution
than to let the View actually release all the child manually and just set
the window as the default parent.h

Co-authored-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9953

4 years agoefl: split Efl.Ui.Factory.create stage into constructing and building
Marcel Hollerbach [Tue, 3 Sep 2019 12:48:58 +0000 (14:48 +0200)]
efl: split Efl.Ui.Factory.create stage into constructing and building

constructing is called during construction time, building is called
after finalize. This is usefull for theme related properties that can
only be set after the theme is applied, which happens during finalize.
Being event allow the user of the factory to add more initialization
without needing to implement any new class.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9952

4 years agoelementary: Efl.Ui.Layout_Factory bind property during widget creation.
Cedric BAIL [Fri, 23 Aug 2019 21:51:54 +0000 (14:51 -0700)]
elementary: Efl.Ui.Layout_Factory bind property during widget creation.

In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9951

4 years agoelementary: Efl.Ui.Image_Factory bind property also during widget creation.
Cedric BAIL [Fri, 23 Aug 2019 21:48:14 +0000 (14:48 -0700)]
elementary: Efl.Ui.Image_Factory bind property also during widget creation.

In the same vain as previous patch this will initialize more of the widget during its
creation and reduce unecessary recalc.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9950

4 years agoecore: update Efl.Boolean_Model to handle children removal and shifting all necessary...
Cedric Bail [Thu, 19 Sep 2019 02:31:39 +0000 (19:31 -0700)]
ecore: update Efl.Boolean_Model to handle children removal and shifting all necessary boolean and index.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10033

4 years agoecore: correctly handle children removal in Efl.Composite_Model by updating all requi...
Cedric Bail [Thu, 19 Sep 2019 02:31:05 +0000 (19:31 -0700)]
ecore: correctly handle children removal in Efl.Composite_Model by updating all required index.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10032

4 years agoefl_gfx_path: Add optimized path command
JunsuChoi [Tue, 24 Sep 2019 02:52:30 +0000 (11:52 +0900)]
efl_gfx_path: Add optimized path command

Summary:
If 'L' is removed due to optimization, it should be supported like 3b1f7be
If the previous command is 'M', use 'L'.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10104

Change-Id: I91c39e240bcfacce3ad59faaf3c2adc9bd747a07

4 years agoevas vg: fix gradient stroke fill memory leaks.
Hermet Park [Tue, 24 Sep 2019 02:46:50 +0000 (11:46 +0900)]
evas vg: fix gradient stroke fill memory leaks.

There were continous creation of gradient objects,
We can stop it by caching it properly,

Also, fix mismatched ref/unref counts.

4 years agoefl-mono: Additional blank line between all methods.
Bruno da Silva Belo [Mon, 23 Sep 2019 23:50:27 +0000 (20:50 -0300)]
efl-mono: Additional blank line between all methods.

Summary:
For better indentation, adding a blank line in the end of
methods.

Test Plan:
using efl_ui_layout.eo.cs, efl_access_object.eo.cs, efl_part.eo.cs and efl_ui_factory_bind.eo.cs as references,
apply changes to the code then check the diffs of after and before of the references files

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, felipealmeida, lauromoura

Tags: PHID-PROJ-uhnmnvlvunw6jgoqdnd4, #efl_language_bindings, #refactoring

Maniphest Tasks: T8167

Differential Revision: https://phab.enlightenment.org/D9712

4 years agoelm_conform: initialize variables for resizing part. 52/214552/2 submit/tizen/20190924.053902
Hosang Kim [Tue, 24 Sep 2019 03:48:08 +0000 (12:48 +0900)]
elm_conform: initialize variables for resizing part.

Change-Id: I21ef8eb27f6a2c37aaa5ae190d8869a1ce2ce4cb

4 years agoefl_gfx_path: Add optimized path command 50/214550/1
JunsuChoi [Tue, 24 Sep 2019 02:52:30 +0000 (11:52 +0900)]
efl_gfx_path: Add optimized path command

Summary:
If 'L' is removed due to optimization, it should be supported like 3b1f7be
If the previous command is 'M', use 'L'.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10104

Change-Id: I97478dffc8c1612d3e60e905f4af37de0b6e5d9d

4 years agoefl_gfx_path: Support 'l' command for optimized path. 49/214549/1
JunsuChoi [Tue, 24 Sep 2019 01:20:43 +0000 (10:20 +0900)]
efl_gfx_path: Support 'l' command for optimized path.

Summary:
If there is no 'l' command for path optimization, refer to the previous cmd.
If the previous command is 'm', use 'l'.

Test Plan:
[Example SVG]
'''
<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 40 40">
<g fill="none" fill-rule="evenodd">
<rect width="40" height="40" fill="#f00" opacity="0"/>
<path d="m12 20 13-12-13 12zm0 0 13 12-13-12z" fill-rule="nonzero" opacity=".12" stroke="#fff" stroke-linecap="round" stroke-linejoin="round" stroke-width="2"/>
</g>
</svg>
'''

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10074

Change-Id: I0e78949fcd0fdbff1d7a7314735319c2ce9924d4

4 years agoeo_mono: remove Efl.Access.Reading_Info_Type_Mask from workaround.cs 81/214481/2
Jaehyun Cho [Mon, 23 Sep 2019 08:06:20 +0000 (17:06 +0900)]
eo_mono: remove Efl.Access.Reading_Info_Type_Mask from workaround.cs

Since Efl.Access.Reading_Info_Type_Mask is defined in
efl_access_object.eo, the previous definition in workaround.cs is
removed.

Change-Id: I080a5c928318a7ba990d76d3e71cb9e831599414

4 years agoefl_canvas_object: set default value to false for not breaking compatibility 34/214534/1
WooHyun Jung [Tue, 24 Sep 2019 01:15:21 +0000 (10:15 +0900)]
efl_canvas_object: set default value to false for not breaking compatibility

@tizen_fix

Change-Id: I56e28fd87d92f5f6605297e24687f58cb4341184

4 years agobuild: resolve build error during migration submit/tizen/20190923.215628
Jongmin Lee [Mon, 23 Sep 2019 21:49:02 +0000 (06:49 +0900)]
build: resolve build error during migration

gl_generic module should be copmpiled prior to the other modules.

@tizen_fix

Change-Id: I8be4330792836b4ba18b7b0b2493d950950b0227

4 years agodocs: Add documentation for Efl.Ui.Scroller
Xavi Artigas [Mon, 23 Sep 2019 20:51:17 +0000 (16:51 -0400)]
docs: Add documentation for Efl.Ui.Scroller

Summary:
These docs were missing.
Ref T7891

Test Plan: Only docs changed

Reviewers: zmike, woohyun, bu5hm4n

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7891

Differential Revision: https://phab.enlightenment.org/D10019

4 years agoosx - require full opengl for gl support on osx
Carsten Haitzler (Rasterman) [Mon, 23 Sep 2019 20:14:50 +0000 (21:14 +0100)]
osx - require full opengl for gl support on osx

the default still is gl-es as documented. you need to explicitly turn
on full opengl to get gl support on osx because thats all the engine
does. document this exception for osx (having gl magically being full
on osx and gle-es elsewhere is another option but then we need
different os specific defaults for this which is kind of bad in other
ways).

4 years agotheme: add 'required' to efl/tab_pager group parts
Xavi Artigas [Mon, 23 Sep 2019 20:09:36 +0000 (16:09 -0400)]
theme: add 'required' to efl/tab_pager group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10087

4 years agoefl_ui_pack: allow NULL as existing parameter in after and before
Marcel Hollerbach [Mon, 23 Sep 2019 20:03:26 +0000 (16:03 -0400)]
efl_ui_pack: allow NULL as existing parameter in after and before

Summary:
with this commit all implementations of Efl.Pack_Linear to permit NULL
as existing parameter, this is verified with a spec test unit.

fixes T8210

Reviewers: zmike, segfaultxavi

Reviewed By: zmike

Subscribers: woohyun, Jaehyun_Cho, YOhoho, segfaultxavi, zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8210

Differential Revision: https://phab.enlightenment.org/D10023

4 years agodoc: wrap comment for EFL_UI_CLICKABLE_PART_BIND docs in edc
Mike Blumenkrantz [Mon, 23 Sep 2019 20:09:22 +0000 (22:09 +0200)]
doc: wrap comment for EFL_UI_CLICKABLE_PART_BIND docs in edc

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10089

4 years agoci - osx - switch to full gl option on osx
Carsten Haitzler (Rasterman) [Mon, 23 Sep 2019 19:54:35 +0000 (20:54 +0100)]
ci - osx - switch to full gl option on osx

4 years agotheme: add 'required' to efl/button:anchor group parts
Xavi Artigas [Mon, 23 Sep 2019 19:27:50 +0000 (15:27 -0400)]
theme: add 'required' to efl/button:anchor group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10086

4 years agotests: Initialize variables and quiet warning.
Lauro Moura [Mon, 23 Sep 2019 19:27:49 +0000 (15:27 -0400)]
tests: Initialize variables and quiet warning.

Summary: The switch does not cover all Align enum values.

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10085

4 years agotheme: add 'required' to efl/spin_button group parts
Xavi Artigas [Mon, 23 Sep 2019 19:27:47 +0000 (15:27 -0400)]
theme: add 'required' to efl/spin_button group parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10084

4 years agotheme: add 'required' to efl/timepicker parts
Xavi Artigas [Mon, 23 Sep 2019 19:27:45 +0000 (15:27 -0400)]
theme: add 'required' to efl/timepicker parts

Summary: ref T8231

Reviewers: zmike, cedric

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8231

Differential Revision: https://phab.enlightenment.org/D10083

4 years agoefl: improve test in checking the return value during Eina_Value get operation.
Cedric Bail [Mon, 23 Sep 2019 19:27:34 +0000 (15:27 -0400)]
efl: improve test in checking the return value during Eina_Value get operation.

Summary: Depends on D10061

Reviewers: zmike, bu5hm4n, SanghyeonLee, segfaultxavi, felipealmeida, lauromoura

Reviewed By: bu5hm4n

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10062

4 years agodocs: Clarify behavior of NULL in Efl.Pack_Linear.
Xavi Artigas [Mon, 23 Sep 2019 19:27:14 +0000 (15:27 -0400)]
docs: Clarify behavior of NULL in Efl.Pack_Linear.

Summary: Depends on D10023

Reviewers: zmike, bu5hm4n

Reviewed By: bu5hm4n

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8210

Differential Revision: https://phab.enlightenment.org/D10024

4 years agobuild - update README and meson options to match echother in defaults
Carsten Haitzler (Rasterman) [Mon, 23 Sep 2019 17:59:27 +0000 (18:59 +0100)]
build - update README and meson options to match echother in defaults

update some defaults like move to gl-es by default, tslib off by
default as this really makes efl simpler to confgure ... by default
with less things to change to get stuff working.

4 years agotheme: add 'required' to efl/bg group parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:38:08 +0000 (13:38 -0400)]
theme: add 'required' to efl/bg group parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10056

4 years agotheme: add 'required' to efl/popup (and related group) parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:38:21 +0000 (13:38 -0400)]
theme: add 'required' to efl/popup (and related group) parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10057

4 years agotheme: add 'required' to efl/scroller group parts
Mike Blumenkrantz [Fri, 20 Sep 2019 17:56:23 +0000 (13:56 -0400)]
theme: add 'required' to efl/scroller group parts

ref T8231

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10058