sgjesse@chromium.org [Mon, 11 Jul 2011 06:45:27 +0000 (06:45 +0000)]
MIPS: Cleaned up calling-related methods in the assembler.
Patterned after r8482, Cleaned up calling-related methods in the ARM assembler.
On MIPS I completely refactored the Jump and Call methods.
All the Jump and Call macro helpers have been replaced with overloaded functions
(matching the ARM version) and using default parameter values where possible.
The previously mostly-unused CallSize function is utilized as well (same as on ARM).
The unused Jump(Operand, ...) and Call(Operand, ...) versions have been completely removed.
I also removed the Jump(BranchDelaySlot, ...) and Call(BranchDelaySlot,...) methods as
they were unused and declaring them would either result in a lot of unused code or the
previously experienced macro-hell. The only exception to this is for Ret() where the
branch delay slot is often used.
This fixes the failing debug tests for example cctest test-debug/DebugStepFor.
Ported r8482 (
41cb9ed)
Patch by Daniel Kalmar <kalmard@homejinni.com>
BUG=
TEST=
Review URL: http://codereview.chromium.org//
7328013
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8585
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Sat, 9 Jul 2011 07:29:32 +0000 (07:29 +0000)]
Updated status file for test262 to latest revision.
Landing for mstarzinger, orginal cl at:
http://codereview.chromium.org/
7329016/
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8584
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 8 Jul 2011 13:37:19 +0000 (13:37 +0000)]
Align host and target architectures when building v8_shell.
This is a fix after r8356. Otherwise, shell can't be built
on a 64-bit host.
R=ager@chromium.org
Review URL: http://codereview.chromium.org/
7328016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8581
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 8 Jul 2011 10:59:20 +0000 (10:59 +0000)]
Fix polymorphic array test
R=jkummerow@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/
7326009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8580
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 8 Jul 2011 10:46:10 +0000 (10:46 +0000)]
Unify handling of element IC stubs.
In the process, add shared stubs for DictionaryValue lookups that are handled in the same way as fast elements and external array elements.
Includes code for MIPS, which compiles and run polymorph-arrays.js successfully.
R=jkummerow@chromium.org
BUG=none
TEST=test/mjsunit/polymorph-arrays.js
Review URL: http://codereview.chromium.org/
7227010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8579
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 8 Jul 2011 09:40:14 +0000 (09:40 +0000)]
Removed useless implementations of GetName and Print for code stubs, the common
super-class handles the most common case already.
Review URL: http://codereview.chromium.org/
7332001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8576
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 8 Jul 2011 09:08:12 +0000 (09:08 +0000)]
Generate shorter instruction forms for constant in ia32 gap resolver.
Review URL: http://codereview.chromium.org//
7277084
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8574
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 8 Jul 2011 08:55:26 +0000 (08:55 +0000)]
Add inspection of whether frame is a construct frame to optimized frames
Also avoid that calling Debug::IsBreakAtReturn causes a full doptimization when there are no break points set. The full deoptimization is caused by Debug::IsBreakAtReturn calling Debug::EnsureDebugInfo which will assume that a break point is now set.
R=svenpanne@chromium.org
BUG=v8:1140
TEST=test/mjsunit/debug-evaluate-locals-optimized.js,test/mjsunit/debug-
evaluate-locals-optimized-doubles.js
Review URL: http://codereview.chromium.org//
7307035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8573
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 8 Jul 2011 08:03:39 +0000 (08:03 +0000)]
Fix compilation error.
Compiler cannot recognize the typename in template declaration. Caught by
MSVC.
R=ricow@chromium.org
Review URL: http://codereview.chromium.org/
7237047
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8572
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 8 Jul 2011 07:31:48 +0000 (07:31 +0000)]
Fix a bug in for/in iteration of arguments objects.
We did not properly combine the property names from the parameter map
and the arguments backing store. They could overwrite each other and
be unsorted.
Also fix an unrelated bug: deleting from a dictionary-mode arguments
backing store could corrupt the parameter map.
R=rossberg@chromium.org
BUG=1531
TEST=mjsunit/regress/regress-1531.js
Review URL: http://codereview.chromium.org/
7278033
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8571
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 8 Jul 2011 06:59:54 +0000 (06:59 +0000)]
MIPS: port Fix ARM regression introduced with polymorphic array support.
Ported r8484 (
9f824d7)
BUG=
TEST=
Review URL: http://codereview.chromium.org//
7237046
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8570
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 8 Jul 2011 06:48:27 +0000 (06:48 +0000)]
MIPS: port Fix a typo in KeyedStoreIC, restore Kraken performance.
Ported r8539 (
46103ea)
BUG=
TEST=
Review URL: http://codereview.chromium.org//
7327016
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8569
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Fri, 8 Jul 2011 06:47:09 +0000 (06:47 +0000)]
MIPS: port Introduce code flushing of RegExp code.
Ported r8532 (
c9db503)
Original commit message:
Due to issues relating mostly to chrome extensions we have lately been
running into OOMs that are caused by our executable space running
out. This change introduces flushing of code from regexps if we have
not used the code for 5 mark sweeps.
The approach is different from the normal function code flusing. Here
we make a copy of the code inside the data array, and exchange the
original code with a smi determined by the sweep_generation (a new
heap variable increased everytime we do mark sweep/compact). If we
encounter a smi in EnsureCompiled we simply reinstate the code
object. If, in the marking phase of mark sweep, we find a regexp that
already have a smi in the code field, and this is more than 5
generations old we flush the code from the saved index.
BUG=
TEST=
Review URL: http://codereview.chromium.org//
7324018
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8568
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Thu, 7 Jul 2011 19:27:48 +0000 (19:27 +0000)]
Try to fix Windows compilation error.
R=whesse@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org//
7321008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8567
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Thu, 7 Jul 2011 14:29:16 +0000 (14:29 +0000)]
Add inspection of arguments for optimized frames
R=svenpanne@chromium.org
BUG=v8:1140
TEST=test/mjsunit/debug-evaluate-locals-optimized.js,test/mjsunit/debug-
evaluate-locals-optimized-doubles.js
Review URL: http://codereview.chromium.org//
7310027
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8566
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 7 Jul 2011 13:57:58 +0000 (13:57 +0000)]
Reduce the number of global constructor calls by changing a constant to a
(constant) inline function.
This brings down the size of v8's .ctors section to 1/4, hopefully fixing the
recent issues with Chromes' CL 91522.
Review URL: http://codereview.chromium.org/
7321005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8565
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Thu, 7 Jul 2011 12:41:20 +0000 (12:41 +0000)]
Implement Object.defineProperty for proxies.
R=kmillikin@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7314003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8564
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Thu, 7 Jul 2011 12:01:49 +0000 (12:01 +0000)]
Don't check symbol literals for being symbols.
R=fschneider@chromium.org
Review URL: http://codereview.chromium.org/
7312024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8563
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 7 Jul 2011 10:22:39 +0000 (10:22 +0000)]
When resolving phies use ANY instead of NONE as a policy for phi operands.
R=fschneider@chromium.org
Review URL: http://codereview.chromium.org/
7313023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8562
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 7 Jul 2011 10:14:55 +0000 (10:14 +0000)]
Don't emit a write barrier when storing boolean-typed values.
Review URL: http://codereview.chromium.org/
7312022
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8561
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Thu, 7 Jul 2011 10:04:56 +0000 (10:04 +0000)]
Ensure that regexps always have code object, even if GC happened while running multiple times in runtime.
Review URL: http://codereview.chromium.org/
7316018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8560
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Wed, 6 Jul 2011 17:21:32 +0000 (17:21 +0000)]
Group property assignments in top-level blocks.
This patch enables insertion of To{Slow,Fast}Properties around a group
of assigments to the same object even when they are put in a block
(e.g. try-catch, if, etc.). Catching exceptions and disabling parts of
code based on some config vars is rather common in top-level code.
R=vegorov@chromium.org
Review URL: http://codereview.chromium.org/
7314002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8558
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 6 Jul 2011 13:02:17 +0000 (13:02 +0000)]
Add inspection of function for optimized frames
R=svenpanne@chromium.org
BUG=none
TEST=test/mjsunit/debug-evaluate-locals-optimized.js,test/mjsunit/debug-evaluate-locals-optimized-doubles.js
Review URL: http://codereview.chromium.org//
7227006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8556
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 6 Jul 2011 12:36:05 +0000 (12:36 +0000)]
Correctly propagate toolchain setting in SConstruct.
Patch by Bert Belder.
Review URL: http://codereview.chromium.org/
7309014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8555
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 6 Jul 2011 12:29:21 +0000 (12:29 +0000)]
Define OS::MaxVirtualMemory on MinGW.
Patch by Bert Belder.
BUG=v8:1508
Review URL: http://codereview.chromium.org/
7212030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8553
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Wed, 6 Jul 2011 12:25:25 +0000 (12:25 +0000)]
MinGW32: define STRUNCATE and change strncpy_s implementation to follow specification.
This fixes the debug build for MinGW32
Patch by Bert Belder.
Review URL: http://codereview.chromium.org/
7308007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8552
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 6 Jul 2011 10:58:52 +0000 (10:58 +0000)]
Prepare push to trunk. Now working on version 3.4.11.
R=svenpanne@chromium.org
Review URL: http://codereview.chromium.org/
7310001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8545
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 6 Jul 2011 10:16:57 +0000 (10:16 +0000)]
Fix debug break on binary boolean operators
The syntax checker finding breakable statements did not take into account that the right hand side of a boolean binary opration might never get evaluated.
R=svenpanne@chromium.org
BUG=v8:1523
TEST=test/mjsunit/regress/regress-1523.js
Review URL: http://codereview.chromium.org//
7212027
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8544
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 6 Jul 2011 09:28:07 +0000 (09:28 +0000)]
Use the information from the last recorded safepoint for the padding after the deferrred code.
R=kmillikin@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org//
7248077
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8543
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 6 Jul 2011 09:15:10 +0000 (09:15 +0000)]
Revert preparser duplicate detection.
Doesn't work on Windows yet.
Crashes some layout-tests.
Review URL: http://codereview.chromium.org/
7278039
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8542
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Wed, 6 Jul 2011 08:32:48 +0000 (08:32 +0000)]
Make preparser detect duplicate parameters and object literal properties.
This is a fix and reapply of r8516 with some comments addressed and more
tests added.
The difference from r8516 is that canonicalization of number literals is
no performed using the same methods as in v8, to avoid false positives/negatives
when detecting duplicates.
Review URL: http://codereview.chromium.org/
7193045
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8541
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Wed, 6 Jul 2011 08:20:30 +0000 (08:20 +0000)]
In preperation of using d8 for running tests: Don't run d8-os when running with --isolates.
When used with d8 this can potentially interfer with the writing,
reading and deletion of files is the isolates flags makes the same
test run concurrently.
Review URL: http://codereview.chromium.org/
7308006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8540
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 6 Jul 2011 07:05:49 +0000 (07:05 +0000)]
Fix a typo in KeyedStoreIC, restore Kraken performance.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org//
7193041
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8539
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 5 Jul 2011 16:12:42 +0000 (16:12 +0000)]
Fix arm build.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/
7308012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8538
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Tue, 5 Jul 2011 15:49:39 +0000 (15:49 +0000)]
Fix a few issues breaking cctest/test-lockers/Regress1433:
o The thread local state in an isolate has to be initialized before
it's used.
o v8::Locker was incorrectly tracking whether it's the topmost one.
o Waking the profiler thread on shutdown should not leave the
semaphore counter in an inconsitent state.
R=fschneider@chromium.org
BUG=v8:1522
TEST=cctest/test-lockers/Regress1433
Review URL: http://codereview.chromium.org/
7309013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8537
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 5 Jul 2011 13:33:51 +0000 (13:33 +0000)]
Add new files to gyp.
Review URL: http://codereview.chromium.org/
7278035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8536
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Tue, 5 Jul 2011 13:21:29 +0000 (13:21 +0000)]
Add support for lazy deoptimization from deferred stack checks
The debugger can be entered from the deferred stack check in optimized code. This can cause both lazy deoptimization and debugger deoptimization (setting the first break point and inspecting the stack for optimized code respectively). This required deoptimization support from the deferred stack check.
The lazy deoptimiztion call is inserted when the deferred code is done including restoring the registers. The bailout to the full code is the begining of the loop body as that is where the stack check is sitting in the optimized code. The bailout is not to the stack check in the full code as that is sitting at the end of the loop.
R=kmillikin@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org//
7212025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8535
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Tue, 5 Jul 2011 11:54:11 +0000 (11:54 +0000)]
Extract string->double and double->string conversions for use in the preparser.
Review URL: http://codereview.chromium.org/
7308004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8534
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Tue, 5 Jul 2011 11:36:52 +0000 (11:36 +0000)]
Fix ABI for API calls on ia32.
Instead of relying on eax value after the call load returned handle value directly from the slot that was preallocated for it.
R=vitalyr@chromium.org
Review URL: http://codereview.chromium.org/
7307004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8533
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Tue, 5 Jul 2011 06:19:53 +0000 (06:19 +0000)]
Introduce code flushing of RegExp code.
Due to issues relating mostly to chrome extensions we have lately been
running into OOMs that are caused by our executable space running
out. This change introduces flushing of code from regexps if we have
not used the code for 5 mark sweeps.
The approach is different from the normal function code flusing. Here
we make a copy of the code inside the data array, and exchange the
original code with a smi determined by the sweep_generation (a new
heap variable increased everytime we do mark sweep/compact). If we
encounter a smi in EnsureCompiled we simply reinstate the code
object. If, in the marking phase of mark sweep, we find a regexp that
already have a smi in the code field, and this is more than 5
generations old we flush the code from the saved index.
Review URL: http://codereview.chromium.org/
7282026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8532
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Tue, 5 Jul 2011 05:27:10 +0000 (05:27 +0000)]
Don't try to build d8 from profiler tick processor scripts.
As described in the issue 1532, this may lead to building a 32-bit version over
existing x64-bit. It's better delegate to delegate this task to an user.
R=vitalyr@chromium.org
BUG=1532
Review URL: http://codereview.chromium.org/
7309012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8530
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 4 Jul 2011 14:13:08 +0000 (14:13 +0000)]
As part of allowing different contexts for inlined functions, eliminate most explicit reads of the context from the stack frame in ia32 crankshaft codegen.
Eliminates the enum flag RESTORE_CONTEXT and CONTEXT_ADJUSTED, and adds a context HValue and LOperand to many hydrogen and lithium instructions.
Context is still used from the stack from in CallKnownFunction (this seems safe), and in CallRuntimeFromDeferred in lithium-codegen-ia32.cc, which needs to be fixed.
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7132002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8529
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Mon, 4 Jul 2011 13:29:56 +0000 (13:29 +0000)]
Fix bug 1529: check for NULL handle in v8::TryCatch::StackTrace.
Internal HandleScope::CloseAndEscape crashes on NULL handles.
R=kmillikin@chromium.org
BUG=v8:1529
TEST=mjsunit/regress/regress-1529
Review URL: http://codereview.chromium.org/
7309004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8527
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ricow@chromium.org [Mon, 4 Jul 2011 13:20:39 +0000 (13:20 +0000)]
Prepare push to trunk. Now working on 3.4.10.
Review URL: http://codereview.chromium.org/
7307003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8526
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 4 Jul 2011 11:58:20 +0000 (11:58 +0000)]
Fix Windows 64-bit compilation error.
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7307002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8525
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Mon, 4 Jul 2011 11:34:29 +0000 (11:34 +0000)]
Speed up V8 random number generator, reverting part of 8490.
Return to previous random number generator, but mix more bits into
output to hide hidden state better. Keep the multithreading fix that
moves the PNG into isolate.
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7250005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8524
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Mon, 4 Jul 2011 09:34:47 +0000 (09:34 +0000)]
Fix a bug in with and catch context allocation.
We were only looking one level up the scope chain to decide which
closure to use in the fresh context. Instead, we should look to the
first non-catch scope.
R=vegorov@chromium.org
BUG=1528
TEST=regress-1528
Review URL: http://codereview.chromium.org/
7309002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8523
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 4 Jul 2011 09:05:57 +0000 (09:05 +0000)]
MIPS: port Introduce scopes to keep track of catch blocks at compile time.
Port r8496 (
b7d5ecf0).
Original commit message:
Introduce scopes to keep track of catch blocks at compile time.
The catch variable is bound in the catch scope. For simplicity in this
initial implementation, it is always allocated even if unused and always
allocated to a catch context even if it doesn't escape. The presence of
catch is no longer treated as a with.
In this change, care must be taken to distinguish between the scope where a
var declaration is hoisted to and the scope where the initialization occurs.
BUG=
TEST=
Review URL: http://codereview.chromium.org//
7212020
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8522
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 4 Jul 2011 09:01:52 +0000 (09:01 +0000)]
MIPS: port Do not pass the global object as the receiver to strict-mode ...
Do not pass the global object as the receiver to strict-mode and
builtin replace and sort functions.
Port r8488 (
6f347b6)
BUG=
TEST=
Review URL: http://codereview.chromium.org//
7278024
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8521
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Mon, 4 Jul 2011 08:57:43 +0000 (08:57 +0000)]
Correctly handle the constant pool in constant pool splitting test
The constant pool was not taken into account in the test test-compiler/SplitConstantsInFullCompiler which caused random failures.
This also reverts the test code added in r8469 and r8471.
R=ricow@chromium.org
BUG=none
TEST=test-compiler/SplitConstantsInFullCompiler
Review URL: http://codereview.chromium.org//
7308001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8520
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 1 Jul 2011 15:44:21 +0000 (15:44 +0000)]
Revert r8516.
Revision 8516 contained a temporary hack that doesn't work on Windows.
TBR: ricow
Review URL: http://codereview.chromium.org/
7298008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8519
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Fri, 1 Jul 2011 14:05:46 +0000 (14:05 +0000)]
Fix an issue with optimization of functions inside catch.
When optimizing a function defined inside a catch, we did not count
the catch context as part of the context chain.
R=vegorov@chromium.org
BUG=1521
TEST=regress-1521
Review URL: http://codereview.chromium.org/
7285032
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8518
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 1 Jul 2011 13:46:52 +0000 (13:46 +0000)]
Add duplicate parameter detection to preparser.
Add tests for duplicate properties of object initialisers to preparser.
TEST=preparser
Review URL: http://codereview.chromium.org/
7168016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8517
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Fri, 1 Jul 2011 13:18:42 +0000 (13:18 +0000)]
Do a backing store sparseness check on fast element delete.
R=vegorov@chromium.org
Review URL: http://codereview.chromium.org/
7298004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8516
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Fri, 1 Jul 2011 12:47:18 +0000 (12:47 +0000)]
Remove unmarked entries from per context map caches.
Made "map_cache" a weak field of global context and added a pass over
all caches late in the marking phase.
R=vegorov@chromium.org
BUG=v8:1516
TEST=cctest/test-api/Regress1516
Review URL: http://codereview.chromium.org/
7285031
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8515
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 1 Jul 2011 11:47:55 +0000 (11:47 +0000)]
exposing a few boolean queries from objects.h
TEST=start with ./d8 --allow-natives-syntax and try %ObjectHasFastElements({})
Review URL: http://codereview.chromium.org/
7289010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8514
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
lrn@chromium.org [Fri, 1 Jul 2011 11:41:45 +0000 (11:41 +0000)]
Make date parser handle all ES5 Date Time Strings correctly.
This means that ES5 Date Time Strings will default to UTC if timezone is absent.
Handle as many legacy strings as possible the same way as before
BUG=v8:1498
TEST=mjsunit/date
Review URL: http://codereview.chromium.org/
7291022
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8513
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 1 Jul 2011 11:12:27 +0000 (11:12 +0000)]
Fix flakiness of optimization assertion on slow ARM builders
(if the test ran too slow, optimization kicked in earlier than expected by the test)
TEST=mjsunit/assert-opt-and-deopt.js no longer flaky
Review URL: http://codereview.chromium.org/
7298001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8511
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Fri, 1 Jul 2011 11:05:04 +0000 (11:05 +0000)]
Sync grokdump.py INSTANCE_TYPES with V8.
R=vitalyr@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7278017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8510
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 1 Jul 2011 11:04:36 +0000 (11:04 +0000)]
Add missing HandleScope
Review URL: http://codereview.chromium.org/
7210056
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8509
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sandholm@chromium.org [Fri, 1 Jul 2011 10:59:38 +0000 (10:59 +0000)]
An attempt to resolve the win32 build error introduced in r8506
Review URL: http://codereview.chromium.org/
7278018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8508
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Fri, 1 Jul 2011 09:35:16 +0000 (09:35 +0000)]
Remove "modules" and "tags" of the logging CPU profiler.
Modules now makes a little sense, as there is only one module.
Tags was a simplistic attempt of supporting nested profiles.
R=sgjesse@chromium.org
BUG=859
Review URL: http://codereview.chromium.org/
7276046
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8507
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sandholm@chromium.org [Fri, 1 Jul 2011 09:29:38 +0000 (09:29 +0000)]
Special case handling of one char split on an ASCII string.
Review URL: http://codereview.chromium.org/
7285030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8506
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 1 Jul 2011 09:02:25 +0000 (09:02 +0000)]
When compiling C++, CXXFLAGS *and* CCFLAGS are used, so there is no need to pass
the latter ones twice.
Review URL: http://codereview.chromium.org/
7292030
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8505
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 1 Jul 2011 07:58:58 +0000 (07:58 +0000)]
Cleanup polymorphic IC code to make use of ElementsKind information in maps.
Review URL: http://codereview.chromium.org/
7283044
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8504
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 1 Jul 2011 07:50:46 +0000 (07:50 +0000)]
Simplify UnaryOpStub a little bit.
Only a single constructor is really needed. Make UnaryOp_Patch's arguments
simpler, avoiding encoding/decoding things in a cryptic way.
Review URL: http://codereview.chromium.org/
7248063
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8503
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Fri, 1 Jul 2011 05:50:14 +0000 (05:50 +0000)]
Fixes the build for the shell on illumos and Solaris. -D__C99FEATURES__ was added to mirror how the build is done on the normal platform. The changes in the platform code are a follow up to a prior review and has the Solaris implementation be more similar to the Linux version as opposed to the FreeBSD.
Contributed by Robert Mustacchi <rm@fingolfin.org>
TEST=Note the test suite uncovered a bug in libm where pow(3M) was not doing the right thing on edge cases. The only test failures are related to this bug.
Review URL: http://codereview.chromium.org/
7282034
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8502
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 30 Jun 2011 18:14:48 +0000 (18:14 +0000)]
Relax register constraints for instructions that support memory operands on IA32.
Review URL: http://codereview.chromium.org/
7290006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8501
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 30 Jun 2011 15:57:56 +0000 (15:57 +0000)]
Change return type of FrameDescription::GetFrameSize to avoid unneeded type casts.
Review URL: http://codereview.chromium.org/
7282033
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8500
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Jun 2011 15:49:14 +0000 (15:49 +0000)]
Remove bogus assertion.
R=fschneider@chromium.org
Review URL: http://codereview.chromium.org/
7291001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8499
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 30 Jun 2011 15:05:24 +0000 (15:05 +0000)]
Fix broken ARM debug build.
TBR=
Review URL: http://codereview.chromium.org/
7284035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8498
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
karlklose@chromium.org [Thu, 30 Jun 2011 14:56:06 +0000 (14:56 +0000)]
Fix problem with arguments object ICs not checking for dictionary mode elements.
R=kmillikin@chromium.org
BUG=1514
TEST=mjsunit/regress/regress-1513.js
Review URL: http://codereview.chromium.org/
7282029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8497
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Jun 2011 14:37:55 +0000 (14:37 +0000)]
Introduce scopes to keep track of catch blocks at compile time.
The catch variable is bound in the catch scope. For simplicity in this
initial implementation, it is always allocated even if unused and always
allocated to a catch context even if it doesn't escape. The presence of
catch is no longer treated as a with.
In this change, care must be taken to distinguish between the scope where a
var declaration is hoisted to and the scope where the initialization occurs.
R=ager@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7280012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8496
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 30 Jun 2011 14:19:52 +0000 (14:19 +0000)]
Refactor handling of test expressions in the graph builder.
Instead of generating two instructions and combining them
at lithium translation using the EmitAtUses predicate, we
generate the correct branch instruction right from the start.
Review URL: http://codereview.chromium.org/
7237024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8495
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mikhail.naganov@gmail.com [Thu, 30 Jun 2011 14:19:33 +0000 (14:19 +0000)]
Heap profiler: annotate fixed arrays by their purpose.
This helps understanding what is a particular array for by
just looking at its name.
R=vitalyr@chromium.org
Review URL: http://codereview.chromium.org/
7248058
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8494
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 30 Jun 2011 14:02:18 +0000 (14:02 +0000)]
Unbreak compilation on MIPS after EmitCallIC removal.
Note: It has only been verified that compilation is OK, nothing more... ;-)
Review URL: http://codereview.chromium.org/
7273097
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8493
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Jun 2011 13:36:52 +0000 (13:36 +0000)]
Exclude %_IsNativeOrStrictMode from natives fuzzer.
R=ricow@chromium.org
Review URL: http://codereview.chromium.org/
7284032
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8492
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 30 Jun 2011 13:08:13 +0000 (13:08 +0000)]
Fix compilation on 64-bit Windows build.
Review URL: http://codereview.chromium.org/
7283043
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8491
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
whesse@chromium.org [Thu, 30 Jun 2011 13:07:43 +0000 (13:07 +0000)]
Improve pseudorandom number generation and move the PNG state to Isolate.
Review URL: http://codereview.chromium.org/
7248060
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8490
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 30 Jun 2011 13:05:03 +0000 (13:05 +0000)]
Nuke EmitCallIC, it is a plain call now.
Note that the MIPS part will need some similar changes, too.
Review URL: http://codereview.chromium.org/
7283042
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8489
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Jun 2011 12:29:19 +0000 (12:29 +0000)]
Do not pass the global object as the receiver to strict-mode and
builtin replace and sort functions.
R=ricow@chromium.org
BUG=v8:1360
TEST=mjsunit/regress/regress-1360.js
Review URL: http://codereview.chromium.org/
7283006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8488
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 30 Jun 2011 12:19:47 +0000 (12:19 +0000)]
Fix presubmit failure in gdb-jit.cc.
R=ricow@chromium.org
Review URL: http://codereview.chromium.org/
7289013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8487
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Jun 2011 12:07:33 +0000 (12:07 +0000)]
Remove failing test while working on a fix.
TBR=ricow@chromium.org
Review URL: http://codereview.chromium.org/
7283040
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8486
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 30 Jun 2011 11:53:54 +0000 (11:53 +0000)]
Fix SConstruct to pass correct defines to samples/preparser when building with library=shared.
Fix shell sample build with library=library.
R=ager@chromium.org
Review URL: http://codereview.chromium.org/
7283039
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8485
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 30 Jun 2011 11:53:15 +0000 (11:53 +0000)]
Fix ARM regression introduced with polymorphic array support.
BUG=none
TEST=Kraken on ARM
Review URL: http://codereview.chromium.org/
7218068
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8484
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 30 Jun 2011 11:52:00 +0000 (11:52 +0000)]
Extend gdb-jit support (OSX/locals+parameters/prettyprint)
Generate Mach-O in-memory objects for OSX. Dump locals and parameters
for non-optimized frames.
Unfortunately, it seems like more-recent-GDB on OSX there is a little
temperamental (eg, the version from macports will be missing symbols
from gdb-integration_g when the version included in xcode will not--
and this is with --gdbjit off).
Includes some Python scripts to make dealing with V8 values in gdb more
pleasant.
Patch by Luke Zarko.
Review URL: http://codereview.chromium.org/
6995161
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8483
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 30 Jun 2011 11:26:15 +0000 (11:26 +0000)]
Cleaned up calling-related methods in the ARM assembler.
Generalized Call macro instruction to handle AST IDs, too, making things more
similar to the Intel assemblers. Removed unused methods. Minor signature
cleanup. Simplified assertions.
Review URL: http://codereview.chromium.org/
7284029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8482
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Jun 2011 11:11:19 +0000 (11:11 +0000)]
Fix a bug in Object.defineProperty.
There was a bug in Object.defineProperty when used to add an indexed
property to an arguments object. When converting the elements backing
store to dictionary mode, the parameter map in front of the backing
store does not change.
R=ager@chromium.org,karlklose@chromium.org
Review URL: http://codereview.chromium.org/
7289011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8481
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Jun 2011 09:25:29 +0000 (09:25 +0000)]
MIPS: stub out Support debugger inspection of locals in optimized frames
Added Deoptimizer::FillInputFrame as UNIMPLEMENTED method.
Ported r8464 (
34f38d1)
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7284026
Patch from Paul Lind <plind44@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8480
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 30 Jun 2011 08:40:31 +0000 (08:40 +0000)]
Add support for dictionary elements to polymorphic crankshaft code.
Review URL: http://codereview.chromium.org/
7285001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8479
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Jun 2011 08:34:10 +0000 (08:34 +0000)]
MIPS: port Explicitly pass the closure when allocating a catch or with context.
Ported r8453 (
59dd697)
Original commit message:
Before: allocation of a catch or with context fetched the closure to store
in the context from the previous context in the context chain. Now: the
closure is passed explicitly.
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7289008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8478
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
kmillikin@chromium.org [Thu, 30 Jun 2011 08:32:59 +0000 (08:32 +0000)]
MIPS: port Remove the fcontext field from all contexts.
Ported 8452 (
8a2a360)
Original commit message:
Before: every context cached the nearest enclosing function context. This
assumed that for nested contexts (i.e., with and catch contexts) the
enclosing function had a materialized link in the context chain.
Now: when necessary, we loop up the context chain to find such a context.
This enables catch contexts without forcing the enclosing function to
allocate its own context.
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7284025
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8477
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Jun 2011 07:24:49 +0000 (07:24 +0000)]
Fix platform-solaris after isolate changes.
Patch from http://code.google.com/p/v8/issues/detail?id=1509.
R=ager@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/
7273092
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8476
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Jun 2011 06:58:13 +0000 (06:58 +0000)]
Remove --strict developer flag from V8.
It makes V8 not have JavaScript semantics by throwing exception all
the time. Even our own natives JavaScript code cannot run using that.
R=ricow@chromium.org
BUG=v8:1511
Review URL: http://codereview.chromium.org/
7248056
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8475
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ager@chromium.org [Thu, 30 Jun 2011 06:10:12 +0000 (06:10 +0000)]
Update test expectations for sputnik to match new revision.
We should coordinate landing this with an update of the tests on the
buildbots.
R=ricow@chromium.org
Review URL: http://codereview.chromium.org/
7280006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8474
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Wed, 29 Jun 2011 15:34:00 +0000 (15:34 +0000)]
ll_prof: Terminate mmap file names on the first NUL char.
R=fschneider@chromium.org
Review URL: http://codereview.chromium.org/
7282011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8473
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vitalyr@chromium.org [Wed, 29 Jun 2011 14:56:08 +0000 (14:56 +0000)]
Suspend runtime profiler as soon as we exit JS.
Lots of web pages have really frequently firing timers that keep the
profiler thread spinning if we require a period of JS inactivity
before suspending the profiler. While it's possible to throttle it by
increasing the sleep delay and adjusting the duration of the required
inactive period, it seemed much simpler to just stop it immediately on
exiting JS.
Stopping the profiler this way effectively turned off two optimization
heuristics: 1) eager optimization (it's reset on waking up the
profiler and now the profiler wakes up much more frequently) and 2)
optimization throttling based on JS to non-JS state ratio (the ratio
is now 100%). I removed these two heuristics and found no performance
regressions so far.
R=ager@chromium.org
BUG=crbug.com/77625
TEST=none
Review URL: http://codereview.chromium.org/
7274024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8472
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Wed, 29 Jun 2011 14:28:41 +0000 (14:28 +0000)]
Fix build on x64
Review URL: http://codereview.chromium.org/
7284011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8471
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Wed, 29 Jun 2011 13:43:24 +0000 (13:43 +0000)]
Simplify EmitCallIC.
Move the identification of the corresponding StatsCounter where it belongs,
namely into the Code class. Use the null pattern to signal "no inlined Smi
code". Removed a few unused counters.
Review URL: http://codereview.chromium.org/
7273066
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8470
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
sgjesse@chromium.org [Wed, 29 Jun 2011 13:40:23 +0000 (13:40 +0000)]
Temporarily add more test output to help locate test failure
R=ricow@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org//
7250002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8469
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00