jnashok [Fri, 24 Jul 2015 07:41:21 +0000 (16:41 +0900)]
[Jira IOT-604] Fix error handling from message handler
This is a specific case where error hadling is not handled
Fixed the error in the send thread
Change-Id: I3f4d1983d379550ee6e72d95b9341da847fce47a
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1871
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
YounghyunJoo [Fri, 31 Jul 2015 11:12:46 +0000 (20:12 +0900)]
Modify PPM Sample Application & Plugins for updated base code
- Change CA connectivity type(CA_DEAFULT)
- Fix some errors on plugins
Change-Id: Idcb2d2dfb77f1c9e98686161e6989d6b96367ac4
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2022
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Fri, 31 Jul 2015 12:05:15 +0000 (21:05 +0900)]
[Resource encapsulation]Add check logic about whether cached resource exists or not.
Throw exception when getCachedData() is requested for non-cached resource.
Add interface for checking cached resource existence.
Mutex for attributes is moved into the class member variable.
Change-Id: I25a163bf6900dd23f14158f28808873059798845
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2024
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Fri, 31 Jul 2015 04:26:24 +0000 (13:26 +0900)]
[Resource Encapsulation]Clean up code on ResourceCache.
fix typing error.
Change-Id: I081f149e6fa38890afc8982655f0bdfcf1caac58
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2015
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>
YounghyunJoo [Fri, 31 Jul 2015 10:14:38 +0000 (19:14 +0900)]
Modify resourceCache codes to synchronize the cacheDataList and to avoid retransmission
- add std::mutex for synchronization of cacheDataList valuable
- add lastSequenceNum valuable to avoid retransmission
Change-Id: I19cc85084d916b91f359ca116e1b3ef69db2150b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2019
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Tested-by: Habib Virji <habib.virji@samsung.com>
Rami Jung [Thu, 30 Jul 2015 04:09:51 +0000 (13:09 +0900)]
[Resource-Encapsulation] compaction by reusing the definition of 'constexpr char KEY[]'
Change-Id: Ibfd7ad1cbf82652c6e30c584be5e0a920b44a228
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1985
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Ossama Othman [Mon, 27 Apr 2015 21:36:19 +0000 (14:36 -0700)]
Implemented Linux BLE transport.
This is an implementation of the proposed OIC Bluetooth Low Energy
transport for Linux.
Change-Id: Id105a1d7a86c59d41900c6e4b0fc1b0a60b97c75
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1125
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
doil.kwon [Thu, 30 Jul 2015 10:43:19 +0000 (19:43 +0900)]
Update 'resource broker' unit test code.
1. whether is called timeoutCB correctly or not when is occurred timeover about 'subscribe' request.
2. whether is called subscribeCB correctly or not when is request 'subscribe'.
3. whether is called timeoutCB correctly or not when is occurred timeover about 'get' request.
and, modify some bug.
this bug is not occurred problem at previous version.but correct this point in order to upgrade our unitTest'
performance.
add license comment and delete white space.
add api for 'device presence' in order to get device_state' value.
Change-Id: Ib265c6d529f84610cf134808bc5581377340bec6
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1987
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Mandeep Shetty [Thu, 30 Jul 2015 22:53:47 +0000 (15:53 -0700)]
Fixed arduino server sending notifications after deregister.
This fixes IOT-627.
Arduino server continuted to send observe notifications even after
client deregisters. This happened because a bool variable tracking if
light was under observation was not set to false.
Change-Id: Ic1f00915632251a9be8772ca3cc4b71373dc3b18
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2011
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Thu, 30 Jul 2015 18:47:40 +0000 (11:47 -0700)]
Fixed unprocessed timed-out messages in the stack.
The portion of messages in the retransmission queue did not have the
resourceUri. As a result timed-out messages when reported back to the RI
layer did not have the resource uri which failed a check on entry into
the RI layer.
This caused the server to not de-register observers and it continued to
send observation notifications to a client that is not reachable.
Removed the check for the resource uri to fix the issue.
Added check for presence of uri before comparing it with the presence
uri so presence responses can be handled separately.
This also fixes IOT-622.
Change-Id: Ie3873d02f4163b81094ca1983e79315b85ff4751
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1995
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 30 Jul 2015 18:57:01 +0000 (11:57 -0700)]
Added null checks post cbor processing.
This allows requests with null parameters to still operate.
This fixes IOT-632.
Change-Id: I6b7b1a48e1d50d34268e1f0fface38b5fd59cb02
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1993
Reviewed-by: Tim Kourt <tim.a.kourt@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwanseo [Wed, 29 Jul 2015 04:33:22 +0000 (13:33 +0900)]
updated the logic to combining block1 and block2 option
- fixed IOT-637 issue
Both the request and response may be large enough to
require the use of blockwise-transfer.
In this case, we should use the block1 and block2 option together.
- fixed IOT-635 issue
if a lot of ports is enable in IP adapter.
Token of CoAP can be used as blockID of BlockData set
since all messages have same Token in multicast
so Token + port have to be used.
- fixed klocworks data leak issue
in CAAddBlockSizeOption, option is created, but the actual option
doesn't have anything done with it.
Change-Id: I82808856c76cfd343c71460e303744b002d9a745
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tim Kourt [Thu, 30 Jul 2015 16:22:31 +0000 (09:22 -0700)]
Fixed a merge of OcConnectivityType and OcConnectivityFlags
throughout the android stack
A small Android API change was introduced as part of the merge: all discovery
calls now take a Set of OcConnectivtyTypes instead of a single enum.
In addition, it fixes a setHeaderOptions bug.
Change-Id: Ib269e39a0168055b4a1f46353cbd620fbff1dbad
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1992
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Wed, 29 Jul 2015 20:21:26 +0000 (13:21 -0700)]
Adding -Wextra to builds using -Wall in order to catch problems that
were being missed.
Change-Id: I4bf0ae091aa2c3da255a9c07b2290f32abf2d0f0
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1978
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
vimala.v [Wed, 29 Jul 2015 11:15:03 +0000 (16:45 +0530)]
[ARDUINO] Fixed send data failure in IP adapter
Change-Id: I8f3cbd6414fca8f92e22f5d3d7ce8c3eebcb4b71
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1975
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Thu, 30 Jul 2015 00:48:37 +0000 (17:48 -0700)]
Corrected a criticial OICRealloc() bug and a few misc issues.
- Fixed a problem wither OICRealloc() where it was returning the
old pointer instead of the sometimes-different new one.
- Removed some code duplication in #if/#else blocks.
- Fixed split declarations and later assignment. This step was the
one that made the OICRealloc() bug immediately visible.
- Updated OICFree() counting to match that in OICMalloc(), except
for the case of failed mallocs.
Change-Id: Ibdf8949d57e72821f0fea9e5c8ca607503ff14dc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1982
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
John Light [Tue, 28 Jul 2015 06:54:43 +0000 (23:54 -0700)]
Fix broken macros in octypes.h
Eliminate 16-bit definition of OCConnectivityType.
Repair macros used to build OCConnectivityType.
Change-Id: Ia1ff69f6bdab5d8d728cb33ea633a4ba9c3912d7
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1977
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sakthivel Samidurai [Thu, 30 Jul 2015 14:21:24 +0000 (07:21 -0700)]
Copy all items of CBOR string array
CBOR String array is coping only the first item.
Fix OCREP_PROP_STRING for string array to copy all items by
calling cbor_value_advance.
Change-Id: I1ea80e94cf21f746188af81dd946c474d8b00ba4
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1990
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
doil.kwon [Thu, 30 Jul 2015 05:36:17 +0000 (14:36 +0900)]
Update Log message for "resource Broker".
it will be shown when is called its related function.
and can be shown more detail(ex: the moment when is found item).
modify log message existing previously.
all log message will be shown before its related action' excution.
also delete white space.
Change-Id: Ibaf2c611ce17bb4635ebd6c68f530d5cc8a40b37
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1983
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
jnashok [Wed, 29 Jul 2015 10:56:11 +0000 (19:56 +0900)]
updating build instructions for casample
this helps in fixing some build problems
Change-Id: I4f424cfa8c4af6304d7da55c7b2947f3dfdbfebc
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1973
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Wed, 29 Jul 2015 22:22:51 +0000 (15:22 -0700)]
Clean up some SonarQube warnings (trailing whitespace, etc).
Clean up trailing whitespace and removed Windows line endings from
most text files to address SonarQube warnings. As a side effect of
this clean-up, several files that should not have been executable had
their executable permission bit removed.
Change-Id: Ie388df6e383219cdebfb56ba8fa86cacf2ca3e46
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1980
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jyong2.kim [Wed, 29 Jul 2015 10:52:48 +0000 (19:52 +0900)]
Fix invalid memory access on resource cache module.
invalidate callback in deleted instance.
Change-Id: Ica3028700935c0cef062719a43affc5f4754a336
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1972
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
koushik.girijala [Fri, 17 Jul 2015 11:52:43 +0000 (17:22 +0530)]
RI Sample for Tizen
working RI Sample for Tizen
Change-Id: Idba74286734d2159b128ddde55cc588bbb19cbea
Signed-off-by: vimala.v <vimala.v@samsung.com>
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1719
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
YounghyunJoo [Wed, 29 Jul 2015 10:01:56 +0000 (19:01 +0900)]
Modify resourceCache unittest buildscript to fix gcc bug
- on gcc-4.6 in linux 64bit environment, gcc bug is occurred.
To fix it, remove the '-Wnoexcept' option in the SConscript file
- additionally, remove constructor, destructor on the unittest class
to prevent build error(noexcept tag) on gcc-4.8
Change-Id: I411ca979e607cdfe33ea50f9fe32b88b434320ed
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1970
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Wed, 29 Jul 2015 01:18:39 +0000 (10:18 +0900)]
Modify DataCache code files to support thread synchronization
- add thread synchronization for the subscriberList
- modify notifyObservers()'s parameter to const variable
Change-Id: I13e18a56be2ec2f6e7e4c0eadc371161dc6b5f3b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
coderhyme [Tue, 28 Jul 2015 05:29:18 +0000 (14:29 +0900)]
Fix a callback problem of PrimitiveResource
The problem was calling the callback even after the object for it was gone.
PrimitiveResource is only created with shared_ptr and callbacks are async operations.
When received the response, there is a possibility that no one holds the resource.
Now checks the object is alive before executing the callback.
Change-Id: I07b20d251c2b8544e7d27f354193b53c910d579c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1950
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
jihwan.seo [Mon, 27 Jul 2015 12:08:13 +0000 (21:08 +0900)]
modified comment for doxygen.
Fixed several files with out of date or
incorrect doxygen comments
Change-Id: Iddd76b6aed32de74c819d3794e6845401561bae5
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1939
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
hyuna0213.jo [Mon, 27 Jul 2015 10:09:10 +0000 (19:09 +0900)]
modified Sconscript in Blockwise transfer
- BWT was not enabling in multiple selection case.
ex) TARGET_TRANSPORT=BLE,IP
- added PDU null checker. (fixed IOT-647 issue)
Change-Id: I2ea5439d57cae63e128d8afb1b2ff519e914c9ce
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1925
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hunje.yeon [Tue, 28 Jul 2015 05:02:14 +0000 (14:02 +0900)]
Add License notification to unit test codes of resource encapsulation
Insert License notification to Unit test codes
Change-Id: I7440b9f26147116f4f46644970b71309329400af
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1947
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Sachin Agrawal [Mon, 27 Jul 2015 21:33:35 +0000 (14:33 -0700)]
Add new resource property 'EXPLICIT_DISCOVERABLE'
Some resources (such as, SVR's) needs to be discovered only when
explicitly requested. This property allows the resource to be included
in discovery response only when explicitly requested via query filters.
Change-Id: I1adeffa0996ecf36ffdd9ebd3dbf9c32d9f3cc0d
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1680
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
sandipan.p [Mon, 27 Jul 2015 09:19:10 +0000 (14:49 +0530)]
Doxygen: Statement end with period ('.')
Change-Id: Ie023e6be66c739c701509a6365237e659205d6d3
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1934
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Markus Jung [Tue, 28 Jul 2015 01:03:33 +0000 (10:03 +0900)]
Including RCS prefix in ResourceContainer class name
Change-Id: Icc1c47349687911ed8ad878e6b0d546e177769a8
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1945
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Ashwini Kumar [Fri, 3 Jul 2015 12:10:19 +0000 (17:40 +0530)]
Fix set command line options for ANDROID_XXX into scons environment.
Due to this the android SDK, NDK and Gradle were downloaded even if
the options are specified on commandline.
Change-Id: I00564d62c8374b73f3b4b75b7d75735d0a49f16f
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1513
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Rami Jung [Mon, 27 Jul 2015 11:51:28 +0000 (20:51 +0900)]
expanding the coverage of testing RCSResourceObject.cpp
It calls both
addAttributeUpdatedListener(const std::string& key,AttributeUpdatedListener h)
addAttributeUpdatedListener(const std::string&& key,AttributeUpdatedListener h)
Change-Id: Ic46f85104fb4887515af9745b3dc11b3d90b9516
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1938
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Mon, 27 Jul 2015 13:30:21 +0000 (19:00 +0530)]
[Resource-Encapsulation] Modified Sample Application
Change-Id: If5c5e1118d9a423a4e7eb1611ac80f431bab0f20
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
sandipan.p [Mon, 27 Jul 2015 13:59:24 +0000 (19:29 +0530)]
Cleaning unused mutex variables for receiver handler.
Server Receiver Handler and Client Receiver Handler are
optimized and merged to a single function CALEDataReceiverHandler.
Change-Id: I633da97c4f6f1ff38efa3c81559223f51316de41
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1942
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Thu, 23 Jul 2015 08:48:44 +0000 (17:48 +0900)]
update android sample app
I have added some log for port number
since there is no way to know it.
Change-Id: I306d0d94ae1523d9de948465ec303d503111ff2f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1846
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
YounghyunJoo [Mon, 27 Jul 2015 11:50:20 +0000 (20:50 +0900)]
Modify resourceCache to handle datacache releasing exception
- catch release exception using try-cache
- clarify the exception discription of resourceCache
Change-Id: I865fc111c1fd8df05fb4e875109b339e99b744f8
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
doil.kwon [Mon, 27 Jul 2015 10:46:27 +0000 (19:46 +0900)]
Modify ResourcePresenceUnitTest Code
- There is Segmentation fault because it is used 'weak pointer' without non-pre used 'shared pointer'.
so ResourcePresence instance's type is changed 'low pointer' to 'shared pointer'
- ResourcePresence's logic was chaging. so UnitTest's logic was changing(used mocking api's order and number)
Change-Id: Ic7ab6ae24b4b7bcb671d11728d16d0031842e002
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1935
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
YounghyunJoo [Mon, 27 Jul 2015 07:41:22 +0000 (16:41 +0900)]
Update ResourceCache Unittest code files
Change-Id: Ic5dab8f0f90fad94f464c68b5ae608415547ed2b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1931
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
hunje.yeon [Mon, 27 Jul 2015 07:36:54 +0000 (16:36 +0900)]
Update Doxygen path for Resource-Encapsulation
Update header path of resource-encapsulation APIs in Doxyfile.
Fix broken API links of RCSDiscoveryManager, RCSRemoteResourceObject
Change-Id: I34671cbbde69fe0e1d616f1a789261ce28a41da6
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1930
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Markus Jung [Mon, 27 Jul 2015 03:43:30 +0000 (12:43 +0900)]
Fixing segmentation fault if container is started without configuration file.
https://jira.iotivity.org/browse/IOT-633
Change-Id: I3559719cf084e462260da55d0b54d0848767e09c
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1926
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jyong2.kim [Sun, 26 Jul 2015 14:24:45 +0000 (23:24 +0900)]
Resource Manipulation: resolve Jira issue IOT-641.
Prevent calling incorrect OC::Platform method.
Change-Id: Ie08b578ac04b768bdcb9404c557749a37acaaf41
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1921
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jon A. Cruz [Sat, 25 Jul 2015 00:32:06 +0000 (17:32 -0700)]
Fixed warning due to incorrect type and comparison order.
Change-Id: Ifb4a7c644c5599888b74895429eb2296ab2c9f57
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1900
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Sun, 26 Jul 2015 11:33:52 +0000 (17:03 +0530)]
[Resource-Encapsulation] Splitted Resource Client to 2 files
- RCSDiscoveryManager and RCSRemoteResourceObject
Change-Id: Iccf1aae4100eba313127fad33dd2adb8bb6bec64
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1914
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Sun, 26 Jul 2015 08:12:39 +0000 (13:42 +0530)]
[Resource Encapsulation] Updated Discover API of Resource Client for RCSAddress
- updated Resource Client, sample, UnittestCases
- added more Exception to Resource Client
Change-Id: Ib91934b372efe23f7a657152a63a9dd7aa5d06ce
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Sun, 26 Jul 2015 05:22:54 +0000 (14:22 +0900)]
Removed noexcept(true) descrutor from test classes
Change-Id: Ibbb00a3b84f33545b7ab441c6f985216a00150d9
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1906
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Fri, 24 Jul 2015 16:17:03 +0000 (01:17 +0900)]
Rename ResourceAttributes to RCSResourceAttributes
Prefix is added for consistency for exposed headers.
Change-Id: I4b038fe5fdd79bfbc6d5b8963491332a180b77a4
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1893
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Fri, 24 Jul 2015 16:14:27 +0000 (01:14 +0900)]
Rename BundleInfo to RCSBundleInfo and ResourceContainer to RCSResourceContainer
Prefixes are added for consistency for exposed headers as a part of API.
Change-Id: Ia968888331f27210e2c8ec00f3859ddadf3e2844
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1892
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Fri, 24 Jul 2015 16:07:20 +0000 (01:07 +0900)]
Rename ResourceObject to RCSResourceObject
Prefix is added for consistency for exposed headers
Change-Id: I8366dba5f404089237ac4b16f19a498a2179356c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1891
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Fri, 24 Jul 2015 13:10:39 +0000 (22:10 +0900)]
Add a comparison helper class for ResourceAttributes::Value
The hepler class is needed to avoid implicitly converting and comparing raw values,
because ResourceAttributes::Value has implicit constructors to make it easy to use.
Change-Id: Ie72524d9000f930e01e63b0f0e0384295ed4f41d
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1890
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
sandipan.p [Fri, 24 Jul 2015 04:11:52 +0000 (09:41 +0530)]
BLE De-fragmentation changes and optimization for receiver handler
Change-Id: If2217589eb7538018fa9e4e79ee55cd3bb52aed8
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1410
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jay Sharma [Fri, 24 Jul 2015 14:23:09 +0000 (19:53 +0530)]
[Resource-Manipulation] Renamed Resource-Manipulation to Resource-Encapsulation
Change-Id: I2520ee961d6556b26c3ba52be8e6d16238615d30
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1888
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
doil.kwon [Fri, 24 Jul 2015 09:52:19 +0000 (18:52 +0900)]
Modify UnitTest Code about "Resource Broker"
- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.6, 4.7, 4.8 gcc compiler
Change-Id: Ie4de09086ba737033f17f5d87bf1a809019351b6
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1878
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Fri, 24 Jul 2015 11:19:24 +0000 (20:19 +0900)]
resource-manipulation: rcs_common.so add missing depending library
rcs_common.so is also depending on liboc.so and libpthread.so, this
patch adds these dependencies to the build.
Add LIBPATH to make sure the libs will be found, this fixes a problem
in some jenkins tests.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: I753c5ec2d35876c789d93d843542344257f44c54
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1883
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Wed, 22 Jul 2015 21:05:19 +0000 (23:05 +0200)]
csdk: libconnectivity_abstraction.so: add missing depending library
libconnectivity_abstractionso depends on libcoap.so and librt.so when
build as shared lib, which is the case for the Tizen build. This patch
adds these dependencies to the build.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: Ib972be2b766d7fbccac9b246ae6f11e6182af94c
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1825
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Fri, 24 Jul 2015 10:23:14 +0000 (19:23 +0900)]
Update UnitTest Code about "Resource Cache"
- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.8 gcc compiler
Change-Id: I0d7f279c178a14eaef1b465ce3bce80253c97dae
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1880
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Fri, 24 Jul 2015 07:37:28 +0000 (16:37 +0900)]
Remove "define variables" on Notification Manager.
change anonymous namespace variables from define variables.
change macro to function in OIC::Service namespace.
Change-Id: I9d1e2a8d23d92b190b3255d21434c84efe359c73
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1875
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Tue, 21 Jul 2015 18:55:50 +0000 (20:55 +0200)]
resource-manipulation: libserver_builder.so add missing depending library
libserver_builder.so is also depending on liboc.so and
librcs_common.so, this patch adds these dependencies to the build.
liboctbstack.so is only needed when LOGGING=true is set. Without
liboctbstack.so libserver_builder.so misses the dependencies to the
OCLog and OCLogv symbols.
Add LIBPATH to make sure the libs will be found, this fixes a problem
in some jenkins tests.
pthread is added two times, once should be enough.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: I6af126eb4af975b7231d01df922885c7dec5fc56
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1799
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Tue, 21 Jul 2015 20:29:14 +0000 (22:29 +0200)]
soft-sensor-manager: libSSMCore.so: add missing depending library
libSSMCore.so also depends on libdl.so, this patch adds these
dependencies to the build.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: I76faff46fe96caef75fb6673c7e83d62b15b8489
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1796
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Tue, 21 Jul 2015 20:06:52 +0000 (22:06 +0200)]
things-manager: libTGMSDKLibrary.so: add missing depending library
libTGMSDKLibrary.so also depends on liboc.so, liboctbstack.so and
pthread, this patch adds these dependencies to the build.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: I174b38e747be247fc25544db629f8ad2b7eb5ef5
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1795
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Heewon Park [Fri, 24 Jul 2015 03:41:52 +0000 (12:41 +0900)]
Update ResourceObject Class.
Doxygen comments for ResourceObject.
Implement feature of autoNotify about if Attribute is deleted.
And add unit test about that case.
Change-Id: I03974b098c13d6d71a1dc209f5a7d41b289274aa
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1866
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
doil.kwon [Thu, 23 Jul 2015 07:10:31 +0000 (16:10 +0900)]
Update UnitTest Code about "Resource Broker"
- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.8 gcc compiler
Modify TestCase for DevicePresenceUnitTest.
Change-Id: Ia7ff55abc186c9dc388803ac967ed37c5d89ed73
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1843
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jyong2.kim [Thu, 23 Jul 2015 08:01:17 +0000 (17:01 +0900)]
Fix invalid memory access on resource broker module.
remove the duplicated memory access on list.
invalidate callback in deleted instance.
delete useless member variable on ResourcePresence class.
Change-Id: If6b3831fa2355140b23efdafc213615280e336ac
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1844
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Markus Jung [Thu, 23 Jul 2015 02:26:37 +0000 (11:26 +0900)]
Require explicit scons argument (containerJavaSupport=1) to include Java related code in resource container.
Further, added a fix of the ResoureContainerTest to be compatible with gcc 4.6. Removed virtual override usage.
More uniform API for whole resource-encapsulation module (using const string refererences).
Use test helper class to avoid gcc version problems.
Change-Id: I338ee7a7305a83f70babb7b07f9a542644f0c111
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1838
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Hauke Mehrtens [Tue, 21 Jul 2015 20:00:18 +0000 (22:00 +0200)]
build: make build fail if unresolved symbols found
gcc links shared libs also when there are still some unresolved
symbols, you have to specify it explicitly to make it fail in such
cases. I think a compiler should fail in such cases otherwise
someone will add some not intended dependencies or some existing
dependencies are not getting declared.
This patch makes gcc fail in such cases. I have only activated this for
libs build in a Linux build and explicitly deactivates it for windows
(does this even work at all?) This should be build tested with Android
also.
This was build tested for Linux and Android.
This patch depends on some other patches I send which are fixing the
problems I found with this change.
Change-Id: I9ab79896ca2e86e9226cd9b39060a0763ef89694
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1802
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Fri, 24 Jul 2015 00:59:45 +0000 (09:59 +0900)]
Modify service/SConscript file to support PPM for Android platform.
Change-Id: I6708ec0a2d69f0e0f974abfa81df62b27cd6575b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1842
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
coderhyme [Thu, 23 Jul 2015 07:55:02 +0000 (16:55 +0900)]
Update comments for ResourceAttributes
Now, ResourceAttributes has appropriate comments for doxygen
Change-Id: I4a8f3f8881117c4cb91a0d871e0549faa66bd047
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1849
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jon A. Cruz [Thu, 23 Jul 2015 00:45:56 +0000 (17:45 -0700)]
Corrected files with doxygen comments that were generating warnings.
Fixed several files with out of date or incorrect doxygen comments.
These included use of explicit tags (@fn, @var, @struct, etc.),
incorrect use of "[IN]" and "[OUT]", and other issues.
Aside from the problems actually marked in the output as warnings,
these issues were causing a large portion of the documentation to
be dropped silently.
Change-Id: I66027f4f98a6e82b7db826693b5ec1b1f30e58cf
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1836
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jon A. Cruz [Wed, 22 Jul 2015 19:36:28 +0000 (12:36 -0700)]
Fixed doxygen comments in camutex.h
Fixed problems with doxygen comments that included a few causing
outright errors and missing functions in the resulting
documentation.
- Removed use of '@' on local names instead of Doxygen keywords
which were causing errors.
- Prefixed '::' to types and enums that were not recongnized.
- Fixed typo in enum name
- Added missing periods at end of brief/summary prose.
Change-Id: I2731d9d5ebf10f738e387a1922027fb752a8a3be
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1834
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Jon A. Cruz [Wed, 22 Jul 2015 19:53:28 +0000 (12:53 -0700)]
Corrected @file doxygen commands that had explicit filenames that
were not valid.
Removed the explicit filename from @file doxygen commands where
the filenames were invalid and causing warnings. (In general the
@file command should be used by itself, with no explicit filename)
Change-Id: I0c3e3392b172c8760e0a281f0c3b293050bedabc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1835
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Thu, 23 Jul 2015 09:21:13 +0000 (18:21 +0900)]
Fixed CA linux sample bug for bulk data
we have to create text file for bulk data only.
so I fixed the condition for data size check.
Change-Id: I96f9441e475dbe67729391e29571cdb8ab443e21
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1847
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Wed, 22 Jul 2015 21:20:30 +0000 (14:20 -0700)]
Updated discovery response when filter query does not match.
Iotivity should respond to discovery requests in below manner:
If query filter matching fails (or if Server does not have
any DISCOVERABLE resources) and discovery request is multicast,
it should NOT send any response.
But, if the discovery request is unicast in above scenario,
it should send an error(RESOURCE_NOT_FOUND - 404) response with
empty payload.
Currently, Iotivity stack sends a response in all error scenarios
with return code as OC_EH_OK (along with some payload) which has
various drawbacks, such as, causes un-necessary traffic in the network
and also wastes power on constrained devices.
Change-Id: Ibb3bedc7b8ae67b708b89e9ad747c031ab552cae
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1766
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Omkar Hegde [Thu, 23 Jul 2015 21:35:40 +0000 (14:35 -0700)]
Changing resource "URL" to "URI"
We were logging the resource URI as URL which
was ambiguous for the test team.
Change-Id: I90e862cc35f3c1fd3ec2f3a95950668fb45d0134
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1861
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Joseph Morrow [Thu, 23 Jul 2015 20:17:34 +0000 (13:17 -0700)]
Finalizing CI build script changes.
This commit effectively only affects the Integration/Validation build.
This had to be done in steps to not break any of the ongoing pre-[build
script overhaul] work that were already in their merge-into-master
validation stages.
Change-Id: I3c32df57d526f7a34847a96f48814fd31f79e4fc
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1859
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Hauke Mehrtens [Tue, 21 Jul 2015 18:50:39 +0000 (20:50 +0200)]
liboc: add missing depending library
liboc.so depends on liboctbstack.so, liboc_logger.so and pthread, this
patch adds these dependencies to the build.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: I971b45669adef31dc9cca719884ebeb74aaf735e
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1794
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
John Light [Fri, 17 Jul 2015 14:39:15 +0000 (07:39 -0700)]
Eliminate warning about const mismatch in caipadapter (IOT-632)
Change-Id: I9c5afff53ded18b01467c0426c24876b219d7a34
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1858
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Hauke Mehrtens [Tue, 21 Jul 2015 20:45:40 +0000 (22:45 +0200)]
csdk: remove dependency to liboc_logger.so in c code
The liboc_logger.so is only used by the c++ part and not by the c part,
remove it from the c only part.
Change-Id: Ib0894974de8ef7150401f02fbd0ea864d1d6f2cd
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1801
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Omkar Hegde [Thu, 23 Jul 2015 18:11:50 +0000 (11:11 -0700)]
Removing unnecessary logs in message handler.
The "IN" and "OUT" tags give no useful information
and completely floods the debug mode. All the useful
information is already being logged within the function.
Change-Id: Ieac528913b659fbaccedcb465000f11f370b678a
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1816
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Wed, 22 Jul 2015 18:31:42 +0000 (11:31 -0700)]
Fix memory leak on OCDoResource
OCDoResource was leaking the generated payload each time, so
this fixes the issue by ensuring it is free'd at the end.
Change-Id: I693318bdcb6d7baa37a5397fab33b0fe4c784960
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1821
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Wed, 22 Jul 2015 21:36:30 +0000 (14:36 -0700)]
Clean up CBOR payload in Arduino sample app.
This effectively keeps Arduino server from crashing when it receives
+24 requests. Services bug IOT-484
(https://jira.iotivity.org/browse/IOT-484).
Change-Id: I1b651e560d935bc71c1b8a3aa5062c2162e313f7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1824
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Thu, 23 Jul 2015 15:55:31 +0000 (08:55 -0700)]
Fix Tizen Build
Hopefully fixes the Tizen build
Change-Id: Ic202729f4d6a571cfad18724da27e5295258a1e2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1854
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
YounghyunJoo [Thu, 23 Jul 2015 02:22:14 +0000 (11:22 +0900)]
Modify resourceCache Unittest code for gcc 4.6 version
remove override tag on the each test code.
Change-Id: I8a22c442c65a3f9099cbb9adcf6e40a518c4fd56
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1837
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Minji Park [Thu, 23 Jul 2015 03:40:27 +0000 (12:40 +0900)]
resource-manipulation: add unittest for container
- add unittest for dynamic bundle loading and resource registration
- update sample bundle used for unittest
Change-Id: I9a59ecd5cbd49a8adbff703d58c0cb72ff58687a
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ravi Nanjundappa [Tue, 21 Jul 2015 04:50:09 +0000 (10:20 +0530)]
resource-manipulation: Fix some typo errors
Fixed some typo in resource-manipulation scons script.
Change-Id: I64099f8b7d1ec18954e13d177b47d5c5cd73bfc8
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1773
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Wed, 22 Jul 2015 12:08:40 +0000 (21:08 +0900)]
Update PPM Android Sample Application for Updated CA API
OcConnectivityType Option on FindResource API(ALL to CT_ADAPTER_IP)
Change-Id: Ide07e1049ce505e03ceeb8ea934378935057d913
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1812
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Wed, 22 Jul 2015 12:34:04 +0000 (21:34 +0900)]
Remove boost library dependency on PPM module.
Change-Id: Ic8710ec19e0417d912869a0a24c7e476a932acf0
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1810
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Omkar Hegde [Wed, 22 Jul 2015 22:38:12 +0000 (15:38 -0700)]
Initialize response payload in entity handler
As no payload is set for observe deregister and the response
payload was uninitialized, the payload destroy method caused a
segfault. This fixes IOT-611.
Change-Id: I050587c18fee922bfe61522f3ba7af6a2b207b09
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1828
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Wed, 22 Jul 2015 16:20:11 +0000 (09:20 -0700)]
Fixed memory leak while sending the response in SRM
Dynamic memory was being allocated while forming the OCSecurityPayload
and was not freed. Also, updated code in ocserverrequest.c to replace
dynamic memory allocation with local variable on the function stack for
CAToken variable.
Change-Id: I4372fe46001c10cb68d069cae5916c8798913121
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1815
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Tue, 21 Jul 2015 10:55:36 +0000 (16:25 +0530)]
[ARDUINO][BLE] Changed UUID's as per OIC Spec
Updated RBL library patch to advertise new UUID's as per OIC spec
Change-Id: I50c50d59779922b2c16e86156fe43ec0a62cde52
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1781
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Wed, 22 Jul 2015 18:10:39 +0000 (11:10 -0700)]
Updated auto_build.sh for continuous integration improvements.
This commit effectively adds a new mode of building in the build
script. This new mode can be referenced as "parallel". Before all
builds occurred in sequence and could take a long time. Now an
individual contributor may build just a shim of the entire build
list. This will allow the Jenkins CI system to build each of the
shims in parallel to better utilize the several executors found
across the many build servers we have available for CI.
Change-Id: I945bc45201d8c3d4a5c754de02eaa623f59c8449
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1818
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Wed, 22 Jul 2015 17:25:48 +0000 (10:25 -0700)]
Fixed invalid write in doxmresource
The doxmresource was allocating based on the size of a short,
but the type was an enum. This adjusts the size to be correct.
Change-Id: Id0dcc26b346b2ef096992bd84173319ddce2c7e6
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1819
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Tue, 21 Jul 2015 11:19:47 +0000 (20:19 +0900)]
modified linux CA sample to handling blockwise-transfer
currently, CA sample send the fixed payload data.
so I modified the CA sample to send bulk data request and response
Change-Id: Icd94f5f0c56defe80890cf020f4413cbc4153f83
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1782
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Wed, 22 Jul 2015 02:49:01 +0000 (11:49 +0900)]
blockwise-transfer rebase into master for merge/review
- block option1, option2 can be supported
- size option can be supported
- late negotiation is supported
- IP tansport can be supported
- not supported in single threaded devices such as the Arduino Mega
- design document can be found on the link below
https://wiki.iotivity.org/proposal_for_block-wise_transfer
Change-Id: Iebaa23ff8a6c1e23ee9fa6e10c09d76385affb66
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Rami Jung [Wed, 22 Jul 2015 11:00:53 +0000 (20:00 +0900)]
adding UnitTest functions in Server Builder
-addAttributeUpdatedListener()
-removeAttributeUpdatedListener()
Change-Id: I3bc137c02d4b6d386b406ee0879242ea961ff085
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1811
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Ravi Nanjundappa [Tue, 21 Jul 2015 08:09:39 +0000 (13:39 +0530)]
Fix compiler warnings.
This fixes compiler warnings related to in csdk and services dirs.
- unused but set variables
- control reaching end of non-void functions
Change-Id: I98b83091dc97e059e2755b98e33aef209dbb5adb
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1778
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jay Sharma [Wed, 22 Jul 2015 15:28:54 +0000 (20:58 +0530)]
[Resource Manipulation] Integrated Resource Manipulation libraries into 4 categories
- rcs_server
- rcs_client
- rcs_common
- rcs_container
Change-Id: I262b7e9c57c48530e2128d14545c335c6a098223
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1814
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Tue, 21 Jul 2015 23:05:54 +0000 (16:05 -0700)]
Fixed build warnings due to assert, unused function, time
This fixes a handful of the warnings present on master.
Change-Id: Idc39f9c8f8c73e0107831bc340738028a1294604
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1804
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Omkar Hegde [Tue, 21 Jul 2015 22:17:05 +0000 (15:17 -0700)]
Default entity handler for collections
Adding default entity handler for collection C samples
in the case when the resource does not exist. This change
fixes IOT-628.
Change-Id: I4f060a856fd9bb712fc145a5c98081ecbe1fec7e
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1803
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Hauke Mehrtens [Tue, 21 Jul 2015 20:41:09 +0000 (22:41 +0200)]
protocol-plugin: libfanserver_mqtt_plugin.so and liblightserver_mqtt_plugin.so add missing depending library
libfanserver_mqtt_plugin.so and liblightserver_mqtt_plugin.so are also
depending on liboc.so and libcrypto.so, this patch adds these
dependencies to the build. In addition it puts the dependency to
mosquitto to the beginning of the list. This is needed because
mosquitto is a statically linked lib and it also has unresolved
symbols, but gcc only searches the dynamic libs defined after the
static for unresolved symbols in the static lib.
mosquitto was only build as a static linked library so we can use the
normal LIBS mechanism and it will be statically linked.
Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.
Change-Id: Ia130827d04bd3bb1a8863fc64d0097a076edc751
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1798
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
projects / platform / upstream / iotivity.git / log