platform/upstream/lmdb.git
11 years agoFix prev commit, cursor depth comparison
Howard Chu [Thu, 7 Nov 2013 17:37:48 +0000 (09:37 -0800)]
Fix prev commit, cursor depth comparison

11 years agoFix cursor_del0 cursor fixup
Howard Chu [Thu, 7 Nov 2013 00:49:25 +0000 (16:49 -0800)]
Fix cursor_del0 cursor fixup

Skip cursors that aren't as deep as current cursor

11 years agoMore for #7589
Howard Chu [Tue, 5 Nov 2013 04:00:55 +0000 (20:00 -0800)]
More for #7589

11 years agoITS#7589 another mdb_page_split fix
Howard Chu [Fri, 1 Nov 2013 00:31:15 +0000 (17:31 -0700)]
ITS#7589 another mdb_page_split fix

Tweak split_indx check, go one slot further.

11 years agoITS#7736 fix regression in ITS#7733 patch
Howard Chu [Thu, 31 Oct 2013 23:01:04 +0000 (16:01 -0700)]
ITS#7736 fix regression in ITS#7733 patch

In d8eccb353b1be7f07e74149dde9a41bb199d74e8

11 years agoITS#7733 check cursor index before cursor_del
Howard Chu [Mon, 28 Oct 2013 14:25:54 +0000 (07:25 -0700)]
ITS#7733 check cursor index before cursor_del

11 years agoITS#7734 Add MDB_NORDAHEAD to CHANGELESS.
David Wilson [Mon, 28 Oct 2013 13:58:04 +0000 (06:58 -0700)]
ITS#7734 Add MDB_NORDAHEAD to CHANGELESS.

11 years agoBump to 0.9.9
Howard Chu [Thu, 24 Oct 2013 22:57:17 +0000 (15:57 -0700)]
Bump to 0.9.9

11 years agoAdd mdb_env_get_fd()
Howard Chu [Mon, 21 Oct 2013 17:29:38 +0000 (10:29 -0700)]
Add mdb_env_get_fd()

Return the environment's filedescriptor. Useful when the caller
is doing their own locking.

11 years agoFix 01dfb2083dd690707a062cabb03801bfad1a6859
Howard Chu [Mon, 14 Oct 2013 16:47:26 +0000 (09:47 -0700)]
Fix 01dfb2083dd690707a062cabb03801bfad1a6859

USE_POSIX_SEM must define USE_HASH

11 years agoITS#7725 add MDB_NORDAHEAD flag for env_open
Howard Chu [Sat, 12 Oct 2013 23:20:04 +0000 (16:20 -0700)]
ITS#7725 add MDB_NORDAHEAD flag for env_open

11 years agoITS#7589 silence warnings
Howard Chu [Sat, 12 Oct 2013 20:40:28 +0000 (13:40 -0700)]
ITS#7589 silence warnings

11 years agoITS#7589 Fix typo in prev commit
Howard Chu [Sat, 12 Oct 2013 20:31:09 +0000 (13:31 -0700)]
ITS#7589 Fix typo in prev commit

11 years agoITS#7589 Cleanup unneeded vars in prev patch
Howard Chu [Sat, 12 Oct 2013 20:19:33 +0000 (13:19 -0700)]
ITS#7589 Cleanup unneeded vars in prev patch

11 years agoITS#7589 avoid wasting space in mdb_page_split
Howard Chu [Sat, 12 Oct 2013 16:34:40 +0000 (09:34 -0700)]
ITS#7589 avoid wasting space in mdb_page_split

Also, check the split point on branch pages as well as leaf pages.

11 years agoAdd MDB_USE_HASH
Howard Chu [Fri, 4 Oct 2013 17:22:14 +0000 (10:22 -0700)]
Add MDB_USE_HASH

There may be other uses for it besides semaphore names.

11 years agoITS#7722 fix page_merge for collapsing root
Howard Chu [Wed, 9 Oct 2013 09:24:45 +0000 (02:24 -0700)]
ITS#7722 fix page_merge for collapsing root

Other cursors being fixed up are not necessarily height 1.

11 years agoITS#7718 invalidate cursor when DB gets emptied
Howard Chu [Tue, 8 Oct 2013 11:43:58 +0000 (04:43 -0700)]
ITS#7718 invalidate cursor when DB gets emptied

11 years agoFix mdb_env_set_mapsize()
Howard Chu [Fri, 4 Oct 2013 09:55:34 +0000 (02:55 -0700)]
Fix mdb_env_set_mapsize()

Don't allow shrinking below minimum size for an already open env.

11 years agoITS#7715 always set filesize for WRITEMAP
Howard Chu [Fri, 4 Oct 2013 09:46:38 +0000 (02:46 -0700)]
ITS#7715 always set filesize for WRITEMAP

11 years agoAdd Caveat: Readers need write access. Whitespace.
Hallvard Furuseth [Thu, 3 Oct 2013 22:48:19 +0000 (00:48 +0200)]
Add Caveat: Readers need write access. Whitespace.

11 years agoMaintain MDB_cursor.mc_top
Hallvard Furuseth [Thu, 3 Oct 2013 21:59:25 +0000 (23:59 +0200)]
Maintain MDB_cursor.mc_top

11 years agomdb_cursor_sibling(): Fix error result
Hallvard Furuseth [Thu, 3 Oct 2013 21:59:25 +0000 (23:59 +0200)]
mdb_cursor_sibling(): Fix error result

11 years agomdb_node_add(): Plug page leak when MDB_PAGE_FULL.
Hallvard Furuseth [Thu, 3 Oct 2013 21:59:25 +0000 (23:59 +0200)]
mdb_node_add(): Plug page leak when MDB_PAGE_FULL.

Do not fail after mdb_page_new() succeeds.

11 years agoOptimize code holding reader mutex
Hallvard Furuseth [Thu, 3 Oct 2013 21:59:24 +0000 (23:59 +0200)]
Optimize code holding reader mutex

11 years agoSet MDB_xcursor DB_DIRTY, clear md_name.
Hallvard Furuseth [Thu, 3 Oct 2013 21:59:24 +0000 (23:59 +0200)]
Set MDB_xcursor DB_DIRTY, clear md_name.

Both were unused and md_name was unmaintained -- except
mdb_cursor_touch(xcursor) would abuse md_name as a key to
touch MAIN_DBI if it could somehow get passed ! DB_DIRTY.

11 years agoSet subDB DBI=parent DBI, fix MDB_DUPSORT delete.
Hallvard Furuseth [Thu, 3 Oct 2013 21:59:24 +0000 (23:59 +0200)]
Set subDB DBI=parent DBI, fix MDB_DUPSORT delete.

xcursor DBIs were parent DBI+1 for debugging. Instead output
-(parent DBI).  Fixes a crash in mdb_cursor_del0()'s xcursor
tracking, it forgot to subtract 1 for C_SUB cursors.

11 years agos/MDB_NORDLOCK/MDB_NOLOCK/
Howard Chu [Thu, 3 Oct 2013 17:26:44 +0000 (10:26 -0700)]
s/MDB_NORDLOCK/MDB_NOLOCK/

Leave all lock management to the caller.

11 years agoMore doc for MDB_NORDLOCK
Howard Chu [Wed, 2 Oct 2013 06:36:57 +0000 (23:36 -0700)]
More doc for MDB_NORDLOCK

11 years agoAdd MDB_NORDLOCK to omit all reader table usage
Howard Chu [Tue, 1 Oct 2013 20:16:38 +0000 (13:16 -0700)]
Add MDB_NORDLOCK to omit all reader table usage

Calling app wants to manage its own locking.

11 years agoDrop unneeded code.
Hallvard Furuseth [Mon, 23 Sep 2013 18:21:11 +0000 (20:21 +0200)]
Drop unneeded code.

MDB_txn.mt_toggle: Use (mt_txnid & 1) instead.
Drop error checks which will be repeated.
mdb_cursor_set(): Turn assert into if/return to match the above.
mdb_cursor_del(): 'flags' are now used as bitflags.

11 years agoClean up and simplify mdb_page_search().
Hallvard Furuseth [Mon, 23 Sep 2013 18:21:11 +0000 (20:21 +0200)]
Clean up and simplify mdb_page_search().

Only named DBs can have DB_STALE, and they do not use MDB_PS_MODIFY.
Replace magic key values with flags.  Drop duplicated comments at
mdb_page_search_root() vs. mdb_page_search(), and rephrase.

11 years agoTweak MDB_DEBUG output
Hallvard Furuseth [Mon, 23 Sep 2013 18:20:42 +0000 (20:20 +0200)]
Tweak MDB_DEBUG output

11 years agoRename SWAP() to avoid conflict with sqlightning.
Hallvard Furuseth [Mon, 23 Sep 2013 18:20:05 +0000 (20:20 +0200)]
Rename SWAP() to avoid conflict with sqlightning.

Happened since sqlightning #includes mdb.c, midl.c.

11 years agomdb_page_unspill(): Rename local vars.
Hallvard Furuseth [Mon, 23 Sep 2013 18:13:27 +0000 (20:13 +0200)]
mdb_page_unspill(): Rename local vars.

The names have caused bugs, "txn" was treated as
the current transaction.

11 years agoITS#7515 Fix mdb_page_unspill() in nested txn.
Hallvard Furuseth [Mon, 23 Sep 2013 18:13:27 +0000 (20:13 +0200)]
ITS#7515 Fix mdb_page_unspill() in nested txn.

Malloc a page in this txn, not in a parent.

11 years agoITS#7515 Fix mdb_txn_commit(nested txn with spills).
Hallvard Furuseth [Mon, 23 Sep 2013 18:13:27 +0000 (20:13 +0200)]
ITS#7515 Fix mdb_txn_commit(nested txn with spills).

Catch malloc error.
Fix hunt for dirty vs spilled pages: Don't leave x at a deleted pageno.
Cleanup: Factor out variables, squash pages already marked for deletion.

11 years agoITS#7515 Fix mt_dirty_room in nested txns.
Hallvard Furuseth [Mon, 23 Sep 2013 18:13:27 +0000 (20:13 +0200)]
ITS#7515 Fix mt_dirty_room in nested txns.

Fix description & code: Also ignore dirty pages hidden by
spilled pages, as they won't merge into our dirty_list.
Update it in mdb_page_flush() instead of mdb_page_spill().

11 years agoITS#7515 mdb_pages_xkeep(): Careful about xcursors.
Hallvard Furuseth [Mon, 23 Sep 2013 18:13:27 +0000 (20:13 +0200)]
ITS#7515 mdb_pages_xkeep(): Careful about xcursors.

Don't prod sub-pages or pages referring to uninitialized xcursors.

11 years agomdb_pages_xkeep(): Reformat, use common flag mask
Hallvard Furuseth [Mon, 23 Sep 2013 18:13:27 +0000 (20:13 +0200)]
mdb_pages_xkeep(): Reformat, use common flag mask

11 years agoUpdate MDB documentation and comments.
Hallvard Furuseth [Mon, 23 Sep 2013 18:09:47 +0000 (20:09 +0200)]
Update MDB documentation and comments.

11 years agoITS#7682 mdb_env_copy(): Avoid Linux O_DIRECT bug.
Hallvard Furuseth [Mon, 23 Sep 2013 18:07:29 +0000 (20:07 +0200)]
ITS#7682 mdb_env_copy(): Avoid Linux O_DIRECT bug.

Use fcntl() to set the flag.  Linux open(,O_DIRECT...) can create
the file even on failure, if the filesystem lacks O_DIRECT support.

11 years agoITS#7681 fix 18a07eb7c2dc33372455a6040984cd6b699b41a5
Howard Chu [Sun, 15 Sep 2013 20:08:29 +0000 (13:08 -0700)]
ITS#7681 fix 18a07eb7c2dc33372455a6040984cd6b699b41a5

Set rc=0 when taking the SET_RANGE branch

11 years agoITS#7701 fix mdb_rebalance
Howard Chu [Sat, 21 Sep 2013 21:37:11 +0000 (14:37 -0700)]
ITS#7701 fix mdb_rebalance

Must copy tmp cursor back to real cursor when merging into tmp cursor.

11 years agoRelease 0.9.8
Howard Chu [Mon, 9 Sep 2013 15:29:46 +0000 (08:29 -0700)]
Release 0.9.8

11 years agoupdates
Howard Chu [Thu, 5 Sep 2013 23:23:49 +0000 (16:23 -0700)]
updates

11 years agoITS#7682 In mdb_env_copy retry open if O_DIRECT fails
Salvador Ortiz [Thu, 5 Sep 2013 22:36:52 +0000 (17:36 -0500)]
ITS#7682 In mdb_env_copy retry open if O_DIRECT fails

11 years agoMore for 5f6fa8c04204888c4ff7ac6be1868d81ff4410a8
Howard Chu [Thu, 5 Sep 2013 13:02:07 +0000 (06:02 -0700)]
More for 5f6fa8c04204888c4ff7ac6be1868d81ff4410a8

Reset delete flag in cursor_put().

11 years agoITS#7681 fix mdb_cursor_set behaviour for MDB_SET_RANGE
Claude Brisson [Thu, 5 Sep 2013 10:58:18 +0000 (12:58 +0200)]
ITS#7681 fix mdb_cursor_set behaviour for MDB_SET_RANGE

11 years agoRemember if last cursor op was a delete
Howard Chu [Tue, 3 Sep 2013 23:10:20 +0000 (16:10 -0700)]
Remember if last cursor op was a delete

If so, don't advance cursor on next NEXT. Also, init xcursor
on the next GET_CURRENT.

11 years agoAdd a changelog
Howard Chu [Thu, 29 Aug 2013 03:22:41 +0000 (20:22 -0700)]
Add a changelog

11 years agoBump version to 0.9.8
Howard Chu [Thu, 29 Aug 2013 02:17:25 +0000 (19:17 -0700)]
Bump version to 0.9.8

11 years agoAllow mdb_env_set_mapsize() on an open environment
Howard Chu [Thu, 29 Aug 2013 02:12:59 +0000 (19:12 -0700)]
Allow mdb_env_set_mapsize() on an open environment

The caller is responsible for making sure no transactions are
active in this process before resizing. This is slightly lighter
weight than doing a full env_close/env_open cycle.

11 years agoITS#7672 fix mdb_dbi_flags
Howard Chu [Tue, 27 Aug 2013 13:28:30 +0000 (06:28 -0700)]
ITS#7672 fix mdb_dbi_flags

Use a txn instead of env argument. Only return persistent flags.

11 years agomdb_page_unspill(): Fix dirty_room in nested txn
Hallvard Furuseth [Sun, 25 Aug 2013 21:59:58 +0000 (23:59 +0200)]
mdb_page_unspill(): Fix dirty_room in nested txn

11 years agoAnother take on spill_pgs and deletes
Howard Chu [Sat, 24 Aug 2013 19:37:45 +0000 (20:37 +0100)]
Another take on spill_pgs and deletes

11 years agoCleanup prev commit
Howard Chu [Sat, 24 Aug 2013 18:54:05 +0000 (11:54 -0700)]
Cleanup prev commit

11 years agoSpeedup deletion from spill_pgs
Howard Chu [Sat, 24 Aug 2013 18:48:37 +0000 (19:48 +0100)]
Speedup deletion from spill_pgs

11 years agoITS#7671 always return the key for a dup val
Howard Chu [Fri, 23 Aug 2013 14:36:07 +0000 (07:36 -0700)]
ITS#7671 always return the key for a dup val

11 years agoITS#7670 Tweak cursor_del0
Howard Chu [Fri, 23 Aug 2013 04:43:29 +0000 (21:43 -0700)]
ITS#7670 Tweak cursor_del0

Always leave cursor pointing at "next" node, if any.
Find next sibling if we're already at end of current page.

11 years agomdb_page_spill(): Fix nested txn mt_dirty_room
Hallvard Furuseth [Fri, 23 Aug 2013 05:39:04 +0000 (07:39 +0200)]
mdb_page_spill(): Fix nested txn mt_dirty_room

11 years agoSimplify last commits
Hallvard Furuseth [Fri, 23 Aug 2013 05:37:17 +0000 (07:37 +0200)]
Simplify last commits

11 years agoTweak prev commit
Howard Chu [Fri, 23 Aug 2013 04:29:53 +0000 (21:29 -0700)]
Tweak prev commit

If somehow "need" is larger than the list size, don't
try to fake out the dirty list.

11 years agoLess aggressive page_spill
Howard Chu [Fri, 23 Aug 2013 01:51:48 +0000 (18:51 -0700)]
Less aggressive page_spill

spilling all possible pages is a waste because the majority will be
needed again. Just do 1/8th of the dirty list instead.

11 years agoUpdate caveats now that mdb_reader_check exists
Howard Chu [Wed, 21 Aug 2013 00:37:53 +0000 (17:37 -0700)]
Update caveats now that mdb_reader_check exists

11 years agoSilence warnings
Howard Chu [Wed, 14 Aug 2013 16:57:25 +0000 (09:57 -0700)]
Silence warnings

11 years agoTweak ITS#7615 fix: Obey strict-aliasing rules.
Hallvard Furuseth [Wed, 14 Aug 2013 13:21:59 +0000 (15:21 +0200)]
Tweak ITS#7615 fix: Obey strict-aliasing rules.

Do not access a long long as an array of longs.

11 years agoITS#7664 better fix
Howard Chu [Tue, 13 Aug 2013 20:12:47 +0000 (13:12 -0700)]
ITS#7664 better fix

For RDONLY, don't get lockfile until we know datafile exists.
Also, don't try to create a new datafile for me_mfd if someone
deleted it after we got me_fd.

11 years agoRevert "ITS#7664 delete lockfile if there is no environment"
Howard Chu [Tue, 13 Aug 2013 20:05:32 +0000 (13:05 -0700)]
Revert "ITS#7664 delete lockfile if there is no environment"

This reverts commit 8725838409512e999d78ea7b60773ce2f94d588f.

11 years agoITS#7664 delete lockfile if there is no environment
Howard Chu [Tue, 13 Aug 2013 18:34:32 +0000 (11:34 -0700)]
ITS#7664 delete lockfile if there is no environment

11 years agoFix uninit'd mem ref in mdb_page_split
Howard Chu [Mon, 12 Aug 2013 19:43:42 +0000 (12:43 -0700)]
Fix uninit'd mem ref in mdb_page_split

Don't compare cursors beyond their depth. (detected by valgrind)

11 years agoTweak NODUPDATA flag check
Howard Chu [Mon, 12 Aug 2013 00:25:00 +0000 (17:25 -0700)]
Tweak NODUPDATA flag check

Should allow for the possibility of future flag combos.

11 years agoFix obscure MDB_MULTIPLE bug
Howard Chu [Mon, 12 Aug 2013 00:15:03 +0000 (17:15 -0700)]
Fix obscure MDB_MULTIPLE bug

If a key has a single existing value, and then a put (MDB_MULTIPLE)
is done where the first of the multiple values matches the existing
value, the put would return SUCCESS without writing any of the
values. Fixed to loop to the next value as intended.

11 years agoPoint to mdb.c for docs on macros in Makefile
Howard Chu [Sat, 10 Aug 2013 21:55:51 +0000 (14:55 -0700)]
Point to mdb.c for docs on macros in Makefile

11 years agoAvoid compiling debug args with C90 compilers.
Hallvard Furuseth [Sat, 10 Aug 2013 11:50:10 +0000 (13:50 +0200)]
Avoid compiling debug args with C90 compilers.

Use double DPRINTF() parenthesis, so varargs macros are not needed.
Parenthesize MDB_DEBUG, in case the user defines it as foo || bar.

11 years agoRefuse ops on bad txns
Hallvard Furuseth [Sat, 10 Aug 2013 11:23:30 +0000 (13:23 +0200)]
Refuse ops on bad txns

11 years agoReplace EINVALs with generalized MDB_INCOMPATIBLE.
Hallvard Furuseth [Sat, 10 Aug 2013 11:23:30 +0000 (13:23 +0200)]
Replace EINVALs with generalized MDB_INCOMPATIBLE.

Also check xcursor instead of DUPSORT, it's slightly briefer.

11 years agoITS#7656 fix install target
John Hewson [Sat, 10 Aug 2013 11:12:42 +0000 (04:12 -0700)]
ITS#7656 fix install target

11 years agoITS#7660 Add mdb_txn_env to API
Salvador Ortiz [Fri, 9 Aug 2013 16:03:28 +0000 (11:03 -0500)]
ITS#7660 Add mdb_txn_env to API

11 years agomdb_txn_commit(): Always commit if MDB_TXN_SPILLS.
Hallvard Furuseth [Sat, 10 Aug 2013 10:29:45 +0000 (12:29 +0200)]
mdb_txn_commit(): Always commit if MDB_TXN_SPILLS.

Checking dirty_list was insufficient after a spill
with no named databases and no positioned cursors.

11 years agoITS#7661 mdb_dbi_flags(): Allow main DBI
Salvador Ortiz [Sat, 10 Aug 2013 07:42:19 +0000 (09:42 +0200)]
ITS#7661 mdb_dbi_flags(): Allow main DBI

11 years agomdb_del must ignore data if db not opened with MDB_DUPSORT
Salvador Ortiz [Fri, 9 Aug 2013 15:08:53 +0000 (10:08 -0500)]
mdb_del must ignore data if db not opened with MDB_DUPSORT

11 years agoAdd mdb_env_get_maxkeysize()
Howard Chu [Fri, 9 Aug 2013 11:51:33 +0000 (04:51 -0700)]
Add mdb_env_get_maxkeysize()

11 years agoReplace unpredictable EINVAL error returns.
Hallvard Furuseth [Fri, 9 Aug 2013 11:05:14 +0000 (13:05 +0200)]
Replace unpredictable EINVAL error returns.

Return EINVAL only for simple programmer errors.

11 years agoRe-fix reader-pid code
Hallvard Furuseth [Fri, 9 Aug 2013 10:54:42 +0000 (12:54 +0200)]
Re-fix reader-pid code

11 years agomdb_cursorpages_mark: Mark current txn and no more.
Hallvard Furuseth [Thu, 8 Aug 2013 17:57:52 +0000 (19:57 +0200)]
mdb_cursorpages_mark: Mark current txn and no more.

Ignore parent txn cursors since it is the current txn's dirty_list
which will be flushed. But check the current txn also when clearing,
since cursors can have pages which are dirty in a parent.

Check !mc_xcursor instead of !MDB_DUPSORT.  Equivalent for valid
data, but a bit safer if the sub-DB flags are corrupt.

11 years agoFix mdb_ovpage_free() vs. spill.
Hallvard Furuseth [Thu, 8 Aug 2013 17:57:52 +0000 (19:57 +0200)]
Fix mdb_ovpage_free() vs. spill.

Ensure me_pghead has room before removing from spill/dirty list.
Don't return pages to me_pghead in nested txns, use mt_free_pgs.

11 years agoFix page spilling when MDB_WRITEMAP.
Hallvard Furuseth [Thu, 8 Aug 2013 17:57:51 +0000 (19:57 +0200)]
Fix page spilling when MDB_WRITEMAP.

mdb_page_spill(): Don't binary-search the unsorted dirty_list.
mdb_page_flush(): Don't overwrite unprocessed dirty_list items.

11 years agoSet MDB_TXN_ERROR when inconsistent txn state
Hallvard Furuseth [Thu, 8 Aug 2013 17:57:51 +0000 (19:57 +0200)]
Set MDB_TXN_ERROR when inconsistent txn state

11 years agoFactor out MDB_env.
Hallvard Furuseth [Thu, 8 Aug 2013 17:54:54 +0000 (19:54 +0200)]
Factor out MDB_env.

11 years agoMDB_LOCK_VERSION -> MDB_LOCK_FORMAT.
Hallvard Furuseth [Thu, 8 Aug 2013 17:43:04 +0000 (19:43 +0200)]
MDB_LOCK_VERSION -> MDB_LOCK_FORMAT.

Pid locking needs a different lockfile-version: MDB_env's with and
without pid locking must not coexist, they can sabotage each other.
Store MDB_LOCK_FORMAT = (version | "use locking" flag) instead.

11 years agoFix mdb_reader_pid().
Hallvard Furuseth [Thu, 8 Aug 2013 17:43:04 +0000 (19:43 +0200)]
Fix mdb_reader_pid().

Treat unexpected errors as "don't know".  Invert Pidcheck return
value, so nonzero including error codes = "the process may exist".

On Windows: Catch exited but still existing processes.  Handle
undefined PROCESS_QUERY_LIMITED_INFORMATION.
On Unix: don't trust F_GETLK error to leave the input alone,
the fcntl() doc seems unclear.

11 years agoUse proper printf format on Windows
Howard Chu [Wed, 7 Aug 2013 19:42:46 +0000 (12:42 -0700)]
Use proper printf format on Windows

11 years agoSilence warnings
Hallvard Furuseth [Mon, 5 Aug 2013 08:01:39 +0000 (10:01 +0200)]
Silence warnings

11 years agoTweak comments
Hallvard Furuseth [Mon, 5 Aug 2013 07:55:57 +0000 (09:55 +0200)]
Tweak comments

11 years agoClarify doc: mdb_copy, nested txns, mdb_drop().
Hallvard Furuseth [Mon, 5 Aug 2013 07:55:48 +0000 (09:55 +0200)]
Clarify doc: mdb_copy, nested txns, mdb_drop().

mdb_copy: Does not copy lockfile. Can trigger file growth.
mdb_txn_begin(): Clarify usage restrictions.
mdb_drop(): State what to do rather than what will be done, since
closing the handle could otherwise be read as happening even at failure.

11 years agoTweak prev commit again
Howard Chu [Wed, 31 Jul 2013 15:09:40 +0000 (08:09 -0700)]
Tweak prev commit again

Make sure errors are propagated from init_meta

11 years agoFix typo in Win32 branch
Howard Chu [Tue, 30 Jul 2013 20:44:28 +0000 (13:44 -0700)]
Fix typo in Win32 branch

11 years agoCleanup prev commit
Howard Chu [Tue, 30 Jul 2013 19:47:12 +0000 (12:47 -0700)]
Cleanup prev commit

Loop on copyfd meta write, since pipes may return after partial write.

11 years agoITS#7652 fix I/O error checks
Howard Chu [Tue, 30 Jul 2013 17:22:12 +0000 (10:22 -0700)]
ITS#7652 fix I/O error checks

partial revert of d6d2638acc245116b8f091ac425b6700d06c4713 and
26a25df5fcc2fcddae6597a61c1b867fc27c568b

The original code was already tested and working correctly.