Mike Blumenkrantz [Fri, 28 Mar 2014 13:43:05 +0000 (09:43 -0400)]
stringshare_replace in fwin: it exists for a reason, stop using macros ffs
Mike Blumenkrantz [Fri, 28 Mar 2014 13:32:51 +0000 (09:32 -0400)]
bugfix: ibar now scrolls correctly during drags
fix T794
Stefan Schmidt [Fri, 28 Mar 2014 09:51:29 +0000 (10:51 +0100)]
music-control: Do not leak the allocated metadata strings
Fix for
ca07e7d505274377635fda2a79d8ac8c61877ea6
Thanks are going to Davide Andreoli for spotting it.
Stefan Schmidt [Fri, 28 Mar 2014 09:14:37 +0000 (10:14 +0100)]
modules/ibar: Fix condition check for edje emits
This fixes a copy and paste error which sneaked into
daa98e867d5340fac9ee087e637be38f653b01fe
CID 1194780
Mike Blumenkrantz [Fri, 28 Mar 2014 01:27:51 +0000 (21:27 -0400)]
never use new clients for stacking
fix Tcedric
Mike Blumenkrantz [Thu, 27 Mar 2014 23:47:31 +0000 (19:47 -0400)]
greatly improve child dialog placement, FIXME--
fix T980
Mike Blumenkrantz [Thu, 27 Mar 2014 21:01:22 +0000 (17:01 -0400)]
Revert "move comp object tiler creation to helper function to catch retries"
This reverts commit
f4e4b2fc4f0e9a1741f11bc945fb72c4b137ff9c.
testing commit that wasn't supposed to go upstream
Mike Blumenkrantz [Thu, 27 Mar 2014 20:54:58 +0000 (16:54 -0400)]
fix access module build
if nobody noticed this was even broken for 3 months, why is it still in the tree?
Mike Blumenkrantz [Thu, 27 Mar 2014 20:42:23 +0000 (16:42 -0400)]
ensure minimum X parent window size of 1x1
fix T1098
Mike Blumenkrantz [Thu, 27 Mar 2014 20:19:16 +0000 (16:19 -0400)]
move comp object tiler creation to helper function to catch retries
Mike Blumenkrantz [Thu, 27 Mar 2014 20:05:21 +0000 (16:05 -0400)]
don't refocus hidden clients on desk flip
probably fix T1083
Mike Blumenkrantz [Thu, 27 Mar 2014 20:02:27 +0000 (16:02 -0400)]
null check _evry_items_sort_func() for users with broken systems
fix T1125
Mike Blumenkrantz [Thu, 27 Mar 2014 19:58:39 +0000 (15:58 -0400)]
check key events for both key and keyname bindings
fix T1119
Mike Blumenkrantz [Thu, 27 Mar 2014 19:50:48 +0000 (15:50 -0400)]
ignore mouse movements on client during keyboard actions
fix T1097
Mike Blumenkrantz [Thu, 27 Mar 2014 19:45:45 +0000 (15:45 -0400)]
ignore X layer window mouse events
fix T1130
Mike Blumenkrantz [Thu, 27 Mar 2014 19:38:37 +0000 (15:38 -0400)]
always unclip/uneffect clients when changing desks
probably fix T1126
Mike Blumenkrantz [Thu, 27 Mar 2014 19:31:18 +0000 (15:31 -0400)]
redo input rects after comp effect layer changes
fix T1070
Mike Blumenkrantz [Thu, 27 Mar 2014 14:45:49 +0000 (10:45 -0400)]
remove invalid shelf autohide window check which would always be wrong
Mike Blumenkrantz [Thu, 27 Mar 2014 14:45:27 +0000 (10:45 -0400)]
disable comp object animation hooks if animations are disabled
Mike Blumenkrantz [Thu, 27 Mar 2014 13:59:48 +0000 (09:59 -0400)]
fix lots of edje emits on non-edje objects
Mike Blumenkrantz [Thu, 27 Mar 2014 13:29:56 +0000 (09:29 -0400)]
+e_icon_edje_get()
Stefan Schmidt [Thu, 27 Mar 2014 15:06:06 +0000 (16:06 +0100)]
tiling: Free allocated memory on error path.
We don't use new_node in this code path. Free before returning.
CID 1186205
Stefan Schmidt [Thu, 27 Mar 2014 11:47:21 +0000 (12:47 +0100)]
bugfix: music_control: Use correct markup for metadata text.
We piped the plain metadata text to edje TEXTBLOCK which might interpret
some of the characters as markup. Better convert it to the correct markup
first. The actual bug case was a & in the metadata cut off the rest of
the text. Now we get the correct & before sending it of to edje.
Fixes T1061
Gwanglim Lee [Thu, 27 Mar 2014 07:37:39 +0000 (07:37 +0000)]
Added a '--disable-wl-x11' to avoid build break since wl-x11 module has a dependency to ECORE_X_EVENT_XKB_STATE_NOTIFY
Summary: Resolved a build break when building e with wayland only options
Test Plan: building e with wayland only options
Reviewers: raster, devilhorns
Reviewed By: devilhorns
CC: cedric
Differential Revision: https://phab.enlightenment.org/D670
Carsten Haitzler (Rasterman) [Wed, 26 Mar 2014 06:32:53 +0000 (15:32 +0900)]
don't delete client objects when _e_client_hook_call returns false.
_e_client_hook_call() returns false when object refcount hit 0... ie..
it's been deleted. it's simply invalid memory access to then del the
object thats already gone to 0 refcount and been deleted/freed.
Carsten Haitzler (Rasterman) [Tue, 25 Mar 2014 13:44:04 +0000 (22:44 +0900)]
tasks - fix tasks on other screens to properly show all window content
this fixes T1120
Mike Blumenkrantz [Mon, 24 Mar 2014 16:36:29 +0000 (12:36 -0400)]
bump efl req version
Mike Blumenkrantz [Mon, 24 Mar 2014 16:33:48 +0000 (12:33 -0400)]
use eo to shut up harmless eo menu errors
Mike Blumenkrantz [Mon, 24 Mar 2014 16:32:06 +0000 (12:32 -0400)]
add eo headers, aka Captain #define
Sebastian Dransfeld [Mon, 24 Mar 2014 12:26:20 +0000 (13:26 +0100)]
ilist: Remove unused assignment
CID 1039758
Sebastian Dransfeld [Mon, 24 Mar 2014 12:23:39 +0000 (13:23 +0100)]
fm: Check return of strrchr
strrchr can return NULL, so we need to check the return value.
CID 1039861
Sebastian Dransfeld [Mon, 24 Mar 2014 12:20:25 +0000 (13:20 +0100)]
fm: Fix weird test
ic is always true for this function, else dereference would fail. So the
only valid thing to check is whether we already have a drop_icon.
CID 1039829
Sebastian Dransfeld [Mon, 24 Mar 2014 12:13:53 +0000 (13:13 +0100)]
dialog: allow setting of NULL icon
If NULL is passed as icon, icon should be disabled.
CID 1039951
Sebastian Dransfeld [Mon, 24 Mar 2014 12:02:56 +0000 (13:02 +0100)]
comp: no need to assign pointer before return
As we return after the list free, no need to set the pointer.
CID 1087717
Sebastian Dransfeld [Mon, 24 Mar 2014 11:59:14 +0000 (12:59 +0100)]
systray: deref pointer after check
CID 1193253
Mike Blumenkrantz [Thu, 20 Mar 2014 18:06:19 +0000 (14:06 -0400)]
set wayland display socket based on e_ipc_socket name
Mike Blumenkrantz [Thu, 20 Mar 2014 17:29:02 +0000 (13:29 -0400)]
export e_ipc_socket filename as extern variable
Tom Hacohen [Thu, 20 Mar 2014 16:10:24 +0000 (16:10 +0000)]
Tiling: start migrating the code to use smart callbacks.
Those are meant to be better than the e hooks.
Mike Blumenkrantz [Thu, 20 Mar 2014 15:38:58 +0000 (11:38 -0400)]
hook sticky smart callbacks properly inside comp object
Mike Blumenkrantz [Thu, 20 Mar 2014 15:29:28 +0000 (11:29 -0400)]
add stick/unstick client smart callbacks
Stefan Schmidt [Thu, 20 Mar 2014 14:50:51 +0000 (15:50 +0100)]
e_pointer: Fix missing if for else if condition
Fixing devilhorns commit and run commit. If we have a condition we want
to check we need an else if not a simple else. Always compile before push.
Especially the small and simple changes. :)
Chris Michael [Thu, 20 Mar 2014 14:15:47 +0000 (14:15 +0000)]
bugfix: Properly hide/show pointer_image & pointer_object based on if
the pointer is located on an existing canvas
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 20 Mar 2014 14:14:31 +0000 (14:14 +0000)]
bugfix: Set pass_events and layer of the pointer image if we are
creating a new one.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Cedric BAIL [Thu, 20 Mar 2014 11:46:54 +0000 (20:46 +0900)]
e: let's just completely blacklist NVidia driver for Wayland.
Chris Michael [Thu, 20 Mar 2014 10:17:46 +0000 (10:17 +0000)]
bugfix: Fix crash on eglTerminate with buggy Nvidia blob driver
NB: Thanks for the report cedric ;)
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 19 Mar 2014 08:36:34 +0000 (08:36 +0000)]
Don't leak the allocated client object if we are returning null from
e_client_new
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Wed, 19 Mar 2014 08:16:54 +0000 (08:16 +0000)]
Use ecore_wl functions to return the pointer location if we are
running as wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Sebastian Dransfeld [Wed, 19 Mar 2014 12:35:37 +0000 (13:35 +0100)]
randr: Update lid status when outputs change
If we only have lid, it will be active even though lid is closed. If we
connect a monitor we want the lid to deactivate.
Chris Michael [Wed, 19 Mar 2014 07:47:20 +0000 (07:47 +0000)]
Fix the "Fix more wayland crashes" commit so that we can build for
wayland-only again
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Tue, 18 Mar 2014 22:15:24 +0000 (18:15 -0400)]
fix more wayland crashes
Mike Blumenkrantz [Tue, 18 Mar 2014 20:14:04 +0000 (16:14 -0400)]
enabling drm output module should NOT require X-less build.
these defines all need to be changed from HAVE_WAYLAND_ONLY to something like WITH_X or we're going to have lots of problems with xwayland later on
Mike Blumenkrantz [Tue, 18 Mar 2014 17:22:11 +0000 (13:22 -0400)]
systray stop crashing in wayland!!!!
Chris Michael [Tue, 18 Mar 2014 09:14:58 +0000 (09:14 +0000)]
Merge branch 'devs/devilhorns/drm'
Chris Michael [Tue, 18 Mar 2014 09:11:28 +0000 (09:11 +0000)]
Add a README for Wayland-only support
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 18 Mar 2014 07:41:47 +0000 (07:41 +0000)]
@bugfix: Set ecore_wayland into 'server mode' before we call init so
that it does not stall and we end up sitting forever.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 13:57:56 +0000 (13:57 +0000)]
@bugfix: Check return of e_comp_wl_init and initialize ecore_wl library
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 13:56:35 +0000 (13:56 +0000)]
@bugfix: Create window pointer for wayland clients
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 13:55:38 +0000 (13:55 +0000)]
@bugfix: Initialize the module idler even If we are wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 13:52:12 +0000 (13:52 +0000)]
@bugfix: Only load external compositing modules if we are wayland-only
@bugfix: Initialize e_comp_wl if we are wayland-only OR supporting
wayland clients.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 13:49:51 +0000 (13:49 +0000)]
@bugfix: Build the wayland desktop shell module if we are Either
building for wayland clients, or building for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 09:07:06 +0000 (09:07 +0000)]
@bugfix: Fix e_win elm window trapping for wayland-only
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 08:41:20 +0000 (08:41 +0000)]
Simplify e_canvas_new code slightly for wayland-only and
wayland-client support.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 17 Mar 2014 08:38:15 +0000 (08:38 +0000)]
@bugfix: Fix pointer to work in drm and also fix some formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 11 Mar 2014 11:24:41 +0000 (11:24 +0000)]
@bugfix: Fix building for WAYLAND_ONLY by using the proper define
sed -i 's/WAYLAND_ONLY/HAVE_WAYLAND_ONLY/g'
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 11 Mar 2014 11:22:51 +0000 (11:22 +0000)]
@bugfix: Fix configure.ac to define HAVE_WAYLAND_ONLY
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 11 Mar 2014 09:01:01 +0000 (09:01 +0000)]
@feature: Add new drm compositing module
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Mike Blumenkrantz [Mon, 17 Mar 2014 16:56:21 +0000 (12:56 -0400)]
ignore size change configurerequests during maximize if not also changing position
correcty fixes gtk window (un)maximize
Mike Blumenkrantz [Mon, 17 Mar 2014 16:49:44 +0000 (12:49 -0400)]
Revert "apply client resize limit for all possible size values during maximize calcs"
This reverts commit
08acb0c6aae2ea63309d48d24ff83a77f63acb78.
fix T1102
Mike Blumenkrantz [Mon, 17 Mar 2014 16:23:07 +0000 (12:23 -0400)]
bugfix: get entry width based on viewport size, not entry size
things like icon properties dialog now fit on a 4k monitor
Mike Blumenkrantz [Fri, 14 Mar 2014 16:38:01 +0000 (12:38 -0400)]
fix elm win usage
Mike Blumenkrantz [Fri, 14 Mar 2014 16:00:23 +0000 (12:00 -0400)]
don't change backlight on zone shutdown
Mike Blumenkrantz [Fri, 14 Mar 2014 15:42:09 +0000 (11:42 -0400)]
ibar mouseover menu no longer breaks when client menu is activated
Carsten Haitzler (Rasterman) [Fri, 14 Mar 2014 15:00:27 +0000 (00:00 +0900)]
part of previous commit - also set delete_requested to 0
Gustavo Sverzut Barbieri [Fri, 14 Mar 2014 14:51:31 +0000 (11:51 -0300)]
configure: allow to specify different systemd units dir, print sysactions.
I don't install to the system, so that way I can install to
~/.config/systemd/user.
also print the sysaction commands so we can be sure what it is using.
Gustavo Sverzut Barbieri [Fri, 14 Mar 2014 14:50:10 +0000 (11:50 -0300)]
m4/ac-plugins: evaluate color escape so it works everywhere.
the color escapes were being evaluated only on "echo -e", but we're
using it in "cat" statements as well. Then evaluate the color escape
so it will work everywhere.
Gustavo Sverzut Barbieri [Sat, 8 Mar 2014 20:56:54 +0000 (17:56 -0300)]
fix @dataroot@ missing warning.
As per autoconf[1] documentation, we should declare @datarootdir@ so
it uses the new convetion of expression @datadir@ as terms of
@datarootdir@.
[1] http://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Changed-Directory-Variables.html
Mike Blumenkrantz [Fri, 14 Mar 2014 13:51:26 +0000 (09:51 -0400)]
fix client resistance visibility check typo
fix T1087
Carsten Haitzler (Rasterman) [Fri, 14 Mar 2014 07:25:14 +0000 (16:25 +0900)]
fix hiding of windows when delete is requested
this is applicable to e19 only (you can't backport this patch as-is -
e19 is too different). this fixes T1063.
Mike Blumenkrantz [Thu, 13 Mar 2014 17:10:55 +0000 (13:10 -0400)]
prevent fallthrough in determining gcc visibility
CID 1040127
Mike Blumenkrantz [Thu, 13 Mar 2014 17:09:43 +0000 (13:09 -0400)]
add note about switch statement fallthrough
CID 1040128
Mike Blumenkrantz [Thu, 13 Mar 2014 17:07:33 +0000 (13:07 -0400)]
bugfix: don't deref teamwork pointer after null check
CID 1040134
Mike Blumenkrantz [Thu, 13 Mar 2014 17:06:08 +0000 (13:06 -0400)]
bugfix: don't deref possibly-null value in mouse bindings
CID 1040138
Mike Blumenkrantz [Thu, 13 Mar 2014 17:00:57 +0000 (13:00 -0400)]
replace ev->keyname with ev->key
see efl
5ae4cfd1923e502731f4d8fc2bf67b1f536a9216
Mike Blumenkrantz [Thu, 13 Mar 2014 16:55:24 +0000 (12:55 -0400)]
remove unnecessary battery_config null check
CID 1040140
Mike Blumenkrantz [Thu, 13 Mar 2014 16:52:36 +0000 (12:52 -0400)]
validate params for e_dnd_util_text_uri_list_convert()
CID 1040144
Mike Blumenkrantz [Thu, 13 Mar 2014 16:50:18 +0000 (12:50 -0400)]
clamp screen sizes to 1 to avoid impossible division-by-zero for window shots
CID 1040148
Mike Blumenkrantz [Thu, 13 Mar 2014 16:44:47 +0000 (12:44 -0400)]
bugfix: correctly calculate minimum flowlayout rows
CID 1132740
Mike Blumenkrantz [Thu, 13 Mar 2014 16:41:53 +0000 (12:41 -0400)]
bugfix: efm_op no longer tries to close invalid fds during delete ops
CID 1132741
Mike Blumenkrantz [Thu, 13 Mar 2014 16:40:27 +0000 (12:40 -0400)]
bugfix: don't use external log domain in systray
CID 1132742
Mike Blumenkrantz [Thu, 13 Mar 2014 16:38:22 +0000 (12:38 -0400)]
bugfix: don't use external log domain in music player
CID 1132743
Mike Blumenkrantz [Thu, 13 Mar 2014 16:33:35 +0000 (12:33 -0400)]
bugfix: don't crash when saving screenshots with no file extension
CID 1132744
Mike Blumenkrantz [Thu, 13 Mar 2014 16:28:36 +0000 (12:28 -0400)]
bugfix: don't crash on possibly-null gadman bg string extensions
CID 1132749
Mike Blumenkrantz [Thu, 13 Mar 2014 16:22:04 +0000 (12:22 -0400)]
check X comp_data existence in pixmap PRESENT usage during refresh
CID 1155279
Mike Blumenkrantz [Thu, 13 Mar 2014 16:18:21 +0000 (12:18 -0400)]
add comments to suppress false positives in intentional switch fallthroughs
CIDs 1155283, 1155282, 1155281
Mike Blumenkrantz [Thu, 13 Mar 2014 16:15:52 +0000 (12:15 -0400)]
don't check for non-pointer existence in lokker pin validation
CID 1155284
Mike Blumenkrantz [Thu, 13 Mar 2014 16:15:11 +0000 (12:15 -0400)]
fix gadman resistance checking for fake/desk shelves
Mike Blumenkrantz [Thu, 13 Mar 2014 16:11:06 +0000 (12:11 -0400)]
improve client positioning resistance accuracy for hidden clients and fake shelves
Mike Blumenkrantz [Thu, 13 Mar 2014 16:07:49 +0000 (12:07 -0400)]
use E_CLIENT_FOREACH macro for resist calcs
CID 1155285
Mike Blumenkrantz [Thu, 13 Mar 2014 16:06:04 +0000 (12:06 -0400)]
null check auth current user get
CID 1155286
Mike Blumenkrantz [Thu, 13 Mar 2014 16:04:48 +0000 (12:04 -0400)]
null check client on X stack request
CID 1155287