dotnet-maestro[bot] [Tue, 5 Mar 2019 19:17:12 +0000 (19:17 +0000)]
[master] Update dependencies from dotnet/core-setup (dotnet/corefx#35713)
* Update dependencies from https://github.com/dotnet/core-setup build
20190301.13
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27501-13
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27501-13
* Remove workaround for System.Runtime.CompilerServices.Unsafe
* Update dependencies from https://github.com/dotnet/core-setup build
20190302.8
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27502-8
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27502-8
* Update dependencies from https://github.com/dotnet/core-setup build
20190303.9
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27503-9
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27503-9
* Update dependencies from https://github.com/dotnet/core-setup build
20190304.10
This change updates the following dependencies
- Microsoft.NETCore.App - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHost - 3.0.0-preview4-27504-10
- Microsoft.NETCore.DotNetHostPolicy - 3.0.0-preview4-27504-10
* Don't include EventRegistrationToken on Unix
This type was accidentally duplicated between CoreLib and contracts.
Suppress that for now since we're detecting the duplication in the shared framework.
Make a fix in the shared items to restore the condition on this type.
Commit migrated from https://github.com/dotnet/corefx/commit/
ae1426803f77356a7bed0b14c505c8b6030b3a6e
David Fowler [Tue, 5 Mar 2019 18:10:09 +0000 (10:10 -0800)]
Fix issue with BufferSegment reuse (dotnet/corefx#35779)
- We stored the last examined segment to compute how many bytes we should decrement on the writer side but if that segment is returned to the segment pool, we end up in a bad state. This properly clears the state so that doesn't happen.
Commit migrated from https://github.com/dotnet/corefx/commit/
c6b999d77e6f7e36851523662a9471e343555e16
Jeremy Barton [Tue, 5 Mar 2019 17:21:27 +0000 (09:21 -0800)]
Fix Linux chain.ChainStatus when multiple layers have errors
The recent chain rewrite caused only the last layer with errors to be reported.
Commit migrated from https://github.com/dotnet/corefx/commit/
fc9629cae7bfcda2196b24ba5127265efce1716a
Eric StJohn [Tue, 5 Mar 2019 16:48:42 +0000 (08:48 -0800)]
Allow CreateRelationship to work with FileAccess.Write (dotnet/corefx#35763)
When adding a relationship InternalRelationshipCollection was creating a part
but not writing anything to it. This caused an empty entry to be created in
the zip archive which later needed to be rewritten. That's disallowed with
FileAccess.Write. Instead, avoid creating the entry until it's content is
written.
When writing a relationship file InternalRelationshipCollection was attempting
to truncate any existing content. This throws when the package is open with
FileAccess.Write since the part stream is not seekable. Don't do the seek
when package is open for FileAccess.Write since no pre-existing content is
possible.
In Package.PartExists don't attempt to get the part. PartExists on .NETCore
only needs to query its local list of parts. Since it isn't returning a
mutable part, it doesn't need to throw for packages opened with FileAccess.Write.
Avoid out of bounds exception when enumerating part keys. The fix that delays
creating the relationship part until its content exposed an issue in
DoOperationOnEachPart. This was creating a copy of the part keys, but then
enumerating over the length of original list instead of the copy. Since I
delayed the creating of a part until it was flushed this made the length change
while iterating the loop. Since this code was using its copied list of keys
it should have never been using the original bounds.
Commit migrated from https://github.com/dotnet/corefx/commit/
1822fec76a7bc02764ffa94c0e1f97b8ebfdbdea
Tomas Weinfurt [Tue, 5 Mar 2019 03:28:24 +0000 (19:28 -0800)]
disable AllHelperPortsAreInGetPortNames on ARM Windows (dotnet/corefx#35773)
Commit migrated from https://github.com/dotnet/corefx/commit/
8a730a6ecd96fef04d74e1807c8b1d193e0a5f16
Aaron Robinson [Tue, 5 Mar 2019 00:41:37 +0000 (16:41 -0800)]
Update API for new RCW license impl in coreclr (dotnet/corefx#35767)
Commit migrated from https://github.com/dotnet/corefx/commit/
4f9e62149207fb1bbef18426bb302cea6869b78a
Adeel Mujahid [Mon, 4 Mar 2019 23:30:57 +0000 (01:30 +0200)]
Adhere to desktop implementation of [Can]ConvertFrom (dotnet/corefx#35760)
* Adhere to desktop implementation of [Can]ConvertFrom
* Add tests for InstanceDescriptor in TypeConverter
Commit migrated from https://github.com/dotnet/corefx/commit/
f603cea8ca5bdb62b33b0d67c67ab84d6d50300f
Tomas Weinfurt [Mon, 4 Mar 2019 23:27:20 +0000 (15:27 -0800)]
Disable alpine39 (dotnet/corefx#35770)
* disable alpine3.9
Commit migrated from https://github.com/dotnet/corefx/commit/
ad13ae9528b0717b74aefa929ea933e6db50cf5d
Viktor Hofer [Mon, 4 Mar 2019 22:19:26 +0000 (23:19 +0100)]
Update adding-api-guidelines.md
Commit migrated from https://github.com/dotnet/corefx/commit/
f75d8e8d9cb48abe623cf43f649fc49b6b8435d8
Clinton Ingram [Mon, 4 Mar 2019 22:07:01 +0000 (14:07 -0800)]
Update brotli to v1.0.7 (dotnet/corefx#35172)
* update to brotli v1.0.7
* update WithState perf test to use compressLevel arg
* update brotli-version.txt
Commit migrated from https://github.com/dotnet/corefx/commit/
6ad08fec6cd1fcb7348dfe60fda775ca69476a8d
Daniel Turan [Fri, 1 Mar 2019 08:08:40 +0000 (09:08 +0100)]
removed test from full .net framework
Commit migrated from https://github.com/dotnet/corefx/commit/
cb726dd396dc70d87a9cf69a1e84f05e8ecc224a
Daniel Turan [Fri, 1 Mar 2019 08:05:42 +0000 (09:05 +0100)]
Ignored tests for custom ValidationResults on .NET Framework, since it is not supported there
Commit migrated from https://github.com/dotnet/corefx/commit/
f2e274bd435c3494dd6b22883b3b589bea5cde6e
Daniel Turan [Wed, 27 Feb 2019 08:01:42 +0000 (09:01 +0100)]
Removed extra leading space
Commit migrated from https://github.com/dotnet/corefx/commit/
959cdfac0744b0a12c41fa06b9f5df55a91ff415
Daniel Turan [Tue, 26 Feb 2019 11:52:15 +0000 (12:52 +0100)]
Adding support for custom ValidationResult (derived class) in CustomValidationAttribute
Commit migrated from https://github.com/dotnet/corefx/commit/
27af01cb476debb4e791e3a8305bed279efecfbc
Stephen Toub [Mon, 4 Mar 2019 20:13:52 +0000 (12:13 -0800)]
Use C# async iterator to implement ChannelReader.ReadAllAsync (dotnet/corefx#35745)
While the hand-written implementation is a bit faster than what the compiler currently generates, it's also a lot more code, and complex, error-prone code. Better to go with the simpler implementation, and work to improve the compiler for the future.
Commit migrated from https://github.com/dotnet/corefx/commit/
0ce020951d5956916a9084820cefe3684d19f856
slozier [Mon, 4 Mar 2019 18:55:12 +0000 (13:55 -0500)]
SBCSCodePageEncoding: Don't call DecoderFallback.CreateFallbackBuffer until needed (dotnet/corefx#35199)
* Don't call DecoderFallback.CreateFallbackBuffer until needed
* Use null instead of fallbackBuffer
Commit migrated from https://github.com/dotnet/corefx/commit/
5419ecd858d11f08938019ba49477039de93ec3f
Viktor Hofer [Mon, 4 Mar 2019 17:44:25 +0000 (18:44 +0100)]
Remove SharedFrameworkValidation (dotnet/corefx#35747)
Commit migrated from https://github.com/dotnet/corefx/commit/
365e78019c73158fa8819141a3191b0e9c1493d1
hamish-rose [Mon, 4 Mar 2019 16:03:27 +0000 (05:03 +1300)]
Add tests for dotnet/coreclrdotnet/corefx#20815 - new Math and MathF rounding modes (dotnet/corefx#33297)
* add tests for new midpointrounding modes
new tests added for Math.cs double Round methods
* add tests for float, decimal
convert to theory
* Update tests
tests now reflect correct rounding behavior
* add tests for existing modes
* code review feedback
- refactor tests to use member data
- move MathF tests to MathF.netcoreapp.cs
- add tests for new modes with digits and special cases
* move math tests to mathtests.netcoreapp.cs
netcoreapp specific tests moved
Commit migrated from https://github.com/dotnet/corefx/commit/
cc42bb95b0877a653d4f556a0839d261ea3563b7
Stephen Toub [Mon, 4 Mar 2019 00:22:23 +0000 (19:22 -0500)]
Avoid NullReferenceException in BinaryObjectInfo (dotnet/corefx#35740)
A corrupted BinaryFormatter stream can result in a BinaryObjectInfo getting constructed before the ObjectManager is constructed, resulting in the BinaryObjectInfo not having a reference to the ObjectManager. Attempts to use it then hit a null reference exception.
Commit migrated from https://github.com/dotnet/corefx/commit/
7622efd2dbd363a632e00b6b95be4d990ea125de
Viktor Hofer [Sun, 3 Mar 2019 17:55:25 +0000 (18:55 +0100)]
Project msbuild syntax cleanup (dotnet/corefx#35686)
* Remove license header from non-shipping files
* Remove obsolete Project attributes
* Remove xml header and remove DefaultTargets
Commit migrated from https://github.com/dotnet/corefx/commit/
c390ce7df50252e11f5d322276e9d19e046d1332
Viktor Hofer [Sun, 3 Mar 2019 17:43:07 +0000 (18:43 +0100)]
OSX to macOS rename in dev guide
Commit migrated from https://github.com/dotnet/corefx/commit/
9f22abfdf98d79dc4ffbc8d77a1de41da519b6bd
Viktor Hofer [Sun, 3 Mar 2019 17:41:19 +0000 (18:41 +0100)]
Update developer-guide to address workflow changes
Commit migrated from https://github.com/dotnet/corefx/commit/
255ec6fb26d5efd3154047641aba031bb2303ad5
David Fowler [Sun, 3 Mar 2019 08:16:33 +0000 (00:16 -0800)]
Revisit back pressure implementation (dotnet/corefx#35711)
- Today when using a PipeReader from a Pipe, when the pause threshold is hit and the reader does not consume enough data to unblock the writer (enough to reduce the resume threshold) an exception is thrown. This exception is extremely hard to understand and work around since it's based on a limit set by the owner of the Pipe. It leads to people setting an extremely big limit (bigger than the biggest message) or disabling the limit completely.
- The changes the back pressure mechanic to be based on examined instead of consumed. This pauses the writer if the pause threshold is hit, but lets the reader continue to buffer until a logical payload is reached (whatever matters to the protocol).
- This breaks software that relied on these limits to enforce a maximum buffer size and those pieces of code need to now handle their own maximum buffer size.
Commit migrated from https://github.com/dotnet/corefx/commit/
ce278ee840561e90b2c6bb9daaee5ff4b9cce293
Dan Moseley [Sun, 3 Mar 2019 03:55:06 +0000 (19:55 -0800)]
Add Windows ARM64 to official builds (dotnet/corefx#35721)
* Add Windows ARM64 to official builds
* Add ARMxx properties
* Disable WMI tests for ARMxx
Commit migrated from https://github.com/dotnet/corefx/commit/
1d6287840322200f6b83d7c459588a23666df3bd
Stephen Toub [Sun, 3 Mar 2019 03:07:24 +0000 (22:07 -0500)]
Improve assert error message in Process tests (dotnet/corefx#35725)
Commit migrated from https://github.com/dotnet/corefx/commit/
9a542f020ed230888cb956c90494910bfc9035c0
danmosemsft [Sat, 2 Mar 2019 23:26:32 +0000 (15:26 -0800)]
Get RH6 outerloop clean
Commit migrated from https://github.com/dotnet/corefx/commit/
21799a3c1613285a90398eb3cf9ce41d704e786b
Hugh Bellamy [Sat, 23 Feb 2019 12:54:12 +0000 (12:54 +0000)]
PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
3814b5fcea2a215f7f0a34f6d944fda711e27cd8
Hugh Bellamy [Mon, 4 Feb 2019 19:51:38 +0000 (19:51 +0000)]
Fix null reference exceptions in TypeConverter
Commit migrated from https://github.com/dotnet/corefx/commit/
a7d0e7b048a549fbce55831d60e19e0e36f33851
Hugh Bellamy [Mon, 4 Feb 2019 19:51:17 +0000 (19:51 +0000)]
Add support for param name for netcore-only exception
Commit migrated from https://github.com/dotnet/corefx/commit/
fa4ae94b220d477b4c8eef2a290542585f50c81c
Steve Harter [Sat, 2 Mar 2019 19:20:34 +0000 (13:20 -0600)]
Initial Json serialization functionality (dotnet/corefx#35609)
Commit migrated from https://github.com/dotnet/corefx/commit/
20657b549ab4de422c3f7a9c50e22bf4d7f789a5
Ahson Khan [Sat, 2 Mar 2019 05:43:59 +0000 (21:43 -0800)]
Move MaxDepth setting to JsonReaderOptions from the JsonReaderState (dotnet/corefx#35312)
* Move MaxDepth setting to JsonReaderOptions from the JsonReaderState.
* Update JsonDocument to support custom MaxDepth
* Address PR feedback.
* Address feedback - cleanup tests and remove unnecessary condition
Commit migrated from https://github.com/dotnet/corefx/commit/
e1a355dd81f61e32500769b23ccbea2cb3331003
Grant [Sat, 2 Mar 2019 04:01:53 +0000 (20:01 -0800)]
Make BitOperations public (CoreFX) (dotnet/corefx#35606)
* Add ref assembly class
* Add [CLSCompliantAttribute(false)]
* Change name to System.Numerics.BitOperations
* Move ref to System.Runtime.Extensions
Commit migrated from https://github.com/dotnet/corefx/commit/
0ae011a57253959b79c952219c5fa16389255b7b
Jeremy Kuhne [Sat, 2 Mar 2019 00:58:36 +0000 (16:58 -0800)]
Fix ImplicitMachineConfigHost parameter checking (dotnet/corefx#28894)
* Fix ImplicitMachineConfigHost parameter checking
Don't assume index of the ConfigurationFileMap in params
Fixes: dotnet/corefx#28784
Commit migrated from https://github.com/dotnet/corefx/commit/
63e052c114b3555c5e595348cc92e4dd3cc0e755
John Salem [Sat, 2 Mar 2019 00:22:29 +0000 (16:22 -0800)]
Make Stacktrace Symbols Cache Aware of Unloadability (phase 1) (dotnet/corefx#35541)
Adds GetSourceLineInfo overload that consumes an Assembly, but does not use it. A follow-up change will use that assembly for caching the MetadataReaderProvider.
dotnet/coreclrdotnet/corefx#20179
Commit migrated from https://github.com/dotnet/corefx/commit/
fa2a3ea5be4a317402e47674c9a1286da24c6d68
Geoff Kizer [Fri, 1 Mar 2019 23:40:58 +0000 (15:40 -0800)]
Merge pull request dotnet/corefx#35623 from MarcoRossignoli/fixuseragentparsing
Fix bug: UserAgent malformed parsing
Commit migrated from https://github.com/dotnet/corefx/commit/
cb54ad963cc655d4c783033a2ab3dc3576d0dc65
Jan Kotas [Fri, 1 Mar 2019 21:59:19 +0000 (13:59 -0800)]
Fix netfx build break
Commit migrated from https://github.com/dotnet/corefx/commit/
524afe84f963b2a87230b19838e72174d4fa90f9
Jan Kotas [Fri, 1 Mar 2019 23:24:44 +0000 (15:24 -0800)]
Cleanup System.Runtime and System.Runtime.Extensions refs (dotnet/corefx#35704)
Commit migrated from https://github.com/dotnet/corefx/commit/
d733469bd423e48ded1a34fad15c062738954437
Marco Rossignoli [Fri, 1 Mar 2019 22:11:29 +0000 (23:11 +0100)]
continue parsing after nested call
Commit migrated from https://github.com/dotnet/corefx/commit/
b2865f5e4dcda0a3745b96d704aebec82ab22d60
Tanner Gooding [Fri, 1 Mar 2019 22:06:35 +0000 (14:06 -0800)]
Adding parsing tests to validate we consider enough significant digits to always round correctly. (dotnet/corefx#35701)
Commit migrated from https://github.com/dotnet/corefx/commit/
34118b74d46129b3095e1b4dbad8441c4db62e33
Santiago Fernandez Madero [Fri, 1 Mar 2019 22:06:14 +0000 (14:06 -0800)]
Add Pull Request Builds documentation (dotnet/corefx#35672)
* Add Pull Request Builds documentation
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
f709c1014e9ee854af1945e83219b573d0a46252
Eric StJohn [Fri, 1 Mar 2019 21:40:45 +0000 (13:40 -0800)]
Remove InitTools and ToolsDir (dotnet/corefx#35677)
* Remove buildtools init-tools and various BuildTools specific properties
* Workaround NuGet restore GeneratePathProperty case-sensitivity
See https://github.com/NuGet/Home/issues/7843
Commit migrated from https://github.com/dotnet/corefx/commit/
e7159674bb5bd2ac3688dd0789efb45e5de62299
Viktor Hofer [Fri, 1 Mar 2019 21:39:06 +0000 (22:39 +0100)]
Move dir.traversal.targets to eng (dotnet/corefx#35684)
Commit migrated from https://github.com/dotnet/corefx/commit/
32724ccf66bfdb4a48e8745ca4bc07480d15805a
Jan Kotas [Fri, 1 Mar 2019 21:10:15 +0000 (13:10 -0800)]
Add test to verify that DangerousRelease preserves Marshal.GetLastWin32Error (dotnet/corefx#35612)
Commit migrated from https://github.com/dotnet/corefx/commit/
d6db020cc7c66f95b0695e03b997936b3cf1f610
Eric StJohn [Fri, 1 Mar 2019 18:09:59 +0000 (10:09 -0800)]
Consume optimization data from bar & cleanup standard repo consumption (dotnet/corefx#35675)
* Consume optimization data from bar & cleanup standard repo consumption
* Remove restoresources from optimizationData.depproj
Commit migrated from https://github.com/dotnet/corefx/commit/
6bc5f9e37ae26eb3ceead1a1c0afac81166b3c8c
Stephen Toub [Fri, 1 Mar 2019 18:02:15 +0000 (13:02 -0500)]
Re-enable BeginSendFile tests (dotnet/corefx#35696)
Commit migrated from https://github.com/dotnet/corefx/commit/
560bbb1f5906ea4ff7f9a6888bf8fe083cf94087
Liudmila Molkova [Fri, 1 Mar 2019 17:15:03 +0000 (09:15 -0800)]
Fix minor Activity W3C format issues (dotnet/corefx#35650)
* Fix minor W3C Activity format issues
* undo csproj changes
* review nits
* review: parentSpanId invalid
* add security safe critical attributes, fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
ba5d02d92ecdf5ee902f8e4b348bc0ffd2a34a96
Stephen Toub [Fri, 1 Mar 2019 16:57:55 +0000 (11:57 -0500)]
Fix XmlWriterTraceListenerTests handling of DateTime (dotnet/corefx#35692)
Some of these tests compare a textual date time from an XmlWriterTraceListener (which internally uses DateTime.Now) against a textual date time from a TraceEventCache (which internally uses DateTime.UtcNow). This means that there's a few hour window (depending on time zone) at the transition of every month where the months end up differing and the test fails.
The tests also have a bug in that the format string used is buggy and isn't actually resulting in day and year being included, just month. And further, even if the time zones are fixed, it's still possible but rare that taking the Now at two different moments could straddle a boundary. So, rather than comparing ToStrings, we just compare the DateTimes, albeit with an allowed window.
Commit migrated from https://github.com/dotnet/corefx/commit/
1b80f1e1da2630b8fe877a35c285d9c4ffe9f2ce
Stephen Toub [Fri, 1 Mar 2019 15:38:45 +0000 (10:38 -0500)]
Merge pull request dotnet/corefx#35655 from dotnet/darc-master-
7c963d5e-3797-4b68-9fad-
354784eeb96a
[master] Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
d1d5e038f37bddce4b3a7910b684d9d4936e2a09
Stephen Toub [Fri, 1 Mar 2019 15:38:01 +0000 (10:38 -0500)]
Merge branch 'master' into darc-master-
7c963d5e-3797-4b68-9fad-
354784eeb96a
Commit migrated from https://github.com/dotnet/corefx/commit/
c523e9a012be1a8ab76df474d66ca0be81c606f1
Viktor Hofer [Fri, 1 Mar 2019 14:06:07 +0000 (15:06 +0100)]
Move codeanalysisruleset to src (dotnet/corefx#35687)
Commit migrated from https://github.com/dotnet/corefx/commit/
9940166bff52155600f25f15da13a83c982526d2
Stephen Toub [Thu, 28 Feb 2019 15:57:01 +0000 (10:57 -0500)]
Adapt corefx to recent coreclr changes
Commit migrated from https://github.com/dotnet/corefx/commit/
feb6eb3db7ca0a886f08ecd1eb259e0ae8ca434c
Tom Deseyn [Fri, 1 Mar 2019 12:30:16 +0000 (13:30 +0100)]
TestCheckChildProcessUserAndGroupIdsElevated: handle GetGroups returning the same group several times (dotnet/corefx#35680)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd9e7342508a05782446572baa3353b9a00cf6dd
Viktor Hofer [Fri, 1 Mar 2019 11:14:48 +0000 (12:14 +0100)]
Delete old vssettings in favor of editorconfig (dotnet/corefx#35683)
Commit migrated from https://github.com/dotnet/corefx/commit/
49c86d5fd8120a972d13229e4f36dedfdf6a477c
Levi Broderick [Thu, 14 Feb 2019 01:39:52 +0000 (17:39 -0800)]
Add ref asm + tests for creating Rune instances from surrogates
Commit migrated from https://github.com/dotnet/corefx/commit/
99436aa00c3772f852d8801f4879869df7cf26c8
Stephen Toub [Fri, 1 Mar 2019 01:05:06 +0000 (20:05 -0500)]
Add missing license headers
Add missing license headers, and make the asn.xslt generator do it going forward.
Commit migrated from https://github.com/dotnet/corefx/commit/
5dc8132370532804a5381b90e2ce87d6c52b61f6
Eric StJohn [Fri, 1 Mar 2019 00:41:22 +0000 (16:41 -0800)]
Ensure ZipPackage can handle file lengths over int.MaxValue … (dotnet/corefx#35660)
* Ensure ZipPackage can handle file lengths over int.MaxValue when using FileAccess.Read and FileAccess.Write.
This helps unblock the scenario of using large files with System.IO.Packaging
FileAccess.Write was completely broken before because ZipPackage would create an entry
and immediately delete it, which is disallowed when you're writing an archive. This
was a porting error, the desktop code had this under an else that was incorrectly removed.
Additionally when reading an archive with a large file, accessing the length of the
stream would cause the entire stream to be read into memory uncompressed and
overflow since this used a MemoryStream backed by a int.max-limited managed array.
Instead use the length info from the archive entry.
* Fix new packaging tests on desktop, respond to CR feedback
Desktop does not support FileAccess.Write on Package.Open: it throws when attempting to
create the ZipArchive. It only supports FileAccess.Read or FileAccess.ReadWrite.
Also clean up the test code.
* Code review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
125eac5808fc63bde5c238acdbaba9cac055855e
Tanner Gooding [Fri, 1 Mar 2019 00:28:30 +0000 (16:28 -0800)]
Removing the ExtractVector128 and InsertVector128 APIs that take an address. (dotnet/corefx#35596)
Commit migrated from https://github.com/dotnet/corefx/commit/
2104ad984999fec501cf060e6b6ab7f74c0b0558
Tomas Weinfurt [Fri, 1 Mar 2019 00:18:41 +0000 (16:18 -0800)]
pull in yet another updated Alpine image (dotnet/corefx#35674)
* pull in updated images with LANG set
Commit migrated from https://github.com/dotnet/corefx/commit/
b9710cb25b86ef4da002949df2dee1d63933734d
Viktor Hofer [Thu, 28 Feb 2019 17:55:25 +0000 (18:55 +0100)]
Allow single hyphen arguments in bash build (dotnet/corefx#35628)
* Allow single hyphen arguments in bash build
* Add clean switch
* Darc update from build '
20190228.2'
Commit migrated from https://github.com/dotnet/corefx/commit/
76e08b605f237bffb74283d83241eaadc4e7ce93
Tomas Weinfurt [Thu, 28 Feb 2019 17:13:57 +0000 (09:13 -0800)]
pull in Alpine image with LANG fix (dotnet/corefx#35657)
Commit migrated from https://github.com/dotnet/corefx/commit/
6ff8bf5722ffdb5b1386b062a12f9d59c3adea87
Marco Rossignoli [Thu, 28 Feb 2019 15:13:24 +0000 (16:13 +0100)]
add some tests
Commit migrated from https://github.com/dotnet/corefx/commit/
12fc04b6f8c20d901f9c89a1b8d8a540fa22dd0d
Jeremy Barton [Thu, 28 Feb 2019 11:31:06 +0000 (03:31 -0800)]
Fix the SslStream order of intermediate certificates with long chains (dotnet/corefx#35641)
Commit migrated from https://github.com/dotnet/corefx/commit/
b30e7723c98a6e7da0fa7d6edd4a54643275afad
Aaron Robinson [Thu, 28 Feb 2019 05:50:57 +0000 (21:50 -0800)]
Update LicenseInterop API (dotnet/corefx#35577)
* Clean up the Interop helper API for managed COM server activation via IClassFactory2.
Commit migrated from https://github.com/dotnet/corefx/commit/
bf09f74c8fe5b6094771266e6beeb36e7447b252
Ahson Khan [Thu, 28 Feb 2019 03:41:48 +0000 (19:41 -0800)]
Avoid re-scanning the whole input ROSequence when getting position in Utf8JsonReader (dotnet/corefx#35310)
* Make sure SequencePosition is saved as part of JsonReaderState
* Avoid rescanning whole ROSequence when getting position.
* We don't guarantee the position for invalid JSON.
* Remove isSingleSegment check when getting position and add single
segment tests
* Address feedback: remove else block and add some comments.
Commit migrated from https://github.com/dotnet/corefx/commit/
b85d017ecac090e6966822f159b48e7edfef37ce
Ahson Khan [Thu, 28 Feb 2019 03:39:21 +0000 (19:39 -0800)]
Auto-generate the reference assemblies and separate type forwards (dotnet/corefx#35557)
* Auto-generate the reference assemblies
* Add back type forwards.
* Revert "Add back type forwards."
This reverts commit dotnet/corefx@
3acf74aabb2e3ba90ac7280d541723d13d72c74a.
* Add back TypeForwardedTo in .Forward.cs files
* Add new type forward files to the csproj files
* Add back if-defs and move TestUtilities comment from ref to source
* Remove duplicate definitions, delete unnecessary manual files,
* Fix build breaks
* Add back missing AsyncMethodBuilderAttr to S.Runtime ref
* Fix typo between XmlDocument and XPath.XDocument
* Add type forward fild missed from previous commit
* Fix ECDiffieHellmanCngPublicKey internal ctor for netfx 4.6.1
* Remove "this type was moved to comments" from the type forwards.
* Add back the Xml and Debugger* attributes to Xml.ReaderWriter
* Add back struct layout attributes
* Add back attributes missing (highlighted from api compat)
* Add missing toolbox item attribute in s.data.common.
* Add missing struct layout attributes and remove unnecessary additions
* Add back InterfaceTypeAttribute
Commit migrated from https://github.com/dotnet/corefx/commit/
16689aa0a933517dc45465fc6edb6223222414a6
Tom Deseyn [Thu, 28 Feb 2019 02:55:26 +0000 (03:55 +0100)]
Process: Unix: use groups of ProcessStartInfo.UserName (dotnet/corefx#34961)
* Process: Unix: use groups of ProcessStartInfo.UserName
* PR feedback
* Fix OSX build
* Fix OSX build II
* Fix OSX build III
* Set ngroups to -1 on error
* Handle setgroups EPERM with fallback to process groups
* pal_process: handle zero groups length
This is for completeness, managed code calls this with at least one group: the primary group of the user.
* Remove uid_t and gid_t sizeof asserts
* Determine user ids using 'id' command
* Deal with OSX and musl specifics
* Try to fix OSX TestStartWithNormalUser by handling setgroups EINVAL
* Fix UnauthorizedAccessException for ExceptionFile when RemoteInvoke as sudo
* OSX getgrouplist is not thread safe
* Try to fix Ubuntu 18.10 test failures
* Refactor RunTestAsSudo to use RemoteInvoke child Process checking
* Try to fix OSX 13.10 fails
* Update test for truncated groups
* Extend tests
* Try fix/debug OSX test fail
* Test: special case OSX for getgrouplist truncate
* PR feedback
* Improve groups checking: O(N*M) to O(N*log(M))
Commit migrated from https://github.com/dotnet/corefx/commit/
b10e8d67b260e26f2e47750cf96669e6f48e774d
Tomas Weinfurt [Thu, 28 Feb 2019 00:52:54 +0000 (16:52 -0800)]
pull updated Alpine3.9 image one more time (dotnet/corefx#35639)
Commit migrated from https://github.com/dotnet/corefx/commit/
94322619b200b05dbb9a386db391407f97ebefa2
Jeremy Kuhne [Thu, 28 Feb 2019 00:33:56 +0000 (16:33 -0800)]
Fix advance for single length delimiter (dotnet/corefx#35597)
* Fix advance for single length delimiter
If the delimiter span for TryReadTo was only one character long we weren't advancing past the delimiter if requested. Add regression test.
* Address feedback
* Scan from beginning as well
Commit migrated from https://github.com/dotnet/corefx/commit/
b0bc99d6f7943a8081a84bea23c5542831c9359e
Afsaneh Rafighi [Wed, 27 Feb 2019 20:55:57 +0000 (12:55 -0800)]
update SqlClient Area Owners (dotnet/corefx#35634)
Commit migrated from https://github.com/dotnet/corefx/commit/
5aeccae0ab98af86e56043c1017474b7c05358e0
Tomas Weinfurt [Wed, 27 Feb 2019 19:46:57 +0000 (11:46 -0800)]
update container name (dotnet/corefx#35631)
* pul in updated Alpine39 image
* images no longer published to old place
Commit migrated from https://github.com/dotnet/corefx/commit/
417c3b8a97b29f7c5c1d25d5f7357b387bc5a68b
Tomas Weinfurt [Wed, 27 Feb 2019 17:37:56 +0000 (09:37 -0800)]
pul in updated Alpine39 image (dotnet/corefx#35627)
Commit migrated from https://github.com/dotnet/corefx/commit/
cbb3159d041c4489ced4ef7142a40a86aa54e35f
Stephen Toub [Wed, 27 Feb 2019 15:20:41 +0000 (10:20 -0500)]
Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)"" (dotnet/corefx#35595)
* Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)" (dotnet/corefx#33709)"
This reverts commit dotnet/corefx@
53ae9af48c5c133f4413e76c1469dfe6ccecd926.
* Adapt to ThrowHelper changes
Commit migrated from https://github.com/dotnet/corefx/commit/
720591ab8c213c8f3563db1f06114ec7c8d012bb
Jan Kotas [Wed, 27 Feb 2019 05:59:42 +0000 (21:59 -0800)]
Disable BitOps tests
Commit migrated from https://github.com/dotnet/corefx/commit/
70af5f296f7bfcdd7b7fade082c15cd19d8b29ab
Marco Rossignoli [Wed, 27 Feb 2019 11:00:17 +0000 (12:00 +0100)]
fix UserAgent parsing
Commit migrated from https://github.com/dotnet/corefx/commit/
840d29c05243f5afe31e43e2415d6dce5b3c71fd
Tomas Weinfurt [Wed, 27 Feb 2019 06:41:05 +0000 (22:41 -0800)]
enable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler (dotnet/corefx#35605)
* enable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler and skip Curl on RH6
Commit migrated from https://github.com/dotnet/corefx/commit/
f44142b855330ca9274827a230b8ad9a3ccda357
Ahson Khan [Wed, 27 Feb 2019 03:12:35 +0000 (19:12 -0800)]
Update the IBufferWriter contract definition documentation to be clearer (dotnet/corefx#35554)
* Update the IBufferWriter contract definition docs
* Address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
1da56c2529c8d52bd8f3b1ceb07795379221dc02
Tanner Gooding [Wed, 27 Feb 2019 02:58:22 +0000 (18:58 -0800)]
Adding some formatter tests validating the updated float/double behavior (dotnet/corefx#35567)
* Adding some formatter tests validating the updated float/double behavior
* Adding a regression test for ToString("R") on integral types, asserting it isn't supported
Commit migrated from https://github.com/dotnet/corefx/commit/
54e341c9ba4ea452b098f2ec9dbcf58da7b33ed6
Viktor Hofer [Wed, 27 Feb 2019 01:07:26 +0000 (02:07 +0100)]
Darc update from build '
20190226.3' (dotnet/corefx#35604)
* Darc update from build '
20190226.3'
* Apply TestAllTargets project filter
Commit migrated from https://github.com/dotnet/corefx/commit/
23c06516a29ac94585cee09e82b5ddf57d0cae0e
Eric St. John [Tue, 26 Feb 2019 19:24:31 +0000 (11:24 -0800)]
Allow tests to sign with a different StrongNameKeyId
Before this change all tests are forced to use the Open key.
Now tests can specify TestStrongNameKeyId to control their key.
Commit migrated from https://github.com/dotnet/corefx/commit/
a8fc4418080e66d97f337e7b663a88b047f1e2e0
Eric St. John [Tue, 26 Feb 2019 17:18:18 +0000 (09:18 -0800)]
Use ILAsm/ILDasm that are restored as part of external
Also fixes a test project to build correctly and deletes a checked in binary.
Commit migrated from https://github.com/dotnet/corefx/commit/
733f5bee45d7b1c684dc353a1197ddb718cc4aa9
Tomas Weinfurt [Tue, 26 Feb 2019 23:12:36 +0000 (15:12 -0800)]
collect system info if IPv6 loopback fails to resolve (dotnet/corefx#35581)
* collect system info if IPv6 loopback fails to resolve
* add emply line after } to comply with style
Commit migrated from https://github.com/dotnet/corefx/commit/
77cde697f9ee9941bdc76e02b9481d781790e86a
Tomas Weinfurt [Tue, 26 Feb 2019 23:11:39 +0000 (15:11 -0800)]
improve detection for ReadOnly_FileSystemHelper (dotnet/corefx#35531)
* improve detection for ReadOnly_FileSystemHelper
* feedback from review
* fix bad resolve
Commit migrated from https://github.com/dotnet/corefx/commit/
7d4f25f1f503f91dd680d6e2c4cb556fd4f631e4
Krzysztof Wicher [Tue, 26 Feb 2019 22:23:27 +0000 (14:23 -0800)]
Remove System.IO.Ports.Native from the framework (dotnet/corefx#35598)
Commit migrated from https://github.com/dotnet/corefx/commit/
3bf49dd2a3f136a85bed3cc40e6648ccdef4a3f9
William Godbe [Tue, 26 Feb 2019 21:54:54 +0000 (13:54 -0800)]
Merge pull request dotnet/corefx#35572 from wtgodbe/UpdateStando
[master] Trigger manual DARC update
Commit migrated from https://github.com/dotnet/corefx/commit/
7c37cfbd03d058b966160fdc39cd902ef3b2782c
Essam Almohammadi [Sat, 9 Feb 2019 10:55:56 +0000 (11:55 +0100)]
Add string overloads to DbDataReader.Get*()
Implement dotnet/corefx#31595
Commit migrated from https://github.com/dotnet/corefx/commit/
b30fc2b4ee302e449e3580ae39cb083a76b813c9
wtgodbe [Tue, 26 Feb 2019 00:26:29 +0000 (16:26 -0800)]
Update ApiCompat baselines
Commit migrated from https://github.com/dotnet/corefx/commit/
01ef5e6cbb395709c02436538018d44c61cfdcc8
Vance Morrison [Tue, 26 Feb 2019 15:51:19 +0000 (07:51 -0800)]
Changes to support W3C style IDs and propagation (dotnet/corefx#33207)
* First set of changes to support W3C style IDs and propagation
see https://w3c.github.io/trace-context
This is mostly for discussion purposes.
* Changed UseW3CFormat to be DefaultIdFormat
* Review feedback
* More comments. Small Renames
* Added Sampling Support, Review feedback.
* Added placeholder for SetRecordingDesired
* Separated out the Sampling support into its own PR.
* Remove more sampling support
* Fix IsWC3Id -> IdFormat
* Added Sampling Support, Review feedback.
* Separated out the Sampling support into its own PR.
* Add ForceW3C option.
* Introduce ForceDefaultIdFormat
* Adding SpanId and TraceId support
* Change ulong->long in SpanID (probably temporary)
* Remove undesired file changes
* Fix up reference assembly.
Note complete because of questions about Span<byte>, but closer now.
* Turn on code that used Span<byte>
* Defer setting IDFormat until start.
This insures that the IDFormat property is either unknown or a given value (that never changes from there).
* More implementation, made the interface more uniform.
* Support to avoid using strings whenever possible
Basically Id, SpanId TraceId properties are set lazily and only converted lazily.
* Added some tests
* First round of testing (and bugfixes)
* More testing
* Added Equality operators
* Rename SpanId -> ActivitySpanId TraceId ->ActivityTraceId
* Add Comments
* Fix bad XML comment
* Review feedback
* Change AsBytes -> CopyTo
Lifetime issues prevent returning Span<T> (which is what AsBytes does. Reverting to CopyTo instead.
Also added System.Memory ref in attempt to resolve build errors (that don't reproduce locally).
* Attempt to fix build break in netfx build
* Deal with Verification errors.
* Provide full namespace for SecuritySafeCriticalAttribute
* More securitySafeCritical annotations to fix test failures on desktop
* Another attempt on setting SecuritySafeCritical
* Remove the readonly ref (to avoid perf issue)
* Fix most -buildAllConfigurations issues
* Tentative change to see if testing works if we ignore the older netstandard configs.
* Workaround package cycle involving DiagnosticSource and Memory
* Satisfy dangling System.Memory dangling reference in package tests
* Add notes to remove the workarounds when Unsafe is fixed.
* Review feedback
Uses Utf8 helpers where possible.
Commit migrated from https://github.com/dotnet/corefx/commit/
fa07e4f0a8e564f33ef8e2de86dc9087a53bdf26
Tomas Weinfurt [Tue, 26 Feb 2019 07:02:20 +0000 (23:02 -0800)]
improve Ssl3 detection (dotnet/corefx#35574)
* improve sslv3 detection
* updates to pass all tests
* correct catch
Commit migrated from https://github.com/dotnet/corefx/commit/
0fa22d4b6753c47b6139980255e932341353179e
Jeremy Barton [Tue, 26 Feb 2019 06:02:02 +0000 (22:02 -0800)]
Add doc comments to JsonDocument (and friends)
* Add doc comments to all public members of JsonDocument, JsonElement, JsonProperty, and JsonValueType.
* Add "do not use this" doc comments on all internal members, because of source-package concerns.
* Change JsonElement.TokenType from internal to private because it could.
Commit migrated from https://github.com/dotnet/corefx/commit/
81e9045dca63ccea9b4fe31f8ac3a035b1b1f86d
Tomas Weinfurt [Tue, 26 Feb 2019 05:28:18 +0000 (21:28 -0800)]
disable AllSubscriberStress test on ARM64 untill we get more resources to run it (dotnet/corefx#35575)
Commit migrated from https://github.com/dotnet/corefx/commit/
dedb0f8e93661d13f18c9afcae6c2883b28a2d68
Erhan Atesoglu [Tue, 26 Feb 2019 03:05:07 +0000 (19:05 -0800)]
Removed GetRootLength Helper Function from PathInternalWindows.cs (dotnet/corefx#35568)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b262c30165fe7c39d9fb582495c76c704c0a0d6
Filip Navara [Tue, 26 Feb 2019 02:47:18 +0000 (03:47 +0100)]
Add temporary resources and copy of Thread implementation to unblock merge of shared CoreLib (dotnet/corefx#35553)
Commit migrated from https://github.com/dotnet/corefx/commit/
facf731986511cb0cc0ceb181b6c7d846afa0743
Adeel Mujahid [Tue, 26 Feb 2019 02:44:03 +0000 (04:44 +0200)]
Use NativeLibrary.TryLoad and prefer RTLD_LAZY over RTLD_NOW (dotnet/corefx#35548)
* Use NativeLibrary.TryLoad in ODBC test
* Use RTLD_LAZY instead of RTLD_NOW
* Add missing using statement
* More RTLD_NOW -> RTLD_LAZY
* Remove unused RTLD_NOW constant
* Use NativeLibrary.TryLoad instead of P/Invoke dlopen
* Inline method body in property
* Add fallback for netcoreapp2x and below
* Reduce visibility of const
Commit migrated from https://github.com/dotnet/corefx/commit/
863b9bff2d77669b426b52dcb1bf7ba9246729e0
Anirudh Agnihotry [Sun, 24 Feb 2019 22:31:51 +0000 (14:31 -0800)]
Removing restriction of first 8 character being different from lognames (dotnet/corefx#35532)
Commit migrated from https://github.com/dotnet/corefx/commit/
26b932e3c56702382d13ece010b300d3181d2891
Stephen Toub [Sat, 23 Feb 2019 10:00:31 +0000 (05:00 -0500)]
Remove Task{CompletionSource} allocations from Http2Stream (dotnet/corefx#35522)
* Remove Task{CompletionSource} allocations from Http2Stream
This change makes the Http2Stream instance itself awaitable via ValueTask, such that we don't need to allocate any additional TaskCompletionSource or Task objects for such internal await'ing, regardless of how many times the Http2Connection or Http2ReadStream needs to wait for headers or response data to arrive.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
aacff5212204ee54e3b3e0172fcf364c3fe253e3
Jan Kotas [Sat, 23 Feb 2019 05:07:03 +0000 (21:07 -0800)]
Use product version in RuntimeInformation.FrameworkDescription (dotnet/corefx#35516)
* Use product version in RuntimeInformation.FrameworkDescription
* Include FrameworkDescription in the Assert
* Strip the git hash in the fallback
Commit migrated from https://github.com/dotnet/corefx/commit/
db95b37fa3218e20ff639b232a41202b24ddcb39
Erhan Atesoglu [Sat, 23 Feb 2019 02:53:24 +0000 (18:53 -0800)]
Removed "Argument_InvalidPathChars" Resource String (dotnet/corefx#35534)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd52650a7ba05b16c5cabf37cb69511cbccc35b9
Jeremy Barton [Sat, 23 Feb 2019 02:37:22 +0000 (18:37 -0800)]
Add #define alias for local_X509_STORE_CTX_get0_store for RHEL6 build
Commit migrated from https://github.com/dotnet/corefx/commit/
eaafb6fd980f161c94c16b7036a73ed3df5871ae
Eric StJohn [Sat, 23 Feb 2019 02:20:16 +0000 (18:20 -0800)]
Make System.Runtime.CompilerServices.Unsafe inbox (dotnet/corefx#35526)
* Make System.Runtime.CompilerServices.Unsafe inbox
Fix a couple places where we wanted to use it from other inbox assemblies but couldn't.
Unsafe remains as a package and newer versions of Unsafe will replace the inbox Version,
permitting us to add API over time.
* Update Rune tests to use TryEncodeToUtf8Bytes directly
* Add temporary suppression to package tests
Commit migrated from https://github.com/dotnet/corefx/commit/
9074d9f5b513a95b7eac9ba1112069c29230d1d2
Santiago Fernandez Madero [Sat, 23 Feb 2019 01:00:31 +0000 (17:00 -0800)]
Disable azure pipelines reporter for official builds (dotnet/corefx#35540)
Commit migrated from https://github.com/dotnet/corefx/commit/
a41629b2604a9dc92305f4df067898a377f72b17