Vitor Sousa [Mon, 5 Aug 2019 21:47:14 +0000 (18:47 -0300)]
csharp: re-enable binbuf tests with -Dmono-beta=false
Summary:
Since the introduction of the `binbuf` keyword in eolian, `Eina_Binbuf` is no
longer a beta only type.
Hence, we enable EFL# binbuf unit tests in non-beta compilation too.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9467
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 17:51:36 +0000 (18:51 +0100)]
evas image - eina file - be paranoud about double closes
tracking some seemingly not so good asan hits on the eina file where
we're accessing an eina file already closed... so be extra paranoid
about it and set things to null after free/close...
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 17:47:20 +0000 (18:47 +0100)]
gif loader - dup eina file as we keep our own copy of it in the loader
we didnt dup the eina file handle since we kee our own handle. we
need ot do that. asan found this.
Marcel Hollerbach [Mon, 5 Aug 2019 17:07:29 +0000 (19:07 +0200)]
introduce a new interface efl_ui_selectable
this is meant to be implemented by entities that *can* be selectabled
(not to be confused with containers that can have selected contents)!
ref T8057
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9503
Marcel Hollerbach [Mon, 5 Aug 2019 16:35:13 +0000 (18:35 +0200)]
efl_ui_selectable: split this up
i dont know why, but something got badly mixed up, the selection APIs
for text and item ended up in the same interface, which seems ... weird
?
This commit splits that up into container_selectable and
text_selectable, there is no future plan on my list for text_selection.
The rest of this series is working towards removing
container_selectable, replacing it with a new interface. However, the
interface will stay until list_view is replaced.
The changes in the legacy code are removing the efl.ui.selection
interface from it, item emission is not depending on the inherited
interfaces, additionally, this interface does not provide any API, so
this should not be an issue.
ref T7766
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9498
WooHyun Jung [Fri, 2 Aug 2019 05:03:38 +0000 (05:03 +0000)]
efl_ui_action_connector: rename clickable_util to action_connector
efl_ui_clickable_util was only for efl_input_clickable interface,
but there can be more cases which want to connect object event
to specific action interfaces (such as scrolling) in the future.
For that extension, efl_ui_action_connector seems better.
ref: T7847
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9486
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 14:19:34 +0000 (15:19 +0100)]
edje cc - fix coverity warning for uninit local var
fix CID 1382208
Lauro Moura [Mon, 5 Aug 2019 14:17:52 +0000 (10:17 -0400)]
efl-mono: Add Model manual implementation to C# and MVVM factories
Summary: Depends on D9273, D9270
Test Plan: Run added testcases.
Reviewers: cedric, bu5hm4n, zmike, SanghyeonLee, felipealmeida, segfaultxavi
Reviewed By: cedric
Subscribers: cedric
Tags: #expertise_solutions, #efl_language_bindings
Differential Revision: https://phab.enlightenment.org/D8080
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 14:02:45 +0000 (15:02 +0100)]
ethumb - fix error free of static string as stringshare
in one case we try stringshare_del a static string, not stringshared,
so fix by always making it a stringshare
fix CID 1402614
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 13:49:58 +0000 (14:49 +0100)]
epp - fix tchnical leak for coverity
its technically a leak.. but epp will give up a nd error out anyway
here so... didn't matter.
fix CID 1402655
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 13:38:10 +0000 (14:38 +0100)]
ecore drm legacy - fix dbus leaks of reply handle
fix CID 1402664
Daniel Kolesa [Mon, 5 Aug 2019 13:43:39 +0000 (15:43 +0200)]
eolian: fix use after free in eolian_database
'toscan' is actually a view to 'mpath' memory, so freeing it first
would result in use-after-free. This is obviously only in the error
branch so it usually does not happen, but fix anyway.
CID1403022
Daniel Kolesa [Mon, 5 Aug 2019 13:41:28 +0000 (15:41 +0200)]
eolian: fix false positive use-after-free in parser
The catch here is that check_match results in a long jump under
that condition. The static analyzer doesn't know this, so declare
intent.
CID1402703
Daniel Kolesa [Mon, 5 Aug 2019 13:39:43 +0000 (15:39 +0200)]
eolian: silence return checking in lexer
Coverity CID1396970.
Daniel Kolesa [Mon, 5 Aug 2019 13:37:13 +0000 (15:37 +0200)]
eolian: refactor "dead" code
This has no functional change but should stop coverity from
complaining.
CID1382214
Daniel Kolesa [Mon, 5 Aug 2019 13:32:15 +0000 (15:32 +0200)]
eolian: attempt to silence coverity overlapping assignment errors
While the previous code was I believe correct, coverity still
complains about it. Split it into two statements also to declare
intent.
CID 1402603..1402724
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 13:28:40 +0000 (14:28 +0100)]
elm theme - fix leak in error cse in elm theme mmap set
we don't free the eina file handle on error. coverity found it. fix
fix CID 1402680
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 13:17:33 +0000 (14:17 +0100)]
ethumb - make coverity happy by including null char
doesnt cost us much to memcpy the nul byte too to keep coverity happy.
fix CID 1402690
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 12:48:14 +0000 (13:48 +0100)]
ecore evas drm - fix multi-dlopening of lib into symbol space
only load libglapi once... not multiple times by storing static ptr to
lib handle.
fix CID 1402692
Yeongjong Lee [Mon, 5 Aug 2019 12:48:04 +0000 (08:48 -0400)]
efl_input_key: replace key property name with key_sym
Summary:
Sorry to touch stable eo classes. there is name conflict issue between class and
property when binding language is generated from eo. for example in C#, compiler
error occurs.
```
src/bindings/mono/efl_input_key.eo.cs(272,26): error CS0542:
`Efl.Input.Key.Key': member names cannot be the same as their enclosing type
```
This patch changes Efl.Input.Key.GetKey/SetKey method to
Efl.Input.Key.GetKeySym/SetKeySym and generates Efl.Input.Key.KeySym
property.
Note that CAPI is not changed.
ref T8093
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, woohyun, zmike, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8093
Differential Revision: https://phab.enlightenment.org/D9483
zmike note: this class was not released at the point of this patch, the class
was only recently marked as stable
Vincent Torri [Mon, 5 Aug 2019 12:47:19 +0000 (08:47 -0400)]
evil: add mprotect() and fix a bit mmap(). Elm_test is working
Test Plan: compilation aand elm_test working
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9493
Marcel Hollerbach [Mon, 5 Aug 2019 12:44:51 +0000 (08:44 -0400)]
efl_ui_spin/button: move from elm_ to efl_ prefixed functions
Summary:
this moves a bunch of api calls from elm_ to efl_. Those calls that are
called on the entry object are still elm, as well as access APIs, they
will have to be moved once efl_ui_text is usable.
Depends on D9475
Reviewers: segfaultxavi, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9488
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 12:44:25 +0000 (13:44 +0100)]
ecore drm - legacy - fix coverity leak complaint
is real - in error case. fix it to make coverity happy.
fix CID 1402696
Carsten Haitzler (Rasterman) [Mon, 5 Aug 2019 12:32:01 +0000 (13:32 +0100)]
ephysics - fix stringshare double del
fix CID 1402707
Hermet Park [Mon, 5 Aug 2019 12:09:14 +0000 (21:09 +0900)]
Hermet Park [Mon, 5 Aug 2019 11:42:26 +0000 (20:42 +0900)]
vg json: up to date internal reference.
rlottie is not officially released, still it's unstable.
JunsuChoi [Mon, 5 Aug 2019 09:08:50 +0000 (18:08 +0900)]
ector_software_rasterizer: Add default value for stroke's miter_limit
Summary:
Currently the default value of miter_limit is defined as 0.
miter_limit should be specified to a value other than 0. becuase it is affected by width.
See below for an explanation of this.
https://www.freetype.org/freetype2/docs/reference/ft2-glyph_stroker.html#ft_stroker_linejoin
There is no particular reason why the default value is 0x4.
It only refers to the standard of web svg.
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit
Test Plan:
setenv("ECTOR_BACKEND", "default", 1);
elm_init(argc, argv);
Evas_Object *win = elm_win_util_standard_add(NULL, "test");
evas_object_smart_callback_add(win, "delete,request", win_del, 0);
elm_win_autodel_set(win, 1);
Evas_Object *bg = elm_bg_add(win);
elm_bg_color_set(bg, 255,255,255);
evas_object_size_hint_align_set(bg, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_size_hint_weight_set(bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_show(bg);
Evas *evas = evas_object_evas_get(win);
Evas_Object *vg = evas_object_vg_add(evas);
evas_object_show(vg);
Evas_Object *container = evas_vg_container_add(vg);
Evas_Object *shape = evas_vg_shape_add(container); //Default is EFL_GFX_JOIN_MITER
evas_vg_shape_append_rect(shape, 0, 0, 100 , 100, 0, 0);
evas_vg_shape_stroke_color_set(shape, 255, 0, 0, 255);
evas_vg_shape_stroke_width_set(shape, 10);
evas_vg_node_origin_set(shape, 50, 150);
shape = evas_vg_shape_add(container);
evas_vg_shape_append_rect(shape, 0, 0, 100 , 100, 0, 0);
evas_vg_shape_stroke_join_set(shape, EFL_GFX_JOIN_BEVEL);
evas_vg_shape_stroke_color_set(shape, 255, 0, 0, 255);
evas_vg_shape_stroke_width_set(shape, 10);
evas_vg_node_origin_set(shape, 200, 150);
shape = evas_vg_shape_add(container);
evas_vg_shape_append_rect(shape, 0, 0, 100 , 100, 0, 0);
evas_vg_shape_stroke_join_set(shape, EFL_GFX_JOIN_ROUND);
evas_vg_shape_stroke_color_set(shape, 255, 0, 0, 255);
evas_vg_shape_stroke_width_set(shape, 10);
evas_vg_node_origin_set(shape, 350, 150);
evas_object_vg_root_node_set(vg, container);
elm_object_content_set(bg, vg);
elm_win_resize_object_add(win, bg);
evas_object_resize(win, WIDTH, HEIGHT);
evas_object_show(win);
elm_run();
elm_shutdown();
Reviewers: smohanty, Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9492
Change-Id: I104e272dc58d11989dfd1cf24959c61955948f94
jeon [Fri, 9 Aug 2019 07:27:14 +0000 (16:27 +0900)]
ecore_wl2_input: attempt to surface to hash if surface is exist during keygrab
Change-Id: Icaa37e52ac19607888b42c7474cf39bd1f858c53
subhransu mohanty [Thu, 8 Aug 2019 05:42:30 +0000 (14:42 +0900)]
optimization: load font config during font init
Font config gets initialized on first call to evas_text
by initializing at the font_init time can help the startup
time with precreated window.
Change-Id: I6dd3c0b065aa19ffe32bf932049b1f2fbc8950f8
subhransu mohanty [Fri, 9 Aug 2019 04:55:29 +0000 (13:55 +0900)]
optimization: remove redundant style tag addition.
These style tags are already been added in reparse() function.
its added again here by mistake.
Change-Id: Ie5cc21b05b3deb0223b76d74bfa6be02e4aed188
subhransu mohanty [Thu, 8 Aug 2019 00:19:36 +0000 (09:19 +0900)]
efl/tracing: refactor tracing in efl to support different tracing backend.
The code will be cleaner with only the Trace call without any ifdef mess.
Easy to change the trace profilier by changing the trace backend.
if disabled won't add any code to efl.
Change-Id: I2b8a1d00f8470b904703c23ffd17aac0ab3eeaaf
WooHyun Jung [Thu, 8 Aug 2019 00:49:15 +0000 (09:49 +0900)]
eina_mempool: change default memory alignment from 2 to 4
This patch is still in review.
https://phab.enlightenment.org/D9520/
If the patch would be modified while reviewing, this patch
should be reverted and the reviewed one needs to be updated.
[Summary]
SIGBUS error occurs on ARM devices. ELM_LAYOUT_MIXIN inherited class data size
is not a multiple of 4, because sizeof(Elm_Layout_Data) is 1 and
eina_mempool_alignof return 2 with size less than 4 which means data_offset
is a * m + 2.
@tizen_fix
Change-Id: I2c25d14def886f4d2ccb0b775ea540c9d41b8c9e
Ali Alzyod [Wed, 7 Aug 2019 11:39:33 +0000 (20:39 +0900)]
evas_text: backward compatibility for setting text size
Summary: This is for backward compatibility for TIZEN Test cases for legacy
Reviewers: woohyun
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9519
Change-Id: I4a928e8f9f92c29bb5d957f0183d6e1097fbe5b0
WooHyun Jung [Tue, 6 Aug 2019 01:11:53 +0000 (10:11 +0900)]
Temporarily enabled svg as hot fix
When svg is disabled, tizen-themes are failed
to be built with the following error message"
"void LottieParserImpl::ParseNext(): Assertion `0'
failed."
This patch needs to be reverted after the error is
fixed by Hermet :)
@tizen_fix
Change-Id: I79607a797cd139180f668dc18a800277022336e2
JunsuChoi [Mon, 5 Aug 2019 09:08:50 +0000 (18:08 +0900)]
ector_software_rasterizer: Add default value for stroke's miter_limit
Summary:
Currently the default value of miter_limit is defined as 0.
miter_limit should be specified to a value other than 0. becuase it is affected by width.
See below for an explanation of this.
https://www.freetype.org/freetype2/docs/reference/ft2-glyph_stroker.html#ft_stroker_linejoin
There is no particular reason why the default value is 0x4.
It only refers to the standard of web svg.
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit
Test Plan:
setenv("ECTOR_BACKEND", "default", 1);
elm_init(argc, argv);
Evas_Object *win = elm_win_util_standard_add(NULL, "test");
evas_object_smart_callback_add(win, "delete,request", win_del, 0);
elm_win_autodel_set(win, 1);
Evas_Object *bg = elm_bg_add(win);
elm_bg_color_set(bg, 255,255,255);
evas_object_size_hint_align_set(bg, EVAS_HINT_FILL, EVAS_HINT_FILL);
evas_object_size_hint_weight_set(bg, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_show(bg);
Evas *evas = evas_object_evas_get(win);
Evas_Object *vg = evas_object_vg_add(evas);
evas_object_show(vg);
Evas_Object *container = evas_vg_container_add(vg);
Evas_Object *shape = evas_vg_shape_add(container); //Default is EFL_GFX_JOIN_MITER
evas_vg_shape_append_rect(shape, 0, 0, 100 , 100, 0, 0);
evas_vg_shape_stroke_color_set(shape, 255, 0, 0, 255);
evas_vg_shape_stroke_width_set(shape, 10);
evas_vg_node_origin_set(shape, 50, 150);
shape = evas_vg_shape_add(container);
evas_vg_shape_append_rect(shape, 0, 0, 100 , 100, 0, 0);
evas_vg_shape_stroke_join_set(shape, EFL_GFX_JOIN_BEVEL);
evas_vg_shape_stroke_color_set(shape, 255, 0, 0, 255);
evas_vg_shape_stroke_width_set(shape, 10);
evas_vg_node_origin_set(shape, 200, 150);
shape = evas_vg_shape_add(container);
evas_vg_shape_append_rect(shape, 0, 0, 100 , 100, 0, 0);
evas_vg_shape_stroke_join_set(shape, EFL_GFX_JOIN_ROUND);
evas_vg_shape_stroke_color_set(shape, 255, 0, 0, 255);
evas_vg_shape_stroke_width_set(shape, 10);
evas_vg_node_origin_set(shape, 350, 150);
evas_object_vg_root_node_set(vg, container);
elm_object_content_set(bg, vg);
elm_win_resize_object_add(win, bg);
evas_object_resize(win, WIDTH, HEIGHT);
evas_object_show(win);
elm_run();
elm_shutdown();
Reviewers: smohanty, Hermet, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9492
Change-Id: I42ad77c8e31d3a6ad10ce894c3c535e00d932be4
Hermet Park [Wed, 31 Jul 2019 07:30:03 +0000 (16:30 +0900)]
Revert "Revert "Backported missing svg loader from upstream""
This reverts commit
b016b078d8baa2d0d8d753415133aac0cdc1364a.
Change-Id: I038c93d2e2faae9658b82283320480849f75fdb7
WooHyun Jung [Mon, 5 Aug 2019 11:43:50 +0000 (20:43 +0900)]
elm_module_tizen_helper : needs to include the definition for EAPI
Change-Id: I81084d2d24cdcd0f3a4dd32f092d84aa84c448ca
WooHyun Jung [Mon, 5 Aug 2019 07:32:08 +0000 (16:32 +0900)]
fix build errors while doing integration works
1. set @beta to properties which include void_ptr
2. EFL_UI_EVENT_CLICKED -> EFL_INPUT_EVENT_CLICKED
3. apply EFL_CANVAS_GROUP_CALC_OPS to tizen only widgets
4. fix wrong integration for evas_gl_api.c
Change-Id: Iec7a61f1c37925b8c9ae9c965807b2ec3ffb8732
Hermet Park [Tue, 30 Jul 2019 07:58:02 +0000 (16:58 +0900)]
vg json: --log level
Vector needs to try load a lottie file in a brutal force way,
If the input source is not identified.
Change-Id: I5811eab7ddb1791d15d99ed0e9c6ca6699ab6c42
Hermet Park [Tue, 30 Jul 2019 10:45:57 +0000 (19:45 +0900)]
efl_ui_animation_view: sync with upstream code.
Change-Id: I511c3665be37da7ad14e2b892e16ca59a90dd2a7
Hermet Park [Wed, 31 Jul 2019 07:32:11 +0000 (16:32 +0900)]
Revert "Revert "ecore_wl2_input: do not generate duplicated mouse in events""
This reverts commit
1abf7b4373fe10fa860f3ab0c71d9c176c533cfa.
Change-Id: Id1148fe0f03b0b66f039430063ed0658ba843221
Hermet Park [Wed, 31 Jul 2019 07:32:00 +0000 (16:32 +0900)]
Revert "Revert "fix build break when wayland2 is not enabled""
This reverts commit
c84e03c43c1dac604652915de683df28ec182226.
Change-Id: I100de91a9b22fc5ef3d97a3de209dbd134747216
Hermet Park [Wed, 31 Jul 2019 07:31:35 +0000 (16:31 +0900)]
Revert "Revert "move tizen specific structure to its own header""
This reverts commit
0f912e0bde30eaa92ae14c1e7ae527947200bf3d.
Change-Id: Ied971c2f211b1a9f77422259b0d8689b0f5b05ae
Hermet Park [Wed, 31 Jul 2019 07:31:10 +0000 (16:31 +0900)]
Revert "Revert "remove unnecessary dependancy from elementary module to keep it same as upstream.""
This reverts commit
db821525c5ebd458a998de2e9fadd51e8a9cfb53.
Change-Id: Ia90b005793a635691e17af9bb674b8adc9f0bcd1
Hermet Park [Wed, 31 Jul 2019 07:29:50 +0000 (16:29 +0900)]
Revert "Revert "meson: move all tizen specific dependancy to 'tizen' option""
This reverts commit
32a707a0161975d35fe64beff351e1a98433c962.
Change-Id: I7a355d74ec4856ec7d1b7ad93d8012d3116313f3
Hermet Park [Wed, 31 Jul 2019 07:29:38 +0000 (16:29 +0900)]
Revert "Revert "meson: move tizen configuration from meson_options to efl.spec""
This reverts commit
f1efd064e0e00444b1c523bf979c1866f89cd10a.
Change-Id: Iada00ffe121a943dcecb3ac4ae1bee398d93db5d
Hermet Park [Wed, 31 Jul 2019 07:29:25 +0000 (16:29 +0900)]
Revert "Revert "meson: remove unnecessary depenadancy""
This reverts commit
45c14c8a3728ddbaba4b661236f345cb1d43cfa4.
Change-Id: I7f93ef831fd159be1656292a67d9651563cb4380
Hermet Park [Wed, 31 Jul 2019 07:29:07 +0000 (16:29 +0900)]
Revert "Revert "meson: Enable dlog logging system only if dlog library available""
This reverts commit
4b134a0d878fe54953bc73253bfef3c22113a1b3.
Change-Id: Ia56df95a7a5d2c89c4ecd23ab5e4c739d6882409
Marcel Hollerbach [Thu, 1 Aug 2019 11:55:06 +0000 (13:55 +0200)]
efl_ui_spin: move the step implementation to spin_button
having efl_ui_spin implementing efl.ui.range_interactive does not make
sense. Efl.Ui.Spin is a not interactive widget, so it should not
implement that interface.
ref T7897
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9475
Marcel Hollerbach [Thu, 1 Aug 2019 11:35:53 +0000 (13:35 +0200)]
efl_ui_spin_button: fix initial displaying of formatting string
spin_button should also implement formatted_apply, the label has a
different part name then spin.
ref T8097
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9474
Marcel Hollerbach [Thu, 1 Aug 2019 11:29:06 +0000 (13:29 +0200)]
efl_ui_spin_button: stop calling only the parent
if the spin button is skipped the spin is called directly, the label
will display the wrong value.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9473
Carsten Haitzler (Rasterman) [Fri, 2 Aug 2019 16:17:48 +0000 (17:17 +0100)]
elm toolbar - fix toolbar item separators and refactor aling/fill of item
only set this is one place and thus get it consistent/right for
separators vs other items.
@fix
Carsten Haitzler (Rasterman) [Fri, 2 Aug 2019 14:50:44 +0000 (15:50 +0100)]
elm toolbar - fix packing options at start to avoid visual layout bugs
i spoetted open moving around and shrinking when it shouldnt -
packging options (fill/align) not always set right. this fixes that.
@fix
Carsten Haitzler (Rasterman) [Thu, 1 Aug 2019 08:16:47 +0000 (09:16 +0100)]
ecore evas x and e sync rendering - disable as it's unused
this has been optional and unused by e for a very long time ot try
sync front-buffered software rendering with the wm/compositor. we may
as well remove the bloat that is here that is unused... it's been
inactive for many years anyway.
Xavi Artigas [Fri, 2 Aug 2019 15:29:27 +0000 (17:29 +0200)]
mono-docs: Add more event args link for event handlers
There were some events missing <value> tags (see
f01b1134012bafcc4d0c82588230796a7c9ef5bb)
Xavi Artigas [Fri, 2 Aug 2019 14:15:20 +0000 (16:15 +0200)]
mono-docs: Escape the recently added docs
This is the second time I forget...
Xavi Artigas [Fri, 2 Aug 2019 12:03:26 +0000 (14:03 +0200)]
mono-docs: Add descriptions to event args
Event args structs had fields without description (missing <value> tag).
Xavi Artigas [Fri, 2 Aug 2019 11:53:19 +0000 (13:53 +0200)]
mono-docs: Proper indentation for previous commit
Xavi Artigas [Fri, 2 Aug 2019 11:49:20 +0000 (13:49 +0200)]
mono-docs: Add event args link for event handlers
For some reason DocFX does not generate links for templated event handlers:
event EventHandler<Efl.Input.IInterfacePointerOutEvt_Args> PointerOutEvt;
After unsuccessfully trying to find out why, this patch adds the link to the
event arguments in a <value> tag, so at least it shows in the documentation
and the reader has somewhere to click to find out what arguments an event
is sending.
Hermet Park [Fri, 2 Aug 2019 09:17:40 +0000 (18:17 +0900)]
efl_canvas_rectangle: rendering optmization.
There was a weird profiling result that rectangles drawing is much much slower than images.
Checked reason, the computation rect clip area is the overload point.
I don't think it's necesary but we can simplely improve the performance here
by replacing native function.
I tested this by drawing 400 number of rectangles,
and this patch improved up abt 10 fps(sw), 20fps(gl).
@TEST CODE
MAX_SIZE = 400;
for(int i=0; i< MAX_SIZE; i++)
{
Evas_Object *rect = evas_object_rectangle_add(layout);
int x = rand() % WINDOW_WIDTH;
int y = rand() % WINDOW_HEIGHT;
evas_object_resize(rect, ELM_SCALE_SIZE(200), ELM_SCALE_SIZE(200));
evas_object_move(rect, x, y);
evas_object_color_set(rect, (rand() % 256), (rand() % 256), (rand() % 256), 255);
evas_object_show(rect);
Elm_Transit *transit = elm_transit_add();
elm_transit_object_add(transit, rect);
int dX = rand() % WINDOW_WIDTH;
int dY = rand() % WINDOW_HEIGHT;
elm_transit_effect_translation_add(transit, 0, 0, dX - x, dY - y);
elm_transit_repeat_times_set(transit, -1);
elm_transit_duration_set(transit, 1.0);
elm_transit_go(transit);
}
Hermet Park [Fri, 2 Aug 2019 09:13:14 +0000 (18:13 +0900)]
evas rectangle: code refactoring.
Just removed white spaces, fixed indentation.
No logical changes.
Jaehyun Cho [Fri, 2 Aug 2019 08:43:45 +0000 (10:43 +0200)]
efl_input_clickable: increase the time interval for repeated counter
Summary:
The repeated counter in Efl.Input.Clickable_Clicked can be used to
identify double click or triple click.
Previously, the repeated counter in Efl.Input.Clickable_Clicked was
calculated within the time interval 0.1 second.
Now, the time interval for the repeated counter is increased to 0.25
second. It seems that 0.25 second is more appropriate to identify if the
two consecutive clicks should be considered together.
(e.g. considered as double click or triple click)
Moreover, in ecore_event and edje, 0.25 second is already used as a time
interval for double click.
Test Plan:
1. Run Efl.Ui.Button in elementary_test
2. Do double click or triple click the buttons
Reviewers: segfaultxavi, bu5hm4n, YOhoho
Reviewed By: segfaultxavi, YOhoho
Subscribers: YOhoho, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9485
Mike Blumenkrantz [Thu, 1 Aug 2019 17:34:18 +0000 (13:34 -0400)]
efl_ui/tags: set entry to fill vertically
forgot this in previous patch
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9479
Mike Blumenkrantz [Thu, 1 Aug 2019 13:20:34 +0000 (09:20 -0400)]
efl_ui/tags: use user size hints for internal objects
restricted min size hint should only be set by an object's own group_calc
function. all other cases should use regular min size hint
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9477
Mike Blumenkrantz [Thu, 1 Aug 2019 17:31:58 +0000 (13:31 -0400)]
efl_ui/flow.box: fix item calc with mixed weights
if a box contains an entire row of items with weight(0), and the next
row contains items with weights set, the item count must be correctly
incremented so that the box uses the right items in its calculations
@fix
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9480
Vincent Torri [Thu, 1 Aug 2019 06:44:00 +0000 (06:44 +0000)]
examples: cast to uintptr_t instead of long
on Windows, long is a 32 bits type
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9470
Marcel Hollerbach [Wed, 31 Jul 2019 17:52:08 +0000 (19:52 +0200)]
efl_ui_position_manager: add event for updating the range
the new event can be used to message back the currently visible range
from the position to the collection / collection_view.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9462
Marcel Hollerbach [Thu, 1 Aug 2019 07:55:05 +0000 (09:55 +0200)]
spinner_example: migrate it to efl::ui::spin_button
we should do that more often, that shows issues.
Right now there seems to be an issue with accessors in cxx, something is
freeing the accessor twice. So this feature is disabled right now.
ref T8100
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9471
Marcel Hollerbach [Wed, 31 Jul 2019 16:06:43 +0000 (18:06 +0200)]
efl_ui_spin_button: rename circulate to wraparound
ref T8097
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9461
Marcel Hollerbach [Wed, 31 Jul 2019 13:19:32 +0000 (15:19 +0200)]
efl_ui_spec: add a test suite for the steady event
this checks that the steady event is correctly emitted after some time.
Right now this test does notthing for EFL_UI_SPIN_CLASS. Reason for this
is that Spin is not interactive, even if it implements the interface for
it. Maybe something we should resolve in future.
ref T7894
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9460
Marcel Hollerbach [Wed, 31 Jul 2019 15:49:44 +0000 (17:49 +0200)]
efl_ui_spin_button: use the newly emitted event from range_interactive
this event is not also in range_interactive, so better use this.
ref T8097
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9459
Marcel Hollerbach [Wed, 31 Jul 2019 12:38:13 +0000 (14:38 +0200)]
efl_ui_range_interactive: add a new event
the steady event from slider now moved here. A spec test suite and the
corresponding implementations will follow.
ref T7894
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D9458
Lauro Moura [Thu, 1 Aug 2019 19:12:12 +0000 (21:12 +0200)]
csharp: Add a documentation_string generator
Summary:
Escapes a single string, without leading `///`
Depends on D9481
Reviewers: segfaultxavi, felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9482
Lauro Moura [Thu, 1 Aug 2019 19:12:10 +0000 (21:12 +0200)]
csharp: Avoid generating empty <value> tags
Depends on D9478
Reviewers: segfaultxavi, felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9481
Xavi Artigas [Thu, 1 Aug 2019 19:12:10 +0000 (21:12 +0200)]
mono-docs: Add misc struct docs
Summary:
Structs have a convenience constructor which was missing parameter documentation.
Struct fields need a <value> tag or there is a hole in the generated docs.
The documentation for the type of the field has been used, when available.
Test Plan: Build docs and look at generated pages for structs.
Reviewers: lauromoura, vitor.sousa, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9478
Daniel Kolesa [Thu, 1 Aug 2019 14:54:00 +0000 (16:54 +0200)]
eolian: remove __builtin_free_cb
This has long been unused. If we need to replace this eventually,
it should be done correctly.
Daniel Kolesa [Thu, 1 Aug 2019 14:47:52 +0000 (16:47 +0200)]
eolian: disallow ptr() in containers in stable API
Christopher Michael [Thu, 1 Aug 2019 13:04:09 +0000 (09:04 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_input_name_get
ref T8016
Christopher Michael [Thu, 1 Aug 2019 12:59:26 +0000 (08:59 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_input_keymap_get
ref T8016
Christopher Michael [Thu, 1 Aug 2019 12:56:42 +0000 (08:56 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_input_display_get function
ref T8016
Christopher Michael [Thu, 1 Aug 2019 12:53:45 +0000 (08:53 -0400)]
tests/ecore_wl2: Add test for ecore_wl2_input_seat_id_get function
ref T8016
Christopher Michael [Thu, 1 Aug 2019 12:53:21 +0000 (08:53 -0400)]
tests/ecore_wl2: Fix assert tests for some window functions
ref T8016
Christopher Michael [Thu, 1 Aug 2019 12:41:07 +0000 (08:41 -0400)]
tests/ecore_wl2: Add start of Ecore_Wl2_Input API tests
ref T8016
Christopher Michael [Thu, 1 Aug 2019 12:32:42 +0000 (08:32 -0400)]
efl_ui_collection: Mark unused parameter
double align is actually unused in this function, so mark it as such
Xavi Artigas [Thu, 1 Aug 2019 11:27:51 +0000 (13:27 +0200)]
eolian_mono: Fix whitespace in generated cs files
Pet peeve of mine.
Marcel Hollerbach [Thu, 1 Aug 2019 09:40:05 +0000 (11:40 +0200)]
fix warning
Marcel Hollerbach [Thu, 27 Jun 2019 15:52:53 +0000 (17:52 +0200)]
elementary_test: add a test to show our frame widget
it does not work yet, but we at least have the chance of seeing it.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9194
WooHyun Jung [Thu, 1 Aug 2019 09:19:51 +0000 (09:19 +0000)]
efl_input_clickable: add longpress_abort
Now, a specific class which uses efl_input_clickable_util is able
to cancel ongoing longpress event by calling longpress_abort.
This commit shows how efl_ui_text uses longpress_abort to satisfy
its own longpress use case
ref T7847
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9455
WooHyun Jung [Thu, 1 Aug 2019 08:19:16 +0000 (17:19 +0900)]
efl_ui_clickable_util: remove efl_input_processed_set
Summary:
efl_input_processed_set needs to be used only when specific
event marks that it is monopolizing current user interaction.
(such as scrolling).
But, press event or unpress event looks not that proper.
Reviewers: bu5hm4n, Jaehyun_Cho
Reviewed By: bu5hm4n, Jaehyun_Cho
Subscribers: AbdullehGhujeh, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9454
Marcel Hollerbach [Tue, 30 Jul 2019 09:13:46 +0000 (11:13 +0200)]
efl_ui_position_manager: move from accessor to function callback
this commit enables access to the item structure of the collection via a
function callback. The function callback now enables batching for items,
which does not pay off right now. However, a few more optimizations can
be done in order to get the whole payoff.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9445
Felipe Magno de Almeida [Wed, 31 Jul 2019 21:26:34 +0000 (18:26 -0300)]
eolian-cxx: Add special type tags to make function_wrapper specializations unique
Reviewers: lauromoura, bu5hm4n, woohyun
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9469
Felipe Magno de Almeida [Wed, 31 Jul 2019 21:23:35 +0000 (18:23 -0300)]
eolian-cxx: Generate eot files
Summary:
Eolian Type files were not being generated, which made some template
specialization to not be defined, for example for function_wrappers.
Reviewers: bu5hm4n, woohyun, lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9468
Mike Blumenkrantz [Wed, 31 Jul 2019 18:37:41 +0000 (14:37 -0400)]
efl_ui/win: use efl_ui_image internally for non-legacy widgets
switch to using a fully non-legacy widget when this is not being created
with elm_win_add
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9466
Mike Blumenkrantz [Wed, 31 Jul 2019 18:02:47 +0000 (14:02 -0400)]
efl_ui/tags: use flow box internally
the existing layout code here is basically just a flow box, so use that
instead to avoid mixing legacy widgets in unified ones
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9463
ali [Mon, 29 Jul 2019 20:18:37 +0000 (20:18 +0000)]
evas_textblock: change font-size/font-family only using EFL.Text.Font Interface
Currently:
User cannot change font size only, he needs to set both font and font size with (**efl_text_font_font_set**)
To change size only, you need to make two calls, one to get font (**efl_text_font_font_get**) , then pass it again with new size to (**efl_text_font_font_set**).
New Behaviour:
If user want to change size only, then he passes NULL as font argument to keep same font.
If user want to change font only, then he passes 0 as font-size argument, to keep same font-size.
Notes:
This is not best solution, but it better than current behaviour.
I think best solution to have separate function to set font size, but It might break current api or duplicate functions.
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9158
Marcel Hollerbach [Wed, 31 Jul 2019 13:02:05 +0000 (09:02 -0400)]
efl_ui_check/radio: use clickable
Summary:
with this commit the state of the check / radio buttons are changes when
the Widget is clicked. The Widget is now using clickable and emits all
the events.
ref T7865
Reviewers: segfaultxavi, zmike, Jaehyun_Cho, woohyun
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7865
Differential Revision: https://phab.enlightenment.org/D9456
Carsten Haitzler (Rasterman) [Wed, 31 Jul 2019 13:05:06 +0000 (14:05 +0100)]
evas events - fix segv if pointer data is freed by cb
callback can free what is in context. avoid that problem
@fix
Xavi Artigas [Wed, 31 Jul 2019 12:24:53 +0000 (14:24 +0200)]
Efl.Composite_Model: Improve docs.
Woochanlee [Wed, 31 Jul 2019 11:34:56 +0000 (07:34 -0400)]
ecore_wl2: Changed log macro ERR->EINA_LOG_ERR.
Summary:
When the ecore_wl2_shutdown() calling without ecore_wl2_init().
It makes crash.
Reviewers: eagleeye, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9452
Xavi Artigas [Wed, 31 Jul 2019 10:53:48 +0000 (12:53 +0200)]
DocFX: Update README with Deployment instructions
The deployment process is currently manual so we better write it down.