profile/ivi/webkit-efl.git
12 years agoUnreviewed windows build fix - avoid return statement after return if USE(ACCELERATED...
jamesr@google.com [Tue, 21 Feb 2012 21:57:06 +0000 (21:57 +0000)]
Unreviewed windows build fix - avoid return statement after return if USE(ACCELERATED_COMPOSITING) is set.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening. Typo fix.
ossy@webkit.org [Tue, 21 Feb 2012 21:40:52 +0000 (21:40 +0000)]
[Qt] Unreviewed gardening. Typo fix.

* platform/qt-5.0-wk2/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compo...
jamesr@google.com [Tue, 21 Feb 2012 21:39:00 +0000 (21:39 +0000)]
ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active
https://bugs.webkit.org/show_bug.cgi?id=79126

Reviewed by Anders Carlsson.

The ScrollingCoordinator should only attempt to coordinate scrolling when compositing is active, since it's all
about manipulating GraphicsLayers. Adds a runtime check.

Also removes some stray #if ENABLE(THREADED_SCROLLING) guards that snuck into FrameView.

* page/FrameView.cpp:
(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChromium build fix. Unreviwed but rubber-stamped by Antti.
jamesr@google.com [Tue, 21 Feb 2012 21:35:38 +0000 (21:35 +0000)]
Chromium build fix. Unreviwed but rubber-stamped by Antti.

* dom/Document.cpp:
* editing/ReplaceSelectionCommand.cpp:
* inspector/InspectorStyleSheet.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed evening gardening after r108364.
ossy@webkit.org [Tue, 21 Feb 2012 21:20:33 +0000 (21:20 +0000)]
[Qt] Unreviewed evening gardening after r108364.

* platform/qt/fast/forms/float-before-fieldset-expected.png: Added.
* platform/qt/fast/forms/float-before-fieldset-expected.txt: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Enable compositor filter layout tests (except on mac and win debug)
wjmaclean@chromium.org [Tue, 21 Feb 2012 21:14:31 +0000 (21:14 +0000)]
[chromium] Enable compositor filter layout tests (except on mac and win debug)
https://bugs.webkit.org/show_bug.cgi?id=79111

Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet Referrer header for media downloads
eric.carlson@apple.com [Tue, 21 Feb 2012 21:08:43 +0000 (21:08 +0000)]
Set Referrer header for media downloads
https://bugs.webkit.org/show_bug.cgi?id=78614

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/media/video-referer.html was modified to test this change.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerReferrer): New, return the document's referer.
* html/HTMLMediaElement.h:

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::referrer): New, return the client's mediaPlayerReferrer.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerReferrer):

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation to add
    a referer header.

LayoutTests:

* http/tests/media/resources/video-referer-check-referer.php: Get the test file and content-type
    from parameters on the url. Fail if referrer is anything but video-referer.html. Add support for
    byte-range requests so it will work with AVFoundation.
* http/tests/media/video-referer.html: Pass video file name and content-type as url parameters
    instead of having another cgi set a cookie. Set the php script as the 'src' on a <source> element
    instead of on the <video> element so we can also add a 'type' attribute.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed.
antti@apple.com [Tue, 21 Feb 2012 20:58:40 +0000 (20:58 +0000)]
Not reviewed.

Remove some obsolete comments, use consistent name for propertyID.

* css/StylePropertySet.h:
(StylePropertySet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up StylePropertySet included headers
antti@apple.com [Tue, 21 Feb 2012 20:48:05 +0000 (20:48 +0000)]
Clean up StylePropertySet included headers
https://bugs.webkit.org/show_bug.cgi?id=79134

Reviewed by Andreas Kling.

Remove unneccesary includes.

* bindings/js/JSDOMBinding.h:
* css/StylePropertySet.cpp:
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
* editing/RemoveCSSPropertyCommand.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAX: move aria-invalid test to top level, so other platforms can use it
cfleizach@apple.com [Tue, 21 Feb 2012 20:43:24 +0000 (20:43 +0000)]
AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Unreviewed. Forgot to update paths.

* accessibility/aria-invalid.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix bug from r107672.
commit-queue@webkit.org [Tue, 21 Feb 2012 20:10:51 +0000 (20:10 +0000)]
Fix bug from r107672.
https://bugs.webkit.org/show_bug.cgi?id=78773

Before set MediaStreamTrack disable/enable operation,
checking the status of MediaStream that contains this MediaStreamTrack.
if MediaStream is finished, then skipping operation of
didSetMediaStreamTrackEnabled().

Patch by Lin Wei <wei.a.lin@intel.com> on 2012-02-21
Reviewed by Adam Barth.
* mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::setEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove RenderLayer::scrolledContentOffset calls to a common function
jchaffraix@webkit.org [Tue, 21 Feb 2012 19:59:42 +0000 (19:59 +0000)]
Move RenderLayer::scrolledContentOffset calls to a common function
https://bugs.webkit.org/show_bug.cgi?id=76971

Reviewed by David Hyatt.

Refactoring without any change in behavior.

This change adds a RenderBox::scrolledContentOffset function to handle all
the calls that goes through the layer(). This indirection will enable us to
add layer() checks without patching a lot of call sites as part of bug 75568.

We also moved down the concept of scroll offset down to RenderBox where it belongs!

* rendering/RenderLayer.h:
(RenderLayer):
(WebCore::RenderLayer::scrolledContentOffset):
Moved scrolledContent to the private section of the class to prevent misuse.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::scrolledContentOffset):
New function to add an indirection with RenderLayer.

* editing/visible_units.cpp:
(WebCore::absoluteLineDirectionPointToLocalPointInBlock):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::offsetForContents):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::offsetFromContainer):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::offsetFromContainer):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlInnerBlock::positionForPoint):
Patched all those call sites to use the new function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd rafaelw as a committer.
rafaelw@chromium.org [Tue, 21 Feb 2012 19:55:18 +0000 (19:55 +0000)]
Add rafaelw as a committer.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2012-02-18 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 21 Feb 2012 19:49:21 +0000 (19:49 +0000)]
2012-02-18  Antonio Gomes  <agomes@rim.com>

        Fat fingers - cache the first rect-based hit test so we do not need to do it again
        https://bugs.webkit.org/show_bug.cgi?id=79115

        Reviewed by Adam Treat.

        Our FatFingers implementation runs currently in two phases:
        the first checks for the elements intrinsically clickable;
        the second checks for elements made clickable by the page
        (for example, a div with a onclick event listener attached to it).
        For each phase, we perform a rect hittest, which is not needed since
        the result of each is the same.

        Patch introduces a caching mechanism so we avoid on rect hittest:
        when the first phase runs, it caches each nodeset per document in
        a hashmap. This second phase works with the cached results.

        No behavioral change, but performance is better since we
        avoid one (possibly expensive) rect hittest.

        I measured the performance gain on https://www.kvd.se/, and we
        save up to 0.04 seconds, by caching and re-using the results.

        * WebKitSupport/FatFingers.cpp:
        (BlackBerry::WebKit::dumpHitTestResult):
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
        (BlackBerry::WebKit::FatFingers::cachingStrategy):
        (WebKit):
        (BlackBerry::WebKit::FatFingers::getNodesFromRect):
        * WebKitSupport/FatFingers.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: update names after deleting message_broker
dpranke@chromium.org [Tue, 21 Feb 2012 19:41:23 +0000 (19:41 +0000)]
webkitpy: update names after deleting message_broker
https://bugs.webkit.org/show_bug.cgi?id=79000

Reviewed by Eric Seidel.

Part 3 of 3 in deleting message_broker.py; this change just
adjusts the names for the newly merged symbols so that they are
private as appropriate.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(_Broker):
(_BrokerConnection):
(_BrokerConnection.__init__):
(AbstractWorker.__init__):
(_ManagerConnection):
(_ManagerConnection.__init__):
(_WorkerConnection):
(_WorkerConnection.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: merge message_broker.py into manager_worker_broker.py
dpranke@chromium.org [Tue, 21 Feb 2012 19:33:42 +0000 (19:33 +0000)]
webkitpy: merge message_broker.py into manager_worker_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78999

Reviewed by Tony Chang.

This is pretty much a straight cut-and-paste of one file into
another (broken up so that docstrings and imports are in the
right place).

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(BrokerClient):
(BrokerClient.is_done):
(BrokerClient.name):
(Broker):
(Broker.__init__):
(Broker.add_topic):
(Broker._get_queue_for_topic):
(Broker.post_message):
(Broker.run_message_loop):
(Broker.run_all_pending):
(Broker._run_loop):
(Broker._dispatch_message):
(_Message):
(_Message.loads):
(_Message.__init__):
(_Message.dumps):
(_Message.__repr__):
(BrokerConnection):
(BrokerConnection.__init__):
(BrokerConnection.run_message_loop):
(BrokerConnection.post_message):
(BrokerConnection.raise_exception):
* Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove obsolete float comparison FIXMEs
eae@chromium.org [Tue, 21 Feb 2012 19:33:02 +0000 (19:33 +0000)]
Remove obsolete float comparison FIXMEs
https://bugs.webkit.org/show_bug.cgi?id=79127

Reviewed by Eric Seidel.

Remove obsolete FIXME comments added back when we were planning to use
floating point units for layout.

No new tests, no code changes.

* page/FrameView.cpp:
(WebCore::FrameView::init):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: prepare to delete message_broker.py
dpranke@chromium.org [Tue, 21 Feb 2012 19:28:03 +0000 (19:28 +0000)]
webkitpy: prepare to delete message_broker.py
https://bugs.webkit.org/show_bug.cgi?id=78997

Reviewed by Eric Seidel.

This is part 1 of 3 changes to fix bug 78187. This change
prepares the code for merging message_broker.py into
manager_worker_broker.py; the tests in message_broker_unittest
are merged into manager_worker_broker_unittest, the symbols
needed by the tests are exported from manager_worker_broker.py,
and manager_worker_broker itself is updated to refer to the
symbols directly (without the module prefix).

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(AbstractWorker):
(AbstractWorker.__init__):
(_ManagerConnection):
(_ManagerConnection.__init__):
(_WorkerConnection):
(_WorkerConnection.__init__):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(InterfaceTest.test_brokerclient_is_abstract):
(InterfaceTest.test_brokerclient_is_abstract.methods):
(MessageTest):
(MessageTest.test__no_body):
(MessageTest.test__body):
* Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIndexedDB: webFrame isn't threadsafe, don't use it from a worker thread
dgrogan@chromium.org [Tue, 21 Feb 2012 19:25:22 +0000 (19:25 +0000)]
IndexedDB: webFrame isn't threadsafe, don't use it from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=78659

After crrev.com/121669, indexed db doesn't use the web frame for
anything if called from a web worker.

No new tests - this check was defensive and possibly not ever
triggered.

Reviewed by Tony Chang.

* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::openFromWorker):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: it is nearly impossible to select and copy text on the Elements panel.
apavlov@chromium.org [Tue, 21 Feb 2012 19:17:40 +0000 (19:17 +0000)]
Web Inspector: it is nearly impossible to select and copy text on the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=60814

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAX: move aria-invalid test to top level, so other platforms can use it
cfleizach@apple.com [Tue, 21 Feb 2012 19:13:34 +0000 (19:13 +0000)]
AX: move aria-invalid test to top level, so other platforms can use it
https://bugs.webkit.org/show_bug.cgi?id=79041

Reviewed by David Kilzer.

* accessibility/aria-invalid-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-invalid-expected.txt.
* accessibility/aria-invalid.html: Copied from LayoutTests/platform/mac/accessibility/aria-invalid.html.
* platform/gtk/Skipped:
* platform/mac/accessibility/aria-invalid-expected.txt: Removed.
* platform/mac/accessibility/aria-invalid.html: Removed.
* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash in RenderTableSection::nodeAtPoint.
inferno@chromium.org [Tue, 21 Feb 2012 19:10:05 +0000 (19:10 +0000)]
Crash in RenderTableSection::nodeAtPoint.
https://bugs.webkit.org/show_bug.cgi?id=78922

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-section-node-at-point-crash.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
m_needsCellRecalc is set. Otherwise, we will end up accessing
removed table cells.

LayoutTests:

* fast/table/table-section-node-at-point-crash-expected.txt: Added.
* fast/table/table-section-node-at-point-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Unreviewed, update chromium leopard baselines for r108364
jamesr@google.com [Tue, 21 Feb 2012 18:54:53 +0000 (18:54 +0000)]
[chromium] Unreviewed, update chromium leopard baselines for r108364

* platform/chromium-mac-leopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
* platform/chromium-mac-leopard/fast/forms/float-before-fieldset-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove PropertySetCSSStyleDeclaration to a file of its own
antti@apple.com [Tue, 21 Feb 2012 18:38:48 +0000 (18:38 +0000)]
Move PropertySetCSSStyleDeclaration to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=79121

Rubber-stamped by Andreas Kling.

This makes StylePropertySet.cpp more readable.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/PropertySetCSSStyleDeclaration.cpp: Copied from Source/WebCore/css/StylePropertySet.cpp.
(WebCore::PropertySetCSSStyleDeclaration::ref):
(WebCore::PropertySetCSSStyleDeclaration::deref):
(WebCore):
* css/PropertySetCSSStyleDeclaration.h: Added.
(WebCore):
(PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(WebCore::PropertySetCSSStyleDeclaration::parentElement):
(WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
(WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
(WebCore::RuleCSSStyleDeclaration::parentRule):
(WebCore::RuleCSSStyleDeclaration::clearParentRule):
(InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::parentElement):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):
* css/StylePropertySet.cpp:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnnecessary preprocessor macros in MainThread.h/cpp
paroga@webkit.org [Tue, 21 Feb 2012 18:24:05 +0000 (18:24 +0000)]
Unnecessary preprocessor macros in MainThread.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=79083

Removed invalid/wrong PLATFORM(WINDOWS) preprocessor macro.

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-02-21

* wtf/MainThread.cpp:
(WTF):
* wtf/MainThread.h:
(WTF):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Unreviewed, update chromium baselines for r108364
jamesr@google.com [Tue, 21 Feb 2012 18:22:08 +0000 (18:22 +0000)]
[chromium] Unreviewed, update chromium baselines for r108364

* platform/chromium-linux/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
* platform/chromium-linux/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
* platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/float-before-fieldset-expected.png: Added.
* platform/chromium-mac/fast/forms/float-before-fieldset-expected.png: Removed.
* platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
* platform/chromium-win/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
* platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
* platform/chromium-win/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.
* platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
* platform/chromium-win/fast/forms/float-before-fieldset-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] WebAudio build is broken
commit-queue@webkit.org [Tue, 21 Feb 2012 18:20:06 +0000 (18:20 +0000)]
[GTK] WebAudio build is broken
https://bugs.webkit.org/show_bug.cgi?id=79113

Patch by Philippe Normand <pnormand@igalia.com> on 2012-02-21
Reviewed by Martin Robinson.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioGStreamerChannelPosition): Set a default value for
the position variable.
* platform/audio/gtk/AudioBusGtk.cpp: Include CString.h, needed
for sharedResourcesPath().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoKill FontFamilyValue.
kling@webkit.org [Tue, 21 Feb 2012 18:00:00 +0000 (18:00 +0000)]
Kill FontFamilyValue.
<http://webkit.org/b/79103>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove FontFamilyValue and replace all usage by CSSPrimitiveValue.
The class was only used to filter font family names, removing bracketed
suffixes, e.g "[Xft]".

This was added to KHTML in 2002 to support the use of specific X11 font
families inside KMail: <https://bugs.kde.org/show_bug.cgi?id=38808>

Test: fast/css/font-family-trailing-bracket-gunk.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSParser.cpp:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
* css/CSSValuePool.h:
(CSSValuePool):
* css/FontFamilyValue.cpp: Removed.
* css/FontFamilyValue.h: Removed.

LayoutTests:

* fast/css/font-family-trailing-bracket-gunk-expected.txt: Added.
* fast/css/font-family-trailing-bracket-gunk.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLittle optimization for CSSParser::parseFillShorthand.
alexis.menard@openbossa.org [Tue, 21 Feb 2012 17:35:17 +0000 (17:35 +0000)]
Little optimization for CSSParser::parseFillShorthand.
https://bugs.webkit.org/show_bug.cgi?id=79042

Reviewed by Hajime Morita.

Remove one extra loop that we can combine with the following one
which adds the properties to the parser's list of properties. I also
removed a useless check.
Instruments shows on the css-parser-yui benchmark an improvement
of 13ms (from 77ms spent in the function to 64ms).

No new tests : refactoring, existings tests should cover.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79046
hyatt@apple.com [Tue, 21 Feb 2012 17:17:43 +0000 (17:17 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Relevant discussion is here: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

This patch makes the following changes to how objects shrink when avoiding floats:
(1) The containing block width used for percentage calculations is now constant. This means that
an overflow:hidden block with a margin-left of 10% will no longer change what 10% means depending
on the available line width. From a code perspective, containingBlockLogicalWidthForContent and
containingBlockLogicalWidthForContentInRegion no longer contain any special-case code for
shrinkToAvoidFloats() objects.

(2) Now the computation of the logical width for the shrinking object itself handles the adjustments.
Two kinds of adjustments are made for both the start and end margins. Conceptually what we do is shrink
the object to the available line width minus our margins, and then expand the width back out to the content edge
or to the float edge as necessary. If the float fully fits in the margin, then we expand back out to the
content edge. Otherwise if the float doesn't fit, then we expand only to the float edge, making sure our
margin overlaps with the float. This expansion is not performed for negative margins, since our result is already
correct in that case.

Reviewed by Dan Bernstein.

Added the new tests from the thread on www-style about this issue (from Alan Gresley and George Talbot)
in fast/block/float.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containsFloat):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::containsFloats):
Changed to be const.

(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::endOffsetForContent):
Added endOffsetForXXX methods to mirror their startOffset counterparts. Used by the width adjustment code.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
New method that handles shrinking the logical width to the line width (and then re-expanding back out to the
float and/or content edges as needed).

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
Patched to no longer do the shrinking of objects to avoid floats.

(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Patched to handle calling the new shrinking code to adjust our logical width.

* rendering/RenderBox.h:
(RenderBox):
The signature of computeLogicalWithUsing changed to be region-specific and to carry along enough information
to efficiently perform the shrinking.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
Patched to handle calling the new shrinking code to adjust our logical width.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=79046

width of overflow:hidden blocks is wrong when their margins overlap floats.

Added new tests from www-style thread: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html

Reviewed by Dan Bernstein.

* fast/block/float/centered-float-avoidance-complexity.html: Added.
* fast/block/float/shrink-to-avoid-float-complexity.html: Added.
* platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
* platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt: Added.
* platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
* platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix the Snow Leopard build.
weinig@apple.com [Tue, 21 Feb 2012 17:01:54 +0000 (17:01 +0000)]
Attempt to fix the Snow Leopard build.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, add platform specific expected file after r107689.
ossy@webkit.org [Tue, 21 Feb 2012 16:49:53 +0000 (16:49 +0000)]
[Qt] Unreviewed gardening, add platform specific expected file after r107689.

* platform/qt-5.0-wk2/http/tests/websocket/test/hybi/bad-sub-protocol-non-ascii-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse libc++ when building with Clang on Mac
weinig@apple.com [Tue, 21 Feb 2012 16:44:31 +0000 (16:44 +0000)]
Use libc++ when building with Clang on Mac
https://bugs.webkit.org/show_bug.cgi?id=78981

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:
In addition to enabling libc++ when building with Clang,
disable gtest's use of tr1::tuple, which doesn't exist in
libc++.

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMac build fix
aroben@apple.com [Tue, 21 Feb 2012 16:38:02 +0000 (16:38 +0000)]
Mac build fix

* WebCore.xcodeproj/project.pbxproj: Mark TextTrack.h and TextTrackCue.h private so that
WebKit can include them.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Fix the N9 build
abecsi@webkit.org [Tue, 21 Feb 2012 16:26:57 +0000 (16:26 +0000)]
[Qt][WK2] Fix the N9 build
https://bugs.webkit.org/show_bug.cgi?id=79101

Reviewed by Noam Rosenthal.

No new tests needed.

* platform/graphics/opengl/TextureMapperGL.cpp: Add missing include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r108309, r108323, and r108326
aroben@apple.com [Tue, 21 Feb 2012 16:26:12 +0000 (16:26 +0000)]
Roll out r108309, r108323, and r108326

They broke the 32-bit Lion build.

Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.

Source/JavaScriptCore:

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/LinkBuffer.h:
* assembler/MacroAssemblerCodeRef.h:
* bytecode/BytecodeConventions.h: Removed.
* bytecode/CallLinkStatus.cpp:
* bytecode/CallLinkStatus.h:
* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:
* bytecode/GetByIdStatus.cpp:
* bytecode/GetByIdStatus.h:
* bytecode/Instruction.h:
* bytecode/LLIntCallLinkInfo.h: Removed.
* bytecode/MethodCallLinkStatus.cpp:
* bytecode/Opcode.cpp:
* bytecode/Opcode.h:
* bytecode/PutByIdStatus.cpp:
* bytecode/PutByIdStatus.h:
* bytecompiler/BytecodeGenerator.cpp:
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGCapabilities.h:
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOperations.cpp:
* heap/Heap.h:
* heap/MarkStack.cpp:
* heap/MarkedAllocator.h:
* heap/MarkedSpace.h:
* interpreter/CallFrame.cpp:
* interpreter/CallFrame.h:
* interpreter/Interpreter.cpp:
* interpreter/Interpreter.h:
* interpreter/RegisterFile.h:
* jit/ExecutableAllocator.h:
* jit/HostCallReturnValue.cpp: Removed.
* jit/HostCallReturnValue.h: Removed.
* jit/JIT.cpp:
* jit/JITCode.h:
* jit/JITDriver.h:
* jit/JITExceptions.cpp:
* jit/JITInlineMethods.h:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* jit/JSInterfaceJIT.h:
* llint/LLIntCommon.h: Removed.
* llint/LLIntData.cpp: Removed.
* llint/LLIntData.h: Removed.
* llint/LLIntEntrypoints.cpp: Removed.
* llint/LLIntEntrypoints.h: Removed.
* llint/LLIntExceptions.cpp: Removed.
* llint/LLIntExceptions.h: Removed.
* llint/LLIntOfflineAsmConfig.h: Removed.
* llint/LLIntOffsetsExtractor.cpp: Removed.
* llint/LLIntSlowPaths.cpp: Removed.
* llint/LLIntSlowPaths.h: Removed.
* llint/LLIntThunks.cpp: Removed.
* llint/LLIntThunks.h: Removed.
* llint/LowLevelInterpreter.asm: Removed.
* llint/LowLevelInterpreter.cpp: Removed.
* llint/LowLevelInterpreter.h: Removed.
* offlineasm/armv7.rb: Removed.
* offlineasm/asm.rb: Removed.
* offlineasm/ast.rb: Removed.
* offlineasm/backends.rb: Removed.
* offlineasm/generate_offset_extractor.rb: Removed.
* offlineasm/instructions.rb: Removed.
* offlineasm/offset_extractor_constants.rb: Removed.
* offlineasm/offsets.rb: Removed.
* offlineasm/opt.rb: Removed.
* offlineasm/parser.rb: Removed.
* offlineasm/registers.rb: Removed.
* offlineasm/self_hash.rb: Removed.
* offlineasm/settings.rb: Removed.
* offlineasm/transform.rb: Removed.
* offlineasm/x86.rb: Removed.
* runtime/CodeSpecializationKind.h: Removed.
* runtime/CommonSlowPaths.h:
* runtime/Executable.cpp:
* runtime/Executable.h:
* runtime/ExecutionHarness.h: Removed.
* runtime/JSArray.h:
* runtime/JSCell.h:
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.h:
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSString.h:
* runtime/JSTypeInfo.h:
* runtime/JSValue.cpp:
* runtime/JSValue.h:
* runtime/JSVariableObject.h:
* runtime/Options.cpp:
* runtime/Options.h:
* runtime/ScopeChain.h:
* runtime/Structure.cpp:
* runtime/Structure.h:
* runtime/StructureChain.h:
* wtf/InlineASM.h:
* wtf/Platform.h:
* wtf/SentinelLinkedList.h:
* wtf/text/StringImpl.h:

Source/WebCore:

* CMakeLists.txt:

Source/WebKit:

* CMakeLists.txt:

Tools:

* DumpRenderTree/efl/CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt]REGRESSION(r92254): It made 2 tests timeout
ossy@webkit.org [Tue, 21 Feb 2012 16:20:29 +0000 (16:20 +0000)]
[Qt]REGRESSION(r92254): It made 2 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=65609

* platform/qt/Skipped: Unskip now passing tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [SuggestBox] textPrompt.css disablement displays garbled suggest box
apavlov@chromium.org [Tue, 21 Feb 2012 16:17:03 +0000 (16:17 +0000)]
Web Inspector: [SuggestBox] textPrompt.css disablement displays garbled suggest box
https://bugs.webkit.org/show_bug.cgi?id=79107

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype.get visible):
(WebInspector.TextPrompt.SuggestBox.prototype.hide):
(WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
* inspector/front-end/textPrompt.css:
(.suggest-box):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: timeline hangs on a page with deep chain of nested events.
yurys@chromium.org [Tue, 21 Feb 2012 16:14:19 +0000 (16:14 +0000)]
Web Inspector: timeline hangs on a page with deep chain of nested events.
https://bugs.webkit.org/show_bug.cgi?id=79106

Use stack of states instead of recursive calls when traversing records tree to
avoid stack overflow.

Reviewed by Pavel Feldman.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype._forAllRecords):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._filterRecords):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [crash] upon style modification after navigation
pfeldman@chromium.org [Tue, 21 Feb 2012 15:56:57 +0000 (15:56 +0000)]
Web Inspector: [crash] upon style modification after navigation
https://bugs.webkit.org/show_bug.cgi?id=79108

Reviewed by Yury Semikhatsky.

* inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::undo):
(WebCore::InspectorHistory::redo):
(WebCore::InspectorHistory::reset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse WTF::cryptographicallyRandomValues in FileSystemWin.cpp
paroga@webkit.org [Tue, 21 Feb 2012 15:52:06 +0000 (15:52 +0000)]
Use WTF::cryptographicallyRandomValues in FileSystemWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=79089

Reviewed by Adam Roben.

Avoid loading and unloading of the crypto library during every
call to openTemporaryFile() and make the code easier.

* platform/win/FileSystemWin.cpp:
(WebCore::openTemporaryFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove stylesheet pointer from StylePropertySet
ossy@webkit.org [Tue, 21 Feb 2012 15:31:14 +0000 (15:31 +0000)]
Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-02-21
Reviewed by Csaba Osztrogonác.

Qt buildfix after r108345.

* css/CSSParser.cpp:
(WebCore::parseColorValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove stylesheet pointer from StylePropertySet
ossy@webkit.org [Tue, 21 Feb 2012 15:14:49 +0000 (15:14 +0000)]
Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Antti Koivisto.

Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
reported a false warning: 'value$m_ptr' may be used uninitialized in this function

* css/CSSParser.cpp:
(WebCore::parseSimpleLengthValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShrink attribute style property sets after populating them.
kling@webkit.org [Tue, 21 Feb 2012 14:37:51 +0000 (14:37 +0000)]
Shrink attribute style property sets after populating them.
<http://webkit.org/b/78972>

Reviewed by Antti Koivisto.

Add a StylePropertySet::shrinkToFit() and call it at the end of updateStyleAttribute()
to minimize the amount of wasted space.

* css/StylePropertySet.h:
(WebCore::StylePropertySet::shrinkToFit):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, skip new failing and crashing test to paint the bot green.
ossy@webkit.org [Tue, 21 Feb 2012 14:20:04 +0000 (14:20 +0000)]
[Qt] Unreviewed gardening, skip new failing and crashing test to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDoes not build on IA64, SPARC and Alpha
kov@webkit.org [Tue, 21 Feb 2012 14:06:36 +0000 (14:06 +0000)]
Does not build on IA64, SPARC and Alpha
https://bugs.webkit.org/show_bug.cgi?id=79047

Patch by Gustavo Noronha Silva  <kov@debian.org> and Bob Tracy <rct@frus.com> on 2012-02-21
Rubber-stamped by Kent Tamura.

* wtf/dtoa/utils.h: these architectures also have correct double
operations, so add them to the appropriate side of the check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Tue, 21 Feb 2012 13:53:41 +0000 (13:53 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove stylesheet pointer from StylePropertySet
antti@apple.com [Tue, 21 Feb 2012 13:49:15 +0000 (13:49 +0000)]
Remove stylesheet pointer from StylePropertySet
https://bugs.webkit.org/show_bug.cgi?id=79092

Reviewed by Andreas Kling.

The context should be passed as an argument for CSS parser invoking setters that actually need it.

- Remove the context stylesheet pointer.
- Add context stylesheet argument to setters.
- Drop an unnecessary StylePropertySet constructor, pass strict parsing flag directly.
- Adapt to changes by passing in the context stylesheet where needed.
- Add StyledElement::applyPresentationAttributeToStyle helpers for building up the attribute style.

* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::addSubresourceStyleURLs):
* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):
* css/CSSParser.h:
(CSSParser):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::addSubresourceStyleURLs):
* css/StylePropertySet.cpp:
(WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(RuleCSSStyleDeclaration):
(InlineCSSStyleDeclaration):
(WebCore):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):
(WebCore::StylePropertySet::clearParentRule):
(WebCore::StylePropertySet::clearParentElement):
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
(WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
(WebCore::RuleCSSStyleDeclaration::contextStyleSheet):
(WebCore::InlineCSSStyleDeclaration::contextStyleSheet):
(SameSizeAsStylePropertySet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::ensureInlineStyleDecl):
* dom/StyledElement.cpp:
(WebCore):
(WebCore::StyledElement::parseAttribute):
(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::updateAttributeStyle):
* dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::applyPresentationAttributeToStyle):
(WebCore):
* html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectStyleForAttribute):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForAttribute):
* html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectStyleForAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::applyBorderAttributeToStyle):
(WebCore::HTMLElement::mapLanguageAttributeToLocale):
(WebCore::HTMLElement::collectStyleForAttribute):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):
* html/HTMLElement.h:
(HTMLElement):
* html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForAttribute):
* html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectStyleForAttribute):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::collectStyleForAttribute):
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::collectStyleForAttribute):
* html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectStyleForAttribute):
* html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::collectStyleForAttribute):
* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectStyleForAttribute):
* html/HTMLTableCaptionElement.cpp:
(WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::collectStyleForAttribute):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::collectStyleForAttribute):
* html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectStyleForAttribute):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectStyleForAttribute):
* html/HTMLUListElement.cpp:
(WebCore::HTMLUListElement::collectStyleForAttribute):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
* mathml/MathMLElement.cpp:
(WebCore::MathMLElement::collectStyleForAttribute):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
(WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::collectStyleForAttribute):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::collectStyleForAttribute):
* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::collectStyleForAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Web Inspector: set breakpoint/pause doesn't work when worker is in a tight loop
yurys@chromium.org [Tue, 21 Feb 2012 13:10:35 +0000 (13:10 +0000)]
[V8] Web Inspector: set breakpoint/pause doesn't work when worker is in a tight loop
https://bugs.webkit.org/show_bug.cgi?id=79097

Source/WebCore:

Worker script will be interrupted to dispatch all arriving inspector commands.
This way debugger will be operable even if worker is in a tight loop.

Reviewed by Pavel Feldman.

* bindings/js/ScriptDebugServer.h:
(Task):
(WebCore::ScriptDebugServer::Task::~Task):
(ScriptDebugServer):
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):
* bindings/js/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::interruptAndRun):
* bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::interruptAndRunTask):
(WebCore):
* bindings/v8/WorkerScriptDebugServer.h:
(v8):
(WebCore):
(WorkerScriptDebugServer):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
* inspector/WorkerDebuggerAgent.h:
(WebCore):
(WorkerDebuggerAgent):
* workers/WorkerMessagingProxy.cpp:
(WebCore):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):
* workers/WorkerRunLoop.h:
(WorkerRunLoop):

Source/WebKit/chromium:

Worker script execution will be interrupted for dispatching inspector commands.

Reviewed by Pavel Feldman.

* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] 3 SVG tests assert after r107207
ossy@webkit.org [Tue, 21 Feb 2012 13:05:04 +0000 (13:05 +0000)]
[Qt] 3 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332

* platform/qt/Skipped: Skip 3 more asserting test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] REGRESSION(r108112): sputnik/Conformance/15_Native_Objects/15.1_The_Global_Objec...
ossy@webkit.org [Tue, 21 Feb 2012 12:38:40 +0000 (12:38 +0000)]
[Qt] REGRESSION(r108112): sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A1.2_T2.html crashes intermittently
https://bugs.webkit.org/show_bug.cgi?id=79029

* platform/qt/Skipped: Skip new crashing test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] tst_QWebPage::infiniteLoopJS() timeouts with DFG JIT
ossy@webkit.org [Tue, 21 Feb 2012 12:34:21 +0000 (12:34 +0000)]
[Qt] tst_QWebPage::infiniteLoopJS() timeouts with DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=79040

Reviewed by Simon Hausmann.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage): Disable tst_QWebPage::infiniteLoopJS() until proper fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed: fixing Mac build (take 2).
pfeldman@chromium.org [Tue, 21 Feb 2012 12:26:14 +0000 (12:26 +0000)]
Not reviewed: fixing Mac build (take 2).

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setShowPaintRects):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, skip new failing mediastream test on GTK.
philn@webkit.org [Tue, 21 Feb 2012 12:16:09 +0000 (12:16 +0000)]
Unreviewed, skip new failing mediastream test on GTK.

* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed: fixing Mac build.
pfeldman@chromium.org [Tue, 21 Feb 2012 12:13:42 +0000 (12:13 +0000)]
Not reviewed: fixing Mac build.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawOutline):
* inspector/DOMNodeHighlighter.h:
(DOMNodeHighlighter):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willPaintImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):
* inspector/InspectorPageAgent.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Switch Debugger agent to TypeBuilder
vsevik@chromium.org [Tue, 21 Feb 2012 12:04:57 +0000 (12:04 +0000)]
Web Inspector: Switch Debugger agent to TypeBuilder
https://bugs.webkit.org/show_bug.cgi?id=78390

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-02-21
Reviewed by Vsevolod Vlasov.

Client code is switched to TypeBuilder.

* inspector/CodeGeneratorInspector.py:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::getFunctionDetails):
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::wrapCallFrames):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed: fixing poor merge in r108332.
pfeldman@chromium.org [Tue, 21 Feb 2012 12:00:48 +0000 (12:00 +0000)]
Not reviewed: fixing poor merge in r108332.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
* inspector/front-end/externs.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [Styles] Rule source URL tooltip should show line number
apavlov@chromium.org [Tue, 21 Feb 2012 11:47:55 +0000 (11:47 +0000)]
Web Inspector: [Styles] Rule source URL tooltip should show line number
https://bugs.webkit.org/show_bug.cgi?id=79087

Reviewed by Pavel Feldman.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix one more GTK+ unit test after r108278.
philn@webkit.org [Tue, 21 Feb 2012 11:46:07 +0000 (11:46 +0000)]
Fix one more GTK+ unit test after r108278.

Reviewed by Alejandro G. Castro.

* tests/testkeyevents.c:
(map_event_cb): No longer grab focus here.
(setup_keyevent_test): Grabbing focus here seems to be late enough in the process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Print warning when importing experimental WK2 APIs in QML
commit-queue@webkit.org [Tue, 21 Feb 2012 11:34:24 +0000 (11:34 +0000)]
[Qt] Print warning when importing experimental WK2 APIs in QML
https://bugs.webkit.org/show_bug.cgi?id=78817

Patch by Andras Becsi <andras.becsi@nokia.com> on 2012-02-21
Reviewed by Simon Hausmann.

* declarative/experimental/plugin.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: clicking empty space should not re-enter edit mode
pfeldman@chromium.org [Tue, 21 Feb 2012 11:32:44 +0000 (11:32 +0000)]
Web Inspector: clicking empty space should not re-enter edit mode
https://bugs.webkit.org/show_bug.cgi?id=79024

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Vsevolod Vlasov.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceMouseDown):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: evaluate on hover does not work for large files.
pfeldman@chromium.org [Tue, 21 Feb 2012 11:30:30 +0000 (11:30 +0000)]
Web Inspector: evaluate on hover does not work for large files.
https://bugs.webkit.org/show_bug.cgi?id=79015

Patch by Pavel Feldman <pfeldman@chomium.org> on 2012-02-21
Reviewed by Yury Semikhatsky.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._handleMouseAction):
* inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer):
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
* inspector/front-end/SourceJavaScriptTokenizer.re2js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: add "show paint rectangles" setting.
pfeldman@chromium.org [Tue, 21 Feb 2012 11:28:47 +0000 (11:28 +0000)]
Web Inspector: add "show paint rectangles" setting.
https://bugs.webkit.org/show_bug.cgi?id=79030

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::DOMNodeHighlighter::drawOutline):
(DOMNodeHighlighter):
* inspector/DOMNodeHighlighter.h:
(WebCore):
(DOMNodeHighlighter):
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::willPaint):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::buildObjectForFrame):
* inspector/InspectorPageAgent.h:
(WebCore):
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):
* inspector/front-end/inspector.js:
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Clean-up project file after r108310
abecsi@webkit.org [Tue, 21 Feb 2012 11:26:27 +0000 (11:26 +0000)]
[Qt] Clean-up project file after r108310

Reviewed by Csaba Osztrogonác.

No new tests needed.

* Target.pri: Fix path for TextTrack headers.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Get rid of the dependency to QtWidgets
abecsi@webkit.org [Tue, 21 Feb 2012 10:57:13 +0000 (10:57 +0000)]
[Qt][WK2] Get rid of the dependency to QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=76276

Reviewed by Simon Hausmann.

Source/WebKit2:

* Target.pri:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/util.h:

Tools:

* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
* MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication):
* QtTestBrowser/locationedit.h:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GStreamer] media/W3C failures
philn@webkit.org [Tue, 21 Feb 2012 10:33:53 +0000 (10:33 +0000)]
[GStreamer] media/W3C failures
https://bugs.webkit.org/show_bug.cgi?id=75078

Reviewed by Martin Robinson.

Source/WebCore:

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): Clean out everything
after file:// url path to cope with media/W3C tests loading
file:///path/to/media.ext?some parameters.

LayoutTests:

Unskip now passing tests and add GTK baselines for them.

* platform/gtk/Skipped:
* platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
* platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix massive crashes in all tests introduced by previous build fix, and fix non-DFG...
fpizlo@apple.com [Tue, 21 Feb 2012 09:49:22 +0000 (09:49 +0000)]
Fix massive crashes in all tests introduced by previous build fix, and fix non-DFG build.
https://bugs.webkit.org/show_bug.cgi?id=75812

Reviewed by Csaba Osztrogonác.

* dfg/DFGOperations.cpp:
(JSC):
* jit/HostCallReturnValue.h:
(JSC::initializeHostCallReturnValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, build fix for non-client-based Geolocation builds after r107982.
mlilek@apple.com [Tue, 21 Feb 2012 09:20:04 +0000 (09:20 +0000)]
Not reviewed, build fix for non-client-based Geolocation builds after r107982.

* page/Geolocation.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Web Inspector: simplify worker debugger implementation
yurys@chromium.org [Tue, 21 Feb 2012 09:09:39 +0000 (09:09 +0000)]
[V8] Web Inspector: simplify worker debugger implementation
https://bugs.webkit.org/show_bug.cgi?id=79085

There is one instance of WorkerScriptDebugServer per worker thread. We don't
need to resolve WorkerContext from V8::Context anymore.

Reviewed by Pavel Feldman.

* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
(WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempted build fix for ELF platforms.
fpizlo@apple.com [Tue, 21 Feb 2012 09:09:22 +0000 (09:09 +0000)]
Attempted build fix for ELF platforms.

* dfg/DFGOperations.cpp:
(JSC):
(JSC::getHostCallReturnValueWithExecState):
* jit/HostCallReturnValue.cpp:
(JSC):
* jit/HostCallReturnValue.h:
(JSC::initializeHostCallReturnValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable the IDL attribute checker in Chromium
haraken@chromium.org [Tue, 21 Feb 2012 09:00:03 +0000 (09:00 +0000)]
Enable the IDL attribute checker in Chromium
https://bugs.webkit.org/show_bug.cgi?id=79082

Reviewed by Adam Barth.

We have fixed 10~ bugs caused by typos of IDL attributes.
This patch adds an IDL attribute checker, which checks if all IDL attributes
used in IDL files are implemented by code generators.

    - The IDL attribute checker uses IDLAttributes.txt, which lists all
      IDL attributes implemented in code generators. If we want to add
      a new IDL attribute, we need to add it to IDLAttributes.txt manually.
    - The IDL attribute checker checks if all IDL attributes used in IDL files
      are listed in IDLAttributes.txt.
    - If the IDL attribute checker fails, the build fails with a verbose error message.

No tests. I manually checked that [Custommm], [CallWith=],
[CallWith=ScriptExecutionContext|Foo] cause build failures.

* WebCore.gyp/WebCore.gyp: Modified to enable the IDL attribute checker.

* bindings/scripts/resolve-supplemental.pl:
(loadIDLAttributes): This method loads a list of IDL attributes from IDLAttributes.txt.
(checkIDLAttributes): This method implementes the IDL attribute checker as described above.
(checkIfIDLAttributesExists):

* bindings/scripts/IDLParser.pm: "1" is not good to represent that
the IDL attribute does not have any value. This patch changed it to "VALUE_IS_MISSING".
(parseExtendedAttributes):
(ParseInterface):
* bindings/scripts/CodeGenerator.pm: Ditto.
(ContentAttributeName):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GetRuntimeEnableFunctionName):
* bindings/scripts/IDLAttributes.txt: Added. This file lists all IDL attributes implemented
in code generators.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse Win32 API to get file information
paroga@webkit.org [Tue, 21 Feb 2012 08:43:35 +0000 (08:43 +0000)]
Use Win32 API to get file information
https://bugs.webkit.org/show_bug.cgi?id=55336

Reviewed by Adam Roben.

Use FindFirstFile() in favour over _wstat64() to share the code with WinCE.

* platform/win/FileSystemWin.cpp:
(WebCore):
(WebCore::getFindData):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::fileExists):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, update test expectations to reflect recent flakiness.
yutak@chromium.org [Tue, 21 Feb 2012 08:25:06 +0000 (08:25 +0000)]
[Chromium] Unreviewed, update test expectations to reflect recent flakiness.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRebaseline a test for GTK+.
mrobinson@webkit.org [Tue, 21 Feb 2012 08:19:42 +0000 (08:19 +0000)]
Rebaseline a test for GTK+.

* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: New baseline.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSkip some test that are failing after r108278.
mrobinson@webkit.org [Tue, 21 Feb 2012 08:10:59 +0000 (08:10 +0000)]
Skip some test that are failing after r108278.

* platform/gtk/Skipped: Skip a few tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agomastercfg_unittest.py fails without simplejson
abarth@webkit.org [Tue, 21 Feb 2012 07:54:25 +0000 (07:54 +0000)]
mastercfg_unittest.py fails without simplejson
https://bugs.webkit.org/show_bug.cgi?id=79070

Reviewed by Csaba Osztrogonác.

Now that we require Python 2.6 (and higher) we can import json rather
than simplejson.  We still need to use the simplejson name because
that's what the master.cfg script expects.

* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(BuildBotConfigLoader._add_dependant_modules_to_sys_modules):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix GTK+ unit tests after r108281.
mrobinson@webkit.org [Tue, 21 Feb 2012 07:45:54 +0000 (07:45 +0000)]
Fix GTK+ unit tests after r108281.

Reviewed by Alejandro G. Castro.

* tests/testwebplugindatabase.c:
(test_webkit_web_plugin_database_get_plugins): Update the description used
in the test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix GTK+ unit tests after r108278.
mrobinson@webkit.org [Tue, 21 Feb 2012 07:44:36 +0000 (07:44 +0000)]
Fix GTK+ unit tests after r108278.

Reviewed by Alejandro G. Castro.

Now that WebCore is no longer stealing focus, we need to
adjust where we grab focus to ensure that it actually succeeds.

* tests/testcopyandpaste.c:
(map_event_cb): No longer grab focus here.
(runPasteTestCallback): Grabbing focus here seems to be late enough in the process.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInvalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
abarth@webkit.org [Tue, 21 Feb 2012 07:32:52 +0000 (07:32 +0000)]
Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
https://bugs.webkit.org/show_bug.cgi?id=78975

Reviewed by Eric Seidel.

Source/WebCore:

We're supposed to set the action attribute on the form element we just
created.  Previously, we assumed the newly created form element would
be on the top of the stack of open elements, but if we're in the table
body insertion mode, the form element gets treated as self closing and
is therefore popped off the stack of open elements.

Fortunately, we already cache a pointer to the most recently inserted
form element on the HTMLConstructionSite, so we can just grab the
element from there.

Test: html5lib/runner.html

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):

LayoutTests:

* html5lib/resourcesl/webkit-02.dat:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnite TextTrack-related files with their friends in WebCore/html/track
abarth@webkit.org [Tue, 21 Feb 2012 07:07:21 +0000 (07:07 +0000)]
Unite TextTrack-related files with their friends in WebCore/html/track
https://bugs.webkit.org/show_bug.cgi?id=78941

Reviewed by Eric Seidel.

The code that supports <track> seems to be split between the
WebCore/html directory and the WebCore/html/track directory.  This
patch unites this code in the WebCore/html/track directory.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* html/LoadableTextTrack.cpp: Removed.
* html/LoadableTextTrack.h: Removed.
* html/TextTrack.cpp: Removed.
* html/TextTrack.h: Removed.
* html/TextTrack.idl: Removed.
* html/TextTrackCue.cpp: Removed.
* html/TextTrackCue.h: Removed.
* html/TextTrackCue.idl: Removed.
* html/TextTrackCueList.cpp: Removed.
* html/TextTrackCueList.h: Removed.
* html/TextTrackCueList.idl: Removed.
* html/track/LoadableTextTrack.cpp: Copied from Source/WebCore/html/LoadableTextTrack.cpp.
* html/track/LoadableTextTrack.h: Copied from Source/WebCore/html/LoadableTextTrack.h.
* html/track/TextTrack.cpp: Copied from Source/WebCore/html/TextTrack.cpp.
* html/track/TextTrack.h: Copied from Source/WebCore/html/TextTrack.h.
* html/track/TextTrack.idl: Copied from Source/WebCore/html/TextTrack.idl.
* html/track/TextTrackCue.cpp: Copied from Source/WebCore/html/TextTrackCue.cpp.
* html/track/TextTrackCue.h: Copied from Source/WebCore/html/TextTrackCue.h.
* html/track/TextTrackCue.idl: Copied from Source/WebCore/html/TextTrackCue.idl.
* html/track/TextTrackCueList.cpp: Copied from Source/WebCore/html/TextTrackCueList.cpp.
* html/track/TextTrackCueList.h: Copied from Source/WebCore/html/TextTrackCueList.h.
* html/track/TextTrackCueList.idl: Copied from Source/WebCore/html/TextTrackCueList.idl.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJSC should be a triple-tier VM
fpizlo@apple.com [Tue, 21 Feb 2012 06:49:37 +0000 (06:49 +0000)]
JSC should be a triple-tier VM
https://bugs.webkit.org/show_bug.cgi?id=75812
<rdar://problem/10079694>

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implemented an interpreter that uses the JIT's calling convention. This
interpreter is called LLInt, or the Low Level Interpreter. JSC will now
will start by executing code in LLInt and will only tier up to the old
JIT after the code is proven hot.

LLInt is written in a modified form of our macro assembly. This new macro
assembly is compiled by an offline assembler (see offlineasm), which
implements many modern conveniences such as a Turing-complete CPS-based
macro language and direct access to relevant C++ type information
(basically offsets of fields and sizes of structs/classes).

Code executing in LLInt appears to the rest of the JSC world "as if" it
were executing in the old JIT. Hence, things like exception handling and
cross-execution-engine calls just work and require pretty much no
additional overhead.

This interpreter is 2-2.5x faster than our old interpreter on SunSpider,
V8, and Kraken. With triple-tiering turned on, we're neutral on SunSpider,
V8, and Kraken, but appear to get a double-digit improvement on real-world
websites due to a huge reduction in the amount of JIT'ing.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/LinkBuffer.h:
* assembler/MacroAssemblerCodeRef.h:
(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):
* bytecode/BytecodeConventions.h: Added.
* bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
(JSC):
(JSC::CallLinkStatus::computeFor):
* bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::isSet):
(JSC::CallLinkStatus::operator!):
(CallLinkStatus):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::bytecodeOffset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):
* bytecode/CodeBlock.h:
(JSC):
(CodeBlock):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addLLIntCallLinkInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::numberOfMethodCallLinkInfos):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::dontJITAnytimeSoon):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::llintExecuteCounter):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeFor):
* bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::wasSeenInJIT):
(GetByIdStatus):
* bytecode/Instruction.h:
(JSC):
(JSC::Instruction::Instruction):
(Instruction):
* bytecode/LLIntCallLinkInfo.h: Added.
(JSC):
(JSC::LLIntCallLinkInfo::LLIntCallLinkInfo):
(LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::~LLIntCallLinkInfo):
(JSC::LLIntCallLinkInfo::isLinked):
(JSC::LLIntCallLinkInfo::unlink):
* bytecode/MethodCallLinkStatus.cpp:
(JSC::MethodCallLinkStatus::computeFor):
* bytecode/Opcode.cpp:
(JSC):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC):
(JSC::PutByIdStatus::computeFor):
* bytecode/PutByIdStatus.h:
(PutByIdStatus):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOperations.cpp:
* heap/Heap.h:
(JSC):
(JSC::Heap::firstAllocatorWithoutDestructors):
(Heap):
* heap/MarkStack.cpp:
(JSC::visitChildren):
* heap/MarkedAllocator.h:
(JSC):
(MarkedAllocator):
* heap/MarkedSpace.h:
(JSC):
(MarkedSpace):
(JSC::MarkedSpace::firstAllocator):
* interpreter/CallFrame.cpp:
(JSC):
(JSC::CallFrame::bytecodeOffsetForNonDFGCode):
(JSC::CallFrame::setBytecodeOffsetForNonDFGCode):
(JSC::CallFrame::currentVPC):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::trueCallerFrame):
* interpreter/CallFrame.h:
(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(ExecState):
(JSC::ExecState::bytecodeOffsetForNonDFGCode):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::~Interpreter):
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
(JSC):
(Interpreter):
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(JSC::Interpreter::classicEnabled):
* interpreter/RegisterFile.h:
(JSC):
(RegisterFile):
* jit/ExecutableAllocator.h:
(JSC):
* jit/HostCallReturnValue.cpp: Added.
(JSC):
(JSC::getHostCallReturnValueWithExecState):
* jit/HostCallReturnValue.h: Added.
(JSC):
(JSC::initializeHostCallReturnValue):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JITCode.h:
(JSC::JITCode::isOptimizingJIT):
(JITCode):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::JITCode):
* jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
* jit/JITExceptions.cpp:
(JSC::jitThrow):
* jit/JITInlineMethods.h:
(JSC::JIT::updateTopCallFrame):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC):
* jit/JITStubs.h:
(JSC):
* jit/JSInterfaceJIT.h:
* llint: Added.
* llint/LLIntCommon.h: Added.
* llint/LLIntData.cpp: Added.
(LLInt):
(JSC::LLInt::Data::Data):
(JSC::LLInt::Data::performAssertions):
(JSC::LLInt::Data::~Data):
* llint/LLIntData.h: Added.
(JSC):
(LLInt):
(Data):
(JSC::LLInt::Data::exceptionInstructions):
(JSC::LLInt::Data::opcodeMap):
(JSC::LLInt::Data::performAssertions):
* llint/LLIntEntrypoints.cpp: Added.
(LLInt):
(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):
* llint/LLIntEntrypoints.h: Added.
(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):
* llint/LLIntExceptions.cpp: Added.
(LLInt):
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrowForThrownException):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
* llint/LLIntExceptions.h: Added.
(JSC):
(LLInt):
* llint/LLIntOfflineAsmConfig.h: Added.
* llint/LLIntOffsetsExtractor.cpp: Added.
(JSC):
(LLIntOffsetsExtractor):
(JSC::LLIntOffsetsExtractor::dummy):
(main):
* llint/LLIntSlowPaths.cpp: Added.
(LLInt):
(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::shouldJIT):
(JSC::LLInt::entryOSR):
(JSC::LLInt::resolveGlobal):
(JSC::LLInt::getByVal):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):
(JSC::LLInt::genericCall):
* llint/LLIntSlowPaths.h: Added.
(JSC):
(LLInt):
* llint/LLIntThunks.cpp: Added.
(LLInt):
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::functionForCallEntryThunkGenerator):
(JSC::LLInt::functionForConstructEntryThunkGenerator):
(JSC::LLInt::functionForCallArityCheckThunkGenerator):
(JSC::LLInt::functionForConstructArityCheckThunkGenerator):
(JSC::LLInt::evalEntryThunkGenerator):
(JSC::LLInt::programEntryThunkGenerator):
* llint/LLIntThunks.h: Added.
(JSC):
(LLInt):
* llint/LowLevelInterpreter.asm: Added.
* llint/LowLevelInterpreter.cpp: Added.
* llint/LowLevelInterpreter.h: Added.
* offlineasm: Added.
* offlineasm/armv7.rb: Added.
* offlineasm/asm.rb: Added.
* offlineasm/ast.rb: Added.
* offlineasm/backends.rb: Added.
* offlineasm/generate_offset_extractor.rb: Added.
* offlineasm/instructions.rb: Added.
* offlineasm/offset_extractor_constants.rb: Added.
* offlineasm/offsets.rb: Added.
* offlineasm/opt.rb: Added.
* offlineasm/parser.rb: Added.
* offlineasm/registers.rb: Added.
* offlineasm/self_hash.rb: Added.
* offlineasm/settings.rb: Added.
* offlineasm/transform.rb: Added.
* offlineasm/x86.rb: Added.
* runtime/CodeSpecializationKind.h: Added.
(JSC):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
(CommonSlowPaths):
* runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC):
(JSC::EvalExecutable::jitCompile):
(JSC::samplingDescription):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::jitCompileFor):
* runtime/ExecutionHarness.h: Added.
(JSC):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
* runtime/JSArray.h:
(JSC):
(JSArray):
* runtime/JSCell.h:
(JSC):
(JSCell):
* runtime/JSFunction.h:
(JSC):
(JSFunction):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.h:
(JSC):
(JSGlobalObject):
* runtime/JSObject.h:
(JSC):
(JSObject):
(JSFinalObject):
* runtime/JSPropertyNameIterator.h:
(JSC):
(JSPropertyNameIterator):
* runtime/JSString.h:
(JSC):
(JSString):
* runtime/JSTypeInfo.h:
(JSC):
(TypeInfo):
* runtime/JSValue.cpp:
(JSC::JSValue::description):
* runtime/JSValue.h:
(LLInt):
(JSValue):
* runtime/JSVariableObject.h:
(JSC):
(JSVariableObject):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* runtime/ScopeChain.h:
(JSC):
(ScopeChainNode):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC):
(Structure):
* runtime/StructureChain.h:
(JSC):
(StructureChain):
* wtf/InlineASM.h:
* wtf/Platform.h:
* wtf/SentinelLinkedList.h:
(SentinelLinkedList):
(WTF::SentinelLinkedList::isEmpty):
* wtf/text/StringImpl.h:
(JSC):
(StringImpl):

Source/WebCore:

Reviewed by Gavin Barraclough.

No new tests, because there is no change in behavior.

* CMakeLists.txt:

Source/WebKit:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

* CMakeLists.txt:

Tools:

Reviewed by Gavin Barraclough.

Changed EFL's build system to include a new directory in JavaScriptCore.

* DumpRenderTree/efl/CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoGet rid of the LocalizationStrategy
benjamin@webkit.org [Tue, 21 Feb 2012 06:38:10 +0000 (06:38 +0000)]
Get rid of the LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=78324

Reviewed by Sam Weinig.

Source/WebCore:

Remove LocalizationStrategy and unify the localization behind
LocalizedStrings.h and LocalizedStrings.cpp.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/DefaultLocalizationStrategy.cpp: Removed.
* platform/DefaultLocalizationStrategy.h: Removed.
* platform/LocalizationStrategy.h: Removed.
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
(WebCore):
* platform/PlatformStrategies.cpp:
* platform/PlatformStrategies.h:
(WebCore):
(WebCore::PlatformStrategies::PlatformStrategies):
(PlatformStrategies):
* platform/qt/LocalizedStringsQt.cpp: Copied from Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp.

Source/WebKit/qt:

Move the localization code from PlatformStrategiesQt.cpp
to LocalizedStringsQt.cpp.

Get rid of LocalizationStrategy from PlatformStrategiesQt

* WebCoreSupport/PlatformStrategiesQt.cpp:
* WebCoreSupport/PlatformStrategiesQt.h:
(PlatformStrategiesQt):

Source/WebKit/wince:

Remove a useless #include of LocalizationStrategy.h.

* WebCoreSupport/PlatformStrategiesWinCE.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out http://trac.webkit.org/changeset/108291
fpizlo@apple.com [Tue, 21 Feb 2012 06:34:14 +0000 (06:34 +0000)]
Unreviewed, rolling out trac.webkit.org/changeset/108291
It completely broke the 32-bit JIT.

* heap/CopiedAllocator.h:
* heap/CopiedSpace.h:
(CopiedSpace):
* heap/Heap.h:
(JSC::Heap::allocatorForObjectWithDestructor):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JIT):
* jit/JITInlineMethods.h:
(JSC):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array):
* runtime/JSArray.cpp:
(JSC::storageSize):
(JSC):
* runtime/JSArray.h:
(ArrayStorage):
(JSArray):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r108259.
ossy@webkit.org [Tue, 21 Feb 2012 06:30:07 +0000 (06:30 +0000)]
[Qt] Unreviewed gardening after r108259.

* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
haraken@chromium.org [Tue, 21 Feb 2012 06:23:57 +0000 (06:23 +0000)]
Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
https://bugs.webkit.org/show_bug.cgi?id=79064

Reviewed by Hajime Morita.

[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
But as far as I read the spec
(http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
is not yet initialized. In particular, there is no statement that says "null should
be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
Removing [TreatReturnedNullStringAsNull] does not change the current behavior.

Test: media/media-controller.html (No change in the test results.)

* html/HTMLMediaElement.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[[Put]] should throw if prototype chain contains a readonly property.
barraclough@apple.com [Tue, 21 Feb 2012 06:17:40 +0000 (06:17 +0000)]
[[Put]] should throw if prototype chain contains a readonly property.
https://bugs.webkit.org/show_bug.cgi?id=79069

Reviewed by Oliver Hunt.

Currently we only check the base of the put, not the prototype chain.
Fold this check in with the test for accessors.

Source/JavaScriptCore:

* runtime/JSObject.cpp:
(JSC::JSObject::put):
    - Updated to test all objects in the propotype chain for readonly properties.
(JSC::JSObject::putDirectAccessor):
(JSC::putDescriptor):
    - Record the presence of readonly properties on the structure.
* runtime/Structure.cpp:
(JSC::Structure::Structure):
    - hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.
* runtime/Structure.h:
(JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto):
(JSC::Structure::setHasGetterSetterProperties):
    - hasGetterSetterPropertiesExcludingProto expanded to hasReadOnlyOrGetterSetterPropertiesExcludingProto.
(JSC::Structure::setContainsReadOnlyProperties):
    - Added.

LayoutTests:

* fast/js/Object-defineProperty-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
(get shouldBeTrue):
    - Added test case.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse InsertinonPoint instead of HTMLContentElement.
hayato@chromium.org [Tue, 21 Feb 2012 06:15:04 +0000 (06:15 +0000)]
Use InsertinonPoint instead of HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=78778

Reviewed by Hajime Morita.

Replace HTMLContentElement with InsertionPoint in NodeRenderingContext and HTMLContentSelection.
This is one of followup patches for r108207.

No new tests, no change in behavior.

* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
* dom/NodeRenderingContext.h:
(WebCore):
(NodeRenderingContext):
(WebCore::NodeRenderingContext::insertionPoint):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointFor):
* dom/ShadowRoot.h:
(WebCore):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelector::select):
* html/shadow/HTMLContentSelector.h:
(WebCore):
(HTMLContentSelection):
(WebCore::HTMLContentSelection::insertionPoint):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
* html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::selections):
(WebCore::InsertionPoint::hasSelection):
(InsertionPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMathML internals - code clean-up for RenderMathMLSubSup
commit-queue@webkit.org [Tue, 21 Feb 2012 06:00:51 +0000 (06:00 +0000)]
MathML internals - code clean-up for RenderMathMLSubSup
https://bugs.webkit.org/show_bug.cgi?id=79063

Patch by David Barton <dbarton@mathscribe.com> on 2012-02-20
Reviewed by Eric Seidel.

In the next patch, I will shrink and revise the <msubsup> formatting code. To make this
easier to follow, I am first doing some simple code clean-up.

No new tests.

* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):
* rendering/mathml/RenderMathMLRow.h:
(WebCore::RenderMathMLRow::isRenderMathMLRow):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
(WebCore::RenderMathMLSubSup::layout):
    - There is no need to iterate over baseWrapper's children since it should have only
      one child, the base of the <msubsup>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReplace [V8Custom=DOMWindowNOP] with [V8Custom]
haraken@chromium.org [Tue, 21 Feb 2012 05:52:43 +0000 (05:52 +0000)]
Replace [V8Custom=DOMWindowNOP] with [V8Custom]
https://bugs.webkit.org/show_bug.cgi?id=79062

Reviewed by Adam Barth.

[V8Custom=DOMWindowNOP] is not implemented by CodeGeneratorV8.pm.
This patch replaces it with [V8Custom].

No new tests. No change in behavior.

* page/DOMWindow.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
haraken@chromium.org [Tue, 21 Feb 2012 05:28:36 +0000 (05:28 +0000)]
[JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
https://bugs.webkit.org/show_bug.cgi?id=79061

Reviewed by Adam Barth.

CSSStyleDeclaration.idl uses [JSGenerateIsReachable=ImplRoot],
but "ImplRoot" is not implemented in CodeGeneratorJS.pm.
This patch replaces [JSGenerateIsReachable=ImplRoot] with [JSGenerateIsReachable].

No tests. No change in behavior.

* css/CSSStyleDeclaration.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago There is no complete test cases of optional arguments for MediaStream API and PeerCo...
commit-queue@webkit.org [Tue, 21 Feb 2012 05:25:05 +0000 (05:25 +0000)]
 There is no complete test cases of optional arguments for MediaStream API and PeerConnection
 https://bugs.webkit.org/show_bug.cgi?id=78578

 Reviewed by Adam Barth.

 * fast/mediastream/peerconnection-AttributesMethod-expected.txt: Added.
 * fast/mediastream/peerconnection-AttributesMethod.html: Added.
 * fast/mediastream/peerconnection-addstream-expected.txt:
 * fast/mediastream/peerconnection-argument-types-expected.txt: Added.
 * fast/mediastream/peerconnection-argument-types.html: Added.
 * fast/mediastream/peerconnection-removestream-expected.txt: Added.
 * fast/mediastream/peerconnection-removestream.html: Added.
 * fast/mediastream/script-tests/AttributesMethod.js: Added.
 * fast/mediastream/script-tests/argument-types.js: Added.
 * fast/mediastream/script-tests/peerconnection-addstream.js:
 * fast/mediastream/script-tests/peerconnection-removestream.js: Added.

Patch by Yanbin Zhang <yanbin.zhang@intel.com> on 2012-02-20

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
haraken@chromium.org [Tue, 21 Feb 2012 05:21:16 +0000 (05:21 +0000)]
[EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
https://bugs.webkit.org/show_bug.cgi?id=79058

Reviewed by Adam Barth.

[EnabledAtRuntime] does not exist any longer. It should be [V8EnabledAtRuntime].

No tests.

* html/shadow/HTMLShadowElement.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReplace [Callback=FunctionOnly] with [Callback]
haraken@chromium.org [Tue, 21 Feb 2012 04:52:58 +0000 (04:52 +0000)]
Replace [Callback=FunctionOnly] with [Callback]
https://bugs.webkit.org/show_bug.cgi?id=79060

Reviewed by Adam Barth.

[Callback=FunctionOnly] is not implemented by any code generator.
This patch replaces it with [Callback].

No tests. No change in behavior.

* Modules/intents/IntentResultCallback.idl:
* Modules/intents/NavigatorIntents.idl:
* dom/RequestAnimationFrameCallback.idl:
* mediastream/NavigatorMediaStream.idl:
* mediastream/NavigatorUserMediaErrorCallback.idl:
* mediastream/NavigatorUserMediaSuccessCallback.idl:
* mediastream/PeerConnection.idl:
* mediastream/SignalingCallback.idl:
* page/PositionCallback.idl:
* page/PositionErrorCallback.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Need to override active/inactive text search highlight color for RenderT...
commit-queue@webkit.org [Tue, 21 Feb 2012 04:17:26 +0000 (04:17 +0000)]
[BlackBerry] Need to override active/inactive text search highlight color for RenderThemeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78920

Override two functions for text search highlight colors so that we can
provide platform specified colors.

Patch by Andy Chen <andchen@rim.com> on 2012-02-17
Reviewed by Antonio Gomes.

No function change so no new tests.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::platformActiveTextSearchHighlightColor):
(WebCore::RenderThemeBlackBerry::platformInactiveTextSearchHighlightColor):
* platform/blackberry/RenderThemeBlackBerry.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, update test expectations.
yutak@chromium.org [Tue, 21 Feb 2012 04:12:25 +0000 (04:12 +0000)]
[Chromium] Unreviewed, update test expectations.

* platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt:
* platform/chromium/fast/js/string-capitalization-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDefault canvas backing store to be 1:1 with specified dimensions.
jknotten@chromium.org [Tue, 21 Feb 2012 03:48:59 +0000 (03:48 +0000)]
Default canvas backing store to be 1:1 with specified dimensions.
https://bugs.webkit.org/show_bug.cgi?id=78971

Reviewed by Adam Barth.

Although the canvas specification states that the backing image may
be larger than the user-specified dimensions, there are a number of
philip canvas tests that fail when the backing image data is not
1:1 with the specified canvas dimensions. These failures are
tracked in https://bugs.webkit.org/show_bug.cgi?id=73645

This change defaults the canvas backing store to be 1:1 with the
user-specified dimensions, while also providing an
ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
behaviour, so that the above bug may be more easily fixed.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate pywebsocket to 0.7.2
bashi@chromium.org [Tue, 21 Feb 2012 03:24:45 +0000 (03:24 +0000)]
Update pywebsocket to 0.7.2
https://bugs.webkit.org/show_bug.cgi?id=79066

This version includes vendor-prefixed deflate-frame extension support.

Reviewed by Kent Tamura.

* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_pywebsocket):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplement fast path for op_new_array in the baseline JIT
mhahnenberg@apple.com [Tue, 21 Feb 2012 03:20:37 +0000 (03:20 +0000)]
Implement fast path for op_new_array in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=78612

Reviewed by Filip Pizlo.

* heap/CopiedAllocator.h:
(CopiedAllocator): Friended the JIT to allow access to m_currentOffset.
* heap/CopiedSpace.h:
(CopiedSpace): Friended the JIT to allow access to
(JSC::CopiedSpace::allocator):
* heap/Heap.h:
(JSC::Heap::storageAllocator): Added a getter for the CopiedAllocator class so the JIT
can use it for simple allocation i.e. when we can just bump the offset without having to
do anything else.
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases): Added new slow case for op_new_array for when
we have to bail out because the fast allocation path fails for whatever reason.
* jit/JIT.h:
(JIT):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicStorage): Added utility function that allows objects to
allocate generic backing stores. This function is used by emitAllocateJSArray.
(JSC):
(JSC::JIT::emitAllocateJSArray): Added utility function that allows the client to
more easily allocate JSArrays. This function is used by emit_op_new_array and I expect
it will also be used for emit_op_new_array_buffer.
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_array): Changed to do inline allocation of JSArrays. Still does
a stub call for oversize arrays.
(JSC):
(JSC::JIT::emitSlow_op_new_array): Just bails out to a stub call if we fail in any way on
the fast path.
* runtime/JSArray.cpp:
(JSC):
* runtime/JSArray.h: Added lots of offset functions for all the fields that we need to
initialize in the JIT.
(ArrayStorage):
(JSC::ArrayStorage::lengthOffset):
(JSC::ArrayStorage::numValuesInVectorOffset):
(JSC::ArrayStorage::allocBaseOffset):
(JSC::ArrayStorage::vectorOffset):
(JSArray):
(JSC::JSArray::sparseValueMapOffset):
(JSC::JSArray::subclassDataOffset):
(JSC::JSArray::indexBiasOffset):
(JSC):
(JSC::JSArray::storageSize): Moved this function from being a static function in the cpp file
to being a static function in the JSArray class. This move allows the JIT to call it to
see what size it should allocate.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
commit-queue@webkit.org [Tue, 21 Feb 2012 03:19:17 +0000 (03:19 +0000)]
Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=78785

Main Contributors:
Daniel Bates <dbates@rim.com>
Bryan Gislason <bgislason@rim.com>
Akash Vaswani <akvaswani@rim.com>
Dave Battista <dbattista@rim.com>
Robin Cao  <robin.cao@torchmobile.com.cn>
Genevieve Mak <gmak@rim.com>
Mike Fenton  <mifenton@rim.com>

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2012-02-20
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* platform/blackberry/RenderThemeBlackBerry.cpp: Added.
* platform/blackberry/RenderThemeBlackBerry.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] [EFL] Collapse duplicate WebGL support code
commit-queue@webkit.org [Tue, 21 Feb 2012 03:10:17 +0000 (03:10 +0000)]
[GTK] [EFL] Collapse duplicate WebGL support code
https://bugs.webkit.org/show_bug.cgi?id=78970

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-02-20
Reviewed by Gustavo Noronha Silva.

No new tests. This just cleans up duplicated code.

Centralize duplicated WebGL code for EFL and GTK+ in the Cairo
directory. This is in preparation for the changes necessary to
connect WebGL to the TextureMapper AC.

* GNUmakefile.list.am: Update source list.
* PlatformEfl.cmake: Update source list.
* platform/graphics/cairo/DrawingBufferCairo.cpp: Renamed from Source/WebCore/platform/graphics/gtk/DrawingBufferGtk.cpp.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp: Integrated the code From GraphicsContext3DGtk.cpp.
* platform/graphics/efl/DrawingBufferEfl.cpp: Removed.
* platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed.
* platform/graphics/gtk/GraphicsContext3DGtk.cpp: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108289 268f45cc-cd09-0410-ab3c-d52691b4dbfc