platform/upstream/dotnet/runtime.git
7 years agoWorkaround libgdiplus glitches
Frederik Carlier [Wed, 20 Sep 2017 21:28:15 +0000 (23:28 +0200)]
Workaround libgdiplus glitches

Don't test metafileHeader.Bounds when using libgdiplus.
Don't test metafile.GetBounds on Unix, force MetafileHeader.Bounds to return an empty rectangle when MetafileSize == 0
Don't validate graphicsUnit on Unix.

Commit migrated from https://github.com/dotnet/corefx/commit/825ef7c0d16798739f4cb69d3a4f1e924ef7ff18

7 years agoDon't depend on X11 in the MetafileTests
Frederik Carlier [Wed, 20 Sep 2017 20:30:54 +0000 (22:30 +0200)]
Don't depend on X11 in the MetafileTests

Commit migrated from https://github.com/dotnet/corefx/commit/6f55b588730ce3d2f341c4ed6af1bc536a570a1d

7 years agoMerge pull request dotnet/corefx#24194 from mellinoe/system.drawing-finish-consolidation
Eric Mellino [Thu, 21 Sep 2017 21:27:36 +0000 (14:27 -0700)]
Merge pull request dotnet/corefx#24194 from mellinoe/system.drawing-finish-consolidation

[Drawing] Move remaining "Unix" files into regular directory structure

Commit migrated from https://github.com/dotnet/corefx/commit/0f14a8cd6b06bcba290e796a641d0acd6a7706b1

7 years agoMerge pull request dotnet/corefx#24183 from maryamariyan/odbc-temp
Eric Mellino [Thu, 21 Sep 2017 19:21:36 +0000 (12:21 -0700)]
Merge pull request dotnet/corefx#24183 from maryamariyan/odbc-temp

Adding System.Data.Odbc package and including in metapackage

Commit migrated from https://github.com/dotnet/corefx/commit/a7575a74be9a3e7ea161298acc6af477f38b7161

7 years ago[Drawing] Move remaining "Unix" files into regular directory structure
Eric Mellino [Thu, 21 Sep 2017 19:03:22 +0000 (12:03 -0700)]
[Drawing] Move remaining "Unix" files into regular directory structure

* As part of this, the "Windows" version of ImageFormat.cs is now being
  used everywhere. This file just contains a bunch of GUID's that are not
  platform-specific in any way.

Commit migrated from https://github.com/dotnet/corefx/commit/74a3d566ecee00e442f05157fd6952f389ff08e2

7 years agoMerge pull request dotnet/corefx#24184 from hughbe/brush-mt
Eric Mellino [Thu, 21 Sep 2017 19:06:51 +0000 (12:06 -0700)]
Merge pull request dotnet/corefx#24184 from hughbe/brush-mt

Fix MultiplyTransform with a disposed brush

Commit migrated from https://github.com/dotnet/corefx/commit/eb851a2b0243859be21e0d9d6fc3c4a4c5f9c7c5

7 years agoCoreFx dotnet/corefx#22406 Span based APIs - Text Reader Writer (dotnet/corefx#23786)
Mandar Sahasrabuddhe [Thu, 21 Sep 2017 17:39:23 +0000 (23:09 +0530)]
CoreFx dotnet/corefx#22406 Span based APIs - Text Reader Writer (dotnet/corefx#23786)

Commit migrated from https://github.com/dotnet/corefx/commit/c09ce65e6de10572abe4058f514338db2ef47ed9

7 years agoFix for 2nd Connection hangs in Mirroring Environment (dotnet/corefx#24181)
Gene Lee [Thu, 21 Sep 2017 09:25:47 +0000 (02:25 -0700)]
Fix for 2nd Connection hangs in Mirroring Environment (dotnet/corefx#24181)

Commit migrated from https://github.com/dotnet/corefx/commit/dd48b05151c56fcf92cacc071f80fd39c099cadc

7 years agoFix MultiplyTransform with a disposed brush
Hugh Bellamy [Thu, 21 Sep 2017 09:00:29 +0000 (10:00 +0100)]
Fix MultiplyTransform with a disposed brush

Commit migrated from https://github.com/dotnet/corefx/commit/cde07104a9369b2542098e426bc5fa399741272b

7 years agoAdding System.Data.Odbc package and including in metapackage
Maryam Ariyan [Thu, 21 Sep 2017 03:33:02 +0000 (23:33 -0400)]
Adding System.Data.Odbc package and including in metapackage

Commit migrated from https://github.com/dotnet/corefx/commit/c895e10bfce739bcc77b4aead77f911dec6774d6

7 years agoRemove unused FEATURE_RANDOMIZED_STRING_HASHING (dotnet/corefx#24178)
Kevin Gosse [Wed, 20 Sep 2017 22:24:04 +0000 (00:24 +0200)]
Remove unused FEATURE_RANDOMIZED_STRING_HASHING (dotnet/corefx#24178)

Commit migrated from https://github.com/dotnet/corefx/commit/b73daf35e0188c1202be727806dede253f3b4332

7 years agoMerge pull request dotnet/corefx#24150 from qmfrederik/drawing/graphics-mono-tests
Eric Mellino [Wed, 20 Sep 2017 21:56:16 +0000 (14:56 -0700)]
Merge pull request dotnet/corefx#24150 from qmfrederik/drawing/graphics-mono-tests

System.Drawing - Add Graphics tests based on Mono's test suite

Commit migrated from https://github.com/dotnet/corefx/commit/de59a4244556433aee39faba347402a30801f03c

7 years agoFix memory map imports (dotnet/corefx#24176)
Jeremy Kuhne [Wed, 20 Sep 2017 21:13:40 +0000 (14:13 -0700)]
Fix memory map imports (dotnet/corefx#24176)

* Fix memory map imports

Imports lost the last error attribute. Add it back and change the results to be the more correct "bool". Tweak the usage based on the new return type.

dotnet/corefx#24159

* Move spin wait

Commit migrated from https://github.com/dotnet/corefx/commit/b0a91f4a19784d87f51c678baadbfe266440f4c0

7 years agoMerge pull request dotnet/corefx#23932 from JonHanna/biginteger_reach_minvalue_opt
Eric Mellino [Wed, 20 Sep 2017 19:31:22 +0000 (12:31 -0700)]
Merge pull request dotnet/corefx#23932 from JonHanna/biginteger_reach_minvalue_opt

Make BigInteger ctor opt path for == int.MinValue reachable.

Commit migrated from https://github.com/dotnet/corefx/commit/2a650d568dba1724b0fe136af6714d7133aab745

7 years agoMerge pull request dotnet/corefx#24166 from hughbe/hatchbrush-fixes
Eric Mellino [Wed, 20 Sep 2017 19:29:24 +0000 (12:29 -0700)]
Merge pull request dotnet/corefx#24166 from hughbe/hatchbrush-fixes

Fix HatchBrush constructor validation, renable more passing tests on Unix

Commit migrated from https://github.com/dotnet/corefx/commit/aa1ff5efc54ee788687c8a912afe2937f4538858

7 years agoMerge pull request dotnet/corefx#24086 from mellinoe/system.drawing-mono-win32-cleanup
Eric Mellino [Wed, 20 Sep 2017 19:24:42 +0000 (12:24 -0700)]
Merge pull request dotnet/corefx#24086 from mellinoe/system.drawing-mono-win32-cleanup

Consolidate more code in the "System.Drawing" namespace.

Commit migrated from https://github.com/dotnet/corefx/commit/dce54eac6369631bf9e0af274cb0abd484edb331

7 years agoPR feedback
Frederik Carlier [Wed, 20 Sep 2017 19:21:50 +0000 (21:21 +0200)]
PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5d1ee6567cd0cae92b66a49168b5bfdcb91a53f7

7 years agoAddress PR feedback
Hugh Bellamy [Wed, 20 Sep 2017 18:35:44 +0000 (19:35 +0100)]
Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/5fbce4b45c94c6f7246d9c58e28c6761dbee7dd9

7 years agoMerge pull request dotnet/corefx#24170 from danmosemsft/fix.threadsleep
Eric Mellino [Wed, 20 Sep 2017 18:09:33 +0000 (11:09 -0700)]
Merge pull request dotnet/corefx#24170 from danmosemsft/fix.threadsleep

Remove Thread.Sleep workaround

Commit migrated from https://github.com/dotnet/corefx/commit/0b2dc05d223938570724da180a3fadbbb0a9052d

7 years agoUpdate BuildTools to prerelease-02020-01 (dotnet/corefx#24172)
Drew Scoggins [Wed, 20 Sep 2017 17:45:20 +0000 (10:45 -0700)]
Update BuildTools to prerelease-02020-01 (dotnet/corefx#24172)

Commit migrated from https://github.com/dotnet/corefx/commit/933ffa4d80a4183951deddfbc4510a94fb12b3f1

7 years agoRemove Thread.Sleep workaround
danmosemsft [Wed, 20 Sep 2017 17:00:35 +0000 (10:00 -0700)]
Remove Thread.Sleep workaround

Commit migrated from https://github.com/dotnet/corefx/commit/7af1113607a94a22fa2e340863408b90211c2f53

7 years agoRenable some already passing tests
Hugh Bellamy [Wed, 20 Sep 2017 11:15:50 +0000 (12:15 +0100)]
Renable some already passing tests

Commit migrated from https://github.com/dotnet/corefx/commit/fa1422e4b4c608be2b98542736776de1e10c0460

7 years agoRemove references to historical Mono bug IDs
Frederik Carlier [Wed, 20 Sep 2017 11:10:17 +0000 (13:10 +0200)]
Remove references to historical Mono bug IDs

Commit migrated from https://github.com/dotnet/corefx/commit/822338b447ed336c5e60d23066f1fe347909abe0

7 years agoDelete accidentally duplicated HatchBrush tests in LinearGradientBrushTests
Hugh Bellamy [Wed, 20 Sep 2017 10:51:57 +0000 (11:51 +0100)]
Delete accidentally duplicated HatchBrush tests in LinearGradientBrushTests

Commit migrated from https://github.com/dotnet/corefx/commit/c8767bc47a4a365ad1fc362733b9ba0c36b3707a

7 years agoValidate HatchStyle passed to HatchBrush ctor
Hugh Bellamy [Wed, 20 Sep 2017 10:50:58 +0000 (11:50 +0100)]
Validate HatchStyle passed to HatchBrush ctor

Commit migrated from https://github.com/dotnet/corefx/commit/6406e382af893765a21eab1d2e11431cb838afde

7 years agoCleanup - Add/simplify using statements of disposable resources (Graphics, Bitmap)
Frederik Carlier [Wed, 20 Sep 2017 10:09:34 +0000 (12:09 +0200)]
Cleanup - Add/simplify using statements of disposable resources (Graphics, Bitmap)

Commit migrated from https://github.com/dotnet/corefx/commit/0b5b1e4113ee848041c89256589d6aec5b9672b8

7 years agoBump System.Drawing.Common.TestData to 1.0.6 (dotnet/corefx#24149)
Frederik Carlier [Tue, 19 Sep 2017 21:54:58 +0000 (23:54 +0200)]
Bump System.Drawing.Common.TestData to 1.0.6 (dotnet/corefx#24149)

* Bump system.drawing.common.testdata to 1.0.6

* Fix path to test data

* Fix whitespace

Commit migrated from https://github.com/dotnet/corefx/commit/c4e03f00fe667aed5a4a79a4b039a8c842fdfcc4

7 years agoAdd an error code fixup to Bitmap.Unix.cs to match Windows.
Eric Mellino [Tue, 19 Sep 2017 21:44:46 +0000 (14:44 -0700)]
Add an error code fixup to Bitmap.Unix.cs to match Windows.

Commit migrated from https://github.com/dotnet/corefx/commit/a4e548c30693ab6e7922a2d8b1444847265fc1f1

7 years agoFix multiplying TextureBrush with a disposed matrix on Unix (dotnet/corefx#24109)
Hugh Bellamy [Tue, 19 Sep 2017 21:28:44 +0000 (22:28 +0100)]
Fix multiplying TextureBrush with a disposed matrix on Unix (dotnet/corefx#24109)

* Fix multiplying TextureBrush with a disposed matrix on Unix

* Enable another passing test

* Fix accidentally committed file

Commit migrated from https://github.com/dotnet/corefx/commit/15f9a31fd45f9a7d667765ef08ecfd1cefddde3a

7 years agoRemove duplicate tests.
Frederik Carlier [Tue, 19 Sep 2017 21:06:10 +0000 (23:06 +0200)]
Remove duplicate tests.

Commit migrated from https://github.com/dotnet/corefx/commit/6cdccce2ef06ae448aa99ecface2085157b0c72d

7 years agoAdd conditionals for recent versions of mono
Frederik Carlier [Tue, 19 Sep 2017 20:34:28 +0000 (22:34 +0200)]
Add conditionals for recent versions of mono

Commit migrated from https://github.com/dotnet/corefx/commit/a379e9cff54b001eecf37c4653de88b5142c1363

7 years agoTiny bit of code cleanup
Frederik Carlier [Tue, 19 Sep 2017 20:34:14 +0000 (22:34 +0200)]
Tiny bit of code cleanup

Commit migrated from https://github.com/dotnet/corefx/commit/b51ddcb89f66dfde8e33061ac030b01b03628947

7 years agoConsolidate more code in the "System.Drawing" namespace.
Eric Mellino [Thu, 14 Sep 2017 23:55:20 +0000 (16:55 -0700)]
Consolidate more code in the "System.Drawing" namespace.

* Remove all remaining Win32 codepaths from the mono codebase. All of this
  code now implicitly assumes that it will be run on a Unix platform.
* Consolidate the rest of the gdipFunctions.cs file into Gdip.cs and
  GdipNative.Unix.cs
* Consolidate the GraphicsUnit and ImageType enumerations -- they were
  duplicated.
* Remove the mono Status enum and use the Windows constants instead in all
  Unix code.
* Move all files into the regular directory structure. Suffix them with
  ".Unix" and ".Windows" when there are collisions.

Commit migrated from https://github.com/dotnet/corefx/commit/98a954b18bc3facbfd19ae35481788c738f6ae62

7 years agoAdd GraphicsTests based on Mono's test suite.
Frederik Carlier [Tue, 19 Sep 2017 20:14:50 +0000 (22:14 +0200)]
Add GraphicsTests based on Mono's test suite.

Commit migrated from https://github.com/dotnet/corefx/commit/a44c20c316e9b847e74252c6644d7ad375df3661

7 years agoFix whitespace
Frederik Carlier [Tue, 19 Sep 2017 20:03:38 +0000 (22:03 +0200)]
Fix whitespace

Commit migrated from https://github.com/dotnet/corefx/commit/4075ec559ca8f4f203b29fd279c1f000eca2b997

7 years agoFix path to test data
Frederik Carlier [Mon, 18 Sep 2017 18:47:42 +0000 (20:47 +0200)]
Fix path to test data

Commit migrated from https://github.com/dotnet/corefx/commit/4f06af813b0687dad8566077b13f245eeaa7ea34

7 years agoUpdate BuildTools to prerelease-02019-02 (dotnet/corefx#24146)
dotnet-maestro-bot [Tue, 19 Sep 2017 20:02:28 +0000 (13:02 -0700)]
Update BuildTools to prerelease-02019-02 (dotnet/corefx#24146)

Commit migrated from https://github.com/dotnet/corefx/commit/014e831ae385e0daff36895f7e9a36839057a02d

7 years agoBump system.drawing.common.testdata to 1.0.6
Frederik Carlier [Wed, 13 Sep 2017 22:23:17 +0000 (00:23 +0200)]
Bump system.drawing.common.testdata to 1.0.6

Commit migrated from https://github.com/dotnet/corefx/commit/8020b147e6edddc8e7657fd91db780c4c6b07ab6

7 years agoRemove invalid NameResolution tests (dotnet/corefx#24147)
David Shulman [Tue, 19 Sep 2017 19:10:21 +0000 (12:10 -0700)]
Remove invalid NameResolution tests (dotnet/corefx#24147)

The Dns_GetHostEntryAsync_* are fundamentially invalid because it's
possible for the broadcast address, 255.255.255.255, to have an DNS
mapping via manually modifying the hosts file.  This was actually
happening on Mac systems as well as an virtual environment running on
top of that (i.e. Windows on Parallels).

Ref:
https://github.com/dotnet/corefx/issues/23992#issuecomment-330250642

Contributes to dotnet/corefx#23992

Commit migrated from https://github.com/dotnet/corefx/commit/e33bee86b4777a2de04bd0dc5b6e9e918bac302a

7 years agoSystem.Drawing: Throw ArgumentNullException on Unix as well (dotnet/corefx#24140)
Frederik Carlier [Tue, 19 Sep 2017 15:19:41 +0000 (17:19 +0200)]
System.Drawing: Throw ArgumentNullException on Unix as well (dotnet/corefx#24140)

* Throw ArgumentNullException when stream is null

* Throw ArgumentNullException when stream is null

Commit migrated from https://github.com/dotnet/corefx/commit/7099d7e7e2fc0e369f29ddc6e53673f73b619cb6

7 years agoMarking {ReadOnly}Span as readonly structs (dotnet/corefx#23908)
Ahson Ahmed Khan [Tue, 19 Sep 2017 15:19:22 +0000 (08:19 -0700)]
Marking {ReadOnly}Span as readonly structs (dotnet/corefx#23908)

* Marking {ReadOnly}Span as readonly structs, fixing issue dotnet/corefx#23809

* Adding readonly attributes to reference assemblies.

* Using "readonly ref" keyword instead of attributes.

* Adding a LangVersion 7.2 property

Commit migrated from https://github.com/dotnet/corefx/commit/6542f6466c929f5590308f0a9150f1aed7b52f49

7 years agoFixed compile warning/error on FreeBSD (dotnet/corefx#24141)
Szczepan [Tue, 19 Sep 2017 14:49:07 +0000 (16:49 +0200)]
Fixed compile warning/error on FreeBSD (dotnet/corefx#24141)

Commit migrated from https://github.com/dotnet/corefx/commit/b1ceb5357f24302f0b5ba0c35be70c7e8cdcfd51

7 years agoUpdate BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02019-01, previ...
dotnet-maestro-bot [Tue, 19 Sep 2017 11:48:10 +0000 (04:48 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02019-01, preview1-25718-02, preview1-25718-03, preview1-25717-02, preview1-25718-01, respectively (dotnet/corefx#24075)

Commit migrated from https://github.com/dotnet/corefx/commit/996ddfd4489436907ef4e282cbfb99f9eb03f00c

7 years agoMerge pull request dotnet/corefx#24131 from mellinoe/revert-remove-drawing
Eric Mellino [Tue, 19 Sep 2017 00:55:17 +0000 (17:55 -0700)]
Merge pull request dotnet/corefx#24131 from mellinoe/revert-remove-drawing

Revert "Remove System.Drawing.Common from the netfx compat package

Commit migrated from https://github.com/dotnet/corefx/commit/5846dbe88490a7685f29784277dd2e599d7cb366

7 years agoRevert "Remove System.Drawing.Common from the netfx compat package (temporary)."
Eric Mellino [Tue, 19 Sep 2017 00:48:42 +0000 (17:48 -0700)]
Revert "Remove System.Drawing.Common from the netfx compat package (temporary)."

This reverts commit dotnet/corefx@f6b0fbd09b8a6dc312e55644a1353cea0fb2936d.

Commit migrated from https://github.com/dotnet/corefx/commit/f41685e2d4bcb350fd5129391e23e82a51523547

7 years agoDisable Test_Write_Metric_eventListener on UWP. (dotnet/corefx#24127)
Brian Robbins [Tue, 19 Sep 2017 00:48:40 +0000 (17:48 -0700)]
Disable Test_Write_Metric_eventListener on UWP. (dotnet/corefx#24127)

Commit migrated from https://github.com/dotnet/corefx/commit/72d769c5cf89ab7875cd4fecf4461c46a4b8cbcd

7 years agoFix instantiating PrincipleContext with Domain type (dotnet/corefx#24122)
Tarek Mahmoud Sayed [Tue, 19 Sep 2017 00:45:54 +0000 (17:45 -0700)]
Fix instantiating PrincipleContext  with Domain type (dotnet/corefx#24122)

* Fix instantiating PrincipleContext  with Domain type

* Enhancement

Commit migrated from https://github.com/dotnet/corefx/commit/adde5513211d944e937449d01f45a823ebd2a469

7 years agoStop running Math.Clamp tests on UAP as API is not there (dotnet/corefx#24125)
Dan Moseley [Tue, 19 Sep 2017 00:32:10 +0000 (17:32 -0700)]
Stop running Math.Clamp tests on UAP as API is not there (dotnet/corefx#24125)

* Stop running Math.Clamp tests on UAP as API is not there

* Disable only for AOT

Commit migrated from https://github.com/dotnet/corefx/commit/03e4e25a1209033f0a82f4f24660ba7cb1db5049

7 years agoMerge pull request dotnet/corefx#24130 from mellinoe/netfx-compat-remove-drawing
Eric Mellino [Tue, 19 Sep 2017 00:13:39 +0000 (17:13 -0700)]
Merge pull request dotnet/corefx#24130 from mellinoe/netfx-compat-remove-drawing

Remove System.Drawing.Common from the netfx compat package (temporary).

Commit migrated from https://github.com/dotnet/corefx/commit/3ed51f91220858f5f8f84579e184bda406ff41b8

7 years agoUpdating corefx to use new roslyn compiler (dotnet/corefx#24076)
Jose Perez Rodriguez [Tue, 19 Sep 2017 00:02:24 +0000 (17:02 -0700)]
Updating corefx to use new roslyn compiler (dotnet/corefx#24076)

* Updating corefx to use new roslyn compiler

* Updating to new version of the compiler and use the switch so tests pass on desktop

* Fix System.Reflection.Metadata tests

Commit migrated from https://github.com/dotnet/corefx/commit/fc4b1adb7f06687aa15f0416d83d2c27a0abf8dd

7 years agoRemove System.Drawing.Common from the netfx compat package (temporary).
Eric Mellino [Tue, 19 Sep 2017 00:00:27 +0000 (17:00 -0700)]
Remove System.Drawing.Common from the netfx compat package (temporary).

Commit migrated from https://github.com/dotnet/corefx/commit/f6b0fbd09b8a6dc312e55644a1353cea0fb2936d

7 years agoData-annotations length fix (dotnet/corefx#24101)
Shimmy [Mon, 18 Sep 2017 23:16:32 +0000 (02:16 +0300)]
Data-annotations length fix (dotnet/corefx#24101)

* Updated in MinLengthAttribute and MaxLengthAttribute to support ICollection<T>

* Added tests

* Fixed typo

* Trying to address two failing checks:
- Linux x64 Release Build
- UWP CoreCLR x64 Debug Build

* Implemented changes requested in review
- Extracted Count checking to an external helper to obey DRY
- Removed dependency of ICollection<T> and changed to simple reflection Count property lookup

* Added requested tests

* Added catch for MissingMetadataException.

* Extracted code from try-catch.

* Added comment as requested.

* Typo correction

Commit migrated from https://github.com/dotnet/corefx/commit/b4daeabcd906283d2845063bc681ca4fa69492e8

7 years agoMerge pull request dotnet/corefx#24123 from mellinoe/system.drawing-fix-osx-loading
Eric Mellino [Mon, 18 Sep 2017 22:55:56 +0000 (15:55 -0700)]
Merge pull request dotnet/corefx#24123 from mellinoe/system.drawing-fix-osx-loading

Fix libgdiplus function loading on OSX.

Commit migrated from https://github.com/dotnet/corefx/commit/bafbafde192e2cce70f11d679f2e39c614db0b89

7 years agoPrevent ServiceControllerTests from dispose when already disposed (dotnet/corefx...
Santiago Fernandez Madero [Mon, 18 Sep 2017 22:01:49 +0000 (15:01 -0700)]
Prevent ServiceControllerTests from dispose when already disposed (dotnet/corefx#24042)

* Disable ServiceProcessTest that has been failing on CI and official builds

* Prevent dispose from been called when already disposed

* Add logging to repro if RemoveService is been called twice on the same ServiceController

Commit migrated from https://github.com/dotnet/corefx/commit/c017ae3ee27605a509f4fec3560998c8754180e0

7 years agoFix libgdiplus function loading on OSX.
Eric Mellino [Mon, 18 Sep 2017 21:12:04 +0000 (14:12 -0700)]
Fix libgdiplus function loading on OSX.

Commit migrated from https://github.com/dotnet/corefx/commit/bc9a9d7ed76053c9b7a5ffad6707002ff7a815db

7 years agoMerge pull request dotnet/corefx#23840 from niustephanie/guidtests
Stephen Toub [Mon, 18 Sep 2017 18:40:28 +0000 (11:40 -0700)]
Merge pull request dotnet/corefx#23840 from niustephanie/guidtests

Expose and add tests for span-based Guid methods

Commit migrated from https://github.com/dotnet/corefx/commit/f54d710a0b3d1577d6455c4058862acfaff65152

7 years agoWrap exceptions from ManagedHandler's server validation callback (dotnet/corefx#24111)
Stephen Toub [Mon, 18 Sep 2017 18:12:48 +0000 (11:12 -0700)]
Wrap exceptions from ManagedHandler's server validation callback (dotnet/corefx#24111)

To match other handlers' behaviors.

Commit migrated from https://github.com/dotnet/corefx/commit/e0b912e37439118651ae12e5685b0ef7efd8f1fd

7 years agodotnet/corefx#24112 Replaced documentation summary of TryPop with text similar to...
koenigst [Mon, 18 Sep 2017 17:22:50 +0000 (19:22 +0200)]
dotnet/corefx#24112 Replaced documentation summary of TryPop with text similar to TryDequeue. (dotnet/corefx#24113)

Commit migrated from https://github.com/dotnet/corefx/commit/b17c1d20b1176a55fc27fbaa1b4e8f953f3dc377

7 years agoAddress remaining PR feedback
Stephen Toub [Mon, 18 Sep 2017 17:14:56 +0000 (13:14 -0400)]
Address remaining PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/43ee827db726f401ee9c76a9c3cf2ce406934349

7 years agoExpose and add tests for Guid.ctor(Span)/TryWriteBytes/TryFormat
Stephanie Niu [Wed, 6 Sep 2017 22:35:32 +0000 (15:35 -0700)]
Expose and add tests for Guid.ctor(Span)/TryWriteBytes/TryFormat

Commit migrated from https://github.com/dotnet/corefx/commit/1c7b5536bf24e1f315ab2e8dd756828ead41c6e2

7 years agoDisable NegotiateStreamTest fixture for distros without working Kerberos (dotnet...
Dan Moseley [Mon, 18 Sep 2017 14:54:57 +0000 (07:54 -0700)]
Disable NegotiateStreamTest fixture for distros without working Kerberos (dotnet/corefx#24098)

Disable NegotiateStreamTest fixture entirely because setup-kdc.sh is broken on some distros

Commit migrated from https://github.com/dotnet/corefx/commit/99bffa97b96c99d4744b4a13b5bc1cbd3eb8896a

7 years agoEnsure ProcessModule for main executable is first in modules list (dotnet/corefx...
Stephen Toub [Mon, 18 Sep 2017 13:37:21 +0000 (06:37 -0700)]
Ensure ProcessModule for main executable is first in modules list (dotnet/corefx#24106)

Commit migrated from https://github.com/dotnet/corefx/commit/382c6835d56d72a3a63aaf8cd42784dd3ddb2dc3

7 years agoWrap cert callback leaked exceptions in WinHttpHandler (dotnet/corefx#24107)
David Shulman [Mon, 18 Sep 2017 03:19:28 +0000 (23:19 -0400)]
Wrap cert callback leaked exceptions in WinHttpHandler (dotnet/corefx#24107)

Similar to the fix done for CurlHandler (dotnet/corefx#21938), fix WinHttpHandler so
that leaked exceptions from the user-provided certificate callback are
properly wrapped.

The ManagedHandler still needs to be fixed since it is not wrapping
properly.

Contributes to dotnet/corefx#21904

Commit migrated from https://github.com/dotnet/corefx/commit/ca5d83ec2855afa7ce4f60d9c5b0dd46e1cb2faf

7 years agoAdd the target to copy the serializer to publish folder. (dotnet/corefx#24096)
Huangli Wu [Sun, 17 Sep 2017 17:25:13 +0000 (10:25 -0700)]
Add the target to copy the serializer to publish folder. (dotnet/corefx#24096)

Commit migrated from https://github.com/dotnet/corefx/commit/f472d663a6e9829483543de55cf830fc13d4818b

7 years agoAdd warning by default in SGEN (dotnet/corefx#24054)
Huangli Wu [Sun, 17 Sep 2017 17:10:07 +0000 (10:10 -0700)]
Add warning by default in SGEN (dotnet/corefx#24054)

* Output warning by default if run the tool directly without /quiet parameter.

* add quiet parameter in the command.

* fix parameter error.

* Update the warning.

Commit migrated from https://github.com/dotnet/corefx/commit/b5d944782098796b404ba20356cd36e384464cbc

7 years agoConcurrentQueue 128-byte cache line (dotnet/corefx#22724)
Steve MacLean [Sun, 17 Sep 2017 16:38:49 +0000 (12:38 -0400)]
ConcurrentQueue 128-byte cache line (dotnet/corefx#22724)

ConcurrentQueue 128-byte cache line

Commit migrated from https://github.com/dotnet/corefx/commit/9c468a08151402a68732c784b0502437b808df9f

7 years agoAdd btrfs and other missing file system types (dotnet/corefx#24102)
Dan Moseley [Sun, 17 Sep 2017 14:11:02 +0000 (07:11 -0700)]
Add btrfs and other missing file system types (dotnet/corefx#24102)

* Uppercase

* Add more filesystems from stat.c. Change to stat names where possible

* Add some more local friendly names

* Add some more remote file types from stat.c

* Add entry to switch present in enum

* Build errors

* Remove Fixed entries that should be RAM

* comment

* Change case of 0X to 0x

* Move cramfs to Fixed

Commit migrated from https://github.com/dotnet/corefx/commit/f77a66355ca596276b5905575a6976e925ef046d

7 years agoFix RHEL6 linux/in.h file detection (dotnet/corefx#24100)
Jan Vorlicek [Sat, 16 Sep 2017 20:10:48 +0000 (22:10 +0200)]
Fix RHEL6 linux/in.h file detection (dotnet/corefx#24100)

On RHEL6, the build got broken by my recent fix of the in_pktinfo /
ip_mreqn detection fix. The reason is that on that platform, linux/in.h
cannot be included on its own, the sys/socket.h needs to be included
before that to provide definitions of some structures. In fact, Linux
doc states that the sys/socket.h should be included before the
linux/in.h. So I am fixing that by adding that include to the detection
code.

Commit migrated from https://github.com/dotnet/corefx/commit/d3dbd54336a1766031be18c1838c71119b54ae4b

7 years agoIncrease some networking test timeouts (dotnet/corefx#24099)
Dan Moseley [Sat, 16 Sep 2017 13:24:43 +0000 (06:24 -0700)]
Increase some networking test timeouts (dotnet/corefx#24099)

* Increase timeouts to attempt to harden against dotnet/corefx#18907

* Increase Sockets passing test timeout

Commit migrated from https://github.com/dotnet/corefx/commit/1e50513872aa684abf9701f58ab036970343019d

7 years agoRemove an assertion from PrintDocumentTests.cs. (dotnet/corefx#24097)
Eric Mellino [Sat, 16 Sep 2017 04:41:33 +0000 (21:41 -0700)]
Remove an assertion from PrintDocumentTests.cs. (dotnet/corefx#24097)

Commit migrated from https://github.com/dotnet/corefx/commit/20bcbcc5392cdadcbf23b1e114ad109ca7fa186e

7 years agoAdd Socket.Send/Receive concurrency test (dotnet/corefx#24056)
Stephen Toub [Sat, 16 Sep 2017 01:31:42 +0000 (18:31 -0700)]
Add Socket.Send/Receive concurrency test (dotnet/corefx#24056)

Help validate that on Unix we're able to invoke Send/Receive multiple times to run concurrently on the same socket instance.  We already have similar tests for Send/ReceiveAsync, so this just adds one for the synchronous Send/Receive.

Commit migrated from https://github.com/dotnet/corefx/commit/e48025a81b9a53e8e073c718c8714c4c8e3f5625

7 years agoMerge pull request dotnet/corefx#24091 from mellinoe/disable-serializer.generator...
Eric Mellino [Sat, 16 Sep 2017 01:09:35 +0000 (18:09 -0700)]
Merge pull request dotnet/corefx#24091 from mellinoe/disable-serializer.generator-tests-arm64

Disable XmlSerializer.Generator.Tests on ARM64.

Commit migrated from https://github.com/dotnet/corefx/commit/e1f54cba4a1f0554e9eae0259b443c19e72ae7fb

7 years agoMerge pull request dotnet/corefx#24088 from mellinoe/x86-nupkg
Eric Mellino [Fri, 15 Sep 2017 23:56:36 +0000 (16:56 -0700)]
Merge pull request dotnet/corefx#24088 from mellinoe/x86-nupkg

Add a NuGet package for System.Runtime.Intrinsics.X86.

Commit migrated from https://github.com/dotnet/corefx/commit/caca392f4d814104fcbe3d49853724d70dcf90b5

7 years agoInclude the fwlink in the warning. (dotnet/corefx#24082)
Huangli Wu [Fri, 15 Sep 2017 23:30:20 +0000 (16:30 -0700)]
Include the fwlink in the warning. (dotnet/corefx#24082)

* Include the fwlink in the warning.

* use instructions

Commit migrated from https://github.com/dotnet/corefx/commit/307fc13500f8f13ee90f92bffda68a65547c1a93

7 years agoDisable XmlSerializer.Generator.Tests on ARM64.
Eric Mellino [Fri, 15 Sep 2017 23:11:01 +0000 (16:11 -0700)]
Disable XmlSerializer.Generator.Tests on ARM64.

Commit migrated from https://github.com/dotnet/corefx/commit/5fed8b1b67a10333504b5f8c71b68431b0208f27

7 years agoMerge pull request dotnet/corefx#24030 from hqueue/fix/issue_24029_tc_build_break
Eric Mellino [Fri, 15 Sep 2017 23:09:51 +0000 (16:09 -0700)]
Merge pull request dotnet/corefx#24030 from hqueue/fix/issue_24029_tc_build_break

Disable building Microsoft.XmlSerializer.Generator.Tests for ARM

Commit migrated from https://github.com/dotnet/corefx/commit/37d8b88be5ce98a86aa5b17998f747cc9e2a06cf

7 years agoFixing build failure on CI happening on Centos (dotnet/corefx#24078)
Maryam Ariyan [Fri, 15 Sep 2017 23:04:04 +0000 (19:04 -0400)]
Fixing build failure on CI happening on Centos (dotnet/corefx#24078)

* Fixing build failure on CI

fixes dotnet/corefx#24066

* applying code review comments

* changing IEnumerable to string[]

* applying code review comments

Commit migrated from https://github.com/dotnet/corefx/commit/2ba1f89c1a4a45bc5d7e2079175fd600f51f50ef

7 years agoAuto-generate the itemgroup. (dotnet/corefx#24079)
Huangli Wu [Fri, 15 Sep 2017 22:34:45 +0000 (15:34 -0700)]
Auto-generate the itemgroup. (dotnet/corefx#24079)

Commit migrated from https://github.com/dotnet/corefx/commit/34873d5ec4187a69eaad2d2a06b40737037ebad3

7 years agoAdd a NuGet package for System.Runtime.Intrinsics.X86.
Eric Mellino [Fri, 15 Sep 2017 21:44:29 +0000 (14:44 -0700)]
Add a NuGet package for System.Runtime.Intrinsics.X86.

Commit migrated from https://github.com/dotnet/corefx/commit/bc741c6a255d51de531b8323d723ec95ea8711bf

7 years agoAdd copyright header from Mono to HttpUtility.cs (dotnet/corefx#24080)
Karel Zikmund [Fri, 15 Sep 2017 21:32:52 +0000 (14:32 -0700)]
Add copyright header from Mono to HttpUtility.cs (dotnet/corefx#24080)

Fixes dotnet/corefx#24043

Copied from Mono: https://github.com/mono/mono/blob/dotnet/corefx@0af1ea70c29a66a59765183b45d6b75fa6c3d8fa/mcs/class/System.Web/System.Web/HttpUtility.cs#L3-L30

Commit migrated from https://github.com/dotnet/corefx/commit/291cf9224cba8b75ba66b21cc435920f7b1027f4

7 years agoAdd help method for SGEN. (dotnet/corefx#23966)
Huangli Wu [Fri, 15 Sep 2017 21:31:23 +0000 (14:31 -0700)]
Add help method for SGEN. (dotnet/corefx#23966)

* Add help method.

* Remove unused help information.

* Update the header.

Commit migrated from https://github.com/dotnet/corefx/commit/aa2dd571dc738373fc2e32f3098e4d0b1da4639c

7 years agoRemove ContinueAsError in sgen test (dotnet/corefx#24015)
Huangli Wu [Fri, 15 Sep 2017 20:56:00 +0000 (13:56 -0700)]
Remove ContinueAsError in sgen test (dotnet/corefx#24015)

* Remove ContinueAsError

* Remove casesensitive

Commit migrated from https://github.com/dotnet/corefx/commit/29d0c87fce1480c8f1cf7ad66463590ef494015e

7 years agoGenerate Microsoft.XmlSerializer.Generator.props. (dotnet/corefx#24084)
Shin Mao [Fri, 15 Sep 2017 20:49:05 +0000 (13:49 -0700)]
Generate Microsoft.XmlSerializer.Generator.props. (dotnet/corefx#24084)

Generate the props file on the fly so that the file can use the correct
reference version.
a

Commit migrated from https://github.com/dotnet/corefx/commit/17f71e0707d22f6ce936eb01ac0dad37e1be6c79

7 years agoUpdate list of System.Net.* SMEs (dotnet/corefx#24077)
Steven White [Fri, 15 Sep 2017 18:49:29 +0000 (11:49 -0700)]
Update list of System.Net.* SMEs (dotnet/corefx#24077)

Commit migrated from https://github.com/dotnet/corefx/commit/a48e2d02d8d116a5d6c81ff46ca7cd158238c68d

7 years agoUpdate CoreClr to preview1-25715-02 (dotnet/corefx#24071)
dotnet-maestro-bot [Fri, 15 Sep 2017 16:51:17 +0000 (09:51 -0700)]
Update CoreClr to preview1-25715-02 (dotnet/corefx#24071)

Commit migrated from https://github.com/dotnet/corefx/commit/f2f561315df5d58121f6d13cf6d81d75c9a3a343

7 years agoDo not use zero width spaces (dotnet/corefx#24069)
Andrius Bentkus [Fri, 15 Sep 2017 14:14:33 +0000 (17:14 +0300)]
Do not use zero width spaces (dotnet/corefx#24069)

Fixes dotnet/corefx#24068

Commit migrated from https://github.com/dotnet/corefx/commit/13db0aefa78577e9c9fd5574103178383c16508e

7 years agoIgnore unhandled exceptions from ManagedWebSocket keep-alive pings (dotnet/corefx...
Stephen Toub [Fri, 15 Sep 2017 11:16:55 +0000 (04:16 -0700)]
Ignore unhandled exceptions from ManagedWebSocket keep-alive pings (dotnet/corefx#24055)

ManagedWebSocket has configurable timer-based keep-alive pings it sends to the remote server.  If such calls fail, such as due to the connection getting closed, we just swallow the exception.  But the way the exception is currently being swallowed results in a faulted task whose exception is never observed, resulting in the unobserved exception event being raised.  Since our intention is to eat these errors and completely ignore them, we don't want the event raised.  This commit just observes any such exceptions.

Commit migrated from https://github.com/dotnet/corefx/commit/edecb1207cbe6194cb9a9f1bc862ef8d1ebb3ef4

7 years agoUpdate CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25715-01,...
dotnet-maestro-bot [Fri, 15 Sep 2017 06:31:19 +0000 (23:31 -0700)]
Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-25715-01, preview1-25714-02, beta-25715-00, beta-25715-00, respectively (dotnet/corefx#24058)

Commit migrated from https://github.com/dotnet/corefx/commit/3c54f59eb397ccf46259e502108c41220a90dea1

7 years agoRefactoring code. No changes made to logic. (dotnet/corefx#24060)
Maryam Ariyan [Fri, 15 Sep 2017 02:53:35 +0000 (22:53 -0400)]
Refactoring code. No changes made to logic. (dotnet/corefx#24060)

* Refactoring code. No changes made to logic.

Applying code review comments requested from pr24017

* removing unnecessary else statement

Commit migrated from https://github.com/dotnet/corefx/commit/4854f643d8cc7448faa59511fe1c88a8da2ea49b

7 years agoFixing assertion failure happening on some of the unix machines (dotnet/corefx#24017)
Maryam Ariyan [Fri, 15 Sep 2017 00:42:34 +0000 (20:42 -0400)]
Fixing assertion failure happening on some of the unix machines (dotnet/corefx#24017)

* Refactoring Process.Start to simplify logic

This also fixes the following existing issues:
- allows user to successfully open folder (23969) with UseShellExecute
- throws when opening a missing file with UseShellExecute

this makes these behaviours consistent across win/unix machines

Updated existing tests to comply with these new fixes

* Simplifying condition checks in Process.Start

* Applying code review comments

Commit migrated from https://github.com/dotnet/corefx/commit/a16368dc4694c0334a8794107a9e868020f0bed5

7 years agoMerge pull request dotnet/corefx#24045 from Priya91/credentialmh
Lakshmi Priya Sekar [Fri, 15 Sep 2017 00:22:43 +0000 (17:22 -0700)]
Merge pull request dotnet/corefx#24045 from Priya91/credentialmh

Fix Dns tests on OSX.

Commit migrated from https://github.com/dotnet/corefx/commit/751ad52f47a045cbab872177e621af58b180cad8

7 years agoFix globalization tests to work with setting customization (dotnet/corefx#24052)
Tarek Mahmoud Sayed [Fri, 15 Sep 2017 00:05:34 +0000 (17:05 -0700)]
Fix globalization tests to work with setting customization (dotnet/corefx#24052)

We used new CultureInfo in many places to check the NumberFormatInfo properties values . these tests can fail if the user customized the  user settings on the running machine. The fix here is to use GetCultureInfo which always ignore the change in the settings and return the original values we need to test against.

Commit migrated from https://github.com/dotnet/corefx/commit/708c20ad05f2474ed8b144ec6c3345d809c7843b

7 years agoEnable disabled date parsing test on Linux (dotnet/corefx#24051)
Tarek Mahmoud Sayed [Fri, 15 Sep 2017 00:01:19 +0000 (17:01 -0700)]
Enable disabled date parsing test on Linux (dotnet/corefx#24051)

Commit migrated from https://github.com/dotnet/corefx/commit/b77c715ce2a7b27c61b56d9cf510a967ac3355f3

7 years agoGenerate ThisAssembly.cs to get Package Version. (dotnet/corefx#24050)
Shin Mao [Thu, 14 Sep 2017 23:47:52 +0000 (16:47 -0700)]
Generate ThisAssembly.cs to get Package Version. (dotnet/corefx#24050)

Commit migrated from https://github.com/dotnet/corefx/commit/74d55bb454f4b00b09235fa4466fd60b00b750bd

7 years agoFix TimeSpan tests for cultures using ',' in place of '.' (dotnet/corefx#24047)
Pent Ploompuu [Thu, 14 Sep 2017 23:31:05 +0000 (02:31 +0300)]
Fix TimeSpan tests for cultures using ',' in place of '.' (dotnet/corefx#24047)

Commit migrated from https://github.com/dotnet/corefx/commit/da2d8d073371a2ceee52b47bf8bd03c2ba97f858

7 years agoICollection<T> support in MinLengthAttribute and MaxLengthAttribute (dotnet/corefx...
Shimmy [Thu, 14 Sep 2017 22:45:43 +0000 (01:45 +0300)]
ICollection<T> support in MinLengthAttribute and MaxLengthAttribute (dotnet/corefx#23664)

* Updated in MinLengthAttribute and MaxLengthAttribute to support ICollection<T>

* Added tests

* Fixed typo

* Trying to address two failing checks:
- Linux x64 Release Build
- UWP CoreCLR x64 Debug Build

* Implemented changes requested in review
- Extracted Count checking to an external helper to obey DRY
- Removed dependency of ICollection<T> and changed to simple reflection Count property lookup

* Added requested tests

Commit migrated from https://github.com/dotnet/corefx/commit/f711317e1955770a462f6e15e6f86c0061d9796e

7 years agoMerge pull request dotnet/corefx#24023 from mellinoe/fix-compat-pack
Eric Mellino [Thu, 14 Sep 2017 21:27:10 +0000 (14:27 -0700)]
Merge pull request dotnet/corefx#24023 from mellinoe/fix-compat-pack

Change the netfx compat pack to only ship stable packages, plus System.Drawing

Commit migrated from https://github.com/dotnet/corefx/commit/5fe1d6902e4de8b852fb835040158c76f2b33957

7 years agoAdd comment about change.
Lakshmi Priya Sekar [Thu, 14 Sep 2017 20:09:59 +0000 (13:09 -0700)]
Add comment about change.

Commit migrated from https://github.com/dotnet/corefx/commit/43d57385ba00001db19b97e1f9840c15c84a5249

7 years agoFix the output message in SGEN. (dotnet/corefx#23949)
Huangli Wu [Thu, 14 Sep 2017 20:15:47 +0000 (13:15 -0700)]
Fix the output message in SGEN. (dotnet/corefx#23949)

* Fix the output message in SGEN.

* Use 'code' in message instead of file.

Commit migrated from https://github.com/dotnet/corefx/commit/9d1b728707902fe018c39761302865b2848adb8c

7 years agoEnable end to end Alpine corefx build (dotnet/corefx#24035)
Jan Vorlicek [Thu, 14 Sep 2017 19:59:35 +0000 (21:59 +0200)]
Enable end to end Alpine corefx build (dotnet/corefx#24035)

This change enables full end to end build of corefx including
managed code on Alpine Linux.

Commit migrated from https://github.com/dotnet/corefx/commit/0688e035d58ec2395049c4035c619529e884cf37