mtklein [Fri, 11 Dec 2015 20:04:47 +0000 (12:04 -0800)]
archive skpx... currently dead code
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1521623003
benjaminwagner [Fri, 11 Dec 2015 19:26:44 +0000 (11:26 -0800)]
Change google3 sync scripts to sync latest rather than LKGR.
This matches the behavior of the autoroller and is generally more useful.
BUG=skia:
Review URL: https://codereview.chromium.org/
1508313004
joshualitt [Fri, 11 Dec 2015 19:05:43 +0000 (11:05 -0800)]
A change to cleanup some organization around df text
BUG=skia:
Review URL: https://codereview.chromium.org/
1519083002
fmalita [Fri, 11 Dec 2015 19:03:27 +0000 (11:03 -0800)]
New GM: image_scale_aligned
To verify alignment for various image scaling modes.
BUG=skia:4649
R=reed@google.com
Review URL: https://codereview.chromium.org/
1514923002
msarett [Fri, 11 Dec 2015 18:37:39 +0000 (10:37 -0800)]
Change computeOutputColorType() to mimic old behavior
This will prevent behavior changes in BitmapFactory when
switching from SkImageDecoder to SkAndroidCodec.
We will only choose kGray8 if it is explicitly requested (and
also supported).
Additionally, we will always decode GIFS and WBMPS to
kIndex8.
BUG=skia:
Review URL: https://codereview.chromium.org/
1519843002
scroggo [Fri, 11 Dec 2015 18:29:02 +0000 (10:29 -0800)]
Add test for previously unflattenables
BUG=skia:4613
Review URL: https://codereview.chromium.org/
1514373003
scroggo [Fri, 11 Dec 2015 17:49:57 +0000 (09:49 -0800)]
Fix a crash in SkParsePath::FromSVGString
BUG=skia:3491
Review URL: https://codereview.chromium.org/
1515193002
joshualitt [Fri, 11 Dec 2015 16:31:17 +0000 (08:31 -0800)]
remove explicit 'f' in glbench shader
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1503383006
benjaminwagner [Fri, 11 Dec 2015 15:54:24 +0000 (07:54 -0800)]
In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS.
Somehow https://codereview.chromium.org/
1491843006 causes fills to change in one test.
BUG=skia:
Review URL: https://codereview.chromium.org/
1516863007
msarett [Fri, 11 Dec 2015 15:38:50 +0000 (07:38 -0800)]
Make BitmapRegionDecoder succeed on invalid requests
If the client requests a color type or alpha type that is
not supported, we should decode to the default/appropriate
color and alpha types to match existing behavior in Android.
BUG=skia:
Review URL: https://codereview.chromium.org/
1513023002
joshualitt [Fri, 11 Dec 2015 14:11:21 +0000 (06:11 -0800)]
Move all text stuff to its own folder
BUG=skia:
Review URL: https://codereview.chromium.org/
1521453002
joshualitt [Fri, 11 Dec 2015 14:08:59 +0000 (06:08 -0800)]
make internaldrawBmpText part of GrTextUtils
BUG=skia:
Review URL: https://codereview.chromium.org/
1518883002
robertphillips [Fri, 11 Dec 2015 12:59:36 +0000 (04:59 -0800)]
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1513573009
kkinnunen [Fri, 11 Dec 2015 08:05:33 +0000 (00:05 -0800)]
Initialize glGen* call id args to zero
Initialize glGenTexture, glGenBuffer call id buffer items to zero before
calls. Otherwise it's not easy to check if the call succeeded or not.
Assert the rule in debug gl context.
Make TesselatingPathRendererTests use debug gl context. It exercises
some of the GenBuffers call sites.
Review URL: https://codereview.chromium.org/
1514033002
kkinnunen [Fri, 11 Dec 2015 07:19:29 +0000 (23:19 -0800)]
Run debug gl context for DEF_GPU_TEST_FOR_ALL_CONTEXTS
Run debug gl context for tests defined with
DEF_GPU_TEST_FOR_ALL_CONTEXTS.
Review URL: https://codereview.chromium.org/
1514023002
msarett [Thu, 10 Dec 2015 23:14:27 +0000 (15:14 -0800)]
Revert of DM: fix `--config $VIA-pdf` to not crash (patchset #3 id:40001 of https://codereview.chromium.org/
1513323002/ )
Reason for revert:
I believe that this is breaking master-skia in Android.
Original issue's description:
> DM: fix `--config $VIA-pdf` to not crash
>
> Committed: https://skia.googlesource.com/skia/+/
6bce4177cb72faac9c10d01d57e17168ae7ecadf
TBR=mtklein@google.com,halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1513053004
msarett [Thu, 10 Dec 2015 22:45:03 +0000 (14:45 -0800)]
Remove flag needed by outdated libpng
BUG=skia:
Review URL: https://codereview.chromium.org/
1514873003
mtklein [Thu, 10 Dec 2015 22:34:23 +0000 (14:34 -0800)]
yet another memcpy -> sk_careful_memcpy
will fix
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3834
No API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1514923003
cdalton [Thu, 10 Dec 2015 22:20:06 +0000 (14:20 -0800)]
Add a warmup flag to visualbench
Adds a flag to control whether we use a warmup bench.
BUG=skia:
Review URL: https://codereview.chromium.org/
1468233003
herb [Thu, 10 Dec 2015 22:17:41 +0000 (14:17 -0800)]
Fix UB function problems for AA merger.
BUG=skia:4634
Review URL: https://codereview.chromium.org/
1518863002
aam [Thu, 10 Dec 2015 22:14:56 +0000 (14:14 -0800)]
Fix 'debugging on Android' android_gdb_app script.
1) com.skia -> com.skia.sample_app
2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example:
./platform_tools/android/bin/android_gdb_app -d nexus_6
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=
1509853006
Review URL: https://codereview.chromium.org/
1509853006
herb [Thu, 10 Dec 2015 22:12:33 +0000 (14:12 -0800)]
Change SkTaskGroup to use std::function. Ripple all the changes.
BUG=skia:4634
Review URL: https://codereview.chromium.org/
1519573003
scroggo [Thu, 10 Dec 2015 21:46:04 +0000 (13:46 -0800)]
Use size_t for strlen() return value
BUG=skia:2810
Review URL: https://codereview.chromium.org/
1518843002
reed [Thu, 10 Dec 2015 21:44:45 +0000 (13:44 -0800)]
try adding flag to allow lcd text even in a layer
BUG=skia:
Review URL: https://codereview.chromium.org/
1513513002
scroggo [Thu, 10 Dec 2015 21:31:59 +0000 (13:31 -0800)]
Use DEF_GM everywhere
BUG=skia:1902
Review URL: https://codereview.chromium.org/
1518893002
robertphillips [Thu, 10 Dec 2015 21:29:14 +0000 (13:29 -0800)]
Address precision issue in circle blur effect
BUG=560651
Review URL: https://codereview.chromium.org/
1504333003
joshualitt [Thu, 10 Dec 2015 21:20:58 +0000 (13:20 -0800)]
Create GrTextUtils
BUG=skia:
Review URL: https://codereview.chromium.org/
1514933002
msarett [Thu, 10 Dec 2015 21:09:24 +0000 (13:09 -0800)]
Add reallyHasAlpha() to SkAndroidCodec
This also modified the default implementation
of onReallyHasAlpha() in SkCodec.
BUG=skia:
Review URL: https://codereview.chromium.org/
1518743002
halcanary [Thu, 10 Dec 2015 20:46:42 +0000 (12:46 -0800)]
DM: fix `--config $VIA-pdf` to not crash
Review URL: https://codereview.chromium.org/
1513323002
halcanary [Thu, 10 Dec 2015 20:40:23 +0000 (12:40 -0800)]
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Committed: https://skia.googlesource.com/skia/+/
b0bd1516bff3f5afcbfd615e805867531657811b
Committed: https://skia.googlesource.com/skia/+/
808ce2886d732b1055f89c8fb0f1b11b47fcb0ce
Review URL: https://codereview.chromium.org/
1507123002
borenet [Thu, 10 Dec 2015 20:09:14 +0000 (12:09 -0800)]
Add buildbot spec for Android One bots
BUG=skia:
Review URL: https://codereview.chromium.org/
1517733002
xidachen [Thu, 10 Dec 2015 20:08:44 +0000 (12:08 -0800)]
SkBlurImageFilter returns input when sigma = 0
In the current implementation, a blur filter is always created even in the
case when sigma.fX == 0 && sigma.fY == 0. This CL makes the blur filter
return input in this case.
BUG=568393
Review URL: https://codereview.chromium.org/
1518643002
scroggo [Thu, 10 Dec 2015 19:28:01 +0000 (11:28 -0800)]
Remove unused CallStacker
Found this while looking for uses of strlen (skbug.com/2810). This code
was written by a former member of the team and is not used.
BUG=skia:2810
Review URL: https://codereview.chromium.org/
1512753006
joshualitt [Thu, 10 Dec 2015 19:22:08 +0000 (11:22 -0800)]
Move flush logic into GrAtlasTextBlob
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1518763002
scroggo [Thu, 10 Dec 2015 18:44:13 +0000 (10:44 -0800)]
Switch SkAutoMalloc to SkAutoTMalloc to avoid cast
Make SkAutoTMalloc's interface look more like SkAutoMalloc:
- add free(), which does what you expect
- make reset() return a pointer fPtr
No public API changes (SkAutoTMalloc is in include/private)
BUG=skia:2148
Review URL: https://codereview.chromium.org/
1516833003
halcanary [Thu, 10 Dec 2015 17:30:57 +0000 (09:30 -0800)]
SkPixelSerializer: remove deprecated virtual
Review URL: https://codereview.chromium.org/
1512333002
joshualitt [Thu, 10 Dec 2015 17:10:10 +0000 (09:10 -0800)]
Move DistanceAdjustTable to its own file
BUG=skia:
Review URL: https://codereview.chromium.org/
1512823004
jvanverth [Thu, 10 Dec 2015 17:06:24 +0000 (09:06 -0800)]
Add Apple renderer strings to PowerVR detection
BUG=skia:4148
Review URL: https://codereview.chromium.org/
1512903005
halcanary [Thu, 10 Dec 2015 16:59:43 +0000 (08:59 -0800)]
SkDocument::setDCTEncoder() for old versions of webkit
Review URL: https://codereview.chromium.org/
1505763003
joshualitt [Thu, 10 Dec 2015 16:54:41 +0000 (08:54 -0800)]
Move appending of large glyphs into GrAtlasTextBlob
BUG=skia:
Review URL: https://codereview.chromium.org/
1517563002
scroggo [Thu, 10 Dec 2015 16:54:36 +0000 (08:54 -0800)]
Silence another PNG print statement
It can still be turned on by using setting
c_suppressPNGImageDecoderWarnings to true.
Review URL: https://codereview.chromium.org/
1512293003
caryclark [Thu, 10 Dec 2015 16:03:58 +0000 (08:03 -0800)]
try again on md formatting
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1520533002
Review URL: https://codereview.chromium.org/
1520533002
halcanary [Thu, 10 Dec 2015 15:52:45 +0000 (07:52 -0800)]
experiment/fiddle
Review URL: https://codereview.chromium.org/
1349163003
joshualitt [Thu, 10 Dec 2015 15:44:50 +0000 (07:44 -0800)]
Move 'mustRegenerate' function into GrAtlasTextBlob
BUG=skia:
Review URL: https://codereview.chromium.org/
1515543003
mtklein [Thu, 10 Dec 2015 15:42:47 +0000 (07:42 -0800)]
another null src, memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3798/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/
1510903005
joshualitt [Thu, 10 Dec 2015 15:29:54 +0000 (07:29 -0800)]
Remove uniform color for GrDistanceFieldGeoProc
BUG=skia:
Review URL: https://codereview.chromium.org/
1512533003
caryclark [Thu, 10 Dec 2015 14:29:44 +0000 (06:29 -0800)]
add path ops presentations to skia.org
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1518453003
Review URL: https://codereview.chromium.org/
1518453003
kkinnunen [Thu, 10 Dec 2015 14:28:13 +0000 (06:28 -0800)]
Make NVPR a GL context option instead of a GL context
Make NVPR a GL context option instead of a GL context.
This may enable NVPR to be run with command buffer
interface.
No functionality change in DM or nanobench. NVPR can
only be run with normal GL APIs.
BUG=skia:2992
Committed: https://skia.googlesource.com/skia/+/
eeebdb538d476c1bfc8b63a946094ca1b505ecd1
Committed: https://skia.googlesource.com/skia/+/
64492c43c3faee7ab0f69b1c84e0267616f85e52
Review URL: https://codereview.chromium.org/
1448883002
kkinnunen [Thu, 10 Dec 2015 09:21:59 +0000 (01:21 -0800)]
Use a pseudo-extension CHROMIUM_framebuffer_mixed_samples
Use the pseudo-extension CHROMIUM_framebuffer_mixed_samples when
run with Chromium command buffer. The extension exposes
NV_framebuffer_mixed_samples subset that Skia needs in order to
use NV_path_rendering with mixed samples.
BUG=506765
Review URL: https://codereview.chromium.org/
1507373004
kkinnunen [Thu, 10 Dec 2015 06:58:34 +0000 (22:58 -0800)]
Populate NVPR functions when run with command buffer
Populate the NV_path_rendering functions provided by
CHROMIUM_path_rendering when the tools are being run with
command buffer API.
BUG=skia:2992
Review URL: https://codereview.chromium.org/
1510163003
bsalomon [Thu, 10 Dec 2015 01:14:40 +0000 (17:14 -0800)]
Do elliptical clips in normalized space on devices with a "real" mediump
BUG=chromium:477684
Review URL: https://codereview.chromium.org/
1517573002
bsalomon [Thu, 10 Dec 2015 01:06:02 +0000 (17:06 -0800)]
Make "alpha only" be a property of GrTextureProducer
Review URL: https://codereview.chromium.org/
1507973005
jvanverth [Thu, 10 Dec 2015 00:54:35 +0000 (16:54 -0800)]
Use BRGA as internal format on later iOS
BUG=skia:2733
Review URL: https://codereview.chromium.org/
1504333007
mtklein [Thu, 10 Dec 2015 00:20:25 +0000 (16:20 -0800)]
another memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3791/steps/dm/logs/stdio
This is getting tedious.
TBR=herb@google.com,reed@google.com
No API changes.
BUG=skia:
Review URL: https://codereview.chromium.org/
1510223003
caryclark [Wed, 9 Dec 2015 22:04:46 +0000 (14:04 -0800)]
add support for capped hairlines
Extend the ends of hairline and haircurve segments when the paint is set to square or round, and the line or curve is at the start or end of a contour.
R=reed@google.com
BUG=skia:4599
Review URL: https://codereview.chromium.org/
1491843006
scroggo [Wed, 9 Dec 2015 21:40:34 +0000 (13:40 -0800)]
Silence libjpeg warnings in SkImageDecoder
We just did the same for libpng (see crrev.com/
1512043002), so we
might as well do this here.
SkImageDecoder is deprecated, and SkCodec already has a way to turn
off its messages.
BUG=skia:1649
Review URL: https://codereview.chromium.org/
1505953007
mtklein [Wed, 9 Dec 2015 21:32:58 +0000 (13:32 -0800)]
Another undefined shift caught by -fsanitize=shift.
left was -16
I didn't see any warning about fTop, but seems simplest to fix that too.
BUG=skia:
Review URL: https://codereview.chromium.org/
1505993007
mtklein [Wed, 9 Dec 2015 21:15:07 +0000 (13:15 -0800)]
Another memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3787/steps/dm/logs/stdio
dst is null.
TBR=herb@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1507113007
mtklein [Wed, 9 Dec 2015 21:02:26 +0000 (13:02 -0800)]
no need for newlines in DM Errors
This should fix some odd formatting problems in the logs, e.g.
Note tally:
583x (skipped: Cannot convert to requested color type.
)
4x (--blacklist _ image decode 4bpp-pixeldata-cropped.bmp)
~~~>
Note tally:
583x (skipped: Cannot convert to requested color type.)
4x (--blacklist _ image decode 4bpp-pixeldata-cropped.bmp)
BUG=skia:
Review URL: https://codereview.chromium.org/
1508223006
benjaminwagner [Wed, 9 Dec 2015 20:51:20 +0000 (12:51 -0800)]
Fix compile error with GOOGLE3 define.
BUG=skia:
Review URL: https://codereview.chromium.org/
1509023004
bsalomon [Wed, 9 Dec 2015 20:50:56 +0000 (12:50 -0800)]
Rewrite drawBitmap/ImageNine on top of GrTextureProducer
Review URL: https://codereview.chromium.org/
1504723004
mtklein [Wed, 9 Dec 2015 20:39:01 +0000 (12:39 -0800)]
Make skia_sanitizer work on Macs too.
This is of course limited by what the compiler suppports.
-fsanitize=address seems to work OK.
BUG=skia:
Review URL: https://codereview.chromium.org/
1512853005
scroggo [Wed, 9 Dec 2015 20:33:21 +0000 (12:33 -0800)]
Remove no-op code in SkAlphaRuns::add
The old code says
runs += x + 1;
alpha += x + 1;
x = 0;
lastAlpha += x; // we don't want the +1
The last line does nothing. Remove this unnecessary line.
BUG=skia:401
Review URL: https://codereview.chromium.org/
1506253002
herb [Wed, 9 Dec 2015 20:27:31 +0000 (12:27 -0800)]
Fix problem with flag unknown to clang. This negates an earlier -Werror causing warnings to be errors.
BUG=skia:
Review URL: https://codereview.chromium.org/
1515653002
msarett [Wed, 9 Dec 2015 20:12:56 +0000 (12:12 -0800)]
Silence libpng warnings in SkImageDecoder
BUG=skia:
Review URL: https://codereview.chromium.org/
1512043002
caryclark [Wed, 9 Dec 2015 20:02:30 +0000 (12:02 -0800)]
ubsan shift fixes
Use an inline function that does a normal shift. When built for the sanitizer, add casts so that the shift is unsigned.
Also make a few fixes to do unsigned shifts or avoid the shift altogether; and add an argument spec to some macros.
R=reed@google.com,mtklein@google.com
BUG=skia:4633
Review URL: https://codereview.chromium.org/
1503423003
halcanary [Wed, 9 Dec 2015 19:36:59 +0000 (11:36 -0800)]
SkBitmap::installPixels(const SkPixmap&);
Review URL: https://codereview.chromium.org/
1505333002
bsalomon [Wed, 9 Dec 2015 18:33:51 +0000 (10:33 -0800)]
Prevent overflow in length() in GLCircularRRectEffect
BUG=chromium:477684
Review URL: https://codereview.chromium.org/
1517483002
halcanary [Wed, 9 Dec 2015 18:21:59 +0000 (10:21 -0800)]
SkBitmap::getColor repsects swizzle
Review URL: https://codereview.chromium.org/
1510253002
bsalomon [Wed, 9 Dec 2015 18:17:35 +0000 (10:17 -0800)]
Split big rrect aa effect up into separate images
Needed to enlarge radii to surface bugs without exceeding max texture size on low end devices.
BUG=chromium:477684
Review URL: https://codereview.chromium.org/
1508003008
senorblanco [Wed, 9 Dec 2015 18:11:43 +0000 (10:11 -0800)]
Fix filter primitive bounds computations.
Make each filter responsible for expanding its destination
bounds. Previously, we were using a union of all
intermediate bounds sizes via join() calls in many image
filters' computeFastBounds(), due to the fact that those
filters could only produce bitmaps the same size as their
inputs. Now, we compute optimal bounds for each filter as
follows:
1) Pass the (unmodified) clip bounds to the root node
of the DAG in the first recursive call to onFilterImage()
as the Context's fClipBounds.
2) Reverse-map the clip: when recursing up the DAG in
filterInput[GPU](), apply filter-specific expansion to the
clip by calling calling onFilterNodeBounds(... kReverse).
This allows upstream nodes to have a clip that respects the
current node's requirements. This is done via helper
function mapContext().
3) Forward-map the source bitmap: just prior to applying
the crop rect in applyCropRect(), we determine the filter's
preferred bounds by mapping the source bitmap bounds
forwards via onFilterNodeBounds(..., kForward).
NOTE: GMs affected by this change:
fast_slow_blurimagefilter: fast and slow paths now produce the same result
spritebitmap: drawSprite() and drawBitmap() paths now produce the same result
filterfastbounds: fast bounds are optimized; all drop-shadow results now appear
apply-filter: snug and not-snug cases give same results
dropshadowimagefilter: drawSprite() results now show shadows
draw-with-filter: no artifacts on erode edges; blur edges no longer clipped
displacement, imagefiltersbase, imagefiltersclipped, imagefilterscropexpand, imagefiltersscaled, matriximagefilter,
resizeimagefilter, localmatriximagefilter, testimagefilters: fixed incorrect clipping
imagefilterstransformed, morphology: no artifacts on erode edges
BUG=skia:1062,skia:3194,skia:3939,skia:4337,skia:4526
Review URL: https://codereview.chromium.org/
1308703007
mtklein [Wed, 9 Dec 2015 18:02:14 +0000 (10:02 -0800)]
fix a couple flaky nonnull attribute ubsan warnings
Errors this should fix:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3779/steps/dm/logs/stdio
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3779/steps/nanobench/logs/stdio
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot
TBR=reed@google.com
No API changes.
BUG=skia:
Review URL: https://codereview.chromium.org/
1504313005
joshualitt [Wed, 9 Dec 2015 17:26:44 +0000 (09:26 -0800)]
Fix bug with GrAtlasTextContext color regen
BUG=skia:
Review URL: https://codereview.chromium.org/
1513723002
mtklein [Wed, 9 Dec 2015 16:37:35 +0000 (08:37 -0800)]
DM: tally notes at the end rather than showing them as they finish.
This should make the (veto) and (skipped: ) both less verbose and easier to grok.
Looks like this'll bring the log files down from ~50M to ~1.5M.
BUG=skia:
Review URL: https://codereview.chromium.org/
1516563002
robertphillips [Wed, 9 Dec 2015 15:54:24 +0000 (07:54 -0800)]
Boost GrGLConicEffect's variables to all high precision
BUG=555779
Committed: https://skia.googlesource.com/skia/+/
624c59a1c7af38eb83e803f345a6f3e225475a08
Review URL: https://codereview.chromium.org/
1513483002
mtklein [Wed, 9 Dec 2015 15:24:10 +0000 (07:24 -0800)]
try stifling integer overflow error
first time we've done this, let's see if it works!
BUG=skia:4667
Looks ok now. Red ASAN bot is different errors.
Review URL: https://codereview.chromium.org/
1507063007
fmalita [Wed, 9 Dec 2015 15:18:16 +0000 (07:18 -0800)]
Cap filtering to kMedium_SkFilterQuality when downsampling
R=reed@google.com
Review URL: https://codereview.chromium.org/
1510673002
robertphillips [Wed, 9 Dec 2015 15:09:21 +0000 (07:09 -0800)]
Revert of Boost GrGLConicEffect's variables to all high precision (patchset #1 id:1 of https://codereview.chromium.org/
1513483002/ )
Reason for revert:
Broke build
Original issue's description:
> Boost GrGLConicEffect's variables to all high precision
>
> BUG=555779
>
> Committed: https://skia.googlesource.com/skia/+/
624c59a1c7af38eb83e803f345a6f3e225475a08
TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=555779
Review URL: https://codereview.chromium.org/
1514553002
borenet [Wed, 9 Dec 2015 15:03:51 +0000 (07:03 -0800)]
Revert of Make NVPR a GL context option instead of a GL context (patchset #9 id:160001 of https://codereview.chromium.org/
1448883002/ )
Reason for revert:
"Could not create surface" on Linux GTX660 bots
Original issue's description:
> Make NVPR a GL context option instead of a GL context
>
> Make NVPR a GL context option instead of a GL context.
> This may enable NVPR to be run with command buffer
> interface.
>
> No functionality change in DM or nanobench. NVPR can
> only be run with normal GL APIs.
>
> BUG=skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/
eeebdb538d476c1bfc8b63a946094ca1b505ecd1
>
> Committed: https://skia.googlesource.com/skia/+/
64492c43c3faee7ab0f69b1c84e0267616f85e52
TBR=mtklein@google.com,bsalomon@google.com,jvanverth@google.com,scroggo@google.com,kkinnunen@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:2992
Review URL: https://codereview.chromium.org/
1513703002
joshualitt [Wed, 9 Dec 2015 14:42:52 +0000 (06:42 -0800)]
A small text cleanup
BUG=skia:
Review URL: https://codereview.chromium.org/
1508853005
robertphillips [Wed, 9 Dec 2015 14:28:06 +0000 (06:28 -0800)]
Boost GrGLConicEffect's variables to all high precision
BUG=555779
Review URL: https://codereview.chromium.org/
1513483002
bsalomon [Wed, 9 Dec 2015 14:27:59 +0000 (06:27 -0800)]
Attempt to land cache purge again [and regen bot logs if still failing]
TBR=
Review URL: https://codereview.chromium.org/
1510103002
halcanary [Wed, 9 Dec 2015 11:56:02 +0000 (03:56 -0800)]
Revert of default SkPixelSerializer (patchset #2 id:20001 of https://codereview.chromium.org/
1507123002/ )
Reason for revert:
I was overconfident.
Original issue's description:
> default SkPixelSerializer
>
> Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
>
> Add SkImageEncoder::CreatePixelSerializer() to return a
> PixelSerializer that calls into SkImageEncoder::EncodeData.
>
> SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
>
> Committed: https://skia.googlesource.com/skia/+/
b0bd1516bff3f5afcbfd615e805867531657811b
>
> Committed: https://skia.googlesource.com/skia/+/
808ce2886d732b1055f89c8fb0f1b11b47fcb0ce
TBR=reed@google.com,scroggo@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1511183002
kkinnunen [Wed, 9 Dec 2015 07:52:40 +0000 (23:52 -0800)]
Use correct config variable in command buffer gl context
Use correct config variable in command buffer gl context.
Before, the fConfig was errorneously used to initialize the
local variable. eglChooseConfig would update the local variable
and the fConfig member variable would never be updated.
Also add error checks to all initialization function calls.
BUG=skia:
Review URL: https://codereview.chromium.org/
1505233002
halcanary [Wed, 9 Dec 2015 03:02:36 +0000 (19:02 -0800)]
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Committed: https://skia.googlesource.com/skia/+/
b0bd1516bff3f5afcbfd615e805867531657811b
Review URL: https://codereview.chromium.org/
1507123002
fmalita [Wed, 9 Dec 2015 02:59:18 +0000 (18:59 -0800)]
[SkDebugger] Show more text blob details
* run count
* glyph count (per run)
* run paint (per run)
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
1507033003
joshualitt [Wed, 9 Dec 2015 02:58:48 +0000 (18:58 -0800)]
Remove spew in GrDefaultPathRenderer
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1509913003
scroggo [Wed, 9 Dec 2015 02:54:13 +0000 (18:54 -0800)]
Make SkCodec support peek() and read()
- Update SkCodec's dox to point out that some of the data must be
read twice in order to decode
- Add an accessor that reports how much is needed for reading twice
- Make SkCodec default to use peek()
If an input stream supports peek()ing, peek() instead of reading.
This way the stream need not implement rewind()
- Make SkCodec use read() + rewind() as a backup
So that streams without peek() implemented can still function
properly (assuming they can rewind).
- read everything we may need to determine the format once
In SkCodec::NewFromStream, peek()/read() 14 bytes, which is enough
to read all of the types we support. Pass the buffer to each subtype,
which will have enough info to determine whether it is the right
type. This simplifies the code and results in less reading and
rewinding.
- NOTE: SkWbmpCodec needs the following number of bytes for the header
+ 1 (type)
+ 1 (reserved)
+ 3 (width - bytes needed to support up to 0xFFFF)
+ 3 (height - bytes needed to support up to 0xFFFF)
= 8
- in SkWebpCodec, support using read + rewind as a backup if peek does
not work.
A change in Android will add peek() to JavaInputStreamAdapter.
BUG=skia:3257
Review URL: https://codereview.chromium.org/
1472123002
jvanverth [Wed, 9 Dec 2015 02:53:44 +0000 (18:53 -0800)]
Move texture drawing utility method to SkGpuDevice
BUG=skia:4542
Review URL: https://codereview.chromium.org/
1506203002
herb [Wed, 9 Dec 2015 02:49:04 +0000 (18:49 -0800)]
Add RTTI to all sanitizers.
BUG=skia:
Review URL: https://codereview.chromium.org/
1510843003
scroggo [Wed, 9 Dec 2015 02:48:38 +0000 (18:48 -0800)]
Remove staging for SkImageDecoder::Peeker
Will no longer be needed once ag/817367 lands - Android will be
inheriting directly from SkPngChunkReader, so no need for the
intermediate.
BUG=skia:4574
Review URL: https://codereview.chromium.org/
1470913004
mtklein [Tue, 8 Dec 2015 22:26:17 +0000 (14:26 -0800)]
Disable sanitizers with a blacklist.
We think this might be more flexible. It allows, e.g, function-level blacklisting,
and here an easy one-stop-shop blacklist for all of third_party/externals.
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1509733003
mtklein [Tue, 8 Dec 2015 19:55:17 +0000 (11:55 -0800)]
Add sk_careful_memcpy to catch undefined behavior in memcpy.
It's undefined behavior to pass null as src or dst to memcpy, even if len is 0.
This currently triggers -fsanitize=attribute-nonnull warnings, but also can
lead to very unexpected code generation with GCC.
sk_careful_memcpy() checks len first before calling memcpy(),
which prevents that weird undefined situation.
This allows me to mark all sanitizers as no-recover, i.e. make-the-bots-red fatal.
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot
BUG=skia:4641
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1510683002
reed [Tue, 8 Dec 2015 18:59:13 +0000 (10:59 -0800)]
Revert of default SkPixelSerializer (patchset #1 id:1 of https://codereview.chromium.org/
1507123002/ )
Reason for revert:
Breaking DEPS roll (linker error)
Original issue's description:
> default SkPixelSerializer
>
> Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
>
> Add SkImageEncoder::CreatePixelSerializer() to return a
> PixelSerializer that calls into SkImageEncoder::EncodeData.
>
> SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
>
> Committed: https://skia.googlesource.com/skia/+/
b0bd1516bff3f5afcbfd615e805867531657811b
TBR=scroggo@google.com,halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1505203003
bsalomon [Tue, 8 Dec 2015 18:53:43 +0000 (10:53 -0800)]
Stop wrapping images backed by generators as bitmaps in SkGpuDevice (except when tiling)
Review URL: https://codereview.chromium.org/
1510903002
mtklein [Tue, 8 Dec 2015 18:53:01 +0000 (10:53 -0800)]
spin off remaining integer overflow fixes
- Carmack rsqrt uses an int where it wants a uint32_t.
- turn off all santizers (including signed-integer-overflow) in third_party/externals/sftntly.
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot
BUG=skia:4635
Review URL: https://codereview.chromium.org/
1511643002
cdalton [Tue, 8 Dec 2015 18:48:31 +0000 (10:48 -0800)]
Improve nvpr glyph batching
Batches together path range draws whose view matrices differ by a
simple translation by pre-translating the individual path transforms
during the copy.
BUG=skia:
Review URL: https://codereview.chromium.org/
1507203002
joshualitt [Tue, 8 Dec 2015 18:47:55 +0000 (10:47 -0800)]
Allow LCD text to batch across colorchanges. This will always use
color vertices, even when we can't batch across color changes
BUG=skia:
Review URL: https://codereview.chromium.org/
1502253003
halcanary [Tue, 8 Dec 2015 18:29:58 +0000 (10:29 -0800)]
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Review URL: https://codereview.chromium.org/
1507123002
cdalton [Tue, 8 Dec 2015 18:20:32 +0000 (10:20 -0800)]
Remove drawPathsFromRange from GrDrawContext
Replaces drawPathsFromRange with a more general drawPathBatch method.
While this still isn't perfect, it's a step in the right direction that
removes the need for path range draws to fit in a public API.
BUG=skia:
Review URL: https://codereview.chromium.org/
1506823004