platform/upstream/dotnet/runtime.git
5 years agofix conversion issues
Sinan Kaya [Mon, 11 Mar 2019 17:31:46 +0000 (17:31 +0000)]
fix conversion issues

Commit migrated from https://github.com/dotnet/coreclr/commit/f1533899b70c634be152c4ad19db99fd5fa79725

5 years agoMerge pull request dotnet/coreclr#23109 from briansull/gh-21231
Brian Sullivan [Thu, 14 Mar 2019 00:33:25 +0000 (17:33 -0700)]
Merge pull request dotnet/coreclr#23109 from briansull/gh-21231

Fix for Issue 21231

Commit migrated from https://github.com/dotnet/coreclr/commit/3d4ed7c829803206db7caea1e348bc4791aec0a6

5 years agoAdd OperationStatus-based UTF8 transcoding APIs (dotnet/coreclr#23219)
Levi Broderick [Wed, 13 Mar 2019 22:43:25 +0000 (15:43 -0700)]
Add OperationStatus-based UTF8 transcoding APIs (dotnet/coreclr#23219)

Commit migrated from https://github.com/dotnet/coreclr/commit/fdd611cbcdc0f7d922dd111e5e1831663c67e685

5 years agoMerge pull request dotnet/coreclr#23220 from BruceForstall/FixArm64HfaJmpCallNyi
Bruce Forstall [Wed, 13 Mar 2019 22:38:41 +0000 (15:38 -0700)]
Merge pull request dotnet/coreclr#23220 from BruceForstall/FixArm64HfaJmpCallNyi

Arm64: Implement JMP call for HFA register arguments

Commit migrated from https://github.com/dotnet/coreclr/commit/c71c92a0c0ff7ac442c3ca9d1ae7cc177072b23f

5 years agoFix for Issue 21231
Brian Sullivan [Thu, 7 Mar 2019 22:20:44 +0000 (14:20 -0800)]
Fix for Issue 21231

When transferring a Zero offset from one GenTree node to another, we need to check if there already is a FieldSeq and append to it.
Added third parameter 'kind' to JitHashTable::Set, and Added enum SetKind
Only allow Set to overwrite an existing entry when kind is set to Overwrite.
Added validation for all calls to JitHashTable::Set
asserting that we don't expect the key to already exist or that we passed Overwrite indicating that we expect to handle it properly.

Added two test cases for Issue 21231

Commit migrated from https://github.com/dotnet/coreclr/commit/ef1d1e86da8406ca86ca98b8d92b038fe1f08d7a

5 years agoUpdate documentation: make docker images point to the registry. (dotnet/coreclr#23243)
Juan Hoyos [Wed, 13 Mar 2019 21:38:41 +0000 (14:38 -0700)]
Update documentation: make docker images point to the registry. (dotnet/coreclr#23243)

Commit migrated from https://github.com/dotnet/coreclr/commit/ac4681867c7dbb92d32d0f26ec7d611b37e92e7e

5 years agoFix SIMD handle issues (dotnet/coreclr#23193)
Carol Eidt [Wed, 13 Mar 2019 21:26:51 +0000 (14:26 -0700)]
Fix SIMD handle issues (dotnet/coreclr#23193)

* Fix SIMD handle issues

PR dotnet/coreclr#23052 was overly aggressive at applying the provided class handle (which defaults to NO_CLASS_HANDLE). In addition, make a small change to `SIMDIntrinsicWiden`, as it doesn't need to go through the complexity of inferring a class handle when it already exists on the node it's duplicating.

Fix dotnet/coreclr#23159

Commit migrated from https://github.com/dotnet/coreclr/commit/5198ce8d7aa80786b1ca7502db5fcf8cf6f3ddce

5 years agoMerge pull request dotnet/coreclr#23212 from CarolEidt/VectorABITest
Carol Eidt [Wed, 13 Mar 2019 21:19:17 +0000 (14:19 -0700)]
Merge pull request dotnet/coreclr#23212 from CarolEidt/VectorABITest

Preliminary Vector ABI test

Commit migrated from https://github.com/dotnet/coreclr/commit/52dc01aff1aeb1d972846706c65d7beb8ff9e1a7

5 years agoexclude tracing/keyword/TwoKeywords/TwoKeywords on WIndows x86. (dotnet/coreclr#23237)
Sergey Andreenko [Wed, 13 Mar 2019 20:08:38 +0000 (13:08 -0700)]
exclude tracing/keyword/TwoKeywords/TwoKeywords on WIndows x86. (dotnet/coreclr#23237)

Commit migrated from https://github.com/dotnet/coreclr/commit/bc9722ccdc539413a386c0aff6500bfa6d88fd80

5 years agoFix missed RelocatedType annotation
Michal Strehovsky [Wed, 13 Mar 2019 12:30:44 +0000 (05:30 -0700)]
Fix missed RelocatedType annotation

[tfs-changeset: 1735855]

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/00fbc8c5a94bde60e5f84e80ac8dd6b6da3ca310

5 years agoEnable FeatureDefaultInterfaces unconditionally (dotnet/coreclr#23225)
Michal Strehovský [Wed, 13 Mar 2019 18:50:13 +0000 (19:50 +0100)]
Enable FeatureDefaultInterfaces unconditionally (dotnet/coreclr#23225)

Fixes dotnet/coreclr#22940.

Commit migrated from https://github.com/dotnet/coreclr/commit/6eebb9d678a786c081b121709fa7471ff0bd08df

5 years agoFix issue 23151 (Cleanup TODO introduced by PR dotnet/coreclr#23148)
Andrew Au [Wed, 13 Mar 2019 16:56:41 +0000 (09:56 -0700)]
Fix issue 23151 (Cleanup TODO introduced by PR dotnet/coreclr#23148)

Commit migrated from https://github.com/dotnet/coreclr/commit/c6089f795eb9d5e72f5db5c530d73bc901245e2a

5 years agoAdd new counter APIs (dotnet/coreclr#23077)
Sung Yoon Whang [Wed, 13 Mar 2019 08:10:35 +0000 (01:10 -0700)]
Add new counter APIs (dotnet/coreclr#23077)

* Refactor EventCounter and add PollingCounter

* Add PollingCounter

* Add IncrementingEventCounter and IncrementingPollingCounter

* Add MetaData API to Counters

* Some more refactoring

* removing commented out code

* some more cleanup

* build fix and addressing some PR comments

* Addressing PR feedback

* use StringBuilder to generate metadata string

Commit migrated from https://github.com/dotnet/coreclr/commit/d247b06ed9c4dc3e6f625629da7db846be687f2d

5 years agoDefault Interface COM testing project (dotnet/coreclr#23195)
Aaron Robinson [Wed, 13 Mar 2019 03:34:45 +0000 (20:34 -0700)]
Default Interface COM testing project (dotnet/coreclr#23195)

* Add tests for native COM client consuming managed COM server that
  consumes interfaces with default implementation.

Commit migrated from https://github.com/dotnet/coreclr/commit/b364ef6c7872d90d75063570f25495286b87acfd

5 years agoArm64: Implement JMP call for HFA register arguments
Bruce Forstall [Sat, 9 Mar 2019 01:58:54 +0000 (17:58 -0800)]
Arm64: Implement JMP call for HFA register arguments

Add the code to load up HFA register arguments into their correct registers
before a JMP call.

Removes remaining NYI.

Fixes dotnet/coreclr#23147

Add a test case with several variants of HFA and JMP call.

Commit migrated from https://github.com/dotnet/coreclr/commit/c08f182bc90b0d32279201b7de89658765e3f6e8

5 years agoDon't retain modifiers for instantation stub signatures (dotnet/coreclr#23210)
Andy Ayers [Tue, 12 Mar 2019 23:46:24 +0000 (16:46 -0700)]
Don't retain modifiers for instantation stub signatures (dotnet/coreclr#23210)

`ConvToJitSig` is not expecting to see modifiers for return types in sigs,
so don't bother preserving them when creating instantiation stubs.

This comes up for instantiation stubs for methods of `ReadOnlySpan<T>`.

Also, if we are preserving modifiers in a sig, make sure to prefix their type
handles with `ELEM_TYPE_INTERNAL`.

Fixes dotnet/coreclr#23136.

Commit migrated from https://github.com/dotnet/coreclr/commit/5831fe40394fcdc34fa161041956d379db433dd6

5 years agoFixing a couple of issues in the Utf8Parsing/Formatting code (dotnet/coreclr#23134)
Tanner Gooding [Tue, 12 Mar 2019 21:29:38 +0000 (14:29 -0700)]
Fixing a couple of issues in the Utf8Parsing/Formatting code (dotnet/coreclr#23134)

* Fixing NumberToSingle and NumberToDouble to handle DigitsCount == 0

* Fixing Utf8Formatter.Float to transcode non ASCII bytes

* Responding to PR feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/b00f12ce4457fc013efce340011b4759e78f9948

5 years agoPreliminary Vector ABI test
Carol Eidt [Tue, 12 Mar 2019 18:28:10 +0000 (11:28 -0700)]
Preliminary Vector ABI test

Commit migrated from https://github.com/dotnet/coreclr/commit/31461ba11fecd93f951b3612e7487228c32dde62

5 years agoFix syntax bug: bash requires spaces around brackets for tests (dotnet/coreclr#23017)
John Salem [Tue, 12 Mar 2019 16:39:50 +0000 (09:39 -0700)]
Fix syntax bug: bash requires spaces around brackets for tests (dotnet/coreclr#23017)

Commit migrated from https://github.com/dotnet/coreclr/commit/3a9bb4176f892bbde935478ff04cb05d3a54a64a

5 years agoFix issue 21089 (Add tests for the `EventPipe support for "Parameters"` feature.)
Andrew Au [Fri, 1 Mar 2019 18:12:48 +0000 (10:12 -0800)]
Fix issue 21089 (Add tests for the `EventPipe support for "Parameters"` feature.)

Commit migrated from https://github.com/dotnet/coreclr/commit/18b6abc2c56adacb27b165491fc0ad757c24abdb

5 years agoReplace Delegate.CreateDelegate (dotnet/corertdotnet/coreclr#7147)
Michal Strehovský [Mon, 11 Mar 2019 20:57:29 +0000 (21:57 +0100)]
Replace Delegate.CreateDelegate (dotnet/corertdotnet/coreclr#7147)

Replacing this with a pattern that is easier to statically analyze. We use the GetType/GetMethod/CreateDelegate pattern in several places already.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/cefce5b5b82bb31600824935c585225aed059271

5 years agoMerge pull request dotnet/coreclr#23141 from CarolEidt/Fix23059
Carol Eidt [Mon, 11 Mar 2019 23:11:50 +0000 (16:11 -0700)]
Merge pull request dotnet/coreclr#23141 from CarolEidt/Fix23059

Fix handling of struct setup assignments

Commit migrated from https://github.com/dotnet/coreclr/commit/9dcbb4707c160b3479489e8421802c2eb3d93b44

5 years agoFix NRE in EqualStringArrays (dotnet/coreclr#23174)
Hugh Bellamy [Mon, 11 Mar 2019 20:59:13 +0000 (20:59 +0000)]
Fix NRE in EqualStringArrays (dotnet/coreclr#23174)

Commit migrated from https://github.com/dotnet/coreclr/commit/e9f23f604d6ed754148930ac85c3bcd1e06b4e55

5 years agoFix bad test (dotnet/coreclr#23173)
Michal Strehovský [Mon, 11 Mar 2019 20:58:20 +0000 (21:58 +0100)]
Fix bad test (dotnet/coreclr#23173)

The test was testing that a non-virtual call to an abstract method that is methodimpl on the same type will land in the methodimpl. This behavior is not specced and cannot be hit with any mainstream .NET languages. We are making non-virtual calls to abstract methods throw a BadImageFormatException instead.

Fixes dotnet/coreclr#23096.

Commit migrated from https://github.com/dotnet/coreclr/commit/27b39d83535231d31f562002b78ac1e1b3b54be3

5 years agoMerge pull request dotnet/coreclr#23187 from BruceForstall/AlwaysArchiveCoreFxTestRes...
Bruce Forstall [Mon, 11 Mar 2019 20:36:45 +0000 (13:36 -0700)]
Merge pull request dotnet/coreclr#23187 from BruceForstall/AlwaysArchiveCoreFxTestResultsXml

Always archive corefx testresults.xml files

Commit migrated from https://github.com/dotnet/coreclr/commit/873cc91a6e88364fd758dec2eb61ed20017cfdee

5 years agoAlways archive corefx testresults.xml files
Bruce Forstall [Mon, 11 Mar 2019 20:10:43 +0000 (13:10 -0700)]
Always archive corefx testresults.xml files

These were only being archived for successful runs, which is
when they are the least interesting. Archive them for all test runs.

Commit migrated from https://github.com/dotnet/coreclr/commit/99935d80bc2047393452fee6210e93ce569afb1c

5 years agoAdd EntryPointFilter option (dotnet/coreclr#23054)
Steve MacLean [Mon, 11 Mar 2019 16:26:57 +0000 (12:26 -0400)]
Add EntryPointFilter option (dotnet/coreclr#23054)

* Add EntryPointFilter

Commit migrated from https://github.com/dotnet/coreclr/commit/2f2fd8d21f8dde67f3bbe125be62a0e53e34bd3b

5 years agoAdd a target to get native resources from another DLL to ILProj SDK (dotnet/coreclr...
Eric StJohn [Mon, 11 Mar 2019 15:53:46 +0000 (08:53 -0700)]
Add a target to get native resources from another DLL to ILProj SDK (dotnet/coreclr#23117)

We use a similar target in CoreFx and I'll need it for another project that is planning on
using this SDK.

When ILResourceReference it will be disassembled to get native resources (EG: fileversion)
to pass to ILasm.

If ILResourceReference is not specified then it does nothing.

Commit migrated from https://github.com/dotnet/coreclr/commit/b0d380514fad5736b54b8f9ed5cd3ea915f5f42c

5 years agoRemove 2 suffix step 1 (dotnet/corefxdotnet/coreclr#35904)
Dan Moseley [Sat, 9 Mar 2019 21:54:04 +0000 (13:54 -0800)]
Remove 2 suffix step 1 (dotnet/corefxdotnet/coreclr#35904)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/f94728547617160837baedc43b7786a457b3e45f

5 years agoMerge pull request dotnet/coreclr#23093 from franksinankaya/gcc_warnings_9
Jan Vorlicek [Mon, 11 Mar 2019 15:08:50 +0000 (16:08 +0100)]
Merge pull request dotnet/coreclr#23093 from franksinankaya/gcc_warnings_9

GCC Signed compare and Narrowing warnings

Commit migrated from https://github.com/dotnet/coreclr/commit/f9820b7c45ed1ae99fef54944727e98bacbd2a2a

5 years agoMerge pull request dotnet/coreclr#23111 from am11/gcc-configuration
Jan Vorlicek [Mon, 11 Mar 2019 13:59:27 +0000 (14:59 +0100)]
Merge pull request dotnet/coreclr#23111 from am11/gcc-configuration

Improve gcc configuration

Commit migrated from https://github.com/dotnet/coreclr/commit/123422de218d6ca5c36cbb7f34ece95dcae333da

5 years agoMerge pull request dotnet/coreclr#23099 from janvorli/remove-pal-cleanup
Jan Vorlicek [Mon, 11 Mar 2019 12:23:25 +0000 (13:23 +0100)]
Merge pull request dotnet/coreclr#23099 from janvorli/remove-pal-cleanup

Remove init_count zeroing from PAL cleanup at process exit

Commit migrated from https://github.com/dotnet/coreclr/commit/20ec8fa5448655309490106cf7ac72bf60b3485f

5 years agoMerge pull request dotnet/coreclr#23121 from janvorli/enable-clang-staticanalyzer...
Jan Vorlicek [Mon, 11 Mar 2019 11:08:26 +0000 (12:08 +0100)]
Merge pull request dotnet/coreclr#23121 from janvorli/enable-clang-staticanalyzer-build

Enable build with clang static analyzer

Commit migrated from https://github.com/dotnet/coreclr/commit/c132634fa1215e8145e35164733da7485bacb262

5 years agoRemove conditions around CMAKE_REQUIRED_LIBRARIES
Adeel [Mon, 11 Mar 2019 09:38:32 +0000 (02:38 -0700)]
Remove conditions around CMAKE_REQUIRED_LIBRARIES

Commit migrated from https://github.com/dotnet/coreclr/commit/107b9424d7dd56c1902b09bb1c67533215190ea8

5 years agoRefactor Encoding to split fast-path and fallback logic (dotnet/coreclr#23098)
Levi Broderick [Mon, 11 Mar 2019 04:40:27 +0000 (21:40 -0700)]
Refactor Encoding to split fast-path and fallback logic (dotnet/coreclr#23098)

This refactoring is limited to ASCIIEncoding at the moment, but it can easily be applied to UTF-8 / UTF-16 / UTF-32.

High-level changes:
- Fallback logic has been split from the fast-path, improving performance of GetBytes and similar routines.
- All of the plumbing of when to invoke the fallback logic and how to manage leftover data has been moved into the base class.
- Almost all of the logic except for the fast-path is now written in terms of verifiable code (Span and ReadOnlySpan).
- Minor bug fixes in EncoderNLS.Convert (see https://github.com/dotnet/coreclr/issues/23020).

Commit migrated from https://github.com/dotnet/coreclr/commit/43a5159d39bd52195c5095da4006183f791c696b

5 years agoMove Buffer to shared (dotnet/coreclr#23157)
Egor Bogatov [Sat, 9 Mar 2019 21:55:43 +0000 (00:55 +0300)]
Move Buffer to shared (dotnet/coreclr#23157)

Commit migrated from https://github.com/dotnet/coreclr/commit/526c32c221192cd5876239b2d72c68d1ba0c40c3

5 years agoTwo more instances
Andrew Au [Sat, 9 Mar 2019 00:07:39 +0000 (16:07 -0800)]
Two more instances

Commit migrated from https://github.com/dotnet/coreclr/commit/81e2f5008826cf8ea7cc51d0cb9fa711e1259506

5 years agoEliminate SampleProfilerEventInstance
Andrew Au [Fri, 8 Mar 2019 23:13:58 +0000 (15:13 -0800)]
Eliminate SampleProfilerEventInstance

Commit migrated from https://github.com/dotnet/coreclr/commit/01024ebfc8b1d166fb345ac411e6aec571e4e571

5 years agoAvoid StackWalk in EventPipeEventInstance constructor
Andrew Au [Sat, 9 Mar 2019 00:00:36 +0000 (16:00 -0800)]
Avoid StackWalk in EventPipeEventInstance constructor

Commit migrated from https://github.com/dotnet/coreclr/commit/8009ba276895edc9decf49c8a2470a1e6bbe2997

5 years agoAdd stack depth check to all Task continuations (dotnet/coreclr#23152)
Stephen Toub [Sat, 9 Mar 2019 16:41:43 +0000 (11:41 -0500)]
Add stack depth check to all Task continuations (dotnet/coreclr#23152)

Currently Task has a stack depth check that avoids stack overflows on very deep stack continuation chains, but it only applies to Task.ContinueWith, not to other kinds of continuations.  This changes that to have it apply to all.

As part of this, this also deletes the current StackGuard type used to achieve the check.  The type was meant to avoid expensive calls to check where we are on the stack, but now that we're using TryEnsureSufficientExecutionStack, it's actually faster to just call that rather than access the current StackGuard from a ThreadLocal.  This then also cleans up the call sites nicely, as they no longer need finally blocks to undo the increment performed on the StackGuard.

Commit migrated from https://github.com/dotnet/coreclr/commit/6633b51df7f91623190ba6bf04c00869cd0fc1e4

5 years agoMove part of RuntimeHelpers to shared partition (dotnet/coreclr#23130)
Marek Safar [Sat, 9 Mar 2019 05:32:53 +0000 (06:32 +0100)]
Move part of RuntimeHelpers to shared partition (dotnet/coreclr#23130)

* Move part of RuntimeHelpers to shared partition

* Remove FormatterServices.cs

Commit migrated from https://github.com/dotnet/coreclr/commit/ed505143f888a16402d0ce891412cdf4f2cb4724

5 years agoProperly override IsEquivalentTo() API in RuntimeType (dotnet/coreclr#23137)
Aaron Robinson [Sat, 9 Mar 2019 01:36:37 +0000 (17:36 -0800)]
Properly override IsEquivalentTo() API in RuntimeType (dotnet/coreclr#23137)

* Properly override IsEquivalentTo() API in RuntimeType
* Add tests for API validation

Commit migrated from https://github.com/dotnet/coreclr/commit/c194074a82ee35f31b1e55233b43256713b26467

5 years agoUpdate eventcounter spec (dotnet/coreclr#23142)
Sung Yoon Whang [Fri, 8 Mar 2019 22:54:38 +0000 (14:54 -0800)]
Update eventcounter spec (dotnet/coreclr#23142)

Commit migrated from https://github.com/dotnet/coreclr/commit/ee56e5874db8780c99d2d93169aacf477f7b73f1

5 years agoMerge pull request dotnet/coreclr#23140 from BruceForstall/RemoveArm64NYI
Bruce Forstall [Fri, 8 Mar 2019 22:45:11 +0000 (14:45 -0800)]
Merge pull request dotnet/coreclr#23140 from BruceForstall/RemoveArm64NYI

Remove unneeded arm64 NYI

Commit migrated from https://github.com/dotnet/coreclr/commit/c1feb4eda03d1d82908d4d733c95413a1c85d749

5 years agoUse 4 core external build queues (dotnet/coreclr#23079)
Jarret Shook [Fri, 8 Mar 2019 22:43:53 +0000 (14:43 -0800)]
Use 4 core external build queues (dotnet/coreclr#23079)

Commit migrated from https://github.com/dotnet/coreclr/commit/d1351f962f7c50deb2115ec2833ac469608b83d0

5 years agoFix missing RunTests.sh in CoreFX Linux jobs. (dotnet/coreclr#23135)
Sergey Andreenko [Fri, 8 Mar 2019 22:24:17 +0000 (14:24 -0800)]
Fix missing RunTests.sh in CoreFX Linux jobs. (dotnet/coreclr#23135)

Commit migrated from https://github.com/dotnet/coreclr/commit/9df1fc369a768c342bc86b5e9c3311540a4ebf2b

5 years agoFix handling of struct setup assignments
Carol Eidt [Fri, 8 Mar 2019 21:09:41 +0000 (13:09 -0800)]
Fix handling of struct setup assignments

In dotnet/coreclr#22791 I was creating struct assignments with COMMAs on the rhs, but that isn't handled downstream.

Fix dotnet/coreclr#23059

Commit migrated from https://github.com/dotnet/coreclr/commit/384eefbd899ced778d99314df0d9e76fdccf71a4

5 years agoRemove unneeded arm64 NYI
Bruce Forstall [Fri, 8 Mar 2019 20:43:54 +0000 (12:43 -0800)]
Remove unneeded arm64 NYI

InitVarDscInfo::alignReg is only used by `_TARGET_ARM_`, so put
it under that ifdef.

Contributes to dotnet/coreclr#18178

Commit migrated from https://github.com/dotnet/coreclr/commit/9485e96368b5bfb64468d53fe5fb31f362be2e2a

5 years agoMerge pull request dotnet/coreclr#23086 from BruceForstall/Arm64ChangeIntFloatSaveOrder
Bruce Forstall [Fri, 8 Mar 2019 20:25:21 +0000 (12:25 -0800)]
Merge pull request dotnet/coreclr#23086 from BruceForstall/Arm64ChangeIntFloatSaveOrder

Arm64: always save int registers at higher addresses than float regs

Commit migrated from https://github.com/dotnet/coreclr/commit/2a77dc515bccf78308232384522017e5a3bdc3f0

5 years agoOptimized RemoveItemsRange to call the list.RemoveRange if the items is of type List<T>
Andrew Hoefling [Thu, 7 Mar 2019 23:08:22 +0000 (18:08 -0500)]
Optimized RemoveItemsRange to call the list.RemoveRange if the items is of type List<T>

Commit migrated from https://github.com/dotnet/coreclr/commit/d29c78bbbcb033f7d189bcc162e580176160a1c9

5 years agoSimplified the RemoveItem logic since we have more robust validation
Andrew Hoefling [Thu, 7 Mar 2019 00:34:57 +0000 (19:34 -0500)]
Simplified the RemoveItem logic since we have more robust validation

Commit migrated from https://github.com/dotnet/coreclr/commit/7e487423d166cf2768d3f6630071d908832f0fe4

5 years agoInsertItemsRange API now checks if the underlying items.IsReadOnly first then collect...
Andrew Hoefling [Wed, 6 Mar 2019 17:57:09 +0000 (12:57 -0500)]
InsertItemsRange API now checks if the underlying items.IsReadOnly first then collection == null

Commit migrated from https://github.com/dotnet/coreclr/commit/44e05888b328699d3a0ca4b76544d7c357b49b47

5 years agoRemoved (Int64) cast statements from RemoveItemsRange when checking for overflow...
Andrew Hoefling [Wed, 6 Mar 2019 17:47:03 +0000 (12:47 -0500)]
Removed (Int64) cast statements from RemoveItemsRange when checking for overflow errors

Commit migrated from https://github.com/dotnet/coreclr/commit/39be7e55798e4f81c531661b0df798e91c7d5936

5 years agoAdded new RemoveRange validation check to see if the resulting range (index + count...
Andrew Hoefling [Wed, 6 Mar 2019 01:31:19 +0000 (20:31 -0500)]
Added new RemoveRange validation check to see if the resulting range (index + count) > items.Count and if it is true throw ArgumentException

Commit migrated from https://github.com/dotnet/coreclr/commit/f48e28bbd7e14fe9b6c708fe57624324a5e604eb

5 years agoUpdated InsertItemsRange to simplify the expression and added performance improvement...
Andrew Hoefling [Wed, 6 Mar 2019 00:00:01 +0000 (19:00 -0500)]
Updated InsertItemsRange to simplify the expression and added performance improvements. If the underlying `items` is using List<T> we should use it's InsertRange method since it is optimized, othersie we use InsertItem

Commit migrated from https://github.com/dotnet/coreclr/commit/dadee3b355c75e33d0c925b27ba3f301d100a51b

5 years agoUpdated RemoveAt->RemoveItem. This change removes redundent validation checks that...
Andrew Hoefling [Tue, 5 Mar 2019 23:46:05 +0000 (18:46 -0500)]
Updated RemoveAt->RemoveItem. This change removes redundent validation checks that happen using the RemoveAt API. RemoveItem gives us direct access to invoke the command

Commit migrated from https://github.com/dotnet/coreclr/commit/d3b9f9dac784c03e10619ff49c8f22579940192c

5 years agoUpdated RemoveRange invocation of RemoveAt to use index instead of i, because the...
Andrew Hoefling [Tue, 5 Mar 2019 23:15:08 +0000 (18:15 -0500)]
Updated RemoveRange invocation of RemoveAt to use index instead of i, because the array changes with each iteration of the for loop and will cause side-effects which may include index out of range exceptions. This needs to be index because as the array shrinks the index is always at the correct position.

Commit migrated from https://github.com/dotnet/coreclr/commit/2fb96bfe42d2b97577918c24be445cc8106ae593

5 years agoAdded ArgumentOutOfRangeException exception in RemoveRange if the count is less than 0
Andrew Hoefling [Tue, 5 Mar 2019 23:14:01 +0000 (18:14 -0500)]
Added ArgumentOutOfRangeException exception in RemoveRange if the count is less than 0

Commit migrated from https://github.com/dotnet/coreclr/commit/5f9e81d1577345c4f3fc4df475b8f3e7f672f0ce

5 years agoUpdated RemoveItemsRange to properly remove each item and not just the index items
Andrew Hoefling [Tue, 5 Mar 2019 05:26:08 +0000 (00:26 -0500)]
Updated RemoveItemsRange to properly remove each item and not just the index items

Commit migrated from https://github.com/dotnet/coreclr/commit/b474a2a96d6ca31f3a093fd83b49537eee382794

5 years agoUpdated RemoveItemsRange to prevent int.MaxValue overflow errors
Andrew Hoefling [Tue, 5 Mar 2019 04:50:36 +0000 (23:50 -0500)]
Updated RemoveItemsRange to prevent int.MaxValue overflow errors

Commit migrated from https://github.com/dotnet/coreclr/commit/0190ab05d31de5ca020ee7a2325ff3d3625af43a

5 years agoRemove ternary operator from invocation as it is the same as inputing items.Count
Andrew Hoefling [Tue, 5 Mar 2019 04:44:19 +0000 (23:44 -0500)]
Remove ternary operator from invocation as it is the same as inputing items.Count

Commit migrated from https://github.com/dotnet/coreclr/commit/c32f57bdae5cd532ebb3587386db937528726ca6

5 years agoAdded ReplaceItemsRange API and updated ReplaceRange to invoke the protected method
Andrew Hoefling [Tue, 5 Mar 2019 03:28:05 +0000 (22:28 -0500)]
Added ReplaceItemsRange API and updated ReplaceRange to invoke the protected method

Commit migrated from https://github.com/dotnet/coreclr/commit/96de98c1aab0b65c0dfd667bc86e6ab14794306c

5 years agoAdding braces on for loop
Andrew Hoefling [Tue, 5 Mar 2019 02:54:41 +0000 (21:54 -0500)]
Adding braces on for loop

Commit migrated from https://github.com/dotnet/coreclr/commit/69c3b0355df56fd47f98faf574e24f577f6d29c2

5 years agoUpdated foreach to use T instead of var
Andrew Hoefling [Tue, 5 Mar 2019 02:53:52 +0000 (21:53 -0500)]
Updated foreach to use T instead of var

Commit migrated from https://github.com/dotnet/coreclr/commit/ff55c32b76d8843a9be7481200c05ac0d0e2c4c4

5 years agoUpdated index out of range exception check to be a single comparison
Andrew Hoefling [Tue, 5 Mar 2019 02:53:26 +0000 (21:53 -0500)]
Updated index out of range exception check to be a single comparison

Commit migrated from https://github.com/dotnet/coreclr/commit/3460d643fa62340b45b85ad0a57934c523ba5496

5 years agoAdded new Range Manipulation APIs for Collection<T> which propogate up to ObservableC...
Andrew Hoefling [Tue, 5 Mar 2019 01:16:16 +0000 (20:16 -0500)]
Added new Range Manipulation APIs for Collection<T> which propogate up to ObservableCollection<T>. AddRange, InsertRange, RemoveRange and Replace Range

Commit migrated from https://github.com/dotnet/coreclr/commit/0f5aee3560635d2c58c023578d00d7955a995163

5 years agoUse CLR_LINK
Adeel [Fri, 8 Mar 2019 19:04:43 +0000 (11:04 -0800)]
Use CLR_LINK

Commit migrated from https://github.com/dotnet/coreclr/commit/4cfaacd6c29d033bb11869ca9ff700991965c051

5 years agoAllow deserialization for ResourceManager created with non-default resource set type...
Filip Navara [Fri, 8 Mar 2019 18:55:25 +0000 (19:55 +0100)]
Allow deserialization for ResourceManager created with non-default resource set type (dotnet/coreclr#23051)

Commit migrated from https://github.com/dotnet/coreclr/commit/d74fa42f811dbe28a8c12ae39122f8d110fbfa5c

5 years agoMerge pull request dotnet/coreclr#23119 from BruceForstall/Arm64PrePostIndexCoalescing
Bruce Forstall [Fri, 8 Mar 2019 18:31:56 +0000 (10:31 -0800)]
Merge pull request dotnet/coreclr#23119 from BruceForstall/Arm64PrePostIndexCoalescing

Allow coalescing of SP adjustment into single register prolog STR/LDR

Commit migrated from https://github.com/dotnet/coreclr/commit/fbaff14510fb0c1844b30a3faaf9a2c8323f294b

5 years agoImprove SSA renaming memory usage (dotnet/coreclr#15000)
mikedn [Fri, 8 Mar 2019 18:29:07 +0000 (20:29 +0200)]
Improve SSA renaming memory usage (dotnet/coreclr#15000)

* Cleanup DumpStacks

It's not exactly useful to dump all the stacks after pushing to a stack. Nor is it useful to dump all the stack after popping only some, perhaps none, in PopBlockStacks.

Also dump stack from top to bottom, makes it easier to find the top, which is usually what you care about during SSA renaming.

* Stop passing null block to SsaRenameState::Push

It makes no difference if the definition is in the "block before any real blocks..." or at the start of the first block, it's just an unnecessary complication.

* Stop handling byrefStatesMatchGcHeapStates in SsaRenameState

SsaBuilder already handles that, doing it again in SsaRenameState just duplicates logic.

* Stop using "count" as a name for "SSA number"

Worst name ever.

Also use "block" consistently, instead of a mix of "bb" and "block".

* Delete "ConstructedArray", not needed

* Various cleanup

- Change SsaRenameState to a class
- Cleanup remaining function comments
- Move SsaRenameStateForBlock & SsaRenameStateLocDef inside SsaRenameState
- Make EnsureStacks private
- Reorder data members
- Use m_ prefix consistently

* Replace jitstd::list with a custom stack

std::list has a few drawbacks:
- It's a doubly linked list but a singly linked list suffices so every node wastes 8 bytes for an extra pointer.
- The list object itself is relatively large 2 head/tail pointers, node count and memory allocator. There can be hundreds of such objects (one for each local variable) so the smaller the better.

Replace with a simple singly linked, intrusive list based stack.

* Share push code between lclvar and memory

It's pretty much the same logic (the only difference is that in the memory case "top" can't ever be null so by sharing the code we get a redundant null check).

Commit migrated from https://github.com/dotnet/coreclr/commit/fb583867ae37e75cf9f5c4f556627283a257d67b

5 years agoRemove extra quotes
Adeel [Fri, 8 Mar 2019 18:03:08 +0000 (10:03 -0800)]
Remove extra quotes

Commit migrated from https://github.com/dotnet/coreclr/commit/998e8efa2f0b2ba1e23c4ce582bba3d0f0001727

5 years agoAdd outerloop-jitstressregs, outerloop-jitstress2-jitstressregs, outerloop-gcstress0x...
Egor Chesakov [Fri, 8 Mar 2019 17:56:20 +0000 (09:56 -0800)]
Add outerloop-jitstressregs, outerloop-jitstress2-jitstressregs, outerloop-gcstress0x3-gcstress0xc TestGroups (dotnet/coreclr#23047)

The following build definitions

* coreclr-ci
* coreclr-outerloop
* coreclr-outerloop-jitminopts-jitstress1-jitstress2
* coreclr-outerloop-jitstressregs
* coreclr-outerloop-jitstress2-jitstressregs
* coreclr-outerloop-gcstress0x3-gcstress0xc

can be triggered from pull requests via /azp run x command.

Commit migrated from https://github.com/dotnet/coreclr/commit/41df61c0f570d94b962430e38b2c24181972b998

5 years agoJIT: rework codegen for Arm64 SIMD Extract/Insert intrinsics (dotnet/coreclr#23114)
Andy Ayers [Fri, 8 Mar 2019 17:02:03 +0000 (09:02 -0800)]
JIT: rework codegen for Arm64 SIMD Extract/Insert intrinsics (dotnet/coreclr#23114)

Add an up-front bounds check during importation instead of waiting
until codegen. Mirrors what we do for similar cases on xarch.

Closes dotnet/coreclr#20260.

Commit migrated from https://github.com/dotnet/coreclr/commit/34e83028171d6775d1020fe5dab7c4260caf16e1

5 years agoMerge pull request dotnet/coreclr#23052 from CarolEidt/Fix22850
Carol Eidt [Fri, 8 Mar 2019 16:35:39 +0000 (08:35 -0800)]
Merge pull request dotnet/coreclr#23052 from CarolEidt/Fix22850

Correctly type SIMD stack values

Commit migrated from https://github.com/dotnet/coreclr/commit/42bacd6a5b0b56f5181c6ab60a9abf05174f3a41

5 years agoAddress @janvorli's feedback
Adeel [Fri, 8 Mar 2019 01:29:22 +0000 (17:29 -0800)]
Address @janvorli's feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/6d26a56a77e86edd3d1df4161c8a9ada5b99a35b

5 years agoEnable build with clang static analyzer
Jan Vorlicek [Fri, 8 Mar 2019 01:31:39 +0000 (17:31 -0800)]
Enable build with clang static analyzer

As part of LLVM, there is a clang static analyzer tool that provides
useful analysis of potential issues in the source code base.

This change enables building coreclr with that analyzer enabled.

Commit migrated from https://github.com/dotnet/coreclr/commit/7b7f8ec1e3f974a43e96c3f01cb0d5a2da913e17

5 years agodisabling tracing/tracevalidation/inducedgc/inducedgc test on ARM64 (dotnet/coreclr...
Sung Yoon Whang [Fri, 8 Mar 2019 09:17:51 +0000 (01:17 -0800)]
disabling tracing/tracevalidation/inducedgc/inducedgc test on ARM64 (dotnet/coreclr#23125)

Commit migrated from https://github.com/dotnet/coreclr/commit/97d979e539063aaf6c5f8b5446fe703c99e31b7a

5 years agoUse platform specific implementation of GetCurrentProcessId (dotnet/coreclr#23084)
Marek Safar [Fri, 8 Mar 2019 07:27:54 +0000 (08:27 +0100)]
Use platform specific implementation of GetCurrentProcessId (dotnet/coreclr#23084)

* Use platform specific implementation of GetCurrentProcessId

directly in shared location instead of relying on runtime export

* Move GetCurrentProcessId to Interop class

* Update ES_BUILD_STANDALONE build

Commit migrated from https://github.com/dotnet/coreclr/commit/0fee55abb6b7c742cb487b12706dc54080e9e128

5 years agoAdded UserFlags field, unblocks dotnet/coreclr#34560 (dotnet/corefxdotnet/coreclr...
Dávid Kaya [Fri, 8 Mar 2019 05:12:31 +0000 (06:12 +0100)]
Added UserFlags field, unblocks dotnet/coreclr#34560 (dotnet/corefxdotnet/coreclr#35851)

* Added UserFlags field

* Added UserFlags

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/1fc9e9c28771863839bf54da3e17f9f2d12e84b2

5 years agoFix a rare JitStress assert. (dotnet/coreclr#23116)
Sergey Andreenko [Fri, 8 Mar 2019 03:43:37 +0000 (19:43 -0800)]
Fix a rare JitStress assert. (dotnet/coreclr#23116)

* Fix undefined behaviour when we check `this==nullptr`.

* Fix ifdef comment.

* Fix rare jit stress assert.

flowgraph.cpp: !IsUninitialized(tree) can fail if `UninitializedWord` returns a valid pointer value.

Commit migrated from https://github.com/dotnet/coreclr/commit/24d05f5e6cb905da8d2bf84d0b1525586152c908

5 years agoFix how we check whether events are enabled via LTTng (dotnet/coreclr#22707)
Sung Yoon Whang [Fri, 8 Mar 2019 02:34:17 +0000 (18:34 -0800)]
Fix how we check whether events are enabled via LTTng (dotnet/coreclr#22707)

* Fix how we check whether events are enabled via LTTng

* Add GCToEEInterface::UpdateGCEventStatus

* Fix build errors

* Finished hooking it up to post_gc

* Some comments about the event keyword/level detection logic

* Fix windows build

* Fix Prv provider keyword logic

* forgot to add one more ifdef

* Fix OSX build

* one more ifdef to fix

* Addressing PR feedback

* Update GCEventStatus at gc_heap::initialize_gc too

Commit migrated from https://github.com/dotnet/coreclr/commit/4685a1e008ad7cf4118e8778d89e63d87ca5b7b6

5 years agoAllow coalescing of SP adjustment into single register prolog STR/LDR
Bruce Forstall [Fri, 8 Mar 2019 01:08:53 +0000 (17:08 -0800)]
Allow coalescing of SP adjustment into single register prolog STR/LDR

Commit migrated from https://github.com/dotnet/coreclr/commit/6e6a4b26dfe914e6924d03ce91aa52f2fab05d79

5 years agoUse DOTNET_${$1} environment variables
Adeel [Fri, 8 Mar 2019 00:50:39 +0000 (16:50 -0800)]
Use DOTNET_${$1} environment variables

Commit migrated from https://github.com/dotnet/coreclr/commit/89dcb477d1fd1e772c8ce1558e103ee72af60c3b

5 years agoMerge pull request dotnet/coreclr#22708 from BrianBohe/updating_comments
Carol Eidt [Fri, 8 Mar 2019 00:40:18 +0000 (16:40 -0800)]
Merge pull request dotnet/coreclr#22708 from BrianBohe/updating_comments

Updating ScopeInfo::siUpdate comments/documentation

Commit migrated from https://github.com/dotnet/coreclr/commit/a2865ead29cc8ef73307927976c3dbaad1298d44

5 years agoImprove gcc configuration
Adeel [Thu, 7 Mar 2019 22:23:55 +0000 (14:23 -0800)]
Improve gcc configuration
* Use `find_path` instead of `check_include_files` for lttng.
* `locate_gcc_exec gcc` to `locate_gcc_exec link` for `gcc_link`
* Remove unused `DCMAKE_OBJCOPY`
* Fix all warnings in gen-buildsys-gcc.sh reported by shellchecker.

Commit migrated from https://github.com/dotnet/coreclr/commit/c6abb4361b008e03fab815e99e337bc1b5b57df2

5 years agoAdd missing CopyToAsync override in FileStream.Unix.cs (dotnet/coreclr#23101)
Stephen Toub [Thu, 7 Mar 2019 22:28:21 +0000 (14:28 -0800)]
Add missing CopyToAsync override in FileStream.Unix.cs (dotnet/coreclr#23101)

Commit migrated from https://github.com/dotnet/coreclr/commit/0523c2115da2b35d7f6ce028f4b128b25354078c

5 years agoDisable tests based on 23103 and 23096 (dotnet/coreclr#23104)
Jarret Shook [Thu, 7 Mar 2019 21:35:09 +0000 (13:35 -0800)]
Disable tests based on 23103 and 23096 (dotnet/coreclr#23104)

* Disable tests based on 23103 and 23096

* Remove disable for arm32 AV

Commit migrated from https://github.com/dotnet/coreclr/commit/833e75d0e65ffa81f6baa1307efb9e6e6c526b8e

5 years agoFix ARMv8.1 atomics disassembly (dotnet/coreclr#23070)
mikedn [Thu, 7 Mar 2019 21:29:09 +0000 (23:29 +0200)]
Fix ARMv8.1 atomics disassembly (dotnet/coreclr#23070)

Fixes dotnet/coreclr#20721.

Commit migrated from https://github.com/dotnet/coreclr/commit/7f5329382ce62478789d80aefcc1e064da24287b

5 years agoUpdate error message for when a parent is marked as COMVisible(false) (dotnet/coreclr...
Aaron Robinson [Thu, 7 Mar 2019 20:19:53 +0000 (12:19 -0800)]
Update error message for when a parent is marked as COMVisible(false) (dotnet/coreclr#23092)

* Update message to include type and parent type marked as COMVisible(false)

Commit migrated from https://github.com/dotnet/coreclr/commit/8b3c55c36531689c337df37f15eb5a40530fa42f

5 years agoFix signed compare warnings
Sinan Kaya [Thu, 7 Mar 2019 02:25:21 +0000 (02:25 +0000)]
Fix signed compare warnings

warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

conversions

Update src/ToolBox/superpmi/mcs/verbdumptoc.cpp

Co-Authored-By: franksinankaya <41809318+franksinankaya@users.noreply.github.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/5a97d8e9f14763a4ff90d14d045f0173e8d4b944

5 years agoJIT: fix filter liveness computation (dotnet/coreclr#23044)
Andy Ayers [Thu, 7 Mar 2019 18:52:19 +0000 (10:52 -0800)]
JIT: fix filter liveness computation (dotnet/coreclr#23044)

When a filter is finished executing, control can logically pass to the
associated handler, any enclosing handler or filter, or any finally or fault
handler nested within the associated try. This is a consequence of two-pass EH.

The jit was not propagating liveness from the nested handlers, which lead to a
live object being collected inadvertently.

This change updates `fgGetHandlerLiveVars` to find the nested handlers and
merge their live-in into the filter block live sets.

Because these implicit EH flow edges can create cycles in the liveness dataflow
equations, the jit will also now always iterate liveness when it sees there is
exception flow, to ensure livness reaches the appropriate fixed point.

Added test case.

Closes dotnet/coreclr#22820.

Commit migrated from https://github.com/dotnet/coreclr/commit/f6cc0134fa4bb0d2f329ebc18c4eb662a5a5d973

5 years agoFix control C trap hang in the debugger (dotnet/coreclr#23090)
Juan Hoyos [Thu, 7 Mar 2019 18:35:25 +0000 (10:35 -0800)]
Fix control C trap hang in the debugger (dotnet/coreclr#23090)

Commit migrated from https://github.com/dotnet/coreclr/commit/637900c4d1792d41b0c195904c079277cd80caf9

5 years agoClean up some arm64 prolog/epilog code (dotnet/coreclr#23080)
Bruce Forstall [Thu, 7 Mar 2019 17:25:17 +0000 (09:25 -0800)]
Clean up some arm64 prolog/epilog code (dotnet/coreclr#23080)

* Clean up some arm64 prolog/epilog code

1. For frame types which establish a frame pointer before the final
SP adjustment, there is no need to report the SP adjustment in unwind
data, as it is unused.
2. Added some comments, esp. related to frameType 1, explaining the
totalFrameSize limit.
3. Fixed frameType 3 #outsz check to > 504 versus >= 504; 504 is a legal
offset for STP/LDP.
4. Fix frameType 3 epilogs to always restore SP from FP. Should give more
prolog/epilog unwind code matching, and simplifies the code.

Closes dotnet/coreclr#22056, dotnet/coreclr#22058, dotnet/coreclr#22057, dotnet/coreclr#22476, dotnet/coreclr#22478.

* Formatting

* Update comment

Commit migrated from https://github.com/dotnet/coreclr/commit/c5935b38947fe1c6beea1a9191e58b3048355b67

5 years agoMerge pull request dotnet/coreclr#23085 from BruceForstall/FixAsmDiffScratchRoot
Bruce Forstall [Thu, 7 Mar 2019 16:34:29 +0000 (08:34 -0800)]
Merge pull request dotnet/coreclr#23085 from BruceForstall/FixAsmDiffScratchRoot

Fix PMI asm diffs

Commit migrated from https://github.com/dotnet/coreclr/commit/781211ecdf96d3d9293e7623dc9e5990dd857e57

5 years agoCleanup unused hosting interfaces (dotnet/coreclr#23091)
Jan Kotas [Thu, 7 Mar 2019 15:37:04 +0000 (07:37 -0800)]
Cleanup unused hosting interfaces (dotnet/coreclr#23091)

Commit migrated from https://github.com/dotnet/coreclr/commit/70300c711b9e507d251f9a31d5c4be9653dd4c8a

5 years agoRemove init_count zeroing from PAL cleanup
Jan Vorlicek [Thu, 7 Mar 2019 15:10:55 +0000 (16:10 +0100)]
Remove init_count zeroing from PAL cleanup

Setting the init_count to 0 in the PALCommonCleanup was causing
intermittent crashes in the GC stress C tests on Linux with
SIGILL. The reason is that the signal handlers do nothing and call a
previous handler in case the PAL is not initialized, which is indicated
by the init_count being zero.

To fix that issue, I have removed the init_count zeroing at process
exit, since the PAL and runtime is still capable of handling the
signals.

Commit migrated from https://github.com/dotnet/coreclr/commit/638b1c1eeaf49282dcb036376ae6e35a7b62aee3

5 years agoCleanup Globalization info code (dotnet/coreclr#22591)
Hugh Bellamy [Thu, 7 Mar 2019 14:39:23 +0000 (14:39 +0000)]
Cleanup Globalization info code (dotnet/coreclr#22591)

Commit migrated from https://github.com/dotnet/coreclr/commit/724112354c74b67629d58d1f6b9c0007f5a13fc9

5 years agoIgnore warning in another build script. (dotnet/coreclr#23082)
Sergey Andreenko [Thu, 7 Mar 2019 07:09:11 +0000 (23:09 -0800)]
Ignore warning in another build script. (dotnet/coreclr#23082)

Commit migrated from https://github.com/dotnet/coreclr/commit/8e39d114c9f9733f3337dc678cd2344631dd4742

5 years agoconversion
Sinan Kaya [Thu, 7 Mar 2019 01:46:07 +0000 (01:46 +0000)]
conversion

Commit migrated from https://github.com/dotnet/coreclr/commit/b1f7195e26d8e0eb310515fe44d02883375c9ec3

5 years agoFix comment (dotnet/coreclr#23058)
Next Turn [Thu, 7 Mar 2019 02:26:51 +0000 (10:26 +0800)]
Fix comment (dotnet/coreclr#23058)

Commit migrated from https://github.com/dotnet/coreclr/commit/a8e9f22240cbd0ac75f119a05d92ccfb19342940