Implement [] and iteration for OCRepresentation

Multiple requests have come in to be able to access the contents
of OCRepresentation in an easier to use manner.  This fix allows
OCRepresentation to be indexed using the [] operator and also
be iterated in an STL compliant fashion.

Additionally, this adds more than 40 tests for this functionality

Change-Id: Ibfc4bc61493324e118c4a6b67efc1d66e8b66b04
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/116
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Improve usability of Group Interface API.

GetActionSetFromString function has memory leak.
So we fix memory leak and improve usability of the function.

We call two function, ExtractKeyValueFromRequest and BuildActionSetFromString
to extract key and value from requset and get ActionSet object from string.

Fix [IOT-283]

Change-Id: Ie13dcd0afc168632d9a53ad27182d15a55c3aca0
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/308
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added comment to the OCRepresentation fix

A build issue is seemingly causing a crash for the Android API
implementation, so the constructors/destructors were all placed
in the .h file.  This commit adds a comment explaining that to the
OCRepresentation code.

Change-Id: I22d0e2a374ea82165d0d7914ebfd2748b5f59c60
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/318
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Add external package management support

Some methods are added to manage external packages:
  'PrepareLib': checks the existence of an external library, if it
doesn't exist, calls the script user provided to download(if required)
and build the source code of the external library or notify user to
install the library.
  'Download': download package from specify URL
  'UnpackAll': unpack the package
  'Configure': execute specify script(configure, bootstrap etc)
  'InstallHeadFile': install head files
  'InstallLib': install library binaries(.so, .a etc)

Change-Id: Ibf3ef58abf8ba5a466b82a341bb6dce83d61726e
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/138
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Add missing LICENSE and NOTICE file to repository.

Change-Id: Ib47076ee53884cb4bd87cc822dff0437ca1deb9e
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/283
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Fred Cooper <fred.cooper@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

[SSM] Upload Tizen sample for 2.3 public sdk IDE

1. Change existing Tizen gbs sample app
   to using Tizen 2.3_rev1 IDE env

Change-Id: I12977bcd4de66d925f6e98f5382f1227d218c72c
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/313
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Adding OCRep destructor, various move activities

Apparently OCRepresentation's destructor was causing issues
in the JNI version.  Seemingly adding a virtual destructor to
the OCRepresentation is enough to cause this to go away.

Also adding move construction/assignment to our more expensive
types.

Change-Id: Icb3b6f25e268384b51126e18ec55fc5099c9b2f9
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/305
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

[SSM] Fix SSM Sample App to handle invalid input for app menu (IOT-290)

Modify SSM Linux Sample App to to prevent unexpected input values

Change-Id: Ic9de6e894a44a903f02d60f6eeaf0fa9035e0e5a
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/315
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[SSM] Cleanup JNI dead code and add NDEBUG definition

1. Cleanup JNI dead code
2. Add NDEBUG definition to SCONS script to prevent crash
   when assert

Change-Id: Ia4dc46548ce3bb0c9b4b28776e6c5f328444ab1a
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/314
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added lock logic in findResource callback for C++ samples

As part of Gerrit review #101,(83fed5a6c6b01d32de3e47c669652a1aa79ebb49)
there were changes required in other samples to prevent a crash in the
findResource callback.

Additionally, made minor correction in groupclient by changing
printf to cout in one of the function

Change-Id: I524f5d862c82011e5d008e686cc1d6e41ac3f170
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/126
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Added Vagrant config files that will create a build VM

As described in the tools/vagrant/README.md, Vagrant can use the
configuration provided in this commit to provision a build VM for building
IoTivity.

Change-Id: Ic2ae5a7bfc9e4274aa76be99a0807517f89c94b8
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/88
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Fix  problem  for multiple api call

It is thread issue. So, add lock mechanism.
Fix [IOT-263]

Change-Id: Ic0fac30b1a4c0c305af607e5caa7c1afd21163b6
Signed-off-by: Jack Lee <jjack.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/243
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix an exception handling issue in con-client app.

Though con-client app do not discover configuration,
diagnostics, and factorySet collection resources in
a network, the con-client app can be proceded.
And even when a response for any GET/PUT request indicates
a bad request, it is correctly delivered to the app.

Reference issue ID : [IOT-291]

Change-Id: Ic101013daa6efea9639295553022fd67f58c925e
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/271
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix infinite loop in GroupAction.

Fix infinite loop in FindAndDeleteActionSet function.

So we change the code.

Fix [IOT-282]

Change-Id: I23d3663ea32c5e56a456b013d4c697fcf0f886d2
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/286
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Altered the .gitignore to properly ignore unittest build biproducts

gitignore wasn't ignoring the gtest install and hippomocks installed
components.

Cleaned whitespace for the unittests makefile, which had tons of
trailing whitespace issues.

Change-Id: I10c4505ddf56df6d34e972553f93531132d53af3
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/280
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: William Dieter <william.r.dieter@intel.com>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Release notes for Feb 1st release

Change-Id: I046922a66eaa03b18482fb139986a439a49f568f
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/282
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix API of ThingsManger.

subscribeCollectionPresence and findCandidateResource are occurred exception or
no response(callback) while to combine resource type
when child resource doesn't have correct type name of resource.

In this case we don't combine the type of resource and
we will ignore.

Fix [IOT-289]

Change-Id: I59c48726a9738e34d6c5561b59a2cdda243168ec
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/277
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

[SSM] Add android sample and fix jni issues.

1. Add android sample application
2. Fix jni issues that mismatch of package name
   and Android-L jni callback issue
3. Fix scons script to build for creating SSM so file.

Change-Id: Ief192a96f6d97fd2ac4ad47b3e7d9029d964f2f6
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/278
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Apply the 'CA_INT' of Connectivity Abstraction for Things Manager.

The Thing Manager does not prepare for the CA.
So we provide different function of CA in the same API.

Change-Id: I8b64608e352a19fddedf42beef647003d18e61f8
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/244
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add API description of Things Manager.

joinGroup and findGroup function call were ambiguous
when join to a local(or remote) resource.
We provide more detail description of function for the user.

Fix [IOT-265],[IOT-267]

Change-Id: I43de1f6671dc73d0725bdc9c0e85ffca45878d2e
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

example: link to libraries using -L flag

executable will be able to load them
from standard paths (/usr/lib*/)

Change-Id: I0728c196b766ce55e7185dffb69d9790b5b065c5
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/246
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Resolved Klocwork warnings for C++ Stack & Samples

Fixed comment, space issue and added default case to switch in
groupclient.cpp

Made code compliance to code guideline

Resolve Infinite loop warning and Memory leak warning.
Also replaced multiple if-else with switch to match code
standards.

Change-Id: I125ab9d20fe4c8352f261afa7a538a7487aa7880
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added support in tinyDTLS to support rehandshake

As per RFC 6347 section 4.2.8, DTLS Server should support requests
from clients who have silently abandoned the existing association
and initiated a new handshake request by sending a ClientHello.
Code is updated to detect this scenario and delete the old
association when client successfully responds to HelloVerifyRequest.

Change-Id: I6e256921215c1a22e9e5013499c4dfd98659f8cc
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/120
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix FindGroup API of Things Manager about group sync feature.

It is not notify about state of finding to caller.
So we will return 'OC_STACK_ERROR' when It was finding a group.
User should be wait findCallback.
Then user will know the result of finding.

FindCallback has the argument which OCResource.
If it is NULL we could not find a group.

Fix [IOT-286]

Change-Id: I2b95d5102e54e4242394c36d51de81f192b87e13
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/230
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix GroupSync API of about GroupSync of Group feature.

Crash is occured when som api of ThingsManager is called multiple times.

Fix [IOT-261], [IOT-264], [IOT-268]

Change-Id: Iec1cb11c570357411351c69450ace91ea6fa3754
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/228
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[SSM] Fix issue about initializing SSM with invalid parameter (IOT-260)

Modify SoftSensorManager to return error code when initialized with invalid parameter

Change-Id: Ia0a54cd6e71321cbe2b4fd18352a2a609c20fabd
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fixed issue to pass PSK identity hint to application in callback

In cases (with PSK ciphersuite) where Server is sending
'PSK Identity Hint’ inside ServerKeyExchange message, DTLS library
is not passing the ‘identity hint’ inside ‘desc’ argument in
get_psk_info(DTLS_PSK_KEY, desc) callback. Instead, ‘desc’ contains
the identity of the client itself. The reason for this is that the
code inside dtls_send_client_key_exchange() method
overwrites the ‘identity hint’ received earlier.

Change-Id: Ibf447e3a6b33284118908a52aed4cf636038ab23
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/119
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Resolve Bug IOT-273 (rename "OC_STACK_REPEATED_REQUEST")

 - OCStackResult "OC_STACK_REPEATED_REQUEST" is renamed to
   "OC_STACK_DUPLICATE_REQUEST"
 - In StringConstants.h, "REPEATE_REQUEST" is rename to
   "DUPLICATE_REQUEST" (Message string also changed)

Change-Id: Ie3bca4642441a59c3c66a98513d0f15d2e923096
Signed-off-by: ywsung <yw.sung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed crash on rec'd invalid data.

This issue is a fix for IOT 114.

Previously, a bad series of JSON coming in would cause an exception
to be thrown. this would result in the callback/server crashing, which
is not appropriate behavior. This fix catches and logs any JSON
errors keeping the callback/server from crashing.

NOTE: This changeset is originally from 01.org(changeset 695,
author: Erich Keane).

Change-Id: I1e7d042f243bc1b86771778c308f1187bcda875f
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/103
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Enable Building C++ samples using Scons

Change-Id: I4ebcee826bcd6f1afdea88038cd0ce340b209103
Signed-off-by: omkar <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/161
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

tizen: packaging: build on x86_64 arm64 and others too

Without this change only 2 arch were possible to build :
arm and x86 (32bits)

Since some scon's variables are not aligned with Tizen's infra name,
mapping is needed for x86 amd arm64.

While for x86_64 it can use the generic RPM macro %{_arch} value
which is same, it prevents writing an extra "if endif block".

Other unsuported arch were not tested (ie: mips, ppc ...)
and would  probably need more sources or make/scon/files adaptations.

With a couple of other fixes (to come later),
rpmbuild was successful using Tizen:Common's repos
with those archs : x86, x86_64, armv7l, aarch64.

Feel free to me ask support upstream or on tizen trackers

Change-Id: I1034d66ac29bee1667a7e12d6ceb9e08806c3a15
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Merge "Add missing enum value of OCStackResult to switch in reason() function of OCException class"

Merge "Improve usability of ActionSet for Group Action Feature."

Added release notes for Jan 17th release

Change-Id: I62b1457e8a35082f7896fb5d64630a173c59f233
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>

Merge "Fix zeroing of OCServerResponse payload array"

Merge "Remove OCICUC from build and repo"

Merge "Enable building C Samples using scons"

Add missing enum value of OCStackResult to switch in reason() function of OCException class

- Adding missing case of enum value (OC_STACK_REPEATED_REQUEST, OC_STACK_INVALID_DEVICE_INFO) to switch statement
- Adding constant strings to StringContant.h
- Reorder case statements by OCStackResult definition order

Change-Id: I207a2f9122779c37df48aae260061fce442de798
Signed-off-by: ywsung <yw.sung@samsung.com>

Enable building C Samples using scons

Change-Id: I9de4f80a0abe0cd1da14b2abb063e3deda928cba
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Signed-off-by: Caiwen Zhang <caiwen.zhang@intel.com>

Improve usability of ActionSet for Group Action Feature.

ActionSet structure is not show directly to developer.
Because there is the definition of ActionSet in GroupManager.h.
So we separate the definition of ActionSet from Groupmanager to ActionSet.h
And it is exposed to developer by one type of header file.

Change-Id: I2ccb93cf70ec42b122aaead4943aed56df161641
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>

Remove OCICUC from build and repo

The OCICUC library isn't properly being maintained and isn't really being
used, so it is being removed.

Signed-off-by: Erich Keane <erich.keane@intel.com>
Change-Id: I613072d5256fd53c6d7ef179cd971356caf18d41

Merge "Remove high frequency log to avoid the log full with useless information"

Merge "Adding tinyDTLS into iotivity repo"

Merge "Reduce footprint by using string literals."

Merge "Changed OCStackResult to be consistent across compile flags."

Fix zeroing of OCServerResponse payload array

Change-Id: I93ba1720a3de0c54937d5d8d48d72574b2dbb65d
Signed-off-by: Maks Naumov <maksqwe1@ukr.net>

Changed OCStackResult to be consistent across compile flags.

Issue 245 was reported that pointed out that the presence flag in
the compiler makes OCStackResult incompatible across differently
compiled versions of the CStack.  Additionally, this spaces out the
error codes from success codes, permitting additional room for more
success codes.

Change-Id: Ia93f34e23756e7663ea80f6667699d59e358058e
Signed-off-by: Erich Keane <erich.keane@intel.com>

Merge "Update gitignore."

Add method of Things-Manager.

It was not included implementation.
So We implement about bindResourceToGroup for Group Formation feature.

Change-Id: Iade53004d8b3d974846a3b9056c6c3b6649104fa
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>

Merge "Fix Memory leak of getResourceType() in ocstack.c"

Remove high frequency log to avoid the log full with useless information

The OCProcess function is invoked in while loop. The functions that are
invoked by OCProcess will be invoked very frequently. If add log in these
functions, it may make the log full of useless information.

This patch removes frequent log from OCProcess/OCProcessPresence/
OCProcessCoAP/coap_read/OCRecvFrom function.

Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Change-Id: Iabe182aca8430438085296cd16d69f5bde0626a8

Reduce footprint by using string literals.

This change replaces the std::string based exception description
string constants in resource/include/StringConstants.h with
string literals instead.  Switching to string literals has a number of
advantages in this case:

- reduced start-up time for binaries that link against liboc
  since the static std::string constants no longer have to
  be initialized at run-time.
- the compiler is free to place the strings in read-only
  memory.
- reduced static and run-time footprint.

Footprint reductions in text, data and bss are as follows:

filename                        text
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   81458   77684   -3774   -4.63%
InProcServerWrapper.o   43292   40122   -3170   -7.32%
OCException.o           5399    1956    -3443   -63.77%
OCPlatform_impl.o       25054   21803   -3251   -12.98%
OCPlatform.o            9574    5535    -4039   -42.19%
OCRepresentation.o      97156   93782   -3374   -3.47%
OCResource.o            28565   25048   -3517   -12.31%
OCUtilities.o           19844   15805   -4039   -20.35%
liboc.so                453688  434400  -19288  -4.25%

filename                        data
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   1916    1916    0       0.00%
InProcServerWrapper.o   1368    1368    0       0.00%
OCException.o           4       4       0       0.00%
OCPlatform_impl.o       552     552     0       0.00%
OCPlatform.o            8       8       0       0.00%
OCRepresentation.o      388     388     0       0.00%
OCResource.o            100     100     0       0.00%
OCUtilities.o           344     344     0       0.00%
liboc.so                6636    6652    16      0.24%

filename                        bss
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   577     309     -268    -46.45%
InProcServerWrapper.o   657     389     -268    -40.79%
OCException.o           320     52      -268    -83.75%
OCPlatform_impl.o       420     152     -268    -63.81%
OCPlatform.o            340     72      -268    -78.82%
OCRepresentation.o      328     60      -268    -81.71%
OCResource.o            340     72      -268    -78.82%
OCUtilities.o           340     72      -268    -78.82%
liboc.so                3340    1192    -2148   -64.31%

filename                        dec
                        std::   const
                        string  char[]  Diff    Change
InProcClientWrapper.o   83951   79909   -4042   -4.81%
InProcServerWrapper.o   45317   41879   -3438   -7.59%
OCException.o           5723    2012    -3711   -64.84%
OCPlatform_impl.o       26026   22507   -3519   -13.52%
OCPlatform.o            9922    5615    -4307   -43.41%
OCRepresentation.o      97872   94230   -3642   -3.72%
OCResource.o            29005   25220   -3785   -13.05%
OCUtilities.o           20528   16221   -4307   -20.98%
liboc.so                463664  442244  -21420  -4.62%

Overall liboc.so drops in size by 20 kilobytes, a 4.62%
reduction in size with these changes in place.

Change-Id: I3e24f56bf702a0ea134b113d542f61e45f8af613
Signed-off-by: Ossama Othman <ossama.othman@intel.com>

Merge "Fixed seg fault in simpleclient sample app (Bug IOT-130)"

Merge "Added style formatting config files for iotivity coding standards"

Merge "Fixed InProcServerWrapper to be thread safe"

Merge "Fixed simpleclient crash caused by curResource being altered"

Fixed InProcServerWrapper to be thread safe

A few of the variables/collections in the server wrapper were not
properly protected against multi-threading.  This fix adds a mutex
to the class to ensure that all accessed items are protected.
Additionally, they are moved out of the root namespace to prevent
polution.

Change-Id: I2eedb9bf9b1960ff7a018a2ca1e15183e42bd9cd
Signed-off-by: Erich Keane <erich.keane@intel.com>

Merge "Fix failed unit tests for CSDK stack."

Merge "C++ Avoid crash in case of Invalid/Empty Payload"

Fix failed unit tests for CSDK stack.

The existing unit tests in stacktests.cpp had not kept up with
ongoing modifications to the C API.  Modified failing tests to
align with latest C API functionality.

Also modified to remove limitation that required the eth0 network
interface to be available on the test machine.  If eth0 was not
available, some tests would fail.

Also added a local function to handle C stack initialization and
modified tests to call this function.  Added local functions to
intialize the number of expected resources and resource index
depending on whether presence is defined.

Re-grouped related test cases and created common group test names.

Change-Id: Ief59854d762ef9837f8b1d5b95bebc6514bd545a
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>

Fix Memory leak of getResourceType() in ocstack.c

When memory allocation is failed, add free memory for already allocated memory.

Change-Id: I601367e7bfe3ff6a616d870636d5b535a32047fd
Signed-off-by: YW Sung <yw.sung@samsung.com>

Change the definition of GROUP_INTERFACE.

The definition of GROUP_INTERFACE as "oc.mi.c"
does not get big meaning.
So, we change the definition to "oc.mi.grp".
Regarding opinion of Caiwen.

Issue : [IOT-253]

Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Change-Id: Ia196e8a2a0856ed0651874eec419f77468e8329e

Merge "Fixed invalid memory read, removed dead code"

Merge "Adding OK Response Code for POST"

Merge "Fixing repeated EH calls when client retransmits requests"

C++ Avoid crash in case of Invalid/Empty Payload

This change is based on a bug reported by SHP wherein
they want to be able to send response with empty payload.
Instead of throwing an error, we now send an empty
OCRepresentation() object to the client callback.

Change-Id: I16f298bf8a0bdbb545e1133d751582f418991352
Signed-off-by: omkar <omkar.m.hegde@intel.com>

Added style formatting config files for iotivity coding standards

The style config files are used to apply IoTivity coding style, as
described on the wiki https://wiki.iotivity.org/iotivity_coding_standards.

Change-Id: Ifd3937bebde658a76aa7c9918b4c699c1384f341
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Signed-off-by: Ossama Othman <ossama.othman@intel.com>

Adding tinyDTLS into iotivity repo

Picked GIT commit id 7d039c from
http://sourceforge.net/projects/tinydtls/ .

iotivity build system can compile tinydtls using autotools
with below steps:
1)autoconf
2)./configure --without-debug --without-ecc 'CFLAGS=-fPIC'
3)make

Change-Id: I97a917955ca13a06914ecee178c0cee0701eda12
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>

Removed executable bit from non-executable files.

Change-Id: Ifa125423fb435575e391471cc7dafe3f1bd84972
Signed-off-by: Ossama Othman <ossama.othman@intel.com>

Merge "Add quick guide into the readme"

[SSM] Fix issues about initializing SSM

1. modify to return error code when xml parsing error occurs
2. apply new SSM Interface
3. modify sample apps according to the new interface design
4. modify ResourceFinder to stop checking presence when SSM terminates

Change-Id: Id5cd6aade44fe531cb547400d15bb343ba28655a
Signed-off-by: Minji Park <minjii.park@samsung.com>

Merge changes I5acd9c57,I90e7a69e

* changes:
  [SSM] Fix context query parser issues
  [SSM] Add omitted arduino sample and soft sensor sample

[PPM] fix Plugin Manager Destructor segment fault.

1. Modify PluginManager Destructor.
2. Remove "free(handle)" and add "dlclose(handle)".

Change-Id: Ib2fc492631914664eac76d0db0d78126e1cefd95
Signed-off-by: junho13.lee <junho13.lee@samsung.com>

[SSM] Fix context query parser issues

This patch resolves issues that related to context query

which occures infinite loop and crash

Change-Id: I5acd9c57ee82a7ba1d3a5a416680a23676acfabb
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>

[SSM] Add omitted arduino sample and soft sensor sample

1. Add omitted arduino sample app
2. Modify previous arduino sample to use proper resource name
3. Add IndoorTrajectory Soft Sensor

Change-Id: I90e7a69ef203d3f57e8350f73ffa47039f883878
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>

Adding OK Response Code for POST

Earlier, we were setting response code for POST only if a new resource
is created assuming that the value is by default OK.
TE tests showed error on using different version of Ubuntu.
Modified simpleserver to explicitly add OK status.
Added constructors to OCResourceRequest and
OCResourceResponse classes to avoid undefined behavior.
This Fixes IOT-128.

Change-Id: I13faff2fb254c777ccc8c8979824d53f5111ab3e
Signed-off-by: omkar <omkar.m.hegde@intel.com>

Fixed simpleclient crash caused by curResource being altered

The foundResource function is called asynchronously, and was written
in a way that was not thread safe. This fix adds a lock and exit logic
so that it works prooperly and only uses the first found curResource
that matches its requirements.

NOTE: This change (author: Erich Keane) is from 01.org.

Change-Id: I984ce1623ff491713ecf5d621f1283ebad33bfef
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>

Update gitignore.

Change-Id: Ie3f1c5a6b6d2c1e8b7d9df6336eea9083597b697
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>

Merge "Add C++ Unit tests"

Fixing repeated EH calls when client retransmits requests

(Bug IOT-239) When a client makes a request to a slow resource
and it does not receive an ACK for that request, it retransmits
the requests which resulted in calling the server's entity handler
several times and multilpe slow responses. When a server
detects a repeated request it should not process it. Also, when
the client receives a slow response it should stop retransmitting
requests.

Change-Id: I101ad3de9b8e0e4990fb096d4a8fe5b9dcebf4b0
Signed-off-by: Yamin Al-Mousa <yamin.s.al-mousa@intel.com>

Fixed invalid memory read, removed dead code

Debug.c's coap_print_addr had its functionality completely removed
in the past.  However, this resulted in returning SOMETHING (not zero!)
despite not actually correctly writing to the addr parameter.

Since this parameter is uninitialized when sent to this function,
and the return value is used to determine whether it correctly added
info to the addr, the debug print following this (net.c:972) attempted
to read the uninitialized data, potentially causing memory corruption.

This fix removes the 'dead' code, then returns a zero (failure, nothing
written).

Change-Id: If4f2c131d9b2f585299363f21c3686c25de29104
Signed-off-by: Erich Keane <erich.keane@intel.com>

Merge "Fixing OCCancel with High_QOS in observe isn't deleting CB."

Fixing OCCancel with High_QOS in observe isn't deleting CB.

(Bug IOT-126) Calling OCCancel should result in deleting all
associated structures including callbacks. This also should
happen when we deregister observation.

Change-Id: I34dd67288873ce27919a12a1d5fe244ef80751b7
Signed-off-by: Yamin Al-Mousa <yamin.s.al-mousa@intel.com>

Add C++ Unit tests

Added unit tests for OCPlatform and OCResource C++ APIs.
All tests are passing

Change-Id: Ib31295db92ad3934dec1ea32e59315cea8fff2a8
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>

Merge "Removing getting started and how to guides from API references."

Removing getting started and how to guides from API references.

Developer content will be available on iotivity.org going forward, so
there is no need for these files in the API docs code. Direct links were
added to the Home.txt for the iotivity.org/documentation and
wiki.iotivity.org sites.

IOT-218 - Removed the "M1 release" text in title from Doxygen output
IOT-219 - Remove "About OIC" , "Programmer's guide" and "how to"

Change-Id: I28e26328a82cb6ff037ce451a5ed6fee368ad635
Signed-off-by: mshaver <michael.r.shaver@intel.com>

Merge "Fix some issues of GroupSynchronization  - findGroup() with null callback parameter issue is fixed.    : return OC_STACK_ERROR, when callback parameter is passed with a null value.  - joinGroup() failure when there is no group match with group type parameter is fixed.  - deleteGroup() failure when delete group with no child is fixed."

Add quick guide into the readme

Change-Id: I502acfebf6a4752bf2ffa57d05dc31e8eac65959
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>

Fix some issues of GroupSynchronization
- findGroup() with null callback parameter issue is fixed.
  : return OC_STACK_ERROR, when callback parameter is passed with a null value.
- joinGroup() failure when there is no group match with group type parameter is fixed.
- deleteGroup() failure when delete group with no child is fixed.

Erase "else" statement for guard condition in findCallback NULL checking.

Change-Id: Id00160e3b2e85e03c4e4dd5bd5fb401f6a8bbd42
Signed-off-by: Soyoung Youn <sy01.youn@samsung.com>

Add missing dependency to readme.

Change-Id: I86cf5280edbe70dfa5c8f0076c9475ee18e5ab0b
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>

Fixed seg fault in simpleclient sample app (Bug IOT-130)

Arduino server sample uses light representation which is different
from what simpleclient expects. Updated simpleclient to catch
exception in this scenario.

Change-Id: I3d5d2e2f7785a9345655bc347662efb7fd0927a2
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>

Merge "Fix some issues of GroupManager"

fix "Coding convention followed in this commit"

Change-Id: Icf3085cc5767330c908ab02c855759ad004509a2
Signed-off-by: Heewon Park <h_w.park@samsung.com>

Fix some issues of GroupManager

    - subscribeCollectionPresence()
        - IOT-197 : Handle null parameter
        - IOT-198 : Check that resource has child resource.
    - findCandidateResources()
        - IOT-210 : Handle null parameter

Change-Id: I6961aa776e5883890da226f07d3cfcf64571279c
Signed-off-by: Jack Lee <jjack.lee@samsung.com>

Merge "This a complete version of OICMiddle. The ReST capability has limited functionality, which we hope to expand shortly after release.  We believe the other parts of OICMiddle are sufficiently robust that the application will be useful as both demo and example in the OIC 0.9.0 release."

This a complete version of OICMiddle.
The ReST capability has limited functionality, which we hope to expand
shortly after release.  We believe the other parts of OICMiddle are
sufficiently robust that the application will be useful as both demo
and example in the OIC 0.9.0 release.

In a partial review prior to moving from 01.org to IoTivity, one
reviewer provided 50 comments.  All of the comments were addressed,
though not all were agreed with.  In some cases, comments were added
to the code to address the concern.  Others may require further
discussion.

Change-Id: I3e52de09a0737dd8dd0323fa2a20e4c94224f9c7
Signed-off-by: John.Light <john.j.light@intel.com>
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Merge "Updated the README files to reference the master build in root"

Updated the README files to reference the master build in root

Change-Id: Ibeb95e7a872ca51e29656a825c37247e48d89fe5
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>

Merge "Android SDK - Initial commit and build system updates"

Android SDK - Initial commit and build system updates

This commit add makes the auto_build process more complete by
adding the following:

1) Auto build now always performs the dependency check
2) Auto build now always attempts to build the Android stack artifacts.
3) Transitioned the Android build process to the v4.9 tool chain
4) Android build now depends on the internal boost dependencies
5) Add an Android compatibility layer for the code that is using
   the C++ 11 basic string functions with is not supported in the
   Android toolchain yet.
6) Added static libraries to many of the shared libraries for the
   Android SDK

NOTE:
a) This commit conflicts with the work that Caiwen was making in the
   C++11 basic_string function compatibility. I will close with him.
b) Expat is needed by the protocol plug in manager for Android.
   This still needs to be closed by release. The PPM build for
   Android under SCONS is currently disabled.

This is the Android SDK client API.
Validation has not been completed. However, this is all new
functionality and does not have any negative impact on any
existing features. Until validation is completed this
functionality should be considered experimental.

This code based currently uses gradle to build the SDK.
It does require that the Android libraries for IoTivity
be built previously using the appropriate SCONS scripts.

This additional patch attempts to transition the boost
build to using git instead of a download in hopes that
the build machine will be happier about it.

Final patch makes Android build optional in auto_build

Another patch to add support for 64-bit hosts

Another patch set to reduce parallel builds to 4

Another patch to add licensing header to two files that we missing
in gerrit review #72

Change-Id: I9695ebf3ea271ec28b69a4fcec509a6c2b7c46a4
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>