platform/core/csapi/xsf.git
5 years agomultithreaded droid os calls during startup (#8245)
kingces95 [Thu, 31 Oct 2019 17:10:59 +0000 (07:10 -1000)]
multithreaded droid os calls during startup (#8245)

5 years agoCheck for ValueType items to perform equals (#8299)
Glenn Versweyveld [Thu, 31 Oct 2019 10:37:35 +0000 (11:37 +0100)]
Check for ValueType items to perform equals (#8299)

5 years agomacOS: Fixed IsPresented PopOver (#8312)
Johann Weiher [Thu, 31 Oct 2019 10:35:09 +0000 (11:35 +0100)]
macOS: Fixed IsPresented PopOver (#8312)

#3149

5 years agoFixed - 5830 - Updated access modifier for EntryCellTableViewCell (#8286) fixes ...
Durgesh Khandal [Wed, 30 Oct 2019 12:33:05 +0000 (18:03 +0530)]
Fixed - 5830 - Updated access modifier for EntryCellTableViewCell (#8286) fixes #5830

5 years agoMerge branch '4.4.0'
Rui Marinho [Tue, 29 Oct 2019 23:51:51 +0000 (23:51 +0000)]
Merge branch '4.4.0'

5 years agoMerge branch '4.3.0' into 4.4.0
Rui Marinho [Tue, 29 Oct 2019 23:50:57 +0000 (23:50 +0000)]
Merge branch '4.3.0' into 4.4.0

5 years agoAdd ListViewHeaderItemMinHeight override in UWP resources.xaml (#8010)
Glenn Versweyveld [Tue, 29 Oct 2019 17:07:59 +0000 (18:07 +0100)]
Add ListViewHeaderItemMinHeight override in UWP resources.xaml (#8010)

* Add ListViewHeaderItemMinHeight override in UWP resources.xaml

* Amend csproj

5 years ago[C] Parent the ImageSource (#8063)
Stephane Delcroix [Tue, 29 Oct 2019 17:06:35 +0000 (18:06 +0100)]
[C] Parent the ImageSource (#8063)

* [C] Parent the ImageSource

Properly parent the imagesource, instead of only setting the inherited context.
Allows proper propagation of DynamicResources and Styles

- fixes #6996

* fix merge

:bell: shame!

5 years agoiOS: Frame with HasShadow set to true and BackgroundColor alpha < 1 casts shadow...
Pieter Nijs [Tue, 29 Oct 2019 14:09:19 +0000 (15:09 +0100)]
iOS: Frame with HasShadow set to true and BackgroundColor alpha < 1 casts shadow on all child views (#7518)

* Updated renderer with additional ShadowView

* Added buttons to test some behavior

* ShadowLayer background color tweaks

* Resolved flawed merge, restored _Template page

* Apply suggestions from code review

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Added more descriptive issue Title

* Updated Issue5108.xml's properties

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

Fixed missing closing tags

* Updated projitems

* Removed eventhandlers from XAML

* Update Issue5108.xaml.cs

Added eventhandlers in code + surrounded code-behind with APP preprocessor directive to avoid issues when building for UITEST

5 years ago[Android] Make sure we use the right Context (#8196)
Rui Marinho [Tue, 29 Oct 2019 13:08:11 +0000 (13:08 +0000)]
[Android] Make sure we use the right Context (#8196)

5 years ago[macOS] Visual glitch when exiting the full screen with ScrollViewer (#8086) fixes...
Sławomir Kulików [Tue, 29 Oct 2019 12:19:49 +0000 (13:19 +0100)]
[macOS] Visual glitch when exiting the full screen with ScrollViewer (#8086) fixes #4854

* added test for issue4854

* fix issue4854

5 years ago[Android] Fixed issue refreshing CollectionView using ScrollView inside DataTemplate...
Javier Suárez Ruiz [Tue, 29 Oct 2019 11:31:39 +0000 (12:31 +0100)]
[Android] Fixed issue refreshing CollectionView using ScrollView inside DataTemplate (#8224) fixes #8198

* Fixed issue 8198 - ScrollView at CollectionView at RefreshView always leads to Pull-To-Refresh

* Added instructions to the Issue8198

* Added support for WebView on Android to align functionality with iOS

* Added more RefreshView Core Gallery samples

* Updated new samples

* Updated instructions text

5 years ago[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145
Samantha Houts [Tue, 29 Oct 2019 11:18:34 +0000 (04:18 -0700)]
[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145

* Add test case for issue 8145

* [Android] Don't double dispose the more sheet

fixes #8145

5 years agoFixed 5680 - Added method to force value coercion (#8097)
Durgesh Khandal [Tue, 29 Oct 2019 10:35:04 +0000 (16:05 +0530)]
Fixed 5680 - Added method to force value coercion (#8097)

5 years agoBetter detect IsCollapsed state/changes on master (#8181)
Shane Neuville [Tue, 29 Oct 2019 00:42:11 +0000 (18:42 -0600)]
Better detect IsCollapsed state/changes on master (#8181)

5 years ago[UWP] Delay RequestRefresh until Loaded (#8190)
Shane Neuville [Tue, 29 Oct 2019 00:41:14 +0000 (18:41 -0600)]
[UWP] Delay RequestRefresh until Loaded (#8190)

fixes #8186

5 years agoOccasionally clean up WeakReferences in Styles whose targets have been collected...
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)

5 years agoFix unbalanced profiler push/pop (#8213)
kingces95 [Mon, 28 Oct 2019 22:37:49 +0000 (12:37 -1000)]
Fix unbalanced profiler push/pop (#8213)

5 years ago[X] resolve indexers on generic types (#8226)
Stephane Delcroix [Mon, 28 Oct 2019 18:25:35 +0000 (19:25 +0100)]
[X] resolve indexers on generic types (#8226)

The lovely #7837 is trying to be smarter at identifying which indexer to invoke,
by checking the parametertype. Of course, it wasn't tested on generic types...

So this is definitely a regression, I apologize for it.

- fixes #8221

5 years agoScrolled event implemented (#8197)
melimion [Mon, 28 Oct 2019 18:24:00 +0000 (21:24 +0300)]
Scrolled event implemented (#8197)

5 years agoFix Flyout behavior so it propagates from templated Content Page once it's created...
Shane Neuville [Mon, 28 Oct 2019 17:26:55 +0000 (11:26 -0600)]
Fix Flyout behavior so it propagates from templated Content Page once it's created (#8135) fixes #7985

* Centralize SendAppearanceChanged call

* - Appearance Change UI tests

* - remove extra button and add better messaging

* - make sure there is space to swipe

* - fix rebase

* - only call appearance change if display page changes

* - process appearance changes before page has fully popped

5 years agoMerge branch '4.4.0'
Rui Marinho [Mon, 28 Oct 2019 12:40:41 +0000 (12:40 +0000)]
Merge branch '4.4.0'

5 years ago[Build] Remove duplicated compile items
Rui Marinho [Mon, 28 Oct 2019 12:21:29 +0000 (12:21 +0000)]
[Build] Remove duplicated compile items

5 years ago[Build] Fix merge
Rui Marinho [Mon, 28 Oct 2019 11:42:23 +0000 (11:42 +0000)]
[Build] Fix merge

5 years agoMerge branch '4.4.0'
Rui Marinho [Mon, 28 Oct 2019 11:19:17 +0000 (11:19 +0000)]
Merge branch '4.4.0'

5 years agoMerge 4.3.0 to 4.4.0
Rui Marinho [Mon, 28 Oct 2019 11:18:20 +0000 (11:18 +0000)]
Merge 4.3.0 to 4.4.0

5 years agoFix Bug 7396 - Shell: Setting Shell.BackgroundColor overrides all colors of TabBar...
Felipe Baltazar [Fri, 25 Oct 2019 22:39:48 +0000 (19:39 -0300)]
Fix Bug 7396 - Shell: Setting Shell.BackgroundColor overrides all colors of TabBar (#7962)

* Fix to bottom tabbar icon/text color 🐛

* Code review ♻

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7396.cs

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
5 years agoLet UICollectionViewCell handle state itself (#7884)
Glenn Versweyveld [Fri, 25 Oct 2019 22:35:41 +0000 (00:35 +0200)]
Let UICollectionViewCell handle state itself (#7884)

Fixes #7416

5 years agoDisable packager in iOS ItemsViewRenderer (#8189)
E.Z. Hart [Fri, 25 Oct 2019 22:25:22 +0000 (16:25 -0600)]
Disable packager in iOS ItemsViewRenderer (#8189)

* fix collectionview renderering weirdness

* add ui test

* include in projitems

* Disable the VisualElementPackager for the ItemsView

5 years agoStore references to local variable so it's not collected (#8205)
Shane Neuville [Fri, 25 Oct 2019 14:38:53 +0000 (08:38 -0600)]
Store references to local variable so it's not collected (#8205)

5 years agoiOS Cell default bgcolor to transparent (#7903) fixes #7680 fixes #7850
Gerald Versluis [Fri, 25 Oct 2019 14:07:07 +0000 (16:07 +0200)]
iOS Cell default bgcolor to transparent (#7903) fixes #7680 fixes #7850

* Update CellRenderer.cs

* Update CellRenderer.cs

* Update CellRenderer.cs

5 years agouse support libs for DrawableWrapper (#8106) fixes #6291
Alan Grgic [Fri, 25 Oct 2019 11:37:46 +0000 (06:37 -0500)]
use support libs for DrawableWrapper (#8106) fixes #6291

5 years agoUpdate GitInfo.txt
Samantha Houts [Thu, 24 Oct 2019 23:25:50 +0000 (16:25 -0700)]
Update GitInfo.txt

5 years agoforeground color fix (#8149)
melimion [Thu, 24 Oct 2019 18:24:51 +0000 (21:24 +0300)]
foreground color fix (#8149)

fixes #8148

5 years agoOccasionally clean up WeakReferences in Styles whose targets have been collected...
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)

5 years agoRebase and Clean Up (#8107)
Brian Macomber [Thu, 24 Oct 2019 10:11:24 +0000 (05:11 -0500)]
Rebase and Clean Up (#8107)

5 years agoAdded instructions and changed the test for Issue2241 (#8080) fixes #2274
adrianknight89 [Thu, 24 Oct 2019 09:56:06 +0000 (04:56 -0500)]
Added instructions and changed the test for Issue2241 (#8080) fixes #2274

* added instructions

* cache old centerY

* Revert "cache old centerY"

This reverts commit cd75d74654d23359cf3ab72d601cb4109a94cda0.

5 years agoSet correct MinWidth for CheckBox style (#7978)
Glenn Versweyveld [Thu, 24 Oct 2019 09:50:46 +0000 (11:50 +0200)]
Set correct MinWidth for CheckBox style (#7978)

Fixes #7048

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

5 years ago[Android] Null checks (#7941) fixes #7939
Gerald Versluis [Thu, 24 Oct 2019 09:43:27 +0000 (11:43 +0200)]
[Android] Null checks (#7941) fixes #7939

5 years agoFix bug 7581 - UWP Map not moving to location when map hidden then shown (#7960)
Konrad Müller [Thu, 24 Oct 2019 07:49:25 +0000 (09:49 +0200)]
Fix bug 7581 - UWP Map not moving to location when map hidden then shown (#7960)

* Add repro

* Set region on layout when move to region failed before

5 years ago[Enhancement] Batch updates via "using" statement (#7807)
Andrei [Thu, 24 Oct 2019 00:27:09 +0000 (03:27 +0300)]
[Enhancement] Batch updates via "using" statement (#7807)

* Added batch object

* updated unit tests

5 years ago[iOS] Fix iOS ScrollToAsync not completing when scrolling to current location (#7979)
Oliver Brown [Wed, 23 Oct 2019 23:09:55 +0000 (00:09 +0100)]
[iOS] Fix iOS ScrollToAsync not completing when scrolling to current location (#7979)

* Add test case for scroll completed.

* Check iOS scrollview for scrolling to the same place.
fixes #7972

5 years agoRevert "[GTK] Fix visibility of hidden pages in the stack (#3904) (#8096)
Andres G. Aragoneses [Wed, 23 Oct 2019 23:02:59 +0000 (07:02 +0800)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#3904) (#8096)

* Revert "[GTK] Fix visibility of hidden pages in the stack (#3904)"

This reverts commit b5b9404bda761e7e5941da7ff26f1d42dd62d1b2.

# Conflicts:
# Xamarin.Forms.Platform.GTK/Controls/Page.cs

* Added test sample for #6663
Fixes #6663

5 years ago[macOs] implements Frame CornerRadius (#8168)
melimion [Wed, 23 Oct 2019 23:01:52 +0000 (02:01 +0300)]
[macOs] implements Frame CornerRadius (#8168)

* implement CornerRadius in FrameRenderer

* add CornerRadius to FrameCoreGalleryPage

* CornerRadius added to Frame enum in TestAttributes

5 years ago[Android] Fix Material button renderer setbackgroundcolor (#8089) fixes #5747 fixes...
Ravinder Jangra [Wed, 23 Oct 2019 18:50:10 +0000 (00:20 +0530)]
[Android] Fix Material button renderer setbackgroundcolor (#8089) fixes #5747 fixes #7002

5 years agoFix System.OverflowException for Hsl with double in invariant string (#8114) fixes...
Bohdan Benetskyi [Wed, 23 Oct 2019 18:22:27 +0000 (20:22 +0200)]
Fix System.OverflowException for Hsl with double in invariant string (#8114) fixes #8113

5 years agoAdding instructions to the UI Test (issue #38770) (#8062)
Mikolaj Kieres [Wed, 23 Oct 2019 18:06:24 +0000 (05:06 +1100)]
Adding instructions to the UI Test (issue #38770) (#8062)

5 years agoFix android scrollbar visibility issue (#8090) fixes #7629 #8015
Ravinder Jangra [Wed, 23 Oct 2019 12:07:00 +0000 (17:37 +0530)]
Fix android scrollbar visibility issue (#8090) fixes #7629 #8015

5 years agoDon't force the Master page closed on disappear if it's set to always visible (#8164)
Shane Neuville [Wed, 23 Oct 2019 10:37:02 +0000 (04:37 -0600)]
Don't force the Master page closed on disappear if it's set to always visible (#8164)

* Don't force master closed when on split

* - fix UI tests to correctly test for tablet

* - remove extra code

* - fix issue with rotation from Modal

5 years agoAutomating bugzilla issue 33870 (#7968)
Mikolaj Kieres [Wed, 23 Oct 2019 08:15:16 +0000 (19:15 +1100)]
Automating bugzilla issue 33870 (#7968)

* Automating bugzilla issue #33870

* Adding UITest category

* Fixing a typo

5 years agoIn Android : Reverse layout only when default layout direction is the… (#7809)
Elashi [Tue, 22 Oct 2019 16:50:36 +0000 (19:50 +0300)]
In Android : Reverse layout only when default layout direction is the… (#7809)

* In Android : Reverse layout only when default layout direction is the opposite of the user settings (#7393)

* - remove ReverseLayout and just rely on LayoutDirection

* - fix formatting

5 years agoFix random test failures (#8083)
Rui Marinho [Tue, 22 Oct 2019 09:54:50 +0000 (10:54 +0100)]
Fix random test failures (#8083)

* [UITEsts] Ignore vertical test

* [UITests] Ignore 5766 uitest

* [UITests] Ignore UITest 1342

5 years agoUnregister effects on dispose (#8109)
Andrei [Tue, 22 Oct 2019 09:52:35 +0000 (12:52 +0300)]
Unregister effects on dispose (#8109)

5 years agoSet MinimumWidth to the correct value on grid calc (#7318)
Shane Neuville [Mon, 21 Oct 2019 19:50:47 +0000 (13:50 -0600)]
Set MinimumWidth to the correct value on grid calc (#7318)

fixes #7303

5 years agoopacity mask added to FrameRenderer (#7828)
melimion [Mon, 21 Oct 2019 19:49:46 +0000 (22:49 +0300)]
opacity mask added to FrameRenderer (#7828)

fixes #7825

5 years agoset XF Verions File to be hidden (#8128)
Shane Neuville [Mon, 21 Oct 2019 19:03:27 +0000 (13:03 -0600)]
set XF Verions File to be hidden (#8128)

5 years ago[Android] Use AppCompat AlertDialog (#8046)
Joe Manke [Mon, 21 Oct 2019 10:16:17 +0000 (05:16 -0500)]
[Android] Use AppCompat AlertDialog (#8046)

* Change Android ControlGallery theme to inherit from Theme.AppCompat.DayNight to test GitHub issue #8029

* Use AppCompat AlertDialog in Android PopupManager

* Apply style to both default and AppCompat dialogs for comparison.

5 years agoMerge branch '4.3.0'
Stephane Delcroix [Mon, 21 Oct 2019 08:45:57 +0000 (10:45 +0200)]
Merge branch '4.3.0'

5 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 21 Oct 2019 08:40:15 +0000 (10:40 +0200)]
Merge branch '4.2.0' into 4.3.0

5 years agoFix ListView.ScrollTo does not work in WPF (#7947)
melimion [Fri, 18 Oct 2019 17:28:29 +0000 (20:28 +0300)]
Fix ListView.ScrollTo does not work in WPF (#7947)

* ScrollTo implementation added

* ScrollToPosition.Center implemented

* animation implemented

5 years agoAlways use current dispatcher to invoke wpf timer (#7958) fixes #6957
Konrad Müller [Fri, 18 Oct 2019 14:07:40 +0000 (16:07 +0200)]
Always use current dispatcher to invoke wpf timer (#7958) fixes #6957

5 years ago[MacOS] FIx agains NRE on disposing Entry renderer (#8019)
Rui Marinho [Fri, 18 Oct 2019 12:03:53 +0000 (13:03 +0100)]
[MacOS] FIx agains NRE on disposing Entry renderer (#8019)

5 years ago[MacOS] Fixed NRE with modal navigation (#7900)
Gerald Versluis [Fri, 18 Oct 2019 12:03:43 +0000 (14:03 +0200)]
[MacOS] Fixed NRE with modal navigation (#7900)

* Added repro and fix

* Added UITest

5 years agoAdd instructions and change UI test (#8077) fixes #2351
adrianknight89 [Fri, 18 Oct 2019 11:54:16 +0000 (06:54 -0500)]
Add instructions and change UI test (#8077) fixes #2351

5 years agoadded instructions (#8076) fixes #2352
adrianknight89 [Fri, 18 Oct 2019 11:52:08 +0000 (06:52 -0500)]
added instructions (#8076) fixes #2352

5 years agoAdd extension methods for ScaleXTo and ScaleYTo (#8007) fixes #8004
Steven Thewissen [Fri, 18 Oct 2019 11:22:48 +0000 (12:22 +0100)]
Add extension methods for ScaleXTo and ScaleYTo (#8007) fixes #8004

* Add extension methods for ScaleXTo and ScaleYTo

* Updated sample with small description

* Updated test

5 years agoFixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElemen...
Jon Robinson Levy [Fri, 18 Oct 2019 10:25:56 +0000 (12:25 +0200)]
Fixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElement, to check if the supplied NavigationPage Eelement has a CurrentPage. If not, an InvalidOperationException is thrown. (Otherwise a NullReferenceException would be thrown at a later point.) (#8034)

5 years agoCreated automated UI tests for issue 1769 (#8020)
Mikolaj Kieres [Thu, 17 Oct 2019 17:53:54 +0000 (04:53 +1100)]
Created automated UI tests for issue 1769 (#8020)

5 years agoMerge branch '4.3.0'
ShaneN [Thu, 17 Oct 2019 17:35:08 +0000 (11:35 -0600)]
Merge branch '4.3.0'

5 years agoCreating automated UI tests for the issue 1747 (#8023) fixes #2237
Mikolaj Kieres [Thu, 17 Oct 2019 10:49:52 +0000 (21:49 +1100)]
Creating automated UI tests for the issue 1747 (#8023) fixes #2237

5 years ago[Tizen] Add Meterial Stepper Renderer (#8037)
shmin [Thu, 17 Oct 2019 10:41:09 +0000 (19:41 +0900)]
[Tizen] Add Meterial Stepper Renderer (#8037)

5 years agoMake UpdateCancelButton virtual (#8027)
Glenn Versweyveld [Thu, 17 Oct 2019 07:35:36 +0000 (09:35 +0200)]
Make UpdateCancelButton virtual (#8027)

This allows people to override the default behaviour

5 years agoPreventing NRE when setting accessibility label while disposing controls (#8051)
Oberdan Bitencourt Ferreira [Thu, 17 Oct 2019 07:32:54 +0000 (04:32 -0300)]
Preventing NRE when setting accessibility label while disposing controls (#8051)

fixes #5612

5 years agoMake the Refresh View Respect Command CanExecute and add Refreshing event (#7866)
Shane Neuville [Thu, 17 Oct 2019 06:44:25 +0000 (00:44 -0600)]
Make the Refresh View Respect Command CanExecute and add Refreshing event (#7866)

* Make Refresh View respect Command CanExecute

* - force isrefreshing false when isenabled fasle
- Add IsRefreshing Event

* - shift command execution up to xplat code

* - fix ui test

* - cleanup

* - add additional check

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7803.xaml.cs

* - fix flag

5 years ago[iOS] Prevent crash when adding item to source of CollectionView in tab (#7940)
E.Z. Hart [Wed, 16 Oct 2019 20:54:16 +0000 (14:54 -0600)]
[iOS] Prevent crash when adding item to source of CollectionView in tab (#7940)

* Prevent crash when adding item to source of CollectionView that's never been displayed;
fixes #7700

* Fix renaming error in UI test

* Add test and fix for adding groups offscreen

* Fix rebase error

* Remove flags

* Add instructions

* Better instructions

5 years ago- merge fixes
ShaneN [Wed, 16 Oct 2019 16:46:33 +0000 (10:46 -0600)]
- merge fixes

5 years agoMerge 4.3.0
ShaneN [Wed, 16 Oct 2019 16:46:25 +0000 (10:46 -0600)]
Merge 4.3.0

5 years agoCleanup material controls character spacing interactions (#7880)
Shane Neuville [Wed, 16 Oct 2019 16:11:51 +0000 (10:11 -0600)]
Cleanup material controls character spacing interactions (#7880)

* Cleanup material controls and spacing

* - remove left over code

* - remove virtual

* - pr comments

5 years agoRemove requirement for CollectionView Experimental flag (#7907)
E.Z. Hart [Wed, 16 Oct 2019 15:44:47 +0000 (09:44 -0600)]
Remove requirement for CollectionView Experimental flag (#7907)

* CollectionView_Experimental is dead; long live CarouselView_Experimental!

* Change CollectionView enabling button labels to CarouselView for CarouselView tests

* Fix UI tests for Carousel

* Honor the CollectionView_Experimental flag for CarouselView

* Update Issue6963.cs

* Update Issue7817.xaml.cs

* Remove collection view flag settings

5 years ago[Android] Fix recyclerview offsets (#8018) fixes #7993
adrianknight89 [Wed, 16 Oct 2019 10:29:33 +0000 (05:29 -0500)]
[Android] Fix recyclerview offsets (#8018) fixes #7993

5 years agoremove duplicate statement (#8014)
adrianknight89 [Wed, 16 Oct 2019 10:16:00 +0000 (05:16 -0500)]
remove duplicate statement (#8014)

5 years agoFix Material Editor so TextChange delegate isn't removed (#8011)
Shane Neuville [Tue, 15 Oct 2019 22:10:36 +0000 (16:10 -0600)]
Fix Material Editor so TextChange delegate isn't removed (#8011)

* Fix Material Editor so delegate isn't removed

* - fix ui test

5 years agoFix bug 5868 "VisualElement.Unfocus does not work on WPF" (#7883)
Konrad Müller [Tue, 15 Oct 2019 19:24:34 +0000 (21:24 +0200)]
Fix bug 5868 "VisualElement.Unfocus does not work on WPF" (#7883)

* Add repro

* fix bug

5 years agoFix shell to correctly pick visible item (#8009)
Shane Neuville [Tue, 15 Oct 2019 18:44:22 +0000 (12:44 -0600)]
Fix shell to correctly pick visible item (#8009)

- when items are removed

5 years ago[macOS] Add padding to Button (#7919) fixes #7851
Oliver Brown [Tue, 15 Oct 2019 18:32:23 +0000 (19:32 +0100)]
[macOS] Add padding to Button (#7919) fixes #7851

* Add basic macOS button padding.

* Add NSButtonCell for offsetting title.

* Remove "private"

5 years agoFix iOS crash when group type is not an IList (#7955)
E.Z. Hart [Tue, 15 Oct 2019 18:19:36 +0000 (12:19 -0600)]
Fix iOS crash when group type is not an IList (#7955)

5 years agoFixed issue setting Position in CarouselView (#7901) fixes #7865
Javier Suárez Ruiz [Tue, 15 Oct 2019 14:37:41 +0000 (16:37 +0200)]
Fixed issue setting Position in CarouselView (#7901) fixes #7865

* Added sample file

* Updated sample

* Fixed the issue on Android and iOS

* Updated IsScrolling property from UWP CarouselView renderer

* Added repro sample instructions

* Update Issue7865.xaml.cs

* [iOS] Update IsScrolling from renderer

5 years agoFixed build error (merge) (#8024)
Javier Suárez Ruiz [Tue, 15 Oct 2019 13:18:03 +0000 (15:18 +0200)]
Fixed build error (merge) (#8024)

5 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Tue, 15 Oct 2019 12:12:49 +0000 (14:12 +0200)]
Merge branch '4.2.0' into 4.3.0

5 years agoLabel size doesn't change when text changed (#7942)
bill2004158 [Tue, 15 Oct 2019 10:53:31 +0000 (18:53 +0800)]
Label size doesn't change when text changed (#7942)

- fixes #7888

5 years agoAdded sample (#7650)
Javier Suárez Ruiz [Tue, 15 Oct 2019 08:37:57 +0000 (10:37 +0200)]
Added sample (#7650)

5 years ago[iOS] Various fixes with ItemsViewController (#7618)
adrianknight89 [Tue, 15 Oct 2019 08:32:26 +0000 (03:32 -0500)]
[iOS] Various fixes with ItemsViewController (#7618)

* various fixes

* remove comment

* move delegator setting to ViewDidLoad

* fix delegator

* fix accessibility issue

5 years agomerge fix with UWP scroll mode
ShaneN [Tue, 15 Oct 2019 05:26:24 +0000 (23:26 -0600)]
merge fix with UWP scroll mode

5 years agoMerge 4.3.0 into master
ShaneN [Tue, 15 Oct 2019 05:19:46 +0000 (23:19 -0600)]
Merge 4.3.0 into master

5 years ago[Android] speed up development builds (#7834)
Shane Neuville [Tue, 15 Oct 2019 05:10:00 +0000 (23:10 -0600)]
[Android] speed up development builds (#7834)

* speed up development builds android

* - remove extra property group

* - add cake descriptions

* - fix

* - remove shared runtime

* - add check for TF_Build

5 years agoFixed ItemSpacing, NumberOfSideItems, PeekAreaInsets and Snap in UWP CarouselView...
Javier Suárez Ruiz [Tue, 15 Oct 2019 00:07:11 +0000 (02:07 +0200)]
Fixed ItemSpacing, NumberOfSideItems, PeekAreaInsets and Snap in UWP CarouselView. (#7930)

5 years ago[Android] Fixed a crash on CollectionView changing ItemsSource (#7945)
Javier Suárez Ruiz [Mon, 14 Oct 2019 21:24:53 +0000 (23:24 +0200)]
[Android] Fixed a crash on CollectionView changing ItemsSource (#7945)

* Added repro sample

* Fixed the crash

5 years agoSet Continue On Error for parallel builds (#7914)
Shane Neuville [Mon, 14 Oct 2019 19:32:06 +0000 (13:32 -0600)]
Set Continue On Error for parallel builds (#7914)

5 years agoMake WkWebViewRenderer default for iOS WebView (#7367)
Gerald Versluis [Mon, 14 Oct 2019 16:18:09 +0000 (18:18 +0200)]
Make WkWebViewRenderer default for iOS WebView (#7367)

* Make WkWebViewRenderer default for iOS

* Update AssemblyInfo.cs

* Update Xamarin.Forms.Platform.cs

* Revert "Update AssemblyInfo.cs"

This reverts commit ca0c034c3fa5c18630c2f7f505e73015a901dd17.

* Fix test 26993 iOS

* Update Bugzilla26993.cs

5 years agoValidate on Date part only (#7766) fixes #5784
Glenn Versweyveld [Mon, 14 Oct 2019 15:56:57 +0000 (17:56 +0200)]
Validate on Date part only (#7766) fixes #5784

* Validate on Date part only

Fixes #5784

* Add unittest

* Both sides should be Date only validated