reed@google.com [Tue, 12 Jun 2012 20:47:53 +0000 (20:47 +0000)]
add readPtr and writePtr to SkReader32 and SkWriter32
add template helper SkSWriter32, which allocates initial storage buffer
Review URL: https://codereview.appspot.com/6299075
git-svn-id: http://skia.googlecode.com/svn/trunk@4237
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 12 Jun 2012 15:17:27 +0000 (15:17 +0000)]
Move SkColorTable into its own header and reduce includes in SkFlattenable.h
Review URL: https://codereview.appspot.com/6299072
git-svn-id: http://skia.googlecode.com/svn/trunk@4236
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 12 Jun 2012 14:56:36 +0000 (14:56 +0000)]
Adding the render_pictures test tool
Submitted on behalf of keyar@chromium.org
Review URL: https://codereview.appspot.com/6300056/
git-svn-id: http://skia.googlecode.com/svn/trunk@4235
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Tue, 12 Jun 2012 13:58:36 +0000 (13:58 +0000)]
Adding API to GrTexture to reset cached texture parameter values
REVIEW=http://codereview.appspot.com/6305084/
BUG=http://code.google.com/p/chromium/issues/detail?id=130925
git-svn-id: http://skia.googlecode.com/svn/trunk@4234
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 12 Jun 2012 00:32:28 +0000 (00:32 +0000)]
Split GrContext's AA Rect drawing methods into helper class
http://codereview.appspot.com/6300070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4233
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 11 Jun 2012 21:21:26 +0000 (21:21 +0000)]
remove SK_CAN_USE_FLOAT (deprecated)
git-svn-id: http://skia.googlecode.com/svn/trunk@4232
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 11 Jun 2012 20:48:18 +0000 (20:48 +0000)]
Disable morphology benchmarks on fixed point builds.
http://codereview.appspot.com/6300082/
git-svn-id: http://skia.googlecode.com/svn/trunk@4231
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 11 Jun 2012 19:22:01 +0000 (19:22 +0000)]
Dilate & Erode benchmarks. Unlike the blur benchmarks (which test
Convolution), they show no improvement from unrolling the GLSL loops
in src/gpu/effects/GrMorphologyEffect.cpp
http://codereview.appspot.com/6299067/
git-svn-id: http://skia.googlecode.com/svn/trunk@4230
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 11 Jun 2012 18:54:07 +0000 (18:54 +0000)]
fix missing switch-statement handler (for conical gradient)
git-svn-id: http://skia.googlecode.com/svn/trunk@4229
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 11 Jun 2012 17:41:14 +0000 (17:41 +0000)]
new baselines for new test (pathinvfill). PDF and GPU fail, so no baselines for them
git-svn-id: http://skia.googlecode.com/svn/trunk@4228
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 11 Jun 2012 17:30:33 +0000 (17:30 +0000)]
Better fix for rev. 4214 (inverse-fill and clipping). This fix avoids changing
the actual clipping bounds, which caused tiny differences in the scan converter.
Also adding a gm (which I should have the first time.)
Review URL: https://codereview.appspot.com/6297073
git-svn-id: http://skia.googlecode.com/svn/trunk@4227
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 11 Jun 2012 16:51:45 +0000 (16:51 +0000)]
Register Two_Point_Conical_Gradient for flattening.
Without being registered, the twopointconical GM fails
when using --pipe or --serialize, since this gradient
will not be flattened/unflattened.
Review URL: https://codereview.appspot.com/6294060
git-svn-id: http://skia.googlecode.com/svn/trunk@4226
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:55:58 +0000 (15:55 +0000)]
fix include name (masked by case insensitiviy on windows)
git-svn-id: http://skia.googlecode.com/svn/trunk@4225
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:52:55 +0000 (15:52 +0000)]
fix SkNWayCanvas cons call again.
git-svn-id: http://skia.googlecode.com/svn/trunk@4224
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:47:23 +0000 (15:47 +0000)]
Fix SkNWayCanvas cons call when creating null canvas.
git-svn-id: http://skia.googlecode.com/svn/trunk@4223
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:46:05 +0000 (15:46 +0000)]
Fix Fixed-Point build by changing static_assert around scalar=float to a runtime crash.
git-svn-id: http://skia.googlecode.com/svn/trunk@4222
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:41:25 +0000 (15:41 +0000)]
Add SK_API to null canvas create method
git-svn-id: http://skia.googlecode.com/svn/trunk@4221
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:39:15 +0000 (15:39 +0000)]
Null canvas
Review URL: http://codereview.appspot.com/6117051/
git-svn-id: http://skia.googlecode.com/svn/trunk@4220
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 11 Jun 2012 15:36:13 +0000 (15:36 +0000)]
Towards NV path rendering
Review URL: http://codereview.appspot.com/6302049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4219
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 11 Jun 2012 12:42:24 +0000 (12:42 +0000)]
Manually unroll loop in convolution (blur) - most GL drivers do, but some
don't, and this leads to 20-30% benchmark speedup.
http://codereview.appspot.com/6308057/
git-svn-id: http://skia.googlecode.com/svn/trunk@4218
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 9 Jun 2012 02:03:40 +0000 (02:03 +0000)]
fix typo: fA is dx^2 + dx^2 - dr^2, not dx^2 - dy^2 - dr^2
git-svn-id: http://skia.googlecode.com/svn/trunk@4217
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 8 Jun 2012 20:36:22 +0000 (20:36 +0000)]
Remove glBlendEquation and glColorPointer
Review URL: http://codereview.appspot.com/6300075/
git-svn-id: http://skia.googlecode.com/svn/trunk@4216
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 8 Jun 2012 18:30:46 +0000 (18:30 +0000)]
Rename the existing flatten(void*) methods.
This change avoids naminc confusion with the SkFlattenable flatten methods and
also changes SkPath to use the void* model instead of taking a SkReader32.
Review URL: https://codereview.appspot.com/6299062
git-svn-id: http://skia.googlecode.com/svn/trunk@4215
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 8 Jun 2012 16:30:12 +0000 (16:30 +0000)]
Detect inverse-fill, and treat its bounds as huge (all of integer space) for the
purposes of comparing w/ the clip-bounds, otherwise we can reject the draw if
the bounds of the path are outside the bounds of the clip.
Review URL: https://codereview.appspot.com/6302058
git-svn-id: http://skia.googlecode.com/svn/trunk@4214
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 8 Jun 2012 15:35:03 +0000 (15:35 +0000)]
Add a tiled pipe mode to SampleApp.
Using the "Pipe" checkbox in SamleApp, you can now
toggle amongst three states: no pipe, a normal pipe
(or others depending on #defines), and a tiled pipe.
You can also use shift + p to toggle.
Review URL: https://codereview.appspot.com/6303055
git-svn-id: http://skia.googlecode.com/svn/trunk@4213
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 8 Jun 2012 14:21:26 +0000 (14:21 +0000)]
Fix for r4201 performance regression (code.google.com/p/skia/issues/detail?id=640)
http://codereview.appspot.com/6299060/
git-svn-id: http://skia.googlecode.com/svn/trunk@4212
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 8 Jun 2012 14:13:02 +0000 (14:13 +0000)]
Call flushMiscFixedFunctionState (D'oh!)
Review URL: http://codereview.appspot.com/6302057/
git-svn-id: http://skia.googlecode.com/svn/trunk@4211
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 7 Jun 2012 21:43:15 +0000 (21:43 +0000)]
Add SkPath::getVerbs/countVerbs
Review URL: http://codereview.appspot.com/6306053/
git-svn-id: http://skia.googlecode.com/svn/trunk@4209
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 7 Jun 2012 21:09:20 +0000 (21:09 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4208
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 7 Jun 2012 20:26:47 +0000 (20:26 +0000)]
extend asAGradient for Conical type (to be implemented by PDF and XPS)
Review URL: https://codereview.appspot.com/6308051
git-svn-id: http://skia.googlecode.com/svn/trunk@4207
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 7 Jun 2012 17:47:33 +0000 (17:47 +0000)]
Make SkPath::RawIter require a non-NULL pts pointer.
Review URL: http://codereview.appspot.com/6301060/
git-svn-id: http://skia.googlecode.com/svn/trunk@4206
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 7 Jun 2012 17:39:48 +0000 (17:39 +0000)]
Add the ability to specify config to GM.
Code adapted from bench.
To specify a config, add -config <configName1>|<configName2> etc
to the command line.
To find the valid names (which can depend on flags passed in), use
-h or --help.
Review URL: https://codereview.appspot.com/6297053
git-svn-id: http://skia.googlecode.com/svn/trunk@4205
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 7 Jun 2012 14:20:52 +0000 (14:20 +0000)]
optimize quad-root for conical gradients
Review URL: https://codereview.appspot.com/6307052
git-svn-id: http://skia.googlecode.com/svn/trunk@4204
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 7 Jun 2012 14:18:34 +0000 (14:18 +0000)]
add bench for conical Gradient
git-svn-id: http://skia.googlecode.com/svn/trunk@4203
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 7 Jun 2012 13:03:03 +0000 (13:03 +0000)]
Fix dumb bug in checking gl interface validation against binding from gl version string
git-svn-id: http://skia.googlecode.com/svn/trunk@4202
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 7 Jun 2012 12:08:45 +0000 (12:08 +0000)]
Move clientID into texture desc
http://codereview.appspot.com/6305044/
git-svn-id: http://skia.googlecode.com/svn/trunk@4201
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo [Wed, 6 Jun 2012 21:26:31 +0000 (21:26 +0000)]
Fix the build for GM.
Add src/pipe/utils as an include directory.
git-svn-id: http://skia.googlecode.com/svn/trunk@4200
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 6 Jun 2012 21:07:10 +0000 (21:07 +0000)]
Add tiled rendering as an option to GM.
Use an SkGPipe to play back drawing into tiles.
This will help us to debug differences in drawing
while tiled.
Pass --tiledPipe to gm to use the tiled pipe.
Review URL: https://codereview.appspot.com/6295050
git-svn-id: http://skia.googlecode.com/svn/trunk@4199
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 6 Jun 2012 20:51:20 +0000 (20:51 +0000)]
Search and replace change. Some Gr enum value names didn't have a "Gr" in their suffix.
Verbal LGTM from TomH
git-svn-id: http://skia.googlecode.com/svn/trunk@4198
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 6 Jun 2012 20:31:56 +0000 (20:31 +0000)]
Add new gradient to support HTML Canvas2D two-point-radial-gradient. Ours is
called (for now at least) TwoPointConical, to distinguish it from the
existing one (TwoPointRadial), and to reflect its odd behavior where it draws
transparent outside the boundary of the "cone" between the two circles.
This impl is unsupported by GPU and Printing at the moment, and Chrome does not
yet invoke it.
Review URL: https://codereview.appspot.com/6299051
git-svn-id: http://skia.googlecode.com/svn/trunk@4197
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 6 Jun 2012 19:13:46 +0000 (19:13 +0000)]
Reenable running samplerstress GM in pipe mode.
It was disabled because samplerstress did was not
registered for flattening. Now that it is, do not
skip it when running GM in pipe mode.
Review URL: https://codereview.appspot.com/6305057
git-svn-id: http://skia.googlecode.com/svn/trunk@4196
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 6 Jun 2012 18:21:18 +0000 (18:21 +0000)]
Remove gpu stats tracking
Review URL: http://codereview.appspot.com/6300052/
git-svn-id: http://skia.googlecode.com/svn/trunk@4194
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 6 Jun 2012 15:38:52 +0000 (15:38 +0000)]
fix bug in GrGLInterface validation added in r4192
git-svn-id: http://skia.googlecode.com/svn/trunk@4193
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 6 Jun 2012 15:17:54 +0000 (15:17 +0000)]
Add GL function pointers for GL_NV_path_rendering
Review URL: http://codereview.appspot.com/6296046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4192
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:13:40 +0000 (12:13 +0000)]
one more warning suppressed (make unused code
avoid bit rot)
git-svn-id: http://skia.googlecode.com/svn/trunk@4191
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:12:28 +0000 (12:12 +0000)]
Turn more warnings on, including
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
Review URL: https://codereview.appspot.com/6307043
git-svn-id: http://skia.googlecode.com/svn/trunk@4190
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:11:55 +0000 (12:11 +0000)]
fix warnings on Mac in src/animator
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6306044
git-svn-id: http://skia.googlecode.com/svn/trunk@4189
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:11:45 +0000 (12:11 +0000)]
fix warnings on Mac in bench
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6302044
git-svn-id: http://skia.googlecode.com/svn/trunk@4188
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:11:33 +0000 (12:11 +0000)]
fix warnings on Mac in experimental
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6307044
git-svn-id: http://skia.googlecode.com/svn/trunk@4187
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:11:10 +0000 (12:11 +0000)]
fix warnings on Mac in miscellaneous files
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6305047
git-svn-id: http://skia.googlecode.com/svn/trunk@4186
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:10:45 +0000 (12:10 +0000)]
fix warnings on Mac in gm
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6305046
git-svn-id: http://skia.googlecode.com/svn/trunk@4185
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:10:26 +0000 (12:10 +0000)]
fix warnings on Mac in src/opts
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6303045
git-svn-id: http://skia.googlecode.com/svn/trunk@4184
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:09:51 +0000 (12:09 +0000)]
fix warnings on Mac in ssamplecode
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6301044
git-svn-id: http://skia.googlecode.com/svn/trunk@4183
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:09:34 +0000 (12:09 +0000)]
fix warnings on Mac in src/core
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6301046
git-svn-id: http://skia.googlecode.com/svn/trunk@4182
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:09:18 +0000 (12:09 +0000)]
fix warnings on Mac in src/effects
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6299049
git-svn-id: http://skia.googlecode.com/svn/trunk@4181
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:09:01 +0000 (12:09 +0000)]
fix warnings on Mac in src/gpu and include/gpu
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6296044
git-svn-id: http://skia.googlecode.com/svn/trunk@4180
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:04:36 +0000 (12:04 +0000)]
fix warnings on Mac in src/images
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6299048
git-svn-id: http://skia.googlecode.com/svn/trunk@4179
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:04:24 +0000 (12:04 +0000)]
fix warnings on Mac in src/pdf
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6299047
git-svn-id: http://skia.googlecode.com/svn/trunk@4178
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:04:11 +0000 (12:04 +0000)]
fix warnings on Mac in src/pipe
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6302045
git-svn-id: http://skia.googlecode.com/svn/trunk@4177
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:04:00 +0000 (12:04 +0000)]
fix warnings on Mac in src/views
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6300045
git-svn-id: http://skia.googlecode.com/svn/trunk@4176
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 12:03:39 +0000 (12:03 +0000)]
fix warnings on Mac in tests
Fix these class of warnings:
- unused functions
- unused locals
- sign mismatch
- missing function prototypes
- missing newline at end of file
- 64 to 32 bit truncation
The changes prefer to link in dead code in the debug build
with 'if (false)' than to comment it out, but trivial cases
are commented out or sometimes deleted if it appears to be
a copy/paste error.
Review URL: https://codereview.appspot.com/6301045
git-svn-id: http://skia.googlecode.com/svn/trunk@4175
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 6 Jun 2012 11:52:28 +0000 (11:52 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@4174
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 5 Jun 2012 20:24:20 +0000 (20:24 +0000)]
Move stencil param adjustment to GrClipMaskManager, attempt to make GrGpuGL::flushStencil readable
Review URL: http://codereview.appspot.com/6295046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4173
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 5 Jun 2012 19:57:42 +0000 (19:57 +0000)]
rebaseline after filtered-gradients-gpu change
git-svn-id: http://skia.googlecode.com/svn/trunk@4172
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 19:35:09 +0000 (19:35 +0000)]
Instance counting for SkRefCnt-derived objects (w/ CanvasTest fix)
http://codereview.appspot.com/6242070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4170
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Tue, 5 Jun 2012 17:57:48 +0000 (17:57 +0000)]
Support Mac-Android Cross-Compilation
- Rename Android sampleApp target to SampleAppAndroid to avoid name collision
- Detect skia_os on Darwin to differentiate between xcode and make builds
Review URL: https://codereview.appspot.com/6303044
git-svn-id: http://skia.googlecode.com/svn/trunk@4168
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 5 Jun 2012 17:39:22 +0000 (17:39 +0000)]
temporary avoid zero-divide (to avoid assert in fixedpoint build)
git-svn-id: http://skia.googlecode.com/svn/trunk@4166
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 5 Jun 2012 17:15:30 +0000 (17:15 +0000)]
temporary:
- suppress PDF for twopointradial GM until we fix its assert/failure (vandebo)
- detect divide-by-zero and abort for now (reed)
git-svn-id: http://skia.googlecode.com/svn/trunk@4165
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 16:24:32 +0000 (16:24 +0000)]
Reverting r4162
git-svn-id: http://skia.googlecode.com/svn/trunk@4164
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 5 Jun 2012 16:14:23 +0000 (16:14 +0000)]
add gm (no images yet) for two-point-radial gradients
git-svn-id: http://skia.googlecode.com/svn/trunk@4163
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 15:40:54 +0000 (15:40 +0000)]
Added instance counting system for SkRefCnt-derived objects
http://codereview.appspot.com/6242070/
git-svn-id: http://skia.googlecode.com/svn/trunk@4162
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 5 Jun 2012 15:13:46 +0000 (15:13 +0000)]
Move stuff from protected to private in GrGpuGL
Review URL: http://codereview.appspot.com/6295044/
git-svn-id: http://skia.googlecode.com/svn/trunk@4161
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 5 Jun 2012 14:58:40 +0000 (14:58 +0000)]
Fix an issue where Pipe did not draw correctly
on all platforms.
Since parameters can be evaluated in any order,
we can't call buffer.read() inline for multiple
parameters. The fix is to read the stream (in
the correct order) before we call the function.
Review URL: https://codereview.appspot.com/6277046
git-svn-id: http://skia.googlecode.com/svn/trunk@4160
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 13:22:14 +0000 (13:22 +0000)]
Added missing #include in SkGlobalInitialization_default.cpp for Android build
git-svn-id: http://skia.googlecode.com/svn/trunk@4156
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 13:12:53 +0000 (13:12 +0000)]
Fix for compiler error in r4154
git-svn-id: http://skia.googlecode.com/svn/trunk@4155
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 5 Jun 2012 12:55:05 +0000 (12:55 +0000)]
Fixed flattening of SkStippleMaskFilter
http://codereview.appspot.com/6279052/
git-svn-id: http://skia.googlecode.com/svn/trunk@4154
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 5 Jun 2012 12:50:41 +0000 (12:50 +0000)]
Mac mini lion rebaselines from r4152
git-svn-id: http://skia.googlecode.com/svn/trunk@4153
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 21:44:25 +0000 (21:44 +0000)]
Rebaseline GPU gradient GMs due to r4151.
git-svn-id: http://skia.googlecode.com/svn/trunk@4152
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 20:21:28 +0000 (20:21 +0000)]
Always filter gradient textures
[GMs could possibly need rebaselining]
Review URL: http://codereview.appspot.com/6286048/
git-svn-id: http://skia.googlecode.com/svn/trunk@4151
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 20:18:54 +0000 (20:18 +0000)]
Remove cached texture width/height that was used by 4x4 filter
Review URL: http://codereview.appspot.com/6286048
git-svn-id: http://skia.googlecode.com/svn/trunk@4150
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 20:06:02 +0000 (20:06 +0000)]
remove 4x4 downsample filter mode
Review URL: http://codereview.appspot.com/6267046/
git-svn-id: http://skia.googlecode.com/svn/trunk@4149
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Jun 2012 20:05:28 +0000 (20:05 +0000)]
GrTexture can now create its own cache key
http://codereview.appspot.com/6269047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4148
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 20:00:01 +0000 (20:00 +0000)]
change gm to use concat instead of setMatrix, so we don't trash the caller if
it was recorded into a picture.
git-svn-id: http://skia.googlecode.com/svn/trunk@4147
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 4 Jun 2012 19:58:30 +0000 (19:58 +0000)]
Clean up likely reference leak in Ganesh custom stages.
http://codereview.appspot.com/6286047/
git-svn-id: http://skia.googlecode.com/svn/trunk@4146
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 19:37:36 +0000 (19:37 +0000)]
rebaselined w/ new (high-fidelity-asColorMatrix) colormatrix impl from 4143
git-svn-id: http://skia.googlecode.com/svn/trunk@4145
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 19:31:00 +0000 (19:31 +0000)]
Break up GrGpuGL::flushGLCommonState
Review URL: http://codereview.appspot.com/6270049/
git-svn-id: http://skia.googlecode.com/svn/trunk@4144
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 19:07:41 +0000 (19:07 +0000)]
remove mutable apis on SkColorMatrixFilter, must use constructor.
fix flattening to not write function-ptrs (no go for serialization), so we
store the raw float values now.
Slight change to GM/DRT images for GPU possible. Just rebaseline.
Review URL: https://codereview.appspot.com/6273052
git-svn-id: http://skia.googlecode.com/svn/trunk@4143
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 19:05:11 +0000 (19:05 +0000)]
move texture flush and param update to separate function
Review URL: http://codereview.appspot.com/6266044/
git-svn-id: http://skia.googlecode.com/svn/trunk@4142
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 18:10:33 +0000 (18:10 +0000)]
remove public function-ptr based colorfilter
Review URL: https://codereview.appspot.com/6286046
git-svn-id: http://skia.googlecode.com/svn/trunk@4141
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Jun 2012 17:45:54 +0000 (17:45 +0000)]
Turn off pipe playback in GM by default.
Works for me, but not on all platforms.
Review URL: https://codereview.appspot.com/6293043
git-svn-id: http://skia.googlecode.com/svn/trunk@4140
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Mon, 4 Jun 2012 17:17:36 +0000 (17:17 +0000)]
Make the GM tool run GMs through an SkGPipe.
Add pipe to core gyp project.
Do not run samplerstress through the pipe, since its
custom MaskFilter will not draw correctly.
Fix an assert in SkGPipeWrite when writing a typeface.
Review URL: https://codereview.appspot.com/6276044
git-svn-id: http://skia.googlecode.com/svn/trunk@4139
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 4 Jun 2012 14:13:06 +0000 (14:13 +0000)]
change static variable to #define
git-svn-id: http://skia.googlecode.com/svn/trunk@4138
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Mon, 4 Jun 2012 13:39:47 +0000 (13:39 +0000)]
Add legacy script to enable skia roll into chromium.
Review URL: https://codereview.appspot.com/6277045
git-svn-id: http://skia.googlecode.com/svn/trunk@4137
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 13:31:48 +0000 (13:31 +0000)]
Revert r4134 due to bot failures
git-svn-id: http://skia.googlecode.com/svn/trunk@4136
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Jun 2012 13:22:14 +0000 (13:22 +0000)]
Fixed Linux compiler complaints
http://codereview.appspot.com/6269045/
git-svn-id: http://skia.googlecode.com/svn/trunk@4135
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 4 Jun 2012 13:03:25 +0000 (13:03 +0000)]
Move GrGpuGL::programUnitTest into its own file
Review URL: http://codereview.appspot.com/6272043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4134
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 4 Jun 2012 12:48:45 +0000 (12:48 +0000)]
Move texture descriptor into GrTexture
http://codereview.appspot.com/6258068/
git-svn-id: http://skia.googlecode.com/svn/trunk@4133
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 4 Jun 2012 12:05:43 +0000 (12:05 +0000)]
--pictureDir foo will load serialized pictures <>.skp from the foo directory
git-svn-id: http://skia.googlecode.com/svn/trunk@4132
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Sat, 2 Jun 2012 14:50:13 +0000 (14:50 +0000)]
add -wp option to write serialized pictures to the specified directory
git-svn-id: http://skia.googlecode.com/svn/trunk@4131
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Fri, 1 Jun 2012 21:23:07 +0000 (21:23 +0000)]
Adding option to serialize mutable bitmaps in SkPicture
BUG=http://code.google.com/p/chromium/issues/detail?id=115654
REVIEW=http://codereview.appspot.com/6221066/
git-svn-id: http://skia.googlecode.com/svn/trunk@4130
2bbb7eff-a529-9590-31e7-
b0007b416f81