Daniel Stenberg [Fri, 5 Nov 2010 21:26:54 +0000 (22:26 +0100)]
--libcurl: simplify output
Removed the code that was needed for libcurl before 7.19.0 which now is
more than two years old.
Simplified the top comment and corrected the URL.
Alfred Gebert [Fri, 5 Nov 2010 14:53:41 +0000 (15:53 +0100)]
LDAP: detect non-binary attributes properly
If the query result has a binary attribute, the binary attribute is
base64 encoded. But all following non binary attributes are also base64
encoded which is wrong.
This is a test (LDAP server is public).
curl
ldap://x500.bund.de:389/o=Bund,c=DE?userCertificate,certificateSerialNumber?sub
?cn=*Woehleke*
Daniel Stenberg [Fri, 5 Nov 2010 13:07:38 +0000 (14:07 +0100)]
xattr: add configure check and #ifdefs
setxattr is a glibc call to set extended attributes, so configure now
checks for it and the code is adapted to only build when the
functionality is present.
Stefan Tomanek [Fri, 5 Nov 2010 11:39:46 +0000 (12:39 +0100)]
save metadata to extended file attributes
It is often convinient to track back the source of a once downloaded
file; this patch makes curl store the source URL and other metadata
alongside the retrieved file by using the extended attributes (if
supported by the file system and enabled by --xattr).
Daniel Stenberg [Fri, 5 Nov 2010 10:19:21 +0000 (11:19 +0100)]
test: remove test 580
Test 580 is removed again for two reasons:
1) Some compilers aren't satisfied by just a data variable called 'test'
when first.o wants a function called 'test'. The Solaris compiler says
"ld: warning: symbol `test' has differing types:" while the AIX compiler
downright rejects it.
2) Test case 1119 that was added after this test is way more complete
and cover everything test 580 does and more without introducing the same
problems.
Daniel Stenberg [Fri, 5 Nov 2010 09:24:22 +0000 (10:24 +0100)]
Daniel Stenberg [Thu, 4 Nov 2010 22:09:08 +0000 (23:09 +0100)]
TODO-RELEASE: "TLS SNI use Host:" is done
262 - Manual setting of TLS Server Name Indication - use Host:
Daniel Stenberg [Thu, 4 Nov 2010 21:55:45 +0000 (22:55 +0100)]
RELEASE-NOTES: synced with
7b823badbcab9d330
Daniel Stenberg [Thu, 4 Nov 2010 18:39:15 +0000 (19:39 +0100)]
curl.1: added a few missing exit codes
Daniel Stenberg [Thu, 4 Nov 2010 14:18:35 +0000 (15:18 +0100)]
certcheck: use the custom Host: name for checks
If you use a custom Host: name in a request to a SSL server, libcurl
will now use that given name when it verifies the server certificate to
be correct rather than using the host name used in the actual URL.
Daniel Stenberg [Thu, 4 Nov 2010 14:16:27 +0000 (15:16 +0100)]
SNI: simplify the custom host name use
The redirect check is already done at the position where the customhost
field is assigned so there's no point in doing that a second time.
Daniel Stenberg [Thu, 4 Nov 2010 13:58:15 +0000 (14:58 +0100)]
host: get the custom Host: name more genericly
When given a custom host name in a Host: header, we can use it for
several different purposes other than just cookies, so we rename it and
use it for SSL SNI etc.
Hongli Lai (Phusion) [Thu, 4 Nov 2010 11:54:58 +0000 (12:54 +0100)]
SNI: set name to custom Host header
OpenSSL SNI host name should be set to the custom Host header, if the
user provided one.
Daniel Stenberg [Thu, 4 Nov 2010 10:42:27 +0000 (11:42 +0100)]
fopen.c: re-indented, fixed previous mistake
I've made the code intended using curl-style now to look more like other
examples.
My previous "fix" was a bit too invasive but is now fixed again.
Daniel Stenberg [Thu, 4 Nov 2010 10:37:23 +0000 (11:37 +0100)]
multi use: call multi_perform even on select() timeouts
Daniel Stenberg [Thu, 4 Nov 2010 09:32:38 +0000 (10:32 +0100)]
example: add smtp-multi.c
An example application source code sending SMTP mail with the multi
interface. It is based on the code Alona Rossen provided, which in turn
is based on existing example/test code, and I converted it even more
into a decent example with a fair multi API use, put the info required
to edit at the top and I added some comments.
Daniel Stenberg [Thu, 4 Nov 2010 08:49:02 +0000 (09:49 +0100)]
CURLOPT_NOSIGNAL: add blurb about SIGPIPE
Dan Fandrich [Thu, 4 Nov 2010 02:03:02 +0000 (19:03 -0700)]
Allow building test 580 out of tree
Daniel Stenberg [Wed, 3 Nov 2010 10:25:06 +0000 (11:25 +0100)]
dist: add symbol-scan.pl to the tarball
Daniel Stenberg [Wed, 3 Nov 2010 10:23:54 +0000 (11:23 +0100)]
test1119: verify symbols-in-versions
Daniel Stenberg [Wed, 3 Nov 2010 10:22:46 +0000 (11:22 +0100)]
runtests: allow tests written as perl scripts
If a command is set type="perl", it can now specify a perl program that will
be run instead of an ordinary curl or built tool.
A perl test automatically disables memory and valgrind debugging.
Daniel Stenberg [Wed, 3 Nov 2010 10:20:19 +0000 (11:20 +0100)]
symbol-scan: verifies symbols-in-versions
This new script scans for all enums and #defines used by the curl/curl.h
and curl/multi.h headers. Then it reads all symbols mentioned in
symbols-in-vesions and make sure that there's no entries missing in
there. It then proceeds to verify that the entries that
symbols-in-vesions mentions but aren't found in the sources are truly
documented as removed.
This script is used in the new test case 1119
Daniel Stenberg [Wed, 3 Nov 2010 09:04:23 +0000 (10:04 +0100)]
symbols-in-versions: added 119 missing symbols
I've developed a script I call symbol-scan.pl that scans the curl.h and
multi.h header files and compare the symbols it finds in there with the
symbols symbols-in-versions documents and outputs a report on the
differences. Using this I've dug through the history to fill up
symbols-in-versions with all the symbols my script found mismatches for.
I will commit symbol-scan.pl separatly and think of a way to put it to
use in the build/tests so that we from now on will get this in-sync
check automatically.
Dan Fandrich [Wed, 3 Nov 2010 06:17:36 +0000 (23:17 -0700)]
Added mk580.pl to the tar ball
Daniel Stenberg [Tue, 2 Nov 2010 22:35:12 +0000 (23:35 +0100)]
symbols-in-versions: added missing symbols
Daniel Stenberg [Tue, 2 Nov 2010 22:34:37 +0000 (23:34 +0100)]
ignore: lib580.c is generated by mk580.pl
Daniel Stenberg [Tue, 2 Nov 2010 21:27:33 +0000 (22:27 +0100)]
test: added test 580 - verifies symbols-in-versions
The new perl script mk580.pl generates a C table in a fresh source file
named lib580.c and if that compiles fine we know that the file
docs/libcurl/symbols-in-versions at least doesn't include any symbols
that are misspelled.
An additional feature would be to somehow scan curl/curl.h and compare
with symbols-in-versions to see if there are symbols missing.
Daniel Stenberg [Tue, 2 Nov 2010 21:01:01 +0000 (22:01 +0100)]
spellfix: CURLOPT_TFTP_BLKSIZE it is
Kamil Dudka [Wed, 27 Oct 2010 08:54:35 +0000 (10:54 +0200)]
ftp: prevent server from hanging on closed data connection
Some FTP servers (e.g. Pure-ftpd) end up hanging if we close the data
connection before transferring all the requested data. If we send ABOR
in that case, it prevents the server from hanging.
Bug: https://bugzilla.redhat.com/643656
Reported by: Pasi Karkkainen, Patrick Monnerat
Dan Fandrich [Thu, 28 Oct 2010 22:47:57 +0000 (15:47 -0700)]
Removed a leftover mention of FTP in an error message
Dan Fandrich [Thu, 21 Oct 2010 21:33:35 +0000 (14:33 -0700)]
Removed the native Makefile.riscos files
These haven't worked in at least 8 years due to missing source
files, and most active RiscOS developers these days apparently
cross-compile anyway.
Signed-off-by: James Bursa <james@zamez.org>
Dan Fandrich [Thu, 21 Oct 2010 01:15:14 +0000 (18:15 -0700)]
Lightened the stack in wc_statemach to permit deeper recursion
Also, added a few hints to help compilers to perform tail call
recursion optimization.
Daniel Stenberg [Wed, 20 Oct 2010 21:31:34 +0000 (23:31 +0200)]
SSH: use libssh2_session_handshake()
In libssh2 1.2.8, libssh2_session_handshake() replaces
libssh2_session_startup() to fix the previous portability problem with
the socket type that was too small for win64 and thus easily could cause
crashes and more.
Daniel Stenberg [Wed, 20 Oct 2010 21:29:37 +0000 (23:29 +0200)]
SSH: avoid using the libssh2_ prefix
It is a bad idea to use the public prefix used by another library and
now we realize that libssh2 introduces a symbol in the upcoming version
1.2.8 that conflicts with our static function named libssh2_free.
Daniel Stenberg [Wed, 20 Oct 2010 12:57:43 +0000 (14:57 +0200)]
formdata: provide error message
When failing to build form post due to an error, the code now does a
proper failf(). Previously libcurl would report an error like "failed
creating formpost data" when a file wasn't possible to open which was
not easy for users to figure out.
I also lower cased a function name to be named more curl-style and
removed some unnecessary code.
Daniel Stenberg [Tue, 19 Oct 2010 18:20:06 +0000 (20:20 +0200)]
URL-parsing: consider ? a divider
The URL parser got a little stricter as it now considers a ? to be a
host name divider so that the slightly sloppier URLs work too. The
problem that made me do this change was the reported problem with an URL
like: www.example.com?email=name@example.com This form of URL is not
really a legal URL (due to the missing slash after the host name) but is
widely accepted by all major browsers and libcurl also already accepted
it, it was just the '@' letter that triggered the problem now.
The side-effect of this change is that now libcurl no longer accepts the
? letter as part of user-name or password when given in the URL, which
it used to accept (and is tested in test 191). That letter is however
mentioned in RFC3986 to be required to be percent encoded since it is
used as a divider.
Bug: http://curl.haxx.se/bug/view.cgi?id=3090268
Daniel Stenberg [Tue, 19 Oct 2010 15:50:10 +0000 (17:50 +0200)]
curl_easy_setopt.3: spellfix
Daniel Stenberg [Tue, 19 Oct 2010 15:48:51 +0000 (17:48 +0200)]
curl_easy_setopt.3: CURLOPT_USE_SSL is not just for FTP
It is for FTP, SMTP, POP3, IMAP at least.
Daniel Stenberg [Mon, 18 Oct 2010 14:20:13 +0000 (16:20 +0200)]
krb4.h: removed unused prototypes
Daniel Stenberg [Mon, 18 Oct 2010 08:00:37 +0000 (10:00 +0200)]
krb4: make a few functions static
Daniel Stenberg [Sun, 17 Oct 2010 16:56:30 +0000 (18:56 +0200)]
TODO-RELEASE: cleanup for 7.21.3 works
"SFTP resume with 4GB file does not work" is now removed as I'm sure
this is really a libssh2 bug and not a libcurl bug.
7.21.2 is released already
Daniel Stenberg [Sun, 17 Oct 2010 16:55:36 +0000 (18:55 +0200)]
RELEASE-NOTES: sync with
09a2d93a0f17ca
Daniel Stenberg [Sun, 17 Oct 2010 16:50:38 +0000 (18:50 +0200)]
http_chunks: remove debug output
Accidentally left in there during my previous debugging of this
Daniel Stenberg [Thu, 14 Oct 2010 20:33:20 +0000 (22:33 +0200)]
Curl_setopt: disallow CURLOPT_USE_SSL without SSL support
In order to avoid for example the pingpong protocols to issue STARTTLS
(or equivalent) even though there's no SSL support built-in.
Reported by: Sune Ahlgren
Bug: http://curl.haxx.se/mail/archive-2010-10/0045.html
Daniel Stenberg [Thu, 14 Oct 2010 20:17:32 +0000 (22:17 +0200)]
options: check for features for some options
Some options, such as the automatic decompression and some SSL related
ones now will bail out if the underlying libcurl doesn't have support
for the particular feature needed.
Dan Fandrich [Thu, 14 Oct 2010 19:45:01 +0000 (12:45 -0700)]
Fixed the IPv6 host address in test1203
Reported by: Christian Weisgerber
Bug: http://curl.haxx.se/bug/view.cgi?id=3087479
Daniel Stenberg [Thu, 14 Oct 2010 12:06:07 +0000 (14:06 +0200)]
curl_easy_setopt.3: clarify CURLOPT_CRLF
The option takes a parameter that should be 1 or 0 to enable or disable
the feature.
URL: http://curl.haxx.se/bug/view.cgi?id=3086428
Guenter Knauf [Wed, 13 Oct 2010 23:22:40 +0000 (01:22 +0200)]
Some more small Watcom makefile fixes.
Guenter Knauf [Wed, 13 Oct 2010 22:57:36 +0000 (00:57 +0200)]
Added --noconfigure switch to testcurl.pl.
Guenter Knauf [Wed, 13 Oct 2010 15:29:47 +0000 (17:29 +0200)]
Modified Watcom makefiles to work on Linux too.
Guenter Knauf [Wed, 13 Oct 2010 14:38:24 +0000 (16:38 +0200)]
Added MingW32 rtmp target; changed Watcom targets.
Modified Watcom targets to avoid backslashs so that they can
work on Linux too.
Daniel Stenberg [Tue, 12 Oct 2010 22:26:19 +0000 (00:26 +0200)]
gitignore: ignore Makefile.vc10.dist made by maketgz
Daniel Stenberg [Tue, 12 Oct 2010 22:21:39 +0000 (00:21 +0200)]
curlver.h: start over at 7.21.3
Daniel Stenberg [Tue, 12 Oct 2010 22:21:00 +0000 (00:21 +0200)]
RELEASE-NOTES: start over towards 7.21.3
Daniel Stenberg [Tue, 12 Oct 2010 22:20:37 +0000 (00:20 +0200)]
THANKS: added contributors from 7.21.2
Daniel Stenberg [Tue, 12 Oct 2010 21:28:44 +0000 (23:28 +0200)]
RELEASE-NOTES: synced with
ecd624b8e774a85
Julien Chaffraix [Tue, 12 Oct 2010 15:27:56 +0000 (08:27 -0700)]
CMake: Build fix.
Do not match the trailing '\n' in the regular expression as this would
make us dump a ) parenthesis on a new line.
This fixes the following error:
would get transformed into:
)
Bug: http://curl.haxx.se/mail/lib-2010-10/0065.html
Reported by: Dimitre Dimitrov
Daniel Stenberg [Thu, 16 Sep 2010 21:11:48 +0000 (23:11 +0200)]
header_callback: strip off file path separated with backslashes
If the filename contains a backslash, only use filename portion. The
idea is that even systems that don't handle backslashes as path
separators probably want that path removed for convenience.
This flaw is considered a security problem, see the curl security
vulnerability http://curl.haxx.se/docs/adv_20101013.html
Dan Fandrich [Tue, 12 Oct 2010 19:12:40 +0000 (12:12 -0700)]
Get the curl source files for Amiga from Makefile.inc
This is similar to how it's done in the lib directory.
The Amiga build appears to have been broken for a year because
of a missing homedir.c
Dan Fandrich [Tue, 12 Oct 2010 18:22:18 +0000 (11:22 -0700)]
Added section on server-supplied names to security considerations
Guenter Knauf [Tue, 12 Oct 2010 13:31:41 +0000 (15:31 +0200)]
Fixed Watcom makefile.
Guenter Knauf [Tue, 12 Oct 2010 04:55:01 +0000 (06:55 +0200)]
Added build bits for librtmp / libssh2 to Watcom makefiles.
Guenter Knauf [Tue, 12 Oct 2010 02:31:56 +0000 (04:31 +0200)]
Added build bits for librtmp to NetWare makefiles.
Daniel Stenberg [Mon, 11 Oct 2010 22:01:40 +0000 (00:01 +0200)]
SFTP: more ignoring negative file sizes
As the change in
5f0ae7a0626cbe709 added a precaution against negative
file sizes that for some reason managed to get returned, this change now
introduces the same check at the second place in the code where the file
size from the libssh2 stat call is used.
This check might not be suitable for a 32 bit curl_off_t, but libssh2.h
assumes long long to work and to be 64 bit so I believe such a small
curl_off_t will be very unlikely to occur in the wild.
Daniel Stenberg [Mon, 11 Oct 2010 19:31:12 +0000 (21:31 +0200)]
SMTP: debug output for no known auth mechanisms supported
... and some minor source code whitespace edits
Daniel Stenberg [Mon, 11 Oct 2010 12:32:37 +0000 (14:32 +0200)]
test: urlglob error messages have no extra newline anymore
Guenter Knauf [Sun, 10 Oct 2010 22:39:24 +0000 (00:39 +0200)]
Added build bits for librtmp to MingW32 makefiles.
Daniel Stenberg [Fri, 8 Oct 2010 21:20:26 +0000 (23:20 +0200)]
RELEASE-NOTES: synced with
61f4cdb73ae4
Daniel Stenberg [Fri, 8 Oct 2010 21:12:34 +0000 (23:12 +0200)]
globbing: fix crash on unballanced open brace
Having an open brace without a closing brace caused a segfault.
Having a closing brace too many caused a silent error to occur, which
caused curl to bail out and return an error code but no error message
was shown. It does now!
All error message outputs no longer wrongly get _two_ newlines written
after the error message.
Reported by: Vlad Ureche
Bug: http://curl.haxx.se/bug/view.cgi?id=3083942
Dan Locks [Thu, 7 Oct 2010 16:05:36 +0000 (18:05 +0200)]
libcurl.m4: AC_PATH_PROG fixes
The invocation of autoconf's AC_PATH_PROG( ) is not quite right for
finding curl-config. This fix corrects the negative case (where
curl-config is not found).
Daniel Stenberg [Wed, 6 Oct 2010 18:03:13 +0000 (20:03 +0200)]
FAQ: added "How do I submit my patch?"
Daniel Stenberg [Tue, 5 Oct 2010 13:00:19 +0000 (15:00 +0200)]
examples: use example.com in example URLs
Daniel Stenberg [Mon, 4 Oct 2010 09:53:33 +0000 (11:53 +0200)]
TODO-RELEASE: libidn problem not repeatable
"261 - configure and libidn" is removed from the list since Julien
Chaffraix tried to repeat it but failed and the reporter did not return
to provide further details.
Reported by: Lyndon Hill
Bug: http://curl.haxx.se/mail/lib-2010-07/0029.html
Daniel Stenberg [Mon, 4 Oct 2010 09:50:43 +0000 (11:50 +0200)]
libcurl.m4: mention argument is PREFIX
The macro provides a --with-libcurl option that expects a PREFIX to be
specified and not actually a "directory" in which libcurl will be found.
This now spells that out more clearly.
Reported by: Dan Locks
Bug: http://curl.haxx.se/bug/view.cgi?id=3079891
Guenter Knauf [Sun, 3 Oct 2010 21:02:41 +0000 (23:02 +0200)]
Some NetWare makefile tweaks.
Renamed SDK_* to NDK_*; made NDK_* defines overwriteable from
environment; removed now obsolete YACC macro;
moved some curl_config.h defines to IPv6 section since they
are only needed when IPv6 is enabled - this makes libcurl compile
with older NDKs too which were not IPv6-aware.
Daniel Stenberg [Sat, 2 Oct 2010 12:37:38 +0000 (14:37 +0200)]
TODO-RELEASE: 416 error fixed
"3076808 Requests fail silently following a 416 error" done
Julien Chaffraix [Sat, 2 Oct 2010 07:54:34 +0000 (00:54 -0700)]
krb5-gssapi: Removed a memory leak in krb5_auth.
We forgot to release the buffer passed to gss_init_sec_context.
The previous logic was difficult to read as we were reusing the same
variable (gssbuf) for both input buffer and output buffer. Splitted the
logic in 2 variables to better underline who needs to be released.
Also made the code break at 80 lines.
Julien Chaffraix [Sat, 2 Oct 2010 07:39:51 +0000 (00:39 -0700)]
krb5-gssapi: Made the function always return a value.
kr5_auth missed a final 'return' statement. This is not an error in
gcc but can lead to potential bugs.
Julien Chaffraix [Sat, 2 Oct 2010 07:33:24 +0000 (00:33 -0700)]
krb5-gssapi: Delete the GSS-API context.
This fixes a memory leak related to the GSS-API code.
Added a krb5_init and krb5_end functions. Also removed a work-around
the lack of proper initialization of the GSS-API context.
Daniel Stenberg [Fri, 1 Oct 2010 22:22:48 +0000 (00:22 +0200)]
HTTP: remove special case for 416
It was pointed out that the special case libcurl did for 416 was
incorrect and wrong. 416 is not really different to other errors so the
response body must be handled like for other errors/http responses.
Reported by: Chris Smowton
Bug: http://curl.haxx.se/bug/view.cgi?id=3076808
Dan Fandrich [Fri, 1 Oct 2010 22:21:59 +0000 (00:21 +0200)]
sws: Added writedelay HTTP server command
This delays between write operations, hopefully making it easier
to spot problems where libcurl doesn't flush the socket properly
before waiting for the next response.
Daniel Stenberg [Fri, 1 Oct 2010 20:47:45 +0000 (22:47 +0200)]
TODO-RELEASE: no bug in ftp_nextconnect
The issue named "266 - Bug in ftp_nextconnect?" was deemed to not be a
bug and instead resulted in clarified docs.
Daniel Stenberg [Fri, 1 Oct 2010 17:52:53 +0000 (19:52 +0200)]
curl_easy_setopt.3: CURLOPT_DIRLISTONLY implies dir list
Make it explicit that setting CURLOPT_DIRLISTONLY to 1 will make libcurl
to list the directory.
Daniel Stenberg [Thu, 30 Sep 2010 22:03:17 +0000 (00:03 +0200)]
RELEASE-NOTES: synced up to
588402585bae
Daniel Stenberg [Thu, 30 Sep 2010 21:58:01 +0000 (23:58 +0200)]
TODO-RELEASE: move new features to next release
Daniel Stenberg [Thu, 30 Sep 2010 21:14:58 +0000 (23:14 +0200)]
README.ares: we know require c-ares 1.6.0
Daniel Stenberg [Thu, 30 Sep 2010 21:08:37 +0000 (23:08 +0200)]
SFTP: avoid downloading negative sizes!
It is still not clarified exactly why this happens, but libssh2
sometimes report a negative file size for the remote SFTP file and that
deeply confuses libcurl (or crashes it) so this precaution is added to
avoid badness.
Reported by: Ernest Beinrohr
Bug: http://curl.haxx.se/bug/view.cgi?id=3076430
Daniel Stenberg [Thu, 30 Sep 2010 21:07:20 +0000 (23:07 +0200)]
TODO-RELEASE: drop curl_easy_setoptv
I haven't read any really convincing arguments for adding it
Dirk Manske [Thu, 30 Sep 2010 09:33:33 +0000 (11:33 +0200)]
multi & hiper examples: updates and cleanups
all multi and hiper examples:
* don't loop curl_multi_perform calls, that was <7.20.0 style, currently
the exported multi functions will not return CURLM_CALL_MULTI_PERFORM
all hiper examples:
* renamed check_run_count to check_multi_info
* don't compare current running handle count with previous value, this
was the wrong way to check for finished requests, simply call
curl_multi_info_read
* it's also safe to call curl_multi_remove_handle inside the
curl_multi_info_read loop.
ghiper.c:
* replaced curl_multi_socket (that function is marked as obsolete) calls
with curl_multi_socket_action calls (as in hiperfifo.c and
evhiperfifo.c)
ghiper.c and evhiperfifo.c:
* be smart as hiperfifo.c, don't do uncessary curl_multi_* calls in
new_conn and main
Daniel Stenberg [Tue, 28 Sep 2010 22:18:05 +0000 (00:18 +0200)]
TODO-RELEASE: one fixed, one postponed, one added
As we're already in feature freeze, I pushed the feature onwards.
Dan Fandrich [Wed, 29 Sep 2010 20:02:37 +0000 (13:02 -0700)]
Renamed test1204 to test1117 to move it into the normal range
Patrick Monnerat [Wed, 29 Sep 2010 14:56:57 +0000 (16:56 +0200)]
Add gopher protocol definition to ILE/RPG binding.
OS400 compile script in test dir updated for chkhostname.
Julien Chaffraix [Mon, 27 Sep 2010 05:44:42 +0000 (22:44 -0700)]
krb5-gssapi: Remove several memory leaks.
Remove a leak seen on Kerberos/MIT (gss_OID is copied internally and
we were leaking it). Now we just pass NULL as advised in RFC2744.
|tmp| was never set back to buf->data.
Cleaned up Curl_sec_end to take into account failure in Curl_sec_login
(where conn->mech would be NULL but not conn->app_data or
conn->in_buffer->data).
Julien Chaffraix [Mon, 27 Sep 2010 05:35:00 +0000 (22:35 -0700)]
security.c: Remove Curl_sec_fflush_fd.
The current implementation would make us send wrong data on a closed
socket. We don't buffer our data so the method can be safely removed.
Julien Chaffraix [Mon, 27 Sep 2010 02:16:38 +0000 (19:16 -0700)]
security.c: We should always register the socket handler.
Following a change in the way socket handler are registered, the custom
recv and send method were conditionaly registered.
We need to register them everytime to handle the ftp security
extensions.
Re-added the clear text handling in sec_recv.
Julien Chaffraix [Mon, 27 Sep 2010 02:14:50 +0000 (19:14 -0700)]
security.c: Fix Curl_sec_login after rewrite.
Curl_sec_login was returning the opposite result that the code in ftp.c
was expecting. Simplified the return code (using a CURLcode) so to see
more clearly what is going on.
Julien Chaffraix [Mon, 27 Sep 2010 01:04:48 +0000 (18:04 -0700)]
security.c: Readd the '\n' to the infof() calls.
They are not automatically added and make the output of the verbose
mode a lot more readable.
Julien Chaffraix [Mon, 27 Sep 2010 00:57:03 +0000 (17:57 -0700)]
security.c: Fix typo (PSBZ -> PBSZ)
Julien Chaffraix [Sun, 26 Sep 2010 23:17:01 +0000 (16:17 -0700)]
security.c: Fix ftp_send_command.
My use of va_args was completely wrong. Fixed the usage so that
we send the right commands!
Daniel Stenberg [Tue, 28 Sep 2010 21:46:14 +0000 (23:46 +0200)]
curl_easy_escape: don't escape "unreserved" characters
According to RFC3986 section 2.3 the letters -, ., _ and ~ should not be
percent-encoded.
Reported by: Miguel Diaz
Bug: http://curl.haxx.se/mail/lib-2010-09/0227.html