platform/upstream/nodejs.git
9 years agodocs: simple project messaging.
Mikeal Rogers [Tue, 2 Dec 2014 02:06:21 +0000 (18:06 -0800)]
docs: simple project messaging.

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/iojs/io.js/pull/24

9 years agodocs: add issue contributing section
Max Ogden [Tue, 2 Dec 2014 01:31:19 +0000 (17:31 -0800)]
docs: add issue contributing section

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/iojs/io.js/pull/21

9 years agotest: extend timeouts in child/exec tests
Rod Vagg [Sat, 29 Nov 2014 02:36:14 +0000 (13:36 +1100)]
test: extend timeouts in child/exec tests

increased resillence on slower computers

Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/iojs/io.js/pull/10

9 years agotest: bump --stack-size to stop child fails on ARM
Rod Vagg [Sat, 29 Nov 2014 10:52:51 +0000 (21:52 +1100)]
test: bump --stack-size to stop child fails on ARM

On ARM, we get a "Maximum call stack size exceeded" when using
require() in the child process, bump it up a bit to avoid the
failures so we can test what we are actually after

Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/iojs/io.js/pull/14

9 years agodeps: openssl - add x32 support
Ben Noordhuis [Tue, 14 Oct 2014 20:52:16 +0000 (22:52 +0200)]
deps: openssl - add x32 support

This commit adds preliminary x32 support.  Configure with:

    $ ./configure --dest-cpu=x32

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agoopenssl: fix keypress requirement in apps on win32
Fedor Indutny [Wed, 11 Dec 2013 17:19:04 +0000 (21:19 +0400)]
openssl: fix keypress requirement in apps on win32

Original source:

http://openssl.6102.n7.nabble.com/PATCH-s-client-Fix-keypress-requirement-with-redirected-input-on-Windows-td46787.html

Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agotest: don't remove empty.txt on win32
Rod Vagg [Thu, 27 Nov 2014 22:43:15 +0000 (09:43 +1100)]
test: don't remove empty.txt on win32

on win32 we use empty.txt in the fixtures directory, otherwise we
use a file constructed specifically for this test due to POSIX
socket path length limitations, in which case we need to do
appropriate cleanup

Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/iojs/io.js/pull/2

9 years agotest: another fix for test-crypto-stream
Fedor Indutny [Fri, 28 Nov 2014 14:13:12 +0000 (17:13 +0300)]
test: another fix for test-crypto-stream

Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agotest: fix test-crypto-stream
Fedor Indutny [Wed, 15 Oct 2014 16:50:15 +0000 (20:50 +0400)]
test: fix test-crypto-stream

Because of constant-timeness change made in openssl-1.0.1j the error is
no longer returned from EVP_DecryptFinal_ex. Now it just return 0, and
thus the error message does not contain proper error code. Adapt to this
change, there is not much that we could do about it.

9 years agopunycode: update to v1.3.2
Mathias Bynens [Fri, 28 Nov 2014 09:50:12 +0000 (10:50 +0100)]
punycode: update to v1.3.2

Changes since v1.2.3:

* Email address support in `toASCII` and `toUnicode`
* `punycode.ucs2.encode` now no longer mutates the `codePoints`
  argument
* Ensure trailing `.` in domain names are preserved
* Some minor code cleanup + bug fixes

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/iojs/io.js/pull/6

9 years agodeps: update openssl to 1.0.1j
Fedor Indutny [Thu, 27 Nov 2014 15:37:49 +0000 (18:37 +0300)]
deps: update openssl to 1.0.1j

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/iojs/io.js/pull/1

9 years agotest: fix floating point NaN tests on mips
James Cowgill [Wed, 26 Nov 2014 17:06:19 +0000 (17:06 +0000)]
test: fix floating point NaN tests on mips

MIPS machines use a slightly different format for NaNs (still perfectly
valid though). This patch adjusts the buffer testcases to allow for
this.

See https://en.wikipedia.org/wiki/NaN#Encoding for some more info.

Based on patch applied to debian by Jérémy Lal <kapouer@melix.org>

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8793

9 years agocrypto: proper fix for d7e700's cause
Fedor Indutny [Wed, 26 Nov 2014 11:37:14 +0000 (14:37 +0300)]
crypto: proper fix for d7e700's cause

Remove useless tests, and `ERR_peek_error()` calls. Things are being set
in a proper order now and there is no need for hacky extra checks.

The right order was:

1. Set certificate
2. Set key

Because setting certificate doesn't properly handle key mismatch errors.

Fix: node-forward/node#67
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/68

9 years agocrypto: allow creation of GCM ciphers with createCipher
Calvin Metcalf [Tue, 11 Nov 2014 18:38:02 +0000 (13:38 -0500)]
crypto: allow creation of GCM ciphers with createCipher

Sets the authenticated encryption specific methods ([set|get]AuthTag and setAAD)
on the Cipher prototype not just the Cipheriv prototype.

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8711

9 years agocrypto: throw if the key doesn't match cert
Fedor Indutny [Mon, 24 Nov 2014 13:17:13 +0000 (16:17 +0300)]
crypto: throw if the key doesn't match cert

fix joyent/node#8770
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/66

9 years agotest: named pipe is invalid when appending .txt
Rod Vagg [Wed, 19 Nov 2014 01:31:46 +0000 (17:31 -0800)]
test: named pipe is invalid when appending .txt

On Windows, appending '.txt' to a named pipe does not produce a valid
regular file name.  We want an empty _file_, not an invalid named pipe.
Fix-up for commit 1f79e4f.

PR-URL: https://github.com/node-forward/node/pull/63
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoMerge remote-tracking branch 'joyent/v0.12' into v0.12
Ben Noordhuis [Sat, 22 Nov 2014 16:34:31 +0000 (17:34 +0100)]
Merge remote-tracking branch 'joyent/v0.12' into v0.12

Conflicts:
Makefile
deps/v8/src/base/platform/platform.h

PR-URL: https://github.com/node-forward/node/pull/65
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agolib: turn on strict mode
Ben Noordhuis [Sat, 22 Nov 2014 15:59:48 +0000 (16:59 +0100)]
lib: turn on strict mode

Turn on strict mode for the files in the lib/ directory.  It helps
catch bugs and can have a positive effect on performance.

PR-URL: https://github.com/node-forward/node/pull/64
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agopath: added parse() and format() functions
Rory Bradford [Tue, 8 Apr 2014 21:48:24 +0000 (22:48 +0100)]
path: added parse() and format() functions

The parse() function splits a path and returns an object
with the different elements. The format() function is the
reverse of this and adds an objects corresponding path
elements to make up a string. Fixes #6976.

Fixes: https://github.com/joyent/node/issues/6976
PR-URL: https://github.com/joyent/node/pull/8750
Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
9 years agopath: allow calling platform specific methods
Timothy J Fontaine [Tue, 11 Jun 2013 00:09:54 +0000 (17:09 -0700)]
path: allow calling platform specific methods

Add path.posix and path.win32 which have the specific methods like
resolve and normalize so you can specifically normalize or resolve
based on the target platform.

PR-URL: https://github.com/joyent/node/pull/5661
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: correct broken link in net.markdown
Steve Sharp [Thu, 20 Nov 2014 18:35:30 +0000 (10:35 -0800)]
doc: correct broken link in net.markdown

Fixes broken link to Readable Stream documentation.

Fixes: https://github.com/joyent/node/issues/8464
PR-URL: https://github.com/joyent/node/pull/8756
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agotls: do not hang without `newSession` handler
Fedor Indutny [Tue, 4 Nov 2014 16:14:55 +0000 (11:14 -0500)]
tls: do not hang without `newSession` handler

When listening for client hello parser events (like OCSP requests), do
not hang if `newSession` event handler is not present.

fix joyent/node#8660
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/47

9 years agolib: add setFlagsFromString() to tracing module
Ben Noordhuis [Fri, 14 Nov 2014 22:20:07 +0000 (23:20 +0100)]
lib: add setFlagsFromString() to tracing module

Expose v8::V8::SetFlagsFromString() on tracing.v8 in lib/tracing.js.

PR-URL: https://github.com/node-forward/node/pull/62
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agodoc: clarify return value of http.createServer
MK Safi [Wed, 14 Aug 2013 23:15:49 +0000 (02:15 +0300)]
doc: clarify return value of http.createServer

PR-URL: https://github.com/joyent/node/pull/6054
Reviewed-by: Isaac Z. Schlueter <i@izs.me>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agosrc: remove static variables from tls_wrap
Ben Noordhuis [Wed, 12 Nov 2014 15:25:07 +0000 (16:25 +0100)]
src: remove static variables from tls_wrap

Remove the error message globals.  More prep work for multi-isolate
support.

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/node-forward/node/pull/58

9 years agosrc: turn two global vars into local vars
Ben Noordhuis [Wed, 12 Nov 2014 14:29:34 +0000 (15:29 +0100)]
src: turn two global vars into local vars

Bring us a little closer to multi-isolate readiness by removing two
global variables.

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/node-forward/node/pull/58

9 years agotest: fix test-cluster-eaccess to work on windows
Rod Vagg [Thu, 13 Nov 2014 05:35:20 +0000 (15:35 +1000)]
test: fix test-cluster-eaccess to work on windows

properly create an EADDRINUSE condition rather than
simulating one with a plain file

PR-URL: https://github.com/node-forward/node/pull/59
Reviewed-By: Bert Belder <bertbelder@gmail.com>
9 years agotest: use common.PIPE for emptyTxt path
Rod Vagg [Thu, 6 Nov 2014 04:30:10 +0000 (14:30 +1000)]
test: use common.PIPE for emptyTxt path

Work-around for long paths exceeding limits for UNIX socket binds,
emptyTxt would otherwise be burried deep in the fixtures directory.

PR-URL: https://github.com/node-forward/node/pull/51
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agodoc: fix typos in http.markdown
Artur Cistov [Fri, 15 Feb 2013 22:21:48 +0000 (22:21 +0000)]
doc: fix typos in http.markdown

PR-URL: https://github.com/joyent/node/pull/4784
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodns: propagate domain for c-ares methods
Chris Dickinson [Sun, 16 Nov 2014 02:33:20 +0000 (18:33 -0800)]
dns: propagate domain for c-ares methods

Fixes: https://github.com/joyent/node/issues/5471
PR-URL: https://github.com/joyent/node/pull/8732
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agoprocess: pid can be a string in process.kill()
Sam Roberts [Wed, 8 Oct 2014 21:36:21 +0000 (14:36 -0700)]
process: pid can be a string in process.kill()

Not allowing string was a change from v0.10 behaviour, commented on in
joyent/node#7991. Allow them again, but still check that argument is
numberish. Also, simplify the fragile and non-portable test code
introduced in 832ec1cd507 that required fixups 2a415358ee, and
ef3c4ed3d.

PR-URL: https://github.com/joyent/node/pull/8531
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agofs: fix symlink error message
Vladimir Kurchatkin [Sat, 1 Nov 2014 10:07:03 +0000 (13:07 +0300)]
fs: fix symlink error message

the arguments were swapped, so fs.symlink{Sync,} would
report that the wrong file EEXIST'd in error.

Fixes: https://github.com/joyent/node/issues/8651
Fixes: https://github.com/joyent/node/issues/4314
Fixes: https://github.com/joyent/node/issues/5381
PR-URL: https://github.com/joyent/node/pull/8657
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agosrc: fixups after v8 upgrade
Ben Noordhuis [Fri, 14 Nov 2014 00:26:22 +0000 (01:26 +0100)]
src: fixups after v8 upgrade

* v8::Platform has a new MonotonicallyIncreasingTime() method,
  implement it.

* The ASCII apocalypse continues with the replacement of external
  ASCII strings with external one byte strings.

9 years agodeps: fix postmortem-metadata generator in v8
Refael Ackermann [Mon, 29 Sep 2014 09:20:50 +0000 (13:20 +0400)]
deps: fix postmortem-metadata generator in v8

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/8476

9 years agodeps: upgrade v8 to 3.30.37
Ben Noordhuis [Thu, 13 Nov 2014 23:52:27 +0000 (00:52 +0100)]
deps: upgrade v8 to 3.30.37

9 years agocrypto: fix X509 cert memory leak in GetPeerCert
Fedor Indutny [Tue, 11 Nov 2014 05:08:09 +0000 (08:08 +0300)]
crypto: fix X509 cert memory leak in GetPeerCert

`SSL_get_peer_certificate` returns referenced X509 object, we should
decrement the reference count once it is not needed.

Fix joyent/node#8674
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/56

9 years agomodule: correct the order of the assertions
haoxin [Tue, 9 Sep 2014 02:22:37 +0000 (10:22 +0800)]
module: correct the order of the assertions

this puts the type-checking assertions in require
into proper order.

PR-URL: https://github.com/joyent/node/pull/8333
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
9 years agobuild: i18n: support little-endian machines
Steven Loomis [Tue, 5 Aug 2014 01:00:55 +0000 (21:00 -0400)]
build: i18n: support little-endian machines

Note that this may not affect anything until powerpc support lands in
v8.

Related: https://github.com/srl295/node/issues/7
Related: https://github.com/srl295/node/commit/ba8ab91bc4762ade646474276c4a4b8cdaf83115
PR-URL: https://github.com/joyent/node/pull/8712
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agobuild: i18n: fix icu toolset dependencies
Steven R. Loomis [Thu, 6 Nov 2014 03:09:43 +0000 (19:09 -0800)]
build: i18n: fix icu toolset dependencies

So what I did here is to make the icutools library actually contain the
entire ICU dependencies needed for host-side tools. Sadly, this will
build ICU twice, but avoids conflicts between host and target side.
This all seems like a gyp bug of some sort, but without docs for
toolsets, who’s to say?

I removed the icuio library as a separate target, because it was only
used by the host-side tools.

PR-URL: https://github.com/joyent/node/pull/8681
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agobuild: i18n: fix build on OSX
Steven R. Loomis [Sat, 4 Oct 2014 06:10:29 +0000 (23:10 -0700)]
build: i18n: fix build on OSX

Fix config option that doesn't work with OSX.

Fixes: https://github.com/joyent/node/issues/8521
PR-URL: https://github.com/joyent/node/pull/8602
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agosrc: fix windows build error
Ben Noordhuis [Tue, 11 Nov 2014 11:06:55 +0000 (12:06 +0100)]
src: fix windows build error

Fix a Windows-only build error that was introduced in
commit 1183ba4 ("zlib: support concatenated gzip files").

Rename the NO_ERROR and FAILED enumerations, they conflict
with macros of the same name in <winerror.h>.

PR-URL: https://github.com/node-forward/node/pull/57
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agolib,src: make os.endianness() inlinable
Ben Noordhuis [Mon, 10 Nov 2014 23:40:58 +0000 (00:40 +0100)]
lib,src: make os.endianness() inlinable

Turn os.endianness() from a run-time function into a pure JS function.
Upsides: makes it a good candidate for inlining at the call site.
Downsides: none that I can think of.

PR-URL: https://github.com/node-forward/node/pull/55
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agodoc: note ability to require files within packages
sudodoki [Mon, 16 Jun 2014 22:05:58 +0000 (01:05 +0300)]
doc: note ability to require files within packages

Adding note to api/modules.markdown about ability to
load arbitrary path from modules from node_module path
by adding reference to path after module name in call
to require()

PR-URL: https://github.com/joyent/node/pull/7794
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
9 years agotls: remove tls.createSecurePair code deprecation
Jackson Tian [Mon, 10 Nov 2014 05:09:58 +0000 (13:09 +0800)]
tls: remove tls.createSecurePair code deprecation

In https://github.com/joyent/node/pulls/8695, the deprecation was
removed from doc.  This removes the deprecation from the code.

PR-URL: https://github.com/joyent/node/pull/8700
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agotest: kill children before cluster parent
Rod Vagg [Sat, 8 Nov 2014 09:03:20 +0000 (20:03 +1100)]
test: kill children before cluster parent

Killing the cluster master first on Windows causes an ESRCH when killing
the children as the OS takes care of them itself.

PR-URL: https://github.com/node-forward/node/pull/53
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agozlib: support concatenated gzip files
Luis Reis [Tue, 9 Sep 2014 16:30:15 +0000 (17:30 +0100)]
zlib: support concatenated gzip files

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: https://github.com/joyent/node/pull/6442

9 years agocrypto: escape DNS altname
Fedor Indutny [Wed, 5 Nov 2014 03:24:19 +0000 (22:24 -0500)]
crypto: escape DNS altname

Vulnerability credit goes to:

    Calvin Liang conradjliang@hotmail.com

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: ...private

9 years agodoc: remove tls.createSecurePair deprecation
Chris Dickinson [Fri, 7 Nov 2014 22:24:12 +0000 (14:24 -0800)]
doc: remove tls.createSecurePair deprecation

pending tls.TLSSocket growing the ability to work
with streams, createSecurePair will remain.

PR-URL: https://github.com/joyent/node/pull/8695
Reviewed-by: Fedor Indutny <fedor@indutny.com>
9 years agouv: revert change causing build failures
Trevor Norris [Fri, 7 Nov 2014 21:44:09 +0000 (13:44 -0800)]
uv: revert change causing build failures

Revert uv_thread_self() to return unsigned long instead of uv_thread_t.
This was causing a build failure on Windows and is only a temporary fix
until the proper patch lands upstream.

Reverts: https://github.com/joyent/libuv/commit/59658a8
Fixes: ce112c2 "deps: update uv to v1.0.0-rc2"

9 years agocore: fix usage of uv_cwd
Saúl Ibarra Corretgé [Fri, 17 Oct 2014 07:31:59 +0000 (09:31 +0200)]
core: fix usage of uv_cwd

It was modified in libuv to be consistent with uv_exepath and not
include the trailing NULL byte in the returned size.

PR-URL: https://github.com/joyent/node/pull/8566
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agocore: replace uv_fs_readdir with uv_fs_scandir
Saúl Ibarra Corretgé [Fri, 17 Oct 2014 07:31:23 +0000 (09:31 +0200)]
core: replace uv_fs_readdir with uv_fs_scandir

PR-URL: https://github.com/joyent/node/pull/8566
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agodeps: update uv to v1.0.0-rc2
Saúl Ibarra Corretgé [Mon, 20 Oct 2014 22:45:30 +0000 (00:45 +0200)]
deps: update uv to v1.0.0-rc2

PR-URL: https://github.com/joyent/node/pull/8566
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agotest: use common.PIPE in simple/test-cluster-eaccess
Rod Vagg [Wed, 5 Nov 2014 23:03:50 +0000 (09:03 +1000)]
test: use common.PIPE in simple/test-cluster-eaccess

PR-URL: https://github.com/node-forward/node/pull/50
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agotest: unlink custom unix socket before test
Ben Noordhuis [Wed, 29 Oct 2014 16:21:12 +0000 (17:21 +0100)]
test: unlink custom unix socket before test

Unlink NODE_COMMON_PIPE before running the test if set in the
environment.  The test runner won't do it for us like it does
for files in test/tmp.

PR-URL: https://github.com/node-forward/node/pull/40
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agobuild: add rpmbuild .spec file
Ben Noordhuis [Fri, 5 Jul 2013 18:10:25 +0000 (20:10 +0200)]
build: add rpmbuild .spec file

Add a .spec file and a rpmbuild(1) driver script.  Useful for people
on RHEL-based systems that want to compile and package from source.

PR-URL: https://github.com/node-forward/node/pull/10
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agosrc: network interface names are UTF-8 encoded
Ben Noordhuis [Mon, 3 Nov 2014 15:42:07 +0000 (16:42 +0100)]
src: network interface names are UTF-8 encoded

Fixes a bug that was introduced in commit f674b09 when v8::String::New()
calls were replaced with calls to one-byte, two-byte and UTF-8 versions.
It turns out that for network interface names, using a one-byte encoding
can produce the wrong results on Windows.  Use UTF-8 instead.

Libuv on Windows correctly encodes non-ASCII characters in the interface
name as UTF-8.  On Unices however, the interface name is just a binary
string with no particular encoding; that's why on UNIX platforms, we
keep interpreting it as a one-byte string.

Fixes joyent/node#8633.

PR-URL: https://github.com/node-forward/node/pull/44
Reviewed-By: Bert Belder <bertbelder@gmail.com>
9 years agonpm: Upgrade to v2.1.6
Timothy J Fontaine [Tue, 4 Nov 2014 23:08:12 +0000 (15:08 -0800)]
npm: Upgrade to v2.1.6

9 years agotest: more thorough tests for npm
Forrest L Norvell [Wed, 24 Sep 2014 01:59:35 +0000 (18:59 -0700)]
test: more thorough tests for npm

9 years agobuild: fix build for SmartOS
Julien Gilli [Thu, 9 Oct 2014 20:01:27 +0000 (13:01 -0700)]
build: fix build for SmartOS

This change in V8: https://code.google.com/p/v8/source/detail?r=22210
has introduced a method named OS::GetCurrentThreadId which fails to
compile on OSes where a "gettid" syscall does not exist.

This build issue has been fixed upstream by several changes:
- https://code.google.com/p/v8/source/detail?r=23459.
- https://codereview.chromium.org/649553002
- https://codereview.chromium.org/642223003

Another minor fix to the upstream changes was also necessary.
See https://code.google.com/p/v8/issues/detail?id=3620 for
more information.

The other build issue was due to the fact that alloca.h is not included
by other system includes on SmartOS, which is assumed by V8.

Built and tested on Linux, MacOS X, Windows and SmartOS.

9 years agosmalloc: check if obj has external data
Vladimir Kurchatkin [Fri, 31 Oct 2014 22:15:12 +0000 (01:15 +0300)]
smalloc: check if obj has external data

PR-URL: https://github.com/joyent/node/pull/8655
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agowindows: fix process description to say "Node.js"
Rod Vagg [Tue, 4 Nov 2014 07:57:11 +0000 (17:57 +1000)]
windows: fix process description to say "Node.js"

Newer incarnations of the task manager only show the description, not
even the product name.

PR-URL: https://github.com/node-forward/node/pull/46
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuisl.nl>
9 years agonode: do not crash on IPC stdin
Fedor Indutny [Tue, 4 Nov 2014 05:08:41 +0000 (00:08 -0500)]
node: do not crash on IPC stdin

When started with IPC pipe on fd=0 child process should not crash when
referencing or using `process.stdin`.

fix joyent/node#8669

PR-URL: https://github.com/node-forward/node/pull/45
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
9 years agosrc: replace NULL with nullptr in debug agent
Ben Noordhuis [Mon, 3 Nov 2014 12:19:17 +0000 (13:19 +0100)]
src: replace NULL with nullptr in debug agent

Update the debug agent to conform to the code style in src/.

9 years agosrc: clean up root_certs iteration
Ben Noordhuis [Mon, 3 Nov 2014 11:15:52 +0000 (12:15 +0100)]
src: clean up root_certs iteration

Drop the trailing nullptr and use ARRAY_SIZE.

9 years agosrc: move debug agent from deps/ to src/
Ben Noordhuis [Mon, 3 Nov 2014 11:03:34 +0000 (12:03 +0100)]
src: move debug agent from deps/ to src/

There is not much point in keeping it a separate project because it
doesn't build standalone, plus it makes applying changes to core more
difficult because of the implicit dependency on header files in src/.

9 years agosrc: make root_certs const
Ben Noordhuis [Thu, 16 Oct 2014 21:14:45 +0000 (23:14 +0200)]
src: make root_certs const

Make the root_certs global fully const.  As a side effect, that moves it
from the .data section to the .rodata section.  Makes it a little easier
to reason about the remaining globals.

9 years agosmalloc: fix copyOnto optimization
Vladimir Kurchatkin [Tue, 28 Oct 2014 12:32:07 +0000 (15:32 +0300)]
smalloc: fix copyOnto optimization

copyOnto is broken when one argument has 1 byte size and the other > 1
byte.

PR-URL: https://github.com/joyent/node/pull/8637
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agoMerge remote-tracking branch 'joyent/v0.12' into v0.12
Ben Noordhuis [Wed, 29 Oct 2014 15:15:15 +0000 (16:15 +0100)]
Merge remote-tracking branch 'joyent/v0.12' into v0.12

Conflicts:
lib/path.js

9 years agobuild: remove python 2.7 dependency
Ben Noordhuis [Wed, 29 Oct 2014 14:43:09 +0000 (15:43 +0100)]
build: remove python 2.7 dependency

Remove the dependency on the 'sysconfig' module, it breaks the build
when $(PYTHON) is python 2.6.

PR-URL: https://github.com/node-forward/node/pull/39
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agov8_platform: fix cpplint issue
Fedor Indutny [Wed, 29 Oct 2014 01:12:49 +0000 (21:12 -0400)]
v8_platform: fix cpplint issue

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: local://fedors.head/pull/1

9 years agostream_wrap: do not crash if handle was closed
Fedor Indutny [Fri, 24 Oct 2014 15:46:25 +0000 (19:46 +0400)]
stream_wrap: do not crash if handle was closed

Ignore cases where the handle is already gone, like we do in
`handle_wrap.cc`. It should be safe to close handle and then call some
binding methods on it, since the internal handle may be shared between
`_tls_wrap.js` and `net.js` modules.

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/node-forward/node/pull/37

9 years agosrc: remove usage of extended sizeof
Nikolai Vavilov [Tue, 28 Oct 2014 17:21:08 +0000 (19:21 +0200)]
src: remove usage of extended sizeof

It's not supported in VS2013.

PR-URL: https://github.com/node-forward/node/pull/38
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agosrc: simplify v8 thread pool implementation
Ben Noordhuis [Sat, 25 Oct 2014 06:45:55 +0000 (08:45 +0200)]
src: simplify v8 thread pool implementation

This commit drops the semaphore in exchange for a second condition
variable and makes the task ring an array member instead of allocating
it on the heap.  That in turn makes size calculations a little easier
because of the array's fixed size.

PR-URL: https://github.com/node-forward/node/pull/34
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agosrc: fix uninitialized memory dereference
Ben Noordhuis [Sat, 25 Oct 2014 05:27:21 +0000 (07:27 +0200)]
src: fix uninitialized memory dereference

The elements of the heap-allocated TaskQueue::ring_ array in
src/node_v8_platform.cc were compared against without being
initialized first.

Fixes node-forward/node#33.

PR-URL: https://github.com/node-forward/node/pull/34
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agonet: add pauseOnConnect option to createServer()
cjihrig [Sat, 18 Oct 2014 01:45:40 +0000 (21:45 -0400)]
net: add pauseOnConnect option to createServer()

Currently when a server receives a new connection the underlying socket
handle begins reading data immediately. This causes problems when
sockets are passed between processes, as data can be read by the first
process and thus never read by the second process.

This commit allows sockets that are constructed with a handle to be
paused initially.

PR-URL: https://github.com/joyent/node/pull/8576
Fixes: https://github.com/joyent/node/issues/7905
Fixes: https://github.com/joyent/node/issues/7784
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agodocs: fix smalloc.dispose() example
Vladimir Kurchatkin [Tue, 21 Oct 2014 09:00:37 +0000 (13:00 +0400)]
docs: fix smalloc.dispose() example

Also couple of additions about dispose and limitations of smalloc'ed
objects.

Fixes: https://github.com/joyent/node/pull/8625
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agodoc: update compiler requirements in README
Ben Noordhuis [Mon, 27 Oct 2014 11:39:19 +0000 (12:39 +0100)]
doc: update compiler requirements in README

The latest V8 upgrade and the C++11-ification of the source code in src/
requires a recent compiler.  Update the requirements in the README.

Fixes node-forward/node#35.

PR-URL: https://github.com/node-forward/node/pull/36
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agolint: fix whitespace issues
Trevor Norris [Sat, 25 Oct 2014 21:27:23 +0000 (14:27 -0700)]
lint: fix whitespace issues

Fixes: f6e5740 "path: resolve normalize drive letter to lower case"
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
9 years agosrc: fix comparison of WCHAR with nullptr
Nikolai Vavilov [Fri, 24 Oct 2014 22:36:59 +0000 (01:36 +0300)]
src: fix comparison of WCHAR with nullptr

PR-URL: https://github.com/node-forward/node/pull/32
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoMerge remote-tracking branch 'origin/v0.12' into v0.12
Fedor Indutny [Fri, 24 Oct 2014 12:52:29 +0000 (16:52 +0400)]
Merge remote-tracking branch 'origin/v0.12' into v0.12

Conflicts:
src/cares_wrap.cc
src/env-inl.h
src/env.h
src/node.cc
src/node.h
src/node_crypto.cc

9 years agosrc: mark more destructors with override keyword
Ben Noordhuis [Thu, 23 Oct 2014 20:45:58 +0000 (22:45 +0200)]
src: mark more destructors with override keyword

The previous commits fixed oversights in destructors that should have
been marked virtual but weren't.  This commit marks destructors from
derived classes with the override keyword.

9 years agosrc: mark SSLWrap destructor as virtual
Ben Noordhuis [Thu, 23 Oct 2014 20:32:41 +0000 (22:32 +0200)]
src: mark SSLWrap destructor as virtual

Like the previous commit but this time for the SSLWrap destructor.

9 years agosrc: mark BaseObject destructor as virtual
Ben Noordhuis [Thu, 23 Oct 2014 20:22:00 +0000 (22:22 +0200)]
src: mark BaseObject destructor as virtual

Like the previous commit but this time for the BaseObject destructor.

9 years agosrc: mark AsyncWrap destructor as virtual
Ben Noordhuis [Thu, 23 Oct 2014 20:04:47 +0000 (22:04 +0200)]
src: mark AsyncWrap destructor as virtual

Make AsyncWrap::~AsyncWrap() virtual, otherwise it is unsafe to delete
a derived class through a pointer to AsyncWrap.  Fortunately, we don't
do that anywhere right now; this commit is merely a preemptive bug fix.

9 years agosrc: mark empty destructors as default
Ben Noordhuis [Wed, 22 Oct 2014 02:53:26 +0000 (04:53 +0200)]
src: mark empty destructors as default

Mark empty destructors as having a default no-op implementation.
Remove a few unused constructors and destructors while we are here.

9 years agosrc: update DISALLOW_COPY_AND_ASSIGN() to c++11
Ben Noordhuis [Wed, 22 Oct 2014 02:33:01 +0000 (04:33 +0200)]
src: update DISALLOW_COPY_AND_ASSIGN() to c++11

Mark the matrix of copy/move constructor/assignment operator as deleted.
Prevents the object from being copied around (the macro already did that
pre-C++11), but also from being moved out.

9 years agosrc: mark virtual functions with override keyword
Ben Noordhuis [Wed, 22 Oct 2014 02:26:25 +0000 (04:26 +0200)]
src: mark virtual functions with override keyword

Add `override` keywords where appropriate.  Makes maintenance easier
because the compiler will shout at you when a base class changes in
an incompatible way.

9 years agosrc: remove STATIC_ASSERT() macro
Ben Noordhuis [Wed, 22 Oct 2014 01:53:57 +0000 (03:53 +0200)]
src: remove STATIC_ASSERT() macro

This macro does not not rightfully belong in node.h, remove it.
Replace the one use site with a C++11 `static_assert` construct.

9 years agosrc: replace NULL with nullptr
Ben Noordhuis [Wed, 22 Oct 2014 01:29:32 +0000 (03:29 +0200)]
src: replace NULL with nullptr

Now that we are building with C++11 features enabled, replace use
of NULL with nullptr.

The benefit of using nullptr is that it can never be confused for
an integral type because it does not support implicit conversions
to integral types except boolean - unlike NULL, which is defined
as a literal `0`.

9 years agopath: resolve normalize drive letter to lower case
dead-horse [Wed, 17 Sep 2014 10:59:59 +0000 (18:59 +0800)]
path: resolve normalize drive letter to lower case

make path.resolve work the same as path.normalize

9 years agoetw: use Isolate to SetJitCodeEventHandler
Rod Vagg [Sat, 18 Oct 2014 12:25:10 +0000 (23:25 +1100)]
etw: use Isolate to SetJitCodeEventHandler

PR-URL: https://github.com/node-forward/node/pull/27
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agotest: allow common.PIPE to be configured via env
Rod Vagg [Sat, 18 Oct 2014 04:06:43 +0000 (15:06 +1100)]
test: allow common.PIPE to be configured via env

Add optional env var $NODE_COMMON_PIPE for setting common.PIPE to
manually deal with maximum path lengths for unix sockets.

PR-URL: https://github.com/node-forward/node/pull/26
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agobuild: remove workarounds for gcc <= 4.4
Ben Noordhuis [Thu, 16 Oct 2014 17:35:16 +0000 (19:35 +0200)]
build: remove workarounds for gcc <= 4.4

Now that V8 requires a compiler with decent C++11 support, there is no
reason to keep supporting old versions of gcc.  Remove workarounds for
bugs in gcc 4.4 and older.

This coincidentally makes it easier to build with clang 3.3 + address
sanitizer because clang no longer chokes on the `-fno-tree-vrp` switch.

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agobuild: add asan option to multi-arch/mode build
Ben Noordhuis [Thu, 16 Oct 2014 17:22:34 +0000 (19:22 +0200)]
build: add asan option to multi-arch/mode build

Make it possible to build node against Address Sanitizer.  Enable with:

    $ make -f Makefile.build asan=clang++ CC=clang CC_host=clang

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agotest: make test runner multi-arch/mode compatible
Ben Noordhuis [Thu, 16 Oct 2014 16:43:13 +0000 (18:43 +0200)]
test: make test runner multi-arch/mode compatible

Make `python tools/test.py --arch=ia32,x64 --mode=debug,release` work.
The test runner looks for the `node` binary in `out/${arch}.${mode}/`.

Running tools/test.py without --arch makes it use `out/Release/node` or
`out/Debug/node` like before.

This commit removes `test/simple/test-executable-path.js` because the
assumptions it makes about the locations of the debug and release
binaries are now outdated.

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agobuild: set up basic multi-arch/mode build
Ben Noordhuis [Thu, 16 Oct 2014 15:10:33 +0000 (17:10 +0200)]
build: set up basic multi-arch/mode build

Make `make -f Makefile.build ia32.release x64.debug` work.  It's not
perfect yet: it requires running `./configure` first and the generated
`config.gypi` is shared across builds.

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agobuild: copy V8 makefile to top-level directory
Ben Noordhuis [Thu, 16 Oct 2014 14:41:24 +0000 (16:41 +0200)]
build: copy V8 makefile to top-level directory

Will be used as the template for a multi-arch, multi-mode build system.

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agobuild: add x32 support
Ben Noordhuis [Tue, 14 Oct 2014 20:52:16 +0000 (22:52 +0200)]
build: add x32 support

This commit adds preliminary x32 support.  Configure with:

    $ ./configure --dest-cpu=x32

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agodeps: fix v8 x32 build
Ben Noordhuis [Tue, 14 Oct 2014 20:50:08 +0000 (22:50 +0200)]
deps: fix v8 x32 build

Fix double definition errors in the libv8_base.a library target by
compiling out stub functions when building for x32.

This fix is incomplete because, although V8 now builds, it makes a
number of bad assumptions about the size of stack slots, see
https://code.google.com/p/v8/issues/detail?id=3630.

PR-URL: https://github.com/node-forward/node/pull/24
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agotest: fix non-determinism in test-crypto-domains
Ben Noordhuis [Thu, 16 Oct 2014 01:45:53 +0000 (03:45 +0200)]
test: fix non-determinism in test-crypto-domains

The test implicitly assumed that crypto operations complete in the same
order as they are started but, because they go round-trip through the
thread pool, there is no such guarantee.  Enforce proper sequencing.

Fixes node-forward/node#22.

PR-URL: https://github.com/node-forward/node/pull/23
Reviewed-By: Fedor Indutny <fedor@indutny.com>