platform/upstream/dotnet/runtime.git
7 years agoAllow cross machine re-crossgen (dotnet/coreclr#14241)
Steve MacLean [Fri, 29 Sep 2017 12:10:32 +0000 (08:10 -0400)]
Allow cross machine re-crossgen (dotnet/coreclr#14241)

Commit migrated from https://github.com/dotnet/coreclr/commit/581a8d93840212355fc467b3620b74b267df806e

7 years ago[x86/Linux] Fix assert in HelperMethodFrame::UpdateRegDisplay (dotnet/coreclr#14235)
Konstantin Baladurin [Fri, 29 Sep 2017 08:08:01 +0000 (11:08 +0300)]
[x86/Linux] Fix assert in HelperMethodFrame::UpdateRegDisplay (dotnet/coreclr#14235)

In some cases during execution of the SOS command 'clrstack -i'
portability assert in HelperMethodFrame::UpdateRegDisplay occurs.
This patch removes this assert and adds corresponding implementation.

Commit migrated from https://github.com/dotnet/coreclr/commit/9b49593f5ca1b3168a4ff947cbfc3d52a97671cb

7 years agoFixing Retain to return MemoryHandle with correct PinnedPointer (dotnet/coreclr#14248)
Ahson Ahmed Khan [Fri, 29 Sep 2017 03:05:35 +0000 (20:05 -0700)]
Fixing Retain to return MemoryHandle with correct PinnedPointer (dotnet/coreclr#14248)

* Fixing Retain to return MemoryHandle with correct PinnedPointer.

* Make MemoryHandle AddOffset internal.

Commit migrated from https://github.com/dotnet/coreclr/commit/eab3a973346bf4bc5ddffc5201f862141a96b000

7 years agoMerge pull request dotnet/coreclr#14247 from rartemev/issue_13420
Roman Artemev [Fri, 29 Sep 2017 02:30:36 +0000 (19:30 -0700)]
Merge pull request dotnet/coreclr#14247 from rartemev/issue_13420

Fixed difference between produced code in CHK and REL modes

Commit migrated from https://github.com/dotnet/coreclr/commit/591983b2b475f9d2a08e29b5640d6a70b124d816

7 years agoAdded CopyToAsync overload using default buffer size (dotnet/coreclr#14219)
Kristian Hellang [Fri, 29 Sep 2017 01:12:24 +0000 (03:12 +0200)]
Added CopyToAsync overload using default buffer size (dotnet/coreclr#14219)

* Added CopyToAsync overload using default buffer size

* Address feedback

* Added comment about overrides and argument validation

* Renamed helper method to GetCopyBufferSize

To convey that this method should only be used for
getting a buffer size to be passed to CopyTo{Async}.

Commit migrated from https://github.com/dotnet/coreclr/commit/b78107d55e4e53805630099f3aa875e6a1273959

7 years agoFixed differenece between produced code in CHK and REL modes
Roman Artemev [Fri, 29 Sep 2017 00:22:08 +0000 (17:22 -0700)]
Fixed differenece between produced code in CHK and REL modes

Commit migrated from https://github.com/dotnet/coreclr/commit/2cb0faedbe72e05c8e9620c74b54a22eecf4ac2a

7 years agoignore GT_ARGPLACE before gtUseNum check. (dotnet/coreclr#14233)
Sergey Andreenko [Thu, 28 Sep 2017 23:16:06 +0000 (16:16 -0700)]
ignore GT_ARGPLACE before gtUseNum check. (dotnet/coreclr#14233)

Commit migrated from https://github.com/dotnet/coreclr/commit/322b440079db0e61fdd9aba3d95891a1d3d00d0d

7 years agoAdd the capability to force JIT options on the SPMI command line. (dotnet/coreclr...
Sergey Andreenko [Thu, 28 Sep 2017 17:37:15 +0000 (10:37 -0700)]
Add the capability to force JIT options on the SPMI command line. (dotnet/coreclr#14209)

expand the grammar for jit{,2}option to -jitoption [force] key=value

Commit migrated from https://github.com/dotnet/coreclr/commit/212a6baa708f40e25860581557b3dda717b709d9

7 years ago[x86/Linux] Fix typo in SetDebuggerREGDISPLAYFromREGDISPLAY (dotnet/coreclr#14221)
Konstantin Baladurin [Thu, 28 Sep 2017 16:26:39 +0000 (19:26 +0300)]
[x86/Linux] Fix typo in SetDebuggerREGDISPLAYFromREGDISPLAY (dotnet/coreclr#14221)

Fix typo in SetDebuggerREGDISPLAYFromREGDISPLAY: Esi -> Eax.

Commit migrated from https://github.com/dotnet/coreclr/commit/0a17ae10d45db4731071e9a450178933b6d9d1f5

7 years agoMerge pull request dotnet/coreclr#14225 from fiigii/falsedependency
Carol Eidt [Thu, 28 Sep 2017 16:00:16 +0000 (09:00 -0700)]
Merge pull request dotnet/coreclr#14225 from fiigii/falsedependency

[RyuJIT] Fix bad VEX encoding to avoid false register dependency

Commit migrated from https://github.com/dotnet/coreclr/commit/f8b5f537bcb234d1df53445e13f187cadb186c37

7 years agoJIT: have gtClone handle long constants (dotnet/coreclr#14201)
Andy Ayers [Thu, 28 Sep 2017 14:56:24 +0000 (07:56 -0700)]
JIT: have gtClone handle long constants (dotnet/coreclr#14201)

The `Enum.HasFlag` opt needs to clone the enum values, and they
can be long constants. Make sure `gtClone` handles this case.

Closes dotnet/coreclr#14149.

Commit migrated from https://github.com/dotnet/coreclr/commit/ec160a4bed52ac7c6aff3a87c0846c1da228936a

7 years agoMerge pull request dotnet/coreclr#14232 from BruceForstall/Fix14196
Bruce Forstall [Thu, 28 Sep 2017 05:16:27 +0000 (22:16 -0700)]
Merge pull request dotnet/coreclr#14232 from BruceForstall/Fix14196

Fix issue with HFA altjit api

Commit migrated from https://github.com/dotnet/coreclr/commit/2dcf8488e71c79c879bb0212bc2211e35e211321

7 years agofix bad VEX.vvvv to avoid false register dependency
Fei Peng [Wed, 27 Sep 2017 17:33:18 +0000 (10:33 -0700)]
fix bad VEX.vvvv to avoid false register dependency

Commit migrated from https://github.com/dotnet/coreclr/commit/57c40213c0bdce1babcaefb1e66ef4f2b106e58d

7 years agoMerge pull request dotnet/coreclr#14192 from sdmaclea/PR-ARM64-JCMP
Brian Sullivan [Thu, 28 Sep 2017 00:28:42 +0000 (17:28 -0700)]
Merge pull request dotnet/coreclr#14192 from sdmaclea/PR-ARM64-JCMP

[Arm64] Add GT_JCMP node

Commit migrated from https://github.com/dotnet/coreclr/commit/00bce3384795a4f6fc56f5fa9a0bbdac3c1e892f

7 years agoMerge pull request dotnet/coreclr#14231 from fiigii/fixintrinsic
Viktor Hofer [Wed, 27 Sep 2017 23:10:40 +0000 (01:10 +0200)]
Merge pull request dotnet/coreclr#14231 from fiigii/fixintrinsic

fix bugs from dotnet/coreclr#14164

Commit migrated from https://github.com/dotnet/coreclr/commit/d113b5fd56d49ff7ed3cb9b34cc122676026d240

7 years agoMerge pull request dotnet/coreclr#14234 from dotnet/ConditionLoc
William Godbe [Wed, 27 Sep 2017 23:07:07 +0000 (16:07 -0700)]
Merge pull request dotnet/coreclr#14234 from dotnet/ConditionLoc

Move Condition location in dotnet-trusted-publish

Commit migrated from https://github.com/dotnet/coreclr/commit/d450f23430dad8af47264f02bf8987be38fc2377

7 years agoMove Condition location in dotnet-trusted-publish
William Godbe [Wed, 27 Sep 2017 23:03:35 +0000 (16:03 -0700)]
Move Condition location in dotnet-trusted-publish

Commit migrated from https://github.com/dotnet/coreclr/commit/377dfa1ca07959f460705c7831edf24e46ba3b33

7 years agoFix issue with HFA altjit api
Bruce Forstall [Wed, 27 Sep 2017 21:42:04 +0000 (14:42 -0700)]
Fix issue with HFA altjit api

One case in the Interop\ArrayMarshalling\ByValArray\MarshalArrayByValTest\MarshalArrayByValTest.cmd
test marshals an array of strings as members of a struct. The !FEATURE_HFA
code for IsHFA() needs to check for value type before calling CheckForHFA(),
which will assert if it is not a value type.

Fixes dotnet/coreclr#14196.

Commit migrated from https://github.com/dotnet/coreclr/commit/83124c7aaf7f4236e24f4c4fde3863f1736f7d47

7 years ago[Arm64] Respond to feedback
Steve MacLean [Wed, 27 Sep 2017 21:16:51 +0000 (17:16 -0400)]
[Arm64] Respond to feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/932b8b5cdd0fda242dfd183599a7e022bc2b66e3

7 years agofix bug from dotnet/coreclr#14164
Fei Peng [Wed, 27 Sep 2017 21:28:07 +0000 (14:28 -0700)]
fix bug from dotnet/coreclr#14164

Commit migrated from https://github.com/dotnet/coreclr/commit/8592fa1f3386cc9646154d16dadd0f8133debdf5

7 years agoAdding {RO}Memory<T> debugger view (dotnet/coreclr#14130)
Ahson Ahmed Khan [Wed, 27 Sep 2017 21:21:28 +0000 (14:21 -0700)]
Adding {RO}Memory<T> debugger view (dotnet/coreclr#14130)

* Adding memory debugger view and fixing ToArray impl.

* Addressing PR feedback and adding span debugger display string.

* Adding link to specific VSTS instance.

* Removing redundant info in comments.

Commit migrated from https://github.com/dotnet/coreclr/commit/9e8fd361f3df5911d46778ba79697e2ec66845aa

7 years agoMerge pull request dotnet/coreclr#14230 from dotnet/CondInjection
William Godbe [Wed, 27 Sep 2017 21:14:40 +0000 (14:14 -0700)]
Merge pull request dotnet/coreclr#14230 from dotnet/CondInjection

Condition Injection on SignType

Commit migrated from https://github.com/dotnet/coreclr/commit/4f455e83b431c093a0281a8de69333f2eba1f463

7 years agoCondition Injection on SignType
William Godbe [Wed, 27 Sep 2017 21:13:27 +0000 (14:13 -0700)]
Condition Injection on SignType

Commit migrated from https://github.com/dotnet/coreclr/commit/dbec18efc6f99144499c6dd6f6d5e7511bc2f37d

7 years agoMerge pull request dotnet/coreclr#14229 from dotnet/PB_Fix
William Godbe [Wed, 27 Sep 2017 20:44:39 +0000 (13:44 -0700)]
Merge pull request dotnet/coreclr#14229 from dotnet/PB_Fix

Change PB_ConfigurationGroup to ConfigurationGroup

Commit migrated from https://github.com/dotnet/coreclr/commit/0dc72a58d49ef7b05093c141972de60f7d658412

7 years agoUpdate DotNet-Trusted-Publish.json
William Godbe [Wed, 27 Sep 2017 20:44:07 +0000 (13:44 -0700)]
Update DotNet-Trusted-Publish.json

Commit migrated from https://github.com/dotnet/coreclr/commit/d013e3ba9e02ca192e8781614b80be224cefd37d

7 years agoFix modf and fmod casing for consistency
Jan Kotas [Tue, 26 Sep 2017 00:17:20 +0000 (17:17 -0700)]
Fix modf and fmod casing for consistency

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/4ade034c829a38a656cbe52a96fbfc98275bbc46

7 years ago[Jit] fix DevDiv_499435 (dotnet/coreclr#14179)
Sergey Andreenko [Wed, 27 Sep 2017 19:00:33 +0000 (12:00 -0700)]
[Jit] fix DevDiv_499435 (dotnet/coreclr#14179)

fix DevDiv_499435

Commit migrated from https://github.com/dotnet/coreclr/commit/bb2f5e780f7e0c12afb65261790fe84b2f02462e

7 years agoMerge pull request dotnet/coreclr#14226 from dotnet/SymbolPkgInject
William Godbe [Wed, 27 Sep 2017 18:26:16 +0000 (11:26 -0700)]
Merge pull request dotnet/coreclr#14226 from dotnet/SymbolPkgInject

Conditionally Inject signed symbol packages on SignType

Commit migrated from https://github.com/dotnet/coreclr/commit/f363e64c5f72f30b47d205c342f256f7cc615a01

7 years agoConditionally Inject signed symbol packages on SignType
William Godbe [Wed, 27 Sep 2017 18:12:04 +0000 (11:12 -0700)]
Conditionally Inject signed symbol packages on SignType

Commit migrated from https://github.com/dotnet/coreclr/commit/074e63ef162618153140a754845ea435bc82a017

7 years ago[ARM64/Unix] Enable FEATURE_EVENT_TRACE (dotnet/coreclr#14176)
Steve MacLean [Wed, 27 Sep 2017 17:38:05 +0000 (13:38 -0400)]
[ARM64/Unix] Enable FEATURE_EVENT_TRACE (dotnet/coreclr#14176)

* [ARM64/Unix] Enable FEATURE_EVENT_TRACE

* [Arm64] Remove _PlatformDoesNotSupportEventTrace

Commit migrated from https://github.com/dotnet/coreclr/commit/fa30eeba02ad0a5ffeb1122467c5cb47bac285a8

7 years agoAdditional parameter validation for StartNoGCRegion (dotnet/coreclr#14088)
Sean Gillespie [Wed, 27 Sep 2017 17:17:38 +0000 (10:17 -0700)]
Additional parameter validation for StartNoGCRegion (dotnet/coreclr#14088)

* Additional parameter validation for StartNoGCRegion

* Fix the clang build by moving some defs before the first goto

* Guard against size_t overflow when scaling allocation budgets

* Move some parameter validation for managed code, throw better exceptions on parameter validation errors

* Remove stray comma

* Address code review feedback - unify code branches that branch to the failure case. Also keep data types as uint64_t as long as possible to avoid size_t overflow

* Fix the clang build

* Code review feedback:
 1. Remove useless asserts
 2. Remove a dead code path
 3. Add a LocalGC TODO to comment

Commit migrated from https://github.com/dotnet/coreclr/commit/00e7aa00a42debda47a7dbe2b54e924670eaefdd

7 years agoMerge pull request dotnet/coreclr#13897 from hseok-oh/ryujit/ftc_arg_count
Jarret Shook [Wed, 27 Sep 2017 17:13:48 +0000 (10:13 -0700)]
Merge pull request dotnet/coreclr#13897 from hseok-oh/ryujit/ftc_arg_count

Argument register & stack size calculation for fast tail call

Commit migrated from https://github.com/dotnet/coreclr/commit/02c0ef24fc332f5f09e0e717462413603027c97c

7 years ago[Arm64] Add JCMP comments per review
Steve MacLean [Wed, 27 Sep 2017 16:41:52 +0000 (12:41 -0400)]
[Arm64] Add JCMP comments per review

Commit migrated from https://github.com/dotnet/coreclr/commit/415e7a7c6a01d5f2c5c722ace07c16e3c4aafa95

7 years ago[Arm64] Fix JCMP lsra binding
Steve MacLean [Tue, 26 Sep 2017 23:31:18 +0000 (19:31 -0400)]
[Arm64] Fix JCMP lsra binding

Commit migrated from https://github.com/dotnet/coreclr/commit/021ecc08732cfd8d95ff5c1abd477f8bcf2a30f6

7 years agoMerge pull request dotnet/coreclr#14207 from CarolEidt/Fix14028
Carol Eidt [Wed, 27 Sep 2017 15:49:42 +0000 (08:49 -0700)]
Merge pull request dotnet/coreclr#14207 from CarolEidt/Fix14028

Handle GT_SIMD in GenTree::Compare

Commit migrated from https://github.com/dotnet/coreclr/commit/dbdaf348f8a8ace5bd02a9074bef98c2ded95f3d

7 years agoMerge pull request dotnet/coreclr#14090 from BredPet/interface_dispatch_cell
Bruce Forstall [Wed, 27 Sep 2017 15:46:19 +0000 (08:46 -0700)]
Merge pull request dotnet/coreclr#14090 from BredPet/interface_dispatch_cell

ARM32: fix interface dispatch cell address transfer

Commit migrated from https://github.com/dotnet/coreclr/commit/0d3c6848351a7a59a9bb586cdf3e064b09f87383

7 years agoJIT: devirtualization support for EqualityComparer<T>.Default (dotnet/coreclr#14125)
Andy Ayers [Wed, 27 Sep 2017 14:15:04 +0000 (07:15 -0700)]
JIT: devirtualization support for EqualityComparer<T>.Default (dotnet/coreclr#14125)

Mark `EqualityComparer<T>.Default`'s getter as `[Intrinsic]` so
the jit knows there is something special about it. Extend the jit's
named intrinsic recognizer to recognize this method.

Add a new jit interface method to determine the exact type returned
by `EqualityComparer<T>.Default`, given `T`. Compute the return type by
mirroring the logic used in the actual implementation. Bail out when
`T` is not final as those cases won't simplify down much and lead to
code bloat.

Invoke this interface method when trying to devirtualize calls where
the 'this' object in the call comes from `EqualityComparer<T>.Default`.

The devirtualized methods can then be inlined. Since the specific comparer
`Equal` and `GetHashCode` methods look more complicated in IL than they
really are, mark them with AggressiveInlining attributes.

If devirtualization and inlining happen, it is quite likely that the value
of the comparer object itself is not used in the body of the comparer. This
value comes from a static field cache on the comparer helper.

When the comparer value is ignored, the jit removes the field access since it
is non-faulting. It also removes the the class init helper that is there to
ensure that the (no-longer accessed) field is properly initialized. This helper
has relatively high overhead even in the fast case where the class has been
initialized aready.

Add a perf test.

Closes dotnet/coreclr#6688.

Commit migrated from https://github.com/dotnet/coreclr/commit/ccc5e17738a4b2f652059f31e8146513163dbee7

7 years ago[GDBJIT] Provide full file names in generated DWARF (dotnet/coreclr#14172)
Igor Kulaychuk [Wed, 27 Sep 2017 13:32:39 +0000 (16:32 +0300)]
[GDBJIT] Provide full file names in generated DWARF (dotnet/coreclr#14172)

* Fix compile unit info

Provide full path to source in SequencePoints for GDBJIT
Use source file and directory path for compile unit info in DWARF instead of module name.

* Add a class for building Directory Table and File Table

* Fix code inconsistencies and add comments

Commit migrated from https://github.com/dotnet/coreclr/commit/9509fc86a50ad107ee4d601e917cf072f135aa5e

7 years agoMerge pull request dotnet/coreclr#14214 from stephentoub/quwi_preferlocal
Stephen Toub [Wed, 27 Sep 2017 12:32:54 +0000 (08:32 -0400)]
Merge pull request dotnet/coreclr#14214 from stephentoub/quwi_preferlocal

Add ThreadPool.QueueUserWorkItem(..., bool preferLocal)

Commit migrated from https://github.com/dotnet/coreclr/commit/863625426be65b96f2a3c085fc049cfcd2f1a82a

7 years agoARM32: fix interface dispatch cell address transfer
Petr Bred [Wed, 20 Sep 2017 17:52:05 +0000 (20:52 +0300)]
ARM32: fix interface dispatch cell address transfer

Signed-off-by: Petr Bred <bredpetr@gmail.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/74478f481290e3e5fb8ee3c2669b66a71ae0056c

7 years agoUse FCDECL2_VI instead of FCDECL_VV (dotnet/coreclr#14215)
Jonghyun Park [Wed, 27 Sep 2017 08:55:30 +0000 (17:55 +0900)]
Use FCDECL2_VI instead of FCDECL_VV (dotnet/coreclr#14215)

Commit migrated from https://github.com/dotnet/coreclr/commit/e8f69d0a160d6f6f69ad40350ea30346bc030b80

7 years agoPermit to disable FEATURE_EVENT_TRACE on Tizen (dotnet/coreclr#14217)
Jonghyun Park [Wed, 27 Sep 2017 08:54:51 +0000 (17:54 +0900)]
Permit to disable FEATURE_EVENT_TRACE on Tizen (dotnet/coreclr#14217)

Commit migrated from https://github.com/dotnet/coreclr/commit/06763844394cc40933162f31fa911ab518ed5518

7 years agoRemove useless variable
Hyeongseok Oh [Wed, 20 Sep 2017 06:22:09 +0000 (15:22 +0900)]
Remove useless variable

Remove compArgRegCount and compFlatArgRegCount in Info struct

Commit migrated from https://github.com/dotnet/coreclr/commit/20b54accdfb51c52830ec63e7ad7a4f5c26a99e2

7 years agoFix typo
Hyeongseok Oh [Tue, 12 Sep 2017 00:47:37 +0000 (09:47 +0900)]
Fix typo

Fix typo in lclvars.cpp and register_arg_convention.h

Commit migrated from https://github.com/dotnet/coreclr/commit/44eebc7fb37ade75cc8de6c78cba95c2f7c0388d

7 years agoEnhancement caller register & stack calculation for fast tail call
Hyeongseok Oh [Mon, 11 Sep 2017 11:21:05 +0000 (20:21 +0900)]
Enhancement caller register & stack calculation for fast tail call

Save caller register count & stack size using argument varDsc initialization
It remove duplicate calculation for register count
and add stack size count in varDsc initialization

Commit migrated from https://github.com/dotnet/coreclr/commit/a303fc2f10aead0e2377849bde8a293159effbc9

7 years ago[RyuJIT/ARM32] Fast tail call: Init LSRA to use R12 to save jump target (dotnet/corec...
Hyeongseok Oh [Wed, 27 Sep 2017 04:20:06 +0000 (13:20 +0900)]
[RyuJIT/ARM32] Fast tail call: Init LSRA to use R12 to save jump target (dotnet/coreclr#14184)

* [RyuJIT/ARM32] Fast tail call: use R12 to save jump target

To save jump target of fast tail call on ARM32, we use r12.

* Use pre-defined mask and fix comment

Use pre-defined mask: RBM_R12
fix comment: mov pc -> br

Commit migrated from https://github.com/dotnet/coreclr/commit/d7e798c7901c55fe8511632d98a2710affdd70ff

7 years agoAdd ThreadPool.QueueUserWorkItem(..., bool preferLocal)
Stephen Toub [Wed, 27 Sep 2017 03:10:46 +0000 (23:10 -0400)]
Add ThreadPool.QueueUserWorkItem(..., bool preferLocal)

Commit migrated from https://github.com/dotnet/coreclr/commit/f28f313685345275e47f25eef9c155feeb59faad

7 years agoMerge pull request dotnet/coreclr#14178 from stephentoub/async_avoid_delegate
Stephen Toub [Wed, 27 Sep 2017 02:39:38 +0000 (22:39 -0400)]
Merge pull request dotnet/coreclr#14178 from stephentoub/async_avoid_delegate

Avoid async method delegate allocation

Commit migrated from https://github.com/dotnet/coreclr/commit/ef08c8221aa4d33f6ad1399d13bdaab9b10b84a0

7 years agoMerge pull request dotnet/coreclr#14197 from rartemev/fixed_test_build_restore
Roman Artemev [Wed, 27 Sep 2017 02:25:13 +0000 (19:25 -0700)]
Merge pull request dotnet/coreclr#14197 from rartemev/fixed_test_build_restore

Fixed Linux test build

Commit migrated from https://github.com/dotnet/coreclr/commit/536cf25edfada76589a84e1620f93c39c15db167

7 years agoHandle GT_SIMD in GenTree::Compare
Carol Eidt [Wed, 27 Sep 2017 00:19:35 +0000 (17:19 -0700)]
Handle GT_SIMD in GenTree::Compare

Fix dotnet/coreclr#14028

Commit migrated from https://github.com/dotnet/coreclr/commit/c68ddbfe82a553b53f1a5821843194f62bd2d81d

7 years agoAdd SetThreadIdealProcessorEx PAL API (dotnet/coreclr#13606)
Xiangyang (Mark) Guo [Wed, 27 Sep 2017 00:11:55 +0000 (17:11 -0700)]
Add SetThreadIdealProcessorEx PAL API (dotnet/coreclr#13606)

* add SetThreadIdealProcessorEx PAL API

* fix lpPreviousIdealProcessor

Commit migrated from https://github.com/dotnet/coreclr/commit/73ef3c13c9b710cb04b67a904b098fb196c224c7

7 years agoUpdate linux-performance-tracing.md (dotnet/coreclr#14194)
Brian Robbins [Tue, 26 Sep 2017 23:47:12 +0000 (16:47 -0700)]
Update linux-performance-tracing.md (dotnet/coreclr#14194)

Add documentation on how to resolve framework symbols on Linux performance traces.

Commit migrated from https://github.com/dotnet/coreclr/commit/44f570e6efc8e908cebaef8d98b36f1b0c6f5c4a

7 years agoEnable event tracing for Tizen. (dotnet/coreclr#14137)
Dmitri-Botcharnikov [Tue, 26 Sep 2017 22:57:20 +0000 (01:57 +0300)]
Enable event tracing for Tizen. (dotnet/coreclr#14137)

Commit migrated from https://github.com/dotnet/coreclr/commit/485bbd5cd77d3824218149093e071e7dd8434627

7 years agoFix for a special CoreRT helper CORINFO_HELP_JIT_PINVOKE_BEGIN (dotnet/coreclr#14147)
Sergey Andreenko [Tue, 26 Sep 2017 22:35:01 +0000 (15:35 -0700)]
Fix for a special CoreRT helper CORINFO_HELP_JIT_PINVOKE_BEGIN (dotnet/coreclr#14147)

Commit migrated from https://github.com/dotnet/coreclr/commit/cc4769bdcc9f7ed60df8893a99a02f1406fb056f

7 years agoMerge pull request dotnet/coreclr#14202 from wtgodbe/SigningDisableInstall
William Godbe [Tue, 26 Sep 2017 22:25:20 +0000 (15:25 -0700)]
Merge pull request dotnet/coreclr#14202 from wtgodbe/SigningDisableInstall

Install signing plugin with Real signing

Commit migrated from https://github.com/dotnet/coreclr/commit/9b3e8b16e3d1a1c46b4f550a861c9692de4b4a4a

7 years agoInstall signing plugin with Real signing
wtgodbe [Tue, 26 Sep 2017 22:25:02 +0000 (15:25 -0700)]
Install signing plugin with Real signing

Commit migrated from https://github.com/dotnet/coreclr/commit/716de0e29a573afbe8001af0b512e90088eafd40

7 years ago[Arm64] Fix GT_JCMP lsra
Steve MacLean [Tue, 26 Sep 2017 21:04:24 +0000 (17:04 -0400)]
[Arm64] Fix GT_JCMP lsra

Commit migrated from https://github.com/dotnet/coreclr/commit/21dab2e6c9a3be7d528de219b8ba272d55850566

7 years agoReplace Contract.Assumes and Contract.Assert with Debug.Assert/Debug.Fail (dotnet...
Dan Moseley [Tue, 26 Sep 2017 21:19:16 +0000 (14:19 -0700)]
Replace Contract.Assumes and Contract.Assert with Debug.Assert/Debug.Fail (dotnet/coreclr#14136)

* Remove use of Contract.Assert and Contract.Assumes in favor of Debug.xx

* Remove dead IA64 blocks

* Remove use of Contract.Requires in favor of Debug.Assert

* Remove Contract.EndContractBlock()

* Dead comments

* Straggler EndcontractBlock

* Remove all Contract.Ensures

* Remove [Pure] attribute and using statements

* Remove using statements for M.D.Contracts.Internal.Contract

* Rmove CA suppressions for Contracts

* Remove M.D.Contracts.Internal stub

* Comments and extra using

* Revert accidentallly removed #if

* Unix build

* Merge Math*

* Fix assert not updated since desktop

* Asserts add no value: remove

* Avoid infinite recursion in StringBuilder assert

* Remove asserts that should be public parameter validation

* Fix comment

* Remove blank line after open curly

Commit migrated from https://github.com/dotnet/coreclr/commit/da8b7181dbe362fbfe64c7ef72ff3a4a7db68f24

7 years agoFixed Linux test build
Roman Art [Sat, 23 Sep 2017 00:09:42 +0000 (17:09 -0700)]
Fixed Linux test build

Commit migrated from https://github.com/dotnet/coreclr/commit/93b646c2833daf3b518ac5fb110494b30114fc60

7 years agoMerge pull request dotnet/coreclr#14195 from wtgodbe/SignType
William Godbe [Tue, 26 Sep 2017 21:06:06 +0000 (14:06 -0700)]
Merge pull request dotnet/coreclr#14195 from wtgodbe/SignType

Use Real signType to install plugin

Commit migrated from https://github.com/dotnet/coreclr/commit/94cbb624a62f7a5712292a3e4da650ba335be4da

7 years agoUse Real signType to install plugin
wtgodbe [Tue, 26 Sep 2017 21:04:57 +0000 (14:04 -0700)]
Use Real signType to install plugin

Commit migrated from https://github.com/dotnet/coreclr/commit/2dfcf509b71ef6fefeb4dc9f289b7224aeb2d377

7 years agoMerge pull request dotnet/coreclr#14193 from wtgodbe/SigningInfra
William Godbe [Tue, 26 Sep 2017 20:34:37 +0000 (13:34 -0700)]
Merge pull request dotnet/coreclr#14193 from wtgodbe/SigningInfra

Update publish infra to parameterize PB_SignType

Commit migrated from https://github.com/dotnet/coreclr/commit/6fa6b7e135fb16fa1943e506d3c9400e2c1da5a7

7 years agoUpdate publish infra to parameterize PB_SignType
wtgodbe [Tue, 26 Sep 2017 20:16:49 +0000 (13:16 -0700)]
Update publish infra to parameterize PB_SignType

Commit migrated from https://github.com/dotnet/coreclr/commit/c84c7768410bc5eaab4d3a8f7009b339d0f4975d

7 years agoRemove Monitor asm helpers (dotnet/coreclr#14146)
Koundinya Veluri [Tue, 26 Sep 2017 20:14:53 +0000 (13:14 -0700)]
Remove Monitor asm helpers (dotnet/coreclr#14146)

- Removed asm helpers on Windows and used portable C++ helpers instead
- Rearranged fast path code to improve them a bit and match the asm more closely

Perf:
- The asm helpers are a bit faster. The code generated for the portable helpers is almost the same now, the remaining differences are:
  - There were some layout issues where hot paths were in the wrong place and return paths were not cloned. Instrumenting some of the tests below with PGO on x64 resolved all of the layout issues. I couldn't get PGO instrumentation to work on x86 but I imagine it would be the same there.
  - Register usage
    - x64: All of the Enter functions are using one or two (TryEnter is using two) callee-saved registers for no apparent reason, forcing them to be saved and restored. r10 and r11 seem to be available but they're not being used.
    - x86: Similarly to x64, the compiled functions are pushing and popping 2-3 additional registers in the hottest fast paths.
    - I believe this is the main remaining gap and PGO is not helping with this
- On Linux, perf is >= before for the most part
- Perf tests used for below are updated in PR https://github.com/dotnet/coreclr/pull/13670

Commit migrated from https://github.com/dotnet/coreclr/commit/8f0ac5d2041d0c577607e2f778f2fbca1f7d732e

7 years ago[Arm64] Add GT_JCMP node
Steve MacLean [Fri, 22 Sep 2017 16:07:43 +0000 (12:07 -0400)]
[Arm64] Add GT_JCMP node

Create new node type GT_JCMP to represent a
fused Relop + JTrue which does not set flags

Add lowering code to create GT_JCMP when
Arm64 could use cbz, cbnz, tbz, or tbnz

Commit migrated from https://github.com/dotnet/coreclr/commit/d4bec111d70761857fcebd122cb36eb8bc383ef6

7 years agoMerge pull request dotnet/coreclr#14171 from wateret/ryu-arm-putarg-bitcast
Carol Eidt [Tue, 26 Sep 2017 14:55:29 +0000 (07:55 -0700)]
Merge pull request dotnet/coreclr#14171 from wateret/ryu-arm-putarg-bitcast

[RyuJIT/armarch] Put arguments with GT_BITCAST

Commit migrated from https://github.com/dotnet/coreclr/commit/296aaf12b40ddd7478b6a14d6099f48b4b049438

7 years ago[RyuJIT/armarch] Put arguments with GT_BITCAST
Hanjoung Lee [Mon, 25 Sep 2017 11:50:27 +0000 (20:50 +0900)]
[RyuJIT/armarch] Put arguments with GT_BITCAST

Put arguments with GT_BITCAST instead of GT_COPY for arm32/arm64

Fix dotnet/coreclr#14008

Commit migrated from https://github.com/dotnet/coreclr/commit/0603f5b9ab96b20f72d006ab78a9b0c608c034df

7 years agoAvoid async method delegate allocation
Stephen Toub [Mon, 25 Sep 2017 16:02:10 +0000 (12:02 -0400)]
Avoid async method delegate allocation

Previously when a task-returning async method would yield for the first time, there would be four allocations: the task, the state machine object boxed to the heap, a context "runner" object, and a delegate that points to the boxed state machine's MoveNext method.  A recent PR changed this to avoid the separate box object and the runner, but that still left the task and the delegate.

This PR avoids the delegate as well in a common case.  For async methods that only ever await Task/Task`1, that aren't using a custom sync context/scheduler, and for which tracing isn't enabled, we know the inner workings of both the builder and the awaiter and can thus bypass the awaiter's pattern APIs; instead of creating the delegate that gets passed to the awaiter and then stored in the wrapped task's continuation slot/list, we can instead just store the boxed state machine directly in the slot/list.

Commit migrated from https://github.com/dotnet/coreclr/commit/9a0630152c4339324ba9ac0fa886f9fb4916e759

7 years ago[ARM32] Update armel rootfs for Tizen (dotnet/coreclr#14173)
Hyung-Kyu Choi [Tue, 26 Sep 2017 00:37:04 +0000 (09:37 +0900)]
[ARM32] Update armel rootfs for Tizen (dotnet/coreclr#14173)

* [Tizen/ARM32] Update armel rootfs for Tizen

- Add lttng-ust-dev to Tizen rootfs for cross build
- Use rootfs of the latest Tizen 4.0

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
* [Tizen/ARM32] Update Tizen CI script

- Update arm32 CI script for Tizen to use the latest environment

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/10c320c512e5246b658c76c1c699233e1ec8a35d

7 years agoAdd CI PR triggers for x86_arm and x64_arm64 testing (dotnet/coreclr#14158)
Bruce Forstall [Tue, 26 Sep 2017 00:22:03 +0000 (17:22 -0700)]
Add CI PR triggers for x86_arm and x64_arm64 testing (dotnet/coreclr#14158)

* Add CI PR triggers for x86_arm and x64_arm64 testing

* Fix bug

* Don't do GC stress with altjit

Commit migrated from https://github.com/dotnet/coreclr/commit/466cc6ecdaef5273b78b4022b459433ddd9d4e64

7 years agoMerge pull request dotnet/coreclr#14041 from sdmaclea/PR-ARM64-SET-FLAGS
Brian Sullivan [Mon, 25 Sep 2017 23:54:25 +0000 (16:54 -0700)]
Merge pull request dotnet/coreclr#14041 from sdmaclea/PR-ARM64-SET-FLAGS

[Arm64] Use GTF_SET_FLAGS/GTF_USE_FLAGS

Commit migrated from https://github.com/dotnet/coreclr/commit/40f63d9d3421d41df225e6f5d41645a4394a8ae1

7 years ago[Arm64] Repsond to feedback
Steve MacLean [Mon, 25 Sep 2017 19:07:22 +0000 (15:07 -0400)]
[Arm64] Repsond to feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/d11ca21103627ef5eed573cb8ce5b208d385adbb

7 years agoCleanup gentree per comments
Steve MacLean [Tue, 19 Sep 2017 22:27:11 +0000 (18:27 -0400)]
Cleanup gentree per comments

Commit migrated from https://github.com/dotnet/coreclr/commit/e74fe85a47260881a5ebc0c2e3d5af7a6409a299

7 years ago[Arm64] Use GTF_SET_FLAGS/GTF_USE_FLAGS
Steve MacLean [Fri, 15 Sep 2017 22:08:09 +0000 (18:08 -0400)]
[Arm64] Use GTF_SET_FLAGS/GTF_USE_FLAGS

Commit migrated from https://github.com/dotnet/coreclr/commit/95f69bf863b500c645a072bc7a46f52bbdb3c491

7 years agoMerge pull request dotnet/coreclr#14145 from BruceForstall/CleanupTestsLst
Bruce Forstall [Mon, 25 Sep 2017 17:10:41 +0000 (10:10 -0700)]
Merge pull request dotnet/coreclr#14145 from BruceForstall/CleanupTestsLst

Re-enable tests that should now pass

Commit migrated from https://github.com/dotnet/coreclr/commit/522c30957ac8b45e692420974bf9732d49503a36

7 years agoMerge pull request dotnet/coreclr#14080 from hqueue/arm/ryujit/issue_13750
Carol Eidt [Mon, 25 Sep 2017 14:47:33 +0000 (07:47 -0700)]
Merge pull request dotnet/coreclr#14080 from hqueue/arm/ryujit/issue_13750

[RyuJIT] Fix assertion condition for interval of constant value in LSRA

Commit migrated from https://github.com/dotnet/coreclr/commit/ee79bb188e097b49f5ffcb36f0d7c86314d45579

7 years ago[mscorlib] Enable hardware intrinsic in debug and reflection (dotnet/coreclr#14164)
Fei Peng [Mon, 25 Sep 2017 12:22:36 +0000 (05:22 -0700)]
[mscorlib] Enable hardware intrinsic in debug and reflection (dotnet/coreclr#14164)

Commit migrated from https://github.com/dotnet/coreclr/commit/de5af5e9547e695c02b09ac6a2437a810962e0f6

7 years ago[RyuJIT/ARM32] Fix assertion condition in LSRA for ARM32
Hyung-Kyu Choi [Wed, 20 Sep 2017 07:05:07 +0000 (16:05 +0900)]
[RyuJIT/ARM32] Fix assertion condition in LSRA for ARM32

Update assertion condition when handling an inactive
constant interval for ARM32, because an inactive constant
interval may be encountered.

Fix dotnet/coreclr#13750

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/a1c7400b8275cbd19d8f826445df31cf060fdfda

7 years agoMoving parts of `System.Math` and `System.MathF` to be shared with CoreRT. (dotnet...
Tanner Gooding [Sat, 23 Sep 2017 21:23:23 +0000 (14:23 -0700)]
Moving parts of `System.Math` and `System.MathF` to be shared with CoreRT. (dotnet/coreclr#14119)

* Moving parts of `System.MathF` to be shared with CoreRT.

* Moving parts of `System.Math` to be shared with CoreRT.

* Updating the new 'Round' named intrinsic to map to the legacy 'Round' intrinsic.

* Adding back the case statement for CORINFO_INTRINSIC_Round, since it is required for Desktop compat.

Commit migrated from https://github.com/dotnet/coreclr/commit/bfaad966b593788a58cf213dbbea6645d6446920

7 years agoMerge pull request dotnet/coreclr#14153 from mikedn/x86-newarr-nint
Bruce Forstall [Sat, 23 Sep 2017 20:39:13 +0000 (13:39 -0700)]
Merge pull request dotnet/coreclr#14153 from mikedn/x86-newarr-nint

Make GitHub_14116 test work on 32 bit

Commit migrated from https://github.com/dotnet/coreclr/commit/ededd38548f742a4ddb16e6af9fe4f4c82c64bef

7 years agoMake GitHub_14116 test work on 32 bit
Mike Danes [Sat, 23 Sep 2017 18:42:43 +0000 (21:42 +0300)]
Make GitHub_14116 test work on 32 bit

newarr expects int32 or native int on the stack. x64 JIT hapilly allows an int64 as well but the x86 JIT asserts.

Also change the constant to 0xFFFFFFF1FFFFFFFF so OverflowException is thrown on 32 bit as well.

Commit migrated from https://github.com/dotnet/coreclr/commit/2b1274c37723ee22d3fc22fd30f7cb2f7401d9be

7 years agoMerge pull request dotnet/coreclr#14143 from sdmaclea/PR-FEEDBACK-14139
Bruce Forstall [Sat, 23 Sep 2017 01:06:06 +0000 (18:06 -0700)]
Merge pull request dotnet/coreclr#14143 from sdmaclea/PR-FEEDBACK-14139

Respond to Feedback dotnet/coreclr#14139

Commit migrated from https://github.com/dotnet/coreclr/commit/7f209ff2970c55e710728996a9d19e9cbc500e9c

7 years ago[Arm64/Arm] Favor emitActualTypeSize for non-memory (dotnet/coreclr#14046)
Steve MacLean [Sat, 23 Sep 2017 01:03:40 +0000 (21:03 -0400)]
[Arm64/Arm] Favor emitActualTypeSize for non-memory (dotnet/coreclr#14046)

* [Arm64/Arm] Favor emitActualTypeSize for non-memory

Register ops size is generally referred to
by emitActualTypeSize.  'Actual' size refers to the
size in register as opposed to size in memory

* [Arm64] Remove bogus CQ ToDo

* Fix formatting

Commit migrated from https://github.com/dotnet/coreclr/commit/89f5e464b7ad8b8f347693d190dc7e475c73ba34

7 years agoRe-enable tests that should now pass
Bruce Forstall [Sat, 23 Sep 2017 00:57:34 +0000 (17:57 -0700)]
Re-enable tests that should now pass

Commit migrated from https://github.com/dotnet/coreclr/commit/011e60b433b76569ce5378196d35917b03d1aaff

7 years agoMerge pull request dotnet/coreclr#14109 from hseok-oh/ryujit/fix_13738
Bruce Forstall [Sat, 23 Sep 2017 00:39:15 +0000 (17:39 -0700)]
Merge pull request dotnet/coreclr#14109 from hseok-oh/ryujit/fix_13738

[RyuJIT/ARM32] JitStress=1 test: padding local variable

Commit migrated from https://github.com/dotnet/coreclr/commit/52f428891a72d44350174c54769c22faa079fcc5

7 years agoMerge pull request dotnet/coreclr#14118 from rartemev/devdiv_491206
Roman Artemev [Sat, 23 Sep 2017 00:11:38 +0000 (17:11 -0700)]
Merge pull request dotnet/coreclr#14118 from rartemev/devdiv_491206

Fixed return constant value cache on 32 bit VMs

Commit migrated from https://github.com/dotnet/coreclr/commit/3856254840e967c97b878d6d9fa61cd2769a94f5

7 years agoMerge pull request dotnet/coreclr#14117 from mikedn/earyprop-neg-length
Bruce Forstall [Sat, 23 Sep 2017 00:09:09 +0000 (17:09 -0700)]
Merge pull request dotnet/coreclr#14117 from mikedn/earyprop-neg-length

Don't early-propagate negative array lengths

Commit migrated from https://github.com/dotnet/coreclr/commit/a11e4b1377cd1f6305782f62dcf555659625e7c2

7 years ago[Arm64] Add Floor/Ceiling intrinsics (dotnet/coreclr#14132)
Steve MacLean [Fri, 22 Sep 2017 23:59:22 +0000 (19:59 -0400)]
[Arm64] Add Floor/Ceiling intrinsics (dotnet/coreclr#14132)

* [Arm64] Add Floor/Ceiling intrinsics

* Templatize emitActualTypeSize

Commit migrated from https://github.com/dotnet/coreclr/commit/492d79e2a29ac36772e1e95b6dd3818959e99890

7 years agoCreate dotnet deployment and acquisition size on disk test (dotnet/coreclr#13956)
Victor "Nate" Graf [Fri, 22 Sep 2017 23:47:15 +0000 (16:47 -0700)]
Create dotnet deployment and acquisition size on disk test (dotnet/coreclr#13956)

* [WIP] First version of SoDBench. Contains bugs

* [WIP] Move SoDBench files and increase error checking

* [WIP] Add NugetConfig to enable pulling packages from myget

* [WIP] Remove unhelpful templates and add back oses

* [WIP] Add ability to specify channel

* [WIP] Improve CSV writing

* [WIP] Improve options parsing

* Fix syntax error

* [WIP] Add test leg to perf.groovy

* [WIP] Adjust label to target an existing machine pool

* Change label to run on virtual machine

* Use setMachineAffinity

* Add ASP.NET-Core feed and deafult to master as the channel

* Change channel to master in perf.groovy

* Move NuGet.Config up a directory so it only needs to be written once

* Add CommandLine to external dependencies

* Remove CommandLine as it is now in external.depproj

* Adjust wget command to work more consistantly

* Change calculation of relative paths for clarity

* Set job to run daily instead of on push/PR

* Build sodbench on job run

* Remove MSBuild from job

* Fix quote placement

* Change metadata to be more accurate

* Add rollup totals for each measured category

* Refactor to use a tree rather than a dictionary

* Limit report size

* Publish in release configuration

Commit migrated from https://github.com/dotnet/coreclr/commit/9d02629b1deaf8c45b57d3bdea545b0c50e2d749

7 years ago[Arm64] Implement JCC/SETCC nodes (dotnet/coreclr#14101)
Steve MacLean [Fri, 22 Sep 2017 23:11:33 +0000 (19:11 -0400)]
[Arm64] Implement JCC/SETCC nodes (dotnet/coreclr#14101)

* [Arm64] Implement JCC/SETCC nodes

* Fix formatting

Commit migrated from https://github.com/dotnet/coreclr/commit/5bd48ba9788119d5cbae8e01751319aed6b6df6e

7 years agoRespond to Feedback dotnet/coreclr#14139
Steve MacLean [Fri, 22 Sep 2017 22:16:52 +0000 (18:16 -0400)]
Respond to Feedback dotnet/coreclr#14139

Commit migrated from https://github.com/dotnet/coreclr/commit/bb6e6d8df00df6e1c37148183e3f693d269fb0e0

7 years agoMerge pull request dotnet/coreclr#13167 from alpencolt/ryu-arm-remove-lea-0-offset
Bruce Forstall [Fri, 22 Sep 2017 22:13:32 +0000 (15:13 -0700)]
Merge pull request dotnet/coreclr#13167 from alpencolt/ryu-arm-remove-lea-0-offset

[RyuJIT/ARM32] Remove LEA[b+0]

Commit migrated from https://github.com/dotnet/coreclr/commit/7418ab22c84aa84f9c2d087199daa1f6336f3753

7 years agoAdded IntegralValue() method
Roman Artemev [Fri, 22 Sep 2017 20:51:10 +0000 (13:51 -0700)]
Added IntegralValue() method

Commit migrated from https://github.com/dotnet/coreclr/commit/99dcfc5816b7578e0d4899a88de15196130d06d0

7 years agoMerge pull request dotnet/coreclr#14139 from sdmaclea/PR-ARM64-EMIT-CBxZ-TBxZ
Brian Sullivan [Fri, 22 Sep 2017 21:34:47 +0000 (14:34 -0700)]
Merge pull request dotnet/coreclr#14139 from sdmaclea/PR-ARM64-EMIT-CBxZ-TBxZ

[Arm64] Add emitters for cbz, cbnz, tbz, and tbnz

Commit migrated from https://github.com/dotnet/coreclr/commit/8dd0eaca2e2b103b6e323ea3b7e875de14a103f1

7 years agoMerge pull request dotnet/coreclr#14140 from jashook/pri0_arm_jobs
Jarret Shook [Fri, 22 Sep 2017 21:16:33 +0000 (14:16 -0700)]
Merge pull request dotnet/coreclr#14140 from jashook/pri0_arm_jobs

Set default arm jobs to pri0

Commit migrated from https://github.com/dotnet/coreclr/commit/374a27b79053e8bf4515b2bd9321e1f6d8762a51

7 years agoFix incorrect use of local var
jashook [Fri, 22 Sep 2017 21:02:55 +0000 (14:02 -0700)]
Fix incorrect use of local var

Commit migrated from https://github.com/dotnet/coreclr/commit/f8215bed2fc76a2b87046d32fe8d32c04ec8f5f2

7 years agoFix build logic as well
jashook [Fri, 22 Sep 2017 20:40:53 +0000 (13:40 -0700)]
Fix build logic as well

Commit migrated from https://github.com/dotnet/coreclr/commit/976f4930654c93a2f351db408d08ec01d277ed22

7 years agoDisable tracing tests on Windows at runtime, not build (dotnet/coreclr#14127)
Victor "Nate" Graf [Fri, 22 Sep 2017 20:30:02 +0000 (13:30 -0700)]
Disable tracing tests on Windows at runtime, not build (dotnet/coreclr#14127)

Commit migrated from https://github.com/dotnet/coreclr/commit/5ae3c50e2e9c22c9236d5b17840bb225a283fa23

7 years agoFileStream should not truncate files when opening fails. Fixes dotnet/corefxdotnet...
Kasper Fabæch Brandt [Fri, 22 Sep 2017 19:51:00 +0000 (21:51 +0200)]
FileStream should not truncate files when opening fails. Fixes dotnet/corefxdotnet/coreclr#24081 (dotnet/coreclr#14043)

Commit migrated from https://github.com/dotnet/coreclr/commit/555f436263ed5632443efbcc9b860a7d7c5069a3

7 years agoMerge pull request dotnet/coreclr#14142 from sdmaclea/PR-ARM64-FIX-TYPO
Brian Sullivan [Fri, 22 Sep 2017 18:27:12 +0000 (11:27 -0700)]
Merge pull request dotnet/coreclr#14142 from sdmaclea/PR-ARM64-FIX-TYPO

[Arm64] Fix typo

Commit migrated from https://github.com/dotnet/coreclr/commit/5d3788573000ed800c5b6851c3c93b59fca3946a