robertphillips@google.com [Wed, 5 Dec 2012 19:34:33 +0000 (19:34 +0000)]
Add display of a path's filltype to debugger
https://codereview.appspot.com/6887044/
git-svn-id: http://skia.googlecode.com/svn/trunk@6679
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 5 Dec 2012 19:07:21 +0000 (19:07 +0000)]
Add drawPoints dash bench
https://codereview.appspot.com/6866053/
git-svn-id: http://skia.googlecode.com/svn/trunk@6678
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 5 Dec 2012 15:32:35 +0000 (15:32 +0000)]
Clean up SkFontHost_mac_coretext.
https://codereview.appspot.com/6843087/
git-svn-id: http://skia.googlecode.com/svn/trunk@6676
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 5 Dec 2012 14:56:08 +0000 (14:56 +0000)]
The goal is to make the ClangCompile buildstep in the Housekeeping bot turn red if there is a warning.
Review URL: https://codereview.appspot.com/6868055
git-svn-id: http://skia.googlecode.com/svn/trunk@6674
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 5 Dec 2012 14:51:39 +0000 (14:51 +0000)]
Add operator delete to match operator new for SkTLList.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6871061
git-svn-id: http://skia.googlecode.com/svn/trunk@6673
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 5 Dec 2012 06:15:42 +0000 (06:15 +0000)]
Add missing SK_API definition at request of Chromium callers
Review URL: https://codereview.appspot.com/6878050
git-svn-id: http://skia.googlecode.com/svn/trunk@6671
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 5 Dec 2012 05:34:51 +0000 (05:34 +0000)]
add test for adding outer contour first and second
git-svn-id: http://skia.googlecode.com/svn/trunk@6670
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 5 Dec 2012 02:01:21 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6669
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 4 Dec 2012 22:52:28 +0000 (22:52 +0000)]
add gm/pathinterior.cpp in advance of cary's path api
git-svn-id: http://skia.googlecode.com/svn/trunk@6668
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 4 Dec 2012 20:34:11 +0000 (20:34 +0000)]
Expand dashing3 GM to include additional dashing cases
https://codereview.appspot.com/6870056/
git-svn-id: http://skia.googlecode.com/svn/trunk@6667
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Dec 2012 15:22:12 +0000 (15:22 +0000)]
Make GrReduceClipStack use a caller provided query rect rather than return a
bounds.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6865059
git-svn-id: http://skia.googlecode.com/svn/trunk@6665
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 4 Dec 2012 15:08:56 +0000 (15:08 +0000)]
Handle recording a bitmap if copy fails.
If SkBitmapHeap::insert() returns INVALID_SLOT, assert at picture
record time so we can debug, but allow it to continue in release
mode, so that we can still capture a picture. At playback time,
print a message so we know that there was an error.
Review URL: https://codereview.appspot.com/6873050
git-svn-id: http://skia.googlecode.com/svn/trunk@6664
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Dec 2012 14:48:57 +0000 (14:48 +0000)]
Fix stale iterators in LList test. Add newline to end of SkTLList.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6663
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 4 Dec 2012 14:18:50 +0000 (14:18 +0000)]
Pull SkMergeImageFilter out into its own file.
Review URL: https://codereview.appspot.com/6873052
git-svn-id: http://skia.googlecode.com/svn/trunk@6662
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 4 Dec 2012 14:06:06 +0000 (14:06 +0000)]
Make SkClipStack::Iter use SkClipStack::Element.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6871051
git-svn-id: http://skia.googlecode.com/svn/trunk@6661
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 4 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6660
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 3 Dec 2012 23:34:32 +0000 (23:34 +0000)]
Fix compiler error in SkTInternalList.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6659
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 3 Dec 2012 22:52:30 +0000 (22:52 +0000)]
Provide default guess at font type in Mac CoreText font host, since CT's detection is unreliable.
git-svn-id: http://skia.googlecode.com/svn/trunk@6658
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 3 Dec 2012 22:45:10 +0000 (22:45 +0000)]
The short version of the 'loca' table stores offsets divided by 2.
git-svn-id: http://skia.googlecode.com/svn/trunk@6657
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 3 Dec 2012 21:38:58 +0000 (21:38 +0000)]
Added SK_BUILD_FOR_NACL to SkPreConfig.h
Submitted on behalf of bmilnor@
git-svn-id: http://skia.googlecode.com/svn/trunk@6656
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 3 Dec 2012 21:19:52 +0000 (21:19 +0000)]
add getTypes() to SkMatrix44, to cache how complex the matrix is.
add bench
optimize operator== by performing 4 compares in a row before checking
optimize setconcat by noting when we can write the answer directly into this
At least on this macbook, I had to mark helpers like isIdentity() as inline to get them inlined.
Review URL: https://codereview.appspot.com/6863053
git-svn-id: http://skia.googlecode.com/svn/trunk@6655
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 19:47:41 +0000 (19:47 +0000)]
Reland r6649 with fix for build errors.
git-svn-id: http://skia.googlecode.com/svn/trunk@6653
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 19:18:57 +0000 (19:18 +0000)]
Revert 6649 due to build breaks.
git-svn-id: http://skia.googlecode.com/svn/trunk@6651
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 3 Dec 2012 19:16:59 +0000 (19:16 +0000)]
Templatize AutoCFRelease and use it.
https://codereview.appspot.com/6855113/
git-svn-id: http://skia.googlecode.com/svn/trunk@6650
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 19:05:44 +0000 (19:05 +0000)]
Insert in middle of SkTInternalLList and SkTLList, in place cons for
SkTLList.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6870050
git-svn-id: http://skia.googlecode.com/svn/trunk@6649
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 18:01:45 +0000 (18:01 +0000)]
Add SkTLList, linked list class implemented on top of the internal llist class.
R=robertphillips@google.com
Committed: https://code.google.com/p/skia/source/detail?r=6644
Review URL: https://codereview.appspot.com/6869049
git-svn-id: http://skia.googlecode.com/svn/trunk@6647
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 3 Dec 2012 17:35:19 +0000 (17:35 +0000)]
Fixed remaining clang compiler warnings
https://codereview.appspot.com/6865053/
git-svn-id: http://skia.googlecode.com/svn/trunk@6646
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 15:59:52 +0000 (15:59 +0000)]
Revert change accidentally committed.
git-svn-id: http://skia.googlecode.com/svn/trunk@6645
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 15:54:12 +0000 (15:54 +0000)]
Add SkTLList, linked list class implemented on top of the internal llist class.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6869049
git-svn-id: http://skia.googlecode.com/svn/trunk@6644
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 3 Dec 2012 14:54:59 +0000 (14:54 +0000)]
Rename SkTDLinkedList to SkTInternalLinked list, add some methods useful for forthcoming SkTLList.
Review URL: https://codereview.appspot.com/6858101
git-svn-id: http://skia.googlecode.com/svn/trunk@6643
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Mon, 3 Dec 2012 14:38:08 +0000 (14:38 +0000)]
Fix clang 'overloaded-virtual' warnings.
This patch fixes the warning like the following:
../../src/animator/SkPaintParts.h:26:18: warning: 'SkPaintPart::add' hides overloaded virtual function [-Woverloaded-virtual]
virtual bool add() = 0;
^
../../src/animator/SkDisplayable.h:35:18: note: hidden overloaded virtual function 'SkDisplayable::add' declared here
virtual bool add(SkAnimateMaker& , SkDisplayable* child);
^
R=robertphillips@google.com,
Review URL: https://codereview.appspot.com/6843134
git-svn-id: http://skia.googlecode.com/svn/trunk@6642
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Mon, 3 Dec 2012 11:41:21 +0000 (11:41 +0000)]
Tweak an enum declaration to make the clang compiler happy.
This exposes our "unknown type" to users, which is a loss of encapsulation.
TBR=robertphillips
http://codereview.appspot.com/6865050/
git-svn-id: http://skia.googlecode.com/svn/trunk@6641
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 1 Dec 2012 02:26:53 +0000 (02:26 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6640
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 30 Nov 2012 21:30:42 +0000 (21:30 +0000)]
Create aliases AddRef() and Release() to SkRefCnt for compatibility with scoped_refptr
Review URL: https://codereview.appspot.com/6844116
git-svn-id: http://skia.googlecode.com/svn/trunk@6639
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 30 Nov 2012 16:19:32 +0000 (16:19 +0000)]
Disabling validation of the glyph cache for standard debug builds.
The validation step is adding 50% overhead to the rendering of
text heavy SkPicture files.
Review URL: https://codereview.appspot.com/6856123
git-svn-id: http://skia.googlecode.com/svn/trunk@6635
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 30 Nov 2012 15:26:04 +0000 (15:26 +0000)]
Add auto table ref for coretext.
https://codereview.appspot.com/6849117/
git-svn-id: http://skia.googlecode.com/svn/trunk@6634
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Fri, 30 Nov 2012 04:42:59 +0000 (04:42 +0000)]
Adds BENCH_ALLOWED_NOISE to widen expected bench ranges.
This is especially useful for benches with small absolute value.
Review URL: https://codereview.appspot.com/6842112
git-svn-id: http://skia.googlecode.com/svn/trunk@6633
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 30 Nov 2012 02:01:24 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6632
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 30 Nov 2012 00:38:29 +0000 (00:38 +0000)]
Fix for roll-blocking compiler error in SkRRect.cpp
git-svn-id: http://skia.googlecode.com/svn/trunk@6630
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 22:39:10 +0000 (22:39 +0000)]
Clean up some Windows compiler warnings.
Review URL: https://codereview.appspot.com/6844111
git-svn-id: http://skia.googlecode.com/svn/trunk@6628
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 21:50:34 +0000 (21:50 +0000)]
rebaseline.py: Allow multiple testnames on the command line.
Review URL: https://codereview.appspot.com/6856118
git-svn-id: http://skia.googlecode.com/svn/trunk@6623
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:21:54 +0000 (21:21 +0000)]
remove 4444 support (for now) form gm -- not used (afaik) and slows us down
Review URL: https://codereview.appspot.com/6782137
git-svn-id: http://skia.googlecode.com/svn/trunk@6622
2bbb7eff-a529-9590-31e7-
b0007b416f81
jamesr@chromium.org [Thu, 29 Nov 2012 21:17:16 +0000 (21:17 +0000)]
Keep track of identity SkMatrix44s
This keeps a bool on SkMatrix44 indicating if we know for sure that the matrix
is identity, similar to the TypeMask on SkMatrix. This is useful to early-out
of potentially expensive matrix math at the cost of some memory.
Review URL: https://codereview.appspot.com/6854113
git-svn-id: http://skia.googlecode.com/svn/trunk@6620
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 21:14:59 +0000 (21:14 +0000)]
Remove SkClipStack::Iter::combinedNext.
Review URL: https://codereview.appspot.com/6844114
git-svn-id: http://skia.googlecode.com/svn/trunk@6619
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 29 Nov 2012 21:05:37 +0000 (21:05 +0000)]
Create a factory to decode an SkBitmap from an SkData.
Add a test and a GM for the factory, and a PNG file for it to decode.
The PNG file is copyright-free, obtained from
http://openclipart.org/detail/29213/paper-plane-by-ddoo
In cmykjpeg, do not attempt to decode in the constructor, since it
currently crashes on Mac (if you provide the correct resource path).
Even when we fix this crash there is no need to do it in the
constructor, since we create all of the gms in order to
get their names (to determine whether to run them).
Review URL: https://codereview.appspot.com/6847122
git-svn-id: http://skia.googlecode.com/svn/trunk@6618
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 21:05:13 +0000 (21:05 +0000)]
Make SkClipStack::Element public.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6858096
git-svn-id: http://skia.googlecode.com/svn/trunk@6617
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:01:00 +0000 (21:01 +0000)]
use fast-pt case when radius <= 1/2, instead of just hairlines
Review URL: https://codereview.appspot.com/6854116
git-svn-id: http://skia.googlecode.com/svn/trunk@6616
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 29 Nov 2012 21:00:39 +0000 (21:00 +0000)]
add SkPictureUtils::GatherPixelRefs()
Review URL: https://codereview.appspot.com/6845106
git-svn-id: http://skia.googlecode.com/svn/trunk@6615
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 19:16:32 +0000 (19:16 +0000)]
Change SkClipStack::Element::State to SkClipStack::Type, rename Comine* members to combine*
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6844113
git-svn-id: http://skia.googlecode.com/svn/trunk@6607
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 19:00:22 +0000 (19:00 +0000)]
Turn on the separable blur (release the hounds!). This will require rebaselines of the following Skia tests: tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect_grad, blurrect, blurs, drawbitmapmatrix (max. pixel change in 8888 is 5).
NOTE: This will require adding SK_DISABLE_SEPARABLE_MASK_BLUR to skia.gyp on the next roll into Chrome, until the Chrome rebaselines are done.
Review URL: https://codereview.appspot.com/6845111
git-svn-id: http://skia.googlecode.com/svn/trunk@6606
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 18:58:19 +0000 (18:58 +0000)]
Rename SkClipStack::Rec to SkClipStack::Element
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6854115
git-svn-id: http://skia.googlecode.com/svn/trunk@6605
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 29 Nov 2012 17:27:37 +0000 (17:27 +0000)]
Fix the gr/gl destruction order in Test.cpp
R=djsollen@google.com
Review URL: https://codereview.appspot.com/6851126
git-svn-id: http://skia.googlecode.com/svn/trunk@6602
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 29 Nov 2012 17:09:27 +0000 (17:09 +0000)]
Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs. Change the Coarse flag (which just turns on separable blurs) to an #ifdef, since separable is no longer just Coarse. (This #ifdef will hopefully be shortlived, once Chrome has switched).
The separable blur algorithm gives +45% on SampleBlur, +84% on SampleBigBlur, +31% on TheVerge, +35 to +85% on blurbench in HQ (depending on size), +8 to +35% in low quality. (All of these on 32bit MacPro).
Review URL: https://codereview.appspot.com/6851117
git-svn-id: http://skia.googlecode.com/svn/trunk@6601
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 16:29:58 +0000 (16:29 +0000)]
Remove legacy flag for android from tests
Review URL: https://codereview.appspot.com/6782133
git-svn-id: http://skia.googlecode.com/svn/trunk@6600
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 15:28:45 +0000 (15:28 +0000)]
Fix test app to ensure that we destroy our GPU resources.
The problem arises on devices like the Nexus 10 where we allow the
destruction of resources using the destructor of a static variable.
However, we have no guarentee that the GPU driver has not already
cleaned up it's resources prior to our static destructor.
Review URL: https://codereview.appspot.com/6851124
git-svn-id: http://skia.googlecode.com/svn/trunk@6599
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 29 Nov 2012 15:09:58 +0000 (15:09 +0000)]
Enable profiling options to be selectively enabled for a given build
Review URL: https://codereview.appspot.com/6858089
git-svn-id: http://skia.googlecode.com/svn/trunk@6598
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 29 Nov 2012 14:31:50 +0000 (14:31 +0000)]
shape ops work in progress
Complete rewrite of binary logic makes the result
work and much easier to understand.
git-svn-id: http://skia.googlecode.com/svn/trunk@6597
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 29 Nov 2012 13:49:33 +0000 (13:49 +0000)]
Add newline at end of SkRRect.h
git-svn-id: http://skia.googlecode.com/svn/trunk@6596
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 29 Nov 2012 13:24:55 +0000 (13:24 +0000)]
SkRoundRect start
https://codereview.appspot.com/6815058/
git-svn-id: http://skia.googlecode.com/svn/trunk@6595
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 29 Nov 2012 02:01:19 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6594
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 28 Nov 2012 22:13:32 +0000 (22:13 +0000)]
Remove what turns out to be a bogus assert.
Any problems with size are already handled by checking the return value of CFNumberGetValue.
git-svn-id: http://skia.googlecode.com/svn/trunk@6592
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 28 Nov 2012 21:28:57 +0000 (21:28 +0000)]
update dox
git-svn-id: http://skia.googlecode.com/svn/trunk@6591
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 28 Nov 2012 21:09:18 +0000 (21:09 +0000)]
Write correct type of sfnt file in mac coretext open stream.
https://codereview.appspot.com/6844105/
git-svn-id: http://skia.googlecode.com/svn/trunk@6590
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Wed, 28 Nov 2012 20:23:49 +0000 (20:23 +0000)]
Update bench_expectations.txt with new codes in issue 6842112.
Rev range is [6580, 6585].
Review URL: https://codereview.appspot.com/6858091
git-svn-id: http://skia.googlecode.com/svn/trunk@6589
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 28 Nov 2012 20:08:32 +0000 (20:08 +0000)]
Update gm self-test to pass again after r6585
Now depends on only "dashing2" test, not all tests whose name starts with "dashing",
so it should be more resilient in the face of further changes.
TBR=borenet,robertphillips
Review URL: https://codereview.appspot.com/6844104
git-svn-id: http://skia.googlecode.com/svn/trunk@6588
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 28 Nov 2012 17:18:11 +0000 (17:18 +0000)]
Added dashing fast path
https://codereview.appspot.com/6844067/
git-svn-id: http://skia.googlecode.com/svn/trunk@6585
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Wed, 28 Nov 2012 14:42:41 +0000 (14:42 +0000)]
Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6847116
git-svn-id: http://skia.googlecode.com/svn/trunk@6579
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 28 Nov 2012 14:11:41 +0000 (14:11 +0000)]
Update gyp to allow alternative out directories
If the enviroment variable SKIA_OUT is set the output of both
gyp and make will be redirected to that directory.
Review URL: https://codereview.appspot.com/6782095
git-svn-id: http://skia.googlecode.com/svn/trunk@6578
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 28 Nov 2012 02:02:11 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6577
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 27 Nov 2012 22:57:41 +0000 (22:57 +0000)]
Implement radius interpolation for separable blur. Unroll both separable implementations, which yields up to 2X perf improvement.
Review URL: https://codereview.appspot.com/6850088
git-svn-id: http://skia.googlecode.com/svn/trunk@6576
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Tue, 27 Nov 2012 21:52:32 +0000 (21:52 +0000)]
update bench_expectations with wider range before further investigations and discussions; change precision of bench values to 0.001.
git-svn-id: http://skia.googlecode.com/svn/trunk@6575
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 21:11:05 +0000 (21:11 +0000)]
capture repro case for gradient bug (inside if-false for now)
git-svn-id: http://skia.googlecode.com/svn/trunk@6574
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 18:37:52 +0000 (18:37 +0000)]
revert prev change to reset
git-svn-id: http://skia.googlecode.com/svn/trunk@6571
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Tue, 27 Nov 2012 17:30:26 +0000 (17:30 +0000)]
add skp bench expectations and watch for alerts.
git-svn-id: http://skia.googlecode.com/svn/trunk@6570
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 17:20:39 +0000 (17:20 +0000)]
guard for self-assignment in reset()
git-svn-id: http://skia.googlecode.com/svn/trunk@6568
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 27 Nov 2012 16:50:14 +0000 (16:50 +0000)]
Temporarily disable clip stack reduce test while working on fix.
git-svn-id: http://skia.googlecode.com/svn/trunk@6567
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Tue, 27 Nov 2012 16:09:42 +0000 (16:09 +0000)]
Close pending save() calls in QT debugger to avoid saveLayer() corruption.
http://codereview.appspot.com/6856076/
git-svn-id: http://skia.googlecode.com/svn/trunk@6565
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 27 Nov 2012 16:04:42 +0000 (16:04 +0000)]
Address debugger profiling issue in tile mode
https://codereview.appspot.com/6843113/
git-svn-id: http://skia.googlecode.com/svn/trunk@6564
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 27 Nov 2012 15:43:57 +0000 (15:43 +0000)]
Make the clip stack reduction test generate inverse filled paths.
Also adds some comments to GrReduceClipStack.
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6847109
git-svn-id: http://skia.googlecode.com/svn/trunk@6561
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 15:18:04 +0000 (15:18 +0000)]
don't leak *every* src mask in the ninepatch case. doh.
git-svn-id: http://skia.googlecode.com/svn/trunk@6560
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 15:15:58 +0000 (15:15 +0000)]
add onOnceBeforeDraw() virtual, so gm's can easily perform lazy initialization
git-svn-id: http://skia.googlecode.com/svn/trunk@6559
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 27 Nov 2012 13:13:22 +0000 (13:13 +0000)]
don't use bit-wise test for equality when using floats.
git-svn-id: http://skia.googlecode.com/svn/trunk@6557
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 27 Nov 2012 02:01:19 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6556
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 26 Nov 2012 21:42:32 +0000 (21:42 +0000)]
Actually fix GPU-less build.
git-svn-id: http://skia.googlecode.com/svn/trunk@6555
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 26 Nov 2012 21:38:37 +0000 (21:38 +0000)]
Fix GPU-less build.
Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@6554
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 26 Nov 2012 21:19:43 +0000 (21:19 +0000)]
Add a function that computes a reduced representation of the clip stack.
Also adds a unit test. The function is not yet used other than in the test.
Review URL: https://codereview.appspot.com/6855098
git-svn-id: http://skia.googlecode.com/svn/trunk@6553
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 20:26:54 +0000 (20:26 +0000)]
change SkDrawFilter::filter to return a bool, where false means don't-draw
Review URL: https://codereview.appspot.com/6851111
git-svn-id: http://skia.googlecode.com/svn/trunk@6551
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 20:18:00 +0000 (20:18 +0000)]
must always include another skia header (unless you're SkTypes.h). In this case,
we need SkScalar.h earlier so we can be sure to have int32_t defined.
inspired by https://codereview.appspot.com/6782122/
git-svn-id: http://skia.googlecode.com/svn/trunk@6548
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 18:16:27 +0000 (18:16 +0000)]
check for bad enum use when adding contours
Review URL: https://codereview.appspot.com/6849103
git-svn-id: http://skia.googlecode.com/svn/trunk@6547
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 16:47:10 +0000 (16:47 +0000)]
remove legacy build-guards, now that webkit has rebaselined these.
SK_DISABLE_FAST_AA_STROKE_RECT
SK_IGNORE_FAST_BLURRECT
SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX
SK_IGNORE_CF_OPTIMIZATION
SK_IGNORE_NEW_STROKERECT
SK_DISABLE_GPU_BLUR
SK_IGNORE_ROTATED_FREETYPE_FIX
The changes should all be:
remove code for #ifdef
remove guard for #ifndef
Review URL: https://codereview.appspot.com/6858073
git-svn-id: http://skia.googlecode.com/svn/trunk@6546
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 26 Nov 2012 14:39:50 +0000 (14:39 +0000)]
choose correct blitrow proc based on global alpha
fixes https://bugs.webkit.org/show_bug.cgi?id=103062
add gm to exercise this new fix
git-svn-id: http://skia.googlecode.com/svn/trunk@6544
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 26 Nov 2012 13:09:17 +0000 (13:09 +0000)]
Visualize bitmaps in debugger
https://codereview.appspot.com/6847084/
git-svn-id: http://skia.googlecode.com/svn/trunk@6541
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 22 Nov 2012 02:02:41 +0000 (02:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@6540
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 21 Nov 2012 22:38:36 +0000 (22:38 +0000)]
Remove GrRandom API in favor of SkRandom.
TEST=tests
R=bsalomon@google.com
Review URL: https://codereview.appspot.com/6855062
git-svn-id: http://skia.googlecode.com/svn/trunk@6539
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Wed, 21 Nov 2012 21:36:34 +0000 (21:36 +0000)]
shape ops work in progress
git-svn-id: http://skia.googlecode.com/svn/trunk@6537
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 21 Nov 2012 19:04:17 +0000 (19:04 +0000)]
Add self-test that reveals SkChecksum weakness
Review URL: https://codereview.appspot.com/6845064
git-svn-id: http://skia.googlecode.com/svn/trunk@6535
2bbb7eff-a529-9590-31e7-
b0007b416f81
rmistry@google.com [Wed, 21 Nov 2012 18:37:58 +0000 (18:37 +0000)]
Fixed some compilation problems with debugger with robertphillips
git-svn-id: http://skia.googlecode.com/svn/trunk@6534
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 21 Nov 2012 18:34:15 +0000 (18:34 +0000)]
add default: to fix warning
git-svn-id: http://skia.googlecode.com/svn/trunk@6533
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 21 Nov 2012 17:11:02 +0000 (17:11 +0000)]
Add drawing of paths to debugger
https://codereview.appspot.com/6850082/
git-svn-id: http://skia.googlecode.com/svn/trunk@6532
2bbb7eff-a529-9590-31e7-
b0007b416f81
sugoi@google.com [Wed, 21 Nov 2012 16:44:45 +0000 (16:44 +0000)]
Simple change to remove unnecessary #define statement.
BUG=http://code.google.com/p/chromium/issues/detail?id=137924
TEST=TestDeferredCanvasBitmapSizeThreshold unit test
Review URL: https://codereview.appspot.com/6845071
git-svn-id: http://skia.googlecode.com/svn/trunk@6531
2bbb7eff-a529-9590-31e7-
b0007b416f81