platform/upstream/glib.git
13 years agoglib-unix.c: Don't leak FDs if pipe2() succeeds
Colin Walters [Tue, 3 May 2011 20:22:13 +0000 (16:22 -0400)]
glib-unix.c: Don't leak FDs if pipe2() succeeds

13 years agoOnly remove the lines that are no longer needed
Matthias Clasen [Tue, 3 May 2011 16:41:11 +0000 (12:41 -0400)]
Only remove the lines that are no longer needed

13 years agoRevert "[build] Remove stale LDADD lines from tests/Makefile.am to allow build"
Matthias Clasen [Tue, 3 May 2011 16:37:45 +0000 (12:37 -0400)]
Revert "[build] Remove stale LDADD lines from tests/Makefile.am to allow build"

This reverts commit b0874ce28e910121fb2d94f6f9183bfdc08e8eaf.

13 years agoUse g types in public API for consistency
Colin Walters [Tue, 3 May 2011 14:57:22 +0000 (10:57 -0400)]
Use g types in public API for consistency

13 years agoGCancellable: Use g_unix_pipe_flags with FD_CLOEXEC
Colin Walters [Mon, 2 May 2011 19:42:51 +0000 (15:42 -0400)]
GCancellable: Use g_unix_pipe_flags with FD_CLOEXEC

The old code was creating a pipe and setting FD_CLOEXEC
non-atomically.

https://bugzilla.gnome.org/show_bug.cgi?id=649225

13 years agog_unix_set_fd_nonblocking: New API to control file descriptor blocking state
Colin Walters [Tue, 3 May 2011 13:52:10 +0000 (09:52 -0400)]
g_unix_set_fd_nonblocking: New API to control file descriptor blocking state

And use it in relevant places in GLib.

https://bugzilla.gnome.org/show_bug.cgi?id=649225

13 years agoglib-unix.h: Unconditionally include unistd.h
Colin Walters [Mon, 2 May 2011 21:02:16 +0000 (17:02 -0400)]
glib-unix.h: Unconditionally include unistd.h

danw points out it's part of POSIX.

https://bugzilla.gnome.org/show_bug.cgi?id=649201

13 years agoFix usage of _GNU_SOURCE
Dan Winship [Sun, 1 May 2011 15:17:14 +0000 (11:17 -0400)]
Fix usage of _GNU_SOURCE

_GNU_SOURCE must be defined before including any other (system)
header, so defining it in glib-unix.h (and hoping no one has included
anything else before that) is wrong. And the "#define _USE_GNU"
workaround for this problem in gnetworkingprivate.h is even wronger
(and still prone to failure anyway due to single-include guards).

Fix this by defining _GNU_SOURCE in config.h when building against
glibc. In theory this is bad because new releases of glibc may include
symbols that conflict with glib symbols, which could then cause
compile failures. However, most people only see new releases of glibc
when they upgrade their distro, at which point they also generally get
new releases of gcc, which have new warnings/errors to clean up
anyway.

https://bugzilla.gnome.org/show_bug.cgi?id=649201

13 years agoAdd back an erroneously-removed line to tests/Makefile.am
Dan Winship [Mon, 2 May 2011 21:06:37 +0000 (17:06 -0400)]
Add back an erroneously-removed line to tests/Makefile.am

13 years agoDrop translated g_warning/g_error
Colin Walters [Fri, 29 Apr 2011 14:59:42 +0000 (10:59 -0400)]
Drop translated g_warning/g_error

http://mail.gnome.org/archives/desktop-devel-list/2011-March/msg00069.html

13 years agoglib/Makefile.am: add gmain-internal.h to sources
Ray Strode [Mon, 2 May 2011 16:33:36 +0000 (12:33 -0400)]
glib/Makefile.am: add gmain-internal.h to sources

It's a new private header.

This commit adds it to the Makefile so it's properly distributed
with the sources.

13 years agogobject: Warn if someone uses the wrong property in g_object_get/set
Benjamin Otte [Mon, 2 May 2011 17:22:25 +0000 (19:22 +0200)]
gobject: Warn if someone uses the wrong property in g_object_get/set

"Interface::property" was not detected before and led to a crash.

13 years agoAdded UG translation
Abduxukur Abdurixit [Mon, 2 May 2011 16:29:59 +0000 (18:29 +0200)]
Added UG translation

13 years agoFix compiler warnings
Dan Winship [Mon, 2 May 2011 15:45:52 +0000 (11:45 -0400)]
Fix compiler warnings

13 years agoFix autoconf 2.68 warnings
Dan Winship [Mon, 2 May 2011 15:44:46 +0000 (11:44 -0400)]
Fix autoconf 2.68 warnings

autoconf 2.68 is very insistent that AC_LANG_SOURCE/AC_LANG_PROGRAM
must be used in certain places, to avoid quoting/lack-of-quoting
problems, or something. Fix.

13 years agoBug 648966 - Update g_unichar_iswide and g_unichar_iswide_cjk
Behdad Esfahbod [Mon, 2 May 2011 15:43:02 +0000 (11:43 -0400)]
Bug 648966 - Update g_unichar_iswide and g_unichar_iswide_cjk

Add tests.

13 years ago[build] Remove stale LDADD lines from tests/Makefile.am to allow build
Behdad Esfahbod [Mon, 2 May 2011 15:26:01 +0000 (11:26 -0400)]
[build] Remove stale LDADD lines from tests/Makefile.am to allow build

Automake 1.11 wasn't happy.

13 years agoUpdate .gitignores
Dan Winship [Mon, 2 May 2011 13:53:59 +0000 (09:53 -0400)]
Update .gitignores

13 years agoSome documentation additions
Matthias Clasen [Mon, 2 May 2011 03:02:53 +0000 (23:02 -0400)]
Some documentation additions

13 years agoAvoid an unused variable warning
Matthias Clasen [Mon, 2 May 2011 00:43:04 +0000 (20:43 -0400)]
Avoid an unused variable warning

Also, clean up some whitespace

13 years agoFix make check
Matthias Clasen [Sun, 1 May 2011 21:07:46 +0000 (17:07 -0400)]
Fix make check

g_thread_init() causes a hash table to be allocated (in read_aliases).
Since hash tables are now a bit larger, we need to bump one of the
probe sizes to avoid our probe slice being used for the aliases
hash table.

13 years agoAdded UG translation
Abduxukur Abdurixit [Sun, 1 May 2011 18:04:51 +0000 (20:04 +0200)]
Added UG translation

13 years agoGHash: make sets with refcounted keys work correctly
Matthias Clasen [Sun, 1 May 2011 14:55:24 +0000 (10:55 -0400)]
GHash: make sets with refcounted keys work correctly

When keys == values, we have to be careful about the order in
which we replace their elements.

13 years agoGHash: introduce a "set" mode
Matthias Clasen [Sun, 1 May 2011 02:28:34 +0000 (22:28 -0400)]
GHash: introduce a "set" mode

Make hash tables start out in a mode in which they don't store
values at all, until the first insertion of a non-identical
key-value pair.

This reduces memory requirements by 1/3 when using hash tables
to store sets.

Based on a patch by Morten Welinder,
https://bugzilla.gnome.org/show_bug.cgi?id=644437

13 years agoGHash: eliminate one of the lookup_nodes functions.
Morten Welinder [Wed, 27 Apr 2011 14:46:00 +0000 (10:46 -0400)]
GHash: eliminate one of the lookup_nodes functions.

Kill g_hash_table_lookup_node and rename g_hash_table_lookup_node_for_insertion
to g_hash_table_lookup_node.  Since at this point we already check for
toombstones in all callers of g_hash_table_lookup_node this doesn't make
a difference.

https://bugzilla.gnome.org/show_bug.cgi?id=644437

13 years agoGHash: split nodes array into seperate arrays.
Morten Welinder [Wed, 27 Apr 2011 14:39:56 +0000 (10:39 -0400)]
GHash: split nodes array into seperate arrays.

This reduces memory requirements by 1/6 on 64-bit machines since
no padding is needed.  It also puts less strain on the memory
allocator since we no longer need one giant slab of memory.

https://bugzilla.gnome.org/show_bug.cgi?id=644437

13 years agoGHash: use macros to check for magic hash values.
Morten Welinder [Wed, 27 Apr 2011 13:53:39 +0000 (09:53 -0400)]
GHash: use macros to check for magic hash values.

https://bugzilla.gnome.org/show_bug.cgi?id=644437

13 years agoUpdate VS2008/2010 README.txt
Chun-wei Fan [Sun, 1 May 2011 01:42:22 +0000 (09:42 +0800)]
Update VS2008/2010 README.txt

Tell people about the usage of ZLib to avoid the
problem such as the one mentioned in Bug 633977

13 years agoBug 648966 - Update g_unichar_iswide and g_unichar_iswide_cjk
Behdad Esfahbod [Fri, 29 Apr 2011 20:14:49 +0000 (16:14 -0400)]
Bug 648966 - Update g_unichar_iswide and g_unichar_iswide_cjk

Update to Unicode 6.0.  Also attach Python script that generates
the tables.

13 years agoRemove duplicate GDBusInterface declaration
Ryan Lortie [Fri, 29 Apr 2011 21:06:26 +0000 (17:06 -0400)]
Remove duplicate GDBusInterface declaration

It was in gdbusinterface.h but also in giotypes.h.  Remove it from the
former.

13 years agoUpdate docs to take comments/suggestions from Matthias into account
David Zeuthen [Fri, 29 Apr 2011 17:11:22 +0000 (13:11 -0400)]
Update docs to take comments/suggestions from Matthias into account

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoMerge branch 'master' into gdbus-codegen
David Zeuthen [Fri, 29 Apr 2011 16:01:35 +0000 (12:01 -0400)]
Merge branch 'master' into gdbus-codegen

13 years agoGFilterInputStream: close-base-stream should not be construct-only
Alexander Larsson [Fri, 29 Apr 2011 14:14:17 +0000 (16:14 +0200)]
GFilterInputStream: close-base-stream should not be construct-only

This is a runtime changable property (by the methods for it), must
be a cut and paste error.

13 years agoUse SIGTRAP (via G_BREAKPOINT()) if G_DEBUG=fatal-warnings
Colin Walters [Tue, 26 Apr 2011 17:04:25 +0000 (13:04 -0400)]
Use SIGTRAP (via G_BREAKPOINT()) if G_DEBUG=fatal-warnings

On Linux with gdb, it's much more convenient to debug programs using
G_DEBUG=fatal-warnings if we send SIGTRAP instead of abort() by
default.  The default handler for both is to terminate the process.

In particular this makes it more easily possible to debug a warning
that's not the first in a program; you can skip past it and
go to the warning you care about.

The "aborting..." message is removed since it's no longer accurate,
and anyways was never very useful; crashes should show up in ABRT/apport
type crash catching systems.

https://bugzilla.gnome.org/show_bug.cgi?id=648423

13 years agoUpdated Spanish translation
Daniel Mustieles [Thu, 28 Apr 2011 18:45:34 +0000 (20:45 +0200)]
Updated Spanish translation

13 years agoglib/gvariant.c: Fix variable name in example code
Shaun McCance [Thu, 28 Apr 2011 16:41:41 +0000 (12:41 -0400)]
glib/gvariant.c: Fix variable name in example code

13 years agoDrop stray reference to gthread.la
Colin Walters [Wed, 27 Apr 2011 23:09:38 +0000 (19:09 -0400)]
Drop stray reference to gthread.la

We now build this test multithreaded in gthread/tests.

13 years agoglib/Makefile.am: Remove stray tab
Colin Walters [Wed, 27 Apr 2011 22:42:29 +0000 (18:42 -0400)]
glib/Makefile.am: Remove stray tab

13 years agoglib-unix: New API to watch some Unix signals
Colin Walters [Thu, 17 Mar 2011 14:11:41 +0000 (10:11 -0400)]
glib-unix: New API to watch some Unix signals

This new API allows watching a few select Unix signals;
looking through the list on my system, I didn't see anything
else that I think it'd reasonable to watch.

We build on the previous patch to make the child watch helper thread
that existed on Unix handle these signals in the threaded case.
In the non-threaded case, they're just global variables.

https://bugzilla.gnome.org/show_bug.cgi?id=644941

13 years agogmain: Prepare child watch handling for more generic signal handling
Colin Walters [Wed, 16 Mar 2011 23:02:15 +0000 (19:02 -0400)]
gmain: Prepare child watch handling for more generic signal handling

In preparation for supporting more Unix signals such as SIGHUP,
SIGTERM etc.,

https://bugzilla.gnome.org/show_bug.cgi?id=644941

13 years agoglib-unix: New Unix-specific API
Colin Walters [Wed, 16 Mar 2011 17:54:28 +0000 (13:54 -0400)]
glib-unix: New Unix-specific API

GLib historically has been designed to be "mostly" portable; there
are some functions only available on Unix like g_io_channel_unix_new(),
but these are typically paired with obvious counterparts for Win32.

However, as GLib is used not only by portable software, but components
targeting Unix (or even just Linux), there are a few cases where it
would be very convenient if GLib shipped built-in functionality.

This initial patch is a basic wrapper around pipe2(), including
fallbacks for older kernels.  This pairs well with the
existing g_spawn_*() API and its child_setup functionality.

However, in the future, I want to add a signal() wrapper here,
complete with proxying the signal to a mainloop.  I have initial code
for this, but doing it sanely (including factoring out gmain.c's
private worker thread), is a complex task, and I don't want to block
on that.

See also gwin32.h for Win32 specific functionality.

https://bugzilla.gnome.org/show_bug.cgi?id=644941

13 years agoUpdate gio.symbols for previous two commits
Colin Walters [Wed, 27 Apr 2011 17:29:07 +0000 (13:29 -0400)]
Update gio.symbols for previous two commits

13 years agoGDesktopAppInfo: Add g_desktop_app_info_get_generic_name
Colin Walters [Wed, 27 Apr 2011 15:34:23 +0000 (11:34 -0400)]
GDesktopAppInfo: Add g_desktop_app_info_get_generic_name

Necessary for rebasing gnome-menus on top of GDesktopAppInfo.

https://bugzilla.gnome.org/show_bug.cgi?id=647967

13 years agoGDesktopAppInfo: Add g_desktop_app_info_get_categories()
Colin Walters [Fri, 15 Apr 2011 19:52:33 +0000 (15:52 -0400)]
GDesktopAppInfo: Add g_desktop_app_info_get_categories()

This is needed to rebase gnome-menus on top of GDesktopAppInfo.

https://bugzilla.gnome.org/show_bug.cgi?id=647903

13 years agoFix %z in g_date_time_format()
David Schleef [Tue, 22 Feb 2011 02:58:09 +0000 (18:58 -0800)]
Fix %z in g_date_time_format()

https://bugzilla.gnome.org/show_bug.cgi?id=642935

13 years agoGHashTable: Small optimization of remove-all
Matthias Clasen [Wed, 27 Apr 2011 04:03:59 +0000 (00:03 -0400)]
GHashTable: Small optimization of remove-all

Don't enter the loop if we are not going to notify anyway.
Pointed out in bug 646013.

13 years agoGHashTable: Add a test for remove-all functionality
Matthias Clasen [Wed, 27 Apr 2011 04:03:28 +0000 (00:03 -0400)]
GHashTable: Add a test for remove-all functionality

13 years agoWhitespace cleanup
Matthias Clasen [Wed, 27 Apr 2011 03:57:17 +0000 (23:57 -0400)]
Whitespace cleanup

13 years agoAllow caching have_qsort_r which re-enables cross-compiling
Maciej Piechotka [Thu, 31 Mar 2011 07:00:27 +0000 (09:00 +0200)]
Allow caching have_qsort_r which re-enables cross-compiling

https://bugzilla.gnome.org/show_bug.cgi?id=646309

13 years agoFix mailing list link in README
Matthias Clasen [Wed, 27 Apr 2011 03:26:58 +0000 (23:26 -0400)]
Fix mailing list link in README

Patch by Thomas Andersen, bug 647594

13 years agoGDBusServer: Documentation: Improvements.
Murray Cumming [Mon, 4 Apr 2011 08:01:51 +0000 (10:01 +0200)]
GDBusServer: Documentation: Improvements.

Provide a fuller description and lead people away if they arrived
here just looking for a way to provide a regular D-Bus service.

https://bugzilla.gnome.org/show_bug.cgi?id=646425

13 years agoUse G_SIGNAL_MUST_COLLECT for VARIANT signals
Christian Persch [Fri, 4 Mar 2011 17:21:51 +0000 (18:21 +0100)]
Use G_SIGNAL_MUST_COLLECT for VARIANT signals

Bug #643624.

13 years agoFix up some harmless FALSE <> NULL confusions
Matthias Clasen [Wed, 27 Apr 2011 02:51:54 +0000 (22:51 -0400)]
Fix up some harmless FALSE <> NULL confusions

Reported in bug 643134.

13 years agoGSequence: Make g_sequence_iter_move behave as documented
Matthias Clasen [Wed, 27 Apr 2011 02:08:24 +0000 (22:08 -0400)]
GSequence: Make g_sequence_iter_move behave as documented

As pointed out in bug 658313, moving before the begin iter is
supposed to return the begin iter, not the end iter. Also add
a test for this behaviour.

13 years agoGDesktopAppInfo: Add "filename" property for bindings
Colin Walters [Tue, 26 Apr 2011 19:08:54 +0000 (15:08 -0400)]
GDesktopAppInfo: Add "filename" property for bindings

GDesktopAppInfo violates the GObject rule that your C constructors
should just be thin wrappers around g_object_new().  While GKeyFile
isn't introspctable, this patch allows from JavaScript:

var app = new Gio.DesktopAppInfo({ filename: '/path/to/foo.desktop' });

https://bugzilla.gnome.org/show_bug.cgi?id=648425

13 years agoSquash some uninitialized variable compiler warnings
Colin Walters [Tue, 26 Apr 2011 17:28:17 +0000 (13:28 -0400)]
Squash some uninitialized variable compiler warnings

From GCC 4.6.

13 years agoGSimpleAsyncResult: push thread context around callback
Dan Winship [Wed, 20 Apr 2011 15:41:47 +0000 (11:41 -0400)]
GSimpleAsyncResult: push thread context around callback

When an old pre-thread-default-context API that takes an explicit
GMainContext wants to call a gio API, it must call
g_main_context_push_thread_default() before, and
g_main_context_pop_thread_default() after the gio call, so that the
gio method will return its result to the desired GMainContext.

But this fails for methods like g_socket_client_connect_async() that
make a chain of multiple async calls, since the pushed/popped context
will only affect the initial call.

Fix this by having GSimpleAsyncResult itself push/pop the context
around the callback invocation, so that if the callback queues another
async request, it will stay in the same context as the original one.

https://bugzilla.gnome.org/show_bug.cgi?id=646957

13 years agoUpdated Turkish translation
Muhammet Kara [Tue, 26 Apr 2011 00:04:20 +0000 (03:04 +0300)]
Updated Turkish translation

13 years agogdbus-codegen: Fix typo in generated docs
David Zeuthen [Mon, 25 Apr 2011 14:42:50 +0000 (10:42 -0400)]
gdbus-codegen: Fix typo in generated docs

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Generate GDBusObject{,Proxy,Skeleton} subtypes
David Zeuthen [Mon, 25 Apr 2011 13:29:18 +0000 (09:29 -0400)]
gdbus-codegen: Generate GDBusObject{,Proxy,Skeleton} subtypes

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoDon't ignore SUPPORTS_STARTUP_NOTIFICATION for commandline GAppInfos
Michael Terry [Mon, 25 Apr 2011 12:29:35 +0000 (08:29 -0400)]
Don't ignore SUPPORTS_STARTUP_NOTIFICATION for commandline GAppInfos

https://bugzilla.gnome.org/show_bug.cgi?id=648416

13 years agoAdd VS 2008 compilation support for some utilities
Chun-wei Fan [Mon, 25 Apr 2011 05:47:07 +0000 (13:47 +0800)]
Add VS 2008 compilation support for some utilities

-Added projects to compile the glib-compile-schemas and gsettings utilities
-Update .vsprops to install these in "install" phase
-Distribute these projects also

13 years agoAdd VS 2010 compilation support for some utilities
Chun-wei Fan [Mon, 25 Apr 2011 05:32:18 +0000 (13:32 +0800)]
Add VS 2010 compilation support for some utilities

-Added projects to compile the glib-compile-schemas and gsettings utilities
-Update .vsprops to install these in "install" phase
-Distribute these projects also

13 years agoFix build broken by previous commit
David Zeuthen [Sat, 23 Apr 2011 23:26:56 +0000 (19:26 -0400)]
Fix build broken by previous commit

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Include docs for generated code in the GIO docs
David Zeuthen [Sat, 23 Apr 2011 21:43:03 +0000 (17:43 -0400)]
gdbus-codegen: Include docs for generated code in the GIO docs

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agodocs: fix typos in networking classes
Thomas Hindoe Paaboel Andersen [Wed, 20 Apr 2011 17:08:06 +0000 (19:08 +0200)]
docs: fix typos in networking classes

13 years agoGDBusObjectManagerServer: make export() return whether the object was removed
David Zeuthen [Wed, 20 Apr 2011 15:54:24 +0000 (11:54 -0400)]
GDBusObjectManagerServer: make export() return whether the object was removed

This is useful in conjunction with g_warn_if_fail().

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoGSocketService: clarify transfer semantics of incoming connections
Dan Winship [Wed, 20 Apr 2011 15:24:46 +0000 (11:24 -0400)]
GSocketService: clarify transfer semantics of incoming connections

The @connection parameter to the ::incoming signal is (transfer none),
so you need to ref it if you want to keep it.

https://bugzilla.gnome.org/show_bug.cgi?id=647746

13 years agogdbus-codegen: Document the generated FOO_PEEK_BAR() and FOO_GET_BAR() macros
David Zeuthen [Wed, 20 Apr 2011 13:00:16 +0000 (09:00 -0400)]
gdbus-codegen: Document the generated FOO_PEEK_BAR() and FOO_GET_BAR() macros

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Generate gtk-doc section docs
David Zeuthen [Tue, 19 Apr 2011 18:39:47 +0000 (14:39 -0400)]
gdbus-codegen: Generate gtk-doc section docs

This is nice to have if using gtk-doc on the generated code. We could
also generate -sections.txt and .types files but we don't do that
right now...

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Set nick+blurb for properties to shut up gtk-doc
David Zeuthen [Tue, 19 Apr 2011 17:42:28 +0000 (13:42 -0400)]
gdbus-codegen: Set nick+blurb for properties to shut up gtk-doc

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: It's GDBusProxyTypeFunc, not GDBusProxyFunc
David Zeuthen [Tue, 19 Apr 2011 17:39:12 +0000 (13:39 -0400)]
gdbus-codegen: It's GDBusProxyTypeFunc, not GDBusProxyFunc

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Document the generated ObjectManagerClient structs
David Zeuthen [Tue, 19 Apr 2011 17:16:10 +0000 (13:16 -0400)]
gdbus-codegen: Document the generated ObjectManagerClient structs

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Add "Returns:" blurb for generated get_proxy_type()
David Zeuthen [Tue, 19 Apr 2011 17:10:25 +0000 (13:10 -0400)]
gdbus-codegen: Add "Returns:" blurb for generated get_proxy_type()

This was forgotten.

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Generate docs when generating C code
David Zeuthen [Mon, 18 Apr 2011 18:23:19 +0000 (14:23 -0400)]
gdbus-codegen: Generate docs when generating C code

This is handy for both gtk-doc and gobject-introspection.

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoAPI: testutils: Add g_test_fail()
Benjamin Otte [Fri, 15 Apr 2011 01:23:12 +0000 (03:23 +0200)]
API: testutils: Add g_test_fail()

This allows tests to fail in a nonfatal way and the test runner can
continue if invoked with -k.

https://bugzilla.gnome.org/show_bug.cgi?id=647826

13 years agotestutils: Sprinkle code with newlines
Benjamin Otte [Mon, 18 Apr 2011 12:45:53 +0000 (14:45 +0200)]
testutils: Sprinkle code with newlines

Readable code ftw!

13 years agotestutils: Return number of bad tests from g_test_run_suite_internal()
Benjamin Otte [Mon, 18 Apr 2011 12:41:51 +0000 (14:41 +0200)]
testutils: Return number of bad tests from g_test_run_suite_internal()

In particular do not return a boolean disguised as an int.

13 years agotestutils: Remove unused variable
Benjamin Otte [Mon, 18 Apr 2011 12:37:24 +0000 (14:37 +0200)]
testutils: Remove unused variable

13 years agotestutils: Return a boolean from g_test_case_run()
Benjamin Otte [Mon, 18 Apr 2011 12:35:58 +0000 (14:35 +0200)]
testutils: Return a boolean from g_test_case_run()

Return value is intened to be TRUE for success, FALSE for failure.
Currently we return TRUE all the time.
Previously the test returned 0 all the time.

13 years agoGDBusObjectManagerClient: Add a GDestroyNotify to the user_data
David Zeuthen [Sat, 16 Apr 2011 19:24:42 +0000 (15:24 -0400)]
GDBusObjectManagerClient: Add a GDestroyNotify to the user_data

For bindings, obviously.

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoGDBus: Add some gobject-introspection annotations for new code
David Zeuthen [Sat, 16 Apr 2011 18:42:21 +0000 (14:42 -0400)]
GDBus: Add some gobject-introspection annotations for new code

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Make generated code introspectable
David Zeuthen [Sat, 16 Apr 2011 18:07:23 +0000 (14:07 -0400)]
gdbus-codegen: Make generated code introspectable

Specific changes

 - Use get_type(), not get_gtype() for the GType function
   - so we need to use the lower-case name type_ for properties called type
 - Don't return a function pointer, just make the function returned
   available instead
 - Add (type) annotations in constructors so g-ir-scanner detects them as such
 - Add (transfer none) annotations to property getters
 - Add (out) annotations to D-Bus method call functions

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Nuke debug spew
David Zeuthen [Fri, 15 Apr 2011 20:36:54 +0000 (16:36 -0400)]
gdbus-codegen: Nuke debug spew

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Never emit empty PropertiesChanged signals
David Zeuthen [Fri, 15 Apr 2011 20:11:43 +0000 (16:11 -0400)]
gdbus-codegen: Never emit empty PropertiesChanged signals

It's not that it's actually a bug to do so per se, strictly speaking,
it's just pointless and wasteful.

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Don't send out PropertiesChanged if value ends up not changing
David Zeuthen [Fri, 15 Apr 2011 19:53:28 +0000 (15:53 -0400)]
gdbus-codegen: Don't send out PropertiesChanged if value ends up not changing

A fairly typical pattern is to have code that does

 foo_set_bar (object, "");
 if (some_condition)
   {
     foo_set_bar (object, "yes");
   }

where some_condition is often true every time @object is updated.

With this code, bar is essentially always "yes" but because of how
gdbus-codegen works, useless PropertiesChanged events got scheduled
and sent out. With this patch, we avoid that by always keeping the
original value around and comparing it only when we deem it's time to
send out the ::PropertiesChanged signal (typically in an idle but can
be forced by the user via flush()).

Also add a test case for this.

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoFix some compiler warnings from gcc 4.6
Colin Walters [Fri, 15 Apr 2011 19:51:25 +0000 (15:51 -0400)]
Fix some compiler warnings from gcc 4.6

13 years agogapplication: Fix typo in property
Colin Walters [Thu, 14 Apr 2011 20:03:18 +0000 (16:03 -0400)]
gapplication: Fix typo in property

13 years agogdbus-codegen: Fix obvious bug in _g_variant_equal0() implementation
David Zeuthen [Fri, 15 Apr 2011 17:51:10 +0000 (13:51 -0400)]
gdbus-codegen: Fix obvious bug in _g_variant_equal0() implementation

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Add support for the org.freedesktop.DBus.Deprecated annotation
David Zeuthen [Fri, 15 Apr 2011 16:56:07 +0000 (12:56 -0400)]
gdbus-codegen: Add support for the org.freedesktop.DBus.Deprecated annotation

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoGApplication: #include "gsettings.h"
Ryan Lortie [Fri, 15 Apr 2011 13:30:24 +0000 (09:30 -0400)]
GApplication: #include "gsettings.h"

Since we call g_settings_sync() from there now...

13 years agoMerge remote-tracking branch 'gvdb/master'
Ryan Lortie [Fri, 15 Apr 2011 13:29:47 +0000 (09:29 -0400)]
Merge remote-tracking branch 'gvdb/master'

13 years agobuilder: do not include <unistd.h> on win32
Ryan Lortie [Fri, 15 Apr 2011 13:27:38 +0000 (09:27 -0400)]
builder: do not include <unistd.h> on win32

Spotted by Kean Johnston <kean.johnston@gmail.com>.

https://mail.gnome.org/archives/gtk-devel-list/2011-April/msg00010.html

13 years agogdbus-codegen: Include a blurb about the license of the generated code
David Zeuthen [Fri, 15 Apr 2011 12:48:21 +0000 (08:48 -0400)]
gdbus-codegen: Include a blurb about the license of the generated code

More precisely, include this line

 The license of this code is the same as for the source it was derived from.

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Use the right program name in introductory comment (again)
David Zeuthen [Fri, 15 Apr 2011 12:44:05 +0000 (08:44 -0400)]
gdbus-codegen: Use the right program name in introductory comment (again)

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Use the right program name in introductory comment
David Zeuthen [Fri, 15 Apr 2011 12:40:52 +0000 (08:40 -0400)]
gdbus-codegen: Use the right program name in introductory comment

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agogdbus-codegen: Add copyright / license headers
David Zeuthen [Fri, 15 Apr 2011 12:33:30 +0000 (08:33 -0400)]
gdbus-codegen: Add copyright / license headers

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoGDBus: Support Ugly_Case and use org.gtk.GDBus.C.Name since it's C-only
David Zeuthen [Fri, 15 Apr 2011 12:24:40 +0000 (08:24 -0400)]
GDBus: Support Ugly_Case and use org.gtk.GDBus.C.Name since it's C-only

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agoBug 637561 - Crash when using G_DBUS_SERVER_FLAGS_RUN_IN_THREAD
Michael Kuhn [Wed, 22 Dec 2010 09:11:11 +0000 (10:11 +0100)]
Bug 637561 - Crash when using G_DBUS_SERVER_FLAGS_RUN_IN_THREAD

https://bugzilla.gnome.org/show_bug.cgi?id=637561

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years ago/gdbus/message-serialize-invalid test: be compatible with D-Bus 1.4.8
Simon McVittie [Thu, 31 Mar 2011 12:58:55 +0000 (13:58 +0100)]
/gdbus/message-serialize-invalid test: be compatible with D-Bus 1.4.8

Older versions of libdbus would let you construct an invalid
DBusMessage, but that's a bug, which will be fixed in 1.4.8/1.5.0.
Instead, construct a valid message of the same length, then replace
substrings in the serialized blob with their invalid counterparts.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=646326

Signed-off-by: David Zeuthen <davidz@redhat.com>