erik.corry@gmail.com [Thu, 10 May 2012 20:34:06 +0000 (20:34 +0000)]
Fix compose-discard crasher from 11524. We can't do a call (to a generic
stub) unless there is a pointer map. This does not fix the 3d-raytrace
regression, that will be in another change.
Review URL: https://chromiumcodereview.appspot.com/
10382102
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11539
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Thu, 10 May 2012 15:55:19 +0000 (15:55 +0000)]
Set object tags directly to the entry name in heap profiler.
Review URL: https://chromiumcodereview.appspot.com/
10382106
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11538
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Thu, 10 May 2012 12:44:15 +0000 (12:44 +0000)]
Extend grokdump with basic interactive shell capabilities.
Supported commands:
- dd: to print memory region
- s: to search for a word in available memory regions
- list: to list available memory regions
R=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10378087
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11537
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Thu, 10 May 2012 10:35:42 +0000 (10:35 +0000)]
Activate new global semantics by default.
R=mstarzinger@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10383085
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11536
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Thu, 10 May 2012 09:17:32 +0000 (09:17 +0000)]
Merge SetObjectNames extra pass into the main pass.
Because heap snapshotting is now performed in a single pass
it is safe to make calls to GetConstructorName and further to
LocalLookupRealNamedProperty right within that main pass.
Review URL: https://chromiumcodereview.appspot.com/
10332087
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11535
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Wed, 9 May 2012 15:49:03 +0000 (15:49 +0000)]
Fix formatting.
TBR=mnaganov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10356075
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11534
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 9 May 2012 15:18:50 +0000 (15:18 +0000)]
Properly set ElementsKind of empty FAST_DOUBLE_ELEMENTS arrays when transitioning.
R=jkummerow@chromium.org
BUG=chromium:117409
TEST=test/mjsunit/regress/regress-117409.js
Review URL: https://chromiumcodereview.appspot.com/
10386045
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11533
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Wed, 9 May 2012 14:34:27 +0000 (14:34 +0000)]
Declare more functions returing a MaybeObject* with MUST_USE_RESULT.
No violations found this time.
Additionally I changed one function JSDate::GetField that never returns
a failure to return a Object* instead.
Review URL: https://chromiumcodereview.appspot.com/
10383088
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11532
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Wed, 9 May 2012 14:34:13 +0000 (14:34 +0000)]
Split nodes and edges into separate arrays in heap profiler.
This allowed the following changes:
- heap profiler now makes one pass less over the heap.
- HeapEntriesMap does not allocate EntryInfo per each entry.
- there's no need for an extra pass to set indexes before serialization.
As a result snapshot taking time has reduced up to 2x times.
Review URL: https://chromiumcodereview.appspot.com/
10353010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11531
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Wed, 9 May 2012 12:49:56 +0000 (12:49 +0000)]
Force checking of result on all functions in elements.h that return MaybeObject*.
Add two missing failure checks found by this.
Review URL: https://chromiumcodereview.appspot.com/
10356071
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11530
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Wed, 9 May 2012 12:35:11 +0000 (12:35 +0000)]
Make Error.prototype.name writable again, as required by the spec and the web.
Address http://code.google.com/p/chromium/issues/detail?id=69187 by instead
ignoring getters on ReferenceError.prototype.name in Error.prototype.toString.
And while we're at it, do the same for SyntaxError and TypeError, and the
properties "message", "type", and "arguments" on all of them, which
potentially have similar issues.
R=danno@chromium.org
BUG=69187
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10234004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11529
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 9 May 2012 07:29:18 +0000 (07:29 +0000)]
Implement explicit back pointers in transition tree.
This makes back pointers in the map transition tree explicit by having
accurate back pointers throughout the lifetime of maps instead of
establishing and destroying back pointers before and after each marking
phase. This is a prerequisite for being able to clear map transitions
during incremental marking.
R=vegorov@chromium.org
BUG=v8:1465
Review URL: https://chromiumcodereview.appspot.com/
10381053
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11528
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 8 May 2012 12:38:24 +0000 (12:38 +0000)]
Force inlining CopyChars and String::Get.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10332054
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11527
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 8 May 2012 12:30:36 +0000 (12:30 +0000)]
Fix function sorter from 11482 with correct fix. The sorter
was reverted from trunk 3.10.8.1, with this change we can
repush it.
Review URL: https://chromiumcodereview.appspot.com/
10377043
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11526
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 8 May 2012 12:18:08 +0000 (12:18 +0000)]
Regexp: Fix overflow in min-match-length calculation. Crbug=126412.
Review URL: https://chromiumcodereview.appspot.com/
10384053
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11525
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 8 May 2012 09:22:58 +0000 (09:22 +0000)]
Make DeltaBlue performance more stable by ignoring type feedback that
tells us that a map can transition to another map when we are generating
code for load operations. This may cause us to deopt if the same routine
is seeing different maps caused by branching in constructors. If so, I
have a different change that is around 100 times more complicated that
lets us generated Crankshaft code for negative lookups.
Review URL: https://chromiumcodereview.appspot.com/
10306010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11524
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 7 May 2012 17:31:14 +0000 (17:31 +0000)]
MIPS: Fixed illegal instruction use on Loongson in code for Math.random().
BUG=v8:2115
TEST=mjsunit/string-case,mjsunit/regress/regress-110509,mjsunit/math-floor
Review URL: https://chromiumcodereview.appspot.com/
10383044
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11523
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 7 May 2012 13:23:56 +0000 (13:23 +0000)]
Fix crash bug in VisitChoice (bug=126272).
Review URL: https://chromiumcodereview.appspot.com/
10332035
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11519
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 7 May 2012 10:05:39 +0000 (10:05 +0000)]
Fix unsigned-Smi check in MappedArgumentsLookup
BUG=126414
TEST=mjsunit/regress/regress-crbug-126414
Review URL: https://chromiumcodereview.appspot.com/
10375033
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11518
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 4 May 2012 15:50:43 +0000 (15:50 +0000)]
Handle negative number in Math.floor,ia32,non-SSE4.1 code path.
Zheng Liu
zheng.z.liu@intel.com
Review URL: https://chromiumcodereview.appspot.com/
10168001
Patch from Zheng Liu <zheng.z.liu@intel.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11517
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 4 May 2012 13:20:41 +0000 (13:20 +0000)]
Intercept a crash, put debug information onto the stack and then abort gracefully.
BUG=125128
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10375009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11516
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Fri, 4 May 2012 09:36:46 +0000 (09:36 +0000)]
Use correct size of promoted space for setting promotion and allocation limits.
Review URL: https://chromiumcodereview.appspot.com/
10376008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11513
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 4 May 2012 09:16:38 +0000 (09:16 +0000)]
Implement ClearFunctionTypeFeedback for test cases.
R=danno@chromium.org
TEST=mjsunit/compiler/inline-construct
Review URL: https://chromiumcodereview.appspot.com/
10332010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11509
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 4 May 2012 09:07:22 +0000 (09:07 +0000)]
MIPS: ARM: Ensure reload of elements pointer in StoreFastDoubleElement stub
Port r11483 (
c291e80e)
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10348016
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11507
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 4 May 2012 08:34:59 +0000 (08:34 +0000)]
MIPS: Fix register clobbering in LoadIC for interceptors.
Port r11492 (
d14ada19)
Original commit message:
Fix register clobbering in LoadIC for interceptors.
This fixes a corner-case where the receiver register was clobbered by
LoadICs for interceptors and inlined followup code still relied on the
receiver to be intact in case of prototype changes.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10315016
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11506
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 4 May 2012 07:53:11 +0000 (07:53 +0000)]
MIPS: Implement clearing of CompareICs.
Port r11491 (
705d40cc)
Original commit message:
Implement clearing of CompareICs.
This allows CompareICs to be cleared during garbage collection to avoid
cross-context garbage retention through maps stored in CompareIC stubs
for the KNOWN_OBJECTS state.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10342024
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11505
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 3 May 2012 22:19:12 +0000 (22:19 +0000)]
Fix warning on Win64
Review URL: https://chromiumcodereview.appspot.com/
10372003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11504
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 3 May 2012 18:53:40 +0000 (18:53 +0000)]
Fix mjsunit.status for new liveedit test
Review URL: https://chromiumcodereview.appspot.com/
10353016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11503
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 3 May 2012 17:31:34 +0000 (17:31 +0000)]
Fix issue 825 (LiveEdit vs. function with no locals) in core and for ia32.
Review URL: https://chromiumcodereview.appspot.com/
10263002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11502
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 3 May 2012 15:13:04 +0000 (15:13 +0000)]
MIPS: Reduce size of LIR instruction by one word and remove dead code.
Port r11454 (
72c662fc)
Original commit message:
Reduce size of LIR instruction by one word and remove dead code.
Until now we always recorded two deoptimization environments for instructions
that are marked as calls. We actually don't need two for all LIR
instructions except one (LInstanceOfKnownGlobal) where there is a lazy
deoptimization point in deferred code.
This change remove on of them and uses one virtual function instead
to make LInstanceOfKnownGlobal work as before.
Additionally, this change removes an unused predicate save_doubles_ from LIR
instructions and removes some helper functions that are used only in one place.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10233019
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11501
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 3 May 2012 14:31:20 +0000 (14:31 +0000)]
Bumped bootup memory limit on 32bit platforms using snapshot.
Somehow the mmaps we do look the same, but the info in the proc FS tells us that
we use a bit more memory. I am not sure if this is a real issue or not, but this
CL should at least get the build bots green again...
TBR=erik.corry@gmail.com
TEST=cctest/test-mark-compact/BootUpMemoryUse
Review URL: https://chromiumcodereview.appspot.com/
10342016
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11500
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 3 May 2012 14:09:26 +0000 (14:09 +0000)]
Fix assert in function sorter.
Review URL: https://chromiumcodereview.appspot.com/
10364002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11497
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 3 May 2012 12:41:40 +0000 (12:41 +0000)]
Use map transitions when defining accessor properties.
AccessorPairs can now contain map transitions, which is similar to our current
handling of CONSTANT_FUNCTION/CONSTANT_TRANSITION, but generalized to a pair for
holding info about the getter and the setter. This way we can achieve map
sharing for objects with accessor properties, which is a prerequisite for making
them fast via inlining. We fall back to the previous way of handling accessor
properties when sharing is not possible or we don't handle a special case.
Note: When an exisiting accessor property is redefined we could in principle
move the AccessorPair out of the descriptor into the object itself (again just
like the way we do something similar for CONSTANT_FUNCTION/CONSTANT_TRANSITION),
but this would require a new property kind for holding a pair of values. Perhaps
we can implement this later, but for now this hopefully rare case is handled
like before, losing map sharing and potentially creating more maps than strictly
necessary.
Review URL: https://chromiumcodereview.appspot.com/
10238005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11496
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 3 May 2012 11:52:56 +0000 (11:52 +0000)]
Modify two regression tests to actually fail when failing.
BUG=
TEST=regress-1639, regress-1639-2
Review URL: https://chromiumcodereview.appspot.com/
10315009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11493
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 3 May 2012 11:28:24 +0000 (11:28 +0000)]
Fix register clobbering in LoadIC for interceptors.
This fixes a corner-case where the receiver register was clobbered by
LoadICs for interceptors and inlined followup code still relied on the
receiver to be intact in case of prototype changes.
R=vegorov@chromium.org
BUG=chromium:125988
TEST=cctest/test-api/Regress125988
Review URL: https://chromiumcodereview.appspot.com/
10358010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11492
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 3 May 2012 10:54:17 +0000 (10:54 +0000)]
Implement clearing of CompareICs.
This allows CompareICs to be cleared during garbage collection to avoid
cross-context garbage retention through maps stored in CompareIC stubs
for the KNOWN_OBJECTS state.
R=vegorov@chromium.org
BUG=v8:2102
Review URL: https://chromiumcodereview.appspot.com/
10263008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11491
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 3 May 2012 09:02:57 +0000 (09:02 +0000)]
Prepare push to trunk. Now working on version 3.11.0.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10354006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11488
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 3 May 2012 08:22:12 +0000 (08:22 +0000)]
Fix assert triggered in fast/regex/pcre-test-4.html We were not filtering out
all the nodes that had non-ASCII characters. That has been fixed, but because
of the protection against over-deep recursion when filtering it is wrong to
assert that all nodes were filtered. This change therefore also makes sure we
can cope with non-filtered nodes by adding back some code removed in
https://chromiumcodereview.appspot.com/
10174017/
Review URL: https://chromiumcodereview.appspot.com/
10358008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11487
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Thu, 3 May 2012 08:11:38 +0000 (08:11 +0000)]
Clean up Makefile, enable MIPS cross-compilation
Review URL: https://chromiumcodereview.appspot.com/
10268010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11486
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 3 May 2012 07:09:17 +0000 (07:09 +0000)]
ARM: Ensure reload of elements pointer in StoreFastDoubleElement stub
R=mstarzinger@chromium.org
TEST=test/mjsunit/regress/regress-125515.js
BUG=chromium:125515
Review URL: https://chromiumcodereview.appspot.com/
10298010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11483
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 2 May 2012 13:07:31 +0000 (13:07 +0000)]
Sort functions when doing megamorphic dispatch/inlining so their
order does not depend on the hash seed.
Review URL: https://chromiumcodereview.appspot.com/
10270032
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11482
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 2 May 2012 12:58:40 +0000 (12:58 +0000)]
Enable code flushing even when objects were marked incrementally,
since the incremental visitor is setting the gc_age fields correctly.
This means the ResetSharedFunctionInfoCountersDuringIncrementalMarking
test passes even if it hits a marking stack overflow.
Review URL: https://chromiumcodereview.appspot.com/
10258001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11481
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 2 May 2012 12:13:39 +0000 (12:13 +0000)]
Small patch to save one jump instruction and one label bind in JSEntryStub.
BUG=v8:2105
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10249003
Patch from Zhongping Wang <kewpie.w.zp@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11480
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 2 May 2012 09:58:42 +0000 (09:58 +0000)]
Ensure reload of elements pointer in StoreFastDoubleElement stub.
R=mstarzinger@chromium.org
TEST=test/mjsunit/regress/regress-125515.js
BUG=chromium:125515
Review URL: https://chromiumcodereview.appspot.com/
10260014
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11479
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 2 May 2012 07:51:03 +0000 (07:51 +0000)]
MIPS: Fix LFastLiteral to check boilerplate elements kind.
Port r11470 (
621f96c0)
Original commit message:
Fix LFastLiteral to check boilerplate elements kind.
Adds a missing check that the elements kind of the boilerplate object
still has the expected elements kind, unoptimized code can transition
the boilerplate. Corner cases might cause the optimized code to be
reentered again.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10271018
Patch from Akos Palfi <palfia@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11474
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 30 Apr 2012 17:06:13 +0000 (17:06 +0000)]
Fix mistakes in r11472
TBR=vegorov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10274008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11473
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 30 Apr 2012 15:17:59 +0000 (15:17 +0000)]
Fixed corner cases in truncation behavior when storing to TypedArrays.
Also simplified ia32 KeyedStoreStubCompiler::GenerateStoreExternalArray a bit.
BUG=v8:2110
TEST=mjsunit/regress/regress-2110
Review URL: https://chromiumcodereview.appspot.com/
10260011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11472
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
vegorov@chromium.org [Mon, 30 Apr 2012 15:02:43 +0000 (15:02 +0000)]
Don't ignore return value of CommitCodePage in AllocateAlignedMemory.
Release the mapping as whole if commit failed to avoid leaking virtual address space.
R=mstarzinger@chromium.org
BUG=chromium:118625
Review URL: https://chromiumcodereview.appspot.com/
10260012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11471
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 30 Apr 2012 14:59:13 +0000 (14:59 +0000)]
Fix LFastLiteral to check boilerplate elements kind.
Adds a missing check that the elements kind of the boilerplate object
still has the expected elements kind, unoptimized code can transition
the boilerplate. Corner cases might cause the optimized code to be
reentered again.
R=danno@chromium.org
TEST=mjsunit/regress/regress-fast-literal-transition
Review URL: https://chromiumcodereview.appspot.com/
10254006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11470
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Mon, 30 Apr 2012 14:41:12 +0000 (14:41 +0000)]
Make sure idle notifications perform a round of incremental GCs after context disposal.
BUG=v8:2107
Review URL: https://chromiumcodereview.appspot.com/
10209026
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11469
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Mon, 30 Apr 2012 13:04:08 +0000 (13:04 +0000)]
Fixed preparser for try statement. Tiny cleanup.
BUG=v8:2109
TBR=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10270007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11468
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Mon, 30 Apr 2012 12:32:11 +0000 (12:32 +0000)]
Prepare push to trunk. Now working on version 3.10.8.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10268006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11465
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Mon, 30 Apr 2012 11:54:34 +0000 (11:54 +0000)]
Revert r11425 because of V8 benchmark performance regression.
Original CL: https://chromiumcodereview.appspot.com/
10202007 "Re-enable optimization for hot functions that have optimization disabled due to many deopts."
Review URL: https://chromiumcodereview.appspot.com/
10265008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11464
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 30 Apr 2012 08:53:48 +0000 (08:53 +0000)]
One more register change missing from r11460.
Also re-enable disabled test (reverts r11461).
BUG=v8:2108
TEST=mozilla tests pass
Review URL: https://chromiumcodereview.appspot.com/
10178039
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11463
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 27 Apr 2012 17:29:22 +0000 (17:29 +0000)]
Temporarily disable crashing mozilla test
BUG=2108
Review URL: https://chromiumcodereview.appspot.com/
10252008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11461
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 27 Apr 2012 13:05:45 +0000 (13:05 +0000)]
ia32: Redefine register usage in LoadIC/KeyedLoadIC to match StoreIC and KeyedStoreIC
Review URL: https://chromiumcodereview.appspot.com/
10254005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11460
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 27 Apr 2012 12:57:01 +0000 (12:57 +0000)]
MIPS: Removed unused variables.
These were found by compilation errors with gcc 4.6.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10253004
Patch from Daniel Kalmar <kalmard@homejinni.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11459
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Thu, 26 Apr 2012 20:16:53 +0000 (20:16 +0000)]
Issue 2081: Expose function's (closure's) inner context in debugger.
This is against the correct branch (bleeding_edge).
Review URL: https://chromiumcodereview.appspot.com/
10171003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11458
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 26 Apr 2012 16:19:14 +0000 (16:19 +0000)]
Print compare-state with --print-code-stubs.
R=vegorov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10235006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11457
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 26 Apr 2012 14:45:58 +0000 (14:45 +0000)]
Fix spurious bugs in GrowAndShrinkNewSpace when the
min and max new space sizes are equal.
Review URL: https://chromiumcodereview.appspot.com/
10241002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11456
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 26 Apr 2012 13:44:18 +0000 (13:44 +0000)]
Remove more assumptions from debug tests. Even though a function
is optimized, does not mean all frames on the stack are optimized.
Also, when we ask for the list of scripts we may get more or less
depending on GC timing. Also fixed a presubmit error and made
%GetOptimizationStatus a little more honest.
Review URL: https://chromiumcodereview.appspot.com/
10234007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11455
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Thu, 26 Apr 2012 12:43:00 +0000 (12:43 +0000)]
Reduce size of LIR instruction by one word and remove dead code.
Until now we always recorded two deoptimization environments for instructions
that are marked as calls. We actually don't need two for all LIR
instructions except one (LInstanceOfKnownGlobal) where there is a lazy
deoptimization point in deferred code.
This change remove on of them and uses one virtual function instead
to make LInstanceOfKnownGlobal work as before.
Additionally, this change removes an unused predicate save_doubles_ from LIR
instructions and removes some helper functions that are used only in one place.
Review URL: https://chromiumcodereview.appspot.com/
10035021
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11454
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 26 Apr 2012 11:58:34 +0000 (11:58 +0000)]
Remove unwarranted assumptions about inlining from a debugger test.
Review URL: https://chromiumcodereview.appspot.com/
10239003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11449
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 26 Apr 2012 11:43:59 +0000 (11:43 +0000)]
Use simple concat of substrings instead of ReplaceStringBuilder for non-global replacements.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10134057
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11448
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Thu, 26 Apr 2012 11:14:24 +0000 (11:14 +0000)]
Add missing literal pool guards.
BUG=V8:2095
TEST=see issue
Review URL: https://chromiumcodereview.appspot.com/
10233006
Patch from Rodolph Perfetta <rodolph.perfetta@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11447
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 26 Apr 2012 09:11:45 +0000 (09:11 +0000)]
Reenable some heap verification and fix test to keep
heap in a consistent state.
Review URL: https://chromiumcodereview.appspot.com/
10227002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11446
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Thu, 26 Apr 2012 09:11:19 +0000 (09:11 +0000)]
Regexp: Remove nodes from the regexp that cannot match because
they contain non-ASCII characters and the input string is ASCII.
Remove unused Clone() method.
Review URL: https://chromiumcodereview.appspot.com/
10174017
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11445
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Thu, 26 Apr 2012 09:07:39 +0000 (09:07 +0000)]
Reduce expense of TraceGVN when --trace-gvn is off
R=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10233004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11444
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 26 Apr 2012 08:19:17 +0000 (08:19 +0000)]
Prepare push to trunk. Now working on version 3.10.7.
R=jkummerow@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10233003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11441
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 26 Apr 2012 07:45:29 +0000 (07:45 +0000)]
Remove unused variable in src/platform-solaris.cc.
Based on a patch contributed by Heinz Gies <heinz@licenser.net>
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10231004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11440
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Wed, 25 Apr 2012 23:06:30 +0000 (23:06 +0000)]
Add "step in recommended" to LiveEdit response object.
Review URL: https://chromiumcodereview.appspot.com/
10185006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11439
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 25 Apr 2012 15:41:57 +0000 (15:41 +0000)]
Fix 64-bit windows size_t assert
R=mstarzinger@chromium.org
TEST=Windows 64 bit build goes green
Review URL: https://chromiumcodereview.appspot.com/
10221006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11438
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mmassi@chromium.org [Wed, 25 Apr 2012 14:32:27 +0000 (14:32 +0000)]
Eliminate redundant array bound checks (checks already performed earlier in the DT).
As a special case, for checks on index expressions with the form (expr + constant) if a smaller constant is checked later in the DT also eliminate the check.
Finally, if a larger constant is checked later in the same BB do the more general check (larger constant) earlier instead of the less general one.
This will not cause useless deoptimizations because, since we are in the same BB, all the checks would have been executed anyway.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10032029
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11437
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 25 Apr 2012 13:22:04 +0000 (13:22 +0000)]
Fix deopted construct stub frame to contain code object.
R=danno@chromium.org
BUG=chromium:124594
TEST=mjsunit/regress/regress-124594
Review URL: https://chromiumcodereview.appspot.com/
10155024
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11436
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 25 Apr 2012 13:12:08 +0000 (13:12 +0000)]
Temporarily disable some heap verification while test failures are
investigated.
Review URL: https://chromiumcodereview.appspot.com/
10221004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11435
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 25 Apr 2012 13:12:00 +0000 (13:12 +0000)]
Use safe string utilities to fix Windows build error.
R=mstarzinger@chromium.org
TEST=waterfall goes green
Review URL: https://chromiumcodereview.appspot.com/
10173023
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11434
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Wed, 25 Apr 2012 12:04:23 +0000 (12:04 +0000)]
Improve --trace-gvn debug output
R=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10203010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11433
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 25 Apr 2012 11:49:31 +0000 (11:49 +0000)]
Fix release build. Add comment accidentally omitted from
preceeding change (stress-compaction).
Review URL: https://chromiumcodereview.appspot.com/
10161027
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11432
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Wed, 25 Apr 2012 11:35:32 +0000 (11:35 +0000)]
Make --stress-compaction more stressful.
Review URL: https://chromiumcodereview.appspot.com/
10141007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11431
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Wed, 25 Apr 2012 10:20:38 +0000 (10:20 +0000)]
Add field names to Code, ConsString, and JSGlobalPropertyCell in heap snapshot.
Review URL: https://chromiumcodereview.appspot.com/
10217001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11430
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 25 Apr 2012 08:45:45 +0000 (08:45 +0000)]
Make String::Empty inlineable.
R=svenpanne@chromium.org
TEST=cctest/test-api/StringEmpty
Review URL: https://chromiumcodereview.appspot.com/
10199019
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11429
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Tue, 24 Apr 2012 16:37:43 +0000 (16:37 +0000)]
Attempt to fix Win32 build by avoiding a compiler intrinsic.
TBR=mstarzinger@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10198020
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11428
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Tue, 24 Apr 2012 15:59:07 +0000 (15:59 +0000)]
Optimise Math.floor(x/y) to use integer division for specific divisor.
Landing for Rodolph Perfetta <rodolph.perfetta@gmail.com>.
Original CL: http://codereview.chromium.org/9638018/
Review URL: https://chromiumcodereview.appspot.com/
10197010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11427
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 24 Apr 2012 14:37:53 +0000 (14:37 +0000)]
Make Isolate::GetData and Isolate::SetData inlineable.
R=svenpanne@chromium.org
TEST=cctest/test-api/IsolateEmbedderData
Review URL: https://chromiumcodereview.appspot.com/
10196013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11426
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Tue, 24 Apr 2012 14:05:07 +0000 (14:05 +0000)]
Re-enable optimization for hot functions that have optimization disabled due to many deopts.
Use exponential backoff in order to avoid getting into optimization-deoptimization cycle.
BUG=v8:2040,121196
Review URL: https://chromiumcodereview.appspot.com/
10202007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11425
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Tue, 24 Apr 2012 12:38:58 +0000 (12:38 +0000)]
Refactoring of heap profiler: split ExtractReferences into several functions.
Review URL: https://chromiumcodereview.appspot.com/
10198011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11424
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Tue, 24 Apr 2012 09:34:13 +0000 (09:34 +0000)]
Remove some unused stuff from regexp implementation.
Review URL: https://chromiumcodereview.appspot.com/
10205010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11423
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erik.corry@gmail.com [Mon, 23 Apr 2012 18:56:07 +0000 (18:56 +0000)]
Fix some bugs in accessing details of the lastest regexp
match. Sometimes were were not updating it when we should
and sometimes we were leaving the lastMatchInfoOverride in
place when we should be using the updated regular last match
info. Small optimization for zero length match in
String.prototype.replace.
Review URL: https://chromiumcodereview.appspot.com/
10184004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11422
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Mon, 23 Apr 2012 18:12:36 +0000 (18:12 +0000)]
Revert r11420 because Win32 compilation was broken.
TBR=danno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10190007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11421
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
fschneider@chromium.org [Mon, 23 Apr 2012 17:44:21 +0000 (17:44 +0000)]
optimise Math.floor(x/y) to use integer divisiion for specific divisor.
BUG=none
TEST=mjsunit/math-floor-of-div.js
Landing for Rodolph Perfetta <rodolph.perfetta@gmail.com>.
Review URL: https://chromiumcodereview.appspot.com/9638018
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11420
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 23 Apr 2012 16:42:34 +0000 (16:42 +0000)]
Fix compile failure on Mac in r11417.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10187003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11419
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Mon, 23 Apr 2012 16:10:35 +0000 (16:10 +0000)]
Show names of the context fields in heap snapshot.
Review URL: https://chromiumcodereview.appspot.com/
10183005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11418
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 23 Apr 2012 15:09:59 +0000 (15:09 +0000)]
Make static API getters inlineable again.
This relands r11376 with minor fixes for Windows where offsets are
slightly different from Linux for unaligned fields.
R=svenpanne@chromium.org
TEST=cctest/test-api/StaticGetters
Review URL: https://chromiumcodereview.appspot.com/
10176004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11417
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 23 Apr 2012 13:59:43 +0000 (13:59 +0000)]
Fix source property of empty RegExp objects.
R=rossberg@chromium.org
BUG=v8:1982
TEST=test262/15.10.4.1-5
Review URL: https://chromiumcodereview.appspot.com/
10134010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11416
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
erikcorry [Mon, 23 Apr 2012 13:44:06 +0000 (13:44 +0000)]
Remove unused IsNan function
Review URL: http://codereview.chromium.org/
10167008
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11415
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 23 Apr 2012 12:54:47 +0000 (12:54 +0000)]
Prepare push to trunk. Now working on version 3.10.6.
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
10187001
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11412
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Mon, 23 Apr 2012 10:12:29 +0000 (10:12 +0000)]
Exclude filler maps from object properties in heap snapshot.
Review URL: https://chromiumcodereview.appspot.com/
10167013
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11411
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
alexeif@chromium.org [Mon, 23 Apr 2012 10:08:07 +0000 (10:08 +0000)]
Add names to GlobalObject inline properties in heap snapshot.
Review URL: https://chromiumcodereview.appspot.com/
10166007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11410
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
peter.rybin@gmail.com [Fri, 20 Apr 2012 17:08:01 +0000 (17:08 +0000)]
Issue 2089 Expose value wrapper's inner values
Review URL: https://chromiumcodereview.appspot.com/
10162006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11407
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 20 Apr 2012 15:20:52 +0000 (15:20 +0000)]
Disabling stepping into callback function of String.replace.
This is being done due to performance concerns.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/
10134006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11406
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00