E.Z. Hart [Wed, 12 Oct 2016 10:46:18 +0000 (04:46 -0600)]
Fix MasterDetailPage/NavigationPage leaks on iPad (#426)
* Remove Master page property changed handler to eliminate leak
* Fix memory leaks with MasterDetailPage and NavigationPage on iOS
Stephane Delcroix [Wed, 12 Oct 2016 07:11:29 +0000 (09:11 +0200)]
[XamlG] Fully qualify method names (#417)
Samantha Houts [Tue, 11 Oct 2016 23:19:48 +0000 (16:19 -0700)]
Update docs
adrianknight89 [Tue, 11 Oct 2016 21:39:18 +0000 (16:39 -0500)]
[iOS] Tapping on ListView with two fingers should not crash (#379)
* Tapping on ListView with two fingers should not crash
* Revert "Tapping on ListView with two fingers should not crash"
This reverts commit
0b0752f3cfdbb1c29678d75bd18c5a00e564d77b.
* code without refactoring
* moving up selector check
Samantha Houts [Tue, 11 Oct 2016 21:36:42 +0000 (14:36 -0700)]
Add reproduction for 41153 (#428)
adrianknight89 [Tue, 11 Oct 2016 21:29:41 +0000 (16:29 -0500)]
Clear cached CultureInfo and TimeZoneInfo on app resume (#423)
Philippe Leybaert [Tue, 11 Oct 2016 19:15:44 +0000 (14:15 -0500)]
OnIdiom support for Desktop (UWP) (#420)
The current implementation for OnIdiom<T> is missing the Desktop property. When running in a Windows UWP "desktop" app, it always returns the Phone property.
Jimmy Garrido [Tue, 11 Oct 2016 18:59:41 +0000 (11:59 -0700)]
[Windows] Fix crash when toggling IsPassword on multiple Entry controls (#405)
* [Windows] Fix crash when toggling IsPassword on multiple Entry controls
adrianknight89 [Tue, 11 Oct 2016 18:57:15 +0000 (13:57 -0500)]
Full feature compatibility with WPF's Colors class (#393)
Added color definitions to match X11 color table.
Warning: the saturation of Pink was changed lightly
Stephane Delcroix [Tue, 11 Oct 2016 18:34:18 +0000 (20:34 +0200)]
Merge branch 'adrianknight89-ios-scrolltoposition'
Paul DiPietro [Tue, 11 Oct 2016 16:56:20 +0000 (11:56 -0500)]
[WinRT] Fix MDP and TabbedPage Appearing/Disappearing (#387)
E.Z. Hart [Tue, 11 Oct 2016 14:52:23 +0000 (08:52 -0600)]
Temporarily disabling 39489 UITest on iOS (#445)
Rui Marinho [Mon, 10 Oct 2016 16:12:54 +0000 (17:12 +0100)]
[Nuspec] Include MacOS (#436)
Rui Marinho [Mon, 10 Oct 2016 11:46:19 +0000 (12:46 +0100)]
[Core] Set IVT to MacOS
Rui Marinho [Thu, 6 Oct 2016 19:32:41 +0000 (20:32 +0100)]
[UITest] Update to UItest beta 5, fix class naming (#413)
* [UITest] Update to UItest beta 5, fix class naming
* [UITest] Fix reference to alpha package
* [UITests] Update UITest
Samantha Houts [Thu, 6 Oct 2016 17:17:51 +0000 (10:17 -0700)]
[A] Prevent blank page from appearing when MainPage is switched (#421)
* repro
* [A]Add horrible hack to prevent background flashing when swapping MainPage
* cleanup repro
* Revert "[A]Add horrible hack to prevent background flashing when swapping MainPage"
This reverts commit
d0fdc3856d0eaa5ec781f790d524ad7624a26560.
* [A] E.Z.'s less magical but just as effective solution
E.Z. Hart [Tue, 4 Oct 2016 18:54:41 +0000 (12:54 -0600)]
Update ToolbarVisibility to TitleVisibility in PhoneResources (#416)
E.Z. Hart [Tue, 4 Oct 2016 17:47:02 +0000 (11:47 -0600)]
Unhook drawer listeners so MDP renderer and pages can be collected (#412)
Null out page in custom MDP renderer in Control Gallery so it can be collected
Checkpoint
Checkpoint
Checkpoint
Checkpoint
Checkpoint
Checkpoint
Samantha Houts [Tue, 4 Oct 2016 16:43:44 +0000 (09:43 -0700)]
[A] PanGestureRecognizer will consistently send Started/Move event (#389)
* Add reproduction for Bugzilla 39768
* [A] Handle onTouchEvent MOVE
adrianknight89 [Tue, 4 Oct 2016 16:31:15 +0000 (11:31 -0500)]
Fixed bug 43993 by removing call to base ViewWillAppear (#333)
* Fixed bug 43993 by removing call to base ViewWillAppear
* Removed commented code and reduced nesting
Stephane Delcroix [Tue, 4 Oct 2016 07:34:35 +0000 (09:34 +0200)]
Merge branch 'ios-scrolltoposition' of https://github.com/adrianknight89/Xamarin.Forms into adrianknight89-ios-scrolltoposition
Rui Marinho [Mon, 3 Oct 2016 23:45:57 +0000 (00:45 +0100)]
Fix tests on IOS10 [Do not merge] (#373)
* [UITests] Update packages
* [UITests] Fix formatting
* [UITests] Fix tests
* Add badges
* Update Android csproj
* fix
adrianknight89 [Mon, 3 Oct 2016 11:09:28 +0000 (06:09 -0500)]
Tab children should be cast to Page (#398)
Jason Smith [Mon, 3 Oct 2016 11:05:09 +0000 (04:05 -0700)]
Make CreateNativeControl virtual instead of abstract (#406)
Fixes backwards compatibility issue.
E.Z. Hart [Mon, 3 Oct 2016 09:16:48 +0000 (03:16 -0600)]
Set UserVisibleHint for new fragment to true (#411)
E.Z. Hart [Fri, 30 Sep 2016 19:36:58 +0000 (13:36 -0600)]
Set AndroidCodeGenTarget to XAJavaInterop1 (#404)
Paul DiPietro [Fri, 30 Sep 2016 19:29:01 +0000 (14:29 -0500)]
[A] Check for ViewStates.Gone in AppCompat TabbedPageRenderer (#365)
Paul DiPietro [Fri, 30 Sep 2016 19:28:08 +0000 (14:28 -0500)]
[WinRT] Fix regression on ListView selection with enter key (#402)
adrianknight89 [Fri, 30 Sep 2016 19:22:02 +0000 (14:22 -0500)]
AppCompat should now be able to set title bar visibility programmatic… (#350)
* AppCompat should now be able to set title bar visibility programmatically
* coding style changes
* making sure page layout runs only on fullscreen flag changes
adrianknight89 [Fri, 30 Sep 2016 19:01:31 +0000 (14:01 -0500)]
[Android] InputTransparent and IsEnabled fixes on visual elements (#344)
* intercepting touch event when inputtransparent and isenabled are set. also made some refactoring.
* keeping tabs
Jason Smith [Fri, 30 Sep 2016 18:59:00 +0000 (11:59 -0700)]
Fix indentation
adrianknight89 [Fri, 30 Sep 2016 18:57:28 +0000 (13:57 -0500)]
[Android] Forward appearing / disappearing methods only for the last item on the stack (#342)
* [Android] Forward appearing / disappearing methods only for the last item on the stack
* use tabs
Rui Marinho [Fri, 30 Sep 2016 18:48:22 +0000 (19:48 +0100)]
[iOS] Keep our native property listener around the same time we keep our proxy, check if we are KVO compliant before adding observer (#403)
Neil McAlister [Fri, 30 Sep 2016 18:47:41 +0000 (21:47 +0300)]
[Windows] Fix Device Style inheritance (#324)
* Make Device Styles get Style Setters from ancestor styles
* Fix parentheses to match style
Paul DiPietro [Tue, 27 Sep 2016 22:15:53 +0000 (17:15 -0500)]
Add .bak extension to .gitignore (#388)
Samantha Houts [Tue, 27 Sep 2016 18:12:49 +0000 (11:12 -0700)]
[Win] Will arrange native children of custom renderers (opt-in) (#322)
* Add repro for 42602
* [Win] Add option to arrange native children
* [Win] Don't allocate arrangedChildren unless required
Stephane Delcroix [Tue, 27 Sep 2016 18:10:39 +0000 (20:10 +0200)]
[Xaml] more primitive types (#385)
* [Xaml] more builtin conversion, and more type primitives
* [XamlC] more builtin conversion, more type primitives
E.Z. Hart [Tue, 27 Sep 2016 18:05:41 +0000 (12:05 -0600)]
Reuse Handler when invoking on main thread (#383)
E.Z. Hart [Tue, 27 Sep 2016 18:02:12 +0000 (12:02 -0600)]
Don't unsubscribe/resubscribe the listener to the same INPC (#384)
E.Z. Hart [Tue, 27 Sep 2016 13:50:02 +0000 (07:50 -0600)]
Fix potential NRE accessing current application via Page.RealParent (#330)
* Fix potential NRE accessing current application via Page.RealParent
* Update Native Bindings Gallery to use MessagingCenter
Samantha Houts [Tue, 27 Sep 2016 13:43:17 +0000 (06:43 -0700)]
[UWP/WinRT] ListView UI virtualization works without explicit height on Cell/Row (#367)
* Add repro for 41271
* [UWP/WinRT] ListView virtualization works without explicit height on Cell/Row
* Adjust repro to clear ItemsSource OnDisappearing.
* Update docs
E.Z. Hart [Tue, 27 Sep 2016 10:51:22 +0000 (04:51 -0600)]
Clean up listeners and tag on ButtonRenderer during disposal (#360)
Clean up OnFocusChangeListener on ViewRenderer during disposal
Prevent memory leak of PageContainer/FragmentContainer when animating fragment transitions
Call Destroy() on Map during disposal
Rebasing
Stephane Delcroix [Mon, 26 Sep 2016 20:40:04 +0000 (22:40 +0200)]
[Xaml] allow compatible arguments for x:Factory (#382)
Stephane Delcroix [Mon, 26 Sep 2016 20:32:19 +0000 (22:32 +0200)]
[C] specify type and default value for native bindings (#376)
Stephane Delcroix [Mon, 26 Sep 2016 20:29:47 +0000 (22:29 +0200)]
[XamlC] Compiled converters (#358)
Stephane Delcroix [Fri, 23 Sep 2016 15:25:46 +0000 (17:25 +0200)]
do not compile winrt stuffs on mac
Stephane Delcroix [Fri, 23 Sep 2016 14:24:49 +0000 (16:24 +0200)]
fix docs
Stephane Delcroix [Fri, 23 Sep 2016 14:00:49 +0000 (16:00 +0200)]
[Xaml] fix build
Rui Marinho [Fri, 23 Sep 2016 13:47:48 +0000 (14:47 +0100)]
[Controls] Link only SDK so we don't brake the sample (#372)
Adrian Knight [Fri, 23 Sep 2016 10:05:08 +0000 (05:05 -0500)]
using internal Clamp method
Stephane Delcroix [Fri, 23 Sep 2016 07:02:50 +0000 (09:02 +0200)]
[Xaml] Xaml native views and bindings for WP8.1 (#363)
Stephane Delcroix [Fri, 23 Sep 2016 07:01:22 +0000 (09:01 +0200)]
[XamlC] Implement IValueProvider.PropertyType (#345)
Stephane Delcroix [Fri, 23 Sep 2016 06:56:29 +0000 (08:56 +0200)]
[XamlC] supports enum and consts in x:Static (#369)
Adrian Knight [Fri, 23 Sep 2016 05:32:32 +0000 (00:32 -0500)]
iOS ScrollView should not scroll out of place on scrolling to element
E.Z. Hart [Wed, 21 Sep 2016 22:04:36 +0000 (16:04 -0600)]
Implement dispose pattern correctly to support derived classes (#364)
Rui Marinho [Sun, 18 Sep 2016 18:24:44 +0000 (19:24 +0100)]
[Controls] Update Insights and UITest packages and fix warnings (#361)
* [Controls] Update Insights and UITest packages
* Update Xamarin.Forms.Platform.Android (Forwarders).csproj
Atsushi Eno [Fri, 16 Sep 2016 21:05:29 +0000 (06:05 +0900)]
Android BeginInvokeOnMainThread() should not possibly block. (#343)
Android.App.Activity.RunOnUiThread() does not always run the argument
Runnable asynchronously; actually it is run synchronously if current
thread is the UI thread [*1][*2]
Use Handler.Post() instead. (It is also used in Android.App.SyncContext[*3])
[*1] https://developer.android.com/reference/android/app/Activity.html#runOnUiThread(java.lang.Runnable)
[*2] http://stackoverflow.com/questions/
33039600/android-runonuithread-not-async
[*3] https://github.com/xamarin/xamarin-android/blob/5777337/src/Mono.Android/Android.App/SyncContext.cs#L15
E.Z. Hart [Fri, 16 Sep 2016 18:55:38 +0000 (12:55 -0600)]
Format MapRenderer according to project code style (#362)
* Format MapRenderer according to project code style
* Using var instead of explicit type for Markers
Rui Marinho [Thu, 15 Sep 2016 17:33:39 +0000 (18:33 +0100)]
[Android] Fix failing UITests (#356)
Stephane Delcroix [Thu, 15 Sep 2016 12:45:50 +0000 (14:45 +0200)]
do not disable warning (#357)
Rui Marinho [Wed, 14 Sep 2016 21:56:17 +0000 (22:56 +0100)]
Remove iOS classic from CI system (#353)
* [CI] Remove classic from build
* [Build] Remove classic forwarder
* [Nuget] Remove classic from Pages azure
* [Build] Remove classic csproj
* [IOS] Remove _UNIFIED_
Rui Marinho [Tue, 13 Sep 2016 21:52:47 +0000 (22:52 +0100)]
Revert "Revert "[Android] Fix warnings (#346)""
This reverts commit
6fa569cfda33d6875896788bba274a313a24fac2.
Jason Smith [Tue, 13 Sep 2016 16:57:19 +0000 (09:57 -0700)]
Update docs
Rui Marinho [Tue, 13 Sep 2016 12:18:03 +0000 (13:18 +0100)]
Revert "[Android] Fix warnings (#346)"
This reverts commit
960f02d0e7549088d15b74bd11628eb987c77a74.
Rui Marinho [Tue, 13 Sep 2016 11:51:57 +0000 (12:51 +0100)]
[Android] Fix warnings (#346)
Samantha Houts [Tue, 13 Sep 2016 11:39:36 +0000 (04:39 -0700)]
[iOS] ViewCells with Accessories will be properly laid out again (#338)
* Add repro for 43161
* [iOS] Don't adjust ViewCell Bounds when there is an Accessory
* [iOS] Fix spacing
Paul DiPietro [Tue, 13 Sep 2016 11:39:02 +0000 (06:39 -0500)]
[A] Fix regression on NavAnimationInProgress (#341)
Rui Marinho [Tue, 13 Sep 2016 11:38:16 +0000 (12:38 +0100)]
[iOS] - Revert setting the frame for ViewCell to try to hide the gap between cells when using a ContextActionCell (#351)
Rui Marinho [Tue, 13 Sep 2016 11:34:22 +0000 (12:34 +0100)]
Revert "[C] Prevent enabling a Button via setting a Command (#308)"
This reverts commit
368a375f13fc2e4b5ff00dbbdd7a2d6bb53988eb.
Jani Lirkki [Mon, 12 Sep 2016 11:53:44 +0000 (14:53 +0300)]
Android AppCompat: Don't do NavigationPage menu updates for disposed page (#331)
Mikhail [Mon, 12 Sep 2016 11:52:31 +0000 (14:52 +0300)]
After Label.FormattedText property changed need invoke UpdateText method (#335)
Paul DiPietro [Mon, 12 Sep 2016 11:51:19 +0000 (06:51 -0500)]
[C] Prevent enabling a Button via setting a Command (#308)
Paul DiPietro [Thu, 8 Sep 2016 22:00:57 +0000 (17:00 -0500)]
[iOS] Adjust Started/Ended hooks in pickers for iOS 10 (#339)
Stephane Delcroix [Thu, 8 Sep 2016 19:01:09 +0000 (21:01 +0200)]
[XamlC] throw exception on missing property (#336)
* Added unit test for 43450
* fix test
* [XamlC] instrument the compiler so we can test it
* [XamlC] throw on missing property
Stephane Delcroix [Thu, 8 Sep 2016 18:51:01 +0000 (20:51 +0200)]
[XamlC] replace the runtime type check by compiletime (#334)
Stephane Delcroix [Thu, 8 Sep 2016 18:45:43 +0000 (20:45 +0200)]
[Xaml] support native views and native bindings (#266)
Allows including Native views directly in xaml.
Support for ios, android, UWP
Stephane Delcroix [Thu, 8 Sep 2016 18:39:05 +0000 (20:39 +0200)]
Native Bindings (#278)
* [C, I, A, W] Support Native Bindings
* fix tabs
E.Z. Hart [Wed, 31 Aug 2016 19:57:35 +0000 (13:57 -0600)]
Fix incorrect background property name on Win 8.1 phone and tablet styles (#329)
Jason Smith [Wed, 31 Aug 2016 05:01:42 +0000 (22:01 -0700)]
Fix docs
Paul DiPietro [Tue, 30 Aug 2016 18:47:09 +0000 (13:47 -0500)]
[Win] Fix FontAttributes unexpectedly changing a label's size (#325)
Paul DiPietro [Tue, 30 Aug 2016 18:34:37 +0000 (13:34 -0500)]
[A] Check UserVisibleHint to prevent non-active tabs from firing SendAppearing in OnResume (#328)
adrianknight89 [Tue, 30 Aug 2016 18:31:41 +0000 (13:31 -0500)]
KeyboardExtensions is now public (#326)
Samantha Houts [Tue, 30 Aug 2016 18:14:13 +0000 (11:14 -0700)]
[A] PanGestureRecognizer will consistently send Completed event (#313)
* Adjust gallery page for reproduction
* [A] Forward OnTouchEvent to Listener...
...and end scrolling on Up.
E.Z. Hart [Tue, 30 Aug 2016 18:12:27 +0000 (12:12 -0600)]
Use character truncation in Windows (#321)
Change layout order ViewCells on Windows to correct label length layout issues
Add extra layout pass on ViewCell load to make cells without margins visible
Jonathan Peppers [Tue, 30 Aug 2016 17:59:32 +0000 (12:59 -0500)]
Fix for ListView BindingContext for Header/Footer (#312)
* ListView - unit test showing BindingContext issue
Apparently the BC doesn't pass to Header and Footer
* ListView - support for passing BC to header and footer
* ListView - test checking BindingContext is set
Checking that it works to set the BindingContext first and the
Header/Footer after
E.Z. Hart [Tue, 30 Aug 2016 17:57:55 +0000 (11:57 -0600)]
Fix memory leak caused by BaseCellView and RendererHolder (#311)
Kangho [Tue, 30 Aug 2016 17:55:00 +0000 (02:55 +0900)]
Update Makefile to support linux env (#309)
Samantha Houts [Tue, 30 Aug 2016 17:46:14 +0000 (10:46 -0700)]
Platform Specifics (#301)
* Playing around with how the platform specifics interfaces etc. might work
* Sample implementation of iOS navigation translucency
* Very slightly reduced code
* Better vendor stuff
* Drop single-implemenation interfaces
* Generics on NavigationPage
* On-demand vendor stuff
* Remove functionally duplicate classes and make ControlGallery work again
* Namespace all the things. XAML test.
* Can use Effect to attach platform specific
* Attach Effect on PropertyChanging for XAML support!
* Rename IConfigPlatform interfaces for readability
* Some renaming to match the documents
* Split class files
* Clear out test-only code
* Re-namespace
* Added On method to rendered Elements
* Allow for removal of platform suffix, convenience methods on specific platforms
* Creating a gallery page for specifics
* Add rudimentary Platform Specifics gallery; make CollapseStyle work on UWP;
Add CollapsedPaneWidth specific property
* Toolbar now working with both collapse styles
* MDP now displaying Content title; toolbar routing around title
* Add a gallery for the iOS NavigationPage stuff
* Add Navigation Page as detail page to verify it works with new Toolbar options
* Make titlebar/toolbar background colors consistent
* ToolbarPlacement now working on NavigationPage
* Toolbar Placement working for tabbed and nav pages
* Fix bug where phone doesn't get default toolbar placement on start
* [Core] Add PS WindowSoftInputModeAdjust
[Core] Make Application extendable
* Toolbar placement now working on Nav, Tabbed, and Master pages on desktop/phone
Remove unnecessary style indirection
Fix build errors
* [A] Add PlatformConfigurationExtensions
* SetSoftInputMode test page
* [A] SetSoftInputMode
Known issue: Status bar color does not work in AdjustResize mode
* [Core] Add PS Blur
* [iOS] Configure renderer for blur
* Add test page
* Move to blur VisualElement for broader support
* Move test pages to gallery
* Update docs
* Use lazy initializer for PlatformConfigurationRegistry
Jimmy Garrido [Tue, 30 Aug 2016 17:45:05 +0000 (10:45 -0700)]
Throw InvalidOperationException if AppLinkEntry.Thumbnail source is invalid (#299)
Marcus Lum [Tue, 30 Aug 2016 17:37:07 +0000 (13:37 -0400)]
Allow Custom Android MapRenderers to override the default MapView options (#285)
* Allow Custom Android MapRenderers to override the default MapView options
* Larger effort to use CreateNativeControl () everywhere instead of just in the Android AppCompat renderers.
Jimmy Garrido [Thu, 25 Aug 2016 18:05:18 +0000 (11:05 -0700)]
Fix crash when ItemsSource is set to null (#320)
Mike Norman [Thu, 25 Aug 2016 16:11:01 +0000 (11:11 -0500)]
Fixed SinInOut description. (#319)
Paul DiPietro [Thu, 25 Aug 2016 00:55:15 +0000 (19:55 -0500)]
Fix regression by adding null check in Windows ListView selection (#314)
Oddbjørn Bakke [Wed, 17 Aug 2016 09:26:27 +0000 (11:26 +0200)]
[Android] Fix for NullReferenceException when using the wrong activit… (#286)
* [Android] Fix for NullReferenceException when using the wrong activity type.
On using FormsApplicationActivity or FormsAppCompatActivity as base Activity in a SplashScreen.
A NullReferenceException will be thrown in the KeyboardManager.
Added InvalidOperationException with "Forms.Init()" message instead, if the Forms.Context is null.
* Fixed indentation
Paul DiPietro [Tue, 16 Aug 2016 19:13:12 +0000 (14:13 -0500)]
[WinRT] Remove preemptive setting of null upon action sheet closure (#305)
Stephane Delcroix [Tue, 16 Aug 2016 18:33:44 +0000 (20:33 +0200)]
[Xaml] Clone node tree on DT, allow markup to be evaluated multiple times (#295)
Paul DiPietro [Tue, 16 Aug 2016 18:33:11 +0000 (13:33 -0500)]
[Windows] Correct enter/esc keypress behaviors for MessageDialog (#292)
Rui Marinho [Tue, 16 Aug 2016 18:31:53 +0000 (19:31 +0100)]
[iOS] Change when we updated the XF INavigationPageController after popping a page natively, Cleanup UITest references (#291)
Jonathan Peppers [Tue, 16 Aug 2016 18:19:21 +0000 (13:19 -0500)]
Fix for BindingExpression memory leak (#279)
* Unit test proving a memory leak with Binding
What we were seeing in our app was that Binding objects stay around when
bound to long-lived ViewModels, even when the View is long gone
* BindingExpression - INotifyPropertyChanged should use WeakReference
I had to make a WeakPropertyChangedProxy class for this, I could not
think of a way to get around creating a new object for this
E.Z. Hart [Tue, 16 Aug 2016 18:10:32 +0000 (12:10 -0600)]
Fix Entry/SearchBar color issues (#306)
* Fix disappearing Entry text on UWP Anniversary Edition
Fix background color reversion bug in UWP Phone
Move SearchBar styling on UWP to its own file
Make foreground/background color changes on UWP SearchBar/Entry consistent
Fix SearchBar color toggle bug on WP8
* Temporarily moving SDK target to previous version
* Fix build error on OSX