Changed the property of /oic/ping resource

The resource property of /oic/ping is changed from DISCOVERABLE to
NONE.

Change-Id: Ibb1d8d80f859fdbb34a75a22b19bd66979fa6b13
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13439
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
(cherry picked from commit a23f545b5ed285d51e34f4faea939db847959e92)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13601

[IOT-1451] Keep client callback when receiving error result

when Client receive error code from some server after request
oic/res. clientCB is removed by return value "OC_STACK_DELETE_
TRANSACTION"

Change-Id: Ibf42740078f0ed6a97ee3b18d22559b0d2fbdf43
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13237
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: MyeongGi Jeong <myeong.jeong@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 2cfef2e49066614eaed9aed40806d9cebc0b5cb5)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13599

Fix for bug while building x86_64 architecture

Change-Id: I9c2538617a897c2b1c4e9129f55bf9623053308b
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13653
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix to get only single credential entry

Old function(GetCredResourceDataByCredId) return not only the indicated credential entry but also all linked entries.

Change-Id: I0466b4c25a21395f08664a11ecfa6fd51a94b258
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

coap: use upstream libcoap header if desired

Change-Id: I94540c72d320ebf87b996d5ddd614c898b8c157f
Origin: https://gerrit.iotivity.org/gerrit/#/c/13615/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13615
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>

Added null check logic for JniOnPublishResourceListener

Added null check logic for JniOnPublishResourceListener

Change-Id: I8967028583b951d2af049a46eb618ba0963db72f
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13399
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 86c3e7a2500b689a074d2099017cb96a5ea1f0e9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13603
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

fix jenkins build failure related setErrorCode

this issue causes by https://gerrit.iotivity.org/gerrit/#/c/13151/

Change-Id: I7eb1a208f65bd6a1f6a207de85363fd540bd2705
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13647
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1237] Client discovers all resources sending discovery request with "rt" query param.

Change-Id: I54904ef0789c5ee4655c20e4c8c82eb9b7d0ac0a
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11031
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

coap-http-proxy: Fix coap headers path

It failed to build on Tizen:2.3.1:Wearable

Change-Id: I1069ab17f11a946605093454b89205a6c208c902
Origin: https://gerrit.iotivity.org/gerrit/#/c/12061/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12061
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12487

Bug fixes.

1)Fixing logic related to conversion of MediaContents to consider NULL object.
2) Fixing bug in switch statement .

Change-Id: I615aca6e55d2bf39b7686331ec59d50f72deb5c4
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13629
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix enrollee sample application's crach issue

Before OCStop() is called, listen thread for calling OCProcess() should
be terminated.

Change-Id: Ibe4f702bb7c71beaf8bb58a8fe21acb873ad06d6
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13583
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
(cherry picked from commit 9331e5eddab194f9f17bf09c3b0c70da5c87ab77)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13593
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove unnecessary setter/getter related errorcode for response

There are invalid APIs setErrorCode/getErrorCode in C++ layer.
It can be caused a big confusion to user.
Since the value never transfer on network. it just set in class inside.
Thur, It is better to remove the methods.

Change-Id: Iab863b1c16095ec77b9733bd3ff0ea38167b2dba
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13151
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add macro about registered topic data.

This patch include,
It added a macro to delete the data that was registered topic.

Change-Id: Ie83b23b7276bb5aaf07388c0faba34b47bce7f16
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13473
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Changes to SSL adapter unit tests
caTrustedCrl discarded due to needlessness

Change-Id: I7b7e9bb0d85474a6f0ecf8f23019b072715c08bd
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13553
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 4c6b0de1730df1addff1a85410f3de7a83ac0271)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13575

Fixed sign-compare warning

In the ParseChain function the bufLen and pos varaible were
changed from int to size_t.  Every location that ParseChain
is called is passing in a size_t as the bufLen an unsigned
type. The pos variable is never negative and should be the
same type as the bufLen.

While in the function the documentation was cleaned up and
comemnts were added to quickly identify the contents of the
pemCertHeader and pemCerFooter byte arrays. As well as clarify
the need of the goto `exit:` label when using the
CHECK_MBEDTLS_RET macro.

Change-Id: I1f063dddea29a2a00ae6e47c7b2240794bcaf5bb
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

linux: Support also armeabi-v7a TARGET_ARCH

This EABI is used in Tizen, this way iotivity
 can be rebuild on Tizen using "linux" profile (TARGET_OS).

For instance unsupported older tizen profiles can be rebuilt using gbs
 (ie Tizen:2.3:Wearable).

Change-Id: Ia84cb173add8efbb10cb2a9632a7637cf6202114
Origin: https://gerrit.iotivity.org/gerrit/#/c/12417/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12417
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13613

Fixed static analysis issues in RI.

Change-Id: Id6a1b8edb41b3863ba722db43285d28e264dfda8
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13133
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1458] fix to handle unexpected disconnected state for BLE

Change-Id: I83ba76e61eb57fce91c42d32c434a3b2735d2aa3
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13371
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

tizen: Scons sqlite puller should not be used

Tizen wants to link with system's sqlite package

Change-Id: I685af2816d21c592e7ef67be3451bb42c4ff338d
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add a maximum observer TTL of 24 hours

A server that transmits notifications mostly in non-confirmable
messages MUST send a notification in a confirmable message instead of
a non-confirmable message at least every 24 hours. This prevents a
client that went away or is no longer interested from remaining in the
list of observers indefinitely.

Change-Id: Ie676f9f5f394fa094b4f2d9fd3a72e2d38d21b24
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11497
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix aircon_controller crash issue

1. Fix crash issue

Change-Id: I6033e3272ce8f085730e1b579e026ef079bd7097
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1459]Add CA API which returns selected transport adapter

Add CA API which returns selected transport adapter.
Returns bit combinations of CATransportAdapter_t enumeration
which indicate enabled adapter.
CATransportAdapter_t CAGetSelectedNetwork();

Change-Id: If9116991585ab20b56303875d2d83a79316d2387
Signed-off-by: bg.chun <bg.chun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13391
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1445] Add ins value when publishing a resource to rd

The ins value has to be included when publishing a resource
to resource-directory. Otherwise resource-directory will
return error code.
Currently, The ins is not included because the return value
of OCGetResourceIns() was not checked properly.

Change-Id: I11b1f405e000f36bb76ca7d24c8dbbbd6e7586fe
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13159
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit b5d331d2d779172bceebb9b92cc73eecc6d6cdae)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13225

Start building json2cbor for Windows.

Change-Id: I9a1e43969c597eed68eac0df28b90571c67de931
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13521
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

License added to cloud codes

License information added to clous codes

Change-Id: Ic16fbb9f76a858e6c98a01389dfdd55e50b4de1e
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13551
Reviewed-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit f188154d6af64981563f2dc4499ea9759613468b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13557

Bug fix about semicolon of if statement.

this patch include,
bug fix about invalid statement.

Change-Id: Ifd9762161058ab1381be2341bf92f0a5184371d9
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

tizen: Apply mbedtls ocf.patch only once

It has been tested with:
  scons -f resource/csdk/stack/samples/tizen/build/SConscript \
    TARGET_OS=tizen LOGGING=TRUE RELEASE=0 \
    SECURED=1 WITH_TCP=1 TARGET_TRANSPORT=IP,BT

Related to:
  https://gerrit.iotivity.org/gerrit/#/c/12029

Change-Id: I1b140503a1e4b3c52cc95d41c27c00bdd4a47ccf
Credit-to: Randeep Singh <randeep.s@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/12965/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12965
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
(cherry picked from commit 54966d90b2cf9f8c844bbaa1b1aa4f876fc91a7e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13517

tizen: Use sqlite from system not scon puller

Change-Id: Id4382d37d34e5ac7d023e38bebd60228c6e6860e
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12913
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit d1ee9e78d898746b842a2439f88d26fd30a377bc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13041

Modified connectivityType on calling getDeviceInfo API at CPP Sample

Modified connectivityType on calling getDeviceInfo API at CPP Sample
Invalid connectivityType is used after merging below patch.
https://gerrit.iotivity.org/gerrit/#/c/13143

Change-Id: Ia881159af02f1eae984d4cda770e23cf6205741a
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13261
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 0ba523056a0174479befe2a147d420be63f62d35)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13541
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

tizen: Ship renamed libuuid into RPM for SDK

This way produced RPM can be installed on target or imported in SDK.

libuuid.so.1 is pulled by pkgconfig from com-oic-ri.spec
 then it will be installed correctly if using "rpm -i *.rpm",

Overiding system libs in packaging, is not encouraged:
Observed issue on Tizen:2.4:Mobile (TM1) :

  sdb shell su -c "rpm -i /opt/usr/media/Others/GBS-ROOT-RI-OIC/*.rpm"
  file /usr/lib/libuuid.so.1 from install of com-oic-ri-1.2.0-0.armv7l \
  conflicts with file from package libuuid-2.20.2-4.139.slp.armv7l

But if we want to unpack RPM contents to be used along Tizen-sdk,
 as app, then uuid is also needed
 (because SDK is missing it from its sysroot).
 So application need to be linked with -luuid1 (same just renamed),
 to avoid collision.

For more details about building IoTivity for Tizen along SDK,
 please check:

https://wiki.iotivity.org/tizen

Change-Id: Iabed0221618d0d602f440e3527e1824177395ee1
Bug: https://jira.iotivity.org/browse/IOT-1343
Origin: https://gerrit.iotivity.org/gerrit/#/c/12471
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 8a3ea331f4c08296a2e11185a780de7f17d42956)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12719

tizen: Disable Bluetooth transport for Tizen:2.3

Tizen:2.3:Wearable (Samsung GearS) builds at least.
Because it's not building using outdated capi BT packages.

Change-Id: Id1b37df55bbdebd7ada1413935f5306ccd1e0002
Bug: https://jira.iotivity.org/browse/IOT-1320
Origin: https://gerrit.iotivity.org/gerrit/#/c/12475/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 8fe95f36541c5191439af915396055c667404269)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13511

tizen: Disable Bluetooth for Tizen:IVI (capi outdated)

Make sure capi-network-bluetooth-devel
 is shipping bluetooth_internal.h.

For instance, 0.1.39 does not have it, while 0.1.52 have it.

In that case it will fail to build and report a message like:

   resource/csdk/connectivity/src/bt_edr_adapter/tizen/\
   caedrclient.c:30:32: \
   fatal error: bluetooth_internal.h: No such file or directory

This need to be checked for other Tizen profiles:
 Tizen:2.3.1:Wearable, Tizen:2.4:Mobile have it.

Bug: https://jira.iotivity.org/browse/IOT-1343
Change-Id: I028f3c4fd8c9526b5d06a55b0f2a5f5c6c113d3d
Origin: https://gerrit.iotivity.org/gerrit/#/c/12355/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 61382c1df95115ef595b06e023d59bcca8bad22c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13509

Merge 1.2-rel cloud project into master

1. Overwrite 1.2-rel cloud project into master

Change-Id: I9271607595166fce4bda9011f028a40514908fec
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Yeonghun Nam <yeonghun.nam@samsung.com>

tizen: Enable Bluetooth along IP

Revert "Change build option - IP only"

This reverts commit 28d898d2dab5a4463ba5f7ea380258a4f4362578.

Change-Id: Ia3223a2ab09ba219bf8048aa28014744e19ed4b0
Author: Yungjae Shin <yj99.shin@samsung.com>
Origin: https://review.tizen.org/gerrit/#/c/63051/
Bug: https://jira.iotivity.org/browse/IOT-1343
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12353
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit cf0b4cbec478e84f4f6a4cc4fa118a96f6cdffb2)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13507

tizen: Simplify missing license macro for Tizen:2.3

Change-Id: I6c2ceec4f37589db6c110a0f04df501c689a3fde
Origin: https://gerrit.iotivity.org/gerrit/#/c/12897/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12897
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 0d1a98d360977b8d967129282ff8644f363c5e79)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13513

tizen: Can support linux as fallback TARGET_OS

It can be helpful for platform developers
 to bypass tizen APIs on Tizen devices.

Might be useful for other RPM based distro,
 like Fedora for ARTIK, or (obsolete) Tizen profiles
 (with outdated Tizen packages).

Reformat options list to make nicer patches
 when configuration is changed (single word == single line).

Bug: https://jira.iotivity.org/browse/IOT-1320
Change-Id: Id1b37df55bbdebd7ada1413935f5306ccd1e0001
Origin: https://gerrit.iotivity.org/gerrit/#/c/12473/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12473
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 9ce88ac4271b9fa8fb400e4db4b8b43b5af5d6a8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13505

tizen: avoid en_speedpython for Tizen:2.4

May be squashed into:
https://review.tizen.org/gerrit/#/c/82272/3/packaging/iotivity.spec

Change-Id: I2d0e8b5e8b9404760ce58ee634348ef6bc3ade1d
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12053
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 4405f658bf7d1004f6a97b7ff211ae88267eee85)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12489

Update run.bat to allow argument overrides

Add arguments to the run.bat cmdline to enable building
for both x86 and amd64 architecture, turning off tests,
enabling logging and building release binaries.

Change-Id: Ic381d258bf8465399d94319a93499365db7f8f24
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13355
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

tizen: Introduce speedpython macro to speedup build

revise build time

Change-Id: I674157a6b446c8fad54cb7c8a2a937007f04db8a
Author: Youngjae Shin <yj99.shin@samsung.com>
Origin: https://review.tizen.org/gerrit/#/c/82272/3
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12051
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit ae5114229c8dd6759795a7f545c4699909bdd5b7)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12221

tizen: Disable TCP by default

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Icd0973c3bc0140d2320b2018de85ba589eae51fc
Origin: https://gerrit.iotivity.org/gerrit/#/c/12099/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 32510b62640f4aa5b7b6d82508ae9ee5d88ee9e6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12491

tizen: Disable WITH_CLOUD by default

Even if the code is building, I have disabled it by default,
 to align default values set in ./build_common/SConscript

If needed it can be enabled, but make sure a value is set to it.

Bug: https://jira.iotivity.org/browse/IOT-1295
Change-Id: Id075b0479185aea2e13396df51ffecd56a9e183f
Origin: https://gerrit.iotivity.org/gerrit/#/c/11305/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11737
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit 7252457fc2f63a43e89c64ac8c3dff8c19dc7d1a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11305

tizen: Use installed sqlite3

Change-Id: I2cc6cb804bd9c28473cf1dfc2b4c85c4da6cb982
Bug: https://jira.iotivity.org/browse/IOT-1296
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12911
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8173

fixed typo in resource/docs/c-doc/Doxfile

Change-Id: I553ad3f3278a0183a3fcc3a1b13ff0bf17ea3791
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13469
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

remove warning issue fragmentation and rdclient

this warning was came from analysis tool
- remove unreachable code.
- apply to check return value in rdclient example.

Change-Id: I2466e15e56f11344ffbc2712527d12c7ae326a0a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11673
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1434] fix subscribe presence for multicast.

it causes a big memory issue to add in serverRequestList.
because this request never remove

and subscribe presence for multicast should be not sent
on network.
since it is just for register clientCB in stack.

Change-Id: I14c9701009350ad52dfdf4e72db64522fc591705
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 45b9f4b4dade573f698f307c421c107d6190653f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13383

[IOT-1436] fix scons build issue related sqlite3 with unsecured mode

sqlite3 is triggering to download by default.
it causes a storage memory waste in user side.
scons build script should check any option for download that lib

Change-Id: I701752bb450dc79d3604304fc7130375586e5356
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13071
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 651887dd94864cf0f8eda52f5a8d7ec93dc27d0e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13381

[IOT-1391] fix BLE scan logic which create thread.

scan thread was made by unicast/multicast request in BLE client.
it causes a big problem which memory overflow issue related Thread.
so, scan thread will be working as one thread.

Change-Id: I87564f88b67d88781366523ae014c29fe1b13e2e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12781
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

replace singly linked-list Data structure with red-black tree for serverRequest

Since every data structure used in stack is singly linked-list,
it would be quite inefficient for some data which can be stored massively
like received request info on server.
So I replaced it with red-black tree.
(tree.h from openBSD : http://openbsd.su/src/sys/sys/tree.h)

Change-Id: I68a9b7d00f7f1f9f6aecacee04e0627b72a4ff6b
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Prevent empty credential to be added

Prevent empty credential to be added
(e.g. only rowneruuid is sent)

Patch #1: initial upload
Patch #2-3: fix arduino build error

Change-Id: I7802dcb76daab3269eb0a9638659087643b0c141
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 9366b7f721f6fe0c526832baf26b102984c7dcee)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13445

SVACE issue fixes

Change-Id: I4cd1fb23818a560449ae1ff3f2635c14ef093da7
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13435
Reviewed-by: Jongmin Choi <jminl.choi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2ee97889f591fccaec860fb7ae7d0d95148c9311)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13447

Update the return value of MOT releated API.

Change-Id: I97a6ee6f0b9eecafd2a28e717887a04decd9209d
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13449
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 1ae2de1ec129cd8ad6de9cabae7cccff755ff170)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13461

Update build script for RE android sample app.

When building of RE android sample app,
we need to execute of scons build and also need additional android studio build.
With this patch, can build android sample app by only scons build.

Change-Id: Ife7142cf89993531bc15bf4b9f655090f50a1bad
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13369
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix issues relates to wrong syncInfo received

Change-Id: I77f9ce5d0fa3e7c40e0fe390b42f210e5a188a50
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13451
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Multiple Ownership Transfer support.

[NOTE] This patch includes the following patches for MOT :
   https://gerrit.iotivity.org/gerrit/#/c/12063/
   https://gerrit.iotivity.org/gerrit/#/c/13375/
   https://gerrit.iotivity.org/gerrit/#/c/13341/
   https://gerrit.iotivity.org/gerrit/#/c/13343/

[Overview]
This patch is to support the multiple ownership transfer(MOT).
We assume the MOT authenticated client is the SubOwner.
SubOwner can access the ALL resources with full permsion except the DOXM, ACL and CRED.

This patch includes following changes :
1. Update the doxm resource to include MOT related properties.
   - New Properties
     . x.org.iotivity.mom : Mode of MOT
     . x.org.iotivity.subowneruuid : List of SubOwner
   - SubOwner has READ permission for DOXM.
   - The resource server will be update subowner list of doxm
     when MOT authentication successfully done.

2. Update the cred, acl resource to include MOT related property.
   - New Properties
     . x.org.iotivity.eowneruuid : entry owner uuid for each entry.
   - SubOwner should set the eowner as subowner's UUID
     when provision the ACL and CRED.
   - SubOwner can access only those resources that registered as eowner.

3. Update the PolicyEngine for SubOwner's access control as following :
   - DOXM : READ ONLY
   - CRED/ACL : SubOwner can access only those resources that registerd as eowner.
     . SubOwner can not provision ACL which is include the DOXM, CRED, ACL, PSTAT.
   - PSTAT : FULL permission
   - Application Resources : FULL permission

4. Add Preconfigured-PIN OxM

5. Update the sample codes
   - Test Preconfigured PIN based MOT
     1. Run the sampleserver_justworks
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Perform the MOT enabled device discovery [Menu:13]
        - Check the discovered device list.
     8. POST the preconfigured-PIN credential [Menu:71]
         - sample's preconfigured-PIN is '12341234'
     9. Change the server's 'oxmsel' [Menu:72]
         - '3' is preconfigured-PIN OxM
     10. Run the subownerclient
     [On the subownerclient]
     11. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     12. Perform the MOT [Menu:20]
     13. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     14. Perform the ACL provisioning TEST [Menu:40]

   - Test Random PIN based MOT
     1. Run the sampleserver_randompin
     2. Run the provisioningclient
     [On the provisioningclient]
     3. Perform the UnOwned Device discovery [Menu:11]
     4. Perform the OTM [Menu:20]
     5. Perform the Owned Device Discovery [Menu:12]
     6. Change the server's 'mode of MOT' [Menu:70]
     7. Run the subownerclient
     [On the subownerclient]
     8. Perform the MOT enabled device discovery [Menu:10]
         - Check the discovered device list.
     9. Perform the MOT [Menu:20]
         In case of random PIN based MOT, PIN input required.
     [On the sampleserver_randompin]
     10. Press 'G' or 'g' on the sampleserver_randompin.
         server will generate and display the random PIN.
     11. Input the server's PIN number on the subownerclient side.
     12. Perform the Multiple Owned device discovery [Menu:11]
         - Check the discovered device list.
     13. Perform the ACL provisioning TEST [Menu:40]
     14. Press 'E' or 'e' on the sampleserver_randompin to exit server.

Change-Id: I25d029839b3567455743031afafb34d2fc78278c
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13419
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Fix bug for invalid return variable.

Invalid return variable is fixed.
1. invalid boolean -> pointer
2. invalid pointer -> boolean

Change-Id: I16cb2338b28ba5bb725ed6eb8d640f04216f7933
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13317
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update discovery when connection was changed.

When connection state was changed try to unicast discovery.

Change-Id: I7fe8f16039e9ead5002282742d6e51d805fc9225
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Updated NS Sample App for testing Sync and sending complete NSMessage

Change-Id: I8bf14b020b1e5ec42dcf5710fe30a1b6beefbe4b
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13401
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for Memory leak results from static analyzer for NS C++ Wrapper.

Change-Id: I97ca331ce6fcd7352350fd36426366433a5521a2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13307
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Build issue for soname for NS Libraries

Change-Id: I07416d904e5ac63bbb389081e99f6849acfff842
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13413
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

setting received  ttl value  by consumer.

Change-Id: I1de504edf851d39d761dfa2a189a77116fca8a85
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13387
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

fix issue related to wrong messageId

Change-Id: I6008dfe8fc3dc648841f0527e993bd698275f7e4
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13385
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Unit tests for SSL adapter update

Change-Id: Ib108dd1ce76632f1393383e6402e73c7ba2e60d7
Signed-off-by: Oleksii Beketov <ol.beketov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13349
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 2fe020f4bc86b7dcecc4a8853b7f772b591a010c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13363

build: ignore debian generated files

Change-Id: I963a02a548344f5c6e9955a4286de595801e9f93
Origin: https://gerrit.iotivity.org/gerrit/#/c/11811/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12967
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
(cherry picked from commit ee74ca52a64302ba39c2d5cce7762fbd4c35427d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11811

tizen: Use upstream packaging file as aligned

Note, for dependencies libraries.
It's easier to maintain them as patches over upstream git.

More details on downstream maintenance at:
https://wiki.iotivity.org/tizen

Change-Id: Id630e6a06bff11c750a106e8fc0cffb9a154f87b
Bug: https://review.tizen.org/gerrit/#/c/82260/
Origin: https://github.com/tizenteam/iotivity/tree/sandbox/pcoval/on/master/tizen
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11683
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11407

fix android build failure issue with WITH_CLOUD=1 and secure mode

Change-Id: I1f1cca166866fda08e2d644032eca7e721bf8db8
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12861
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ec9364d7abdbd06a406d2028cdfa27b315aefffe)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13061

added error code (4.03 / 5.00) in ocstack result

Change-Id: I311c0b76a2faa7704be8f4a8b89088a0ae471c6a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13135
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: byonggon chun <bg.chun@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1388] fixed duplicate start server in EDR adapter.

when both mode(server and client) in App is set.
startDiscoveryServer and startListenningServer is calling.
and then both accept thread
and receive thread is running redundantly

Change-Id: I70395ace6115d52d28d2c034ea24c70aafeb671e
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12799
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13065

modify about rule of coding.

this patch include,
1. modify if statement and while statement about rule of coding.
2. remove unused function.

Change-Id: I73117fcc15581dfaff435cd5922f14c91356c358
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13357
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Bug fix about result of static anlayzer.

this patch include,
bug fix about memory leak and coding idiom.

Change-Id: I6fba4a8b182ce88cda44571ebb490c7573812c01
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13267
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix crash in Android provisioning client App.

Catch exception in provision Android client for setDeviceId API.

Change-Id: I19918e47eac9f040d490e3805964c6cc7d5d3fba
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13345
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit add0610e0eafe8c51d669151fa77aeca5ee59bd6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13347

Update a logic to check an availability of cloud server resource

Rather than URI, resource type of the cloud server resource is more
confirmable to check the availability.

Change-Id: I61f3b63412b39fc56e993a3041ac007d0886368b
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add null checking for observe request in easy setup

Checking if entityHandlerRequest is NULL is added.

Change-Id: I79bf75c9f53f28b9c0c679a5dd7371552764b5cd
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13323
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix for all discovered devices to include a secure port

This patch prevent to add the device that does not have a secure port to discovered device list

Change-Id: Ia7283b37b7820e045f4a51ad03395205b4240dd3
Signed-off-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13299
Reviewed-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 44d8220a5c20a0077cfc4c65fbd9919b37129278)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13303

IOT-1448 - Fix Windows x86 Build issue

The affected test were processing the windows
include files before the iotivity_config.h
could set the preprocessor config.

Update callback calling convention

Change-Id: I9adbfafef2c2e1b117a37ad9003ff53bb0450656
Signed-off-by: Mike Fenelon <mike.fenelon@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13185
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Update the ACL delete mechanism as determined by OSWG.

After this patch,
If 'subject' not exist in the query string of DELETE request,
All ACE data will be removed.

Change-Id: Ife12c457b2029991168bf048bbfb90278ea4b3a2
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 8d7bb539d4325a857a8297a760348ccc0e1eb081)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13297

[IOT-1442] Apply the new ACL policy for device owner and resource owner.

According to new ACL policy,
Device owner's ACL should be provisioned while OTM.
For this reason, Ownership transfer manager should updates the owner's ACL while OTM.

- Patch #1 : Initial upload
- Patch #2 : Updated according to comments.
- Patch #3 : Rebase
- Patch #4 : Fixed a bug that occured during rebase.

Change-Id: I92a78e6145afdb3341582555739a64184bee65db
Signed-off-by: Chul Lee <chuls.lee@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12265
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 21c991f5a317bc1e3872bcb25a216e903352b40b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13275

Add license comment

Change-Id: I1374b2ee45e120bae756e1e2f975eba23fee24f4
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13291
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Added NULL check for GetDoxmResourceData

Change-Id: Iea981a40ebaccef368ae4cbd834c30cb124fd76c
Signed-off-by: sahil bansal <sahil.bansal@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 615726b1656173c4a6892ef28a6c3e664a0125ec)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13273

Keep ACL rowneruuid when POST payload does not have rowneruuid

Maintains the ACL rowneruuid when the payload of POST request
does not have rowneruuid

Change-Id: I52177b84ba9ced8b1078b3edea12256e23d6dfd8
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit b012422858a1834d1b3868dbf51f67bcebd613c1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13271

[IOT-1438] Solve Build issue on Tizen secured build through gbsbuild script

- add secured check logic into gbsbuild.sh file
- using this logic, check mbedtls file & apply the patch

Change-Id: I6d458ea599562216444582b78724a1b61023d6de
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13099
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit 3f7b46b56356b3d8997fc56d5904a1e0e12d9c87)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13263

[IOT-1440] findResource() to return list of discovered resources.

OCPlatform::findResource() does not return all the discovered resources in single callback
even though it gets the whole discovery payload from RI C layer.

This change implements OCPlatform::findResourceList() API which does return all the parsed
resources in discovery payload in single callback.

Change-Id: Ic95541f7303a15eb676029e6f2ea4952e5e3ca3e
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13113
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix bugs for result of static analizer.

1. Initializatioin of local variable is added.
2. Invalid memory double free is removed on error handling.

Change-Id: I2d4c8460dd1e81ef88f6119f79deeae09c7f01c8
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13201
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
(cherry picked from commit bae888047c3313e742f2b56cbab3366b118762e4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13259

bug fix about memory leak.

this patch include,
bug fix for dynamic analyzer.

Change-Id: I4fc7ff7436ac6019abe3aaaf8467392068e0ad7d
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13253
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

IOT-1447 Fix scope_id usage

Never assume that a scope id and an interface index are the same.
Removed bad code from the tcp adapter; the scope id should always
be present in the addr string of a scoped IPv6 address, and is correctly
handled by CAConvertNameToAddr and CAConvertAddrToName.

Change-Id: I19f8739d7da2e7944e3904770ca0d8e914608ba2
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13181
Reviewed-by: Jaewook Jung <jw0213.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Update observe-request processing logic.

Change-Id: Icb5ae1a3f8c8e985570b30b0420cc6e7fe98ffdc
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13235
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Bug fix about memory leak.

this patch include,
bug fix for dynamic analyzer.

Change-Id: I9a36d496b76c9d712d80af45492f0e38a7aff4ea
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13243
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1392] Fix Android build for SECURE=0 and WITH_TCP=1

Change-Id: Ia4423b2ad9b2f0d38f95050aea5380d4bde70fae
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12761
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit ca322622fe08d67f39ae7b491038c1d6f040b8d1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12847
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

bug fix for response of topic and modify unittest.

this patch include,
1. bug fix for response of topic post case.
2. modify unittest about included interface type.

Change-Id: I5bba7ef93260c2c67f25d9d79455e383d6ea8c0c
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[IOT-1444] Enabling handling observe requests for collection resource.

Change-Id: If72f5a85858240787dea2b307710f1167c14c68a
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13149
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added SVACE Fixes for C++ wrapper Unit TCs

Change-Id: I09224a2bcd6e38c0d8cbb80caf5a0009161113d2
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove unnecessary define and files for SSL

1) Removed X.509 build option because it is enabled by default
2) Deleted DTLS and TLS adapter files because thay are included in SSL

Change-Id: I078c5b0c912801f17fa858d6fdd2abe39feed9f8
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13115
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13213

tizen: Ship only BSD licence from libcoap

libcoap-4.1.1 is also licenced LICENSE.GPL,
to avoid ambiguity, tizen use the more permissive one, BSD.

This patch can be reverted,
 if Tizen wants to ship all upstream licences

Change-Id: Idc77605c48322f36887cc502dc0be570e2562486
Origin: https://gerrit.iotivity.org/gerrit/#/c/12969/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12805
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

[IOT-1449] mbedTLS: Use wcslen instead of lstrlenW on Windows

lstrlenW is not allowed in Windows Store applications. Use wcslen
instead.

Also fix a nearby narrowing size_t to int conversion to make sure
it's safe.

Change-Id: I14d37b6a0d6c82444f4733f5d54bd8173ca62b71
Signed-off-by: Kevin Kane <kkane@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13183
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit aa49bbd28a78a486df9568b3867a373100e92e2f)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13207

Fix a faulty logic in PMSingleDeviceDiscovery

A device discovery transaction should be removed AFTER port discovery
is done or discovery time is expired.

Change-Id: I55062a3a8ef5187bf249d0afee2276e40c0f52d9
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Reviewed-by: Heewon Park <h_w.park@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 3c07416db2f0bd587fbe9e1619d0fe954bb6cfc1)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13165

Set ACL Rowner to PT's Device ID in SRPProvisionACL

If Rowner of ACL to be provisioned in SRPProvisionACL is empty,
Set it to PT's Device ID

Patch #1: Initial upload
Patch #2: Jongsung's recommendation applied
Patch #3: Fix typo
Patch #4-5: GetDoxmDeviceID failure taken care of

Change-Id: I38886d32fd35f39370d4e5e46e39b66edfc0f003
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13037
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit e3a136f22d2c08a237b7b949d914a9f299fea3d8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13205

Cloud ACL Modifications

Modifications to Cloud ACL

Patch #1: ACE Id changed to UUID format
Patch #2: Changes modified DeleteACE & UpdateACE changes added
Patch #3: Oid check included in verifyAcl
Patch #4-5: OCCloudAclIndividualDeleteAce() added
Patch #6: Minor bug fixes
Patch #7: OCCloudAclIndividualUpdate() added

Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Change-Id: I6b3b4c68f06c43ce002df36a741ea4eb8549ba44
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12739
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 6c08489dfc353cb854f2d04c4648108c04d114b6)
Reviewed-on: https://gerrit.iotivity.org/gerrit/12785

[IOT-1446] Fix discovery failure issue

Change logic in the Policy Engine in order to resolve
discovery failure issue

Patch #1: Initial upload
Patch #2: Error message changed

Change-Id: I08ab1dec15cb0f49374d42d97b65a23fe885db39
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13173
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
(cherry picked from commit 5c78f31a2d4415c970f38db14e248bfef348a6b0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/13199

Updated Easysetup Security logic.

 - EnrolleeSecure resource not to re-created during previous request is processed
   for every security provisioning request to get callback from security-logic

Change-Id: I905b1cf708db68583a95bd9cad299212fa00ec84
Signed-off-by: Parkhi <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13077
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add logic about checking the NULL and modify warning code.

This patch include, check the NULL and modify warning code.

Change-Id: Ie28548563357e0c9565ecdcd776cce60d3d42f33
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modified CloudClient (CPP)

to use DEFAULT_PORT 5683

Change-Id: I32c5d5c7e373250ac2af3354c5a345a02d4cdbea
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/12935
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/13017