Afsaneh Rafighi [Thu, 25 Apr 2019 16:34:24 +0000 (09:34 -0700)]
Merge pull request dotnet/corefx#36678 from Wraith2/sqlfeat-udtbytes
SqlClient Allow specifying a UDT SqlParameter value as bytes
Commit migrated from https://github.com/dotnet/corefx/commit/
aff33dce8057538524af37ab00e09a21b56e6d3e
Jim Demis [Thu, 25 Apr 2019 15:40:08 +0000 (18:40 +0300)]
Fixes compression method override of zero-length files (dotnet/corefx#37079)
* Fixes compression method override of zero-length files
When a zero-length file is stored using compression method, ZipArchive still overrides the method to “not compressed”, and ignore compressed bytes that are still present, rendering the zip file unusable.
Fixes dotnet/corefx#30317
* Ignore uncompressed data for zero-byte files
* Removed unnecesary compressed data and resolved review feedback
* Changed to assert lengths from stream and removed forgotten debug assert
* Moved compressed size reset before WriteLocalFileHeader to keep assert
* Applied test feedback
* Renamed few fields
Commit migrated from https://github.com/dotnet/corefx/commit/
bdd2014f2d1863a296f76b5c90152ae016854afc
Tom Deseyn [Thu, 25 Apr 2019 15:36:23 +0000 (17:36 +0200)]
Linux: determine ProcessName using /proc cmdline to avoid truncated names (dotnet/corefx#37144)
* Linux: determine ProcessName using /proc cmdline to avoid truncated names
* PR feedback
* LongProcessNamesAreSupported test: ensure Process gets killed when Assert throws
Commit migrated from https://github.com/dotnet/corefx/commit/
4214b09864bea0416f17727ffa39a55d950035d1
Viktor Hofer [Thu, 25 Apr 2019 14:48:24 +0000 (16:48 +0200)]
Enable CoreLib coverage (dotnet/corefx#37172)
* Enable CoreLib coverage
Commit migrated from https://github.com/dotnet/corefx/commit/
eb2d732bf8d35186c70c743812e5d17584b6975f
Eric StJohn [Thu, 25 Apr 2019 09:25:08 +0000 (02:25 -0700)]
Use Coreclr transport packages (dotnet/corefx#37163)
* Replace CoreCLR package with transport package
This allows us to remove the manual download step
* Remove IL and NI folders, use IL in debug or when specified
I also simplified some of these targets. NuGet automatically includes all files in native,
so additional inclusion was unnecessary.
* Disable IL CoreLib swap for UAP10.0.16299 and AOT
Commit migrated from https://github.com/dotnet/corefx/commit/
8c7afe67ee2e9bd21a4412265b66f875cfafaede
Devendar Reddy Adulla [Thu, 25 Apr 2019 01:16:26 +0000 (18:16 -0700)]
Embedded resources may not have extension in the name (dotnet/corefx#37048)
* Bitmaps are replaced with Icons and Logical names are changed to not having any extensions.
* Checking for Rawformat before calling MakeTransparent method.
* Adding a test attribute
* Adding test.
Commit migrated from https://github.com/dotnet/corefx/commit/
27d0597c556d7a4040571d09ede9b84bc1cc6b85
Jan Kotas [Thu, 25 Apr 2019 00:06:30 +0000 (17:06 -0700)]
Unify WIN32_FIND_DATA (dotnet/corefx#37158)
Commit migrated from https://github.com/dotnet/corefx/commit/
51922de496a713568b493e791c60e419042d19b5
Steve Harter [Wed, 24 Apr 2019 18:37:04 +0000 (11:37 -0700)]
Fix JSON deserializer property name escaping and address naming feedback (dotnet/corefx#37124)
Commit migrated from https://github.com/dotnet/corefx/commit/
cf0624854a1a4d8eda961a6eb06bb803b0555dfd
Zachary Danz [Wed, 24 Apr 2019 17:57:55 +0000 (10:57 -0700)]
Fix link to Preview SDKs (dotnet/corefx#37150)
Commit migrated from https://github.com/dotnet/corefx/commit/
c73d2c15c0194ead26d54cb72224f2daf1e1c5cc
dotnet-maestro[bot] [Wed, 24 Apr 2019 17:33:37 +0000 (17:33 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37141)
* Update dependencies from https://github.com/dotnet/coreclr build
20190423.74
- Microsoft.NET.Sdk.IL - 3.0.0-preview6-27623-74
- Microsoft.NETCore.ILAsm - 3.0.0-preview6-27623-74
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview6-27623-74
* Update ThreadPool test for revised behavior
Commit migrated from https://github.com/dotnet/corefx/commit/
7f60d72fb64cfacec41f47d59ac5e35ed54aa442
Jan Kotas [Wed, 24 Apr 2019 15:46:42 +0000 (08:46 -0700)]
Fix CPINFOEXW definition (dotnet/corefx#37131)
* Fix CPINFOEXW definition
* Unify MAX_PATH definition and switch to use it for GetCPInfoEx
Commit migrated from https://github.com/dotnet/corefx/commit/
24efeca2cb7e8a83125ecdbc62c95040fddabdf2
Stefan [Wed, 24 Apr 2019 15:05:14 +0000 (17:05 +0200)]
Add missing 'if' in summary comment (dotnet/corefx#37136)
Add missing 'if' in summary comment
Commit migrated from https://github.com/dotnet/corefx/commit/
7a60f1e1ef6080e0f29e007ae6218043abdef3ad
Tomas Weinfurt [Wed, 24 Apr 2019 11:02:23 +0000 (04:02 -0700)]
fix ReadAtLeastAsync (dotnet/corefx#37130)
Commit migrated from https://github.com/dotnet/corefx/commit/
c75330881567febca956696e0cc0bd66687bc1bc
Karel Zikmund [Wed, 24 Apr 2019 10:09:47 +0000 (03:09 -0700)]
Update System.IO* areas ownership
Commit migrated from https://github.com/dotnet/corefx/commit/
ad01dd1c314485bb2b86ed6743004a132912754d
Viktor Hofer [Wed, 24 Apr 2019 03:02:17 +0000 (05:02 +0200)]
Fix test asset publishing when retrying (dotnet/corefx#37116)
Fixes official builds that are retried, i.e.: https://dev.azure.com/dnceng/internal/_build/results?buildId=165244
Commit migrated from https://github.com/dotnet/corefx/commit/
918609481617f5c167496925c02bf0329afbff76
Charles Stoner [Wed, 24 Apr 2019 01:11:11 +0000 (18:11 -0700)]
Port remaining members of Microsoft.VisualBasic.Strings (dotnet/corefx#37123)
Commit migrated from https://github.com/dotnet/corefx/commit/
48cc70c649b7876ca43155451cafba5499107c07
Ludovic Henry [Tue, 23 Apr 2019 21:39:47 +0000 (14:39 -0700)]
Make GC.GetGCMemoryInfo public (dotnet/corefx#37092)
* Make GC.GetGCMemoryInfo public
Fix https://github.com/dotnet/corefx/issues/34631
* Fix uapaot framework
* Address review
* Add some tests
* Harden some tests
* Merge the GCMemoryInfo tests
* Simplify test
We are in a remote process, no need to clean up the GCHandle at the end of the test
Commit migrated from https://github.com/dotnet/corefx/commit/
9e2f3b630a51875fc0455a7cabb8803f6527f81e
Jim [Tue, 23 Apr 2019 21:29:19 +0000 (00:29 +0300)]
Fixes an issue with some characters not recognized as ASCII (dotnet/corefx#36879)
* Fixes an issue with some characters not recognized as ASCII
Three characters "{","|" and "}" was being wrongfully marked as NonAscii, thus making IsWellFormedUriString function return false when combined with any other Unicode character(s).
Fix dotnet/corefx#36101
* restored original solution file
* Updated test
Added "|" character to test string
Removed not needed unicode string
Added skip om Net Framework
* Added more strings to test
* Added comment and removed not needed check for escaping
Commit migrated from https://github.com/dotnet/corefx/commit/
e13d1c997475e938f6e1eee8c3c73cd166033090
Carlos Sanchez Lopez [Tue, 23 Apr 2019 20:46:50 +0000 (13:46 -0700)]
Directory.Move behaves differently on Unix vs. Windows (dotnet/corefx#37121)
* Directory.Move behaves differently on Unix vs. Windows
We will now throw an exception in Unix platforms like in Windows, if the destination path already exists.
* Modifying ExistingDirectory test method that verifies Move overwrite so its called by all platforms.
We already had a test method that tests Move when the destination path exists. I simply removed the platform attribute that restricted it to Windows and renamed the test method so its universal (as opposed to platform specific).
Commit migrated from https://github.com/dotnet/corefx/commit/
f9c85c033361ee5bfcf43707dc6d29731f8bc3cb
Tanner Gooding [Tue, 23 Apr 2019 20:40:45 +0000 (13:40 -0700)]
Regenerating reference sources in order to reorder enum fields (dotnet/corefx#37045)
Commit migrated from https://github.com/dotnet/corefx/commit/
17382def0f680653870c31af1acf086ac41dcc0b
Jose Perez Rodriguez [Tue, 23 Apr 2019 19:59:02 +0000 (12:59 -0700)]
Adding a few serialization attributes back to the reference assemblies (dotnet/corefx#37005)
* Adding a few serialization attributes back to the reference assemblies
* Use GenerateReferenceSource for the contracts that were changed
Commit migrated from https://github.com/dotnet/corefx/commit/
eea71b082b9f3d7ac74fe9297b1a5d66c1372508
William Godbe [Tue, 23 Apr 2019 19:27:57 +0000 (12:27 -0700)]
Merge pull request dotnet/corefx#37059 from dotnet/darc-master-
64fc4629-3427-4547-a455-
773e6620fa4c
[master] Update dependencies from dotnet/standard
Commit migrated from https://github.com/dotnet/corefx/commit/
50919ec6cd7f580d12c7c06909cbe812d3196e3d
Wraith2 [Sun, 7 Apr 2019 19:18:43 +0000 (20:18 +0100)]
special case bytes in udt parameter write
Commit migrated from https://github.com/dotnet/corefx/commit/
21e1b5d53c9b778ec53be473b612aa880005b3be
wtgodbe [Tue, 23 Apr 2019 17:06:19 +0000 (10:06 -0700)]
Update APICompat baseline
Commit migrated from https://github.com/dotnet/corefx/commit/
50e72c8b4a1b87872d1e35ae17fef4312c939488
Tomas Weinfurt [Tue, 23 Apr 2019 14:42:24 +0000 (07:42 -0700)]
make invalidUri more invalid (dotnet/corefx#37109)
Commit migrated from https://github.com/dotnet/corefx/commit/
69d2e45a8a8840ba7a90e4ad2d2805d9033aabfc
Stephen Toub [Tue, 23 Apr 2019 11:47:02 +0000 (07:47 -0400)]
Revert "Squash fix for process name. (dotnet/corefx#36913)" (dotnet/corefx#37113)
This reverts commit dotnet/corefx@
8b515adcd4ea0b8233f018f9e87ef946ce0e7c42.
Commit migrated from https://github.com/dotnet/corefx/commit/
9b71f88a2a02bba67c5eb8764b4770535a8e904a
David Fowler [Tue, 23 Apr 2019 04:26:44 +0000 (21:26 -0700)]
Fix flaky test (dotnet/corefx#37106)
- Synchronize reads and writes using a tcs.
Commit migrated from https://github.com/dotnet/corefx/commit/
a78bd0c13887e26372aafdffb8f06be26563c4a8
Kevin Jones [Mon, 22 Apr 2019 22:46:00 +0000 (18:46 -0400)]
Support RSAES-OAEP encryption with EnvelopedCms
Allow an RSA recipient to indicate the encryption padding that should be used. This makes it easier to get RSA-OAEP-SHA1, and makes it possible to get RSA-OAEP-SHA2 (for some specific SHA-2).
Commit migrated from https://github.com/dotnet/corefx/commit/
6cc58374f68b28ef991c3f155f1e87a5902cacf8
Anirudh Agnihotry [Mon, 22 Apr 2019 22:14:35 +0000 (15:14 -0700)]
Added code for removing oleHeader (dotnet/corefx#36891)
* added code for removing oleHeader and modifiying it to use span
* updating the testdata version and reading only the header signature first
* removing size check on the size of object header as welll as we are catching ArgumentOutOfRangeException
* Updating verison numbers
Commit migrated from https://github.com/dotnet/corefx/commit/
eb9b565f13905624ba01464c876dc06a83a3d9e2
Afsaneh Rafighi [Mon, 22 Apr 2019 20:09:20 +0000 (13:09 -0700)]
Merge pull request dotnet/corefx#37027 from Wraith2/sqltest-concurrentload
SqlClient add concurrent load tests
Commit migrated from https://github.com/dotnet/corefx/commit/
a3ab91e10045bb298f48c1d1f9bd5b0782a8ac46
Tomas Weinfurt [Mon, 22 Apr 2019 19:28:16 +0000 (12:28 -0700)]
write Host header first if we need to add it (dotnet/corefx#37007)
* write Host header first if we need to add it
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
724d8f73e66b747e079875d431d4c1fa546119e1
Charles Stoner [Mon, 22 Apr 2019 18:32:16 +0000 (11:32 -0700)]
Initial port of Microsoft.VisualBasic.Devices and Microsoft.VisualBasic.MyServices (dotnet/corefx#37085)
Commit migrated from https://github.com/dotnet/corefx/commit/
37703f186d593425418a7fcf705173c707da30d4
Stephen Toub [Mon, 22 Apr 2019 16:03:51 +0000 (12:03 -0400)]
Fix conditional fact in ArrayBufferWriter tests (dotnet/corefx#37086)
Commit migrated from https://github.com/dotnet/corefx/commit/
3bda413dc3ae242a7f47967dceb9ffbc13024c78
Steve MacLean [Mon, 22 Apr 2019 14:06:21 +0000 (10:06 -0400)]
Revise and fix CreateInstanceAssemblyResolve (dotnet/corefx#37080)
dotnet/coreclrdotnet/corefx#24154 will remove the quirk the CreateInstanceAssemblyResolve
test was testing. It will now throw a FileNotFoundException, without triggering
a resolving event.
Commit migrated from https://github.com/dotnet/corefx/commit/
ea10af28f44e473f3f71934c6bfa9a2830403153
Steve MacLean [Sun, 21 Apr 2019 20:19:00 +0000 (16:19 -0400)]
Add ContextualReflection tests (dotnet/corefx#37052)
* Add ContextualReflection tests
Commit migrated from https://github.com/dotnet/corefx/commit/
b96247e76506e81ff6eb28dd2a14914a59e2a257
Steve Harter [Sun, 21 Apr 2019 16:13:09 +0000 (09:13 -0700)]
Add Dictionary support to JsonSerializer (dotnet/corefx#37070)
* Add Dictionary support to JsonSerializer
This partially addresses https://github.com/dotnet/corefx/issues/36024.
For the intial version, only `Dictionary<string, [some concrete type]>`
is supported.
* Refactor
* Add more tests
Commit migrated from https://github.com/dotnet/corefx/commit/
431f6557d0089e07c953934583e1decca3c90831
Steve MacLean [Sun, 21 Apr 2019 15:09:43 +0000 (11:09 -0400)]
Fix DefaultLoadContextTest (dotnet/corefx#37071)
Move clear of olc.LoadedFromContext earlier before System.Runtime is loaded.
Commit migrated from https://github.com/dotnet/corefx/commit/
0ac3306ffe66327ec6360694579fe1fe786816e1
Stephen Toub [Sat, 20 Apr 2019 20:07:52 +0000 (16:07 -0400)]
Add EnumeratorCancellationAttribute (dotnet/corefx#37064)
* Update ChannelReader.ReadAllAsync for EnumeratorCancellationAttribute
* Add EnumeratorCancellationAttribute
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
13cd96122c25328a1b180a6289923657180a7b69
Peter Stevenson [Sat, 20 Apr 2019 15:40:41 +0000 (16:40 +0100)]
Squash fix for process name. (dotnet/corefx#36913)
Handle long process names on Linux
See: https://github.com/2E0PGS/corefx/commit/dotnet/corefx@
56e73858adb046b57165eae44af111d64e2fcd98
* add test
* update test
* update test
* address PR feedback
* fix alpine ci
* fix compilation
* add some log for alpine fail
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8b515adcd4ea0b8233f018f9e87ef946ce0e7c42
Tomas Weinfurt [Sat, 20 Apr 2019 13:36:43 +0000 (06:36 -0700)]
skip GetAsync_IPv6LinkLocalAddressUri_Success if address is not available (dotnet/corefx#37051)
Commit migrated from https://github.com/dotnet/corefx/commit/
8e2e72b2683a4b4b983b184f1e703a3174b8566c
Charles Stoner [Sat, 20 Apr 2019 06:31:00 +0000 (23:31 -0700)]
Port Microsoft.VisualBasic.Conversion class (dotnet/corefx#37047)
Commit migrated from https://github.com/dotnet/corefx/commit/
c608ddaa2a024dde2510f3c1122c89ba07b4325d
Ahson Khan [Sat, 20 Apr 2019 00:35:24 +0000 (17:35 -0700)]
Address and fix ArrayBufferWriter and Utf8JsonWriter feedback and nits (dotnet/corefx#37017)
* Address ABW and Utf8JsonWriter feedback and nits.
* Address ABW init and test feedback.
* Fix up JsonWriter usage of ABW and update tests.
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
4a25e4b03bcb5b9b1b2319b4178d2dfcfe05b3b1
Stephan Tolksdorf [Fri, 19 Apr 2019 22:05:14 +0000 (00:05 +0200)]
Fix doc comment for Utf8JsonReader.ValueSequence (dotnet/corefx#37038)
Fixes issue dotnet/corefx#37036.
Commit migrated from https://github.com/dotnet/corefx/commit/
c0cd09bb7fb1d40e51e4fdab1822a50a2b322260
Wraith2 [Fri, 19 Apr 2019 21:52:40 +0000 (22:52 +0100)]
remove commented code and address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
23a78c29abb05724c69fb81603542aeefb617f78
Zachary Danz [Fri, 19 Apr 2019 21:38:42 +0000 (14:38 -0700)]
Update windows instructions to encourage VS 2019 preview explicitly (dotnet/corefx#37013)
* Update windows instructions to encourage 16 preview
* Update windows-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
feb534bfdf8695068cfd85a6e39e57ecb6373371
Charles Stoner [Fri, 19 Apr 2019 20:11:39 +0000 (13:11 -0700)]
More porting of vbruntime (dotnet/corefx#37010)
Commit migrated from https://github.com/dotnet/corefx/commit/
432a34fed6f0db6d76d5b3f8bbc8297fb0aa5f6b
Ian Griffiths [Fri, 19 Apr 2019 17:44:08 +0000 (18:44 +0100)]
Support XmlKnownDtds in XmlPreloadedResolver (dotnet/corefx#36971)
* Support XmlKnownDtds in XmlPreloadedResolver
The XmlPreloadedResolver class purports to provide certain well-known DTDs - its constructor accepts a value from the XmlKnownDtds enumeration, and if you specify either of the supported DTD sets (sXHTML 1.0, and RSS 0.91) it is meant to make the relevant DTDs available.
In desktop .NET, this works as advertised. In .NET Core, it does not, for the reasons described in https://github.com/dotnet/corefx/issues/36929
This was missed because there are no tests to verify that the XmlPreloadedResolver makes the relevant DTDs available when asked to. (In fact, the tests that existed seemed to be based on a misunderstanding of how this class works.) This adds tests that verify that the known DTDs are provided when requested. And it reinstates the relevant EmbeddedResource entries required to enable the functionality. (The code for this has been in .NET Core's XmlPreloadedResolver all along. It was only the absence of the necessary embedded resources preventing it from working.)
* Completed refactoring that was half-complete
In the previous commit I introduced the NormalizeContent method to avoid duplication of various calls to string.Replace but I left in one such call. This replaces it with a call to the new NormalizeContent, as intended.
* Replace \ with / in test paths
Tests failed on Linux with this:
Could not find a part of the path '/root/helix/work/workitem/Utils\\DTDs\\/XHTML10\
I'm hoping that replacing the backslashes with forward slashes will get the tests passing.
* Replaced fixed / and \ with Path.Combine
Although using / everywhere did seem to work, the preferred way to generate paths is Path.Combine.
Note that this still uses string concatenation for the system ID URI because that's not a path, it's just an identifier.
Commit migrated from https://github.com/dotnet/corefx/commit/
eb63183901fbe6afc2be4e1ff0f365fe20cefbf5
Tanner Gooding [Fri, 19 Apr 2019 16:33:54 +0000 (09:33 -0700)]
Renaming the Sse2.StoreLow(ulong/long*, ...) methods to Sse2.StoreScalar (dotnet/corefx#37029)
Commit migrated from https://github.com/dotnet/corefx/commit/
9ca73f6b6ab92a977e6191e64ae09baf7d0bf131
Tarek Mahmoud Sayed [Fri, 19 Apr 2019 15:46:25 +0000 (08:46 -0700)]
Fix IDN Tests to support Unicode 11 (dotnet/corefx#37011)
Windows 19H1 upgraded the IDN data to Unicode 11. The change here is to to use the new Unicode 11 IDN test data in our tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
3679699457b7cf7ece9c6f82f214346cfb07eff9
dotnet-maestro[bot] [Fri, 19 Apr 2019 15:09:12 +0000 (15:09 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#37023)
* Update dependencies from https://github.com/dotnet/coreclr build
20190418.74
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27618-74
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27618-74
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27618-74
* Fix StackTrace.ToString with null frame test
Commit migrated from https://github.com/dotnet/corefx/commit/
8fa3e3c3624967a4049070791788f0602b2581e1
Wraith2 [Fri, 19 Apr 2019 13:48:22 +0000 (14:48 +0100)]
add concurrent load tests
Commit migrated from https://github.com/dotnet/corefx/commit/
7e89b7e3f4d4fd6a706e6878c0b9132c1b32e96f
Chris Ross [Fri, 19 Apr 2019 05:27:38 +0000 (22:27 -0700)]
Implement server-side of NegotiateStream on Unix (dotnet/corefx#36827)
Commit migrated from https://github.com/dotnet/corefx/commit/
0a9a366e290aded3e9bf5d082d6beee5ff560177
Tomas Weinfurt [Fri, 19 Apr 2019 04:15:37 +0000 (21:15 -0700)]
add test for connection timeouts (dotnet/corefx#36990)
* add test for connection timeouts
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
2a6ee34edd98c1746c11c9354bef12654822f5ee
Ponant [Fri, 19 Apr 2019 04:14:10 +0000 (06:14 +0200)]
Performance improvements in EmailAddressAttribute (dotnet/corefx#36994)
* performance improvements by a factor of 2 to 10
I get a perf improvement by using IndexOf which ranges from a a factor of two for an email address having 20 char to nearly 10 for 60 char.
* Update src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/EmailAddressAttribute.cs
force explicit type
* Simplify code
Commit migrated from https://github.com/dotnet/corefx/commit/
556e080cce3bbd075f7199286b33842f5c0a0c61
Sung Yoon Whang [Fri, 19 Apr 2019 01:04:39 +0000 (18:04 -0700)]
Add missing method
Commit migrated from https://github.com/dotnet/corefx/commit/
c150a145990a662258e685ea204a8e83a7333111
Sung Yoon Whang [Fri, 19 Apr 2019 00:56:07 +0000 (17:56 -0700)]
I'm stupid
Commit migrated from https://github.com/dotnet/corefx/commit/
d64827a410909d18d90c0fa2b25c52f65ce59e2c
Sung Yoon Whang [Fri, 19 Apr 2019 00:49:51 +0000 (17:49 -0700)]
splitting implementation of EventCounter to non-uap/uap
Commit migrated from https://github.com/dotnet/corefx/commit/
2d1e2ff48e61a70ef990f48e677f6237b044fe52
Sung Yoon Whang [Thu, 18 Apr 2019 23:39:08 +0000 (16:39 -0700)]
try to exclude new counters for uap
Commit migrated from https://github.com/dotnet/corefx/commit/
c29c7b4a5630b896bbbb73f18f0de2dea9e0d123
Sung Yoon Whang [Thu, 18 Apr 2019 22:50:48 +0000 (15:50 -0700)]
disable exposing new counter types on ProjectN until they are propagated through the targetingpack
Commit migrated from https://github.com/dotnet/corefx/commit/
33724212beccbdca43d020f595dce88e38eaab31
Sung Yoon Whang [Thu, 18 Apr 2019 06:33:42 +0000 (23:33 -0700)]
some type annotation stuff
Commit migrated from https://github.com/dotnet/corefx/commit/
c478c7c2d86b31917e6bd8dd62c66d8f00cac10a
Sung Yoon Whang [Thu, 18 Apr 2019 06:32:41 +0000 (23:32 -0700)]
remove extra nl
Commit migrated from https://github.com/dotnet/corefx/commit/
0955fc31dfd9fca8b200aa5f1c59a453c01ca0ef
Sung Yoon Whang [Thu, 18 Apr 2019 06:16:47 +0000 (23:16 -0700)]
Exposing the new counter APIs in System.Diagnostics.Tracing
Commit migrated from https://github.com/dotnet/corefx/commit/
c042b3aa7de95332624f3d725e8abdb4d3d043f5
Jose Perez Rodriguez [Thu, 18 Apr 2019 23:21:48 +0000 (16:21 -0700)]
Fix Json Source package not includding ArrayBufferWriter (dotnet/corefx#37009)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1b0a40964253b1bc48dd3be734eb2e1cf716db3
Charles Stoner [Thu, 18 Apr 2019 21:23:40 +0000 (14:23 -0700)]
Port StringType (dotnet/corefx#36951)
Commit migrated from https://github.com/dotnet/corefx/commit/
d69b4f7864a76a375d4178b1afa8c9e97ee549b8
buyaa-n [Thu, 18 Apr 2019 19:46:20 +0000 (12:46 -0700)]
Hashcode calculation update (dotnet/corefx#37002)
Seems packaging failure is not related, merging, thank you all for feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
e816593d49d87ec2a5815e34b82c5c8ba86aa85f
Tomas Weinfurt [Thu, 18 Apr 2019 19:10:31 +0000 (12:10 -0700)]
allow Http2 loopback test be unencrypted (dotnet/corefx#36968)
* fix tests with http/2
* make SSL on Loopback server configurable via environment
* update variable names
Commit migrated from https://github.com/dotnet/corefx/commit/
95987e3e3aa95b2ae6386b17271a172d20fe50cc
David Fowler [Thu, 18 Apr 2019 17:32:55 +0000 (10:32 -0700)]
Handle concurrent dispose and WriteAsync calls (dotnet/corefx#36988)
- lock the entire Write operation
- Added a test that Completes both reader and writer in the middle of writing a large buffer
Commit migrated from https://github.com/dotnet/corefx/commit/
90d98b9abb87743c2340506a7823e452c757767c
Tomas Weinfurt [Thu, 18 Apr 2019 12:42:24 +0000 (05:42 -0700)]
handle bad Expires better (dotnet/corefx#36908)
* handle bad Expires better
* update tests
* internal -> private
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
82eedbff6b767c0bd9297d3dd27c89d925a28e93
Ahson Khan [Thu, 18 Apr 2019 06:57:50 +0000 (23:57 -0700)]
Re-design Utf8JsonWriter as a regular class rather than a ref struct. (dotnet/corefx#36961)
* Add an in-box array-backed IBufferWriter<T>
* Update Utf8JsonWriter ref and main writer file.
* Fix JsonWriter WriteValue APIs.
* Use Environment.NewLine static and invert some stream conditions.
* Update JsonWriter properties and fix serializer build breaks.
* Update JsonWriter unit tests.
* Add xml comments, clean up, and improve test coverage.
* Update JsonDocument and JsonSerializer to react to JsonWriter changes.
* Normalize the reference assembly.
* Do not escape/validate comments and update issue number.
* Do not escape comments and validate they don't contain embedded
delimiter
* Remove dead code and update issue number in comments.
* Throw InvalidOEx instead of ArgEx if IBW doesn't give requested memory.
* Fix test build breaks for netfx.
* Remove dead code and fix source packaging.
* Address PR feedback.
* Disable writing floats test on windows
* 8 digit floats don't work well on older TFMs. Reduce to 7.
Commit migrated from https://github.com/dotnet/corefx/commit/
1f9b84a0804e868c7e0f37a3c10fbaf7c735ae14
Stephen Toub [Thu, 18 Apr 2019 04:01:04 +0000 (00:01 -0400)]
Fix SocketsHttpHandler streams to do sync I/O in sync methods (dotnet/corefx#36946)
* Fix SocketsHttpHandler response streams to do sync I/O in sync methods
SocketsHttpHandler hands back response Streams for reading response body content. While we encourage developers to use the async Stream APIs, Stream does expose synchronous APIs, yet the current implementations are just wrapping the async ones and doing sync-over-async.
This fixes the response stream synchronous APIs to be sync down to the underlying networking stream.
It also fixes a couple other minor issues, e.g. Flush{Async} on read-only stream should be nops rather than throwing, we should include an error message about a stream being read-only when trying to write to it, etc.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
315fd00cb2465390900209919cdb2bf6bc44ae0e
David Shulman [Thu, 18 Apr 2019 03:33:23 +0000 (20:33 -0700)]
Fix ClientWebSocket closing handshake logic (dotnet/corefx#36975)
An HttpListener websocket test was failing after the change from PR dotnet/corefx#36928. That PR made changes
to tighten up the transition to the Closed state after the closing handshake had completed.
That PR missed some additional changes needed especially in cases where a server (such as loopback)
sends the close frame almost concurrently with the client sending the close frame.
This PR fixes the close frame handshake logic and also makes some optimizations in cases where the
websocket has already transitioned to the Aborted state during the closing handshake. In that case,
the websocket should not wait for a close frame to be received but should simply proceed to closing
the connection.
Fixes dotnet/corefx#36963
Commit migrated from https://github.com/dotnet/corefx/commit/
1824535f95defea3ba464599ee4b9937a82eaaf9
Adeel Mujahid [Thu, 18 Apr 2019 03:02:55 +0000 (04:02 +0100)]
Improve System.Native build experience for new platforms (dotnet/corefx#36926)
Commit migrated from https://github.com/dotnet/corefx/commit/
65f07a9cf6e3d53cbd77c52d5ecffe00be0ff804
Levi Broderick [Thu, 18 Apr 2019 02:35:56 +0000 (19:35 -0700)]
Add extra tests for UTF-16 validation of random 8-char data (dotnet/corefx#36903)
Commit migrated from https://github.com/dotnet/corefx/commit/
60aee3575e21af1070e7b834905d1864a401828d
Eric StJohn [Thu, 18 Apr 2019 01:11:05 +0000 (18:11 -0700)]
Fix SDK downgrading Platforms package (dotnet/corefx#36981)
Commit migrated from https://github.com/dotnet/corefx/commit/
dcd80906ded9fee765d7ce4de4d992d5108df63c
Jose Perez Rodriguez [Thu, 18 Apr 2019 00:48:24 +0000 (17:48 -0700)]
Manually updating dependencies in order to get the new coreclr packages. (dotnet/corefx#36976)
* Update the Index and Range interfaces and tests
* Fix api compat failure with utf8string
* Fix the test to use Assert.Throws
* Update dependencies manually
Commit migrated from https://github.com/dotnet/corefx/commit/
d5a5f3c9eb96adf38115cbc04e5664abf328b02d
dotnet-maestro[bot] [Wed, 17 Apr 2019 23:18:59 +0000 (16:18 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36922)
* Update dependencies from https://github.com/dotnet/coreclr build
20190415.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27615-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27615-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27615-72
* Update dependencies from https://github.com/dotnet/coreclr build
20190416.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27616-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27616-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27616-72
* Update CoreCLR dependencies to 3.0.0-preview5-27616-73
* Fixing the Min/Max and MinMagnitude/MaxMagnitude for System.Math and System.MathF to expect NaN propagation
Commit migrated from https://github.com/dotnet/corefx/commit/
818355a02ec70c72d44e4ad2b1b95943350d55bb
Steve Harter [Wed, 17 Apr 2019 22:52:49 +0000 (15:52 -0700)]
Add Json serializer property name related features (dotnet/corefx#36940)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc8c22291049b2626ec5b102869685fc95fa41cc
Adeel Mujahid [Wed, 17 Apr 2019 18:44:46 +0000 (19:44 +0100)]
Use NativeLibrary.[Try]Load for netcoreapp3 (dotnet/corefx#36944)
Commit migrated from https://github.com/dotnet/corefx/commit/
fbc748b93e65600a68b217ec59fc4522d5df4ffb
Tanner Gooding [Wed, 17 Apr 2019 17:07:51 +0000 (10:07 -0700)]
Regenerating the System.Runtime.Intrinsics reference source (dotnet/corefx#36965)
Commit migrated from https://github.com/dotnet/corefx/commit/
fa25b86d6789440f42ba391deda428e302f584f9
Stephen Toub [Wed, 17 Apr 2019 15:15:40 +0000 (11:15 -0400)]
Disable asserting HttpListener web socket test (dotnet/corefx#36964)
Commit migrated from https://github.com/dotnet/corefx/commit/
18cd561127e35841db2775dc7a85adad70363e18
Anirudh Agnihotry [Wed, 17 Apr 2019 06:22:12 +0000 (23:22 -0700)]
adding default encoder as png when we are not able to find encoder (dotnet/corefx#36937)
Commit migrated from https://github.com/dotnet/corefx/commit/
dbbabfbf3e5a355b9bde2a01f2effde96631242a
Michal Strehovský [Wed, 17 Apr 2019 04:47:15 +0000 (06:47 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36924)
This reverts commit dotnet/corefx@
8e843314e1dbd3b3f26abb1f285349be8920cce4.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9f88bd7fd774ce433a764b6d388517c6460164a
Tomas Weinfurt [Wed, 17 Apr 2019 04:00:27 +0000 (21:00 -0700)]
fix tests with http/2 (dotnet/corefx#36945)
Commit migrated from https://github.com/dotnet/corefx/commit/
f80cf8c360ef00c9a5fdc990e3abd7df23ee0015
Viktor Hofer [Wed, 17 Apr 2019 00:40:30 +0000 (02:40 +0200)]
Update testdata versions (dotnet/corefx#36938)
* Update testdata versions
* Bump versions in projects and group in TestData
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
e5d2b5291277dbd7444d0a17a2bff4784265d917
David Shulman [Wed, 17 Apr 2019 00:15:30 +0000 (17:15 -0700)]
Fix ClientWebSocket close handshake when using proxy (dotnet/corefx#36928)
When the client websocket was going through a proxy, it would sometimes transition to the
'Aborted' state and not the 'Closed' state after a successful closing handshake.
I first opened this bug a year ago but finally was able to get back to it and root cause the
problem. The problem only occured with the managed websocket. The .NET Framework did not have
this problem. And some proxies didn't cause a problem with managed websocket (such as Fiddler).
The root cause is a misinterpretation of RFC 6455, Section 7.1.1. This describes the behavior
of how the websocket's TCP connection should be closed. The most graceful way is to wait for
the server to initiate the close of the socket. In cases where it is taking too long to wait
for the server to start the TCP close, then the client can start the TCP close of the socket.
But no matter how the socket is finally closed, the websocket state should transition to 'Closed'
as soon as a valid closing handshake was performed (i.e. close frames both sent and received).
And this occurs before any logic for closing the TCP connection.
The code in managed websocket has a timer to wait 1 second for the server to start a close. If
the timer finishes, then the managed websocket calls an Abort() method to close the socket. This
ends up transitioning the websocket to an 'Aborted' state which is incorrect. The state should
only be moved to the 'Aborted' state if a closing handshake was not completed.
I added a new test to support this change and moved the LoopbackProxyServer code to Common.
Fixes dotnet/corefx#28027
Commit migrated from https://github.com/dotnet/corefx/commit/
0c9684c2c4057908cf697a366a3b1527326e507d
Eric StJohn [Tue, 16 Apr 2019 23:06:39 +0000 (16:06 -0700)]
Fix VB.Core SLN configurations (dotnet/corefx#36934)
Commit migrated from https://github.com/dotnet/corefx/commit/
39cc91592c3d9c8fe7700a6323755cd7747c34ab
Tomas Weinfurt [Tue, 16 Apr 2019 21:53:07 +0000 (14:53 -0700)]
add tests for invalid HTTP headers (dotnet/corefx#36898)
* add SendAsync_InvalidHeader_Throw
* fix tests
* move SendAsync_InvalidHeader_Throw
Commit migrated from https://github.com/dotnet/corefx/commit/
18e1fabd13b40eb6ea88c1b7bae8c4e14a927019
Carlos Sanchez Lopez [Tue, 16 Apr 2019 21:24:34 +0000 (14:24 -0700)]
Update owners (dotnet/corefx#36936)
Updating ownership in the System.Net area (removing Max and Caesar).
URI - Will.
Commit migrated from https://github.com/dotnet/corefx/commit/
c3c0efd9029370ab9762ee254e3db8b8e3dddf34
Filip Navara [Sun, 14 Apr 2019 20:50:50 +0000 (22:50 +0200)]
Move EventSource to shared CoreLib partition
Commit migrated from https://github.com/dotnet/corefx/commit/
00279f8fd11a96f57b8a56855d313f9e2c9bb513
Tomas Weinfurt [Tue, 16 Apr 2019 18:54:24 +0000 (11:54 -0700)]
support HTTP/2 without TLS (dotnet/corefx#36753)
* support HTTP/2 without ssl
* feedback from review
* revert changes GetAsync->SendAsync
* remove unused variable
* feedback from review
* feedback from review
* add missong Trace().
Commit migrated from https://github.com/dotnet/corefx/commit/
7ed0c5338941346a3cacb4e18f19aaddb283da90
Viktor Hofer [Tue, 16 Apr 2019 17:41:48 +0000 (19:41 +0200)]
React to RunTests CLI changes & Manual darc update (dotnet/corefx#36915)
* Manual darc update from build '
20190415.12'
* React to RunTests CLI changes
Commit migrated from https://github.com/dotnet/corefx/commit/
53f9e9e7fc87cbc08449307fbb0fbe567516e38f
Hugh Bellamy [Tue, 16 Apr 2019 14:59:12 +0000 (15:59 +0100)]
Remove devdocs from System.Runtime.InteropServices code (dotnet/corefx#36669)
* Cleanup System.Runtime.InteropServices code
- Move public classes/enums to their own file
- Use summary instead of devdoc
- Misc
Commit migrated from https://github.com/dotnet/corefx/commit/
8d79b6117e9d584eebb8b6933bba83dd514010ca
Viktor Hofer [Tue, 16 Apr 2019 11:59:00 +0000 (13:59 +0200)]
Update SDK requirement in windows-instructions
Commit migrated from https://github.com/dotnet/corefx/commit/
e2ecd2c33aed216f9a1062044aedf10e25ee8ca4
Viktor Hofer [Tue, 16 Apr 2019 07:19:21 +0000 (09:19 +0200)]
Upgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)
* Upgrade SDK to 3.0
* Remove asp and desktop framework references
* Manual darc update from build '
20190415.1'
* Suppress type overlap with ns2.1
* Make SDK use output of core-setup for both ref and runtime
SDK is ignoring RuntimeFrameworkVersion for ref packs. Set TargetingPackVersion
on KnownFrameworkReference instead.
https://github.com/dotnet/sdk/issues/3129
Commit migrated from https://github.com/dotnet/corefx/commit/
66bcc2d2b1248ed5384393adf5f3a647d18b75f1
Grant [Tue, 16 Apr 2019 01:24:04 +0000 (18:24 -0700)]
Ref Assembly and Units for Span.Trim (dotnet/corefx#35576)
* Units for Trim
* Add ref assembly
* Bug
* Add char units
* Bugs
* CR fixes - 1
* CR fixes - 2
* CR fixes - 3
* CR fixes - 4
* CR fixes - 5
* Revert formatting
* unfo formatting
* Get MemberData working
* Normalize ref
* Manual revert changes
* CR fixes
* Undo code cleanup
* Fixes
* Update ref
* Update ref
* Update ref
* Move memory tests
* Revert StringTests
* Remove redundant unit code
* Add missing refs
* Bug
* dotnet msbuild /t:GenerateReferenceSource
* Revert unintended changes
* POC : Check if fix works
* Fix units
* Revert temp test
* Update ApiCompatBaseline.uapaot.txt
Commit migrated from https://github.com/dotnet/corefx/commit/
2191763a765654710df5317dc65dc7cd935bc8c1
Tomas Weinfurt [Mon, 15 Apr 2019 22:15:32 +0000 (15:15 -0700)]
add test for lower casing header name logic (dotnet/corefx#36708)
* add test for 35164
* update SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2
* fix uwp tests
* change port from 123 to 443
Commit migrated from https://github.com/dotnet/corefx/commit/
4e3b46c22cec88a1f0deaa2f594634e5553412e1
Steve Harter [Mon, 15 Apr 2019 21:44:04 +0000 (14:44 -0700)]
Remove null coalescing assignment operator to avoid build-from-source compile issues (dotnet/corefx#36890)
Commit migrated from https://github.com/dotnet/corefx/commit/
f78e9881bd8ef1def0227569d822693b944378a7
Omair Majid [Mon, 15 Apr 2019 20:55:02 +0000 (16:55 -0400)]
Close the socket if bind() fails (dotnet/corefx#36769)
When using a socket with bind() and bind fails, close the socket to free
up the resources associated with the socket.
Commit migrated from https://github.com/dotnet/corefx/commit/
03ae543d4da4e539b9915a5f38f36a69739fa9d9
Steve Harter [Mon, 15 Apr 2019 17:58:03 +0000 (10:58 -0700)]
Json deserializer collection perf improvements by avoiding boxing (dotnet/corefx#36865)
Commit migrated from https://github.com/dotnet/corefx/commit/
6bfaf4116b5180c857bf6ad531f0655fd57c5eef
Santiago Fernandez Madero [Mon, 15 Apr 2019 17:55:42 +0000 (12:55 -0500)]
Remove myget publish entirely (dotnet/corefx#36886)
Commit migrated from https://github.com/dotnet/corefx/commit/
d601d2e7602c9dbb6ae0d95c450bce2db027f78d