jochen [Mon, 19 Jan 2015 10:12:28 +0000 (02:12 -0800)]
Add missing if (FLAG_verify_heap) checks around heap verification
BUG=chromium:449943
R=svenpanne@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
848403003
Cr-Commit-Position: refs/heads/master@{#26127}
mvstanton [Mon, 19 Jan 2015 09:31:02 +0000 (01:31 -0800)]
ClusterFuzz fix: %NormalizeElements shouldn't process the global proxy.
BUG=449070
R=yangguo@chromium.org
LOG=N
Review URL: https://codereview.chromium.org/
859713002
Cr-Commit-Position: refs/heads/master@{#26126}
yangguo [Mon, 19 Jan 2015 09:17:12 +0000 (01:17 -0800)]
Correctly load RegExp.source from the holder.
R=mvstanton@chromium.org
BUG=chromium:447561
LOG=N
Review URL: https://codereview.chromium.org/
844193004
Cr-Commit-Position: refs/heads/master@{#26125}
bmeurer [Mon, 19 Jan 2015 08:07:22 +0000 (00:07 -0800)]
[turbofan] Make Factory::NewNumber() always return the minus_zero_value.
TEST=unittests
Review URL: https://codereview.chromium.org/
857783002
Cr-Commit-Position: refs/heads/master@{#26124}
chunyang.dai [Mon, 19 Jan 2015 05:44:00 +0000 (21:44 -0800)]
X87: Add fast-path OOB support to KeyedLoadIC_Generic
port
79ed8f173ce1624f6d7821ea6b44ce75efa97912.
original commit message:
Add fast-path OOB support to KeyedLoadIC_Generic
BUG=
Review URL: https://codereview.chromium.org/
862443002
Cr-Commit-Position: refs/heads/master@{#26123}
chunyang.dai [Mon, 19 Jan 2015 05:06:29 +0000 (21:06 -0800)]
X87: split api call stubs into accessor and function call stubs
port
6950ead0b0a8373441dc8f8d3b2c316e82549ce9
original commit message:
split api call stubs into accessor and function call stubs
BUG=
Review URL: https://codereview.chromium.org/
860593002
Cr-Commit-Position: refs/heads/master@{#26122}
machenbach [Sun, 18 Jan 2015 15:43:02 +0000 (07:43 -0800)]
Revert of Reland Auto-generate v8 version based on tags. (patchset #1 id:1 of https://codereview.chromium.org/
843913009/)
Reason for revert:
The gclient hook of v8 is not executed on this builder:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/49765
Original issue's description:
> Reland Auto-generate v8 version based on tags.
>
> This relands the CL
> https://codereview.chromium.org/
797503007/.
>
> It runs the version generation two times. First during
> runhooks as a fallback for recipes that loose git context
> (e.g. android_aosp). Second during compilation like in the
> original CL. In case of failures, the result from the
> runhooks call will be reused.
>
> BUG=chromium:446166
> LOG=n
>
> Committed: https://crrev.com/
d3d6e38b2cba73b52bd5ed00f4441a7db3284a19
> Cr-Commit-Position: refs/heads/master@{#26120}
TBR=jochen@chromium.org,jkummerow@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:446166
Review URL: https://codereview.chromium.org/
855263002
Cr-Commit-Position: refs/heads/master@{#26121}
machenbach [Sun, 18 Jan 2015 11:25:41 +0000 (03:25 -0800)]
Reland Auto-generate v8 version based on tags.
This relands the CL
https://codereview.chromium.org/
797503007/.
It runs the version generation two times. First during
runhooks as a fallback for recipes that loose git context
(e.g. android_aosp). Second during compilation like in the
original CL. In case of failures, the result from the
runhooks call will be reused.
BUG=chromium:446166
LOG=n
Review URL: https://codereview.chromium.org/
843913009
Cr-Commit-Position: refs/heads/master@{#26120}
machenbach [Sat, 17 Jan 2015 13:45:27 +0000 (05:45 -0800)]
Revert of [turbofan] Fix bunch of tests failing with --turbo-deoptimization. (patchset #1 id:1 of https://codereview.chromium.org/
786333004/)
Reason for revert:
This changes layout test expectations. I ran a bisect over the layout tests:
Bad:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/1600
Good:
http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/1599
If this is intentional please first land a CL with manualrebaseline test expectations for the changed tests and then reland.
Original issue's description:
> [turbofan] Fix bunch of tests failing with --turbo-deoptimization.
>
> R=bmeurer@chromium.org
>
> Committed: https://crrev.com/
e9e772121b36697821dbfff61f36e0a68367f21c
> Cr-Commit-Position: refs/heads/master@{#26115}
TBR=bmeurer@chromium.org,jarin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
804333005
Cr-Commit-Position: refs/heads/master@{#26119}
akos.palfi [Sat, 17 Jan 2015 09:02:07 +0000 (01:02 -0800)]
MIPS: Fix after 'MIPS: split api call stubs into accessor and function call stubs'.
Port
6950ead0b0a8373441dc8f8d3b2c316e82549ce9
This commit fixes the remaining test failures after:
ec52f8df7f0956ecaed0422110847ee5634c1304
BUG=
Review URL: https://codereview.chromium.org/
855183003
Cr-Commit-Position: refs/heads/master@{#26118}
v8-autoroll [Sat, 17 Jan 2015 04:29:07 +0000 (20:29 -0800)]
Update V8 DEPS.
Rolling v8/tools/clang to
97bfed3644c03f48864c479b8714f08ed80c5d13
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
851413002
Cr-Commit-Position: refs/heads/master@{#26117}
akos.palfi [Sat, 17 Jan 2015 03:21:42 +0000 (19:21 -0800)]
MIPS: split api call stubs into accessor and function call stubs
Port
6950ead0b0a8373441dc8f8d3b2c316e82549ce9
Note: This port has known issues, there are about 40 test failures. The purpose of this commit is to unbreak the MIPS build.
BUG=
Review URL: https://codereview.chromium.org/
853323002
Cr-Commit-Position: refs/heads/master@{#26116}
jarin [Fri, 16 Jan 2015 22:23:23 +0000 (14:23 -0800)]
[turbofan] Fix bunch of tests failing with --turbo-deoptimization.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
786333004
Cr-Commit-Position: refs/heads/master@{#26115}
yangguo [Fri, 16 Jan 2015 22:22:13 +0000 (14:22 -0800)]
Use back reference map to find references to global proxy.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
825933004
Cr-Commit-Position: refs/heads/master@{#26114}
jarin [Fri, 16 Jan 2015 22:21:08 +0000 (14:21 -0800)]
[turbofan] Add frame state to the PlainPrimitiveToNumber unit test.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
792043007
Cr-Commit-Position: refs/heads/master@{#26113}
mstarzinger [Fri, 16 Jan 2015 22:20:00 +0000 (14:20 -0800)]
Allow --always-opt to go further into the pipeline (1).
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
841213003
Cr-Commit-Position: refs/heads/master@{#26112}
jkummerow [Fri, 16 Jan 2015 22:18:48 +0000 (14:18 -0800)]
Add fast-path OOB support to KeyedLoadIC_Generic
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
852313002
Cr-Commit-Position: refs/heads/master@{#26111}
yangguo [Fri, 16 Jan 2015 22:17:37 +0000 (14:17 -0800)]
Extend and fix tests for custom heap snapshot.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
856793002
Cr-Commit-Position: refs/heads/master@{#26110}
Michael Achenbach [Fri, 16 Jan 2015 21:56:03 +0000 (22:56 +0100)]
Whitespace change to trigger bots.
Cr-Commit-Position: refs/heads/master@{#26109}
Michael Achenbach [Fri, 16 Jan 2015 20:56:32 +0000 (21:56 +0100)]
Whitespace change to trigger bots.
Cr-Commit-Position: refs/heads/master@{#26108}
machenbach [Fri, 16 Jan 2015 19:17:55 +0000 (11:17 -0800)]
Revert of Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/
856813003/)
Reason for revert:
Revert didn't help.
Original issue's description:
> Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/
828803004/)
>
> Reason for revert:
> Speculative revert to see if win XP recovers. Will reland if not.
>
> Original issue's description:
> > [turbofan] Improve memory layout of Node class.
> >
> > Also gets rid of the reinterpret_cast on this.
> >
> > R=svenpanne@chromium.org
> >
> > Committed: https://crrev.com/
f91e8046fad99365c74ccbb39d42de58398dab57
> > Cr-Commit-Position: refs/heads/master@{#26103}
>
> TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
dc6f34d83650dce8faa3e82e87c050f12732d4b3
> Cr-Commit-Position: refs/heads/master@{#26106}
TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
855723002
Cr-Commit-Position: refs/heads/master@{#26107}
machenbach [Fri, 16 Jan 2015 16:49:58 +0000 (08:49 -0800)]
Revert of [turbofan] Improve memory layout of Node class. (patchset #1 id:1 of https://codereview.chromium.org/
828803004/)
Reason for revert:
Speculative revert to see if win XP recovers. Will reland if not.
Original issue's description:
> [turbofan] Improve memory layout of Node class.
>
> Also gets rid of the reinterpret_cast on this.
>
> R=svenpanne@chromium.org
>
> Committed: https://crrev.com/
f91e8046fad99365c74ccbb39d42de58398dab57
> Cr-Commit-Position: refs/heads/master@{#26103}
TBR=svenpanne@chromium.org,dcarney@chromium.org,bmeurer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
856813003
Cr-Commit-Position: refs/heads/master@{#26106}
mvstanton [Fri, 16 Jan 2015 13:28:22 +0000 (05:28 -0800)]
Vector-based KeyedLoadIC MISS logic needs improvement.
Two issues:
1) We would trace the MISS two times on vector-based KeyedLoadIC
with a string key in MEGAMORPHIC state.
2) There was a confusing asymmetry in the handling of going
GENERIC. This change makes it the same whether
--vector-ics is on or not.
BUG=
Review URL: https://codereview.chromium.org/
839893005
Cr-Commit-Position: refs/heads/master@{#26105}
mstarzinger [Fri, 16 Jan 2015 13:21:59 +0000 (05:21 -0800)]
Remove distinction between DisableTurbofan and DisableCrankshaft.
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
826833004
Cr-Commit-Position: refs/heads/master@{#26104}
bmeurer [Fri, 16 Jan 2015 13:16:32 +0000 (05:16 -0800)]
[turbofan] Improve memory layout of Node class.
Also gets rid of the reinterpret_cast on this.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
828803004
Cr-Commit-Position: refs/heads/master@{#26103}
mstarzinger [Fri, 16 Jan 2015 12:53:24 +0000 (04:53 -0800)]
Enable test coverage for --turbo-deoptimization mode.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
845193004
Cr-Commit-Position: refs/heads/master@{#26102}
mstarzinger [Fri, 16 Jan 2015 12:38:13 +0000 (04:38 -0800)]
First simple implementation of class literals in TurboFan.
R=rossberg@chromium.org,jarin@chromium.org
TEST=cctest/test-run-jsops/ClassLiteral
Review URL: https://codereview.chromium.org/
798873006
Cr-Commit-Position: refs/heads/master@{#26101}
marja.holtta [Fri, 16 Jan 2015 12:01:12 +0000 (04:01 -0800)]
Restore the sanity of AUTHORS. CLA OK.
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
806023003
Cr-Commit-Position: refs/heads/master@{#26100}
Balazs Kilvady [Fri, 16 Jan 2015 11:22:07 +0000 (12:22 +0100)]
MIPS64: fix Make map check in NamedStoreHandlerCompiler::GenerateFieldTypeChecks weak.
BUG=
R=balazs.kilvady@imgtec.com, ulan@chromium.org
Review URL: https://codereview.chromium.org/
854073004
Cr-Commit-Position: refs/heads/master@{#26099}
bmeurer [Fri, 16 Jan 2015 11:04:01 +0000 (03:04 -0800)]
[turbofan] Initial attempt to cleanup Node and related classes.
- Make Node::Inputs and Node::Uses mostly STL compliant.
- Get rid of some pre-C++11 crappiness.
- Start moving unit tests from cctest to unittests.
- TrimInputCount() now tries to reserve inputs slots for
later appending.
- Fix numerous style guide violations.
TEST=cctest,unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
851263002
Cr-Commit-Position: refs/heads/master@{#26098}
dcarney [Fri, 16 Jan 2015 10:59:01 +0000 (02:59 -0800)]
split api call stubs into accessor and function call stubs
BUG=
Review URL: https://codereview.chromium.org/
836093007
Cr-Commit-Position: refs/heads/master@{#26097}
bmeurer [Fri, 16 Jan 2015 10:40:23 +0000 (02:40 -0800)]
Migrate TRACED_FOREACH to C++11.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
851243002
Cr-Commit-Position: refs/heads/master@{#26096}
jochen [Fri, 16 Jan 2015 10:39:16 +0000 (02:39 -0800)]
Add checks to the marking queue
Hopefully we'll catch heap corruption earlier where identifying the
object that holds a stale pointer.
Speaking of staleness, also remove old debugging code.
BUG=chromium:128415
R=ulan@chromium.org,hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
843013005
Cr-Commit-Position: refs/heads/master@{#26095}
bmeurer [Fri, 16 Jan 2015 10:36:19 +0000 (02:36 -0800)]
[turbofan] Only mark non-smis as references.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
812033012
Cr-Commit-Position: refs/heads/master@{#26094}
Sven Panne [Fri, 16 Jan 2015 10:12:02 +0000 (11:12 +0100)]
Another attempt to fix regress-crbug-178790.
This time we simply undo the change introduced by the PPC port for
this test. No idea why it should be necessary, and Windows XP
obviously doesn't give us that much stack, anyway.
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
826833003
Cr-Commit-Position: refs/heads/master@{#26093}
Sven Panne [Fri, 16 Jan 2015 09:45:21 +0000 (10:45 +0100)]
PPC aftermath: Fix regress-crbug-178790.
The test fails on XP only, so let's tentatively raise the stack limit more. We probably need to investigate what a tighter limit might be and (more importantly) what the underlying reason for the failure is.
Hopefully 1800kB is enough, we can't test this via try jobs, because we don't have XP try bots. :-/
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
791693005
Cr-Commit-Position: refs/heads/master@{#26092}
Sven Panne [Fri, 16 Jan 2015 07:42:00 +0000 (08:42 +0100)]
Contribution of PowerPC port (continuation of
422063005)
Contribution of PowerPC port (continuation of
422063005). The inital patch
covers the core changes to the common files. Subsequent patches will cover
changes to common files to support AIX and to update the ppc directories so
they are current with the changes in the rest of the project.
This is based off of the GitHub repository
https://github.com/andrewlow/v8ppc
BUG=
R=svenpanne@chromium.org, danno@chromium.org, sevnpanne@chromium.org
Review URL: https://codereview.chromium.org/
817143002
Cr-Commit-Position: refs/heads/master@{#26091}
cdai2 [Fri, 16 Jan 2015 05:24:24 +0000 (13:24 +0800)]
X87: ES6 computed property names
port
74e38e34b3caecfb660c3ed1336a58c551215793.
original commit message:
This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and classes.
This is a revert of the revert,
7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba.
BUG=
R=weiliang.lin@intel.com
Review URL: https://codereview.chromium.org/
825593004
Cr-Commit-Position: refs/heads/master@{#26090}
deftly [Fri, 16 Jan 2015 05:07:10 +0000 (21:07 -0800)]
fix defines for openbsd - build fails without them:
Original version from robert@openbsd.org with modification from myself
BUG=
Review URL: https://codereview.chromium.org/
856553002
Cr-Commit-Position: refs/heads/master@{#26089}
paul.lind [Fri, 16 Jan 2015 04:42:30 +0000 (20:42 -0800)]
MIPS: ES6 computed property names.
Port:
74e38e34b3caecfb660c3ed1336a58c551215793
Original commit message:
This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.
This is a revert of the revert,
7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba.
BUG=v8:3754
LOG=Y
Review URL: https://codereview.chromium.org/
829913005
Cr-Commit-Position: refs/heads/master@{#26088}
v8-autoroll [Fri, 16 Jan 2015 04:41:20 +0000 (20:41 -0800)]
Update V8 DEPS.
Rolling v8/build/gyp to
194ec65a55edf24c1976d4265f57e8c90ef5bb2f
Rolling v8/tools/clang to
790f3b26cdce99c8e5751893a18134afd0202ed0
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
814833012
Cr-Commit-Position: refs/heads/master@{#26087}
arv [Fri, 16 Jan 2015 00:20:00 +0000 (16:20 -0800)]
Computed property names: Enable test on windows again
Enable test on windows again and disable the problematic lines only.
BUG=v8:3815
LOG=N
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
850773004
Cr-Commit-Position: refs/heads/master@{#26086}
Erik Arvidsson [Thu, 15 Jan 2015 20:51:22 +0000 (15:51 -0500)]
Skip computed property name test on Windows
BUG=v8:3815
LOG=N
TBR=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
854903002
Cr-Commit-Position: refs/heads/master@{#26085}
arv [Thu, 15 Jan 2015 20:02:20 +0000 (12:02 -0800)]
ES6 computed property names
This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.
This is a revert of the revert,
7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba.
BUG=v8:3754
LOG=Y
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
798243004
Cr-Commit-Position: refs/heads/master@{#26084}
adamk [Thu, 15 Jan 2015 19:18:05 +0000 (11:18 -0800)]
Remove dead TargetCollector code from the parser
This also simplifies target_stack_ and tightens up the types of nodes
that can appear in it.
Best I can tell, this code has been dead since
https://code.google.com/p/v8/source/detail?r=7542
Review URL: https://codereview.chromium.org/
850093004
Cr-Commit-Position: refs/heads/master@{#26083}
bmeurer [Thu, 15 Jan 2015 17:08:41 +0000 (09:08 -0800)]
[turbofan] Improve AstGraphBuilder::BuildToBoolean() for heap constants.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
852963004
Cr-Commit-Position: refs/heads/master@{#26082}
bmeurer [Thu, 15 Jan 2015 15:29:31 +0000 (07:29 -0800)]
Revert of [turbofan] Make Factory::NewNumber() always return the minus_zero_value. (patchset #1 id:1 of https://codereview.chromium.org/
838263006/)
Reason for revert:
Breaks the tree
Original issue's description:
> [turbofan] Make Factory::NewNumber() always return the minus_zero_value.
>
> TEST=unittests
> R=mstarzinger@chromium.org, dcarney@chromium.org
>
> Committed: https://crrev.com/
55b3e268b2895e2c09230d39669a75b6ab4e7e4d
> Cr-Commit-Position: refs/heads/master@{#26080}
TBR=dcarney@chromium.org,mstarzinger@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
853683009
Cr-Commit-Position: refs/heads/master@{#26081}
Benedikt Meurer [Thu, 15 Jan 2015 15:09:50 +0000 (16:09 +0100)]
[turbofan] Make Factory::NewNumber() always return the minus_zero_value.
TEST=unittests
R=mstarzinger@chromium.org, dcarney@chromium.org
Review URL: https://codereview.chromium.org/
838263006
Cr-Commit-Position: refs/heads/master@{#26080}
bmeurer [Thu, 15 Jan 2015 15:07:29 +0000 (07:07 -0800)]
[turbofan] Turn IrOpcode::IsXXX() into range checks.
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
807573004
Cr-Commit-Position: refs/heads/master@{#26079}
bmeurer [Thu, 15 Jan 2015 13:26:40 +0000 (05:26 -0800)]
Revert of [turbofan] Use PlainPrimitiveToNumber whenever possible. (patchset #1 id:1 of https://codereview.chromium.org/
852763002/)
Reason for revert:
Tanks performance of SQLite and towers.c.
Original issue's description:
> [turbofan] Use PlainPrimitiveToNumber whenever possible.
>
> TEST=cctest,unittests
> R=jarin@chromium.org
>
> Committed: https://crrev.com/
1a5db24e6bf831e61e3f4aa0c252f77e48c3689c
> Cr-Commit-Position: refs/heads/master@{#26071}
TBR=jarin@chromium.org,dcarney@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
852153003
Cr-Commit-Position: refs/heads/master@{#26078}
marja [Thu, 15 Jan 2015 13:10:01 +0000 (05:10 -0800)]
Check author of a CL against the AUTHORS file.
The code is copied from Chromium presubmit.
BUG=
Review URL: https://codereview.chromium.org/
837503003
Cr-Commit-Position: refs/heads/master@{#26077}
mvstanton [Thu, 15 Jan 2015 12:52:33 +0000 (04:52 -0800)]
Vector-based LoadICs need to handle Smi receivers.
The MISS handler was being called when the receiver was a Smi, instead,
we should recognize the case and use the heap number map.
BUG=
Review URL: https://codereview.chromium.org/
854623002
Cr-Commit-Position: refs/heads/master@{#26076}
mstarzinger [Thu, 15 Jan 2015 12:47:53 +0000 (04:47 -0800)]
Remove redundant test expectation from mjsunit.
R=jkummerow@chromium.org
TEST=mjsunit/nans
Review URL: https://codereview.chromium.org/
850303002
Cr-Commit-Position: refs/heads/master@{#26075}
dcarney [Thu, 15 Jan 2015 12:17:23 +0000 (04:17 -0800)]
[turbofan] add flag for register allocation verification
BUG=
Review URL: https://codereview.chromium.org/
798873008
Cr-Commit-Position: refs/heads/master@{#26074}
Yang Guo [Thu, 15 Jan 2015 11:48:57 +0000 (12:48 +0100)]
Fix number-string cache test case.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/
843913008
Cr-Commit-Position: refs/heads/master@{#26073}
yangguo [Thu, 15 Jan 2015 11:22:04 +0000 (03:22 -0800)]
Fix remaining issues in the custom snapshot.
Math functions:
Some Math functions require typed arrays for their implementation. The embedded
script may call those Math functions. The serializer needs to deal with this.
Added assertion to make sure no other typed array is created when snapshotting.
Number-string cache:
We assume that the initial snapshot does not expand the number-string cache.
This is no longer true for custom heap snapshots.
Bound functions:
Bound functions store the bound arguments in a COW fixed array, including the
bindee function. COW arrays are serialized into the startup snapshot and
referenced in the partial snapshot via partial snapshot cache. However, the
bindee function is context-dependent and must not be part of the startup
snapshot. There is no need for bound functions to use a COW array though.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
851073002
Cr-Commit-Position: refs/heads/master@{#26072}
bmeurer [Thu, 15 Jan 2015 09:49:14 +0000 (01:49 -0800)]
[turbofan] Use PlainPrimitiveToNumber whenever possible.
TEST=cctest,unittests
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
852763002
Cr-Commit-Position: refs/heads/master@{#26071}
ulan [Thu, 15 Jan 2015 09:43:25 +0000 (01:43 -0800)]
Make map check in NamedStoreHandlerCompiler::GenerateFieldTypeChecks weak.
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
853713002
Cr-Commit-Position: refs/heads/master@{#26070}
dcarney [Thu, 15 Jan 2015 09:05:52 +0000 (01:05 -0800)]
Reland "[turbofan] simplify gap ordering"
BUG=
Review URL: https://codereview.chromium.org/
854703002
Cr-Commit-Position: refs/heads/master@{#26069}
dcarney [Thu, 15 Jan 2015 08:55:51 +0000 (00:55 -0800)]
add register allocator regression test
BUG=
Review URL: https://codereview.chromium.org/
852633002
Cr-Commit-Position: refs/heads/master@{#26068}
machenbach [Thu, 15 Jan 2015 08:01:03 +0000 (00:01 -0800)]
Revert of Auto-generate v8 version based on tags. (patchset #5 id:80001 of https://codereview.chromium.org/
797503007/)
Reason for revert:
Blocks roll on android_aosp:
https://codereview.chromium.org/
851953005/
Original issue's description:
> Auto-generate v8 version based on tags.
>
> BUG=chromium:446166
> LOG=y
>
> Committed: https://crrev.com/
b301b85be895c6fcd1edfe2fd1e60b5abd0ac64d
> Cr-Commit-Position: refs/heads/master@{#26062}
TBR=jochen@chromium.org,jkummerow@chromium.org,tandrii@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:446166
Review URL: https://codereview.chromium.org/
850263002
Cr-Commit-Position: refs/heads/master@{#26067}
baptiste.afsa [Thu, 15 Jan 2015 06:30:51 +0000 (22:30 -0800)]
[turbofan] Allow 0.0 as immediate for floating-point comparison on arm/arm64.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
850073002
Cr-Commit-Position: refs/heads/master@{#26066}
v8-autoroll [Thu, 15 Jan 2015 06:29:40 +0000 (22:29 -0800)]
Update V8 DEPS.
Rolling v8/build/gyp to
789a019a832029f9a6f8d906a4bcee4736eabc90
Rolling v8/testing/gtest to
be1868139ffe0ccd0e8e3b37292b84c821d9c8ad
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
850223003
Cr-Commit-Position: refs/heads/master@{#26065}
balazs.kilvady [Wed, 14 Jan 2015 20:39:44 +0000 (12:39 -0800)]
MIPS: Fix 'MIPS: Fix after 'Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs''.'
Fix
30f2578ca2829a5c9b8952df20fd39bf7c99ea30
BUG=
Review URL: https://codereview.chromium.org/
846423002
Cr-Commit-Position: refs/heads/master@{#26064}
Ben L. Titzer [Wed, 14 Jan 2015 17:06:26 +0000 (18:06 +0100)]
[turbofan] Fix corner case in loop analysis.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
852783002
Cr-Commit-Position: refs/heads/master@{#26063}
machenbach [Wed, 14 Jan 2015 16:43:24 +0000 (08:43 -0800)]
Auto-generate v8 version based on tags.
BUG=chromium:446166
LOG=y
Review URL: https://codereview.chromium.org/
797503007
Cr-Commit-Position: refs/heads/master@{#26062}
yangguo [Wed, 14 Jan 2015 16:42:15 +0000 (08:42 -0800)]
Correctly reference global proxy in the partial snapshot.
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
853493003
Cr-Commit-Position: refs/heads/master@{#26061}
mstarzinger [Wed, 14 Jan 2015 15:24:20 +0000 (07:24 -0800)]
First simple implementation of for-of in TurboFan.
R=rossberg@chromium.org
TEST=cctest/test-run-jsbranches/ForOfContinueStatement
Review URL: https://codereview.chromium.org/
850803002
Cr-Commit-Position: refs/heads/master@{#26060}
yangguo [Wed, 14 Jan 2015 15:22:40 +0000 (07:22 -0800)]
Introduce new compile histogram that includes parsing/caching.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
851953003
Cr-Commit-Position: refs/heads/master@{#26059}
jochen [Wed, 14 Jan 2015 14:43:58 +0000 (06:43 -0800)]
Remove support for signatures with arguments
Support for it is slow and difficult to implement, and it's not used in
Blink. An embedder that uses this feature will have to check the
argument types itself.
BUG=none
R=dcarney@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
848173002
Cr-Commit-Position: refs/heads/master@{#26058}
fedor.indutny [Wed, 14 Jan 2015 14:35:24 +0000 (06:35 -0800)]
src: fix build on freebsd
BUG=
R=danno
Review URL: https://codereview.chromium.org/
839053004
Cr-Commit-Position: refs/heads/master@{#26057}
bmeurer [Wed, 14 Jan 2015 13:56:55 +0000 (05:56 -0800)]
Add proper support for proxies to HType.
TEST=mjsunit/regress/regress-crbug-448730
BUG=chromium:448730
LOG=y
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
847373002
Cr-Commit-Position: refs/heads/master@{#26056}
Benedikt Meurer [Wed, 14 Jan 2015 13:49:35 +0000 (14:49 +0100)]
Remove stray + character.
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/
847383002
Cr-Commit-Position: refs/heads/master@{#26055}
marja [Wed, 14 Jan 2015 13:23:36 +0000 (05:23 -0800)]
Saner AUTHORS, part 2: Adding AUTHORS based on "Patch from" / "Patch by" lines.
Notes:
- All the added authors have signed the CLA.
- Updated 2 AUTHORS lines to match the e-mail addresses used for signing the CLA.
- In addition, checked that all authors in the AUTHORS file after this change
have signed the CLA.
- Whenever it was possible to guess, based on the e-mail address, that the
contribution was made under a corporate CLA, added the company and the
wildcard instead of the individual.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/
832083004
Cr-Commit-Position: refs/heads/master@{#26054}
jarin [Wed, 14 Jan 2015 13:09:20 +0000 (05:09 -0800)]
[turbofan] Allow deoptimization for JSToNumber operator.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
841443004
Cr-Commit-Position: refs/heads/master@{#26053}
jochen [Wed, 14 Jan 2015 12:48:29 +0000 (04:48 -0800)]
Update gyp files to guarantee proper recreation when changing deps
Also make sure that x86_64 is mapped to x64 as target arch
R=machenbach@chromium.org
LOG=n
BUG=none
Review URL: https://codereview.chromium.org/
846363002
Cr-Commit-Position: refs/heads/master@{#26052}
bmeurer [Wed, 14 Jan 2015 12:06:41 +0000 (04:06 -0800)]
[turbofan] Fix truncation/representation sloppiness wrt. bool/bit.
TEST=cctest,mjsunit,unittests
BUG=v8:3812
LOG=y
Review URL: https://codereview.chromium.org/
850013003
Cr-Commit-Position: refs/heads/master@{#26051}
dcarney [Wed, 14 Jan 2015 11:52:24 +0000 (03:52 -0800)]
Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/
833563004/)
Reason for revert:
This is now really blocking the roll. I believe it's just missing
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
in the d8 config but I have no way to check.
Original issue's description:
> Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/
838983002/)
>
> Reason for revert:
> Relanding because this is not actually blocking the roll.
>
> Original issue's description:
> > Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/
834113005/)
> >
> > Reason for revert:
> > V8 roll fails due to this change. (see https://codereview.chromium.org/
843673003/)
> >
> > Original issue's description:
> > > Add d8 target to the GN build.
> > >
> > > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions.
> > >
> > > Committed: https://crrev.com/
36383f08c1f692ea797d54a27d7c6b3d3d53b440
> > > Cr-Commit-Position: refs/heads/master@{#25984}
> >
> > TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://crrev.com/
ef50fdfdb05e1a3a3822962f5235b804218a5f4e
> > Cr-Commit-Position: refs/heads/master@{#25985}
>
> TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
ebf3c34fb91b4b61f5c32383a115214c516ab5b0
> Cr-Commit-Position: refs/heads/master@{#25996}
TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
810493004
Cr-Commit-Position: refs/heads/master@{#26050}
yangguo [Wed, 14 Jan 2015 11:06:38 +0000 (03:06 -0800)]
Store embed-script flag as metadata into snapshot blob.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
848023002
Cr-Commit-Position: refs/heads/master@{#26049}
bmeurer [Wed, 14 Jan 2015 09:06:50 +0000 (01:06 -0800)]
Revert of [turbofan] Improve typed lowering of JSBitwiseAnd. (patchset #1 id:1 of https://codereview.chromium.org/
811653004/)
Reason for revert:
Breaks SQLite
Original issue's description:
> [turbofan] Improve typed lowering of JSBitwiseAnd.
>
> TEST=unittests
> R=jarin@chromium.org
>
> Committed: https://crrev.com/
284e1108182995abe85f580bc813d26491642b8c
> Cr-Commit-Position: refs/heads/master@{#26046}
TBR=jarin@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
795833006
Cr-Commit-Position: refs/heads/master@{#26048}
Benedikt Meurer [Wed, 14 Jan 2015 07:56:19 +0000 (08:56 +0100)]
[turbofan] Index parameter to StoreWriteBarrier is word size.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
818173004
Cr-Commit-Position: refs/heads/master@{#26047}
Benedikt Meurer [Wed, 14 Jan 2015 07:39:58 +0000 (08:39 +0100)]
[turbofan] Improve typed lowering of JSBitwiseAnd.
TEST=unittests
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
811653004
Cr-Commit-Position: refs/heads/master@{#26046}
balazs.kilvady [Tue, 13 Jan 2015 20:27:55 +0000 (12:27 -0800)]
MIPS: [turbofan] Improve code generation for unordered comparisons.
Port
c24220c0c14b60e6c6d7383b7d9c287086050afb
TEST=cctest,unittests
BUG=
Review URL: https://codereview.chromium.org/
850733004
Cr-Commit-Position: refs/heads/master@{#26045}
verwaest [Tue, 13 Jan 2015 18:05:35 +0000 (10:05 -0800)]
Reduce number of deopts caused by ForceDelete.
BUG=
Review URL: https://codereview.chromium.org/
845403002
Cr-Commit-Position: refs/heads/master@{#26044}
Andy Wingo [Tue, 13 Jan 2015 14:36:50 +0000 (15:36 +0100)]
AbortOptimization, RetryOptimization preserve first bailout reason
The current logic appears to have been introduced in
https://codereview.chromium.org/
596783002.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
836033005
Cr-Commit-Position: refs/heads/master@{#26043}
mstarzinger [Tue, 13 Jan 2015 13:38:41 +0000 (05:38 -0800)]
Make UBSan happy about OpParameter casts.
R=svenpanne@chromium.org
BUG=chromium:448141
LOG=N
Review URL: https://codereview.chromium.org/
847093002
Cr-Commit-Position: refs/heads/master@{#26042}
chunyang.dai [Tue, 13 Jan 2015 13:12:27 +0000 (05:12 -0800)]
Fix the compilation error for turbofan unsupported platform.
Fix the compilation error for turbofan unsupported platform. The Linkage::GetOsrValuePosition()
function is implemented in linkage-impl.h. And this file is included by different platform specific
file separately. This leads to compilation error for turbofan unsupported platform.
The fix is adding one dummy implementation in linkage.cc.
BUG=
Review URL: https://codereview.chromium.org/
848873002
Cr-Commit-Position: refs/heads/master@{#26041}
bmeurer [Tue, 13 Jan 2015 13:02:28 +0000 (05:02 -0800)]
[turbofan] Reduce Word32And masking with shifted inputs.
TEST=unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
847113002
Cr-Commit-Position: refs/heads/master@{#26040}
marja [Tue, 13 Jan 2015 11:58:37 +0000 (03:58 -0800)]
Saner AUTHORS, part 1: Corporate CLLAs and wildcards.
Updating AUTHORS for companies who have signed CCLA.
Changes:
- Added wildcard rules for company e-mail addresses
- Removed individual e-mail addresses for contributors who are under a corporate
CLLA (the copyright holder in this case is the company, not the individual
authors). Domains affected by this change: intel.com, arm.com, codeaurora.org.
In addition, added a wildcard rule for Chromium (which was not previously
listed at all).
R=danno
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
850653003
Cr-Commit-Position: refs/heads/master@{#26039}
bmeurer [Tue, 13 Jan 2015 11:02:40 +0000 (03:02 -0800)]
[turbofan] Add PlainPrimitiveToNumber simplified operator.
TEST=unittests
Review URL: https://codereview.chromium.org/
845333002
Cr-Commit-Position: refs/heads/master@{#26038}
Sven Panne [Tue, 13 Jan 2015 10:52:29 +0000 (11:52 +0100)]
Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type)
We could use BoolToInt consistently, but for now let's just fix the warnings.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
825913005
Cr-Commit-Position: refs/heads/master@{#26037}
bmeurer [Tue, 13 Jan 2015 10:01:06 +0000 (02:01 -0800)]
[turbofan] Avoid expensive fixup for Uint32Div if divisor is even.
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
840813008
Cr-Commit-Position: refs/heads/master@{#26036}
yangguo [Tue, 13 Jan 2015 08:48:00 +0000 (00:48 -0800)]
Update references to global object after deserializing context.
R=jochen@chromium.org
TEST=test-serialize/CustomContext{Des,S}erialization
Also test by
- make ia32.debug embedscript=<full path to mjsunit.js>
- d8 -e "assertDoesNotThrow('print(1)')"
Review URL: https://codereview.chromium.org/
846023002
Cr-Commit-Position: refs/heads/master@{#26035}
bmeurer [Tue, 13 Jan 2015 08:41:52 +0000 (00:41 -0800)]
[turbofan] Improve code generation for unordered comparisons.
TEST=cctest,unittests
Review URL: https://codereview.chromium.org/
850653002
Cr-Commit-Position: refs/heads/master@{#26034}
jarin [Tue, 13 Jan 2015 08:40:39 +0000 (00:40 -0800)]
[turbofan] Add missing deopt.
BUG=chromium:447567
LOG=n
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
809463005
Cr-Commit-Position: refs/heads/master@{#26033}
svenpanne [Tue, 13 Jan 2015 08:36:53 +0000 (00:36 -0800)]
Avoid MSVC's C6282 warning (assignment of constant in Boolean context).
By courtesy of /analyze... :-}
Review URL: https://codereview.chromium.org/
846223002
Cr-Commit-Position: refs/heads/master@{#26032}
v8-autoroll [Tue, 13 Jan 2015 04:22:39 +0000 (20:22 -0800)]
Update V8 DEPS.
Rolling v8/tools/clang to
a4a0b2db20ba74e9d928be13ff701b244cfdd0c2
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
847043002
Cr-Commit-Position: refs/heads/master@{#26031}
marja [Mon, 12 Jan 2015 17:31:47 +0000 (09:31 -0800)]
CompleteParserRecorder: Don't do zero-sized allocations.
Instead, we should use Collector::kMinCapacity.
R=jochen@chromium.org
BUG=v8:3727
LOG=N
Review URL: https://codereview.chromium.org/
847823002
Cr-Commit-Position: refs/heads/master@{#26030}
yangguo [Mon, 12 Jan 2015 15:26:20 +0000 (07:26 -0800)]
Embed custom script into the snapshot.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
845973003
Cr-Commit-Position: refs/heads/master@{#26029}
caitpotter88 [Mon, 12 Jan 2015 15:07:36 +0000 (07:07 -0800)]
Check for octals in template spans only, not expressions
BUG=v8:3806
LOG=N
R=arv@chromium.org, dslomov@chromium.org
Review URL: https://codereview.chromium.org/
808793004
Cr-Commit-Position: refs/heads/master@{#26028}