Grant [Sat, 2 Mar 2019 04:01:53 +0000 (20:01 -0800)]
Make BitOperations public (CoreFX) (dotnet/corefx#35606)
* Add ref assembly class
* Add [CLSCompliantAttribute(false)]
* Change name to System.Numerics.BitOperations
* Move ref to System.Runtime.Extensions
Commit migrated from https://github.com/dotnet/corefx/commit/
0ae011a57253959b79c952219c5fa16389255b7b
Jeremy Kuhne [Sat, 2 Mar 2019 00:58:36 +0000 (16:58 -0800)]
Fix ImplicitMachineConfigHost parameter checking (dotnet/corefx#28894)
* Fix ImplicitMachineConfigHost parameter checking
Don't assume index of the ConfigurationFileMap in params
Fixes: dotnet/corefx#28784
Commit migrated from https://github.com/dotnet/corefx/commit/
63e052c114b3555c5e595348cc92e4dd3cc0e755
John Salem [Sat, 2 Mar 2019 00:22:29 +0000 (16:22 -0800)]
Make Stacktrace Symbols Cache Aware of Unloadability (phase 1) (dotnet/corefx#35541)
Adds GetSourceLineInfo overload that consumes an Assembly, but does not use it. A follow-up change will use that assembly for caching the MetadataReaderProvider.
dotnet/coreclrdotnet/corefx#20179
Commit migrated from https://github.com/dotnet/corefx/commit/
fa2a3ea5be4a317402e47674c9a1286da24c6d68
Geoff Kizer [Fri, 1 Mar 2019 23:40:58 +0000 (15:40 -0800)]
Merge pull request dotnet/corefx#35623 from MarcoRossignoli/fixuseragentparsing
Fix bug: UserAgent malformed parsing
Commit migrated from https://github.com/dotnet/corefx/commit/
cb54ad963cc655d4c783033a2ab3dc3576d0dc65
Jan Kotas [Fri, 1 Mar 2019 21:59:19 +0000 (13:59 -0800)]
Fix netfx build break
Commit migrated from https://github.com/dotnet/corefx/commit/
524afe84f963b2a87230b19838e72174d4fa90f9
Jan Kotas [Fri, 1 Mar 2019 23:24:44 +0000 (15:24 -0800)]
Cleanup System.Runtime and System.Runtime.Extensions refs (dotnet/corefx#35704)
Commit migrated from https://github.com/dotnet/corefx/commit/
d733469bd423e48ded1a34fad15c062738954437
Marco Rossignoli [Fri, 1 Mar 2019 22:11:29 +0000 (23:11 +0100)]
continue parsing after nested call
Commit migrated from https://github.com/dotnet/corefx/commit/
b2865f5e4dcda0a3745b96d704aebec82ab22d60
Tanner Gooding [Fri, 1 Mar 2019 22:06:35 +0000 (14:06 -0800)]
Adding parsing tests to validate we consider enough significant digits to always round correctly. (dotnet/corefx#35701)
Commit migrated from https://github.com/dotnet/corefx/commit/
34118b74d46129b3095e1b4dbad8441c4db62e33
Santiago Fernandez Madero [Fri, 1 Mar 2019 22:06:14 +0000 (14:06 -0800)]
Add Pull Request Builds documentation (dotnet/corefx#35672)
* Add Pull Request Builds documentation
* PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
f709c1014e9ee854af1945e83219b573d0a46252
Eric StJohn [Fri, 1 Mar 2019 21:40:45 +0000 (13:40 -0800)]
Remove InitTools and ToolsDir (dotnet/corefx#35677)
* Remove buildtools init-tools and various BuildTools specific properties
* Workaround NuGet restore GeneratePathProperty case-sensitivity
See https://github.com/NuGet/Home/issues/7843
Commit migrated from https://github.com/dotnet/corefx/commit/
e7159674bb5bd2ac3688dd0789efb45e5de62299
Viktor Hofer [Fri, 1 Mar 2019 21:39:06 +0000 (22:39 +0100)]
Move dir.traversal.targets to eng (dotnet/corefx#35684)
Commit migrated from https://github.com/dotnet/corefx/commit/
32724ccf66bfdb4a48e8745ca4bc07480d15805a
Jan Kotas [Fri, 1 Mar 2019 21:10:15 +0000 (13:10 -0800)]
Add test to verify that DangerousRelease preserves Marshal.GetLastWin32Error (dotnet/corefx#35612)
Commit migrated from https://github.com/dotnet/corefx/commit/
d6db020cc7c66f95b0695e03b997936b3cf1f610
Eric StJohn [Fri, 1 Mar 2019 18:09:59 +0000 (10:09 -0800)]
Consume optimization data from bar & cleanup standard repo consumption (dotnet/corefx#35675)
* Consume optimization data from bar & cleanup standard repo consumption
* Remove restoresources from optimizationData.depproj
Commit migrated from https://github.com/dotnet/corefx/commit/
6bc5f9e37ae26eb3ceead1a1c0afac81166b3c8c
Stephen Toub [Fri, 1 Mar 2019 18:02:15 +0000 (13:02 -0500)]
Re-enable BeginSendFile tests (dotnet/corefx#35696)
Commit migrated from https://github.com/dotnet/corefx/commit/
560bbb1f5906ea4ff7f9a6888bf8fe083cf94087
Liudmila Molkova [Fri, 1 Mar 2019 17:15:03 +0000 (09:15 -0800)]
Fix minor Activity W3C format issues (dotnet/corefx#35650)
* Fix minor W3C Activity format issues
* undo csproj changes
* review nits
* review: parentSpanId invalid
* add security safe critical attributes, fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
ba5d02d92ecdf5ee902f8e4b348bc0ffd2a34a96
Stephen Toub [Fri, 1 Mar 2019 16:57:55 +0000 (11:57 -0500)]
Fix XmlWriterTraceListenerTests handling of DateTime (dotnet/corefx#35692)
Some of these tests compare a textual date time from an XmlWriterTraceListener (which internally uses DateTime.Now) against a textual date time from a TraceEventCache (which internally uses DateTime.UtcNow). This means that there's a few hour window (depending on time zone) at the transition of every month where the months end up differing and the test fails.
The tests also have a bug in that the format string used is buggy and isn't actually resulting in day and year being included, just month. And further, even if the time zones are fixed, it's still possible but rare that taking the Now at two different moments could straddle a boundary. So, rather than comparing ToStrings, we just compare the DateTimes, albeit with an allowed window.
Commit migrated from https://github.com/dotnet/corefx/commit/
1b80f1e1da2630b8fe877a35c285d9c4ffe9f2ce
Stephen Toub [Fri, 1 Mar 2019 15:38:45 +0000 (10:38 -0500)]
Merge pull request dotnet/corefx#35655 from dotnet/darc-master-
7c963d5e-3797-4b68-9fad-
354784eeb96a
[master] Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
d1d5e038f37bddce4b3a7910b684d9d4936e2a09
Stephen Toub [Fri, 1 Mar 2019 15:38:01 +0000 (10:38 -0500)]
Merge branch 'master' into darc-master-
7c963d5e-3797-4b68-9fad-
354784eeb96a
Commit migrated from https://github.com/dotnet/corefx/commit/
c523e9a012be1a8ab76df474d66ca0be81c606f1
Viktor Hofer [Fri, 1 Mar 2019 14:06:07 +0000 (15:06 +0100)]
Move codeanalysisruleset to src (dotnet/corefx#35687)
Commit migrated from https://github.com/dotnet/corefx/commit/
9940166bff52155600f25f15da13a83c982526d2
Stephen Toub [Thu, 28 Feb 2019 15:57:01 +0000 (10:57 -0500)]
Adapt corefx to recent coreclr changes
Commit migrated from https://github.com/dotnet/corefx/commit/
feb6eb3db7ca0a886f08ecd1eb259e0ae8ca434c
Tom Deseyn [Fri, 1 Mar 2019 12:30:16 +0000 (13:30 +0100)]
TestCheckChildProcessUserAndGroupIdsElevated: handle GetGroups returning the same group several times (dotnet/corefx#35680)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd9e7342508a05782446572baa3353b9a00cf6dd
Viktor Hofer [Fri, 1 Mar 2019 11:14:48 +0000 (12:14 +0100)]
Delete old vssettings in favor of editorconfig (dotnet/corefx#35683)
Commit migrated from https://github.com/dotnet/corefx/commit/
49c86d5fd8120a972d13229e4f36dedfdf6a477c
Levi Broderick [Thu, 14 Feb 2019 01:39:52 +0000 (17:39 -0800)]
Add ref asm + tests for creating Rune instances from surrogates
Commit migrated from https://github.com/dotnet/corefx/commit/
99436aa00c3772f852d8801f4879869df7cf26c8
Stephen Toub [Fri, 1 Mar 2019 01:05:06 +0000 (20:05 -0500)]
Add missing license headers
Add missing license headers, and make the asn.xslt generator do it going forward.
Commit migrated from https://github.com/dotnet/corefx/commit/
5dc8132370532804a5381b90e2ce87d6c52b61f6
Eric StJohn [Fri, 1 Mar 2019 00:41:22 +0000 (16:41 -0800)]
Ensure ZipPackage can handle file lengths over int.MaxValue … (dotnet/corefx#35660)
* Ensure ZipPackage can handle file lengths over int.MaxValue when using FileAccess.Read and FileAccess.Write.
This helps unblock the scenario of using large files with System.IO.Packaging
FileAccess.Write was completely broken before because ZipPackage would create an entry
and immediately delete it, which is disallowed when you're writing an archive. This
was a porting error, the desktop code had this under an else that was incorrectly removed.
Additionally when reading an archive with a large file, accessing the length of the
stream would cause the entire stream to be read into memory uncompressed and
overflow since this used a MemoryStream backed by a int.max-limited managed array.
Instead use the length info from the archive entry.
* Fix new packaging tests on desktop, respond to CR feedback
Desktop does not support FileAccess.Write on Package.Open: it throws when attempting to
create the ZipArchive. It only supports FileAccess.Read or FileAccess.ReadWrite.
Also clean up the test code.
* Code review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
125eac5808fc63bde5c238acdbaba9cac055855e
Tanner Gooding [Fri, 1 Mar 2019 00:28:30 +0000 (16:28 -0800)]
Removing the ExtractVector128 and InsertVector128 APIs that take an address. (dotnet/corefx#35596)
Commit migrated from https://github.com/dotnet/corefx/commit/
2104ad984999fec501cf060e6b6ab7f74c0b0558
Tomas Weinfurt [Fri, 1 Mar 2019 00:18:41 +0000 (16:18 -0800)]
pull in yet another updated Alpine image (dotnet/corefx#35674)
* pull in updated images with LANG set
Commit migrated from https://github.com/dotnet/corefx/commit/
b9710cb25b86ef4da002949df2dee1d63933734d
Viktor Hofer [Thu, 28 Feb 2019 17:55:25 +0000 (18:55 +0100)]
Allow single hyphen arguments in bash build (dotnet/corefx#35628)
* Allow single hyphen arguments in bash build
* Add clean switch
* Darc update from build '
20190228.2'
Commit migrated from https://github.com/dotnet/corefx/commit/
76e08b605f237bffb74283d83241eaadc4e7ce93
Tomas Weinfurt [Thu, 28 Feb 2019 17:13:57 +0000 (09:13 -0800)]
pull in Alpine image with LANG fix (dotnet/corefx#35657)
Commit migrated from https://github.com/dotnet/corefx/commit/
6ff8bf5722ffdb5b1386b062a12f9d59c3adea87
Marco Rossignoli [Thu, 28 Feb 2019 15:13:24 +0000 (16:13 +0100)]
add some tests
Commit migrated from https://github.com/dotnet/corefx/commit/
12fc04b6f8c20d901f9c89a1b8d8a540fa22dd0d
Jeremy Barton [Thu, 28 Feb 2019 11:31:06 +0000 (03:31 -0800)]
Fix the SslStream order of intermediate certificates with long chains (dotnet/corefx#35641)
Commit migrated from https://github.com/dotnet/corefx/commit/
b30e7723c98a6e7da0fa7d6edd4a54643275afad
Aaron Robinson [Thu, 28 Feb 2019 05:50:57 +0000 (21:50 -0800)]
Update LicenseInterop API (dotnet/corefx#35577)
* Clean up the Interop helper API for managed COM server activation via IClassFactory2.
Commit migrated from https://github.com/dotnet/corefx/commit/
bf09f74c8fe5b6094771266e6beeb36e7447b252
Ahson Khan [Thu, 28 Feb 2019 03:41:48 +0000 (19:41 -0800)]
Avoid re-scanning the whole input ROSequence when getting position in Utf8JsonReader (dotnet/corefx#35310)
* Make sure SequencePosition is saved as part of JsonReaderState
* Avoid rescanning whole ROSequence when getting position.
* We don't guarantee the position for invalid JSON.
* Remove isSingleSegment check when getting position and add single
segment tests
* Address feedback: remove else block and add some comments.
Commit migrated from https://github.com/dotnet/corefx/commit/
b85d017ecac090e6966822f159b48e7edfef37ce
Ahson Khan [Thu, 28 Feb 2019 03:39:21 +0000 (19:39 -0800)]
Auto-generate the reference assemblies and separate type forwards (dotnet/corefx#35557)
* Auto-generate the reference assemblies
* Add back type forwards.
* Revert "Add back type forwards."
This reverts commit dotnet/corefx@
3acf74aabb2e3ba90ac7280d541723d13d72c74a.
* Add back TypeForwardedTo in .Forward.cs files
* Add new type forward files to the csproj files
* Add back if-defs and move TestUtilities comment from ref to source
* Remove duplicate definitions, delete unnecessary manual files,
* Fix build breaks
* Add back missing AsyncMethodBuilderAttr to S.Runtime ref
* Fix typo between XmlDocument and XPath.XDocument
* Add type forward fild missed from previous commit
* Fix ECDiffieHellmanCngPublicKey internal ctor for netfx 4.6.1
* Remove "this type was moved to comments" from the type forwards.
* Add back the Xml and Debugger* attributes to Xml.ReaderWriter
* Add back struct layout attributes
* Add back attributes missing (highlighted from api compat)
* Add missing toolbox item attribute in s.data.common.
* Add missing struct layout attributes and remove unnecessary additions
* Add back InterfaceTypeAttribute
Commit migrated from https://github.com/dotnet/corefx/commit/
16689aa0a933517dc45465fc6edb6223222414a6
Tom Deseyn [Thu, 28 Feb 2019 02:55:26 +0000 (03:55 +0100)]
Process: Unix: use groups of ProcessStartInfo.UserName (dotnet/corefx#34961)
* Process: Unix: use groups of ProcessStartInfo.UserName
* PR feedback
* Fix OSX build
* Fix OSX build II
* Fix OSX build III
* Set ngroups to -1 on error
* Handle setgroups EPERM with fallback to process groups
* pal_process: handle zero groups length
This is for completeness, managed code calls this with at least one group: the primary group of the user.
* Remove uid_t and gid_t sizeof asserts
* Determine user ids using 'id' command
* Deal with OSX and musl specifics
* Try to fix OSX TestStartWithNormalUser by handling setgroups EINVAL
* Fix UnauthorizedAccessException for ExceptionFile when RemoteInvoke as sudo
* OSX getgrouplist is not thread safe
* Try to fix Ubuntu 18.10 test failures
* Refactor RunTestAsSudo to use RemoteInvoke child Process checking
* Try to fix OSX 13.10 fails
* Update test for truncated groups
* Extend tests
* Try fix/debug OSX test fail
* Test: special case OSX for getgrouplist truncate
* PR feedback
* Improve groups checking: O(N*M) to O(N*log(M))
Commit migrated from https://github.com/dotnet/corefx/commit/
b10e8d67b260e26f2e47750cf96669e6f48e774d
Tomas Weinfurt [Thu, 28 Feb 2019 00:52:54 +0000 (16:52 -0800)]
pull updated Alpine3.9 image one more time (dotnet/corefx#35639)
Commit migrated from https://github.com/dotnet/corefx/commit/
94322619b200b05dbb9a386db391407f97ebefa2
Jeremy Kuhne [Thu, 28 Feb 2019 00:33:56 +0000 (16:33 -0800)]
Fix advance for single length delimiter (dotnet/corefx#35597)
* Fix advance for single length delimiter
If the delimiter span for TryReadTo was only one character long we weren't advancing past the delimiter if requested. Add regression test.
* Address feedback
* Scan from beginning as well
Commit migrated from https://github.com/dotnet/corefx/commit/
b0bc99d6f7943a8081a84bea23c5542831c9359e
Afsaneh Rafighi [Wed, 27 Feb 2019 20:55:57 +0000 (12:55 -0800)]
update SqlClient Area Owners (dotnet/corefx#35634)
Commit migrated from https://github.com/dotnet/corefx/commit/
5aeccae0ab98af86e56043c1017474b7c05358e0
Tomas Weinfurt [Wed, 27 Feb 2019 19:46:57 +0000 (11:46 -0800)]
update container name (dotnet/corefx#35631)
* pul in updated Alpine39 image
* images no longer published to old place
Commit migrated from https://github.com/dotnet/corefx/commit/
417c3b8a97b29f7c5c1d25d5f7357b387bc5a68b
Tomas Weinfurt [Wed, 27 Feb 2019 17:37:56 +0000 (09:37 -0800)]
pul in updated Alpine39 image (dotnet/corefx#35627)
Commit migrated from https://github.com/dotnet/corefx/commit/
cbb3159d041c4489ced4ef7142a40a86aa54e35f
Stephen Toub [Wed, 27 Feb 2019 15:20:41 +0000 (10:20 -0500)]
Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)"" (dotnet/corefx#35595)
* Revert "Revert "Add another Zip IEnumerable<T> extension method (dotnet/corefx#26582)" (dotnet/corefx#33709)"
This reverts commit dotnet/corefx@
53ae9af48c5c133f4413e76c1469dfe6ccecd926.
* Adapt to ThrowHelper changes
Commit migrated from https://github.com/dotnet/corefx/commit/
720591ab8c213c8f3563db1f06114ec7c8d012bb
Jan Kotas [Wed, 27 Feb 2019 05:59:42 +0000 (21:59 -0800)]
Disable BitOps tests
Commit migrated from https://github.com/dotnet/corefx/commit/
70af5f296f7bfcdd7b7fade082c15cd19d8b29ab
Marco Rossignoli [Wed, 27 Feb 2019 11:00:17 +0000 (12:00 +0100)]
fix UserAgent parsing
Commit migrated from https://github.com/dotnet/corefx/commit/
840d29c05243f5afe31e43e2415d6dce5b3c71fd
Tomas Weinfurt [Wed, 27 Feb 2019 06:41:05 +0000 (22:41 -0800)]
enable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler (dotnet/corefx#35605)
* enable GetAsync_AllowedSSLVersion_Succeeds for SocketHttpHandler and skip Curl on RH6
Commit migrated from https://github.com/dotnet/corefx/commit/
f44142b855330ca9274827a230b8ad9a3ccda357
Ahson Khan [Wed, 27 Feb 2019 03:12:35 +0000 (19:12 -0800)]
Update the IBufferWriter contract definition documentation to be clearer (dotnet/corefx#35554)
* Update the IBufferWriter contract definition docs
* Address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
1da56c2529c8d52bd8f3b1ceb07795379221dc02
Tanner Gooding [Wed, 27 Feb 2019 02:58:22 +0000 (18:58 -0800)]
Adding some formatter tests validating the updated float/double behavior (dotnet/corefx#35567)
* Adding some formatter tests validating the updated float/double behavior
* Adding a regression test for ToString("R") on integral types, asserting it isn't supported
Commit migrated from https://github.com/dotnet/corefx/commit/
54e341c9ba4ea452b098f2ec9dbcf58da7b33ed6
Viktor Hofer [Wed, 27 Feb 2019 01:07:26 +0000 (02:07 +0100)]
Darc update from build '
20190226.3' (dotnet/corefx#35604)
* Darc update from build '
20190226.3'
* Apply TestAllTargets project filter
Commit migrated from https://github.com/dotnet/corefx/commit/
23c06516a29ac94585cee09e82b5ddf57d0cae0e
Eric St. John [Tue, 26 Feb 2019 19:24:31 +0000 (11:24 -0800)]
Allow tests to sign with a different StrongNameKeyId
Before this change all tests are forced to use the Open key.
Now tests can specify TestStrongNameKeyId to control their key.
Commit migrated from https://github.com/dotnet/corefx/commit/
a8fc4418080e66d97f337e7b663a88b047f1e2e0
Eric St. John [Tue, 26 Feb 2019 17:18:18 +0000 (09:18 -0800)]
Use ILAsm/ILDasm that are restored as part of external
Also fixes a test project to build correctly and deletes a checked in binary.
Commit migrated from https://github.com/dotnet/corefx/commit/
733f5bee45d7b1c684dc353a1197ddb718cc4aa9
Tomas Weinfurt [Tue, 26 Feb 2019 23:12:36 +0000 (15:12 -0800)]
collect system info if IPv6 loopback fails to resolve (dotnet/corefx#35581)
* collect system info if IPv6 loopback fails to resolve
* add emply line after } to comply with style
Commit migrated from https://github.com/dotnet/corefx/commit/
77cde697f9ee9941bdc76e02b9481d781790e86a
Tomas Weinfurt [Tue, 26 Feb 2019 23:11:39 +0000 (15:11 -0800)]
improve detection for ReadOnly_FileSystemHelper (dotnet/corefx#35531)
* improve detection for ReadOnly_FileSystemHelper
* feedback from review
* fix bad resolve
Commit migrated from https://github.com/dotnet/corefx/commit/
7d4f25f1f503f91dd680d6e2c4cb556fd4f631e4
Krzysztof Wicher [Tue, 26 Feb 2019 22:23:27 +0000 (14:23 -0800)]
Remove System.IO.Ports.Native from the framework (dotnet/corefx#35598)
Commit migrated from https://github.com/dotnet/corefx/commit/
3bf49dd2a3f136a85bed3cc40e6648ccdef4a3f9
William Godbe [Tue, 26 Feb 2019 21:54:54 +0000 (13:54 -0800)]
Merge pull request dotnet/corefx#35572 from wtgodbe/UpdateStando
[master] Trigger manual DARC update
Commit migrated from https://github.com/dotnet/corefx/commit/
7c37cfbd03d058b966160fdc39cd902ef3b2782c
Essam Almohammadi [Sat, 9 Feb 2019 10:55:56 +0000 (11:55 +0100)]
Add string overloads to DbDataReader.Get*()
Implement dotnet/corefx#31595
Commit migrated from https://github.com/dotnet/corefx/commit/
b30fc2b4ee302e449e3580ae39cb083a76b813c9
wtgodbe [Tue, 26 Feb 2019 00:26:29 +0000 (16:26 -0800)]
Update ApiCompat baselines
Commit migrated from https://github.com/dotnet/corefx/commit/
01ef5e6cbb395709c02436538018d44c61cfdcc8
Vance Morrison [Tue, 26 Feb 2019 15:51:19 +0000 (07:51 -0800)]
Changes to support W3C style IDs and propagation (dotnet/corefx#33207)
* First set of changes to support W3C style IDs and propagation
see https://w3c.github.io/trace-context
This is mostly for discussion purposes.
* Changed UseW3CFormat to be DefaultIdFormat
* Review feedback
* More comments. Small Renames
* Added Sampling Support, Review feedback.
* Added placeholder for SetRecordingDesired
* Separated out the Sampling support into its own PR.
* Remove more sampling support
* Fix IsWC3Id -> IdFormat
* Added Sampling Support, Review feedback.
* Separated out the Sampling support into its own PR.
* Add ForceW3C option.
* Introduce ForceDefaultIdFormat
* Adding SpanId and TraceId support
* Change ulong->long in SpanID (probably temporary)
* Remove undesired file changes
* Fix up reference assembly.
Note complete because of questions about Span<byte>, but closer now.
* Turn on code that used Span<byte>
* Defer setting IDFormat until start.
This insures that the IDFormat property is either unknown or a given value (that never changes from there).
* More implementation, made the interface more uniform.
* Support to avoid using strings whenever possible
Basically Id, SpanId TraceId properties are set lazily and only converted lazily.
* Added some tests
* First round of testing (and bugfixes)
* More testing
* Added Equality operators
* Rename SpanId -> ActivitySpanId TraceId ->ActivityTraceId
* Add Comments
* Fix bad XML comment
* Review feedback
* Change AsBytes -> CopyTo
Lifetime issues prevent returning Span<T> (which is what AsBytes does. Reverting to CopyTo instead.
Also added System.Memory ref in attempt to resolve build errors (that don't reproduce locally).
* Attempt to fix build break in netfx build
* Deal with Verification errors.
* Provide full namespace for SecuritySafeCriticalAttribute
* More securitySafeCritical annotations to fix test failures on desktop
* Another attempt on setting SecuritySafeCritical
* Remove the readonly ref (to avoid perf issue)
* Fix most -buildAllConfigurations issues
* Tentative change to see if testing works if we ignore the older netstandard configs.
* Workaround package cycle involving DiagnosticSource and Memory
* Satisfy dangling System.Memory dangling reference in package tests
* Add notes to remove the workarounds when Unsafe is fixed.
* Review feedback
Uses Utf8 helpers where possible.
Commit migrated from https://github.com/dotnet/corefx/commit/
fa07e4f0a8e564f33ef8e2de86dc9087a53bdf26
Tomas Weinfurt [Tue, 26 Feb 2019 07:02:20 +0000 (23:02 -0800)]
improve Ssl3 detection (dotnet/corefx#35574)
* improve sslv3 detection
* updates to pass all tests
* correct catch
Commit migrated from https://github.com/dotnet/corefx/commit/
0fa22d4b6753c47b6139980255e932341353179e
Jeremy Barton [Tue, 26 Feb 2019 06:02:02 +0000 (22:02 -0800)]
Add doc comments to JsonDocument (and friends)
* Add doc comments to all public members of JsonDocument, JsonElement, JsonProperty, and JsonValueType.
* Add "do not use this" doc comments on all internal members, because of source-package concerns.
* Change JsonElement.TokenType from internal to private because it could.
Commit migrated from https://github.com/dotnet/corefx/commit/
81e9045dca63ccea9b4fe31f8ac3a035b1b1f86d
Tomas Weinfurt [Tue, 26 Feb 2019 05:28:18 +0000 (21:28 -0800)]
disable AllSubscriberStress test on ARM64 untill we get more resources to run it (dotnet/corefx#35575)
Commit migrated from https://github.com/dotnet/corefx/commit/
dedb0f8e93661d13f18c9afcae6c2883b28a2d68
Erhan Atesoglu [Tue, 26 Feb 2019 03:05:07 +0000 (19:05 -0800)]
Removed GetRootLength Helper Function from PathInternalWindows.cs (dotnet/corefx#35568)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b262c30165fe7c39d9fb582495c76c704c0a0d6
Filip Navara [Tue, 26 Feb 2019 02:47:18 +0000 (03:47 +0100)]
Add temporary resources and copy of Thread implementation to unblock merge of shared CoreLib (dotnet/corefx#35553)
Commit migrated from https://github.com/dotnet/corefx/commit/
facf731986511cb0cc0ceb181b6c7d846afa0743
Adeel Mujahid [Tue, 26 Feb 2019 02:44:03 +0000 (04:44 +0200)]
Use NativeLibrary.TryLoad and prefer RTLD_LAZY over RTLD_NOW (dotnet/corefx#35548)
* Use NativeLibrary.TryLoad in ODBC test
* Use RTLD_LAZY instead of RTLD_NOW
* Add missing using statement
* More RTLD_NOW -> RTLD_LAZY
* Remove unused RTLD_NOW constant
* Use NativeLibrary.TryLoad instead of P/Invoke dlopen
* Inline method body in property
* Add fallback for netcoreapp2x and below
* Reduce visibility of const
Commit migrated from https://github.com/dotnet/corefx/commit/
863b9bff2d77669b426b52dcb1bf7ba9246729e0
Anirudh Agnihotry [Sun, 24 Feb 2019 22:31:51 +0000 (14:31 -0800)]
Removing restriction of first 8 character being different from lognames (dotnet/corefx#35532)
Commit migrated from https://github.com/dotnet/corefx/commit/
26b932e3c56702382d13ece010b300d3181d2891
Stephen Toub [Sat, 23 Feb 2019 10:00:31 +0000 (05:00 -0500)]
Remove Task{CompletionSource} allocations from Http2Stream (dotnet/corefx#35522)
* Remove Task{CompletionSource} allocations from Http2Stream
This change makes the Http2Stream instance itself awaitable via ValueTask, such that we don't need to allocate any additional TaskCompletionSource or Task objects for such internal await'ing, regardless of how many times the Http2Connection or Http2ReadStream needs to wait for headers or response data to arrive.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
aacff5212204ee54e3b3e0172fcf364c3fe253e3
Jan Kotas [Sat, 23 Feb 2019 05:07:03 +0000 (21:07 -0800)]
Use product version in RuntimeInformation.FrameworkDescription (dotnet/corefx#35516)
* Use product version in RuntimeInformation.FrameworkDescription
* Include FrameworkDescription in the Assert
* Strip the git hash in the fallback
Commit migrated from https://github.com/dotnet/corefx/commit/
db95b37fa3218e20ff639b232a41202b24ddcb39
Erhan Atesoglu [Sat, 23 Feb 2019 02:53:24 +0000 (18:53 -0800)]
Removed "Argument_InvalidPathChars" Resource String (dotnet/corefx#35534)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd52650a7ba05b16c5cabf37cb69511cbccc35b9
Jeremy Barton [Sat, 23 Feb 2019 02:37:22 +0000 (18:37 -0800)]
Add #define alias for local_X509_STORE_CTX_get0_store for RHEL6 build
Commit migrated from https://github.com/dotnet/corefx/commit/
eaafb6fd980f161c94c16b7036a73ed3df5871ae
Eric StJohn [Sat, 23 Feb 2019 02:20:16 +0000 (18:20 -0800)]
Make System.Runtime.CompilerServices.Unsafe inbox (dotnet/corefx#35526)
* Make System.Runtime.CompilerServices.Unsafe inbox
Fix a couple places where we wanted to use it from other inbox assemblies but couldn't.
Unsafe remains as a package and newer versions of Unsafe will replace the inbox Version,
permitting us to add API over time.
* Update Rune tests to use TryEncodeToUtf8Bytes directly
* Add temporary suppression to package tests
Commit migrated from https://github.com/dotnet/corefx/commit/
9074d9f5b513a95b7eac9ba1112069c29230d1d2
Santiago Fernandez Madero [Sat, 23 Feb 2019 01:00:31 +0000 (17:00 -0800)]
Disable azure pipelines reporter for official builds (dotnet/corefx#35540)
Commit migrated from https://github.com/dotnet/corefx/commit/
a41629b2604a9dc92305f4df067898a377f72b17
Matt Galbraith [Fri, 22 Feb 2019 22:20:15 +0000 (14:20 -0800)]
Merge pull request dotnet/corefx#35533 from dotnet/Add-Alpine-3-9
Adding Alpine 3.9 Runs to official
Commit migrated from https://github.com/dotnet/corefx/commit/
dc6dfe11752a00136df36b5c62f6b891322068e6
Matt Galbraith [Fri, 22 Feb 2019 22:07:50 +0000 (14:07 -0800)]
Adding Alpine 3.9 Runs to official
There may be a little more work to be done here for displaying what actually ran, but I believe we're ready to use the new Helix Client docker work.
Commit migrated from https://github.com/dotnet/corefx/commit/
eeaeb1a11f244dc13e827decd3ab0c810089f747
Jeremy Barton [Fri, 22 Feb 2019 20:51:22 +0000 (12:51 -0800)]
Add support for OCSP on Linux, overhaul Linux X509Chain processing
This change moves a lot of the chain building work from managed code into the native shim, largely to cut down on the number of P/Invokes required to set up the chain builder.
Once a chain has been built to a point where only one issuer will be considered, if revocation was requested and a CRL is not available, attempt an OCSP request if the certificate indicates the CA has an OCSP endpoint.
Based on CA/Browser Forum's requirements this expects CRL for all intermediates and only attempts OCSP for the end-entity certificate.
"Conforming" OCSP requests are opportunistically cached on the basis that local filesystem re-reads are more reliable (and faster) than doing a live request to the CA.
Commit migrated from https://github.com/dotnet/corefx/commit/
0fbbb68a3f7be82d26e4b2dff5c25c192e3a2023
Stephen Toub [Fri, 22 Feb 2019 18:51:14 +0000 (13:51 -0500)]
Avoid some 1st-chance exceptions on Linux in GetAllNetworkInterfaces (dotnet/corefx#35523)
Commit migrated from https://github.com/dotnet/corefx/commit/
cbf462058cf0aa96c171f84604e575be9f41830a
Marco Rossignoli [Fri, 22 Feb 2019 13:57:42 +0000 (14:57 +0100)]
Fix bug: Process.OutputDataReceived not firing (dotnet/corefx#33974)
* fix bug
* address PR feedback
* remove flaky assertions
* remove test for Uap
* update test
* nit: remove empty line
* add test to outerloop
* try deterministic test with fileSystem lock
* update test
* update test
* add cleanup to test
* update test
* update test comment
* refactor test
* address PR feedback
* address PR feedback
* Address PR feedback
* update tests
* try anonymous pipe
* remove FileSystemLock
* fix test
* try tu run on UAP
* try to run on UAP
* updates
* uap experiment
* uap experiment
* uap experiment
* remove uap from tests
* updates
* update tests
* fix test name
* avoid uap compile error
* apply Stephen steps
* Update ProcessStreamReadTests.cs
Add comment
* update comment
Commit migrated from https://github.com/dotnet/corefx/commit/
7817a109400b5b22c02ae6667706cda8a7f3d168
Jan Kotas [Fri, 22 Feb 2019 10:55:41 +0000 (02:55 -0800)]
Update Environment.Version test to not expect hardcoded version (dotnet/corefx#35512)
* Update Environment.Version test to not expect hardcoded version
Contributes to https://github.com/dotnet/corefx/issues/31099
* Fix nit
Commit migrated from https://github.com/dotnet/corefx/commit/
d8473a7bab7cb9b26344281913c488b7475644bb
Stephen Toub [Fri, 22 Feb 2019 03:16:04 +0000 (22:16 -0500)]
Use a pooled buffer in BrotliStream (dotnet/corefx#35492)
* Use a pooled buffer in BrotliStream
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
bca44089343cf14cffd3cb0982b7e209692f6731
David Fowler [Fri, 22 Feb 2019 03:15:41 +0000 (19:15 -0800)]
Reduce the amount of exceptions throw in Advance (dotnet/corefx#35509)
* Reduce the amount of exceptions throw in Advance
- Advance checks for 3 error conditions today, no writing head (no body called GetMemory()), bytesWritten being a positive number and that Advance is called with a bytesWritten between 0 and _writingMemory.Length. Instead, just unify those into a single ArgumentOutOfRangeException.
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
498a7e169a452d3e53a061c1433aea637506a14a
Santiago Fernandez Madero [Fri, 22 Feb 2019 02:32:07 +0000 (18:32 -0800)]
Restore optional tooling for windows to use optimization data (dotnet/corefx#35433)
Commit migrated from https://github.com/dotnet/corefx/commit/
c839a4d5b1cb8889e6251d47aed3fdfd098586ef
Stephen Toub [Fri, 22 Feb 2019 02:17:11 +0000 (21:17 -0500)]
Reduce PLINQ outerloop test execution time (dotnet/corefx#35510)
Our PLINQ test suite has a ridiculously large number of test cases, in particular in outerloop (~200K), and as such it takes a long time to run. In outerloop CI legs on some machines we're currently bumping up against time limits, causing spurious failures. While more may be needed, these two small tweaks shrink execution time on my machine by 50%.
Commit migrated from https://github.com/dotnet/corefx/commit/
bec9e1ec77306f339fd2b34d0e9b6013b5555c39
Jan Kotas [Fri, 22 Feb 2019 02:08:30 +0000 (18:08 -0800)]
Use the .NET Core product version for informational version description (dotnet/corefx#35436)
* Use the .NET Core product version for informational version description
The 4.X.Y.Z versions that we use for file and assembly versions are confusing. We can make the situation better by including the official .NET Core version in the informational assembly version description at least.
* Move ProductVersion to Versions.props
* Move Packaging.props to later
Commit migrated from https://github.com/dotnet/corefx/commit/
0577135efa86fec33f1cc9bb10808d31e302a94f
Mike McLaughlin [Fri, 22 Feb 2019 00:43:56 +0000 (16:43 -0800)]
Publish corefx test assets (dotnet/corefx#35473)
* Publish corefx test assets
So coreclr and other repos can run the corefx tests.
New step to publish the test zip files to dotnet-core blob storage.
Publishes the build manifest from above to blob storage path:
https://dotnetfeed.blob.core.windows.net/dotnet-core/corefx-tests/$(Version)/$(TargetOS).$(ArchGroup)/$(TargetGroup)/corefx-test-assets.xml
Declare DotNet-Blob-Feed only in official builds
* Code review feedback.
The blob path should NOT be Normalized.
* WIP
Commit migrated from https://github.com/dotnet/corefx/commit/
bfb495d39e2d7b5d7cc0b571ed504670b2faa68c
Geoff Kizer [Fri, 22 Feb 2019 00:03:00 +0000 (16:03 -0800)]
Merge pull request dotnet/corefx#35485 from geoffkizer/http2streamstate
add StreamState and rework HTTP2 stream state handling
Commit migrated from https://github.com/dotnet/corefx/commit/
cab8d6bbfe49c7571f682234622f4ea3bfcf5010
David Fowler [Thu, 21 Feb 2019 23:31:23 +0000 (15:31 -0800)]
Override WriteAsync on the DefaultPipeWriter (dotnet/corefx#35484)
- Today we're using an extension method on IBufferWrite<T> to implement
copying the input buffer to the underlying PipeWriter. Luckily this
method is virtual so we can optimize using the Pipe's internal structures
directly rather than going through GetMemory and Advance
Commit migrated from https://github.com/dotnet/corefx/commit/
a0bbeb7f2143a063eb5e944026787974362c8b3d
Tomas Weinfurt [Thu, 21 Feb 2019 23:01:02 +0000 (15:01 -0800)]
fix ping TTL option for OSX (dotnet/corefx#35506)
Commit migrated from https://github.com/dotnet/corefx/commit/
ecad65740b41b1502188ac6b412ade53fb54ba3e
Geoff Kizer [Thu, 21 Feb 2019 21:52:02 +0000 (13:52 -0800)]
address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
333fabaffeabf3b4de5d6ba45e54b2078f57adcf
ericstj [Thu, 21 Feb 2019 00:54:05 +0000 (16:54 -0800)]
Make restore of external 2-pass
Commit migrated from https://github.com/dotnet/corefx/commit/
c8e44c3d027d0539e7f9091336cc48e59e7d03e8
Eric St. John [Wed, 20 Feb 2019 00:35:49 +0000 (16:35 -0800)]
Restore IBC data and embed during Windows release builds
See the following docs.
https://github.com/dotnet/arcade/blob/dotnet/corefx@
bac85242024ba867b6204b90c1522793093f5e31/Documentation/ArcadeSdk.md#ibc-optimization-data-embedding
We are using IBC data produced by our perf team and embedding into all builds of a DLL;
currently we don't distinguish cross-compiles of the same DLL, nor does arcade define any
conventions to do so. I've disabled it for references and not-supported assemblies.
Commit migrated from https://github.com/dotnet/corefx/commit/
96661fad0e63a7869539fa0981c8b8be2f3824d3
Stephen Toub [Thu, 21 Feb 2019 17:16:35 +0000 (12:16 -0500)]
Disable two Socket.Begin/EndSendFile tests (dotnet/corefx#35494)
Commit migrated from https://github.com/dotnet/corefx/commit/
1c802d6d8c06b727c102c00e5eb4224de9608a16
Jan Kotas [Thu, 21 Feb 2019 17:15:56 +0000 (09:15 -0800)]
Omit Environment.Version from CodeDom generated files (dotnet/corefx#35458)
* Omit Environment.Version from CodeDom generated files
Contributes to https://github.com/dotnet/coreclr/pull/22664
* Disable tests on .NET Framework
Commit migrated from https://github.com/dotnet/corefx/commit/
89f72f6edb0d4ec18afa8e8138d1f12fdde09e5d
Stephen Toub [Thu, 21 Feb 2019 16:46:00 +0000 (11:46 -0500)]
Merge pull request dotnet/corefx#35489 from dotnet/darc-master-
f2564df9-8df7-4569-8e31-
4500b86d8bfa
[master] Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
3ec07dba620c98da2a53856ab756d9322972d953
Viktor Hofer [Thu, 21 Feb 2019 14:42:16 +0000 (15:42 +0100)]
Update publish.yml
Commit migrated from https://github.com/dotnet/corefx/commit/
4762671d7034adced7320f8e8f9b4f1d53c88450
Stephen Toub [Thu, 21 Feb 2019 14:30:40 +0000 (09:30 -0500)]
Fix ArgumentOutOfRangeException validation in GregorianCalendarTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
07116a67cacaa2965479429a1bfd19fb60fcd53f
Stephen Toub [Thu, 21 Feb 2019 14:27:43 +0000 (09:27 -0500)]
Merge branch 'master' into darc-master-
f2564df9-8df7-4569-8e31-
4500b86d8bfa
Commit migrated from https://github.com/dotnet/corefx/commit/
fb4bcafc113a208da4ba60b8f56bc58689d624b3
Viktor Hofer [Thu, 21 Feb 2019 14:18:47 +0000 (15:18 +0100)]
Add test targets to build script (dotnet/corefx#34385)
* Add test targets to build script
* Remove few manual copy targets in projects
* Remove PlatformAbstractions dependency
* Update ArchiveTests type to enum
* Set warnaserror false on arm/arm64
* Update docs
* Darc update from build '
20190221.4'
Commit migrated from https://github.com/dotnet/corefx/commit/
a619534cac9b7d000f0899248656d232cb44f61f
dotnet-maestro-bot [Thu, 21 Feb 2019 12:22:00 +0000 (04:22 -0800)]
Update CoreFxOptimizationData to master-
20190221.1 (dotnet/corefx#35482)
Commit migrated from https://github.com/dotnet/corefx/commit/
d86f48243bdd9ec9b187d6e142e209a0adccc761
Geoff Kizer [Wed, 20 Feb 2019 20:54:39 +0000 (12:54 -0800)]
add StreamState and rework HTTP2 stream state handling
cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
1eba83637d47fde09c8e1748b0ebb4ca42da5ca4
Santiago Fernandez Madero [Thu, 21 Feb 2019 02:41:48 +0000 (18:41 -0800)]
Remove unused upload-tests.proj (dotnet/corefx#35475)
Commit migrated from https://github.com/dotnet/corefx/commit/
8a9dd52ae5bab85ec3bd1d3cf73ba165668332f0
OmariO [Thu, 21 Feb 2019 02:25:20 +0000 (02:25 +0000)]
Improve BitArray's Get, Set, SetAll and Not methods performance (dotnet/corefx#35364)
* Improve BitArray's Get, Set, Set All and Not methods performance. The generated code is smaller and allows to use AggressiveInlining for Get and Set.
* Update BitArray.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
2b8e77e0b1e8699db7e3656a6ad86d181317a155
Filip Navara [Thu, 21 Feb 2019 02:23:41 +0000 (03:23 +0100)]
Move Thread to shared CoreLib (dotnet/corefx#35462)
Commit migrated from https://github.com/dotnet/corefx/commit/
694eeba312046e2097c731d40f32c1cac675aa03
Geoff Kizer [Thu, 21 Feb 2019 02:23:19 +0000 (18:23 -0800)]
don't dispose the HTTP2 connection writer lock, to avoid race (dotnet/corefx#35468)
* don't dispose the writer lock, to avoid race
* Update Http2Connection.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
c4c8f72cd8d18d6ec00afea6644ae2077d442869